KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 174 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/174/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 08 Nov 2019 04:32:42 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 189 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/189/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 08 Nov 2019 04:32:42 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/404)67%
(271/404)56%
(34800/61641)40%
(17597/43546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9645/10118)47%
(4487/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)61%
(8805/14546)52%
(4566/8831)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4670/8288)43%
(2023/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(385/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1799/4291)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)26%
(68/265)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 305 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/305/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Nov 2019 04:32:42 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/404)67%
(271/404)56%
(34812/61642)40%
(17603/43550)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9656/10118)47%
(4492/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)60%
(8799/14545)52%
(4569/8831)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8288)43%
(2023/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1799/4291)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D21004: [UserMetaData] Shortcut attribute queries for the common case

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:4fdb2048f25d: [UserMetaData] Shortcut attribute queries 
for the common case (authored by bruns).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21004?vs=69416=69417

REVISION DETAIL
  https://phabricator.kde.org/D21004

AFFECTED FILES
  CMakeLists.txt
  src/filemetadatautil.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame
Cc: hurikhan77, lots0logs, fbampaloukas, domson, ashaposhnikov, astippich, 
spoorun, ngraham, abrahams

D21004: [UserMetaData] Shortcut attribute queries for the common case

[Stefan Brüns]

bruns updated this revision to Diff 69416.
bruns edited the summary of this revision.
bruns added a comment.


  KF5_MIN_VERSION bump to 5.60

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21004?vs=57507=69416

BRANCH
  arcpatch-D21004

REVISION DETAIL
  https://phabricator.kde.org/D21004

AFFECTED FILES
  CMakeLists.txt
  src/filemetadatautil.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame
Cc: hurikhan77, lots0logs, fbampaloukas, domson, ashaposhnikov, astippich, 
spoorun, ngraham, abrahams

D25194: Use modern for

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25194

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 173 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/173/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 07 Nov 2019 21:47:48 +
 Build duration:
9 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25195: use modern for syntax

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D25195

To: aacid, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis added a comment.


  I see the difference now as well. @niccolove BTW, the top right corner is a 
bit messed up. It's rising above the rest of the shadow on the top edge.
  
  Rather than painstakingly making shadows by hand in Inkscape, perhaps we 
should be using KWin for the shadows?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/24/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 07 Nov 2019 18:22:36 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/23/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 07 Nov 2019 14:51:32 +
 Build duration:
3 hr 30 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

D25195: use modern for syntax

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25195

To: aacid, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25115: Add guard for missing kirigami

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:6f8610a1431a: Add guard for missing kirigami (authored by 
davidedmundson).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25115?vs=69183=69404

REVISION DETAIL
  https://phabricator.kde.org/D25115

AFFECTED FILES
  src/kcmoduleqml.cpp

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25194: Use modern for

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25194

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

[Volker Krause]

vkrause added a comment.


  anyone?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24980

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

[Arjen Hiemstra]

On 07-11-2019 15:34, Friedrich W. H. Kossebau wrote:

Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra:

Hi,

Quick Charts has been moved to KDE review. The intent is to make it a
Tier 1 framework.


Any chance the official name can be "KQuickCharts"? "Quick Charts" is a
generic name which only asks for being misunderstood, is hard to google 
etc..


Fair point. Since the repo is already kquickcharts, I will update the 
documentation

to match.



Quick Charts is a QML module that implements a set of 
high-performance,

GPU accelerated
charts. Currently the main user of it is a new KSysGuard UI I have 
been

working on, but
once it is part of Frameworks I also hope to convert several bits of
Plasma to using it.


If there is only one user currently, might it perhaps be a better idea 
to do
some independent releases for a while to get more feedback on the API, 
before
settling to the API freeze by being part of KDE Frameworks? It will be 
at

least a year until KF6 is there to properly fix up any potential API
inconveniences which users might find.
I would at least recommend to first get some API shaping by real-world
exposure.


So there is one known user currently, KSysGuard. Additionally, there are
several places in Plasma that I want to look at to use them. There is 
also
the KInfoCenter energy information page where we want to look at using 
this.
Additionally, there has been some interest from others. I do not know 
what

Plasma's policy is regarding dependencies, but having it in Frameworks
would make things quite a bit simpler to port existing things.

The module has been in development for about 5 months at this point. We 
have
been using it for the mentioned new KSysGuard UI as well as some other 
bits

we want to upstream. At this point, I am fairly sure that any major API
changes would amount to a "KF6" version anyway. I would rather commit to 
the

stable API so that people will know there is no large chance of things
suddenly changing from underneath them.

 - Arjen



Sorry otherwise for not reviewing myself, not into QML the recent 
months.


Cheers
Friedrich

D25015: Update breeze theme shadows

[Nathaniel Graham]

ngraham added a comment.


  Ah, pixel-perfect before-and-after images make it much easier to see. I will 
reiterate my belief that the shadows now need to be bigger if we're going to 
make them lighter and weaker.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Nathaniel Graham]

ngraham added a comment.


  Cool, I'm okay with that.
  
  The "Loading more" indicator is aligned to the top, not centered like the 
other loading indicator is.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25197

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

[Nathaniel Graham]

ngraham retitled this revision from "Add a new Template for KCM's." to "Add a 
new template for KCMs".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava
Cc: yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25149: Add a new Template for KCM's.

[Tomaz Canabrava]

tcanabrava added a comment.


  In D25149#559075 , @davidedmundson 
wrote:
  
  > A very sensible idea. ++
  >
  > > templates/kcm-qml/qml-plasmoid.png
  >
  > What's this about?
  
  
  We need a better icon. it's the icon for the `Plasmoid` template.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava
Cc: yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25149: Add a new Template for KCM's.

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 69400.
tcanabrava added a comment.


  - Add KConfigXT

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25149?vs=69296=69400

BRANCH
  arcpatch-D25149

REVISION DETAIL
  https://phabricator.kde.org/D25149

AFFECTED FILES
  templates/CMakeLists.txt
  templates/kcm-qml/%{APPNAMELC}settings.kcfg
  templates/kcm-qml/%{APPNAMELC}settings.kcfgc
  templates/kcm-qml/CMakeLists.txt
  templates/kcm-qml/Messages.sh
  templates/kcm-qml/README
  templates/kcm-qml/kcm-qml.kdevtemplate
  templates/kcm-qml/kcm.cpp
  templates/kcm-qml/kcm.h
  templates/kcm-qml/kcm_%{APPNAMELC}.desktop
  templates/kcm-qml/package/contents/ui/main.qml
  templates/kcm-qml/package/metadata.desktop
  templates/kcm-qml/qml-plasmoid.png

To: tcanabrava
Cc: yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25170: make the libssh finder ensure the new ssh target is set

[Andreas Schneider]

asn added a comment.


  Thanks Harald, this is an awesome idea!
  
  https://www.libssh.org/2019/11/07/libssh-0-9-2/

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25170

To: sitter
Cc: asn, heikobecker, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 69399.
leinir added a comment.


  - Merge branch 'master' into be-more-friendly-during-initial-load
  - Add a bit of @since

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25173?vs=69383=69399

BRANCH
  be-more-friendly-during-initial-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25173

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 69398.
leinir added a comment.


  - Add some @since

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25197?vs=69397=69398

BRANCH
  reduce-some-noise (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25197

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.
leinir added reviewers: KNewStuff, Frameworks, Plasma, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25197

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Dan Leinir Turthra Jensen]

leinir added a dependency: D25173: Give some more pretty feedback in 
NewStuff::Page while the Engine is loading.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25197

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir added a dependent revision: D25197: Show a "Loading more..." busy 
indicator when loading view data.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Add an isFetching property to the QML ItemsModel, and use that
  to show a busy indicator with a label at the end of the view
  of entries when scrolling through it. This ensures the user is
  informed when fetching is happening, without being too in-your-
  face about it all.
  
  Also remove the passive notifications for busy messages:
  Since all the busy messages are for the model, and we now have a
  different way to show this to the user, get rid of that one.
  We still have a number of idle messages and other such informational
  bits, but this gets rid of a great many of the more obnoxious
  messages that keep popping up.

REPOSITORY
  R304 KNewStuff

BRANCH
  reduce-some-noise (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25197

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25193: use more modern for construct

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D25193

To: aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25192: Replace for with maths with range for

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D25192

To: aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25195: use modern for syntax

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25195

AFFECTED FILES
  src/platforms/xcb/kkeyserver.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

[Arjen Hiemstra]

On 07-11-2019 15:24, Alexander Potashev wrote:

чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra :


On 21-10-2019 15:22, Arjen Hiemstra wrote:
> Hi,
>
> Quick Charts has been moved to KDE review. The intent is to make it a
> Tier 1 framework.
>
> Quick Charts is a QML module that implements a set of
> high-performance, GPU accelerated
> charts. Currently the main user of it is a new KSysGuard UI I have
> been working on, but
> once it is part of Frameworks I also hope to convert several bits of
> Plasma to using it.

It has now been a little over two weeks. If there are no objections, I
will move this to frameworks later today.


Hi Arjen,

Did anyone from the Plasma team approve the new KSysGuard UI?


It is being developed together with several people from the Plasma team
actually. :)

It will also go through a separate review, but it needs Quick Charts
to be ready before that can happen.

 - Arjen

Re: Quick Charts in KDE Review

[Friedrich W. H. Kossebau]

Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra:
> Hi,
> 
> Quick Charts has been moved to KDE review. The intent is to make it a
> Tier 1 framework.

Any chance the official name can be "KQuickCharts"? "Quick Charts" is a 
generic name which only asks for being misunderstood, is hard to google etc..
 
> Quick Charts is a QML module that implements a set of high-performance,
> GPU accelerated
> charts. Currently the main user of it is a new KSysGuard UI I have been
> working on, but
> once it is part of Frameworks I also hope to convert several bits of
> Plasma to using it.

If there is only one user currently, might it perhaps be a better idea to do 
some independent releases for a while to get more feedback on the API, before 
settling to the API freeze by being part of KDE Frameworks? It will be at 
least a year until KF6 is there to properly fix up any potential API 
inconveniences which users might find.
I would at least recommend to first get some API shaping by real-world 
exposure.

Sorry otherwise for not reviewing myself, not into QML the recent months.

Cheers
Friedrich

Re: Quick Charts in KDE Review

[David Edmundson]

Approved in general, but we will cover that and any ported applets
effectively ported from KDeclarative::Plotter in relevant separate
review processes.

David

Re: Quick Charts in KDE Review

[Alexander Potashev]

чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra :
>
> On 21-10-2019 15:22, Arjen Hiemstra wrote:
> > Hi,
> >
> > Quick Charts has been moved to KDE review. The intent is to make it a
> > Tier 1 framework.
> >
> > Quick Charts is a QML module that implements a set of
> > high-performance, GPU accelerated
> > charts. Currently the main user of it is a new KSysGuard UI I have
> > been working on, but
> > once it is part of Frameworks I also hope to convert several bits of
> > Plasma to using it.
>
> It has now been a little over two weeks. If there are no objections, I
> will move this to frameworks later today.

Hi Arjen,

Did anyone from the Plasma team approve the new KSysGuard UI?

-- 
Alexander Potashev

D25193: use more modern for construct

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25193

To: aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D25173#559588 , @ngraham wrote:
  
  > I still see "Loading Data" in a passiveNotification as well as in text 
under the loading indicator.
  
  
  i'm seeing a couple of bits which really probably want to be turned into 
something else (but as separate diffs, as i'm not really keen on this ending up 
yet another several-months-long saga):
  
  - Loading data (which should really just be an inline item (probably the 
footer) with a spinner to indicate when the model is fetching more items)
  - Loading one preview (which is basically just debug information and should 
be turned into that)
  
  > Do we really need the passiveNotifications at all? I think we can probably 
improve the user experience vy removing them entirely. For example instead of 
"Loading one preview" we can just show individual loading indicators on the 
previews themselves
  
  i'm afraid we do - as you might gather from that short list above, there's an 
enormous amount of of these bits of information being thrown back from the 
engine, and until we're certain we have captured all of them by some other 
method (and removed the noise), we really can't just get rid of it. (yes, i 
realise how much you dislike[1] them, and i'm quite happy to move towards 
removing them, we just can't do it by just straight up removing them entirely. 
We also can't simply replace it with a dialog box either, because /some/ are 
informational and can be safely ignored, while some are important, and there's 
no straightforward way to tell which is which)
  
  [1] was going to say hate, but it's a terribly strong term, and i feel like 
we probably need to reserve it for things which actually deserve that strength 
;)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25194: Use modern for

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25194

AFFECTED FILES
  src/ioslaves/http/parsinghelpers.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25192: Replace for with maths with range for

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25192

To: aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25193: use more modern for construct

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25193

AFFECTED FILES
  src/kdeinit/kinit.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25192: Replace for with maths with range for

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25192

AFFECTED FILES
  src/tools/ksvg2icns/ksvg2icns.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25189: Add an overlay component for item activity feedback

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> ngraham wrote in FeedbackOverlay.qml:63
> Bonus points for showing a link that actually takes you to 
> https://bugs.kde.org/enter_bug.cgi?product=frameworks-knewstuff when this 
> error condition is present

Couple of places where that wants to happen, yup :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25189

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25189: Add an overlay component for item activity feedback

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:24ffb9cb9c11: Add an overlay component for item activity 
feedback (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25189?vs=69384=69391

REVISION DETAIL
  https://phabricator.kde.org/D25189

AFFECTED FILES
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25189: Add an overlay component for item activity feedback

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Good stuff.

INLINE COMMENTS

> FeedbackOverlay.qml:63
> +} else {
> +statusLabel.text = i18nc("Label for the busy indicator 
> which should only be shown when the entry has been given some unknown or 
> invalid status.", "Invalid or unknown state. Please report this to the KDE 
> Community in a bug report.");
> +}

Bonus points for showing a link that actually takes you to 
https://bugs.kde.org/enter_bug.cgi?product=frameworks-knewstuff when this error 
condition is present

REPOSITORY
  R304 KNewStuff

BRANCH
  better-inline-feedback-for-item-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25189

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Nathaniel Graham]

ngraham added a comment.


  I still see "Loading Data" in a passiveNotification as well as in text under 
the loading indicator. Do we really need the passiveNotifications at all? I 
think we can probably improve the user experience vy removing them entirely. 
For example instead of "Loading one preview" we can just show individual 
loading indicators on the previews themselves

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven added a comment.


  I feel the code is ready for review toward merging.

INLINE COMMENTS

> global.h:321
> +/// Filename, access, type, size, linkdest
> +StatBasic = 0x1,
> +/// uid, gid

Naming should be explicit enough now.
I still wonder about granularity if I should expose some more.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven updated this revision to Diff 69385.
meven marked an inline comment as done.
meven added a comment.


  Add Stat prefix to enum values of KIO::StatDetail

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=69261=69385

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/CMakeLists.txt
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

[Vlad Zahorodnii]

zzag abandoned this revision.
zzag added a comment.


  Okay, I see.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25184

To: zzag, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25189: Add an overlay component for item activity feedback

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.
leinir added reviewers: KNewStuff, Frameworks, Plasma, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25189

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25189: Add an overlay component for item activity feedback

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This is the very first steps toward allowing for better, more involved
  feedback on what is happening with the items (such as download progress,
  the ability to abort installations, and such things).
  
  BUG:413441
  
  Also removes a now unneeded passive notification call

REPOSITORY
  R304 KNewStuff

BRANCH
  better-inline-feedback-for-item-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25189

AFFECTED FILES
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

[David Edmundson]

davidedmundson added a comment.


  From wallpaper interface:
  
m_qmlObject->setSource(m_pkg.fileUrl("mainscript"));
  
  packages.cpp
  void QmlWallpaperPackage::initPackage(Plasma::Package *package)
  {
  
package->addFileDefinition("mainscript", QStringLiteral("ui/main.qml"), 
i18n("Main Script File"));
package->setRequired("mainscript", true);
  
  it seems hardcoded in p-f, at which point the warning itself is correct and 
it's the wallpapers themselves that are wrong.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25184

To: zzag, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 69383.
leinir added a comment.


  - Merge branch 'master' into be-more-friendly-during-initial-load
  - Don't show the passive notification for already shown messages

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25173?vs=69348=69383

BRANCH
  be-more-friendly-during-initial-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25173

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

[Arjen Hiemstra]

On 21-10-2019 15:22, Arjen Hiemstra wrote:

Hi,

Quick Charts has been moved to KDE review. The intent is to make it a
Tier 1 framework.

Quick Charts is a QML module that implements a set of
high-performance, GPU accelerated
charts. Currently the main user of it is a new KSysGuard UI I have
been working on, but
once it is part of Frameworks I also hope to convert several bits of
Plasma to using it.


It has now been a little over two weeks. If there are no objections, I
will move this to frameworks later today.



- Arjen

D25165: Only show DownloadItemsSheet if there's more than one download item

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:7de5ad66fd89: Only show DownloadItemsSheet if 
theres more than one download item (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25165?vs=69336=69377

REVISION DETAIL
  https://phabricator.kde.org/D25165

AFFECTED FILES
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: leinir, #knewstuff, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25168: Use the pointing hand cursor for the single-clickable delegates

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:728f01f064ab: Use the pointing hand cursor for the 
single-clickable delegates (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25168?vs=69339=69376

REVISION DETAIL
  https://phabricator.kde.org/D25168

AFFECTED FILES
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: leinir, #knewstuff, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns