D27665: Support SAE in securityTypeFromConnectionSetting

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  securityTypeFromConnectionSetting-support-SAE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27665

To: hexchain, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27586: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R306:c10ca8623903: templates: Convert license statements to 
SPDX headers (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27586?vs=76236=76437#toc

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27586?vs=76236=76437

REVISION DETAIL
  https://phabricator.kde.org/D27586

AFFECTED FILES
  templates/kpartsapp/LICENSES/GPL-2.0-or-later.txt
  templates/kpartsapp/src/part/%{APPNAMELC}part.cpp
  templates/kpartsapp/src/part/%{APPNAMELC}part.h
  templates/kpartsapp/src/shell/%{APPNAMELC}shell.cpp
  templates/kpartsapp/src/shell/%{APPNAMELC}shell.h
  templates/kpartsapp/src/shell/main.cpp

To: kossebau, cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Ömer Fadıl Usta]

usta added a comment.


  Freebsd side broken again :
  00:31:45  
./build/icons-dark/generated/devices/24/network-wired-activated.svg:14: parser 
error : Opening and ending tag mismatch: g line 8 and svg
  00:31:45  
  00:31:45^
  00:31:45  
./build/icons-dark/generated/devices/24/network-wired-activated.svg:15: parser 
error : EndTag: 'https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: usta, davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D27662: Rewrite nextcloud plugin

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  nextcloud

REVISION DETAIL
  https://phabricator.kde.org/D27662

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Allen Winter]

winterz accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R175 KHolidays

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr, winterz
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27665: Support SAE in securityTypeFromConnectionSetting

[hexchain]

hexchain added a dependent revision: D27666: Support WPA3-SAE in the applet 
popup.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D27665

To: hexchain, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27665: Support SAE in securityTypeFromConnectionSetting

[hexchain]

hexchain created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added a reviewer: jgrulich.
hexchain requested review of this revision.

REVISION SUMMARY
  Allow SAE to be returned from securityTypeFromConnectionSetting.

TEST PLAN
  Not visible on its own. Intended to work with another plasma-nm change.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  securityTypeFromConnectionSetting-support-SAE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27665

AFFECTED FILES
  src/utils.cpp

To: hexchain, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27635: Restore kio-webdav plugin

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27635

To: nicolasfella, bshah, leinir, #frameworks

D23339: Fix memory leak in ConfigView and Dialog

[Nicolas Fella]

nicolasfella added a comment.


  This makes plasmashell crash for me as soon as a notification appears.
  
  https://invent.kde.org/snippets/730

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23339

To: dvratil, #plasma, #frameworks, apol, davidedmundson
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27662: Rewrite nextcloud plugin

[Nicolas Fella]

nicolasfella updated this revision to Diff 76421.
nicolasfella added a comment.


  - Remove debug

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27662?vs=76420=76421

BRANCH
  nextcloud

REVISION DETAIL
  https://phabricator.kde.org/D27662

AFFECTED FILES
  src/plugins/nextcloud/nextcloudjob.cpp
  src/plugins/nextcloud/nextcloudjob.h
  src/plugins/nextcloud/nextcloudplugin_config.qml

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27662: Rewrite nextcloud plugin

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, apol, bshah.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Let CopyJob and the webdav KIO slave do the hard work. Run the 
GetCredentialsJob async. Use generic dav-storage service type instead of 
nextcloud-upload (introduced in D21738 ).

TEST PLAN
  Shared one or multiple files to my nextcloud

REPOSITORY
  R495 Purpose Library

BRANCH
  nextcloud

REVISION DETAIL
  https://phabricator.kde.org/D27662

AFFECTED FILES
  src/plugins/nextcloud/nextcloudjob.cpp
  src/plugins/nextcloud/nextcloudjob.h
  src/plugins/nextcloud/nextcloudplugin_config.qml

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27654: [kio] Fix running konsole on Wayland

[David Faure]

dfaure added a comment.


  Since this is konsole specific, it's fine to use a Qt-specific argument.
  But IMHO you could also just remove the %i altogether.
  I never understood the idea of "take the icon from the desktop file, not the 
one the application would use by default".
  I mean, with some stretch of the imagination I can see N desktop files 
launching the same app with different options including the icon (why not...), 
but not like here where it will just look up the default konsole.desktop anyway.
  
  Wait, you're actually passing the icon of the command being executed now 
(while the old code would end up using the stuff from konsole.desktop I 
think)
  But it gets worse, konsole is a unique-application by default, isn't it? So 
this icon will never show, unless this is the first app that starts konsole -- 
and then all subsequent apps will end up with that icon of the first 
command This is all nonsense to me
  
  Option 1: remove %i
  Option 2: test all the scenarios above... (icon in app desktop file + konsole 
not already running, then launching konsole again ; icon in app desktop file + 
konsole already running with default parameters)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27654

To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27097: Port from QRegExp to QRegularExpression

[David Faure]

dfaure added a comment.


  Deprecate the attribute, keep the code. There is more KF5-based code out 
there than the one visible by lxr.kde.org. Some of it not even public. We make 
the same promise as Qt, preserving SC and BC in major versions.
  
  OK for "Invalid PCRE pattern syntax"

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27097

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Alexander Saoutkin]

feverfew updated this revision to Diff 76419.
feverfew added a comment.


  - Fix the diff

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21795?vs=76073=76419

BRANCH
  arcpatch-D21795_1

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.cpp
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/policykit/PolicyKitBackend.cpp
  src/backends/policykit/PolicyKitBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

D27635: Restore kio-webdav plugin

[Nicolas Fella]

nicolasfella updated this revision to Diff 76416.
nicolasfella added a comment.


  - Simplify

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27635?vs=76413=76416

BRANCH
  restore

REVISION DETAIL
  https://phabricator.kde.org/D27635

AFFECTED FILES
  CMakeLists.txt
  src/daemon/CMakeLists.txt
  src/daemon/daemon.cpp
  src/daemon/kio-webdav/CMakeLists.txt
  src/daemon/kio-webdav/createkioservice.cpp
  src/daemon/kio-webdav/createnetattachjob.cpp
  src/daemon/kio-webdav/kio-webdav.json
  src/daemon/kio-webdav/kioservices.cpp
  src/daemon/kio-webdav/kioservices.h
  src/daemon/kio-webdav/removekioservice.cpp
  src/lib/kaccountsdplugin.cpp
  src/lib/kaccountsdplugin.h

To: nicolasfella, bshah, leinir, #frameworks

D27635: Restore kio-webdav plugin

[Nicolas Fella]

nicolasfella updated this revision to Diff 76413.
nicolasfella added a comment.


  - Adapt path

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27635?vs=76328=76413

BRANCH
  restore

REVISION DETAIL
  https://phabricator.kde.org/D27635

AFFECTED FILES
  CMakeLists.txt
  src/daemon/CMakeLists.txt
  src/daemon/daemon.cpp
  src/daemon/kio-webdav/CMakeLists.txt
  src/daemon/kio-webdav/createkioservice.cpp
  src/daemon/kio-webdav/createnetattachjob.cpp
  src/daemon/kio-webdav/kio-webdav.json
  src/daemon/kio-webdav/kioservices.cpp
  src/daemon/kio-webdav/kioservices.h
  src/daemon/kio-webdav/removekioservice.cpp
  src/lib/kaccountsdplugin.cpp
  src/lib/kaccountsdplugin.h

To: nicolasfella, bshah, leinir, #frameworks

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/72/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 25 Feb 2020 18:59:03 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.ktooltipwidgettest

D27296: [PlasmaComponents]Clean up ListItem code

[George Vogiatzis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:10c112fccda8: [PlasmaComponents]Clean up ListItem code 
(authored by gvgeo).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27296?vs=75391=76411

REVISION DETAIL
  https://phabricator.kde.org/D27296

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ListItem.qml

To: gvgeo, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:d3a1b5148008: [KStyle] Set the color of KMessageWidgets 
to the correct one from the current… (authored by davidre).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27039?vs=74713=76410

REVISION DETAIL
  https://phabricator.kde.org/D27039

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: davidre, #frameworks, aacid, anthonyfieroni, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d946fb71ea22: [KMessageWidget] Allow the style to change 
our palette (authored by davidre).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27038?vs=76408=76409

REVISION DETAIL
  https://phabricator.kde.org/D27038

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

[David Redondo]

davidre updated this revision to Diff 76408.
davidre added a comment.


  Rebase

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27038?vs=74701=76408

BRANCH
  polish

REVISION DETAIL
  https://phabricator.kde.org/D27038

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kcoreconfigskeleton.h:764
>  QString whatsThis;
> +QString val;
> +

Something I have noticed while testing this.
Since it changes the memory of a very common data struct in a very common lib, 
it creates a lot of crashes if apps are not compiled with the installed version.
So all local builds should be rebuild or reinstalled, once this has landed, or 
you end up with a lot of crashes.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 76405.
meven marked 6 inline comments as done.
meven added a comment.


  Move KCoreConfigSkeleton::ItemEnum::Choice::value to cpp file, use a regex to 
filter valid choice name

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=76040=76405

BRANCH
  arcpatch-D27463_1

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27601: KConfig: Convert to SPDX license statements

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> cordlandwehr wrote in kcfg.xsd:20
> Actually, I though quite a time about this and at the end did a comparison of 
> the permissions specifically provided by this statement: use, copy and modify 
> (yet there is no explicit statement of sublicensing and combining with other 
> works). That -- in my understanding -- is the legal equivalent to the BSD-2 
> clause. However, the statement is quite different than the usual BSD 2 
> Clauses. but I am not aware of any license that is phrased in exactly this 
> statement.
> 
> What is your opinion? Otherwise, I would also be fine with omitting it from 
> the change for now and I could contact the authors if they agree and then do 
> this change atomically later.

Searching in google, this looks like a standard license text for dtd files.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27601

To: cordlandwehr
Cc: ognarb, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 76403.
cordlandwehr added a comment.


  Better handling of explenatory texts

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27601?vs=76224=76403

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27601

AFFECTED FILES
  KF5ConfigMacros.cmake
  LICENSES/BSD-2-Clause.txt
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT.txt
  autotests/fallbackconfigresourcestest.cpp
  autotests/helper.h
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/kconfigcompiler_test.h
  autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp
  autotests/kconfig_compiler/klocalizedstring.h
  autotests/kconfig_compiler/test10main.cpp
  autotests/kconfig_compiler/test11_types.h
  autotests/kconfig_compiler/test11main.cpp
  autotests/kconfig_compiler/test12main.cpp
  autotests/kconfig_compiler/test13main.cpp
  autotests/kconfig_compiler/test1main.cpp
  autotests/kconfig_compiler/test2main.cpp
  autotests/kconfig_compiler/test3amain.cpp
  autotests/kconfig_compiler/test3main.cpp
  autotests/kconfig_compiler/test4main.cpp
  autotests/kconfig_compiler/test5main.cpp
  autotests/kconfig_compiler/test6main.cpp
  autotests/kconfig_compiler/test7main.cpp
  autotests/kconfig_compiler/test8main.cpp
  autotests/kconfig_compiler/test9main.cpp
  autotests/kconfig_compiler/test_dpointer_main.cpp
  autotests/kconfig_compiler/test_emptyentries_main.cpp
  autotests/kconfig_compiler/test_fileextensions_main.cxx
  autotests/kconfig_compiler/test_notifiers_main.cpp
  autotests/kconfig_compiler/test_qdebugcategorymain.cpp
  autotests/kconfig_compiler/test_signal_main.cpp
  autotests/kconfig_compiler/test_translation_kde_domain_main.cpp
  autotests/kconfig_compiler/test_translation_kde_main.cpp
  autotests/kconfig_compiler/test_translation_qt_main.cpp
  autotests/kconfigguitest.cpp
  autotests/kconfigguitest.h
  autotests/kconfigloadertest.cpp
  autotests/kconfigloadertest.h
  autotests/kconfignokdehometest.cpp
  autotests/kconfigskeletontest.cpp
  autotests/kconfigskeletontest.h
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  autotests/kentrymaptest.cpp
  autotests/kentrymaptest.h
  autotests/ksharedconfig_in_global_object.cpp
  autotests/ksharedconfigtest.cpp
  autotests/kstandardshortcuttest.cpp
  autotests/kstandardshortcuttest.h
  autotests/test_kconf_update.cpp
  autotests/test_kconf_update.h
  autotests/test_kconfigutils.cpp
  autotests/test_kconfigutils.h
  cmake/rules_PyKF5.py
  src/core/bufferfragment_p.h
  src/core/conversioncheck.h
  src/core/kauthorized.cpp
  src/core/kauthorized.h
  src/core/kconfig.cpp
  src/core/kconfig.h
  src/core/kconfig_p.h
  src/core/kconfigbackend.cpp
  src/core/kconfigbackend_p.h
  src/core/kconfigbase.cpp
  src/core/kconfigbase.h
  src/core/kconfigbase_p.h
  src/core/kconfigdata.cpp
  src/core/kconfigdata.h
  src/core/kconfiggroup.cpp
  src/core/kconfiggroup.h
  src/core/kconfiggroup_p.h
  src/core/kconfigini.cpp
  src/core/kconfigini_p.h
  src/core/kconfigwatcher.cpp
  src/core/kconfigwatcher.h
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h
  src/core/kemailsettings.cpp
  src/core/kemailsettings.h
  src/core/ksharedconfig.cpp
  src/core/ksharedconfig.h
  src/gui/kconfiggroupgui.cpp
  src/gui/kconfiggui.cpp
  src/gui/kconfiggui.h
  src/gui/kconfigloader.cpp
  src/gui/kconfigloader.h
  src/gui/kconfigloader_p.h
  src/gui/kconfigloaderhandler_p.h
  src/gui/kconfigskeleton.cpp
  src/gui/kconfigskeleton.h
  src/gui/kstandardshortcut.cpp
  src/gui/kstandardshortcut.h
  src/gui/kwindowconfig.cpp
  src/gui/kwindowconfig.h
  src/kconf_update/kconf_update.cpp
  src/kconf_update/kconfigutils.cpp
  src/kconf_update/kconfigutils.h
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigParameters.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd
  src/kconfig_compiler/kconfig_compiler.cpp
  src/kreadconfig/kreadconfig.cpp
  src/kreadconfig/kwriteconfig.cpp

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Andreas Cord-Landwehr]

cordlandwehr marked 3 inline comments as done.
cordlandwehr added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in kcfg.xsd:20
> What makes you think it's BSD?

Actually, I though quite a time about this and at the end did a comparison of 
the permissions specifically provided by this statement: use, copy and modify 
(yet there is no explicit statement of sublicensing and combining with other 
works). That -- in my understanding -- is the legal equivalent to the BSD-2 
clause. However, the statement is quite different than the usual BSD 2 Clauses. 
but I am not aware of any license that is phrased in exactly this statement.

What is your opinion? Otherwise, I would also be fine with omitting it from the 
change for now and I could contact the authors if they agree and then do this 
change atomically later.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27601

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27616: [UrlHandler] optimise the code and less if nesting

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in urlhandler.cpp:55
> I could be wrong, but this is exactly equivalent to the original code, i.e. 
> it won't reach this unless helpcenter is empty and it's not a kde app... and 
> I actually wanted to ask about this bit from the original code, what is it 
> supposed to do?

I guess it was in case it wasn't found. Maybe just change into an error saying 
"can't open the following help url %1"  where %1 is the url

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27616

To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27602: KDbusAddons: Convert license statement to SPDX

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R271:a222808f86cd: KDbusAddons: Convert license statement to 
SPDX (authored by cordlandwehr).

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27602?vs=76225=76401

REVISION DETAIL
  https://phabricator.kde.org/D27602

AFFECTED FILES
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/deadservicetest.cpp
  autotests/kdbusinterprocesslocktest.cpp
  autotests/kdbusservicetest.cpp
  autotests/kdbussimpleservice.cpp
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdbusinterprocesslock.cpp
  src/kdbusinterprocesslock.h
  src/kdbusservice.cpp
  src/kdbusservice.h
  src/kdedmodule.cpp
  src/kdedmodule.h
  src/kdeinitinterface.cpp
  src/kdeinitinterface.h
  src/tools/kquitapp/kquitapp.cpp

To: cordlandwehr, cgiboudeaux
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27603: KDNSSD: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R272:563fc1416d90: KDNSSD: Convert license headers to SPDX 
statements (authored by cordlandwehr).

REPOSITORY
  R272 KDNSSD

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27603?vs=76226=76400

REVISION DETAIL
  https://phabricator.kde.org/D27603

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-or-later.txt
  cmake/FindAvahi.cmake
  cmake/FindDNSSD.cmake
  src/avahi-domainbrowser.cpp
  src/avahi-domainbrowser_p.h
  src/avahi-publicservice.cpp
  src/avahi-publicservice_p.h
  src/avahi-remoteservice.cpp
  src/avahi-remoteservice_p.h
  src/avahi-servicebrowser.cpp
  src/avahi-servicebrowser_p.h
  src/avahi-servicetypebrowser.cpp
  src/avahi-servicetypebrowser_p.h
  src/avahi_listener.cpp
  src/avahi_listener_p.h
  src/domainbrowser.h
  src/domainmodel.cpp
  src/domainmodel.h
  src/dummy-domainbrowser.cpp
  src/dummy-publicservice.cpp
  src/dummy-remoteservice.cpp
  src/dummy-servicebrowser.cpp
  src/dummy-servicetypebrowser.cpp
  src/mdnsd-domainbrowser.cpp
  src/mdnsd-domainbrowser_p.h
  src/mdnsd-publicservice.cpp
  src/mdnsd-remoteservice.cpp
  src/mdnsd-responder.cpp
  src/mdnsd-responder.h
  src/mdnsd-sdevent.h
  src/mdnsd-servicebrowser.cpp
  src/mdnsd-servicebrowser_p.h
  src/mdnsd-servicetypebrowser.cpp
  src/mdnsd-servicetypebrowser_p.h
  src/org.freedesktop.Avahi.DomainBrowser.xml
  src/org.freedesktop.Avahi.ServiceBrowser.xml
  src/org.freedesktop.Avahi.ServiceTypeBrowser.xml
  src/publicservice.h
  src/remoteservice.h
  src/servicebase.cpp
  src/servicebase.h
  src/servicebase_p.h
  src/servicebrowser.h
  src/servicemodel.cpp
  src/servicemodel.h
  src/servicetypebrowser.h

To: cordlandwehr, cgiboudeaux
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27586: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr accepted this revision.
cordlandwehr added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kossebau wrote in main.cpp:31
> Hmpf, that slipped me. The regular expression overdoing its job :)
> I guess that will be hit in more KAboutData instances. Perhaps ignoring hits 
> which are enclosed by " might filter this properly?
> Also should no space be added possibly if  is missing?

using the `"` as enclosed flags sounds to be a nice pragmatic approach

REPOSITORY
  R306 KParts

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27586

To: kossebau, cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27637: kill twitter support

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:13f9f45f2cce: kill twitter support (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27637?vs=76334=76399

REVISION DETAIL
  https://phabricator.kde.org/D27637

AFFECTED FILES
  CMakeLists.txt
  src/plugins/CMakeLists.txt
  src/plugins/twitter-microblog.service.in
  src/plugins/twitter/Messages.sh
  src/plugins/twitter/contents/code/main.js.in
  src/plugins/twitter/contents/code/package.json
  src/plugins/twitter/contents/config/config.qml
  src/plugins/twitter/metadata.json

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27637: kill twitter support

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  killtwitter

REVISION DETAIL
  https://phabricator.kde.org/D27637

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27660: Add Inno Setup syntax, including embedded Pascal scripting

[Michael Hansen]

zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  innosetup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27660

AFFECTED FILES
  autotests/folding/setup.iss.fold
  autotests/html/setup.iss.html
  autotests/input/setup.iss
  autotests/reference/setup.iss.ref
  data/syntax/innosetup.xml

To: zrax
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27097: Port from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  Looking at the incremental stuff some more, there are no public methods that 
mention incremental; the only way is to set the KFind::FindIncremental flag; 
the only method I could find is in the private API (find_p.h) 
startNewIncrementalSearch(). So technically it's all hidden behind the 
d-pointer, there's nothing to deprecate about incremental search, except remove 
the flag/enum FindIncremental... (does that mean we can remove the incremental 
code now, or wait till the KF6 branching?).
  
  FWIW, I checked lxr again and KFind::FindIncremental exists only in kmplayer 
and khtml, and in both cases it's in commented out code.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27097

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Nathaniel Graham]

ngraham added a comment.


  In D27122#617594 , @niccolove 
wrote:
  
  > F8131397: image.png 
  
  
  Now that //is// relaxing :) I like it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27502: Create ConfigView an unmanaged ConfigWidget

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> settings.cpp:62
>  
> -bool Settings::setCheckUppercase(bool check)
> +void Settings::setCheckUppercase(bool check)
>  {

Please rename it to "skip uppercase"...

Otherwise it does the opposite of its name, it's just confusing

> settings.cpp:67
>  
>  bool Settings::checkUppercase() const
>  {

Likewise should be renamed to "skip"

> configview.cpp:43
> +
> +void ConfigViewPrivate::slotSelectionChanged() {
> +
> ui.removeButton->setEnabled(!ui.ignoreListWidget->selectedItems().isEmpty());

Break the line before { please

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27502

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27654: [kio] Fix running konsole on Wayland

[Wolfgang Bauer]

wbauer updated this revision to Diff 76387.
wbauer added a comment.


  Use `KShell::quoteArg()` in case the icon name contains spaces or other 
special chars.
  No idea if that's possible/allowed, but better be safe than sorry I suppose.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27654?vs=76375=76387

REVISION DETAIL
  https://phabricator.kde.org/D27654

AFFECTED FILES
  src/core/desktopexecparser.cpp

To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[David Faure]

dfaure added a comment.


  OK. `man ascii` says 0x1d is "GS (group separator)", not completely bogus :)
  
  I wonder how/why it becomes  in XML, but quick googling says that 
entity seems to be '␝' which indeed reads GS :)
  
  At the KConfig level, this is good for catching people who don't use the 
proper APIs that encapsulate that stuff :-)
  But at the kconfig_compiler level, people want to be able to write XML files 
by hand.
  So "modifying the schema to be able to specify subgroups in the XML" sounds 
like the way to go, not coming up with yet another weird character (it might as 
well be this one then, for consistency).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27647: throw out the windows variant of the smb slave

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-no-win

REVISION DETAIL
  https://phabricator.kde.org/D27647

To: sitter, ngraham, #windows, vonreth
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27646: smb: apply a whole bunch of static analyzer improvements

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  tidy

REVISION DETAIL
  https://phabricator.kde.org/D27646

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27644: do not hide enum warnings via switch default label

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  nodefault

REVISION DETAIL
  https://phabricator.kde.org/D27644

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27502: Create ConfigView an unmanaged ConfigWidget

[Benjamin Port]

bport updated this revision to Diff 76384.
bport added a comment.


  Rework, not expose anymore settings and loader but expose a new settings class

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27502?vs=75997=76384

REVISION DETAIL
  https://phabricator.kde.org/D27502

AFFECTED FILES
  autotests/test_settings.cpp
  src/core/CMakeLists.txt
  src/core/languagefilter.cpp
  src/core/loader.cpp
  src/core/loader_p.h
  src/core/settings.cpp
  src/core/settings.h
  src/core/settings_p.h
  src/core/settingsimpl.cpp
  src/core/settingsimpl_p.h
  src/core/speller.cpp
  src/ui/CMakeLists.txt
  src/ui/configui.ui
  src/ui/configview.cpp
  src/ui/configview.h
  src/ui/configwidget.cpp
  src/ui/dialog.cpp
  src/ui/highlighter.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27654: [kio] Fix running konsole on Wayland

[Wolfgang Bauer]

wbauer edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27654

To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove updated this revision to Diff 76382.
niccolove added a comment.


  re-tweaked commits

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27122?vs=76381=76382

BRANCH
  contrast_effect_background_color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27122

AFFECTED FILES
  src/desktoptheme/breeze-dark/CMakeLists.txt
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove updated this revision to Diff 76381.
niccolove added a comment.


  Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27122?vs=76373=76381

BRANCH
  contrast_effect_background_color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27122

AFFECTED FILES
  src/desktoptheme/breeze-dark/CMakeLists.txt
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 76378.
niccolove added a comment.


  Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=76376=76378

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  In D27122#617614 , @trmdi wrote:
  
  > Hmm, I think you need to rebase to remove unrelated files in this patch 
e.g. `dropjob.cpp` ... ?
  
  
  Definitively. *sigh*

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27654: [kio] Fix running konsole on Wayland

[Wolfgang Bauer]

wbauer created this revision.
wbauer added a reviewer: dfaure.
wbauer added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
wbauer requested review of this revision.

REVISION SUMMARY
  %i expands to "--icon someicon", but Qt recognizes this option only on 
X11/xcb.
  So konsole failed to start on Wayland.
  
  To fix this problem, pass "-qwindowicon" instead, which is supported on all 
platforms.
  
  See 
https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Exec_key_of_.desktop_files
 for details.
  
  BUG: 408497
  FIXED-IN: 5.68.0

TEST PLAN
  Create a menu entry in kmenueditor that calls a command line application 
(say, "top"), with "Run in Terminal" (on the "Advanced" tab) enabled.
  Try to start it from the application menu.
  
  konsole starts successfully on Wayland now too, with or without an icon set.
  Still works on X11/xcb as well.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27654

AFFECTED FILES
  src/core/desktopexecparser.cpp

To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Tranter Madi]

trmdi added a comment.


  Hmm, I think you need to rebase to remove unrelated files in this patch e.g. 
`dropjob.cpp` ... ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 76376.
niccolove added a comment.


  Added toparea margins

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=75824=76376

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  plasma-framework.categories
  src/CMakeLists.txt
  src/declarativeimports/core/private/DefaultToolTip.qml
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml
  src/declarativeimports/plasmaextracomponents/qml/Title.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/toparea.svg
  src/plasma/CMakeLists.txt
  src/plasma/pluginloader.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasmaquick/CMakeLists.txt
  src/scriptengines/qml/CMakeLists.txt
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h
  tests/components/radiobutton3.qml

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

ervin added a comment.


  In D27540#617589 , @alexde wrote:
  
  > Does this patch also fix indirectly #274629?
  
  
  I doubt it, this bug report seems confused BTW... it was never broken on the 
kdelibs side but *some* dialogs have bugs which break the feature for them. 
Unrelated to this patch we'd been doing a big sweep on the systemsettings 
module to address among other thing the problems they might have in that 
department.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27647: throw out the windows variant of the smb slave

[Hannah von Reth]

vonreth accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-no-win

REVISION DETAIL
  https://phabricator.kde.org/D27647

To: sitter, ngraham, #windows, vonreth
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27097: Port from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  In D27097#615648 , @dfaure wrote:
  
  > OK for deprecating Incremental. A full revert (at KF6 time) of commit 
9ac82e27ad0322e444c16 
 
looks tricky though :-)
  >  I searched the git history, and I can't see where we ever used 
FindIncremental... [I searched kdelibs, since I'm pretty sure this was added 
for KHTML]
  
  
  It's got to be removed at KF6; since it's not actually used, it'll make the 
code simpler, I think (partial/incremental matching is usually a complex pain).
  
  > You say that nothing calls find(QRegExp), that's because the find dialog 
just sets the option RegularExpression, right?
  >  This makes sense actually. I don't see why we have this API. The user uses 
the dialog and checks a box...
  
  Yeah, I meant explicitly call Kfind::find() that takes a QRegExp.
  
  > It sounds like we should just deprecate find(QRegExp) and point to the 
RegularExpression option.
  >  (and make it private, as you said, i.e. move to private class)
  
  OK, will do.

INLINE COMMENTS

> dfaure wrote in kfinddialog.cpp:567
> I doubt end users want to open Qt API documentation...

One alternative is https://perldoc.perl.org/perlre.html :)

I could opt for:
"Invalid PCRE (Perl-compatible regular expressions) pattern syntax" OR
"Invalid PCRE pattern syntax"

then one online search later, the user finds what PCRE is.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27097

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  I felt that the transparency was not working very well with the headerbar on 
some wallpapers, so I toned down the transparency a bit, going from
  F8131395: image.png 
  to
  F8131397: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Alex Debus]

alexde added a comment.


  Does this patch also fix indirectly #274629?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove updated this revision to Diff 76373.
niccolove added a comment.


  Tweaked values

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27122?vs=75787=76373

BRANCH
  contrast_effect_background_color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27122

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  plasma-framework.categories
  src/CMakeLists.txt
  src/declarativeimports/core/private/DefaultToolTip.qml
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml
  src/declarativeimports/plasmaextracomponents/qml/Title.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze-dark/CMakeLists.txt
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg
  src/plasma/CMakeLists.txt
  src/plasma/pluginloader.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasmaquick/CMakeLists.txt
  src/scriptengines/qml/CMakeLists.txt
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h
  tests/components/radiobutton3.qml

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.12 - Build # 123 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.12/123/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Feb 2020 14:58:30 +
 Build duration:
4 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Config-5.68.0.xmlcompat_reports/KF5Config_compat_report.htmllogs/KF5Config/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kconfig_compiler.kconfigcompiler_basic_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(82/90)91%
(82/90)80%
(7309/9186)59%
(3717/6328)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(2014/2025)52%
(834/1619)autotests.kconfig_compiler97%
(29/30)97%
(29/30)97%
(317/327)49%
(109/222)src.core88%
(23/26)88%
(23/26)69%
(2501/3611)56%
(1224/2169)src.gui71%
(5/7)71%
(5/7)62%
(449/726)54%
(176/327)src.kconf_update100%
(2/2)100%
(2/2)71%
(421/592)55%
(249/456)src.kconfig_compiler100%
(8/8)100%
(8/8)88%
(1607/1822)81%
(1125/1397)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/83)0%
(0/138)

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin added a comment.


  In D27133#617577 , @dfaure wrote:
  
  > I really have zero experience with this stuff, but you're asking for my 
opinion nonetheless, so you'll get it, as crappy as it might be :-)
  >
  > Your comment refers to "group separator" as if it was an existing notion in 
KConfig. Can you point me where? Grepping for '241' or for 'separator' gives 
nothing.
  >  Do KConfig files use this already? Or is this all kconfig_compiler 
specific?
  >  I told you, I'm clueless :-)
  
  
  Right, on the C++ side you'd have to look for \x1d

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.13 - Build # 91 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.13/91/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 25 Feb 2020 14:58:30 +
 Build duration:
2 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Config-5.68.0.xmlcompat_reports/KF5Config_compat_report.htmllogs/KF5Config/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kconfig_compiler.kconfigcompiler_basic_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(82/90)91%
(82/90)80%
(7309/9186)59%
(3717/6328)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(2014/2025)52%
(834/1619)autotests.kconfig_compiler97%
(29/30)97%
(29/30)97%
(317/327)49%
(109/222)src.core88%
(23/26)88%
(23/26)69%
(2501/3611)56%
(1224/2169)src.gui71%
(5/7)71%
(5/7)62%
(449/726)54%
(176/327)src.kconf_update100%
(2/2)100%
(2/2)71%
(421/592)55%
(249/456)src.kconfig_compiler100%
(8/8)100%
(8/8)88%
(1607/1822)81%
(1125/1397)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/83)0%
(0/138)

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.13/85/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 25 Feb 2020 14:58:30 +
 Build duration:
1 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kconfig_compiler.kconfigcompiler_basic_test

D27497: Fix code generation for entries with min/max

[Henri Chain]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d218b93a5350: Fix code generation for entries with 
min/max (authored by hchain).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27497?vs=76368=76371

REVISION DETAIL
  https://phabricator.kde.org/D27497

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test13.cpp.ref
  autotests/kconfig_compiler/test_param_minmax.cpp.ref
  autotests/kconfig_compiler/test_param_minmax.h.ref
  autotests/kconfig_compiler/test_param_minmax.kcfg
  autotests/kconfig_compiler/test_param_minmax.kcfgc
  autotests/kconfig_compiler/test_param_minmax_main.cpp
  autotests/kconfig_compiler/test_properties_minmax.cpp.ref
  autotests/kconfig_compiler/test_properties_minmax.h.ref
  autotests/kconfig_compiler/test_properties_minmax.kcfg
  autotests/kconfig_compiler/test_properties_minmax.kcfgc
  autotests/kconfig_compiler/test_properties_minmax_main.cpp
  autotests/kconfig_compiler/test_signal.cpp.ref
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[David Faure]

dfaure added a comment.


  I really have zero experience with this stuff, but you're asking for my 
opinion nonetheless, so you'll get it, as crappy as it might be :-)
  
  Your comment refers to "group separator" as if it was an existing notion in 
KConfig. Can you point me where? Grepping for '241' or for 'separator' gives 
nothing.
  Do KConfig files use this already? Or is this all kconfig_compiler specific?
  I told you, I'm clueless :-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27497: Fix code generation for entries with min/max

[Henri Chain]

hchain updated this revision to Diff 76368.
hchain added a comment.


  add bugzilla

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27497?vs=76317=76368

REVISION DETAIL
  https://phabricator.kde.org/D27497

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test13.cpp.ref
  autotests/kconfig_compiler/test_param_minmax.cpp.ref
  autotests/kconfig_compiler/test_param_minmax.h.ref
  autotests/kconfig_compiler/test_param_minmax.kcfg
  autotests/kconfig_compiler/test_param_minmax.kcfgc
  autotests/kconfig_compiler/test_param_minmax_main.cpp
  autotests/kconfig_compiler/test_properties_minmax.cpp.ref
  autotests/kconfig_compiler/test_properties_minmax.h.ref
  autotests/kconfig_compiler/test_properties_minmax.kcfg
  autotests/kconfig_compiler/test_properties_minmax.kcfgc
  autotests/kconfig_compiler/test_properties_minmax_main.cpp
  autotests/kconfig_compiler/test_signal.cpp.ref
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Noah Davis]

ndavis added a comment.


  I can see the utility in indicating non-default values in some cases, 
particularly with software that has a lot of necessary complexity in the 
settings or where non-default values can cause problems (see SVG Cleaner GUI 
for an example of both). However, I don't think it's necessary for most 
software to indicate non-default values or even dirty values.
  
  Here's a picture of SVG Cleaner GUI for reference:
  F8131329: Screenshot_20200225_094148.PNG 

  
  Notice how the non-default values are indicated with a blue dot and 
categories that contain options with non-default values also have a blue dot.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

[Kevin Ottens]

ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27497

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Nathaniel Graham]

ngraham retitled this revision from "KCModule: Indicate when a setting has been 
changed from the default value" to "KCModule: Indicate when a setting has been 
changed from the default or previous value".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27497: Fix code generation for entries with min/max

[Kevin Ottens]

ervin edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27497

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default value

[David Redondo]

davidre added a comment.


  That title is now not optimal isn't it? 1. It's not only in KCModule 2. It 
also shows unsaved settings

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default value

[Nathaniel Graham]

ngraham retitled this revision from "Status indicator for individual widgets in 
KCModule" to "KCModule: Indicate when a setting has been changed from the 
default value".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil updated this revision to Diff 76365.
dvratil added a comment.


  - Rebase to master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21902?vs=60891=76365

BRANCH
  arcpatch-D21902

REVISION DETAIL
  https://phabricator.kde.org/D21902

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/calendar/eventpluginsmanager.h

To: dvratil, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added a comment.


  In D27540#615160 , @ervin wrote:
  
  > In D27540#615156 , @ngraham 
wrote:
  >
  > > Please add screenshots to the Test Plan section for patches that change 
the UI. :) Also it would be nice to indicate how someone can test this. Which 
apps? System Settings? Where? How?
  >
  >
  > Well, second part I pointed out a few kcms you can test with. ;-)
  
  
  And now you got a screenshot as well. Waiting for further feedback now.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin edited the test plan for this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin updated this revision to Diff 76362.
ervin added a comment.


  Handle visibility of the tracked widget, setters become slots, and add plural 
to "indicatorWidgets".

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27540?vs=76089=76362

REVISION DETAIL
  https://phabricator.kde.org/D27540

AFFECTED FILES
  src/CMakeLists.txt
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h
  src/kconfigdialogmanager_p.h
  src/settingsstatusindicator.cpp
  src/settingsstatusindicator_p.h

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added a comment.


  In D27540#615091 , @davidre wrote:
  
  > The editmarks should probably respect the visibility of the associated 
widget. In this picture I use a invisble lineedit to manage the settings of the 
QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager)
  >  F8117874: grafik.png 
  
  
  For the record, next iteration of that patch will honor the visibility of the 
associated widget (got some more changes to do locally before uploading though, 
stay tuned).
  
  That being said, what you did is a very naughty hack you know. Why not fixing 
KConfigDialogManager or go through a QGroupBox (which is handled in some way). 
;-)

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27627: Fix initialization order

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1e11099c1616: Fix initialization order (authored by 
dvratil).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27627?vs=76306=76361

REVISION DETAIL
  https://phabricator.kde.org/D27627

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp

To: dvratil, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23339: Fix memory leak in ConfigView and Dialog

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4b93b71a4924: Fix memory leak in ConfigView and Dialog 
(authored by dvratil).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23339?vs=76305=76360

REVISION DETAIL
  https://phabricator.kde.org/D23339

AFFECTED FILES
  src/plasmaquick/configview.cpp
  src/plasmaquick/configview.h
  src/plasmaquick/dialog.h

To: dvratil, #plasma, #frameworks, apol, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27633: Port to KPluginLoader

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> kaccountsdplugin.cpp:24
>  
> -KAccountsDPlugin::KAccountsDPlugin(QObject *parent)
> +KAccountsDPlugin::KAccountsDPlugin(QObject *parent, const QVariantList& args)
>  : QObject(parent)

This caused a compiler warning to show up - pushed a quick fix already so don't 
worry about it, but thought i'd mention it for completion's sake :) 
https://commits.kde.org/kaccounts-integration/74e770cc9398d9802f9d0fef652cb5b6da29a74d

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol

D27647: throw out the windows variant of the smb slave

[Harald Sitter]

sitter added a reviewer: Windows.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27647

To: sitter, ngraham, #windows
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27647: throw out the windows variant of the smb slave

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it hasn't been built in ages because the top level cmakelists actually only
  adds the smb dir when samba is found (which would be never I guess?).
  it is also continuously ignored when sweeping changes are made (such as
  the move to json plugin metadata or the debug category change).
  
  overall it is entirely useless as native UNC path handling seems to work
  just fine these days in for example okular and kate. so, I very much
  believe that bespoke smb handling is entirely moot on windows (as it
  should be, really)

TEST PLAN
  okular and kate still open remote UNC paths without it on windows

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-no-win

REVISION DETAIL
  https://phabricator.kde.org/D27647

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb_win.cpp
  smb/kio_smb_win.h

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27646: smb: apply a whole bunch of static analyzer improvements

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  among other things:
  
  - {} initialize the posix structs
  - =default d/ctors where appropriate
  - synced argument names between header and cpp
  - no c-style casting
  - while(true) instead of while(1)
  - initialize class members that could previously have gone uninitialized
  - no single-line-multi-variable declaration

TEST PLAN
  builds

REPOSITORY
  R320 KIO Extras

BRANCH
  tidy

REVISION DETAIL
  https://phabricator.kde.org/D27646

AFFECTED FILES
  smb/dnssddiscoverer.cpp
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_auth.cpp
  smb/kio_smb_browse.cpp
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/kio_smb_internal.cpp
  smb/kio_smb_internal.h
  smb/kio_smb_mount.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27616: [UrlHandler] optimise the code and less if nesting

[Ahmad Samir]

ahmadsamir added a comment.


  I created D27615  first; then this one on 
top of it (optimising the code in a separate commit).

INLINE COMMENTS

> apol wrote in urlhandler.cpp:55
> won't this recurse forever?

I could be wrong, but this is exactly equivalent to the original code, i.e. it 
won't reach this unless helpcenter is empty and it's not a kde app... and I 
actually wanted to ask about this bit from the original code, what is it 
supposed to do?

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27616

To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27644: do not hide enum warnings via switch default label

[Harald Sitter]

sitter added a reviewer: ngraham.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27644

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27644: do not hide enum warnings via switch default label

[Harald Sitter]

sitter created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  should we ever extend the url types the compiler will not warn us that
  the new type may need handling. instead return when we have handled
  a type so the fallback can be moved after the switch

REPOSITORY
  R320 KIO Extras

BRANCH
  nodefault

REVISION DETAIL
  https://phabricator.kde.org/D27644

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 356 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/356/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Feb 2020 10:23:34 +
 Build duration:
3 min 48 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2692)0%
(0/1827)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2056)0%
(0/1412)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 209 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/209/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 25 Feb 2020 10:23:34 +
 Build duration:
3 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5Kirigami2-5.68.0.xmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2692)0%
(0/1827)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2056)0%
(0/1412)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi added a dependent revision: D27188: KCM Notifications : Manage 
app-specific notifications with KCconfigXT's magic.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a dependent revision: D27188: KCM Notifications : Manage 
app-specific notifications with KCconfigXT's magic.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27642: RFC WIP support OSX style device icons system for dns-sd discoveries

[Harald Sitter]

sitter created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  looking for some general thoughts on the concept
  
  osx and newer sambas send model data in the dnssd entires. this allows
  osx to show fitting device icons based on the remote (and CRT icons for
  services discovered through other means than dns-sd).
  e.g. if you share something from your macbook your imac will show a
  macbook/laptop icon instead of a generic computer screen.
  meanwhile machines found over SMB1 (and I guess wsdiscovery) are shown
  with CRT screens and a BSOD.
  
  this prototype would essentially allow us to have a similar level of polish,
  albeit a bit dependent on samba since samba would need to have a suitable 
model
  set. for example tuxedo could set laptop-foobar in their smb.conf and a 
suitable
  icon set on clients could show a laptop or even foobar specific icon instead 
of the
  stock one.
  
  so, if we know the model we'd set
  `network-server-model-$modelName`
  e.g.
  `network-server-model-laptop-foobar`
  and an icon theme would be able to provide regular icon fallbacks
  to theme this.
  
  `network-server-model-laptop-foobar`
  as specific model icon (the foobar type laptop from $vendor)
  `network-server-model-laptop`
  as generic model icon if model isn't available
  `network-server`
  as generic server icon if the specific ones are not available
  
  on the WSD side we could also give WSD discovered hosts a WSD icon *cough CRT 
screen* ;)
  in point of fact, I am almost certain that I've seen something like 
_device-info,
  albeit much less precise, in one of the device profile SOAP specs. IIRC
  on the WSD side we can at least tell apart printers from actual computers, 
not sure
  if that is worth the headache of having to deal with more soap though *shrug*

TEST PLAN
  have an osx machine on the network

REPOSITORY
  R320 KIO Extras

BRANCH
  wsd-model

REVISION DETAIL
  https://phabricator.kde.org/D27642

AFFECTED FILES
  smb/dnssddiscoverer.cpp
  smb/dnssddiscoverer.h

To: sitter
Cc: kde-frameworks-devel, ngraham, kfm-devel, broulik, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D27502: Create ConfigView an unmanaged ConfigWidget

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ervin wrote in settings.cpp:109
> This is an odd bit of logic, isn't it?

Yes indeed, but what we want is to save false if checked and true if not 
checked.
I moved the logic there in order to work with kconfigxt and with current 
implementation

> ervin wrote in configview.cpp:33
> I'm kind of surprised at this extra widget, can't we get rid of it?

I kept same widget logic as ConfigWidget. Ididn't want to change that to ensure 
we have the same baheviour

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27502

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns