D26749: WIP: Support NDK r20 and Qt 5.14

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Seems ready to land to me.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26749

To: vkrause, apol
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> vkrause wrote in Android.cmake:173
> I actually didn't test 64bit ARM here, only armv7 and x86, both work. What 
> does break for you there?

I'm not sure what was going on, seems to work now.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26749

To: vkrause, apol
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D25315: KDirModel: implement showing a root node for the requested URL

[Raphael Rosch]

rrosch added a comment.


  Crash:
  
kf5.kio.kdirmodel: Items emitted in directory QUrl("file:///home/myuser/") 
but that directory isn't in KDirModel! Root directory: 
QUrl("file:///home/myuser/")
KCrash: Application 'konqueror' crashing...
  
  This happens right after pressing F9 to bring up the sidebar.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26211: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 76705.
ahmadsamir added a comment.


  - Move the QRegularExpression definition out of the for loop, more efficient 
as it'll reused
  - match() always allocates a QRegularExpressionMatch anyway, so move it 
inside the while loop
  - Make the first () non-capturing since the capture group isn't needed

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26211?vs=72149=76705

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26211

AFFECTED FILES
  data/parsetrigrams.cpp

To: ahmadsamir, cullmann, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26211: Port QRegExp to QRegularExpression

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Actually, one can re-use this regex for all files by moving it before the 
scope of the loop, or?
  The match on the other side is allocated per match() call, I would just move 
that inside the inner stuff and just do some
  const auto match = rx

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26211

To: ahmadsamir, cullmann, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27693: Add syntax highlighting for Java Properties

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for this addition and the MIT licensing!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-java-properties

REVISION DETAIL
  https://phabricator.kde.org/D27693

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0daf938b0660: TypeScript: add private fields and 
type-only imports/exports, and some fixes (authored by nibags, committed by 
cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27692?vs=76518=76703

REVISION DETAIL
  https://phabricator.kde.org/D27692

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.php.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27693: Add syntax highlighting for Java Properties

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4a0a0e56cd86: Add syntax highlighting for Java Properties 
(authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27693?vs=76512=76704

REVISION DETAIL
  https://phabricator.kde.org/D27693

AFFECTED FILES
  autotests/folding/test.properties.fold
  autotests/html/test.properties.html
  autotests/input/test.properties
  autotests/reference/test.properties.ref
  data/syntax/java-properties.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, let's merge this.
  Thanks for all the work on that!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D27692

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25315: KDirModel: implement showing a root node for the requested URL

[David Faure]

dfaure updated this revision to Diff 76701.
dfaure retitled this revision from "KDirModel: implement showing "/" as a root 
node, optionally" to "KDirModel: implement showing a root node for the 
requested URL".
dfaure edited the summary of this revision.
dfaure removed a subscriber: rrosch.
dfaure added a comment.


  Rework the patch so that any node can be shown as a visible root.
  
  This is actually much cleaner, no more empty-URL hacks.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25315?vs=70183=76701

BRANCH
  2019_11_kdirmodel_root

REVISION DETAIL
  https://phabricator.kde.org/D25315

AFFECTED FILES
  autotests/kdirmodeltest.cpp
  autotests/kdirmodeltest.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kdirmodeltest_gui.cpp

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns, 
rrosch

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27692

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27741: KCodecs: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license statements to SPDX 
expressions" to "KCodecs: Convert license statements to SPDX expressions".

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D27741

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27738: KCoreAddons: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license statements to SPDX 
expressions" to "KCoreAddons: Convert license statements to SPDX expressions".

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D27738

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27742: Solid: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license headers to SPDX 
expressions" to "Solid: Convert license headers to SPDX expressions".

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27742

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27742: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX expressions and add
  license files as required by REUSE specification.

REPOSITORY
  R245 Solid

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27742

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/fakeUpower.cpp
  autotests/fakeUpower.h
  autotests/fakehardwaretest.cpp
  autotests/fakehardwaretest.h
  autotests/fakelogind.cpp
  autotests/fakelogind.h
  autotests/halbasictest.cpp
  autotests/halbasictest.h
  autotests/logindinhibitionargumenttest.cpp
  autotests/qtest_dbus.h
  autotests/solidfreedesktoptest.cpp
  autotests/solidhwtest.cpp
  autotests/solidhwtest.h
  autotests/solidjobtest.cpp
  autotests/solidmttest.cpp
  autotests/solidpowertest.cpp
  cmake/FindIOKit.cmake
  cmake/FindUDev.cmake
  cmake/SolidBackendsMacros.cmake
  src/imports/devices.cpp
  src/imports/devices.h
  src/imports/devices_p.h
  src/imports/solidextensionplugin.cpp
  src/imports/solidextensionplugin.h
  src/solid/devices/backends/fakehw/fakebattery.cpp
  src/solid/devices/backends/fakehw/fakebattery.h
  src/solid/devices/backends/fakehw/fakeblock.cpp
  src/solid/devices/backends/fakehw/fakeblock.h
  src/solid/devices/backends/fakehw/fakecamera.cpp
  src/solid/devices/backends/fakehw/fakecamera.h
  src/solid/devices/backends/fakehw/fakecdrom.cpp
  src/solid/devices/backends/fakehw/fakecdrom.h
  src/solid/devices/backends/fakehw/fakedevice.cpp
  src/solid/devices/backends/fakehw/fakedevice.h
  src/solid/devices/backends/fakehw/fakedevice_p.h
  src/solid/devices/backends/fakehw/fakedeviceinterface.cpp
  src/solid/devices/backends/fakehw/fakedeviceinterface.h
  src/solid/devices/backends/fakehw/fakegenericinterface.cpp
  src/solid/devices/backends/fakehw/fakegenericinterface.h
  src/solid/devices/backends/fakehw/fakemanager.cpp
  src/solid/devices/backends/fakehw/fakemanager.h
  src/solid/devices/backends/fakehw/fakenetworkshare.cpp
  src/solid/devices/backends/fakehw/fakenetworkshare.h
  src/solid/devices/backends/fakehw/fakeopticaldisc.cpp
  src/solid/devices/backends/fakehw/fakeopticaldisc.h
  src/solid/devices/backends/fakehw/fakeportablemediaplayer.cpp
  src/solid/devices/backends/fakehw/fakeportablemediaplayer.h
  src/solid/devices/backends/fakehw/fakeprocessor.cpp
  src/solid/devices/backends/fakehw/fakeprocessor.h
  src/solid/devices/backends/fakehw/fakestorage.cpp
  src/solid/devices/backends/fakehw/fakestorage.h
  src/solid/devices/backends/fakehw/fakestorageaccess.cpp
  src/solid/devices/backends/fakehw/fakestorageaccess.h
  src/solid/devices/backends/fakehw/fakevolume.cpp
  src/solid/devices/backends/fakehw/fakevolume.h
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h
  src/solid/devices/backends/fstab/fstabmanager.cpp
  src/solid/devices/backends/fstab/fstabmanager.h
  src/solid/devices/backends/fstab/fstabnetworkshare.cpp
  src/solid/devices/backends/fstab/fstabnetworkshare.h
  src/solid/devices/backends/fstab/fstabservice.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h
  src/solid/devices/backends/fstab/fstabwatcher.cpp
  src/solid/devices/backends/fstab/fstabwatcher.h
  src/solid/devices/backends/hal/halbattery.cpp
  src/solid/devices/backends/hal/halbattery.h
  src/solid/devices/backends/hal/halblock.cpp
  src/solid/devices/backends/hal/halblock.h
  src/solid/devices/backends/hal/halcamera.cpp
  src/solid/devices/backends/hal/halcamera.h
  src/solid/devices/backends/hal/halcdrom.cpp
  src/solid/devices/backends/hal/halcdrom.h
  src/solid/devices/backends/hal/haldevice.cpp
  src/solid/devices/backends/hal/haldevice.h
  src/solid/devices/backends/hal/haldeviceinterface.cpp
  src/solid/devices/backends/hal/haldeviceinterface.h
  src/solid/devices/backends/hal/halfstabhandling.cpp
  src/solid/devices/backends/hal/halfstabhandling.h
  src/solid/devices/backends/hal/halgenericinterface.cpp
  src/solid/devices/backends/hal/halgenericinterface.h
  src/solid/devices/backends/hal/halmanager.cpp
  src/solid/devices/backends/hal/halmanager.h
  src/solid/devices/backends/hal/halopticaldisc.cpp
  src/solid/devices/backends/hal/halopticaldisc.h
  src/solid/devices/backends/hal/halportablemediaplayer.cpp
  src/solid/devices/backends/hal/halportablemediaplayer.h
  src/solid/devices/backends/hal/halprocessor.cpp
  src/solid/devices/backends/hal/halprocessor.h
  src/solid/devices/backends/hal/halstorage.cpp
  src/solid/devices/backends/hal/halstorage.h
  src/solid/devices/backends/hal/halstorageaccess.cpp
  

D27742: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27742

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D27741

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX expressions and add
  license files as required by REUSE specification. Note that some
  missing copyright holders were recovered from kdelibs history (see
  respective commit)

REPOSITORY
  R270 KCodecs

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27741

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/MIT.txt
  LICENSES/MPL-1.1.txt
  autotests/base64benchmark.cpp
  autotests/codectest.cpp
  autotests/codectest.h
  autotests/kcharsetstest.cpp
  autotests/kcharsetstest.h
  autotests/kcodecstest.cpp
  autotests/kcodecstest.h
  autotests/kemailaddresstest.cpp
  autotests/kemailaddresstest.h
  autotests/kencodingprobertest.cpp
  autotests/kencodingprobertest.h
  autotests/rfc2047test.cpp
  autotests/rfc2047test.h
  cmake/rules_PyKF5.py
  src/kcharsets.cpp
  src/kcharsets.h
  src/kcodecs.cpp
  src/kcodecs.h
  src/kcodecs_p.h
  src/kcodecsbase64.cpp
  src/kcodecsbase64.h
  src/kcodecsidentity.cpp
  src/kcodecsidentity.h
  src/kcodecsqp.cpp
  src/kcodecsqp.h
  src/kcodecsuuencode.cpp
  src/kcodecsuuencode.h
  src/kemailaddress.cpp
  src/kemailaddress.h
  src/kencodingprober.cpp
  src/kencodingprober.h
  src/kentities.gperf
  src/probers/CharDistribution.cpp
  src/probers/CharDistribution.h
  src/probers/ChineseGroupProber.cpp
  src/probers/ChineseGroupProber.h
  src/probers/JapaneseGroupProber.cpp
  src/probers/JapaneseGroupProber.h
  src/probers/JpCntx.cpp
  src/probers/JpCntx.h
  src/probers/LangBulgarianModel.cpp
  src/probers/LangCyrillicModel.cpp
  src/probers/LangGreekModel.cpp
  src/probers/LangHebrewModel.cpp
  src/probers/LangHungarianModel.cpp
  src/probers/LangThaiModel.cpp
  src/probers/UnicodeGroupProber.cpp
  src/probers/UnicodeGroupProber.h
  src/probers/nsBig5Prober.cpp
  src/probers/nsBig5Prober.h
  src/probers/nsCharSetProber.cpp
  src/probers/nsCharSetProber.h
  src/probers/nsCodingStateMachine.h
  src/probers/nsEUCJPProber.cpp
  src/probers/nsEUCJPProber.h
  src/probers/nsEUCKRProber.cpp
  src/probers/nsEUCKRProber.h
  src/probers/nsEscCharsetProber.cpp
  src/probers/nsEscCharsetProber.h
  src/probers/nsEscSM.cpp
  src/probers/nsGB2312Prober.cpp
  src/probers/nsGB2312Prober.h
  src/probers/nsHebrewProber.cpp
  src/probers/nsHebrewProber.h
  src/probers/nsLatin1Prober.cpp
  src/probers/nsLatin1Prober.h
  src/probers/nsMBCSGroupProber.cpp
  src/probers/nsMBCSGroupProber.h
  src/probers/nsMBCSSM.cpp
  src/probers/nsPkgInt.h
  src/probers/nsSBCSGroupProber.cpp
  src/probers/nsSBCSGroupProber.h
  src/probers/nsSBCharSetProber.cpp
  src/probers/nsSBCharSetProber.h
  src/probers/nsSJISProber.cpp
  src/probers/nsSJISProber.h
  src/probers/nsUniversalDetector.cpp
  src/probers/nsUniversalDetector.h
  src/probers/tables/Big5Freq.tab
  src/probers/tables/EUCKRFreq.tab
  src/probers/tables/GB2312Freq.tab
  src/probers/tables/JISFreq.tab

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25123: New yakuake logo/icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0a5c9abac1ff: New yakuake logo/icon (authored by mglb, 
committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25123?vs=75148=76687

REVISION DETAIL
  https://phabricator.kde.org/D25123

AFFECTED FILES
  icons-dark/apps/48/yakuake.svg
  icons/apps/48/yakuake.svg

To: mglb, #vdg, #yakuake, hein, ndavis, mweepigeon
Cc: mweepigeon, davidre, GB_2, ndavis, ognarb, ngraham, hein, 
kde-frameworks-devel, numerodix, vmarinescu, ryanmccoskrie, LeGast00n, cblack, 
michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 153 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/153/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 29 Feb 2020 15:28:41 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 261 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/261/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 29 Feb 2020 15:28:41 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 147 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/147/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 29 Feb 2020 15:28:40 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 208 lines...][2020-02-29T15:29:02.886Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-02-29T15:29:02.886Z] [  4%] Automatic MOC for target qrcAlias[2020-02-29T15:29:02.886Z] [ 12%] Automatic MOC for target dupe[2020-02-29T15:29:02.886Z] [ 16%] Automatic MOC for target symlink[2020-02-29T15:29:02.886Z] [ 16%] Automatic MOC for target scalable[2020-02-29T15:29:02.886Z] [ 20%] Automatic MOC for target newline[2020-02-29T15:29:02.886Z] [ 20%] Built target breeze-icons-dark-mkdir[2020-02-29T15:29:02.886Z] [ 20%] Built target breeze-icons-mkdir[2020-02-29T15:29:02.886Z] Using POSIX-style sed arguments[2020-02-29T15:29:02.886Z] Using POSIX-style sed arguments[2020-02-29T15:29:02.886Z] [ 20%] Built target qrcAlias_autogen[2020-02-29T15:29:03.146Z] Scanning dependencies of target qrcAlias[2020-02-29T15:29:03.146Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2020-02-29T15:29:03.146Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2020-02-29T15:29:03.406Z] [ 29%] Built target symlink_autogen[2020-02-29T15:29:03.406Z] [ 29%] Built target dupe_autogen[2020-02-29T15:29:03.406Z] [ 29%] Built target newline_autogen[2020-02-29T15:29:03.406Z] [ 29%] Built target scalable_autogen[2020-02-29T15:29:03.406Z] Scanning dependencies of target symlink[2020-02-29T15:29:03.406Z] [ 33%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-02-29T15:29:03.406Z] [ 37%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2020-02-29T15:29:03.666Z] Scanning dependencies of target newline[2020-02-29T15:29:03.666Z] Scanning dependencies of target dupe[2020-02-29T15:29:03.666Z] [ 41%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2020-02-29T15:29:03.666Z] Scanning dependencies of target scalable[2020-02-29T15:29:03.666Z] [ 45%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2020-02-29T15:29:03.666Z] [ 54%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2020-02-29T15:29:03.666Z] [ 54%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2020-02-29T15:29:03.666Z] [ 58%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[2020-02-29T15:29:03.666Z] [ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2020-02-29T15:29:03.666Z] [ 62%] Built target breeze-validate-svg[2020-02-29T15:29:03.923Z] [ 66%] Linking CXX executable bin/qrcAlias[2020-02-29T15:29:03.923Z] [ 66%] Built target qrcAlias[2020-02-29T15:29:03.923Z] Scanning dependencies of target breeze-icons-dark-rcc[2020-02-29T15:29:03.923Z] Scanning dependencies of target breeze-icons-rcc[2020-02-29T15:29:03.923Z] [ 75%] Generating res/breeze-icons-dark.qrc[2020-02-29T15:29:03.923Z] [ 75%] Generating res/breeze-icons.qrc[2020-02-29T15:29:04.498Z] /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/autotests/scalabletest.cpp:76:26: warning: result of comparison of constant -1 with _expression_ of type 'KIconLoaderDummy::Context' is always true [-Wtautological-constant-out-of-range-compare][2020-02-29T15:29:04.498Z] QVERIFY2(context != -1,[2020-02-29T15:29:04.498Z]  ~~~ ^  ~~[2020-02-29T15:29:04.498Z] /usr/local/include/qt5/QtTest/qtestcase.h:77:9: note: expanded from macro 'QVERIFY2'[2020-02-29T15:29:04.498Z] if (statement) {\[2020-02-29T15:29:04.498Z] ^[2020-02-29T15:29:04.498Z] [ 79%] Linking CXX executable ../bin/symlink[2020-02-29T15:29:04.498Z] [ 79%] Built target symlink[2020-02-29T15:29:04.498Z] [ 83%] Linking CXX executable ../bin/dupe[2020-02-29T15:29:04.755Z] [ 87%] Linking CXX executable ../bin/newline[2020-02-29T15:29:04.755Z] [ 87%] Built target dupe[2020-02-29T15:29:04.755Z] [ 87%] Built target newline[2020-02-29T15:29:04.755Z] 1 warning generated.[2020-02-29T15:29:04.755Z] [ 91%] Linking CXX executable ../bin/scalable[2020-02-29T15:29:04.755Z] [ 91%] Built target scalable[2020-02-29T15:29:07.287Z] [ 95%] Generating breeze-icons.rcc[2020-02-29T15:29:07.287Z] [100%] Generating breeze-icons-dark.rcc[2020-02-29T15:29:09.177Z] [100%] Built target breeze-icons-dark-rcc[2020-02-29T15:29:09.177Z] [100%] Built target breeze-icons-rcc[2020-02-29T15:29:24.046Z] [100%] Built target breeze-generate-24px-versions[2020-02-29T15:29:24.046Z] [100%] Built target breeze-generate-24px-versions-dark[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[2020-02-29T15:29:24.805Z] + python3 -u ci-tooling/helpers/install-build.py --product Frameworks --project 

D25123: New yakuake logo/icon

[Nathaniel Graham]

ngraham added a task: T10243: Some KDE applications could use better icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein, ndavis, mweepigeon
Cc: mweepigeon, davidre, GB_2, ndavis, ognarb, ngraham, hein, 
kde-frameworks-devel, numerodix, vmarinescu, ryanmccoskrie, LeGast00n, cblack, 
michaelh, bruns

D25123: New yakuake logo/icon

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein, ndavis, mweepigeon
Cc: mweepigeon, davidre, GB_2, ndavis, ognarb, ngraham, hein, 
kde-frameworks-devel, numerodix, vmarinescu, ryanmccoskrie, LeGast00n, cblack, 
michaelh, bruns

D25123: New yakuake logo/icon

[Andrew Hou]

mweepigeon accepted this revision.
mweepigeon added a comment.


  Looks great to me!

REPOSITORY
  R266 Breeze Icons

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein, ndavis, mweepigeon
Cc: mweepigeon, davidre, GB_2, ndavis, ognarb, ngraham, hein, 
kde-frameworks-devel, numerodix, vmarinescu, ryanmccoskrie, LeGast00n, cblack, 
michaelh, bruns

D25123: New yakuake logo/icon

[Nathaniel Graham]

ngraham added a comment.


  @mglb ping

REPOSITORY
  R266 Breeze Icons

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein, ndavis
Cc: davidre, GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, 
numerodix, vmarinescu, ryanmccoskrie, LeGast00n, cblack, michaelh, bruns

D25315: KDirModel: implement showing "/" as a root node, optionally

[David Faure]

dfaure added a comment.


  In D25315#619727 , @rrosch wrote:
  
  > > Keep only matters for further calls to openUrl, not the first one. It's 
about whether to *add* or *replace* the currently open URL.
  > >  KDirModel takes care of that.
  >
  > Ah ok, so it's going to do that without me needing to explicitly specify 
"Keep"?
  
  
  Yes. Basically KDirModel is one layer above KDirLister, it encapsulates it. 
If you use KDirModel, you shouldn't have to use KDirLister API directly.
  
  >>> Which should show the node for "/home" as the root, but is instead giving 
me a flat listing of all the child nodes without "/home" as the root.
  >> 
  >> Oh, hmm, that's not how setRootIndex works (that's a *view* feature, we 
can't change that).
  >>  I changed the model to have one more node for "/", while I see now that 
what you want is that it *always* shows a root node even when the root is 
another directory.
  > 
  > Yeah that was my intent with the above. How come it doesn't work in the 
view for `file:///home/myuser` but it works for `file:///`?
  
  I thought the plan was to always show a tree that starts at the root, like 
iirc the old "Root" tab in konqueror-kde4, or the Root tree view in dolphin.
  This is why KDirModel::openUrl("file:///home/myuser", ShowRoot) shows
  
"/"
| - home
| - myuser
  
  > In any case, the code here you provided works great for at least `file:///` 
and that gets us quite far. How much of a rework would getting it to work with 
subdirectories (like `file:///home/myuser`) take?
  
  No idea. I'll work on it and let you know how much work it was :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 443 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/443/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 29 Feb 2020 14:10:39 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34818/62097)40%
(17704/43862)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)96%
(9734/10191)47%
(4551/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8725/14617)51%
(4515/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 318 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/318/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 29 Feb 2020 14:10:39 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34822/62098)40%
(17696/43858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4549/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14617)51%
(4510/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 309 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/309/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 29 Feb 2020 14:10:39 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto added a comment.


  I have tried all the suggested commands, none of them worked. I opened a new 
merge request where everything is correct:
  https://phabricator.kde.org/D27740
  
  Can you delete this merge request or tell me how I can do it?
  Sorry for the questions, but I have never worked with this system and coming 
from Git, I don't find it intuitive.

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27740: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto created this revision.
cacahueto added reviewers: Frameworks, nicolasfella, vkrause.
Herald added a project: Frameworks.
cacahueto requested review of this revision.

REVISION SUMMARY
  KNotifications assigns the ID 0 to the default action on a notification (the
  one when the notification itself is selected). Additional actions (buttons on
  the notification) are counted starting with 1.
  
  In the Android backend however, the default action has ID 0 and the additional
  actions are counted starting with 0 as well. This has been fixed to work as
  described above.

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27740

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, jbbgameich, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto updated this revision to Diff 76684.
cacahueto added a comment.


  Adapt action numbering in Android to work like in KNotifications
  
  Summary:
  KNotifications assigns the ID 0 to the default action on a notification (the
  one when the notification itself is selected). Additional actions (buttons on
  the notification) are counted starting with 1.
  
  In the Android backend however, the default action has ID 0 and the additional
  actions are counted starting with 0 as well. This has been fixed to work as
  described above.
  
  Reviewers: #frameworks , 
nicolasfella, vkrause
  
  Subscribers: kde-frameworks-devel
  
  Tags: #frameworks 
  
  Differential Revision: https://phabricator.kde.org/D27528

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27528?vs=76065=76684

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

[Ahmad Samir]

ahmadsamir updated this revision to Diff 76682.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Tweak commit message

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27735?vs=76671=76682

BRANCH
  l-font-sytleName (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27735

AFFECTED FILES
  src/gui/kconfiggroupgui.cpp

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27738: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D27738

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27738: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX expressions and add license files
  as required by REUSE specification.

REPOSITORY
  R244 KCoreAddons

BRANCH
  sdpx

REVISION DETAIL
  https://phabricator.kde.org/D27738

AFFECTED FILES
  LICENSES/BSD-2-Clause.txt
  LICENSES/BSD-3-Clause.txt
  LICENSES/CC0-1.0.txt
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/LicenseRef-Qt-Commercial.txt
  LICENSES/MPL-1.1.txt
  LICENSES/Qt-LGPL-exception-1.1.txt
  autotests/alwaysunloadplugin.cpp
  autotests/alwaysunloadplugin.h
  autotests/desktoptojsontest.cpp
  autotests/jsonplugin.cpp
  autotests/jsonplugin.h
  autotests/jsonplugin2.cpp
  autotests/jsonplugin2.h
  autotests/kaboutdataapplicationdatatest.cpp
  autotests/kaboutdatatest.cpp
  autotests/kautosavefiletest.cpp
  autotests/kautosavefiletest.h
  autotests/kcompositejobtest.cpp
  autotests/kcompositejobtest.h
  autotests/kdelibs4configmigratortest.cpp
  autotests/kdelibs4migrationtest.cpp
  autotests/kdirwatch_unittest.cpp
  autotests/kfileutilstest.cpp
  autotests/kfileutilstest.h
  autotests/kformattest.cpp
  autotests/kformattest.h
  autotests/kjobtest.cpp
  autotests/kjobtest.h
  autotests/klistopenfilesjobtest_unix.cpp
  autotests/klistopenfilesjobtest_unix.h
  autotests/klistopenfilesjobtest_win.cpp
  autotests/klistopenfilesjobtest_win.h
  autotests/kmacroexpandertest.cpp
  autotests/kosreleasetest.cpp
  autotests/kpluginfactorytest.cpp
  autotests/kpluginloadertest.cpp
  autotests/kpluginmetadatatest.cpp
  autotests/kprocesslisttest.cpp
  autotests/kprocesslisttest.h
  autotests/kprocesstest.cpp
  autotests/kprocesstest_helper.cpp
  autotests/kprocesstest_helper.h
  autotests/krandomtest.cpp
  autotests/kshareddatacachetest.cpp
  autotests/kshelltest.cpp
  autotests/ktexttohtmltest.cpp
  autotests/ktexttohtmltest.h
  autotests/kurlmimedatatest.cpp
  autotests/kurlmimedatatest.h
  autotests/kusertest.cpp
  autotests/multiplugin.cpp
  autotests/multiplugin.h
  autotests/unversionedplugin.cpp
  autotests/unversionedplugin.h
  autotests/versionedplugin.cpp
  autotests/versionedplugin.h
  cmake/FindFAM.cmake
  cmake/FindProcstat.cmake
  cmake/rules_PyKF5.py
  src/desktoptojson/desktoptojson.cpp
  src/desktoptojson/desktoptojson.h
  src/desktoptojson/main.cpp
  src/lib/caching/kshareddatacache.cpp
  src/lib/caching/kshareddatacache.h
  src/lib/caching/kshareddatacache_p.h
  src/lib/caching/kshareddatacache_win.cpp
  src/lib/caching/posix_fallocate_mac.h
  src/lib/io/kautosavefile.cpp
  src/lib/io/kautosavefile.h
  src/lib/io/kbackup.cpp
  src/lib/io/kbackup.h
  src/lib/io/kdirwatch.cpp
  src/lib/io/kdirwatch.h
  src/lib/io/kdirwatch_p.h
  src/lib/io/kfilesystemtype.cpp
  src/lib/io/kfilesystemtype.h
  src/lib/io/kfileutils.cpp
  src/lib/io/kfileutils.h
  src/lib/io/kmessage.cpp
  src/lib/io/kmessage.h
  src/lib/io/kprocess.cpp
  src/lib/io/kprocess.h
  src/lib/io/kprocess_p.h
  src/lib/io/kurlmimedata.cpp
  src/lib/io/kurlmimedata.h
  src/lib/jobs/kcompositejob.cpp
  src/lib/jobs/kcompositejob.h
  src/lib/jobs/kcompositejob_p.h
  src/lib/jobs/kjob.cpp
  src/lib/jobs/kjob.h
  src/lib/jobs/kjob_p.h
  src/lib/jobs/kjobtrackerinterface.cpp
  src/lib/jobs/kjobtrackerinterface.h
  src/lib/jobs/kjobuidelegate.cpp
  src/lib/jobs/kjobuidelegate.h
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h
  src/lib/kcoreaddons.cpp
  src/lib/kcoreaddons.h
  src/lib/plugin/desktopfileparser.cpp
  src/lib/plugin/desktopfileparser_p.h
  src/lib/plugin/kexportplugin.h
  src/lib/plugin/kpluginfactory.cpp
  src/lib/plugin/kpluginfactory.h
  src/lib/plugin/kpluginfactory_p.h
  src/lib/plugin/kpluginloader.cpp
  src/lib/plugin/kpluginloader.h
  src/lib/plugin/kpluginmetadata.cpp
  src/lib/plugin/kpluginmetadata.h
  src/lib/randomness/krandom.cpp
  src/lib/randomness/krandom.h
  src/lib/randomness/krandomsequence.cpp
  src/lib/randomness/krandomsequence.h
  src/lib/text/kmacroexpander.cpp
  src/lib/text/kmacroexpander.h
  src/lib/text/kmacroexpander_p.h
  src/lib/text/kmacroexpander_unix.cpp
  src/lib/text/kmacroexpander_win.cpp
  src/lib/text/kstringhandler.cpp
  src/lib/text/kstringhandler.h
  src/lib/text/ktexttohtml.cpp
  src/lib/text/ktexttohtml.h
  src/lib/text/ktexttohtml_p.h
  src/lib/text/ktexttohtmlemoticonsinterface.h
  src/lib/util/kdelibs4configmigrator.cpp
  src/lib/util/kdelibs4configmigrator.h
  src/lib/util/kdelibs4migration.cpp
  src/lib/util/kdelibs4migration.h
  src/lib/util/kformat.cpp
  src/lib/util/kformat.h
  src/lib/util/kformatprivate.cpp
  src/lib/util/kformatprivate_p.h
  

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a08449a9a2cb: templates: Convert license statements to 
SPDX headers (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27640?vs=76679=76680

REVISION DETAIL
  https://phabricator.kde.org/D27640

AFFECTED FILES
  templates/cpp-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/cpp-plasmoid/src/%{APPNAMELC}.cpp
  templates/cpp-plasmoid/src/%{APPNAMELC}.h
  templates/cpp-plasmoid/src/package/contents/ui/main.qml
  templates/cpp-plasmoid/src/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper/package/contents/ui/config.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid-with-qml-extension/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/qml-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid/package/contents/ui/main.qml
  templates/qml-plasmoid/package/metadata.desktop

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Wow that Qt bug report has really extensive investigation, very impressive.
  
  The fix looks ok to me (without being an expert on the topic, it does seem to 
match what that bug report is saying).

REPOSITORY
  R237 KConfig

BRANCH
  l-font-sytleName (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27735

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  templatesusespdxlicensestyle

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 76679.
kossebau added a comment.


  Update license keys to what KAboutLicense currently supports

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27640?vs=76343=76679

BRANCH
  templatesusespdxlicensestyle

REVISION DETAIL
  https://phabricator.kde.org/D27640

AFFECTED FILES
  templates/cpp-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/cpp-plasmoid/src/%{APPNAMELC}.cpp
  templates/cpp-plasmoid/src/%{APPNAMELC}.h
  templates/cpp-plasmoid/src/package/contents/ui/main.qml
  templates/cpp-plasmoid/src/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper/package/contents/ui/config.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid-with-qml-extension/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/qml-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid/package/contents/ui/main.qml
  templates/qml-plasmoid/package/metadata.desktop

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

[Ahmad Samir]

ahmadsamir added a comment.


  Caveat: setting the general font to e.g. "Noto Sans" and then restarting the 
fonts KCM; opening the general font selection dialog, "Semi condensed" is 
selected instead of Regular. That looks like a bug in the static method 
nearestExistingFont() from plasma-desktop/kcms/fonts/fonts.cpp , I am working 
on porting the fonts KCM to QFontDialog, and will try to fix that there.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27735

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D27640#619817 , @cordlandwehr 
wrote:
  
  > My only question is, how is the X-KDE-PluginInfo-License value is 
evaluated? Are we free to write any value? Or do we have to extend some 
mechanism? I would be great to also use SPDX identifiers there!
  
  
  From what I can tell, Plasma itself currently ignores the license info, e.g. 
there is no display of About data for plasmoids or wallpaper plugins (sadly, 
IMHO, but no resources to fix myself).
  
  In general X-KDE-PluginInfo+* is feed to KPluginMetaData, which just holds 
the raw string. The string itself is evaluated e,g,in KAboutPluginDialog via 
KAboutLicense::byKeyword(), the only place I know about currently (besides 
deprecated KAboutData::fromPluginMetaData, which does the same 
KAboutLicense::byKeyword).
  
  KAboutLicense itself once was already extended to support keywords (see D6672 
), but needs update to latest SPDX 
identifiers,

INLINE COMMENTS

> cordlandwehr wrote in metadata.desktop:96
> does this work with our PluginInfo mechanism? actually, I did not yet look 
> into the SPDX license handling in desktop files or any other tooling for 
> outbound licenses for libraries, plugins or applications; same question for 
> the same changes below in the desktop files

Hmpf, this is outdated version, forgot to append to commit before arc diff.
Should be "LGPLv21+" as I had found later that KAboutLicense still only 
supports the meanwhile deprecated spdx key variants.
Will update next.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27243: KQuickCharts: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1049:b294f7fb337e: KQuickCharts: Convert license headers to 
SPDX statements (authored by cordlandwehr).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R1049 KQuickCharts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27243?vs=75244=76677

REVISION DETAIL
  https://phabricator.kde.org/D27243

AFFECTED FILES
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT.txt
  autotests/ArraySourceTest.cpp
  autotests/qmltest.cpp
  autotests/tst_BarChart.qml
  autotests/tst_LineChart.qml
  autotests/tst_PieChart.qml
  controls/ChartsControlsPlugin.cpp
  controls/ChartsControlsPlugin.h
  controls/Legend.qml
  controls/LegendDelegate.qml
  controls/LineChartControl.qml
  controls/PieChartControl.qml
  controls/Theme.qml
  controls/styles/org.kde.desktop/Theme.qml
  examples/charts/BarChart.qml
  examples/charts/ContinuousLineChart.qml
  examples/charts/LineChart.qml
  examples/charts/PieChart.qml
  examples/charts/RangeEditor.qml
  examples/charts/main.cpp
  examples/charts/main.qml
  examples/snippets/barchart.qml
  examples/snippets/linechart.qml
  examples/snippets/minimal.qml
  examples/snippets/piechart.qml
  src/BarChart.cpp
  src/BarChart.h
  src/Chart.cpp
  src/Chart.h
  src/ChartsPlugin.cpp
  src/ChartsPlugin.h
  src/LineChart.cpp
  src/LineChart.h
  src/PieChart.cpp
  src/PieChart.h
  src/RangeGroup.cpp
  src/RangeGroup.h
  src/XYChart.cpp
  src/XYChart.h
  src/datasource/ArraySource.cpp
  src/datasource/ArraySource.h
  src/datasource/ChartAxisSource.cpp
  src/datasource/ChartAxisSource.h
  src/datasource/ChartDataSource.cpp
  src/datasource/ChartDataSource.h
  src/datasource/ColorGradientSource.cpp
  src/datasource/ColorGradientSource.h
  src/datasource/ModelHistorySource.cpp
  src/datasource/ModelHistorySource.h
  src/datasource/ModelSource.cpp
  src/datasource/ModelSource.h
  src/datasource/SingleValueSource.cpp
  src/datasource/SingleValueSource.h
  src/datasource/ValueHistorySource.cpp
  src/datasource/ValueHistorySource.h
  src/decorations/AxisLabels.cpp
  src/decorations/AxisLabels.h
  src/decorations/GridLines.cpp
  src/decorations/GridLines.h
  src/decorations/LegendModel.cpp
  src/decorations/LegendModel.h
  src/scenegraph/BarChartNode.cpp
  src/scenegraph/BarChartNode.h
  src/scenegraph/LineChartMaterial.cpp
  src/scenegraph/LineChartMaterial.h
  src/scenegraph/LineChartNode.cpp
  src/scenegraph/LineChartNode.h
  src/scenegraph/LineGridNode.cpp
  src/scenegraph/LineGridNode.h
  src/scenegraph/LineSegmentNode.cpp
  src/scenegraph/LineSegmentNode.h
  src/scenegraph/PieChartMaterial.cpp
  src/scenegraph/PieChartMaterial.h
  src/scenegraph/PieChartNode.cpp
  src/scenegraph/PieChartNode.h
  src/scenegraph/SDFShader.cpp
  src/scenegraph/SDFShader.h
  src/shaders/desktop_header.glsl
  src/shaders/desktop_header_core.glsl
  src/shaders/es_header.glsl
  src/shaders/linechart.frag
  src/shaders/linechart.vert
  src/shaders/linechart_core.frag
  src/shaders/linechart_core.vert
  src/shaders/piechart.frag
  src/shaders/piechart.vert
  src/shaders/piechart_core.frag
  src/shaders/piechart_core.vert
  src/shaders/sdf.frag
  src/shaders/sdf_core.frag
  src/shaders/uv.vert

To: cordlandwehr, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  So, how to move forward with this change? The two open discussion points are:
  
  - How to handle COPYING files? --> IMO this is a general question that I want 
to address in a global change when we updated all the license headers. For this 
I created a task to track this question: https://phabricator.kde.org/T12730
  - How to handle the unneeded empty lines in the license file? --> the license 
files must not be changed according to https://reuse.software/faq/, thus I 
created an upstream issue at SPDX 
(https://github.com/spdx/license-list-data/issues/60). but I am afraid that we 
have to wait for this issue to be fixed before we can update the license files 
on our side. Judging from experience, this will take quite some time and 
according to the REUSE guidelines we are doing everything correctly.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

[Ahmad Samir]

ahmadsamir added a comment.


  Konsole's workaroun: 
https://phabricator.kde.org/R319:41693fe9ee263f8f2281852a740ee52d55f003ef
  KTextEditor workaround: 
https://phabricator.kde.org/R39:4d91fa7e918d983e6569798dfe20c7c9faf4bb9e

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27735

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Andreas Cord-Landwehr]

cordlandwehr marked 3 inline comments as done.
cordlandwehr added a comment.


  Reverted license change for the XSD file. Right now I do not see any 
equivalent in the SPDX registry.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27601

To: cordlandwehr
Cc: ognarb, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 76675.
cordlandwehr added a comment.


  Reverting DTD license change

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27601?vs=76403=76675

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27601

AFFECTED FILES
  KF5ConfigMacros.cmake
  LICENSES/BSD-2-Clause.txt
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT.txt
  autotests/fallbackconfigresourcestest.cpp
  autotests/helper.h
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/kconfigcompiler_test.h
  autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp
  autotests/kconfig_compiler/klocalizedstring.h
  autotests/kconfig_compiler/test10main.cpp
  autotests/kconfig_compiler/test11_types.h
  autotests/kconfig_compiler/test11main.cpp
  autotests/kconfig_compiler/test12main.cpp
  autotests/kconfig_compiler/test13main.cpp
  autotests/kconfig_compiler/test1main.cpp
  autotests/kconfig_compiler/test2main.cpp
  autotests/kconfig_compiler/test3amain.cpp
  autotests/kconfig_compiler/test3main.cpp
  autotests/kconfig_compiler/test4main.cpp
  autotests/kconfig_compiler/test5main.cpp
  autotests/kconfig_compiler/test6main.cpp
  autotests/kconfig_compiler/test7main.cpp
  autotests/kconfig_compiler/test8main.cpp
  autotests/kconfig_compiler/test9main.cpp
  autotests/kconfig_compiler/test_dpointer_main.cpp
  autotests/kconfig_compiler/test_emptyentries_main.cpp
  autotests/kconfig_compiler/test_fileextensions_main.cxx
  autotests/kconfig_compiler/test_notifiers_main.cpp
  autotests/kconfig_compiler/test_qdebugcategorymain.cpp
  autotests/kconfig_compiler/test_signal_main.cpp
  autotests/kconfig_compiler/test_translation_kde_domain_main.cpp
  autotests/kconfig_compiler/test_translation_kde_main.cpp
  autotests/kconfig_compiler/test_translation_qt_main.cpp
  autotests/kconfigguitest.cpp
  autotests/kconfigguitest.h
  autotests/kconfigloadertest.cpp
  autotests/kconfigloadertest.h
  autotests/kconfignokdehometest.cpp
  autotests/kconfigskeletontest.cpp
  autotests/kconfigskeletontest.h
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  autotests/kentrymaptest.cpp
  autotests/kentrymaptest.h
  autotests/ksharedconfig_in_global_object.cpp
  autotests/ksharedconfigtest.cpp
  autotests/kstandardshortcuttest.cpp
  autotests/kstandardshortcuttest.h
  autotests/test_kconf_update.cpp
  autotests/test_kconf_update.h
  autotests/test_kconfigutils.cpp
  autotests/test_kconfigutils.h
  cmake/rules_PyKF5.py
  src/core/bufferfragment_p.h
  src/core/conversioncheck.h
  src/core/kauthorized.cpp
  src/core/kauthorized.h
  src/core/kconfig.cpp
  src/core/kconfig.h
  src/core/kconfig_p.h
  src/core/kconfigbackend.cpp
  src/core/kconfigbackend_p.h
  src/core/kconfigbase.cpp
  src/core/kconfigbase.h
  src/core/kconfigbase_p.h
  src/core/kconfigdata.cpp
  src/core/kconfigdata.h
  src/core/kconfiggroup.cpp
  src/core/kconfiggroup.h
  src/core/kconfiggroup_p.h
  src/core/kconfigini.cpp
  src/core/kconfigini_p.h
  src/core/kconfigwatcher.cpp
  src/core/kconfigwatcher.h
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h
  src/core/kemailsettings.cpp
  src/core/kemailsettings.h
  src/core/ksharedconfig.cpp
  src/core/ksharedconfig.h
  src/gui/kconfiggroupgui.cpp
  src/gui/kconfiggui.cpp
  src/gui/kconfiggui.h
  src/gui/kconfigloader.cpp
  src/gui/kconfigloader.h
  src/gui/kconfigloader_p.h
  src/gui/kconfigloaderhandler_p.h
  src/gui/kconfigskeleton.cpp
  src/gui/kconfigskeleton.h
  src/gui/kstandardshortcut.cpp
  src/gui/kstandardshortcut.h
  src/gui/kwindowconfig.cpp
  src/gui/kwindowconfig.h
  src/kconf_update/kconf_update.cpp
  src/kconf_update/kconfigutils.cpp
  src/kconf_update/kconfigutils.h
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigParameters.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd
  src/kconfig_compiler/kconfig_compiler.cpp
  src/kreadconfig/kreadconfig.cpp
  src/kreadconfig/kwriteconfig.cpp

To: cordlandwehr
Cc: ognarb, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  Ping! At least a reply would be nice

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27640: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Looks good to me and I agree that it is a good idea to consistently license 
everything as LGPL-2.1-or-later.
  My only question is, how is the X-KDE-PluginInfo-License value is evaluated? 
Are we free to write any value? Or do we have to extend some mechanism? I would 
be great to also use SPDX identifiers there!

INLINE COMMENTS

> metadata.desktop:96
>  X-KDE-PluginInfo-Depends=
> -X-KDE-PluginInfo-License=GPL
> +X-KDE-PluginInfo-License=LGPL-2.1-or-later
>  X-KDE-PluginInfo-EnabledByDefault=true

does this work with our PluginInfo mechanism? actually, I did not yet look into 
the SPDX license handling in desktop files or any other tooling for outbound 
licenses for libraries, plugins or applications; same question for the same 
changes below in the desktop files

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

[Ahmad Samir]

ahmadsamir added a comment.


  Some relevant info:
  
https://bugreports.qt.io/browse/QTBUG-63792?focusedCommentId=377225=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-377225
  https://codereview.qt-project.org/c/qt/qtbase/+/181645/

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27735

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, davidedmundson, cfeck, ervin.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  If the styleName property is set for a QFont, using setBold(true) would
  lead to Qt using an "emboldended"/synthetic font style instead of using
  the bold style provided by the font itself (usually as a standalone font
  file), the former looks ugly (IIUC, Freetype emboldens fonts as a last
  resort for fonts that don't provide a bold style at all).
  
  Accoring to upstream[1] the styleName property is useful for fonts with
  fancy style names, and also it shouldn't be set if it's not needed; and
  indeed using styleName with e.g. "Regular" doesn't make sense, as there
  is no "Regular Bold" style AFAICS.
  
  Checking for "Regular|Normal|Book|Roman" is based on examining the font
  styles provided by the font packages available on OpenSuse Tumbleweed ATM,
  and not checking for some of the weird/non-common ones e.g. I've seen "Roma"
  and "Rounded".
  
  For more details see:
  [1] https://bugreports.qt.io/browse/QTBUG-63792
  https://bugs.kde.org/show_bug.cgi?id=378523
  
  BUG: 378523
  
  FIXED-IN: 5.68

TEST PLAN
  All unit tests still pass.
  
  Changing the fonts via e.g. the fonts KCM doesn't append the font sytleName,
  to the relevant font config entry, if the "Regular" style or co. is used.
  
  A simple test, look at the current dir name in the Dolphin url bar with
  and without ",Regular" appended to the font= entry (assuming you're using
  Noto Sans or DejaVu Sans as the styleName varies from font to font).

REPOSITORY
  R237 KConfig

BRANCH
  l-font-sytleName (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27735

AFFECTED FILES
  src/gui/kconfiggroupgui.cpp

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

[Michel Ludwig]

mludwig added a comment.


  In D26342#619785 , @aacid wrote:
  
  > without having used Sonnet much, this seems the wrong API to me.
  >
  > Are you saying that it can happen that you tell Sonnet "use this language" 
and it goes and say "nah i'll ignore you and do my thing".
  
  
  Yep, that's right, and it won't even tell you which language it has detected. 
When the autodetection feature was introduced, it fundamentally changed the 
behaviour of Sonnet, breaking KatePart's spell checking in the process.
  
  > It seems to me that what would make sense is that the "use this language" 
is what sets autoDetectLanguageDisabled to false, or at least the function that 
should get a new overload saying setLanguage(¿qstring? language, bool 
disableAutoDetection) if we want to be sure not to change existing behaviour
  
  Ideally, the autodetection feature should be redesigned as it is only usable 
for simple text fields in its current form. KatePart requires a more 
sophisticated way of detecting languages(s).

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26342: Allow overriding to disable auto language detection

[Albert Astals Cid]

aacid added a comment.


  without having used Sonnet much, this seems the wrong API to me.
  
  Are you saying that it can happen that you tell Sonnet "use this language" 
and it goes and say "nah i'll ignore you and do my thing".
  
  It seems to me that what would make sense is that the "use this language" is 
what sets autoDetectLanguageDisabled to false, or at least the function that 
should get a new overload saying setLanguage(¿qstring? language, bool 
disableAutoDetection) if we want to be sure not to change existing behaviour

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns