D28195: Avoid double fetch and temporary hex encoding for NTFS attributes

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Dolphin, dfaure.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  The attrib is a DWORD (32 bit unsigned int) in the Windows APIs (see
  WIN32_FILE_ATTRIBUTE_DATA), and exported as a 4 byte array by ntfs-3g.
  As the size is known, there is no need to query it. As each file has
  the "archive" flag set on creation, i.e. the first getxattr call typically
  never returns 0, this cuts the number of syscalls by half.
  
  Skip the temporary hex encoding of the value, it is pointless to hex-
  encode the value and immediately after parse it again.

TEST PLAN
  1. touch foo
  2. getfattr -n system.ntfs_attrib_be -e hex foo
  3. dolphin ./
  4. setfattr -n system.ntfs_attrib_be -v 0x0022
  5. refresh dolphin

REPOSITORY
  R241 KIO

BRANCH
  ntfs_hidden

REVISION DETAIL
  https://phabricator.kde.org/D28195

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: bruns, #dolphin, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  OK.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28079

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28189: karchivetest: avoid interference from kdebugsettings

[David Faure]

dfaure added a comment.


  Can't see what's weird about that. Logging config comes from a config file 
stored in QStandardPaths::GenericConfigLocation, seems pretty reasonable to me.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D28189

To: dfaure, apol, sandsmark
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[David Edmundson]

davidedmundson added a comment.


  I've done a code review, they need following up regardless.
  
  ---
  
  As you saw in the bug report I don't like the feature, and I'm against it. 
Though I can't veto changes.
  
  Repeating myself on bugzilla.
  
  The two things I really hate as justifications for doing anything are  
"windows does it" or "many users want". It's our job to do thinking and provide 
something that's actually better.
  
  This little menu was one of the first things I saw when I first used 
Konqueror and I remember it being one of the things that made me love KDE. 
  It's excellent thought through usability, drag and drop is inherently 
ambiguous. For something so important, always prompting is always safe. It's 
consistent and not pseudo-random and the little UI follows fitt's law and is 
scarcely slower. I'm aware this is an option, but IMHO an option for something 
bad.

INLINE COMMENTS

> dropjob.cpp:366
> +// if the default behavior has been changed to MoveAction
> +const KConfigGroup g = 
> KConfigGroup(KSharedConfig::openConfig(QStringLiteral("kdeglobals")), 
> QStringLiteral("KDE"));
> +if (g.readEntry("dndToMove", false)) {

there's no need to reopen kdelgobals

Use KSharedConfig::openConfig()

and due to the magic of cascading it will include kdeglobals

> dropjob.cpp:286
> +
> +QStorageInfo sourceStorage;
> +QStorageInfo destStorage(m_destUrl.path());

Why QStorageInfo? We're in kio. There's a KMountPoint which is similar

I suspect this is a recursive list up the tree resolving symlinks. This will 
mean blocking stat calls, so this somewhat undermines a lot of the recent work 
in that field.

> dropjob.cpp:287
> +QStorageInfo sourceStorage;
> +QStorageInfo destStorage(m_destUrl.path());
> +

If destination is a symlink on the same partition but that symlink points to 
another partition what happens?

I haven't checked myself, but if we are doing this I need us to be super super 
sure.

> dropjob.cpp:309
> +sourceStorage.setPath(url.path());
> +if (sourceStorage.device() != destStorage.device()) {
> +allItemsAreSameDevice = false;

This will trigger when both storage devices are invalid, which isn't what we 
want.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D14707: autotests: skip '/' fstab check with zfs

[David Faure]

dfaure added a comment.


  Yep, that's exactly what I see in the output from kmountpointtest. One entry 
for swap, but no entry for "/".
  So any file on the filesystem doesn't look like it comes from a partition 
that was mounted at boot time.
  
  In other words it looks like everything is from a USB key or CD -- which 
means no monitoring for changes, since that would prevent ejecting the USB key 
or CD. Therefore all tests that test for the monitoring features failed.
  
  Now I make it skip the swap entry, so there's nothing left ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14707

To: dfaure, adridg
Cc: bcooksley, bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D27741: KCodecs: Convert license statements to SPDX expressions

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> Big5Freq.tab:3
>  /*  -*- C++ -*-
> -*  Copyright (C) 1998 
> -*
> -*
> -*  Permission is hereby granted, free of charge, to any person obtaining
> -*  a copy of this software and associated documentation files (the
> -*  "Software"), to deal in the Software without restriction, including
> -*  without limitation the rights to use, copy, modify, merge, publish,
> -*  distribute, sublicense, and/or sell copies of the Software, and to
> -*  permit persons to whom the Software is furnished to do so, subject to
> -*  the following conditions:
> -*
> -*  The above copyright notice and this permission notice shall be included 
> -*  in all copies or substantial portions of the Software.
> -*
> -*  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> -*  EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> -*  MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> -*  NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
> -*  LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
> -*  OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
> -*  WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> +SPDX-FileCopyrightText: 1998 
> +

You added "Netscape Communications Corporation" on other files but not this 
one. (IMO, you shouldn't, Netscape is explicitly mentioned only in 
src/probers/nsSJISProber.h)

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D27741

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R237 KConfig

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27601

To: cordlandwehr, cgiboudeaux
Cc: ognarb, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27738: KCoreAddons: Convert license statements to SPDX expressions

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> kshareddatacache.cpp:11
> +placed in the public domain. See http://sites.google.com/site/murmurhash/
> +SPDX-License-Identifier: CC0-1.0
> +*/

Why?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D27738

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D27245#619834 , @cordlandwehr 
wrote:
  
  > So, how to move forward with this change? The two open discussion points 
are:
  >
  > - How to handle COPYING files? --> IMO this is a general question that I 
want to address in a global change when we updated all the license headers. For 
this I created a task to track this question: https://phabricator.kde.org/T12730
  
  
  IMO, duplicating the license files is not necessary as long as there are no 
file refering to COPYING.LIB. This could be done now.
  
  > - How to handle the unneeded empty lines in the license file? --> the 
license files must not be changed according to https://reuse.software/faq/, 
thus I created an upstream issue at SPDX 
(https://github.com/spdx/license-list-data/issues/60). but I am afraid that we 
have to wait for this issue to be fixed before we can update the license files 
on our side. Judging from experience, this will take quite some time and 
according to the REUSE guidelines we are doing everything correctly.
  
  Let's keep them until https://github.com/spdx/LicenseListPublisher/issues/61 
is fixed.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27428: KItemViews: Convert license statements to SPDX expressions

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R276 KItemViews

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27428

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27742: Solid: Convert license headers to SPDX expressions

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R245 Solid

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27742

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27429: ThreadWeaver: Convert license headers to SPDX expressions

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM

INLINE COMMENTS

> main.cpp:1
> -#include 
> +#include 
>  

I don't see what changed here. looks unrelated to this PR

REPOSITORY
  R279 ThreadWeaver

BRANCH
  spdxHeaders

REVISION DETAIL
  https://phabricator.kde.org/D27429

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, mirko, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D14707: autotests: skip '/' fstab check with zfs

[Ben Cooksley]

bcooksley added a comment.


  That is strange - as our FreeBSD Builders definitely have an /etc/fstab file:
  
root@FreeBSDBuilderIota:~ # cat /etc/fstab 
# DeviceMountpoint  FStype  Options Dump
Pass#
/dev/vtbd0p2noneswapsw  0   0
  
  I've checked and the file is definitely world-readable - and is the same on 
all three builders.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14707

To: dfaure, adridg
Cc: bcooksley, bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, cfeck, apol, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Minor optimisation by instantiating one QFontDatabase Object, and using
  it in KFontChooser::Private members.

TEST PLAN
  KFontChooser still works in Kate

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28193

AFFECTED FILES
  src/kfontchooser.cpp

To: ahmadsamir, #frameworks, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28189: karchivetest: avoid interference from kdebugsettings

[David Faure]

dfaure closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D28189

To: dfaure, apol, sandsmark
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, cfeck, apol, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Use new connect syntax
  - Prefix increment where appropriate
  - Replace foreach/iterator-based for with range-for
  - Remove (really) old TODOs

TEST PLAN
  make && ctest
  KFontChooser in e.g. Kate still loads and works as before

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28189: karchivetest: avoid interference from kdebugsettings

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense. It's weird that this needs doing through QStandardPaths but it's 
not something we can address here.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28189

To: dfaure, apol, sandsmark
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFilesJob

[David Faure]

dfaure added a comment.


  The test fails on FreeBSD, in CI.
  
  
https://build.kde.org/job/Frameworks/view/Platform%20-%20FreeBSDQt5.13/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/118/testReport/junit/projectroot/autotests/klistopenfilesjobtest_unix/
  
  Any plans for fixing it, or should I mark it as expected failure?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/80/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 18:36:22 +
 Build duration:
1 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

[David Faure]

dfaure updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T12173

To: dfaure
Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, 
ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck, 
cgiboudeaux, cullmann, vkrause, cordlandwehr, knauss

D14707: autotests: skip '/' fstab check with zfs

[David Faure]

dfaure abandoned this revision.
dfaure added a comment.


  So, this patch is wrong, and I just disabled that part of kmountpointtest on 
FreeBSD 
(https://cgit.kde.org/kio.git/commit/?id=e1ef54531ecf7dc9966860dce890201aa100c240)
  
  The fact that KMountPoint sees no mountpoints on the FreeBSD CI (because it 
has no /etc/fstab) is the reason why kdirlistertest fails: it thinks the 
partition is "manually mounted" (like a USB key) since it's not in /etc/fstab. 
For that reason, kdirlister doesn't watch the partition for changes, which the 
test relies on.
  
  OK, fixed by skipping "swap" in kmountpoint 
(https://cgit.kde.org/kio.git/commit/?id=a84f65262354aa55e67ed136a0fb0517e91aba11),
 and kdirlister then skips the logic of manually-mounted when there's no 
mountpoint at all.
  
  
https://build.kde.org/job/Frameworks/view/Platform%20-%20FreeBSDQt5.13/job/kio/job/kf5-qt5%20FreeBSDQt5.13/
 is green for the first time in history. \o/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14707

To: dfaure, adridg
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 76 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/76/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 18:02:20 +
 Build duration:
8 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 47 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27695/32728)53%
(11159/20995)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12599/12674)50%
(6635/13169)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6344/7479)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8153/9774)63%
(2455/3891)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D27910: Make sure warning output is enabled before testing if the correct warning is printed

[David Faure]

dfaure added a comment.


  Note that in both cases the env var QT_LOGGING_RULES would break the unittest 
anyway... so yeah it's only about qtlogging.ini which we can easily skip with 
test mode.
  
  Here's my suggested fix: D28189 
  
  @apol Warnings are enabled by default, for all categories, the way we define 
them.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27910

To: sandsmark, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28189: karchivetest: avoid interference from kdebugsettings

[David Faure]

dfaure created this revision.
dfaure added reviewers: apol, sandsmark.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  NO_CHANGELOG

TEST PLAN
  test still passes

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28189

AFFECTED FILES
  autotests/karchivetest.cpp

To: dfaure, apol, sandsmark
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 349 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/349/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 18:00:06 +
 Build duration:
7 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 348 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/348/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 17:13:12 +
 Build duration:
6 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28188: breeze-icons autotests: skip symlinks in the builddir

[David Faure]

dfaure created this revision.
dfaure added reviewers: sitter, bshah, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  It's ok for symlinks in the builddir to be broken.
  We can't (easily) detect that they actually point to something that will
  exist after make install.
  
  With a typical kdesrc-build setup the test passed because it ignored the
  builddir (which is outside the srcdir) completely.
  
  In CI however the builddir is a subdir, so the recursive directory
  traversal in the unittest ends up there...

TEST PLAN
  bin/symlink works again. I created a broken symlink in the srcdir, it 
detected it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28188

AFFECTED FILES
  autotests/symlinktest.cpp

To: dfaure, sitter, bshah, lbeltrame
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27614: build: fix the build where install prefix is not user-writable

[David Faure]

dfaure added a comment.


  Nobody cares about broken CI, or my comment here wasn't noticed, so I fixed 
it myself. https://phabricator.kde.org/D28188

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27614

To: bshah, ngraham, lbeltrame, sitter
Cc: dfaure, sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 347 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/347/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 16:36:50 +
 Build duration:
7 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 480 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/480/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 16:36:50 +
 Build duration:
7 min 20 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35188/62425)40%
(17729/43878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(9946/10415)47%
(4587/9798)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8753/14650)51%
(4527/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  Idea: instead of allowing a context menu to be defined, we require that the 
contextual actions always be defined as actions and appear in the expanded 
view. Then, we make the expanded view contain a tab view and put the contextual 
actions into one tab, hiding the tab bar when there's only one tab, and 
allowing additional tabs to be defined. With this, you wouldn't define a whole 
separate custom expanded view; you would define additional tabs to put in the 
tabbed view. This would allow us to remove the context menu to make the 
contextual actions discoverable and touch-friendly even in more complex 
delegates where you want contextual actions as well as some kind of custom view.
  
  Thoughts?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 78177.
ngraham added a comment.


  Fix documentation formatting

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=78104=78177

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1d644f8f2eb5: GIT_SILENT kpasswdserver, break long lines 
for readability; add braces around if (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28186?vs=78171=78176

REVISION DETAIL
  https://phabricator.kde.org/D28186

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

[Ahmad Samir]

ahmadsamir added a comment.


  In D28186#631962 , @dfaure wrote:
  
  > Nice.
  >
  > clang-format can't be configured to add missing braces,
  
  
  Nope, I'd have had to use clang-format (which requires a "compilation 
server", I read some docs, searched online, tried, then read more docs; found 
that it took me about half an hour and I still couldn't get it to work (it 
replaced all of two occurrences and then barfed), I realised it would have 
taken me 10 minutes to do it by hand, and get on with what's left of my life, 
which is what I did).
  
  > and to have a max line length?
  
  I used a .clang-format copied from clang-format.cmake from 
extra-cmake-modules, which has "ColumnLimit: 240", but that apparently leads to 
really long lines... why I didn't tweak the number? I forgot :D

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver-long-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28186

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28187: KIO DesktopExecParser: simplify code

[David Faure]

dfaure created this revision.
dfaure added reviewers: ahmadsamir, feverfew, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  - Remove special case for hasSchemeHandler, it's just a hack.
  
  When starting a service that handles a specific scheme, we know it
  supports that URL (supportedProtocols returns it).
  
  - Instead, the broken logic was that if we are in the special case
  
  "username set, no password", which forces a FUSE request *even* for a
  supported protocol, and that FUSE request fails, then we don't want to
  fallback to kioexec. Using the service directly works just fine.
  
  - Merge the two for() loops. The first one is "no %u, so only local
  
  files are supported", easy to model in the condition for the bool
  'supported'.
  
  - If we do proceed without kioexec after a fuse error, recheck
  
  request.reply.isError otherwise we end up replacing a URL with a DBus
  error message :-)
  
  - Even further optimization: skip the FUSE request for the case of
  
  a scheme-handler with username. For local, KIO, scheme-handlers,
  supported means supported. The hack is only for the other case:
  explicitly listed protocols with X-KDE-Protocols like in vlc.desktop

TEST PLAN
  krununittest (which unfortunately doesn't cover all cases),
  plus stepping with gdb to see if we make a FUSE request.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28187

AFFECTED FILES
  src/core/desktopexecparser.cpp

To: dfaure, ahmadsamir, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 479 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/479/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 16:09:23 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35139/62389)40%
(17705/43878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(9946/10415)47%
(4598/9798)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8748/14648)51%
(4512/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)53%
(683/1294)38%
(392/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 346 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/346/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 16:09:23 +
 Build duration:
7 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28184

To: dfaure, meven, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D21902: Calendar: add method to show event details

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Nice.
  
  clang-format can't be configured to add missing braces, and to have a max 
line length?

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver-long-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28186

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

[David Faure]

dfaure added a comment.


  They are not the same.
  
  (3,4)
  vs
  (2,4)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28184

To: dfaure, meven, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I confirm that the test gets fixed.
  Also the change makes sense.
  
  It seems to me that both else branches end the same. From `list = ...` it can 
be moved out, no?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28184

To: dfaure, meven, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78171.
ahmadsamir retitled this revision from "GIT_SILENT break long lines for 
readability; add braces around if" to "GIT_SILENT kpasswdserver, break long 
lines for readability; add braces around if".
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28186?vs=78170=78171

BRANCH
  l-kpasswdserver-long-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28186

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28186: GIT_SILENT break long lines for readability; add braces around if

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  The code still compiles.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver-long-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28186

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[David Faure]

dfaure added a comment.


  In D28169#631893 , @ahmadsamir 
wrote:
  
  > Yesterday, I did try tweaking XDG_DATA_DIRS to make it find the .desktop 
file without it being in /usr/share/applications
  
  
  It's more portable to use QStandardPaths test mode and copy the file where 
QStandardPaths will expect it.
  XDG_DATA_DIRS wouldn't work on macOS or Windows.
  
  > but I didn't think that it'd take time for ksyscoca to pick it up (or even 
that ksycoca was involved, though in retrospect that makes sense).
  
  KMimeTypeTrader is all about querying ksycoca.
  
  > - I still think the workaround for vlc should be tightened, with e.g. 
checking for .desktop file name
  
  I don't think this is VLC specific at all.
  xine or mplayer or other non-KIO-based apps would have the exact same 
problem. They can't get hold of the password.
  Anyhow, to be discussed with the FUSE people if I'm missing something. As you 
probably know, I'm not involved in the FUSE stuff.
  
  > - Currently the code calls hasSchemeHandler() twice, once from KRun::init() 
and then in resultingArguments(); also for 
KMimeTypeTrader::self()->preferredService(), it's called from KRun 
schemeService() and from hasSchemeHandler() (the latter is used twice so, 
preferredService() is called three times :D)
  
  Interesting point.
  Checking hasSchemeHandler in both KRun and inside the implementation 
ProcessLauncherJob makes sense to me. It's two different layers of public API; 
passing information between the two would make for horrible API.
  In KRun it allows us to say ok, we don't need to find the mimetype, go 
straight to running the associated service.
  In KProcessRunner (used by ProcessLauncherJob), it's indeed a bit stupid to 
look up the associated service when we *are* running this service. Oh, 
especially since KIO::DesktopExecParser::supportedProtocols already grabs those 
protocols from the MimeType... So `supported` is true. Then what? why? 
Debugging further OK I see. The earlier comment I deleted is true again. 
ssh://root@ has username, so this makes the fuse request, fails, and then 
blindly sets useKioexec = true for no good reason. I'll fix that logic. And 
then we can remove the unneeded hasSchemeHandler() hack.
  
  Thanks for making me dig further ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

[David Faure]

dfaure created this revision.
dfaure added a reviewer: meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  It failed for me, and for FreeBSD on CI.
  I guess the Linux CI has it all on the same partition, so the moving
  across partition case isn't really tested there.
  
  See explanations in the code comment.

TEST PLAN
  Now jobtest passes locally

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28184

AFFECTED FILES
  autotests/jobtest.cpp

To: dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 345 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/345/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 14:46:12 +
 Build duration:
6 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  In D28169#631885 , @dfaure wrote:
  
  > OK, it's fixed now, after 3 commits :-)
  >  You can drop this change, it's better that CI actually tests the code.
  
  
  [..]
  Yesterday, I did try tweaking XDG_DATA_DIRS to make it find the .desktop file 
without it being in /usr/share/applications, but I didn't think that it'd take 
time for ksyscoca to pick it up (or even that ksycoca was involved, though in 
retrospect that makes sense).
  
  However, a couple of points that are still bothering me (consider them food 
for thought):
  
  - I still think the workaround for vlc should be tightened, with e.g. 
checking for .desktop file name
  - Currently the code calls hasSchemeHandler() twice, once from KRun::init() 
and then in resultingArguments(); also for 
KMimeTypeTrader::self()->preferredService(), it's called from KRun 
schemeService() and from hasSchemeHandler() (the latter is used twice so, 
preferredService() is called three times :D)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[David Faure]

dfaure added a comment.


  OK, it's fixed now, after 3 commits :-)
  You can drop this change, it's better that CI actually tests the code.
  Thanks for your help though (with this, and with everything else - very much 
appreciated)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 477 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/477/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 13:59:33 +
 Build duration:
5 min 35 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35164/62384)40%
(17722/43866)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9946/10409)47%
(4585/9786)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8753/14650)51%
(4521/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 344 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/344/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 13:57:46 +
 Build duration:
5 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 353 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/353/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 13:56:44 +
 Build duration:
5 min 31 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35161/62385)40%
(17718/43862)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9946/10409)47%
(4587/9786)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8753/14650)51%
(4522/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2076/4812)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4286)36%
(1300/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 476 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/476/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 13:51:12 +
 Build duration:
8 min 19 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35140/62383)40%
(17704/43866)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(9935/10408)47%
(4579/9786)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8740/14650)51%
(4510/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 343 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/343/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 13:51:12 +
 Build duration:
6 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 352 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/352/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 13:51:12 +
 Build duration:
5 min 30 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35135/62383)40%
(17702/43862)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(9935/10408)47%
(4577/9786)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8740/14650)51%
(4509/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2076/4812)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4286)36%
(1311/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D27950: Assign an icon to action submenus

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3f69e6401e44: Assign an icon to action submenus (authored 
by apol).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27950?vs=77295=78164

REVISION DETAIL
  https://phabricator.kde.org/D27950

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: apol, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 475 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/475/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 13:01:51 +
 Build duration:
8 min 55 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35140/62382)40%
(17705/43866)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(9935/10408)47%
(4577/9786)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8740/14650)51%
(4514/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 342 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/342/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 13:01:51 +
 Build duration:
7 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 351 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/351/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 13:01:51 +
 Build duration:
6 min 6 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35135/62382)40%
(17698/43862)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(9935/10408)47%
(4575/9786)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8730/14649)51%
(4505/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2076/4812)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 95 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/95/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 13:03:36 +
 Build duration:
3 min 8 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.69.0.xmllogs/KF5Parts/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)48%
(26/54)48%
(26/54)27%
(791/2949)15%
(225/1453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)92%
(262/286)47%
(83/178)src51%
(22/43)51%
(22/43)23%
(529/2349)12%
(142/1189)tests0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/86)

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 73 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/73/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 13:03:36 +
 Build duration:
2 min 43 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.69.0.xmllogs/KF5Parts/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)48%
(26/54)48%
(26/54)27%
(791/2949)15%
(225/1453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)92%
(262/286)47%
(83/178)src51%
(22/43)51%
(22/43)23%
(529/2349)12%
(142/1189)tests0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/86)

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a comment.


  Ping? :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25301

REVISION DETAIL
  https://phabricator.kde.org/D25301

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

[Méven Car]

meven updated this revision to Diff 78159.
meven marked 3 inline comments as done.
meven added a comment.


  Add 3 missing static

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25301?vs=78141=78159

BRANCH
  arcpatch-D25301

REVISION DETAIL
  https://phabricator.kde.org/D25301

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 474 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/474/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 12:27:21 +
 Build duration:
8 min 54 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35163/62378)40%
(17735/43858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9941/10404)47%
(4580/9778)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8757/14650)51%
(4540/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[David Faure]

dfaure added a comment.


  The bug is that, after the fuse dbus call fails, we can't just blindly go to 
kioexec. It depends on `supported`. ktelnetservice supports ssh, so we don't 
need kioexec. Will rework...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 350 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/350/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 12:27:21 +
 Build duration:
6 min 35 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35170/62379)40%
(17733/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9941/10404)47%
(4576/9778)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8759/14650)51%
(4538/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2076/4812)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 341 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/341/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 12:27:21 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[David Faure]

dfaure added a comment.


  In D28169#631841 , @ahmadsamir 
wrote:
  
  > In D28169#631809 , @dfaure wrote:
  >
  > > Ah, we had tried already to make it work uninstalled.
  > >
  > > The actual way to do that would be to copy that desktop file into a local 
ApplicationsLocation. I'll do that, I just did something similar in KParts.
  >
  >
  > That ApplicationsLocation will be on the CI system?
  
  
  Yes, in ~/.qttest/share/applications
  See https://commits.kde.org/kio/b60aae15eaf97bc921fb7ad3a2068448f303055f
  But it still fails, I'm trying to debug why.
  
  Can't reproduce it locally even after uninstaling kio and all 
ktelnetservice*.desktop from /usr, so the problem is something else...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28097: GIT_SILENT clang-format kpasswdserver.*

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:66837e4c049d: GIT_SILENT clang-format kpasswdserver.* 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28097?vs=78157=78158

REVISION DETAIL
  https://phabricator.kde.org/D28097

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kiod_kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.h

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28097: GIT_SILENT clang-format kpasswdserver.*

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78157.
ahmadsamir added a comment.


  Rebase on master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28097?vs=78155=78157

BRANCH
  l-kpasswdserver-clang-format (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28097

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kiod_kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.h

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[Ahmad Samir]

ahmadsamir added a comment.


  In D28169#631809 , @dfaure wrote:
  
  > Ah, we had tried already to make it work uninstalled.
  >
  > The actual way to do that would be to copy that desktop file into a local 
ApplicationsLocation. I'll do that, I just did something similar in KParts.
  
  
  That ApplicationsLocation will be on the CI system?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78156.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28169?vs=78152=78156

BRANCH
  l-krun-ssh-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28169

AFFECTED FILES
  autotests/krununittest.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 340 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/340/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 12:07:11 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28097: GIT_SILENT clang-format kpasswdserver.*

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks. Let's do manual changes separately :-)

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver-clang-format (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28097

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28097: GIT_SILENT clang-format kpasswdserver.*

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78155.
ahmadsamir retitled this revision from "GIT_SILENT clang-format kpasswdserver.* 
plus some manual changes" to "GIT_SILENT clang-format kpasswdserver.*".
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28097?vs=78154=78155

BRANCH
  l-kpasswdserver-clang-format (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28097

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kiod_kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.h

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 473 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/473/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 12:07:11 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35198/62419)40%
(17729/43858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9941/10404)47%
(4574/9778)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8756/14650)51%
(4535/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78154.
ahmadsamir added a comment.


  clang-format only, less prone to errors, as the level of stupidity of the 
tool is locked at the compile time of the tool (unlike manual changes)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28097?vs=77816=78154

BRANCH
  l-kpasswdserver-clang-format (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28097

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kiod_kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.cpp
  src/kpasswdserver/kpasswdserver.h

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 349 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/349/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 12:07:11 +
 Build duration:
8 min 51 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35197/62418)40%
(17737/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9941/10404)47%
(4584/9778)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8760/14650)51%
(4539/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2076/4812)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78153.
ahmadsamir added a comment.


  Tweak docs

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28122?vs=78124=78153

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

AFFECTED FILES
  docs/pics/kfontchooserdialog.png
  src/CMakeLists.txt
  src/kfontchooserdialog.cpp
  src/kfontchooserdialog.h
  tests/CMakeLists.txt
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kparts » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20FreeBSDQt5.13/67/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 11:50:16 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[David Faure]

dfaure added a comment.


  Ah, we had tried already to make it work uninstalled.
  
  The actual way to do that would be to copy that desktop file into a local 
ApplicationsLocation. I'll do that, I just did something similar in KParts.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: KIO: try to assign an icon to action submenus

[David Faure]

On dimanche 15 mars 2020 19:11:39 CET Chloe Kudryavtsev wrote:
> So we need to be able to pass an icon inside of a ServiceList.
> As mentioned, ServiceList is a QList.
> QList is part of Qt and KServiceAction is part of KService.

The usual solution for this is to replace ServiceList with 
struct SubMenu
{
QList actions;
QIcon icon;
};
in the code that is about a submenu, like in insertServicesSubmenus.

But I see what you mean, submenus are an aggregation of independent actions 
who belong to the same priority (as selected by selectList()), so there's no 
single definition for those submenus, where we would be able to set an icon.

C++ problems can be fixed, but not conceptual ones like the one above.
I'm dropping my objections.
https://phabricator.kde.org/D27950 approved.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D27950: Assign an icon to action submenus

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27950

To: apol, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/94/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 11:50:16 +
 Build duration:
3 min 18 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.69.0.xmllogs/KF5Parts/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.partloadertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)37%
(20/54)37%
(20/54)21%
(622/2941)13%
(182/1453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)71%
(201/283)38%
(68/178)src40%
(17/43)40%
(17/43)18%
(421/2344)10%
(114/1189)tests0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/86)

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.14/14/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 21 Mar 2020 11:50:15 +
 Build duration:
2 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/72/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 11:50:15 +
 Build duration:
2 min 2 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.69.0.xmllogs/KF5Parts/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.partloadertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)37%
(20/54)37%
(20/54)21%
(622/2941)13%
(182/1453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)71%
(201/283)38%
(68/178)src40%
(17/43)40%
(17/43)18%
(421/2344)10%
(114/1189)tests0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/86)

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78152.
ahmadsamir retitled this revision from "[DesktopExecParser] Let the service 
open protocols is claims to support" to "[krununittest] Skip the test if 
ktelnetservice5{,.desktop} isn't found".
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Just fix unittest

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28169?vs=78120=78152

BRANCH
  l-krun-ssh-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28169

AFFECTED FILES
  autotests/krununittest.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> file_unix.cpp:147
> +
> +QString getUserName(KUserId uid)
> +{

static

> file_unix.cpp:164
> +
> +QString getGroupName(KGroupId gid)
> +{

static

> file_unix.cpp:248
> +
> +bool createUDSEntry(const QString , const QByteArray , 
> UDSEntry ,
> +  KIO::StatDetails details)

static

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25301

REVISION DETAIL
  https://phabricator.kde.org/D25301

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27936: Windows: Add suport for file date creation

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27936

To: meven, #frameworks, elvisangelaccio, #windows, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I would prefer a unittest based on public API, showing the actual bug (before 
the fix) with kdeglobals and a local config file.

INLINE COMMENTS

> kconfigdata.h:76
> +/**
> + * Entry will need to be wrote on a not global file even if it match 
> default value
> + */

s/wrote/written/
s/match/matches/

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27760: WIP | Added BatchMoveJob

[David Faure]

dfaure added a comment.


  Looks good, just a few things.

INLINE COMMENTS

> batchmovejobtest.cpp:91
> +job->setUiDelegate(nullptr);
> +QSignalSpy spy(job, SIGNAL(fileMoved(QUrl, QUrl)));
> +

Use newer syntax ::BatchMoveJob::fileMoved?

> batchmovejobtest.cpp:104
> +{
> +//m_homeDir.removeRecursively();
> +}

This reads really scary! :-)

Can you rename the var to what it is, like m_homeTmpDir?

And this can be re-enabled, no?

Alternatively, use QTemporaryDir, it cleans up automatically.

> batchmovejob.cpp:104
> +emit fileMoved(d->m_listIterator->from, d->m_listIterator->to);
> +d->m_listIterator++;
> +emitPercent(d->m_listIterator - d->m_items.constBegin(), 
> d->m_items.count());

prefer prefix increment (++ in front)

> batchmovejob.h:37
> +
> +BatchMoveJobItem()
> +{

Where is this ctor needed?

Both could just be removed, then you can use aggregate initialization with {}

> batchmovejob.h:50
> + *
> + * A KIO job to move multiple files simoultaneousoly
> + *

typo: simultaneously

(bulk purchase of the 'o' letter?) :)

> batchmovejob.h:52
> + *
> + * @since 5.67
> + */

5.69

> fileundomanager.h:140
> + * 
> + * BatchMove: @since 5.67 KIO::batchMoveJob. Used when moving multiple 
> files in a single job
>   */

5.69

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27760

To: emateli, dfaure, ngraham
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27883: Register spawned applications as an independent cgroups

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kprocessrunner.cpp:292
> +
> +QDBusMessage message = 
> QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"),
> +   
> QStringLiteral("/org/freedesktop/systemd1"),

The code in this method should be in some #ifdef UNIX and not MAC, right?
Pretty pointless to make this DBus call on Windows ;)

> kprocessrunner.cpp:301
> +
> +QList pidList = {static_cast(m_process->pid())};
> +

(this is what made me think about Windows, where pid is a 64bit value).

> kprocessrunner.cpp:308
> +message.setArguments({name, mode, QVariant::fromValue(properties), 
> QVariant::fromValue(aux)});
> +QDBusPendingCall reply = 
> QDBusConnection::sessionBus().asyncCall(message);
> +}

And then? if we don't care about the async reply, maybe you should remove the 
left part of the equal sign?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kpasswdserver.cpp:249
>  #ifdef HAVE_KF5WALLET
> -if (!result &&
> -!m_walletDisabled &&
> -(info.username.isEmpty() || info.password.isEmpty()) &&
> -
> !KWallet::Wallet::keyDoesNotExist(KWallet::Wallet::NetworkWallet(),
> -  
> KWallet::Wallet::PasswordFolder(),
> -  makeWalletKey(key, 
> info.realmValue)))
> -{
> +const bool keyExists = 
> !KWallet::Wallet::keyDoesNotExist(KWallet::Wallet::NetworkWallet(), 
> KWallet::Wallet::PasswordFolder(), makeWalletKey(key, info.realmValue));
> +if (!result

This didn't use to be called when m_walletDisabled is true.

Make it a lambda if you want to simplify the if() condition while still 
preserving evaluation order?

Or better: let's not change code in a "reformatting" commit...  It's too 
dangerous. I could have missed this. Reviewing reformatting from a tool and 
reviewing changes made by a human are two different kinds of reviews :-)

> kpasswdserver.cpp:309
>  #ifdef HAVE_KF5WALLET
> -if (!result &&
> -!m_walletDisabled &&
> -(info.username.isEmpty() || info.password.isEmpty()) &&
> -
> !KWallet::Wallet::keyDoesNotExist(KWallet::Wallet::NetworkWallet(),
> -  
> KWallet::Wallet::PasswordFolder(),
> -  makeWalletKey(key, 
> info.realmValue)))
> -{
> +const bool keyExists = 
> !KWallet::Wallet::keyDoesNotExist(KWallet::Wallet::NetworkWallet(), 
> KWallet::Wallet::PasswordFolder(), makeWalletKey(key, info.realmValue));
> +if (!result

same

> kpasswdserver.cpp:748
>  const bool bypassCacheAndKWallet = 
> info.getExtraField(AUTHINFO_EXTRAFIELD_BYPASS_CACHE_AND_KWALLET).toBool();
> -if ( !bypassCacheAndKWallet
> -&& ( username.isEmpty() || password.isEmpty() )
> +const bool keyExists = 
> !KWallet::Wallet::keyDoesNotExist(KWallet::Wallet::NetworkWallet(),
> + 
> KWallet::Wallet::PasswordFolder(),

same

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28097

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

[David Faure]

dfaure added a comment.


  I wrote QMimeDatabase, and my only intent was to move the main glob to be 
first. Not to prevent people from removing it. So this is a Qt bug.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28079

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Frameworks » kparts » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20FreeBSDQt5.13/66/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 10:00:23 +
 Build duration:
4 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.partloadertest

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 71 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/71/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 10:00:23 +
 Build duration:
3 min 15 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.69.0.xmllogs/KF5Parts/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.partloadertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)37%
(20/54)37%
(20/54)21%
(610/2934)12%
(181/1453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)68%
(189/276)38%
(67/178)src40%
(17/43)40%
(17/43)18%
(421/2344)10%
(114/1189)tests0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/86)

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 93 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/93/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Mar 2020 10:00:23 +
 Build duration:
2 min 26 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.69.0.xmllogs/KF5Parts/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.partloadertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)37%
(20/54)37%
(20/54)21%
(610/2934)12%
(181/1453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)68%
(189/276)38%
(67/178)src40%
(17/43)40%
(17/43)18%
(421/2344)10%
(114/1189)tests0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/86)

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.14/13/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 21 Mar 2020 10:00:23 +
 Build duration:
2 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.partloadertest

D25315: KDirModel: implement showing a root node for the requested URL

[David Faure]

dfaure added a subscriber: rrosch.
dfaure added a comment.


  @rrosch Does this now behave as expected?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns