D28328: [Inotify] Remove not-so-OptimizedByteArray

[Stefan Brüns]

bruns updated this revision to Diff 78608.
bruns edited the summary of this revision.
bruns added reviewers: Baloo, ngraham.
bruns added a comment.


  summary

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28328?vs=78607=78608

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28328

AFFECTED FILES
  src/file/kinotify.cpp
  src/file/optimizedbytearray.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28328: [Inotify] Remove not-so-OptimizedByteArray

[Stefan Brüns]

bruns created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28328

AFFECTED FILES
  src/file/kinotify.cpp
  src/file/optimizedbytearray.h

To: bruns
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28325: [Inotify] Call QFile::decode only in a single place

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28325

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28325: [Inotify] Call QFile::decode only in a single place

[Stefan Brüns]

bruns updated this revision to Diff 78606.
bruns added a comment.


  simplify condition, whitespace

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28325?vs=78601=78606

REVISION DETAIL
  https://phabricator.kde.org/D28325

AFFECTED FILES
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78605.
apol added a comment.


  Don't leak

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78604=78605

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78604.
apol marked 3 inline comments as done.
apol added a comment.


  Rebase on top of ksyntaxhighlighting, works great

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78117=78604

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28325: [Inotify] Call QFile::decode only in a single place

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28325

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28325: [Inotify] Call QFile::decode only in a single place

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> apol wrote in kinotify.cpp:371
> This conditional looks off, maybe it would make sense to have an intermediate 
> class to decide when to initialize it?
> 
> Something like this:
> 
>   template 
>   class Delayed
>   {
>   public:
>   Delayed(std::function func) : m_func(func) {}
>   T operator*() {
>   if (!m_value) {
>   m_value = m_func();
>   }
>   return *m_value;
>   }
>   std::function m_func;
>   std::optional m_value;
>   };
> 
> and consuming it as
> 
>   Delayed fname([]{return QFile::decodeName(path);});
>   //...
>   Q_EMIT accessed(*fname);
> 
> Then the object itself makes sure it's initialised just once without the risk 
> of forgetting one of the cases.

Have you read the summary?

> it removes the duplicated QFile::decode() calls from the object code.

Your code is expanded in all places again, and even adds more code (the check).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28325

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28325: [Inotify] Call QFile::decode only in a single place

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kinotify.cpp:365
>  
> + // All events which need a decoded path, i.e. everything
> + // but EventMoveFrom | EventQueueOverflow | EventIgnored

Indentation looks off.

> kinotify.cpp:371
> +EventMoveTo | EventOpen | EventUnmount;
> + const QString fname = event->mask & fileEvents ? 
> QFile::decodeName(path) : QString();
> +

This conditional looks off, maybe it would make sense to have an intermediate 
class to decide when to initialize it?

Something like this:

  template 
  class Delayed
  {
  public:
  Delayed(std::function func) : m_func(func) {}
  T operator*() {
  if (!m_value) {
  m_value = m_func();
  }
  return *m_value;
  }
  std::function m_func;
  std::optional m_value;
  };

and consuming it as

  Delayed fname([]{return QFile::decodeName(path);});
  //...
  Q_EMIT accessed(*fname);

Then the object itself makes sure it's initialised just once without the risk 
of forgetting one of the cases.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28325

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> pino wrote in kinotify.cpp:350
> ... but only also if wd is < 0

man inotify

> IN_Q_OVERFLOW
>  Event queue overflowed (wd is -1 for this event).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  By the way I looked through the 319 icons.
  
  - Some icons actually need fixing in icons/.
  - The emblem rating is blue in icons-dark/, because it links to another 
class. We can:
- Leave rating in icons-dark/
- Change the light version to be blue too
  - (Probably) All mimetype icons in size 32px and 64px look significantly 
different in light and dark

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28324: [Inotify] Remove dead/duplicate code

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> bruns wrote in kinotify.cpp:350
> First check is here

... but only also if wd is < 0

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kinotify.cpp:350
>  }
>  
>  // the event name only contains an interesting value if we get an 
> event for a file/folder inside

First check is here

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  I have to take some short notes here.
  
  I have written a .sed script which we can use to convert icons/ files to 
icons-dark/ files. It does the same substitutions as my perl script above, but 
matches only in the stylesheet. That means, fixed colors will not be changed. 
That should fix things like this: F8199106: devices_64_network-rj45-female.png 

  
  The script must be called with the -E option, because it uses new POSIX 
regexes.
  
$ sed -E -f swap_colors.sed -i file/to-change.svg
  
  F8200468: swap_colors.sed 
  Of course you may give it a better name.
  
  Open questions are:
  
  - The icons in applets/ use #314045 as ColorScheme-ViewBackground, altough 
Icon_Workflow_Tips defines #232629. I think it should really be #232629, 
because that is the color which is actually used by the Breeze Dark theme. 
swap_colors.sed substitutes to #232629. The following picture illustrates what 
that means: (Auto-generated left, original right) F8200470: montage.png 
 I think we can do it how swap_colors.sed 
does it now, and get rid of icons-dark/applets/.
  - Icon_Workflow_Tips defines #232629 for ColorScheme-Text, but many icons 
have #4d4d4d as ColorScheme-Text, for example those in icons/applets/, but also 
some in icons-dark/actions/. The latter is a mistake which will be fixed by 
auto-generating. The former is currently respected by swap_colors.sed, and 
auto-generated icons correspond to those in icons-dark. (I think the icons 
should actually use #232629, but than can be fixed independently.)
  
  Next steps:
  
  - Run the compare-dark-light.pl again with the new swap_colors.sed script, to 
be sure it does color swapping fine now.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28327: [Inotify] Start the MoveFrom expire timer at most once per inotify batch

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  We may get several MoveFrom/MoveTo events per read. If we are lucky,
  we get complete pairs for renames and the cookie list is empty, then
  there is no need to start the timer at all.
  
  Avoid indefinite process delays of unpaired MoveFrom events by new
  MoveFrom events. Restart the timer only if not already active, and
  process all events when a 1 second deadline has passed.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28327

AFFECTED FILES
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case the index level is set to "non content indexing", the file was
  still flagged when it had changed. As the content indexer checks for
  the level itself (the config may have changed in the meantime), the
  effect is limited, but the code is still wrong.
  
  In case the level is set to "content indexing", the flag would be set
  twice. As it is a flag the effect is limited, but it blows up the
  transaction unnecessarily.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28326

AFFECTED FILES
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28325: [Inotify] Call QFile::decode only in a single place

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Most events need a decoded path, so move it to the front. As only one
  flag per event can be set the decoding only happens once, but it removes
  the duplicated QFile::decode() calls from the object code.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28325

AFFECTED FILES
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  event->mask & EventQueueOverflow is already checked once early in the
  function, no need to do the check twice.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28324

AFFECTED FILES
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28323: Fix some stylesheet colors in 2 icon files

[David Hurka]

davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This fixes two tiny inconsistencies in existing icon files in icons/.
  In the stylesheet they have #232627 for ColorScheme-Text.
  Now they use #232629, like in all other icon files.
  
  This inconsistency wasn’t a problem until now,
  but would make it difficult to auto-generate icons-dark/ from icons.
  The key in auto-generating is to substitute the colors in the stylesheets,
  so the stylesheets need to have the correct colors.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-some-stylesheet-colors

REVISION DETAIL
  https://phabricator.kde.org/D28323

AFFECTED FILES
  icons/status/22/TeamViewer.svg
  icons/status/22/flameshot-tray.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

[David Faure]

dfaure added a comment.


  Interestingly, D28268  is also about 
executing a KServiceAction, but I cannot port it to this API, because the 
KService::Ptr is not known in that (public) method.
  The caller, KFileItemActions, knows it so it could pass it to a new overload 
with one more parameter, but this seems to point out that maybe a 
KServiceAction is enough? KDesktopFileActions uses the name and icon from the 
action rather than the namd and icon from the service. Dunno if that's better 
though?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28285

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[David Faure]

dfaure added a task: T11549: KIO: remove unneeded QWidget dependencies to set 
parent windows or display errors.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a dependent revision: D28321: [WIP] [applets/devicenotifier] Port 
to ExpandableListItem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  Ready for re-review.
  
  @davidedmundson

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 78593.
ngraham added a comment.


  Add new properties `defaultActionButtonVisible` and `subtitleColor`, used in 
the device notifier

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=78324=78593

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28307: Fix build of KGantt

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R478:0fd515542b7c: Fix build of KGantt (authored by apol).

REPOSITORY
  R478 KDiagram: Libraries for diagrams

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28307?vs=78548=78583

REVISION DETAIL
  https://phabricator.kde.org/D28307

AFFECTED FILES
  src/KGantt/kganttgraphicsitem.h

To: apol, #frameworks, danders
Cc: danders

D28203: Move corner fold to top right in 24 icons

[Nathaniel Graham]

ngraham added a comment.


  Oh, you don't have one yet? That's surprising to me! You've submitted a ton 
of great stuff. You should apply for one and list me as the sponsor. :)
  
  https://community.kde.org/Infrastructure/Get_a_Developer_Account

REPOSITORY
  R266 Breeze Icons

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28307: Fix build of KGantt

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R478 KDiagram: Libraries for diagrams

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28307

To: apol, #frameworks, danders
Cc: danders

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka added a comment.


  I would need a developer account to land this. Same for D27983 
 I assume?

REPOSITORY
  R266 Breeze Icons

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontchooserdialog.cpp:97
> The theoretical answer is yes, this would crash. But note that the user 
> cannot just close the application by clicking somewhere while a modal dialog 
> is up. This requires much more subtle interaction like a DBus call.
> 
> There are a million modal dialogs out there created on the stack, but sure, 
> if you want to be pedantic, use QPointer, new (and manual delete, for lack of 
> a proper smart pointer for this)...
> 
> (or we could set WA_DeleteOnClose instead of the manual delete? I just added 
> a comment to the blog about that)

OK, given how many modal dialogs are out there, I'll leave it as is.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, 
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28312: Implement urls using hints

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Set the hint directly in KNotification instead of the backend. Saves us a bit 
of code

TEST PLAN
  spectacle notifications still has an image

REPOSITORY
  R289 KNotifications

BRANCH
  urlshint

REVISION DETAIL
  https://phabricator.kde.org/D28312

AFFECTED FILES
  src/knotification.cpp
  src/notifybypopup.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28303: LaTeX: fix math parentheses in optional labels

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:213d4bb197a3: LaTeX: fix math parentheses in optional 
labels (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28303?vs=78536=78562

REVISION DETAIL
  https://phabricator.kde.org/D28303

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28303: LaTeX: fix math parentheses in optional labels

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the fix + regression test!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-latex

REVISION DETAIL
  https://phabricator.kde.org/D28303

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27338: Provide an initial implementation for input-method-unstable-v1

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> inputmethod_interface.cpp:153-154
> +{
> +for (auto r : d->resourceMap())
> +d->send_commit_state(r->handle, serial);
> +}

I don't understand why we need `resourceMap()` here. 
zwp_input_method_context_v1 is not a global so I would expect to see something 
like

  void InputMethodContextInterface::sendCommitState(uint32 serial)
  {
  d->send_commit_state();
  }

> inputmethod_interface.cpp:206-210
> +void zwp_input_panel_surface_v1_destroy_resource(Resource * resource) 
> override {
> +wl_resource_destroy(resource->handle);
> +if (resourceMap().isEmpty())
> +q->deleteLater();
> +}

Only delete `q`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 80 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/80/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 26 Mar 2020 14:53:25 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 47 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27718/32770)53%
(11151/21009)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12582/12680)50%
(6615/13173)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6365/7493)65%
(1841/2834)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8172/9796)63%
(2462/3903)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78557.
apol added a comment.


  vlad++

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27338?vs=78553=78557

BRANCH
  arcpatch-D27338

REVISION DETAIL
  https://phabricator.kde.org/D27338

AFFECTED FILES
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/inputmethod_interface.cpp
  src/server/inputmethod_interface.h
  src/server/surfacerole.cpp
  src/server/surfacerole_p.h

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27338: Provide an initial implementation for input-method-unstable-v1

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> inputmethod_interface.cpp:128
> +{
> +wl_resource_destroy(resource->handle);
> +if (resourceMap().isEmpty())

Don't call wl_resource_destroy() in foobar_destroy_resource(), it's dangerous.

  void zwp_input_method_context_v1_destroy(Resource *resource)
  {
  wl_resource_destroy(resource->handle);
  }
  
  void zwp_input_method_context_v1_destroy_resource(Resource *resource)
  {
  Q_UNUSED(resource)
  q->deleteLater();
  }

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 120 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/120/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 26 Mar 2020 14:53:25 +
 Build duration:
6 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 47 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27731/32767)53%
(11167/21009)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12604/12679)50%
(6637/13173)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6357/7491)65%
(1836/2834)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8171/9796)63%
(2461/3903)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 26 Mar 2020 14:53:24 +
 Build duration:
5 min 12 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78553.
apol added a comment.


  forgot to save the file

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27338?vs=78549=78553

BRANCH
  arcpatch-D27338

REVISION DETAIL
  https://phabricator.kde.org/D27338

AFFECTED FILES
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/inputmethod_interface.cpp
  src/server/inputmethod_interface.h
  src/server/surfacerole.cpp
  src/server/surfacerole_p.h

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28309: Remove cppcheck from kwayland

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:665dc779c668: Remove cppcheck from kwayland (authored by 
apol).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28309?vs=78550=78552

REVISION DETAIL
  https://phabricator.kde.org/D28309

AFFECTED FILES
  .arclint

To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27660: Add Inno Setup syntax, including embedded Pascal scripting

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:517dccc95ecf: Add Inno Setup syntax, including embedded 
Pascal scripting (authored by zrax, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27660?vs=77133=78551

REVISION DETAIL
  https://phabricator.kde.org/D27660

AFFECTED FILES
  autotests/folding/setup.iss.fold
  autotests/html/setup.iss.html
  autotests/input/setup.iss
  autotests/reference/setup.iss.ref
  data/syntax/innosetup.xml

To: zrax, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28309: Remove cppcheck from kwayland

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28309

To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27660: Add Inno Setup syntax, including embedded Pascal scripting

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Cool +1 ;=)
  Thanks for the contribution.
  We use that at company, nice to have.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  innosetup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27660

To: zrax, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28309: Remove cppcheck from kwayland

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Like we did on kwin, it doesn't work.

TEST PLAN
  This very patch

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28309

AFFECTED FILES
  .arclint

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol marked 4 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78549.
apol added a comment.


  address comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27338?vs=78515=78549

BRANCH
  arcpatch-D27338

REVISION DETAIL
  https://phabricator.kde.org/D27338

AFFECTED FILES
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/inputmethod_interface.cpp
  src/server/inputmethod_interface.h
  src/server/surfacerole.cpp
  src/server/surfacerole_p.h

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28307: Fix build of KGantt

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78548.
apol added a comment.


  Address @danders comment

REPOSITORY
  R478 KDiagram: Libraries for diagrams

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28307?vs=78543=78548

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28307

AFFECTED FILES
  src/KGantt/kganttgraphicsitem.h

To: apol, #frameworks
Cc: danders

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[David Edmundson]

davidedmundson added a comment.


  T11549 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[David Edmundson]

davidedmundson added a comment.


  > Do we have a kf6 workboard entry for this effort?
  
  T12163 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28307: Fix build of KGantt

[Dag Andersen]

danders added a comment.


  Ummpf, my mistake, it is the GraphicsItem that needs exporting.

REPOSITORY
  R478 KDiagram: Libraries for diagrams

REVISION DETAIL
  https://phabricator.kde.org/D28307

To: apol, #frameworks
Cc: danders

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:c2e0be30f87f: Use bold italic at 100% for sect4 titles, 
and bold 100% for sect5 titles (authored by yurchor).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28304?vs=78544=78545

REVISION DETAIL
  https://phabricator.kde.org/D28304

AFFECTED FILES
  common/en/kde-docs.css

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28304

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

yurchor updated this revision to Diff 78544.
yurchor added a comment.


  Fixed definitions as suggested.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28304?vs=78537=78544

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28304

AFFECTED FILES
  common/en/kde-docs.css

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Dag Andersen]

danders added a comment.


  I got the best result (imho) with this:
  div.sect3 h4 {
  
font-size: 100%;
font-weight: bold;
  
  }
  div.sect4 h5 {
  
font-size: 100%;
font-weight: bold;
  
  }
  
  div.sect5 h6 {
  
font-size: 90%;
font-style: italic;
  
  }
  
  Note the 90% for sect5.
  It seems h6 is almost the same as h5, but h7 is *much* smaller, even smaller 
than text.
  Also suspect defult for sect3 id h5, so set it to h4.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D28304

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28307: Fix build of KGantt

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  My compiler doesn't like exporting namespaces.

TEST PLAN
  Builds now

REPOSITORY
  R478 KDiagram: Libraries for diagrams

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28307

AFFECTED FILES
  src/KGantt/kganttgraphicsitem.h

To: apol, #frameworks

D27660: Add Inno Setup syntax, including embedded Pascal scripting

[Nibaldo González]

nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27660

To: zrax, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D28304

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[Kai Uwe Broulik]

broulik added a comment.


  Do we have a kf6 workboard entry for this effort?
  I think we should also have a replacement job for `new KRun(url)` and I'd 
love if we could split out the "default app for this mimetype" logic we (also?) 
have in `KFileItemActions` out into a dedicated public class.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

yurchor created this revision.
yurchor added reviewers: Documentation, danders.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Now the titles are small and hard to distinguish.
  
  BUG: 419256

TEST PLAN
  Replace kde-docs.css in your system to see the results.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28304

AFFECTED FILES
  common/en/kde-docs.css

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28303: LaTeX: fix math parentheses in optional labels

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, 
jpoelen.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 418979
  
  Single parentheses within `[...]` were highlighted as math text, but the math 
text is `\(...\)`.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-latex

REVISION DETAIL
  https://phabricator.kde.org/D28303

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28302: [KNewFileMenu] Add extension to proposed filename

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Using "create new" text or html file, add the extension to the proposed
  filename, this makes those plain text files work for other OS's e.g.
  Windows (with Linux plain text files (.txt) don't usually have a extension
  relying on mimetype detection); as for but HTML filenames they do have
  extensions even on Linux.
  
  BUG: 61669

TEST PLAN
  make && ctest; and using the create name text/html file menu in dolphin

REPOSITORY
  R241 KIO

BRANCH
  l-template-proposed-file-name-ext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28302

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D28161#634955 , @sitter wrote:
  
  > In D28161#634951 , @ahmadsamir 
wrote:
  >
  > > > Please don't touch kdsoap-ws-discovery-client though. It's not 
maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client
  > >
  > > That's confusing; but OK, I'll revert that part of the diff.
  >
  >
  > Yeah, it's not ideal but the library is not API-stable so we need a fixed 
reference point. Do please make a merge request for it though, Casper is very 
responsive to MRs.
  
  
  OK, will do, thanks for the pointer. :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28161

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

[Harald Sitter]

sitter added a comment.


  In D28161#634951 , @ahmadsamir 
wrote:
  
  > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained 
here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client
  >
  > That's confusing; but OK, I'll revert that part of the diff.
  
  
  Yeah, it's not ideal but the library is not API-stable so we need a fixed 
reference point. Do please make a merge request for it though, Casper is very 
responsive to MRs.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28161

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78528.
ahmadsamir added a comment.


  Leave out kdsoap-ws-discovery-client, it's maintained somewhere else...

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28161?vs=78090=78528

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28161

AFFECTED FILES
  bookmarks/kio_bookmarks.cpp
  fish/fish.cpp
  man/kio_man.cpp
  man/man2html.cpp

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D28161#634949 , @sitter wrote:
  
  > Looks good to me, not that this means much with regular expressions. The 
lack of tests on this stuff makes me sad :((
  
  
  Unit tests are indeed useful...
  
  > Please don't touch kdsoap-ws-discovery-client though. It's not maintained 
here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client
  
  That's confusing; but OK, I'll revert that part of the diff.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28161

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

[Harald Sitter]

sitter added a comment.


  Looks good to me, not that this means much with regular expressions. The lack 
of tests on this stuff makes me sad :((
  
  Please don't touch kdsoap-ws-discovery-client though. It's not maintained 
here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28161

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#633820 , @dfaure wrote:
  
  > Implementation note: the fastest way to know if two items are on the same 
partition is to compare KIO::UDSEntry::UDS_DEVICE_ID values. But unfortunately 
it looks like this code takes URLs, not proper KFileItems created from a 
kio_file job... I guess that means statbuf.st_dev directly, on Unix?
  
  
  `KIO::UDSEntry::UDS_DEVICE_ID` doesn't provide wanted info in this case. See 
my example:
  
[ "UDS_NAME"="/home/trmdi/Downloads/mount/Data" "UDS_SIZE"=0 
"UDS_DEVICE_ID"=4607182418800017408 "UDS_INODE"=30008928 "UDS_FILE_TYPE"=0 
"UDS_ACCESS"=0 "UDS_MODIFICATION_TIME"=140192419498368 
"UDS_ACCESS_TIME"=22970816 "UDS_USER"="root" "UDS_GROUP"="" ]

[ "UDS_NAME"="/home/trmdi/Downloads/mount" "UDS_SIZE"=0 
"UDS_DEVICE_ID"=4607182418800017408 "UDS_INODE"=30008928 "UDS_FILE_TYPE"=0 
"UDS_ACCESS"=0 "UDS_MODIFICATION_TIME"=140192419498368 
"UDS_ACCESS_TIME"=22970816 "UDS_USER"="root" "UDS_GROUP"="" ]
  
  (Data is a symlink to a directory in /dev/sda2, mount is in /dev/sda1)
  
  While `KMointPoint` is still right:
  
"/home/trmdi/Downloads/mount"  -  "/dev/sda1"
"/home/trmdi/Downloads/mount/Data"  -  "/dev/sda2"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28298: Reduce superfluous changedEntriesChanged emissions

[Kai Uwe Broulik]

broulik added a comment.


  Hmm, when doing this, Qt suddenly refuses to pass the entries through to a 
`QQmlListReference`

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28298

To: broulik, #frameworks, leinir, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28298: Reduce superfluous changedEntriesChanged emissions

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28298

To: broulik, #frameworks, leinir, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28298: Reduce superfluous changedEntriesChanged emissions

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, leinir, ahiemstra.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For some reason I couldn't entirely get behind, `changedEntries` was 
signalled to change on the QML side on component creation.
  Even when replacing the `Binding` by a direct binding, this wouldn't work. 
However, while I can't just `alias` it, it turns out, `ghnsDialog` already has 
a `changedEntries` alias, which we can then just bind to.
  Furthermore, don't signal a change when clearing if it was already empty.
  
  This fixes the wallpaper model in Plasma reloading in-flight, causing 
thumbnail generation to fail. While this is a genuine bug in the model it only 
started to be a problem with GHNS needlessly reloading the model.
  
  BUG: 419234

TEST PLAN
  - My thumbnails show up fine again
  - Installing a new thumbnail still reloads the model (`changedEntries` is 
signalled to change when I install something)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28298

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/quickengine.cpp

To: broulik, #frameworks, leinir, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, nicolasfella, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This can be used for job error reporting using `KNotification` rather than a 
`KDialog`.

TEST PLAN
  F8199446: Screenshot_20200326_092153.png 

  
  As discussed in D28286 
  
auto *job = new KIO::ApplicationLauncherJob(service);
auto *delegate = new KNotificationJobUiDelegate;
delegate->setAutoErrorHandlingEnabled(true);
job->setUiDelegate(delegate);
job->start();
  
  Is there a way to get the job description/title outside of its `description` 
emission? I kinda would like to show the job title in the notification but I 
don't see how.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

AFFECTED FILES
  src/CMakeLists.txt
  src/knotificationjobuidelegate.cpp
  src/knotificationjobuidelegate.h

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4f5503644aa6: [ApplicationLauncherJob] Add way to launch 
KServiceAction (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28285?vs=78470=78518

REVISION DETAIL
  https://phabricator.kde.org/D28285

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/applicationlauncherjob.h

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> inputmethod_interface.cpp:128-129
> +wl_resource_destroy(resource->handle);
> +if (resourceMap().isEmpty())
> +q->deleteLater();
> +}

Destroy `q` in zwp_input_method_context_v1_destroy_resource(). In the 
destructor request, we usually want to destroy only the resource.

> inputmethod_interface.cpp:181
> +
> +class Q_DECL_HIDDEN InputPanelSurfaceInterface::Private : public 
> QtWaylandServer::zwp_input_panel_surface_v1
> +{

We need to destroy the wl_resource for zwp_input_panel_surface_v1 when the 
associated surface is destroyed.

> apol wrote in inputmethod_interface.cpp:179
> I don't know, just looked at it and it doesn't seem that useful?

zwp_input_panel_surface_v1 defines a surface role (based on weston code) so it 
should be a subclass of SurfaceRole. In long term, we want to do something like

  SurfaceRole *role = SurfaceRole::get(surface);
  if (role) {
  wl_resource_post_error(resource->handle, ZMY_SHELL_SURFACE_ERROR_ROLE,
 "Cannot reassign surface role"); // DIE!
  return;
  }

> apol wrote in inputmethod_interface.cpp:199-200
> I would rather not, otherwise when implementing private members they read 
> like local variables.

Frameworks' policies have no a single word about this so I guess it's okay(?) 
to put `m_`. I asked to drop `m_` because Qt folks seem to prefer not to put 
`m_` in private classes.

I would appreciate if you bring this topic up to the discussion in 
#kde-frameworks-devel since we're not consistent with naming in private classes.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns