D18883: Add PDF thumbnailer

[Méven Car]

meven added a comment.


  ping
  
  Is it still standing ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: meven, bruns, dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, 
kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/18/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 00:59:41 +
 Build duration:
3 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.70.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6933/9126)43%
(10802/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2901/2996)49%
(6197/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/16/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 00:59:41 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » prison » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20WindowsMSVCQt5.14/1/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 00:12:02 +
 Build duration:
6 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 26 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/26/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 00:00:08 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarktest

D29370: Use UI marker context in more tr() calls

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:d256eaf8d8ed: Use UI marker context in more tr() calls 
(authored by kossebau).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29370?vs=81762=82330

REVISION DETAIL
  https://phabricator.kde.org/D29370

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: kossebau, #frameworks, #localization, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29369: Use UI marker context in more tr() calls

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:1d8d223745eb: Use UI marker context in more tr() calls 
(authored by kossebau).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29369?vs=81761=82329

REVISION DETAIL
  https://phabricator.kde.org/D29369

AFFECTED FILES
  src/kbookmarkcontextmenu.cpp
  src/kbookmarkmenu.cpp
  src/konqbookmarkmenu.cpp

To: kossebau, #frameworks, #localization
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29368: Use UI marker context in more tr() calls

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:5b08593fc0c4: Use UI marker context in more tr() calls 
(authored by kossebau).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29368?vs=81760=82328

REVISION DETAIL
  https://phabricator.kde.org/D29368

AFFECTED FILES
  src/khistorycombobox.cpp
  src/klineedit.cpp

To: kossebau, #frameworks, #localization
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29367: Use UI marker context in more tr() calls

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R276:df9e5d3bb765: Use UI marker context in more tr() calls 
(authored by kossebau).

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29367?vs=81759=82327

REVISION DETAIL
  https://phabricator.kde.org/D29367

AFFECTED FILES
  src/kfilterproxysearchline.cpp
  src/ktreewidgetsearchline.cpp

To: kossebau, #frameworks, #localization, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29363: Use UI marker context in more tr() calls

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:5904c475cb37: Use UI marker context in more tr() calls 
(authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29363?vs=81744=82326#toc

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29363?vs=81744=82326

REVISION DETAIL
  https://phabricator.kde.org/D29363

AFFECTED FILES
  src/kactionselector.cpp
  src/kassistantdialog.cpp
  src/kcharselect.cpp
  src/kcolorcombo.cpp
  src/kdatepicker.cpp
  src/kdatetimeedit.cpp
  src/keditlistwidget.cpp
  src/kfontchooser.cpp
  src/kfontchooserdialog.cpp
  src/kfontrequester.cpp
  src/kmessagewidget.cpp
  src/kmimetypechooser.cpp
  src/knewpassworddialog.cpp
  src/knewpasswordwidget.ui
  src/kpassworddialog.cpp
  src/kpassworddialog.ui
  src/kpasswordlineedit.cpp
  src/kpixmapregionselectordialog.cpp
  src/kpixmapregionselectorwidget.cpp
  src/ksqueezedtextlabel.cpp

To: kossebau, #frameworks, #localization, cfeck
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[David Faure]

dfaure created this revision.
dfaure added reviewers: ahmadsamir, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  [Next up, KRun::displayOpenWithDialog]

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29547

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/krun.h

To: dfaure, ahmadsamir, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Ping? If no-one objects would push upcoming Monday, May 11th.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29414

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Andres Betts]

abetts added a comment.


  +1 from me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham added a comment.


  In D29534#666554 , @ndavis wrote:
  
  > I don't like the look of those +/- buttons. I think this makes it harder to 
know that you can drag the panel height up and down.
  
  
  That would be a comment for D29535 , but 
I will repeat my argument here: I think that drag is the least important 
interaction method for panel thickness adjustment since you typically want to 
make fine adjustments or arrive at a specific value, both of which are unsuited 
for drag-based interactions. Nevertheless, I have implemented drag-adjustment 
in the spinbox control here to not lose it, which also yields the advantage 
that other potential Plasma components that use a spinbox will benefit from it.
  
  We can improve the look of this control in another patch. To my knowledge it 
hasn't been used at all so it wouldn't surprise me if it's a bit unpolished.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Noah Davis]

ndavis added a comment.


  I don't like the look of those +/- buttons. I think this makes it harder to 
know that you can drag the height up and down.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham retitled this revision from "Implement wheel/touchpad scrolling for 
SpinBox control" to "Implement scroll and drag adjustment of values for SpinBox 
control".
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham added a task: T9460: Consider a more user-friendly SpinBox control.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham updated this revision to Diff 82311.
ngraham added a comment.


  Implement click-and-drag (along both the X and Y axes) to modify the value

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82276=82311

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 7 inline comments as done.
araujoluis added inline comments.

INLINE COMMENTS

> tcanabrava wrote in kcolorcombo.cpp:244
> namedColors.reserve(colors.size());

Done!

> tcanabrava wrote in kcolorcombo.cpp:245
> for(auto color : colors)

Done!

> tcanabrava wrote in kcolorcombo.cpp:288
> why is there a for running with all code comented out?

Done!

> tcanabrava wrote in kcolorcombo.h:60
> QPair - no need for a struct.

Done!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:50c5c2fd7e5c: KBookmarkMenuTest: extend unittest to cover 
undeprecated API (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29541?vs=82300=82308#toc

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29541?vs=82300=82308

REVISION DETAIL
  https://phabricator.kde.org/D29541

AFFECTED FILES
  autotests/kbookmarkmenutest.cpp

To: kossebau, #frameworks, nicolasfella, dfaure, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  extendunittestfornudeprecated

REVISION DETAIL
  https://phabricator.kde.org/D29541

To: kossebau, #frameworks, nicolasfella, dfaure, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sorry, I have one last comment about a comment :)

INLINE COMMENTS

> copyjob.cpp:477
> +// Check available free space for remote urls
> +// TODO: find a way to report connection errors to the user
> +KIO::FileSystemFreeSpaceJob *spaceJob = 
> KIO::fileSystemFreeSpace(existingDest);

This comment is now completely out of context. It used to be about NFS/SMB, now 
this information has gone and one is left wondering why kind of connections 
we're talking about (connection to the kioslave???)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 585 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/585/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 May 2020 19:13:05 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34414/62844)39%
(17457/44522)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4296/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8452/14359)50%
(4394/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8341)43%
(2079/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/88/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 08 May 2020 19:04:08 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34416/62845)39%
(17452/44518)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4288/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8452/14359)50%
(4397/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8343)43%
(2077/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/95/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 08 May 2020 18:53:33 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 584 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/584/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 May 2020 18:43:50 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34430/62844)39%
(17463/44522)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4293/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8463/14359)51%
(4400/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4695/8341)43%
(2082/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 182 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/182/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 08 May 2020 18:53:33 +
 Build duration:
11 min and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/87/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 08 May 2020 18:44:55 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34416/62845)39%
(17454/44518)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4292/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8452/14359)50%
(4395/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8343)43%
(2077/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 86 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/86/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 08 May 2020 18:25:53 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34420/62846)39%
(17475/44518)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4301/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8451/14359)51%
(4402/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8343)43%
(2077/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 583 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/583/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 May 2020 18:25:53 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34413/62844)39%
(17454/44522)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4293/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8452/14359)50%
(4395/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8341)43%
(2078/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/94/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 08 May 2020 18:33:05 +
 Build duration:
6 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

ahmadsamir updated this revision to Diff 82305.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  "existingDest" is a better name for the var relating to m_asMethod

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29485?vs=82285=82305

BRANCH
  l-freespace-remote-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29485

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:430
> This is the same as "actualDest" too, so its definition could be moved 
> further up and shared with this too.
> 
> (Not that the name is perfect --- when copying ~/file.txt to ~/file2.txt, the 
> actual destination is ~/file2.txt.
> Or copying ~/dir1 as ~/dir2, then the actual destination is ~/dir2. So even a 
> name like destDir isn't perfect...)
> 
> existingDest maybe. ~ exists. ~/dir2 not yet.

> This is the same as "actualDest" too, so its definition could be moved 
> further up and shared with this too.

The code handling UDS_LOCAL_PATH is in between them, it may change m_dest.

And "existingDest" it is.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 93 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/93/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 08 May 2020 18:25:53 +
 Build duration:
7 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 181 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/181/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 08 May 2020 18:30:19 +
 Build duration:
2 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 961 lines...][2020-05-08T18:32:19.824Z] [214/732] Linking CXX shared module bin\kf5\kio\http.dll[2020-05-08T18:32:19.824Z]Creating library lib\http.lib and object lib\http.exp[2020-05-08T18:32:19.824Z]Creating library lib\http.lib and object lib\http.exp[2020-05-08T18:32:19.824Z] [215/732] Generating kpasswdserveradaptor.cpp, kpasswdserveradaptor.h[2020-05-08T18:32:20.099Z] [216/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kiogui_debug.cpp.obj[2020-05-08T18:32:20.099Z] [217/732] Generating kpasswdserveradaptor.moc[2020-05-08T18:32:20.409Z] [218/732] Automatic MOC for target kiod_kpasswdserver[2020-05-08T18:32:20.409Z] [219/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\faviconrequestjob.cpp.obj[2020-05-08T18:32:20.728Z] [220/732] Generating kpasswdserveradaptor.cpp, kpasswdserveradaptor.h[2020-05-08T18:32:20.728Z] [221/732] Linking CXX executable bin\kioslave5.exe[2020-05-08T18:32:20.728Z] [222/732] Generating kpasswdserveradaptor.moc[2020-05-08T18:32:21.355Z] [223/732] Linking CXX shared module bin\kf5\kio\trash.dll[2020-05-08T18:32:21.355Z]Creating library lib\trash.lib and object lib\trash.exp[2020-05-08T18:32:21.355Z]Creating library lib\trash.lib and object lib\trash.exp[2020-05-08T18:32:21.641Z] [224/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kprocessrunner.cpp.obj[2020-05-08T18:32:21.641Z] ..\src\gui\kprocessrunner.cpp(227): warning C4551: function call missing argument list[2020-05-08T18:32:21.641Z] [225/732] Linking CXX shared module bin\kf5\kiod\kssld.dll[2020-05-08T18:32:21.641Z]Creating library lib\kssld.lib and object lib\kssld.exp[2020-05-08T18:32:21.641Z]Creating library lib\kssld.lib and object lib\kssld.exp[2020-05-08T18:32:23.201Z] [226/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openurljob.cpp.obj[2020-05-08T18:32:23.201Z] [227/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openurljobhandlerinterface.cpp.obj[2020-05-08T18:32:23.201Z] [228/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\commandlauncherjob.cpp.obj[2020-05-08T18:32:23.501Z] [229/732] Generating org.kde.KIOExecd.xml[2020-05-08T18:32:23.501Z] [230/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\KF5KIOGui_autogen\mocs_compilation.cpp.obj[2020-05-08T18:32:23.772Z] [231/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\applicationlauncherjob.cpp.obj[2020-05-08T18:32:23.772Z] [232/732] Automatic MOC for target kioexecd[2020-05-08T18:32:23.772Z] [233/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:32:24.052Z] [234/732] Automatic MOC for target kmountpointtest[2020-05-08T18:32:24.052Z] [235/732] Generating kioexecdadaptor.cpp, kioexecdadaptor.h[2020-05-08T18:32:24.052Z] [236/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kiod_kpasswdserver_autogen\mocs_compilation.cpp.obj[2020-05-08T18:32:24.349Z] [237/732] Generating kioexecdadaptor.moc[2020-05-08T18:32:24.349Z] [238/732] Automatic MOC for target kcookiejartest[2020-05-08T18:32:24.630Z] [239/732] Automatic MOC for target upurltest[2020-05-08T18:32:25.648Z] [240/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kiod_kpasswdserver.cpp.obj[2020-05-08T18:32:26.615Z] [241/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T18:32:26.959Z] [242/732] Building CXX object autotests\CMakeFiles\kmountpointtest.dir\kmountpointtest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:32:26.959Z] [243/732] Building CXX object autotests\CMakeFiles\upurltest.dir\upurltest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:32:27.234Z] [244/732] Linking CXX shared library bin\KF5KIOGui.dll[2020-05-08T18:32:27.234Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T18:32:27.234Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T18:32:27.512Z] [245/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecd_autogen\mocs_compilation.cpp.obj[2020-05-08T18:32:27.512Z] [246/732] Automatic MOC for target jobtest[2020-05-08T18:32:27.512Z] [247/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T18:32:27.843Z] [248/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\__\kpasswdserver.cpp.obj[2020-05-08T18:32:29.601Z] [249/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserver.cpp.obj[2020-05-08T18:32:29.601Z] [250/732] Building CXX object 

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 180 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/180/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 08 May 2020 18:25:53 +
 Build duration:
4 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 981 lines...][2020-05-08T18:30:01.685Z] [228/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openurljob.cpp.obj[2020-05-08T18:30:01.685Z] [229/732] Automatic MOC for target kioexecd[2020-05-08T18:30:01.956Z] [230/732] Generating org.kde.KIOExecd.xml[2020-05-08T18:30:01.956Z] [231/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kiogui_debug.cpp.obj[2020-05-08T18:30:01.956Z] [232/732] Generating kioexecdadaptor.cpp, kioexecdadaptor.h[2020-05-08T18:30:01.956Z] [233/732] Generating kioexecdadaptor.moc[2020-05-08T18:30:02.234Z] [234/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openurljobhandlerinterface.cpp.obj[2020-05-08T18:30:02.234Z] [235/732] Automatic MOC for target threadtest[2020-05-08T18:30:02.234Z] [236/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T18:30:02.234Z] [237/732] Automatic MOC for target kcookiejartest[2020-05-08T18:30:02.499Z] [238/732] Building CXX object autotests\CMakeFiles\threadtest.dir\threadtest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:30:02.499Z] [239/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\favicons_debug.cpp.obj[2020-05-08T18:30:02.499Z] [240/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kprocessrunner.cpp.obj[2020-05-08T18:30:02.499Z] ..\src\gui\kprocessrunner.cpp(227): warning C4551: function call missing argument list[2020-05-08T18:30:02.770Z] [241/732] Automatic MOC for target globaltest[2020-05-08T18:30:02.770Z] [242/732] Automatic MOC for target kfileitemtest[2020-05-08T18:30:03.033Z] [243/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\applicationlauncherjob.cpp.obj[2020-05-08T18:30:03.033Z] [244/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserver.cpp.obj[2020-05-08T18:30:03.296Z] [245/732] Automatic MOC for target mkpathjobtest[2020-05-08T18:30:03.562Z] [246/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecdebug.cpp.obj[2020-05-08T18:30:03.562Z] [247/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecd_autogen\mocs_compilation.cpp.obj[2020-05-08T18:30:03.828Z] [248/732] Automatic MOC for target udsentrytest[2020-05-08T18:30:03.828Z] [249/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest.cpp.obj[2020-05-08T18:30:03.828Z] [250/732] Building CXX object autotests\CMakeFiles\mkpathjobtest.dir\mkpathjobtest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:30:04.126Z] [251/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T18:30:04.390Z] [252/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\__\kpasswdserver.cpp.obj[2020-05-08T18:30:04.390Z] [253/732] Linking CXX shared library bin\KF5KIOGui.dll[2020-05-08T18:30:04.390Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T18:30:04.390Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T18:30:04.390Z] [254/732] Automatic MOC for target kmountpointtest[2020-05-08T18:30:04.390Z] [255/732] Linking CXX shared module bin\kf5\kiod\kpasswdserver.dll[2020-05-08T18:30:04.390Z]Creating library lib\kpasswdserver.lib and object lib\kpasswdserver.exp[2020-05-08T18:30:04.390Z]Creating library lib\kpasswdserver.lib and object lib\kpasswdserver.exp[2020-05-08T18:30:04.390Z] [256/732] Building CXX object autotests\CMakeFiles\kfileitemtest.dir\kfileitemtest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:30:05.358Z] [257/732] Building CXX object autotests\CMakeFiles\threadtest.dir\threadtest.cpp.obj[2020-05-08T18:30:05.358Z] ..\autotests\threadtest.cpp(53): warning C4551: function call missing argument list[2020-05-08T18:30:05.358Z] [258/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecdadaptor.cpp.obj[2020-05-08T18:30:05.642Z] [259/732] Building CXX object autotests\CMakeFiles\kfileitemtest.dir\kfileitemtest.cpp.obj[2020-05-08T18:30:05.642Z] [260/732] Building CXX object autotests\CMakeFiles\udsentrytest.dir\udsentrytest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:30:05.907Z] [261/732] Building CXX object autotests\CMakeFiles\kmountpointtest.dir\kmountpointtest_autogen\mocs_compilation.cpp.obj[2020-05-08T18:30:05.907Z] [262/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecd.cpp.obj[2020-05-08T18:30:05.907Z] [263/732] Linking CXX executable bin\kpasswdservertest.exe[2020-05-08T18:30:05.907Z] [264/732] Automatic MOC for target jobremotetest[2020-05-08T18:30:06.176Z] [265/732] Linking CXX executable bin\threadtest.exe[2020-05-08T18:30:06.682Z] [266/732] Building CXX 

D29528: [OpenUrlJob] Improve comments/docs

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1b9b239eb262: [OpenUrlJob] Improve comments/docs 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29528?vs=82286=82304

REVISION DETAIL
  https://phabricator.kde.org/D29528

AFFECTED FILES
  src/gui/openurljob.cpp
  src/gui/openurljob.h
  src/gui/openurljobhandlerinterface.h
  src/widgets/kdesktopfileactions.cpp
  src/widgets/kopenwithdialog.cpp
  src/widgets/krun.cpp
  src/widgets/widgetsopenurljobhandler.h

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cb89bab36a5a: [CopyJob] Get rid of an old TODO and use 
QFile::rename() (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29537?vs=82288=82303

REVISION DETAIL
  https://phabricator.kde.org/D29537

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol added a comment.


  Moving to kwayland-server

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson, zzag
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol abandoned this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson, zzag
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, nicolasfella, dfaure, ahmadsamir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R294 KBookmarks

BRANCH
  extendunittestfornudeprecated

REVISION DETAIL
  https://phabricator.kde.org/D29541

AFFECTED FILES
  autotests/kbookmarkmenutest.cpp

To: kossebau, #frameworks, nicolasfella, dfaure, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29540: plasmawindowmodel: Expose the internal id to the model

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It allows to use this class together with the screencast protocol.
  It's public API on the window anyway so it should probably be exposed.

TEST PLAN
  Used it with the other screencast patches for convenience.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29540

AFFECTED FILES
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

To: apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Nice!

REPOSITORY
  R241 KIO

BRANCH
  l-qfile-rename (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29537

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29528: [OpenUrlJob] Improve comments/docs

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-late (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29528

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> copyjob.cpp:430
> +if (!m_privilegeExecutionEnabled && !isWritable) {
> +const QUrl dest = m_asMethod ? 
> m_dest.adjusted(QUrl::RemoveFilename) : m_dest;
> +q->setError(ERR_WRITE_ACCESS_DENIED);

This is the same as "actualDest" too, so its definition could be moved further 
up and shared with this too.

(Not that the name is perfect --- when copying ~/file.txt to ~/file2.txt, the 
actual destination is ~/file2.txt.
Or copying ~/dir1 as ~/dir2, then the actual destination is ~/dir2. So even a 
name like destDir isn't perfect...)

existingDest maybe. ~ exists. ~/dir2 not yet.

> copyjob.cpp:448
>  const QString fileName = m_dest.fileName();
> +// The statJob that returned "entry" has taken into account 
> m_asMethod
>  m_dest = QUrl::fromLocalFile(sLocalPath);

It has, but "taking into account" is ambiguous. I first thought it meant "we 
stat'ed the final dest", while in fact it means we stat'ed the parent existing 
dest. Maybe no comment is better than an ambiguous comment :-)

> ahmadsamir wrote in copyjob.cpp:479
> s/below/below, because return is called right after it, so that 
> statCurrentSrc is called from the lambda/
> 
> does that sound better?

Yes. But comments should add information, not just describe what the code 
already says :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven added a comment.


  In D29397#666153 , @kossebau wrote:
  
  > In D29397#666134 , @meven wrote:
  >
  > > In D29397#666132 , @kossebau 
wrote:
  > >
  > > > For another stupid question (the first one was already asked by someone 
else and answered :) ):
  > > >  Given some generated thumbnails are cached, does the thumbnail cache 
specification support logical resolution?
  > >
  > >
  > > I am evolving here the specification : the images stored are stored with 
their HiDpi size (width * dpr, height * dpr), and then some metadata is written.
  >
  >
  > Specification as in, 
https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html?
 So there is some work on extending the specs not yet reflected on that page?
  
  
  Thanks for the reference.
  I meant I am beyond the spec, adding some by facts, that is not great :/
  This spec is showing its age, and would need to evolve to cover HiDPi use 
case, but I am not editing it ATM.
  
  > How is the metadata written?
  
  line 751 of PreviewJob.
  
  >>> How would cached thumbnails work cross-screen?
  >> 
  >> Cache thumbnails with low dpr will look blurry on hidpi screen, other than 
that's not an issue.
  > 
  > Cached thumbnails rendered for hidpi (so e.g. being 256x256 with bigger 
details due to hidpi context) , but used for lowdpi elsewhere will be an issue 
as well. E.g. when it comes to text rendered with minfontsize like in case of 
plain text documents, it will be too large then.
  > 
  > I wonder if the thumbnail cache would not need the same extension like the 
icon spec had, with a @2x variant, to make up for that. There are still a lot 
of lowdpi devices out there, and they are getting mixed.
  
  That looks like the way to go, I would favor adding normal@2x and large@2x in 
.cache/thumbnails

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in thumbcreator.h:215
> docu?

I wonder about moving qreal devicePixelRatio before img parameter

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29539: Port to ThumbnailCreatorV3 to support devicePixelRatio

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ngraham, broulik, elvisangelaccio.
meven requested review of this revision.

REVISION SUMMARY
  Generate a thumbnail depending of devicePixelRatio.
  
  Depends on kio D29397 
  And kio-extras D29526 

TEST PLAN
  Manually tested

REPOSITORY
  R343 FFmpeg Thumbnailers

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29539

AFFECTED FILES
  ffmpegthumbnailer.cpp
  ffmpegthumbnailer.h

To: meven, #frameworks, ngraham, broulik, elvisangelaccio

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven updated this revision to Diff 82292.
meven marked an inline comment as done.
meven added a comment.


  Code style

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29397?vs=82290=82292

BRANCH
  preview-dpr

REVISION DETAIL
  https://phabricator.kde.org/D29397

AFFECTED FILES
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/thumbcreator.cpp
  src/widgets/thumbcreator.h

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven updated this revision to Diff 82290.
meven marked 2 inline comments as done.
meven added a comment.


  Improve documentation, code style

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29397?vs=82255=82290

BRANCH
  preview-dpr

REVISION DETAIL
  https://phabricator.kde.org/D29397

AFFECTED FILES
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/thumbcreator.cpp
  src/widgets/thumbcreator.h

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  Renaming a dir A to a on a FAT32 partition still works

REPOSITORY
  R241 KIO

BRANCH
  l-qfile-rename (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29537

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29528: [OpenUrlJob] Improve comments/docs

[Ahmad Samir]

ahmadsamir updated this revision to Diff 82286.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29528?vs=82260=82286

BRANCH
  l-late (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29528

AFFECTED FILES
  src/gui/openurljob.cpp
  src/gui/openurljob.h
  src/gui/openurljobhandlerinterface.h
  src/widgets/kdesktopfileactions.cpp
  src/widgets/kopenwithdialog.cpp
  src/widgets/krun.cpp
  src/widgets/widgetsopenurljobhandler.h

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29528: [OpenUrlJob] Improve comments/docs

[Ahmad Samir]

ahmadsamir marked 2 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in openurljob.cpp:590
> That one was on purpose. I find this version less readable, mixing a test and 
> an actual action (with error handling).

Fair point.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29528

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

ahmadsamir updated this revision to Diff 82285.
ahmadsamir marked 2 inline comments as done.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29485?vs=82113=82285

BRANCH
  l-freespace-remote-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29485

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

ahmadsamir marked 2 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:430
> Here you kept a comment that said "we want to check", but the check already 
> happened.
> I'd say just remove the two lines of comments.
> The code is clearer without them.

Copy-paste-comment logic mistake.

> dfaure wrote in copyjob.cpp:433
> That is not a path, for remote URLs. I suggest using 
> dest.toDisplayString(QUrl::PreferLocalFiles) and just inlining that in the 
> setErrorText call.

path as in "destination dir", but indeed technically it's not the 'path' part 
for remote urls. And toDisplayString will remove any passwords (not sure there 
may be passwords here, but still, safer that way).

> dfaure wrote in copyjob.cpp:444
> I think this check is too early.
> 
> UDS_LOCAL_PATH is also set by kio_desktop and kio_remote, for instance.
> It's the main point of that entry: to map URLs from 
> kioslaves-that-wrap-the-local-file-system back to local paths.
> 
> AFAICS the old code would use UDS_LOCAL_PATH also for non-local-file URLs.

Excellent points; I was scratching my head trying to figure out what use 
UDS_LOCAL_PATH is when, while testing with qDebug(), it was _always_ empty, the 
only time it wasn't empty was in testtrash unit test, some code there set it, 
used it or something. So I resorted to grep'ing the code and I found the 
KCoreDirLister::cachedItemForUrl instance (which answers your next comment). So 
someone who knows all the use-cases of UDS_LOCAL_PATH (you in this case) 
should/must update the UDS_LOCAL_PATH docs :D

> dfaure wrote in copyjob.cpp:478
> The lambda is called after going back to the event loop, so this will have 
> happened anyway, no?
> I don't get it.
> 
> On the other hand I'm fine if this is done here, I'm just not sure why the 
> comment says it has to be so.
> 
> (Easy solution is to remove that comment, especially given the suggestion 
> below it won't even seem weird to do things in this order)

"The lambda is called after going back to the event loop, so this will have 
happened anyway, no?"
Good point (thanks for the info, I didn't think of the event loop POV).

However, right after the connect(), 'return' is called, so as not to call 
statCurrentSrc() on line 502, I want it called from the lambda _after_ the free 
space check job finishes. In one of the iterations working on this patch I got 
a race, where it would sometimes work and error out if there isn't enough free 
space at a remote dest, but some other times it would start copying; hence the 
"must" part; I don't recall the exact details though (I've been working on it 
for a couple of days, I tried so many stuff, the details of the trial and error 
are mushed all together at this point sorry :/)

So, I'll remove the comment or improve it to convey the idea in a clearer way.

> copyjob.cpp:479
> +// Must do this here before statCurrentSrc() is called in the lambda 
> connected to
> +// FileSystemFreeSpaceJob below
>  q->removeSubjob(job);

s/below/below, because return is called right after it, so that statCurrentSrc 
is called from the lambda/

does that sound better?

> dfaure wrote in copyjob.cpp:485
> Maybe you can move the if (m_dest.isLocalFile()) block here, and use `else`.
> It'll be clearer that free space check happens in both cases.

Looking at it again, removeSubjob can be called before the free disk space 
check, because it's statCurrentSrc that adds a new subJob (I was worried of 
calling removeSubjob too early).

> dfaure wrote in copyjob.cpp:486
> ... and this line is the same in both code paths, so it could be extracted to 
> before the if().
> 
> To avoid confusion between dest and m_dest, maybe rename this var to 
> destToCheck ?

actualDest sounds nicer.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29536: Adds a missing LibreOffice icon shortcut

[Manuel Jesús de la Fuente]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b94a72842766: Adds a missing LibreOffice icon shortcut 
(authored by manueljlin).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29536?vs=82281=82284

REVISION DETAIL
  https://phabricator.kde.org/D29536

AFFECTED FILES
  icons-dark/apps/16/libreoffice-startcenter.svg
  icons/apps/16/libreoffice-startcenter.svg

To: manueljlin, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29536: Adds a missing LibreOffice icon shortcut

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fixlo16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29536

To: manueljlin, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29536: Adds a missing LibreOffice icon shortcut

[Manuel Jesús de la Fuente]

manueljlin edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29536

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29536: Adds a missing LibreOffice icon shortcut

[Manuel Jesús de la Fuente]

manueljlin created this revision.
manueljlin added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
manueljlin requested review of this revision.

REVISION SUMMARY
  Makes the 16px icon actually show up

REPOSITORY
  R266 Breeze Icons

BRANCH
  fixlo16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29536

AFFECTED FILES
  icons-dark/apps/16/libreoffice-startcenter.svg
  icons/apps/16/libreoffice-startcenter.svg

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29527: Add MapProxySource

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1049:fa334cf9e809: Add MapProxySource (authored by ahiemstra).

REPOSITORY
  R1049 KQuickCharts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29527?vs=82256=82278

REVISION DETAIL
  https://phabricator.kde.org/D29527

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/MapProxySourceTest.cpp
  src/CMakeLists.txt
  src/ChartsPlugin.cpp
  src/datasource/MapProxySource.cpp
  src/datasource/MapProxySource.h

To: ahiemstra, mart
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham updated this revision to Diff 82276.
ngraham marked 4 inline comments as done.
ngraham added a comment.


  More control, less parseInt

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82274=82276

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> SpinBox.qml:49
> +if (wheel.angleDelta.y > 0 && control.value <= control.to) {
> +control.value = parseInt(control.value, 10) + 
> control.stepSize
> +valueModified()

`control.value` is already a numeric type as `control` is  a SpinBox, so you 
don't need to `parseInt` here. `control.value =+ control.stepSize`

> SpinBox.qml:50
> +control.value = parseInt(control.value, 10) + 
> control.stepSize
> +valueModified()
> +} else if (wheel.angleDelta.y < 0 && control.value >= 
> control.from) {

I think you would need to explicitly call this on `control`? 
`control.valueModified()`.

> SpinBox.qml:52
> +} else if (wheel.angleDelta.y < 0 && control.value >= 
> control.from) {
> +control.value = parseInt(control.value, 10) - 
> control.stepSize
> +valueModified()

`control.value =- control.stepSize`

> SpinBox.qml:53
> +control.value = parseInt(control.value, 10) - 
> control.stepSize
> +valueModified()
> +}

`control.valueModified()`.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham updated this revision to Diff 82274.
ngraham added a comment.


  Mark the value has having been modified after adjusting by scrolling

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82273=82274

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently adjusting the value by scrolling is not implemented. This patch 
implements it.

TEST PLAN
  [Coming soon]

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29527: Add MapProxySource

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  works perfectly :)

REPOSITORY
  R1049 KQuickCharts

BRANCH
  mapproxysource

REVISION DETAIL
  https://phabricator.kde.org/D29527

To: ahiemstra, mart
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> previewjob.cpp:173
> +
> +void PreviewJob::setDefaultDevicePixelRatio(qreal defaultDevicePixelRatio) {
> +s_defaultDevicePixelRatio = defaultDevicePixelRatio;

coding style: '{' on separate line

> thumbcreator.cpp:52
> +
> +bool ThumbCreatorV3::create(const QString , int width, int height, 
> QImage ) {
> +return createV3(path, width, height, img, 1);

'{' on its own line for methods

> thumbcreator.h:215
> + * @param img The QImage to store the preview in.
> + * @param devicePixelRatio
> + *

docu?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 92 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/92/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 08 May 2020 12:24:54 +
 Build duration:
9 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 179 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/179/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 08 May 2020 12:24:54 +
 Build duration:
2 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 972 lines...][2020-05-08T12:26:28.997Z]Creating library lib\http.lib and object lib\http.exp[2020-05-08T12:26:29.623Z] [222/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\commandlauncherjob.cpp.obj[2020-05-08T12:26:29.891Z] [223/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kiod_kpasswdserver_autogen\mocs_compilation.cpp.obj[2020-05-08T12:26:29.891Z] [224/732] Generating kpasswdserveradaptor.cpp, kpasswdserveradaptor.h[2020-05-08T12:26:29.891Z] [225/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kiod_kpasswdserver.cpp.obj[2020-05-08T12:26:29.891Z] [226/732] Generating kpasswdserveradaptor.moc[2020-05-08T12:26:30.864Z] [227/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\faviconrequestjob.cpp.obj[2020-05-08T12:26:30.864Z] [228/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\applicationlauncherjob.cpp.obj[2020-05-08T12:26:31.146Z] [229/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kprocessrunner.cpp.obj[2020-05-08T12:26:31.146Z] ..\src\gui\kprocessrunner.cpp(227): warning C4551: function call missing argument list[2020-05-08T12:26:31.426Z] [230/732] Linking CXX shared module bin\kf5\kiod\kssld.dll[2020-05-08T12:26:31.426Z]Creating library lib\kssld.lib and object lib\kssld.exp[2020-05-08T12:26:31.426Z]Creating library lib\kssld.lib and object lib\kssld.exp[2020-05-08T12:26:31.714Z] [231/732] Generating kioexecdadaptor.cpp, kioexecdadaptor.h[2020-05-08T12:26:31.714Z] [232/732] Generating kioexecdadaptor.moc[2020-05-08T12:26:32.716Z] [233/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openurljobhandlerinterface.cpp.obj[2020-05-08T12:26:32.716Z] [234/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T12:26:32.716Z] [235/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kiogui_debug.cpp.obj[2020-05-08T12:26:33.006Z] [236/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\KF5KIOGui_autogen\mocs_compilation.cpp.obj[2020-05-08T12:26:33.280Z] [237/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openurljob.cpp.obj[2020-05-08T12:26:33.588Z] [238/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\favicons_debug.cpp.obj[2020-05-08T12:26:33.588Z] [239/732] Building CXX object autotests\CMakeFiles\upurltest.dir\upurltest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:26:33.897Z] [240/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserver.cpp.obj[2020-05-08T12:26:34.198Z] [241/732] Automatic MOC for target kacltest[2020-05-08T12:26:34.514Z] [242/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:26:35.976Z] [243/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecd_autogen\mocs_compilation.cpp.obj[2020-05-08T12:26:35.976Z] [244/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecdebug.cpp.obj[2020-05-08T12:26:36.612Z] [245/732] Automatic MOC for target listdirtest[2020-05-08T12:26:36.612Z] [246/732] Automatic MOC for target kmountpointtest[2020-05-08T12:26:37.225Z] [247/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T12:26:37.225Z] [248/732] Linking CXX shared library bin\KF5KIOGui.dll[2020-05-08T12:26:37.225Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T12:26:37.225Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T12:26:37.225Z] [249/732] Building CXX object autotests\CMakeFiles\upurltest.dir\upurltest.cpp.obj[2020-05-08T12:26:37.225Z] [250/732] Building CXX object autotests\CMakeFiles\kacltest.dir\kacltest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:26:37.502Z] [251/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest.cpp.obj[2020-05-08T12:26:37.804Z] [252/732] Linking CXX shared module bin\kf5\kiod\kpasswdserver.dll[2020-05-08T12:26:37.804Z]Creating library lib\kpasswdserver.lib and object lib\kpasswdserver.exp[2020-05-08T12:26:37.804Z]Creating library lib\kpasswdserver.lib and object lib\kpasswdserver.exp[2020-05-08T12:26:41.442Z] [253/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecdadaptor.cpp.obj[2020-05-08T12:26:41.442Z] [254/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\__\kpasswdserver.cpp.obj[2020-05-08T12:26:41.442Z] [255/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecd.cpp.obj[2020-05-08T12:26:41.442Z] [256/732] Linking CXX executable 

D29397: KPreviewJob : Support for DeviceRatioPixel

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D29397#666134 , @meven wrote:
  
  > In D29397#666132 , @kossebau 
wrote:
  >
  > > For another stupid question (the first one was already asked by someone 
else and answered :) ):
  > >  Given some generated thumbnails are cached, does the thumbnail cache 
specification support logical resolution?
  >
  >
  > I am evolving here the specification : the images stored are stored with 
their HiDpi size (width * dpr, height * dpr), and then some metadata is written.
  
  
  Specification as in, 
https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html?
 So there is some work on extending the specs not yet reflected on that page?
  How is the metadata written?
  
  >> How would cached thumbnails work cross-screen?
  > 
  > Cache thumbnails with low dpr will look blurry on hidpi screen, other than 
that's not an issue.
  
  Cached thumbnails rendered for hidpi (so e.g. being 256x256 with bigger 
details due to hidpi context) , but used for lowdpi elsewhere will be an issue 
as well. E.g. when it comes to text rendered with minfontsize like in case of 
plain text documents, it will be too large then.
  
  I wonder if the thumbnail cache would not need the same extension like the 
icon spec had, with a @2x variant, to make up for that. There are still a lot 
of lowdpi devices out there, and they are getting mixed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/91/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 08 May 2020 11:58:25 +
 Build duration:
8 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiogui_openurljobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29528: [OpenUrlJob] Improve comments/docs

[David Faure]

dfaure added a comment.


  Thanks!

INLINE COMMENTS

> openurljob.cpp:393
> +if (mime.isValid() && mimeName != m_mimeTypeName) {
> +m_mimeTypeName =mimeName;
>  }

missing space after '='

> openurljob.cpp:590
> +const QMimeType mimeType = db.mimeTypeForName(m_mimeTypeName);
> +if (isExecutableMime(mimeType) && handleExecutables(mimeType)) {
> +return;

That one was on purpose. I find this version less readable, mixing a test and 
an actual action (with error handling).

> openurljob.h:114
>   * Starts the job.
> - * You must call this, after having done all the setters.
> + * You must call this, after having called all the needed setters.
>   * This is a GUI job, never use exec(), it would block user interaction.

I think I used the sentence in the two LauncherJobs, feel free to make the same 
change here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29528

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 178 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/178/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 08 May 2020 11:58:25 +
 Build duration:
3 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 981 lines...][2020-05-08T12:01:38.952Z] [228/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kiod_kpasswdserver_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:39.559Z] [229/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\favicons_debug.cpp.obj[2020-05-08T12:01:39.559Z] [230/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kprocessrunner.cpp.obj[2020-05-08T12:01:39.559Z] ..\src\gui\kprocessrunner.cpp(227): warning C4551: function call missing argument list[2020-05-08T12:01:39.559Z] [231/732] Generating kioexecdadaptor.cpp, kioexecdadaptor.h[2020-05-08T12:01:39.828Z] [232/732] Generating kioexecdadaptor.moc[2020-05-08T12:01:39.828Z] [233/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\commandlauncherjob.cpp.obj[2020-05-08T12:01:39.828Z] [234/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\KF5KIOGui_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:40.436Z] [235/732] Automatic MOC for target kcookiejartest[2020-05-08T12:01:40.694Z] [236/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\applicationlauncherjob.cpp.obj[2020-05-08T12:01:40.694Z] [237/732] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kiogui_debug.cpp.obj[2020-05-08T12:01:41.275Z] [238/732] Automatic MOC for target kfileitemtest[2020-05-08T12:01:41.860Z] [239/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:42.476Z] [240/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T12:01:42.773Z] [241/732] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kpasswdserver.cpp.obj[2020-05-08T12:01:43.063Z] [242/732] Automatic MOC for target upurltest[2020-05-08T12:01:43.358Z] [243/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecd_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:43.358Z] [244/732] Building CXX object autotests\CMakeFiles\upurltest.dir\upurltest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:43.943Z] [245/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecdebug.cpp.obj[2020-05-08T12:01:43.943Z] [246/732] Building CXX object autotests\CMakeFiles\kfileitemtest.dir\kfileitemtest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:43.943Z] [247/732] Automatic MOC for target dataprotocoltest[2020-05-08T12:01:44.579Z] [248/732] Linking CXX shared library bin\KF5KIOGui.dll[2020-05-08T12:01:44.579Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T12:01:44.579Z]Creating library lib\KF5KIOGui.lib and object lib\KF5KIOGui.exp[2020-05-08T12:01:44.579Z] [249/732] Automatic MOC for target jobtest[2020-05-08T12:01:44.579Z] [250/732] Automatic MOC for target jobremotetest[2020-05-08T12:01:44.852Z] [251/732] Automatic MOC for target kprotocolinfotest[2020-05-08T12:01:46.285Z] [252/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest.cpp.obj[2020-05-08T12:01:46.285Z] [253/732] Building CXX object autotests\CMakeFiles\kprotocolinfotest.dir\kprotocolinfotest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:46.861Z] [254/732] Linking CXX shared module bin\kf5\kiod\kpasswdserver.dll[2020-05-08T12:01:46.861Z]Creating library lib\kpasswdserver.lib and object lib\kpasswdserver.exp[2020-05-08T12:01:46.861Z]Creating library lib\kpasswdserver.lib and object lib\kpasswdserver.exp[2020-05-08T12:01:47.156Z] [255/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdserveradaptor.cpp.obj[2020-05-08T12:01:47.425Z] [256/732] Automatic MOC for target mkpathjobtest[2020-05-08T12:01:47.692Z] [257/732] Automatic MOC for target ktcpsockettest[2020-05-08T12:01:47.981Z] [258/732] Automatic MOC for target kmountpointtest[2020-05-08T12:01:47.981Z] [259/732] Automatic MOC for target listdirtest[2020-05-08T12:01:47.981Z] [260/732] Building CXX object src\kioexec\CMakeFiles\kioexecd.dir\kioexecdadaptor.cpp.obj[2020-05-08T12:01:47.981Z] [261/732] Building CXX object autotests\CMakeFiles\kfileitemtest.dir\kfileitemtest.cpp.obj[2020-05-08T12:01:47.981Z] [262/732] Building CXX object autotests\CMakeFiles\mkpathjobtest.dir\mkpathjobtest_autogen\mocs_compilation.cpp.obj[2020-05-08T12:01:48.266Z] [263/732] Building CXX object autotests\CMakeFiles\upurltest.dir\upurltest.cpp.obj[2020-05-08T12:01:48.888Z] [264/732] Automatic MOC for target kacltest[2020-05-08T12:01:49.192Z] [265/732] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\__\kpasswdserver.cpp.obj[2020-05-08T12:01:50.628Z] [266/732] Building CXX object 

D19080: Make file overwrite a bit safer

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dfaure wrote in jobtest.cpp:1759
> The other problems were fixed, but this test still fails randomly.
> 
> In fact, why are we checking that the dest file already started to be created 
> when totalSize is emitted?
> Surely copying involves looking at the src file first, emitting totalSize, 
> and *then* starting to create the destination, no?
> 
> Maybe it's not totalSize we should connect to, but more of a progress 
> signal

Done in https://commits.kde.org/kio/30d74b814f794e52fa4561181b7b864558144e3a

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19080

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29528: [OpenUrlJob] Improve comments/docs

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  l-late (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29528

AFFECTED FILES
  src/gui/openurljob.cpp
  src/gui/openurljob.h
  src/gui/openurljobhandlerinterface.h
  src/widgets/kdesktopfileactions.cpp
  src/widgets/kopenwithdialog.cpp
  src/widgets/krun.cpp
  src/widgets/widgetsopenurljobhandler.h

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven added a comment.


  In D29397#666132 , @kossebau wrote:
  
  > For another stupid question (the first one was already asked by someone 
else and answered :) ):
  >  Given some generated thumbnails are cached, does the thumbnail cache 
specification support logical resolution?
  
  
  I am evolving here the specification : the images stored are stored with 
their HiDpi size (width * dpr, height * dpr), and then some metadata is written.
  When reading the cached version for large, the user expects a 256*256 (modulo 
aspect ratio) and can find a (256 * dpr, 256 * dpr) image (or can read the 
devicePixelRatio from metadata)
  You can see in https://phabricator.kde.org/D29526#C575294OL738 and line 582 
how to detect and handle such a case.
  
  > How would cached thumbnails work cross-screen?
  
  Cache thumbnails with low dpr will look blurry on hidpi screen, other than 
that's not an issue.
  We would need applications to update to use Hidpi thumbnails to renew 
thumbnails.
  I might want to evict low dpr thumbnails.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Friedrich W. H. Kossebau]

kossebau added a comment.


  For another stupid question (the first one was already asked by someone else 
and answered :) ):
  Given some generated thumbnails are cached, does the thumbnail cache 
specification support logical resolution? How would cached thumbnails work 
cross-screen?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29525: Make Previews devicePixelRatio aware

[Méven Car]

meven added a reviewer: elvisangelaccio.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29525

To: meven, #dolphin, #frameworks, dfaure, ngraham, elvisangelaccio
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, 
fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29525: Make Previews devicePixelRatio aware

[Méven Car]

meven edited the summary of this revision.
meven edited the test plan for this revision.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29525

To: meven, #dolphin, #frameworks, dfaure, ngraham
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, 
fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29525: Make Previews devicePixelRatio aware

[Méven Car]

meven updated this revision to Diff 82257.
meven added a comment.


  Fix

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29525?vs=82253=82257

BRANCH
  arcpatch-D29525

REVISION DETAIL
  https://phabricator.kde.org/D29525

AFFECTED FILES
  src/main.cpp

To: meven, #dolphin, #frameworks, dfaure, ngraham
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, 
fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

[Ahmad Samir]

ahmadsamir added a comment.


  In D29385#664552 , @dfaure wrote:
  
  > -void KIO::OpenUrlJob::setRunFlags(KIO::ApplicationLauncherJob::RunFlags 
runFlags)
  >  +void KIO::OpenUrlJob::setDeleteTemporaryFile(bool b)
  >
  > The more I think about it, the least I like the use of flags here.
  >
  > 1. they are from the wrong class as Kai-Uwe pointed out, but more 
importantly:
  > 2. the other bool setters here are for unrelated concerns, better keep them 
separate.
  >
  >   Are we doing lineEdit->setDragEnabled(true); 
lineEdit->setClearButtonEnabled(true); lineEdit->setReadOnly(true); or are we 
doing lineEdit->setFlags(QLineEdit::DragEnabled | QLineEdit::ClearButtonEnabled 
| QLineEdit::ReadOnly)?
  
  
  I vote:
  lineEdit->setDragEnabled(true); lineEdit->setClearButtonEnabled(true); 
lineEdit->setReadOnly(true);
  it's:
  
  - more readable, and easier to use (similar methods are used through out Qt 
code)
  - avoids the case you talked about, of the user setting nonsensical, from the 
code POV, flags.
  
  I was too slow working my way through this short story^W^W review, so I've 
gathered my other comments (mostly code style, docs changes...etc) in a diff, 
that I'll submit shortly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29385

To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, 
svuorela
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute

[David Faure]

dfaure closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29524

To: dfaure, cgiboudeaux, vatra, kfunk, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29527: Add MapProxySource

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  A source that provides values from a map based on keys from a different
  source.

TEST PLAN
  The auto test passes.

REPOSITORY
  R1049 KQuickCharts

BRANCH
  mapproxysource

REVISION DETAIL
  https://phabricator.kde.org/D29527

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/MapProxySourceTest.cpp
  src/CMakeLists.txt
  src/ChartsPlugin.cpp
  src/datasource/MapProxySource.cpp
  src/datasource/MapProxySource.h

To: ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  tested successfully with the openSUSE package which uses absolute paths

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29524

To: dfaure, cgiboudeaux, vatra, kfunk, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven updated this revision to Diff 82255.
meven marked an inline comment as done.
meven added a comment.


  Improve naming of a variable, fix scaling of the resulting preview

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29397?vs=82079=82255

BRANCH
  preview-dpr

REVISION DETAIL
  https://phabricator.kde.org/D29397

AFFECTED FILES
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/thumbcreator.cpp
  src/widgets/thumbcreator.h

To: meven, dfaure, broulik, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D19080: Make file overwrite a bit safer

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> jobtest.cpp:1759
> +Q_UNUSED(totalSize);
> +QCOMPARE(destFileExists,  QFile::exists(destPartFile));
> +});

The other problems were fixed, but this test still fails randomly.

In fact, why are we checking that the dest file already started to be created 
when totalSize is emitted?
Surely copying involves looking at the src file first, emitting totalSize, and 
*then* starting to create the destination, no?

Maybe it's not totalSize we should connect to, but more of a progress signal

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19080

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29526: Thumbnails: make thumbnail generation dpr-aware

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, dfaure, broulik, sitter, ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Thumbnail ioslave can now receive a devicePixelRatio metadata parameter, that 
it will pass to its thumbnail creators plugins implementing ThumbCreatorV3.
  It updates the directory thumbnail generation.
  
  Port image, jpeg, djvu, krita, svg, text to new ThumbCreatorV3.
  
  Depends on D29397 

TEST PLAN
  Manualy tested
  With dolphin D29525 

REPOSITORY
  R320 KIO Extras

BRANCH
  thumbnail-dpr

REVISION DETAIL
  https://phabricator.kde.org/D29526

AFFECTED FILES
  CMakeLists.txt
  thumbnail/djvucreator.cpp
  thumbnail/djvucreator.h
  thumbnail/imagecreator.cpp
  thumbnail/imagecreator.h
  thumbnail/jpegcreator.cpp
  thumbnail/jpegcreator.h
  thumbnail/kritacreator.cpp
  thumbnail/kritacreator.h
  thumbnail/svgcreator.cpp
  thumbnail/svgcreator.h
  thumbnail/textcreator.cpp
  thumbnail/textcreator.h
  thumbnail/thumbnail.cpp
  thumbnail/thumbnail.h

To: meven, #frameworks, dfaure, broulik, sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven added a dependent revision: D29526: Thumbnails: make thumbnail generation 
dpr-aware.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven added a dependent revision: D29525: Make Previews devicePixelRatio aware.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29525: Make Previews devicePixelRatio aware

[Méven Car]

meven created this revision.
meven added reviewers: Dolphin, Frameworks, dfaure, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
meven requested review of this revision.

REVISION SUMMARY
  Depends on D29397 
  And kio-extras patch.

TEST PLAN
  rm -r ~/.cache/local

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29525

AFFECTED FILES
  src/main.cpp

To: meven, #dolphin, #frameworks, dfaure, ngraham
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, 
fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29381: Thumbnail text: use libmagic to detect encoding

[Méven Car]

meven updated this revision to Diff 82252.
meven added a comment.


  Oops

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29381?vs=82251=82252

BRANCH
  D29381

REVISION DETAIL
  https://phabricator.kde.org/D29381

AFFECTED FILES
  CMakeLists.txt
  cmake/Findlibmagic.cmake
  thumbnail/CMakeLists.txt
  thumbnail/config-thumbnail.h.cmake
  thumbnail/textcreator.cpp

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29381: Thumbnail text: use libmagic to detect encoding

[Méven Car]

meven updated this revision to Diff 82251.
meven added a comment.


  Make Thumbnail ioslave devicePixelRatio capable

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29381?vs=81786=82251

BRANCH
  thumbnail-dpr

REVISION DETAIL
  https://phabricator.kde.org/D29381

AFFECTED FILES
  CMakeLists.txt
  cmake/Findlibmagic.cmake
  thumbnail/CMakeLists.txt
  thumbnail/config-thumbnail.h.cmake
  thumbnail/djvucreator.cpp
  thumbnail/djvucreator.h
  thumbnail/imagecreator.cpp
  thumbnail/imagecreator.h
  thumbnail/jpegcreator.cpp
  thumbnail/jpegcreator.h
  thumbnail/kritacreator.cpp
  thumbnail/kritacreator.h
  thumbnail/svgcreator.cpp
  thumbnail/svgcreator.h
  thumbnail/textcreator.cpp
  thumbnail/textcreator.h
  thumbnail/thumbnail.cpp
  thumbnail/thumbnail.h

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute

[David Faure]

dfaure created this revision.
dfaure added reviewers: cgiboudeaux, vatra, kfunk, apol, vkrause.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  works as before for the case where it's relative.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29524

AFFECTED FILES
  modules/ECMGeneratePriFile.cmake

To: dfaure, cgiboudeaux, vatra, kfunk, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 83 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/83/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 08 May 2020 09:41:59 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)57%
(35728/62884)41%
(18201/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(10123/10592)46%
(4736/10224)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)60%
(8650/14382)52%
(4547/8738)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(627/812)61%
(377/618)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(425/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 90 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/90/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 08 May 2020 09:42:01 +
 Build duration:
8 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_openurljobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 580 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/580/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 May 2020 09:41:59 +
 Build duration:
7 min 17 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)57%
(35716/62882)41%
(18195/44550)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(10123/10593)46%
(4742/10224)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)60%
(8645/14382)52%
(4540/8738)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(627/812)61%
(377/618)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(425/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 177 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/177/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 08 May 2020 09:41:58 +
 Build duration:
5 min 35 sec and counting