Re: Extending the license policy to include ODbL-1.0

[Alexander Potashev]

Thank you Volker!

On Thu, Sep 23, 2021 at 6:01 PM Volker Krause  wrote:
>
> done
>
> On Mittwoch, 22. September 2021 23:20:56 CEST Alexander Potashev wrote:
> > Thanks!
> >
> > Could you please update the changelog section
> > https://community.kde.org/Policies/Licensing_Policy#Changelog ?
> >
> > On Wed, Sep 22, 2021 at 5:38 PM Volker Krause  wrote:
> > > Thanks everyone, I've added the suggested change to the wiki now.
> > >
> > > Regards,
> > > Volker
> > >
> > > On Mittwoch, 15. September 2021 17:26:57 CEST Volker Krause wrote:
> > > > Hi,
> > > >
> > > > there's a MR [1] for ki18n containing data tables generated from OSM
> > > > data,
> > > > which implies the ODbL-1.0 license [2]. We also already have other
> > > > places
> > > > ([3], [4]) actually doing this.
> > > >
> > > > However that's a license not yet covered by our license policy, so I
> > > > suggest we add it.
> > > >
> > > > ODbL is essentially LGPL-y but for data rather than code, so
> > > > conceptually
> > > > compatible with our existing licensing.
> > > >
> > > > It's also not like there's any viable alternative to OSM data, so not
> > > > doing
> > > > this would imply not being able to implement features integrating
> > > > OSM-derived data.
> > > >
> > > > The proposed addition to the policy section of
> > > > https://community.kde.org/
> > > > Policies/Licensing_Policy would be:
> > > >
> > > >
> > > > # ''Geographic data'', in particular data based on or derived from
> > > > OpenStreetMap may be licensed under the '''[https://spdx.org/licenses/
> > > > ODbL-1.0.html Open Data Commons Open Database License v1.0]'''.
> > > >
> > > >
> > > > What do you think?
> > > >
> > > > Regards,
> > > > Volker
> > > >
> > > > [1] https://invent.kde.org/frameworks/ki18n/-/merge_requests/19
> > > > [2] https://spdx.org/licenses/ODbL-1.0.html
> > > > [3]
> > > > https://invent.kde.org/pim/kitinerary/-/blob/master/src/lib/knowledgedb
> > > > / timezonedb_data.cpp
> > > > [4]
> > > > https://invent.kde.org/libraries/kpublictransport/-/blob/master/src/lib
> > > > / knowledgedb/linemetadata_data.cpp
>


-- 
Alexander Potashev

Re: Extending the license policy to include ODbL-1.0

[Alexander Potashev]

Thanks!

Could you please update the changelog section
https://community.kde.org/Policies/Licensing_Policy#Changelog ?

On Wed, Sep 22, 2021 at 5:38 PM Volker Krause  wrote:
>
> Thanks everyone, I've added the suggested change to the wiki now.
>
> Regards,
> Volker
>
> On Mittwoch, 15. September 2021 17:26:57 CEST Volker Krause wrote:
> > Hi,
> >
> > there's a MR [1] for ki18n containing data tables generated from OSM data,
> > which implies the ODbL-1.0 license [2]. We also already have other places
> > ([3], [4]) actually doing this.
> >
> > However that's a license not yet covered by our license policy, so I suggest
> > we add it.
> >
> > ODbL is essentially LGPL-y but for data rather than code, so conceptually
> > compatible with our existing licensing.
> >
> > It's also not like there's any viable alternative to OSM data, so not doing
> > this would imply not being able to implement features integrating
> > OSM-derived data.
> >
> > The proposed addition to the policy section of https://community.kde.org/
> > Policies/Licensing_Policy would be:
> >
> >
> > # ''Geographic data'', in particular data based on or derived from
> > OpenStreetMap may be licensed under the '''[https://spdx.org/licenses/
> > ODbL-1.0.html Open Data Commons Open Database License v1.0]'''.
> >
> >
> > What do you think?
> >
> > Regards,
> > Volker
> >
> > [1] https://invent.kde.org/frameworks/ki18n/-/merge_requests/19
> > [2] https://spdx.org/licenses/ODbL-1.0.html
> > [3] https://invent.kde.org/pim/kitinerary/-/blob/master/src/lib/knowledgedb/
> > timezonedb_data.cpp
> > [4] https://invent.kde.org/libraries/kpublictransport/-/blob/master/src/lib/
> > knowledgedb/linemetadata_data.cpp
>


-- 
Alexander Potashev

Re: Information regarding upcoming Gitlab Migration

[Alexander Potashev]

On Fri, May 1, 2020 at 10:14 PM Ben Cooksley  wrote:
> On Sat, May 2, 2020 at 6:17 AM Alexander Potashev  
> wrote:
> > I have a similar use case. Sometimes I need to share a URL to a
> > project. For this purpose I used to share e.g.
> > https://cgit.kde.org/releaseme.git/about
> >
> > Does this migration make such permalinks impossible?
> >
> >
> > From what I see, we lose permalinks because
> >  1. cgit.kde.org will be discontinued
>
> We provide the commits.kde.org redirector for permanent links.
> Anywhere needing a long life link to a particular repository, commit,
> etc (like documentation) should be using these links and not anything
> else.

This is helpful. Thank you Ben!

-- 
Alexander Potashev

Re: Information regarding upcoming Gitlab Migration

[Alexander Potashev]

On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah  wrote:
> Use case 4 : Tom is a student in Germany and is interested in
> contributing to wikitolearn, and he asks where can I find code of the
> wikitolearn?

Hi,

I have a similar use case. Sometimes I need to share a URL to a
project. For this purpose I used to share e.g.
https://cgit.kde.org/releaseme.git/about

Does this migration make such permalinks impossible?


>From what I see, we lose permalinks because
 1. cgit.kde.org will be discontinued
 2. A once valid URL https://invent.kde.org/games/knetwalk may become
unavailable if the project moves to another group, for example
https://invent.kde.org/unmaintained/knetwalk

--
Alexander Potashev

D26168: i18n: Split translations for strings "Translation"

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:cfa4f04d4303: i18n: Split translations for strings 
Translation (authored by aspotashev).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26168?vs=72025=72787

REVISION DETAIL
  https://phabricator.kde.org/D26168

AFFECTED FILES
  src/kaboutapplicationdialog.cpp
  src/kaboutplugindialog.cpp
  src/kbugreport.cpp

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26170: i18n: Add more semantic context strings

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:b834a855bf29: i18n: Add more semantic context strings 
(authored by aspotashev).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26170?vs=72028=72788

REVISION DETAIL
  https://phabricator.kde.org/D26170

AFFECTED FILES
  src/kaboutapplicationdialog.cpp
  src/kaboutapplicationpersonlistdelegate_p.cpp
  src/kaboutkdedialog_p.cpp
  src/kaboutplugindialog.cpp
  src/kactionconflictdetector.cpp
  src/kbugreport.cpp
  src/kedittoolbar.cpp
  src/kkeysequencewidget.cpp
  src/klicensedialog_p.cpp
  src/kmenumenuhandler_p.cpp
  src/kshortcuteditwidget.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutsdialog.cpp
  src/kswitchlanguagedialog_p.cpp
  src/ktoolbar.cpp

To: aspotashev, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

[Alexander Potashev]

aspotashev added a comment.


  In D26168#581665 , @kossebau wrote:
  
  > Seems you went fully "at it", good work :)
  >
  > "after string freeze" meant "after relase tagging for string freeze 
reasons" , right? ;)
  
  
  Yes, of course.

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

[Alexander Potashev]

aspotashev added a comment.


  will try to push around January 5, 2020 after string freeze

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26170: i18n: Add more semantic context strings

[Alexander Potashev]

aspotashev added a comment.


  will try to push around January 5, 2020 after string freeze

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26170

To: aspotashev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

[Alexander Potashev]

aspotashev added a comment.


  In D26168#581637 , @kossebau wrote:
  
  > Looks good to me for what I know as programmer, but none-translator :)
  >  While at it, for consistency the other tab titles could also get a 
"@title:tab" UI marker context?
  
  
  While at it, yes
  
  https://phabricator.kde.org/D26170

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26170: i18n: Add more semantic context strings

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  it compiles

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-more-msgctxt

REVISION DETAIL
  https://phabricator.kde.org/D26170

AFFECTED FILES
  src/kaboutapplicationdialog.cpp
  src/kaboutapplicationpersonlistdelegate_p.cpp
  src/kaboutkdedialog_p.cpp
  src/kaboutplugindialog.cpp
  src/kactionconflictdetector.cpp
  src/kbugreport.cpp
  src/kedittoolbar.cpp
  src/kkeysequencewidget.cpp
  src/klicensedialog_p.cpp
  src/kmenumenuhandler_p.cpp
  src/kshortcuteditwidget.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutsdialog.cpp
  src/kswitchlanguagedialog_p.cpp
  src/ktoolbar.cpp

To: aspotashev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

[Alexander Potashev]

aspotashev added a subscriber: kossebau.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  it compiles

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

AFFECTED FILES
  src/kaboutapplicationdialog.cpp
  src/kaboutplugindialog.cpp
  src/kbugreport.cpp

To: aspotashev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

[Alexander Potashev]

aspotashev added a comment.


  In D25720#572291 , @ngraham wrote:
  
  > Though Dolphin seems to have some kind of local hack to make Shift+delete 
work for file deletion. But it doesn't work for Cut. It's all pretty messy.
  
  
  I don't know the internals of Dolphin, but it works. And I still don't get 
why we need to change anything in KConfig.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25720

To: ngraham, #frameworks, cfeck
Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

[Alexander Potashev]

aspotashev added a comment.


  What are the applications where both actions are used and thus one may notice 
this conflict?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25720

To: ngraham, #frameworks, cfeck
Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25638: autotests: Find perl executable on all platforms

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all 
platforms (authored by aspotashev).

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25638?vs=70636=70663

REVISION DETAIL
  https://phabricator.kde.org/D25638

AFFECTED FILES
  autotests/CMakeLists.txt

To: aspotashev, #frameworks, dfaure
Cc: dfaure, apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, 
GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25638: autotests: Find perl executable on all platforms

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:93
> maybe it would make sense to check for BSD instead?
> I don't know much about BSD, but I'd expect the shebang to work there as well.

I think it's better to minimize platform-specific if-endifs and make CMake code 
clean rather  than micro-optimize per platform.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25638: autotests: Find perl executable on all platforms

[Alexander Potashev]

aspotashev added a reviewer: Frameworks.
aspotashev added a project: Frameworks.
aspotashev added a subscriber: Frameworks.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, dcaliste, 
michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, 
knauss, dvratil

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[Alexander Potashev]

.RecursOn_LibICal_TestCase31.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase32.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase33.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase34.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase35.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase36.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase37.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase38.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase39.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase40.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase41.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase42.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase43.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase44.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase45.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase46.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase48.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase49.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase50.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase51.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase54.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase55.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase56.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_LibICal_TestCase57.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_PayDay.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest01.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest02.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest03.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest04.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest05.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest06.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest07.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest08.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest09.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest10.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest11.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest12.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest13.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest14.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest15.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest16.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest17.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest18.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest19.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest20.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest21.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest22.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest23.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest24.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest25.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest26.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest27.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest28.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest29.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest30.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest31.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest32.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest33.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest34.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest35.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest36.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest36U.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest37.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest38.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest39.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest40.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_RFC2445_RRULETest41.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_Until_TestCase02.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_Until_TestCase03.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_Until_TestCase04.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_Until_TestCase05.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_Until_TestCase06.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_anniversary_4.6.1.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_daily.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_exdate.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_hourly.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_lastworkday.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_monthly.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_rdate.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_test1.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_weekly.ics*
>
>
> * - Failed: projectroot.autotests.RecursOn_yearly.ics*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase01.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase02.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase03.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase04.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase05.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase06.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase07.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase08.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase09.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase10.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase11.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase12.vcs*
>
>
> * - Failed: projectroot.autotests.VCalIn_KOrganizer_vCalTestCase13.vcs*
>
>
> * - Failed: projectroot.autotests.testcalendarobserver*
>
>
> * - Failed: projectroot.autotests.testicaltimezones*
>
>
> * - Failed: projectroot.autotests.testrecurtodo*
>


-- 
Alexander Potashev

D25530: Sonnet: Add locales that are missing in QLocale

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> waqar wrote in loader.cpp:255
> I used wikipedia and the description files provided with the dictionaries for 
> this information. It may not be correct however. If you know the language or 
> the rules, please feel free to correct me and I will amend the commit 
> accordingly

There may be different consistent approaches to capitalization:

1. Use the spelling like if the language name comes in the middle of a 
sentence. This implies all-lowercase spelling for many Cyrillic-based 
languages, e.g. "русский" for Russian.
2. Use the spelling like if the language name comes in the beginning of a 
sentence. In many languages that means that first letter is in uppercase, e.g. 
"Русский" for Russian.

I don't know which of these approaches is taken by Qt, but we should follow the 
pattern. Until then, I can't say how to fix this patch.

---

After having a look on the Qt source code (qlocale_unix.cpp, qlocale_win.cpp) 
I'm not sure where do these native language names from on Unix/Linux. 
QSystemLocale::query() as defined in qlocale_unix.cpp seems to returns an empty 
QVariant.

I think it would be really helpful if we add unit tests for this 
Loader::languageNameForCode() method.

---

I don't know these languages, however I can read Russian and at least detect 
capital letters in languages that mostly reuse the Russian alphabet.

Now so sure about Chuvash language anymore because English Wikipedia says 
"Чӑвашла" while Russian 
Wikipedia and many other resources in Russian say "чӑвашла", e.g. 
https://en.wiktionary.org/wiki/чӑваш_чӗлхи

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> loader.cpp:255
> +{QLatin1String("cv"),  {QStringLiteral("Чӑвашла"),   
> QString()}},  //Chuvash
> +{QLatin1String("cv_RU"),   {QStringLiteral("Чӑвашла"),   
> QStringLiteral("Россия")}},
> +{QLatin1String("grc"), {QStringLiteral("Αρχαία Ελληνικά"),   
> QString()}},  //Ancient Greek

Is there any rule behind your decision to spell some language names capitalized 
and some others not capitalized?

Examples:

- Чӑвашла - first letter is capital
- коми - all letters in lowercase

I didn't find any indication that these languages might have a rule to 
capitalize language names like English has.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D19498: loadLibrary: Use enum values to define what type of plugin we load

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R317:f6a65feda870: loadLibrary: Use enum values to define what 
type of plugin we load (authored by aspotashev).

REPOSITORY
  R317 Kross

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19498?vs=53083=69890

REVISION DETAIL
  https://phabricator.kde.org/D19498

AFFECTED FILES
  src/core/manager.cpp

To: aspotashev, #frameworks, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19498: loadLibrary: Use enum values to define what type of plugin we load

[Alexander Potashev]

aspotashev added a comment.


  ping?

REPOSITORY
  R317 Kross

REVISION DETAIL
  https://phabricator.kde.org/D19498

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: New Framework Review: KDAV

[Alexander Potashev]

вс, 10 нояб. 2019 г. в 15:44, David Faure :
>
> On samedi 9 novembre 2019 21:14:46 CET Alexander Potashev wrote:
> > сб, 9 нояб. 2019 г. в 14:37, Volker Krause :
> > > during Akademy there was a request to promote KDAV from KDE PIM to
> > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements
> > > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It
> > > would be classified as a functional tier 3 framework.
> >
> > Hi Volker,
> >
> > The name "KDAV" suggests that it might implement WebDAV. Do you think
> > if it should be renamed to something like "DAVExtensions" or let's say
> > "AnyDAV"?
>
> The name seems fine to me. The substring "DAV" appears just as much in WebDAV
> as it does in CalDav/CardDav/GroupDav. So there's no reason to infer "WebDAV"
> from "KDAV".
>
> "Extensions" sounds very optional, and "AnyDAV" looks like yet-another WebDAV-
> based protocol in itself.
>
> The issue you see is that someone looking for WebDAV support might end up
> thinking KDAV is the right thing to use? Well, maybe it should be, i.e. this
> would probably be the right place for some proper future WebDAV API compared
> to using kio_http with metadata directly

OK. LGTM as well after your explanation.

-- 
Alexander Potashev

Re: New Framework Review: KDAV

[Alexander Potashev]

сб, 9 нояб. 2019 г. в 14:37, Volker Krause :
> during Akademy there was a request to promote KDAV from KDE PIM to Frameworks
> for use by Plasma Mobile. KDAV is a framework that implements the CalDav/
> CardDav/GroupDav protocol on top of KIO's WebDav support. It would be
> classified as a functional tier 3 framework.

Hi Volker,

The name "KDAV" suggests that it might implement WebDAV. Do you think
if it should be renamed to something like "DAVExtensions" or let's say
"AnyDAV"?

-- 
Alexander Potashev

D25216: Fix translations of $GenericName

[Alexander Potashev]

aspotashev accepted this revision.
aspotashev added a comment.


  LGTM since it fixes the issue.
  
  A next step could be a clearer explaination of what $GenericName will be 
replaced with. Is it always replaced with Filelight's GenericName from its 
filelight.desktop file?

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization, aspotashev
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Alexander Potashev]

aspotashev added a comment.


  In general, string concatenation that you suggested is a big red flag for me 
as a translator. Concatenation often creates an untranslatable word puzzle.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Alexander Potashev]

aspotashev added a comment.


  I suggest a more flexible approach which allows translators to more around 
the "$GenericName" part inside their translation and change the " - " separator 
to anything more appropriate in their language:
  
i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - current folder", 
QStringLiteral("$GenericName"))
  
  (and so on for the other messages)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

[Alexander Potashev]

чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra :
>
> On 21-10-2019 15:22, Arjen Hiemstra wrote:
> > Hi,
> >
> > Quick Charts has been moved to KDE review. The intent is to make it a
> > Tier 1 framework.
> >
> > Quick Charts is a QML module that implements a set of
> > high-performance, GPU accelerated
> > charts. Currently the main user of it is a new KSysGuard UI I have
> > been working on, but
> > once it is part of Frameworks I also hope to convert several bits of
> > Plasma to using it.
>
> It has now been a little over two weeks. If there are no objections, I
> will move this to frameworks later today.

Hi Arjen,

Did anyone from the Plasma team approve the new KSysGuard UI?

-- 
Alexander Potashev

Re: Vacations

[Alexander Potashev]

Hi David,

I wish you to have nice vacations!

Who is going to release and announce KDE Frameworks 5.64.0 next Saturday?

вс, 3 нояб. 2019 г. в 22:45, David Faure :
>
> I'm going to be away on vacations until Nov 20, so don't worry if you don't
> get patches reviewed during that time.
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>


-- 
Alexander Potashev

Re: Quick Charts in KDE Review

[Alexander Potashev]

Hi Arjen,

1. I don't see any checks in the autotests. Would it be easy to
compare the displayed chart against a reference screenshot image, in
each of the tests?

The same screenshots could also help developers understand what kind
of charts kquickcharts is good for.

2. How to add a grid, ticks and labels to a line chart?

пн, 21 окт. 2019 г. в 16:46, Arjen Hiemstra :
>
> On 21-10-2019 15:22, Arjen Hiemstra wrote:
> > Hi,
> >
> > Quick Charts has been moved to KDE review. The intent is to make it a
> > Tier 1 framework.
> >
> > Quick Charts is a QML module that implements a set of
> > high-performance, GPU accelerated
> > charts. Currently the main user of it is a new KSysGuard UI I have
> > been working on, but
> > once it is part of Frameworks I also hope to convert several bits of
> > Plasma to using it.
>
> And of course, a link would be useful:
>
> https://invent.kde.org/kde/kquickcharts
>
> >
> > - Arjen



-- 
Alexander Potashev

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:39b92febeec5: i18n: Add ellipsis to action items 
(X-Purpose-ActionDisplay) (authored by aspotashev).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24464?vs=67426=67436

REVISION DETAIL
  https://phabricator.kde.org/D24464

AFFECTED FILES
  src/plugins/imgur/imgurplugin.json
  src/plugins/pastebin/pastebinplugin.json

To: aspotashev, apol, nicolasfella, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

[Alexander Potashev]

aspotashev created this revision.
aspotashev added reviewers: apol, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24464

AFFECTED FILES
  src/plugins/imgur/imgurplugin.json
  src/plugins/pastebin/pastebinplugin.json

To: aspotashev, apol, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

[Alexander Potashev]

aspotashev added a comment.


  At least for now Window CI tries and tests something:
  
  
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.13/1/console

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D23149: Only build tests when DBus is available

[Alexander Potashev]

aspotashev added a comment.


  Does this mean we cannot test Solid on Windows CI? 
https://api.kde.org/frameworks/solid/html/ says Solid is supported also on 
Windows.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D22544: [RFC] Deprecate KPassivePopup

[Alexander Potashev]

aspotashev added a comment.


  In D22544#505476 , @ngraham wrote:
  
  > In D22544#497637 , @aspotashev 
wrote:
  >
  > > > The case where no notification daemon is running is IMHO an edge case 
that we don't need to support.
  > >
  > > Disagree here. I believe a lot of people don't use a notification system 
on Linux. If we remove KPassivePopup, some apps with stop working properly for 
them.
  >
  >
  > This seems unlikely to me simply given that all the major DEs have 
notification systems installed by default, so the pool of people you're talking 
about would be limited to people using purely DIY systems or bare-bones tiling 
WMs. In such a case, by deliberately not installing notification stuff, those 
users are signaling that they don't want notifications, in which case, they 
should be //happy// to not see KPassivePopups, no? :)
  
  
  Of course not. If an application is designed to tell something to its user by 
means of a notification, then we can judge the application stops working 
corrently as soon as notifications are blocked. IOW, if KNotifications drops 
KPassivePopup support, then every application using KNotifications now requires 
a notification system. This is not fatal, but it limits the range of systems 
where a application can be used.
  
  >> Also, even if you use Plasma, sometimes it crashes, and then you don't 
have a notification daemon to connect to.
  > 
  > Then we should make it more reliable. :)
  
  Impossible. In the current design, you can always make Plasma crash with a 
broken custom widget.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22544

To: nicolasfella, #frameworks, broulik
Cc: ngraham, davidedmundson, aspotashev, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D22884: [RFC] Don't show title on page by default

[Alexander Potashev]

aspotashev added a comment.


  In D22884#505656 , @ndavis wrote:
  
  > Perhaps it is technically a bug, but it seems to me that most of the time 
(at least in all of the KDE programs I have installed), the title is just the 
section name, "Configure (the) [section name]" or "[secion name] Options". In 
Krita, the page titles are sometimes even shorter than the section names. 
However, if the bug is so widespread and the intended way of using a page title 
is so rare, perhaps we should disable page titles by default? It also seems to 
me that if a page needs an additional description that the user can't see until 
they get to the page, perhaps the section name isn't accurate or descriptive 
enough?
  
  
  It's not always "Configure [section name]". You can't have a long section 
name or it would be truncated. When the section name can't describe all the 
aspects of a KCM, its title can be used to elaborate.
  
  Examples:
  
  - section name "KDE Connect", title "Connect and sync your devices"
  - section name "Screen Edges", title "Active Screen Corners and Edges"
  
  Even if we manage to make section names and titles short and descriptive at 
some point in time, we shouldn't block way for new KCMs that might be too 
complicated to be named with a couple of words.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22884

To: ngraham, #vdg, mart, cfeck
Cc: aspotashev, GB_2, ndavis, cfeck, mmustac, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Alexander Potashev]

aspotashev added a comment.


  This broke some public APIs on Windows: since Qt5DBus is not being "imported" 
by CMake, a group of .cpp files is not being compiled, see e.g. 
https://cgit.kde.org/knotifications.git/tree/src/CMakeLists.txt#n25 . Thus e.g. 
class KStatusNotifierItem implementation becomes unavailable at linking time, 
even though CMake configuration installs the respective header files.
  
  As a consequence, we have linking errors in applications that rely on 
KStatusNotifierItem: https://phabricator.kde.org/T11275

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

Re: New framework: KCalCore

[Alexander Potashev]

сб, 20 июл. 2019 г. в 13:14, David Faure :
> I just discussed this with Volker IRL and I found a solution to address my
> initial concern with the name, the fact that a developer (who's new to all
> this) seeing "Cal" might not understand this as meaning Calendar.
> At the same time, KCalendar is unclear (does it display a calendar? is it
> about calendar systems? etc.). And we already discussed the problem with the
> other alternatives (a new developer wouldn't understand Incidences, iCal isn't
> the only format behind all this, etc.)
>
> So I suggested KCalendarCore, and Volker agreed.

Hi David,

How about KCalendarFormats?

In my opinion KCalendarCore is bad because it would suggest there must
be other KCalendar[...] libraries that depend on KCalendarCore, in a
manner similar to
 - QtCore <- QtGui,QtQuick and
 - KIOCore <- KIOWidgets,KIOGui.

-- 
Alexander Potashev

D22544: [RFC] Deprecate KPassivePopup

[Alexander Potashev]

aspotashev added a comment.


  kdialog also uses KPassivePopup

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22544

To: nicolasfella, #frameworks, broulik
Cc: aspotashev, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22544: [RFC] Deprecate KPassivePopup

[Alexander Potashev]

aspotashev added a comment.


  > The case where no notification daemon is running is IMHO an edge case that 
we don't need to support.
  
  Disagree here. I believe a lot of people don't use a notification system on 
Linux. If we remove KPassivePopup, some apps with stop working properly for 
them.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22544

To: nicolasfella, #frameworks, broulik
Cc: aspotashev, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

Re: New framework: KCalCore

[Alexander Potashev]

пт, 12 июл. 2019 г. в 19:25, Volker Krause :
> - Alexander P's fundamental objections to the current KCalCore API

After studing kcalcore sources again and also its usages with LXR, I
realize that i would be painful to remove the FileStorage
functionality because it implements format detection, and it's hard to
decide in what use cases we can or cannot drop format detection (vCal1
vs iCal2).

For use cases where file operations have to be asynchronous, the
FileStorage layer can be ignored and
ICalFormat::fromRawString()/fromString()/toString() used directly
instead (however I didn't try this approach yet because it's
uncommon).

All in all, I agree to follow the golden rule "if it works, don't touch it".

-- 
Alexander Potashev

D22047: Fix translation of actiondisplay

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> imgurplugin.json:105
> +"Name[zh_TW]": "Imgur",
> +"X-Purpose-ActionDisplay": "Imgur"
>  },

same for Imgur :(

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: aspotashev, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> pastebinplugin.json:105
> +"Name[zh_TW]": "Pastebin",
> +"X-Purpose-ActionDisplay": "Pastebin"
>  },

oops, ActionDisplay should have ellipsis, e.g. "Pastebin..."

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: aspotashev, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

[Alexander Potashev]

aspotashev added a comment.


  Dammit, I'm still not on the same page with the review request.
  
  In fact you had to trust your unit test and go fix the code :)
  
diff --git a/src/klocalizedstring.cpp b/src/klocalizedstring.cpp
index b1ba745..fed5b8a 100644
--- a/src/klocalizedstring.cpp
+++ b/src/klocalizedstring.cpp
@@ -1198,7 +1198,7 @@ KLocalizedString KLocalizedString::subs(double a, int 
fieldWidth,
 QChar fillChar) const
 {
 KLocalizedString kls(*this);
-kls.d->arguments.append(QStringLiteral("%1").arg(a, fieldWidth, 
format, precision, fillChar));
+kls.d->arguments.append(QStringLiteral("%L1").arg(a, fieldWidth, 
format, precision, fillChar));
 kls.d->values.append(static_cast(a));
 return kls;
 }

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

D22069: Localize long number strings

[Alexander Potashev]

aspotashev added a comment.


  In D22069#485921 , @ngraham wrote:
  
  >   Actual   (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20"
  >   Expected (QString(" 4,20"))   : " 4,20"
  >   
  >
  > What am I doing wrong?
  
  
  Oops, I answered without looking at the code.
  
  This subs() call in turn calls QString::arg() overload for double: 
https://doc.qt.io/qt-5/qstring.html#arg-9
  I'm not sure how to interpret this part of Qt documentation, may be the 
authors meant that "%L1 ".subs(4.2, 5, 'f', 2) 
would produce locale-aware " 4.20"/" 4,20" and just "%1".subs(... 'f' ...) 
always uses a decimal **point**.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

D22069: Localize long number strings

[Alexander Potashev]

aspotashev added a comment.


  You might want to test against different locales, like this: 
https://cgit.kde.org/ktimetracker.git/tree/src/tests/formattimetest.cpp

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

D13150: Add ellipsis where appropriate

[Alexander Potashev]

aspotashev added a comment.


  We probably need to fall back to "%1..." if X-Purpose-Action is not defined, 
which is possible for 3rd-party plugins.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D19498: loadLibrary: Use enum values to define what type of plugin we load

[Alexander Potashev]

aspotashev added a reviewer: Frameworks.

REPOSITORY
  R317 Kross

REVISION DETAIL
  https://phabricator.kde.org/D19498

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21565: phabricator: Fix fallthrough in switch

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:a520d9ea1800: phabricator: Fix fallthrough in switch 
(authored by aspotashev).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21565?vs=59080=59122

REVISION DETAIL
  https://phabricator.kde.org/D21565

AFFECTED FILES
  src/plugins/phabricator/quick/difflistmodel.cpp

To: aspotashev, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21565: phabricator: Fix fallthrough in switch

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R495 Purpose Library

BRANCH
  phab-fix-fallthrough

REVISION DETAIL
  https://phabricator.kde.org/D21565

AFFECTED FILES
  src/plugins/phabricator/quick/difflistmodel.cpp

To: aspotashev
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

[Alexander Potashev]

вт, 9 апр. 2019 г. в 20:10, Volker Krause :
>
> On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote:
> > вс, 7 апр. 2019 г. в 15:45, Volker Krause :
> > > Hi,
> > >
> > > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > >
> > > KCalCore is an implementation of the iCalendar standard based on libical,
> > > covering the data model, input/output and the rather complex recurrence
> > > algorithms defined in that standard. It's used outside of KDE PIM as well,
> > > e.g. by Zanshin or the Plasma Mobile calendar app.
> >
> > Hi Volker,
> >
> > While porting KTimeTracker to KF5, I noticed that KCalCore lost KIO
> > support on the way from KDELibs4 to KF 5.0.
> >
> > Of course I can subclass ICalFormat, but the FileStorage<->ICalFormat
> > relation looks weird to me: ICalFormat::save() is the method that
> > actually writes file to disk, while class name "ICalFormat" suggests
> > that it should only be concerned about iCal contents, not the I/O.
> >
> > May be CalFormat should only implement marshal/unmarshal methods, then
> > actual r/w from disk can be done in FileStorage. Otherwise, for me to
> > add KIO support right now I need to subclass ICalFormat rather than
> > FileStorage which is weird.
>
> Right. IMHO the entire file handling code should probably not be in there in
> the first place. That is, the CalStorage class hierarchy and the file I/O
> methods from the CalFormat hierachy (streaming to/from QIODevice rather than
> working with full QByteArray serialization might however make sense there).
>
> This is also why KIO support was a very bad idea in there, the KCalCore API is
> synchronous (predating KIO), while KIO is asynchronous, and so is likely any
> other persistence backend one might want to use.
>
> Looking at lxr.kde.org I'm however reluctant to remove any of this now though,
> this is still too widely used.

Hi Volker,

Thanks for your thoughts!

Since David suggested renaming KCalCore to something else, how about we instead
 1. Redesign the API (e.g. drop file handling, etc) and call it e.g.
KCal, get it into KF5,
 2. Keep releasing KCalCore as part of KDEPIM and may be port it to
KF5::KCal as backend to reduce codebase,
 3. Deprecate KCalCore and gradually port everything to the new clean KF5::KCal?
...
 4. PROFIT: nobody's code is hurt since the legacy KCalCore API is
still available.

-- 
Alexander Potashev

Re: New framework: KCalCore

[Alexander Potashev]

вс, 7 апр. 2019 г. в 17:24, Alexander Potashev :
>
> вс, 7 апр. 2019 г. в 15:45, Volker Krause :
> > Hi,
> >
> > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> >
> > KCalCore is an implementation of the iCalendar standard based on libical,
> > covering the data model, input/output and the rather complex recurrence
> > algorithms defined in that standard. It's used outside of KDE PIM as well,
> > e.g. by Zanshin or the Plasma Mobile calendar app.
>
> Hi Volker,
>
> While porting KTimeTracker to KF5, I noticed that KCalCore lost KIO
> support on the way from KDELibs4 to KF 5.0.

Another pitfall is shared pointers required everywhere. Because of
them, one can't easily subclass KCalCore classes.

Examples:
 1. KTimeTracker has a class [1] derived from
KCalCore::MemoryCalendar. In order to pass "this" into
KCalCore::FileStorage ctor, it also stores a QWeakPointer to recover
the associated shared pointer. I would love if KCalCore::FileStorage
could accept a plain pointer to KCalCore::Calendar, there is no reason
to make it shared pointer.
 2. akonadi-calendar uses the same approach [2]. Kudos to whoever
invented this clever hack
https://twitter.com/elonmusk/status/1104498091305009152


[1] 
https://cgit.kde.org/scratch/nalvarez/ktimetracker-filtered.git/tree/src/file/filecalendar.cpp?h=develop=d12569704d7b8c399151a46c067b51f2d6fbd8d1
[2] 
https://api.kde.org/frameworks-api/frameworks-apidocs/kdepim/akonadi-calendar/html/classAkonadi_1_1CalendarBase.html#ae3f11b166c0b51f4f071d3a74c6b91ba

-- 
Alexander Potashev

Re: New framework: KCalCore

[Alexander Potashev]

вс, 7 апр. 2019 г. в 15:45, Volker Krause :
> Hi,
>
> I'd like to propose KCalCore for review to move from KDE PIM to KF5.
>
> KCalCore is an implementation of the iCalendar standard based on libical,
> covering the data model, input/output and the rather complex recurrence
> algorithms defined in that standard. It's used outside of KDE PIM as well,
> e.g. by Zanshin or the Plasma Mobile calendar app.

Hi Volker,

While porting KTimeTracker to KF5, I noticed that KCalCore lost KIO
support on the way from KDELibs4 to KF 5.0.

Of course I can subclass ICalFormat, but the FileStorage<->ICalFormat
relation looks weird to me: ICalFormat::save() is the method that
actually writes file to disk, while class name "ICalFormat" suggests
that it should only be concerned about iCal contents, not the I/O.

May be CalFormat should only implement marshal/unmarshal methods, then
actual r/w from disk can be done in FileStorage. Otherwise, for me to
add KIO support right now I need to subclass ICalFormat rather than
FileStorage which is weird.


P.S.  Sorry for the off-topic.

-- 
Alexander Potashev

D20005: Report human-readable error if Qt5Widgets is required but is not found

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:490602677222: Report human-readable error if Qt5Widgets 
is required but is not found (authored by aspotashev).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20005?vs=54695=54832

REVISION DETAIL
  https://phabricator.kde.org/D20005

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: aspotashev, #frameworks, apol
Cc: apol, cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20005: Report human-readable error if Qt5Widgets is required but is not found

[Alexander Potashev]

aspotashev updated this revision to Diff 54695.
aspotashev retitled this revision from "WIP: Find Qt5Widgets, required for 
Qt5::uic" to "Report human-readable error if Qt5Widgets is required but is not 
found".
aspotashev added a comment.


  Implement probably the most lightweight behaviour.

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20005?vs=54636=54695

REVISION DETAIL
  https://phabricator.kde.org/D20005

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

[Alexander Potashev]

aspotashev added a comment.


  I'm not sure about this because
  
  1. Not a find_package() guru
  2. We may need to add Qt5Widgets as a new dependency of ki18n. For now ki18n 
won't pull qtwidgets, and your projects may fail compiling which is not very 
developer-friendly.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

[Alexander Potashev]

aspotashev created this revision.
aspotashev added a reviewer: Frameworks.
aspotashev added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

REVISION SUMMARY
  If I have
  
find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUIRED)
  
  in CMakeLists.txt, cmake failed with the following error:
  
get_target_property() called with non-existent target "Qt5::uic".
  
  referencing the following line in KF5I18nMacros.cmake:
  
get_target_property(QT_UIC_EXECUTABLE Qt5::uic LOCATION)

TEST PLAN
  Run cmake on a project with the following lines:
  
find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUIRED)
ki18n_wrap_ui(foo_SRCS bar.ui)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Alexander Potashev]

aspotashev added a comment.


  In D13150#428167 , @ngraham wrote:
  
  > This results in every item in the menu getting an ellipsis, which isn't 
appropriate because not all of them require more user action to proceed (the 
imgur plugin is one such example). It seems like we need a way to indicate in 
the desktop file that the plugin will require user interaction and need an 
ellipsis displayed in the UI, without hardcoding that information with an 
ellipsis in the plugin's own name.
  
  
  This sounds like a hack as well. I think we need another translatable field 
in JSON, independent from "Name".
  
  Here is a similar problem with KIO: 
https://bugs.kde.org/show_bug.cgi?id=243287

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19501: Do not use deprecated KUrlRequester::fileDialog()

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R317:32502e83a1a6: Do not use deprecated 
KUrlRequester::fileDialog() (authored by aspotashev).

REPOSITORY
  R317 Kross

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19501?vs=53090=53100

REVISION DETAIL
  https://phabricator.kde.org/D19501

AFFECTED FILES
  src/ui/actioncollectionview.cpp

To: aspotashev, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19501: Do not use deprecated KUrlRequester::fileDialog()

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

REPOSITORY
  R317 Kross

BRANCH
  fix-deprecated

REVISION DETAIL
  https://phabricator.kde.org/D19501

AFFECTED FILES
  src/ui/actioncollectionview.cpp

To: aspotashev
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19498: loadLibrary: Use enum values to define what type of plugin we load

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

REVISION SUMMARY
  Enum values are more lightweight and easier to compare than strings.

TEST PLAN
  The manual test ".../kross-interpreters/build/tests/krosstest
  .../kross-interpreters/tests/testguiform.py" should open a dialog. It 
validates
  both kross interpreter loading and kross module loading.

REPOSITORY
  R317 Kross

BRANCH
  enum-for-plugin-types

REVISION DETAIL
  https://phabricator.kde.org/D19498

AFFECTED FILES
  src/core/manager.cpp

To: aspotashev
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124398/
---

(Updated March 2, 2019, 5:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit aef8165848ad157c81a9aa36ab1b40a0c7ec929c by Alexander 
Potashev to branch master.


Repository: kross


Description
---

All shared libraries (including modules) are loaded by KrossCore with
the use of QLibrary and searched in paths returned by
QCoreApplication::libraryPaths(). QCoreApplication::libraryPaths()
includes /plugins, therefore KDE_INSTALL_QTPLUGINDIR is
the right place to install Kross modules.


Diffs
-

  src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 


Diff: https://git.reviewboard.kde.org/r/124398/diff/1/


Testing
---


Thanks,

Alexander Potashev

D16966: Fix typo in i18n message (cmdline option description)

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:49a674d3bdb0: Fix typo in i18n message (cmdline option 
description) (authored by aspotashev).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16966?vs=47770=47771

REVISION DETAIL
  https://phabricator.kde.org/D16966

AFFECTED FILES
  src/kpackagetool/options.h

To: aspotashev, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16966: Fix typo in i18n message (cmdline option description)

[Alexander Potashev]

aspotashev updated this revision to Diff 47770.
aspotashev added a comment.


  fix another typo

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16966?vs=45698=47770

BRANCH
  arcpatch-D16966

REVISION DETAIL
  https://phabricator.kde.org/D16966

AFFECTED FILES
  src/kpackagetool/options.h

To: aspotashev, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE Frameworks web page

[Alexander Potashev]

Thanks!

вт, 11 дек. 2018 г. в 15:32, Jonathan Riddell :
> > 2. Text on the blue grid under "Organisation" is not very readable.
>
> Works for me.  Again it's copying what's on the Kirigami page.  Suggestions 
> welcome but the page needs some colour to break it up.

I don't speak CSS, but placing this white text over its own
text-shadow in blue (same dark blue as the background's primary color)
could make it more readable as the grid won't interfere the letters
anymore. (Sorry, it's just my guess, I didn't actually check how it
would look.)

> > 4. Can't find no direct link nor straightforward way to go to Git
> > repos or download source tarballs. I think these must be easy to
> > access, since KF5 is a developer-oriented product.
>
> I added 'download' to the release announcement link which seems to be
> the best way to point the visitor to the newest release.

https://download.kde.org/stable/frameworks/ could also work as a
download link. Other products' announcements at
https://www.kde.org/announcements/ may confuse newcomers. IMO the best
would be a page with links to https://cgit.kde.org/... for each of the
frameworks.

-- 
Alexander Potashev

Re: KDE Frameworks web page

[Alexander Potashev]

пн, 10 дек. 2018 г. в 16:43, Jonathan Riddell :
>
> Frameworks has no web page and the announcements still point to the
> 5.0 announcement for more information.
>
> So here's a proposal for adding to kde.org/products/
>
> https://www.kde.org/products/frameworks/

Hi,

Nice work!

Now nitpicking:

1. The titles ending in fullstop look weird:
"Features."
"Organisation."
"Get The Frameworks."

2. Text on the blue grid under "Organisation" is not very readable.

3. I heard that "organisation" is British English, should be
"organiZation" for the US variant.

4. Can't find no direct link nor straightforward way to go to Git
repos or download source tarballs. I think these must be easy to
access, since KF5 is a developer-oriented product.

-- 
Alexander Potashev

D16966: Fix typo in i18n message (cmdline option description)

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R290 KPackage

BRANCH
  opt-i18n

REVISION DETAIL
  https://phabricator.kde.org/D16966

AFFECTED FILES
  src/kpackagetool/options.h

To: aspotashev
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

[Alexander Potashev]

aspotashev added a comment.


  FYI, according to an old custom mentioned at 
https://community.kde.org/Schedules/Frameworks , KF5.52 is already in string 
freeze, thus this change may only be pushed after 5.52 is released. However you 
can ask for an exception in the kde-i18n-doc mailing list unless it gets too 
close to KF5.52 tagging day.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications
Cc: aspotashev, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3671d67a7956: baloodb: Make changes to cmdline arg 
description after rename prune - clean (authored by aspotashev).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13294?vs=35442=35494

REVISION DETAIL
  https://phabricator.kde.org/D13294

AFFECTED FILES
  src/tools/experimental/baloodb/main.cpp

To: aspotashev, michaelh, #baloo, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

[Alexander Potashev]

aspotashev created this revision.
aspotashev added a reviewer: michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
aspotashev requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  rename-prune-to-clean

REVISION DETAIL
  https://phabricator.kde.org/D13294

AFFECTED FILES
  src/tools/experimental/baloodb/main.cpp

To: aspotashev, michaelh
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D7849: Fix the tray icon scaling on HiDPI screens

[Alexander Potashev]

aspotashev added a comment.


  related bug report: https://bugs.kde.org/show_bug.cgi?id=360333

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, 
plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9107: Add undo support to BatchRenameJob

[Alexander Potashev]

aspotashev added a comment.


  Please don't push this while in string freeze because you added a new 
translatable ('i18n()') message.
  
  https://community.kde.org/Schedules/Frameworks

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9107

To: chinmoyr, #frameworks, dfaure
Cc: aspotashev

D8767: Fix translation of toolbar name when it has i18n context

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:17eeaf00b651: Fix translation of toolbar name when it has 
i18n context (authored by aspotashev).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8767?vs=22243=22244

REVISION DETAIL
  https://phabricator.kde.org/D8767

AFFECTED FILES
  src/CMakeLists.txt
  src/kedittoolbar.cpp
  src/ktoolbar.cpp
  src/ktoolbarhelper.cpp
  src/ktoolbarhelper_p.h

To: aspotashev, dfaure, apol
Cc: #frameworks

D8767: Fix translation of toolbar name when it has i18n context

[Alexander Potashev]

aspotashev marked an inline comment as done.

REPOSITORY
  R263 KXmlGui

BRANCH
  toolbar-i18n-with-ctxt

REVISION DETAIL
  https://phabricator.kde.org/D8767

To: aspotashev, dfaure, apol
Cc: #frameworks

D8767: Fix translation of toolbar name when it has i18n context

[Alexander Potashev]

aspotashev updated this revision to Diff 22243.
aspotashev added a comment.


  const QString 

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8767?vs=22207=22243

BRANCH
  toolbar-i18n-with-ctxt

REVISION DETAIL
  https://phabricator.kde.org/D8767

AFFECTED FILES
  src/CMakeLists.txt
  src/kedittoolbar.cpp
  src/ktoolbar.cpp
  src/ktoolbarhelper.cpp
  src/ktoolbarhelper_p.h

To: aspotashev, dfaure, apol
Cc: #frameworks

D8767: Fix translation of toolbar name when it has i18n context

[Alexander Potashev]

aspotashev created this revision.
aspotashev added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The Configure Toolbars dialog did not take into account the "context" 
attribute of toolbar text which should be used as i18n context string.
  
  KDE Partition Manager was affected:
  

  Edit 
Toolbar
[...]

TEST PLAN
  Run partitionmanager and check translated toolbar names in: 1. Configure 
Toolbars dialog; 2. In the menu under "Tools -> Toolbars Shown".

REPOSITORY
  R263 KXmlGui

BRANCH
  toolbar-i18n-with-ctxt

REVISION DETAIL
  https://phabricator.kde.org/D8767

AFFECTED FILES
  src/CMakeLists.txt
  src/kedittoolbar.cpp
  src/ktoolbar.cpp
  src/ktoolbarhelper.cpp
  src/ktoolbarhelper_p.h

To: aspotashev, dfaure
Cc: #frameworks

Re: Review Request 129609: utils.js: Escape backslash in i18n string

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129609/#review102103
---



Fsck, gettext incorrectly extracts "\s" as "s".

- Alexander Potashev


On Янв. 19, 2017, 7:09 п.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129609/
> ---
> 
> (Updated Янв. 19, 2017, 7:09 п.п.)
> 
> 
> Review request for Kate and KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> utils.js: Escape backslash in i18n string
> 
> 
> Diffs
> -
> 
>   src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a 
> 
> Diff: https://git.reviewboard.kde.org/r/129609/diff/
> 
> 
> Testing
> ---
> 
> None!
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Re: Review Request 129609: utils.js: Escape backslash in i18n string

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129609/
---

(Updated Jan. 19, 2017, 4:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Kate and KDE Frameworks.


Changes
---

Submitted with commit 4eac3b9b3c78cc854751ab2e8e128bb6eb030056 by Alexander 
Potashev to branch master.


Repository: ktexteditor


Description
---

utils.js: Escape backslash in i18n string


Diffs
-

  src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a 

Diff: https://git.reviewboard.kde.org/r/129609/diff/


Testing
---

None!


Thanks,

Alexander Potashev

[Differential] [Accepted] D4023: kformat: Make it possible to properly translate relative days of the week

[Alexander Potashev]

aspotashev accepted this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4023

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mpyne, #frameworks, kde-i18n-doc, aacid, aspotashev
Cc: aacid

[Differential] [Commented On] D4023: kformat: Make it possible to properly translate relative days of the week

[aspotashev (Alexander Potashev)]

aspotashev added inline comments.

INLINE COMMENTS

> kformatprivate.cpp:381
>  {
> -return tr("Last %1").arg(m_locale.dayName(date.dayOfWeek(), format));
> +switch(date.dayOfWeek()) {
> +case 1: return tr("Last Monday","day in the previous week");

Needs a space: "switch ("

> kformatprivate.cpp:382
> +switch(date.dayOfWeek()) {
> +case 1: return tr("Last Monday","day in the previous week");
> +case 2: return tr("Last Tuesday",   "day in the previous week");

Indentation of "case " lines is probably against the coding style.

> kformatprivate.cpp:400
> +case 7: return tr("Next Sunday","day in the week after 
> this");
> +}
>  }

http://doc.qt.io/qt-5/qdate.html#dayOfWeek says "Returns 0 if the date is 
invalid". What happens when the input date is invalid?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4023

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mpyne, #frameworks, kde-i18n-doc, aspotashev

Review Request 129609: utils.js: Escape backslash in i18n string

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129609/
---

Review request for Kate and KDE Frameworks.


Repository: ktexteditor


Description
---

utils.js: Escape backslash in i18n string


Diffs
-

  src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a 

Diff: https://git.reviewboard.kde.org/r/129609/diff/


Testing
---

None!


Thanks,

Alexander Potashev

Re: Review Request 129510: Add FreeBSD to metainfo.yaml.

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129510/#review101043
---


Ship it!




I didn't try building Kross on FreeBSD, but should be good because it does not 
contain any platform-specific code.

- Alexander Potashev


On Ноя. 20, 2016, 7:19 п.п., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129510/
> ---
> 
> (Updated Ноя. 20, 2016, 7:19 п.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> Add FreeBSD to metainfo.yaml.
> 
> 
> Diffs
> -
> 
>   metainfo.yaml 28937c96ba71aecd81d3565d071fe6560ef2e68e 
> 
> Diff: https://git.reviewboard.kde.org/r/129510/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/#review100597
---



Not sure if C++11's shared_ptr can be used, at least it's not mentioned here: 
https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11

- Alexander Potashev


On Ноя. 5, 2016, 3:05 п.п., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129341/
> ---
> 
> (Updated Ноя. 5, 2016, 3:05 п.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Dropping implicit boost usage.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/backendpersisthandler.cpp 
> 413d4cd23ef1e15b75cd366061f07f179241af58 
>   src/runtime/kwalletd/knewwalletdialog.h 
> ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
>   src/runtime/kwalletd/knewwalletdialog.cpp 
> 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
>   src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
>   src/runtime/kwalletd/kwalletwizard.cpp 
> cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 
> 
> Diff: https://git.reviewboard.kde.org/r/129341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128818: Revert "Remove unused KF5 dependencies"

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128818/
---

(Updated Сен. 3, 2016, 12:13 п.п.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez and Andreas Sturmlechner.


Repository: kross


Description
---

This reverts commit ce2a58313fbeaee6482c9718ce4dfdf5cc190875.

Rationale:

  kross/src/ui/actioncollectionview.cpp uses
  1. KComboBox from KCompletion,
  2. KMessageBox from KWidgetsAddons,
  3. KActionCollection from KXmlGui.

  KrossUi compiled without problem because some other dependencies (e.g.
  KParts) linked to these 3 libraries publicly (in the sense of CMake
  keywords PUBLIC/PRIVATE/INTERFACE).


Diffs
-

  CMakeLists.txt 53965efbbe72746f5dc6528686d4c8d965f0097a 

Diff: https://git.reviewboard.kde.org/r/128818/diff/


Testing
---

Compiles.


Thanks,

Alexander Potashev

Re: Review Request 128818: Revert "Remove unused KF5 dependencies"

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128818/#review98839
---


Ship it!




Doing a self-ship-it because it's trivial.

- Alexander Potashev


On Сен. 3, 2016, 12:11 п.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128818/
> ---
> 
> (Updated Сен. 3, 2016, 12:11 п.п.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Andreas 
> Sturmlechner.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> This reverts commit ce2a58313fbeaee6482c9718ce4dfdf5cc190875.
> 
> Rationale:
> 
>   kross/src/ui/actioncollectionview.cpp uses
>   1. KComboBox from KCompletion,
>   2. KMessageBox from KWidgetsAddons,
>   3. KActionCollection from KXmlGui.
> 
>   KrossUi compiled without problem because some other dependencies (e.g.
>   KParts) linked to these 3 libraries publicly (in the sense of CMake
>   keywords PUBLIC/PRIVATE/INTERFACE).
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 53965efbbe72746f5dc6528686d4c8d965f0097a 
> 
> Diff: https://git.reviewboard.kde.org/r/128818/diff/
> 
> 
> Testing
> ---
> 
> Compiles.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Re: Review Request 128582: Remove unused KF5 dependencies

[Alexander Potashev]

> On Авг. 25, 2016, 10:02 п.п., Andreas Sturmlechner wrote:
> > lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies 
> > still in use.
> 
> Alexander Potashev wrote:
> Oops... You're right: kross/src/ui/actioncollectionview.cpp uses
> 1. KComboBox from KCompletion,
> 2. KMessageBox from KWidgetsAddons,
> 3. KActionCollection from KXmlGui.
> 
> KrossUi compiled without problem because some other dependencies (e.g. 
> KParts) linked to these 3 libraries publicly (in the sense of CMake keywords 
> PUBLIC/PRIVATE/INTERFACE).
> 
> Will revert this commit.

Anti-patch: https://git.reviewboard.kde.org/r/128818/


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128582/#review98658
-------


On Авг. 3, 2016, 5:23 д.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128582/
> ---
> 
> (Updated Авг. 3, 2016, 5:23 д.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> Remove unused KF5 dependencies
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
> 
> Diff: https://git.reviewboard.kde.org/r/128582/diff/
> 
> 
> Testing
> ---
> 
> Still compiles successfully.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Review Request 128818: Revert "Remove unused KF5 dependencies"

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128818/
---

Review request for KDE Frameworks, Aleix Pol Gonzalez and Andreas Sturmlechner.


Repository: kross


Description
---

This reverts commit ce2a58313fbeaee6482c9718ce4dfdf5cc190875.

Rationale:

  kross/src/ui/actioncollectionview.cpp uses
  1. KComboBox from KCompletion,
  2. KMessageBox from KWidgetsAddons,
  3. KActionCollection from KXmlGui.

  KrossUi compiled without problem because some other dependencies (e.g.
  KParts) linked to these 3 libraries publicly (in the sense of CMake
  keywords PUBLIC/PRIVATE/INTERFACE).


Diffs
-

  CMakeLists.txt 53965efbbe72746f5dc6528686d4c8d965f0097a 

Diff: https://git.reviewboard.kde.org/r/128818/diff/


Testing
---

Compiles.


Thanks,

Alexander Potashev

Re: Review Request 128582: Remove unused KF5 dependencies

[Alexander Potashev]

> On Авг. 25, 2016, 10:02 п.п., Andreas Sturmlechner wrote:
> > lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies 
> > still in use.

Oops... You're right: kross/src/ui/actioncollectionview.cpp uses
1. KComboBox from KCompletion,
2. KMessageBox from KWidgetsAddons,
3. KActionCollection from KXmlGui.

KrossUi compiled without problem because some other dependencies (e.g. KParts) 
linked to these 3 libraries publicly (in the sense of CMake keywords 
PUBLIC/PRIVATE/INTERFACE).

Will revert this commit.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128582/#review98658
---


On Авг. 3, 2016, 5:23 д.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128582/
> ---
> 
> (Updated Авг. 3, 2016, 5:23 д.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> Remove unused KF5 dependencies
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
> 
> Diff: https://git.reviewboard.kde.org/r/128582/diff/
> 
> 
> Testing
> ---
> 
> Still compiles successfully.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Re: Review Request 128583: Make KrossUi and the command-line tool optional

[Alexander Potashev]

> On Авг. 3, 2016, 4:28 д.п., Aleix Pol Gonzalez wrote:
> > Why?
> 
> Alexander Potashev wrote:
> To make Kross easier to build for exotic (= non-Linux) platforms. (We 
> have no actual users for these options yet.)
> 
> Aleix Pol Gonzalez wrote:
> My experience says this tends to complicate the usage of the frameworks, 
> especially when it includes different targets being offered depending on how 
> it's built.

Ok, let's wait until these options are necessary.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128583/#review98025
---


On Авг. 3, 2016, 2:36 д.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128583/
> ---
> 
> (Updated Авг. 3, 2016, 2:36 д.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> Make KrossUi and the command-line tool optional
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
>   src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
>   src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 
> 
> Diff: https://git.reviewboard.kde.org/r/128583/diff/
> 
> 
> Testing
> ---
> 
> Still compiles successfully in all 4 configurations: {BUILD_KROSSUI = ON, 
> OFF} x {BUILD_KROSS_CLI = ON, OFF}.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Re: Review Request 128583: Make KrossUi and the command-line tool optional

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128583/
---

(Updated Авг. 8, 2016, 2:41 д.п.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kross


Description
---

Make KrossUi and the command-line tool optional


Diffs
-

  CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
  src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
  src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 

Diff: https://git.reviewboard.kde.org/r/128583/diff/


Testing
---

Still compiles successfully in all 4 configurations: {BUILD_KROSSUI = ON, OFF} 
x {BUILD_KROSS_CLI = ON, OFF}.


Thanks,

Alexander Potashev

Re: Review Request 128589: Take over maintainership; remove framework deprecation flags

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128589/
---

(Updated Авг. 8, 2016, 2:39 д.п.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kross


Description
---

Take over maintainership; remove framework deprecation flags


Diffs
-

  metainfo.yaml 28937c96ba71aecd81d3565d071fe6560ef2e68e 

Diff: https://git.reviewboard.kde.org/r/128589/diff/


Testing
---


Thanks,

Alexander Potashev

Re: Review Request 128587: Move the QtScript backend into a separate directory

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128587/
---

(Updated Aug. 4, 2016, 4:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit b359b9939d5b5e1a7d76e81da5ce0d8d449e29a8 by Alexander 
Potashev to branch master.


Repository: kross


Description
---

Move the QtScript backend into a separate directory


Diffs
-

  src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
  src/qts-interpreter/CMakeLists.txt PRE-CREATION 
  src/qts/CMakeLists.txt 06d1c572246ccd3d96b3d10b0eac5e9e8a0db3d6 
  src/qts/interpreter.h  
  src/qts/interpreter.cpp  
  src/qts/script.h  
  src/qts/script.cpp 0c9cb1ff47c605bd8414e4b9ba29e83ee7b59cda 

Diff: https://git.reviewboard.kde.org/r/128587/diff/


Testing
---


Thanks,

Alexander Potashev

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128586: Use a dedicated Qt logging category in KrossUi

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128586/
---

(Updated Aug. 3, 2016, 10:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit dfac6e7005624a7cb433a4cedef2494a4ee63a00 by Alexander 
Potashev to branch master.


Repository: kross


Description
---

Use a dedicated Qt logging category in KrossUi


Diffs
-

  src/ui/CMakeLists.txt 1f7c0cb47fd40f8b57de20ae139b151423ae73e6 
  src/ui/actioncollectionmodel.cpp 455e966c60e6d428b3b027d9b9501612edf601b8 

Diff: https://git.reviewboard.kde.org/r/128586/diff/


Testing
---


Thanks,

Alexander Potashev

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128585: Use a dedicated Qt logging category in qts/*

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128585/
---

(Updated Aug. 3, 2016, 2:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 3a9ea94f9304b641895dbe2d4277fbaaf4e658c8 by Alexander 
Potashev to branch master.


Repository: kross


Description
---

Use a dedicated Qt logging category in qts/*


Diffs
-

  src/qts/CMakeLists.txt 06d1c572246ccd3d96b3d10b0eac5e9e8a0db3d6 
  src/qts/plugin.cpp 7684e6d399a7ed7bbf1ab3c81559c4987b6a7ac6 
  src/qts/script.cpp 0c9cb1ff47c605bd8414e4b9ba29e83ee7b59cda 
  src/qts/values_p.h fdbf6616861e8577f133a9fc0deb8c6249967062 

Diff: https://git.reviewboard.kde.org/r/128585/diff/


Testing
---


Thanks,

Alexander Potashev

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128582: Remove unused KF5 dependencies

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128582/
---

(Updated Aug. 3, 2016, 2:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit ce2a58313fbeaee6482c9718ce4dfdf5cc190875 by Alexander 
Potashev to branch master.


Repository: kross


Description
---

Remove unused KF5 dependencies


Diffs
-

  CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 

Diff: https://git.reviewboard.kde.org/r/128582/diff/


Testing
---

Still compiles successfully.


Thanks,

Alexander Potashev

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128584: Use a dedicated Qt logging category in KrossCore's .cpp files

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128584/
---

(Updated Aug. 3, 2016, 2:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit a0dde322b465198d2434dc42616feffedb18c4be by Alexander 
Potashev to branch master.


Repository: kross


Description
---

Use a dedicated Qt logging category in KrossCore's .cpp files


Diffs
-

  CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
  src/core/CMakeLists.txt b5cb8c22a449a83800c8d85c2301fff80209aa1c 
  src/core/action.cpp f1ecf488865ba7783471a00bc4b3582a2babef1a 
  src/core/actioncollection.cpp 81311679c53dfaa72945b6dc85c1f913a2a6cfb9 
  src/core/interpreter.cpp 37fd5237c1b6b15c34f19812f4d9f9634065d0ad 
  src/core/manager.cpp bf4f10ba0479f044c60d8e25e2ca8dd5363861ce 

Diff: https://git.reviewboard.kde.org/r/128584/diff/


Testing
---


Thanks,

Alexander Potashev

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128583: Make KrossUi and the command-line tool optional

[Alexander Potashev]

> On Авг. 3, 2016, 4:28 д.п., Aleix Pol Gonzalez wrote:
> > Why?

To make Kross easier to build for exotic (= non-Linux) platforms. (We have no 
actual users for these options yet.)


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128583/#review98025
---


On Авг. 3, 2016, 2:36 д.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128583/
> ---
> 
> (Updated Авг. 3, 2016, 2:36 д.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> Make KrossUi and the command-line tool optional
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
>   src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
>   src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 
> 
> Diff: https://git.reviewboard.kde.org/r/128583/diff/
> 
> 
> Testing
> ---
> 
> Still compiles successfully in all 4 configurations: {BUILD_KROSSUI = ON, 
> OFF} x {BUILD_KROSS_CLI = ON, OFF}.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128586: Use a dedicated Qt logging category in KrossUi

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128586/
---

Review request for KDE Frameworks.


Repository: kross


Description
---

Use a dedicated Qt logging category in KrossUi


Diffs
-

  src/ui/CMakeLists.txt 1f7c0cb47fd40f8b57de20ae139b151423ae73e6 
  src/ui/actioncollectionmodel.cpp 455e966c60e6d428b3b027d9b9501612edf601b8 

Diff: https://git.reviewboard.kde.org/r/128586/diff/


Testing
---


Thanks,

Alexander Potashev

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128587: Move the QtScript backend into a separate directory

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128587/
---

Review request for KDE Frameworks.


Repository: kross


Description
---

Move the QtScript backend into a separate directory


Diffs
-

  src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
  src/qts-interpreter/CMakeLists.txt PRE-CREATION 
  src/qts/CMakeLists.txt 06d1c572246ccd3d96b3d10b0eac5e9e8a0db3d6 
  src/qts/interpreter.h  
  src/qts/interpreter.cpp  
  src/qts/script.h  
  src/qts/script.cpp 0c9cb1ff47c605bd8414e4b9ba29e83ee7b59cda 

Diff: https://git.reviewboard.kde.org/r/128587/diff/


Testing
---


Thanks,

Alexander Potashev

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel