D29231: Add keyboard_shortcuts_inhibit protocol

[Cyril Rossi]

crossi added a comment.


  some code style related comments

INLINE COMMENTS

> test_keyboard_shortcuts_inhibitor_interface.cpp:109
> +m_manager = m_display.createKeyboardShortcutsInhibitManager(this);
> + QVERIFY(m_serverCompositor->isValid());
> +connect(m_serverCompositor, ::surfaceCreated, this, 
> [this](SurfaceInterface *surface) {

indentation

> test_keyboard_shortcuts_inhibitor_interface.cpp:154
> +for (int i = 0; i < 3; ++i) {
> +KWayland::Client::Surface *s 
> =m_clientCompositor->createSurface(this);
> +m_clientSurfaces += s->operator wl_surface *();

add space after =

> display.h:328
> + */
> +KeyboardShortcutsInhibitManagerInterface 
> *createKeyboardShortcutsInhibitManager(QObject *object);
> +

parameter should be `QObject *parent = nullptr`

> keyboard_shortcuts_inhibit_interface.h:69
> +friend class KeyboardShortcutsInhibitorInterface;
> +explicit KeyboardShortcutsInhibitManagerInterface(Display *d, QObject 
> *parent);
> +void removeInhibitor(SurfaceInterface *const surface, SeatInterface 
> *const seat);

parent parameter should be defaulted to nullptr

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> keyboard_shortcuts_inhibit_interface.cpp:92
> +{
> +return d->m_surface;
> +}

indentation is missing

> keyboard_shortcuts_inhibit_interface.h:39
> +void setActive(bool active);
> +bool isActive();
> +private:

Should be const

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:00213a3a0906: kconfig_compiler : generate kconfig 
settings with subgroup (authored by crossi).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=77426=80841

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks, meven
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Cyril Rossi]

crossi added a dependent revision: D28629: [WIP] Port KCM to 
SettingStateBinding.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Cyril Rossi]

crossi added a dependent revision: D28622: [WIP] Port KCM KWin Decoration and 
VirtualDesktop to SettingStateBinding.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27724: Synchronise setNeedsSave between KCModule and ConfigModule in both directions

[Cyril Rossi]

crossi added a comment.


  In D27724#633240 , @davidedmundson 
wrote:
  
  > > Unfortunately, if the user clicks on reset button at first, the apply 
button is disabled an stays disabled.
  >
  > I'm not sure I understand why that would happen.
  >
  > That means there's something else going on, and we shouldn't ship this till 
we understand it.
  
  
  I don't understand either but I didn't investigate deeper.
  From what I have tested, it does not keep in sync setNeedsSave state.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a comment.


  In D27133#625924 , @apol wrote:
  
  > The patch and the feature sound good to me, the resulting xml feels a bit 
weird and could use some clarification.
  
  
  Thank you for your comment.
  
  I agree it looks a bit odd, nested group element would be more xmlish.
  We choose a simpler approach as moving in the kconfig_compiler code isn't 
easy and the need was for one kcm (notifications).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a comment.


  @dfaure, any opinion on this revision ?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 77426.
crossi added a comment.


  rebase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=77049=77426

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

[Cyril Rossi]

crossi added a comment.


  Tested as an alternative to D27944 
  At initialization, the apply button is enabled.
  Unfortunately, if the user clicks on reset button at first, the apply button 
is disabled an stays disabled.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson
Cc: iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi marked 5 inline comments as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 77049.
crossi added a comment.


  rename attribute to parentGroupName

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=76833=77049

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi planned changes to this revision.
crossi added inline comments.

INLINE COMMENTS

> ervin wrote in test_subgroups.kcfg:10
> Now that I see it, I think I'd go for "parentGroupName" since this is not 
> referential and really about the name (like the name parameter)

`parentGroupName` sounds more explicit, I will replace with it.

> ervin wrote in KConfigSourceGenerator.cpp:354
> Unrelated right, this is not due to your patch, or am I confused?

It was there before my patch, just pointing it for later.

Fortunately, some of the concerns have been addressed in D27497 


REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 76833.
crossi added a comment.


  rework: introduce parentGroup attribute to group element

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75059=76833

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi planned changes to this revision.
crossi added a comment.


  Thanks for your comments.
  
  A new attribute to the group element would be more readable and easier to 
edit/maintain.
  
  To generate code like :
  
KConfig config;
KConfigGroup generalGroup( , "General" );
KConfigGroup colorsGroup = config.group( "Colors" );
  
  kcfg will look like :
  


true


  
  Currently, I only need one level of subgroup, let's keep it simple and drop 
the group separator stuff for the moment.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi added a dependent revision: D27188: KCM Notifications : Manage 
app-specific notifications with KCconfigXT's magic.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a dependent revision: D27188: KCM Notifications : Manage 
app-specific notifications with KCconfigXT's magic.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:c8bf5e96cf2f: KConfigSkeletonItem : allow to set a 
KconfigGroup to read and write items in… (authored by crossi).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=76281=76282

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 76281.
crossi added a comment.


  fix comment

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=75829=76281

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> meven wrote in KConfigXmlParser.cpp:203
> If you don't mind I am putting aside the second part as it is not directly 
> related to this PR, i.e name attribute validation. (FYI we had 
> KConfigXmlParser::validateNameAndKey)

I guess there are more problematic characters. IMO this is not the right place, 
you pointed `validateNameAndKey()` which seems to be a better choice to 
implement such checks.

BTW, this is not related to this PR.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27496: Fix isImmutable generated property

[Cyril Rossi]

crossi accepted this revision.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27496

To: meven, hchain, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi added a reviewer: mdawson.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi marked 9 inline comments as done.
crossi added inline comments.

INLINE COMMENTS

> ervin wrote in kcoreconfigskeleton.h:448
> That's my understanding to have them virtuals in KF6 indeed, that was 
> introduced by David Edmundson a little while ago. This is necessary because 
> of the way KConfigSkeletonItem is done and because 
> KConfigCompilerSignallingItem is basically a decorator.

Added David's comment from D25791  to make 
things clearer on what to do.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 75829.
crossi added a comment.


  Comments

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74799=75829

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75056.
crossi added a comment.


  fix compiling error for kcfgfile arg="true"

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75032=75056

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75059.
crossi added a comment.


  update tests

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75056=75059

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:7c4f46aded18: Allow ManagedConfigModule derived class to 
register explicitly… (authored by crossi).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=75052=75053

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi updated this revision to Diff 75052.
crossi added a comment.


  rebase

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=74128=75052

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> meven wrote in KConfigSourceGenerator.cpp:335
> This character won't be easy on the user.
> Ideally we perhaps would want to allow users to add  
> 
> We could use alternatively attributes.

I'm open for another separator, btw this part is not intended for the user, 
they have super user friendly KCM to edit their settings.

Adding nested  as you mentioned has bigger impact on compiler, xsd, and 
so on.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75032.
crossi added a comment.


  remove TODO comment that was addressed

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=74938=75032

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 74938.
crossi added a comment.


  noop

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=74937=74938

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi created this revision.
crossi added a reviewer: ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Following D27059 , add group separator to 
generate kconfig settings with subgroups

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 74799.
crossi added a comment.


  code style

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74756=74799

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 74756.
crossi added a comment.


  code style

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74754=74756

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi created this revision.
crossi added a reviewer: ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Currently KConfgiSkeleton cannot manage item entry in subgroup.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi updated this revision to Diff 74128.
crossi added a comment.


  code style

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=74125=74128

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi updated this revision to Diff 74125.
crossi added a comment.


  Clean the list properly

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=73411=74125

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi planned changes to this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi reclaimed this revision.
This revision now requires changes to proceed.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi abandoned this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven
Cc: plasma-devel, meven, bport, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi abandoned this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ee3176ce5641: Expose KConfig settings to allow 
registration in KCM Notification (authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=74023=74079

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 74023.
crossi added a comment.


  Remove unneeded forward declaration

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=74021=74023

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 74021.
crossi added a comment.


  Following discussion with @ervin and @broulik, export generated KConfig 
settings, remove singleton option. The KCM will have its own KConfig settings' 
instance like other KCMs.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=73214=74021

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi planned changes to this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi updated this revision to Diff 73411.
crossi added a comment.


  API documentation. Schedule settingsChanged(). Clean up the list. Code style.

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=71673=73411

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi updated this revision to Diff 73216.
crossi added a comment.


  space

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26082?vs=73215=73216

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi updated this revision to Diff 73215.
crossi added a comment.


  Add API documentation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26082?vs=71783=73215

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 73214.
crossi added a comment.


  Add API documentation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=71676=73214

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> broulik wrote in settings.h:343
> Not a fan of this becoming public API

Maybe not the best approach.

Any suggestion to access the KCoreConfigSkeleton encapsulated to register them 
in the KCM's ConfigModule ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, mart, davidedmundson, 
broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Allow the KCM Notifications to query the immutable status of each settings.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> meven wrote in managedconfigmodule.h:205
> Mention importance of emitting configChanged signal to automatically call 
> settingsChanged as alternative to calling settingsChanged.

It is not an alternative, configChanged is a KCoreConfigSkeleton's signal that 
will trigger a settingsChanged.
The proper way to use it, is register several settings (KCoreConfigSkeleton), 
then call settingsChanged that will perform a check on all registered settings.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> davidedmundson wrote in managedconfigmodule.cpp:43
> Any reason for doing this approach rather than connecting to QObject:: 
> destroyed and cleaning the list as we go?

Sort of a guard if one registers manually a KCoreConfigSkeleton and then 
deallocate it.
It is not intended to manage the deallocation as KCoreConfigSkeleton are 
normally registered in the QObject hierarchy.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  For KCM Notification, allow to register the generated settings to the 
ManagedConfigModule machinery

TEST PLAN
  refactor, no change

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Helpful for derived class that do not store KConfig settings as children 
items.

TEST PLAN
  Should not break binary compatibility. Same behaviour as before.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

[Cyril Rossi]

crossi abandoned this revision.
crossi added a comment.


  No longer need since 866d3f45b84e 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25520

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

[Cyril Rossi]

crossi added a dependent revision: D25525: KCM Style : take into account 
immutable properties.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25520

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

[Cyril Rossi]

crossi added a comment.


  In D25520#567254 , @broulik wrote:
  
  > Can't you do `view.enabled: false`?
  >  Edit: Never mind, `view` is bound to `scroll.view`, not `scroll`
  
  
  I did, but the GridView's style was not updateed to show it was disabled.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25520

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Some KCM use GridViewKCM as root item, and they may have extra items appended 
in the footer. Setting 'enabled: false' property of the root item, will disable 
the whole page, including the header and footer as well. This patch allow to 
enable/disable only the GridView.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25520

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns