D12992: New elisa icon

[Diego Gangl]

januz added a comment.


  In D12992#267534 , @lshoravi wrote:
  
  > I agree in that a circle doesn't have as much personality as maybe a
  >  casette. I also agree in that the casette felt off when looking at it.
  >
  > How would something like an LP player with the E on top feel? I won't have
  >  time until Monday (finals coming up), but my gut says that a brown-ish
  >  square with a dark circle (like seeing an LP player from above) with some
  >  iconography on top could look good.
  
  
  Yeah, that could be interesting. Another idea to explore could be replacing 
the green background with a vinyl record, keeping the E on top in white. 
  Also, I think the E would read better if it was open on top (instead of 
curlying on itself). With that change you could also bring back the clef-like 
bottom and it'd still read fine.
  
  @mgallien I'm not sure about youngsters not getting it. There are still bands 
putting out cassettes, and Guardians of the galaxy brought them back to the 
spotlight for a while too. And who knows, maybe in a few decades kids will look 
at cassettes and think they are 3D printed Elisa icons :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: paullesur, januz, astippich, mgallien, alex-l, andreask, 
kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, 
michaelh, ngraham, bruns, kmf

D12992: New elisa icon

[Diego Gangl]

januz added a comment.


  TBH I like the concept of the cassette icon more than the current 
implementation of it. What was good about about is that it had //personality//, 
which is a big deal since usually icons also double as logos. IMO a solid icon 
should be 1) Memorable and 2) Descriptive. Imagine both icons amongst these 
google search results 
 and 
consider which one would stand out, which one you would know it's elisa's. 
These icons are technically great, they are just not memorable.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: januz, astippich, mgallien, alex-l, andreask, kde-frameworks-devel, 
ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, 
ngraham, bruns, kmf

D12992: New elisa icon

[Diego Gangl]

januz added a comment.


  In D12992#266673 , @mgallien wrote:
  
  > In D12992#266288 , @alex-l wrote:
  >
  > > F5863162: image.png 
  > >
  > > ^ I'm for this one without the quaver
  >
  >
  > I also prefer this one without the quaver.
  >  Is it possible to really simplify the background for the small size icon ? 
It would be probably much easier to read it.
  >
  > @astippich  and @januz what is your opinion ? You are also working on Elisa 
and should have the rights to speak ;)
  
  
  I agree on this one without the quaver, maybe it could also have a bit of a 
circle at the end of the (like the circles in the quaver). That said, we just 
changed icons a month or 2 ago. Are we sure about completely dropping the 
casette concept and changing again?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: januz, astippich, mgallien, alex-l, andreask, kde-frameworks-devel, 
ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, 
ngraham, bruns, kmf

D10365: New icon for Elisa music player

[Diego Gangl]

januz added a comment.


  Agree with the text not being useful for small sizes, but it could look good 
for a large logo-style image (like say, a 256px logo on the wiki/homepage). 
  A cassette is definitely an interesting idea for an icon. At least it's not 
another musical note or play icon 

 :)
  
  It's true that it's old school, but we also use CDs for albums which is also 
kind of old school now, so it's not totally off. Green is ok too, since the CDs 
and their background are all green (and blueish). You could also mixing it with 
some subtle blue/cyan tints in there.
  
  Also, I think if we're going 80s we should go all the way. Instead of a 
gradient (green to white), consider using some 80s motif like the vanishing 
lines in here:
  
https://www.google.com.ar/search?dcr=0=imgo%3A1=isch=1=zzp-WvW5MsPCwATB-LGwAQ=awesome+mix+vol+2=awesome+mix_l=psy-ab.3.1.0l10.345494.346631.0.348056.11.9.0.2.2.0.144.983.4j5.9.00...1c.1.64.psy-ab..1.10.890...0i67k1.0.QW76y1ueao8#imgrc=66ooLxhTsA9q2M
  
  You should probably limit it to 1-2 lines for the smaller sizes though. You 
could probably replace the text with the lines/motif in small sizes too.
  
  More ideas for that: 
https://www.google.com.ar/search?dcr=0=imgo%3A1=isch=1=Rj1-WvPjLYaTwgTj1p2YCw=80s+cassette=80s+cassette_l=psy-ab.3..0l2j0i30k1l4j0i8i30k1l2.18392.20298.0.20566.12.12.0.0.0.0.115.1019.11j1.12.00...1c.1.64.psy-ab..0.12.1013...0i67k1j0i10i24k1.0.PyemoiQ5FVk
  
  BTW, love your avatar!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska
Cc: januz, astippich, andreask, andreaska, ltoscano, ngraham, #frameworks, 
paullesur, michaelh, ognarb, kmf, progwolff, mgallien

D8371: Support for underscores in numeric literals (Python 3.6)

[Diego Gangl]

januz added a comment.


  Thanks for the tips guys!
  
  This patch still has two problems (that I'm aware :) ):
  
  - I can't get it to match the dot in the float regex. The regex itself is ok 
(https://regexr.com/3idtj), but it just doesn't work.
  - The regexes don't work inside lists or dictionaries. I've noticed 
highlighting for complex numbers doesn't work either though, so it might not be 
related to this patch.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8371

To: januz, #kate
Cc: dhaumann, cullmann, #frameworks, genethomas, vkrause

D8371: Support for underscores in numeric literals (Python 3.6)

[Diego Gangl]

januz updated this revision to Diff 24317.
januz added a comment.


  - Tweaked regexes to fit better with the other regex in the file
  - Version bump
  - Added autotests and updated references

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8371?vs=20991=24317

BRANCH
  python_separators

REVISION DETAIL
  https://phabricator.kde.org/D8371

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.py.ref
  data/syntax/python.xml

To: januz, #kate
Cc: dhaumann, cullmann, #frameworks, genethomas, vkrause

D8371: Support for underscores in numeric literals (Python 3.6)

[Diego Gangl]

januz added a comment.


  In https://phabricator.kde.org/D8371#177673, @cullmann wrote:
  
  > b) an extended unit test would be nice, to really show that the regex are 
right.
  
  
  Hi, sure. Is there any documentation on how to make those tests? I noticed 
there are some ref and input files, do I just modify those and run the tests?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8371

To: januz, #kate
Cc: cullmann, #frameworks, genethomas, vkrause, dhaumann

D8371: Support for underscores in numeric literals (Python 3.6)

[Diego Gangl]

januz created this revision.
januz added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This patch adds support for underscores in numeric literals for Python 3.6 
(from PEP 515 )
  Bug from tracker: https://bugs.kde.org/show_bug.cgi?id=385422

TEST PLAN
  Test different numbers with underscore in the code editor sample.
  
  an_int = 100_000_000
  a_float = 100__000.0
  some_hex = 0xEAD2_DF24_3D

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8371

AFFECTED FILES
  data/syntax/python.xml

To: januz
Cc: #frameworks, cullmann, vkrause, dhaumann