D18864: FlatBuffers schema syntax highlighting

[Harald Fernengel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:926feb55fa02: FlatBuffers schema syntax highlighting 
(authored by harald).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18864?vs=51331=51398

REVISION DETAIL
  https://phabricator.kde.org/D18864

AFFECTED FILES
  autotests/folding/test.fbs.fold
  autotests/html/test.fbs.html
  autotests/input/test.fbs
  autotests/reference/test.fbs.ref
  data/syntax/flatbuffers.xml

To: harald, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, 
ngraham, bruns, demsking, sars

D18864: FlatBuffers schema syntax highlighting

[Harald Fernengel]

harald marked 2 inline comments as done.
harald added a comment.


  In D18864#408305 , @dhaumann wrote:
  
  > Hi Harald, nice hearing from you. Patch looks good and can almost go in as 
is. But could you address the two comments and also add a test file for unit 
testing? It can be short, is not required to make sense, and best is also MIT 
licensed.
  
  
  Hi Dominik, thanks so much for the review :) I took the default flatbuffers 
file from their docs as that has most of the keywords/attributes. Their 
documentation is Apache licensed, so I guess this should be OK?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

To: harald, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D18864: FlatBuffers schema syntax highlighting

[Harald Fernengel]

harald updated this revision to Diff 51331.
harald added a comment.


  Added test, license and highlighting of attributes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18864?vs=51217=51331

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

AFFECTED FILES
  autotests/folding/test.fbs.fold
  autotests/html/test.fbs.html
  autotests/input/test.fbs
  autotests/reference/test.fbs.ref
  data/syntax/flatbuffers.xml

To: harald, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D18864: FlatBuffers schema syntax highlighting

[Harald Fernengel]

harald created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
harald requested review of this revision.

REVISION SUMMARY
  Support for FlatBuffers schema, for grammar see
  https://google.github.io/flatbuffers/flatbuffers_grammar.html

TEST PLAN
  Opened some Flatbuffers in kate and Qt Creator

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

AFFECTED FILES
  data/syntax/flatbuffers.xml

To: harald
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D16801: Fix build on macOS

[Harald Fernengel]

harald abandoned this revision.
harald added a comment.


  Abandoned, already fixed by https://phabricator.kde.org/D16862

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16801

To: harald
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16801: Fix build on macOS

[Harald Fernengel]

harald removed a reviewer: apol.
This revision now requires review to proceed.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16801

To: harald, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16801: Fix build on macOS

[Harald Fernengel]

harald created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
harald requested review of this revision.

REVISION SUMMARY
  On macOS, I'm getting the following error:
  
CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if):
  if given arguments:

"AND" "AND"

  Unknown arguments specified
  
  The reason is the double expansion of arguments in CMake, so instead of `if 
(${FOO})` one should write `if(FOO)`.
  
  This patch fixes the build.

TEST PLAN
  Running `cmake` on Mac OS X passes.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16801

AFFECTED FILES
  src/runtime/plugins/CMakeLists.txt

To: harald
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130138/
---

(Updated June 1, 2017, 1:27 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
---

Apparently, exceptions are disabled when building *.mm files.
The alternative would be to set

target_compile_options(sonnet_nsspellchecker PRIVATE "-fexceptions")

in order to force exception to be on for *.mm files. However, since
exceptions aren't used in the code, let's just build without.


Diffs
-

  src/plugins/nsspellchecker/CMakeLists.txt 
f8c99d1ea080b1e28f60c57f8f588ed059c96711 

Diff: https://git.reviewboard.kde.org/r/130138/diff/


Testing
---


Thanks,

Harald Fernengel

Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130139/
---

(Updated June 1, 2017, 1:27 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and René J.V. Bertin.


Repository: kinit


Description
---

Seems that some versions of clang default to build *.mm files with
exceptions disabled, so compilation would fail with:

include/QtCore/qlist.h:522:9: error: cannot use 'throw' with exceptions disabled


Diffs
-

  src/kdeinit/CMakeLists.txt f00dd77baa95dbe7583e08760302951446aff387 

Diff: https://git.reviewboard.kde.org/r/130139/diff/


Testing
---


Thanks,

Harald Fernengel

Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

[Harald Fernengel]

> On May 25, 2017, 2:36 p.m., René J.V. Bertin wrote:
> > See also https://phabricator.kde.org/D5972

agree that it should be fixed in ecm. Hope the fix can make it to the next 
release of kf5-ecm so I can remove my hack from homebrew


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130139/#review103244
---


On May 25, 2017, 11:37 a.m., Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130139/
> ---
> 
> (Updated May 25, 2017, 11:37 a.m.)
> 
> 
> Review request for KDE Frameworks and René J.V. Bertin.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> Seems that some versions of clang default to build *.mm files with
> exceptions disabled, so compilation would fail with:
> 
> include/QtCore/qlist.h:522:9: error: cannot use 'throw' with exceptions 
> disabled
> 
> 
> Diffs
> -
> 
>   src/kdeinit/CMakeLists.txt f00dd77baa95dbe7583e08760302951446aff387 
> 
> Diff: https://git.reviewboard.kde.org/r/130139/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

Re: Review Request 123075: do not require X11 on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/
---

(Updated June 1, 2017, 1:20 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Michael Palimaka.


Repository: kdesu


Description
---

do not require X11 on Mac OS X


Diffs
-

  CMakeLists.txt 9623483d6f11f9cdb7d7dc19decfd7cf5e86d079 

Diff: https://git.reviewboard.kde.org/r/123075/diff/


Testing
---


Thanks,

Harald Fernengel

Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130139/
---

Review request for KDE Frameworks and René J.V. Bertin.


Repository: kinit


Description
---

Seems that some versions of clang default to build *.mm files with
exceptions disabled, so compilation would fail with:

include/QtCore/qlist.h:522:9: error: cannot use 'throw' with exceptions disabled


Diffs
-

  src/kdeinit/CMakeLists.txt f00dd77baa95dbe7583e08760302951446aff387 

Diff: https://git.reviewboard.kde.org/r/130139/diff/


Testing
---


Thanks,

Harald Fernengel

Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130138/
---

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
---

Apparently, exceptions are disabled when building *.mm files.
The alternative would be to set

target_compile_options(sonnet_nsspellchecker PRIVATE "-fexceptions")

in order to force exception to be on for *.mm files. However, since
exceptions aren't used in the code, let's just build without.


Diffs
-

  src/plugins/nsspellchecker/CMakeLists.txt 
f8c99d1ea080b1e28f60c57f8f588ed059c96711 

Diff: https://git.reviewboard.kde.org/r/130138/diff/


Testing
---


Thanks,

Harald Fernengel

Re: Review Request 125390: Fix build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125390/
---

(Updated Sept. 29, 2015, 1:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit 0f8592f27064ba92485928a0de074c58118414aa by Harald 
Fernengel to branch master.


Repository: kdesignerplugin


Description
---

Qt 5.5 requires Qt5UiPlugin framework to be in the include path.
On Linux this didn't break as all Qt headers are typically in the
same prefix, but on Mac, the include hierarchy is quite different.


Diffs
-

  KF5DesignerPluginMacros.cmake 15db23db3c275c231487d8bafc8fb3f4df624905 

Diff: https://git.reviewboard.kde.org/r/125390/diff/


Testing
---


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125337: Mark kconfig-compiler as non-gui tool

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125337/
---

(Updated Sept. 25, 2015, 11:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez and Matthew Dawson.


Changes
---

Submitted with commit 83b223025670494116349382144780143f6e9563 by Harald 
Fernengel to branch master.


Repository: kconfig


Description
---

Makes sure that it doens't create an app bundle on Mac OS X


Diffs
-

  src/kconfig_compiler/CMakeLists.txt 368a4d84d032878ff56234e0c540463670a94ec7 

Diff: https://git.reviewboard.kde.org/r/125337/diff/


Testing
---

Builds with homebrew on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125390: Fix build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125390/
---

Review request for KDE Frameworks and Alex Merry.


Repository: kdesignerplugin


Description
---

Qt 5.5 requires Qt5UiPlugin framework to be in the include path.
On Linux this didn't break as all Qt headers are typically in the
same prefix, but on Mac, the include hierarchy is quite different.


Diffs
-

  KF5DesignerPluginMacros.cmake 15db23db3c275c231487d8bafc8fb3f4df624905 

Diff: https://git.reviewboard.kde.org/r/125390/diff/


Testing
---


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125337: Mark kconfig-compiler as non-gui tool

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125337/
---

Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
---

Makes sure that it doens't create an app bundle on Mac OS X


Diffs
-

  src/kconfig_compiler/CMakeLists.txt 368a4d84d032878ff56234e0c540463670a94ec7 

Diff: https://git.reviewboard.kde.org/r/125337/diff/


Testing
---

Builds with homebrew on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123075: do not require X11 on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/
---

Review request for KDE Frameworks and Michael Palimaka.


Repository: kdesu


Description
---

do not require X11 on Mac OS X


Diffs
-

  CMakeLists.txt 9623483d6f11f9cdb7d7dc19decfd7cf5e86d079 

Diff: https://git.reviewboard.kde.org/r/123075/diff/


Testing
---


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119567: Also find catalog files that are symlinks

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119567/
---

(Updated Feb. 13, 2015, 12:26 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

When building KF5 on Mac OS X with homebrew, the catalog and
other files are symlinked from the 'Cellar' (install dir) to the
homebrew prefix. After that, meinproc5 wouldn't find its catalog
because it decides to ignore symbolic links. Removing that option
fixes the build on Mac OS X.


Diffs
-

  src/docbookl10nhelper.cpp 6eecb376cab6e3ba03e9548b3402eaa5e5530198 
  src/xslt.cpp 3c81a172b00458419fc2f310cbdf76eb357336fc 

Diff: https://git.reviewboard.kde.org/r/119567/diff/


Testing
---

Builds on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119567: Also find catalog files that are symlinks

[Harald Fernengel]

 On Aug. 1, 2014, 11:25 p.m., Luigi Toscano wrote:
  src/xslt.cpp, line 426
  https://git.reviewboard.kde.org/r/119567/diff/1/?file=294860#file294860line426
 
  Uhm, but that's strange. Just to be sure, do I understand it correctly 
  that every file in customization is sym-linked? O.o

Yes, homebrew on Mac OS X is a packager that works like GoboLinux, where each 
file is installed in a temp area, and then symlinked into the actual file system


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119567/#review63656
---


On Aug. 1, 2014, 5:58 p.m., Harald Fernengel wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119567/
 ---
 
 (Updated Aug. 1, 2014, 5:58 p.m.)
 
 
 Review request for Documentation, KDE Frameworks and Luigi Toscano.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 When building KF5 on Mac OS X with homebrew, the catalog and
 other files are symlinked from the 'Cellar' (install dir) to the
 homebrew prefix. After that, meinproc5 wouldn't find its catalog
 because it decides to ignore symbolic links. Removing that option
 fixes the build on Mac OS X.
 
 
 Diffs
 -
 
   src/docbookl10nhelper.cpp 6eecb376cab6e3ba03e9548b3402eaa5e5530198 
   src/xslt.cpp 3c81a172b00458419fc2f310cbdf76eb357336fc 
 
 Diff: https://git.reviewboard.kde.org/r/119567/diff/
 
 
 Testing
 ---
 
 Builds on Mac OS X
 
 
 Thanks,
 
 Harald Fernengel
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119567: Also find catalog files that are symlinks

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119567/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

When building KF5 on Mac OS X with homebrew, the catalog and
other files are symlinked from the 'Cellar' (install dir) to the
homebrew prefix. After that, meinproc5 wouldn't find its catalog
because it decides to ignore symbolic links. Removing that option
fixes the build on Mac OS X.


Diffs
-

  src/docbookl10nhelper.cpp 6eecb376cab6e3ba03e9548b3402eaa5e5530198 
  src/xslt.cpp 3c81a172b00458419fc2f310cbdf76eb357336fc 

Diff: https://git.reviewboard.kde.org/r/119567/diff/


Testing
---

Builds on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

[Harald Fernengel]

 On March 4, 2014, 8:28 p.m., Kevin Ottens wrote:
  src/karchive.h, line 32
  https://git.reviewboard.kde.org/r/115977/diff/1/?file=245721#file245721line32
 
  Hm, why the change to  for the includes? We try to stick to  in 
  public headers.
 
 Kevin Ottens wrote:
 Any news?
 
 Kevin Ottens wrote:
 Should it be discarded by lack of activity?

Heh, patch is still valid, I just didn't have time to follow up  test. The  
vs.  is due to the way OS X frameworks find their headers - e.g. either use 
prefix/foo.h or foo.h.


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115977/#review51936
---


On Feb. 23, 2014, 7:15 p.m., Harald Fernengel wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115977/
 ---
 
 (Updated Feb. 23, 2014, 7:15 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: karchive
 
 
 Description
 ---
 
 Change CMakeLists.txt to create Mac OS X frameworks
 
 
 Diffs
 -
 
   CMakeLists.txt f5dc644fdba13e29c94940c77d628e92e0759787 
   src/CMakeLists.txt 53e97284cab199f5eb75aa276adfadc18d677682 
   src/karchive.h d4209cf334190dda735fcb4687fa102a4e7a73cd 
   src/karchivedirectory.h 60225d0be9fc2e28ff2b998dcc8fb28512c6e3cd 
   src/karchiveentry.h aad6840ee0dc22e5760ddda99ce975a1d9a9dc92 
   src/karchivefile.h c7d2e0e0735f75a8e490082aa8598fd08206a998 
   src/ktar.h 4bca89884e646ffae90aa1a9e15a985e998e843f 
 
 Diff: https://git.reviewboard.kde.org/r/115977/diff/
 
 
 Testing
 ---
 
 'make install' on Mac OS X
 
 
 Thanks,
 
 Harald Fernengel
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115982/
---

(Updated March 4, 2014, 6:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Repository: kiconthemes


Description
---

This is a small tool that generates Mac OS X icon files from (oxygen) svg[z] 
files.


Diffs
-

  src/tools/ksvg2icns/ksvg2icns.cpp PRE-CREATION 
  src/tools/ksvg2icns/CMakeLists.txt PRE-CREATION 
  src/CMakeLists.txt 76932ca87c7de2dc25398e1fca8916426ce7e566 

Diff: https://git.reviewboard.kde.org/r/115982/diff/


Testing
---

Builds on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/
---

(Updated March 4, 2014, 8:09 p.m.)


Status
--

This change has been discarded.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Let it point to ~/Library/Application Support as that is what QStandardPaths 
expects

This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as data 
path, but Qt only reports ~/Library/Application\ Support

So - do we add some magic to Qt to allow user-configurable extra data dirs 
(juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR to 
~/Library/Application\ Support?


Diffs
-

  kde-modules/KDEInstallDirs.cmake 9ff23540f00a2794b1ebd842656c3d61b047a500 

Diff: https://git.reviewboard.kde.org/r/115752/diff/


Testing
---

Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115977: RFC: Install KArchive as Mac OS X Framework

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115977/
---

Review request for KDE Frameworks.


Repository: karchive


Description
---

Change CMakeLists.txt to create Mac OS X frameworks


Diffs
-

  CMakeLists.txt f5dc644fdba13e29c94940c77d628e92e0759787 
  src/CMakeLists.txt 53e97284cab199f5eb75aa276adfadc18d677682 
  src/karchive.h d4209cf334190dda735fcb4687fa102a4e7a73cd 
  src/karchivedirectory.h 60225d0be9fc2e28ff2b998dcc8fb28512c6e3cd 
  src/karchiveentry.h aad6840ee0dc22e5760ddda99ce975a1d9a9dc92 
  src/karchivefile.h c7d2e0e0735f75a8e490082aa8598fd08206a998 
  src/ktar.h 4bca89884e646ffae90aa1a9e15a985e998e843f 

Diff: https://git.reviewboard.kde.org/r/115977/diff/


Testing
---

'make install' on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Mac OS X Frameworks Frameworks

[Harald Fernengel]

Hi,

TL;DR

Do we want to do build KDE Frameworks as Mac OS X Frameworks?

Long Story:

on Mac OS X, libraries are typically deployed as Frameworks (e.g. a
directory containing the shared library, headers, resources and meta
data). A framework can be simply draggeddropped to Xcode projects and
it's also easier from command line:

clang++ -framework KF5Archive -framework QtCore main.cpp

(Assuming that Qt and KF5Archive are in a standard Framework path,
otherwise, add -F /path/to/framework).

I tried to create an OS X Framework out of KArchive and ended up with
attached patch (see also https://git.reviewboard.kde.org/r/115977/)

What needs to happen on KF5 side?

1) All public headers must be added as source files (e.g. to
add_library()) and set as PUBLIC_HEADER property on the target. Instead
of a manual install rule, we need to set PUBLIC_HEADER DESTINATION to
the install TARGETS rule.

2) Public (installed) headers must use

#include myOtherHeader  // (double quotes)

to include headers belonging to the same framework

3) Public headers must use

#include KF5Whatever/foo.h

to include headers belonging to other frameworks

Is that worth the hassle? If yes, I can try to convert some of our libs
to OS X frameworks, hoping not to break things for other platforms ;)

Harald
diff --git a/CMakeLists.txt b/CMakeLists.txt
index f5dc644..0c59012 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -53,6 +53,8 @@ ecm_setup_version(${KF5_VERSION}
 PACKAGE_VERSION_FILE 
${CMAKE_CURRENT_BINARY_DIR}/KF5ArchiveConfigVersion.cmake
 )
 
+list(APPEND KArchive_GENERATED_HEADERS 
${CMAKE_CURRENT_BINARY_DIR}/karchive_version.h)
+
 add_subdirectory(src)
 add_subdirectory(autotests)
 add_subdirectory(tests)
@@ -69,10 +71,6 @@ ecm_configure_package_config_file(
 INSTALL_DESTINATION ${CMAKECONFIG_INSTALL_DIR}
 )
 
-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/karchive_version.h
-DESTINATION ${INCLUDE_INSTALL_DIR}
-COMPONENT Devel)
-
 install(FILES
 ${CMAKE_CURRENT_BINARY_DIR}/KF5ArchiveConfig.cmake
 ${CMAKE_CURRENT_BINARY_DIR}/KF5ArchiveConfigVersion.cmake
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 53e9728..2eaa05f 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -34,7 +34,27 @@ set(karchive_SRCS
 kzip.cpp
 )
 
-add_library(KF5Archive ${karchive_SRCS} ${karchive_OPTIONAL_SRCS})
+ecm_generate_headers(KArchive_HEADERS
+HEADER_NAMES
+KArchive
+KArchiveEntry
+KArchiveFile
+KArchiveDirectory
+KAr
+KCompressionDevice
+KFilterBase
+KFilterDev
+KTar
+KZip
+KZipFileEntry
+
+REQUIRED_HEADERS KArchive_HEADERS
+)
+
+list(APPEND KArchive_GENERATED_HEADERS 
${CMAKE_CURRENT_BINARY_DIR}/karchive_export.h)
+
+add_library(KF5Archive ${karchive_SRCS} ${karchive_OPTIONAL_SRCS} 
${KArchive_HEADERS} ${KArchive_GENERATED_HEADERS})
+set_target_properties(KF5Archive PROPERTIES FRAMEWORK TRUE)
 generate_export_header(KF5Archive BASE_NAME KArchive)
 add_library(KF5::Archive ALIAS KF5Archive)
 
@@ -56,25 +76,12 @@ set_target_properties(KF5Archive PROPERTIES
 EXPORT_NAME Archive
 )
 
-ecm_generate_headers(KArchive_HEADERS
-HEADER_NAMES
-KArchive
-KArchiveEntry
-KArchiveFile
-KArchiveDirectory
-KAr
-KCompressionDevice
-KFilterBase
-KFilterDev
-KTar
-KZip
-KZipFileEntry
-
-REQUIRED_HEADERS KArchive_HEADERS
-)
+set_target_properties(KF5Archive PROPERTIES PUBLIC_HEADER 
${KArchive_HEADERS};${KArchive_GENERATED_HEADERS})
 
 install(TARGETS KF5Archive
 EXPORT KF5ArchiveTargets
+FRAMEWORK DESTINATION ${LIB_INSTALL_DIR}
+PUBLIC_HEADER DESTINATION ${INCLUDE_INSTALL_DIR}/KArchive
 ${INSTALL_TARGETS_DEFAULT_ARGS})
 
 if(LIBLZMA_FOUND)
@@ -85,12 +92,6 @@ if(LIBLZMA_FOUND)
 )
 endif()
 
-install(FILES
-${CMAKE_CURRENT_BINARY_DIR}/karchive_export.h
-${KArchive_HEADERS}
-DESTINATION ${INCLUDE_INSTALL_DIR}/KArchive
-COMPONENT Devel)
-
 include(ECMGeneratePriFile)
 ecm_generate_pri_file(
 BASE_NAME KArchive
diff --git a/src/karchive.h b/src/karchive.h
index d4209cf..a75d240 100644
--- a/src/karchive.h
+++ b/src/karchive.h
@@ -29,7 +29,7 @@
 #include QtCore/QStringList
 #include QtCore/QHash
 
-#include karchive_export.h
+#include karchive_export.h
 
 #ifdef Q_OS_WIN
 #include qplatformdefs.h // mode_t
diff --git a/src/karchivedirectory.h b/src/karchivedirectory.h
index 60225d0..d234fc8 100644
--- a/src/karchivedirectory.h
+++ b/src/karchivedirectory.h
@@ -28,7 +28,7 @@
 #include QtCore/QString
 #include QtCore/QStringList
 
-#include karchiveentry.h
+#include karchiveentry.h
 
 class KArchiveDirectoryPrivate;
 /**
diff --git a/src/karchiveentry.h b/src/karchiveentry.h
index aad6840..d5c68a9 100644
--- a/src/karchiveentry.h
+++ b/src/karchiveentry.h
@@ -24,7 +24,7 @@
 #include sys/stat.h
 #include sys/types.h
 
-#include karchive_export.h
+#include karchive_export.h
 
 #ifdef Q_OS_WIN
 #include qplatformdefs.h // 

Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115982/
---

Review request for KDE Frameworks and Christoph Feck.


Repository: kiconthemes


Description
---

This is a small tool that generates Mac OS X icon files from (oxygen) svg[z] 
files.


Diffs
-

  src/CMakeLists.txt 76932ca87c7de2dc25398e1fca8916426ce7e566 
  src/tools/ksvg2icns/CMakeLists.txt PRE-CREATION 
  src/tools/ksvg2icns/ksvg2icns.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115982/diff/


Testing
---

Builds on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/
---

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Let it point to ~/Library/Application Support as that is what QStandardPaths 
expects

This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as data 
path, but Qt only reports ~/Library/Application\ Support

So - do we add some magic to Qt to allow user-configurable extra data dirs 
(juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR to 
~/Library/Application\ Support?


Diffs
-

  kde-modules/KDEInstallDirs.cmake 9ff23540f00a2794b1ebd842656c3d61b047a500 

Diff: https://git.reviewboard.kde.org/r/115752/diff/


Testing
---

Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115541: Build fix for Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115541/
---

(Updated Feb. 12, 2014, 9:05 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: attica


Description
---

Case-insensitive filesystems don't like the Attica vs. attica pathes, when 
installing, the headers would all be messed up. Instead, install everything to 
include/KF5/Attica to be in line with the other frameworks.

Note - this might not be the best solution, but we need one in order to deploy 
on Mac OS X :)


Diffs
-

  src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d 

Diff: https://git.reviewboard.kde.org/r/115541/diff/


Testing
---

Only on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115684/#review49655
---

Ship it!


Ship It!

- Harald Fernengel


On Feb. 11, 2014, 10:15 p.m., David Faure wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115684/
 ---
 
 (Updated Feb. 11, 2014, 10:15 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 Harald Fernengel.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Generate local forwarding headers under a local subdir, to fix clash on Mac 
 OS X.
 
 This is intended to replace RR 115541.
 
 With case-insensitive filesystems, creating KParts and kparts subdirs
 in the same parent was obviously a bad idea, especially since we then
 make a copy of KParts and don't expect the contents of kparts to tag 
 along.
 Solved by making that KParts (installed) and local/kparts (not installed).
 
 Downside: the modules that use this PREFIX feature need a change like this:
 -target_include_directories(KF5Parts PUBLIC 
 $BUILD_INTERFACE:${KParts_BINARY_DIR})
 +target_include_directories(KF5Parts PUBLIC 
 $BUILD_INTERFACE:${KParts_BINARY_DIR};${CMAKE_CURRENT_BINARY_DIR}/local)
 
 Easily scripted though:
 perl -pi -e 's//\;\${CMAKE_CURRENT_BINARY_DIR}\/local/ if 
 (/target_include_directories/  /PUBLIC/)' `grep -rwl PREFIX .`
 
 
 Diffs
 -
 
   modules/ECMGenerateHeaders.cmake e98a22e91151d23d7c798ff22a33097ec2a59d10 
 
 Diff: https://git.reviewboard.kde.org/r/115684/diff/
 
 
 Testing
 ---
 
 Applied it, ran the perl script, and a full build-from-scratch worked.
 Not tested on a Mac, though :)
 
 
 Thanks,
 
 David Faure
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

[Harald Fernengel]

 On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote:
  Makes sense to me, I most certainly didn't consider it as a problem.
  
  This could break compilation on some projects other than KParts, will you 
  be able to try the rest of the modules?
  
  Thanks for figuring it out!
 
 David Faure wrote:
 I compiled *all* the frameworks, after porting all of them with the perl 
 line above.
 
 It's all working, but I find it slightly ugly that the user of the macro 
 has to know about adding ./local to the include path. This is why I put it 
 up for review, maybe someone has a better idea.
 
 Alex Merry wrote:
 If you don't mind holding off until the weekend, I'll try to have a look 
 at it on Friday.

Works great on Mac OS X :)


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115684/#review49615
---


On Feb. 11, 2014, 10:15 p.m., David Faure wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115684/
 ---
 
 (Updated Feb. 11, 2014, 10:15 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 Harald Fernengel.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Generate local forwarding headers under a local subdir, to fix clash on Mac 
 OS X.
 
 This is intended to replace RR 115541.
 
 With case-insensitive filesystems, creating KParts and kparts subdirs
 in the same parent was obviously a bad idea, especially since we then
 make a copy of KParts and don't expect the contents of kparts to tag 
 along.
 Solved by making that KParts (installed) and local/kparts (not installed).
 
 Downside: the modules that use this PREFIX feature need a change like this:
 -target_include_directories(KF5Parts PUBLIC 
 $BUILD_INTERFACE:${KParts_BINARY_DIR})
 +target_include_directories(KF5Parts PUBLIC 
 $BUILD_INTERFACE:${KParts_BINARY_DIR};${CMAKE_CURRENT_BINARY_DIR}/local)
 
 Easily scripted though:
 perl -pi -e 's//\;\${CMAKE_CURRENT_BINARY_DIR}\/local/ if 
 (/target_include_directories/  /PUBLIC/)' `grep -rwl PREFIX .`
 
 
 Diffs
 -
 
   modules/ECMGenerateHeaders.cmake e98a22e91151d23d7c798ff22a33097ec2a59d10 
 
 Diff: https://git.reviewboard.kde.org/r/115684/diff/
 
 
 Testing
 ---
 
 Applied it, ran the perl script, and a full build-from-scratch worked.
 Not tested on a Mac, though :)
 
 
 Thanks,
 
 David Faure
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115699: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115699/
---

(Updated Feb. 12, 2014, 3:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Gräßlin.


Repository: kde4support


Description
---

Fix the case where X11 is not available at compile time. 'Atom' seems to be 
X11-only? Also, KStartupInfo is required even on non-X11 builds.


Diffs
-

  src/kdeui/kapplication.cpp 47e4983c7392a0d60036ae86d976ae689a40d54a 
  src/kdeui/kmenubar.cpp f2dc2b1b3d22fa38cfe6af4a7761c148f840620d 

Diff: https://git.reviewboard.kde.org/r/115699/diff/


Testing
---

Compiles on Mac OS X.


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115708: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115708/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

On Mac OS X, the binary is in docbookl10nhelper.app/..., so let cmake 
substitute the actual binary instead of hard-coding it. Should also fix the 
build on windows, where the executable has a .exe suffix


Diffs
-

  src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a 

Diff: https://git.reviewboard.kde.org/r/115708/diff/


Testing
---

Building on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115708: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115708/#review49680
---



src/CMakeLists.txt
https://git.reviewboard.kde.org/r/115708/#comment34965

Note - cmake is documented to replace the COMMAND by the actual command, as 
we added it with add_executable before. Still, I would like someone to test 
this on non Mac OS X platforms :)


- Harald Fernengel


On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115708/
 ---
 
 (Updated Feb. 12, 2014, 9:46 p.m.)
 
 
 Review request for Documentation, KDE Frameworks and Luigi Toscano.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 On Mac OS X, the binary is in docbookl10nhelper.app/..., so let cmake 
 substitute the actual binary instead of hard-coding it. Should also fix the 
 build on windows, where the executable has a .exe suffix
 
 
 Diffs
 -
 
   src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a 
 
 Diff: https://git.reviewboard.kde.org/r/115708/diff/
 
 
 Testing
 ---
 
 Building on Mac OS X
 
 
 Thanks,
 
 Harald Fernengel
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115209: Fix KDoctools build on Windows

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/#review49691
---


I locally fixed the 'if (WIN32)' issue in CMakeLists.txt and it fixes the build 
also on Mac OS X :) Nicely done!

- Harald Fernengel


On Jan. 22, 2014, 3:12 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115209/
 ---
 
 (Updated Jan. 22, 2014, 3:12 p.m.)
 
 
 Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 Two separate commits: 
 
 ---
 
 Print a message when a file is not found
 
 This way meinproc no longer fails silently
 
 --
 
 Allow compiling on Windows with MSVC
 
 
 Diffs
 -
 
   CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 
   src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b 
   src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 
   src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade 
   src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 
 
 Diff: https://git.reviewboard.kde.org/r/115209/diff/
 
 
 Testing
 ---
 
 Works on windows once https://git.reviewboard.kde.org/r/115210/ is also 
 applied
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115708: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115708/
---

(Updated Feb. 13, 2014, 6:51 a.m.)


Status
--

This change has been discarded.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

On Mac OS X, the binary is in docbookl10nhelper.app/..., so let cmake 
substitute the actual binary instead of hard-coding it. Should also fix the 
build on windows, where the executable has a .exe suffix


Diffs
-

  src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a 

Diff: https://git.reviewboard.kde.org/r/115708/diff/


Testing
---

Building on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115541: Build fix for Mac OS X

[Harald Fernengel]

 On Feb. 8, 2014, 10:07 a.m., David Faure wrote:
  Urgh, we were hoping this wouldn't be an issue.
  
  This commit would break #include attica/event.h, so it cannot go in.
  
  All namespaced frameworks do it this way already btw, see kparts for 
  instance:
  
  -- Up-to-date: 
  /d/kde/inst/kde_frameworks/include/KF5/KParts/KParts/ReadWritePart
  -- Up-to-date: 
  /d/kde/inst/kde_frameworks/include/KF5/KParts/kparts/readwritepart.h
  
  Since there is no filename clash, what is the issue if these end up in the 
  same folder on Mac OSX?
 
 Harald Fernengel wrote:
 Here's the layout after make install on OS X:
 
 include/KF5/KParts/textextension.h contains:
 
 #include /tmp/kf5-kparts-ty2Y/src/textextension.h
 
 ^^^ this is broken, points to the temporary build dir...? What should 
 this include?
 
 Then, we have include/KF5/KParts/KParts/ which contains both lower case 
 and upper case headers.
 
 include/KF5/KParts/KParts/textextension.h is the actual header
 
 include/KF5/KParts/KParts/TextExtension contains:
 
 #include kparts/textextension.h
 

 
 David Faure wrote:
 Ah, I see. The local forwarding includes which are supposed to only be 
 used during compilation of kparts, get installed because they end up in 
 KParts/ instead of kparts/ (and the cmakelists.txt file just installs the 
 whole directory).
 
 I can think of two solutions...
 1) put local forwarders into ./local/kparts instead of ./kparts, to 
 ensure they stay out of ./KParts
 2) change cmakelists.txt to install a list of camelcase headers instead 
 of just the whole directory (which gives surprises with an unclean 
 builddir, installing old stuff still lying around)
 
 The first one seems simpler.
 
 In kparts/src:
 - target_include_directories(KF5Parts PUBLIC 
 $BUILD_INTERFACE:${KParts_BINARY_DIR})
 + target_include_directories(KF5Parts PUBLIC 
 $BUILD_INTERFACE:${KParts_BINARY_DIR}/local)
 
 And in CEM:
 
 diff --git a/modules/ECMGenerateHeaders.cmake 
 b/modules/ECMGenerateHeaders.cmake
 index e98a22e..38839f2 100644
 --- a/modules/ECMGenerateHeaders.cmake
 +++ b/modules/ECMGenerateHeaders.cmake
 @@ -50,7 +50,7 @@ function(ECM_GENERATE_HEADERS)
  endif()
  
  if(NOT EGH_OUTPUT_DIR)
 -set(EGH_OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR})
 +set(EGH_OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR}/local)
  endif()
  
  # Make sure EGH_RELATIVE is /-terminated when it's not empty
 
 Can you try it?

Ok, let's use Attica again as example as with the ECMGenerateHeaders.cmake 
change, the dependencies for KParts don't compile any more :)

So, I applied the CEM patch, then in Attica, I now have e.g. 
src/local/Attica/topic.h that contains: #include 
/tmp/kf5-attica-yJxM/src/topic.h

Installing that dir:

-install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/Attica DESTINATION 
${INCLUDE_INSTALL_DIR} COMPONENT Devel)
+install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/local/Attica DESTINATION 
${INCLUDE_INSTALL_DIR} COMPONENT Devel)

gives me the same brokenness?

How would the install rule look like for Attica?


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115541/#review49240
---


On Feb. 7, 2014, 7:37 p.m., Harald Fernengel wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115541/
 ---
 
 (Updated Feb. 7, 2014, 7:37 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: attica
 
 
 Description
 ---
 
 Case-insensitive filesystems don't like the Attica vs. attica pathes, when 
 installing, the headers would all be messed up. Instead, install everything 
 to include/KF5/Attica to be in line with the other frameworks.
 
 Note - this might not be the best solution, but we need one in order to 
 deploy on Mac OS X :)
 
 
 Diffs
 -
 
   src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d 
 
 Diff: https://git.reviewboard.kde.org/r/115541/diff/
 
 
 Testing
 ---
 
 Only on Mac OS X
 
 
 Thanks,
 
 Harald Fernengel
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115541: Build fix for Mac OS X

[Harald Fernengel]

 On Feb. 8, 2014, 10:07 a.m., David Faure wrote:
  Urgh, we were hoping this wouldn't be an issue.
  
  This commit would break #include attica/event.h, so it cannot go in.
  
  All namespaced frameworks do it this way already btw, see kparts for 
  instance:
  
  -- Up-to-date: 
  /d/kde/inst/kde_frameworks/include/KF5/KParts/KParts/ReadWritePart
  -- Up-to-date: 
  /d/kde/inst/kde_frameworks/include/KF5/KParts/kparts/readwritepart.h
  
  Since there is no filename clash, what is the issue if these end up in the 
  same folder on Mac OSX?

Here's the layout after make install on OS X:

include/KF5/KParts/textextension.h contains:

#include /tmp/kf5-kparts-ty2Y/src/textextension.h

^^^ this is broken, points to the temporary build dir...? What should this 
include?

Then, we have include/KF5/KParts/KParts/ which contains both lower case and 
upper case headers.

include/KF5/KParts/KParts/textextension.h is the actual header

include/KF5/KParts/KParts/TextExtension contains:

#include kparts/textextension.h


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115541/#review49240
---


On Feb. 7, 2014, 7:37 p.m., Harald Fernengel wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115541/
 ---
 
 (Updated Feb. 7, 2014, 7:37 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: attica
 
 
 Description
 ---
 
 Case-insensitive filesystems don't like the Attica vs. attica pathes, when 
 installing, the headers would all be messed up. Instead, install everything 
 to include/KF5/Attica to be in line with the other frameworks.
 
 Note - this might not be the best solution, but we need one in order to 
 deploy on Mac OS X :)
 
 
 Diffs
 -
 
   src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d 
 
 Diff: https://git.reviewboard.kde.org/r/115541/diff/
 
 
 Testing
 ---
 
 Only on Mac OS X
 
 
 Thanks,
 
 Harald Fernengel
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115541: Build fix for Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115541/
---

Review request for KDE Frameworks.


Repository: attica


Description
---

Case-insensitive filesystems don't like the Attica vs. attica pathes, when 
installing, the headers would all be messed up. Instead, install everything to 
include/KF5/Attica to be in line with the other frameworks.

Note - this might not be the best solution, but we need one in order to deploy 
on Mac OS X :)


Diffs
-

  src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d 

Diff: https://git.reviewboard.kde.org/r/115541/diff/


Testing
---

Only on Mac OS X


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115494: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/
---

Review request for KDE Frameworks.


Repository: kjs


Description
---

Build on Mac OS X

Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so 
manually cast to the required type.

Also, there seems to be some magic with __signbit, it seems to be detected but 
then compilation fails. Prefer the suggested ::signbit() instead if available.


Diffs
-

  src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
  src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
  src/kjs/interpreter.cpp e6996512fdeaf3b6973261ceb9a21e343d95e4c0 
  src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 

Diff: https://git.reviewboard.kde.org/r/115494/diff/


Testing
---

It compiles again on Mac OS X :)


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115494: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/
---

(Updated Feb. 5, 2014, 1:42 p.m.)


Review request for KDE Frameworks and Bernd Buschinski.


Repository: kjs


Description
---

Build on Mac OS X

Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so 
manually cast to the required type.

Also, there seems to be some magic with __signbit, it seems to be detected but 
then compilation fails. Prefer the suggested ::signbit() instead if available.


Diffs
-

  src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
  src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
  src/kjs/interpreter.cpp e6996512fdeaf3b6973261ceb9a21e343d95e4c0 
  src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 

Diff: https://git.reviewboard.kde.org/r/115494/diff/


Testing
---

It compiles again on Mac OS X :)


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115494: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/
---

(Updated Feb. 5, 2014, 4:06 p.m.)


Review request for KDE Frameworks and Bernd Buschinski.


Changes
---

updated the signbit call to not use ::signbit as it seems to be a macro on some 
systems


Repository: kjs


Description
---

Build on Mac OS X

Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so 
manually cast to the required type.

Also, there seems to be some magic with __signbit, it seems to be detected but 
then compilation fails. Prefer the suggested ::signbit() instead if available.


Diffs (updated)
-

  src/kjs/ConfigureChecks.cmake 473da1c 
  src/kjs/global.h.cmake d821a72 
  src/kjs/interpreter.cpp e699651 
  src/kjs/operations.h a54f366 

Diff: https://git.reviewboard.kde.org/r/115494/diff/


Testing
---

It compiles again on Mac OS X :)


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115502: Fix math function checks

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115502/#review49074
---

Ship it!


Fixes the signbit issue also on Mac OS X :)

- Harald Fernengel


On Feb. 5, 2014, 5:03 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115502/
 ---
 
 (Updated Feb. 5, 2014, 5:03 p.m.)
 
 
 Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.
 
 
 Repository: kjs
 
 
 Description
 ---
 
 Fix math function checks
 
 Between things being in the std:: namespace and math.h and cmath
 interfering with each other (at least for glibc), the configure checks
 for math functions do not actually perform the checks they claim to.
 
 This tests that the functions (in whatever form) can reasonably be
 called from C++ code that includes both math.h and cmath.
 
 
 Diffs
 -
 
   src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
   src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
   src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 
 
 Diff: https://git.reviewboard.kde.org/r/115502/diff/
 
 
 Testing
 ---
 
 Configures, builds and installs with gcc 4.8.2 and glibc 2.18 (Archlinux).  
 The configure checks report the results you would expect (providing you are 
 aware that cmath undefs signbit).
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115494: Build on Mac OS X

[Harald Fernengel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/
---

(Updated Feb. 5, 2014, 8:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Bernd Buschinski.


Repository: kjs


Description
---

Build on Mac OS X

Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so 
manually cast to the required type.

Also, there seems to be some magic with __signbit, it seems to be detected but 
then compilation fails. Prefer the suggested ::signbit() instead if available.


Diffs
-

  src/kjs/ConfigureChecks.cmake 473da1c 
  src/kjs/global.h.cmake d821a72 
  src/kjs/interpreter.cpp e699651 
  src/kjs/operations.h a54f366 

Diff: https://git.reviewboard.kde.org/r/115494/diff/


Testing
---

It compiles again on Mac OS X :)


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel