D11880: Add firewall-config and firewall-applet icons

[Wolfgang Bauer]

wbauer added a comment.


  In D11880#331450 , @ngraham wrote:
  
  > However, there seems to be a problem for the breeze dark versions:
  >  F6283726: Screenshot_20180924_215524.png 

  >
  > Shouldn't the wall be light-colored? Does it work for you when actually 
deployed and in use with breeze dark?
  
  
  
  
  In D11880#331724 , @ngraham wrote:
  
  > Never mind, it's a Cuttlefish issue. Everything looks good to me.
  
  
  Actually it's not. We got a bug report about exactly that in openSUSE:
  https://bugzilla.opensuse.org/show_bug.cgi?id=1157921
  
  Creating the symlink firewall-applet-shields_up -> firewall-applet fixes it, 
so it's probably a bug in the icon loader when doing the fallback...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: wbauer, dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, 
ngraham, LeGast00n, cblack, GB_2, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#338464 , @dfaure wrote:
  
  > I don't really know, but see https://phabricator.kde.org/D4254 for the full 
reasoning of the unittest.
  
  
  As far as I understand it, the themes are marked as scalable with a directory 
scope (icon theme spec 
),
 but there is no guarantee a theme is "complete".
  
  AFAICS, it is sufficient to link the 48px config icon and the other 22px 
icons into the "scalable" directory.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh

D11880: Add firewall-config and firewall-applet icons

[David Faure]

dfaure added a comment.


  I don't really know, but see https://phabricator.kde.org/D4254 for the full 
reasoning of the unittest.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#337514 , @dfaure wrote:
  
  > This commit breaks the unittest "scalabletest" :
  >
  > FAIL!  : ScalableTest::test_scalable(icons:Applications) The following 
icons are not available in a scalable directory:
  >
  >   firewall-applet-panic
  >   firewall-applet
  >   firewall-applet-error
  >   firewall-applet-shields_up
  >Loc: 
[/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  >
  > FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following 
icons are not available in a scalable directory:
  >
  >   firewall-applet-panic
  >   firewall-applet
  >   firewall-applet-error
  >   firewall-applet-shields_up
  >Loc: 
[/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  >   
  >
  > Please fix ;)
  
  
  I'm afraid I don't understand the error or what to do about it. Aren't SVGs 
naturally scalable? Isn't the scalable directory unused in the Breeze icon 
theme because every icon is scalable?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh

D11880: Add firewall-config and firewall-applet icons

[David Faure]

dfaure added a comment.


  This commit breaks the unittest "scalabletest" :
  
  FAIL!  : ScalableTest::test_scalable(icons:Applications) The following icons 
are not available in a scalable directory:
  
firewall-applet-panic
firewall-applet
firewall-applet-error
firewall-applet-shields_up
 Loc: [/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  
  FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following 
icons are not available in a scalable directory:
  
firewall-applet-panic
firewall-applet
firewall-applet-error
firewall-applet-shields_up
 Loc: [/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  
  Please fix ;)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:61ac11747089: Add firewall-config and firewall-applet 
icons (authored by ndavis, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=42390=42396

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet-shields_up.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet-shields_up.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet-shields_up.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet-shields_up.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  Shipping it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  Love it! Ship it! +100

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  +1 ship it!
  
  Final #VDG  review?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis updated this revision to Diff 42390.
ndavis added a comment.


  Add firewall-applet-shields_up icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=42257=42390

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet-shields_up.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet-shields_up.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet-shields_up.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet-shields_up.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#332426 , @ndavis wrote:
  
  > In D11880#332406 , @bruns wrote:
  >
  > > Looks good - can you provide an overview png of the complete 
firewall-applet icon set? I.e. the (now four) status icons  and the config icon?
  >
  >
  > F6286904: firewall_icons.png 
  
  
  Great, thanks!
  +1!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#332406 , @bruns wrote:
  
  > Looks good - can you provide an overview png of the complete 
firewall-applet icon set? I.e. the (now four) status icons  and the config icon?
  
  
  F6286904: firewall_icons.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#332364 , @ndavis wrote:
  
  > How about this? F6286776: firewall-applet-shields_up.png 

  
  
  Looks good - can you provide an overview png of the complete firewall-applet 
icon set? I.e. the (now four) status icons  and the config icon?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#332347 , @ndavis wrote:
  
  > I'm down to add a shields-up state icon. shields-down can just be the 
normal icon.
  
  
  Thats completely fine IMHO, we just need two different icons for shields up 
and down.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  How about this? F6286776: firewall-applet-shields_up.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  I'm down to add a shields-up state icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#332193 , @ngraham wrote:
  
  > So we need more icons, then?
  
  
  Preferably yes, but both would fall back to `firewall-applet` otherwise.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  So we need more icons, then?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#331724 , @ngraham wrote:
  
  > Never mind, it's a Cuttlefish issue. Everything looks good to me.
  >
  > Do we have final sign-off by other #VDG 
 folks?
  
  
  Sorry to add some last minute disturbance, but is seems firewall-applet will 
get distinct `firewall-applet-normal-shields_up` and 
`firewall-applet-normal-shields_down` icons in the next version:
  https://github.com/firewalld/firewalld/pull/394

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Never mind, it's a Cuttlefish issue. Everything looks good to me.
  
  Do we have final sign-off by other #VDG 
 folks?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I still get the issue in Cuttlefish after clearing the cache.
  
  Is anyone else able to reproduce this issue with viewing the icons in 
Cuttlefish and turning on "Inverted"?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#331450 , @ngraham wrote:
  
  > FWIW, I'm okay with the existing `firewall-applet`. So here's what we've 
got now, as viewed with `cuttlefish`:
  >  F6283724: Screenshot_20180924_215450.png 

  >
  > I say +1!
  >
  > However, there seems to be a problem for the breeze dark versions:
  >  F6283726: Screenshot_20180924_215524.png 

  >
  > Shouldn't the wall be light-colored? Does it work for you when actually 
deployed and in use with breeze dark?
  
  
  Yes, it should be #f2f2f2 and it is on my end. I have the correct color on my 
own copy and when I download the raw files from Phabricator. Are you sure you 
aren't experiencing some kind of bug or maybe your cache is old?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  FWIW, I'm okay with the existing `firewall-applet`. So here's what we've got 
now, as viewed with `cuttlefish`:
  F6283724: Screenshot_20180924_215450.png 

  
  I say +1!
  
  However, there seems to be a problem for the breeze dark versions:
  F6283726: Screenshot_20180924_215524.png 

  
  Shouldn't the wall be light-colored? Does it work for you when actually 
deployed and in use with breeze dark?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  In D11880#330865 , @ndavis wrote:
  
  > In D11880#330861 , @ngraham 
wrote:
  >
  > > For the panic mode icon, how about leaving the wall itself black, and 
only the lock is orange?
  >
  >
  > Like this? This is #4d4d4d (icon grey), the standard color for small breeze 
icons, not black.
  >  F6281673: Screenshot_20180924_000854.png 
F6281669: Screenshot_20180924_000627.png 

  
  
  Perfect, I love it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis updated this revision to Diff 42257.
ndavis added a comment.


  Remove 48px firewall-applet icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=42212=42257

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#330909 , @svenmauch 
wrote:
  
  > In D11880#330788 , @ngraham 
wrote:
  >
  > > I think that `firewall-applet` looks maybe a bit too plain at its 22px 
size. The wall seems to need something.
  >
  >
  > I think the 22px firewall-applet looks really good and would fit perfectly 
with the notifications popup and task icons. I'm not sure why the 48px version 
is colored though?
  
  
  It's just a symlink to the firewall-config icon. When I started this diff, 
firewall-applet showed up in searches for "firewall" in the application menus. 
That appears not to be the case anymore, so I will remove the 48px 
firewall-applet icon.
  
  > Thank you for the superb work @ndavis & @bruns!
  
  Thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Sven Mauch]

svenmauch added a comment.


  In D11880#330810 , @ndavis wrote:
  
  > While orange may mean "warning", it could mean any kind of warning. In this 
case, it's a warning that an extreme setting is being used, but there is a lock 
in the corner to show that it is at least safe.
  
  
  Exactly what I thought!
  
  In D11880#330865 , @ndavis wrote:
  
  > Like this? This is #4d4d4d (icon grey), the standard color for small breeze 
icons, not black.
  >  F6281673: Screenshot_20180924_000854.png 
F6281669: Screenshot_20180924_000627.png 

  
  
  Looks great! +1
  
  In D11880#330788 , @ngraham wrote:
  
  > I think that `firewall-applet` looks maybe a bit too plain at its 22px 
size. The wall seems to need something.
  
  
  I think the 22px firewall-applet looks really good and would fit perfectly 
with the notifications popup and task icons. I'm not sure why the 48px version 
is colored though?
  
  Thank you for the superb work @ndavis & @bruns!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis updated this revision to Diff 42212.
ndavis added a comment.


  Change wall color of firewall-applet-panic to \#4d4d4d (breeze) and \#f2f2f2 
(breeze-dark)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=42119=42212

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#330861 , @ngraham wrote:
  
  > For the panic mode icon, how about leaving the wall itself black, and only 
the lock is orange?
  
  
  Like this? This is #4d4d4d (icon grey), the standard color for small breeze 
icons, not black.
  F6281673: Screenshot_20180924_000854.png 
F6281669: Screenshot_20180924_000627.png 

  
  > I don't want to totally dominate the conversation here, so I'll step aside 
for a bit and let others have their say. But I want to let you know that I 
really appreciate your patience here, @ndavis. I'm sorry this there's been so 
much back-and-forth and that the patch sat ignored for so long. We'll do better 
for your next one!
  
  Thank you! It's been great to see how other people come up with designs here.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  For the panic mode icon, how about leaving the wall itself black, and only 
the lock is orange?
  
  I don't want to totally dominate the conversation here, so I'll step aside 
for a bit and let others have their say. But I want to let you know that I 
really appreciate your patience here, @ndavis. I'm sorry this there's been so 
much back-and-forth and that the patch sat ignored for so long. We'll do better 
for your next one!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  Here's how the checkmark idea looks. I prefer the plain wall since it fits in 
with the other icons better.
  
  16px
  F6281345: firewall-applet(check)16.svg 
  
  22px
  F6281342: firewall-applet(check)22.svg 
  
  Here's another idea with a shield in the middle, similar to the 48px icon. I 
still prefer the plain wall.
  
  16px
  F6281346: firewall-applet(shield)16.svg 
  
  22px
  F6281347: firewall-applet(shield)22.svg 

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#330788 , @ngraham wrote:
  
  > I like `firewall-config` and `firewall-applet-error` as they are.
  >
  > I think that `firewall-applet` looks maybe a bit too plain at its 22px 
size. The wall seems to need something.
  
  
  Maybe the emblem-checked icon should go in the lower right corner to match 
the style of the other two firewall-applet icons? I choose to make it fairly 
simple so that it would normally fit in with other icons in the system tray 
except for when there is an error or Panic Mode is enabled.
  
  > I like the lock on `firewall-applet-panic`. I'm not sure about the orange 
color though. Orange means "warning". If I'm understanding you correctly, 
`firewall-applet-panic` should evoke feelings of maximum safety.
  
  Yes, but I also agree with @svenmauch about the previous version being too 
positive. If a user enables panic mode by accident, how will they know 
something might be wrong with their settings? As it is, firewall-applet-panic 
is the firewall-applet icon with the emblem-locked icon in the corner and I've 
applied the color of emblem-locked to the wall. While orange may mean 
"warning", it could mean any kind of warning. In this case, it's a warning that 
an extreme setting is being used, but there is a lock in the corner to show 
that it is at least safe.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  For the benefit of others, here's what they look like now:
  
  22px:
  F6281196: 22px.png 
  
  48px:
  F6281197: 48px.png 
  
  I like `firewall-config` and `firewall-applet-error` as they are.
  
  I think that `firewall-applet` looks maybe a bit too plain at its 22px size. 
The wall seems to need something.
  
  I like the lock on `firewall-applet-panic`. I'm not sure about the orange 
color though. Orange means "warning". If I'm understanding you correctly, 
`firewall-applet-panic` should evoke feelings of maximum safety.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis updated this revision to Diff 42119.
ndavis added a comment.


  Change to bruns/state-* hybrid style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=41973=42119

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  In D11880#329995 , @bruns wrote:
  
  > If you use "{xxx, size=full}", you can avoid the scaling (preferable for 
small inline images).
  
  
  Fixed. Thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  In D11880#329994 , @ndavis wrote:
  
  > 16px
  >  F6278474: Screenshot_20180921_230725.png 

  >
  > 22px
  >  F6278475: Screenshot_20180921_230711.png 

  
  
  If you use "{xxx, size=full}", you can avoid the scaling (preferable for 
small inline images).

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  Here are some new styles based on suggestions and @bruns's ideas. I've also 
tried to make one of the new styles looks similar to the status/*/state-* icons.
  
  16px
  F6278474: Screenshot_20180921_230725.png 

  
  22px
  F6278475: Screenshot_20180921_230711.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  I think I'm confused about the process here. Are we using @bruns's icons now?
  
  In D11880#329896 , @bruns wrote:
  
  > F6277682: out.png 
  >
  > How about these - error, "trusted zone", panic, "public/untrusted"
  
  
  Firewall-applet does not use trusted and untrusted icons. There is just 
normal, panic and error.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Sven Mauch]

svenmauch added a comment.


  Yup! +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  I solemnly approve! +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  Now that's what I'm talkin' about. Those are awesome in my book. Other #VDG 
 folks, thoughts?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  Alternate error version:
  F6277862: out.png 
  
  F6277861: icons_apps_22_firewall-applet-error.svg 


REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  F6277841: out.png 
  
  F6277844: icons_apps_22_firewall-applet-open.svg 

  
  F6277843: icons_apps_22_firewall-applet.svg 

  
  F6277842: icons_apps_22_firewall-applet-error.svg 

  
  F6277840: icons_apps_22_firewall-applet-panic.svg 


REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham added a comment.


  I like your depiction of the logical consequences of the firewall being 
depicted as a wall, @bruns. That seems great. I think a further exploration is 
warranted:
  
  `Error:` wall is damaged or compromised; maybe holes in it or a pile of brick 
rubble! Red color is appropriate here
  
  `Trusted zone:` doorway or open door in wall - yours seems perfect.
  
  `Panic:` extra security: could use iconography of bars, swords, shields, 
locks, etc. Anything to connote "nobody'e getting through here!" Not sure red 
is the right color here.
  
  `Public/untrusted:` only some entry allowed; closed door would work. Yours 
seems a bit too unfriendly with those vertical bars maybe.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  Seems good to me. Guys?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Stefan Brüns]

bruns added a comment.


  F6277682: out.png 
  
  How about these - error, "trusted zone", panic, "public/untrusted"
  
  F6277688: icons_apps_22_firewall-applet.svg 

  
  F6277687: icons_apps_22_firewall-applet-open.svg 

  
  F6277686: icons_apps_22_firewall-applet-panic.svg 

  
  F6277685: icons_apps_22_firewall-applet-error.svg 


REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  If I understand right, there are three states of firewall security that you 
can be in. Maybe we could use the traffic lights metaphor and have green for 
low, yellow for medium and red for high?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Alessandro Longo]

alex-l added a comment.


  Very cool icons! But in the panic one the padlock is too small :-/ what a 
about a checkmark (✅) on the wall instead?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Sven Mauch]

svenmauch added a comment.


  I like the regular icon, looks great!
  
  Though I'm unsure about the panic icon. It communicates "all is well" to me 
instead of "all network traffic blocked". Maybe there is a better way to 
achieve this. An orange icon with a spread out hand in front of it? Just an 
idea.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: svenmauch, kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I like the brick wall metaphor, which does a good job of communicating the 
point, while being visually distinct from the shield.
  
  Looks great to me! Let's see if any other VDG folks have opinions in the next 
day or two, and if not, I'll ship it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  Regular
  F6275107: Screenshot_20180920_052849.png 

  Panic
  F6275109: Screenshot_20180920_053034.png 

  Not sure if I want to try to cause an error on my own system just to show how 
the error icon looks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis updated this revision to Diff 41973.
ndavis added a comment.


  Fix mixed up firewall-applet and firewall-applet-panic (22px)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=41972=41973

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis added a comment.


  Hmm. Something is preventing me from changing the name of firewall-applet to 
firewall-applet-panic (apps/22) and vice versa. I own all of the files in that 
directory (noah:users), but the file names keep being reset to their current 
state.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis updated this revision to Diff 41972.
ndavis added a comment.


  
  
  1. Updating D11880 <https://phabricator.kde.org/D11880>: Add firewall-config 
and firewall-applet icons #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Fix mixed up firewall-applet and firewall-applet-panic (22px)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=41971=41972

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Noah Davis]

ndavis retitled this revision from "Add firewalld icons" to "Add 
firewall-config and firewall-applet icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns