D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  We still haven't figured out where to put all of the `yast-*` icons. Most of 
them are now symlinks to preferences icons, but that doesn't fix the fact that 
this patch can't pass the scalable test. This is because `apps/32` is a fixed 
size directory. I don't think `preferences/` should be used for the YaST icons 
because `preferences/` is meant to be used for our settings category icons and 
YaST is 3rd party. Would it be acceptable to change `apps/32` to the following?
  
[apps/32]
Size=32
Context=Applications
Type=Scalable
MinSize=16
MaxSize=32
  
  This way the icons can be used in YaST and Plasma won't try to use a 32px 
icon when a 48 px icon should be used.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#380743 , @fvogt wrote:
  
  > Turns out it's a trivial issue: breeze's index.theme doesn't contain the 
parameters for `apps/64` so it's like that directory doesn't even exist.
  >
  > I don't know how to fix it though - apps/48 is already configured to also 
contain 64px images so maybe apps/64 should just get moved into /48?
  
  
  They could both be scalable directories. 48px will just end up being the 
default size and 64px will only be used when there isn't a 48px icon. Maybe 
that's not ideal because that means 64px will never be used in the application 
dashboard for most apps, but we generally only make 48px versions of app icons 
anyway.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Fabian Vogt]

fvogt added a comment.


  In D17623#380551 , @ndavis wrote:
  
  > In D17623#380549 , @fvogt wrote:
  >
  > > In D17623#380511 , @ndavis 
wrote:
  > >
  > > > @fvogt @hellcp For some reason YaST Control Center only works with 32px 
icons from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.
  > >
  > >
  > > AFAICT YaST just uses `QIcon::fromTheme("foo").pixmap(32, 32)` which 
should work just fine. Did you refresh the icon cache? What's the issue 
exactly? Do you see the wrong icon, wrong size or no icon at all?
  >
  >
  > Actually, it works with 32px and 48px Breeze icons, but not 64px. If the 
Breeze icon is 64px, yast-c-c shows the hicolor icon. If there is no hicolor 
icon for a module (i.e., I delete all `yast-printer` icons from hicolor), 
yast-c-c shows the `yast` icon, even if there is a Breeze icon at 64px. I'm 
pretty sure it's not an icon cache issue because there are no issues with 
changing icons to 48px versions, only 64px has issues.
  
  
  Turns out it's a trivial issue: breeze's index.theme doesn't contain the 
parameters for `apps/64` so it's like that directory doesn't even exist.
  
  I don't know how to fix it though - apps/48 is already configured to also 
contain 64px images so maybe apps/64 should just get moved into /48?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#380549 , @fvogt wrote:
  
  > In D17623#380511 , @ndavis wrote:
  >
  > > @fvogt @hellcp For some reason YaST Control Center only works with 32px 
icons from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.
  >
  >
  > AFAICT YaST just uses `QIcon::fromTheme("foo").pixmap(32, 32)` which should 
work just fine. Did you refresh the icon cache? What's the issue exactly? Do 
you see the wrong icon, wrong size or no icon at all?
  
  
  Actually, it works with 32px and 48px Breeze icons, but not 64px. If the 
Breeze icon is 64px, yast-c-c shows the hicolor icon. If there is no hicolor 
icon for a module (i.e., I delete all `yast-printer` icons from hicolor), 
yast-c-c shows the `yast` icon, even if there is a Breeze icon at 64px. I'm 
pretty sure it's not an icon cache issue because there are no issues with 
changing icons to 48px versions, only 64px has issues.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Fabian Vogt]

fvogt added a comment.


  In D17623#380511 , @ndavis wrote:
  
  > @fvogt @hellcp For some reason YaST Control Center only works with 32px 
icons from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.
  
  
  AFAICT YaST just uses `QIcon::fromTheme("foo").pixmap(32, 32)` which should 
work just fine. Did you refresh the icon cache? What's the issue exactly? Do 
you see the wrong icon, wrong size or no icon at all?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  @fvogt @hellcp For some reason YaST Control Center only works with 32px icons 
from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added a comment.


  In D17623#380204 , @ndavis wrote:
  
  > In D17623#378670 , @ngraham 
wrote:
  >
  > >   apps/32/yast-checkmedia.svg   
preferences/32/preferences-devices-drive-optical-ok.svg
  >
  >
  > Why `ok`? This is a preferences icon, so it doesn't make sense for there to 
be preferences about `ok`, which usually represents a state.
  
  
  My intention was to have the last word reflect the checkmark (presumably a 
version with an X  could be made). Another word could work too.
  
  >>   apps/32/yast-create-new-vm.svgpreferences/32/preferences-vm-add.svg
  >>   apps/32/yast-vm-install.svg   
preferences/32/preferences-vm-install.svg
  >>   apps/32/yast-vm-migrate.svg   
preferences/32/preferences-vm-migrate.svg
  >>   apps/32/yast-vm.svg   preferences/32/preferences-vm.svg
  > 
  > Is `vm` too short? Could `virtualization` be better? `preferences-vm-add` 
seems awfully similar to an action icon for a preferences icon, but that's 
because of how the icon is used in the first place.
  
  `virtualization` seems fine, yeah.
  
  >>   apps/32/yast-device-tree.svg  preferences/32/preferences-devices.svg
  > 
  > This icon represents a tree of devices in a graph of the system's drive 
partitions. I'm not sure if it's good as an icon for just any `devices`.
  
  `preferences-devices-tree.svg` then?
  
  >>   apps/32/yast-disk.svg 
preferences/32/preferences-devices-drive-harddisk-partitions.svg
  > 
  > This icon currently uses openSUSE colors to represent the YaST Partitioner. 
I might have to change the colors to make it a KDE partition preferences icon.
  
  Ok.
  
  >>   apps/32/yast-docker.svg   
preferences/32/preferences-system-docker.svg
  > 
  > Should this be `preferences-virtualization-docker`?
  
  +1
  
  >>   apps/32/yast-dsl.svg  
preferences/32/preferences-system-network-modem.svg
  > 
  > I was planning on turning this into a 64px device icon 
(`network-rj11-female`). If I were to do an actual modem icon, I would pick 
something that looks more like a modem. Lots of modems don't have RJ11 
(DSL/Telephone wire) ports and lots of devices that have RJ11 ports are not 
modems. I've had some issues with getting 64px icons to work though. They 
should work and I see no reason for them not to since I've seen them work, but 
whenever I try, the icons fallback to hicolor. I'll have to talk to LCP or YaST 
devs about that.
  
  So `preferences-system-network-rj11-female.svg` then?
  
  >>   apps/32/yast-lan.svg  
preferences/32/preferences-system-network-ethernet.svg
  > 
  > Same deal as the RJ11 icon, except it's RJ45. However, the name makes sense 
for a preferences icon specifically for ethernet, whatever that would be used 
for.
  
  Perhaps it could be `preferences-system-network-rj45-female.svg`, and create 
a symlink to it called `preferences-system-network-ethernet.svg`?
  
  >>   apps/32/yast-hwinfo.svg   
preferences/32/preferences-system-hwinfo.svg
  > 
  > This is a 32px version of the existing `hwinfo` icon since it looks blurry 
as hell when scaled down to 32px.
  
  Right.
  
  >>   apps/32/yast-instserver.svg   
preferences/32/preferences-system-network-server-install.svg
  > 
  > `instserver` is for providing installation repos, not specifically for 
installing a server. Is `install` good enough?
  
  Maybe `preferences-system-network-server-installation` then? Install servers 
aren't uncommon.
  
  >>   apps/32/yast-journal.svg  preferences/32/preferences-book.svg
  > 
  > This is an icon for the systemd journal. It could probably be replaced with 
a 32px version of the KSystemLog icon or something similar.
  
  Sounds good to me.
  
  >>   apps/32/yast-nis.svg  
preferences/32/preferences-desktop-user-nis.svg
  > 
  > Why is this `preferences-desktop-user-nis` and LDAP 
`preferences-system-network-ldap`? They both have similar functions, except 
LDAP is a more secure replacement for NIS.
  
  We could do `preferences-system-network-nis`.
  
  >>   apps/32/yast-snapper.svg  
preferences/32/preferences-devices-drive-harddisk-snapper.svg
  > 
  > Snapper is a system snapshotting program, not a type of device.
  
  I was just re-using the naming style of the other icons that have a hard disk 
with an icon in it. Ideas?
  
  > 
  > 
  >>   apps/32/yast-sudo.svg 
preferences/32/preferences-desktop-user-sudo.svg
  > 
  > This is for configuring `sudo`. It doesn't have anything to do with a 
specific user or the desktop.
  
  `preferences-system-user-sudo`?
  
  >>   apps/32/yast-vpn.svg  
preferences/32/preferences-web-browser-vpn.svg
  > 
  > Generally, VPNs are handled by `plasma-nm`, not anything to do with web 
browsers specifically. Perhaps I could have picked an icon that isn't 
consistent with the `preferences-web-browser-*` icons.
  
  Yeah, I 

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378670 , @ngraham wrote:
  
  >   apps/32/yast-checkmedia.svg   
preferences/32/preferences-devices-drive-optical-ok.svg
  
  
  Why `ok`? This is a preferences icon, so it doesn't make sense for there to 
be preferences about `ok`, which usually represents a state.
  
  >   apps/32/yast-create-new-vm.svgpreferences/32/preferences-vm-add.svg
  >   apps/32/yast-vm-install.svg   
preferences/32/preferences-vm-install.svg
  >   apps/32/yast-vm-migrate.svg   
preferences/32/preferences-vm-migrate.svg
  >   apps/32/yast-vm.svg   preferences/32/preferences-vm.svg
  
  Is `vm` too short? Could `virtualization` be better? BTW, the way this icon 
is used is similar to an action ico
  
  >   apps/32/yast-device-tree.svg  preferences/32/preferences-devices.svg
  
  This icon represents a tree of devices in a graph of the system's drive 
partitions. I'm not sure if it's good as an icon for just any `devices`.
  
  >   apps/32/yast-disk.svg 
preferences/32/preferences-devices-drive-harddisk-partitions.svg
  
  This icon currently uses openSUSE colors to represent the YaST Partitioner. I 
might have to change the colors to make it a KDE partition preferences icon.
  
  >   apps/32/yast-docker.svg   
preferences/32/preferences-system-docker.svg
  
  Should this be `preferences-virtualization-docker`?
  
  >   apps/32/yast-dsl.svg  
preferences/32/preferences-system-network-modem.svg
  
  I was planning on turning this into a 64px device icon 
(`network-rj11-female`). If I were to do an actual modem icon, I would pick 
something that looks more like a modem. Lots of modems don't have RJ11 
(DSL/Telephone wire) ports and lots of devices that have RJ11 ports are not 
modems. I've had some issues with getting 64px icons to work though. They 
should work and I see no reason for them not to since I've seen them work, but 
whenever I try, the icons fallback to hicolor. I'll have to talk to LCP or YaST 
devs about that.
  
  >   apps/32/yast-lan.svg  
preferences/32/preferences-system-network-ethernet.svg
  
  Same deal as the RJ11 icon, except it's RJ45. However, the name makes sense 
for a preferences icon specifically for ethernet, whatever that would be used 
for.
  
  >   apps/32/yast-hwinfo.svg   
preferences/32/preferences-system-hwinfo.svg
  
  This is a 32px version of the existing `hwinfo` icon since it looks blurry as 
hell when scaled down to 32px.
  
  >   apps/32/yast-instserver.svg   
preferences/32/preferences-system-network-server-install.svg
  
  `instserver` is for providing installation repos, not specifically for 
installing a server. Is `install` good enough?
  
  >   apps/32/yast-journal.svg  preferences/32/preferences-book.svg
  
  This is an icon for the systemd journal. It could probably be replaced with a 
32px version of the KSystemLog icon or something similar.
  
  >   apps/32/yast-nis.svg  
preferences/32/preferences-desktop-user-nis.svg
  
  Why is this `preferences-desktop-user-nis` and LDAP 
`preferences-system-network-ldap`? They both have similar functions, except 
LDAP is a more secure replacement for NIS.
  
  >   apps/32/yast-snapper.svg  
preferences/32/preferences-devices-drive-harddisk-snapper.svg
  
  Snapper is a system snapshotting program, not a type of device.
  
  >   apps/32/yast-sudo.svg 
preferences/32/preferences-desktop-user-sudo.svg
  
  This is for configuring `sudo`. It doesn't have anything to do with a 
specific user or the desktop.
  
  >   apps/32/yast-vpn.svg  
preferences/32/preferences-web-browser-vpn.svg
  
  Generally, VPNs are handled by `plasma-nm`, not anything to do with web 
browsers specifically. Perhaps I could have picked an icon that isn't 
consistent with the `preferences-web-browser-*` icons.
  
  >   apps/32/yast-wol.svg  
preferences/32/preferences-web-browser-power.svg
  
  This is Wake-on-Lan . It 
doesn'thave anything to do with web browsers. Perhaps I could have picked an 
icon that isn't consistent with the `preferences-web-browser-*` icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378989 , @ngraham wrote:
  
  > In D17623#378783 , @ndavis wrote:
  >
  > > 2. It's supposed to be a newspaper. I tried to make it look similar to 
`message-news`: F6486579: Screenshot_20181218_073508.png 

  > >   - An alternative newspaper style might be something similar to 
`news-subscribe`: F6486581: Screenshot_20181218_073629.png 

  >
  >
  > Yeah, that might be better. `message-news` itself doesn't really look that 
much like a newspaper lol! Something more like this might be clearer, for both 
icons: https://www.flaticon.com/free-icon/text-lines_254005
  
  
  I'm not sure about the isometric-ish look. It just doesn't feel like it fits 
in with the other Breeze icons. How is this? F6495264: 
Screenshot_20181220_175818.png F6495266: 
Screenshot_20181220_180001.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added a comment.


  In D17623#378783 , @ndavis wrote:
  
  > 2. It's supposed to be a newspaper. I tried to make it look similar to 
`message-news`: F6486579: Screenshot_20181218_073508.png 

  >   - An alternative newspaper style might be something similar to 
`news-subscribe`: F6486581: Screenshot_20181218_073629.png 

  
  
  Yeah, that might be better. `message-news` itself doesn't really look that 
much like a newspaper lol! Something more like this might be clearer, for both 
icons: https://www.flaticon.com/free-icon/text-lines_254005
  
  > 3. Here's how that looks: F6486584: Screenshot_20181218_073915.png 
F6486586: Screenshot_20181218_074012.png 

  
  That looks better to my eyes! Very nice icon. I think that will look 
fantastic in Dolphin's Settings window for the Services tab as part of the 
"colorize all the icons" initiative (T10165 
).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378670 , @ngraham wrote:
  
  > Also, here are my only aesthetic suggestions:
  >
  > - Messages icon:  how about making this look more like the 
utilities-log-viewer icon? Maybe a 32px version of that?
  > - Release notes icon: I'm not sure this icon really works. I can't tell 
what it is. A fax machine?
  > - Services icon: I don't think the top of the bell should cast a shadow 
here; in general the shadow only seems to overlap the icon itself, not the 
background. When it does that here, it looks kind of weird.
  
  
  
  
  1. Good point, although the actual message viewer doesn't look a lot like 
KSystemLog: F6486567: Screenshot_20181218_072948.png 

- the journal module is just a module for showing the systemd journal, so 
it looks more like KSystemLog: F6486575: Screenshot_20181218_073228.png 

  2. It's supposed to be a newspaper. I tried to make it look similar to 
`message-news`: F6486579: Screenshot_20181218_073508.png 

- An alternative newspaper style might be something similar to 
`news-subscribe`: F6486581: Screenshot_20181218_073629.png 

  3. Here's how that looks: F6486584: Screenshot_20181218_073915.png 
F6486586: Screenshot_20181218_074012.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Here's a preliminary suggestion:
  
Current icon  What it should be a symlink to

apps/32/yast-apparmor.svg 
preferences/32/preferences-security-apparmor.svg
apps/32/yast-auth-client.svg  
preferences/32/preferences-security-kerberos.svg
apps/32/yast-autoyast.svg 
apps/32/yast-bootloader.svg   
preferences/32/preferences-system-startup.svg
apps/32/yast-checkmedia.svg   
preferences/32/preferences-devices-drive-optical-ok.svg
apps/32/yast-create-new-vm.svgpreferences/32/preferences-vm-add.svg
apps/32/yast-device-tree.svg  preferences/32/preferences-devices.svg
apps/32/yast-dhcp-server.svg  
preferences/32/preferences-system-network-server-dhcp.svg
apps/32/yast-disk.svg 
preferences/32/preferences-devices-drive-harddisk-partitions.svg
apps/32/yast-dns-server.svg   
preferences/32/preferences-system-network-server-dns.svg
apps/32/yast-docker.svg   
preferences/32/preferences-system-docker.svg
apps/32/yast-dsl.svg  
preferences/32/preferences-system-network-modem.svg
apps/32/yast-firewall.svg 
preferences/32/preferences-security-firewall.svg
apps/32/yast-ftp-server.svg   
preferences/32/preferences-system-network-server-ftp.svg
apps/32/yast-hardware.svg preferences/32/preferences-system-cpu.svg
apps/32/yast-host.svg 
preferences/32/preferences-system-network-server.svg
apps/32/yast-http-server.svg  
preferences/32/preferences-system-network-server-http.svg
apps/32/yast-hwinfo.svg   
preferences/32/preferences-system-hwinfo.svg
apps/32/yast-instserver.svg   
preferences/32/preferences-system-network-server-install.svg
apps/32/yast-iscsi-client.svg 
preferences/32/preferences-devices-drive-harddisk-iscsi.svg
apps/32/yast-iscsi-server.svg 
preferences/32/preferences-system-network-server-iscsi.svg
apps/32/yast-journal.svg  preferences/32/preferences-book.svg
apps/32/yast-kerberos-server.svg  
preferences/32/preferences-system-network-server-security.svg
apps/32/yast-kernel.svg   
preferences/32/preferences-system-linux.svg
apps/32/yast-lan.svg  
preferences/32/preferences-system-network-ethernet.svg
apps/32/yast-ldap-server.svg  
preferences/32/preferences-system-network-server-ldap.svg
apps/32/yast-ldap.svg 
preferences/32/preferences-system-network-ldap.svg
apps/32/yast-mail.svg 
preferences/32/preferences-system-network-server-mail.svg
apps/32/yast-messages.svg preferences/32/preferences-system-log.svg
apps/32/yast-nfs-server.svg   
preferences/32/preferences-system-network-server-nfs.svg
apps/32/yast-nis-server.svg   
preferences/32/preferences-system-network-server-nis.svg
apps/32/yast-nis.svg  
preferences/32/preferences-desktop-user-nis.svg
apps/32/yast-ntp-client.svg   
preferences/32/preferences-system-network-ntp.svg
apps/32/yast-printer.svg  
preferences/32/preferences-devices-printer.svg
apps/32/yast-proxy.svg
preferences/32/preferences-system-network-proxy.svg
apps/32/yast-release-notes.svg
preferences/32/preferences-releasenotes.svg
apps/32/yast-remote.svg   
preferences/32/preferences-system-network-remote.svg
apps/32/yast-samba-client.svg 
preferences/32/preferences-system-network-samba.svg
apps/32/yast-samba-server.svg 
preferences/32/preferences-system-network-server-samba.svg
apps/32/yast-scanner.svg  
preferences/32/preferences-devices-scanner.svg
apps/32/yast-security.svg preferences/32/preferences-security.svg
apps/32/yast-services-manager.svg preferences/32/preferences-services.svg
apps/32/yast-slp-server.svg   
preferences/32/preferences-system-network-server-slp.svg
apps/32/yast-snapper.svg  
preferences/32/preferences-devices-drive-harddisk-snapper.svg
apps/32/yast-software.svg 
apps/32/yast-sudo.svg 
preferences/32/preferences-desktop-user-sudo.svg
apps/32/yast-support.svg  preferences/32/preferences-system-help.svg
apps/32/yast-sw_single.svg
apps/32/yast-sw_source.svg
apps/32/yast-sysconfig.svgpreferences/32/preferences.svg
apps/32/yast-system.svg   maybe replace 
preferences/32/preferences-desktop.svg with this and make the icon a symlink to 
it
apps/32/yast-tftp-server.svg  
preferences/32/preferences-system-network-server-tftp.svg
apps/32/yast-update.svg   
apps/32/yast-vm-install.svg   preferences/32/preferences-vm-install.svg
apps/32/yast-vm-migrate.svg   preferences/32/preferences-vm-migrate.svg
apps/32/yast-vm.svg   preferences/32/preferences-vm.svg

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378553 , @ngraham wrote:
  
  > In D17623#378253 , @ndavis wrote:
  >
  > > We can turn the `yast-*` into symlinks and rename the real icons to 
proper names when we need them. You're asking me to guess what the right names 
for the future would be before we need them. There's no existing pattern for 
authentication related icons like there is for drives and network stuff.
  >
  >
  > I think we can come up with appropriate new patterns. The reason why I'd 
like to do this is because the new icons are so good that other apps should be 
able to use them too, if appropriate! But if they were prefixed with `yast-`, 
that would just be weird.
  >
  > Could you provide a list of the new icons you created that are not already 
symlinks? It's hard to tell in this diff since new icons are intermixed with 
symlinks.
  
  
  
  
apps/32/yast-apparmor.svg
apps/32/yast-auth-client.svg
apps/32/yast-autoyast.svg
apps/32/yast-bootloader.svg
apps/32/yast-checkmedia.svg
apps/32/yast-create-new-vm.svg
apps/32/yast-device-tree.svg
apps/32/yast-dhcp-server.svg
apps/32/yast-disk.svg
apps/32/yast-dns-server.svg
apps/32/yast-docker.svg
apps/32/yast-dsl.svg
apps/32/yast-firewall.svg
apps/32/yast-ftp-server.svg
apps/32/yast-hardware.svg
apps/32/yast-host.svg
apps/32/yast-http-server.svg
apps/32/yast-hwinfo.svg
apps/32/yast-instserver.svg
apps/32/yast-iscsi-client.svg
apps/32/yast-iscsi-server.svg
apps/32/yast-journal.svg
apps/32/yast-kerberos-server.svg
apps/32/yast-kernel.svg
apps/32/yast-lan.svg
apps/32/yast-ldap-server.svg
apps/32/yast-ldap.svg
apps/32/yast-mail.svg
apps/32/yast-messages.svg
apps/32/yast-nfs-server.svg
apps/32/yast-nis-server.svg
apps/32/yast-nis.svg
apps/32/yast-ntp-client.svg
apps/32/yast-printer.svg
apps/32/yast-proxy.svg
apps/32/yast-release-notes.svg
apps/32/yast-remote.svg
apps/32/yast-samba-client.svg
apps/32/yast-samba-server.svg
apps/32/yast-scanner.svg
apps/32/yast-security.svg
apps/32/yast-services-manager.svg
apps/32/yast-slp-server.svg
apps/32/yast-snapper.svg
apps/32/yast-software.svg
apps/32/yast-sudo.svg
apps/32/yast-support.svg
apps/32/yast-sw_single.svg
apps/32/yast-sw_source.svg
apps/32/yast-sysconfig.svg
apps/32/yast-system.svg
apps/32/yast-tftp-server.svg
apps/32/yast-update.svg
apps/32/yast-vm-install.svg
apps/32/yast-vm-migrate.svg
apps/32/yast-vm.svg
apps/32/yast-vpn.svg
apps/32/yast-wol.svg
apps/32/yast.svg
apps/48/yast-installation.svg
apps/48/yast-sw_single.svg
apps/48/yast.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added a comment.


  In D17623#378253 , @ndavis wrote:
  
  > We can turn the `yast-*` into symlinks and rename the real icons to proper 
names when we need them. You're asking me to guess what the right names for the 
future would be before we need them. There's no existing pattern for 
authentication related icons like there is for drives and network stuff.
  
  
  I think we can come up with appropriate new patterns. The reason why I'd like 
to do this is because the new icons are so good that other apps should be able 
to use them too, if appropriate! But if they were prefixed with `yast-`, that 
would just be weird.
  
  Could you provide a list of the new icons you created that are not already 
symlinks? It's hard to tell in this diff since new icons are intermixed with 
symlinks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378248 , @ngraham wrote:
  
  > In D17623#378023 , @ndavis wrote:
  >
  > > When the time comes, we can make symlinks with more appropriate names and 
different sizes.
  >
  >
  > If we continue to use this patch to create icons with names that start with 
`yast-`, I would prefer for those to be the symlinks. So for example your new 
`yast-auth-client` icon should be named `auth-kerberos` and `yast-auth-client` 
should be a symlink to it.
  
  
  We can turn the `yast-*` into symlinks and rename the real icons to proper 
names when we need theme. You're asking me to guess what the right names for 
the future would be before we need them. There's no existing pattern for 
authentication related icons like there is for drives and network stuff.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  LCP, the other openSUSE designer I've been working with, had this to say:
  
  >   I have to disagree with ngraham here, imagine how many potential 
conflicts in hicolor we could get if yast icons had no prefix
  
  and we can't load those icons from resource like everything else
  
  He doesn't currently have a KDE account. Hopefully he will get one so I don't 
need to copy and paste what he says.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added reviewers: cfeck, broulik, elvisangelaccio.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  In D17623#378023 , @ndavis wrote:
  
  > I'd have to make PRs for ~60 GitHub repositories, so I'd like to avoid that 
if possible.
  
  
  I understand that this would be really annoying, but conceptually it seems 
like the correct approach. If YaST wants to icons from icon themes, it doesn't 
seem reasonable to expect every single icon theme in existence to make special 
icons just fro YaST. YaST should use commonly-named icons.
  
  > When the time comes, we can make symlinks with more appropriate names and 
different sizes.
  
  If we continue to use this patch to create icons with names that start with 
`yast-`, I would prefer for those to be the symlinks. So for example your new 
`yast-auth-client` icon should be named `auth-kerberos` and `yast-auth-client` 
should be a symlink to it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378006 , @ngraham wrote:
  
  > Nice work, these are good icons!
  >
  > However, I wonder whether we really want to use the `yast-` prefix for 
these images, especially the ones without explicit opensuse iconography.
  >  I can imagine some of these being useful in other apps' settings dialogs 
as well, but it would feel weird to use an icon that starts with `yast-`. Can 
we not change YaST itself to use different names for its icons? If YaST has 
recently gained the ability to take icons from icon themes, it seems 
unreasonable for it to expect icons named `yast-` rather than just 
using more neutrally-named icons.
  >
  > For example `yast-auth-client` could be be named `auth-kerberos` or 
something so that any kerberos-related things can use that nice icon.
  
  
  I'd have to make PRs for ~60 GitHub repositories, so I'd like to avoid that 
if possible. I agree that some of these would be useful for other programs 
though. When the time comes, we can make symlinks with more appropriate names 
and different sizes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added a comment.


  Nice work, these are good icons!
  
  However, I wonder whether we really want to use the `yast-` prefix for these 
images, especially the ones without explicit opensuse iconography. I can 
imagine some of these being useful in other apps' settings dialogs as well, but 
it would feel weird to use an icon that starts with `yast-`. Can we not change 
YaST itself to use different names for its icons? If YaST has recently gained 
the ability to take icons from icon themes, it seems unreasonable for it to 
expect icons named `yast-` rather than just using more 
neutrally-named icons.
  
  For example `yast-auth-client` could be be named `auth-kerberos` or something 
so that any kerberos-related things can use that nice icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis updated this revision to Diff 47674.
ndavis added a comment.


  Change printer and scanner icons to 32px since YaST Control Center doesn't 
want to work with symlinks to 64px device icons.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17623?vs=47668=47674

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

AFFECTED FILES
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-printer.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-scanner.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons/apps/32/yast-addon.svg
  icons/apps/32/yast-alternatives.svg
  icons/apps/32/yast-apparmor.svg
  icons/apps/32/yast-auth-client.svg
  icons/apps/32/yast-autoyast.svg
  icons/apps/32/yast-bootloader.svg
  icons/apps/32/yast-checkmedia.svg
  icons/apps/32/yast-create-new-vm.svg
  icons/apps/32/yast-device-tree.svg
  icons/apps/32/yast-dhcp-server.svg
  icons/apps/32/yast-disk.svg
  icons/apps/32/yast-dns-server.svg
  icons/apps/32/yast-docker.svg
  icons/apps/32/yast-dsl.svg
  icons/apps/32/yast-fcoe.svg
  icons/apps/32/yast-firewall.svg
  icons/apps/32/yast-fonts.svg
  icons/apps/32/yast-ftp-server.svg
  icons/apps/32/yast-hardware.svg
  icons/apps/32/yast-host.svg
  icons/apps/32/yast-http-server.svg
  icons/apps/32/yast-hwinfo.svg
  icons/apps/32/yast-instserver.svg
  icons/apps/32/yast-iscsi-client.svg
  icons/apps/32/yast-iscsi-server.svg
  icons/apps/32/yast-journal.svg
  icons/apps/32/yast-kerberos-server.svg
  icons/apps/32/yast-kernel.svg
  icons/apps/32/yast-keyboard.svg
  icons/apps/32/yast-lan.svg
  icons/apps/32/yast-language.svg
  icons/apps/32/yast-ldap-server.svg
  icons/apps/32/yast-ldap.svg
  icons/apps/32/yast-mail.svg
  icons/apps/32/yast-messages.svg
  icons/apps/32/yast-misc.svg
  icons/apps/32/yast-network.svg
  icons/apps/32/yast-nfs-server.svg
  icons/apps/32/yast-nfs.svg
  icons/apps/32/yast-nis-server.svg
  icons/apps/32/yast-nis.svg
  icons/apps/32/yast-ntp-client.svg
  icons/apps/32/yast-printer.svg
  icons/apps/32/yast-proxy.svg
  icons/apps/32/yast-release-notes.svg
  icons/apps/32/yast-remote.svg
  icons/apps/32/yast-samba-client.svg
  icons/apps/32/yast-samba-server.svg
  icons/apps/32/yast-scanner.svg
  icons/apps/32/yast-security.svg
  

D17623: Add YaST icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Most of these icons are meant to be used in YaST Control Center.
  
  There is currently an issue where there is no good folder to place these. 
`apps/32` is a `Fixed` directory, which means this patch will fail the scalable 
test. `preferences/32` would work, except it's only meant to be used for icons 
that are used by the KDE System Settings. Currently, most of these icons are 
32px because that's the size they will be at in the YaST Control Center. 
Another way to solve the scalable issue would be to also create 48px versions 
of all of these icons, but that would be a lot of work and I want these icons 
to be in KF5.54 so that openSUSE Leap 15.1 will have them.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

AFFECTED FILES
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons-dark/apps/64/yast-printer.svg
  icons-dark/apps/64/yast-scanner.svg
  icons/apps/32/yast-addon.svg
  icons/apps/32/yast-alternatives.svg
  icons/apps/32/yast-apparmor.svg
  icons/apps/32/yast-auth-client.svg
  icons/apps/32/yast-autoyast.svg
  icons/apps/32/yast-bootloader.svg
  icons/apps/32/yast-checkmedia.svg
  icons/apps/32/yast-create-new-vm.svg
  icons/apps/32/yast-device-tree.svg
  icons/apps/32/yast-dhcp-server.svg
  icons/apps/32/yast-disk.svg
  icons/apps/32/yast-dns-server.svg
  icons/apps/32/yast-docker.svg
  icons/apps/32/yast-dsl.svg
  icons/apps/32/yast-fcoe.svg
  icons/apps/32/yast-firewall.svg
  icons/apps/32/yast-fonts.svg
  icons/apps/32/yast-ftp-server.svg
  icons/apps/32/yast-hardware.svg
  icons/apps/32/yast-host.svg
  icons/apps/32/yast-http-server.svg
  icons/apps/32/yast-hwinfo.svg
  icons/apps/32/yast-instserver.svg
  icons/apps/32/yast-iscsi-client.svg
  icons/apps/32/yast-iscsi-server.svg
  icons/apps/32/yast-journal.svg
  icons/apps/32/yast-kerberos-server.svg
  icons/apps/32/yast-kernel.svg
  icons/apps/32/yast-keyboard.svg
  icons/apps/32/yast-lan.svg
  icons/apps/32/yast-language.svg
  icons/apps/32/yast-ldap-server.svg