D19324: Add code-oss icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:54a20776ffb4: Add code-oss icon (authored by axionl, 
committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52826=52827

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg, ndavis
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52826.
axionl added a comment.


  - Setting my username to pass the automated audit.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52786=52826

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg, ndavis
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  One last thing, you need to use your real name as your Git user name in order 
for this patch to pass an automated audit.
  
  This page explain how to do that if you need a guide: 
https://help.github.com/en/articles/setting-your-username-in-git

REPOSITORY
  R266 Breeze Icons

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg, ndavis
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D19324#421552 , @axionl wrote:
  
  > This is my first time to contribute plasma/kde project, I feel sorry for my 
mistakes and thanks for your help.
  
  
  No need to feel sorry, I'm just trying to help you learn how our systems 
work. Congratulations on your first contribution to KDE!

REPOSITORY
  R266 Breeze Icons

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg, ndavis
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a comment.


  In D19324#421552 <https://phabricator.kde.org/D19324#421552>, @axionl wrote:
  
  > In D19324#421178 <https://phabricator.kde.org/D19324#421178>, @ndavis wrote:
  >
  > > Great. Now you just need to get rid of the invisible rectangle. You can 
do that quickly with `sed -i 's|||' code.svg`. After you've done that, 
I can accept and land this.
  > >
  > > BTW, you're meant to put the comment for the diff update at the top, but 
it's not a huge deal. That's why you keep getting this text in all of your 
update comments:
  > >
  > > - Merge branch 'master' into code-oss
  > >  
  > >   # Updating D19324: Add code-oss icon
  > >   #
  > >   # Enter a brief description of the changes included in this update.
  > >   # The first line is used as subject, next lines as comment.
  > >   #
  > >   # If you intended to create a new revision, use:
  > >   #  $ arc diff --create
  > >
  > >
  > > The stuff to the left of the `#` characters is ignored if you put the 
comment at the top.
  >
  >
  > This is my first time to contribute plasma/kde project, I feel sorry for my 
mistakes and thanks for your help.
  
  
  You're doing great, and the icons look amazing, most of this is just icing on 
the cake :D

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#421178 <https://phabricator.kde.org/D19324#421178>, @ndavis wrote:
  
  > Great. Now you just need to get rid of the invisible rectangle. You can do 
that quickly with `sed -i 's|||' code.svg`. After you've done that, 
I can accept and land this.
  >
  > BTW, you're meant to put the comment for the diff update at the top, but 
it's not a huge deal. That's why you keep getting this text in all of your 
update comments:
  >
  > - Merge branch 'master' into code-oss
  >  
  >   # Updating D19324: Add code-oss icon
  >   #
  >   # Enter a brief description of the changes included in this update.
  >   # The first line is used as subject, next lines as comment.
  >   #
  >   # If you intended to create a new revision, use:
  >   #  $ arc diff --create
  >
  >
  > The stuff to the left of the `#` characters is ignored if you put the 
comment at the top.
  
  
  This is my first time to contribute plasma/kde project, I feel sorry for my 
mistakes and thanks for your help.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52786.
axionl added a comment.


  - Merge branch 'master' into code-oss
  
  Remove the invisible rectangle.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52721=52786

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  Great. Now you just need to get rid of the invisible rectangle. You can do 
that quickly with `sed -i 's|||' code.svg`. After you've done that, 
I can accept and land this.
  
  BTW, you're meant to put the comment for the diff update at the top, but it's 
not a huge deal. That's why you keep getting this text in all of your update 
comments:
  
  - Merge branch 'master' into code-oss

# Updating D19324: Add code-oss icon
#
# Enter a brief description of the changes included in this update.
# The first line is used as subject, next lines as comment.
#
# If you intended to create a new revision, use:
#  $ arc diff --create
  
  The stuff to the left of the `#` characters is ignored if you put the comment 
at the top.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52719.
axionl added a comment.


  - Merge branch 'master' into code-oss
  
  1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Replace the green accent and optimize the svg

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52696=52719

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52721.
axionl added a comment.


  - Merge branch 'master' into code-oss
  
  1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Optimize svg

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52719=52721

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  In D19324#420982 , @axionl wrote:
  
  > Just I like it as a modern design style and also avoiding some problems for 
the similarity of official icon, but if you mind that I can remove it.
  
  
  I think that even though the green accent looks nice, the icons should be the 
same for light and dark themes. As for similarity to the official icon, I don't 
think that's a problem. Usually, destroying the original branding is the 
problem when it comes to adapting icons to fit a theme.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#420976 , @ndavis wrote:
  
  > I see you've kept the green on the light theme version instead of using the 
same icon for both versions. Is there a reason for this or do you just prefer 
it?
  >
  > This looks just about ready to land on the master branch, there are just a 
few more things you need to do.
  
  
  Just I like it as a modern design style and also avoiding some problems for 
the similarity of official icon, but if you mind that I can remove it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  You also need to optimize the SVG. You can do that by using one of the three 
SVG optimizers on this page: 
https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow#svg-optimization
  
  I should add that to the HIG at some point in the future.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  I see you've kept the green on the light theme version instead of using the 
same icon for both versions. Is there a reason for this or do you just prefer 
it?
  
  This looks just about ready to land on the master branch, there are just a 
few more things you need to do.

INLINE COMMENTS

> code.svg:903
> +   height="10.58" />
> + +   
> style="opacity:0.35;fill:none;fill-opacity:1;stroke:none;stroke-width:0.26458332"

Delete this invisible rectangle.

> code.svg:884
> +   height="10.58" />
> + +   
> style="opacity:0.35;fill:none;fill-opacity:1;stroke:none;stroke-width:0.26458332"

Delete this invisible rectangle.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52696.
axionl added a comment.


  - Merge branch 'master' into code-oss
  
  1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Try to fix the layer and shadows.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52588=52696

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  Much better. Now for some questions and suggestions.
  
  Why does the icon use green on the top of the logo? The light theme version 
doesn't look bad, but isn't the official logo all blue? In general, we try to 
preserve the original branding.
  
  Why is the dark theme version greener than the light theme? Normally we try 
to make color icons the same for light and dark themes.
  
  It would be good to turn those shadows into gradients with `` as the 
color for the bottom right of the shadow. The darker shadow should expand to 
cover the whole area to the bottom left of the right side of the logo. Here's 
what I mean: 
  F6637009: Screenshot_20190226_052530.png 

  F6637011: Screenshot_20190226_052559.png 

  
  The parts of the logo in this icon are layered differently from the official 
logo: 
https://user-images.githubusercontent.com/49339/32078472-5053adea-baa7-11e7-9034-519002f12ac7.png
  
  The right edge of the right side of the logo is a bit too dark relative to 
the inner edge.
  
  If you're having trouble finding the right blues to make the logo look 3D, 
try using the shadows to separate the layers like I did in the screenshots 
above.
  
  I'll have more to say later.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52588.
axionl added a comment.


  - Merge branch 'master' into code-oss
  
  1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  fixed color details.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52587=52588

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52587.
axionl added a comment.


  - Merge branch 'master' into code-oss
  
  1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Redraw by inkscape.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52581=52587

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#419767 , @ndavis wrote:
  
  > In D19324#419766 , @axionl wrote:
  >
  > > I use the Gravit Designer (https://designer.io/) to design this icon, not 
the inkscape, but I think I can redraw it by inkscape.
  >
  >
  > Please do. KDE software is only made with free and open source software. If 
you need help with Inkscape, let us know. We would be glad to help.
  >
  > > For the filename, because I'm using archlinux and the icon name is 
`code-oss.svg` on `/usr/share/pixmaps`.
  >
  > In that case, run `ln -sr code-oss.svg code.svg` in the same directory as 
`code-oss.svg` to made a symlink so that the icon works for Arch Linux and any 
other distro.
  
  
  Ok, I am done as soon as possible.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  In D19324#419766 , @axionl wrote:
  
  > I use the Gravit Designer (https://designer.io/) to design this icon, not 
the inkscape, but I think I can redraw it by inkscape.
  
  
  Please do. KDE software is only made with free and open source software. If 
you need help with Inkscape, let us know. We would be glad to help.
  
  > For the filename, because I'm using archlinux and the icon name is 
`code-oss.svg` on `/usr/share/pixmaps`.
  
  In that case, run `ln -sr code-oss.svg code.svg` in the same directory as 
`code-oss.svg` to made a symlink so that the icon works for Arch Linux and any 
other distro.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#419751 , @ndavis wrote:
  
  > Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and 
Gwenview it looks like vector graphics. Something is seriously screwed up in 
this SVG. Did you use Inkscape? Can you explain what process you used to make 
this icon?
  >  F6636063: Screenshot_20190226_020059.png 

  >  F6636069: Screenshot_20190226_020524.png 

  >
  > In D19324#419700 , @ngraham 
wrote:
  >
  > > > `code-oss-dark.svg`
  > >
  > > Is this the correct name?
  >
  >
  > I don't think so. The Code-OSS flatpak and the VS Code RPM use `code.png`, 
so I think the name needs to be `code.svg` for light and dark Breeze icons. It 
would be a good idea to test if using icon themes actually works though, 
because `code.png` installs to 
`/usr/share/code/resources/app/resources/linux/code.png` and 
`/usr/share/pixmaps/code.png` instead of hicolor.
  
  
  I use the Gravit Designer (https://designer.io/) to design this icon, not the 
inkscape, but I think I can redraw it by inkscape.
  
  For the filename, because I'm using archlinux and the icon name is 
`code-oss.svg` on `/usr/share/pixmaps`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52581.
axionl added a comment.


  - Merge branch 'master' into code-oss

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52571=52581

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons/apps/48/code-oss.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and 
Gwenview it looks like vector graphics. Something is seriously screwed up in 
this SVG. Did you use Inkscape? Can you explain what process you used to make 
this icon?
  F6636063: Screenshot_20190226_020059.png 

  F6636069: Screenshot_20190226_020524.png 

  
  In D19324#419700 , @ngraham wrote:
  
  > > `code-oss-dark.svg`
  >
  > Is this the correct name?
  
  
  I don't think so. The Code-OSS flatpak and the VS Code RPM use `code.png`, so 
I think the name needs to be `code.svg` for light and dark Breeze icons. It 
would be a good idea to test if using icon themes actually works though, 
because `code.png` installs to 
`/usr/share/code/resources/app/resources/linux/code.png` and 
`/usr/share/pixmaps/code.png` instead of hicolor.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#419702 , @rooty wrote:
  
  > There are commands/aliases here for how to take quick screenshots 
https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow
  >
  > I ran montage-breeze and I got F6635927: new.png 

  >  which looks really nice.
  >
  > However, is there some reason that it looks different from a Dolphin 
generated thumbnail? F6635929: image.png 
  >
  > EDIT: And yes the dark version should have the same name as the regular 
version (code-oss.svg).
  
  
  I have the same problem but this icon working well and can be display normaly 
on my firebrowser.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a comment.


  There are quick commands/aliases here for how to take quick screenshots 
https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow
  
  I ran it and I got F6635927: new.png 
  which looks really nice.
  
  However, is there some reason that it looks different from a Dolphin 
generated thumbnail? F6635929: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Nathaniel Graham]

ngraham added a comment.


  > `code-oss-dark.svg`
  
  Is this the correct name? I assume the app itself isn't named 
"code-oss-dark", right? Also screenshots are appreciated, as is filling in the 
test plan. :)
  
  https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
axionl requested review of this revision.

REVISION SUMMARY
  Add the code-oss icons follow the breeze and breeze-dark style

REPOSITORY
  R266 Breeze Icons

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss-dark.svg
  icons/apps/48/code-oss.svg

To: axionl
Cc: kde-frameworks-devel, michaelh, ngraham, bruns