Re: Review Request 125164: Finish killed KIO jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Nov. 3, 2015, 11:44 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kio Description --- Scheduler::jobFinished cleans up the job but doesn't report it as such. Diffs - src/core/simplejob.cpp 3380cbe autotests/jobtest.h 7641131 autotests/jobtest.cpp 7da92d5 Diff: https://git.reviewboard.kde.org/r/125164/diff/ Testing --- Added a test and made it pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125164: Finish killed KIO jobs
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/
---
(Updated Oct. 30, 2015, 12:46 p.m.)
Review request for KDE Frameworks.
Changes
---
Updated the patch not to try to kill jobs that already finished, as suggested
by David.
Still doesn't solve the issue.
```
snapshot(2084)/(default) unknown: No file found for ".xml" , even though
update-mime-info said it would exist.
ksnapshot(2084)/(default) unknown: Either it was just removed, or the directory
doesn't have executable permission...
ksnapshot(2084)/(default) unknown: ("/home/apol/.local/share/mime",
"/home/kde-devel/kde5/share/mime", "/usr/share/mime")
ksnapshot(2084)/(default) KIO::SimpleJob::doKill: killing a job that already
finished KIO::ListJob(0xec3f90)
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL:
QUrl("kdevelop-build1.png")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL:
QUrl("kdevelop-build1.bmp")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL:
QUrl("kdevelop-build1.bmp")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL:
QUrl("kdevelop-build1.png")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Items emitted in
directory QUrl("file:///home/apol/Documents") but that directory isn't in
KDirModel! Root directory: QUrl("file:///home/apol/imatges")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Item:
QUrl("file:///home/apol/Documents/sudokuTitle.png")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Item:
QUrl("file:///home/apol/Documents/firma.png")
ksnapshot(2084)/(default) KDirModelPrivate::dump: Dumping contents of KDirModel
KDirModel(0xa3c5f0) dirLister url: QUrl("file:///home/apol/imatges")
ksnapshot(2084)/(default) unknown: ASSERT: "result" in file
/home/kde-devel/frameworks/kio/src/widgets/kdirmodel.cpp, line 433
Program received signal SIGABRT, Aborted.
0x722885f8 in raise () from /usr/lib/libc.so.6
(gdb) where
#0 0x722885f8 in raise () from /usr/lib/libc.so.6
#1 0x72289a7a in abort () from /usr/lib/libc.so.6
#2 0x72f2805e in qt_message_fatal (context=..., message=) at
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:1610
#3 QMessageLogger::fatal (this=this@entry=0x7fff9960,
msg=msg@entry=0x731db7f0 "ASSERT: \"%s\" in file %s, line %d") at
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:784
#4 0x72f235de in qt_assert (assertion=, file=, line=) at
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3046
Python Exception cannot resolve overloaded method `data':
Re: Review Request 125164: Finish killed KIO jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87694 --- Reopened because now everyone has the crash I was complaining on the reviews there: https://git.reviewboard.kde.org/r/125613/ Will have to look into how to fix properly, whatever that means. - Aleix Pol Gonzalez On Oct. 29, 2015, 1:35 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125164/ > --- > > (Updated Oct. 29, 2015, 1:35 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > --- > > Scheduler::jobFinished cleans up the job but doesn't report it as such. > > > Diffs > - > > src/core/simplejob.cpp 3380cbe > autotests/jobtest.cpp c24bcea > autotests/jobtest.h ef8c3e1 > > Diff: https://git.reviewboard.kde.org/r/125164/diff/ > > > Testing > --- > > Added a test and made it pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125164: Finish killed KIO jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Oct. 23, 2015, 2:48 a.m.) Review request for KDE Frameworks. Changes --- When killing a job, report it as finished. Summary (updated) - Finish killed KIO jobs Repository: kio Description (updated) --- Scheduler::jobFinished cleans up the job but doesn't report it as such. Diffs (updated) - src/core/simplejob.cpp 3380cbe autotests/jobtest.cpp c24bcea autotests/jobtest.h ef8c3e1 Diff: https://git.reviewboard.kde.org/r/125164/diff/ Testing --- Added a test and made it pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
