D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Fix pri file: have qmake name of QtGui as 
dep, to not fail with CamelCase includes" to "Fix pri file: have qmake name of 
QtGui as dep, do not fail with CamelCase includes".

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27334

To: kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven created this revision.
meven added reviewers: ervin, bport, crossi, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Allow to write choices such as :
  
  
  


  
  

TEST PLAN
  ctest

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp

To: meven, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27328: Drop qmake pri file generation & installation, currently broken

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:015a4d01140e: Drop qmake pri file generation  
installation, currently broken (authored by kossebau).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27328?vs=75483=75838

REVISION DETAIL
  https://phabricator.kde.org/D27328

AFFECTED FILES
  metainfo.yaml
  src/CMakeLists.txt

To: kossebau, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27327: Drop qmake pri file generation & installation, currently broken

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R281:3b16da10e770: Drop qmake pri file generation  
installation, currently broken (authored by kossebau).

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27327?vs=75482=75839

REVISION DETAIL
  https://phabricator.kde.org/D27327

AFFECTED FILES
  metainfo.yaml
  src/CMakeLists.txt

To: kossebau, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Ping?  Will land on Thursday otherwise, given I am sure about these 2 fixes 
to make prison usable with qmake at all.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27334

To: kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 75852.
meven added a comment.


  update xsd

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=75837=75852

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  Testing/Temporary/CTestCostData.txt
  Testing/Temporary/LastTest.log
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Standardizing Qt logging categories used in KF

[Friedrich W. H. Kossebau]

Hi,

while going through the KF modules to adapt to the new 
ecm_qt_install_logging_categories() macro* to auto-generate KDebugSettings 
.categories (& .renamecategories) files I once more found there is no real 
naming pattern for the logging categories.
* https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html

Examples:
org.kde.attica
org.kde.pim.kcalcore
kf5.kconfig.core
kf5.kconfigwidgets
sonnet.core
sonnet.plugins.aspell
kf5.kemoticons.plugin_adium

As a result one cannot "calculate" the name which would be used for a given 
library (or feature), but has to first look that up (or relying on 
kdebugsettings & maintained .categories file). Also am I missing the ability 
from KDebug times where there was the option to control debug output per 
certain feature across libraries/KF modules.

My proposal would be to switch to use these patterns:

"kf".[.][.]
"kf"...[.]
"kf"..[.]
"kf"..[.]

So the examples would become:
kf.attica
kf.calendarcore
kf.config.core
kf.configwidgets
kf.sonnet.core
kf.sonnet.clients.aspell
kf.emoticons.adium

If people agree on such standardization, I would propose to do that renaming 
already now and not only at KF6 time. Given the categories being rather 
undocumented, usually only looked up when needed and kdebugsettings also 
supporting renames, I would think we can improve the situation already now.
Having clear and known categories also might help once reaching work on KF6, 
when logged debugging might be more used during the Qt6 porting and other 5->6 
work.


Please head over to
https://phabricator.kde.org/T12716
for a detailed description and reasoning of the current proposal to the 
problem, and join the discussion over there, so we have a central place to 
collect and track comments/ideas/work.

Cheers
Friedrich

D27451: Drop KToolInvocation support from KRun::runService

[David Edmundson]

davidedmundson updated this revision to Diff 75867.
davidedmundson added a comment.


  Remove extra include

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27451?vs=75811=75867

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27451

AFFECTED FILES
  src/widgets/krun.cpp

To: davidedmundson, dfaure
Cc: ervin, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack created this revision.
cblack added reviewers: KWin, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This patch adds an interface allowing a compositor to send
  the service name and object path of a PlasmaWindow's application menu
  to the client.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  .gitignore
  src/CMakeLists.txt
  src/client/CMakeLists.txt
  src/org_kde_kwayland.categories
  src/server/CMakeLists.txt

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:d2172d3c0843: Fix inverted logic in 
IOKitStorage::isRemovable (authored by mwolff).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27065?vs=74772=75857

REVISION DETAIL
  https://phabricator.kde.org/D27065

AFFECTED FILES
  src/solid/devices/backends/iokit/iokitstorage.cpp

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-mac, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> kcoreconfigskeleton.h:459
> +// given we can't, I've shadowed the method. This isn't pretty, but given
> +// the docs say it should generally only be used from auto generated 
> code,
>  void setWriteFlags(KConfigBase::WriteConfigFlags flags);

the end of the sentence is missing.  ("should be fine")

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack updated this revision to Diff 75855.
cblack added a comment.


  Figure out how to use arc correctly

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=75854=75855

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack planned changes to this revision.
cblack added a comment.


  whoops, I seem to have forgotten how to use arc

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

[Mathis Brüchert]

mbruchert added a comment.


  thank you so much!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis
Cc: ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27223: add kirigami-gallery icon

[Mathis Brüchert]

mbruchert updated this revision to Diff 75859.
mbruchert added a comment.


  - fix issues

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27223?vs=75772=75859

BRANCH
  arcpatch-D27223

REVISION DETAIL
  https://phabricator.kde.org/D27223

AFFECTED FILES
  icons-dark/apps/48/kirigami-gallery.svg
  icons/apps/48/kirigami-gallery.svg

To: mbruchert, mart, #vdg, ndavis
Cc: ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27468: Don't double delete CommentsModel

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  CommentsModel instances are owned by the engine.
  
  They are fetched through a getter with a cache, so ownership has to stay
  that way.
  
  QuickItemsModel should not be deleting them.
  
  BUG: 417802

TEST PLAN
  Got a valgrind log of the crash, which showed the issue
  (see attached bug report)
  
  Afterwards:
  Opened systemsettings, opened comments dialog
  Closed systemsettings

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27468

AFFECTED FILES
  src/qtquick/quickitemsmodel.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/62/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 17 Feb 2020 19:10:20 +
 Build duration:
1 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D27463: KconfigXT: Add a value attribute to Enum field choices

[David Redondo]

davidre added a comment.


  If you touch the xsd do you neeed to increase the version number?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 309 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/309/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 18 Feb 2020 05:03:58 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34806/62086)40%
(17684/43868)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)96%
(9726/10183)47%
(4539/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14619)51%
(4517/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4662/8329)43%
(2068/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D27455: FileWidgets: Ignore Return events from KDirOperator

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice, works for me.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

[Friedrich W. H. Kossebau]

Am Dienstag, 18. Februar 2020, 04:03:05 CET schrieb Nate Graham:
> On 2020-02-16 14:43, Albert Astals Cid wrote:
> > Maybe i explain myself wrongly, i'm not blaming distros at all.
> > 
> > They made a decision, we/I may agree with them or not, that's *my/our*
> > problem, what I was disagreeing is to us having to do extra work because
> > someone elses (the distros) decision.
> We already do this: it's called the Plasma LTS product. :-) It's been
> specifically created to cater to various distros' desires for an
> extended-support product they can ship to users of their own LTS releases.
> 
> However all the autotests in the world will not resolve the fundamental
> incompatibility between the Plasma LTS product, which is built around
> the release model of extended, ongoing bugfix releases, and Frameworks,
> which is built around a rolling release model with no bugfix releases at
> all.

For one, distribution seem to be just fine with that. And it should be them to 
complain if they cannot make use of Plasma LTS to create a product endorsed by 
their distribution/operating system flavour users. Why would the package and 
use Plasma otherwise, if not to create a usable product.
They simply create their own KF LTS, by backporting patches which they define  
important enough to the version of KF they use. Like they do for all the other 
software where they pinpointed to a certain version and where upstream does 
not do a matching LTS, starting with the Linux kernel.

And as said before, the Plasma team could just maintain some LTS version of KF 
next to the normal master release branch and the normal releases. That branch 
could then even be synced with the release schedule pf Plasma LTS, incl. the 
lifespan,

Is there a list of Plasma LTS usages in distributions which are horrible 
because of important fixes to KF not being backported? Or is this more a 
theoretical problem you are afraid of seeing the current quality hick-up?

Cheers
Friedrich

D27459: Port QLinkedList which is deprecated in qt5.15

[Albert Astals Cid]

aacid added a comment.


  Are we sure we can lose the features of QLinkedList here?
  
  maybe makes more sense to use std::list that has the same features as 
QLinkedList?

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure, apol
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Re: 2 kirigami fixes for a point release

[Luca Beltrame]

In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto:

> think KDE software should be presented to users. Basically, we
> acknowledge that Neon is already an actual OS--the "KDE OS"--and we

Please don't suggest such downstream-hostile solutions, in particular because 
this failing is entirely upstream. We have already plenty in FOSS, I don't 
want KDE to be yet another community that "adopts" them.

"We messed up so let's make things our way" is not an acceptable approach.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 434 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/434/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 18 Feb 2020 05:04:02 +
 Build duration:
9 min 20 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34828/62088)40%
(17707/43872)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)96%
(9726/10183)47%
(4545/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8734/14619)51%
(4526/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4661/8329)43%
(2069/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1806/4289)36%
(1312/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 301 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/301/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 18 Feb 2020 05:03:58 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

[Kevin Ottens]

ervin added a comment.


  Sounds innocuous indeed and I always found that queued connection weird... I 
mean resetting to false whatever happens during load? That's fine for simple 
cases but not real complex ones.
  
  Still, can we have some more extensive testing on a good chunk of the modules 
in systemsettings? We also have very weird beasts in the mix (KScreenLocker KCM 
comes into mind for instance but there are more), I'd rather not see them 
break. It's also worth checking in things like Kontact, KMail and friends which 
extensively use KCModules for their config dialogs.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27452

To: bport, #plasma, davidedmundson, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

[David Edmundson]

davidedmundson added a comment.


  I found out why this was added.  7e4b9688d52f55828ba4a5b82e9d8fe5b1a5ff94 

  
  In 2008 things changed to being loaded in the showEvent
  
  Many people blindly connecting to widgets changing in the constructor so when 
we deferred called load() they're going to change.
  
  This led to some KCMs signalling they changed prematurely so random hacks 
were "strategically placed" (sic)
  
  
  
  I'm still very positive this is technically right. 
  Whether it'll cause any breakages is another story.  For system settings it 
is a problem if they signal they are changed when they are not as we get an 
annoying "there are unsaved changes" prompt.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27452

To: bport, #plasma, davidedmundson, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27455: FileWidgets: Ignore Return events from KDirOperator

[Méven Car]

meven created this revision.
meven added reviewers: dfaure, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Activated event is used to handle key returns from KDirOperator.
  Making a Return in the KDirOperator would cause a double treatment of the 
event :
  
  - one for activated / _slotActivated
  - one for Key_Return activated

TEST PLAN
  - Open Kate
  - Ctrl+Maj + S, to save file as
  - type a file name
  - go to a directory using the arrows keys and return key
  
  Before:
  The dialog returns immediately with the file name in the opened directory.
  
  After:
  The directory is opened, the user can continue specifying path.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27455

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: meven, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27455: FileWidgets: Ignore Return events from KDirOperator

[Méven Car]

meven added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27455: FileWidgets: Ignore Return events from KDirOperator

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26769: Always strip html if server does not support it

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Also, title must never be HTML, there's a reason the capability is called 
//body//-markup :)

REPOSITORY
  R289 KNotifications

BRANCH
  stripcorrently

REVISION DETAIL
  https://phabricator.kde.org/D26769

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26769: Always strip html if server does not support it

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  stripcorrently

REVISION DETAIL
  https://phabricator.kde.org/D26769

To: nicolasfella, #frameworks, broulik, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Taking over KNotifications maintainership

[Kai Uwe Broulik]

Hi all,

I propose to make me the official maintainer of KNotifications given 
that's pretty much what I've been doing for quite some time already anyway.


It still lists Martin Klapetek as maintainer who unfortunately isn't 
very active anymore.


Cheers
Kai Uwe

Re: Taking over KNotifications maintainership

[Aleix Pol]

El dl., 17 de febr. 2020, 12:19, Kai Uwe Broulik  va
escriure:

> Hi all,
>
> I propose to make me the official maintainer of KNotifications given
> that's pretty much what I've been doing for quite some time already anyway.
>
> It still lists Martin Klapetek as maintainer who unfortunately isn't
> very active anymore.
>
> Cheers
> Kai Uwe
>

+1

Makes sense, you have been acting as such in practice already.

Aleix

>

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

[Kevin Ottens]

ervin added a comment.


  Yes, we really need a large clean up in this area, we got strata of old cruft 
layered on top often with duplicated states between them. We also have the 
widget and QML cases being very different in their state management (one 
comparing widget content with the settings object every time, the other one 
looking at the state of the settings object). This screams for being properly 
rethought. With KF6 around the corner it makes it very tempting to revisit.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27452

To: bport, #plasma, davidedmundson, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27455: FileWidgets: Ignore Return events from KDirOperator

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

[Arjen Hiemstra]

ahiemstra added a comment.


  @heikobecker This patch has been open for a long time... Do you have commit 
access or do you need someone to commit it for you?

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25794

To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25795: Rename kf5quickcharts_example to kquickcharts_example

[Arjen Hiemstra]

ahiemstra added a comment.


  @heikobecker This patch has been open for a long time... Do you have commit 
access or do you need someone to commit it for you?

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25795

To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker added a comment.


  In D25794#612748 , @ahiemstra 
wrote:
  
  > @heikobecker This patch has been open for a long time... Do you have commit 
access or do you need someone to commit it for you?
  
  
  I have and I already committed it: 
https://cgit.kde.org/kquickcharts.git/commit/?id=d9d724b013024d3c332cc3bf9da02ff211637ebb
 No idea why this wasn't closed automatically.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25794

To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25795: Rename kf5quickcharts_example to kquickcharts_example

[Heiko Becker]

heikobecker closed this revision.
heikobecker added a comment.


  In D25795#612749 , @ahiemstra 
wrote:
  
  > @heikobecker This patch has been open for a long time... Do you have commit 
access or do you need someone to commit it for you?
  
  
  I have and I already committed it: 
https://cgit.kde.org/kquickcharts.git/commit/?id=e3ae6f929ebc5cb5f7cc4086bb98a21f382b2119
 No idea why this wasn't closed automatically.

REVISION DETAIL
  https://phabricator.kde.org/D25795

To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D25794

To: heikobecker, #frameworks, ahiemstra, davidedmundson

Re: 2 kirigami fixes for a point release

[Ben Cooksley]

On Mon, Feb 17, 2020 at 10:43 AM Albert Astals Cid  wrote:
>
> El diumenge, 16 de febrer de 2020, a les 22:34:51 CET, David Faure va 
> escriure:
> > On dimanche 16 février 2020 22:17:17 CET Albert Astals Cid wrote:
> > > This is their fault, they as a distribution have decided to support a 
> > > random
> > > KDE Frameworks version for longer than we do support it, so they are the
> > > ones that should be the job of supporting it.
> > >
> > > It's like you are trying to say we should be doing the distributions jobs,
> > > what we should be doing is doing our job which is making the best software
> > > we can, not spending time accomodating decisions that somebody else took
> > > for us, and since distributions often only bring us pain in the shape of
> > > not updating versions, etc. IMHO what we should be doing is moving away
> > > from distributions model and more into the snap/flatpak model in which we
> > > control what we give our users.
> > >
> > > Sadly flatpak doesn't work for non applications and snap is
> > > Ubuntu-only-not-really-but-yes-really so for Plasma this doesn't really
> > > solver the problem so maybe we should just finally tell our users to start
> > > using the good distributions if they care about their user experience. By
> > > good meaning those with a rolling KDE software suite or those that 
> > > actually
> > > do backport fixes to the version they have randomly decided to lock onto.
> >
> > At the same time, we can only successfully convince distributions to upgrade
> > to the monthly KF5 releases if they are stable and don't come with
> > regressions. I believe this is true for most of the frameworks, but I'm not 
> > so
> > sure about kirigami/qqc2-desktop-style, based on what I hear (not just the
> > recent issue).
> >
> > Before blaming distros, I believe we have our own backyard to take care of,
> > with for sure more systematic use of code reviews and possibly more 
> > automated
> > testing, for those frameworks (for the latter I guess that QtQuick doesn't
> > make it easy, but that's part of the problem...).
>
> Maybe i explain myself wrongly, i'm not blaming distros at all.
>
> They made a decision, we/I may agree with them or not, that's *my/our* 
> problem, what I was disagreeing is to us having to do extra work because 
> someone elses (the distros) decision.

Unfortunately users will sadly blame us, saying KDE software is
buggy/broken/etc.
It therefore falls on us to apply pressure on the distributions making
bad decisions and make them correct them.

Those distributions that provide a bad experience to our users, and
refuse to fix it, are working against us and the goals we are trying
to achieve.

(I'm not saying that we should bow down to flawed, short sighted and
broken distribution policies here, if anyone is bending it should be
their policies bending down to us)

>
> And yes, totally, we need more autotests, and moving to gitlab so tests are 
> finally run *before* merging stuff.

That will come once we have migrated code management and review to Gitlab yes.
It wouldn't have helped in the case of Kirigami sadly as there are no
unit tests for the things which were broken, but i'm sure it will help
in other areas for sure.

>
> Cheers,
>   Albert

Cheers,
Ben

>
> >
> >
>
>
>
>

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 183 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/183/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 17 Feb 2020 08:51:40 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.68.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(263/298)88%
(263/298)68%
(33260/49174)50%
(14972/30054)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)93%
(4776/5130)49%
(1789/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5503/5545)58%
(970/1680)src.buffer88%
(15/17)88%
(15/17)90%
(1700/1892)75%
(1103/1472)src.completion100%
(11/11)100%
(11/11)57%
(1787/3131)42%
(1010/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1943/3170)48%
(1431/2965)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(201/220)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(716/1038)56%
(226/403)src.search100%
  

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, davidedmundson, ervin, crossi, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.

REVISION SUMMARY
  Currently from David Edmundson comment on https://phabricator.kde.org/D27384
  
  1. KCModule::showEvent()
  
  this queues up a load and queues up a KCModule::changed(false)
  
  2. during load ConfigModule::setNeedsSave(true) is called we set 
d->_needsSave to true
  3. we emit ConfigModule::changed(true) which we proxy through to 
KCModule::changed(true)
  4. we then process the queued KCModule::setChanged(false) from the earlier 
KCModule::showEvent
  5. so we disable the button
  6. any subsequent changes in the KCM will call 
ConfigModule::setNeedsSave(true)

TEST PLAN
  - Fix problem with ConfigModule KCM
  - Tried qtquicksettings module, no regression from my side

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27452

AFFECTED FILES
  src/kcmodule.cpp

To: bport, #plasma, davidedmundson, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

[Ben Cooksley]

On Mon, Feb 17, 2020 at 10:55 AM Friedrich W. H. Kossebau
 wrote:
>
> Sorry, no time to rewrite to make this short.
>
> Am Mittwoch, 12. Februar 2020, 21:59:32 CET schrieb Nate Graham:
> > [+ frameworks and plasma mailing lists]
> >
> > On 2020-02-12 11:31, Albert Astals Cid wrote:
> > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va
> escriure:
> > >> On another note, I have to admit I'm starting to doubt how well our LTS
> > >> Plasma product works without a corresponding LTS frameworks release to
> > >> support it. We can fix bugs in software that uses the Plasma release
> > >> schedule till the cows come home, but if the bug is in Frameworks, users
> > >> are stuck with it forever since LTS distros don't typically ship new
> > >> Frameworks releases.
>
> Yes, this has been questioned a few times. Also seeing Plasma LTS used
> together with a non-LTS Qt is a bit strange.
> But somehow it seems there has not been enough pain for those using the Plasma
> LTS to change something. Possibly because distributions simply backport
> important bug fixes for KF themselves, kind of maintaining their own KF LTS
> version of the KF version they pinpointed to when they froze the ingredients
> to their OS. Because they are used to do this for other projects as well, and
> so miss this could be done in cooperation with upstream.
>
> IMHO distributions using Plasma LTS, Plasma team & other stakeholders should
> team up here and maintain a matching LTS branch of Frameworks together at the
> central KDE repos together. Well, and a version also satisfying other clients
> of KF, like non-workspace applications from KDE.
>
> It's not a reason to change normal KF release cycle.
>
> BTW, we release our software in variants of GPL. We give distributions lots of
> rights by that license to do with the source code what they like, not what
> pleases us as authors. So we want to do cooperation here, not get into any
> form of commandeering them, as it starts sounding elsewhere in this thread.
>
> If unsatisfied with the quality, make Plasma a trademark and hand it out only
> to distributions which are complying with the standards the Plasma team is
> fine with ;)
> Oh, look, an iceweasel is running over there... ;)

Another option is to withdraw the privilege of pre-release access to
packages from the distributions that don't comply.

>
> > >> Yes yes, they should, and all that--but they don't.
> > >>
> > >> It seems like we either need to:
> > >> - Work on convincing these distros to ship Frameworks versions in a
> > >> rolling manner to their LTS users
> > >> - Provide an LTS Frameworks product that can receive bugfixes and get
> > >> point releases, to support the Plasma LTS product
> > >> - Stop misleadingly offering a Plasma LTS product, since everything in
> > >> it that comes from Frameworks isn't actually LTS
> > >
> > > This should not matter, Plasma LTS is built on *lots* of other libraries
> > > that are not LTS either.
> > >
> > > If it matters is because the quality of KF5 releases are not good, that's
> > > what should be fixed IMHO.
> > Yes, the Frameworks 5.67 release was indeed was quite buggy and
> > regression-filled from a Plasma perspective :(
> >
> > However buggy releases are the proximate cause, not the root cause. We
> > have to ask: what causes buggy releases?
> >
> > I would argue that bugginess is baked into the Frameworks product by
> > virtue of its very fast one-month release cycle and lack of beta
> > periods, as there are for apps and Plasma. No matter how diligent patch
> > review is, regressions always sneak in; that's why QA and beta-testing
> > exist.
>
> This assumes the master branch of KF modules serves the purpose of beta
> testing. My understanding is: it does not. And could not be, for the very
> reason you gave, too little time and too few testers.
>
> The master branch's purpose is mainly to collect all changes for the next
> release, and serve as reference when merging dependent changes across multiple
> repos for CI. It should be in the state of "always releaseable".
>
> Which also means patches going in should have seen a beta period by the people
> doing the patches _before_ merging them, and be well understood in their
> potential side-effects. Yes, this also means that for cross-repo/products
> developer should have first done some testing for some time with locally
> patched variants of all affected repos, if unsure about their changes (say,
> removing an unused variable is well understood in effect scope and does not
> need lots of testingi).
> But by default crowd-sourcing the QA to fellow developers also working against
> current master and wanting to test-drive their own changes is not the way to
> go. For one they do not know they should test certain things and thus might
> not even get close to things, thus not do any testing, or it will conflict
> with their own work, when they cannot be sure it was their own change or
> someone else's which breaks 

D27451: Drop KToolInvocation support from KRun::runService

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This drops the use of kinit as per T12140 
. Few applications link to
  kdeinit correctly and the potential savings that come from library 
  linking are now negligible.
  
  We use the internal app spawning path for the majority of application
  launches anyway via the relatively new KRun::runApplication. There isn't
  a need for runService to support a more complex addition path.
  
  It will also simplify any future changes coming to KRun.

TEST PLAN
  Opened a file from kicker's recently used selection (which uses this 
runService)
  It opened as normal, with correct startup notifications

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27451

AFFECTED FILES
  src/widgets/krun.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27451: Drop KToolInvocation support from KRun::runService

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27451

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

[Wolfgang Bauer]

wbauer added a comment.


  In D11880#331450 , @ngraham wrote:
  
  > However, there seems to be a problem for the breeze dark versions:
  >  F6283726: Screenshot_20180924_215524.png 

  >
  > Shouldn't the wall be light-colored? Does it work for you when actually 
deployed and in use with breeze dark?
  
  
  
  
  In D11880#331724 , @ngraham wrote:
  
  > Never mind, it's a Cuttlefish issue. Everything looks good to me.
  
  
  Actually it's not. We got a bug report about exactly that in openSUSE:
  https://bugzilla.opensuse.org/show_bug.cgi?id=1157921
  
  Creating the symlink firewall-applet-shields_up -> firewall-applet fixes it, 
so it's probably a bug in the icon loader when doing the fallback...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: wbauer, dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, 
ngraham, LeGast00n, cblack, GB_2, michaelh

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi added a reviewer: mdawson.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port QLinkedList (deprecated in qt5.15)

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

AFFECTED FILES
  src/ktoolbarhandler.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27451: Drop KToolInvocation support from KRun::runService

[Kevin Ottens]

ervin added a comment.


  For the record, it LGTM and I'm glad to see this point discussing during the 
sprint coming through. :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27451

To: davidedmundson, dfaure
Cc: ervin, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 75829.
crossi added a comment.


  Comments

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74799=75829

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27355: POC: Make kstatusnotifieritem available without dbus

[Johnny Jazeix]

jjazeix added a reviewer: broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27355

To: vonreth, bcooksley, jjazeix, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 75824.
niccolove added a comment.


  Remove hardcoded values

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=75796=75824

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

[Niccolò Venerandi]

niccolove added a comment.


  With big panels this is not really a problem, but I feel like a 3px lines 
takes too much space from the icon space, making it a bit cramped. Here's an 
example of a theme using a 2px line as well (Sweet KDE, the most downloaded 
Plasma theme):
  F8108529: Screenshot_20200217_140307.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27445

To: niccolove, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D25583: Quit baloo_file_extractor if DB transaction fails

[David Edmundson]

davidedmundson added a comment.


  > From the viewpoint of baloo_file, the process just hangs, which is bad.
  
  Ok, I can add support for passing the error down to baloo_file.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns, ngraham
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27444: Added top area

[Niccolò Venerandi]

niccolove added a comment.


  In D27444#612582 , @ngraham wrote:
  
  > This will need CMake changes to actually install it.
  
  
  Isn't this automatically done by the glob?
  
FILE(GLOB widgets widgets/*.svg)
plasma_install_desktoptheme_svgs(default SUBPATH widgets FILES ${widgets})

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi marked 9 inline comments as done.
crossi added inline comments.

INLINE COMMENTS

> ervin wrote in kcoreconfigskeleton.h:448
> That's my understanding to have them virtuals in KF6 indeed, that was 
> introduced by David Edmundson a little while ago. This is necessary because 
> of the way KConfigSkeletonItem is done and because 
> KConfigCompilerSignallingItem is basically a decorator.

Added David's comment from D25791  to make 
things clearer on what to do.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> jucato wrote in knotification.h:96
> Maybe we should keep this part that the icon name, especially that it has to 
> be one that can be found by KIconLoader.

Since Qt5 KIconLoader is an implementation detail. Even our apps and frameworks 
use QIcon::fromTheme, I haven't looked at what KNotifications does but pretty 
sure it's using QIcon.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26918: Improve KNotification API docs

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> apol wrote in knotification.h:96
> Since Qt5 KIconLoader is an implementation detail. Even our apps and 
> frameworks use QIcon::fromTheme, I haven't looked at what KNotifications does 
> but pretty sure it's using QIcon.

It actually sends out the icon name as a string and plasmashell then looks it 
up.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  icon sizes and label placements tested correct in  several scenarios
  
  - control.icon.width/height is used as maximum size of the icon
  - if the button is smaller icons always scale down
  - icons stay ccentered regardless of button size when there is no text

TEST PLAN
  fixes icon sizes without workarounds like D27260 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> broulik wrote in knotification.h:96
> It actually sends out the icon name as a string and plasmashell then looks it 
> up.

With QIcon?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns