D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka added a comment.


  I’m not sure whether I did everything correctly. If I did, this is too 
complicated.
  
  The guidelines in the community wiki 
 and the 
HIG  are missing:
  
  - What are the borders good for?
  - What icon sizes are needed? (I choosed 16, 22, 24, because theese have the 
most icons.)
  - What is 24px good for? Isn’t it just 22px with 1px additional border?
  
  And there are just workflow tips, is the actual workflow for adding icons 
described somewhere?
  
  One more problem: scour breaks up the colors of the path elements, if they 
are more than 2. It moves the fill attribute in a group, but then the color 
attributes seem to override it, so the stylesheet is ignored.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg
Cc: kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This is my try to add the icons I requested in D21196#484674 
.
  
  The icons are: pagelayout-[single|facing|facing-first-centered|overview], as 
they are needed for the View Layout menu; and pagelayout-continuous, as it is 
needed for the Continuous view option (which might be moved into the View 
Layout menu).
  
  BUG: 409082

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/pagelayout-continuous.svg
  icons-dark/actions/16/pagelayout-facing-first-centered.svg
  icons-dark/actions/16/pagelayout-facing.svg
  icons-dark/actions/16/pagelayout-overview.svg
  icons-dark/actions/16/pagelayout-single.svg
  icons-dark/actions/22/pagelayout-continuous.svg
  icons-dark/actions/22/pagelayout-facing-first-centered.svg
  icons-dark/actions/22/pagelayout-facing.svg
  icons-dark/actions/22/pagelayout-overview.svg
  icons-dark/actions/22/pagelayout-single.svg
  icons-dark/actions/24/pagelayout-continuous.svg
  icons-dark/actions/24/pagelayout-facing-first-centered.svg
  icons-dark/actions/24/pagelayout-facing.svg
  icons-dark/actions/24/pagelayout-overview.svg
  icons-dark/actions/24/pagelayout-single.svg
  icons/actions/16/pagelayout-continuous.svg
  icons/actions/16/pagelayout-facing-first-centered.svg
  icons/actions/16/pagelayout-facing.svg
  icons/actions/16/pagelayout-overview.svg
  icons/actions/16/pagelayout-single.svg
  icons/actions/22/pagelayout-continuous.svg
  icons/actions/22/pagelayout-facing-first-centered.svg
  icons/actions/22/pagelayout-facing.svg
  icons/actions/22/pagelayout-overview.svg
  icons/actions/22/pagelayout-single.svg
  icons/actions/24/pagelayout-continuous.svg
  icons/actions/24/pagelayout-facing-first-centered.svg
  icons/actions/24/pagelayout-facing.svg
  icons/actions/24/pagelayout-overview.svg
  icons/actions/24/pagelayout-single.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka added a subscriber: Okular.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka added a comment.


  I assume that `fill="currentColor"` also doesn’t work as expected, fixing 
that now...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka updated this revision to Diff 62415.
davidhurka added a comment.


  - Remove color attributes, which were added by scour-icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62411=62415

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka updated this revision to Diff 62411.
davidhurka added a comment.


  - Fix id=current-color-scheme attributes which were removed by scour-icon.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62332=62411

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka added a comment.


  What does `fill:currentColor` mean, by the way?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-26 Thread David Hurka
davidhurka updated this revision to Diff 62602.
davidhurka added a comment.


  - Add missing id=currentColorScheme to 24px versions of snap-page
  
  These snap-page.svg files weren’t in 16px nor 22px, so I forgot them when I 
replaced `type="text/css"` with `type="text/css" id="currentColorScheme"` in 
all files. Thanks for watching out.
  
  > The current color is determined by the color class.
  
  So `currentColor` is a property of any CSS class?

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62415=62602

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis, ngraham
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-26 Thread David Hurka
davidhurka marked 2 inline comments as done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis, ngraham
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-26 Thread David Hurka
davidhurka updated this revision to Diff 62603.
davidhurka added a comment.


  - Add missing .ColorScheme-Text { to 24px versions of snap-page.svg
  
  And then the class name was missing, together with the opening brace: 
`.ColorScheme-Text {`. This is not a comfortable workflow...
  
  Would it make sense to parse the SVG files and collect the path elements in 
QPainterPaths, to put them in a new SVG file with the correct color scheme CSS 
stuff?

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62602=62603

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis, ngraham
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment.


  
  
  In D22617#499767 , @ndavis wrote:
  
  > Nice work!
  >
  > I know a lot of monochrome icons currently use the bottom right position 
for the folded corner, but I think we should start using the top right. The 
bottom right clashes with our convention of putting additional symbols in the 
bottom right and all of our color icons use the top right for the corner fold.
  
  
  Makes sense, so I’m flipping snap-page now. Is that written down somewhere?
  
  Previously I thought a fold on the top is for documents, and a fold on the 
bottom for pages. Icons like file-new have a fold on the top, icons like 
insert-page-break have it at the bottom.
  
  > There are some additional changes I would like to see.
  > 
  > Naming scheme:
  >  Since this is changing the view, the naming scheme should be something 
like `view-pages-*` rather than `pagelayout-*`
  
  Because it’s changing the layout of page//s//, not a layout //in a// page, 
yes?
  
  > `pagelayout-single`: 
  >  This should be a relative symlink to `snap-page.svg` since they're the 
same icon.
  
  Ok.
  
  > `pagelayout-facing`:
  >  The 16px version is good, but the larger versions don't use up enough of 
the available canvas. In general, aim to use 100% of the allowed vertical space 
(16px in height with 3px top/bottom margins for 22px) unless that would force 
you to squish the symbols in an unattractive way.
  
  I have increased the height by 1px for the 22px icon.
  
  > `pagelayout-facing-first-centered`: 
  >  The top page should be centered to reflect how the view mode works. I 
think the top page shouldn't be cut off, but that means you'll need to shrink 
the size of the pages overall. This will be particularly difficult for the 16px 
version. If you can't get the 16px version to look right with a 2px margin on 
the top and bottom, I'll accept it with a 1px margin even though that goes 
against the HIG.
  
  I can’t follow you here. Centering the first page is a feature / technical 
detail of Okular, but it indicates that the first page is somehow special, like 
the cover page of a book. But your document could be a single chapter of the 
book as well, so the first page is just a regular odd-numbered page. That page 
should be aligned right.
  
  Now my 16px icon looks like a bunch of arrows, not so fine...
  
  >  ---
  > 
  > I don't think it's necessary to do 24px versions of these icons, but 
there's no harm in doing them. It's just more work.
  
  Removed them.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka updated this revision to Diff 62293.
davidhurka added a comment.


  - Remove 24px icons
  - Flip snap-page icons vertically, so the corner fold is at the top-right
  - Make pagelayout-single link to snap-page
  - Flip pagelayout-* icons, except pagelayout-single

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62208=62293

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/pagelayout-continuous.svg
  icons-dark/actions/16/pagelayout-facing-first-centered.svg
  icons-dark/actions/16/pagelayout-facing.svg
  icons-dark/actions/16/pagelayout-overview.svg
  icons-dark/actions/16/pagelayout-single.svg
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/22/pagelayout-continuous.svg
  icons-dark/actions/22/pagelayout-facing-first-centered.svg
  icons-dark/actions/22/pagelayout-facing.svg
  icons-dark/actions/22/pagelayout-overview.svg
  icons-dark/actions/22/pagelayout-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/pagelayout-continuous.svg
  icons/actions/16/pagelayout-facing-first-centered.svg
  icons/actions/16/pagelayout-facing.svg
  icons/actions/16/pagelayout-overview.svg
  icons/actions/16/pagelayout-single.svg
  icons/actions/16/snap-page.svg
  icons/actions/22/pagelayout-continuous.svg
  icons/actions/22/pagelayout-facing-first-centered.svg
  icons/actions/22/pagelayout-facing.svg
  icons/actions/22/pagelayout-overview.svg
  icons/actions/22/pagelayout-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka updated this revision to Diff 62294.
davidhurka added a comment.


  - Rename pagelayout-* to view-pages-*

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62293=62294

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment.


  What is the icons-dark directory good for? The icons in there are mostly just 
the same as in icons.
  
  And I’m a bit concerned that scour-icon removes the id="currentColorScheme" 
attribute from the stylesheet. How do I avoid that?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment.


  In D22617#500131 , @ndavis wrote:
  
  > I'll give the latest changes a proper review in a little while.
  >
  > In D22617#500046 , @davidhurka 
wrote:
  >
  > > What is the icons-dark directory good for? The icons in there are mostly 
just the same as in icons.
  >
  >
  > Non-Qt apps, since they don't work with our stylesheets. Hopefully an XDG 
standard for coloring symbolic/monochrome icons will fix that and then we can 
drop icons-dark.
  
  
  But it is just a redundancy. Can’t there be a script, which copies icons to 
icons-dark and changes the colors, when compiling the icons?
  
  >> And I’m a bit concerned that scour-icon removes the 
id="currentColorScheme" attribute from the stylesheet. How do I avoid that?
  > 
  > Hm, you could try removing `--enable-id-stripping` and `--shorten-ids` from 
the command. If anything from this page 
 confuses 
you or doesn't work, be sure to post in the Discussion section. Writing 
documentation isn't a strength of mine, but it's something that has to be done.
  
  Done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment.


  In D22617#499767 , @ndavis wrote:
  
  > Nice work!
  >
  > I know a lot of monochrome icons currently use the bottom right position 
for the folded corner, but I think we should start using the top right. The 
bottom right clashes with our convention of putting additional symbols in the 
bottom right and all of our color icons use the top right for the corner fold.
  
  
  Other icons with fold in the bottom I could find:
  
  - document-duplicate
  - document-revert-symbolic[-rtl]
  - kt-restore-defaults
  - password-copy
  - viewpdf
  - xml-node-duplicate
  - user-desktop-symbolic
  - document-multiple
  - folder-documents[-symbolic]
  - emblem-documents-symbolic
  
  Most icons indeed have the fold at the top, especially Mimetypes icons look 
great. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment.


  In D22617#500212 , @ndavis wrote:
  
  > In D22617#500031 , @davidhurka 
wrote:
  >
  > > I can’t follow you here. Centering the first page is a feature / 
technical detail of Okular, but it indicates that the first page is somehow 
special, like the cover page of a book. But your document could be a single 
chapter of the book as well, so the first page is just a regular odd-numbered 
page. That page should be aligned right.
  >
  >
  > Since it's an icon for Okular and the feature is called "Facing Pages 
(Center First Page), I don't understand what the problem is with making the top 
symbol centered.
  >
  > Here's what I had in mind:
  >  F7077350: view-pages-facing-first-centered.svg 
 F7077351: 
view-pages-facing-first-centered.svg 
  
  
  Just thinking about RTL layout, centering the top symbol is probably better. 
Fold will still be on the right, because all the other icons already have it on 
the right...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka retitled this revision from "Add icons for pagelayout options, as 
needed in Okular" to "Add view-pages-* icons, as needed in Okular for page 
layout selection".
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka updated this revision to Diff 62332.
davidhurka added a comment.


  - Adapt view-pages-facing and -facing-first-centered to use ndavis' suggested 
files

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62294=62332

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka added a comment.


  By the way, the suggested stylesheet in 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does 
not follow https://hig.kde.org/style/icon.html as far as I can understand it.
  
  - Why does the stylesheet need a background?
  - How are the color scheme properties in the stylesheet mapped to the reduced 
breeze palette in the HIG? (I think neutral or Beware Orange do not clearly 
map.)
  
  If this is ok now, I still have to add the lost `id="current-color-scheme"`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka added a comment.


  In D22617#500361 , @ndavis wrote:
  
  > In D22617#500346 , @davidhurka 
wrote:
  >
  > > - Why does the stylesheet need a background?
  >
  >
  > You only need to add the classes that you will use. If you want to use the 
window background color, you can use the Background class.
  
  
  Making the parts with background color transparent would be better, right? 
That would even work on systems which don’t access the stylesheet.
  
  >> - How are the color scheme properties in the stylesheet mapped to the 
reduced breeze palette in the HIG? (I think neutral or Beware Orange do not 
clearly map.)
  > 
  > Beware Orange is just the name of a color (it's an arbitrary name). 
NeutralText is a class that maps to the Neutral Text color in your system 
colorscheme. The color of Neutral Text just happens to be Beware Orange with 
the Breeze colorscheme, but you could make it purple by changing the 
colorscheme. Since Breeze uses Beware Orange, that color must be the default 
color in the stylesheet so that the icon color looks like Breeze in non-Qt apps.
  
  So this means, changing the Neutral Text property on your system will modify 
the Beware Orange parts of breeze icons, yes? That’s what I meant with mapping.
  
  I could imagine adding this to the HIG: A table with the reduced breeze color 
palette, the color names, the corresponding color scheme entries, and the 
existing description to the color. (So only add the color scheme entry.)
  
  > If you find any more flaws in the HIG, report an issue at 
https://invent.kde.org/websites/hig-kde-org/issues
  
  Concerning margins: https://invent.kde.org/websites/hig-kde-org/issues/12
  
  > or fork, patch and merge request to submit a patch for that repo.
  
  Not today, have to leave the wall plug now... :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns


D22297: Add id="current-color-scheme" to collapse-all icons

2019-07-06 Thread David Hurka
davidhurka accepted this revision.
davidhurka added a comment.
This revision is now accepted and ready to land.


  Yes, problem solved. The icon is now visible with a dark color theme.
  
  Did not check anything else, someone with more knowledge about icons should 
do that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22297

To: nhiga, #vdg, davidhurka
Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22297: Add id="current-color-scheme" to collapse-all icons

2019-07-06 Thread David Hurka
davidhurka added a comment.


  (Added screenshots)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22297

To: nhiga, #vdg, davidhurka
Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22297: Add id="current-color-scheme" to collapse-all icons

2019-07-06 Thread David Hurka
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22297

To: nhiga, #vdg, davidhurka
Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D27983: Make find-location show a magnifier on a map, to be different to mark-location

2020-03-11 Thread David Hurka
davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This changes find-location, and adds the 22px variant.
  BUG: 407061

REPOSITORY
  R266 Breeze Icons

BRANCH
  create-find-location

REVISION DETAIL
  https://phabricator.kde.org/D27983

AFFECTED FILES
  icons-dark/actions/16/find-location.svg
  icons-dark/actions/22/find-location.svg
  icons-dark/actions/symbolic/find-location-symbolic.svg
  icons/actions/16/find-location.svg
  icons/actions/22/find-location.svg
  icons/actions/symbolic/find-location-symbolic.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27983: Make find-location show a magnifier on a map, to be different to mark-location

2020-03-11 Thread David Hurka
davidhurka edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27983

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


T11950: Reduce the pain of working on monochrome Breeze icons

2020-03-10 Thread David Hurka
davidhurka added a comment.


  Whoops, this Task went past me //while// I created breeze-icon-cleaner 
. What a pity!
  
  I think with this tool, we can check the remaining four tasks of the TODO in 
the task description. Sounds optimistic? Well...:
  
  - breeze-icon-cleaner repository has change-to-dark.pl, which converts icons 
from Breeze to Breeze-Dark. (Easy task...)
  - It doesn’t “optimize” the icons, it creates new ones which //are// optimal. 
Below is an example, so you can judge yourself.
  - It embeds the stylesheets. It doesn’t even require additional attention 
while painting the icon in Inkscape, it simply deduces the classes from the 
colors. Easier than what @mglb suggested...
  - “adjust the text”? If code alignment is meant: see below.
  

http://www.w3.org/2000/svg;>


.ColorScheme-NegativeText {
color:#da4453;
}




  
  Let me know what you think.
  
  ---
  
  By the way: Nice that someone removed all that 24px icons and wrote a script 
to generate them. Thanks, @ngraham!

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, davidhurka
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender


D27557: Auto-generate 24px monochrome icons

2020-04-07 Thread David Hurka
davidhurka added a comment.


  In D27557#616831 , @sitter wrote:
  
  >
  
  
  
  
  > - if your script is doing a lot of stuff you may want to revise how the 
script works. specifically for this diff sed needs to iter all the content of 
all the SVGs this can benefit greatly from running across multiple cores, but 
with the way it is written it cannot. a better solution would be to move the 
for loop into cmake and then construct targets for all files where each target 
calls `generate.sh inputfile` and the shell script only has the logic from 
inside the loop. this effectively gives you free "threading" in that 
cmake/make/ninja know how to run build targets in parallel so by making each 
file its own target you can now utilize all cores of a system without having to 
manage threading manually.
  
  
  
  1. I’m sure most build systems don’t run on Tianhe-2, so we don’t need one 
thread per icon.
  2. If someone uses make instead of ninja, make will take very much time to 
fire up the 2000 (11000 if we also auto-generate dark versions) threads.
  
  I think it makes more sense to define one target for every directory, and 
then 4 (43) parralel-running Python scripts iterate through their own 
directory. Then we also don’t need a for loop in cmake.
  
  By the way that inefficient shell script needs only 18 seconds on my 
slowbook. I think that is fast enough and competitively green enough, and a 
streamlined Python script will probably be even better.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: davidhurka, usta, davidre, bcooksley, kossebau, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-04-06 Thread David Hurka
davidhurka added a comment.


  Now we have less than 130 icons which are different in icons/ and 
icons-dark/, and less than 100 icons which we should keep as dark version. 
Maybe we can keep event less.
  
  I have sorted them into two files.
  
  F8221155: dark_icons_to_keep.txt 
  
  F8221154: dark_icons_to_remove.txt 

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender


T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-04-06 Thread David Hurka
davidhurka added a comment.


  @ngraham How’s your progress with the bash script? I’m currently trying to 
understand bash syntax. Maybe I can do it, if you don’t have done it already.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender


D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka retitled this revision from "Move document corner fold to top right 
in two icons

This updates document-close in the sizes below 32px and gnumeric-link-internal 
to the new style. I forgot them in D28203.
gnumeric-link-internal uses ButtonFocus." to "Move document corner fold to top 
right in two icons".
davidhurka edited the summary of this revision.
davidhurka edited the test plan for this revision.
davidhurka added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka updated this revision to Diff 80707.
davidhurka added a comment.


  - Use Highlight instead of ButtonFocus, Noah already decided that somewhere 
else

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29027?vs=80702=80707

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

AFFECTED FILES
  icons-dark/actions/16/document-close.svg
  icons-dark/actions/16/gnumeric-link-internal.svg
  icons-dark/actions/22/document-close.svg
  icons-dark/actions/22/gnumeric-link-internal.svg
  icons/actions/16/document-close.svg
  icons/actions/16/gnumeric-link-internal.svg
  icons/actions/22/document-close.svg
  icons/actions/22/gnumeric-link-internal.svg

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29027: Move document corner fold to top right in two icons

2020-04-20 Thread David Hurka
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29027: Move document corner fold to top right in two iconsThis updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203.gnumeric-link-intern

2020-04-20 Thread David Hurka
davidhurka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

AFFECTED FILES
  icons-dark/actions/16/document-close.svg
  icons-dark/actions/16/gnumeric-link-internal.svg
  icons-dark/actions/22/document-close.svg
  icons-dark/actions/22/gnumeric-link-internal.svg
  icons/actions/16/document-close.svg
  icons/actions/16/gnumeric-link-internal.svg
  icons/actions/22/document-close.svg
  icons/actions/22/gnumeric-link-internal.svg

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29027: Move document corner fold to top right in two icons

2020-04-21 Thread David Hurka
davidhurka added a comment.


  I looked at the other gnumeric icons. Those which are not a symlink use fixed 
colors, while the linked icons use Highlight. I don’t see the point to use 
fixed colors.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


T11950: Reduce the pain of working on monochrome Breeze icons

2020-03-13 Thread David Hurka
davidhurka added a comment.


  This is how my source file for find-location (D27983 
) looks in inkscape.
  
  F8174793: Screenshot_20200313_201936.png 

  
  Would it be nice to post such screenshots in Revisions, instead of 
montage-breeze-dark images? Theese are a bit redundant with automated tools. 
The screenshot would make it easy to spot pixel-misalignments.
  
  The montage-breeze output should stay, to see how the icon looks at original 
size. Or is another inkscape screenshot at original size (Key 1) sufficient?
  
  F8174818: Screenshot_20200313_203610.png 


TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, davidhurka
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender


D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread David Hurka
davidhurka added a comment.


  Cuttlefish (Ubuntu release)?
  
  So that means all icons should be changed from Highlight to ButtonFocus? That 
would also affect colorful icons. Some of them have Highlight and ButtonFocus 
in the stylesheet, fortunately with the same color.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread David Hurka
davidhurka abandoned this revision.
davidhurka added a comment.


  Ok, then I’ll let you do it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread David Hurka
davidhurka created this revision.
davidhurka added a reviewer: ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This fixes the 3 icons with blue elements, which I recently modified. I used 
ButtonFocus, but it should be Highlight.

REPOSITORY
  R266 Breeze Icons

BRANCH
  rename-buttonfocus-highlight

REVISION DETAIL
  https://phabricator.kde.org/D28553

AFFECTED FILES
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/insert-page-break.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/filename-title-amarok.svg
  icons/actions/22/insert-page-break.svg

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27983: Make find-location show a magnifier on a map, to be different to mark-location

2020-04-04 Thread David Hurka
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:aff4a3e23d92: Make find-location show a magnifier on a 
map, to be different to mark-location (authored by davidhurka).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27983?vs=77419=79269

REVISION DETAIL
  https://phabricator.kde.org/D27983

AFFECTED FILES
  icons-dark/actions/16/find-location.svg
  icons-dark/actions/22/find-location.svg
  icons-dark/actions/symbolic/find-location-symbolic.svg
  icons/actions/16/find-location.svg
  icons/actions/22/find-location.svg
  icons/actions/symbolic/find-location-symbolic.svg

To: davidhurka, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns


D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Hurka
davidhurka updated this revision to Diff 79272.
davidhurka added a comment.


  Rebase on an initial commit which points to D28203 
, not D28204 
.
  
  - link 32px document-preview-archive and document-preview
  - Move corner fold to top for 6 32px icons
  - Fix symlinks: make relative
  - Give **/acrobat.svg its fixed color back

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=78484=79272

BRANCH
  temp-2

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  

D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Hurka
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2808396a7bb8: Move corner fold to top right in 24 icons 
(authored by davidhurka).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=79272=79273

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  

D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Hurka
davidhurka added a comment.


  I created revision D28204  accidentally 
when I tried to update this revision. That made my initial commit point to 
D28204  instead of D28203 
, so I couldn’t tell arc to land //this// 
revision. So I made git commit --amend on the initial commit to change the 
revision number, and rebased the other commits on the new commit. Phabricator 
UI tells me that the patch content stayed identical, so I land this now.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Hurka
davidhurka added a comment.


  @ndavis commited (excerpt):
  
diff --git a/icons-dark/actions/22/document-export-ocal.svg 
b/icons-dark/actions/22/document-export-ocal.svg
index 4bfca303..ace4fe41 12
--- a/icons-dark/actions/22/document-export-ocal.svg
+++ b/icons-dark/actions/22/document-export-ocal.svg
@@ -1 +1 @@
-/home/david/kde/breeze-icons/icons-dark/actions/22/document-export.svg
\ No newline at end of file
+document-export.svg
\ No newline at end of file
  
  Yep, apparently you found the problem faster than me. :) I thought I fixed 
all the symlinks, wasn’t the case... Thanks for fixing my mess!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns


D28561: Remove border from format-border-set-* icons

2020-04-04 Thread David Hurka
davidhurka added a comment.


  There are 22px versions of these icons. They passed the auto-generation, 
because they use a different approach. They have a border, but it is not in 
ViewBackground, but in Text with transparency 0.1. Should I add such a border 
to the 16px version, or remove it in the 22px version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28561: Remove border from format-border-set-* icons

2020-04-04 Thread David Hurka
davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  These icons had a kind of border in ViewBackground color, which made them 
look a bit strange. I don’t know whether that was intended.
  But with swap_colors.sed (T12855 ), the 
generated dark version didn’t match the original dark version.
  So I removed the ViewBackground elements.
  
  - set-bottom and set-internal didn’t have this border, but they had elements 
outside the canvas (actually the border), which are removed now.
  - set-internal also had one element outside the canvas.
  - set-internal-vertical had the vertical edge outside the canvas. I fixed 
that.
  - set-none had all outer edges, so it was identical to set-all. I removed the 
edges, because it should probably have “none” edges.
  - set-all does not need fixing.
  
  Screenshots:
  Before: Light and dark versions have the ViewBackground border.
  
  In the autogenerated dark version, the border looks different.
  
  After: No border in light version and autogenerated dark version.
  
  Template file. Cyan is a proxy color for ColorScheme-Text with transparency 
0.5.

REPOSITORY
  R266 Breeze Icons

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

AFFECTED FILES
  icons-dark/actions/16/format-border-set-bottom.svg
  icons-dark/actions/16/format-border-set-diagonal-bl-tr.svg
  icons-dark/actions/16/format-border-set-diagonal-tl-br.svg
  icons-dark/actions/16/format-border-set-external.svg
  icons-dark/actions/16/format-border-set-internal-horizontal.svg
  icons-dark/actions/16/format-border-set-internal-vertical.svg
  icons-dark/actions/16/format-border-set-internal.svg
  icons-dark/actions/16/format-border-set-left.svg
  icons-dark/actions/16/format-border-set-none.svg
  icons-dark/actions/16/format-border-set-right.svg
  icons-dark/actions/16/format-border-set-top.svg
  icons/actions/16/format-border-set-bottom.svg
  icons/actions/16/format-border-set-diagonal-bl-tr.svg
  icons/actions/16/format-border-set-diagonal-tl-br.svg
  icons/actions/16/format-border-set-external.svg
  icons/actions/16/format-border-set-internal-horizontal.svg
  icons/actions/16/format-border-set-internal-vertical.svg
  icons/actions/16/format-border-set-internal.svg
  icons/actions/16/format-border-set-left.svg
  icons/actions/16/format-border-set-none.svg
  icons/actions/16/format-border-set-right.svg
  icons/actions/16/format-border-set-top.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28561: Remove border from format-border-set-* icons

2020-04-04 Thread David Hurka
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28561: Remove border from format-border-set-* icons

2020-04-05 Thread David Hurka
davidhurka updated this revision to Diff 79386.
davidhurka added a comment.


  - Remove border elements in 22px versions of format-border-*
  
  I would like if you accept this new patch version, to be formally correct.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28561?vs=79303=79386

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

AFFECTED FILES
  icons-dark/actions/16/format-border-set-bottom.svg
  icons-dark/actions/16/format-border-set-diagonal-bl-tr.svg
  icons-dark/actions/16/format-border-set-diagonal-tl-br.svg
  icons-dark/actions/16/format-border-set-external.svg
  icons-dark/actions/16/format-border-set-internal-horizontal.svg
  icons-dark/actions/16/format-border-set-internal-vertical.svg
  icons-dark/actions/16/format-border-set-internal.svg
  icons-dark/actions/16/format-border-set-left.svg
  icons-dark/actions/16/format-border-set-none.svg
  icons-dark/actions/16/format-border-set-right.svg
  icons-dark/actions/16/format-border-set-top.svg
  icons-dark/actions/22/format-border-set-bottom.svg
  icons-dark/actions/22/format-border-set-diagonal-bl-tr.svg
  icons-dark/actions/22/format-border-set-diagonal-tl-br.svg
  icons-dark/actions/22/format-border-set-external.svg
  icons-dark/actions/22/format-border-set-internal-horizontal.svg
  icons-dark/actions/22/format-border-set-internal-vertical.svg
  icons-dark/actions/22/format-border-set-internal.svg
  icons-dark/actions/22/format-border-set-left.svg
  icons-dark/actions/22/format-border-set-none.svg
  icons-dark/actions/22/format-border-set-right.svg
  icons-dark/actions/22/format-border-set-top.svg
  icons/actions/16/format-border-set-bottom.svg
  icons/actions/16/format-border-set-diagonal-bl-tr.svg
  icons/actions/16/format-border-set-diagonal-tl-br.svg
  icons/actions/16/format-border-set-external.svg
  icons/actions/16/format-border-set-internal-horizontal.svg
  icons/actions/16/format-border-set-internal-vertical.svg
  icons/actions/16/format-border-set-internal.svg
  icons/actions/16/format-border-set-left.svg
  icons/actions/16/format-border-set-none.svg
  icons/actions/16/format-border-set-right.svg
  icons/actions/16/format-border-set-top.svg
  icons/actions/22/format-border-set-bottom.svg
  icons/actions/22/format-border-set-diagonal-bl-tr.svg
  icons/actions/22/format-border-set-diagonal-tl-br.svg
  icons/actions/22/format-border-set-external.svg
  icons/actions/22/format-border-set-internal-horizontal.svg
  icons/actions/22/format-border-set-internal-vertical.svg
  icons/actions/22/format-border-set-internal.svg
  icons/actions/22/format-border-set-left.svg
  icons/actions/22/format-border-set-none.svg
  icons/actions/22/format-border-set-right.svg
  icons/actions/22/format-border-set-top.svg

To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28561: Remove border from format-border-set-* icons

2020-04-05 Thread David Hurka
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28561: Remove border from format-border-set-* icons

2020-04-05 Thread David Hurka
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:07487651e13c: Remove border from format-border-set-* 
icons (authored by davidhurka).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28561?vs=79386=79393

REVISION DETAIL
  https://phabricator.kde.org/D28561

AFFECTED FILES
  icons-dark/actions/16/format-border-set-bottom.svg
  icons-dark/actions/16/format-border-set-diagonal-bl-tr.svg
  icons-dark/actions/16/format-border-set-diagonal-tl-br.svg
  icons-dark/actions/16/format-border-set-external.svg
  icons-dark/actions/16/format-border-set-internal-horizontal.svg
  icons-dark/actions/16/format-border-set-internal-vertical.svg
  icons-dark/actions/16/format-border-set-internal.svg
  icons-dark/actions/16/format-border-set-left.svg
  icons-dark/actions/16/format-border-set-none.svg
  icons-dark/actions/16/format-border-set-right.svg
  icons-dark/actions/16/format-border-set-top.svg
  icons-dark/actions/22/format-border-set-bottom.svg
  icons-dark/actions/22/format-border-set-diagonal-bl-tr.svg
  icons-dark/actions/22/format-border-set-diagonal-tl-br.svg
  icons-dark/actions/22/format-border-set-external.svg
  icons-dark/actions/22/format-border-set-internal-horizontal.svg
  icons-dark/actions/22/format-border-set-internal-vertical.svg
  icons-dark/actions/22/format-border-set-internal.svg
  icons-dark/actions/22/format-border-set-left.svg
  icons-dark/actions/22/format-border-set-none.svg
  icons-dark/actions/22/format-border-set-right.svg
  icons-dark/actions/22/format-border-set-top.svg
  icons/actions/16/format-border-set-bottom.svg
  icons/actions/16/format-border-set-diagonal-bl-tr.svg
  icons/actions/16/format-border-set-diagonal-tl-br.svg
  icons/actions/16/format-border-set-external.svg
  icons/actions/16/format-border-set-internal-horizontal.svg
  icons/actions/16/format-border-set-internal-vertical.svg
  icons/actions/16/format-border-set-internal.svg
  icons/actions/16/format-border-set-left.svg
  icons/actions/16/format-border-set-none.svg
  icons/actions/16/format-border-set-right.svg
  icons/actions/16/format-border-set-top.svg
  icons/actions/22/format-border-set-bottom.svg
  icons/actions/22/format-border-set-diagonal-bl-tr.svg
  icons/actions/22/format-border-set-diagonal-tl-br.svg
  icons/actions/22/format-border-set-external.svg
  icons/actions/22/format-border-set-internal-horizontal.svg
  icons/actions/22/format-border-set-internal-vertical.svg
  icons/actions/22/format-border-set-internal.svg
  icons/actions/22/format-border-set-left.svg
  icons/actions/22/format-border-set-none.svg
  icons/actions/22/format-border-set-right.svg
  icons/actions/22/format-border-set-top.svg

To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-25 Thread David Hurka
davidhurka marked 3 inline comments as done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-25 Thread David Hurka
davidhurka added inline comments.

INLINE COMMENTS

> ngraham wrote in acrobat.svg:2
> Yeah probably. The color is intrinsic to their brand, not something we should 
> re-color.

Actually the 16px version of acrobat.svg //was// recolored by 
colorScheme-Negative. I will set the color fixed anyway.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-25 Thread David Hurka
davidhurka updated this revision to Diff 78484.
davidhurka added a comment.


  - Give **/acrobat.svg its fixed color back

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=78459=78484

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  icons/actions/22/filename-group-tracks.svg
  icons/actions/22/filename-title-amarok.svg
  

D28203: Move corner fold to top right in 24 icons

2020-03-26 Thread David Hurka
davidhurka added a comment.


  I would need a developer account to land this. Same for D27983 
 I assume?

REPOSITORY
  R266 Breeze Icons

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D28323: Fix some stylesheet colors in 2 icon files

2020-03-26 Thread David Hurka
davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This fixes two tiny inconsistencies in existing icon files in icons/.
  In the stylesheet they have #232627 for ColorScheme-Text.
  Now they use #232629, like in all other icon files.
  
  This inconsistency wasn’t a problem until now,
  but would make it difficult to auto-generate icons-dark/ from icons.
  The key in auto-generating is to substitute the colors in the stylesheets,
  so the stylesheets need to have the correct colors.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-some-stylesheet-colors

REVISION DETAIL
  https://phabricator.kde.org/D28323

AFFECTED FILES
  icons/status/22/TeamViewer.svg
  icons/status/22/flameshot-tray.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-03-25 Thread David Hurka
davidhurka added a comment.


  Can you write a bash script which copies the icon files to icons-dark/ and 
substitutes the colors? Apparently you know how to do that, my bash skills are 
a bit worse.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender


T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-03-25 Thread David Hurka
davidhurka added a comment.


  I have created montages of the different icons. The original files to the 
left, the generated to the right. (Hover the images to see the file path)
  
  There are false positives:
  F8199094: categories_32_applications-development.png 

  
  Many have title bar buttons or panel buttons which should not be recolored:
  F8199096: categories_32_applications-engineering.png 

  F8199101: devices_64_computer.png 
  
  Many have more subtle differences (look at the screws):
  F8199104: devices_64_drive-partition.png 

  
  Many have big differences (which can maybe be avoided by improving the color 
substitution):
  F8199106: devices_64_network-rj45-female.png 

  
  Sometimes the generated ones look better (debatable):
  F8199111: emblems_22_rating.png 
  F8199113: actions_32_cursor-cross.png 
  
  In some icons I don’t see whether the difference is intended (look at the 
border):
  F8199116: actions_16_format-border-set-left.png 

  
  The script takes the output file of compare-dark-light.pl as argument. First 
you need to create the directory montages/.
  F8199092: montage-apparently-different-icons.pl 


TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender


T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-03-26 Thread David Hurka
davidhurka added a comment.


  By the way I looked through the 319 icons.
  
  - Some icons actually need fixing in icons/.
  - The emblem rating is blue in icons-dark/, because it links to another 
class. We can:
- Leave rating in icons-dark/
- Change the light version to be blue too
  - (Probably) All mimetype icons in size 32px and 64px look significantly 
different in light and dark

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender


T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-03-26 Thread David Hurka
davidhurka added a comment.


  I have to take some short notes here.
  
  I have written a .sed script which we can use to convert icons/ files to 
icons-dark/ files. It does the same substitutions as my perl script above, but 
matches only in the stylesheet. That means, fixed colors will not be changed. 
That should fix things like this: F8199106: devices_64_network-rj45-female.png 

  
  The script must be called with the -E option, because it uses new POSIX 
regexes.
  
$ sed -E -f swap_colors.sed -i file/to-change.svg
  
  F8200468: swap_colors.sed 
  Of course you may give it a better name.
  
  Open questions are:
  
  - The icons in applets/ use #314045 as ColorScheme-ViewBackground, altough 
Icon_Workflow_Tips defines #232629. I think it should really be #232629, 
because that is the color which is actually used by the Breeze Dark theme. 
swap_colors.sed substitutes to #232629. The following picture illustrates what 
that means: (Auto-generated left, original right) F8200470: montage.png 
 I think we can do it how swap_colors.sed 
does it now, and get rid of icons-dark/applets/.
  - Icon_Workflow_Tips defines #232629 for ColorScheme-Text, but many icons 
have #4d4d4d as ColorScheme-Text, for example those in icons/applets/, but also 
some in icons-dark/actions/. The latter is a mistake which will be fixed by 
auto-generating. The former is currently respected by swap_colors.sed, and 
auto-generated icons correspond to those in icons-dark. (I think the icons 
should actually use #232629, but than can be fixed independently.)
  
  Next steps:
  
  - Run the compare-dark-light.pl again with the new swap_colors.sed script, to 
be sure it does color swapping fine now.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender


D28203: Move corner fold to top right in 24 icons

2020-03-25 Thread David Hurka
davidhurka updated this revision to Diff 78459.
davidhurka added a comment.


  - Fix symlinks: make relative

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=78305=78459

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  icons/actions/22/filename-group-tracks.svg
  icons/actions/22/filename-title-amarok.svg
  

D28203: Move corner fold to top right in 24 icons

2020-03-25 Thread David Hurka
davidhurka marked an inline comment as done.
davidhurka added inline comments.

INLINE COMMENTS

> acrobat.svg:2
> -http://www.w3.org/2000/svg; width="22" height="22">
> - 
> -

I realize that acrobat.svg had a fixed color, which I mistakenly replaced by 
colorScheme-Negative. Shall I change that back?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-03-27 Thread David Hurka
davidhurka added a comment.


  Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 
50% transparency, while rating has 100% opacity? That makes my compare script 
go wild, and I think it doesn’t look intended.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender


D28362: Fix stylesheet linking in 8 icons

2020-03-27 Thread David Hurka
davidhurka updated this revision to Diff 78701.
davidhurka added a subscriber: ndavis.
davidhurka added a comment.


  @ndavis

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28362?vs=78700=78701

BRANCH
  fix-some-style-attributes

REVISION DETAIL
  https://phabricator.kde.org/D28362

AFFECTED FILES
  icons/actions/16/distribute-vertical-center.svg
  icons/actions/16/edit-clear-locationbar-ltr.svg
  icons/actions/16/mail-reply-all.svg
  icons/actions/22/distribute-vertical-center.svg
  icons/actions/22/edit-clear-locationbar-ltr.svg
  icons/actions/22/kstars_supernovae.svg
  icons/actions/symbolic/list-remove-symbolic.svg
  icons/devices/16/network-wireless-connected-25.svg

To: davidhurka
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28362: Fix stylesheet linking in 8 icons

2020-03-27 Thread David Hurka
davidhurka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  These 8 icons were (partially) not recolored by the stylesheet, because their 
elements were either not linked to the stylesheet, or had contradicting style 
information.
  This adds the missing class attributes and removes the wrong color 
definitions in the style attributes.
  
  Furthermore, I would like to know why 
icons/actions/symbolic/list-remove-symbolic.svg has an additional stylesheet 
“current-color-scheme-6”. Is that information available?

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-some-style-attributes

REVISION DETAIL
  https://phabricator.kde.org/D28362

AFFECTED FILES
  icons/actions/16/distribute-vertical-center.svg
  icons/actions/16/edit-clear-locationbar-ltr.svg
  icons/actions/16/mail-reply-all.svg
  icons/actions/22/distribute-vertical-center.svg
  icons/actions/22/edit-clear-locationbar-ltr.svg
  icons/actions/22/kstars_supernovae.svg
  icons/actions/symbolic/list-remove-symbolic.svg
  icons/devices/16/network-wireless-connected-25.svg

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28362: Fix stylesheet linking in 8 icons

2020-03-27 Thread David Hurka
davidhurka updated this revision to Diff 78702.
davidhurka added a comment.


  - Fix spelling

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28362?vs=78701=78702

BRANCH
  fix-some-style-attributes

REVISION DETAIL
  https://phabricator.kde.org/D28362

AFFECTED FILES
  icons/actions/16/distribute-vertical-center.svg
  icons/actions/16/edit-clear-locationbar-ltr.svg
  icons/actions/16/mail-reply-all.svg
  icons/actions/22/distribute-vertical-center.svg
  icons/actions/22/edit-clear-locationbar-ltr.svg
  icons/actions/22/kstars_supernovae.svg
  icons/actions/symbolic/list-remove-symbolic.svg
  icons/devices/16/network-wireless-connected-25.svg

To: davidhurka
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28203: Move corner fold to top right in 24 icons

2020-03-28 Thread David Hurka
davidhurka requested review of this revision.
davidhurka added a comment.


  One potentially important thing: See inline comment.

INLINE COMMENTS

> filename-title-amarok.svg:8
> +}
> +.ColorScheme-ButtonFocus {
> +color:#3daee9;

I realized that http://notmart.org/blog/2016/05/icon-colors/ and 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets 
contratict in the class names. One uses `ColorScheme-Highlight`, the other 
`ColorScheme-ButtonFocus`. breeze-icon-cleaner uses `ColorScheme-ButtonFocus`. 
In the repository I see several icons which use `ColorScheme-Highlight`, and 
only a few which use `ColorScheme-ButtonFocus`.

So which one is correct? I assume that 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets 
needs to be fixed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D29163: WIP: Add document-replace icon (Like for Overwrite action)

2020-04-24 Thread David Hurka
davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This adds an icon document-replace in 16px, 22px, and 32px size,
  which can be used for the overwrite confirmation box of the Save As dialog.

REPOSITORY
  R266 Breeze Icons

BRANCH
  create-document-replace

REVISION DETAIL
  https://phabricator.kde.org/D29163

AFFECTED FILES
  document-replace.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29163: WIP: Add document-replace icon (Like for Overwrite action)

2020-04-24 Thread David Hurka
davidhurka planned changes to this revision.
davidhurka added a comment.


  The current state is as follows:
  F8258336: image.png 
  F8258342: image.png 
  
  All paper sheets are shrunken by 2px, and 16px and 32px got a smaller corner 
fold to look proportional.
  
  The 16px black sheet got its original corner fold back, because it looked too 
small otherwise.
  
  I would like some feedback
  
  - on the overall icon idea
  - Whether I should connect the red sheet to the black sheet. Usually there is 
1px margin arround emblems, but in this case the sheets have different color, 
so no margin would theoretically be possible.
  
  Without margin:
  F8258350: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29163

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29163: RFC: Add document-replace icon (Like for Overwrite action)

2020-04-24 Thread David Hurka
davidhurka retitled this revision from "WIP: Add document-replace icon (Like 
for Overwrite action)" to "RFC: Add document-replace icon (Like for Overwrite 
action)".
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29163

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29027: Move document corner fold to top right in two icons

2020-04-29 Thread David Hurka
davidhurka added a comment.


  Is it possible to land this without arc? I can’t get arc running on my 
current system. :(
  
  If you want this in the next release, you too may land it for me. Otherwise I 
will land it when I have my own system back, i. e. in a few weeks.
  
  I will change the other gnumeric icons to use Highlight instead of a fixed 
color later.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29163: RFC: Add document-replace icon (Like for Overwrite action)

2020-04-29 Thread David Hurka
davidhurka added a comment.


  Then I will remove the border. I think it looks slightly better, because the 
bottom-left corner is visible this way; and the 16px version looks to chunky 
otherwise.
  
  I will update this revision when I have my system back. Otherwise, anyone 
else may take the template file from this revision and update it. Command would 
be:
  
$ breeze-icon-cleaner -s '16 22 32' -n 'document-replace' 
document-replace.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29163

To: davidhurka, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D28203: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

2020-03-22 Thread David Hurka
davidhurka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  icons/actions/22/filename-group-tracks.svg
  icons/actions/22/filename-title-amarok.svg
  icons/actions/22/fork.svg
  icons/actions/22/gnumeric-pagesetup-hf-page.svg
  icons/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons/actions/22/insert-page-break.svg
  icons/actions/22/password-copy.svg
  icons/actions/22/restoration.svg

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

2020-03-22 Thread David Hurka
davidhurka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28204

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  icons/actions/22/filename-group-tracks.svg
  icons/actions/22/filename-title-amarok.svg
  icons/actions/22/fork.svg
  icons/actions/22/gnumeric-pagesetup-hf-page.svg
  icons/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons/actions/22/insert-page-break.svg
  icons/actions/22/password-copy.svg
  icons/actions/22/restoration.svg

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

2020-03-22 Thread David Hurka
davidhurka abandoned this revision.
davidhurka added a comment.


  Whoops duplicate.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28204

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-22 Thread David Hurka
davidhurka retitled this revision from "Move corner fold to top right in 24 
icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 
icons (dark and light), make 24px symlink versions of 30icons (dark and light)" 
to "Move corner fold to top right in 24 icons".
davidhurka edited the summary of this revision.
davidhurka edited the test plan for this revision.
davidhurka added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-22 Thread David Hurka
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-23 Thread David Hurka
davidhurka added a comment.


  I understand the concerns. It looks unbalanced. But these icons also look 
unbalanced now: acrobat, filename-title-amarok.
  
  By the way I changed the arrow of document-export to point //outwards// the 
document, not inwards. That often confused me in inkscape, where both icons are 
used next to each other.
  
  document-edit-encrypt and -decrypt are swapped now. Maybe that could confuse 
users who are used to look at the corner fold.
  
  And insert-page-break looses the metaphor of “a break in the page”, but I 
think that’s ok.
  
  I wasn’t aware that there are still 32px monochrome icons. I will fix that. 
Didn’t we want to drop them?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

2020-03-23 Thread David Hurka
davidhurka updated this revision to Diff 78304.
davidhurka added a comment.


  - link 32px document-preview-archive and document-preview
  - Move corner fold to top for 6 32px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28204?vs=78231=78304

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28204

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

2020-03-23 Thread David Hurka
davidhurka abandoned this revision.
davidhurka added a comment.


  garg.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28204

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-23 Thread David Hurka
davidhurka added a comment.


  There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 
16px. There are 1561 icons in 22px but not in 32px, and 9 icons in 32px but not 
in 22px. What are 12px and 32px good for?
  
  I fixed the 6 32px icons which had the old style. 2 additional 32px icons 
already had the corner fold in the top: document-edit-sign, document-preview. I 
linked document-preview and document-preview-archive.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D28203: Move corner fold to top right in 24 icons

2020-03-23 Thread David Hurka
davidhurka updated this revision to Diff 78305.
davidhurka added a comment.


  - link 32px document-preview-archive and document-preview
  - Move corner fold to top for 6 32px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=78230=78305

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  

D29163: RFC: Add document-replace icon (Like for Overwrite action)

2020-07-11 Thread David Hurka
davidhurka abandoned this revision.
davidhurka added a comment.


  Moved to https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/18

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29163

To: davidhurka, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns