[Kicad-developers] Hard coded hotkeys

[hauptmech]

Jon Evans, Kristoffer Ödmark, John Beard, and maybe Tomasz Włostowski

I filed a bug report for the temporary hard-coded hotkeys that have not 
been cleaned up. I'm super motivated to not have them in 5 so if you 
can't get to it let me know and I'll see if I can figure out how to do it.


-hauptmech






___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH/RFC] Eeschema menubar

[Wayne Stambaugh]

Michael,

I merged your patches.  Thank you for your contribution to KiCad.

Cheers,

Wayne

On 02/22/2018 02:28 PM, Michael Kavanagh wrote:

You guessed it. Also some very minor modifications to the Kicad manager menubar.

Cheers,
Michael



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[José Ignacio]

I couldn't find it so I reported
https://bugs.launchpad.net/kicad/+bug/1751171

On Thu, Feb 22, 2018 at 6:34 PM, Jon Evans  wrote:

> Is there already a bug report for that?  We should make sure to keep track
> of all this so if someone has time to do some kind of settings-saving
> overhaul for V6 we catch all of that stuff.
>
> On Thu, Feb 22, 2018 at 7:31 PM, José Ignacio 
> wrote:
>
>> One thing that is very inconsistent is that layer settings for plotting
>> gerbers are saved in the board file (as they should), but settings for the
>> drill file are saved in the global kicad settings (which means that if i
>> have two different projects that need different drill settings i need to
>> remember to change them back and forth). In an ideal world those settings
>> would be saved in a CAM file with the project, but having them saved in the
>> board file is the second best.
>>
>> On Thu, Feb 22, 2018 at 3:28 PM, Eeli Kaikkonen > > wrote:
>>
>>>
>>>
>>> 2018-02-22 23:05 GMT+02:00 Tiger12506 :
>>>
 I agree 100% on separate file. As someone who puts kicad files in git,
 the most irritating thing in the world is having unrelated changes in your
 diff. Separate file gives you the flexibility to have either situation --
 if you want the vcs to track it, you include the file, if you don't, your
 vcs ignores the file. It's unfortunate that there are already UI states in
 any of the files that represent a design.

 Cheers. :)


>>> I agree, too. As a both end user and someone who has studied usability I
>>> know the current situation creates unnecessary cognitive and emotinal
>>> stress for the end user. Many times a user can't be sure or can't remember
>>> what he/she actually did or if he did something by accident. Seeing the
>>> message that something was changed is disturbing because you can't know
>>> what happened and what will be saved. If the non-design-related data would
>>> be in a separate file it wouldn't even have to be asked about IMO because
>>> it's safe to save always, it's not critical data in any way.
>>>
>>> But about the compatibility between versions - what kind of
>>> compatibility would be needed? I just tried deleting the layers section
>>> from a board file. Pcbnew opened it happily. So, let's suppose v5.1 is
>>> released later with this change in file format: extra data is not stored in
>>> the kicad_pcb file but in another file. If the project is created with 5.1
>>> then 5.0 can read it, it just doesn't restore the layer visibility. How
>>> serious would that be? If the project was created with 5.0, then 5.1 could
>>> also handle it (if the code which reads the file wasn't changed). It could
>>> either save the data in the compatible way or take it off from the design
>>> file and move it to the other file.
>>>
>>> How KiCad reacts to removing other non-design data from the file, I
>>> don't know.
>>>
>>> Eeli Kaikkonen
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Clear out old layer data when loading on top of an existing image

[Jon Evans]

Fixes: https://bugs.launchpad.net/kicad/+bug/1747443

-Jon
From 781adc8252bace405d30ba9e8878265fac73be4e Mon Sep 17 00:00:00 2001
From: Jon Evans 
Date: Thu, 22 Feb 2018 19:31:51 -0500
Subject: [PATCH] Clear out old layer data when loading on top of an existing
 image

Fixes: lp:1747443
* https://bugs.launchpad.net/kicad/+bug/1747443
---
 gerbview/excellon_read_drill_file.cpp | 24 +++-
 gerbview/readgerb.cpp |  4 
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/gerbview/excellon_read_drill_file.cpp b/gerbview/excellon_read_drill_file.cpp
index 8895ff394..f444de64c 100644
--- a/gerbview/excellon_read_drill_file.cpp
+++ b/gerbview/excellon_read_drill_file.cpp
@@ -163,12 +163,19 @@ bool GERBVIEW_FRAME::Read_EXCELLON_File( const wxString& aFullFileName )
 wxString msg;
 int layerId = GetActiveLayer();  // current layer used in GerbView
 GERBER_FILE_IMAGE_LIST* images = GetGerberLayout()->GetImagesList();
-EXCELLON_IMAGE* drill_Layer = (EXCELLON_IMAGE*) images->GetGbrImage( layerId );
+auto gerber_layer = images->GetGbrImage( layerId );
+auto drill_layer = dynamic_cast( gerber_layer );
 
-if( drill_Layer == NULL )
+if( gerber_layer && !drill_layer )
 {
-drill_Layer = new EXCELLON_IMAGE( layerId );
-layerId = images->AddGbrImage( drill_Layer, layerId );
+// The active layer contains old gerber data we have to clear
+Erase_Current_DrawLayer( false );
+}
+
+if( drill_layer == nullptr )
+{
+drill_layer = new EXCELLON_IMAGE( layerId );
+layerId = images->AddGbrImage( drill_layer, layerId );
 }
 
 if( layerId < 0 )
@@ -178,7 +185,7 @@ bool GERBVIEW_FRAME::Read_EXCELLON_File( const wxString& aFullFileName )
 }
 
 // Read the Excellon drill file:
-bool success = drill_Layer->LoadFile( aFullFileName );
+bool success = drill_layer->LoadFile( aFullFileName );
 
 if( !success )
 {
@@ -188,14 +195,13 @@ bool GERBVIEW_FRAME::Read_EXCELLON_File( const wxString& aFullFileName )
 }
 
 // Display errors list
-if( drill_Layer->GetMessages().size() > 0 )
+if( drill_layer->GetMessages().size() > 0 )
 {
 HTML_MESSAGE_BOX dlg( this, _( "Error reading EXCELLON drill file" ) );
-dlg.ListSet( drill_Layer->GetMessages() );
+dlg.ListSet( drill_layer->GetMessages() );
 dlg.ShowModal();
 }
 
-// TODO(JE) Is this the best place to add items to the view?
 if( success )
 {
 EDA_DRAW_PANEL_GAL* canvas = GetGalCanvas();
@@ -204,7 +210,7 @@ bool GERBVIEW_FRAME::Read_EXCELLON_File( const wxString& aFullFileName )
 {
 KIGFX::VIEW* view = canvas->GetView();
 
-for( GERBER_DRAW_ITEM* item = drill_Layer->GetItemsList(); item; item = item->Next() )
+for( GERBER_DRAW_ITEM* item = drill_layer->GetItemsList(); item; item = item->Next() )
 {
 view->Add( (KIGFX::VIEW_ITEM*) item );
 }
diff --git a/gerbview/readgerb.cpp b/gerbview/readgerb.cpp
index 293c4a40e..f3209bf5c 100644
--- a/gerbview/readgerb.cpp
+++ b/gerbview/readgerb.cpp
@@ -50,6 +50,10 @@ bool GERBVIEW_FRAME::Read_GERBER_File( const wxString& GERBER_FullFileName )
 gerber = new GERBER_FILE_IMAGE( layer );
 images->AddGbrImage( gerber, layer );
 }
+else
+{
+Erase_Current_DrawLayer( false );
+}
 
 /* Read the gerber file */
 bool success = gerber->LoadGerberFile( GERBER_FullFileName );
-- 
2.14.1

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Jon Evans]

Is there already a bug report for that?  We should make sure to keep track
of all this so if someone has time to do some kind of settings-saving
overhaul for V6 we catch all of that stuff.

On Thu, Feb 22, 2018 at 7:31 PM, José Ignacio  wrote:

> One thing that is very inconsistent is that layer settings for plotting
> gerbers are saved in the board file (as they should), but settings for the
> drill file are saved in the global kicad settings (which means that if i
> have two different projects that need different drill settings i need to
> remember to change them back and forth). In an ideal world those settings
> would be saved in a CAM file with the project, but having them saved in the
> board file is the second best.
>
> On Thu, Feb 22, 2018 at 3:28 PM, Eeli Kaikkonen 
> wrote:
>
>>
>>
>> 2018-02-22 23:05 GMT+02:00 Tiger12506 :
>>
>>> I agree 100% on separate file. As someone who puts kicad files in git,
>>> the most irritating thing in the world is having unrelated changes in your
>>> diff. Separate file gives you the flexibility to have either situation --
>>> if you want the vcs to track it, you include the file, if you don't, your
>>> vcs ignores the file. It's unfortunate that there are already UI states in
>>> any of the files that represent a design.
>>>
>>> Cheers. :)
>>>
>>>
>> I agree, too. As a both end user and someone who has studied usability I
>> know the current situation creates unnecessary cognitive and emotinal
>> stress for the end user. Many times a user can't be sure or can't remember
>> what he/she actually did or if he did something by accident. Seeing the
>> message that something was changed is disturbing because you can't know
>> what happened and what will be saved. If the non-design-related data would
>> be in a separate file it wouldn't even have to be asked about IMO because
>> it's safe to save always, it's not critical data in any way.
>>
>> But about the compatibility between versions - what kind of compatibility
>> would be needed? I just tried deleting the layers section from a board
>> file. Pcbnew opened it happily. So, let's suppose v5.1 is released later
>> with this change in file format: extra data is not stored in the kicad_pcb
>> file but in another file. If the project is created with 5.1 then 5.0 can
>> read it, it just doesn't restore the layer visibility. How serious would
>> that be? If the project was created with 5.0, then 5.1 could also handle it
>> (if the code which reads the file wasn't changed). It could either save the
>> data in the compatible way or take it off from the design file and move it
>> to the other file.
>>
>> How KiCad reacts to removing other non-design data from the file, I don't
>> know.
>>
>> Eeli Kaikkonen
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[José Ignacio]

One thing that is very inconsistent is that layer settings for plotting
gerbers are saved in the board file (as they should), but settings for the
drill file are saved in the global kicad settings (which means that if i
have two different projects that need different drill settings i need to
remember to change them back and forth). In an ideal world those settings
would be saved in a CAM file with the project, but having them saved in the
board file is the second best.

On Thu, Feb 22, 2018 at 3:28 PM, Eeli Kaikkonen 
wrote:

>
>
> 2018-02-22 23:05 GMT+02:00 Tiger12506 :
>
>> I agree 100% on separate file. As someone who puts kicad files in git,
>> the most irritating thing in the world is having unrelated changes in your
>> diff. Separate file gives you the flexibility to have either situation --
>> if you want the vcs to track it, you include the file, if you don't, your
>> vcs ignores the file. It's unfortunate that there are already UI states in
>> any of the files that represent a design.
>>
>> Cheers. :)
>>
>>
> I agree, too. As a both end user and someone who has studied usability I
> know the current situation creates unnecessary cognitive and emotinal
> stress for the end user. Many times a user can't be sure or can't remember
> what he/she actually did or if he did something by accident. Seeing the
> message that something was changed is disturbing because you can't know
> what happened and what will be saved. If the non-design-related data would
> be in a separate file it wouldn't even have to be asked about IMO because
> it's safe to save always, it's not critical data in any way.
>
> But about the compatibility between versions - what kind of compatibility
> would be needed? I just tried deleting the layers section from a board
> file. Pcbnew opened it happily. So, let's suppose v5.1 is released later
> with this change in file format: extra data is not stored in the kicad_pcb
> file but in another file. If the project is created with 5.1 then 5.0 can
> read it, it just doesn't restore the layer visibility. How serious would
> that be? If the project was created with 5.0, then 5.1 could also handle it
> (if the code which reads the file wasn't changed). It could either save the
> data in the compatible way or take it off from the design file and move it
> to the other file.
>
> How KiCad reacts to removing other non-design data from the file, I don't
> know.
>
> Eeli Kaikkonen
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Fix assert on GerbView launch

[Jon Evans]

Fixing a small bug in my recently-merged patch
That'll teach me to try to do 3 things at once ;-)
From 08ab7228870df603589c8f476c704b0435fd43fa Mon Sep 17 00:00:00 2001
From: Jon Evans 
Date: Thu, 22 Feb 2018 19:14:27 -0500
Subject: [PATCH] Fix assert on GerbView launch

---
 pcbnew/layer_widget.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pcbnew/layer_widget.h b/pcbnew/layer_widget.h
index e80206110..532e296bd 100644
--- a/pcbnew/layer_widget.h
+++ b/pcbnew/layer_widget.h
@@ -103,6 +103,7 @@ public:
 state   = aState;
 tooltip = aTooltip;
 changeable = aChangeable;
+spacer = false;
 }
 
 ROW()
-- 
2.14.1

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Jon Evans]

Here are two more quick patches addressing some of the easier changes.
I have some other bugs to look at that seem more urgent, so I'm not going
to work on the right-click menu or settings persistence.

Thanks,
Jon

On Thu, Feb 22, 2018 at 6:15 PM, Wayne Stambaugh 
wrote:

> Patch merged.  Thanks.
>
>
> On 02/21/2018 11:39 PM, Jon Evans wrote:
>
>> Hi all,
>>
>> This patch rearranges the Render panel to be in a more logical order, and
>> adds some whitespace.
>> I divided it into three groupings:
>> 1) footprint related
>> 2) other board objects
>> 3) non-board stuff like grid, ratlines, etc.
>>
>> I also bumped out the default size so that scrollbars aren't needed by
>> default on my Linux system.
>>
>> -Jon
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
From f68aef258199e963401fb0829f50639bd6f06048 Mon Sep 17 00:00:00 2001
From: Jon Evans 
Date: Thu, 22 Feb 2018 19:02:20 -0500
Subject: [PATCH 2/2] Only show microvia and blind/buried via settings if they
 are enabled

---
 pcbnew/pcb_edit_frame.cpp   |  1 +
 pcbnew/pcb_layer_widget.cpp | 10 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/pcbnew/pcb_edit_frame.cpp b/pcbnew/pcb_edit_frame.cpp
index 682d6da8f..dd3c79398 100644
--- a/pcbnew/pcb_edit_frame.cpp
+++ b/pcbnew/pcb_edit_frame.cpp
@@ -828,6 +828,7 @@ void PCB_EDIT_FRAME::ShowDesignRulesEditor( wxCommandEvent& event )
 {
 ReCreateLayerBox();
 ReCreateAuxiliaryToolbar();
+m_Layers->ReFillRender();
 OnModify();
 }
 }
diff --git a/pcbnew/pcb_layer_widget.cpp b/pcbnew/pcb_layer_widget.cpp
index da8f38a41..97960893d 100644
--- a/pcbnew/pcb_layer_widget.cpp
+++ b/pcbnew/pcb_layer_widget.cpp
@@ -388,6 +388,8 @@ void PCB_LAYER_WIDGET::SetLayersManagerTabsText()
 void PCB_LAYER_WIDGET::ReFillRender()
 {
 BOARD* board = myframe->GetBoard();
+auto settings = board->GetDesignSettings();
+
 ClearRenderRows();

 // Add "Items" tab rows to LAYER_WIDGET, after setting color and checkbox state.
@@ -401,6 +403,12 @@ void PCB_LAYER_WIDGET::ReFillRender()
 if( m_fp_editor_mode && !isAllowedInFpMode( renderRow.id ) )
 continue;

+if( renderRow.id == LAYER_VIA_MICROVIA && !settings.m_MicroViasAllowed )
+continue;
+
+if( renderRow.id == LAYER_VIA_BBLIND && !settings.m_BlindBuriedViaAllowed )
+continue;
+
 renderRow.tooltip = wxGetTranslation( s_render_rows[row].tooltip );
 renderRow.rowName = wxGetTranslation( s_render_rows[row].rowName );

--
2.14.1

From 1d08a35d5c3d10a2f8484beb2e1c7ddf4e139638 Mon Sep 17 00:00:00 2001
From: Jon Evans 
Date: Thu, 22 Feb 2018 18:54:50 -0500
Subject: [PATCH 1/2] Rename "Render" to "Items" and a few other wording
 changes

---
 gerbview/gerbview_layer_widget.cpp |  4 ++--
 pcbnew/layer_widget.cpp|  4 ++--
 pcbnew/pcb_layer_widget.cpp| 28 ++--
 3 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/gerbview/gerbview_layer_widget.cpp b/gerbview/gerbview_layer_widget.cpp
index 415cfc011..7373a8250 100644
--- a/gerbview/gerbview_layer_widget.cpp
+++ b/gerbview/gerbview_layer_widget.cpp
@@ -92,8 +92,8 @@ bool GERBER_LAYER_WIDGET::AreArbitraryColorsAllowed()

 void GERBER_LAYER_WIDGET::SetLayersManagerTabsText( )
 {
-m_notebook->SetPageText(0, _("Layer") );
-m_notebook->SetPageText(1, _("Render") );
+m_notebook->SetPageText(0, _("Layers") );
+m_notebook->SetPageText(1, _("Items") );
 }

 /**
diff --git a/pcbnew/layer_widget.cpp b/pcbnew/layer_widget.cpp
index 3969e14f9..9f36a5f8c 100644
--- a/pcbnew/layer_widget.cpp
+++ b/pcbnew/layer_widget.cpp
@@ -495,7 +495,7 @@ LAYER_WIDGET::LAYER_WIDGET( wxWindow* aParent, wxWindow* aFocusOwner, int aPoint
 m_LayerPanel->SetSizer( bSizer3 );
 m_LayerPanel->Layout();
 bSizer3->Fit( m_LayerPanel );
-m_notebook->AddPage( m_LayerPanel, _( "Layer" ), true );
+m_notebook->AddPage( m_LayerPanel, _( "Layers" ), true );
 m_RenderingPanel = new wxPanel( m_notebook, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxTAB_TRAVERSAL );

 wxBoxSizer* bSizer4;
@@ -515,7 +515,7 @@ LAYER_WIDGET::LAYER_WIDGET( wxWindow* aParent, wxWindow* aFocusOwner, int aPoint
 m_RenderingPanel->SetSizer( bSizer4 );
 m_RenderingPanel->Layout();
 bSizer4->Fit( m_RenderingPanel );
-m_notebook->AddPage( m_RenderingPanel, _( "Render" ), false );
+m_notebook->AddPage( 

Re: [Kicad-developers] [PATCH] Remove duplicate source file from list

[Wayne Stambaugh]

Simon,

I merged your patch.  Thank you for your contribution to KiCad.

Cheers,

Wayne

On 02/22/2018 02:18 PM, Simon Richter wrote:

---
  common/CMakeLists.txt | 5 -
  1 file changed, 5 deletions(-)



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] kicad compile error on FreeBSD

[Maciej Suminski]

I am sorry about that. I swear it would not have happened if I got a
single warning message from the compiler, but both clang 4.0.0 and gcc
7.1.1 had merrily compiled the code, so I have not expected such
problems. Thank you for quick reaction Jean-Pierre.

Regards,
Orson

On 02/22/2018 09:33 PM, Wayne Stambaugh wrote:
> This shouldn't have happened.  We are not c++14 project.  We are c++11
> project until it is deemed safe to move up to the next c++ standard.
> Please be more careful about this.
> 
> On 2/22/2018 3:15 PM, Jon Evans wrote:
>> Also broken on MacOS.  Hashing of enum types (and therefore using them
>> as unordered_map keys) doesn't work on all compilers until C++14.  Patch
>> attached that should fix it (tested on MacOS)
>>
>>
>>
>> On Thu, Feb 22, 2018 at 1:05 PM, Foo Barmann > > wrote:
>>
>> Hi,
>> while trying to compile the current kicad sources under FreeBSD
>> 11-stable (compiler is clang 4.0) I get the attached errors:
>>
>> The used WxGtk Packages are:
>> py27-wxPython-common-3.0.2.0_4 GUI toolkit for the Python
>> programming language
>> py27-wxPython30-3.0.2.0_4  GUI toolkit for the Python
>> programming language
>> wx30-gtk2-3.0.2_7  The wxWidgets GUI toolkit with GTK+
>> bindings
>>
>> Error:
>> ...
>> FAILED: common/CMakeFiles/common.dir/confirm.cpp.o
>> /usr/local/libexec/ccache/c++  -DHAVE_STDINT_H -DKICAD_SCRIPTING
>> -DKICAD_SCRIPTING_MODULES -DKICAD_SCRIPTING_WXPYTHON -DWXUSINGDLL
>> -DWX_COMPATIBILITY -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -D__WXGTK__
>> -Iinclude -Icommon/. -isystem
>> /usr/local/lib/wx/include/gtk2-unicode-3.0 -isystem
>> /usr/local/include/wx-3.0 -Icommon/./dialogs -Icommon/./widgets
>> -Icommon/./dialog_about -I/usr/local/include/cairo
>> -I/usr/local/include/pixman-1 -I/usr/local/include
>> -Icommon/../3d-viewer -Icommon/../pcbnew -Icommon/../polygon -I.
>> -I/usr/local/include/python2.7 -Iscripting -Wall -O2 -pipe
>> -fstack-protector -fno-strict-aliasing  --std=c++11
>> 
>> -I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include
>> -I/usr/local/include -msse -Wno-unused-local-typedefs
>> -Wno-strict-aliasing -pthread -Wshadow -O2 -pipe -fstack-protector
>> -fno-strict-aliasing  --std=c++11
>> 
>> -I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include
>> -I/usr/local/include -msse -fPIC -fvisibility=hidden
>> -fvisibility-inlines-hidden   -std=gnu++11 -MD -MT
>> common/CMakeFiles/common.dir/confirm.cpp.o -MF
>> common/CMakeFiles/common.dir/confirm.cpp.o.d -o
>> common/CMakeFiles/common.dir/confirm.cpp.o -c common/confirm.cpp
>> In file included from common/confirm.cpp:30:
>> In file included from /usr/local/include/wx-3.0/wx/stockitem.h:16:
>> In file included from /usr/local/include/wx-3.0/wx/string.h:46:
>> In file included from /usr/local/include/wx-3.0/wx/strvararg.h:22:
>> In file included from /usr/local/include/wx-3.0/wx/unichar.h:15:
>> In file included from /usr/local/include/wx-3.0/wx/stringimpl.h:66:
>> In file included from /usr/include/c++/v1/string:470:
>> In file included from /usr/include/c++/v1/string_view:171:
>> In file included from /usr/include/c++/v1/__string:56:
>> In file included from /usr/include/c++/v1/algorithm:637:
>> /usr/include/c++/v1/type_traits:1474:38: error: implicit
>> instantiation of undefined template 'std::__1::hash'
>>     : public integral_constant {};
>>  ^
>> /usr/include/c++/v1/unordered_map:383:18: note: in instantiation of
>> template class 'std::__1::is_empty> >' requested here
>>   bool = is_empty<_Hash>::value &&
>> !__libcpp_is_final<_Hash>::value
>>  ^
>> /usr/include/c++/v1/unordered_map:765:13: note: in instantiation of
>> default argument for '__unordered_map_hasher> std::__1::__hash_value_type,
>> std::__1::hash >' required here
>>     typedef __unordered_map_hasher  
>> __hasher;
>>     ^~
>> common/confirm.cpp:72:46: note: in instantiation of template class
>> 'std::__1::unordered_map> std::__1::hash,
>> std::__1::equal_to,
>> std::__1::allocator> > >' requested here
>>     const std::unordered_map stdTitle = {
>>  ^
>> /usr/include/c++/v1/type_traits:397:50: note: template is declared here
>> template  struct _LIBCPP_TEMPLATE_VIS hash;
>>  ^
>> 

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Wayne Stambaugh]

Patch merged.  Thanks.

On 02/21/2018 11:39 PM, Jon Evans wrote:

Hi all,

This patch rearranges the Render panel to be in a more logical order, 
and adds some whitespace.

I divided it into three groupings:
1) footprint related
2) other board objects
3) non-board stuff like grid, ratlines, etc.

I also bumped out the default size so that scrollbars aren't needed by 
default on my Linux system.


-Jon


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Eeli Kaikkonen]

2018-02-22 23:05 GMT+02:00 Tiger12506 :

> I agree 100% on separate file. As someone who puts kicad files in git, the
> most irritating thing in the world is having unrelated changes in your
> diff. Separate file gives you the flexibility to have either situation --
> if you want the vcs to track it, you include the file, if you don't, your
> vcs ignores the file. It's unfortunate that there are already UI states in
> any of the files that represent a design.
>
> Cheers. :)
>
>
I agree, too. As a both end user and someone who has studied usability I
know the current situation creates unnecessary cognitive and emotinal
stress for the end user. Many times a user can't be sure or can't remember
what he/she actually did or if he did something by accident. Seeing the
message that something was changed is disturbing because you can't know
what happened and what will be saved. If the non-design-related data would
be in a separate file it wouldn't even have to be asked about IMO because
it's safe to save always, it's not critical data in any way.

But about the compatibility between versions - what kind of compatibility
would be needed? I just tried deleting the layers section from a board
file. Pcbnew opened it happily. So, let's suppose v5.1 is released later
with this change in file format: extra data is not stored in the kicad_pcb
file but in another file. If the project is created with 5.1 then 5.0 can
read it, it just doesn't restore the layer visibility. How serious would
that be? If the project was created with 5.0, then 5.1 could also handle it
(if the code which reads the file wasn't changed). It could either save the
data in the compatible way or take it off from the design file and move it
to the other file.

How KiCad reacts to removing other non-design data from the file, I don't
know.

Eeli Kaikkonen
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Tiger12506]

I agree 100% on separate file. As someone who puts kicad files in git, 
the most irritating thing in the world is having unrelated changes in 
your diff. Separate file gives you the flexibility to have either 
situation -- if you want the vcs to track it, you include the file, if 
you don't, your vcs ignores the file. It's unfortunate that there are 
already UI states in any of the files that represent a design.


Cheers. :)

On 2/22/2018 2:08 PM, Wayne Stambaugh wrote:

I'm agreeing with Andy on this one.  I really don't like the idea of
putting UI or print/plot state information in the board file.  Most of
the current state information was added by my predecessor.  I've never
liked the idea of UI state information being saved in the board file.
Andy pointed out that the same argument could be made for the project
file which makes sense to me.  An intermediate file seems like a
reasonable compromise.  I know this is one of those arguments that users
are going to disagree about.  I'll save everyone the hassle of arguing
about it by saying that as long as I am project manager, no additional
UI states are going to be added to any of the file formats.  If there
was some way I could remove them from the current board file format
without wrecking compatibility, I would.

Cheers,

Wayne

On 2/22/2018 1:07 PM, Andrzej Wolski wrote:

I agree. I think layer visibility data should be saved in board file
because that file should be independent of project file and any other
files. I would like to be able to send only pcb file via email, and have
all information contained there.

Some solution to problem Andy described might be not to mark board
modified if only layer visibility was changed.

Both Altium and Kicad have small hole here: board is not marked modified
if you flip view or enable high contrast mode, but it is marked if you
enable/disable some layer :)

Andrzej


On 02/22/2018 06:48 PM, Jon Evans wrote:

The tradeoff there is that other users will have a workflow that
involves setting up a nice set of layers displayed/hidden for working
on a board, and want to switch to another set for another board.
Maybe saving in the app preferences is okay in the short term, but I
think eventually it's best to be able to save custom display states
(including layer visibility and other options) in the project.
Other software has solved this problem by making multiple project
files, and having the idea of the "base" project file and the "user
settings" project file, with the latter explicitly not going in to
version control.

-Jon

On Thu, Feb 22, 2018 at 12:15 PM, Andy Peters > wrote:


 On Feb 22, 2018, at 7:58 AM, Jon Evans > wrote:

 Currently some of the render visibility stuff is saved in the
 application preferences, and some is not saved.
 I think if there are layers related to board item visibility that
 aren't saved, saving them in the project or board makes more
 sense than saving in the app config.

 User perspective:

 Saving the render visibility in the project or pcb file “touches”
 that file, so Kicad will want to save the file when you close the
 project or PCB. And then your source-code control system thinks
 that the file has been modified (because it was!). This sort of
 change has nothing to do with the design, it is only a
 rendering/display detail.

 A common example: I often use pcbnew (or Altium, it has the same
 problem) to view a design, without intending to actually modify
 it. And when doing that, I often change layer visibility and such.
 When closing the pcb file, the user will be asked to save the
 file. “But all I did was look at different layers .. I didn’t
 change the design!”

 So, please, don’t keep layer visibility/rendering information in
 the pcb or project file!

 -a


 Re. 3, yes I think that same framework could be used to add some
 shortcuts for the "render" side pretty easily.

 Re. 2, seems reasonable, haven't looked at the code yet

 I can probably tackle this but can also leave it to Andrzej if
 you are interested in it.

 @Wayne I guess the first patch can be merged now if you are OK
 with it, since Jeff isn't worried about conflicts?

 -Jon

 On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh
 > wrote:

 On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
 > If some work on Render panel is still being done, I would
 have some
 > suggestions:
 > 1. "Text Front" and "Text Back" should be renamed to
 something like
 > "Footpr. Text Front" It is misleading now.

 I'm fine with this but please do not abbreviate the word
 footprint.

 > 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they
 are disabled
 > in design 

Re: [Kicad-developers] kicad compile error on FreeBSD

[Wayne Stambaugh]

This shouldn't have happened.  We are not c++14 project.  We are c++11
project until it is deemed safe to move up to the next c++ standard.
Please be more careful about this.

On 2/22/2018 3:15 PM, Jon Evans wrote:
> Also broken on MacOS.  Hashing of enum types (and therefore using them
> as unordered_map keys) doesn't work on all compilers until C++14.  Patch
> attached that should fix it (tested on MacOS)
> 
> 
> 
> On Thu, Feb 22, 2018 at 1:05 PM, Foo Barmann  > wrote:
> 
> Hi,
> while trying to compile the current kicad sources under FreeBSD
> 11-stable (compiler is clang 4.0) I get the attached errors:
> 
> The used WxGtk Packages are:
> py27-wxPython-common-3.0.2.0_4 GUI toolkit for the Python
> programming language
> py27-wxPython30-3.0.2.0_4  GUI toolkit for the Python
> programming language
> wx30-gtk2-3.0.2_7  The wxWidgets GUI toolkit with GTK+
> bindings
> 
> Error:
> ...
> FAILED: common/CMakeFiles/common.dir/confirm.cpp.o
> /usr/local/libexec/ccache/c++  -DHAVE_STDINT_H -DKICAD_SCRIPTING
> -DKICAD_SCRIPTING_MODULES -DKICAD_SCRIPTING_WXPYTHON -DWXUSINGDLL
> -DWX_COMPATIBILITY -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -D__WXGTK__
> -Iinclude -Icommon/. -isystem
> /usr/local/lib/wx/include/gtk2-unicode-3.0 -isystem
> /usr/local/include/wx-3.0 -Icommon/./dialogs -Icommon/./widgets
> -Icommon/./dialog_about -I/usr/local/include/cairo
> -I/usr/local/include/pixman-1 -I/usr/local/include
> -Icommon/../3d-viewer -Icommon/../pcbnew -Icommon/../polygon -I.
> -I/usr/local/include/python2.7 -Iscripting -Wall -O2 -pipe
> -fstack-protector -fno-strict-aliasing  --std=c++11
> 
> -I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include
> -I/usr/local/include -msse -Wno-unused-local-typedefs
> -Wno-strict-aliasing -pthread -Wshadow -O2 -pipe -fstack-protector
> -fno-strict-aliasing  --std=c++11
> 
> -I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include
> -I/usr/local/include -msse -fPIC -fvisibility=hidden
> -fvisibility-inlines-hidden   -std=gnu++11 -MD -MT
> common/CMakeFiles/common.dir/confirm.cpp.o -MF
> common/CMakeFiles/common.dir/confirm.cpp.o.d -o
> common/CMakeFiles/common.dir/confirm.cpp.o -c common/confirm.cpp
> In file included from common/confirm.cpp:30:
> In file included from /usr/local/include/wx-3.0/wx/stockitem.h:16:
> In file included from /usr/local/include/wx-3.0/wx/string.h:46:
> In file included from /usr/local/include/wx-3.0/wx/strvararg.h:22:
> In file included from /usr/local/include/wx-3.0/wx/unichar.h:15:
> In file included from /usr/local/include/wx-3.0/wx/stringimpl.h:66:
> In file included from /usr/include/c++/v1/string:470:
> In file included from /usr/include/c++/v1/string_view:171:
> In file included from /usr/include/c++/v1/__string:56:
> In file included from /usr/include/c++/v1/algorithm:637:
> /usr/include/c++/v1/type_traits:1474:38: error: implicit
> instantiation of undefined template 'std::__1::hash'
>     : public integral_constant {};
>  ^
> /usr/include/c++/v1/unordered_map:383:18: note: in instantiation of
> template class 'std::__1::is_empty >' requested here
>   bool = is_empty<_Hash>::value &&
> !__libcpp_is_final<_Hash>::value
>  ^
> /usr/include/c++/v1/unordered_map:765:13: note: in instantiation of
> default argument for '__unordered_map_hasher std::__1::__hash_value_type,
> std::__1::hash >' required here
>     typedef __unordered_map_hasher  
> __hasher;
>     ^~
> common/confirm.cpp:72:46: note: in instantiation of template class
> 'std::__1::unordered_map std::__1::hash,
> std::__1::equal_to,
> std::__1::allocator > >' requested here
>     const std::unordered_map stdTitle = {
>  ^
> /usr/include/c++/v1/type_traits:397:50: note: template is declared here
> template  struct _LIBCPP_TEMPLATE_VIS hash;
>  ^
> In file included from common/confirm.cpp:35:
> In file included from include/html_messagebox.h:34:
> In file included from
> include/../common/dialogs/dialog_display_info_HTML_base.h:14:
> In file included from include/dialog_shim.h:29:
> In file included from include/hashtables.h:103:
> In file included from /usr/include/c++/v1/unordered_map:369:
> 

[Kicad-developers] Jenkins build is back to normal : kicad-qa #3628

[Miguel Angel Ajo]

See 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] kicad compile error on FreeBSD

[Jon Evans]

Yes, looks like your fix will work too!

On Thu, Feb 22, 2018 at 3:19 PM, jp charras  wrote:

> Le 22/02/2018 à 21:15, Jon Evans a écrit :
> > Also broken on MacOS.  Hashing of enum types (and therefore using them
> as unordered_map keys)
> > doesn't work on all compilers until C++14.  Patch attached that should
> fix it (tested on MacOS)
> >
> >
>
> I am thinking I already fixed (fix already committed) this compil issue,
> although using a different way.
>
>
> --
> Jean-Pierre CHARRAS
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] kicad compile error on FreeBSD

[jp charras]

Le 22/02/2018 à 21:15, Jon Evans a écrit :
> Also broken on MacOS.  Hashing of enum types (and therefore using them as 
> unordered_map keys)
> doesn't work on all compilers until C++14.  Patch attached that should fix it 
> (tested on MacOS)
> 
> 

I am thinking I already fixed (fix already committed) this compil issue, 
although using a different way.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] kicad compile error on FreeBSD

[Jon Evans]

Also broken on MacOS.  Hashing of enum types (and therefore using them as
unordered_map keys) doesn't work on all compilers until C++14.  Patch
attached that should fix it (tested on MacOS)



On Thu, Feb 22, 2018 at 1:05 PM, Foo Barmann  wrote:

> Hi,
> while trying to compile the current kicad sources under FreeBSD 11-stable
> (compiler is clang 4.0) I get the attached errors:
>
> The used WxGtk Packages are:
> py27-wxPython-common-3.0.2.0_4 GUI toolkit for the Python programming
> language
> py27-wxPython30-3.0.2.0_4  GUI toolkit for the Python programming
> language
> wx30-gtk2-3.0.2_7  The wxWidgets GUI toolkit with GTK+ bindings
>
> Error:
> ...
> FAILED: common/CMakeFiles/common.dir/confirm.cpp.o
> /usr/local/libexec/ccache/c++  -DHAVE_STDINT_H -DKICAD_SCRIPTING
> -DKICAD_SCRIPTING_MODULES -DKICAD_SCRIPTING_WXPYTHON -DWXUSINGDLL
> -DWX_COMPATIBILITY -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -D__WXGTK__
> -Iinclude -Icommon/. -isystem /usr/local/lib/wx/include/gtk2-unicode-3.0
> -isystem /usr/local/include/wx-3.0 -Icommon/./dialogs -Icommon/./widgets
> -Icommon/./dialog_about -I/usr/local/include/cairo
> -I/usr/local/include/pixman-1 -I/usr/local/include -Icommon/../3d-viewer
> -Icommon/../pcbnew -Icommon/../polygon -I. -I/usr/local/include/python2.7
> -Iscripting -Wall -O2 -pipe -fstack-protector -fno-strict-aliasing
> --std=c++11 -I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-
> 2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include -I/usr/local/include
> -msse -Wno-unused-local-typedefs -Wno-strict-aliasing -pthread -Wshadow -O2
> -pipe -fstack-protector -fno-strict-aliasing  --std=c++11
> -I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-
> 2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include -I/usr/local/include
> -msse -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -std=gnu++11
> -MD -MT common/CMakeFiles/common.dir/confirm.cpp.o -MF
> common/CMakeFiles/common.dir/confirm.cpp.o.d -o
> common/CMakeFiles/common.dir/confirm.cpp.o -c common/confirm.cpp
> In file included from common/confirm.cpp:30:
> In file included from /usr/local/include/wx-3.0/wx/stockitem.h:16:
> In file included from /usr/local/include/wx-3.0/wx/string.h:46:
> In file included from /usr/local/include/wx-3.0/wx/strvararg.h:22:
> In file included from /usr/local/include/wx-3.0/wx/unichar.h:15:
> In file included from /usr/local/include/wx-3.0/wx/stringimpl.h:66:
> In file included from /usr/include/c++/v1/string:470:
> In file included from /usr/include/c++/v1/string_view:171:
> In file included from /usr/include/c++/v1/__string:56:
> In file included from /usr/include/c++/v1/algorithm:637:
> /usr/include/c++/v1/type_traits:1474:38: error: implicit instantiation of
> undefined template 'std::__1::hash'
> : public integral_constant {};
>  ^
> /usr/include/c++/v1/unordered_map:383:18: note: in instantiation of
> template class 'std::__1::is_empty'
> requested here
>   bool = is_empty<_Hash>::value && !__libcpp_is_final<_Hash>::
> value
>  ^
> /usr/include/c++/v1/unordered_map:765:13: note: in instantiation of
> default argument for '__unordered_map_hasher std::__1::__hash_value_type,
> std::__1::hash >' required here
> typedef __unordered_map_hasher
> __hasher;
> ^~
> common/confirm.cpp:72:46: note: in instantiation of template class
> 'std::__1::unordered_map std::__1::hash, std::__1::equal_to,
> std::__1::allocator >'
> requested here
> const std::unordered_map stdTitle = {
>  ^
> /usr/include/c++/v1/type_traits:397:50: note: template is declared here
> template  struct _LIBCPP_TEMPLATE_VIS hash;
>  ^
> In file included from common/confirm.cpp:35:
> In file included from include/html_messagebox.h:34:
> In file included from include/../common/dialogs/
> dialog_display_info_HTML_base.h:14:
> In file included from include/dialog_shim.h:29:
> In file included from include/hashtables.h:103:
> In file included from /usr/include/c++/v1/unordered_map:369:
> /usr/include/c++/v1/__hash_table:1952:21: error: called object type
> 'hasher' (aka 'int') is not a function or function pointer
> size_t __hash = hash_function()(__k);
> ^~~
> /usr/include/c++/v1/__hash_table:1113:16: note: in instantiation of
> function template specialization 'std::__1::__hash_table _1::__hash_value_type, int,
> std::__1::__unordered_map_equal std::__1::__hash_value_type,
> std::__1::equal_to, true>, std::__1::allocator __hash_value_type >
> 

[Kicad-developers] [PATCH/RFC] Eeschema menubar

[Michael Kavanagh]

You guessed it. Also some very minor modifications to the Kicad manager menubar.

Cheers,
Michael


0001-Kicad-Minor-menubar-changes.patch
Description: Binary data


0002-Eeschema-New-menubar-structure.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Remove duplicate source file from list

[Simon Richter]

---
 common/CMakeLists.txt | 5 -
 1 file changed, 5 deletions(-)

diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt
index c31178986..9a4c2300c 100644
--- a/common/CMakeLists.txt
+++ b/common/CMakeLists.txt
@@ -432,11 +432,6 @@ set( PCB_COMMON_SRCS
 widgets/widget_net_selector.cpp
 )
 
-set( PCB_COMMON_SRCS
-${PCB_COMMON_SRCS}
-../pcbnew/pcb_painter.cpp
-)
-
 # add -DPCBNEW to compilation of these PCBNEW sources
 set_source_files_properties( ${PCB_COMMON_SRCS} PROPERTIES
 COMPILE_DEFINITIONS "PCBNEW"
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Wayne Stambaugh]

I'm agreeing with Andy on this one.  I really don't like the idea of
putting UI or print/plot state information in the board file.  Most of
the current state information was added by my predecessor.  I've never
liked the idea of UI state information being saved in the board file.
Andy pointed out that the same argument could be made for the project
file which makes sense to me.  An intermediate file seems like a
reasonable compromise.  I know this is one of those arguments that users
are going to disagree about.  I'll save everyone the hassle of arguing
about it by saying that as long as I am project manager, no additional
UI states are going to be added to any of the file formats.  If there
was some way I could remove them from the current board file format
without wrecking compatibility, I would.

Cheers,

Wayne

On 2/22/2018 1:07 PM, Andrzej Wolski wrote:
> I agree. I think layer visibility data should be saved in board file
> because that file should be independent of project file and any other
> files. I would like to be able to send only pcb file via email, and have
> all information contained there.
> 
> Some solution to problem Andy described might be not to mark board
> modified if only layer visibility was changed.
> 
> Both Altium and Kicad have small hole here: board is not marked modified
> if you flip view or enable high contrast mode, but it is marked if you
> enable/disable some layer :)
> 
> Andrzej
> 
> 
> On 02/22/2018 06:48 PM, Jon Evans wrote:
>> The tradeoff there is that other users will have a workflow that
>> involves setting up a nice set of layers displayed/hidden for working
>> on a board, and want to switch to another set for another board.
>> Maybe saving in the app preferences is okay in the short term, but I
>> think eventually it's best to be able to save custom display states
>> (including layer visibility and other options) in the project.
>> Other software has solved this problem by making multiple project
>> files, and having the idea of the "base" project file and the "user
>> settings" project file, with the latter explicitly not going in to
>> version control.
>>
>> -Jon
>>
>> On Thu, Feb 22, 2018 at 12:15 PM, Andy Peters > > wrote:
>>
>>
>> On Feb 22, 2018, at 7:58 AM, Jon Evans > > wrote:
>>>
>>> Currently some of the render visibility stuff is saved in the
>>> application preferences, and some is not saved.
>>> I think if there are layers related to board item visibility that
>>> aren't saved, saving them in the project or board makes more
>>> sense than saving in the app config.
>>
>> User perspective:
>>
>> Saving the render visibility in the project or pcb file “touches”
>> that file, so Kicad will want to save the file when you close the
>> project or PCB. And then your source-code control system thinks
>> that the file has been modified (because it was!). This sort of
>> change has nothing to do with the design, it is only a
>> rendering/display detail.
>>
>> A common example: I often use pcbnew (or Altium, it has the same
>> problem) to view a design, without intending to actually modify
>> it. And when doing that, I often change layer visibility and such.
>> When closing the pcb file, the user will be asked to save the
>> file. “But all I did was look at different layers .. I didn’t
>> change the design!” 
>>
>> So, please, don’t keep layer visibility/rendering information in
>> the pcb or project file!
>>
>> -a
>>
>>>
>>> Re. 3, yes I think that same framework could be used to add some
>>> shortcuts for the "render" side pretty easily.
>>>
>>> Re. 2, seems reasonable, haven't looked at the code yet
>>>
>>> I can probably tackle this but can also leave it to Andrzej if
>>> you are interested in it.
>>>
>>> @Wayne I guess the first patch can be merged now if you are OK
>>> with it, since Jeff isn't worried about conflicts?
>>>
>>> -Jon
>>>
>>> On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh
>>> > wrote:
>>>
>>> On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
>>> > If some work on Render panel is still being done, I would
>>> have some
>>> > suggestions:
>>> > 1. "Text Front" and "Text Back" should be renamed to
>>> something like
>>> > "Footpr. Text Front" It is misleading now.
>>>
>>> I'm fine with this but please do not abbreviate the word
>>> footprint.
>>>
>>> > 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they
>>> are disabled
>>> > in design settings.
>>>
>>> This makes sense as long as you do not couple the layer
>>> manager UI code
>>> to the board object code.
>>>
>>> > 3. It would be nice to have right click menu with something
>>> like:

[Kicad-developers] Build failed in Jenkins: kicad-qa #3627

[Miguel Angel Ajo]

See 

Changes:

[Wayne Stambaugh] Scale up number of segments per polygon for larger features.

--
[...truncated 1.48 KB...]
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ grep -q ^MAKEJOBS=
+ env
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] Built target lib_table_lexer_source_files
[  0%] [  2%] Built target idf3
Built target kicad_3dsg
[  2%] Built target pcb_plot_lexer_source_files
[  2%] Built target netlist_lexer_source_files
[  2%] Built target pcb_lexer_source_files
[  2%] Built target page_layout_lexer_source_files
[  5%] Built target gal
[  5%] Generating version string header
-- Using Git to determine build version string.
[  5%] [  5%] Built target lib_dxf
-- Found Git: /usr/bin/git (found version "2.1.4") 
Built target specctra_lexer_source_files
[ 49%] Built target bitmaps
[ 49%] Built target polygon
-- Writing 
 file with 
version: (5.0-dev-4142-g80f36ce)
[ 49%] Built target version_header
Scanning dependencies of target pcbcommon
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/board_items_to_polygon_shape_transform.cpp.o
Scanning dependencies of target common
[ 50%] [ 50%] [ 50%] Building CXX object 
common/CMakeFiles/common.dir/build_version.cpp.o
Building CXX object common/CMakeFiles/common.dir/hotkeys_basic.cpp.o
Building CXX object common/CMakeFiles/common.dir/confirm.cpp.o
[ 50%] Building CXX object common/CMakeFiles/common.dir/project.cpp.o
In file included from /usr/include/c++/4.9/bits/hashtable.h:35:0,
 from /usr/include/c++/4.9/unordered_map:47,
 from 
:103,
 from 
:29,
 from 
:14,
 from 
:34,
 from 
:35:
/usr/include/c++/4.9/bits/hashtable_policy.h: In instantiation of ‘struct 
std::__detail::__is_noexcept_hash’:
/usr/include/c++/4.9/type_traits:134:12:   required from ‘struct 
std::__and_, 
std::__detail::__is_noexcept_hash 
>’
/usr/include/c++/4.9/type_traits:145:38:   required from ‘struct 
std::__not_, 
std::__detail::__is_noexcept_hash 
> >’
/usr/include/c++/4.9/bits/unordered_map.h:100:66:   required from ‘class 
std::unordered_map’
:72:46:   required 
from here
/usr/include/c++/4.9/bits/hashtable_policy.h:85:33: error: no match for call to 
‘(const std::hash) (const KI_DIALOG::TYPE&)’
  noexcept(declval()(declval()))>
 ^
In file included from /usr/include/c++/4.9/bits/move.h:57:0,
 from /usr/include/c++/4.9/bits/stl_pair.h:59,
 from /usr/include/c++/4.9/bits/stl_algobase.h:64,
 from /usr/include/c++/4.9/bits/char_traits.h:39,
 from /usr/include/c++/4.9/string:40,
 from /usr/include/wx-3.0/wx/stringimpl.h:66,
 from /usr/include/wx-3.0/wx/unichar.h:15,
 from /usr/include/wx-3.0/wx/strvararg.h:22,
 from /usr/include/wx-3.0/wx/string.h:46,
 from 

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Andrzej Wolski]

I agree. I think layer visibility data should be saved in board file 
because that file should be independent of project file and any other 
files. I would like to be able to send only pcb file via email, and have 
all information contained there.


Some solution to problem Andy described might be not to mark board 
modified if only layer visibility was changed.


Both Altium and Kicad have small hole here: board is not marked modified 
if you flip view or enable high contrast mode, but it is marked if you 
enable/disable some layer :)


Andrzej


On 02/22/2018 06:48 PM, Jon Evans wrote:
The tradeoff there is that other users will have a workflow that 
involves setting up a nice set of layers displayed/hidden for working 
on a board, and want to switch to another set for another board.
Maybe saving in the app preferences is okay in the short term, but I 
think eventually it's best to be able to save custom display states 
(including layer visibility and other options) in the project.
Other software has solved this problem by making multiple project 
files, and having the idea of the "base" project file and the "user 
settings" project file, with the latter explicitly not going in to 
version control.


-Jon

On Thu, Feb 22, 2018 at 12:15 PM, Andy Peters > wrote:



On Feb 22, 2018, at 7:58 AM, Jon Evans > wrote:


Currently some of the render visibility stuff is saved in the
application preferences, and some is not saved.
I think if there are layers related to board item visibility that
aren't saved, saving them in the project or board makes more
sense than saving in the app config.


User perspective:

Saving the render visibility in the project or pcb file “touches”
that file, so Kicad will want to save the file when you close the
project or PCB. And then your source-code control system thinks
that the file has been modified (because it was!). This sort of
change has nothing to do with the design, it is only a
rendering/display detail.

A common example: I often use pcbnew (or Altium, it has the same
problem) to view a design, without intending to actually modify
it. And when doing that, I often change layer visibility and such.
When closing the pcb file, the user will be asked to save the
file. “But all I did was look at different layers .. I didn’t
change the design!”

So, please, don’t keep layer visibility/rendering information in
the pcb or project file!

-a



Re. 3, yes I think that same framework could be used to add some
shortcuts for the "render" side pretty easily.

Re. 2, seems reasonable, haven't looked at the code yet

I can probably tackle this but can also leave it to Andrzej if
you are interested in it.

@Wayne I guess the first patch can be merged now if you are OK
with it, since Jeff isn't worried about conflicts?

-Jon

On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh
> wrote:

On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
> If some work on Render panel is still being done, I would
have some
> suggestions:
> 1. "Text Front" and "Text Back" should be renamed to
something like
> "Footpr. Text Front" It is misleading now.

I'm fine with this but please do not abbreviate the word
footprint.

> 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they
are disabled
> in design settings.

This makes sense as long as you do not couple the layer
manager UI code
to the board object code.

> 3. It would be nice to have right click menu with something
like:
>     "Show all footprint related"
>     "Hide all footprint related"
>     "Show all free primitives"
>     "Hide all free primitives"
>     "Show all other???"
>     "Hide all other???"
>     "Show all"
>     "Hide all"

Don't we already have something like this in the layer
manager (see
attached image)?

> 4. State of some checkboxes is not saved.

I think only the layer visibility states are saved in the
board file.  I
would rather not add any more non-board related information
the board
file format than is already there.  This state information
could be
saved in the project file or the application config file.  My
preference
is the project file but it's not a strong preference.

>
> If you can't, I could do some of these changes (if it's not
too late for
> them).
>
> Cheers,
> Andrzej
>
>
> W dniu 2018-02-22 o 05:39, Jon Evans pisze:
>> Hi all,
>>
>> This patch 

[Kicad-developers] kicad compile error on FreeBSD

[Foo Barmann]

Hi,
while trying to compile the current kicad sources under FreeBSD 11-stable
(compiler is clang 4.0) I get the attached errors:

The used WxGtk Packages are:
py27-wxPython-common-3.0.2.0_4 GUI toolkit for the Python programming
language
py27-wxPython30-3.0.2.0_4  GUI toolkit for the Python programming
language
wx30-gtk2-3.0.2_7  The wxWidgets GUI toolkit with GTK+ bindings

Error:
...
FAILED: common/CMakeFiles/common.dir/confirm.cpp.o
/usr/local/libexec/ccache/c++  -DHAVE_STDINT_H -DKICAD_SCRIPTING
-DKICAD_SCRIPTING_MODULES -DKICAD_SCRIPTING_WXPYTHON -DWXUSINGDLL
-DWX_COMPATIBILITY -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -D__WXGTK__
-Iinclude -Icommon/. -isystem /usr/local/lib/wx/include/gtk2-unicode-3.0
-isystem /usr/local/include/wx-3.0 -Icommon/./dialogs -Icommon/./widgets
-Icommon/./dialog_about -I/usr/local/include/cairo
-I/usr/local/include/pixman-1 -I/usr/local/include -Icommon/../3d-viewer
-Icommon/../pcbnew -Icommon/../polygon -I. -I/usr/local/include/python2.7
-Iscripting -Wall -O2 -pipe -fstack-protector -fno-strict-aliasing
--std=c++11
-I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include
-I/usr/local/include -msse -Wno-unused-local-typedefs -Wno-strict-aliasing
-pthread -Wshadow -O2 -pipe -fstack-protector -fno-strict-aliasing
--std=c++11
-I/wrkdirs/usr/ports/cad/kicad-devel/work/kicad-source-mirror-2e42d5c0065c2c0b4a537f48fca8746c4f61548a/include
-I/usr/local/include -msse -fPIC -fvisibility=hidden
-fvisibility-inlines-hidden   -std=gnu++11 -MD -MT
common/CMakeFiles/common.dir/confirm.cpp.o -MF
common/CMakeFiles/common.dir/confirm.cpp.o.d -o
common/CMakeFiles/common.dir/confirm.cpp.o -c common/confirm.cpp
In file included from common/confirm.cpp:30:
In file included from /usr/local/include/wx-3.0/wx/stockitem.h:16:
In file included from /usr/local/include/wx-3.0/wx/string.h:46:
In file included from /usr/local/include/wx-3.0/wx/strvararg.h:22:
In file included from /usr/local/include/wx-3.0/wx/unichar.h:15:
In file included from /usr/local/include/wx-3.0/wx/stringimpl.h:66:
In file included from /usr/include/c++/v1/string:470:
In file included from /usr/include/c++/v1/string_view:171:
In file included from /usr/include/c++/v1/__string:56:
In file included from /usr/include/c++/v1/algorithm:637:
/usr/include/c++/v1/type_traits:1474:38: error: implicit instantiation of
undefined template 'std::__1::hash'
: public integral_constant {};
 ^
/usr/include/c++/v1/unordered_map:383:18: note: in instantiation of
template class 'std::__1::is_empty'
requested here
  bool = is_empty<_Hash>::value && !__libcpp_is_final<_Hash>::value
 ^
/usr/include/c++/v1/unordered_map:765:13: note: in instantiation of default
argument for '__unordered_map_hasher,
std::__1::hash >' required here
typedef __unordered_map_hasher
__hasher;
^~
common/confirm.cpp:72:46: note: in instantiation of template class
'std::__1::unordered_map >'
requested here
const std::unordered_map stdTitle = {
 ^
/usr/include/c++/v1/type_traits:397:50: note: template is declared here
template  struct _LIBCPP_TEMPLATE_VIS hash;
 ^
In file included from common/confirm.cpp:35:
In file included from include/html_messagebox.h:34:
In file included from
include/../common/dialogs/dialog_display_info_HTML_base.h:14:
In file included from include/dialog_shim.h:29:
In file included from include/hashtables.h:103:
In file included from /usr/include/c++/v1/unordered_map:369:
/usr/include/c++/v1/__hash_table:1952:21: error: called object type
'hasher' (aka 'int') is not a function or function pointer
size_t __hash = hash_function()(__k);
^~~
/usr/include/c++/v1/__hash_table:1113:16: note: in instantiation of
function template specialization
'std::__1::__hash_table, int, std::__1::__unordered_map_equal,
std::__1::equal_to, true>,
std::__1::allocator
> >::__emplace_unique_key_args' requested here
return __emplace_unique_key_args(_NodeTypes::__get_key(__x), __x);
   ^
/usr/include/c++/v1/unordered_map:1414:18: note: in instantiation of member
function
'std::__1::__hash_table, int, std::__1::__unordered_map_equal,

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Andy Peters]

On Feb 22, 2018, at 10:48 AM, Jon Evans  wrote:
> 
> The tradeoff there is that other users will have a workflow that involves 
> setting up a nice set of layers displayed/hidden for working on a board, and 
> want to switch to another set for another board.
> Maybe saving in the app preferences is okay in the short term, but I think 
> eventually it's best to be able to save custom display states (including 
> layer visibility and other options) in the project.
> Other software has solved this problem by making multiple project files, and 
> having the idea of the "base" project file and the "user settings" project 
> file, with the latter explicitly not going in to version control.
> -Jon

A “dot” file for this sort of preference, which in Unix is hidden by default 
(gotta do an ls -a to see it), seems to me a good compromise. Upon creation of 
the project, a .settings file is created from reasonable defaults (a system 
default? user default?). Changes to the display/rendering configuration get 
saved here. If it gets deleted, or isn’t in the SCC repo and the project is 
checked out elsewhere, it gets recreated from defaults when the program is run. 
If the user cares, it can be added to the SCC repo.

-a


> On Thu, Feb 22, 2018 at 12:15 PM, Andy Peters  > wrote:
> 
> On Feb 22, 2018, at 7:58 AM, Jon Evans  > wrote:
>> 
>> Currently some of the render visibility stuff is saved in the application 
>> preferences, and some is not saved.
>> I think if there are layers related to board item visibility that aren't 
>> saved, saving them in the project or board makes more sense than saving in 
>> the app config.
> 
> User perspective:
> 
> Saving the render visibility in the project or pcb file “touches” that file, 
> so Kicad will want to save the file when you close the project or PCB. And 
> then your source-code control system thinks that the file has been modified 
> (because it was!). This sort of change has nothing to do with the design, it 
> is only a rendering/display detail.
> 
> A common example: I often use pcbnew (or Altium, it has the same problem) to 
> view a design, without intending to actually modify it. And when doing that, 
> I often change layer visibility and such. When closing the pcb file, the user 
> will be asked to save the file. “But all I did was look at different layers 
> .. I didn’t change the design!” 
> 
> So, please, don’t keep layer visibility/rendering information in the pcb or 
> project file!

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Jon Evans]

The tradeoff there is that other users will have a workflow that involves
setting up a nice set of layers displayed/hidden for working on a board,
and want to switch to another set for another board.
Maybe saving in the app preferences is okay in the short term, but I think
eventually it's best to be able to save custom display states (including
layer visibility and other options) in the project.
Other software has solved this problem by making multiple project files,
and having the idea of the "base" project file and the "user settings"
project file, with the latter explicitly not going in to version control.

-Jon

On Thu, Feb 22, 2018 at 12:15 PM, Andy Peters  wrote:

>
> On Feb 22, 2018, at 7:58 AM, Jon Evans  wrote:
>
>
> Currently some of the render visibility stuff is saved in the application
> preferences, and some is not saved.
> I think if there are layers related to board item visibility that aren't
> saved, saving them in the project or board makes more sense than saving in
> the app config.
>
>
> User perspective:
>
> Saving the render visibility in the project or pcb file “touches” that
> file, so Kicad will want to save the file when you close the project or
> PCB. And then your source-code control system thinks that the file has been
> modified (because it was!). This sort of change has nothing to do with the
> design, it is only a rendering/display detail.
>
> A common example: I often use pcbnew (or Altium, it has the same problem)
> to view a design, without intending to actually modify it. And when doing
> that, I often change layer visibility and such. When closing the pcb file,
> the user will be asked to save the file. “But all I did was look at
> different layers .. I didn’t change the design!”
>
> So, please, don’t keep layer visibility/rendering information in the pcb
> or project file!
>
> -a
>
>
> Re. 3, yes I think that same framework could be used to add some shortcuts
> for the "render" side pretty easily.
>
> Re. 2, seems reasonable, haven't looked at the code yet
>
> I can probably tackle this but can also leave it to Andrzej if you are
> interested in it.
>
> @Wayne I guess the first patch can be merged now if you are OK with it,
> since Jeff isn't worried about conflicts?
>
> -Jon
>
> On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh 
> wrote:
>
>> On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
>> > If some work on Render panel is still being done, I would have some
>> > suggestions:
>> > 1. "Text Front" and "Text Back" should be renamed to something like
>> > "Footpr. Text Front" It is misleading now.
>>
>> I'm fine with this but please do not abbreviate the word footprint.
>>
>> > 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are disabled
>> > in design settings.
>>
>> This makes sense as long as you do not couple the layer manager UI code
>> to the board object code.
>>
>> > 3. It would be nice to have right click menu with something like:
>> > "Show all footprint related"
>> > "Hide all footprint related"
>> > "Show all free primitives"
>> > "Hide all free primitives"
>> > "Show all other???"
>> > "Hide all other???"
>> > "Show all"
>> > "Hide all"
>>
>> Don't we already have something like this in the layer manager (see
>> attached image)?
>>
>> > 4. State of some checkboxes is not saved.
>>
>> I think only the layer visibility states are saved in the board file.  I
>> would rather not add any more non-board related information the board
>> file format than is already there.  This state information could be
>> saved in the project file or the application config file.  My preference
>> is the project file but it's not a strong preference.
>>
>> >
>> > If you can't, I could do some of these changes (if it's not too late for
>> > them).
>> >
>> > Cheers,
>> > Andrzej
>> >
>> >
>> > W dniu 2018-02-22 o 05:39, Jon Evans pisze:
>> >> Hi all,
>> >>
>> >> This patch rearranges the Render panel to be in a more logical order,
>> >> and adds some whitespace.
>> >> I divided it into three groupings:
>> >> 1) footprint related
>> >> 2) other board objects
>> >> 3) non-board stuff like grid, ratlines, etc.
>> >>
>> >> I also bumped out the default size so that scrollbars aren't needed by
>> >> default on my Linux system.
>> >>
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] PPA: library packages modifications

[Jean-Samuel Reynaud]

Dear All,

Libraries packages on PPA follow now the same schema as future debian's
package for KiCad.

So packages are renamed as:
kicad-library => kicad-libraries
kicad-library-footprints => kicad-footprints
kicad-library-packages3d => kicad-packages3d
kicad-library-symbols => kicad-symbols
kicad-library-templates => kicad-templates

 Future update/downgrade from/to between ppa and Ubuntu official KiCad's
package should be easier in the future.
 Ubuntu official Kicad's packages are not yet on new shema (work is in
progress on Carsten side, big thanks to him) but will be ok on the a
near future.


Regards,
Le 17/02/2018 à 15:22, Nick Østergaard a écrit :
> Thank you very much, both of you.
> 
> Den 17. feb. 2018 8.44 AM skrev "Jean-Samuel Reynaud"
> >:
> 
> Hi
> 
> Package naming will change in ppa to follow exactly the same schema
> as debian's packages. 
> 
> I will process those change as soon as possible. 
> 
> Regards.
> 
> Le 16 févr. 2018 23:46, "Nick Østergaard"  > a écrit :
> 
> 2018-01-15 11:55 GMT+01:00 Carsten Schoenert
> >:
> 
> Hi,
> 
> adding some notes here for the planned Debian packaging.
> Jean-Samuel emailed my some days ago already about his
> planes and we
> have tried to stay in contact about a consistent packaging
> schema
> between Ubuntu and Debian which makes absolutely sense in my
> eyes.
> 
> Am 15.01.2018 um 09:40 schrieb Jean-Samuel Reynaud:
> ...
> > *New package situation:*
> >
> > So I have reshaped packages:
> >
> > kicad-library
> > kicad-library-footprints
> > kicad-library-packages3d
> > kicad-library-symbols
> > kicad-library-templates
> 
> I've agree on those new needed binary packages, which will also
> introduce the depending new source packages.
> 
> 
> So what did the final naming become?
> 
> According to the PPA it looks like:
> 
> https://code.launchpad.net/~js-reynaud/+archive/ubuntu/ppa-kicad/+packages?field.name_filter=_filter=published_filter=artful
> 
> 
> 
> kicad-library (not sure what this does)
> kicad-library-all (date of this is older than the packages, but
> I guess this is a meta package)
> kicad-library-footprints
> kicad-library-packages3d
> kicad-library-symbols
> kicad-library-templates
> 
> While on the figure on your page I see:
> https://wiki.debian.org/KiCad
> kicad-libraries (meta package for footprint, symbols and templates)
> kicad-footprint
> kicad-packages3d
> kicad-symbols
> kicad-templates
>  
> 
> 
> > kicad-library is a meta package. It had a dependency 
> (recommend, not
> > strong) to each others.
> 
> In terms of Debian and Ubuntu there is only Recommends and
> Suggests
> available. The difference between both is simple that a
> Suggests will
> never be installed automatically, a Recommends will be
> installed unless
> the user is turning this globally off (default in on) or
> while calling
> 'apt install' by the option '--no-install-recommends'.
> There is no strong or soft recommending.
> 
> I suggested to use 'kicad-libraries' as the package name and
> make
> 'kicad-library' a transitional package.
> 
> > The version of this package will be prefixed with a "1:" to put 
> it on
> > the front of older version of kicad-library.
> 
> This is not needed in my eyes. The sense of a epoch version
> is something
> different [1]. As long as the new version number for
> 'kicad-libra[y|ies]' is greater than the previous one the
> update will
> work as wanted, the new version is overwriting the old package.
> But I haven't looked at the existing PPA packages from
> Jean-Samuel in
> detail until now.
> 
> > kicad-library-packages3d own all 3D. This package have a large 
> size (~
> > 330M, 4G on disk) . It will have a recommended dependency to
> > kicad-library-footprint
> >
> > kicad-library-footprints own all footprints
> > kicad-library-symbols same with symbols
> > kicad-library-templates same with ... templates ;)
> >

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Andrzej Wolski]

I won't be able to do it before weekend, so if you have time, please go 
ahead.


Cheers,
Andrzej


On 02/22/2018 03:58 PM, Jon Evans wrote:
Currently some of the render visibility stuff is saved in the 
application preferences, and some is not saved.
I think if there are layers related to board item visibility that 
aren't saved, saving them in the project or board makes more sense 
than saving in the app config.


Re. 3, yes I think that same framework could be used to add some 
shortcuts for the "render" side pretty easily.


Re. 2, seems reasonable, haven't looked at the code yet

I can probably tackle this but can also leave it to Andrzej if you are 
interested in it.


@Wayne I guess the first patch can be merged now if you are OK with 
it, since Jeff isn't worried about conflicts?


-Jon

On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh > wrote:


On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
> If some work on Render panel is still being done, I would have some
> suggestions:
> 1. "Text Front" and "Text Back" should be renamed to something like
> "Footpr. Text Front" It is misleading now.

I'm fine with this but please do not abbreviate the word footprint.

> 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are
disabled
> in design settings.

This makes sense as long as you do not couple the layer manager UI
code
to the board object code.

> 3. It would be nice to have right click menu with something like:
>     "Show all footprint related"
>     "Hide all footprint related"
>     "Show all free primitives"
>     "Hide all free primitives"
>     "Show all other???"
>     "Hide all other???"
>     "Show all"
>     "Hide all"

Don't we already have something like this in the layer manager (see
attached image)?

> 4. State of some checkboxes is not saved.

I think only the layer visibility states are saved in the board
file.  I
would rather not add any more non-board related information the board
file format than is already there.  This state information could be
saved in the project file or the application config file. My
preference
is the project file but it's not a strong preference.

>
> If you can't, I could do some of these changes (if it's not too
late for
> them).
>
> Cheers,
> Andrzej
>
>
> W dniu 2018-02-22 o 05:39, Jon Evans pisze:
>> Hi all,
>>
>> This patch rearranges the Render panel to be in a more logical
order,
>> and adds some whitespace.
>> I divided it into three groupings:
>> 1) footprint related
>> 2) other board objects
>> 3) non-board stuff like grid, ratlines, etc.
>>
>> I also bumped out the default size so that scrollbars aren't
needed by
>> default on my Linux system.
>>
>> -Jon
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers

>> Post to     : kicad-developers@lists.launchpad.net

>> Unsubscribe : https://launchpad.net/~kicad-developers

>> More help   : https://help.launchpad.net/ListHelp

>
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers

> Post to     : kicad-developers@lists.launchpad.net

> Unsubscribe : https://launchpad.net/~kicad-developers

> More help   : https://help.launchpad.net/ListHelp

>

___
Mailing list: https://launchpad.net/~kicad-developers

Post to     : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp





___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Andrzej Wolski]

3. It would be nice to have right click menu with something like:
     "Show all footprint related"
     "Hide all footprint related"
     "Show all free primitives"
     "Hide all free primitives"
     "Show all other???"
     "Hide all other???"
     "Show all"
     "Hide all"

Don't we already have something like this in the layer manager (see
attached image)?


Yes, but Render tab should have separate menu.




4. State of some checkboxes is not saved.

I think only the layer visibility states are saved in the board file.  I
would rather not add any more non-board related information the board
file format than is already there.  This state information could be
saved in the project file or the application config file.  My preference
is the project file but it's not a strong preference.


Checkboxes which do not preserve state are: Through Hole Pads, Tracks, 
Non Plated Holes.
They all have separate layers, which I think are already in bitfield in 
a board file, so that won't be a problem.


I did not check if all colors are preserved.

Cheers,
Andrzej


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build failed in Jenkins: kicad-qa #3626

[Miguel Angel Ajo]

See 

Changes:

[jean-pierre charras] Add inc/dec current layer alpha to menus.

--
Started by an SCM change
Building remotely on debian8 (clang gcc linux) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://github.com/KiCad/kicad-source-mirror.git # timeout=10
Fetching upstream changes from https://github.com/KiCad/kicad-source-mirror.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/KiCad/kicad-source-mirror.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 4dda8a39fe3826875550f46644bc39228cfc10f2 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 4dda8a39fe3826875550f46644bc39228cfc10f2
Commit message: "Add inc/dec current layer alpha to menus."
 > git rev-list --no-walk 2e42d5c0065c2c0b4a537f48fca8746c4f61548a # timeout=10
[kicad-qa] $ /bin/sh -xe /tmp/jenkins2062894022264442682.sh
+ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
+ gcc --version
gcc (Debian 4.9.2-10) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ env
+ grep -q ^MAKEJOBS=
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] Built target lib_table_lexer_source_files
[  0%] Built target idf3
[  0%] Built target pcb_plot_lexer_source_files
[  0%] Built target netlist_lexer_source_files
[  2%] Built target kicad_3dsg
[  2%] Built target pcb_lexer_source_files
[  2%] Built target page_layout_lexer_source_files
[  2%] Generating version string header
[  5%] Built target gal
-- Using Git to determine build version string.
[  5%] Built target lib_dxf
-- Found Git: /usr/bin/git (found version "2.1.4") 
[  5%] Built target specctra_lexer_source_files
[  5%] Built target polygon
-- Writing 
 file with 
version: (5.0-dev-4141-g4dda8a3)
[  5%] Built target version_header
[ 49%] Built target bitmaps
Scanning dependencies of target pcbcommon
[ 49%] [ 49%] [ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/board_items_to_polygon_shape_transform.cpp.o
Building CXX object common/CMakeFiles/pcbcommon.dir/__/pcbnew/board_commit.cpp.o
Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_base_frame.cpp.o
Scanning dependencies of target common
[ 49%] Building CXX object 
common/CMakeFiles/common.dir/widgets/indicator_icon.cpp.o
[ 49%] Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
[ 50%] Building CXX object common/CMakeFiles/common.dir/confirm.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_board.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_dimension.cpp.o
In file included from /usr/include/c++/4.9/bits/hashtable.h:35:0,
 from /usr/include/c++/4.9/unordered_map:47,
 from 
:103,
 from 
:29,
 from 
:14,
 from 
:34,
 from 

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Andy Peters]

On Feb 22, 2018, at 7:58 AM, Jon Evans  wrote:
> 
> Currently some of the render visibility stuff is saved in the application 
> preferences, and some is not saved.
> I think if there are layers related to board item visibility that aren't 
> saved, saving them in the project or board makes more sense than saving in 
> the app config.

User perspective:

Saving the render visibility in the project or pcb file “touches” that file, so 
Kicad will want to save the file when you close the project or PCB. And then 
your source-code control system thinks that the file has been modified (because 
it was!). This sort of change has nothing to do with the design, it is only a 
rendering/display detail.

A common example: I often use pcbnew (or Altium, it has the same problem) to 
view a design, without intending to actually modify it. And when doing that, I 
often change layer visibility and such. When closing the pcb file, the user 
will be asked to save the file. “But all I did was look at different layers .. 
I didn’t change the design!” 

So, please, don’t keep layer visibility/rendering information in the pcb or 
project file!

-a

> 
> Re. 3, yes I think that same framework could be used to add some shortcuts 
> for the "render" side pretty easily.
> 
> Re. 2, seems reasonable, haven't looked at the code yet
> 
> I can probably tackle this but can also leave it to Andrzej if you are 
> interested in it.
> 
> @Wayne I guess the first patch can be merged now if you are OK with it, since 
> Jeff isn't worried about conflicts?
> 
> -Jon
> 
> On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh  > wrote:
> On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
> > If some work on Render panel is still being done, I would have some
> > suggestions:
> > 1. "Text Front" and "Text Back" should be renamed to something like
> > "Footpr. Text Front" It is misleading now.
> 
> I'm fine with this but please do not abbreviate the word footprint.
> 
> > 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are disabled
> > in design settings.
> 
> This makes sense as long as you do not couple the layer manager UI code
> to the board object code.
> 
> > 3. It would be nice to have right click menu with something like:
> > "Show all footprint related"
> > "Hide all footprint related"
> > "Show all free primitives"
> > "Hide all free primitives"
> > "Show all other???"
> > "Hide all other???"
> > "Show all"
> > "Hide all"
> 
> Don't we already have something like this in the layer manager (see
> attached image)?
> 
> > 4. State of some checkboxes is not saved.
> 
> I think only the layer visibility states are saved in the board file.  I
> would rather not add any more non-board related information the board
> file format than is already there.  This state information could be
> saved in the project file or the application config file.  My preference
> is the project file but it's not a strong preference.
> 
> >
> > If you can't, I could do some of these changes (if it's not too late for
> > them).
> >
> > Cheers,
> > Andrzej
> >
> >
> > W dniu 2018-02-22 o 05:39, Jon Evans pisze:
> >> Hi all,
> >>
> >> This patch rearranges the Render panel to be in a more logical order,
> >> and adds some whitespace.
> >> I divided it into three groupings:
> >> 1) footprint related
> >> 2) other board objects
> >> 3) non-board stuff like grid, ratlines, etc.
> >>
> >> I also bumped out the default size so that scrollbars aren't needed by
> >> default on my Linux system.
> >>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build failed in Jenkins: kicad-qa #3625

[Miguel Angel Ajo]

See 

Changes:

[Maciej Suminski] Do not allow selecting tracks if they are hidden

--
[...truncated 948 B...]
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 2e42d5c0065c2c0b4a537f48fca8746c4f61548a
Commit message: "Do not allow selecting tracks if they are hidden"
 > git rev-list --no-walk 2dfc35a9d65a324ed4fb00c61d9ad46fe747a9f5 # timeout=10
[kicad-qa] $ /bin/sh -xe /tmp/jenkins3414659525047298169.sh
+ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
+ gcc --version
gcc (Debian 4.9.2-10) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ grep -q ^MAKEJOBS=
+ env
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] Built target lib_table_lexer_source_files
[  0%] Built target idf3
[  2%] Built target kicad_3dsg
[  2%] Built target pcb_plot_lexer_source_files
[  2%] Built target netlist_lexer_source_files
[  2%] Built target pcb_lexer_source_files
[  2%] [  2%] Built target page_layout_lexer_source_files
Generating version string header
[  5%] -- Using Git to determine build version string.
Built target gal
[  5%] Built target lib_dxf
-- Found Git: /usr/bin/git (found version "2.1.4") 
[  5%] Built target specctra_lexer_source_files
[  5%] [ 49%] Built target polygon
Built target bitmaps
-- Writing 
 file with 
version: (5.0-dev-4140-g2e42d5c)
[ 49%] Built target version_header
Scanning dependencies of target common
Scanning dependencies of target pcbcommon
[ 49%] [ 50%] [ 50%] Building CXX object 
common/CMakeFiles/common.dir/confirm.cpp.o
Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
Building CXX object common/CMakeFiles/common.dir/footprint_info.cpp.o
[ 50%] Building CXX object common/CMakeFiles/pcbcommon.dir/fp_lib_table.cpp.o
[ 50%] Building CXX object common/CMakeFiles/common.dir/hash_eda.cpp.o
In file included from /usr/include/c++/4.9/bits/hashtable.h:35:0,
 from /usr/include/c++/4.9/unordered_map:47,
 from 
:103,
 from 
:29,
 from 
:14,
 from 
:34,
 from 
:35:
/usr/include/c++/4.9/bits/hashtable_policy.h: In instantiation of ‘struct 
std::__detail::__is_noexcept_hash’:
/usr/include/c++/4.9/type_traits:134:12:   required from ‘struct 
std::__and_, 
std::__detail::__is_noexcept_hash 
>’
/usr/include/c++/4.9/type_traits:145:38:   required from ‘struct 
std::__not_, 
std::__detail::__is_noexcept_hash 
> >’
/usr/include/c++/4.9/bits/unordered_map.h:100:66:   required from ‘class 
std::unordered_map’
:72:46:   required 
from here
/usr/include/c++/4.9/bits/hashtable_policy.h:85:33: error: no match for call to 
‘(const std::hash) (const KI_DIALOG::TYPE&)’
  noexcept(declval()(declval()))>
 ^
In file included from /usr/include/c++/4.9/bits/move.h:57:0,
 from /usr/include/c++/4.9/bits/stl_pair.h:59,
   

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

[Maciej Sumiński]

Good catch, thank you Andrzej. I have just committed your patch to the
master branch.

Cheers,
Orson

On 02/22/2018 02:43 PM, Andrzej Wolski wrote:
> Wayne,
> 
> thanks for merging. I have a complementary patch that fixes problem with
> selecting hidden tracks.
> 
> Cheers,
> Andrzej
> 
> 
> On 02/21/2018 08:40 PM, Wayne Stambaugh wrote:
>> Andrzej,
>>
>> I merged your patches.  Hopefully this will tamp down some of the layer
>> visibility complaints.  Thank you for your contribution to KiCad.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 2/21/2018 12:44 PM, Andrzej Wolski wrote:
>>> Wayne,
>>>
>>> in attachment all 3 patches I have, rebased.
>>>
>>> Cheers,
>>> Andrzej
>>>
>>>
>>> On 02/21/2018 05:45 PM, Wayne Stambaugh wrote:
 Andrzej,

 This patch does not apply cleanly.  Please rebase and resubmit it when
 you get a chance.

 Thanks,

 Wayne

 On 2/21/2018 11:27 AM, Andrzej Wolski wrote:
> Wayne,
>
> I have attached that patch to bug report whom which you messaged me,
> thought you will see it.
>
> I'm attaching it again in this email.
>
> Cheers,
> Andrzej
>
>
> On 02/21/2018 05:20 PM, Wayne Stambaugh wrote:
>> Andrzej,
>>
>> You have not replied to my last message about your original patch
>> that
>> you sent to the developers mailing list[1].  I need that one so I can
>> apply and test the rest of your layer visibility patches.  If you
>> want
>> these to make it into rc1, please send me this patch as an attachment
>> soon.  I am planning to branch rc1 by Friday at the latest.
>>
>> Cheers,
>>
>> Wayne
>>
>>
>> [1]: https://lists.launchpad.net/kicad-developers/msg34009.html
>>
>> On 2/19/2018 10:05 AM, Andrzej Wolski wrote:
>>> Patch (in attachment) for "Tracks" turned out to be very simple.
>>> If it gets accepted, I could make more of these.
>>>
>>> Andrzej
>>>
>>>
>>> On 02/19/2018 02:12 PM, Andrzej Wolski wrote:
 It would be also nice to have separate controls for:
 1. Tracks
 2. Drawing primitives (graphic lines, arcs, and circles)
 3. Zones
 4. Polygons
 5. Text (now there is control only for footprint text)
 6. Dimensions
 7. Plated holes

 That would make Render tab (almost) complete.

 Andrzej

 W dniu 2018-02-18 o 21:00, Jon Evans pisze:
> Hi all,
>
> Right now the behavior of the "Layer" and "Render" tabs of the
> layers
> widget are confusing to users, resulting in complaints on the
> forum
> and some bug reports:
>
> https://bugs.launchpad.net/kicad/+bug/1748181
> https://bugs.launchpad.net/kicad/+bug/1743890
>
> I could take a crack at fixing this (before or after 5.0
> depending on
> what the complexity ends up being) but before I write any code I
> wanted to propose how I think it should work.
>
> I think the visibility of any object should be the AND of layer
> visibility and render visibility.
>
> To get there:
>
> 1) In the Render tab, get rid of the distinction between
> front/back.
> For example "Pads Back" and "Pads Front" becomes just "Pads"
>
> 2) Change the visibility code so that an object is visible if (a)
> the
> associated Render setting is turned on for the type of object, and
> (b) at least one of the layers the object is on is enabled in the
> Layers tab.
>
> 3) (optionally) Rename "Render" to something more friendly like
> "Items" or "Item Types" to make it more clear to the user that
> this
> is where they can turn off the display of various types of
> items as
> opposed to various layerse
>
> If this plan is OK, I will start working out the details of how to
> get there.  Right now the Render tab is directly controlling the
> visibility of certain "GAL Layers" but unfortunately the set of
> objects that appears on one GAL layer is not always equal to
> the set
> of objects that the user would expect to turn on and off, as
> seen by
> the bug reports.  So, there will have to be some additional logic
> created to manage these settings beyond just turning on and off
> layers in the GAL.
>
> -Jon
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>>> ___
>>> Mailing 

[Kicad-developers] Build failed in Jenkins: kicad-qa #3622

[Miguel Angel Ajo]

See 

Changes:

[Maciej Suminski] Fix a copy-paste error in WX_HTML_REPORT_PANEL badges creator

--
Started by an SCM change
Building remotely on debian8 (clang gcc linux) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://github.com/KiCad/kicad-source-mirror.git # timeout=10
Fetching upstream changes from https://github.com/KiCad/kicad-source-mirror.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/KiCad/kicad-source-mirror.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 8a8b062d8e833d1dfa5c8694f78f199fa2ea2fba 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 8a8b062d8e833d1dfa5c8694f78f199fa2ea2fba
Commit message: "Fix a copy-paste error in WX_HTML_REPORT_PANEL badges creator"
 > git rev-list --no-walk fea71c9f8f02c59a05de19293a8ce5a55432527b # timeout=10
[kicad-qa] $ /bin/sh -xe /tmp/jenkins4939811258412707721.sh
+ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
+ gcc --version
gcc (Debian 4.9.2-10) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ env
+ grep -q ^MAKEJOBS=
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] Built target lib_table_lexer_source_files
[  0%] Built target idf3
[  2%] Built target kicad_3dsg
[  2%] Built target pcb_plot_lexer_source_files
[  2%] Built target netlist_lexer_source_files
[  2%] Built target pcb_lexer_source_files
[  2%] Built target page_layout_lexer_source_files
[  2%] Generating version string header
[  2%] -- Using Git to determine build version string.
Built target lib_dxf
[  5%] Built target gal
-- Found Git: /usr/bin/git (found version "2.1.4") 
[  5%] Built target specctra_lexer_source_files
[  5%] Built target polygon
-- Writing 
 file with 
version: (5.0-dev-4137-g8a8b062)
[ 49%] Built target bitmaps
[ 49%] Built target version_header
[ 54%] Built target pcbcommon
[ 56%] Built target pcad2kicadpcb
[ 61%] Built target 3d-viewer
Scanning dependencies of target common
[ 61%] [ 61%] [ 63%] [ 63%] Building CXX object 
common/CMakeFiles/common.dir/dialogs/wx_html_report_panel.cpp.o
Building CXX object common/CMakeFiles/common.dir/confirm.cpp.o
Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
Building CXX object common/CMakeFiles/common.dir/copy_to_clipboard.cpp.o
[ 63%] Building CXX object common/CMakeFiles/common.dir/draw_frame.cpp.o
[ 63%] Building CXX object common/CMakeFiles/common.dir/eda_doc.cpp.o
In file included from /usr/include/c++/4.9/bits/hashtable.h:35:0,
 from /usr/include/c++/4.9/unordered_map:47,
 from 
:103,
 from 
:29,
 from 
:14,
 from 
:34,
 from 
:35:
/usr/include/c++/4.9/bits/hashtable_policy.h: In instantiation of ‘struct 

[Kicad-developers] Build failed in Jenkins: kicad-qa #3623

[Miguel Angel Ajo]

See 

Changes:

[Maciej Suminski] Fix constant naming conflict in KI_DIALOG

--
Started by an SCM change
Building remotely on debian8 (clang gcc linux) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://github.com/KiCad/kicad-source-mirror.git # timeout=10
Fetching upstream changes from https://github.com/KiCad/kicad-source-mirror.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/KiCad/kicad-source-mirror.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 918ac567e5878af19038e8dbf2703b15f219f29e 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 918ac567e5878af19038e8dbf2703b15f219f29e
Commit message: "Fix constant naming conflict in KI_DIALOG"
 > git rev-list --no-walk 8a8b062d8e833d1dfa5c8694f78f199fa2ea2fba # timeout=10
[kicad-qa] $ /bin/sh -xe /tmp/jenkins6143164427287572658.sh
+ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
+ gcc --version
gcc (Debian 4.9.2-10) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ env
+ grep -q ^MAKEJOBS=
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] Built target lib_table_lexer_source_files
[  0%] Built target idf3
[  2%] Built target kicad_3dsg
[  2%] Built target pcb_plot_lexer_source_files
[  2%] Built target netlist_lexer_source_files
[  2%] Built target pcb_lexer_source_files
[  2%] Built target page_layout_lexer_source_files
[  2%] Generating version string header
[  2%] -- Using Git to determine build version string.
Built target lib_dxf
-- Found Git: /usr/bin/git (found version "2.1.4") 
[  2%] Built target specctra_lexer_source_files
[  2%] Built target polygon
[ 46%] -- Writing 
 file with 
version: (5.0-dev-4138-g918ac56)
Built target bitmaps
[ 46%] Built target version_header
Scanning dependencies of target gal
[ 46%] [ 46%] [ 46%] Building CXX object 
common/CMakeFiles/gal.dir/draw_panel_gal.cpp.o
Building CXX object 
common/CMakeFiles/gal.dir/gal/opengl/cached_container_ram.cpp.o
Building CXX object common/CMakeFiles/gal.dir/gal/opengl/vertex_manager.cpp.o
Scanning dependencies of target pcbcommon
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_base_frame.cpp.o
[ 46%] Building CXX object 
common/CMakeFiles/gal.dir/gal/opengl/gpu_manager.cpp.o
[ 46%] Building CXX object common/CMakeFiles/gal.dir/gal/opengl/utils.cpp.o
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_edge_mod.cpp.o
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_module.cpp.o
Linking CXX static library libgal.a
[ 49%] Built target gal
Scanning dependencies of target common
[ 49%] Building CXX object 
common/CMakeFiles/common.dir/dialogs/dialog_env_var_config.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_draw_panel_gal.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
[ 49%] Building CXX object common/CMakeFiles/common.dir/block_commande.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/sel_layer.cpp.o
[ 49%] Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
[ 50%] Building 

[Kicad-developers] Build failed in Jenkins: kicad-qa #3624

[Miguel Angel Ajo]

See 

Changes:

[Maciej Suminski] Fix a typo in KI_DIALOG::Title()

--
Started by an SCM change
Building remotely on debian8 (clang gcc linux) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://github.com/KiCad/kicad-source-mirror.git # timeout=10
Fetching upstream changes from https://github.com/KiCad/kicad-source-mirror.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/KiCad/kicad-source-mirror.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 2dfc35a9d65a324ed4fb00c61d9ad46fe747a9f5 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 2dfc35a9d65a324ed4fb00c61d9ad46fe747a9f5
Commit message: "Fix a typo in KI_DIALOG::Title()"
 > git rev-list --no-walk 918ac567e5878af19038e8dbf2703b15f219f29e # timeout=10
[kicad-qa] $ /bin/sh -xe /tmp/jenkins1295134944951034262.sh
+ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
+ gcc --version
gcc (Debian 4.9.2-10) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ + grep -q ^MAKEJOBS=
env
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] Built target lib_table_lexer_source_files
[  2%] [  2%] Built target idf3
Built target kicad_3dsg
[  2%] Built target pcb_plot_lexer_source_files
[  2%] Built target pcb_lexer_source_files
[  2%] Built target netlist_lexer_source_files
[  2%] Built target page_layout_lexer_source_files
[  2%] [  2%] Generating version string header
[  5%] Built target gal
Built target lib_dxf
-- Using Git to determine build version string.
-- Found Git: /usr/bin/git (found version "2.1.4") 
[  5%] [  5%] Built target specctra_lexer_source_files
Built target polygon
[ 49%] Built target bitmaps
-- Writing 
 file with 
version: (5.0-dev-4139-g2dfc35a)
[ 49%] Built target version_header
[ 54%] Built target pcbcommon
[ 56%] Built target pcad2kicadpcb
[ 61%] Built target 3d-viewer
Scanning dependencies of target common
[ 63%] [ 63%] [ 63%] [ 63%] Building CXX object 
common/CMakeFiles/common.dir/build_version.cpp.o
Building CXX object common/CMakeFiles/common.dir/confirm.cpp.o
Building CXX object common/CMakeFiles/common.dir/footprint_info.cpp.o
Building CXX object common/CMakeFiles/common.dir/eda_doc.cpp.o
[ 63%] Building CXX object common/CMakeFiles/common.dir/gestfich.cpp.o
In file included from /usr/include/c++/4.9/bits/hashtable.h:35:0,
 from /usr/include/c++/4.9/unordered_map:47,
 from 
:103,
 from 
:29,
 from 
:14,
 from 
:34,
 from 
:35:
/usr/include/c++/4.9/bits/hashtable_policy.h: In instantiation of ‘struct 
std::__detail::__is_noexcept_hash’:
/usr/include/c++/4.9/type_traits:134:12:   required from ‘struct 
std::__and_, 

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

[Andrzej Wolski]

Hi Jeff,

I mean tracks hidden with "Tracks" checkbox in Render tab.

Cheers,
Andrzej

W dniu 2018-02-22 o 16:39, Jeff Young pisze:

Hi Andrzej,

If you mean tracks under footprints, I think that’s already been fixed.  See 
https://bugs.launchpad.net/kicad/+bug/1646339.

Cheers,
Jeff.



On 22 Feb 2018, at 13:43, Andrzej Wolski  wrote:

Wayne,

thanks for merging. I have a complementary patch that fixes problem with 
selecting hidden tracks.

Cheers,
Andrzej


On 02/21/2018 08:40 PM, Wayne Stambaugh wrote:

Andrzej,

I merged your patches.  Hopefully this will tamp down some of the layer
visibility complaints.  Thank you for your contribution to KiCad.

Cheers,

Wayne

On 2/21/2018 12:44 PM, Andrzej Wolski wrote:

Wayne,

in attachment all 3 patches I have, rebased.

Cheers,
Andrzej


On 02/21/2018 05:45 PM, Wayne Stambaugh wrote:

Andrzej,

This patch does not apply cleanly.  Please rebase and resubmit it when
you get a chance.

Thanks,

Wayne

On 2/21/2018 11:27 AM, Andrzej Wolski wrote:

Wayne,

I have attached that patch to bug report whom which you messaged me,
thought you will see it.

I'm attaching it again in this email.

Cheers,
Andrzej


On 02/21/2018 05:20 PM, Wayne Stambaugh wrote:

Andrzej,

You have not replied to my last message about your original patch that
you sent to the developers mailing list[1].  I need that one so I can
apply and test the rest of your layer visibility patches.  If you want
these to make it into rc1, please send me this patch as an attachment
soon.  I am planning to branch rc1 by Friday at the latest.

Cheers,

Wayne


[1]: https://lists.launchpad.net/kicad-developers/msg34009.html

On 2/19/2018 10:05 AM, Andrzej Wolski wrote:

Patch (in attachment) for "Tracks" turned out to be very simple.
If it gets accepted, I could make more of these.

Andrzej


On 02/19/2018 02:12 PM, Andrzej Wolski wrote:

It would be also nice to have separate controls for:
1. Tracks
2. Drawing primitives (graphic lines, arcs, and circles)
3. Zones
4. Polygons
5. Text (now there is control only for footprint text)
6. Dimensions
7. Plated holes

That would make Render tab (almost) complete.

Andrzej

W dniu 2018-02-18 o 21:00, Jon Evans pisze:

Hi all,

Right now the behavior of the "Layer" and "Render" tabs of the
layers
widget are confusing to users, resulting in complaints on the forum
and some bug reports:

https://bugs.launchpad.net/kicad/+bug/1748181
https://bugs.launchpad.net/kicad/+bug/1743890

I could take a crack at fixing this (before or after 5.0
depending on
what the complexity ends up being) but before I write any code I
wanted to propose how I think it should work.

I think the visibility of any object should be the AND of layer
visibility and render visibility.

To get there:

1) In the Render tab, get rid of the distinction between front/back.
For example "Pads Back" and "Pads Front" becomes just "Pads"

2) Change the visibility code so that an object is visible if (a)
the
associated Render setting is turned on for the type of object, and
(b) at least one of the layers the object is on is enabled in the
Layers tab.

3) (optionally) Rename "Render" to something more friendly like
"Items" or "Item Types" to make it more clear to the user that this
is where they can turn off the display of various types of items as
opposed to various layerse

If this plan is OK, I will start working out the details of how to
get there.  Right now the Render tab is directly controlling the
visibility of certain "GAL Layers" but unfortunately the set of
objects that appears on one GAL layer is not always equal to the set
of objects that the user would expect to turn on and off, as seen by
the bug reports.  So, there will have to be some additional logic
created to manage these settings beyond just turning on and off
layers in the GAL.

-Jon


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

<0001-Do-not-allow-selecting-tracks-if-they-are-hidden.patch>___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing 

[Kicad-developers] Build failed in Jenkins: kicad-qa #3621

[Miguel Angel Ajo]

See 

Changes:

[Maciej Suminski] Converted zone drawing tools to store points in a 
SHAPE_LINE_CHAIN

[Maciej Suminski] WX_STATUS_POPUP refactor

[Maciej Suminski] Added STATUS_TEXT_POPUP for simple popup text display

[Maciej Suminski] Forbid drawing self-intersecting polygons.

[Maciej Suminski] KI_DIALOG: flexible way of creating dialogs, including "do 
not show

[Maciej Suminski] PNS: display a message in case of keep-out zone triangulation 
failure

[Maciej Suminski] Point Editor: prevent creation of self-intersecting polygons

[Maciej Suminski] Separate copper and graphical zone tools

--
[...truncated 4.52 KB...]
[ 46%] Building CXX object 
common/CMakeFiles/gal.dir/gal/opengl/gpu_manager.cpp.o
[ 46%] Building CXX object common/CMakeFiles/gal.dir/gal/opengl/utils.cpp.o
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/board_design_settings.cpp.o
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/board_items_to_polygon_shape_transform.cpp.o
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_board.cpp.o
[ 46%] Building CXX object common/CMakeFiles/gal.dir/gal/cairo/cairo_gal.cpp.o
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_board_item.cpp.o
Linking CXX static library libgal.a
[ 46%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_dimension.cpp.o
[ 49%] Built target gal
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_drawsegment.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_edge_mod.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_module.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/netclass.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/netinfo_item.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/netinfo_list.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_pad.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_pcb_target.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_pcb_text.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_text_mod.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_track.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/class_zone.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/collectors.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/connectivity_algo.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/connectivity_data.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/convert_drawsegment_list_to_polygon.cpp.o
[ 49%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/eagle_plugin.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/gpcb_plugin.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/kicad_clipboard.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/kicad_netlist_reader.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/kicad_plugin.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/legacy_netlist_reader.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/legacy_plugin.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/netlist_reader.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pad_custom_shape_functions.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pad_draw_functions.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_display_options.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_draw_panel_gal.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_netlist.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_painter.cpp.o
[ 50%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
[ 52%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_screen.cpp.o
[ 52%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_view.cpp.o
[ 52%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/ratsnest_data.cpp.o
[ 52%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/ratsnest_viewitem.cpp.o
[ 52%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/sel_layer.cpp.o
[ 52%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/__/pcbnew/zone_settings.cpp.o
[ 52%] Building CXX object 
common/CMakeFiles/pcbcommon.dir/widgets/widget_net_selector.cpp.o

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

[Jeff Young]

Hi Andrzej,

If you mean tracks under footprints, I think that’s already been fixed.  See 
https://bugs.launchpad.net/kicad/+bug/1646339.

Cheers,
Jeff.


> On 22 Feb 2018, at 13:43, Andrzej Wolski  wrote:
> 
> Wayne,
> 
> thanks for merging. I have a complementary patch that fixes problem with 
> selecting hidden tracks.
> 
> Cheers,
> Andrzej
> 
> 
> On 02/21/2018 08:40 PM, Wayne Stambaugh wrote:
>> Andrzej,
>> 
>> I merged your patches.  Hopefully this will tamp down some of the layer
>> visibility complaints.  Thank you for your contribution to KiCad.
>> 
>> Cheers,
>> 
>> Wayne
>> 
>> On 2/21/2018 12:44 PM, Andrzej Wolski wrote:
>>> Wayne,
>>> 
>>> in attachment all 3 patches I have, rebased.
>>> 
>>> Cheers,
>>> Andrzej
>>> 
>>> 
>>> On 02/21/2018 05:45 PM, Wayne Stambaugh wrote:
 Andrzej,
 
 This patch does not apply cleanly.  Please rebase and resubmit it when
 you get a chance.
 
 Thanks,
 
 Wayne
 
 On 2/21/2018 11:27 AM, Andrzej Wolski wrote:
> Wayne,
> 
> I have attached that patch to bug report whom which you messaged me,
> thought you will see it.
> 
> I'm attaching it again in this email.
> 
> Cheers,
> Andrzej
> 
> 
> On 02/21/2018 05:20 PM, Wayne Stambaugh wrote:
>> Andrzej,
>> 
>> You have not replied to my last message about your original patch that
>> you sent to the developers mailing list[1].  I need that one so I can
>> apply and test the rest of your layer visibility patches.  If you want
>> these to make it into rc1, please send me this patch as an attachment
>> soon.  I am planning to branch rc1 by Friday at the latest.
>> 
>> Cheers,
>> 
>> Wayne
>> 
>> 
>> [1]: https://lists.launchpad.net/kicad-developers/msg34009.html
>> 
>> On 2/19/2018 10:05 AM, Andrzej Wolski wrote:
>>> Patch (in attachment) for "Tracks" turned out to be very simple.
>>> If it gets accepted, I could make more of these.
>>> 
>>> Andrzej
>>> 
>>> 
>>> On 02/19/2018 02:12 PM, Andrzej Wolski wrote:
 It would be also nice to have separate controls for:
 1. Tracks
 2. Drawing primitives (graphic lines, arcs, and circles)
 3. Zones
 4. Polygons
 5. Text (now there is control only for footprint text)
 6. Dimensions
 7. Plated holes
 
 That would make Render tab (almost) complete.
 
 Andrzej
 
 W dniu 2018-02-18 o 21:00, Jon Evans pisze:
> Hi all,
> 
> Right now the behavior of the "Layer" and "Render" tabs of the
> layers
> widget are confusing to users, resulting in complaints on the forum
> and some bug reports:
> 
> https://bugs.launchpad.net/kicad/+bug/1748181
> https://bugs.launchpad.net/kicad/+bug/1743890
> 
> I could take a crack at fixing this (before or after 5.0
> depending on
> what the complexity ends up being) but before I write any code I
> wanted to propose how I think it should work.
> 
> I think the visibility of any object should be the AND of layer
> visibility and render visibility.
> 
> To get there:
> 
> 1) In the Render tab, get rid of the distinction between front/back.
> For example "Pads Back" and "Pads Front" becomes just "Pads"
> 
> 2) Change the visibility code so that an object is visible if (a)
> the
> associated Render setting is turned on for the type of object, and
> (b) at least one of the layers the object is on is enabled in the
> Layers tab.
> 
> 3) (optionally) Rename "Render" to something more friendly like
> "Items" or "Item Types" to make it more clear to the user that this
> is where they can turn off the display of various types of items as
> opposed to various layerse
> 
> If this plan is OK, I will start working out the details of how to
> get there.  Right now the Render tab is directly controlling the
> visibility of certain "GAL Layers" but unfortunately the set of
> objects that appears on one GAL layer is not always equal to the set
> of objects that the user would expect to turn on and off, as seen by
> the bug reports.  So, there will have to be some additional logic
> created to manage these settings beyond just turning on and off
> layers in the GAL.
> 
> -Jon
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>>> 

Re: [Kicad-developers] IPC-2581

[Wayne Stambaugh]

On 2/21/2018 8:43 PM, Ouabache Designworks wrote:
> 
> 
> On Wed, Feb 21, 2018 at 3:37 PM, Wayne Stambaugh  > wrote:
> 
> I'm not opposed to KiCad taking part in this it's just a simple matter
> of lack of time.  If someone else is interested in representing KiCad at
> these meetings, I would not be opposed to that it's just not going to be
> me.  I am completely out of free time to do any more than my current
> work load.
> 
> Cheers,
> 
> Wayne
> 
> 
> 
> Well I'm retired and have plenty of time on my hands so I will join as
> an individual and keep this group up
> to date with what you would have to do if you wanted to advertise
> compliance. I will not be an "official" representative
> for Kicad and will not make any claims that would commit this group to
> do anything  to comply with the standard. You
> will need to make that decision for your self
> 
> I have also been working with the IEEE-1685 IP-Xact folks and will keep
> you informed on how that standard can help you.
> 
> 
> 
> John Eaton
> 
> 

John,

I appreciate the the offer.  If there is any way I can help, I will do
my best.

Thanks,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Jon Evans]

Currently some of the render visibility stuff is saved in the application
preferences, and some is not saved.
I think if there are layers related to board item visibility that aren't
saved, saving them in the project or board makes more sense than saving in
the app config.

Re. 3, yes I think that same framework could be used to add some shortcuts
for the "render" side pretty easily.

Re. 2, seems reasonable, haven't looked at the code yet

I can probably tackle this but can also leave it to Andrzej if you are
interested in it.

@Wayne I guess the first patch can be merged now if you are OK with it,
since Jeff isn't worried about conflicts?

-Jon

On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh 
wrote:

> On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
> > If some work on Render panel is still being done, I would have some
> > suggestions:
> > 1. "Text Front" and "Text Back" should be renamed to something like
> > "Footpr. Text Front" It is misleading now.
>
> I'm fine with this but please do not abbreviate the word footprint.
>
> > 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are disabled
> > in design settings.
>
> This makes sense as long as you do not couple the layer manager UI code
> to the board object code.
>
> > 3. It would be nice to have right click menu with something like:
> > "Show all footprint related"
> > "Hide all footprint related"
> > "Show all free primitives"
> > "Hide all free primitives"
> > "Show all other???"
> > "Hide all other???"
> > "Show all"
> > "Hide all"
>
> Don't we already have something like this in the layer manager (see
> attached image)?
>
> > 4. State of some checkboxes is not saved.
>
> I think only the layer visibility states are saved in the board file.  I
> would rather not add any more non-board related information the board
> file format than is already there.  This state information could be
> saved in the project file or the application config file.  My preference
> is the project file but it's not a strong preference.
>
> >
> > If you can't, I could do some of these changes (if it's not too late for
> > them).
> >
> > Cheers,
> > Andrzej
> >
> >
> > W dniu 2018-02-22 o 05:39, Jon Evans pisze:
> >> Hi all,
> >>
> >> This patch rearranges the Render panel to be in a more logical order,
> >> and adds some whitespace.
> >> I divided it into three groupings:
> >> 1) footprint related
> >> 2) other board objects
> >> 3) non-board stuff like grid, ratlines, etc.
> >>
> >> I also bumped out the default size so that scrollbars aren't needed by
> >> default on my Linux system.
> >>
> >> -Jon
> >>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Wayne Stambaugh]

On 2/22/2018 9:10 AM, Andrzej Wolski wrote:
> If some work on Render panel is still being done, I would have some
> suggestions:
> 1. "Text Front" and "Text Back" should be renamed to something like
> "Footpr. Text Front" It is misleading now.

I'm fine with this but please do not abbreviate the word footprint.

> 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are disabled
> in design settings.

This makes sense as long as you do not couple the layer manager UI code
to the board object code.

> 3. It would be nice to have right click menu with something like:
>     "Show all footprint related"
>     "Hide all footprint related"
>     "Show all free primitives"
>     "Hide all free primitives"
>     "Show all other???"
>     "Hide all other???"
>     "Show all"
>     "Hide all"

Don't we already have something like this in the layer manager (see
attached image)?

> 4. State of some checkboxes is not saved.

I think only the layer visibility states are saved in the board file.  I
would rather not add any more non-board related information the board
file format than is already there.  This state information could be
saved in the project file or the application config file.  My preference
is the project file but it's not a strong preference.

> 
> If you can't, I could do some of these changes (if it's not too late for
> them).
> 
> Cheers,
> Andrzej
> 
> 
> W dniu 2018-02-22 o 05:39, Jon Evans pisze:
>> Hi all,
>>
>> This patch rearranges the Render panel to be in a more logical order,
>> and adds some whitespace.
>> I divided it into three groupings:
>> 1) footprint related
>> 2) other board objects
>> 3) non-board stuff like grid, ratlines, etc.
>>
>> I also bumped out the default size so that scrollbars aren't needed by
>> default on my Linux system.
>>
>> -Jon
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Andrzej Wolski]

If some work on Render panel is still being done, I would have some 
suggestions:
1. "Text Front" and "Text Back" should be renamed to something like 
"Footpr. Text Front" It is misleading now.
2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are disabled 
in design settings.

3. It would be nice to have right click menu with something like:
    "Show all footprint related"
    "Hide all footprint related"
    "Show all free primitives"
    "Hide all free primitives"
    "Show all other???"
    "Hide all other???"
    "Show all"
    "Hide all"
4. State of some checkboxes is not saved.

If you can't, I could do some of these changes (if it's not too late for 
them).


Cheers,
Andrzej


W dniu 2018-02-22 o 05:39, Jon Evans pisze:

Hi all,

This patch rearranges the Render panel to be in a more logical order, 
and adds some whitespace.

I divided it into three groupings:
1) footprint related
2) other board objects
3) non-board stuff like grid, ratlines, etc.

I also bumped out the default size so that scrollbars aren't needed by 
default on my Linux system.


-Jon


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

[Andrzej Wolski]

Wayne,

thanks for merging. I have a complementary patch that fixes problem with 
selecting hidden tracks.


Cheers,
Andrzej


On 02/21/2018 08:40 PM, Wayne Stambaugh wrote:

Andrzej,

I merged your patches.  Hopefully this will tamp down some of the layer
visibility complaints.  Thank you for your contribution to KiCad.

Cheers,

Wayne

On 2/21/2018 12:44 PM, Andrzej Wolski wrote:

Wayne,

in attachment all 3 patches I have, rebased.

Cheers,
Andrzej


On 02/21/2018 05:45 PM, Wayne Stambaugh wrote:

Andrzej,

This patch does not apply cleanly.  Please rebase and resubmit it when
you get a chance.

Thanks,

Wayne

On 2/21/2018 11:27 AM, Andrzej Wolski wrote:

Wayne,

I have attached that patch to bug report whom which you messaged me,
thought you will see it.

I'm attaching it again in this email.

Cheers,
Andrzej


On 02/21/2018 05:20 PM, Wayne Stambaugh wrote:

Andrzej,

You have not replied to my last message about your original patch that
you sent to the developers mailing list[1].  I need that one so I can
apply and test the rest of your layer visibility patches.  If you want
these to make it into rc1, please send me this patch as an attachment
soon.  I am planning to branch rc1 by Friday at the latest.

Cheers,

Wayne


[1]: https://lists.launchpad.net/kicad-developers/msg34009.html

On 2/19/2018 10:05 AM, Andrzej Wolski wrote:

Patch (in attachment) for "Tracks" turned out to be very simple.
If it gets accepted, I could make more of these.

Andrzej


On 02/19/2018 02:12 PM, Andrzej Wolski wrote:

It would be also nice to have separate controls for:
1. Tracks
2. Drawing primitives (graphic lines, arcs, and circles)
3. Zones
4. Polygons
5. Text (now there is control only for footprint text)
6. Dimensions
7. Plated holes

That would make Render tab (almost) complete.

Andrzej

W dniu 2018-02-18 o 21:00, Jon Evans pisze:

Hi all,

Right now the behavior of the "Layer" and "Render" tabs of the
layers
widget are confusing to users, resulting in complaints on the forum
and some bug reports:

https://bugs.launchpad.net/kicad/+bug/1748181
https://bugs.launchpad.net/kicad/+bug/1743890

I could take a crack at fixing this (before or after 5.0
depending on
what the complexity ends up being) but before I write any code I
wanted to propose how I think it should work.

I think the visibility of any object should be the AND of layer
visibility and render visibility.

To get there:

1) In the Render tab, get rid of the distinction between front/back.
For example "Pads Back" and "Pads Front" becomes just "Pads"

2) Change the visibility code so that an object is visible if (a)
the
associated Render setting is turned on for the type of object, and
(b) at least one of the layers the object is on is enabled in the
Layers tab.

3) (optionally) Rename "Render" to something more friendly like
"Items" or "Item Types" to make it more clear to the user that this
is where they can turn off the display of various types of items as
opposed to various layerse

If this plan is OK, I will start working out the details of how to
get there.  Right now the Render tab is directly controlling the
visibility of certain "GAL Layers" but unfortunately the set of
objects that appears on one GAL layer is not always equal to the set
of objects that the user would expect to turn on and off, as seen by
the bug reports.  So, there will have to be some additional logic
created to manage these settings beyond just turning on and off
layers in the GAL.

-Jon


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


>From 225e8641fbeffd39f7e2e17cff397a0a70cf22cf Mon Sep 17 00:00:00 2001
From: Andrzej Wolski 
Date: Thu, 22 Feb 2018 07:53:16 +0100
Subject: [PATCH 1/2] Do not allow selecting tracks if they are hidden
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="2.7.4"

This is a multi-part message in MIME format.
--2.7.4
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit


This is a complementary patch to dbafdd39.
---
 pcbnew/collectors.cpp   |  2 ++
 pcbnew/collectors.h | 10 ++
 pcbnew/pcb_base_frame.cpp   |  1 +
 pcbnew/tools/selection_tool.cpp |  8 
 4 files changed, 21 insertions(+)


--2.7.4

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

[Wayne Stambaugh]

Jon,

I'm fine with the rearranging but I think Jeff is doing some work on the
layer manager.  You might want to coordinate with him to make sure you
don't end up with a big merge clash.

Cheers,

Wayne

On 2/21/2018 11:39 PM, Jon Evans wrote:
> Hi all,
> 
> This patch rearranges the Render panel to be in a more logical order,
> and adds some whitespace.
> I divided it into three groupings:
> 1) footprint related
> 2) other board objects
> 3) non-board stuff like grid, ratlines, etc.
> 
> I also bumped out the default size so that scrollbars aren't needed by
> default on my Linux system.
> 
> -Jon
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

[Wayne Stambaugh]

Jon,

This fixed the issue so I merged your patch.  Thanks.

Wayne

On 2/21/2018 8:46 PM, Jon Evans wrote:
> Here's a patch that fixes the issues observed.
> I have changed the algorithm to a simpler one that should be more
> bulletproof.
> I think the optimal approach for complicated footprints is still not
> this way, but that would require more time to tweak and optimize (i.e.
> generating some kind of bounding hull that is non-convex, and caching it
> until the shape changes)
> 
> You can see the new patch on Andrzej's test files here:
> https://imgur.com/a/L16ky
> Purple shows the bounding boxes, yellow shows the selectable area under
> the new algorithm. 
> ​
> -Jon
> 
> On Wed, Feb 21, 2018 at 1:41 PM, Wayne Stambaugh  > wrote:
> 
> If you could get it done by Friday before I roll out rc1, that's fine.
> 
> Wayne
> 
> On 2/21/2018 1:37 PM, Jon Evans wrote:
> > I'll be able to look at it this evening.  Can report then whether or not
> > I will have a patch tonight.  Up to you whether or not that is too long
> > of a delay.
> >
> > -Jon
> >
> > On Wed, Feb 21, 2018 at 1:32 PM, Wayne Stambaugh  
> > >> wrote:
> >
> >     Jon,
> >
> >     Would you please take a look at this as soon as possible?  If
> you cannot
> >     get to it in a reasonable amount of time, please let me know
> so I can
> >     back out your polygon hit test patch.  We need to be able to
> select
> >     footprints.
> >
> >     Thanks,
> >
> >     Wayne
> >
> >     On 2/21/2018 11:41 AM, Andrzej Wolski wrote:
> >     > After this patch, I can no longer select some footprints by
> clicking
> >     > inside their area.
> >     > Please see the board in an attachment.
> >     >
> >     > Andrzej
> >     >
> >     > W dniu 2018-02-20 o 16:44, Wayne Stambaugh pisze:
> >     >> Jon,
> >     >>
> >     >> I merged your patch.
> >     >>
> >     >> Thanks,
> >     >>
> >     >> Wayne
> >     >>
> >     >> On 2/18/2018 7:01 PM, Jon Evans wrote:
> >     >>> Hi Wayne,
> >     >>>
> >     >>> In my testing there is no performance impact, but more
> testing is
> >     >>> welcome.  It shouldn't be doing the calculation on too many
> >     objects in
> >     >>> general, since this is a "second pass" hit test that
> applies to
> >     modules
> >     >>> that have a bounding box overlapping the mouse cursor.
> >     >>> However, I did some more testing and discovered some weird
> >     behavior, so
> >     >>> I have tweaked the algorithm in the attached new version
> of the
> >     patch.
> >     >>>
> >     >>> -Jon
> >     >>>
> >     >>> On Sun, Feb 18, 2018 at 5:25 PM, Wayne Stambaugh
> >     
> >
> >     >>> 
>  >     >>>
> >     >>>  Hey Jon,
> >     >>>
> >     >>>  Did you notice an performance hit with your patch? 
> >     Obviously there
> >     >>>  is going to be more overhead calculating a polygon
> versus a
> >     >>>  rectangle.  I just want to be sure we are not causing any
> >     usability
> >     >>>  issues due to the polygon calculations.
> >     >>>
> >     >>>  Thanks,
> >     >>>
> >     >>>  Wayne
> >     >>>
> >     >>>
> >     >>>  On 02/18/2018 12:10 PM, Jon Evans wrote:
> >     >>>
> >     >>>  Hi all,
> >     >>>
> >     >>>  The attached patch adds some plumbing to
> calculate and
> >     make use
> >     >>>  of a polygonal bounding area for modules.  It
> fixes the
> >     below
> >     >>>  issue and in general improves the accuracy of
> selection
> >     in my
> >     >>>  testing.
> >     >>>
> >     >>>  This mechanism could be extended to other objects
> besides
> >     >>>  modules if it's useful.  I figured I'd start by
> sending out
> >     >>> this
> >     >>>  patch to get feedback, and if it gets merged,
> look for
> >     other
> >     >>>  areas where we could improve things by using polygons
> >     >>> instead of
> >     >>>  bounding boxes.
> >     >>>
> >     >>>  https://bugs.launchpad.net/kicad/+bug/1749077
> 
> >      

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

[Andrzej Wolski]

It works fine now, thanks.

Andrzej

W dniu 2018-02-22 o 02:46, Jon Evans pisze:

Here's a patch that fixes the issues observed.
I have changed the algorithm to a simpler one that should be more 
bulletproof.
I think the optimal approach for complicated footprints is still not 
this way, but that would require more time to tweak and optimize (i.e. 
generating some kind of bounding hull that is non-convex, and caching 
it until the shape changes)


You can see the new patch on Andrzej's test files here:
https://imgur.com/a/L16ky
Purple shows the bounding boxes, yellow shows the selectable area 
under the new algorithm.

​
-Jon

On Wed, Feb 21, 2018 at 1:41 PM, Wayne Stambaugh > wrote:


If you could get it done by Friday before I roll out rc1, that's fine.

Wayne

On 2/21/2018 1:37 PM, Jon Evans wrote:
> I'll be able to look at it this evening.  Can report then
whether or not
> I will have a patch tonight.  Up to you whether or not that is
too long
> of a delay.
>
> -Jon
>
> On Wed, Feb 21, 2018 at 1:32 PM, Wayne Stambaugh

> >> wrote:
>
>     Jon,
>
>     Would you please take a look at this as soon as possible? 
If you cannot
>     get to it in a reasonable amount of time, please let me know
so I can
>     back out your polygon hit test patch.  We need to be able to
select
>     footprints.
>
>     Thanks,
>
>     Wayne
>
>     On 2/21/2018 11:41 AM, Andrzej Wolski wrote:
>     > After this patch, I can no longer select some footprints
by clicking
>     > inside their area.
>     > Please see the board in an attachment.
>     >
>     > Andrzej
>     >
>     > W dniu 2018-02-20 o 16:44, Wayne Stambaugh pisze:
>     >> Jon,
>     >>
>     >> I merged your patch.
>     >>
>     >> Thanks,
>     >>
>     >> Wayne
>     >>
>     >> On 2/18/2018 7:01 PM, Jon Evans wrote:
>     >>> Hi Wayne,
>     >>>
>     >>> In my testing there is no performance impact, but more
testing is
>     >>> welcome.  It shouldn't be doing the calculation on too many
>     objects in
>     >>> general, since this is a "second pass" hit test that
applies to
>     modules
>     >>> that have a bounding box overlapping the mouse cursor.
>     >>> However, I did some more testing and discovered some weird
>     behavior, so
>     >>> I have tweaked the algorithm in the attached new version
of the
>     patch.
>     >>>
>     >>> -Jon
>     >>>
>     >>> On Sun, Feb 18, 2018 at 5:25 PM, Wayne Stambaugh
>     
>
>     >>>       >>>
>     >>>  Hey Jon,
>     >>>
>     >>>  Did you notice an performance hit with your patch?
>     Obviously there
>     >>>  is going to be more overhead calculating a polygon
versus a
>     >>>  rectangle.  I just want to be sure we are not
causing any
>     usability
>     >>>  issues due to the polygon calculations.
>     >>>
>     >>>  Thanks,
>     >>>
>     >>>  Wayne
>     >>>
>     >>>
>     >>>  On 02/18/2018 12:10 PM, Jon Evans wrote:
>     >>>
>     >>>  Hi all,
>     >>>
>     >>>  The attached patch adds some plumbing to
calculate and
>     make use
>     >>>  of a polygonal bounding area for modules.  It
fixes the
>     below
>     >>>  issue and in general improves the accuracy of
selection
>     in my
>     >>>  testing.
>     >>>
>     >>>  This mechanism could be extended to other
objects besides
>     >>>  modules if it's useful. I figured I'd start by
sending out
>     >>> this
>     >>>  patch to get feedback, and if it gets merged,
look for
>     other
>     >>>  areas where we could improve things by using
polygons
>     >>> instead of
>     >>>  bounding boxes.
>     >>>
>     >>> https://bugs.launchpad.net/kicad/+bug/1749077

>     >
>     >>>  
>     >>
>     >>>
  

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

[miles mccoo]

So I'd like to help out and take a look, but getting wxphoenix with gtk2 is
proving a bit challenging. I did manage to install something (albeit the
wrong one) in the past.

Nick, what command did you use to install?


Miles


I have a fresh virtual ubuntu 16.04 install.

I think I ran my normal pkg installs.

sudo apt-get -y install libwxgtk3.0-0v5 libglew-dev libcairo2-dev
libbz2-dev doxygen libssl-dev libboost-dev libboost-thread-dev
libboost-context-dev libboost-filesystem-dev libboost-iostreams-dev
libboost-locale-dev libboost-program-options-dev swig python-wxgtk3.0*
git cmake libwxgtk3.0 libglm-dev libcurl3 libcurl3-dev python-dev


I ran the installs recommended on the wxpython page
sudo apt install  dpkg-dev build-essential libjpeg-dev libtiff-dev
libsdl1.2-dev libgstreamer-plugins-base0.10-dev libnotify-dev freeglut3
freeglut3-dev libsm-dev

sudo apt-get -y install libwxgtk3.0-0v5 libglew-dev libcairo2-dev
libbz2-dev doxygen libssl-dev libboost-dev libboost-thread-dev
libboost-context-dev libboost-filesystem-dev libboost-iostreams-dev
libboost-locale-dev libboost-program-options-dev swig python-wxgtk3.0*
git cmake libwxgtk3.0 libglm-dev libcurl3 libcurl3-dev python-dev

I later removed wx with gtk3 which was somehow part of my standard installs

sudo apt remove libwxgtk3.0
sudo apt remove python-wxgtk3.0*


sudo apt-get install libgtk2.0-dev
sudo apt install libwebkitgtk-dev

wget
https://wxpython.org/Phoenix/snapshot-builds/wxPython-4.0.2a1.dev3684+086967a.tar.gz

sudo pip install --upgrade --pre -f wxPython-4.0.2a1.dev3684+086967a.tar.gz
wxPython


I get a bunch of spew including these:

Configure options: ['--enable-unicode', '--with-gtk=3',
'--with-opengl', '--enable-sound', '--enable-graphics_ctx',
'--enable-mediactrl', '--enable-display', '--enable-geometry',
'--enable-debug_flag', '--enable-optimise', '--disable-debugreport',
'--enable-uiactionsim', '--with-sdl']
/tmp/pip-build-W4npQK/wxPython/ext/wxWidgets/configure --enable-unicode
--with-gtk=3 --with-opengl --enable-sound --enable-graphics_ctx
--enable-mediactrl --enable-display --enable-geometry --enable-debug_flag
--enable-optimise --disable-debugreport --enable-uiactionsim --with-sdl


   checking for GTK+ - version >= 3.0.0... Package gtk+-3.0 was not found
in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-3.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-3.0' found
no
*** Could not run GTK+ test program, checking why...
*** The test program failed to compile or link. See the file config.log
for the
*** exact error that occured. This usually means GTK+ is incorrectly
installed.
configure: error:
The development files for GTK+ were not found. For GTK+ 2, please
ensure that pkg-config is in the path and that gtk+-2.0.pc is
installed. For GTK+ 1.2 please check that gtk-config is in the path,
and that the version is 1.2.3 or above. Also check that the
libraries returned by 'pkg-config gtk+-2.0 --libs' or 'gtk-config
--libs' are in the LD_LIBRARY_PATH or equivalent.



pkg-config seems to be ok
pkg-config gtk+-2.0 --libs
-lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo
-lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0
-lglib-2.0 -lfontconfig -lfreetype







On Fri, Feb 16, 2018 at 8:13 PM, Carsten Schoenert 
wrote:

> Hello Wayne,
>
> as Nick has written about a different part in this thread ...
>
> Am 24.11.17 um 14:00 schrieb Wayne Stambaugh:
> > I'm surprised there is no RFP for phoenix yet given that it will (has)
> > become the replacement for wxpython.  wxpython is a dead code base as
> > far as I know.  I certainly can create an RFP for phoenix but I am in no
> > position to actually help with the packaging.
>
> Everybody can open up a RFP in Debian, so $somebody just needs to it. :-)
>
> But, in the between time a ITP (Intent To Package) was opened for
> wxpython4.0 [1] some days ago. And since a few days a prepared binary
> package set is waiting in NEW [2] to get processed by the FTP Masters.
> So there is some light out there. ;)
>
> The upload was addressed into unstable so it should get into unstable
> and a few days later into testings once it gets accepted.
>
> [1] https://bugs.debian.org/888554
> [2] https://ftp-master.debian.org/new/wxpython4.0_4.0.1+dfsg-1.html
>
> --
> Regards
> Carsten Schoenert
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema patch, ngspice simulation bjt carac use case

[Maciej Sumiński]

Hi Ludovic,

Thank you very much for your simulator improvements, it looks very
promising. I see there is a lot of changes to the code and I am a bit
afraid to push it to the master branch right now, when we are so close
to v5 release. I am going to review it in details and merge it as soon
as v5 is out.

One thing that I have already spotted is that you have modified
dialog_*_base.cpp files. They are auto-generated, so it means your
changes will be overridden the next time someone regenerates the dialog
files. You should use wxFormBuilder to modify the corresponding .fbp
files instead. Fortunately the dialog files modifications are small, so
there is not much work wasted.

Regards,
Orson

On 02/22/2018 09:39 AM, ludovic léau-mercier wrote:
> Hi all,
> 
> i have a first version of several patch for an simulation use case :
> view bjt caracteristics.
> 
> You can found in attachment schematics, result and patch.
> 
> Now i would like create patch to create improvment in plot (legend and
> scale)
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Don't recache items unnecessarily when toggling D-code display

[Maciej Sumiński]

Hi Jon,

Thank you for the patch, I have just pushed it to the master branch.

Cheers,
Orson

On 02/22/2018 05:12 AM, Jon Evans wrote:
> Hi all,
> 
> This patch improves the logic for d-code display in GerbView so that there
> is now no cost in toggling the codes on or off.  They are still slow to
> render in huge files, but at least we only have the hit once when the file
> first is loaded.
> 
> -Jon
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp