[Koha-bugs] [Bug 9767] Fix for updatedatabase.pl (mixed version numbers)

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9767

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9767] Fix for updatedatabase.pl (mixed version numbers)

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9767

--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 15965
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15965action=edit
Bug 9767: Fix for updatedatabase.pl (mixed version numbers)

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9767] Fix for updatedatabase.pl (mixed version numbers)

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9767

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9767] Fix for updatedatabase.pl (mixed version numbers)

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9767

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Tested by manually resetting version number.
The warnings for 3.11.00.25 can be ignored. But now 24 was executed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9767] Fix for updatedatabase.pl (mixed version numbers)

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9767

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Taking the liberty to set to Passed QA for attention of RM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9767] Fix for updatedatabase.pl (mixed version numbers)

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9767

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Severity|enhancement |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #15947|0   |1
is obsolete||

--- Comment #27 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 15966
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15966action=edit
[SIGNED-OFF] Bug 6898 - circulation librarians can't run overdues without
reports permissions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

--- Comment #28 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #23)
 (In reply to comment #20)
  I set status to signed-off.
  Followup can be validated by QA ?
 
 Fridolyn, I don't see your SO on my original patch.
 
 Kyle

Here it is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

--- Comment #35 from Mirko Tietgen mi...@abunchofthings.net ---
Patches appear to be applied in the wrong order.

 4) Run through the make file, you will notice 5 new configuration options.

No, I don't. Am I missing something obvious?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 15967
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15967action=edit
Bug 9207 - Improve z39.50 speed slowdowns for sites with many records

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl ---
I tested the new index, but it is hard to say if it is really faster with just
a few thousand records in import_records.
I have timed with Time::HiRes a few times, and got slightly better results. But
just running the queries like _update_batch_record_counts does in mysql did not
really make a difference.
Nevertheless, I can imagine that this index makes a difference when you have
much more records.
Tested the upgrade.
Tested the install by running kohastructure partially from command-line.

Amended the patch for a small detail: there is no index in Koha with two
underscores in the name. So I removed one underscore.

No further QA comments: Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8244] Script to find exporter problems

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

--- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA: Looking at this one now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8244] Script to find exporter problems

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #23 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
koha-qa is happy.
Optional dependency is added.
In the above comments there was a discussion if the script should start running
if passed no parameters. For the record, I just note that it still does. (Not a
blocker.)
Available time does not allow me to dive into the details of PPI, TAP, etc. for
now. In order to really say something about this code, someone probably should.
But that might block this patch for long time.. (Pushing this isolated test
script will not hurt anyone :)

I still have three questions:

1) When running the script, I have lots of warnings like No plan found in TAP
output. For instance for admin/import_export_framework.pl.
Could you please clarify? Is this just a false positive?

2) For some other scripts, a reference is made to failed tests. E.g.
acqui/basketgroup.pl: Failed tests:  7-9.
As I understand, these should refer to not exported subroutines. How can I find
which ones? Are they routines in one of the 'used' modules? Documentation is
not very clear. Naming the routines would be very helpful. Note that running
the script without parameters will delete the temp dir right away; so I cannot
check it.

3) The usage statement says: For more information, open the file with a text
editor.. Which file?

I would like to pass qa on this patch. It has been here already too long. It
may need some follow-ups to provide more useful information, but that should
not block pushing this patch.
But before doing so, I would like to see your answers on the above three
questions.
For that reason I set this patch to Failed QA. After receiving your answers, I
will update the status again and add a signoff.

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

The natural sort works great.
The version 0.7 is available on http://www.datatables.net/plug-ins/sorting

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15959|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15968
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15968action=edit
Bug 9431 [Revised] Use DataTables on Patron Category Administration page

Replace the tablesorter plugin with the DataTables plugin on the
patron category administration page. Structural changes were made to the
table markup for validity and to deal with a DataTables bug which
prevents it from properly parsing a th with a colspan.

To test, open the Patron Category Administration page (Administration -
Patron types and categories). Confirm that table sorting works
correctly.

Revision adds a natural sort plugin to the main datatables
configuration JavaScript file to enable sorting of columns like those in
this table which include mixed numeric and text data. Allows correct
numeric sorting of data like 0 years, 1 years, 2 years, 18 years, etc.

Further revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Sorting works. No errors.
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA: Looking at this one now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hello Owen,

Don't you think we can delete the a links in headers?
Is it really relevant to keep sorting (without js) only on 1 table? (I suppose
it is for the case where javascript is disabled).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #13570|0   |1
is obsolete||
  Attachment #13574|0   |1
is obsolete||

--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 15969
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15969action=edit
Bug 4906 - Problem with grace period calculation and fine intervals 1

This patch adds the system preference FinesIncludeGracePeriod which
allows the library the choice to include the grace period when calculating
a fine ( Koha's current behavior ) or to ingore the grace period for
the purposes of fines calculation. It is set by default to preserve the
current behavior.

Signed-off-by: Srikanth Dhondi srika...@catalyst.net.nz

Rebased March 8, 2013. Included renaming pref. (marcelr)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15926|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 15926
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15926
Add robots txt file to deny all bots

not the good report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15766|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Switch back to Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Assignee|katrin.fisc...@bsz-bw.de|k...@bywatersolutions.com
Summary|Problem with grace period   |Allow fine calculation to
   |calculation and fine|exclude grace period
   |intervals 1|

--- Comment #19 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Changing the title of this report and opening a new bug for the original one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

--- Comment #20 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 15970
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15970action=edit
Bug 4906: Allow fine calculation to exclude grace period

This patch adds the system preference FinesIncludeGracePeriod which
allows the library the choice to include the grace period when calculating
a fine ( Koha's current behavior ) or to ignore the grace period for
the purposes of fines calculation. It is set by default to preserve the
current behavior.

Signed-off-by: Srikanth Dhondi srika...@catalyst.net.nz

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Rebased March 8, 2013. Included renaming pref.
Works as advertised. Renamed the bug title and opened a new report for the
original bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #15969|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9768] New: Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768

Bug ID: 9768
   Summary: Problem with grace period calculation and fine
intervals 1
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

With a fine interval  1 there is currently no way to avoid a effective grace
period. Fines can not start the day after the due date.

Configuration:
With grace period = 1
fine interval 5 (= weekly, the library is closed Sunday and Saturday)

Result:
The first fine ist set 7 days after the item was due.
Monday, checkout
Tuesday, item due
Wednesday
Thursday
Friday
Saturday, holiday
Sunday, holiday
Monday,
Tuesday, first fine

Grace period for fine intervals  1 should describe the days between the due
date and the day the first fine is set.

CalcFines() in Overdues.pm:
 266 my $days_minus_grace = $daystocharge - $data-{'firstremind'};
 267 if ($data-{'chargeperiod'}  0  $days_minus_grace  0 ) { 
 268 $amount = int($daystocharge / $data-{'chargeperiod'}) *
$data-{'fine'};

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768

--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Bug 4906 was originally meant for this problem, but went into another
direction.
Hopefully, Katrin still wants to look at this..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9768

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=4906

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Kyle probably should have opened a new report for this development some time
ago. I did now the other way around. Bug 9768 is the new old one :)

This patch works as advertised. Code looks good to me.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals 1

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #2)
 QA Comment:
 Kyle probably should have opened a new report for this development some time
 ago. I did now the other way around. Bug 9768 is the new old one :)
 
 This patch works as advertised. Code looks good to me.
 
 Passed QA

Yeah.. This should have been a comment at the other report..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Kyle probably should have opened a new report for this development some time
ago. I did now the other way around. Bug 9768 is the new old one :)

This patch works as advertised. Code looks good to me.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8054] can hit submit twice when paying fines

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8054] can hit submit twice when paying fines

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #14432|0   |1
is obsolete||

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 15971
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15971action=edit
Bug 8054 - double clicking can cause duplicate payments/fines

Uses preventDoubleForSubmit() to prevent double form submissions in the fines
module.

To test:

Create a manual invoice/fine
Create some manual fines, click save like mad - you should get only one fine
(without, you will get several if you click madly enough)

Click Pay fines
Pay some fines, clicking save like mad on each. You should only get one
payment. (without, you will get several payments)

Create a manual credit
Create a credit, click save like mad. You should only get one credit. (without
you will get several if you click madly enough)

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8054] can hit submit twice when paying fines

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||m.de.r...@rijksmuseum.nl

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Seems to work fine although I may not be that good in madly clicking..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

--- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Can someone who tested this explain in a few words where the difference is
between Kyle's change and what the bug was intended to do? I am a bit confused
at this point :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
   Patch complexity|--- |Trivial patch
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

Maybe it would be easy not to use this dependency and implement a simple
routine to do the same thing (in order to avoid an additional dependency).
But that's not really the question here.

This patch marks the String::Random module as mandatory.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8054] can hit submit twice when paying fines

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Small changes. Using existing jquery to prevent double submission. Improving
usability (foolproof..)

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8054] can hit submit twice when paying fines

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054

--- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Small changes. Using existing jquery to prevent double submission. Improving
usability (foolproof..)

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15804|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15972
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15972action=edit
Bug 9734 - String::Random is marked as optional, but C4::Members requires it

jcamins confirmed on IRC it is not optional.

To test:
1) perl koha_perl_deps.pl -a |grep String::Random
2) notice the No in the last column - it should be Yes
3) apply patch and repeat same steps, looking for Yes.
4) prove t/Installer_PerlModules.t # which checks String::Random is required

Sponsored-by: software.coop
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8054] can hit submit twice when paying fines

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054

--- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Better in midair collisions :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15942|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9767] Fix for updatedatabase.pl (mixed version numbers)

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9767

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9766] Remove YUI menu on budget planning page in favor of different column-hiding system

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9766

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Summary|Replace YUI menu on budget  |Remove YUI menu on budget
   |planning page with  |planning page in favor of
   |Bootstrap   |different column-hiding
   ||system

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9766] Remove YUI menu on budget planning page in favor of different column-hiding system

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9766

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 15973
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15973action=edit
Bug 9766 - Remove YUI menu on budget planning page in favor of different
column-hiding system

The budget planning table previously used a YUI menu as part of a
system for hiding and showing table columns. Instead of trying
to convert that sytem to Bootstrap I have used code from the
batch modification/deletion pages which uses a list of checkboxes
to show and hide table columns. This has the advantage of giving
the user visual feedback of what columns are hidden and of offering the
user an interface which is familiar from other pages.

This patch also moves CSS from a batch-operations-specific
CSS file into the main CSS file. Batch modification templates have been
modified accordingly.

To test, view the budget planning page and choose different
plan by options (by month, by library, by item type). Test
the show/hide action on each individual column and using the
show all and hide all checkboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9766] Remove YUI menu on budget planning page in favor of different column-hiding system

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9766

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

--- Comment #23 from Kyle M Hall k...@bywatersolutions.com ---
I think Paul explains it in comment 14. 

(In reply to comment #22)
 Can someone who tested this explain in a few words where the difference is
 between Kyle's change and what the bug was intended to do? I am a bit
 confused at this point :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13872|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15966|0   |1
is obsolete||

--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15974
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15974action=edit
Bug 6898 - circulation librarians can't run overdues without reports
permissions

Reuploading to correct patch order.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15948|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15975
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15975action=edit
Bug 6898 - circulation librarians can't run overdues without reports
permissions followup

Reuploading to correct patch order.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2699] Organization for Reports

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2699

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9117

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9117] Reports hierarchies management improvements

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=2699

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2699] Organization for Reports

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2699

--- Comment #1 from Sophie MEYNIEUX sophie.meyni...@biblibre.com ---
I don't know if Bug 9117 answer this need

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #13 from Mirko Tietgen mi...@abunchofthings.net ---
Installed Koha-common 3.10.3-1
created instances test1 and test2 with Marc21 and Normarc respectively
installed Norwegian language for test2 so I can choose Normarc in the web
installer
ran web installer
created a staff user
changed marcflavor to Normarc for test2
added some biblios, reindexed
searched test1 (marc21), all looks ok
searched test2 (normarc), got message »Feil: Can't call method raw on an
undefined value at /usr/share/koha/lib/C4/Search.pm line 471.«

Upgraded to my own package of master+9256
created instances test3 and test4 with Marc21 and Normarc respectively
installed Norwegian language for test4 so I can choose Normarc in the web
installer (needs to be done again or the layouts are broken!)
ran web installer
created a staff user
changed marcflavor to Normarc for test4

Unicode is broken in the patron type pulldown when you try to create a new
user. I have not looked around more, instead I tried searching.

added some biblios, reindexed
searched test3 (marc21), all looks ok
searched test4 (normarc), all looks ok.
(if you forget to change marcflavor syspref to Normarc, you will get the same
error as described for test2 instance)

So the patch seems to do what it is intended to do. I do not recall having seen
broken Unicode when creating a patron in the unpatched version (maybe I didn't
pay attention) and I want to have another look at it later but so far it's
looking good.

I have a repository with the package if somebody else would like to try it but
does not feel like going through the pain of building it themselves. I won't be
able to test for Unimarc problems for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #36 from Elliott Davis elli...@bywatersolutions.com ---
(In reply to comment #35)
 Patches appear to be applied in the wrong order.
 
  4) Run through the make file, you will notice 5 new configuration options.
 
 No, I don't. Am I missing something obvious?

They do seem to be in the wrong order in BZ.  The new configuration options are
Staff/OPAC DNS and port entries.

I think the problem with the merge was the incorrect order.  If you apply the
patches backwards it should be fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9769] New: Replace YUI buttons on acquisitions basket page

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769

Bug ID: 9769
   Summary: Replace YUI buttons on acquisitions basket page
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/acqui/basket.pl?basketno=
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

The toolbar buttons on the acquisitions basket page are constructed using YUI.
They should use Bootstrap instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #37 from Mirko Tietgen mi...@abunchofthings.net ---
Yes i did it backwards. I have seen the DNS and port options when running the
makefile, I thought there was some NGiNX option supposed to come up

 5) Make sure you choose NGiNX as your webserver

So this is not supposed to happen when I run the makefile?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

--- Comment #38 from Elliott Davis elli...@bywatersolutions.com ---
(In reply to comment #37) 
  5) Make sure you choose NGiNX as your webserver
 
 So this is not supposed to happen when I run the makefile?

This was in an older version of the patch.  It was removed at the request of
the RM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9769] Replace YUI buttons on acquisitions basket page with Bootstrap

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Summary|Replace YUI buttons on  |Replace YUI buttons on
   |acquisitions basket page|acquisitions basket page
   ||with Bootstrap

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9769] Replace YUI buttons on acquisitions basket page with Bootstrap

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9769] Replace YUI buttons on acquisitions basket page with Bootstrap

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 15976
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15976action=edit
Bug 9769 - Replace YUI buttons on acquisitions basket page with Bootstrap

Toolbar buttons on the acquisitions basket page are constructed by YUI.
They should use Bootstrap instead.

Other minor changes: Fixes for invalid markup.

To test, view baskets in various states: Empty, open closed. View
baskets in groups and not in groups. Buttons should look correct and
work correctly:

- Edit
- Delete
- Close
- Reopen
- Export

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

--- Comment #39 from Mirko Tietgen mi...@abunchofthings.net ---
I see. I did not read the whole backlog of the bug. It would be nice to have a
revised version of the test plan if it does not apply anymore. Are there more
changes to it that I should be aware of?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

--- Comment #40 from Elliott Davis elli...@bywatersolutions.com ---
that should be the only one.  

To Test:
1) Ensure that you have nginx installed
2) Esure that you have the following packages installed libplack-perl
libcgi-emulate-psgi-perl libcgi-compile-perl
3) Apply patch
4) Run through the make file, you will notice 4 new configuration options.
5) You may choose whatever ports you wish and also whatever DNS entries you
wish
6) After you're done configuring run make
7) Run make install (you may need sudo if you've used sudo before)
8) Start plack (you may wish to copy the script to init.d) with the script in
koha-dev/bin/koha-plack.sh (requires sudo)
9) TURN OFF APACHE, and start NGiNX
10) go to your web browser and see if everything fires up as normal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9770] New: C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770

Bug ID: 9770
   Summary: C4::ClassSortRoutine::Dewey can pad the wrong part of
a call number internally
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: ja...@esilibrary.com
CC: m.de.r...@rijksmuseum.nl

The subroutine get_class_sort_key tokenizes a call number string (splitting on
periods and whitespace) and counts the number of tokens that solely contain
digits.  If there is only one such digit group, a comment in the code states
that it will pad said digit group.  However, the bug is that the code assumes
said digit group is the first token, when this may not be the case.  Patch to
follow...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770

--- Comment #1 from Jason Etheridge ja...@esilibrary.com ---
Created attachment 15977
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15977action=edit
patch to Dewey.pm

I may need to try git send-email again; don't think I had mail configured on my
dev server.  I'm also not versed in Koha's unit testing, so haven't tried to
add a test yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com ---
Patch tested with a sandbox, by Marc Sabin marc.sa...@sciencespo-grenoble.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9765] Remove unused include file: budgetperiods-admin.inc

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9765

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15955|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15978
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15978action=edit
Bug 9765 - Remove unused include file: budgetperiods-admin.inc

budgetperiods-admin.inc doesn't appear to be used anywhere in Koha. This
patch removes it.

To test, confirm that a search for references to budgetperiods-admin.inc
returns no results.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #15766|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 15979
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15979action=edit
Bug 9685: Allow sort baskets by number

In acqui/booksellers.pl, first column of baskets tables is name (#number).
This allows to sort by name but not by numnber.

This patch splits acutal first column into 2 columns number and name to allow
sorting on number.
Sets default sort on name like existing.

Test plan:
Look at page and use sorting on name and n° columns.

Signed-off-by: Marc Sabin marc.sa...@sciencespo-grenoble.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9765] Remove unused include file: budgetperiods-admin.inc

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9765

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9771] New: Replace YUI buttons on acquisitions basket groups page with Bootstrap

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771

Bug ID: 9771
   Summary: Replace YUI buttons on acquisitions basket groups page
with Bootstrap
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/acqui/basketgroup.pl?booksellerid=
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

The toolbar on the acquisitions basket group page uses YUI to generate buttons
and menus. It should use Boostrap instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

--- Comment #46 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Can it be pushed to stable branches ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15932|0   |1
is obsolete||
  Attachment #15933|0   |1
is obsolete||
  Attachment #15951|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15980
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15980action=edit
Bug 9761: Make it possible to confirm future hold requests at checkin time

Description:
A new pref ConfirmFutureHolds is added. When confirming a hold at checkin time,
the number of days in this pref is taken into account when looking for
reserves.
Note that this pref does not interfere with renewing, issuing or transferring
a book. For report Holds to pull, the default end date is calculated with this
new preference.
The use of ConfirmFutureHolds is useful only when future holds are allowed.

Test plan:
1) Enable future holds. Add a number of days into ConfirmFutureHolds.
2) Place a future hold within this number of days.
3) Run holds to pull report. Check default startdate and enddate.
4) Check this book in. Can you confirm the hold? Do not confirm.
5) Issue the book to another patron. You should not see a warning.
6) Renew the book for this patron via opac or staff. No warning either.
7) Check in again. Warning pops up again.
8) Transfer book. Switch branch. Check in. Hold found pops up. Do not confirm.
9) Back to first branch. Check in (with popup). Remove the hold. Add new future
hold past the number of days. Check in (no warn).

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15981
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15981action=edit
Bug 9761: dbrev for ConfirmFutureHolds

Db rev for new pref ConfirmFutureHolds.

Test plan:
Run [your server]/cgi-bin/koha/installer/install.pl?step=3op=updatestructure
Optionally, run a new install to test sysprefs.sql.
Or:
Edit sysprefs.sql, leave at least the last few lines including the new one.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15982
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15982action=edit
Bug 9761: Reformulating the preference description

After some thought, I had to reformulate what this pref does.
No code changes here.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9760] Simplify local use preferences

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9760

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15928|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15983
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15983action=edit
Bug 9760: Simplify local use preferences

Removes a lot of code that was needed to handle prefs the old way.

Test plan:
Goto Local use preferences. Do you see some local preferences?
Add a new pref, edit and delete it.
Modify the url to systempreferences.pl?tab=OPAC or tab=log. You should only see
a short message.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9760] Simplify local use preferences

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9760

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9771] Replace YUI buttons on acquisitions basket groups page with Bootstrap

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9771] Replace YUI buttons on acquisitions basket groups page with Bootstrap

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 15984
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15984action=edit
Bug 9771 - Replace YUI buttons on acquisitions basket groups page with
Bootstrap

The acquisitions basket group page has a toolbar with YUI-generated
buttons and menus. It should use Bootstrap instead.

This patch removes the YUI menu buttons altogether, replacing that
functionality with the sidebar menu now included on other acquisitions
pages (See Bug 8913). The New basket group button is now styled by
Bootstrap.

Other minor changes: Corrections of invalid markup, improvement to
breadcrumbs.

To test, view the basket group page and confirm that the toolbar button
looks correct and works correctly. Confirm that navigation works and
that functionality of the basket group edit page is not affected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9759] last subfield can be deleted

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15927|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15985
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15985action=edit
Bug 9759: last subfield can be deleted

In authorities and biblios editors, a repeatable subfield can be deleted (small
icon next to input).
Clone subfields are really deleted but last existing subfield is just set empty
instead of deleted.
But when same field is repeated, the last subfield can be deleted.

This patch corrects this, last subfield of a field, even repeated, can not be
deleted.

Test plan :
- Edit a biblio
- Choose a repeatable field with a repeatable subfield : ie 600 and $x
- Edit 600, enter a text in $x : ie subA
- Clone $x
- Delete second $x
= second $x is deleted
- Delete first $x
= $x is not deleted but set empty
- Edit 600, enter a text in $x : ie subA
- Clone 600
- Edit second 600, enter a text in $x : ie subB
- Clone $x of second 600
- Delete second $x of second 600
= second $x of second 600 is deleted
- Delete first $x of second 600
= with this patch : first $x of second 600 is set empty
= without this patch : first $x of second 600 is deleted, second 600 has no $x
anymore
Perform same test plan on an authority.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Summary|Replace YUI button on   |Style button on notices and
   |notices and slips page with |slips page with Bootstrap
   |Bootstrap   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9759] last subfield can be deleted

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9748] noitemlinks not being enforced

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9751] Patron flags red in moremember.pl like in circulation.pl

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15903|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15986
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15986action=edit
Bug 9751: Patron flags red in moremember.pl like in circulation.pl

In a patron detail page (moremember.pl), when looking at a patron with one or
more flags.
Click on Check out tab and look at circulation page : flags are red. It is more
attractive for librarian.

This patch add CSS classes to patron flags in moremember.pl so they look more
like circulation.pl :
- red color
- custom list bullets

Test plan ;
- Set to a patron all flags.
- Go to detail page of this patron
= Check all flags are red and bullets are like 

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9751] Patron flags red in moremember.pl like in circulation.pl

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9751

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9772] New: Displayed Norwegian chars correctly in the patron category dropdown on the Patrons page

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9772

Bug ID: 9772
   Summary: Displayed Norwegian chars correctly in the patron
category dropdown on the Patrons page
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: mag...@enger.priv.no
  Reporter: mag...@enger.priv.no
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If you install the Norwegian sample data (specifically the sample patron
categories) and go to the Patrons page, then click on the patron category
dropdown to create a new patron, the Norwegian characters are displayed as
black diamonds with a question mark in them. 

As far as I can tell, the sample data should be OK, and when they are displayed
in Administration  Patron categories, they do look ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9772] Displayed Norwegian chars correctly in the patron category dropdown on the Patrons page

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9772

--- Comment #1 from Magnus Enger mag...@enger.priv.no ---
Created attachment 15987
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15987action=edit
Bug 9772 - Display Norwegian chars correctly in the patron category dropdown

To reproduce:
- Install Norwegian translation
- Run through the web installer in Norwegian, and make sure you choose
  the optionl (2-Valgfritt) patron_categories.sql data
- Log in and visit the Patrons page
- The dropdown should contain black diamonds with question marks instead
  of the Norwegian chars æøå

To test
- Apply the patch to the situation above
- Check the dropdown again - æøå should be displayed
- If you want to check with other interface languages than Norwegian,
  remember to re-install the nb-NO translation after the patch has been
  applied

This feels slightly like curing the symptom instead of the disease,
alternative patches are welcome!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9772] Displayed Norwegian chars correctly in the patron category dropdown on the Patrons page

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9772

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9555] Template files contain single quote strings

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15963|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15988
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15988action=edit
Bug 9555: Another template contains single quotes in a js string

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9555] Template files contain single quote strings

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9773] New: Replace YUI AJAX calls in cataloging plugins with jQuery

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773

Bug ID: 9773
   Summary: Replace YUI AJAX calls in cataloging plugins with
jQuery
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
CC: m.de.r...@rijksmuseum.nl

There are calls in a few cataloging plugins to YUI AJAX functions. These can be
replaced with jQuery code.

 cataloguing/value_builder/callnumber.pl
 cataloguing/value_builder/callnumber-KU.pl
 cataloguing/value_builder/stocknumberam123.pl
 cataloguing/value_builder/unimarc_field_010.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >