[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

--- Comment #1 from Marc Véron  ---
Created attachment 43218
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43218=edit
Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t

This patch removes C4::Dates from following files:

-  t/db_dependent/Budgets.t
-  t/db_dependent/Holds.t
-  t/db_dependent/Koha_template_plugin_KohaDates.t
-  t/db_dependent/Log.t
-  t/db_dependent/NewsChannels.t

To test:
- First run all tests above
- Apply patch
- Then run tests again. The results should be the same.
  (Note: I get 2 fails with NewsChannels.t, they are the same with
   and without patch).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12468] copyright symbol not translating right

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
This record exist in Library of Congress but don't have copyright date.

I've been searching another example but after an hour I found nothing.
Although a record with phonograph found in LC database with LCCN 2014618376 in
Koha searched with Standard ID. The record was successfully copied to the
default framework.

Maybe, like comments 3 and 4 only OCLC connexion got that problem. It seems to
be an UTF-8 problem.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14977] New: Remove C4::Dates from files t/db_dependent/*.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

Bug ID: 14977
   Summary: Remove C4::Dates from files t/db_dependent/*.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

This patch removes C4::Dates from following files:

-  t/db_dependent/Budgets.t
-  t/db_dependent/Holds.t
-  t/db_dependent/Koha_template_plugin_KohaDates.t
-  t/db_dependent/Log.t
-  t/db_dependent/NewsChannels.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch
   Assignee|gmcha...@gmail.com  |ve...@veron.ch
 Blocks||14870


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Depends on||14977


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977
[Bug 14977] Remove C4::Dates from files t/db_dependent/*.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #8 from Liz Rea  ---
I have seen double ups in issues on 3.20, probably because of this.

Example: 

+--+++-+-+-+
| issue_id | borrowernumber | itemnumber | date_due| timestamp 
 | issuedate   |
+--+++-+-+-+
|  1840368 |547 | 123292 | 2015-10-29 23:59:00 | 2015-10-08
10:09:20 | 2015-10-08 10:09:19 |
|  1840369 |547 | 123292 | 2015-10-29 23:59:00 | 2015-10-08
10:09:21 | 2015-10-08 10:09:20 |
+--+++-+-+-+

Because the ajax table is slow to load, sometimes extra careful staff members
scan things twice because they thought they didn't get it. Seems a bit odd that
it wouldn't prompt for renew instead of generating another issue, but there it
is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #11 from Héctor Eduardo Castro Avalos  
---
I was looking that there no info about this in documentation
, section
Advanced constraints or I don't know if this exist in another page.

I added here Documentation Manager.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #43069|0   |1
is obsolete||

--- Comment #12 from Héctor Eduardo Castro Avalos  
---
Created attachment 43215
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43215=edit
[SIGNED OFF]Bug 14922 - Remove C4::Dates from cataloguing/additem.pl

This patch removes C4::Dates from cataloguing/additem.pl

To test:

- In MARC bibliographic framework, define a default value
  for one of the in Tag 952 Subfield struture, e.g. for
  subfield x Non-public note. You can define it under
  'Advancde constraints'. Define the value similar to the following:
  Year: Month:MM Day:DD
- Create a new item for a biblio and verify that , MM and DD are
  replaced with today's values.
- Apply patch and repeat that previous step behaves as before.
- Verify that the overall functionality of the form is the same
  as before applying the patch.

Signed-off-by: Hector Castro 
Works as advertised. With the last script not accept more than MMDD
If you enter something else, the script sends to the end of line.
This patch follow up the pattern in constraint default value

Patch amended following comment #6  / mv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #43203|0   |1
is obsolete||

--- Comment #13 from Héctor Eduardo Castro Avalos  
---
Created attachment 43216
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43216=edit
[SIGNED-OFF]Bug 14922 - (followup) Fix string output

This patch makes  MM and DD display correctly.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #43065|0   |1
is obsolete||

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 43217
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43217=edit
[SIGNED-OFF]Bug 14924 - (follow-up) Add date validation using eval

This patch adds a date validation (see comment #3).

To test:

- Apply patch
- Create a new user or edit an existing user
- Try valid dates for date of birth
- Try invalid dates as -00-00 or 32/01/1970. You can can
  copy/paste such strings to the date field, ignore the warning
  message and submit. Verify that after submit you get a message
  "Date of birth is invalid"
- Try the same with enrollement /expiry dates

Signed-off-by: Hector Castro 
Works as advertised. Tested with invalid dates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #20 from Liz Rea  ---
This looks like it needs a rebase on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #11 from Julian Maurice  ---
Patches rebased on master.
Minor conflict resolved, switching back to Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #162 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #161)
> 6/ Koha::Borrowers->find is called in
> Koha::REST::V1::Borrowers::get_borrower and Koha::REST::V1->startup (?)

Forget that!
(I am hidden already).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #145 from Robin Sheat  ---
(In reply to Jonathan Druart from comment #141)
> Did you have time to look into the terms aggregations?
> Or maybe is it what you are already using?

Yeah, I'm aware of that. Unfortunately, it only became deprecated after I'd
implemented it, and I haven't got around to going back and reworking it. I
don't think it'll be a big change, it's possible it's sufficient to just switch
the ES type we're using. Anyway, I've put it on the "deal with later" pile.

(In reply to Jonathan Druart from comment #142)
> On a unimarc installation, there are no mapping at all for authorities.
> If an unimarc user follows this bug report...

Working out the MARC21 mappings was tedious enough :)

(In reply to Jonathan Druart from comment #143)
> Maybe I have not drunk enough tea this morning but...
> I am trying to improve the mappings area to have a consistent interface to
> manage them.
> The idea is to 1) move the elastic_mapping.sql to a elastic_mapping.json
> file (easier to modify and read), 2) provide methods to
> serialize/unserialize mappings and then 3) introduce a backup/import/reset
> mappings feature and finally 4) make easier the mapping progression to get a
> good basis to use ES.
> 
> I have managed to create a json file from the sql file, the structure is
> something like:
> 
> {
>   biblio => {
> title => {
>   label=> 'Title',
>   type => 'string',
>   mappings => [
> {
>   suggestible => 1,
>   facet   => 1,
>   marc21  => '245a',
>   unimarc => '200a',
>   normarc => '245a',
> },
>   ]
>},
> }
> 
> And I have some questions :)
> - Do you agree with the idea?

Well... I don't know. Though I'm not a fan of that structure really, as it's
not ideal, and is a bit more limited. Also, in this case you can't have more
than one title, but that's not really the big issue. Mostly it's just a very
denormalised view of the data. Better for manually editing an SQL file, but not
really so good for a computer to use. This is why the SQL file has the data in
that form and then normalises it in the database. 

> - Don't you think the index_name should be a column of the search_fields
> table?

Yes, it should be kept with search_field.name as it's effectively more
information needed to describe where something gets stored.

> - Some of the fields don't have a type, should we assign "string" as the
> default value?

I'd like to not just because that implies that they've consciously been made
strings. Ideally as time goes on, people will decide that this is a date, and
this is a ... IP address or something, and add those as types while putting the
logic in to handle it. So, if a type is unspecified, then it gets treated like
a string by default, but it really means "we haven't decided yet."

> - wordings: 'sortable' and 'facetable' sounds more appropriate than 'sort'
> and 'facet'

hmm. I don't really mind either way. My thinking was that "facet" and "sort"
were easier to type. But I broke the consistency because "suggest" seemed
weird. I don't object to any of them changing.

> - (/me is clearing his throat) I think that all the mappings of a field
> should be removed if the field is removed. In other word, there is a 1-n
> relationship beetwen search_field and search_marc_map, which means that the
> join table (search_marc_to_field) is not needed and we could simplify the
> structure removing it.

I had a good reason for doing many-to-many. Let me see if I can remember it...

Oh wait, I documented it:

-- This joins the two search tables together. We can have any combination:
-- one marc field could have many search fields (maybe you want one value
-- to go to 'author' and 'corporate-author) and many marc fields could go
-- to one search field (e.g. all the various author fields going into
-- 'author'.)

If you remove the many-to-many relationship then you end up with
duplication/denormalisation. My thinking behind the UI is that you might have,
say, a list of all the fields and under them, a set of all the MARC fields that
map to it. Or perhaps the inverse. I hadn't really thought about it too much,
but a properly denormalised relational structure means that we have the maximum
amount of flexibility. The only improvement to the structure in this respect is
that the sort, facet, suggest things should really be at the join level. I have
a feeling I considered that, then decided it risked crossing the line into too
fiddly, but it would get more power out of it. At the moment you'd have to
duplicate the MARC details if you want different values for those three which
isn't ideal.

(In reply to Jonathan Druart from comment #144)
> Ha, something else: the biblionumber should be a field of the biblios index.

Oh, it's embedded as the ID on the ES record. There's no point duplicating it
as its own field, 

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #146 from Robin Sheat  ---
(In reply to Robin Sheat from comment #145)
> We don't have a reliable

I was going to say we don't have a reliable biblionumber source in the marc,
but we do as I force it to be correct. But that's not relevant, we should just
use the ID.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #5 from Marc Véron  ---
Hi Kyle, I get errors with:

t/db_dependent/DecreaseLoanHighHolds.t (Wstat: 2048 Tests: 12 Failed: 8)
  Failed tests:  2, 4-5, 7, 9-12
  Non-zero exit status: 8

(...)
not ok 4 - Should have duration of 1

#   Failed test 'Should have duration of 1'
#   at t/db_dependent/DecreaseLoanHighHolds.t line 97.
#  got: '0'
# expected: '1'
not ok 5 - due_date should be a DateTime object

#   Failed test 'due_date should be a DateTime object'
#   at t/db_dependent/DecreaseLoanHighHolds.t line 98.
#  got: ''
# expected: 'DateTime'
(...)

not ok 7 - Should exceed threshold

#   Failed test 'Should exceed threshold'
#   at t/db_dependent/DecreaseLoanHighHolds.t line 116.
#  got: '0'
# expected: '1'

(... and more)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

--- Comment #92 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #91)
> Comment on attachment 42609 [details] [review]
> Bug-6810: Send membership expiry reminder notices.
> 
> Review of attachment 42609 [details] [review]:
> -
> 
> ::: C4/Letters.pm
> @@ +800,5 @@
> >  
> > +if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){
> > +my @dateexpiry = split /-/, $values->{'dateexpiry'};
> > +
> > +$values->{'dateexpiry'} = C4::Dates->new(
> 
> This was not really kind of Marc. He is trying to remove the C4::Dates usage.

Ooops, sorry, removed by next patch!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

--- Comment #91 from Jonathan Druart  
---
Comment on attachment 42609
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42609
Bug-6810: Send membership expiry reminder notices.

Review of attachment 42609:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=6810=42609)
-

::: C4/Letters.pm
@@ +800,5 @@
>  
> +if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){
> +my @dateexpiry = split /-/, $values->{'dateexpiry'};
> +
> +$values->{'dateexpiry'} = C4::Dates->new(

This was not really kind of Marc. He is trying to remove the C4::Dates usage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #161 from Jonathan Druart  
---
I have also started QAing this one yesterday.
Back today with few comments:
1/ 404 is not documented in the swagger.json file
2/ The properties for "borrowers" are not exhaustive
3/ Wording: borrowers vs patrons? "Patron" should be used now, especially for
new code.
4/ this patch set introduces swagger.json but nothing to use it, how is it
useful?
5/ We need a way to split this json file, it will be a mess to edit!
And something to validate it. We need guidelines.
6/ Koha::Borrowers->find is called in Koha::REST::V1::Borrowers::get_borrower
and Koha::REST::V1->startup (?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #163 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #161)
> 1/ 404 is not documented in the swagger.json file

Forget that again, it is!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

Julian Maurice  changed:

   What|Removed |Added

  Attachment #43115|0   |1
is obsolete||

--- Comment #10 from Julian Maurice  ---
Created attachment 43185
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43185=edit
Bug 14788: Add unit tests for GetTopIssues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

Julian Maurice  changed:

   What|Removed |Added

  Attachment #43051|0   |1
is obsolete||

--- Comment #9 from Julian Maurice  ---
Created attachment 43184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43184=edit
Bug 14788: Move opac-topissues.pl code into C4::Circulation

Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a
time).
No problems found.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #147 from Jonathan Druart  
---
(In reply to Robin Sheat from comment #145)
> (In reply to Jonathan Druart from comment #143)
> > Maybe I have not drunk enough tea this morning but...
> > I am trying to improve the mappings area to have a consistent interface to
> > manage them.
> > The idea is to 1) move the elastic_mapping.sql to a elastic_mapping.json
> > file (easier to modify and read), 2) provide methods to
> > serialize/unserialize mappings and then 3) introduce a backup/import/reset
> > mappings feature and finally 4) make easier the mapping progression to get a
> > good basis to use ES.
> > 
> > I have managed to create a json file from the sql file, the structure is
> > something like:
> > 
> > {
> >   biblio => {
> > title => {
> >   label=> 'Title',
> >   type => 'string',
> >   mappings => [
> > {
> >   suggestible => 1,
> >   facet   => 1,
> >   marc21  => '245a',
> >   unimarc => '200a',
> >   normarc => '245a',
> > },
> >   ]
> >},
> > }
> > 
> > And I have some questions :)
> > - Do you agree with the idea?
> 
> Well... I don't know. Though I'm not a fan of that structure really, as it's
> not ideal, and is a bit more limited. Also, in this case you can't have more
> than one title, but that's not really the big issue. Mostly it's just a very
> denormalised view of the data. Better for manually editing an SQL file, but
> not really so good for a computer to use. This is why the SQL file has the
> data in that form and then normalises it in the database. 

I don't understand the problem with the structure, you could have several
mappings (it's an arrayref of hashrefs).
With this structure I could insert exactly the same data in the tables (except
if I missed something...).

> > - Some of the fields don't have a type, should we assign "string" as the
> > default value?
> 
> I'd like to not just because that implies that they've consciously been made
> strings. Ideally as time goes on, people will decide that this is a date,
> and this is a ... IP address or something, and add those as types while
> putting the logic in to handle it. So, if a type is unspecified, then it
> gets treated like a string by default, but it really means "we haven't
> decided yet."

So todo later :)

> > - wordings: 'sortable' and 'facetable' sounds more appropriate than 'sort'
> > and 'facet'
> 
> hmm. I don't really mind either way. My thinking was that "facet" and "sort"
> were easier to type. But I broke the consistency because "suggest" seemed
> weird. I don't object to any of them changing.

Not a big deal but better sooner than later.

> > - (/me is clearing his throat) I think that all the mappings of a field
> > should be removed if the field is removed. In other word, there is a 1-n
> > relationship beetwen search_field and search_marc_map, which means that the
> > join table (search_marc_to_field) is not needed and we could simplify the
> > structure removing it.
> 
> I had a good reason for doing many-to-many. Let me see if I can remember
> it...
> 
> Oh wait, I documented it:
> 
> -- This joins the two search tables together. We can have any combination:
> -- one marc field could have many search fields (maybe you want one value
> -- to go to 'author' and 'corporate-author) and many marc fields could go
> -- to one search field (e.g. all the various author fields going into
> -- 'author'.)
> 
> If you remove the many-to-many relationship then you end up with
> duplication/denormalisation. My thinking behind the UI is that you might
> have, say, a list of all the fields and under them, a set of all the MARC
> fields that map to it. Or perhaps the inverse. I hadn't really thought about
> it too much, but a properly denormalised relational structure means that we
> have the maximum amount of flexibility. The only improvement to the
> structure in this respect is that the sort, facet, suggest things should
> really be at the join level. I have a feeling I considered that, then
> decided it risked crossing the line into too fiddly, but it would get more
> power out of it. At the moment you'd have to duplicate the MARC details if
> you want different values for those three which isn't ideal.

Yes, it's related to the index_name unique key discussion we had last week.
We should either move sort, facet, suggest to the join table or remove it, but
not keep the current structure.

I am not sure about the gain of having the three tables, we could still know
what fields are mapped with this MARC field or the inverse (same marc_field
values).
Anyway, the current structure force us to duplicate the MARC details, because
of the sort, facet, suggest, which could differ.

> (In reply to Jonathan Druart from comment #144)
> > Ha, something else: the biblionumber should be a field of the biblios index.
> 

[Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

Robin Sheat  changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #148 from Robin Sheat  ---
(In reply to Jonathan Druart from comment #147)
> I don't understand the problem with the structure, you could have several
> mappings (it's an arrayref of hashrefs).

Oh, yes, you're right. I missed that bit.

> With this structure I could insert exactly the same data in the tables
> (except if I missed something...).

It's just that it's not a natural representation from a database theory point
of view. Why are the various MARC forms lumped together like that? Why should a
schema change be necessary when (god forbid) a new flavour is added? Actually,
that could be important as if we want to add support for different things into
ES, say importing a feed from a journal provider or whatever, you could use a
flavour to mark how the source is mapped into elasticsearch. Additionally, it
promotes redundancy as you are forced to repeat things to have all the required
combinations, which always causes an icky feeling :)

Essentially, having a proper relational many-to-many is the most expressive and
flexible system that is feasible.

I think I'm OK with moving the attributes (sortable, etc) into the join though.
It probably makes the most sense.

> Yes, it's related to the index_name unique key discussion we had last week.
> We should either move sort, facet, suggest to the join table or remove it,
> but not keep the current structure.
> 
> I am not sure about the gain of having the three tables, we could still know
> what fields are mapped with this MARC field or the inverse (same marc_field
> values).
> Anyway, the current structure force us to duplicate the MARC details,
> because of the sort, facet, suggest, which could differ.

Right, but removing the M-to-M still means we have to duplicate things. And
that'll be why the index was there but problematic, because the attributes are
in the wrong place. The index will (I think) be fine if they get removed. 

> Indeed we could add it later, but don't you think it's worth to let the
> librarians (and devs) search something like "biblionumber:42", which is a
> more familiar term than "ID"?

Oh, good point. Yes, that should be done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #2 from Liz Rea  ---
In additional, unexpected news: Debian Jessie seems to be unaffected, and
honestly I expected it would be.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

Craig Miskell  changed:

   What|Removed |Added

 CC||cr...@catalyst.net.nz

--- Comment #1 from Craig Miskell  ---
It appears based on some debugging that when running under apache-mpm-itk,
setuid binaries like 'at' don't have quite enough permissions to do what they
need. While it does end up running as daemon.daemon, and can write to files in
/var/spool/cron/atjobs/, it fails at the fchown step with EPERM.  From the docs
for fchown, that means "The effective UID does not match the owner of the file,
and the process is not privileged (Linux: it does not have the CAP_FOWNER
capability))". 

Without going deeper, I expect this is a result of mpm-itk dropping
capabilities or privileges to get down to the run-time user, and not being able
to elevate back up as a result. This would affect any other setuid programs
too.

Converting to some sort of app-layer (starman? plack?) may solve it, where
apache runs as normal, and the application runs out of app processes that run
as the correct user from the start, and which can therefore setuid back up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #149 from Robin Sheat  ---
(In reply to Robin Sheat from comment #91)
> > The item is a "Visual Materials" which has a itemtype.notforloan flag set.
> 
> Good to know, I've not tested that case yet.

Well, I spent far too long staring at that, only to find it's been working all
along. You can set it on the itemtype and it should have always worked (as
that's done in post-processing, which is the same between zebra and es), and
all it needed to work at the item level was a mapping from the notforloan field
into es to be added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #51 from Liz Rea  ---
Hi,

If you feel like it, a version of this for 3.18 would be pretty nice, as this
one doesn't apply cleanly.

(Maybe I'll have a look, but don't count on it!)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #178 from Martin Renvoize  ---
Created attachment 43204
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43204=edit
Bug 13799: RESTful API with Mojolicious and Swagger2

Actual routes are:
  /borrowers
Return a list of all borrowers in Koha

  /borrowers/{borrowernumber}
Return the borrower identified by {borrowernumber}
(eg. /borrowers/1)

There is a test file you can run with:
  $ prove t/db_dependent/rest/borrowers.t

All API stuff is in /api/v1 (except Perl modules)
So we have:
  /api/v1/script.cgi CGI script
  /api/v1/swagger.json   Swagger specification

Change both OPAC and Intranet VirtualHosts to access the API,
so we have:
  http://OPAC/api/v1/swagger.json   Swagger specification
  http://OPAC/api/v1/{path} API endpoint
  http://INTRANET/api/v1/swagger.json   Swagger specification
  http://INTRANET/api/v1/{path} API endpoint

Add a (disabled) virtual host in Apache configuration api.HOSTNAME,
so we have:
  http://api.HOSTNAME/api/v1/swagger.json   Swagger specification
  http://api.HOSTNAME/api/v1/{path} API endpoint

Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be
able to pass it to Mojolicious

Test plan:
  1/ Install Perl modules Mojolicious and Swagger2
  2/ perl Makefile.PL
  3/ make && make install
  4/ Change etc/koha-httpd.conf and copy it to the right place if needed
  5/ Reload Apache
  6/ Check that http://(OPAC|INTRANET)/api/v1/borrowers and
 http://(OPAC|INTRANET)/api/v1/borrowers/{borrowernumber} works

Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers
(where X is an integer greater than 1) returns a 404 error

Signed-off-by: Alex Arnaud 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #180 from Martin Renvoize  ---
Created attachment 43206
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43206=edit
Bug 13799: Add missing license notices

Signed-off-by: Joonas Kylmälä 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #179 from Martin Renvoize  ---
Created attachment 43205
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43205=edit
Bug 13799: Add cookie-based authentication to REST API

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #181 from Martin Renvoize  ---
Created attachment 43207
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43207=edit
Bug 13799: Fix API unit tests

They were failing because of the now required 'borrowers' permission

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #43187|0   |1
is obsolete||

--- Comment #184 from Martin Renvoize  ---
Created attachment 43210
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43210=edit
Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #182 from Martin Renvoize  ---
Created attachment 43208
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43208=edit
Bug 13799: (QA followup) make tests use random data

With the introduction of TestBuilder there's no need to
rely on existing data on the DB (the original patch relies
on categories and branches already existing).

This patch creates a random branch, category and two borrowers
with the fixed data that is needed for the tests. It adjusts
the tests to use the randomized data instead of the previously
fixed one.

Signed-off-by: Tomas Cohen Arazi 
The feature works as expected and all tests passes. koha-qa.pl too.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #43189|0   |1
is obsolete||

--- Comment #185 from Martin Renvoize  ---
Created attachment 43211
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43211=edit
Bug 13799: Change 'required' value type from string to boolean

String is not accepted as a valid value in more recent versions of
Swagger2 module

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #43190|0   |1
is obsolete||

--- Comment #187 from Martin Renvoize  ---
Created attachment 43213
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43213=edit
Bug 13799 - Followup: x-mojo-controller deprecation

Remove the use of soon to be deprecated x-mojo-controller from our
specification and replace with the recommended operationId format.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #43186|0   |1
is obsolete||

--- Comment #183 from Martin Renvoize  ---
Created attachment 43209
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43209=edit
Bug 13799: Change Mojolicious default mode to 'production'

This avoid getting a debug page when URL is wrong.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #43192|0   |1
is obsolete||

--- Comment #188 from Martin Renvoize  ---
Created attachment 43214
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43214=edit
Bug 13799 - Followup: Refactor spec file

Spreading the specification over multiple files should lead to a more
manageable specification long term

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #42874|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #43191|0   |1
is obsolete||

--- Comment #186 from Martin Renvoize  ---
Created attachment 43212
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43212=edit
Bug 13799: Reword 'borrower' to 'patron'

Also, complete the Swagger definition of a patron

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #42875|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #42876|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #42877|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #42878|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #189 from Martin Renvoize  ---
Rebased my two patches (marked with 'Followup' keyword) and signed off on prior
patches.

QA Note, let's get he patrons example right and not only define all fields with
descriptions but actually define types so validation may become useful.

I'm happy to do this as another followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #190 from Martin Renvoize  ---
My patches require the latest versions of Swagger2 and JSON::Validator modules.
 I highly recommend especially whilst in development that we stick to the
latest versions of these modules...  The code is moving fast and becoming more
and more refined almost daily.

The latest changes include..

* Validating the swagger.json specification file against the swagger schema
during application startup (This should prevent 'bad schema' making it into
release).
* Correct handling of $ref json-references in schemata
* Stricter coercion functions and validation (JSON::Boolean and Integer
coercion handling improvements)

and various other bugfixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14976] New: Specify due date, calendar and useDaysMode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14976

Bug ID: 14976
   Summary: Specify due date, calendar and useDaysMode
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Hi,

If you check out an item with "specify due date", due date does not take into
account the calendar and closing days.

It will be nice that syspref useDaysMode be used for loans with a manual due
date.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #16 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #14)
> Hm, I think 0/1 as the description is not very friendly for the cataloger
> and might lead to some confusion. Another suggestion: We could use the
> mechanism that makes system preferences available in the XSLT. We could
> create a variable to store the description that matches the authorised value
> category linked to 942$n for the value 1. And then base the check on that.
> Does that make sense? :)

I don't think I followed that well ; )

Here's what I'm thinking:
1) Add a new system preference OpacSuppressionValue that defines the value ( 1,
the Authorised Value description for 1, default of 1 if not set ). So this
value could be 1, Yes, Si, Oui or what have you.
2) Pass this new pref to the XSLT
3) Compare against the pref value rather than just '1'

Is this what you are thinking Katrin?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #168 from Kyle M Hall  ---
Also, thanks for the followups Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #164 from Julian Maurice  ---
Created attachment 43186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43186=edit
Bug 13799: Change Mojolicious default mode to 'production'

This avoid getting a debug page when URL is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14959] Support for Library Communications Framework (LCF)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14959

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #165 from Julian Maurice  ---
Created attachment 43187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43187=edit
Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #166 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #161)
> 2/ The properties for "borrowers" are not exhaustive
> 3/ Wording: borrowers vs patrons? "Patron" should be used now, especially
> for new code.

Ok, these points need to be fixed

> 4/ this patch set introduces swagger.json but nothing to use it, how is it
> useful?

swagger.json, apart from being the api documentation, is also used by
Mojolicious' plugin Swagger2 to create the routes (map URL to
controller/action) and do some basic type check on input and output. So it is
useful (or at least, used) even without documentation generators like SwaggerUI

> 5/ We need a way to split this json file, it will be a mess to edit!

There is an issue on Github for splitting the JSON spec
https://github.com/jhthorsen/swagger2/issues/33
which was moved to
https://github.com/jhthorsen/json-validator/issues/4
which ends with a commit in master
https://github.com/jhthorsen/json-validator/commit/5d7d9db22b891758ac979cc87f1ab018030df2c2

It seems there is something to test here.

> And something to validate it. We need guidelines.

What kind of validation ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

--- Comment #1 from Martin Persson  ---
Created attachment 43188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43188=edit
Bug 8630 - Adlibris covers (syspref files)

This patch adds a system preference for cover images from Swedish
book retailer Adlibris. Images are retrieved via http or https
from an external web server. This might leak OPAC and Staff
interface data to third parties and should thus be used with
caution.

Sponsored-By: Halland County Library

Test plan:

Test 1: Test upgrade procedure for clean installation.

  Start by removing existing sysprefs, if present:

  $ mysql -u kohaadmin -p -D koha
  > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

* Apply this patch which will add a pref file, update the 'syspref'
  structure and add an atomic upgrade file.

* Install the update:
  Koha$ perl installer/data/mysql/updatedatabase.pl

* Once upgraded and logged in, Select 'More', 'Administration',
  'Global Preferences' and finally 'Enhanced content'.
  There should be a new option called 'Adlibris'.

  The first option should default to "Don't show", if not the
  patch is broken.

  The second options should show the default URL:
  http://www.adlibris.com/se/organisationer/showimagesafe.aspx

  If not, the patch is broken.

Test 2: Changing sysprefs

* In the control panel, change the first value from "Don't show"
  to "Show" and save the changes. Use MySQL client to inspect changes:

  $ mysql -u kohaadmin -p -D koha
  > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

  The column 'value' should now have the value '1', if not the patch
  is broken.

Test 3: Apply update to existing data

* Re-execute the installer now that the database has the data already:
  Koha$ perl installer/data/mysql/updatedatabase.pl

  If any errors occur the patch is broken.

  Examine the database contents:

  $ mysql -u kohaadmin -p -D koha
  > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%';

  If the values were overwritten by the installer the patch is broken.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Colin Campbell  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Colin Campbell  ---
having applied the patch against current master server terminates when
processing an issue transaction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #167 from Kyle M Hall  ---
(In reply to Julian Maurice from comment #166)
> (In reply to Jonathan Druart from comment #161)
> > 2/ The properties for "borrowers" are not exhaustive
> > 3/ Wording: borrowers vs patrons? "Patron" should be used now, especially
> > for new code.
> 
> Ok, these points need to be fixed

Agreed. The external api terminology must be patron / patrons at the least. At
some point we need to change Koha::Borrower(s) to Koha::Patron(s) but that is
entirely separate and distinct from this work.

> > 5/ We need a way to split this json file, it will be a mess to edit!
> 
> There is an issue on Github for splitting the JSON spec
> https://github.com/jhthorsen/swagger2/issues/33
> which was moved to
> https://github.com/jhthorsen/json-validator/issues/4
> which ends with a commit in master
> https://github.com/jhthorsen/json-validator/commit/
> 5d7d9db22b891758ac979cc87f1ab018030df2c2
> 
> It seems there is something to test here.

Agreed. It would be *much* better if we can split this file up. If the Swagger2
version we are using doesn't support it, we may have to table this issue until
a newer version is available for us to use with Koha.

> > And something to validate it. We need guidelines.
> 
> What kind of validation ?

I think a unit test using Test::JSON::is_valid_json should be sufficient.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #170 from Martin Renvoize  ---
I've been working allot lately with the developer of the Swagger2 perl tools.
We have got $ref support working well now, with relative paths, full paths and
url's all passing tests.  I asusme it's this piece you were refering to when
talking about splitting up the spec file khall?


Regarding 'patrons' vs 'borrowers' can we not use the 'americanised' term
pretty please.. to me it would be much better to generalise it.. they're not
limited to borrowers/patrons at all.. they're 'users' ;)

Back on topic, I'll be looking at all this stuff today.. great work Julian in
my brief look so far.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #3 from Magnus Enger  ---
Locations (authorized value LOC) also show the codes instead of descriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #17 from Tomás Cohen Arazi  ---

Ok, a brief about the errors and causes.

Trivial:
t/db_dependent/Borrower.t: transaction race, probably TestBuilder's fault.
t/db_dependent/Installer.t: Uses DBI directly, should be easy to tweak
t/db_dependent/Items.t: transaction race, probably TestBuilder's fault.
t/db_dependent/Reports_Guided.t: DBIx doesn't raise the warning the test
expect.
t/db_dependent/Search.t: It seems to be failing to connect. The code actually
mocks the connection, the _new_dbh function. There shouldn't be a behaviour
change, but it fails.
t/db_dependent/Sitemapper.t: It seems to be failing to connect. The code
actually mocks the connection, the _new_dbh function. There shouldn't be a
behaviour change, but it fails.


Might be an important issue:
t/db_dependent/Circulation_issuingrules.t: results differ from expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #171 from Kyle M Hall  ---
(In reply to Martin Renvoize from comment #170)
> I've been working allot lately with the developer of the Swagger2 perl
> tools. We have got $ref support working well now, with relative paths, full
> paths and url's all passing tests.  I asusme it's this piece you were
> refering to when talking about splitting up the spec file khall?

Yes, I believe so.

> Regarding 'patrons' vs 'borrowers' can we not use the 'americanised' term
> pretty please.. to me it would be much better to generalise it.. they're not
> limited to borrowers/patrons at all.. they're 'users' ;)

The general consensus has been for internal terminology to match outward
terminology. Right now we use patrons, members and borrowers internally. Since
we use patrons externally we should use it internally. I we want to change the
nomenclature further we should put it to a dev meeting vote!

> Back on topic, I'll be looking at all this stuff today.. great work Julian
> in my brief look so far.

Excellent!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14970] New: routed items still say available

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14970

Bug ID: 14970
   Summary: routed items still say available
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nic...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

If you set up a routing list in Serials and you have a serial that is being
routed it says it's available in the opac, but it's not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #169 from Julian Maurice  ---
Created attachment 43189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43189=edit
Bug 13799: Change 'required' value type from string to boolean

String is not accepted as a valid value in more recent versions of
Swagger2 module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #16 from Tomás Cohen Arazi  ---
This patchset removes DBIx::Connector usage, but is also moving the database
handler creation responsability into the Koha::Database class.

It looks great, convenient and makes a lot of sense.

But right now it breaks some tests. Probably due to problems on the tests
themselves:

Test Summary Report
---
t/db_dependent/Borrower.t(Wstat: 65280 Tests: 8
Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 13 tests but ran 8.
t/db_dependent/Circulation_issuingrules.t(Wstat: 768 Tests: 7
Failed: 3)
  Failed tests:  2, 6-7
  Non-zero exit status: 3
t/db_dependent/Installer.t   (Wstat: 65280 Tests: 1
Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 9 tests but ran 1.
t/db_dependent/Items.t   (Wstat: 65280 Tests: 6
Failed: 1)
  Failed test:  6
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 9 tests but ran 6.
t/db_dependent/Reports_Guided.t  (Wstat: 256 Tests: 18
Failed: 1)
  Failed test:  16
  Non-zero exit status: 1
t/db_dependent/Search.t  (Wstat: 65280 Tests: 1
Failed: 1)
  Failed test:  1
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 4 tests but ran 1.
t/db_dependent/Sitemapper.t  (Wstat: 1536 Tests: 14
Failed: 6)
  Failed tests:  6, 8, 10, 12-14
  Non-zero exit status: 6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14971] New: RIS only outputs the first 10 characters for either ISBN10 or ISBN13

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971

Bug ID: 14971
   Summary: RIS only outputs the first 10 characters for either
ISBN10 or ISBN13
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: j...@fct.unl.pt
QA Contact: testo...@bugs.koha-community.org

RIS only outputs the first 10 characters for either ISBN10 or ISBN13.

After "[Bug 14245] RIS in unimarc flavour is still deficient" where "Pushed to
Stable" I upgrade to version 3.20.04 and tested sucessfully several exports to
RIS until I try my own book with ISBN ending with "letter X" it was than that I
realized that RIS was just only outputing the first 10 characters of either
ISBN10 or ISBN13.

Please use these live examples to compare MARC view data with RIS exported
data:
https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=9
https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=130
https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=47281
https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=54176

Errors encountered are:
0-19-855284-X exported as SN  - 0-19-85528
1-881526-11-9 exported as SN  - 1-881526-1
9780444521262 exported as SN  - 9780444521
972-97183-0-X exported as SN  - 972-97183-

Please don't limit the size length for "SN" in RIS, because it also may contain
(-) hyfens.

Thank You.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #172 from Martin Renvoize  ---
Firs comment: 

Unless we're actually going to use Mojolicious Sessions, and thus mojo cookies
then we need not confuse users by making the secret configurable.

As far as I can tell, secrets are only used to sign mojo cookies (Whether we
should eventually switch to mojo hmac signed cookies over csgisessid is another
question all together)

As such, I would suggest we hard code a suitably silly secret just to quell
warnings that will be output otherwise safe in the knowledge that we are not
actually using said secret anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14972] New: Limit by availability does not return results if *any* items are on-loan or lost

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14972

Bug ID: 14972
   Summary: Limit by availability does not return results if *any*
items are on-loan or lost
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Viewing search results on search.pl -- if I click 'Limit to currently available
items.', any Bib records that have items which are on-loan or lost do not show
in the facet search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #1 from Alex Arnaud  ---
Created attachment 43193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43193=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #174 from Martin Renvoize  ---
Error responses..  I see you've added a nice simple schema for validating error
responses.

However, there seems to be a general move toward standardising on the error
format at described by the Swagger2 plugins error handler..

Perhaps we should follow suite and adopt that same format, which is pretty darn
close to what we have already (with the exception that it allows for an array
of errors with messages as a posed to just a single error message string).

I'm also happy to supply a patch if this is how we wish to proceed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #175 from Martin Renvoize  ---
Created attachment 43190
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43190=edit
Bug 13799 - Followup: x-mojo-controller deprecation

Remove the use of soon to be deprecated x-mojo-controller from our
specification and replace with the recommended operationId format.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298

--- Comment #4 from Marjorie Barry-Vila  ---
Hi,
I tested it on a sand box and I do not have good results. The commands fails
and nothing happens.
See video here https://owncloud.ccsr.qc.ca/index.php/s/jxTIuf3cq0cl5j9/download

Regards

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12331] can't save results to zotero

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12331

Francisco Peixoto  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Status|CLOSED  |REOPENED
 CC||fabreupeix...@gmail.com

--- Comment #4 from Francisco Peixoto  ---
Good evening

Dear Nicole and Bernardo

Probably you still didn't reach any solution for this. I'am also having
problems with Zotero Koha connector and I reported in the Zotero forum

https://forums.zotero.org/discussion/52521/koha-translator/#Item_5

The problem I reported is a bit different but might be connected with this one.

The problem I reported I face it in different catalogs even on the Bywater demo
OPAC.

Hope this could be a way to solve the problem.

Thanks
Kind regards
Francisco

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #173 from Martin Renvoize  ---
x-mojo-controller has recently been deprecated, though not entirely removed
from the Swagger2 Mojo Plugin, withe the prefernce now being that the core
swagger key 'operationId' is used in preference to it.

I'm happy to submit a patch that updates both our spec and the resultant method
names in the Borrowers controller.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] New: Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Bug ID: 14973
   Summary: Suggestions - Search and warn user about existing
biblio when submitting a suggestion
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

When submitting a new purchase suggestion, we search for similar document among
biblio and show a message if a duplicate is found. User can ignore the message
and confirm the suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #177 from Martin Renvoize  ---
Created attachment 43192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43192=edit
Bug 13799 - Followup: Refactor spec file

Spreading the specification over multiple files should lead to a more
manageable specification long term

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #176 from Julian Maurice  ---
Created attachment 43191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43191=edit
Bug 13799: Reword 'borrower' to 'patron'

Also, complete the Swagger definition of a patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #8 from Héctor Eduardo Castro Avalos  ---
(In reply to Marc Véron from comment #7)
> Created attachment 43069 [details] [review]
> Bug 14922 - Remove C4::Dates from cataloguing/additem.pl
> ... 
> Patch amended following comment #6  / mv

Hi, MARC I tested this patch with this kind of patterns:
Pattern: Year: Month:MM Day:DD
the result is:
Year:2015-10-07T11:26:57->year Mount:2015-10-07T11:26:57->month
Date:2015-10-07T11:26:57->day

Pattern: MMDD
Result:
2015-10-07T11:35:32->year2015-10-07T11:35:32->month2015-10-07T11:35:32->day

I've been tested other sort of patterns but the result is the same.
Patch 14936 not applied since patch in Discussion and not mentioned in this
bug.

I don't know if this behaviour in dates is right.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Nicole Engard (ByWater)  changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14974


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974
[Bug 14974] Use the REST API for cities
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14974


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974
[Bug 14974] Use the REST API for cities
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] New: Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Bug ID: 14974
   Summary: Use the REST API for cities
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 13799, 14888

One of the simplest script in Koha is admin/cities.pl.
There is no relationship, very few columns, etc.
The script has been rewritten recently (bug 14888) to use Koha::Object[s].
It has been cleaned and is a good candidate to collect the different point of
views/implementations possible to use the REST API (bug 13799).


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
[Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888
[Bug 14888] Move the cities related code to Koha::Cities
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

--- Comment #1 from Kyle M Hall  ---
Created attachment 43195
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43195=edit
Bug 14975 - Fine grace period label is incorrect

The column heading for grace period is "Fine grace period (day)" but the
grace period works based on the unit selected ( hours or days ). The
"(day)" part should be removed as it caused confusion for librarians.

Test Plan:
1) Apply this patch
2) Go to the circ rules editor
3) Note the header and footer columns for grace period no longer
   have "(days)" at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #2 from Jonathan Druart  
---
I would be happy to see a try using AngularJS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13016] Add fine grace period by hour

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13016

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Kyle M Hall  ---
Grace periods for hourly checkouts are in hours. The column is just labeled
wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] New: Fine grace period label is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Bug ID: 14975
   Summary: Fine grace period label is incorrect
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: kyle.m.h...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The column heading for grace period is "Fine grace period (day)" but the grace
period works based on the unit selected ( hours or days ). The "(day)" part
should be removed as it caused confusion for librarians.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

Summary|Add ability to place|Add ability to place
   |document delivery / article |article requests in Koha
   |requests in Koha|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #1 from Jonathan Druart  
---
Created attachment 43194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43194=edit
Bug 14974: Joubu's try to use the REST API for cities

Here's my try.
The naive way is to do AJAX calls and redirect to the list after
delete/update/add.

The main issue is that it does not simplify the code so far...

Question:
How to display notif to the user after actions (delete/update/add)?
How to simplify the swagger file?
How to present a search interface?

See other comments in the code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Cindy Murdock Ames  changed:

   What|Removed |Added

 CC||cmurd...@ccfls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Jonathan Druart  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz,
   ||julian.maur...@biblibre.com
   ||,
   ||jwea...@bywatersolutions.co
   ||m,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||olli-antti.kivila...@jns.fi
   ||, tomasco...@gmail.com

--- Comment #3 from Jonathan Druart  
---
Hi everyone (ccing some people who could be interested in this discussion),
Bug 13799 is going to pass the QA step.
I think we need to know where we are going and what is the next step.
Beside the authentication problem, how could we use the REST API from Koha
scripts?

I have submitted my naive implementation (see above), but it's not so nice and
would like to see what you have in mind.

We need to have good basis, write guidelines and impose them, before pushing
any patches, IMO. What is suggested on bug 13799 is too light and need a
framework to be used efficiently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922

--- Comment #10 from Marc Véron  ---
Created attachment 43203
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43203=edit
Bug 14922 - (followup) Fix string output

This patch makes  MM and DD display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922

Marc Véron  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/