[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #56637|0   |1
is obsolete||

--- Comment #16 from Aleisha Amohia  ---
Created attachment 56638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56638=edit
Bug 14957: Key fixes to patch

- Fixing merge conflicts
- adding String::Similariry to list of dependencies
- font-awesome icons and adding consistency to formatting
- removing original use of onclick
- moving help text out of main page and into a new help file

When testing, follow above test plan but:
1) Remember to install String::Similarity before testing (apt-get
install libstring-similarity-perl)
2) Instead of doing step 7, click Help in top-right corner instead.
Confirm this works and shows as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17465] New: Add a System Preference to control number of Saved Reports displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465

Bug ID: 17465
   Summary: Add a System Preference to control number of Saved
Reports displayed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: b...@calyx.net.au
QA Contact: testo...@bugs.koha-community.org

The Saved Reports page lists 20 reports by default.  A drop-down enables this
to be changed to 10, 50, 100 or 'all' but this selection does not persist. 
Where a library has a large number of reports with frequent access, the need to
constantly reset this can be quite annoying.  

We propose to add a system preference 'numSavedReports'. The description would
be something like: 'By default, show 20 reports on the Saved Reports page.
Other allowed values are 10, 50, 100 and All'

The number chosen will also apply when a category tab is selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #15 from Aleisha Amohia  ---
Created attachment 56637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56637=edit
Bug 14957: Key fixes to patch

- Fixing merge conflicts
- adding String::Similariry to list of dependencies
- font-awesome icons and adding consistency to formatting
- removing original use of onclick
- moving help text out of main page and into a new help file

When testing, follow above test plan but:
1) Remember to install String::Similarity before testing (apt-get
install libstring-similarity-perl)
2) Instead of doing step 7, click Help in top-right corner instead.
Confirm this works and shows as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17445] REST API: Generic handling of malformed query parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17445

--- Comment #9 from Josef Moravec  ---
Created attachment 56634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56634=edit
[SIGNED-OFF] BUG 17445: Add 'malformed query' error response

This patch adds to the x-mojo-around action code to give a meaningful
error given a bad query parameter in the query string for a request.

Test Plan
1) Submit an api request to an existing restful endpoint with no query
parameters
2) Confirm the correct response is being given
3) Submit an api request to an existing restful endpoint with an allowed
query parameter
4) Confimr the correct response is being given
5) Submit an api request to an existing restful endpoint with a
malformed query paramter
6) Note the 400 response code and helpful json api body

https://bugs.koha-community.org/show_bug.cgi?id=17445

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17445] REST API: Generic handling of malformed query parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17445

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56500|0   |1
is obsolete||
  Attachment #56546|0   |1
is obsolete||
  Attachment #56547|0   |1
is obsolete||

--- Comment #10 from Josef Moravec  ---
Created attachment 56635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56635=edit
[SIGNED-OFF] Bug 17445: Just some refactoring

The idea is to make the code more readable moving the code to its own
subroutine

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17445] REST API: Generic handling of malformed query parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17445

--- Comment #11 from Josef Moravec  ---
Created attachment 56636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56636=edit
[SIGNED-OFF] Bug 17445: Move the params check after the authentication check

If the user is not authorised to call this route, we would prefer to
raise a 403 instead of 400

Note that we wanted to submit tests for this change but the city code
does not let use do that (we are allowed to list/show cities even
without any permissions). The patrons.t is not complete enought and the
holds.t tests do not pass...

Tomas plans to submit tests but we reach the end of the hackfest ;)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17445] REST API: Generic handling of malformed query parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17445

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17464] Order deny, allow / Deny from all was deprecated in Apache 2.4 and is now a hard error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

Bob Ewart  changed:

   What|Removed |Added

 CC||bob-ew...@bobsown.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17464] New: Order deny, allow / Deny from all was deprecated in Apache 2.4 and is now a hard error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

Bug ID: 17464
   Summary: Order deny,allow / Deny from all was deprecated in
Apache 2.4 and is now a hard error
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: bob-ew...@bobsown.com
QA Contact: testo...@bugs.koha-community.org

The Allow, Deny and Order directives were deprecated in Apache 2.4 and are no
longer recognized.

Order deny,allow
Deny from all

Should be:
Require all denied

lines 36/37 and 169/170 in koha-httpd.conf should be changed

This is in Koha compiled from source and appears in most of the versions I've
tried.

Also add:

  Require all granted

or you will get an 'access forbidden' error

If using plugins also add:

  Require all granted


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17434] Moremember displaying primary and secondary phone number twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
Version|16.05   |master
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17434] Moremember displaying primary and secondary phone number twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434

--- Comment #1 from Josef Moravec  ---
Created attachment 56633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56633=edit
Bug 17434: Moremember displaying primary and secondary phone number twice

Test plan:
1) Create patron category with category code "P" and create a patron
with this category
2) Fill in either the primary or other phone number
3) Go to patron details page (moremember.pl)
=> without patch you see primary/other phone duplicated
=> with patch you should see the number only once as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17434] Moremember displaying primary and secondary phone number twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #13 from Chris Cormack  ---
Once the facets are working we will submit them as patches for sign off, but
testing now would help catch any issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #12 from Chris Cormack  ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Jonathan Druart from comment #10)
> > It seems that the code is available at
> > http://git.catalyst.co.nz/gw?p=koha.git;a=shortlog;h=refs/heads/wr262182
> 
> What's the status of this branch? Is it considered as testable/wip/done?

It is testable, however


* Facets most probably do not work (to be done)

* We had to change Catmandu::Store::ElasticSearch::Bag
https://github.com/LibreCat/Catmandu-Store-Elasticsearch/issues/10

But we would love some testing. (It is built on top of your bug to move the
elasticsearch code (that is already in that branch))

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17463] New: Wrong recipient for suggestion' s notice in branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17463

Bug ID: 17463
   Summary: Wrong recipient for suggestion's notice in branch
specific
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

Hi,

There is test plan to understand the problem:

Branch A with borrower A and librarian A, Branch B with librarian B
Notice ACCEPTED, ORDERED, AVAILABLE set to each branch

- borrower A done a suggestion A
- librarian from branch A accepted suggestion A
- email for suggestion ACCEPTED sent to borrower A
- librarian from branch A ordered suggestion A, a biblio is created (biblio A)
- email for suggestion ORDERED sent to borrower A
- librarian from branch B ordered an other copy from the same biblio A (not
from suggestion A, really from biblio A)
- Order from librarian B is also related to suggestion A : this is the problem.
- librarian B received his item before librarian A
- email for suggestion AVAILABLE sent to borrower A while item for branch A is
not arrived yet.



Do you understand me?

Order from an other branch for the same biblio should not be related to the
initial suggestion.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14348] Staff patron specific section for adding links and notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14348

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

Chris Cormack  changed:

   What|Removed |Added

  Attachment #56631|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 56632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56632=edit
Bug 17459 Follow up

Adding POD and --userid and --password options

1/ To test, use the same routine as before, with no options.
2/ You should have a user with koha/koha as userid and passwords
3/ Delete that user
4/ Run the script with --userid  --password 
5/ You should have a user in koha with userid/password set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

Chris Cormack  changed:

   What|Removed |Added

  Attachment #56608|0   |1
is obsolete||

--- Comment #4 from Chris Cormack  ---
Created attachment 56630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56630=edit
Bug 17459: Add a script to create a superlibrarian user

This is for developers: it's quite long (many clics) to create a new
superlibrarian user.
This new script creates a new user with superlibrarian permissions with
the easy to remember credential koha/koha

Test plan:
  perl misc/devel/create_superlibrarian.pl
Log in to Koha using koha/koha

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

--- Comment #5 from Chris Cormack  ---
Created attachment 56631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56631=edit
Bug 17459 Follow up

Adding POD and --userid and --password options

1/ To test, use the same routine as before, with no options.
2/ You should have a user with koha/koha as userid and passwords
3/ Delete that user
4/ Run the script with --userid  --password 
5/ You should have a user in koha with userid/password set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #4 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #3)
> We can imagine another syspref to list the patron categories not affected by
> this behaviour.

Or a flag in the (patron) categories table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #3 from Jonathan Druart  
---
We can imagine another syspref to list the patron categories not affected by
this behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17444] Export by date and time in export_record.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17444

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56496|0   |1
is obsolete||
  Attachment #56574|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 56629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56629=edit
Bug 17444: Enable exporting by time, not only date

Test plan:
1) Apply the patch
2) Edit a biblio
3) run export_records.pl with date time few minutes in the past
for example: --format=xml --record-type=bibs --date="2016-10-14 10:00:05"
--filename="koha.xml"
4) look in the file and cofirm that the right record was exported
5) Try the same but with time after the biblio was edited, it shouldn't be
exported

Signed-off-by: radiuscz 

Bug 17444: Follow-up, don't change the name of parameter "date"

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17444] Export by date and time in export_record.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17444

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17444] Export by date and time in export_record.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17444

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #10 from Jonathan Druart  
---
I have squashed the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17411] Change exit 1 to exit 0 in acqui/ basket.pl to prevent Internal Server Error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17411

--- Comment #6 from Jonathan Druart  
---
Created attachment 56628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56628=edit
Bug 17411: Remove 3 other occurrences of exit 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17411] Change exit 1 to exit 0 in acqui/ basket.pl to prevent Internal Server Error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17411

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56121|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 56627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56627=edit
Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal
Server Error

Note: Same situation as in Bug 17403

To test:
- Verifiy that code change makes sense.

Note: Same situation as in Bug 17403
Signed-off-by: David Cook 

Signed-off-by: Jonathan Druart 
Amended patch: Remove unecessary comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17411] Change exit 1 to exit 0 in acqui/ basket.pl to prevent Internal Server Error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17411

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17405] Edit record uses Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17405] Edit record uses Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56564|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 56626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56626=edit
Bug 17405 Edit record uses Default framework

In detail view (catalogue/detail.pl), when clicking on Edit > Edit
record button, the record editor should be opened with the biblio record
framework. It isn't the case. The Default framework is used. Same issue
with Edit > Edit as new (duplicate).

TO TEST:

1. Find a biblio record using a framework which is not the Default one.
2. See the biblio record in detail view (catalogue/detail.pl).
3. Click on Edit > Edit record.
4. Click on Settings => you can see 'Default' as selected framework.
5. Apply the patch.
6. Repeat step 3-4. => the biblio record framework is selected.
7. Repeat 3-4 using Edit > Edit as new (duplicate).

Signed-off-by: Frédéric Demians 
  Added a test plan

Signed-off-by: Bernardo Gonzalez Kriegel 
Fix the issue, no errors.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

--- Comment #15 from Jonathan Druart  
---
Jacek, do you think 17261 and 17274 are correct or do they need to be reworked?

I think we are cover all the cases and that should work correctly most of the
time.
However it will be bad to display wrong informations...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #92 from Brendan Gallagher  ---
(In reply to Jonathan Druart from comment #91)
> (In reply to Jonathan Druart from comment #90)
> > Created attachment 56619 [details] [review] [review]
> > Bug 17216: Revert changes to ItemsSearchField schema file
> 
> @RM, could you please push this follow-up please? It seems that I have
> generated a wrong file (80 vs 32).

Thanks!  Pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16079] Retrieving system preferences from database via DBIx is not fast enough

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15341

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16079

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #7 from Jonathan Druart  
---
Increasing the severity as we need it in the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #11 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #10)
> It seems that the code is available at
> http://git.catalyst.co.nz/gw?p=koha.git;a=shortlog;h=refs/heads/wr262182

What's the status of this branch? Is it considered as testable/wip/done?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #44)
> Is there a good reason not to add the new ACQORDER notice?

Without the letter created I get
"Order e-mail was sent to the vendor." on the interface, but

No orderacquisition ACQORDER letter transported by email at
/home/koha/src/C4/Letters.pm line 689.

in the logs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #44 from Jonathan Druart  
---
Is there a good reason not to add the new ACQORDER notice?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

--- Comment #36 from Jonathan Druart  
---
Nick, if the barcode is not mandatory and you don't fill it, you will get:
Can't call method "delete_subfield" on an undefined value at
/home/koha/src/acqui/addorder.pl line 331.


Please fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 56625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56625=edit
Bug 10337: (followup) Upper case MARC flavour

This patch makes the populate_db.pl script upper case what gets passed
with the --marcflavour option switch. This is needed in order for this
to fit ``kohadevbox`` configuration files, and it is harmless for other
uses.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15504] Track Patron's Last Activity

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #10 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Ok, let's use ČSN's primary level only. Continuing the signoff process...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #101 from Jonathan Druart  
---
Yes indeed, launching several searches in different tabs will give wrong
results.
I have no idea how we could fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

Jonathan Druart  changed:

   What|Removed |Added

Summary|Inter-site holds|Inter-site holds
   ||improvement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8752] Log circulation renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #6 from Sally Healey  
---
Hi,

Is this bug still under consideration for inclusion?  

We would really like to see a renewal log included in Koha, especially if it
enabled us to see which user performed the renewal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #2 from Jonathan Druart  
---
Created attachment 56624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56624=edit
Bug 17453: Inter-site holds improvement

At the moment users can reserve items and choose any library as a pick up
location, but there is no mechanism to prevent users from reserving items that
are available on the shelf at any given location from reserving the item at the
same location, essentially creating a Fetch and Collect scenario.
This has an impact on staff workloads as they are having to process
reservations
and check shelves for items that students can already come and collect from the
open library shelves.
The aim of this enhancement is to decrease the impact on staff workload there
should be a restriction in place that prevents users from requesting items for
collection at a library where the item is currently available.

Implementation:
We first tried to add a new circulation rule adding a 4th
“NotIfAvailableAtPickupLibrary” option to "On shelf holds allowed".
That would make the development more flexible.
But in that case we quickly faced non-trivial problematics:
Let's say you have 3 items I1, I2 and I3. The first one has onshelfholds
set to Yes and 2 others has it set to “NotIfAvailableAtPickupLibrary”.
What would be the expected behavior if a hold is placed at biblio level?
And if a hold is placed at item level for I1?
This second point could be answered by reworking the interface to move
the libraries dropdown list elsewhere (1 list per item) or by adding a
lot of JS code to handle the different situation. But it would be
much more complicated to implement.
So finally I moved back to the simple approach and added a new pref to
handle the behavior globally.

Test plan:
0/ Switch off OPACHoldsIfAvailableAtPickup
1/ Let's say you have 3 libraries L1, L2, L3, create 2 items owned by L1
and L2
2/ Place a biblio level hold. You should only be able to pick it up at
L3
2/ Place a item level hold. You should only be able to pick it up at
L3
3/ Create a third items owned by L3
4/ Now you should not be able to place a hold on this record anymore

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #1 from Jonathan Druart  
---
Created attachment 56623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56623=edit
Bug 17453: Add pref OPACHoldsIfAvailableAtPickup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #100 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #99)
> These patches have been submitted 3 years ago, and have been rewritten 3
> times already.

Okay that's fair. My comments are not about issues which should block this.

One thing I am concerned about is the behavior of browsing when you have
multiple tabs open. Browsing selected records seems to get confused if you
perform a search in another tab, with the list of selected records getting
replaced by the list of searched records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 56622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56622=edit
Bug 10337: (QA followup) Allow choosing MARC flavour

This patch enables the --marcflavour option switch so the user
can specify the desired marc flavour. The code for handling it
was already in place, just not used.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #56614|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 56621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56621=edit
Bug 10337: Add a script to populate devs' DBs with sample data

Executing the installer process and inserting all the sample data take a
lot of clics and time.
The idea of this script is to provide a quick way to insert all the
sample data easily to get a working Koha install asap.

Test plan:
- Set your database config to a non-existent DB
- Execute perl misc/devel/populate_db.pl
You will get an error
- Create an empty DB
- Execute perl misc/devel/populate_db.pl
It will insert all the MARC21 sample data
- Execute perl misc/devel/populate_db.pl
You will get an error because the DB is not empty (systempreferences and
borrowers tables)

Signed-off-by: Chris Cormack 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #9 from Josef Moravec  ---
(In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #8)
> Yes, I agree, that we should sort the texts somehow reasonably. What do you
> think about using my first proposal, ie. sorting like aábcčdďeéě...? This
> seems to me as more accurate approach, even if it's not as defined
> simplified standard rules.

I can't agree with you, it would be more unaccurate approach, because if use
the current patches, we are able to perfectly match the primary level of sortng
as defined by ČSN 97 6030. But with your approach with doesn't implement
anything...

Moreover, the primary level works in most cases and merging primary and
secondary levels rules together just ends like a mess in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Claire Gravely  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17462

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462

Claire Gravely  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12310

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462

Claire Gravely  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17098

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

Claire Gravely  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17462

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17462] New: Pay fines not accepting ', ' for EUR currency input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462

Bug ID: 17462
   Summary: Pay fines not accepting ',' for EUR currency input
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: claire_grav...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When currencyformat is set to EUR, it is not currently possible to enter
amounts into pay amount /cgi-bin/koha/members/paycollect.pl?borrowernumber=XXX
using ','(comma) instead of '.' (point).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1707] Search for patron '%' returns all results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707

--- Comment #5 from Petter Goksøyr Åsen  ---
I have put a limit on the query as you suggested:
http://paste.koha-community.org/135 
It's not in production yet, but testing in staging so far seems good.

The result is probably not accurate, as you said, but I think it's only
potentially wrong if you have a very wide search (i.e few numbers which matches
lots of borrowernumbers). If the result list is long, say tens of thousands, it
does not matter that its not accurate.

If you search for full fields (in our case its social security number as
extended patron attribute), the returned result is always correct

In my mind, it's quite dangerous that Koha allows to generate SQL-queries which
are several MB of text, which generated huge loads on our server, so I'd prefer
safety to accuracy here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #8 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Yes, I agree, that we should sort the texts somehow reasonably. What do you
think about using my first proposal, ie. sorting like aábcčdďeéě...? This seems
to me as more accurate approach, even if it's not as defined simplified
standard rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17105] Do not see checkouts in the table of circulation.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17105

--- Comment #3 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #2)
> (In reply to Marcel de Rooy from comment #0)
> 
> > This javascript error occurred: Sunday not defined.
> 
> I can reproduce this error in Firefox if I manually update the
> CalendarFirstDayOfWeek preference with the value "Sunday." Could it be a
> data problem from an upgrade?

Might have been a syspref caching problem too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #7 from Josef Moravec  ---
(In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #6)
> Regardning your last post, the sorting is much more sofisticated. The
> simplified (your) alphabet is used only when we actually CAN decide about
> hte correct order. If we cannot, it's required to use special signs like in
> this example:
> - Sálá
> - Sála
> In this case the secondary ordering rule should be taken into account, I
> think.

According to Zebra documentation here:
http://www.indexdata.com/zebra/doc/character-map-files.html

It looks like zebra is not capable doing 2-level sorting...

So propably this could be better than nothing, as it looks like secondary
sorting is edge case...

what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373

François Pichenot  changed:

   What|Removed |Added

 CC||fpiche...@ville-roubaix.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues with sentence splitting in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56615|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues with sentence splitting in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

--- Comment #26 from Jonathan Druart  
---
ok, back to Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #6 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Regardning your last post, the sorting is much more sofisticated. The
simplified (your) alphabet is used only when we actually CAN decide about hte
correct order. If we cannot, it's required to use special signs like in this
example:
- Sálá
- Sála
In this case the secondary ordering rule should be taken into account, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #5 from Josef Moravec  ---
It's not true.

For sorting shouldn't be used full czech alphabet.

See https://cs.wikipedia.org/wiki/Abecedn%C3%AD_%C5%99azen%C3%AD

or

https://albatros.vlada.cz/usneseni/usneseni_webtest.nsf/WebGovRes/0AD8FEF4CC04B7A4C12571B6006D69D0?OpenDocument

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #4 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
In my opinion, czech alphabet needs better sorting of characters like "a" vs.
"á". For instance "Cáchovnice" should be sorted after "Carevna", but it's not:
http://prntscr.com/cvrem1
I think we cannot consider eéě as the same one to be perfect.

This is the correct ordering of czech characters:
https://cs.wikipedia.org/wiki/Česká_abeceda

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17398] Enhance circulation message UI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 CC||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #3 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
The right copy command for kohadevbox is following:
cp /home/vagrant/kohaclone/etc/zebradb/lang_defs/cs/sort-string-utf.chr
/etc/koha/zebradb/lang_defs/cs/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues with sentence splitting in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

Marc Véron  changed:

   What|Removed |Added

Summary|Translatability: Fix issues |Translatability: Fix issues
   |in Administration   |with sentence splitting in
   |preferences |Administration preferences

--- Comment #25 from Marc Véron  ---
(In reply to Jonathan Druart from comment #24)
> It won't, it just removes the strings I mentionned.

But what I'm doing with the first patch is fixing sentence splitting. It is not
related to wrong french translations , see comment #5

I think if you want to fix the problem mentionned by jmbroust (screenshot and
comments #4 and #5), your patch should go to a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

--- Comment #2 from Josef Moravec  ---
If you aren't building and installing packages after applying patches (which is
most cases I think) you may need copy the new configuration file to /etc
directory manually:

mkdir /etc/koha/zebradb/lang_defs/cs

cp etc/zebradb/lang_defs/cs/sort-string-utf.chr /etc/koha/zebradb/lang_defs/cs/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

--- Comment #24 from Jonathan Druart  
---
It won't, it just removes the strings I mentionned.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17461] Make plugins-home.pl complain about plugins that can not be loaded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17461

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17461] Make plugins-home.pl complain about plugins that can not be loaded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17461

--- Comment #1 from Magnus Enger  ---
Created attachment 56620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56620=edit
Bug 17461 - Warn about plugins that can't be loaded

The logs should have some info if a module has been installed that can
not be loaded.

To test:
- Make sure you have an up to date dev install
- Install v1.0 of the KitchenSink plugin from
  https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases
- Make sure the plugin does not show up in the list of installed
  plugins, and that the intranet-error.log has no info about it
- Apply the patch
- Reload plugins-home.pl
- Verify that there is now some interesting info in intranet-error.log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17461] New: Make plugins-home.pl complain about plugins that can not be loaded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17461

Bug ID: 17461
   Summary: Make plugins-home.pl complain about plugins that can
not be loaded
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org

I tried to install an older version of the KitchenSink plugin, but it did not
show up in the list of plugins. And there was nothing interesting in the logs
either. So how do I figure out what the problem is? See attached patch for my
solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17461] Make plugins-home.pl complain about plugins that can not be loaded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17461

Magnus Enger  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

--- Comment #10 from Magnus Enger  ---
The new scripts need to be documented in man pages, similar to the existing
scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17460] Staff interface to manage self-registered patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17460

--- Comment #2 from Mubassir Ahsan  ---
Instant Solution Scenario 1: 
It is possible to list self-registered patrons by their assigned temporary
patron category in patrons page. 
But the question is it is not possible to determine they  have verified their
email address or not.

Instant Solution Scenario 2:
Adding a page with a button self-registered patrons list just after the button
"Patron Lists". Which may contain following listed table columns:
1. Card 
2. Name
3. Email
4. Verified or not
5. Library (Dropdown list will facilitate to change instantly)
6. Patron Category (Dropdown list will facilitate to change instantly)
7. Button to activate or reject

An email template should be added to send activation notification.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

Magnus Enger  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #9 from Magnus Enger  ---
Looks like this has a patch that needs signoff. Changing the status
accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

--- Comment #23 from Marc Véron  ---
(In reply to Jonathan Druart from comment #22)
> It removes the 'file.pref#prefname#' parts from the msgstr.

How does it ease the problem with splitted sentences?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

--- Comment #22 from Jonathan Druart  
---
It removes the 'file.pref#prefname#' parts from the msgstr.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #91 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #90)
> Created attachment 56619 [details] [review]
> Bug 17216: Revert changes to ItemsSearchField schema file

@RM, could you please push this follow-up please? It seems that I have
generated a wrong file (80 vs 32).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #90 from Jonathan Druart  
---
Created attachment 56619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56619=edit
Bug 17216: Revert changes to ItemsSearchField schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

--- Comment #13 from Jonathan Druart  
---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

--- Comment #12 from Jonathan Druart  
---
Created attachment 56618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56618=edit
Bug 16344: [DO NOT PUSH] Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

--- Comment #11 from Jonathan Druart  
---
Created attachment 56617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56617=edit
Bug 16344: Fix alignment between top and bottom columns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53428|0   |1
is obsolete||
  Attachment #53429|0   |1
is obsolete||
  Attachment #53430|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 56616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56616=edit
Bug 16344: Add a circ rule to limit the auto renewals given a specific

This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to
block/allow
auto renewals after a given date.
The idea is to stop renewals at a given date. That way the library will have
time to send overdues and get the books back before the students do on holiday.

Test plan:
0/ Execute the update DB entry
1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow
2/ Modify the issues.issuedate, to simulate a checkout in the past:
UPDATE issues
SET issuedate = "-mm-dd hh:mm:ss"
WHERE itemnumber = YOUR_ITEMNUMBER;
with issuedate = 2 days before for instance
3/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed
4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday
5/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17460] Staff interface to manage self-registered patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17460

Mubassir Ahsan  changed:

   What|Removed |Added

 CC||mahsa...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17426] AutoCommit should not be set in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17426

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

--- Comment #21 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #20)
> (In reply to Jonathan Druart from comment #19)
> > Kyle, what are you testing on t/db_dependent/Koha/Account.t?
> > it seems that it is already covered by the tests on 
> > t/db_dependent/Accounts.t
> 
> I did not add that unit test file. I'll just deprecate it since it is not
> necessary.

Then now you need to provide tests for these changes :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

--- Comment #3 from Jonathan Druart  
---
(In reply to Chris Cormack from comment #2)
> Would you mind if I did a quick follow up that added the option to pass in
> username and password as parameters?
> 
> (It could still default to koha/koha if they weren't set)

Please do :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|minor   |normal

--- Comment #3 from Katrin Fischer  ---
We are currently running into this - it's irritating for the libraries tht
sometimes you have to use . and other times you have to use , - There is a lot
of error potential if you are not careful. Updating severity a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1707] Search for patron '%' returns all results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
(In reply to Petter Goksøyr Åsen from comment #3)
> This is still a problem. I'd say the member search is dangerous and
> generates some horrible queries which takes many minutes to run if you have
> a large dataset.
> 
> We have over 300,000 patrons.
> 
> If someone search for something stupid like %29% - this is (part of) the
> generated query:
> https://gist.githubusercontent.com/boutros/db14414591ea77638b2a3a183a18ec00/
> raw/d59f7ef33890b7a034f24a0d350b5af3b6257e4e/bigquery.sql

How d(In reply to Petter Goksøyr Åsen from comment #3)
> This is still a problem. I'd say the member search is dangerous and
> generates some horrible queries which takes many minutes to run if you have
> a large dataset.
> 
> We have over 300,000 patrons.
> 
> If someone search for something stupid like %29% - this is (part of) the
> generated query:
> https://gist.githubusercontent.com/boutros/db14414591ea77638b2a3a183a18ec00/
> raw/d59f7ef33890b7a034f24a0d350b5af3b6257e4e/bigquery.sql

For the records: http://irc.koha-community.org/koha/2016-10-13#i_1866950

Petter, how did you finally fix it?
I have several ways to fix it but I don't figure out which one is the best.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

--- Comment #21 from Marc Véron  ---
(In reply to Jonathan Druart from comment #20)
> Created attachment 56615 [details] [review]
> [COUNTER-PATCH] Bug 16687: Translatability: Fix issues in Administration
> preferences
> 
> This is how I'd fix that issue, please give it a try.

Hi Jonathan,

Thanks for the counter patch.

Can you please elaborate a little bit what your counter patch does?
How does it ease the problem with splitted sentences?

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8010] Search history can be added to the wrong patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010

--- Comment #5 from Jonathan Druart  
---
What you describe is the expected behavior.
We could imagine a pref to disable the search history for non-logged in user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687

--- Comment #20 from Jonathan Druart  
---
Created attachment 56615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56615=edit
[COUNTER-PATCH] Bug 16687: Translatability: Fix issues in Administration
preferences

This is how I'd fix that issue, please give it a try.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17459] Add a script to create a superlibrarian user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17459

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
Would you mind if I did a quick follow up that added the option to pass in
username and password as parameters?

(It could still default to koha/koha if they weren't set)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/