[Koha-bugs] [Bug 18120] New: CRUD Endpoint for Vendors in REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Bug ID: 18120
   Summary: CRUD Endpoint for Vendors in REST API
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: matthias.meusbur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: bren...@bywatersolutions.com, tomasco...@gmail.com

Add an endpoint for handling vendors.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18119] Bug 17988 broke cataloging javascript functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #4 from Jonathan Druart  
---
Thanks Josef!
Skipping QA as it's  very easy one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18119] Bug 17988 broke cataloging javascript functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #60237|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 60240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60240=edit
Bug 18119: Fix comment in cataloguing.js

Test plan:
Go to cataloging, and try something which depends on javascript -
collapse/uncollapse fields, open authority search window, ...
-> without patch it is not working
-> with patch it is working correctly

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18119] Bug 17988 broke cataloging javascript functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18111] Import default framework is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18111

--- Comment #6 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #4)
> > +ExportFramework('', \$strXml, $format);
> 
> Shouldn't this be $frameworkcode? You split the code and name logic, so the
> code is set properly.

Erk yes of course, I kept the wrong line!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18111] Import default framework is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18111

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #60216|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 60239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60239=edit
Bug 18111: Fix import of default framework

Caused by bug 16035.

Recreate the issue:
Go to Home › Administration › MARC frameworks
For the default framework: Actions > import
It will not work

Test plan:
Confirm test plans from bug 16035 and bug 17389 still pass
Confirm that the import for the default framework now works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

--- Comment #11 from Jonathan Druart  
---
Silly me, comment in JS is not #!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780

Josef Moravec  changed:

   What|Removed |Added

  Attachment #59513|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 60238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60238=edit
[SIGNED-OFF] Bug 17780 - When choose an author in authority results new window
shows a blank screen

Select2 (Bug 13501) introduced divs and inputs that broke some assumptions
about the expected HTML structure.
This patch checks if input has name attribute, because some inputs in Select2
have not.

To test:
Try to add info from the authorities to field that has subfield with Select2
(subfield with authorised values on Koha 16.11+)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18119] Bug 17988 broke cataloging javascript functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119

--- Comment #2 from Josef Moravec  ---
Created attachment 60237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60237=edit
Bug 18119: Fix comment in cataloguing.js

Test plan:
Go to cataloging, and try something which depends on javascript -
collapse/uncollapse fields, open authority search window, ...
-> without patch it is not working
-> with patch it is working correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18119] Bug 17988 broke cataloging javascript functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780

Josef Moravec  changed:

   What|Removed |Added

 Depends on||18119


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119
[Bug 18119] Bug 17988 broke cataloging javascript functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18119] Bug 17988 broke cataloging javascript functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119

Josef Moravec  changed:

   What|Removed |Added

 Depends on||17988
   Assignee|gmcha...@gmail.com  |josef.mora...@gmail.com
 Blocks||17780
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||katrin.fisc...@bsz-bw.de,
   ||synapse@gmail.com

--- Comment #1 from Josef Moravec  ---
Blocks 17780, because it is not testable without this patch


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780
[Bug 17780] When choose an author in authority results new window shows a blank
screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988
[Bug 17988] Select2 prevents correct tag expand/minimize functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

Josef Moravec  changed:

   What|Removed |Added

 Blocks||18119


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119
[Bug 18119] Bug 17988 broke cataloging javascript functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18119] New: Bug 17988 broke cataloging javascript functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119

Bug ID: 18119
   Summary: Bug 17988 broke cataloging javascript functionality
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: josef.mora...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

See comment 8 on bug 17988

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118

Mason James  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118

Mason James  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 Depends on||10988


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Mason James  changed:

   What|Removed |Added

 Blocks||18118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118
[Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and 'OpacPublic'
syspref combination
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118

--- Comment #2 from Mason James  ---
Created attachment 60236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60236=edit
Bug 18118 - Unexpected behaviour with 'GoogleOpenIDConnect' and 'OpacPublic'
syspref combination.

to test this patch...
1/ configure a working 'GoogleOpenIDConnect' account

2/ set 'OpacPublic' syspref to OFF

3/ log in user successfully via google-auth, observe redirect to opac-user.pl
(bad)

4/ apply patch

5/ log in user successfully via google-auth, observe expected redirect to
opac-main.pl (good)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

--- Comment #10 from Katrin Fischer  ---
Hi Oleg, we will need a sign-off there first - I have upped the severity a bit!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

--- Comment #9 from Oleg Vasilenko  ---
It would be great, if another bug connected with Select2 would also be pushed
to master — Bug 17780
It gives us a lot of problems, because authority records either are not added
at all, or added without ID (and so would not be updated).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #26 from M. Tompsett  ---
(In reply to M. Tompsett from comment #25)
> Sweet! Let's get some sign off. :)

t/db_dependent/Circulation.t does a good job of testing the revision, except
for one case!

2675 # If the count of the union of the lists of reservable items
for each borrower
2676 # is equal or greater than the number of borrowers, we know
that all reserves
2677 # can be filled with available items. We can get the union of
the sets simply
2678 # by pushing all the elements onto an array and removing the
duplicates.
2679 my @reservable;
2680 my %borrowers;
2681 print STDERR "check 1\n";
2682 ITEM: foreach my $i (@itemnumbers) {
2683 print STDERR "check 2\n";
2684 my $item = GetItem($i);
2685 next if IsItemOnHoldAndFound($i);
2686 print STDERR "check 3\n";
2687 for my $b (@borrowernumbers) {
2688 print STDERR "check 4\n";
2689 my $borr = $borrowers{$b}//=
C4::Members::GetMember(borrowernumber => $b);
2690 next unless IsAvailableForItemLevelRequest($item,
$borr);
2691 print STDERR "check 5\n";
2692 next unless CanItemBeReserved($b,$i);
2693 print STDERR "check 6\n";
2694
2695 push @reservable, $i;
2696 if (@reservable >= @borrowernumbers) {
2697 print STDERR "check 7\n";
2698 $resfound = 0;
2699 last ITEM;
2700 }
2701 print STDERR "check 8\n";
2702 last;
2703 }
2704 }

As you can see, I added print statements, "check 8" is not triggered.

$ git checkout -b bug_17941 origin/master
$ git bz apply 17941
-- add in the STDERR's above.
$ sudo koha-shell -c bash kohadev
K$ prove -v t/db_dependent/Circulation.t 2>&1 | grep check | sort -u
-- output has check 1 through check 7, but not check 8.

So, if you could add a test which triggers check 8, that would be good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118

--- Comment #1 from Mason James  ---
(In reply to Mason James from comment #0)
> When 'OpacPublic' is set to NO, a successful login will load the main OPAC
> page (opac-main.pl), that's good, correct and expected
> 
> The bug is that with 'OpacPublic' set to OFF and 'GoogleOpenIDConnect' set
> ON - a successful login redirects the user to their account page
> (opac-user.pl) not the main OPAC page, that's unexpected and bad

oops, s/NO/OFF/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18118] New: Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118

Bug ID: 18118
   Summary: Unexpected behaviour with 'GoogleOpenIDConnect' and
'OpacPublic' syspref combination
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: m...@kohaaloha.com
QA Contact: testo...@bugs.koha-community.org

When 'OpacPublic' is set to NO, a successful login will load the main OPAC page
(opac-main.pl), that's good, correct and expected

The bug is that with 'OpacPublic' set to OFF and 'GoogleOpenIDConnect' set ON -
a successful login redirects the user to their account page (opac-user.pl) not
the main OPAC page, that's unexpected and bad

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Mason James  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #9 from Mason James  ---
Created attachment 60235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60235=edit
Bug 18026 - URL to database columns link in system preferences is incorrect
(master)

Here's a patch for the master branch

 Changes to be committed:
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #8 from Mason James  ---
Created attachment 60234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60234=edit
Bug 18026 - URL to database columns link in system preferences is incorrect
(3.22.x)

Here's a patch for the 3.22.x branch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Mason James  changed:

   What|Removed |Added

  Attachment #60231|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Mason James  changed:

   What|Removed |Added

  Attachment #60230|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #7 from Mason James  ---
Created attachment 60233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60233=edit
Bug 18026 - URL to database columns link in system preferences is incorrect
(16.11.x)

Here's a patch for the 16.11.x branch

modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #6 from Mason James  ---
Created attachment 60232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60232=edit
Bug 18026 - URL to database columns link in system preferences is incorrect
(16.05.x)

Here's a patch for the 16.05.x branch

modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #5 from Mason James  ---
Created attachment 60231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60231=edit
Bug 18026 - URL to database columns link in system preferences is incorrect
(16.05.x)

Here's a patch for the 16.05.x branch

The command I used to do the search/replace was...

$ grep -irl 'schema.koha-community.org/tables' ./* | grep -v .git | xargs perl
-pi -e 's^koha-community.org/tables^koha-community.org/16_05^'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Mason James  changed:

   What|Removed |Added

  Attachment #60138|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #4 from Mason James  ---
Created attachment 60230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60230=edit
Bug 18026 - URL to database columns link in system preferences is incorrect
(16.11.x)

Here's a patch for the 16.11.x branch

The command I used to do the search/replace was...

$ grep -irl 'schema.koha-community.org/tables' ./* | grep -v .git | xargs perl
-pi -e 's^koha-community.org/tables^koha-community.org/16_11^'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13777] patron lists not showing on patron search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13777

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||aleishaamo...@hotmail.com

--- Comment #2 from Aleisha Amohia  ---
I don't believe this is still valid on the latest version. Setting to Resolved

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #2 from Aleisha Amohia  ---
Created attachment 60229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60229=edit
Bug 13205: Last/first page options for result list paging

This patch adds first and last page buttons to the pagination at the
bottom of a page of catalog search results.

To test:
1) Apply patch
2) Do a number of searches
3) For each search, ensure that the first and last page buttons work as
expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13057] Empty library dropdown in funds header search on some budgets and funds pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13057

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Aleisha Amohia  ---
I think this has been fixed - In this latest version, there is no dropdown of
libraries. You can select 'Plan by libraries', which takes you to a page where
all branches are showing and you can select which to plan for. Setting to
Resolved

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13844] Orphaned lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13844

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #3 from Aleisha Amohia  ---
See Bug 11889 - I have created a patch for a syspref that lets you choose
whether to delete a user's lists when you delete their account, or if the
ownership of those lists will get transferred to the person who deleted the
owner.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10909] You can delete a patron who has created virtualsheves without any warn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10909

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #3 from Aleisha Amohia  ---
See Bug 11889 - I have created a patch for a syspref that lets you choose
whether to delete a user's lists when you delete their account, or if the
ownership of those lists will get transferred to the person who deleted the
owner.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn' t have permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||aleishaamo...@hotmail.com
   Assignee|m.de.r...@rijksmuseum.nl|aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn' t have permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn' t have permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679

--- Comment #4 from Aleisha Amohia  ---
Created attachment 60228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60228=edit
Bug 10679: Hide delete option for lists if user does not have permission

The reason the delete button was still showing is because, by default,
we allow anyone to remove THEIR OWN contributions from a list. So, the
delete button will always show. This patch makes sure that the delete
button will only show if permission for anyone else to add or delete
their own entries is granted.

To test:
1) Make a public list setting all permissions to 'do not allow' EXCEPT
'remove own contributed entries' (set this to Allow). This should be
done by default, but just make sure
2) Log in as a different user and go to that list. notice the 'remove
selected' button shows, but attempting to delete any records fails.
3) Apply patch and refresh the page
4) Notice that the delete button is now gone.
5) Log back in as the list owner and set the first two permissions to
'Allow' (add entries, remove their own contributed entries)
6) Log back in as a different user and go to the list. The delete button
should now be showing and work as expected.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a baset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a baset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
  Change sponsored?|--- |Sponsored
 CC||aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a baset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978

--- Comment #1 from Aleisha Amohia  ---
Created attachment 60227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60227=edit
Bug 10978: Redirect to basket list of a supplier after deleting a basket

This patch redirects to the vendor's list of baskets after deleting a
basket, fixes breadcrumbs after deletion and also hides the toolbar
actions after deletion (seeing as you can't edit/export etc a basket
that no longer exists).

To test:
1) Go to Acquisitions -> find a vendor -> view a basket or create a new
basket
2) Delete the basket. Notice you are taken to a list of all vendors and
baskets
3) Apply patch and do step 1 again
4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and
confirm link to return to baskets for the vendor works.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #24 from M. Tompsett  ---
Comment on attachment 60191
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60191
Bug 17941 typo

Review of attachment 60191:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17941=60191)
-

::: C4/Circulation.pm
@@ +2688,4 @@
>  next unless IsAvailableForItemLevelRequest($item, $borr);
>  next unless CanItemBeReserved($b,$i);
>  
> +push @reservable, $i;

Ah, you caught it. Great!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #25 from M. Tompsett  ---
Comment on attachment 60192
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60192
Bug 19741 more typos

Review of attachment 60192:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17941=60192)
-

::: C4/Circulation.pm
@@ +2684,4 @@
>  my $item = GetItem($i);
>  next if IsItemOnHoldAndFound($i);
>  for my $b (@borrowernumbers) {
> +my $borr = $borrowers{$b}//= 
> C4::Members::GetMember(borrowernumber => $b);

Sweet! Let's get some sign off. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #23 from M. Tompsett  ---
Comment on attachment 60189
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60189
Bug 17941 avoid scanning the full cartesian product

Review of attachment 60189:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17941=60189)
-

Love the optimization, but two tiny code changes would improve readability.

::: C4/Circulation.pm
@@ +2683,5 @@
> +ITEM: foreach my $i (@itemnumbers) {
> +my $item = GetItem($i);
> +next if IsItemOnHoldAndFound($i);
> +for my $b (@borrowernumbers) {
> +my $borr = $borrowers{$b}//= 
> C4::Members::GetMember(borrowernumber => $_);

Could we avoid $_? It is harder to read. Here it should be $b.

@@ +2687,5 @@
> +my $borr = $borrowers{$b}//= 
> C4::Members::GetMember(borrowernumber => $_);
> +next unless IsAvailableForItemLevelRequest($item, $borr);
> +next unless CanItemBeReserved($b,$i);
> +
> +push @reservable;

The old code is pushing item numbers into the reservable array. This seems to
be using an implicit $_ type behaviour, which I believe is $b. This isn't code
equivalent, and explicit is always easier for debugging later. Though, I don't
think it will matter, which is probably why it was optimized this way. Still,
could we be explicit? It's easier to read.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18111] Import default framework is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18111

--- Comment #4 from M. Tompsett  ---
Comment on attachment 60216
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60216
Bug 18111: Fix import of default framework

Review of attachment 60216:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18111=60216)
-

Overall, I like this cleaner code.

::: admin/import_export_framework.pl
@@ +53,5 @@
>  ## Exporting
>  if ($action eq 'export' && $input->request_method() eq 'GET') {
>  my $strXml = '';
> +my $format = $input->param('type_export_' . $framework_name);
> +ExportFramework('', \$strXml, $format);

Shouldn't this be $frameworkcode? You split the code and name logic, so the
code is set properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13685] Sorting Patron Reading History

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

M. Tompsett  changed:

   What|Removed |Added

  Attachment #60222|0   |1
is obsolete||

--- Comment #15 from M. Tompsett  ---
Created attachment 60226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60226=edit
[SIGNED-OFF] Bug 13685: Sorting by author in opac reading history

opac-readingrecord.pl was actually already set up to do this, the option
to sort by author was just not put into the tt file. This patch adds
that.

To test:
1) Log into OPAC, go to your reading history
2) Confirm that 'Order by author' shows in the dropdown
3) Confirm it works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13685] Sorting Patron Reading History

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13685] Sorting Patron Reading History

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

--- Comment #14 from M. Tompsett  ---
Strangely, orderbyauthor code was already in the perl script, but finding where
it may have been deleted is difficult. But this fix is good. And as the layout
doesn't change, I think bug 18108 could be closed (unless we foresee people
signing out a large number of books at the same time, in which case we should
add this drop-down). I was worried about consistency of appearance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7626] Delete multiple tags at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com
 CC||aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7626] Delete multiple tags at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626

Aleisha Amohia  changed:

   What|Removed |Added

   Attachment #7949|0   |1
is obsolete||

--- Comment #2 from Aleisha Amohia  ---
Created attachment 60225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60225=edit
Bug 7626: Delete multiple tags in OPAC at once

This patch removes the individual 'Delete' buttons for every tag as
suggested in Comment 0. It adds a checkbox to every tag, with a 'Delete
selected tags' button at the bottom of the table. This patch also adds a
function to check if any checkboxes have been checked before submitting
the form (only works with JS enabled).

To test:
1) Find a record in the OPAC and add some tags to it
2) Go to your tags and notice the checkboxes, no more delete buttons for
each tag
3) Click 'Delete selected tags' button without selecting any tags
4) Confirm alert shows up. Click OK
5) Select one or more tags and click 'Delete selected tags' button
6) Confirm delete is successful and correct number of deleted tags shows
up

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7626] Delete multiple tags at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6495] After deleting a list the output of lists is truncated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6495

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #5 from Aleisha Amohia  ---
Is this still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11889] Disown a list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|m.de.r...@rijksmuseum.nl|aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored
 CC||aleishaamo...@hotmail.com
   Patch complexity|Medium patch|Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11889] Disown a list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11889] Disown a list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

--- Comment #5 from Aleisha Amohia  ---
Created attachment 60224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60224=edit
Bug 11889: Disown a list upon deletion of owner

This patch adds a syspref 'ListOwnershipUponPatronDeletion' which
decides if all the owner's lists (public and private) are deleted
when the owner is deleted, or if the ownership of their public and
shared lists are transfered to the user who deleted the owner (private
lists that are not shared are always deleted).

To test:
1) Apply patch and update database
2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...'
3) Set up a superlibrarian user
4) Log in as this superlibrarian user and set up three lists, a public
list (maybe named 'public'), and two private lists (named 'private' and
'shared')
5) Log in as this user to the opac (if you haven't already) and share
the 'shared' list with someone
6) View the virtualshelves table in mysql to see the three lists you
just created under your new user
7) Also view the virtualshelfshares table in mysql to see the 'shared'
list
8) Log into the staff client with your regular user (a different user to
the one you just created)
9) Search for the user you just created and delete them
10) Go to your lists
11) You should see the 'shared' list under your private lists, and their
'public' list under your public lists, both with you as the owner
12) if you view both the virtualshelves table and the virtualshelfshares
table in mysql again, youll see you are now the owner and the 'private'
list will no longer exist.
13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...'
14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and
'public' lists before you re-create them)
15) You should not see any of the lists you just made under private or
public lists this time. To confirm, check the virtualshelves table in
mysql and make sure that all three lists have been deleted.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18117] Convert browser alerts to modals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18117] New: Convert browser alerts to modals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117

Bug ID: 18117
   Summary: Convert browser alerts to modals
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

With modals becoming more active in Koha, I think we need to move away from
alert messages and stick with modals.

Alert messages look different from browser to browser, and you have less/no
control over the look and feel of the alert.

Modals would allow for more enhancement, such as color and sound, if someone
chose that.

The big concern is consistency.  We lack consistency between alerts and modals,
and with alerts between browsers.

I would proposed a stop on use of alert messages, and convert existing uses of
alerts to modal.

That's my opinion.  Would like to hear others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17913] Merge three authority merge fixes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #75 from Katrin Fischer  ---
Thx a lot Josef for retesting this on 16.11 specifically. 
I have pushed Marcel's patch and Josef's follow-up up to 16.11.x for 16.11.04
now. 

Marcel, could you take a look maybe too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Liz Rea  changed:

   What|Removed |Added

  Attachment #60108|0   |1
is obsolete||

--- Comment #4 from Liz Rea  ---
Created attachment 60223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60223=edit
Bug 18025 - Expired password recovery links cause sql crash

When a user gets an email, but doesn't act or visit it within two days,
 attempting to create a new one causes a collision. We should just
 delete the old one, assuming they still want to reset their
 password.

To test:
create yourself a borrower with a userid and password.
Attempt a password recovery on the OPAC
update the entry in the database for that user to have an expired token
e.g. update borrower_password_recovery set valid_until = '2017-01-25
03:25:26' where borrowernumber = 12;
Attempt another password recovery operation - should error
apply the patch
Try it again - no error, new token is generated and additional email
with new link is sent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

--- Comment #8 from Katrin Fischer  ---
Follow up breaks the collapsing/uncollapsing of the fields -  
I think # is not allowed in Javascript for comments.
Needs to be fixed on master - I will remove the second patch from my branch
before pushing it up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #92 from Katrin Fischer  ---
Revert?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18095] Batch item modification: Better message if no item is modified

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
Conflicts in 16.11.x - please rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #25 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

Thx Cloe!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18047] JavaScript error on item search form unless LOC defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #13 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #22 from Katrin Fischer  ---
Should this be in 16.11.x? Not sure if it fixes a bug atm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18089] All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #24 from Katrin Fischer  ---
'Smells' a bit of possible behaviour change. Marcel, what do you think?
Not pushing this for 16.11.04, might reconsider later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13685] Sorting Patron Reading History

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #60134|0   |1
is obsolete||

--- Comment #13 from Aleisha Amohia  ---
Created attachment 60222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60222=edit
Bug 13685: Sorting by author in opac reading history

opac-readingrecord.pl was actually already set up to do this, the option
to sort by author was just not put into the tt file. This patch adds
that.

To test:
1) Log into OPAC, go to your reading history
2) Confirm that 'Order by author' shows in the dropdown
3) Confirm it works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13685] Sorting Patron Reading History

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #31 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

At last :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18077] Batch item modification link is bold when batch item deletion is active in tools menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18077

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18077] Batch item modification link is bold when batch item deletion is active in tools menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18077

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #60107|0   |1
is obsolete||

--- Comment #4 from Aleisha Amohia  ---
Created attachment 60221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60221=edit
Bug 18077: Batch item modification link is bold when batch item deletion is
active in tools menu

To test:
1) Go to Tools -> Batch item deletion
2) Notice the link for Batch item MODIFICATION is bold, not the deletion
link
3) Apply patch and refresh page
4) Correct link should now be bold.
5) Go to batch item modification and confirm the correct link is bold

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17940] Holds not going to waiting state after having been transferred

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #12 from Katrin Fischer  ---
Good to see this fixed!

This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18076] Error when placing a hold and holds per record is set to 999

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||katrin.fisc...@bsz-bw.de
   Severity|normal  |enhancement
 Resolution|--- |FIXED

--- Comment #10 from Katrin Fischer  ---
Code clean-up - good thing, but strictly speaking not a bug fix. Resetting to
enh. As an enhancement this won't get backported for 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441

Johnny Rotten  changed:

   What|Removed |Added

 CC||geo...@nekls.org,
   ||geor...@latahlibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18073] Holds to pull UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #10 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

... but looking forward to see it in 17.05!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079
Bug 18079 depends on bug 18073, which changed state.

Bug 18073 Summary: Holds to pull UI improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18116] New: Koha.pm should contain pointers to other koha documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18116

Bug ID: 18116
   Summary: Koha.pm should contain pointers to other koha
documentation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Developer documentation
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Running

perldoc Koha

gives documentation for Koha.pm, which currently contains the koha version
number.

... but the other reason one might want to run 'perldoc Koha' is as an entry
point for documentation for the entire koha project.

I think we should expand

SEE ALSO
C4::Context

kohaversion.pl

To point to the major modules in Koha -- Koha::Objects, C4::Circulation, the
development section of the Koha wiki, Koha documentation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #25 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

--- Comment #24 from Katrin Fischer  ---
Created attachment 60220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60220=edit
Screenshot in Firefox

Just for comparison - it looks nicer in Firefox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14020] Improve access to the 'Serial receive' link

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14020

Aleisha Amohia  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||aleishaamo...@hotmail.com
 Status|NEW |RESOLVED

--- Comment #1 from Aleisha Amohia  ---
This has been fixed - in the latest version, the serial receive button is the
main button and the other two options are in a drop down. Marking as Resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Christopher Brannon  ---
We hide the Check in column with css (display:none) instead of removing the
column.  There can be issues with removing a column completely.  This is the
simplest method we found.

Anyway, regarding the button, we simply relabel the button with jQuery.  Is it
possible to modify the button code to change the label or hide it altogether
based on which columns are visible?  So, it would be code right where the
button is displayed that would determine what is on the label.

For example, 
* Button normally displays "Renew or check in selected" (The shorter the
better)
* Button displays "Renew selected" if the Check in column is hidden
* Button displays "Check in selected" if Renew column is hidden
* Button is hidden if both Renew and Check in columns are hidden (up for
discussion if the Renew all button should also be hidden if the renew column is
hidden)

I don't think it is wise to have an option for a particular column in a
separate preference.  It makes sense to have it all together like this.  Keeps
it simple.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/