[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #63626|0   |1
is obsolete||

--- Comment #3 from Aleisha Amohia  ---
Created attachment 63724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63724=edit
Bug 18649: Translatability: Get rid of tt directive in translation for
admin/categories.tt and onboardingstep2.tt

Translation tool shows
[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]
for en/modules/admin/categories.tt and
koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt

This patch fixes it.

To test:
- Apply patch
- Verify that code changes make sense
- Verify that template directive is no longer picked by translation

https://bugs.koha-community.org/show_bug.cgi?id=18641

Patch works as expected for me - also this is a really great way to do
this kind of fix! We should have this all over Koha.
Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18674] New: Show timezone for Perl and MySQL on the About Koha page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

Bug ID: 18674
   Summary: Show timezone for Perl and MySQL on the About Koha
page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: About
  Assignee: neng...@gmail.com
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

With the pushing of Bug 18299, we no longer have a quick way of checking the
timezone of the Perl and MySQL connection. 

We should add some code to the About Koha page to show this info.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18674

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18299

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299

--- Comment #17 from David Cook  ---
(In reply to Kyle M Hall from comment #15)
> (In reply to David Cook from comment #13)
> > (In reply to Jonathan Druart from comment #8)
> > > I was not aware of this script and I think it does not make sense to have 
> > > it.
> > > I'd prefer to remove it than adding more code to the codebase to maintain 
> > > it.
> > > 
> > > Opinions?
> > 
> > I was not aware of this script until recently, but I have been using it to
> > double-check that I've set up the timezone for Koha correctly in Apache. 
> > 
> > I'm OK with removing the script overall, but could we add timezone
> > information to the About page in the "Server information" tab?
> 
> Can you file an enhancement bug for that? I imagine we should be able to
> make that happen pretty easily.

Sounds good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669

--- Comment #4 from David Cook  ---
(In reply to Josef Moravec from comment #3)
> I just signed off, because it does work as described, but I am just curious
> if we should make the changes from bug 9683 and this bug to debian apache
> templates too...

Thanks, Josef. 

I figure it's probably a good idea to update the Debian templates as well, but
I imagine that should be a separate bug. 

Soon, I'm going to set up a Debian virtual machine to test Debian-specific
patches so maybe at that point I'll post some patches (or be able to test
someone else's).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alei...@catalyst.net.nz

--- Comment #2 from Aleisha Amohia  ---
Patch was unable to apply:

Applying: Bug 18260: Koha::Biblio - Remove GetBiblio
Using index info to reconstruct a base tree...
M   C4/Acquisition.pm
M   C4/Biblio.pm
M   C4/ILSDI/Services.pm
M   C4/ImportBatch.pm
M   C4/Serials.pm
M   Koha/REST/V1/Hold.pm
M   catalogue/imageviewer.pl
M   catalogue/itemsearch.pl
M   t/db_dependent/Acquisition.t
M   tools/batch_delete_records.pl
Falling back to patching base and 3-way merge...
Auto-merging tools/batch_delete_records.pl
CONFLICT (content): Merge conflict in tools/batch_delete_records.pl
Auto-merging t/db_dependent/Acquisition.t
Auto-merging catalogue/itemsearch.pl
Auto-merging catalogue/imageviewer.pl
Auto-merging Koha/REST/V1/Hold.pm
Auto-merging C4/Serials.pm
Auto-merging C4/ImportBatch.pm
Auto-merging C4/ILSDI/Services.pm
Auto-merging C4/Biblio.pm
Auto-merging C4/Acquisition.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 18260: Koha::Biblio - Remove GetBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley  changed:

   What|Removed |Added

Summary|Creation of informational   |Creation of Koha feature
   |tool displayed after|release change tool
   |running Koha update |displayed after running
   ||Koha update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

David Roberts  changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om

--- Comment #10 from David Roberts  ---
Katrin, I hope that's working better now. No idea what went wrong last time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

--- Comment #8 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

--- Comment #9 from PTFS Europe Sandboxes  ---
Created attachment 63723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63723=edit
Bug 18656 - Require confirmation of deletion of files from patron record

This patch adds a JavaScript confirm to the deletion of files. It also
styles the file deletion link as a Bootstrap button.

To test, apply the patch and open the "Files" page for a patron who has
files attached.

- Verify that clicking any "delete" link prompts for a confirmation.
- Verify that confirming the dialog triggers the deletion of the correct
  file.
- Verify that canceling the confirmation dialog aborts the deletion.
- Confirm that the "Delete" button looks correct.

Signed-off-by: David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #63691|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

Brendan Gallagher  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||bren...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18671] Calendar.t failing exception holiday test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18671

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18673] News author does not display on staff client home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Severity|enhancement |trivial
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18673] News author does not display on staff client home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673

--- Comment #1 from Marc Véron  ---
Created attachment 63722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63722=edit
Bug 18673: News author does not display on staff client home page

News authors do not display on staff client homepage, independently of
syspref 'NewsAuthorDisplay'. This patch fixes the issue.

To verify:
- Create news with display location 'All'
- Set syspref NewsAuthorDisplay to 'Staff client only' or 'Both OPAC and staff
client'
- Go to staff client
- Verify that news author does not appear (but it should)

To test:
- Applly patch
- Verify that news author is displayed as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18673] New: News author does not display on staff client home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673

Bug ID: 18673
   Summary: News author does not display on staff client home page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

News authors do not display on staff client homepage, independently of syspref
'NewsAuthorDisplay'

To verify:
- Create news with display location 'All'
- Set syspref NewsAuthorDisplay to 'Staff client only' or 'Both OPAC and staff
client'
- Go to staff client
- Verify that news author does not appear (but it should)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665

--- Comment #3 from Marc Véron  ---
Created attachment 63721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63721=edit
Bug 18665: Add test for HtmlTags.pm

This patch adds tests for the tt filter HtmlTags.pm

To test: prove -v t/HtmlTags.t should pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18672] New: Creation Date and Modification Date are the same for a list in the Lists Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

Bug ID: 18672
   Summary: Creation Date and Modification Date are the same for a
list in the Lists Module
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: ka...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 63720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63720=edit
Creation Date and Modification Date are the same for a list in the Lists Module

In the Lists Module the creation date and the modification date show the same
date for each list. The expected behavior is that the creation date would be
the date that the list was created and the modification date would be the last
date that any changes were made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12836] Add a script to regenerate Explain files from configs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
There is a lot of output running this from inside the koha-shell as 'perl
misc/maintanence/generate_explain.pl'

Looking at /etc/koha/sites/kohadev/koha-conf.xml
Use of uninitialized value $publicserver in split at
misc/maintenance/generate_explain.pl line 216.
Use of uninitialized value $host in concatenation (.) or string at
misc/maintenance/generate_explain.pl line 217.
Use of uninitialized value $port in concatenation (.) or string at
misc/maintenance/generate_explain.pl line 217.
SRU is listening on host  and port 
Use of uninitialized value $pqf_properties_file in concatenation (.) or string
at misc/maintenance/generate_explain.pl line 221.
Looking at 
Use of uninitialized value $file_name in -e at /usr/share/perl5/File/Slurp.pm
line 116.
Use of uninitialized value $file_name in sysopen at
/usr/share/perl5/File/Slurp.pm line 193.
Use of uninitialized value $file_name in concatenation (.) or string at
/usr/share/perl5/File/Slurp.pm line 194.
read_file '' - sysopen: No such file or directory at
misc/maintenance/generate_explain.pl line 225.

Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12644] Add subtitles to staff client cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #63713|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 63719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63719=edit
[SIGNED OFF] Bug 12644 - Add subtitles to staff client cart

This patch adds display of subtitles to the staff client cart.

To test you should have some values mapped to subtitle in Administration
-> Keyword to MARC Mapping.

1. Apply the patch.
2. Add some records to the staff client cart which have subtitles.
3. Open the cart and onfirm that subtitles display correctly in both the
   brief and "More details" view.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12644] Add subtitles to staff client cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #76 from Katrin Fischer  ---
Ok, trying to get this tested :)

First: QA tools:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt
   FAIL   git manipulation
The file has been added and deleted in the same patchset

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 55)
forbidden pattern: tab char (line 68)
forbidden pattern: tab char (line 63)
forbidden pattern: tab char (line 61)
forbidden pattern: tab char (line 64)
forbidden pattern: tab char (line 58)
forbidden pattern: tab char (line 65)
forbidden pattern: tab char (line 73)
forbidden pattern: tab char (line 59)
forbidden pattern: tab char (line 57)
forbidden pattern: tab char (line 60)

 FAIL   reports/report_files.pl
   FAIL   git manipulation
The file has been added and deleted in the same patchset

Easy to fix - as we got no sign-off yet, we'd just need to fix the tabs and
squash the patches.

Second: Some code review

1) I think as the permission is under Tools and the files live there too, it
should also be shown as a tool on the tools page instead of under reports. I'd
put it under "Additional tools", maybe under the log viewer.
Report/log files

2) When I click on the link under Reports, I get a 'not found' error. What am I
missing?

3) Looking at the history of this bug, are we missing 2 patches?
Bug 11317 - Allow sorting on date column in file access tool. (1.29 KB, patch)
Bug 11317 - Remove datatables-strings.inc from .tt (959 bytes, patch) 

4) 
+use strict;
+use warnings;
Shoudl be: use Modern::Perl;

Sorry, can't test further because of 2)!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #61089|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 63718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63718=edit
[SIGNED OFF] Bug 9031 - Overdue items crossing DST boundary throw invalid local
time exception

To test:
1 - Set TZ to America/New York
2 - Checkout item and set due date to '2016-03-09 02:29:00"
3 - Make sure fines are set for the item type, fine mode production,
  calculate fines on return
4 - Check in item - invalid date time warning in logs
5 - Apply patch
6 - Check in item - no error
7 - prove t/Calendar.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18671] Calendar.t failing exception holiday test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18671

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=9031

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18671

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395

--- Comment #7 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #6)
> Fixed typo basetgroupname

Thanks. How embarrassing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18671] New: Calendar.t failing exception holiday test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18671

Bug ID: 18671
   Summary: Calendar.t failing exception holiday test
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Test is failing on master - I haven't verified yet if that points to a real
problem, so just setting to 'normal' for now.

prove t/Calendar.t 
t/Calendar.t .. 1/38 
#   Failed test 'Exception holiday is not a closed day test'
#   at t/Calendar.t line 164.
#  got: '1'
# expected: '0'
# Looks like you failed 1 test of 38.
t/Calendar.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/38 subtests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #63681|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 63717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63717=edit
[SIGNED OFF] Bug 5395: Update C4::Acquisition::SearchOrders POD

Comparing the perldoc to the function:
- basketname
- basketgroupname
- budget_id
Were missing. This adds them.

Also, a description of ordernumber and search were
added, as they are not self-evident by their name
alone.

There are no code changes, so all tests should pass
or fail identically before and after patch.

Signed-off-by: Katrin Fischer 
Fixed typo basetgroupname

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

--- Comment #7 from Katrin Fischer  ---
If it's not working from the sandboxes I can attach a patch with your sign-off
line, just let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #63716|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #63691|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #63715|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

--- Comment #5 from PTFS Europe Sandboxes  ---
Created attachment 63716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63716=edit
Bug 18571: Add default ES configuration to koha-conf-site.xml.in

This patch adds a default configuration entry for elasticsearch. It will
add localhost:9200 to the server subsection, and koha_instance (replacing
instance
for the corresponding instance name) for the namespace.

To test:
- Apply the patch
- Copy the file to the /etc/koha dir:
  $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha
- Create a new instance:
  $ sudo koha-create --create-db test
=> SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section:

 
 localhost:9200
 koha_test
 

- Sign off :-D

Note: As the use of ES is syspref driven, this default entry doesn't have any
use
until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt
but will help end users test the ES integration. Advanced users will take care
of
this config entry manually (pointing to external servers/clusters, etc).

Signed-off-by: Mirko Tietgen 

Signed-off-by: Nick Clemens 

Signed-off-by: Kyle M Hall 

Signed-off-by: David Roberts 

https://bugs.koha-community.org/show_bug.cgi?id=18656

Signed-off-by: David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Hi David, the wrong patch got attached, I am reverting this. Do you want to try
again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

--- Comment #4 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #63691|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

--- Comment #3 from PTFS Europe Sandboxes  ---
Created attachment 63715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63715=edit
Bug 18571: Add default ES configuration to koha-conf-site.xml.in

This patch adds a default configuration entry for elasticsearch. It will
add localhost:9200 to the server subsection, and koha_instance (replacing
instance
for the corresponding instance name) for the namespace.

To test:
- Apply the patch
- Copy the file to the /etc/koha dir:
  $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha
- Create a new instance:
  $ sudo koha-create --create-db test
=> SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section:

 
 localhost:9200
 koha_test
 

- Sign off :-D

Note: As the use of ES is syspref driven, this default entry doesn't have any
use
until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt
but will help end users test the ES integration. Advanced users will take care
of
this config entry manually (pointing to external servers/clusters, etc).

Signed-off-by: Mirko Tietgen 

Signed-off-by: Nick Clemens 

Signed-off-by: Kyle M Hall 

Signed-off-by: David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 CC||sandbo...@ptfs-europe.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #81 from Mirko Tietgen  ---
According to Tomás, the newer versions break dev setups, so we are back to
libmojolicious-perl 6.15 and libjson-validator-perl 0.67 for the time being.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514

--- Comment #6 from Nick Clemens  ---
I will double check, I may have just missed those and jumped here.

A few lines do need fixed though:
Koha::ElasticSearch::Indexer;
should be 
Koha::SearchEngine::Elasticsearch::Indexer;

Do you have a bug for ES indexing broken? I haven't hit a problem, but maybe I
need to refresh my mappings.

-Nick

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514

--- Comment #5 from Chris Cormack  ---
Actually no there aren't. Have you not been seeing my updates in our WR system
Nick?

Basically there isn't missing code here, rebuilding elastic search indexes is
busted in master. 

[Request] ** http://localhost:9200 -[400] [mapper_parsing_exception] Failed to
parse mapping [data]: The [string] type is removed in 5.0 and automatic upgrade
failed because parameters [index_analyzer] are not supported for automatic
upgrades. You should now use either a [text] or [keyword] field instead for
field [ff7-01-02]

This is nothing to do with the overdrive code. 

As it dies for misc/search_tools/rebuild_elastic_search.pl too. Which is not
touched by this. That dies for me on current master, with or without these
patches. 

(As an aside we need to track down why you didnt see the updates)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514

--- Comment #4 from Nick Clemens  ---
I think there are some updates on a git branch that need to be imported here,
current code doesn't run

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343

Emma Perks  changed:

   What|Removed |Added

 CC||emma.perks@heartofengland.n
   ||hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11813] Send 'Opac self registration verification' email from branch address if possible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11813

Emma Perks  changed:

   What|Removed |Added

 CC||emma.perks@heartofengland.n
   ||hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901

Emma Perks  changed:

   What|Removed |Added

 CC||emma.perks@heartofengland.n
   ||hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12566] Duplicate checks for Self Registered borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566

Emma Perks  changed:

   What|Removed |Added

 CC||emma.perks@heartofengland.n
   ||hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512

--- Comment #12 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #10)
> Tests don't pass applied on 16.11.x - not pushing this, please check.
> Test Summary Report
> ---
> t/db_dependent/Template/Plugin/AuthorisedValues.t (Wstat: 65280 Tests: 1
> Failed: 1)
>   Failed test:  1
>   Non-zero exit status: 255

Tests were using build_object which doesn't seem to be in 16.11.X

New tests attached

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512

--- Comment #11 from Nick Clemens  ---
Created attachment 63714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63714=edit
Bug 18512: Add tests 16.11.X version

Remove use of build_object

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12644] Add subtitles to staff client cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12644] Add subtitles to staff client cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

--- Comment #2 from Owen Leonard  ---
Created attachment 63713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63713=edit
Bug 12644 - Add subtitles to staff client cart

This patch adds display of subtitles to the staff client cart.

To test you should have some values mapped to subtitle in Administration
-> Keyword to MARC Mapping.

1. Apply the patch.
2. Add some records to the staff client cart which have subtitles.
3. Open the cart and onfirm that subtitles display correctly in both the
   brief and "More details" view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12644] Add subtitles to staff client cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

Owen Leonard  changed:

   What|Removed |Added

Summary|Add subtitles staff client  |Add subtitles to staff
   |cart|client cart

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12644] Add subtitles staff client cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667

Owen Leonard  changed:

   What|Removed |Added

  Attachment #63708|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 63712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63712=edit
Bug 18667 [Revised] Show a diff view of SQL reports when converting

This patch reformats the SQL conversion before-and-after view so that it
shows a diff between the two, just as the Manage MARC Import interface
does.

This patch also makes a correction to the JavaScript which is triggered
by the closing of the modal. In Bootstrap 3 "hidden.bs.modal" is the
event name instead of "hidden."

To test, apply the patch and find an SQL report in your reports library
which requires updating.

- Click the "Update SQL" button.
- In the modal window, the "existing" and "updated" SQL should be shown
  side-by-side with colored highlighting of the differece.
- Confirm that the "Update" button still works correctly.
- Also confirm that if you open the preview of another report, the
  "Close" button hides the modal and updates the contents of the modal
  markup. Use your browser's DOM inspector to confirm that  contains only  and its contents.

Revision moves inline style attributes to CSS block.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #2 from Jacek Ablewicz  ---
(In reply to Katrin Fischer from comment #0)
> The database update 16.06.00.028 fails with following error in an update
> from 3.22.19 to 16.11.08:
> 
> Attempting upgrade to 16.06.00.028 (Bug 17135) ...
> DBD::mysql::st execute failed: Unknown column 'me.no_auto_renewal_after' 
> in 'field list' [for Statement "SELECT `me`.`categorycode`, 
> `me`.`itemtype`, `me`.`restrictedtype`, `me`.`rentaldiscount`, 
> `me`.`reservecharge`, `me`.`fine`, `me`.`finedays`, 
> `me`.`maxsuspensiondays`, `me`.`firstremind`, `me`.`chargeperiod`, 
> `me`.`chargeperiod_charge_at`, `me`.`accountsent`, `me`.`chargename`, 
> `me`.`maxissueqty`, `me`.`maxonsiteissueqty`, `me`.`issuelength`, 
> `me`.`lengthunit`, `me`.`hardduedate`, `me`.`hardduedatecompare`, 
> `me`.`renewalsallowed`, `me`.`renewalperiod`, `me`.`norenewalbefore`, 
> `me`.`auto_renew`, `me`.`no_auto_renewal_after`, `me`.`reservesallowed`, 
> `me`.`holds_per_record`, `me`.`branchcode`, `me`.`overduefinescap`, 
> `me`.`cap_fine_to_replacement_price`, `me`.`onshelfholds`, 
> `me`.`opacitemholds`, `me`.`article_requests` FROM `issuingrules` `me` 
> WHERE ( ( `me`.`branchcode` = ? AND `me`.`categorycode` = ? AND 
> `me`.`itemtype` = ? ) )" with ParamValues: 0='XXX', 1='STUDENT', 
> 2='NORMAL'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
> 
> It's missing the column no_auto_renewal_after which is not present at this
> time in the database. It's added later on with update 16.06.00.046.
> 
> Could it be because the schema already has the column?

Yes, looks like it happens because during this particular upgrade step DBIx
schema is out of sync with the actual database structure, and CalcFine (after
Bug 17599 got pushed ?) is prone to fail because of that.

During upgrades from 16.05.03+ to 16.11.* or 17.05.*, there will be an attempt
to re-run the script from Bug 17135, and it will fail - but at least the
non-accruing FU fine records got already closed in earlier 16.05.03 upgrade
step, so this error should be (relatively) harmless.

Upgrades to 16.11+ from versions earlier than 16.05.03 are affected to a larger
extent by this issue - execution of the script will fail, some non-accruing FU
fines will remain unclosed, and they may get overwritten later on.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fields driven by plugins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Cataloging plugins: change  |Cataloging plugins: change
   |of behaviour at fileds  |of behaviour at fields
   |driven by plugins   |driven by plugins

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #78 from Katrin Fischer  ---


>For non-package installations, the following rewrite rules will need to be 
>>added to the apache config file:
>RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L]
>RewriteRule ^(.*)_(.*).css$ $1.css [R=301,N,L]

Wonder if this might not get lost - would there be a way to automate it? What
happens if you don't?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Josef Moravec  ---
But otherwise it's working as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667

--- Comment #2 from Josef Moravec  ---
Comment on attachment 63708
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63708
Bug 18667 - Show a diff view of SQL reports when converting

Review of attachment 63708:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18667=63708)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt
@@ +7,4 @@
>  [% IF msg == 'no_report' %]
>  There is no valid report for this id.
>  [% ELSIF msg == 'can_be_updated' %]
> +

It would be better to use class instead of style attribute

@@ +11,5 @@
> +Existing SQL
> +[% current_sql | html_entity 
> %]
> +
> +
> +

And here too please

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/