[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #20 from Fridolin SOMERS  ---
Someone has to sign-off the last 2 patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #19 from Fridolin SOMERS  ---
Created attachment 72099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72099=edit
Bug 17809: (follow-up) search in COUNTRY category

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20280] Authorised value categories list in bibliographic frameworks has 2 empty entries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20280

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20280] New: Authorised value categories list in bibliographic frameworks has 2 empty entries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20280

Bug ID: 20280
   Summary: Authorised value categories list in bibliographic
frameworks has 2 empty entries
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To test:
- Edit a subfield in any of your bibliographic frameworks
- In the last section, take a look at the authorised value categories list
- Confirm there are 2 empty entries

Tested with sample data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides confusing options

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

--- Comment #6 from Liz Rea  ---


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides confusing options

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

--- Comment #5 from Hugh Rundle  ---
I'd be very happy to work on that omnibus project Liz, it sounds reasonably
straightforward. Maybe we can talk in our other channel about how to get set up
and understand the process to be able to push patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides confusing options

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #4 from Liz Rea  ---
There ought to be an omnibus for "eliminating ambiguous ok/cancel buttons,"
this happens across Koha and it needs to be fixed for UX reasons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides confusing options

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

--- Comment #3 from Katrin Fischer  ---
Makes sense, thx Hugh!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067

--- Comment #13 from Katrin Fischer  ---
What we need is:
select authorised_value from marc_subfield_structure where frameworkcode =
"BKS" and kohafield = "items.materials" and authorised_value is not null and
authorised_value != "";

But I am failing to translate this correctly at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides confusing options

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

--- Comment #2 from Hugh Rundle  ---
Sorry Katrin, that's probably the en-NZ language pack changing it from Hold to
Reservation in our instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #28 from Hugh Rundle  ---
I like Liz's suggested way of dealing with it.

On the topic of alerts, there is a related problem in that the holds
cancellation alert is quite confusing anyway, because "ok" cancels the hold and
"cancel" doesn't. I've listed this as a separate bug since it affects
unallocated holds as well:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides confusing options

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
It should also not say reservation, but hold (if someone goes to fix this).
I think yes / no would work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20278] New: Cancel Hold alert in OPAC provides confusing options

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

Bug ID: 20278
   Summary: Cancel Hold alert in OPAC provides confusing options
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: hu...@brimbank.vic.gov.au
QA Contact: testo...@bugs.koha-community.org

When a patron cancels a hold, an alert pops up asking "Are you sure you want to
cancel this reservation?" The two options available are "OK" or "Cancel".

OK -> cancels hold
Cancel -> does not cancel hold (cancels the operation)

This is confusing, because clicking 'Cancel' stops the cancellation of the
hold!

It would be clearer if the options were "Yes" and "No":

>Are you sure you want to cancel this hold?
>Yes | No

or perhaps:

>Are you sure you want to cancel this hold?
>Yes I'm sure| Undo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067

--- Comment #12 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #11)
> Caused by commit 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757
> Bug 17250: Do not retrieve marc subfield structure when the authorised
> value is not defined

Or maybe before...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20067


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067
[Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on
notice (catalogue/detail.pl)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||17250

--- Comment #11 from Jonathan Druart  
---
Caused by commit 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757
Bug 17250: Do not retrieve marc subfield structure when the authorised
value is not defined


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250
[Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #27 from Liz Rea  ---
I'm with Hugh.

What should probably happen here, is that if a user cancels the waiting hold
from the OPAC, it should be immediately expired, and put on the "expired holds"
("holds waiting over x days) list in the staff interface. Items on this list
are necessarily actioned by librarians, i.e. pulled off the hold shelf and
returned to circulation or moved on to the next borrower. 

If we need a message for the borrower, it should be something like "This hold
is waiting for you at the library, canceling this hold will remove you from the
list and immediately make the item available to other library users. Cancel
this hold anyway? / Do not cancel this hold"

We could even do a separate tab for these on that waitingreserves page, if that
makes the decision easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067

--- Comment #10 from Katrin Fischer  ---
I think the error is in detail.pl around here:

$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield
=> 'items.materials', authorised_value => { not => undef } });
my %materials_map;
use Data::Dumper; warn Dumper $mss->count;
if ($mss->count) {
my $materials_authvals = GetAuthorisedValues($mss->next->authorised_value);
if ($materials_authvals) {
foreach my $value (@$materials_authvals) {
$materials_map{$value->{authorised_value}} = $value->{lib};
}
}
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067

--- Comment #9 from Katrin Fischer  ---
Hi Marjorie,

can confirm this with the sample data on master!

To test:
- make sure sample data and configuration is loaded
- edit any item
- write 2 in the $3 materials specificed
- check the details page normal view - it will display 'restocking'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

--- Comment #27 from Katrin Fischer  ---

> Indeed, I will add a warn for statistics saying it is used in reports and
> for old_issues that is used in reading history.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #26 from Hugh Rundle  ---
I don't want to derail a quick bugfix given that the current behaviour is
clearly misleading, but is there a reason this initial assumption has gone
unchallenged?

>If a hold is 'waiting' for the patron to collect then the patron should be
>prevented from cancelling the hold via their account in the opac.

Why? Surely we should be making it easy for patrons to self-manage their loans
and holds. As a library patron I would expect to be able to cancel a hold at
any time. If the problem is that staff need to be notified somehow about
cancelled allocated holds then it would be better to tackle that. Would that be
a new bug or have i missed something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18805] Add ability to use up account credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

--- Comment #9 from Katrin Fischer  ---
(In reply to Kyle M Hall from comment #8)
> (In reply to Katrin Fischer from comment #6)
> > When trying to suspend a hold from the holds list in staff, there is an
> > internal server error that translates to:
> > 
> > Can't call method "ymd" on an undefined value at
> > /home/vagrant/kohaclone/Koha/Hold.pm line 65.
> 
> Can you test again? I can't recreate your error. My guess is it was an
> unrelated bug.

I wonder if this comment ended up on the wrong bug report? It appears really
unrelated to the bug topic now and I don't remember. Please discount it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

--- Comment #63 from Katrin Fischer  ---
Hi David, thx for the feedback. Moving this to Failed QA as it seems more
appropriate for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #34 from Katrin Fischer  ---
> Following your comments, I made cosmetic adjustments to the previous patch:
> -  no longer present in alert dialog
> - I also toned down from 'exclamation mark' to a simple period
> - removed the dangling space before ':'
> - server side formatting was changed from sprintf to $Price
> - I also removed the formatting in the  fields. It made no
> sense to me that formatting was used for data traveling between the page and
> the server, unbeknown to the user.

Thx!


> About the behavior of the form: I agree with you, the UX should definitely
> be more user-friendly. Now, I'm open to changes, but I'd rather implement
> everything once we reach a consensus on how it should behave than doing
> "flavors" of the same patch just for QA. Nothing personal ;)
> 
> I'll put this back to 'Needs signoff', for now, just to make it clear that I
> want people testing this patch, but feel free to dial it back to "Failed QA"
> or "In discussion". I'll be keeping a close eye on this.

I totally agree with this approach. It might make sense to ask on the mailing
list as well to get some attention on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Katrin Fischer  ---
Aleisha, can you please take a look at Nicks and my comments? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Roch D'Amour  changed:

   What|Removed |Added

 CC||roch.dam...@inlibro.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Roch D'Amour  changed:

   What|Removed |Added

   Assignee|dominic.piche...@inlibro.co |roch.dam...@inlibro.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

--- Comment #18 from Roch D'Amour  ---
Created attachment 72098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72098=edit
Bug 18820: Main block size now adjust to OpacNavRight like it would for
opacuserlogin

Test plans  :
- "beforepatch.png" shows the result you get when OpacNavRight and opacnav are
set to false.
- "opacuserlogin=f_opacnav=f.png" shows the result with the patch and
OpacNavRight and opacnav set to false
- "opacuserlogin=t_opacnav=f.png" shows the result with the patch and
OpacNavRight set to true and opacnav set to false

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20277] New: Link to host item doesn't work in analytical records if 773$a is present

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20277

Bug ID: 20277
   Summary: Link to host item doesn't work in analytical records
if 773$a is present
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: verolenci...@yahoo.com.ar
QA Contact: testo...@bugs.koha-community.org

A lot of analytical records are made for serials. And for most of them the
title is their primary access point. The OPAC and intranet link in the
analytical record to the host item works well in these cases.
But if you have a 1XX field in your host item, this information goes in your
773$a subfield but the OPAC and intranet link in the analytical record to the
host item includes 773$a and 773$t data but searches only in the title index.
In this situation you can't retrieve the host item record.

Test:
- Create an analytical record for a (host)record with a 1XX field.
- Use the link in the analytical ("In" note) to retrieve the host record in the
intranet client and the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7010] Select all records from search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010

--- Comment #4 from Patrick Robitaille  ---
Hi, 

this problematic always persists in version 17.05. It would be great that when
you select all it very select all the records for a search et not juste the
resultsof one page. 

Patrick. (In reply to Patrick Robitaille from comment #3)
> Hi, 
> 
> this problematic always persists in version 17.05. It would be great that
> when you select all it very select all the records for a search et not juste
> the results of one page. 
> 
> Patrick.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Kyle M Hall  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7010] Select all records from search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010

--- Comment #3 from Patrick Robitaille  ---
Hi, 

this problematic always persists in version 17.05. It would be great that when
you select all it very select all the records for a search et not juste the
resultsof one page. 

Patrick.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Roch D'Amour  changed:

   What|Removed |Added

 CC||roch.dam...@inlibro.com
 Status|Failed QA   |Needs Signoff

--- Comment #118 from Roch D'Amour  ---
Forgot to add test plan... Here we go :

- Generate file hash based on fullpath + filename. This make sure all files are
accessible, even if they have the same filename.

Testing:
0. Make sure the requirements from the last patches are met
1. Add 2 accessdir in your koha-conf, i.e. "/tmp/test" and "/tmp/moretest".
2. Add a file in both directories using the same name for the file:
-echo "small file" > /tmp/test/log
-echo "the size of this file is quite huge" > /tmp/moretest/log
3. Go to Home › Tools › Report/log files and you should see both files with
different size.
4. Download (or open) both files. They should be different.

Thanks for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7010] Select all records from search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20276] New: GetCourseItem is using the wrong call to get itemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276

Bug ID: 20276
   Summary: GetCourseItem is using the wrong call  to get
itemnumber
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

In course_reserves/add_items.pl we now get the item via Objects

This line:
 66 my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} );
Should be:
 66 my $course_item = GetCourseItem( itemnumber => $item->itemnumber );

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20276] GetCourseItem is using the wrong call to get itemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276

Nick Clemens  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #117 from Roch D'Amour  ---
Created attachment 72097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72097=edit
Bug 11317 - File with same name in different directories now has distinct hash

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #7 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #6)
> Hum, I am going to postpone this change for my mental health (holds...)
> 
> But at first glance there is something wrong: the diffbranch flag will never
> be set and we will have a lot of useless code in the template.
> 
> Are you sure this change is correct?

I'm not sure what you mean. This doesn't change ModItemTransfer at all. It only
replaces a bunch of code with a call to ModItemTransfer *if* the item needs
transferred. This reduces code and complexity, and does not affect any other
use of ModItemTransfer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608

--- Comment #9 from David Gustafsson  ---
We (Gothenburg University Library) run a heavily modified version of
bulkmarcimport.pl where this issue should be fixed. We have not have the time
to separate out all fixes into separate issues, and as one big patch the chance
of getting it passed review is probably pretty low. Plus I think authorities
might be broken (since we don't use that functionality). Here it is if you want
to try it out: https://github.com/ub-digit/Koha/tree/bulkmarcimport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19961] Move template JavaScript to the footer: Patron card creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19961] Move template JavaScript to the footer: Patron card creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961

--- Comment #1 from Owen Leonard  ---
Created attachment 72096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72096=edit
Bug 19961: Move template JavaScript to the footer: Patron card creator

This patch modifies the staff client patron card creator templates so
that JavaScript is included in the footer instead of the header.

Also changed: Removed "type" attribute from script tags.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing card batches
- Creating and managing card templates
- Creating and managing printer profiles
- Creating and managing images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #37 from Victor Grousset/tuxayo  ---
Conflicts T_T

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
   Assignee|koha-b...@lists.koha-commun |victor.grous...@biblibre.co
   |ity.org |m

--- Comment #36 from Victor Grousset/tuxayo  ---
It turns out that this is my next task :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72094|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 72095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72095=edit
Bug 19933: (follow-up) Remove patronflags - easy ones

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #14 from Jonathan Druart  
---
Created attachment 72094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72094=edit
Bug 19933: (follow-up) Remove patronflags - easy ones

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20275] Add comment to let users know they can define multiple plugindirs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275

--- Comment #1 from Nick Clemens  ---
Created attachment 72093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72093=edit
Bug 20275: Add comment to let user know they can define multiple plugindirs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20275] Add comment to let users know they can define multiple plugindirs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879

Nick Clemens  changed:

   What|Removed |Added

 Blocks||20275


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275
[Bug 20275] Add comment to let users know they can define multiple plugindirs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20275] Add comment to let users know they can define multiple plugindirs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Depends on||15879


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879
[Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20275] New: Add comment to let users know they can define multiple plugindirs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275

Bug ID: 20275
   Summary: Add comment to let users know they can define multiple
plugindirs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling item-level_itypes syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Keywords||Academy
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20274] New: itemtypes.plugin report: not handling item-level_itypes syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

Bug ID: 20274
   Summary: itemtypes.plugin report: not handling
item-level_itypes syspref
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: victor.grous...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

== Reproduce ==
1. Use staff:/cgi-bin/koha/reports/manager.pl?report_name=itemtypes
2. Change the syspref item-level_itypes
3. One case should give a 0 result


== Cause ==
There is a conditional but part of the SQL query was copy pasted without being
changed.


== Fix ==
"SELECT itemtype" → "SELECT biblioitems.itemtype" in these two lines

https://gitlab.com/koha-community/Koha/blob/673a40d2acc5c8c58b7f3e7e6d11c329d0587fc6/reports/itemtypes.plugin#L46

https://gitlab.com/koha-community/Koha/blob/673a40d2acc5c8c58b7f3e7e6d11c329d0587fc6/reports/itemtypes.plugin#L68

(or maybe the other ones)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #22 from Julian Maurice  ---
(In reply to Claes from comment #19) 
> A second suggestion would complicate it for the developer :-) but here it
> comes:
> 1) The search history page should have a number for each search set/search
> querie. And the numbers should be in this format: #1, #2, #3
> 2) An extra column at the end of the line with tick boxes for each line and
> with the heading "Delete searches". As in 2) above.
> 3) A search line above the search history with the text Combine queries and
> a brief example (#1 OR #3) AND #6. As the example show there are no box
> ticking here but you send a querie using old search sets.
> 4) remove the big red button "Remove selected searches"
> 5) remove the first column with tick boxes

I've chosen this 2nd option, as it is much more flexible, and was not that
complicated to write (it even removes code!).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #21 from Julian Maurice  ---
Created attachment 72092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72092=edit
Bug 12460: Simplify interface to combine queries

The complicated interface using 'Match any/Match all', checkboxes and
'NOT' selectors is replaced by a simple textbox which expects queries
like this:

  (#1 or #3) and #6

where 1, 3 and 6 are IDs in search_history table.

A new column in the table show these ids.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

  Attachment #59384|0   |1
is obsolete||

--- Comment #20 from Julian Maurice  ---
Created attachment 72091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72091=edit
Bug 12460: Allow to start a new search from multiple search history lines

This patch regroups searches of current and previous sessions to allow
selecting lines from both groups.
It adds a new column (session date) to allow to differentiate searches
of current session from other sessions.
Patch is for Intranet and OPAC

Test plan:
  1. Login to intranet interface
  2. Do some biblio searches
  3. Go to the search history page
  4. See you have a new action available "Start a new search", grayed
 because you haven't selected any line
  5. Select two or more searches
  6. "Start a new search" is now enabled, click it.
  7. A dropdown list appears, asking you to chose between a "Match any"
 search and a "Match all" search. There is also a new column in the
 table ("Not") allowing you to apply a NOT to the corresponding line
  8. Make your choice, and then click on Go button, next to the dropdown
 list. You will be redirected to the catalogue search results.
  9. Confirm that the results are correct.
 10. Set syspref opacthemes to 'bootstrap'
 11. Go to OPAC interface anonymously and repeat steps 2-9
 12. Login to OPAC interface and repeat steps 2-9
 13. Check that authority search history still works as before the patch
 (except that there is only one table instead of two)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

--- Comment #1 from Alex Arnaud  ---
Created attachment 72090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72090=edit
Bug 20273 - Use compat routines for autocomplete in auth_finder.pl

Test plan:
  - Context: Koha working with elasticsearch,
  - Apply BZ 19582 (that make auth_finder.pl works again),
  - apply this patch,
  - go to cgi-bin/koha/authorities/auth_finder.pl,
  - type at least 3 chararcters in a search field and
check that the autocomplete returns results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #12 from Alex Arnaud  ---
I'm not sure for value_any by value_all. It could be an issue related to my
unimarc authorities mapping. Can anyone using marc21 confirm this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #35 from Koha Team Lyon 3  ---
Hello,
if someone is OK to work on this before the next hackfest in March, I'm OK to
test it during the hackfest.
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #11 from Alex Arnaud  ---
Also, i think that "C4::AuthoritiesMarc;" is no longer needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #34 from Koha Team Lyon 3  ---
Hello,
if someone is OK to work on this before the next hackfest in March, I'm OK to
test it during the hackfest.
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13560] need an add option in marc modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560

--- Comment #19 from Victor Grousset/tuxayo  ---
(In reply to Nick Clemens on IRC)
> ideally you would test all the options just to ensure I didn't break anything 
> unintentionally, but if any other option worked it would seem features are 
> intact

I tried to play with the copy function, but that failed (even on the 17.11) so
due to lack of functional knowledge I can't improvise more than that.

But that doesn't seem a big issue. So this would be reading for being QAed if I
understand correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

 Blocks||20273


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273
[Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use
search_auth_compat
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Alex Arnaud  changed:

   What|Removed |Added

 Depends on||19582
 Status|NEW |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582
[Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20273] New: Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Bug ID: 20273
   Summary: Elasticsearch: Auth-finder.pl autocomplete must use
search_auth_compat
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com

BZ 19582 make auth_finder.pl use search_auth_compat instead of
SearchAuthorities. It remains to do the same to the autocomplete feature
provided for each search fields.
See comment: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582#c8

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Ere Maijala  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||ere.maij...@helsinki.fi

--- Comment #26 from Ere Maijala  ---
I've attached a proposed fix for this. It uses the eslt str:encode-uri function
to encode the href parameters. It's already in use with the link tracking in
the OPAC templates. The patch contains changes for
MARC21slim2intranetDetail.xsl, MARC21slim2intranetResults.xsl and
MARC21slim2OPACDetail.xsl, but obviously this should be extended to any other
templates. I just didn't want to spend the effort before getting feedback.

The only downside I can find with encode-uri is that the second parameter is
required. If you find this too horrible, there's also the possibility of using
register_function on the perl side to make a perl-based version available. It
would allow even more control over the process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #25 from Ere Maijala  ---
Created attachment 72089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72089=edit
Bug 14716: URI-encode URLs in xsl templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17006] Add route to change patron's password

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|REST API: add route to  |Add route to change
   |change patron's password|patron's password

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17006] REST API: add route to change patron's password

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17006] REST API: add route to change patron's password

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tomás Cohen Arazi  changed:

   What|Removed |Added

URL||https://wiki.koha-community
   ||.org/wiki/Patrons_password_
   ||endpoint_RFC
   Assignee|lari.task...@jns.fi |tomasco...@gmail.com

--- Comment #47 from Tomás Cohen Arazi  ---
I'm taking over this one with Lari's agreement. I will add a RFC proposal to be
voted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72024|0   |1
is obsolete||

--- Comment #29 from Kyle M Hall  ---
Created attachment 72088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72088=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

Rebased (2017-12-21): Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19018] Can we make XSLT_Handler a little bit less verbose ?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19018

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #0)
> As reported on bug 17807, XSLT_Handler reports that a XSLT file is not found
> for each record it wants to process (running oai.pl).
> 
> Additionally, we also have:
> Can't locate object method "nodeType" via package " encoding="UTF-8"?>
> [ And a complete MARC record dump. ]
> " (perhaps you forgot to load "
> [ Same MARC record dump again ]
> "?) at /usr/share/perl5/HTTP/OAI/Encapsulation.pm line 68.

Will make XSLT_Handler print less warnings on report 20272.
If anyone else want to address the OAI warn, please reopen/rename this one.

*** This bug has been marked as a duplicate of bug 20272 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error codes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272

--- Comment #1 from Marcel de Rooy  ---
*** Bug 19018 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error codes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20272] New: XSLT_Handler should use alphanumeric error codes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272

Bug ID: 20272
   Summary: XSLT_Handler should use alphanumeric error codes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Currently, the code uses error numbers 1 to 7.
The method errstr is not widely used.
In order to translate error message, we could use a template.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20269] Allow selecting default collate rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20269

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] New: Merge deleted/old tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Bug ID: 20271
   Summary: Merge deleted/old tables with their "alive" cousins
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P1 - high
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: boutrosboutrosbout...@gmail.com
QA Contact: testo...@bugs.koha-community.org

In Koha's DB, instead of having a "soft" deletion of entries by flagging the
deleted one as so, the rows in the db is actually deleted, but only after a new
row in a different table is inserted.

Koha's DB is relational, so there is a cascade of links between each object: a
biblio is referred by many items, and each item is referred by issues, holds,
messages.

E.g.: when a row in the item table is moved from "items" to "deleted_items",
then all the references from holds, transfers and so on will be broken.

The suggested more orthodox approach to this would be to add a "deleted_at"
column, which is normally null unless the row is deleted, then it set to the
timestamp of when it was deletion.

This means that the row is still there and will still be referred by other
tables, but it just won't be shown in the relevant lists.

This would improve the maintenance of Koha in many ways (e.g.: the
auto_increment id on those tables caused lots of issues when you add an item
and delete it immediately after. the next new item will have the same
itemnumber as the previously deleted one, clashing with it in many ways).

This bug is about merging the all these tables:
deletedborrowers   => borrowers
deletedbiblio  => biblio
deletedbiblioitems => biblioitems
deletedbiblio_metadata => biblio_metadata
deleteditems   => items
old_issues => issues
old_reserves   => reserves

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20270] SIP2 Connection Issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20270

Anil Tiwari  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20270] New: SIP2 Connection Issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20270

Bug ID: 20270
   Summary: SIP2 Connection Issue
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aniltiwar...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Created attachment 72087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72087=edit
SIP Log

Hi,

We have Installed Koha 17.05.06.000, and created multiple SIP users to
integrate with RFID Kiosk. When we are trying to connect with one kiosk it
works perfectly. If we try to connect more Kiosk the SIP2 is not responding to
93 packet. 

Can  you please suggest what could be the issue. 

Regards,
Anil

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #28 from Kyle M Hall  ---
(In reply to Alex Arnaud from comment #27)
> Kyle,
> 
> Haven't you forgotten to add accountline-details.pl, accountline-details.tt
> and accounttype.inc in the last patch?

Wow, no idea what happened there. Thanks for letting me know!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20269] New: Allow selecting default collate rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20269

Bug ID: 20269
   Summary: Allow selecting default collate rule
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@joensuu.fi
QA Contact: testo...@bugs.koha-community.org

For some languages, the default collate rule set in kohastructure.sql,
utf8_unicode_ci, doesn't work correctly.

For example, Finnish alphabet expects the alphabet to sort abc...xyzåäö, but
the unicode_ci rule doesn't handle the åäö right. Instead, we need to use the
swedish_ci rule.

It would be nice to be able to define the default collate rule during install.

Problem can be seen for example when you go catalogue a new record and have
frameworks starting with 'ä' or 'ö', those will sort incorrectly.

On the database, you can test this with:

insert into biblio_framework (frameworkcode, frameworktext) values ('TEST',
'Äänikirja');

-- Note where the 'Äänikirja' is located
select * from biblio_framework order by frameworktext collate utf8_unicode_ci;

-- And then the correct order, with 'Äänikirja' last:
select * from biblio_framework order by frameworktext collate utf8_swedish_ci;

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #17 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #10)
> 2/ What does mean an additional field linked to a MARC field for aqbasket?
> I think that this option should be hidden for this table (additional fields
> admin page, /acqui/histsearch.pl, add basket page, etc.)

I think we should answer to that before fixing the other issues.
Changing status to In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #26 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #25)

Maybe like:

Purge statistics entries more than DAYS days old

Purge catalog records deleted more then DAYS days ago

Purge patrons deleted more than DAYS days ago

Purge checkouts (old_issues) returned more than DAYS days ago

Purge transfers completed more than DAYS day ago

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #16 from Julian Maurice  ---
Created attachment 72086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72086=edit
Bug 15774: Fix additional fields filters

Addresses the following QA comments:

1/ Regression:
On serials/serials-search.pl, the filters are not filled with what the
users searched for and the additional fields linked to an AV are not
displayed as a dropdown list.

4/ When searching an order, there is no way not to set a "all" value for
additional fields linked to AV.

5/ When searching an order and the search does not return any results,
the field should contain what the user filled in.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #27 from Alex Arnaud  ---
Kyle,

Haven't you forgotten to add accountline-details.pl, accountline-details.tt and
accounttype.inc in the last patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #15 from Julian Maurice  ---
Created attachment 72085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72085=edit
Bug 15774: Fix AV categories dropdown list in admin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

--- Comment #25 from Jonathan Druart  
---
(In reply to Fridolin SOMERS from comment #23)
> (In reply to Jonathan Druart from comment #21)
> > Please improve the POD to explain what means "older than DAYS days" for each
> > option you added.
> 
> Sorry but I don't see how it could be explained.
> Look at sessdays arg :
>--sessdays DAYSpurge only sessions older than DAYS days.

Yes existing POD is bad, that is not a valid argument :)

+   --statistics DAYS   Purge entries from statistics older than DAYS days.

=> this one may be ok

+   --deleted-catalog  DAYS Purge deleted catalog older than DAYS

=> This can be improved: Remove deleted catalogue records that have been
removed before DAYS

+   --deleted-patrons DAYS  Purge deleted patrons older than DAYS days.

=> So if they are too old? Let remove all the retired!

+   --old-issues DAYS   Purge old issues older than DAYS days.

=> Then we are going to "purge the checkins that have been checked out" [...]

+   --old-reserves DAYS Purge old reserves older than DAYS days.

=> I am expecting "holds" and "filled" in the description

+   --transfers DAYSPurge arrived items transfers older than DAYS days.

=> Hum, any native English speakers around?

Should we keep "issues" and "reserves" in the parameter?
At least not in the POD.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20218] Tracklinks fails when URL has special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20218

Nick Clemens  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #4 from Nick Clemens  ---
Bumping severity - this breaks functionality for anyone using trackclicks and
affects users directly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

--- Comment #1 from Marcel de Rooy  ---
Created attachment 72084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72084=edit
Bug 19633: Use alphanumeric error codes in upload

The error codes 1 to 7 are used in Uploader.pm or tools/upload.pl.
It would be nice to use alphanumeric codes instead.
No behavior change expected.

Test plan:
[1] Run t/db_dependent/Upload.t
[2] Verify that a regular upload with tools/upload.pl still works.
[3] Rename upload_path in your koha-conf.xml. Restart Plack, flush the cache
and try to upload to a category. Correct error message?
[4] Upload the same file twice to the same category.
Correct error message the second time?

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Uploader.pm / upload.pl --  |Use alphanumeric error
   |Use alphanumeric error  |codes in upload
   |codes   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/