[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #134908|0 |1 is obsolete|| --- Comment #10 from Victor Grousset/tuxayo --- Created attachment 134912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134912=edit Bug 30733: Simplify translatable strings And a few minor fixes when they where causing issues for translatability. Simplified via wrapping strings with to split to huge concatenated strings with a lot of %s everywhere. == Test plan == This patch needs mainly proof reading. Still it's possible to do some basic testing to demonstrate that adding a in an IF doesn't break anything. Pick in one of the 110 modified templates a string that you know how to display. Otherwise: 1. acquisitions => vendor => basket => add to basket => search "from existing record" => add order 2. Cancel the order 3. You see without issue "Bibliographic record will not be deleted" 4. administration => Patron categories 5. Try to delete a used and unused category 6. You see as expected Category is in use. Deletion not possible! and Confirm deletion of category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|22.05.00,21.11.05,21.05.14, |22.05.00,21.11.05,21.05.14, released in|20.11.18|20.11.18,19.11.29 --- Comment #15 from Victor Grousset/tuxayo --- Note: has been backported and pushed to 19.11.x branch for 19.11.29 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #9 from Victor Grousset/tuxayo --- After today's dev meeting: if we get enough confidence after reviewing the patch, Fridolin could still merge it in the next two days albeit the string freeze. The string enhancements will compensate the two days lost for the translators. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #8 from Victor Grousset/tuxayo --- Updating the .po files of a lang on master, then doing "git add" on the .po and then updating with the patches should allow to see the difference. git diff | grep "\-msgid" | wc -l 182 git diff | grep "\+msgid" | wc -l 337 That makes sense, ~680 used to remove 182 strings means that I split in 3.7 on average. I had the impression that on the 2300 search results on Pootle, I had touched more than 182 though. But if I "only" added 680 than makes sense. As for the 337 string added, with 680 and assuming half of the simpler strings being duplicates with existing or between themselves, that makes sense to have only 337 new strings. A quick skimming in the updated staff .po searching for %s shows that the terrible strings remaining are mostly those that make the of each Koha page. So that's still quite a number of strings to clean. And then a few templates outputting CSV. Doing git diff and there searching for «\-msgid "» and «\+msgid "» allows to see the complexity of the removed strings and the simplicity of the added ones. @Fridolin here is your count method, I don't know what it means but here it is so you can interpret it: #current master msggrep -K -e '%s' misc/translator/po/fr-FR-staff-prog.po | grep -c "^msgid" 1749 #after patch msggrep -K -e '%s' misc/translator/po/fr-FR-staff-prog.po | grep -c "^msgid" 1708 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30738] Log warnings in forked CGI MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30738 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30738] Log warnings in forked CGI MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30738 --- Comment #1 from David Cook --- Created attachment 134911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134911=edit Bug 30738: Log warnings for background MARC import This change logs warnings from the CGI background MARC import. Test plan: 0) Apply patch 1) Export a record with an item 2) Update the 952$f subfield to "Circulation" (any value over 10 chars) 3) Import the record and try to add the item 4) The import will stay stuck with "Importing" status and 0% job progress 5) Check the /var/log/koha/kohadev/intranet-error.log file and notice there's an error with the following text: "Data too long for column 'coded_location_qualifier' at row 1" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30738] Log warnings in forked CGI MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30738 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30738] Log warnings in forked CGI MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30738 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28152 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30739] Fatal errors during MARC import force status of "Importing" forever
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28152 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30739, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30738 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30738] Log warnings in forked CGI MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30738 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30739 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30739] Fatal errors during MARC import force status of "Importing" forever
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30738 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30739] Fatal errors during MARC import force status of "Importing" forever
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739 --- Comment #1 from David Cook --- (In reply to David Cook from comment #0) > Either we need to fail the whole import or we need to catch the error and > just report on it at the end. The better option is probably to report on it at the end, because otherwise we'd need to run a full reversion and the MARC import reversion is not very good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30739] New: Fatal errors during MARC import force status of "Importing" forever
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739 Bug ID: 30739 Summary: Fatal errors during MARC import force status of "Importing" forever Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org We need to be careful when processing MARC imports. I was trying to import 1 MARC record with 1 item, and it kept getting stuck as 0% job progress and "Importing" status forever. Thanks to Bug 30738, I saw this was due to the following error: [2022/05/12 03:37:37] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'coded_location_qualifier' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 main::__ANON__ /kohadevbox/koha/tools/manage-marc-import.pl (339) -- Either we need to fail the whole import or we need to catch the error and just report on it at the end. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #1) > The error only appears in the log if you comment the close STDERR and > close STDOUT lines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30738 should be able to help there... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30738] New: Log warnings in forked CGI MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30738 Bug ID: 30738 Summary: Log warnings in forked CGI MARC import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org While most of Koha can use Plack/PSGI these days, there are still a few CGI scripts like "manage-marc-import.pl". This script forks itself in order to run in the background, and in so doing it closes STDOUT and STDERR to tell Apache not to control it anymore. (One day I hope to make this use the RabbitMQ, but that day is not today.) Unfortunately, this means warnings get suppressed. I've noticed cases (usually with items) where a fatal error causes the import to fail (with the batch stuck in "Importing" with a 0% job progress bar) and there are no warnings in the logs! Very frustrating! But we can use Koha::Logger to save the day... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 --- Comment #3 from wainuiwitikap...@catalyst.net.nz --- Created attachment 134910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134910=edit Bug 30590: Use AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module Test plan: 1) Set values in 'AutoSelfCheckID' and 'AutoSelfCheckPass' system preferences, and enable 'AutoSelfCheckAllowed' 2) Enable 'SelfCheckinModule' system preference 3) Visit /cgi-bin/koha/sci/sci-main.pl and notice a login page loads 4) Apply patch and restart services 5) Repeat step 3 and notice a login page does not load this time 6) Enter a barcode, check an item in Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Attachment #134801|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Attachment #134909|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #7 from Victor Grousset/tuxayo --- Hola Bernardo :D (In reply to Bernardo Gonzalez Kriegel from comment #5) > In > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=134908=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/ > overdue.tt_sec1 > you enclose only "Items" between .., but not "Item" and > "overdue as of", that's deliberate? > > The original string was > msgid "%s %sItems%sItem%s overdue as of %s%s " > and the new one > msgid "%sItem%s overdue as of %s%s " Yes that's the intended result. To still keep some context, I hesitated and didn't have a strong opinion about what is better. Now that I reread it there would be no ambiguity. So better isolate every piece, right? Now that you are here I can ask what should I do about semicolons? Should I always include them in the string? I left part of them out because I guess I would help RTL languages: > And also I included semicolons in the when the context allows for a > translated version with the semicolon on the left to make sense. If the > context has a related thing just after on the same line (on the right) to the > string, then I didn't include the semicolon to leave it "pointing" at the > right thing. Even though that's wrong, but we can't swap the phrases. > caveat: I don't have any experience in translating RTL in Koha so I'm not > sure if these things help. > And I just noticed we have an RTL CSS that might actually swap stuff. If > that's the case, the fact that I left the semicolon outside the might > not be an issue because it should end up swapped right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 --- Comment #2 from wainuiwitikap...@catalyst.net.nz --- Created attachment 134909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134909=edit Bug 30590 fixing sci sso -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #6 from Victor Grousset/tuxayo --- (In reply to Fridolin Somers from comment #2) > In text above you forgot to remove 'type' in second line, after [% END %]. > > But it is OK in patch : Indeed I mess up the manual example, sorry for the confusion. > Still I think there is a problem. > > This will lead to the translation of : > "Payment type" > "Transaction type" > "%s: " A diff between updated strings on master and updated strings with the patch shows by searching for the location comment "transaction_types.inc" that "Payment type" is created "Transaction type" already exists and the location "transaction_types.inc" is added in it's list No other "transaction_types.inc" to be found that could show that "%s: " is created or linked to an existing one > Usually the ":" is with translated text : > "Payment type: " > "Transaction type: " ok, shall I make all the strings include the ":" ? In your above example I see a trailing space after the semicolon but we don't aim for this in source strings right? > You may add a span for ending character alone : > +[% IF type > == 'payment' %]Payment type[% ELSE %]Transaction > type[% END %]: > But the context may be hard to understand for translators. Translators probably will just copy it as it without deducing they can there decide their punctuation spacing style. Assuming the string extraction script keeps it. But it seems not from a check above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30520] Command line stage and import broken since 21.11.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #6 from David Cook --- Oh interesting... I found the web based MARC stage and import broken in 21.11 as well. I'm starting to look into it... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Victor, great work! In https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134908=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt_sec1 you enclose only "Items" between .., but not "Item" and "overdue as of", that's deliberate? The original string was msgid "%s %sItems%sItem%s overdue as of %s%s " and the new one msgid "%sItem%s overdue as of %s%s " -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #19 from David Cook --- (In reply to Martin Renvoize from comment #10) > This improves things for me.. but I think it needs more eyes from someone > more familiar with Zebra. Thanks for adding me. Hopefully my comments were a bit helpful... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #18 from David Cook --- Ah, but as I look again at Koha/Biblio.pm, we have to factor in Elasticsearch. I don't know if Elasticsearch can handle double quotes around $cleaned_title. I suppose clean_search_term() could escape double quotes within 245$a using a backslash[1], plus it could return the clean_search_term wrapped in double quotes, so that Zebra processes it correctly. I'll leave that distinction up to someone more familiar with the Koha-ES integration... [1] Z> find (Any="shuffle "") CCL ERROR: ')' expected Z> find (Any="shuffle \"") Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 3, setno 28 SearchResult-1: term=shuffle cnt=3 records returned: 0 Elapsed: 0.000369 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #17 from David Cook --- (In reply to Martin Renvoize from comment #7) > Hmm, I started looking at adding unit tests for this and I see that there > are a reasonable number for the same function in ElasticSearch.. wondering > if we need to handle any other cases here that are already handled in the ES > implementation..? As Liz and Sheri have mentioned, there are other special characters in the CCL syntax. (See https://software.indexdata.com/yaz/doc/tools.html#ccl.syntax) However, so long as those are within double quotes, they should be treated as search data and not reserved characters. So I suppose clean_search_term() should really just escape double quotes. -- Note: We're in a fortunate position here of building the search string ourselves rather than having to parse user input, so we have so much control and ability to do this the way that works for the search engine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #16 from David Cook --- In fact, an even better option would be this: $searchstr = qq#(Host-item:"$cleaned_title")#; This way, we're putting the key-value pair into its own little group. We can then add "and", "or", or whatever. (I really haven't gone down the rabbit hole of the purpose of $searchstr. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #4 from Victor Grousset/tuxayo --- Some testing notes before I forget. - it has been checked multiple times that no has been added to a - attention was given to leave out CSV and JSON outputs - each .inc was checked individually to ensure it's indeed HTML and not CSV, JSON or the content of a - via doing searches in the git log for and it's possible to be very confident that there is not typo in the tag and not mismatching of tags (same method used on bug 29602 that worked well to find little mistakes) - one proofreading pass was especially focused in ensuring that IF and ELSE couldn't cause a tag mismatch - QA test tools pass albeit some unusual Perl warnings outputted by the script: root@kohadevbox:koha(simplify-translatable-strings)$ time /kohadevbox/qa-test-tools/koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 68990b9 '9a Bug 30722: Typo in overdue recalls') Processing files before patches File not found : lib/jquery/jquery-ui-1.13.1.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 130. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 130. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 236. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 343. |>| 116 / 116 (100.00%) Processing files after patches File not found : lib/jquery/jquery-ui-1.13.1.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 130. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 130. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 236. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 343. |>| 116 / 116 (100.00%) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418
--- Comment #15 from David Cook ---
(In reply to Martin Renvoize from comment #11)
> [WARN] CCL parsing error (10014) Unknown qualifier ZOOM for query:
> Host-item=( Utensili = ) at /home/koha/kohaclone/C4/Search.pm line 242.
> [2022/05/09 12:39:13] [WARN] Warning from simple_search_compat: 'CCL parsing
> error (10014) Unknown qualifier ZOOM' at /home/koha/kohaclone/Koha/Biblio.pm
> line 540.
This warning actually reveals that we're going about this the wrong way.
Take this code:
$searchstr = "Host-item:($cleaned_title)";
We're just injecting an arbitrary string between those parentheses, and that's
causing parsing errors.
What we should be doing is this:
$searchstr = qq#Host-item:("$cleaned_title")#;
Observe the difference:
Z> find Host-item=( Utensili = )
CCL ERROR: Unknown qualifier
Z> find Host-item=(" Utensili = ")
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 0, setno 2
SearchResult-1: term=Utensili cnt=0
records returned: 0
Elapsed: 0.000349
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #134903|0 |1 is obsolete|| --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 134908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134908=edit Bug 30733: Simplify translatable strings And a few minor fixes when they where causing issues for translatability. Simplified via wrapping strings with to split to huge concatenated strings with a lot of %s everywhere. == Test plan == This patch needs mainly proof reading. Still it's possible to do some basic testing to demonstrate that adding a in an IF doesn't break anything. Pick in one of the 110 modified templates a string that you know how to display. Otherwise: 1. acquisitions => vendor => basket => add to basket => search "from existing record" => add order 2. Cancel the order 3. You see without issue "Bibliographic record will not be deleted" 4. administration => Patron categories 5. Try to delete a used and unused category 6. You see as expected Category is in use. Deletion not possible! and Confirm deletion of category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi --- Comment #11 from Lari Taskula --- (In reply to Tomás Cohen Arazi from comment #10) > I have started coding this. The first thing I did was making it an entry in > the circulation rules page so this can be set per library and per patron > category. > > More on this tomorrow :-D Any updates on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #16 from David Cook --- (In reply to Jonathan Druart from comment #8) > Are you sure we don't only need to pass/cache the MARC record? > Did you benchmark this patch? Maybe it's worth looking again at this one with Devel::NYTProf to see where speed gains could be made... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30629] in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- Bug 26932 looks like a typo, it's unrelated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #2 from David Nind --- Patch no longer applies: git bz apply 30295 Bug 30295 - Send a notification when a recall is manually cancelled 131763 - Bug 30295: Send a notification when a recall is manually cancelled Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30295: Send a notification when a recall is manually cancelled error: sha1 information is lacking or useless (Koha/Recall.pm). error: could not build fake ancestor Patch failed at 0001 Bug 30295: Send a notification when a recall is manually cancelled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30737] oai.pl error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30737 --- Comment #1 from Claudio --- Created attachment 134907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134907=edit oai.pl error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30737] New: oai.pl error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30737 Bug ID: 30737 Summary: oai.pl error Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: cost...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 134906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134906=edit oai error Harvesting error: https://CATALOG/cgi-bin/koha/oai.pl "the requested page is not available" Tested in 21.05.14 See PDFs attached please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24552] Koha does not work with Search::Elasticsearch 6.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Mason James changed: What|Removed |Added Blocks||30736 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30736 [Bug 30736] Upgrade 'libsearch-elasticsearch-perl' package to version 6.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30736] Upgrade 'libsearch-elasticsearch-perl' package to version 6.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30736 Mason James changed: What|Removed |Added Depends on||24552 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 [Bug 24552] Koha does not work with Search::Elasticsearch 6.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30736] New: Upgrade 'libsearch-elasticsearch-perl' package to version 6.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30736 Bug ID: 30736 Summary: Upgrade 'libsearch-elasticsearch-perl' package to version 6.00 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com this bug tracks the upgrade of 'libsearch-elasticsearch-perl' package to version 6.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #14 from Fridolin Somers --- *** Bug 27575 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27575] Search "Analytics: Show analytics" broken when records title ends with ":"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27575 Fridolin Somers changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #5 from Fridolin Somers --- *** This bug has been marked as a duplicate of bug 29418 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735
--- Comment #2 from Fridolin Somers ---
Created attachment 134905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134905=edit
Bug 30735: Fix filtering by patron attribute with AV in overdues report
In Circulation > Overdues, if there are seachable patron attributes they can be
used in left filters.
Search does not work if this attribute is linked to an authorized values
category.
The problem is that AV code is compared to the AV desciption in :
if (grep { $attrval eq lc($_->[1]) } @{ $pattrs->{$code} }) {
Looking at a Data::Dumper of the var $pattrs you see for example :
$VAR1 = {
'ATT1' => [
[
'afr',
'Afrikaans'
]
]
};
First row is attribute code and second row is desciption.
It works for an attribute without AV because in this case
'avdescription' is undefined so code is stored as description :
push @{ $pattrs->{$row->{attrcode}} }, [
$row->{attrval},
defined $row->{avdescription} ? $row->{avdescription} :
$row->{attrval},
];
This patch fixes the code and removes commented line.
Also reviews the SQL query :
- avcategory is useless
- use alias attrcode for borrower_attributes.code to be more explicit
Test plan :
1) Create a patron A with overdues
2) Go to Circulation > Overdues
3) Check you see the patron A
4) Create a patron attribute, searchable, with an authorized value category, ie
LANG
5) Edit patron A to set a value in this attribute
6) Go to Circulation > Overdues
7) Select attribute value and apply filter
8) Check you see the patron A
9) Redo test plan with a patron attribute, searchable, without an authorized
value category
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735 --- Comment #1 from Fridolin Somers --- This looks like very-old-buggy-code ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] New: Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735 Bug ID: 30735 Summary: Filtering by patron attribute with AV does not work in overdues report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In Circulation > Overdues, if there are seachable patron attributes they can be used in left filters. Search does not work if this attribute is linked to an authorized values category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin Somers --- (In reply to Victor Grousset/tuxayo from comment #0) > --- > > There are a few fixes like > Payment[% ELSE %]Transaction[% END %] type: > > ↓ > Payment type[% ELSE %]Transaction type[% END %] > type: > because having "type" separated removes the context and it locks the word > order as same as English. Which makes this string not possible to correctly > translate in French, Spanish and Esperanto for example. In text above you forgot to remove 'type' in second line, after [% END %]. But it is OK in patch : -[% IF type == 'payment' %]Payment[% ELSE %]Transaction[% END %] type: +[% IF type == 'payment' %]Payment type[% ELSE %]Transaction type[% END %]: Still I think there is a problem. This will lead to the translation of : "Payment type" "Transaction type" "%s: " Usually the ":" is with translated text : "Payment type: " "Transaction type: " For example french translation will add a space "Type de transaction : " But this may generate strings with and without ending character : "Payment type" "Payment type: " You may add a span for ending character alone : +[% IF type == 'payment' %]Payment type[% ELSE %]Transaction type[% END %]: But the context may be hard to understand for translators. And there are soo much places to change. Great work BTW ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30173] The suppress limit breaks the OPAC adv search using OR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30173 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16116] Change of issue publication date doesn't reflect on the next issue generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14846] Items with no holdingbranch causes user's holds display to freeze
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11967] Add support for RMA notices to Acquisitions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11967 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8425] Autobarcode generates duplicate barcodes with AcqCreateItems = on order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27667] Display the number of non-indexed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Fridolin Somers changed: What|Removed |Added Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27667] Display the number of non-indexed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27667] Display the number of non-indexed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 --- Comment #2 from Fridolin Somers --- I was digging into ES bugs/enh and found this easy one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27667] Display the number of non-indexed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 --- Comment #1 from Fridolin Somers --- Created attachment 134904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134904=edit Bug 27667: Display a warning for records missing in Elasticsearch On "About Koha" page are displayed the numbers of indexed biblios and authorities with ES. It could be great if we could have comparison with the number of records in the database to display the number of missing records. In the "System information" tab with the other "Data problems". If Searchengine has any issue (index count will be -1), we do not display missing records. Test plan : 1) Use Elasticsearch searchengine 2) Rebuild all records : koha-elasticsearch --rebuild -d kohadev 3) Go to "About Koha" page and look at System information tab => you see no warning 4) On a biblio record delete the MARCXML in biblio_metadata.metadata 5) Rebuild all records : koha-elasticsearch --rebuild -d kohadev 6) Go to "About Koha" page and look at System information tab => you see warning : 1 record(s) missing on a total of 435 in indice koha_kohadev_biblios. 7) On a authority record delete the MARCXML in auth_header.marcxml 8) Rebuild all records : koha-elasticsearch --rebuild -d kohadev 9) Go to "About Koha" page and look at System information tab => you see warning : 1 record(s) missing on a total of 1705 in indice koha_kohadev_authorities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27667] Display the number of non-indexed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27667] Display the number of non-indexed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27667] Display the number of non-indexed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they have requested transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30520] Command line stage and import broken since 21.11.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where clause' 500 error in API /api/v1/acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30528] Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being paid' with CurrencyFormat = FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30734] t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Fridolin Somers changed: What|Removed |Added Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30734] New: t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Bug ID: 30734 Summary: t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10 : koha_1 | # Failed test 'No tests run for subtest "decoded_data() and set_encoded_data() tests"' koha_1 | # at t/db_dependent/Koha/BackgroundJob.t line 169. koha_1 | hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this) at /kohadevbox/koha/Koha/BackgroundJob.pm line 262. koha_1 | # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27693] Add ability to sort ElasticSearch configuration tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27693 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- Search fields tab is now sortable. In other tabs the order is important (there is drag and drop) so I is dangerous to propose sorting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #97 from Martin Renvoize --- Brill.. will take a look at taking that approach tomorrow... thanks Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #96 from Martin Renvoize --- We have an ON DELETE SET NULL on the foreign key.. whilst I like keys for integrity that's wrong if we actually want to keep the link when the biblio is moved to deleted_biblios.. This needs some thought... another case where merging tables would help. We could just remove the code level key requirement in th store routine for biblionumber if it doesn't already exist in storage? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #95 from Andrew Fuerste-Henry --- I would disallow the deletion and instead direct the user to first cancel the order. For comparison, if I have a bib with a hold on it and try to use the "Delete all items" option under Edit on the bib, I get the message "1 hold(s) on this record. You must delete all holds before deleting all items." So we have some precedent for just blocking a deletion like this and redirecting the user to something else that needs to happen first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #94 from Martin Renvoize --- Right.. so should we dissallow deletion of Biblio's that have orders attached.. or remove the key constraint from Orders? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #93 from Andrew Fuerste-Henry --- This is still an issue on current master. To recreate: 1: Add an order to a basket, using the "From a new (empty) record" option to create a bib and item 2: Once your order is entered, delete the bib (via the cataloging interface, not via acquisitions) 3: reload your basket, see your order now says "Deleted bibliographic record, can't find title" 4: click Cancel Order, confirm cancellation 5: get this error: Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/cancelorder.pl line 59. at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12141] On Display Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org --- Comment #17 from Michael Adamyk --- +1 This would be a fantastic feature. As others have mentioned, we have some school libraries that may want to use Course Reserves, so having both Course Reserves and Display would be ideal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30733 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29602 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |vic...@tuxayo.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #1 from Victor Grousset/tuxayo --- Created attachment 134903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134903=edit Bug 30733: Simplify translatable strings And a few minor fixes when they where causing issues for translatability. Simplified via wrapping strings with to split to huge concatenated strings with a lot of %s everywhere. == Test plan == This patch needs mainly proof reading. Still it's possible to do some basic testing to demonstrate that adding a in an IF doesn't break anything. Pick in one of the 110 modified templates a string that you know how to display. Otherwise: 1. acquisitions => vendor => basket => add to basket => search "from existing record" => add order 2. Cancel the order 3. You see without issue "Bibliographic record will not be deleted" 4. administration => Patron categories 5. Try to delete a used and unused category 6. You see as expected Category is in use. Deletion not possible! and Confirm deletion of category -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] New: Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Bug ID: 30733 Summary: Simplify translatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: vic...@tuxayo.net QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr A.K.A "We must be nicer with translators 2" (follow-up of bug 29602) It's the same simple idea that worked well without issues: Add in templates to not have anymore translatable strings like %sEnter a new purchase suggestion%s %sPurchase suggestions%s %s%s%sKoha online%s catalog git is a great help to review this patch. Don't use the bugzilla diff view. Apply the patch and use: git show --color-words=. Now you will see just the added You can search for and go one by one to check that the opening and closing tags match and that there is no typo. Then the same with I already did that though, so you might want to spare pressing the "n" (next) key 1300 times (684 x 2) --- This patch has been made by searching in the translation platform for "%s" and inspecting the 2300 strings containing it to find those that are terrible to translate: those with tons of %s which are a concatenation of independent strings. Mainly the IFs in template produce these abominations. bug 29602 focused on CASE statement. This is an attempt for all the rest. Except for CSV templates and page tags because can't be used there. Some less terrible strings have been skipped due to lack of time. --- I tried to think about right to left languages in cases like Confirm deletion of subfield [%- tagsubfield | html -%] I included the variable tagsubfield in the so there will be a %s in the translatable string which should allow to invert the order when translating to be RTL. And also I included semicolons in the when the context allows for a translated version with the semicolon on the left to make sense. If the context has a related thing just after on the same line (on the right) to the string, then I didn't include the semicolon to leave it "pointing" at the right thing. Even though that's wrong, but we can't swap the phrases. caveat: I don't have any experience in translating RTL in Koha so I'm not sure if these things help. And I just noticed we have an RTL CSS that might actually swap stuff. If that's the case, the fact that I left the semicolon outside the might not be an issue because it should end up swapped right? --- There are a few fixes like Payment[% ELSE %]Transaction[% END %] type: ↓ Payment type[% ELSE %]Transaction type[% END %] type: because having "type" separated removes the context and it locks the word order as same as English. Which makes this string not possible to correctly translate in French, Spanish and Esperanto for example. --- There is a double , it looks like: Author(s) This is expected. There was already one spanning (ha ha) a few lines and I needed another one just for the string on this line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Martin Renvoize changed: What|Removed |Added Severity|major |normal --- Comment #92 from Martin Renvoize --- Still an issue today? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #28 from Martin Renvoize --- So are we agreed we should stop the installer/upgrade with a sane error message and warn in the about page for non-dynamic installs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30659] Date Acquired is not working in KOHA 21.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30659 Martin Renvoize changed: What|Removed |Added Severity|critical|normal CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29782] Missing entries for display locations in HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Martin Renvoize changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|critical|normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30520] Command line stage and import broken since 21.11.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize changed: What|Removed |Added CC||ere.maij...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30520] Command line stage and import broken since 21.11.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30520] Command line stage and import broken since 21.11.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Good catch Andreas.. interestingly I couldn't easily spot where userid and categorycode are actually ever referred to in the overlay context.. but it doesn't appear to break anything. Signing off as unit tests continue to pass and the fix does indeed work as proposed. Might be night to add a unit test for this particular change though ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
