[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #10 from Mason James --- (In reply to Tomás Cohen Arazi from comment #9) > Pushed to master for 22.11. > > Nice work everyone, thanks! thanks, can we push thru to o-o-stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31107] smsalertnumber missing from OPAC self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31107 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30801] OPAC and staff interface show 856 as link even if there is no $u (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30801 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #77 from Lari Taskula --- (In reply to Christopher Brannon from comment #76) > Even if an undo was an option, it would have been for a limited time. Yes, > maybe we would have averted a phone call or annoying work, or an angry > patron, but we get those anyway, and if they wait long enough, they will > miss that window and still call. I'm not saying I'm 100% against it, but a > confirmation is their 2nd chance to fix a mistake. We don't really offer > undo's anywhere else. Why should this be the exception? I think anything that reduces manual work from librarians is worth considering. > I think removing the button is a better option. I'm fine with having the button stay as it is or get removed, or moving this into a new Bug. As you said it seems out of scope. I appreciate that and it's okay. My intention was to share a possible scenario and an idea for enhancement but not stop the Bug from moving forward because of it. It's not that huge deal for me. Tomás has done great work with this Bug! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #76 from Christopher Brannon --- I think removing the button is a better option. Even if an undo was an option, it would have been for a limited time. Yes, maybe we would have averted a phone call or annoying work, or an angry patron, but we get those anyway, and if they wait long enough, they will miss that window and still call. I'm not saying I'm 100% against it, but a confirmation is their 2nd chance to fix a mistake. We don't really offer undo's anywhere else. Why should this be the exception? I do like the process Tomás has laid out in the patch, regardless of what he does with the button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31114] New: OpacHiddenItems is not respected in search results when an OPAC search is filtered by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114 Bug ID: 31114 Summary: OpacHiddenItems is not respected in search results when an OPAC search is filtered by branch Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lucy.vaux-har...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org When filtering OPAC searches by library (OpacAddMastheadLibraryPulldown enabled) the search results will include title records where all items for that library are hidden from the OPAC due to the values in OpacHiddenItems. When clicking through to the detailed view of an affected record the copies are correctly hidden in the holdings table but it is confusing for the library customer to find the title in the search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #75 from Tomás Cohen Arazi --- (In reply to Lari Taskula from comment #74) > (In reply to Christopher Brannon from comment #73) > > Is that even possible if holds are automatically triggered for the next hold > > after cancellation? (maybe I'm not completely understanding the process). > > While the hold is in pending cancellation request status (not yet > processed), it should be possible. The cancellation request entry would > simply be deleted from the newly introduced "hold_cancellation_requests" > table and the hold would continue to exist normally. > > > An undo seems like it is out of the scope of this project anyway. > > Perhaps. But I don't like a disabled button in OPAC saying "Cancellation > requested" and the fact that if a patron wanted to revert the action there > is nothing they can do other than giving the library a phone call and cause > a lot of annoying manual work for the librarians, or an angry patron if > nothing could be done. There's no cancellation acceptance workflow (there was, originally, and I stripped it out). The main intention here is to let the staff know that hold has been cancelled even if waiting. I guess we could just remove it from the OPAC view. As it is really cancelled. Just having this intermediate status to be able to alert staff in different places. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch / HomeOrHolding together in sysprefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|andre...@dubcolib.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25220] maxoutstanding syspref should be disabled by a null value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|andre...@dubcolib.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|andre...@dubcolib.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26035] AutoMemberNum fails on very large cardnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|andre...@dubcolib.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|andre...@dubcolib.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description to explain consequences of setting in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|andre...@dubcolib.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25219] Include note in fines-related system preferences which can be disabled by leaving them blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25219 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|andre...@dubcolib.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31113] New: Permission change to so user can use marc modification template only when adding or editing single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31113 Bug ID: 31113 Summary: Permission change to so user can use marc modification template only when adding or editing single record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: aspencatt...@clicweb.org QA Contact: testo...@bugs.koha-community.org Would like to see a permission to allow the application of marc modification template to single record, without having the permission to do batch record modification. This would allow admin to create marc modification template that a novice cataloger could use to supply certain fields they probably would not know to change. (Like in leader, 008, 007). We would not want them to be able to do batch record modification - just use template on single record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31067] Sub-tools permission not applying on intranet-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31067] Sub-tools permission not applying on intranet-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31001] "CGI::param called in list context" warning in basket.pl flooding error log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31001] "CGI::param called in list context" warning in basket.pl flooding error log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30769] Typo: Item typeX:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30769] Typo: Item typeX:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC Modification Templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --- Comment #1 from AspenCat Team --- This would be useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30769] Typo: Item typeX:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769 Tomás Cohen Arazi changed: What|Removed |Added Attachment #137180|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 137250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137250=edit Bug 30769: Typo fix in request.tt This patch fixes a small typo at koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574 To test: 1 - Set item-level_itypes in administrative preferences to bibliographic record 2 - Navigate to /reserve/request.pl in admin interface 3 - Notice that the typo is there in hold details 4 - Apply Patch 5 - Typo is fixed Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30769] Typo: Item typeX:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23869] Add regex test to marc mod template setup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23869 --- Comment #1 from AspenCat Team --- This would be very handy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26717] Allow specifying where to insert new subfields in MARC Modification Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26717 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26716] Allow specifying where to insert new fields in MARC Modification Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26716 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --- Comment #1 from AspenCat Team --- This would be handy! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23869] Add regex test to marc mod template setup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23869 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31001] "CGI::param called in list context" warning in basket.pl flooding error log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001 Tomás Cohen Arazi changed: What|Removed |Added Attachment #136558|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 137249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137249=edit Bug 31001: Fix "CGI::param called in list context" warning in basket.pl CGI param basketno should be explicitly scalar, or else error log gets flooded with this warning: AH01215: CGI::param called in list context from /home/vagrant/kohaclone/acqui/basket.pl line 175, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. This patch fixes it by working with it in a scalar context. The functionality still remains the same but warning doesn't flood error log. To reproduce: 1. Head over to the acquisitions page. 2. Pick existing vendor with email contact info or create a new one. 3. Create a new basket or use existing one, and if it doesn't have any orders, add a new order to it. 4. Use the "E-mail order" button to send order. 5. Check the error log and find the upper mentioned warning. (Note: if you're going to test this more than once, you might need to restart your Plack in order for this warning to get added to your log file again, reasons of that is that the authors of CGI.pm decided to "warn only once") 6. Apply the patch. 7. Use the "E-mail order" button again, ensure that the same warning doesn't get added to the log file again. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31001] "CGI::param called in list context" warning in basket.pl flooding error log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #74 from Lari Taskula --- (In reply to Christopher Brannon from comment #73) > Is that even possible if holds are automatically triggered for the next hold > after cancellation? (maybe I'm not completely understanding the process). While the hold is in pending cancellation request status (not yet processed), it should be possible. The cancellation request entry would simply be deleted from the newly introduced "hold_cancellation_requests" table and the hold would continue to exist normally. > An undo seems like it is out of the scope of this project anyway. Perhaps. But I don't like a disabled button in OPAC saying "Cancellation requested" and the fact that if a patron wanted to revert the action there is nothing they can do other than giving the library a phone call and cause a lot of annoying manual work for the librarians, or an angry patron if nothing could be done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Joonas Kylmälä changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |joonas.kylm...@iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098 --- Comment #6 from David Nind --- A way to test could be to either: 1. run the command in the cron job manually to generate the backups and see if the files appear in the directory, or 2. create a file in the backup directory and see if you can see it in the staff interface, or If the files are in the directory, but you can't see them in the staff interface then it will be a permission problem. If the command doesn't generate the files, then check the logs for any errors (I'm not sure which logs to check..). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31098 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14564 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098 --- Comment #5 from David Nind --- (In reply to victor from comment #4) > Would I need to set permission for /var/spool/koha ? I think you are correct. From bug 14564 comment 16 , then it set the permissions as root:kohadev-koha ownership and 640 permission. This is so that the files can be read by the webserver for your Koha instance - kohadev-koha should be changed to whatever your instance name/file ownership persmissions should be - check the files under the koha to see what that should be. Not sure whether this is a regression, or it is something that needs to be set manually). I'm not the greatest at linux file permissions, so I might be worng! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31112] New: Able to renew checkout when the number of holds exceeds available number of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Bug ID: 31112 Summary: Able to renew checkout when the number of holds exceeds available number of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@iki.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If AllowRenewalIfOtherItemsAvailable is set to Allow we are incorrectly (against the syspref description) allowing to renew some checkouts when the holds are coming from a single patron. When there is only 1 available item for checkout in the biblio and a single patron has made 2 biblio level holds we allow the patron who has a single item on loan to renew their item and disregard the fact the we are leaving one hold unfilled. According to the AllowRenewalIfOtherItemsAvailable syspref the renewal should only be possible when other items can fill all the unfilled holds. I have made a patch for this and will submit it shortly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 David Nind changed: What|Removed |Added Attachment #137239|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 137248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137248=edit Bug 31106: Fix links generated in XSLTs This patch addresses the case of links that are generated on the XSLT side, those linking to and from host records using 773$t and 773$a. To test: 1. Pick a bibliographic record (I chose 'Unconditional' from the sample data 2. Add " and ? to the title statement. I changed it to 'Uncond"itional?¿' 3. Add a child record to it 4. Open the detail page for the host record => FAIL: It doesn't show the 'Show analytics' link 5. Repeat 4 for the same record, in the OPAC => FAIL: It doesn't show the 'Show analytics' link 6. Apply this patch 7. Repeat 4 and 5. => SUCCESS: Links are shown! 8. Follow the links => SUCCESS: The links take you to the right resultset! 9. Go to the child record, and notice the link back to the parent works :-D 10. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 David Nind changed: What|Removed |Added Attachment #137238|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 137247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137247=edit Bug 31106: Make clean_search_term escape double quotes We noticed that several characters will break Zebra queries. So search terms need to be quoted for things to work. In this context, double quotes inside search terms are problematic because double quotes are what we use for quoting strings. This patch makes the clean_search_term method escape double quotes. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t => FAIL: It doesn't work as it should! 3. Apply this patch 4. Repeat 2 => SUCCESS: It does the job! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 David Nind changed: What|Removed |Added Attachment #137237|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 137246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137246=edit Bug 31106: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31022] 400/404 actually returns 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31022 --- Comment #5 from Tomás Cohen Arazi --- Ok, tested myself, this is some Mojolicious::Plugin::OpenAPI bug. Reported it: https://github.com/jhthorsen/mojolicious-plugin-openapi/issues/237 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31022] 400/404 actually returns 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31022 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #3) > I do however find it really weird still that you can define more than one > definition for the same response status on the endpoint... > > i.e. the internal 400 definitions for the validator software and then our > own one for our own errors. > > I would have expected our definition to take precedence over the internal > one and thus need it to be a superset of the built-in one. > > Interesting. Doesn't our definition just overload the default/internal one? It used to return a 500 because it wasn't considered a valid response in the spec, which I find correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the|This report adds pref |This enhancement enables release notes|ListOwnerDesignated. It |the transfer of public list |serves as the new owner of |ownership when a patron is |public or shared lists when |deleted (from both the |a patron is deleted as long |staff interface, and |as |scripts or cron jobs such |ListOwnershipUponPatronDele |as |tion has been set to|misc/cronjobs/delete_patons |transfer. |.pl). A new system | |preference |Another |ListOwnershipUponPatronDele |advantage is that deleting |tion sets the action to |patrons in scripts or cron |take when a patron with |jobs now allows you to |public lists is deleted |preserve their public or|(options: delete the lists |shared lists. |or change owner of these ||lists). If set to change ||the owner, then the lists ||are transferred to the ||borrower number set in the ||new ListOwnerDesignated ||system preference. --- Comment #12 from David Nind --- Testing notes (using koha-testing-docker): 1. Test plan correction for patch Bug 30933: Change for patron->delete, the script name at the end to delete patrons is not spelt correctly - this should be ..patrons.pl.. not patons.pl: misc/cronjobs/delete_patons.pl -c -v -library YOUR_CODE 2. Testing that lists continue to work after transfer from the staff interface: . Can delete public lists as the super librarian (koha) . Can transfer . Can edit . Can't add or remove items if 'Allow changes to contents from:' is set to 'Owner only', but can change this then add or remove items 2. Testing that lists continue to work as expected after transfer from the OPAC: . If changes can only be made by the owner, another OPAC user can't make any changes (as expected) . If changes can be made by anyone seeing the list, another OPAC user can add and remove items from the list (as expected), can't delete or edit the list (as expected) . If changes can be made by staff only, then they can only delete, edit, etc., if they have the correct permissions (as expected) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30976] Cover images for biblio should be displayed first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #29 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 David Nind changed: What|Removed |Added Attachment #136424|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 137245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137245=edit Bug 30933: (follow-up) Use cannot_be_transferred in shelves scripts Test plan: Verify if transfer shared list on OPAC still works as expected. Same for intranet counterpart for public lists. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 David Nind changed: What|Removed |Added Attachment #136423|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 137244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137244=edit Bug 30933: (follow-up) Consolidate transfer checks Adding shelf->cannot_be_transferred with unit tests. Note: This follow-up actually refers to comment42 on the preceding report 25498. Furthermore, we could still improve later on using error code more effectively (adding codes). Here we concentrate on moving the checks to module level. Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 David Nind changed: What|Removed |Added Attachment #136422|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 137243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137243=edit Bug 30933: Adjust pref description, include ListOwnerDesignated Test plan: View the pref on the System preferences, Patrons tab. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 David Nind changed: What|Removed |Added Attachment #136421|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 137242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137242=edit Bug 30933: Change for patron->delete Test plan: Run t/db_dependent/Koha/Patrons.t Set pref ListOwnershipUponPatronDeletion to transfer. Set pref ListOwnerDesignated to some valid borrowernumber. Pick a user with public or shared list, delete from interface. Pick a user with public or shared list, delete by script. (*) Verify in both cases that new list owner is the designated one. (*) Tip: Create another branch. Move the patron to be deleted to that branch. And delete by script with: misc/cronjobs/delete_patons.pl -c -v -library YOUR_CODE Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 David Nind changed: What|Removed |Added Attachment #136420|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 137241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137241=edit Bug 30933: Database revision (new pref) Adds pref ListOwnerDesignated. Generalize description of ListOwnershipUponPatronDeletion a bit. Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header which is over 8192 bytes apache's limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||lari.task...@hypernova.fi, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header which is over 8192 bytes apache's limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 137240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137240=edit Bug 31104: Put each link on a separate header This patch makes the Pagination helper put each Link entry on the response headers on a separate header. In practice, this leads to shorter headers and will avoid apache default/reasonable limits. To test: 1. Open the patron search page 2. Open the koha logs: $ tail -f /var/log/koha/kohadev/*.log 3. On the 'Search for patron' input, use a really long string, like 'superlongstringthatistoolongforapacheyeahsuperlong' => SUCCESS: There's no user with an attribute with that content :-D => FAIL: You get an error like (28)No space left on device: [client 127.0.0.1:60330] AH10124: header size is over the limit allowed by ResponseFieldSize (8192 bytes). Bad response header: 'Link:...' 4. Apply this patch 5. Restart all: $ restart_all 6. Repeat 2 and 3 => SUCCESS: No results => SUCCESS: No error in the logs 7. Run: $ kshell k$ prove t/Koha/REST/Plugin/Pagination.t \ t/db_dependent/api/v1/*.t => SUCCESS: Tests pass! Note 1: The Link header is expected to be in CSV format, which is usually the way libraries treat repeated headers anyway. Note 2: Apache is not rejecting the response, just stripping out the 'bad header'. So this is not a critical issue. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header which is over 8192 bytes apache's limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31111] Syndetic Unbound Cover Images would be nice to be visible on the Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Kelly McElligott changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31111] New: Syndetic Unbound Cover Images would be nice to be visible on the Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Bug ID: 3 Summary: Syndetic Unbound Cover Images would be nice to be visible on the Staff Client Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently, Syndetic images are visible to patrons on the OPAC, but it would be extremely helpful to the staff to have these images on the Staff Interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Tomás Cohen Arazi changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 137239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137239=edit Bug 31106: Fix links generated in XSLTs This patch addresses the case of links that are generated on the XSLT side, those linking to and from host records using 773$t and 773$a. To test: 1. Pick a bibliographic record (I chose 'Unconditional' from the sample data 2. Add " and ? to the title statement. I changed it to 'Uncond"itional?¿' 3. Add a child record to it 4. Open the detail page for the host record => FAIL: It doesn't show the 'Show analytics' link 5. Repeat 4 for the same record, in the OPAC => FAIL: It doesn't show the 'Show analytics' link 6. Apply this patch 7. Repeat 4 and 5. => SUCCESS: Links are shown! 8. Follow the links => SUCCESS: The links take you to the right resultset! 9. Go to the child record, and notice the link back to the parent works :-D 10. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 137238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137238=edit Bug 31106: Make clean_search_term escape double quotes We noticed that several characters will break Zebra queries. So search terms need to be quoted for things to work. In this context, double quotes inside search terms are problematic because double quotes are what we use for quoting strings. This patch makes the clean_search_term method escape double quotes. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t => FAIL: It doesn't work as it should! 3. Apply this patch 4. Repeat 2 => SUCCESS: It does the job! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 137237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137237=edit Bug 31106: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Tomás Cohen Arazi changed: What|Removed |Added Attachment #137183|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Tomás Cohen Arazi changed: What|Removed |Added Attachment #137185|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Tomás Cohen Arazi changed: What|Removed |Added Attachment #137184|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30769] Typo: Item typeX:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769 --- Comment #4 from Michal Urban --- (In reply to Jonathan Druart from comment #3) > Michal, did you write this patch? Why is the author Nick? I'm not sure, I did write the patch. Maybe I messed something up when doing git bz attach, I sign off on a lot of Nick's patches so it's possible that information from one of his patches was attached to my patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #9 from Michal Urban --- Created attachment 137236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137236=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs Followed Nick's testing procedure, works good This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Signed-off-by: Michal Urban -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Michal Urban changed: What|Removed |Added Attachment #136807|0 |1 is obsolete|| --- Comment #8 from Michal Urban --- Created attachment 137235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137235=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Michal Urban changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Martin Renvoize changed: What|Removed |Added Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 --- Comment #3 from Martin Renvoize --- Weird.. it passed before we made the same change for CheckoutRenewals.. seems we can't add the same thing twice. We can certainly leave this one as is for now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize changed: What|Removed |Added Attachment #137208|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 137234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137234=edit Bug 15187: (QA follow-up) Add unit test This patch adds a unit test for the newly introduced filter. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize changed: What|Removed |Added Attachment #137207|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 137233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137233=edit Bug 15187: Index 880 in Zebra the same as Elasticsearch This patch modifies the MARC21 export to Zebra, so that 880 fields are rewritten as their linked fields, in the same way that we already do with Elasticsearch, so that the alternate graphic representation of fields are indexed accordingly. (ie 880 $6245-01 Chinese titles will be indexed into the title index using the 245 rules) Test plan: 0. Apply patch 1. Turn on ICU indexing 1b. vi /etc/koha/zebradb/etc/default.idx 1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml 1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml 1e. Restart Zebra server 1f. Re-index Zebra 2. Add record with a 880 $6 245-01 $a 教牧書信 field. 3. Search for this record using a title index with the Chinese title 4. Note that the record is correctly retrieved (Note: This test probably works better using author or series as they present as links on the detail page which makes the fix more obviously useful.) Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098 --- Comment #4 from victor --- Would I need to set permission for /var/spool/koha ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31098] The options to "export database" and "export settings" are not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098 --- Comment #3 from victor --- is already defined in nano etc/cron.daily/koha-common koha-run-backups --days 2 --output /var/spool/koha however it is not generating backup koha-dump instance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #21 from Tomás Cohen Arazi --- I agree with Marcel that the endpoint route doesn't feel correct. In our API we stick to using nouns instead of verbs (more RPC-ish). So I'd suggest POST /api/v1/auth/otp/token_delivery I haven't read the patches yet, but I'd like to mention that, to me, OTP should be generated in very specific cases and so our handling in V1/Auth.pm needs to be very careful. Somehow, we need to identify a session that is in an intermediate state: it already identified correctly but still needs a specific action. So not any active session should be able to request a OTP. As I said, I haven't reviewed this completely, so take it with a grain of salt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988 --- Comment #40 from Shi Yao Wang --- Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988 Shi Yao Wang changed: What|Removed |Added Attachment #136469|0 |1 is obsolete|| --- Comment #39 from Shi Yao Wang --- Created attachment 137232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137232=edit Bug 30988: Fix minor formatting issues Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988 Shi Yao Wang changed: What|Removed |Added Attachment #136468|0 |1 is obsolete|| --- Comment #38 from Shi Yao Wang --- Created attachment 137231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137231=edit Bug 30988: Moving id token validation code into a module Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988 Shi Yao Wang changed: What|Removed |Added Attachment #136467|0 |1 is obsolete|| --- Comment #37 from Shi Yao Wang --- Created attachment 137230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137230=edit Bug 30988: Add generic OpenIDConnect client implementation A generic OpenID Connect implementation. Test plan: 1- Set up an OAuth2 provider that has a discovery doc (e.g. for google it's https://accounts.google.com/.well-known/openid-configuration) and note down the client id and client secret. Docs to help setup: google: https://developers.google.com/identity/protocols/oauth2/openid-connect https://koha-community.org/manual/20.11/en/html/administrationpreferences.html gitlab: https://docs.gitlab.com/ee/integration/oauth_provider.html 2- Apply the patch 3- Run atomicupdate to update database 4- Configure system preferences: a- Set OIDC to Yes b- Enter the url to the discovery doc of your OAuth2 provider c- Fill OIDCOAuth2ClientID with noted client id d- Fill OIDCOAuth2ClientSecret with noted client secret e- Change OIDCProviderName to change the text displayed on OIDC login buttons f- Configure the other related system preferences as you wish. They shoud work the same way as the similar googleopenidconnect system preferences. 5- If OIDCAutoRegister is set to Don't allow, have a koha account with the same email as the one used by your OAuth2 provider. 6- In OPAC, sign in using OpenID Connect. 7- You may have to log into your OpenID provider account and accept conditions. It should finally log you into the koha account. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 --- Comment #2 from Tomás Cohen Arazi --- It doesn't apply on master, and when fixing it I get the error for CheckoutRenewal back! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133678|0 |1 is obsolete|| --- Comment #295 from Shi Yao Wang --- Created attachment 137229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137229=edit Bug 17015: Check out with the useDaysMode preference When checking out with useDaysMode preference set to "Use the calendar to push the due date to the next open day", an error 500 appears. This patch fixes this error. To test: 1. Go in Administration->useDaysMode 2. Set this preference t0 "Use the calendar to push the due date to the next open day" 3. Make sure you have a patron and a item (note the patron's category and the item's type) 4. Make sure you have a circulation rule with the patron's category and the item type in step 3 5. Attempt a checkout 6. An error 500 appears 7. Apply the patch 8. The error is no longer there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|tomasco...@gmail.com|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133605|0 |1 is obsolete|| --- Comment #294 from Shi Yao Wang --- Created attachment 137228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137228=edit Bug 17015: Fixing QA tools failures This patch fixes tests that fails with the QA tool. To test, run the QA tool All tests should say OK except 2 that fails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
Shi Yao Wang changed:
What|Removed |Added
Attachment #133604|0 |1
is obsolete||
--- Comment #293 from Shi Yao Wang ---
Created attachment 137227
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137227=edit
Bug 17015: DiscreteCalendar->new() method is now in a HASH
This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
~ The error "Can't use string ("branchcode") as a HASH ref while
"strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar
USING THE DISCRETE CALENDAR:
1- New UI
a) Calendar on the left
b) Holidays list on the right
2- New color system for holiday types:
a) Working day : white
b) Unique holiday: red
c) Holiday repeating weekly: yellow
d) Holiday repeating yearly: orange
e) Floating holiday: green
f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133603|0 |1 is obsolete|| --- Comment #292 from Shi Yao Wang --- Created attachment 137226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137226=edit Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133602|0 |1 is obsolete|| --- Comment #291 from Shi Yao Wang --- Created attachment 137225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137225=edit Bug 17015: Automatically update calendar when creating or deleting a branch Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133601|0 |1 is obsolete|| --- Comment #290 from Shi Yao Wang --- Created attachment 137224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137224=edit Bug 17015: When using book drop mode, set check in time as closing hours Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133600|0 |1 is obsolete|| --- Comment #289 from Shi Yao Wang --- Created attachment 137223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137223=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133599|0 |1 is obsolete|| --- Comment #288 from Shi Yao Wang --- Created attachment 137222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137222=edit Bug 17015: Schema file for new discrete_calendar table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133598|0 |1 is obsolete|| --- Comment #287 from Shi Yao Wang --- Created attachment 137221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137221=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133597|0 |1 is obsolete|| --- Comment #286 from Shi Yao Wang --- Created attachment 137220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137220=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #133596|0 |1 is obsolete|| --- Comment #285 from Shi Yao Wang --- Created attachment 137219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137219=edit Bug 17015: Performance comparison (images) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Assignee|ch...@bigballofwax.co.nz|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_22_11_candidate |release-notes-needed --- Comment #218 from Tomás Cohen Arazi --- Follow-up pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20 from Jonathan Druart --- Failing QA for comment 18. Marcel I waiting for an answer from you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
