[Koha-bugs] [Bug 33318] New: Revert bug 31818 from Koha 21.11.x branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Bug ID: 33318 Summary: Revert bug 31818 from Koha 21.11.x branch Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Since Koha 21.11.14 when bug 31818 was backported the Advanced editor is stuck on 'Loading, please wait'. Looking in the console the error is: "Uncaught TypeError: $.fn.popover.Constructor.DEFAULTS.whiteList is undefined" If you uncomment the lines added by bug 31818 the 'Keyboard shortcut' modal still displays with content so I am not sure bug 31818 is needed on 21.11.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Alex Buckley --- Ready for testing. Note: I have not attached unit tests because no unit test files currently check the cookie values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #4 from Alex Buckley --- Created attachment 148580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148580=edit Bug 33259: Optionally set SameSite attribute of session cookie to Strict Note: The below test plan is assuming you are running the Mozilla Firefox browser. Test plan: 1. Apply patches 2. Upgrade database sudo koha-upgrade-schema 3. Confirm the new system preference 'SameSiteSessionCookie' is 'Lax' 4. Go to a staff client and OPAC page, right click, choose 'Inspect', go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 5. Confirm 'SameSite' = 'Lax' 6. Change the 'SameSiteSessionCookie' to 'Strict' 7. Open a new private browser window. Go to a staff client and OPAC page, right click, choose 'Inspect, go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 8. Repeat step 4 and confirm 'SameSite' = 'Strict' 9. Go to: Cataloguing > New record 10. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #3 from Alex Buckley --- Created attachment 148579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148579=edit Bug 33259: Add SameSiteSessionCookie system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #148578|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #148577|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 Adam Styles changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31532] Zebra search results including 880 with original script incorrect because of Bug 15187
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31532 --- Comment #14 from David Cook --- (In reply to Lucas Gass from comment #11) > Backported to 22.05.x for upcoming 22.05.08 It looks like bug 15187 wasn't reverted. I think that needs to be done too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #37 from David Cook --- Looks like this wasn't reverted out of 22.05... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #25 from Janusz Kaczmarek --- Nick, I have looked into the corrected version. I see one problem: with Zebra, for: 655 7 $a Literatura angielska $2 DBN you search first for: "Literatura angielska + DBN" and, since there is no 040 $f, there is the second query for: "Literatura angielska + undefined' But having two auth records: 00116nz a2200049n 4500 008 230210 n anznnbabn a ana d 155$a Literatura angielska 00116nz a2200049n 4500 008 230210 n an|nnbabn a ana d 155$a Literatura angielska you will get both as response, while only one of them is appropriate (the first one) [note 008/11]. Why not to index, in Zebra, directly 008/11 and 040 $f into the same index, without the 'index_subject_thesaurus' help-template which inserts 'undefined' for lacking 040 $f? Note that in ES in this case you are adding subject-heading-thesaurus == 'z' to the query, not '|'. Also, it is not clear for me why do you hardcoded subject-heading-thesaurus in Koha/SearchEngine/Elasticsearch.pm, instead of putting it in mapping.yaml as: Subject-heading-thesaurus: label: Subject-heading-thesaurus mappings: - facet: '' marc_field: 008_/11 marc_type: marc21 sort: ~ suggestible: '' - facet: '' marc_field: 040f marc_type: marc21 sort: ~ suggestible: '' type: '' which seems to me more general and therefor natural... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #2 from Alex Buckley --- Created attachment 148578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148578=edit Bug 33259: Optionally set SameSite attribute of session cookie to Strict Note: The below test plan is assuming you are running the Mozilla Firefox browser. Test plan: 1. Apply patches 2. Upgrade database sudo koha-upgrade-schema 3. Confirm the new system preference 'SameSiteSessionCookie' is 'Lax' 4. Go to a staff client and OPAC page, right click, choose 'Inspect', go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 5. Confirm 'SameSite' = 'Lax' 6. Change the 'SameSiteSessionCookie' to 'Strict' 7. Open a new private browser window. Go to a staff client and OPAC page, right click, choose 'Inspect, go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 8. Repeat step 4 and confirm 'SameSite' = 'Strict' 9. Go to: Cataloguing > New record 10. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #1 from Alex Buckley --- Created attachment 148577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148577=edit Bug 33259: Add SameSiteSessionCookie system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 David Nind changed: What|Removed |Added Attachment #148570|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 148576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148576=edit Bug 33316: Improve display Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes: 1. I used 'Batch item modification' to add a public note to two items. 2. Repeated step 1, but added a non-public note for the same items. 3. List of jobs shows 4 jobs - 2 for batch item modifications, and 2 for Elasticsearch index updates. 4. When viewing the details for an Elastic search index update, it now lists the record ids updated in the detailed messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #35 from David Cook --- (In reply to Katrin Fischer from comment #34) > It looks like this required quite a bit of detectice work - thanks a lot! A hunch and some lucky searching heh Since Mason and I have already worked on this one, how do we move this along through QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #1 from Hammat wele --- Created attachment 148575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148575=edit Bug 33317: Add system preference to set meta robots for the OPAC Websites must have a robots meta tag to improve search engine crawling, so we could tell search engines to not index OPAC pages for example. To test: 1) Look at opac-main source and see that meta name=robots is missing. 2) Apply patch. 3) Go to system preferences > OPAC and add some directives to OpacMetaRobots (ex: noindex,nofollow). 4) Look at opac-main source and confirm that meta name=robots now has content equal to the text set in the OpacMetaRobots system preference. 5) This should Prevent search engines from indexing Opac pages (if OpacMetaRobots is set to noindex) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||hammat.w...@inlibro.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What|Removed |Added Assignee|oleon...@myacpl.org |hammat.w...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] New: Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Bug ID: 33317 Summary: Add system preference to set meta robots for the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: hammat.w...@inlibro.com QA Contact: testo...@bugs.koha-community.org Websites must have a robots meta tag to improve search engine crawling, so we could tells search engines to not index OPAC pages for example. It needs to be added to koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc The content should also be available as a system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31606] Enhance acquisitions to allow ordering on next year's budget when still in current year.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31606 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #10 from Aleisha Amohia --- Created attachment 148574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148574=edit Default accounting details tab gives option to select a fund for all orders from a file Hi all, I've found an option to select a fund for all orders from a file. It is found under the 'Default accounting details' tab, visible at the same stage as selecting items from the file to order. I believe this addresses the need to batch edit orders to apply a fund. Can you please advise, where would it be useful to store the budget ID (or name) with the order? If this is still needed? I think it's a great idea to display the budget names in the fund dropdown when adding orders to baskets. Thanks Aleisha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Janusz Kaczmarek changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Janusz Kaczmarek changed: What|Removed |Added Attachment #148569|0 |1 is obsolete|| --- Comment #3 from Janusz Kaczmarek --- Created attachment 148573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148573=edit Bug 33309: Index items after renewal transaction completes This patch ensures a record is indexed only after the renewal transaction has completed successfully. Otherwise the job cannot be found by the background process worker, becaue it was not yet in the DB To test: 1 - Make sure you are using ES, and the es indexer is running 2 - tail -f /var/log/koha/kohadev/*.log 3 - Issue an item to a patron and renew it 4 - Note error in es-indexer-output.log like: [2023/03/21 12:22:36] [WARN] No job found for id=157 main:: /kohadevbox/koha/misc/workers/es_indexer_daemon.pl (129) 5 - Apply patch 6 - Renew again 7 There should be no error 8 - Search for the record and confirm items info displays correctly 9 - View the background jobs in admin, confirm the most recent job has completed Signed-off-by: Janusz Kaczmarek -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 --- Comment #2 from Janusz Kaczmarek --- The only comment I would have for the testers -- since it is a race condition, not for every renewal would happen the issue signalized by "No job found for id=nnn"; sometimes everything would proceed smoothly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Aleisha Amohia changed: What|Removed |Added Attachment #148447|0 |1 is obsolete|| --- Comment #10 from Aleisha Amohia --- Created attachment 148572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148572=edit Bug 33019: Make sure ES records are indexed the first time This patch ensures records are indexed when they are created. Previously, we were launching the indexer inside of of a transaction. This meant that the job was being enqueued, but not being found by the worker, becaue it was not yet in the DB This patch skips record indexing in the transaction, and moves the indexing command after To test: 1 - Make sure you are using ES, and the es indexer is running 2 - tail -f /var/log/koha/kohadev/*.log 3 - Create a new record 4 - Note error in es-indexer-output.log like: [2023/03/21 12:22:36] [WARN] No job found for id=157 main:: /kohadevbox/koha/misc/workers/es_indexer_daemon.pl (129) 5 - Apply patch 6 - Create another record 7 There should be no error 8 - Search for the record and confirm it can be found 9 - View the background jobs in admin, confirm the most recent job has completed Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25295] Allow customization of staff client based on login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 --- Comment #43 from Nick Clemens --- (In reply to Jonathan Druart from comment #41) > (In reply to Nick Clemens from comment #39) > > Created attachment 148350 [details] [review] [review] > > Bug 32594: POC > > I don't think we should loop over the jobs, we are adding additional (almost > useless) processing. Here we need to do things fast, so let's update them > all at once. To prevent other scripts/jobs to use this, we should not > provide a method (that does not feel correct). I was trying to set the number processed to the numebr in the job, I forgot we made all a size of 1 I squashed and mark yours SO > > Now we need to decide if we allow indexing jobs from another worker. The > detail page of the job is still wrong " / records have successfully been > reindexed. Some errors occurred.". Bug 33319 filed to improve As for processing: > IMO we should not provide 2 ways to process the jobs, only the new worker > should do it. So let's remove the process method and simplify the job detail > view. > Sounds like we should move that to a separate bug... I think that's a third job - we could have some plugins or some outside system wanting to handle indexation for some reason? But I am okay to remove too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Nick Clemens changed: What|Removed |Added Attachment #148513|0 |1 is obsolete|| --- Comment #42 from Nick Clemens --- Created attachment 148571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148571=edit Bug 32594: Mark jobs as started and finished Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33316 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32594 --- Comment #2 from Nick Clemens --- This could certainly be improved, but is better than it was To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #7 from Fridolin Somers --- OK, like for bug 33297 ? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148504 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #1 from Nick Clemens --- Created attachment 148570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148570=edit Bug 33316: Improve display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33316] New: Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Bug ID: 33316 Summary: Improve display of ES indexer jobs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33309 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33019 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 --- Comment #1 from Nick Clemens --- Created attachment 148569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148569=edit Bug 33309: Index items after renewal transaction completes This patch ensures a record is indexed only after the renewal transaction has completed successfully. Otherwise the job cannot be found by the background process worker, becaue it was not yet in the DB To test: 1 - Make sure you are using ES, and the es indexer is running 2 - tail -f /var/log/koha/kohadev/*.log 3 - Issue an item to a patron and renew it 4 - Note error in es-indexer-output.log like: [2023/03/21 12:22:36] [WARN] No job found for id=157 main:: /kohadevbox/koha/misc/workers/es_indexer_daemon.pl (129) 5 - Apply patch 6 - Renew again 7 There should be no error 8 - Search for the record and confirm items info displays correctly 9 - View the background jobs in admin, confirm the most recent job has completed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27973] Limit to currently available items should have an option to filter out notforloan statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #10 from Christopher Brannon --- I am hoping this feature will get some much needed attention. It has been unreliable for way too long. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #11 from Christopher Brannon --- I am hoping this feature will get some much needed attention. It has been unreliable for way too long. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33315] Missing space in TICKET_NOTIFY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Caroline Cyr La Rose --- I reloaded the yaml, and this seems to be already corrected... Apologies! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33315 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33315 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose changed: What|Removed |Added Blocks||33315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 [Bug 33315] Missing space in TICKET_NOTIFY -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33315] Missing space in TICKET_NOTIFY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 Caroline Cyr La Rose changed: What|Removed |Added Depends on||31028 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33313, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33314 Severity|enhancement |trivial Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33315] New: Missing space in TICKET_NOTIFY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 Bug ID: 33315 Summary: Missing space in TICKET_NOTIFY Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org The is a missing space between the reporter name/cardnumber and the rest of the sentence in TICKET_NOTIFY. This is very minor, but makes the notice look a little less professional. To reproduce: 1. Make sure staffClientBaseURL is filled correctly 2. Enable CatalogConcerns 3. Enter an email address in CatalogerEmails 4. Go to a bibliographic record in the staff interface 5. Click New > New catalog concern 6. Fill out the form and click Submit 7. Check the message_queue table for the message --> In the message, the sentence is Caroline Cyr La Rose (123456)reported the following concern with (missing space between "(123456)" and "reported") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 --- Comment #30 from Nick Clemens --- (In reply to Jonathan Druart from comment #29) > Created attachment 148562 [details] [review] > Bug 30860: [alternative patch] Cache CanItemBeReserved return value > > Instead of hacking CanBookBeReserved this patch suggests to simply cache > the return value of CanItemBeReserved that could be then returned *on > demand* > We don't want to introduce side-effects hard to catch from this simple > change, so let's return the cache value only from the 2 scripts we are > dealing with. This works, and in initial testing seems to offer improvement. I have one hesitation Current: code calls CanBookBeReserved, which exits on first holdable item, then we call CanItemBeReserved for every item Worst case, last item is holdable - for 100 items we call CanItemBeReserved 200 times My patches: code calls CanBookBeReserved which in turn calls CanItemBeReserved for every item. Then we loop over the results for each item Worst case, we call CanItemBeReserved 100 times - we do this no matter what Alternate patches: code calls CanBookBeReserved which exits on first holdable item we then retrieve any alreayd calculated from cache, then we cache each result as we go forward. Worst case - first item is holdable - we retrieve a single value from cache, then cache every subsequent CanItemBeReserved call and never use it - though we still only call CanItemBeReserved 100 times max I don't know what the actual tendency for number of items holdable, but it feels like we can do a lot of caching that we don't necessarily need. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33314 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose changed: What|Removed |Added Blocks||33314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Caroline Cyr La Rose changed: What|Removed |Added Severity|enhancement |minor Depends on||31028 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33314] New: Link to bibliographic record incomplete in default TICKET_NOTIFY notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Bug ID: 33314 Summary: Link to bibliographic record incomplete in default TICKET_NOTIFY notice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When reporting a catalog concern, an email is sent to the cataloging team with a link to the bibliographic record in question. However, this link seems to be incomplete. (Might be linked to bug 33313, but I think the source of the problem is different...) To reproduce: 1. Make sure staffClientBaseURL is filled correctly 2. Enable CatalogConcerns 3. Enter an email address in CatalogerEmails 4. Go to a bibliographic record in the staff interface 5. Click New > New catalog concern 6. Fill out the form and click Submit 7. Check the message_queue table for the message --> In the message, the link base to the record is empty a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=61" Unfortunately, it's not as easy as changing the pref name to staffClientBaseURL because the line in the notice is [%- INCLUDE 'biblio-title.inc' biblio=ticket.biblio link = 1 -%]. So I'm guessing it's taking the baseURL somewhere else, but I don't know where. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose changed: What|Removed |Added Blocks||33313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Caroline Cyr La Rose changed: What|Removed |Added Depends on||31028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33313] New: TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313
Bug ID: 33313
Summary: TICKET_NOTIFY looking for IntranetBaseURL rather than
staffClientBaseURL in default notice
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs@lists.koha-community.org
Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
While I think IntranetBaseURL is a better name for it, the system preference is
still called staffClientBaseURL ;)
To reproduce 1:
1. Go to Tools > Notices and slips
2. Look for TICKET_NOTIFY
3. Click 'Edit' next to TICKET_NOTIFY
4. Click 'Email'
--> In the message body is this line
a href='[%- Koha.Preference('IntranetBaseURL')
-%]/cgi-bin/koha/cataloguing/concerns.pl
To reproduce 2:
1. Make sure staffClientBaseURL is filled correctly
2. Enable CatalogConcerns
3. Enter an email address in CatalogerEmails
4. Go to a bibliographic record in the staff interface
5. Click New > New catalog concern
6. Fill out the form and click Submit
7. Check the message_queue table for the message
--> In the message, the link base is empty
You can mark this concern as resolved from the concern management page
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33312] New: Add circulation and fines rules table from smart-rules.pl to column settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Bug ID: 33312 Summary: Add circulation and fines rules table from smart-rules.pl to column settings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com It would be very helpful to be able to configure hiding columns as libraries rarely (if ever) use all the columns (suspensions vs fines, etc.) Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #3 from Andrew Fuerste-Henry --- See bug 33301 for discussion the use case for this and a more formal way to configure temporary shelving locations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33301] Request for adding a facility to remember the previous item location and switch back to it upon check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33301 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31187 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33301 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33287] Race condition in Koha::BackgroundJob?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33287 --- Comment #6 from Janusz Kaczmarek --- (In reply to Nick Clemens from comment #5) [...] > It looks like this is the same issue - AddRenewal is called in a transaction > - so we need to index after the transaction is committed. Could you open a > new bug for that one? OK, Bug 33309 created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242
--- Comment #13 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #12)
> Yes, more code to maintain, and the parsing here looks hacky to me, for less
> flexibility.
What is hacky in this parsing ?
if( $entry =~
/^(add|subtract)_(years|months|weeks|days|hours|minutes|seconds)$/ ) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33301] Request for adding a facility to remember the previous item location and switch back to it upon check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33301 --- Comment #4 from Andrew Fuerste-Henry --- Thinking of ways to make this simpler, it'd be a great first step to introduce a method by which to indicate which shelving locations should be considered "temporary" in the style of the shelving cart. Maybe a system preference where one enters a list of shelving locations, and Koha remembers that any edit to set an item to one of those locations should set items.location without changing items.permanent_location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33301] Request for adding a facility to remember the previous item location and switch back to it upon check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33301 --- Comment #3 from Andrew Fuerste-Henry --- But see bug 31187 for how this workflow doesn't currently allow for setting a temporary shelving location for multiple items in a batch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33301] Request for adding a facility to remember the previous item location and switch back to it upon check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33301 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry --- This is technically possible, though I'd love to see a more official and codified process. The database includes items.permanent_location, but Koha really only expects you to use to store the item's actual location while it's set to either a temporary status set when the item is first cataloged (defined in NewItemsDefaultLocation) or "CART" for cart_to_shelf cron. By default, any edit to items.location outside of cataloging a new item or setting an item to CART at checkin will *also* update permanent_location, thereby messing up what you're trying to do. But you can make location and permanent_location independently editable and then make items change from their temporary location to their permanent location at checkin. To do so: - Create a new 952 subfield, editable, managed within the Items tab, set to use the LOC authorised value. You'll have to repeat this setup in each framework in which you have items where you want to use a temporary shelving location. - Go to Koha To MARC Mapping in administration and connect the subfield you just created to items.permanent_location - go to system preferences set UpdateItemLocationOnCheckin to update all items toe their permanent shelving location at checkin (https://koha-community.org/manual/latest/en/html/circulationpreferences.html#updateitemlocationoncheckin) - Pull up an item record and see that the edit screen shows both location and permanent location. Confirm that you can edit either without changing the other. - Check in an item where the two values don't match, confirm it updates to the permanent_location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941 Juliet Heltibridle changed: What|Removed |Added CC||jheltibri...@rcplib.org --- Comment #5 from Juliet Heltibridle --- I would like to see this added, I use the documentation links on bibliographic records very often and would use them if they were included on authority records as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33311] New: Add preference for voice notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33311 Bug ID: 33311 Summary: Add preference for voice notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: supp...@shoutbomb.com QA Contact: testo...@bugs.koha-community.org Created attachment 148568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148568=edit Message settings Current options for circulation notices do not include voice/phone. Can this option be added. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33310] New: Use template wrapper for tabs: Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Bug ID: 33310 Summary: Use template wrapper for tabs: Suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the suggestions page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What|Removed |Added Blocks||33310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 [Bug 33310] Use template wrapper for tabs: Suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Hmm. Interesting. I added it once and know that there are more references to GDPR; you see some of them already scrolling thru this patch. We will now have a general name that still uses gdpr artifacts under the surface. No blocker, but also a bit hesistant to change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 --- Comment #12 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #10) > > I was going to PQA until I saw bug 33029, which gives us more flexibility. > > Not sure we need both personally. > > Yes we looked at that. Kyle, Nick and I concluded that both go fine together. > See description too, saying this: > > Compare the 33029 approach > [% KohaDates.datetime_from_string(checkout.issuedate).add( days => 3) | > $KohaDates %] > with the approch of this report > [% checkout.issuedate | $KohaDates add_days => 3 %] > > The latter notation is definitely shorter and prettier in my use case and > does only need a few lines more. Yes, more code to maintain, and the parsing here looks hacky to me, for less flexibility. Note that I didn't FQA but I am not the one who is going to PQA this ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33287] Race condition in Koha::BackgroundJob?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33287 Janusz Kaczmarek changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33309 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33309] New: Race condition while checkout renewal with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309
Bug ID: 33309
Summary: Race condition while checkout renewal with ES
Change sponsored?: ---
Product: Koha
Version: 22.11
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P3
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: janus...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: n...@bywatersolutions.com
Performing checkout renewal with ES turned on causes race condition in
BackgroundJobs processing, manifesting with lines like:
[2023/03/20 17:18:10] [WARN] No job found for id=13218 main::
/usr/share/koha/bin/background_jobs_worker.pl (114)
in worker-output.log.
This is due to calling -- inside transaction -- $item_object->store in
C4::Circulation::AddRenewal. [Koha::Item->store in turn calls
$indexer->index_records, which in installations with ES creates BackgroundJob].
The solution could be similar to that proposed in Bug 33019, i.e. calling
$item_object->store with {skip_record_index => 1} and calling
$indexer->index_records after the transaction ends.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > I was going to PQA until I saw bug 33029, which gives us more flexibility. > Not sure we need both personally. Yes we looked at that. Kyle, Nick and I concluded that both go fine together. See description too, saying this: Compare the 33029 approach [% KohaDates.datetime_from_string(checkout.issuedate).add( days => 3) | $KohaDates %] with the approch of this report [% checkout.issuedate | $KohaDates add_days => 3 %] The latter notation is definitely shorter and prettier in my use case and does only need a few lines more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #6 from Jonathan Druart --- Then people won't find the syspref when searching for "GDPR". Shouldn't we add a ref in the description at least? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31212] Datelastseen should be a datetime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212
--- Comment #33 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #32)
> Can you explain the changes in C4/Items.pm?
I mean the ones from the first patch.
This one is definitely not needed:
+my $today = output_pref({ dt => dt_from_string, dateformat => 'iso',
dateonly => 0 });
This one should not be needed either:
+$datelastseen = output_pref({ str => $datelastseen, dateformat =>
'iso', dateonly => 0 });
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #4) > This is a bit of teasing: > > > select="marc:subfield[@code='2']"/>:// > > But when you would put mailto inside $2, this goes wrong again ;) > Not really a blocker, just noting a fictive improvement. Ended up fixing it with three more lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33308] New: Add ability to to use sftp with runreport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308 Bug ID: 33308 Summary: Add ability to to use sftp with runreport.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz It would be very awesome to be able to specify a sftp/ftps target with the cronjob runreport.pl job, to complement the ability currently available to email the report somewhere. Some kind of secure solve for "allowing the koha user to automatically accept the hostkey" on the first connection would also be nice, but not a requirement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 --- Comment #9 from Marcel de Rooy --- Created attachment 148567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148567=edit Bug 32794: (follow-up) Replace code by new function (template) Test plan: Same as first patch. Bonus: Remove protocol from $u. Set first ind1 to 7. Put mailto in $2. Check link. Change $2 to tel. Check link. Change $2 to https. Check link. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31212] Datelastseen should be a datetime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #32 from Jonathan Druart --- Can you explain the changes in C4/Items.pm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 --- Comment #8 from Marcel de Rooy --- Created attachment 148566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148566=edit Bug 32794: (follow-up) Consolidate shared code into one function (:template) Few extra lines for the $2 exception as noted on Bugzilla. Note: We should probably check why the utils xslt on opac and intranet have so much differences currently. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 Marcel de Rooy changed: What|Removed |Added Attachment #147745|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 148565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148565=edit Bug 32794: Expand tests for access method in XLST files This patch expands the checks for 856u to check for mailto, and adds a few conditiona checks of the first indicator to cover more methods Reference: https://www.oclc.org/bibformats/en/8xx/856.html To test: 1 - Edit a record and add a few 856 fields: 856 0 0 $umailto:t...@example.org 856 0 0 $ut...@example.org 856 2 0 $utelnet://pucc.princeton.edu 856 2 0 $upucc.princeton.edu 856 3 0 $u888555 2 - View staff details and results and opac details and results 3 - Note all links have been prepended with http:// 4 - Apply patch 5 - Refresh all views, ensure links are correctly formed Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #24 from Frank Hansen --- (In reply to Nick Clemens from comment #23) > (In reply to Frank Hansen from comment #22) > > > I would still like to comment on ind2=4. As for us, we treat them as local > > subject headings only and they are not included in any thesaurus. Therefore, > > I would prefer not to see any authority records for either 008/11=| (or > > 008/11=n) in our catalog, even if the format allows it. > > Are you saying you won't import those records - or you want those records to > be ignored when linking? The former sounds easy enough, the second seems it > would require a syspref to not link those > Sorry if I was unclear. Records with ind2=4 is not exported from National Library catalogue at first. So they will not be imported to our local catalogue. We are not planning to create any either manually or automatically. > > I also want to comment on 040$f. According to the Swedish cataloguing > > guidelines here > ... > > So I question about allowing to omit 040$f when 008/11=z. > > This sounds like a comment on cataloging standards, and maybe something that > can be set in frameworks. But I don't think we need code for this? > Maybe not. We will use 040$f to specify system/thesaurus conventions in any case. I just want to make sure that it not have a negative impact on filtering on thesauruses if we omit 040$f. > > What causes the most trouble for me is, as mentioned earlier, that non-6XX > > fields are hardcoded to LCSH. This creates problems for libraries outside > > the US, as we typically do not use LCSH names. I wish we could skip > > thesaurus search for those fields. > > These patches do now skip searching thesaurus when linking non-subject fields I'm testing bug33277 and what I have seen so far looks good. (both ES and Zebra) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #10 from Jonathan Druart --- I was going to PQA until I saw bug 33029, which gives us more flexibility. Not sure we need both personally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #8 from Jonathan Druart --- Shouldn't it be EmailAddress instead of Email? It's not a verb, and we have AutoEmailOpacUser where it is used as a verb. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #16 from Hammat wele --- (In reply to Laura Escamilla from comment #14) > For me this is not working either. In PrefillGuaranteeField I am adding > every Alternate address field. When I search for a guarantor, and then add > them to the guarantee, the fields do not populate. Hi Laura, thank you for testing. I've updated the test plan since the guarantee's information take a little time to be filled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #15 from Hammat wele --- Created attachment 148564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148564=edit Bug 26597: (follow-up) Add disabling / enabled the save button while waiting from api to respond I've updated the test plan since the REST API route takes a little time to respond To test: 1) Apply patch 2) Search PrefillGuaranteeField preference and make sure some fields are selected 3) Select a user that can have a guarantor 4) In the edit form, click on "Search to add" in "Patron guarantor" fieldset 5) Choose a patron who has at least one of the fields in 1) set 6) Click Select 7) Wait until save button is enabled 8) Confirm guarantee's information is filled from the guarantor's record 9) Check that any preexisting information is not overwritten -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 --- Comment #1 from Owen Leonard --- Created attachment 148563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148563=edit Bug 33307: Use template wrapper for tabs: Lists This patch updates the lists template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the lists page in the staff interface. - Confirm that the two tabs, "Your lists" and "Public lists" look correct and work correctly. - Test that the correct tab is selected when you add the "public" or "private" parameter to the url: /cgi-bin/koha/virtualshelves/shelves.pl?op=list=1 /cgi-bin/koha/virtualshelves/shelves.pl?op=list=0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What|Removed |Added Blocks||33307 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 [Bug 33307] Use template wrapper for tabs: Lists -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33307] New: Use template wrapper for tabs: Lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 Bug ID: 33307 Summary: Use template wrapper for tabs: Lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the lists page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 --- Comment #29 from Jonathan Druart --- Created attachment 148562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148562=edit Bug 30860: [alternative patch] Cache CanItemBeReserved return value Instead of hacking CanBookBeReserved this patch suggests to simply cache the return value of CanItemBeReserved that could be then returned *on demand* We don't want to introduce side-effects hard to catch from this simple change, so let's return the cache value only from the 2 scripts we are dealing with. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
