[Koha-bugs] [Bug 33960] Add ability to retrieve deleted bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_05_candidate |additional_work_needed --- Comment #53 from Katrin Fischer --- We have some test fails to be fixed, that were probably caused by the work here: t_db_dependent_TestBuilder_t not ok 697 - Module Koha::Old::Biblio::Metadatas should have koha_object[s]_class method if needed not ok 698 - Module Koha::DeletedbiblioMetadata should be defined not ok 699 - Module Koha::DeletedbiblioMetadatas should be defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Katrin Fischer changed: What|Removed |Added Keywords|release-notes-needed|additional_work_needed --- Comment #105 from Katrin Fischer --- We have some test failures where this bug is a likely candidate: t_db_dependent_TestBuilder_t not ok 553 - Module Koha::ILL::Comments should have koha_object[s]_class method if needed not ok 554 - Module Koha::Illcomment should be defined not ok 555 - Module Koha::Illcomments should be defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00|24.05.00,23.11.05 released in|| Status|Pushed to main |Pushed to stable --- Comment #14 from Fridolin Somers --- Pushed to 23.11.x for 23.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Severity|normal |major --- Comment #6 from Fridolin Somers --- Rise importance to major since it can break the server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 --- Comment #42 from Aleisha Amohia --- (In reply to David Nind from comment #41) > Everything worked OK to me, except that I had to run the updatedatabase > twice for the "Recall awaiting pickup" and "Return recalled item" options to > appear under the patron messaging preferences. > Mmm I noticed that too, a bit weird and will definitely caused problems for users ... I'm not sure of a way around that except taking the 'IGNORE' out if 'INSERT IGNORE INTO' for the message_attributes update. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #16 from David Cook --- I think perhaps we should use swagger.yml for development, and then we could build swagger_bundle.yml during the build. In koha-testing-docker, Koha is starting so fast I can't catch the Swagger parsing with strace. I'm excited to try this out on a test server with multiple instances and more realistic load than my dev machine. Great work here, Tomas (and everyone else)! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #15 from David Cook --- Created attachment 165446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165446=edit Bug 36546: Fix js-yaml dependency in package.json -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 David Cook changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #101 from Victor Grousset/tuxayo --- It works :) (readded Pedro's SO line that was lost in Comment 91 changes) It functionally makes sense, found nothing out of order after some exploratory testing on opac, staff and ILS-DI. Thanks David for the earlier testing and notes :) REST API doesn't seem to have a way to place holds so nothing to see there. Like Pedro, I'm not confident in understanding alone enough the completeness and correctness of the many changes in C4/Reserves.pm and opac-reserve.pl to fully QA. But let's try going with this since we both found no obvious issue in the code. The RM is free to request more review. Works, makes sense, QA script happy, code looks good, passing QA :) -- @Arthur: For releases notes, it would be clearer if the name of the ticket was something like: «"OPAC item level holds" circulation rules are not followed by ILS-DI» Do you confirm that's the fix in a nutshell? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #14 from David Cook ---
Comment on attachment 165412
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165412
Bug 36546: Add a bundled version of the API spec
Review of attachment 165412:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=36546=165412)
-
::: Koha/REST/V1.pm
@@ +75,4 @@
> $self->secrets([$secret_passphrase]);
> }
>
> +my $spec_file =
> $self->home->rel_file("api/v1/swagger/swagger_bundle.yaml");
Perhaps we should test for "swagger_bundle.yaml" and fallback to "swagger.yaml"
if it's unavailable?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
--- Comment #13 from David Cook ---
(In reply to David Cook from comment #12)
> Btw, I think the problem is that "js-yaml" is in "resolutions" in our
> package.json.
>
> That's overriding the dependency for @redocly/openapi-core it seems.
>
> Looks like Owen did that back in 2019 for bug 23025
>
> Something to revisit it seems.
find node_modules -name "package.json" -exec grep 'js-yaml' {} \;
"name": "@types/js-yaml",
"description": "TypeScript definitions for js-yaml",
"homepage":
"https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/js-yaml;,
"directory": "types/js-yaml"
"name": "js-yaml",
"repository": "nodeca/js-yaml",
"js-yaml": "bin/js-yaml.js"
"module": "./dist/js-yaml.mjs",
"import": "./dist/js-yaml.mjs",
"unpkg": "dist/js-yaml.min.js",
"jsdelivr": "dist/js-yaml.min.js",
"js-yaml": "^4.1.0",
"@types/js-yaml": "^4.0.3",
"js-yaml": "^4.1.0",
"name": "js-yaml",
"homepage": "https://github.com/nodeca/js-yaml;,
"repository": "nodeca/js-yaml",
"js-yaml": "bin/js-yaml.js"
"unpkg": "dist/js-yaml.min.js",
"jsdelivr": "dist/js-yaml.min.js",
Probably time to upgrade our js-yaml version and stop the "resolutions"
override...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #12 from David Cook --- Btw, I think the problem is that "js-yaml" is in "resolutions" in our package.json. That's overriding the dependency for @redocly/openapi-core it seems. Looks like Owen did that back in 2019 for bug 23025 Something to revisit it seems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #11 from David Cook --- (In reply to David Cook from comment #10) > Now I can get redocly to run, but it looks like this isn't going to work out > of the box... kohadev-koha@kohadevbox:koha(bug36546)$ redocly bundle api/v1/swagger/swagger.yaml > api/v1/swagger/swagger_bundle.yaml bundling api/v1/swagger/swagger.yaml... � Created a bundle for api/v1/swagger/swagger.yaml at stdout 422ms. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 David Cook changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #10 from David Cook --- (In reply to David Cook from comment #8) > Trying to troubleshoot the issue, but it looks like it should be working > when I look through the JS files. I mean the js-yaml version does seem incompatible. It should be 4.1.0 instead of 3.13.1, but even after upgrading it I still get the same error... -- rm -rf node_modules rm yarn.lock yarn install No luck. Node.js/yarn are so weird... -- cd /kohadevbox/koha/node_modules/@redocly/openapi-core yarn install This installs @redocly's openapi-core dependencies into /kohadevbox/koha/node_modules/@redocly/openapi-core/node_modules, which includes js-yaml 4.1.0 while kohadevbox/koha/node_modules/js-yaml is still 3.13.1 -- Now I can get redocly to run, but it looks like this isn't going to work out of the box... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #9 from Tomás Cohen Arazi --- (In reply to David Cook from comment #8) > rm -rf node_modules/ > yarn install > > Still doesn't work. > > Trying to troubleshoot the issue, but it looks like it should be working > when I look through the JS files. It is weird, I didn’t manage to make it run before I left the office. If you want to try it, run it through npx instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #8 from David Cook --- rm -rf node_modules/ yarn install Still doesn't work. Trying to troubleshoot the issue, but it looks like it should be working when I look through the JS files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #7 from David Cook --- If I take down Koha and try to start it up, it breaks koha-testing-docker as it fails on the yarn api:bundle and exits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #6 from David Cook --- (In reply to Tomás Cohen Arazi from comment #4) > Putting this here for review/discussion. > > Feedback is welcome! Unfortunately, I couldn't get this patch to work. I did a "yarn install" then "yarn api:bundle" and this is what I got: yarn run v1.22.19 $ redocly bundle api/v1/swagger/swagger.yaml > api/v1/swagger/swagger_bundle.yaml /kohadevbox/koha/node_modules/@redocly/openapi-core/lib/js-yaml/index.js:9 implicit: [js_yaml_1.types.merge], ^ TypeError: Cannot read properties of undefined (reading 'merge') at Object. (/kohadevbox/koha/node_modules/@redocly/openapi-core/lib/js-yaml/index.js:9:32) at Module._compile (node:internal/modules/cjs/loader:1256:14) at Module._extensions..js (node:internal/modules/cjs/loader:1310:10) at Module.load (node:internal/modules/cjs/loader:1119:32) at Module._load (node:internal/modules/cjs/loader:960:12) at Module.require (node:internal/modules/cjs/loader:1143:19) at require (node:internal/modules/cjs/helpers:121:18) at Object. (/kohadevbox/koha/node_modules/@redocly/openapi-core/lib/utils.js:18:19) at Module._compile (node:internal/modules/cjs/loader:1256:14) at Module._extensions..js (node:internal/modules/cjs/loader:1310:10) Node.js v18.17.1 error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Comment #5 from David Cook ---
I am so happy to see other people talking about this, because this has been
driving me crazy for *years*. It's arguably my biggest pet peeve about Koha!
A few years ago, I got Jan Henning Thorsen to add
"skip_validating_specification" to Mojolicious::Plugin::OpenAPI, and I've
turned that on locally in Koha, but it hasn't made a noticeable difference to
startup times, and when I use strace I notice something similar to Didier. The
same syscalls over and over again:
newfstatat(AT_FDCWD, "/usr", {st_mode=S_IFDIR|0755, st_size=4096, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share", {st_mode=S_IFDIR|0755, st_size=4096, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha", {st_mode=S_IFDIR|0755, st_size=4096,
...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api", {st_mode=S_IFDIR|0755,
st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1", {st_mode=S_IFDIR|0755,
st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger", {st_mode=S_IFDIR|0755,
st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
{st_mode=S_IFREG|0644, st_size=44125, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
{st_mode=S_IFREG|0644, st_size=44125, ...}, 0) = 0
Jan was always skeptical about the validation being the problem, but he
humoured me nonetheless. In my tests in 2021, skipping validation solved the
problem, but using "skip_validating_specification" hasn't helped in 2024 (and
earlier years).
Even back then, I figured the problem was with the dereferencing of the spec,
but it seemed to only happen with the validation.
I'd be interested to see a flamegraph generated with Tomas's patch. I'm going
to give it a go now and see what strace says...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36328] C4::Scrubber should allow more HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #16 from wainuiwitikap...@catalyst.net.nz --- Applied to 22.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #165443|0 |1 is obsolete|| --- Comment #100 from Victor Grousset/tuxayo --- Created attachment 165445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165445=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api). Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold What this patch does : -- Move get_opacitemholds_policy check into Reserves.pm::CanBookBeReserved -- Update CanItemBeReserved to return recordHoldsOnly status if interface is OPAC -- Update warning labels in opac-reserve.tt accordingly. To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place item-level hold on staff interface 3 - Hold is still allowed (rule do not apply to staff) 4 - Attempt to place item-level hold from opac or ilsdi 5 - Hold is not allowed (rule apply from opac or ilsdi) 6 - Change rule to 'force' 7 - Item-level hold can still be placed from the staff interface 8 - Record-level hold cannot be placed from opac or ilsdi Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #165442|0 |1 is obsolete|| --- Comment #99 from Victor Grousset/tuxayo --- Created attachment 165444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165444=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36561] Inappropriate permission for "/api/v1/auth/password/validation"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36561 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27423 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36561 --- Comment #16 from David Cook --- @Nick, did you guys come up with anything in the end? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36563] Item search does not search for multiple values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #18 from Aleisha Amohia --- Noting I see the keywords already to get this into 23.11 and 23.05 ... and we will be very happy about it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 Aleisha Amohia changed: What|Removed |Added Keywords||rel_23_05_candidate, ||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #13 from Aleisha Amohia --- This fixes a bug in 23.11 and 23.05. Can we please ensure it is backported? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 --- Comment #23 from David Cook --- (In reply to Marcel de Rooy from comment #22) > Does this report include thinking about how we could secure more sensitive > data in our koha-conf file? Like DB password, encryption key, etc. Note e.g. > discussion on encryption keys in koha-conf on 34976. I hadn't thought of that specifically, but there's no reason we couldn't think about that too. I think that sensitive data in koha-conf.xml is fairly secure at the moment. Only root and the Koha instance user can read koha-conf.xml (at least with the Debian packages). But are you thinking of something more like "docker secret"? Or AWS Secrets Manager/HashiCorp Vault? Something where the secrets are encrypted at rest? I think the tough part with Koha is there are so many moving pieces. Lots of daemons, lots of cronjobs. All which need access to the secret/sensitive data, which gets more complicated if you have to deal with secret keepers running in a separate process, which need security of their own too. -- It could be interesting to build multiple ways to get secret/sensitive data. With "docker secret", maybe some way to say KOHA_CONF=/run/secrets/koha-conf.yml. Symlinks might also be workable here. I think secret keepers would be harder, but not impossible. -- Overall, this is probably a good place to be thinking about these things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #165112|0 |1 is obsolete|| --- Comment #98 from Victor Grousset/tuxayo --- Created attachment 165443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165443=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api). Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold What this patch does : -- Move get_opacitemholds_policy check into Reserves.pm::CanBookBeReserved -- Update CanItemBeReserved to return recordHoldsOnly status if interface is OPAC -- Update warning labels in opac-reserve.tt accordingly. To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place item-level hold on staff interface 3 - Hold is still allowed (rule do not apply to staff) 4 - Attempt to place item-level hold from opac or ilsdi 5 - Hold is not allowed (rule apply from opac or ilsdi) 6 - Change rule to 'force' 7 - Item-level hold can still be placed from the staff interface 8 - Record-level hold cannot be placed from opac or ilsdi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #165111|0 |1 is obsolete|| --- Comment #97 from Victor Grousset/tuxayo --- Created attachment 165442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165442=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18787] Create permission profiles for staff users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #6 from David Cook --- *** Bug 31184 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31184] Add default permissions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31184 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from David Cook --- (In reply to Caroline Cyr La Rose from comment #2) > So has this become a duplicate of bug 18787 then? Looks like it! *** This bug has been marked as a duplicate of bug 18787 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7003] Canned report to show patrons and permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31184] Add default permissions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31184 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #2 from Caroline Cyr La Rose --- So has this become a duplicate of bug 18787 then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7003] Canned report to show patrons and permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20813 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=7003 CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36679] New: anonymous patron is not blocked from checkout via self check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679 Bug ID: 36679 Summary: anonymous patron is not blocked from checkout via self check Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org The anonymous patron is not allowed to checkout through the staff module, but it appears that you can login as this user on the self check and check out items. While it is more likely this could be exploited with a random library card number, this does create a hole in blocking circ on this account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36342] Allow entering date ranges directly in bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36342 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36342] Allow entering date ranges directly in bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36342 --- Comment #2 from Lucas Gass --- Created attachment 165441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165441=edit Bug 36342: Add Maskito date range support To test: 1. Make some items bookable by going to catalogue/moredetail.pl?biblionumber=X 2. On the toolbar for that record you should now see "Place booking" 3. Try placing a booking and adding the date range for "Booking dates" manually. 4. Play with the DateFormat system preference to make sure this works for all supported date formats. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36342] Allow entering date ranges directly in bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36342 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7003] Canned report to show patrons and permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #5 from Caroline Cyr La Rose --- I was just about to write a new bug report about this. I'm looking for all the users in one instance who have a specific permission. Maybe this could be done in conjunction with the revamp of user permissions (bug 20813?), but we need an easier way to see who has which permission than an SQL report like this monster https://wiki.koha-community.org/wiki/SQL_Reports_Patrons#Accounts_with_permissions_.28v22.11.29 (kudos to Christopher for figuring all that out!) it's massive! A page in Administration would be great I think. - See all the users who have permissions - See all permissions of a user (could be a link to their "set permissions" page) - See all users who have a particular permission - Seeing this page could be limited by a permission or could be linked to the existing "permissions" permission -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36678 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21357 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 --- Comment #2 from Nick Clemens --- Created attachment 165440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165440=edit Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 --- Comment #1 from Nick Clemens --- Created attachment 165439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165439=edit Bug 36678: Adjust unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35625] Add support for system flag to additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625 Mark Hofstetter changed: What|Removed |Added CC||k...@trust-box.at -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] New: Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 Bug ID: 36678 Summary: Include fields with non-filing characters removed when indexing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com Created attachment 165438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165438=edit Sample record for testing Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. Consider: L'amour de l'art : art contemporain et collections privées du Sud-Ouest. Currently a search for: amour de l'art will return no results in elastic search We should include the form with non-filing characters removed See also bug 21357 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35906] Add bookable option on itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com Status|Needs Signoff |Signed Off --- Comment #43 from Esther Melander --- Works according to test plan. Just a few notes: I tested this by changing the Book item type to allow for bookings. However, when I searched for Books, the Bookable dropdown for the item was not updated for existing items. I still had to go in and manually update the option to Follow item type. This is probably correct for existing items. There is not a way to update this via batch item modification for existing items (Bug 35671). However, adding a new item does default to Follow item type in the Bookable dropdown. I was able to place a booking for the item. Library limitations appear to work. In a consortium, if one library wants an item type like Books to be bookable and another does not, they will have to create separate item types with library limitations. If I change the item type like Books to be bookable by item type, book some items, and then go and change those items to not be bookable, the bookings/bookings tab disappears from the bibliographic detail view. In this scenario, the bookings should not disappear even though the item type is no longer bookable. Perhaps a separate bug. I did not understand step 8, other than I could see the behavior difference in the item detail page with the bookable option by item type enabled versus not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35906] Add bookable option on itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 ByWater Sandboxes changed: What|Removed |Added Attachment #164585|0 |1 is obsolete|| --- Comment #42 from ByWater Sandboxes --- Created attachment 165437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165437=edit Bug 35906: (follow-up) rebased it Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676 --- Comment #1 from Jan Kissig --- Created attachment 165436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165436=edit BUG 36676 When sending a fee paid message to SIP2 with an unknown patron id it will respond with an empty response followed by dropping the connection to a client. to test on ktd (23.11): a) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 2352900100046 -m fee_paid --fee-type FT --fee-amount 0.01 Output: Trying 'fee_paid' SEND: 3720240423124447FT00USDBV0.01|AO|AA2352900100046|ACterm1| Use of uninitialized value $data in concatenation (.) or string at /usr/share/koha/bin/sip_cli_emulator.pl line 355, chunk 1. READ: b) apply patch c) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 2352900100046 -m fee_paid --fee-type FT --fee-amount 0.01 Output: Trying 'fee_paid' SEND: 3720240423125602FT00USDBV0.01|AO|AA2352900100046|ACterm1| READ: 38N20240423125602AO|AA2352900100046|AFInvalid patron barcode.| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #112 from Nick Clemens --- Created attachment 165435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165435=edit Bug 36120: (QA follow-up) Tidy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #111 from Nick Clemens --- Created attachment 165434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165434=edit Bug 36120: Restore edit Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #110 from Nick Clemens --- Created attachment 165433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165433=edit Bug 36120: (follow-up) Only display locations for bookable items This patch updates the pickup locations picker to only include locations for items that are bookable. We should look at doing this on the API level as it highlights some issues with re-using item holds pickup location rules. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #109 from Nick Clemens --- Created attachment 165432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165432=edit Bug 36120: Ensure pickup location and item can be picked in either order Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #108 from Nick Clemens --- Created attachment 165431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165431=edit Bug 36120: Account for both pickup_location and date selection in items This patch ensures we account for both pickup location and date selections having taken place before an item selection is pondered. We now correctly disable item options given both conditions rather than it being a race between the two. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #107 from Nick Clemens --- Created attachment 165430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165430=edit Bug 36120: Re-enable 'Any item' selectable Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #106 from Nick Clemens --- Created attachment 165429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165429=edit Bug 36120: Unit tests for pickup_locations change This patch adds unit tests for the additional caching of location_items in the pickup_locations method of Koha::Biblio. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #105 from Nick Clemens --- Created attachment 165428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165428=edit Bug 36120: Add unit test for pickup_library relation accessor This patch adds a unit test for the newly introduced pickup_library accessor added to Koha::Booking Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #104 from Nick Clemens --- Created attachment 165427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165427=edit Bug 36120: Schema update Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #103 from Nick Clemens --- Created attachment 165426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165426=edit Bug 36120: Ensure pickup_library_id is NOT NULL This patch updates the database schema to ensure bookings.pickup_library_id is NOT NULL Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #102 from Nick Clemens --- Created attachment 165425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165425=edit Bug 36120: Ensure existing bookings are assigned a pickup library Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer Signed-off-by: Kristi Krueger Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #101 from Nick Clemens --- Created attachment 165424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165424=edit Bug 36120: Add pickup library to bookings list table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer Signed-off-by: Kristi Krueger Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #100 from Nick Clemens --- Created attachment 165423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165423=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer Signed-off-by: Kristi Krueger Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #99 from Nick Clemens --- Created attachment 165422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165422=edit Bug 36120: Add pickup_library support to bookings API Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer Signed-off-by: Kristi Krueger Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #98 from Nick Clemens --- Created attachment 165421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165421=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer Signed-off-by: Kristi Krueger Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #97 from Nick Clemens --- Created attachment 165420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165420=edit Bug 36120: Schema update Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer Signed-off-by: Kristi Krueger Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Nick Clemens changed: What|Removed |Added Attachment #165175|0 |1 is obsolete|| Attachment #165176|0 |1 is obsolete|| Attachment #165177|0 |1 is obsolete|| Attachment #165178|0 |1 is obsolete|| Attachment #165179|0 |1 is obsolete|| Attachment #165180|0 |1 is obsolete|| Attachment #165181|0 |1 is obsolete|| Attachment #165182|0 |1 is obsolete|| Attachment #165183|0 |1 is obsolete|| Attachment #165184|0 |1 is obsolete|| Attachment #165185|0 |1 is obsolete|| Attachment #165186|0 |1 is obsolete|| Attachment #165187|0 |1 is obsolete|| Attachment #165188|0 |1 is obsolete|| Attachment #165214|0 |1 is obsolete|| Attachment #165216|0 |1 is obsolete|| --- Comment #96 from Nick Clemens --- Created attachment 165419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165419=edit Bug 36120: Add pickup_library_id to bookings table Sponsored-by: Cuyahoga County Public Library Signed-off-by: Lisette Scheer Signed-off-by: Kristi Krueger Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #28 from Martin Renvoize --- For bonus points I'm tempted to display a 'Expected language' field for the default notices in the editor to show the output of the highest priority language when more than one is installed. This clarifying to staff what language we're expecting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 Pedro Amorim changed: What|Removed |Added Attachment #164055|0 |1 is obsolete|| --- Comment #16 from Pedro Amorim --- Created attachment 165418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165418=edit Bug 34597: Implementation New can_patron_place_ill_in_opac method to include all rules that need checking to determine if a patron is allowed to place an ILL request on the OPAC or not. Added effective_BlockExpiredPatronOpacActions_contains rule to this new method. Test plan, k-t-d,: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Edit a patron category, visit: /cgi-bin/koha/admin/categories.pl 3) Set 'Placing an ILL request' for the "Block expired patrons" input config 4) Add a new patron of one of the above category, make sure this patron is expired (set an expirydate to the past). 5) Login as that user and visit ILL page in OPAC: /cgi-bin/koha/opac-illrequests.pl 6) Confirm there is no "Create a new request" button 7) Access the create a new request page url directly: /cgi-bin/koha/opac-illrequests.pl?op=add_form=FreeForm 8) Confirm you get a 403 page 9) Set the 'Block expired actions' to "Follow system preference BlockExpiredPatronOpacActions" 10) Test different values of the BlockExpiredPatronOpacActions system preference and confirm the behaviour matches what's configured -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 Pedro Amorim changed: What|Removed |Added Attachment #164054|0 |1 is obsolete|| --- Comment #15 from Pedro Amorim --- Created attachment 165417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165417=edit Bug 34597: Add tests prove t/db_dependent/Koha/Illrequest.t prove t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 Pedro Amorim changed: What|Removed |Added Attachment #164053|0 |1 is obsolete|| --- Comment #14 from Pedro Amorim --- Created attachment 165416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165416=edit Bug 34597: Add 'ill_request' to system preference options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 Pedro Amorim changed: What|Removed |Added Attachment #164052|0 |1 is obsolete|| --- Comment #13 from Pedro Amorim --- Created attachment 165415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165415=edit Bug 34597: Add 'ill_request' to patron category admin page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 Pedro Amorim changed: What|Removed |Added Attachment #165413|0 |1 is obsolete|| --- Comment #19 from Pedro Amorim --- Created attachment 165414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165414=edit Bug 36453: (QA follow-up): Cosmetic fixes This is a squash of several improvements: - Override weird blue color being applied from MultipleSelect when all options from an optgroup are selected; - Fix input width depending on selected value. Now it should always be same width regardless; - Updated the system preference UI wording to reflect new behavior; - Updated UI labels in the patron category edit page to enforce that the actions being selected are "actions to be blocked" - Corrected sysprefs.sql entry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #18 from Pedro Amorim --- Thank you Arthur for testing and your review. I agree with all your comments and I have followed up on the QA follow-up patch. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 --- Comment #17 from Pedro Amorim --- Created attachment 165413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165413=edit Bug 36453: (QA follow-up): Cosmetic fixes This is a squash of several improvements: - Override weird blue color being applied from MultipleSelect when all options from an optgroup are selected; - Fix input width depending on selected value. Now it should always be same width regardless; - Updated the system preference wording to reflect updated behavior; - Updated UI labels in the patron category edit page to enforce that the actions being selected are "actions to be blocked" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize changed: What|Removed |Added Attachment #165404|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed, | |RM_priority | Status|Passed QA |Pushed to main --- Comment #20 from Martin Renvoize --- Thanks Emmi, it's looking good to me.. I've pushed in Katrins absence as RM backup. It'll be great to see the dashboard go green shortly :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |In Discussion --- Comment #4 from Tomás Cohen Arazi --- Putting this here for review/discussion. Feedback is welcome! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 165412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165412=edit Bug 36546: Add a bundled version of the API spec This patch makes the Koha::REST::V1 class use a bundled version of the API spec. For that to happen, this patch also adds: * a `yarn api:bundle` task for generating the `swagger_bundle.yaml` file * the bundle file to `.gitignore` * @redocly/cli to the packages.json dependencies (yarn add @redocly/cli) * `api:bundle` is added to the `yarn build` general command NOTE: A new workflow is introduced by this patch as developers will need to call the `yarn api:bundle` command on each API spec change they make. To test: 1. Have KTD running 2. Verify the API works as usual => SUCCESS: The API just works 3. Apply this patch 4. Run: $ ktd --shell k$ yarn api:bundle 5. Restart plack: k$ koha-plack --restart kohadev ; tail -f /var/log/koha/kohadev/*.log => SUCCESS: The API loads correctly 6. Repeat 2 => SUCCESS: Nothing changed 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com, ||matt.blenkinsop@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- Fixed and working, thanks Tomas. Tests passing and present. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Martin Renvoize changed: What|Removed |Added Attachment #164773|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 165411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165411=edit Bug 36505: (follow-up) Consistent error codes in POST Signed-off-by: Brendan Lawlor Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505
Martin Renvoize changed:
What|Removed |Added
Attachment #164772|0 |1
is obsolete||
--- Comment #13 from Martin Renvoize ---
Created attachment 165410
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165410=edit
Bug 36505: Add support for `extended_attributes` in PUT /patrons/:patron_id
This patch does what the title says. With it, you will be able to PUT on
the already existing endpoint, but also pass:
```json
[ { "type": "THE_TYPE", "value": "a" }, ... ]
```
Bonus: to ease testing I added `x-koha-embed: extended_attributes`
support.
To test:
1. Apply the unit tests
2. Run:
$ ktd --shell
k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: This is not implemented!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Exhaustive testes pass!
5. Sign off :-D
Signed-off-by: Brendan Lawlor
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Martin Renvoize changed: What|Removed |Added Attachment #164771|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 165409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165409=edit Bug 36505: Unit tests Signed-off-by: Brendan Lawlor Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Caroline Cyr La Rose changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||laurence.ra...@biblibre.com ||, michaela.sie...@kit.edu, ||philip@lmscloud.de --- Comment #27 from Caroline Cyr La Rose --- I CC'd a couple of people who I know use/support Koha in other languages. I will also send an email to the French mailing list to get their opinions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Martin Renvoize changed: What|Removed |Added Attachment #164890|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 165408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165408=edit Bug 36295: Space out content blocks in batch record modification This patch adds a float clearing class to a line break in the batch record modification template to fix a spacing issue in Chrome. To test apply the patch and go to Cataloging -> Batch record modification There should be space between the two sections. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Martin Renvoize changed: What|Removed |Added Attachment #164889|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 165407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165407=edit Bug 36295: Space out content blocks in batch record deletion This patch adds a float-clearing line break to the batch record deletion template so that the "Record type" section has visual separation from the record number submission tabs. To test, apply the patch and go to Cataloging -> Batch record deletion. There should be padding between the two sections. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #26 from Martin Renvoize --- Can I get some real-life users to comment on my thoughts regarding point three in the above comment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #25 from Martin Renvoize --- Right.. we can drop the TMP fix patch once those have been corrected upstream in main. I also think the Restore final fallback isn't really required but I did it whilst I was in here as Jonathan mentioned it. The final patch is the important one as it brings us a step closer to the end goal by getting the tests working without having to manually install a translation. However, I'm now strongly of the opinion we should not be doing the interface level check and instead use the highest priority language in the system preferences as the 'default'. My understanding of how 'default' is used is that the 'default' notice is generally written in the primary language of the system and so it would match the top pick for interface language selection and possible not match the selected interface language of the moment. Use cases: 1) US English only. Default == English + Includes should be English 2) Single translation only (French Canadian). Default == French Canadian + Includes should also be French Canadian. 3) Multiple languages. Default template written in French Canadian, the Include should also use French Canadian (even if the staff user clicking to print has switched to Italian) otherwise we have the main notice in French Candian with the Include parts in Itelian. Right now. case 3 fails. I also think we could re-arrange the tests a bit to clean up.. I think we could/should be testing Template selection _+ include selection in the same places.. i.e each time we check the 'title' we would also check the 'content' to ensure they match consistently.. rather than the current check of template selection followed by a section for include selection checking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36053] Replacement prices not populating when supplied from MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize changed: What|Removed |Added Attachment #165384|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #24 from Martin Renvoize --- Created attachment 165406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165406=edit Bug 33237: (QA follow-up) Clarify tests and Mock This patch tries to clarify the tests a little and expand their coverage whilst also adding some defualt translated includes to the test area and mocking the config to allow the tests to run without installing translations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize changed: What|Removed |Added Attachment #165383|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 165405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165405=edit Bug 33237: (follow-up) Restore final fallback This restores the final fallback to 'en' as mentioned by Jonathan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize changed: What|Removed |Added Attachment #165382|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 165404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165404=edit Bug 33237: TMP Fix for Budget test failing in main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33134] Add some missing languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
