subject:"\[Koha\-bugs\] \[Bug 17855\] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha"

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-03-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #169 from Alex Buckley  ---
I have removed the web installer improvements that require the SQL files to be
moved to the default directory, meaning the two patches I have attached to this
bug report do not contain a web installer with a basic and advanced setup mode. 

Therefore these patches simply contain minor web installer UI improvements
(which do not require the movement of SQL files to a default directory) in
addition to the onboarding tool, and so the onboarding tool can be tested and
pushed without the need for bug 18039 to pass QA. 

The onboarding tool has been tested multiple times in this bug report in the
past.

I have tested these two patches by applying them to a clean branch and then
running through the installer and onboarding tool and everything works as
outlined in (https://koha-community.org/manual/installation/html/index.html)
except there is no basic and advanced setup modes in the web installer because
like I said I removed that functionality deliberately to get the onboarding
tool through.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-03-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #168 from Alex Buckley  ---
Created attachment 61668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61668=edit
Bug 17855 - Reverted back to original step 3 in the web installer so there is
no basic and advanced setup mode and consequently no need for SQL files to be
moved to a 'default' directory for all languages.

Onboarding tool and the rest of the web installer still exists in this
commit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-03-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #167 from Alex Buckley  ---
Created attachment 61667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61667=edit
Bug 17855: Onboarding tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-03-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #60092|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-03-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||18346


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346
[Bug 18346] Improved web installer containing basic and advanced setup modes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-03-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks|18060   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060
[Bug 18060] Add onboarding functionality to guide users through setting up
labels for the first time
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #166 from Alex Buckley  ---
(In reply to Jonathan Druart in comment 165)

The thing that concerns me regarding having to test the combination of this bug
with bugs 18039 and 17942 for all languages in order to get the onboarding tool
into Koha in one go is:

* The differences in the web installer when run in different languages (e.g. No
UNIMARC marc flavour available when running web installer in de-DE), are going
to significantly hold up the process of getting the onboarding tool
functionality out to the users due to complex troubleshooting to determine the
reason for why the web installer is displaying different options when run in
different languages and then the associated signoff process.

Is it therefore possible for us to try to get the combination of these three
bugs signed off by language singularly (starting with English) to split the
problem into manageable chunks that will get through the signoff and QA
process?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59856|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59857|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59826|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59840|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59712|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59711|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59710|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59279|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59281|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59280|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #165 from Jonathan Druart  
---
(In reply to Alex Buckley from comment #164)
> >If you agree with the plan, we can go with try to get 18039 first, then this 
> >>one.
> >But I have no idea how we can test 18039 widely and make sure it will not 
> >>introduce any regressions.
> 
> To clarify do you mean try to get 18039 through testing and QA before this
> bug?   

Yes definitely. We have to push a feature that will work for any languages, not
only for English.

> >At the beginning of the onboarding tool, if I already have patron categories 
> >and libraries, the steps 1 and 2 are skipped.
> >But it's a bit weird, we do not understand what is going on.
> >IIRC when I tested earlier, these steps contain message like "data already 
> >>exists, click on next".
> 
> Yes I changed the way the steps for creating libraries, patron categories
> and item types were displayed if the user had installed sample libraries,
> patron categories and item types in the web installer due to your request in
> comment 70) so now the user is redirected to the next step that they do need
> to complete.

Ok, we can improve that later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #164 from Alex Buckley  ---
(in reply to Jonathan Druart in comment 161)

>To make thing clear: I did not want to obsolete the other patches because of 
>>the error, and I was a bit tired yesterday and the last patch does not 
>contain >any commit message.

Now that that error has kindly been resolved by Katrin and Liz's work on bug
17942 I will continue to test these three combined bug patches (17855, 18039
and 17942) and if successful I will obsolete the 10 previous patches for this
bug and amend the final commit message of this bug.

>If you agree with the plan, we can go with try to get 18039 first, then this 
>>one.
>But I have no idea how we can test 18039 widely and make sure it will not 
>>introduce any regressions.

To clarify do you mean try to get 18039 through testing and QA before this bug? 

>At the beginning of the onboarding tool, if I already have patron categories 
>and libraries, the steps 1 and 2 are skipped.
>But it's a bit weird, we do not understand what is going on.
>IIRC when I tested earlier, these steps contain message like "data already 
>>exists, click on next".

Yes I changed the way the steps for creating libraries, patron categories and
item types were displayed if the user had installed sample libraries, patron
categories and item types in the web installer due to your request in comment
70) so now the user is redirected to the next step that they do need to
complete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #163 from Jonathan Druart  
---
With fr-FR, I do not see the "select all data" link on "Selecting Default
Settings"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #162 from Jonathan Druart  
---
At the beginning of the onboarding tool, if I already have patron categories
and libraries, the steps 1 and 2 are skipped.
But it's a bit weird, we do not understand what is going on.
IIRC when I tested earlier, these steps contain message like "data already
exists, click on next".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #161 from Jonathan Druart  
---
(In reply to Alex Buckley from comment #159)
> The installer-strings.inc file is created in bug 17942 and so there must be
> a bad conflict in the merge to make the most recent patch of 17855. So I
> would suggest trying the merge again.

Silly me, I think I understood.
I certainly apply patches from 17942, then generated the translated languages.
Then back on this one but forgot to regenerate the templates.

To make thing clear: I did not want to obsolete the other patches because of
the error, and I was a bit tired yesterday and the last patch does not contain
any commit message.

If you agree with the plan, we can go with try to get 18039 first, then this
one.
But I have no idea how we can test 18039 widely and make sure it will not
introduce any regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #160 from Liz Rea  ---
Katrin is kindly providing a resolved-by-her patch on Owen's bug. She's awesome
and stuff.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #159 from Alex Buckley  ---
(in reply to Jonathan Druart in comment 156)

Liz and I discovered the source of the problem after looking at the patches in
bug 17855 and 18039 and we saw that installer-strings.inc does not exist in
either. 

The installer-strings.inc file is created in bug 17942 and so there must be a
bad conflict in the merge to make the most recent patch of 17855. So I would
suggest trying the merge again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #158 from Liz Rea  ---
Hi Jonathan,

I haven't been able to make mine error in your way either. Here's what I did:

Applied the patches, 17855, your squashed patch, and then 18039 - all went ok.

Installed fr-FR in my developer install: 
sudo env KOHA_CONF=/etc/koha/sites/library/koha-conf.xml
PERL5LIB=/home/liz/koha-src/koha/ perl translate install fr-FR
(I also installed de-DE, for funsies, but I haven't run through the installer
in de-DE)

Dropped my koha database
Created a new db in it's place

Ran through the installer in fr-FR, and made it all the way through to logging
in as our newly created super librarian. 

As a note, there were lots of "C4::Carp redefined" warnings in the intranet
log, but they didn't seem to cause any noticeable problem.

One thing I did note was that the fr-FR DB templates have some additional
mandatory options re: UNIMARC, and the default MARC flavour is the 3rd one in
the list. That might not be right but I think not a problem for this bug to
fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #157 from Alex Buckley  ---
(in reply to Jonathan Druart in comment 155)
At this stage yes that does all make sense thank you.

(in reply to Jonathan Druart in comment 156)
Interestingly I cannot seem to replicate the error you are getting. I am not
getting that error displayed in the web browser or the intranet-error.log file. 

Is the error appearing when running the web installer/onboarding tool in a
particular language?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #156 from Jonathan Druart  
---
Note sure what's is going on, I get 
  Template process failed: file error - installer-strings.inc: not found at
/home/vagrant/kohaclone/C4/Templates.pm line 121.

on /installer/onboarding.pl?step=2

I do not manage to know where it comes from.

(With and without my changes)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #155 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #154)
> Created attachment 60092 [details] [review]
> Bug 17855: Onboarding tool

So... I hope I did not break everything.
I extracted the installer files from this patchset and move them to bug 18039.
Then I have squashed all the patches together and here is the resulting
squashed patch. Please apply it alone!

I have tried to move the installer files for the translated languages. Take a
look at bug 18039.
That sounds a quite big work and I am not confident with the patchset, we will
need to test it deeply.

So the plan would be to
1/ Apply patches from 18039
2/ Apply the squashed patch
3/ Test the different languages (how to make sure nothing has been missed??)
4/ Pushed everything altogether

Does that make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #154 from Jonathan Druart  
---
Created attachment 60092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60092=edit
Bug 17855: Onboarding tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|18039   |
 Depends on||18039


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039
[Bug 18039] Move the mandatory and optional files for non-english languages
into 'default' directory so bug 17855 permits use of other languages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #153 from Jonathan Druart  
---
I am sorry but this patchset can go without bug 18039.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||18060


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060
[Bug 18060] Add onboarding functionality to guide users through setting up
labels for the first time
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||18059


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18059
[Bug 18059] Add further explanation of the steps in the onboarding tool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks|18002   |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002
[Bug 18002] Add functionality to create  a vendor and budget in the onboarding
tool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59842|0   |1
is obsolete||

--- Comment #152 from Alex Buckley  ---
Created attachment 59857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59857=edit
Bug 17855: Followup silence a warning when there are no imported patrons.

Signed-off-by: Mark Tompsett 
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59841|0   |1
is obsolete||

--- Comment #151 from Alex Buckley  ---
Created attachment 59856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59856=edit
Bug 17855: Follow up on more trimming

Still needed to remove some libraries to address point 3 in comment #133.

Signed-off-by: Mark Tompsett 
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #150 from M. Tompsett  ---
Created attachment 59842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59842=edit
Bug 17855: Followup silence a warning when there are no imported patrons.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59830|0   |1
is obsolete||

--- Comment #148 from M. Tompsett  ---
Created attachment 59840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59840=edit
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Tets plan: Same as outlined in previous comments:
Go to and go through the web installer and onboarding tool:
https://koha-community.org/manual/installation/html/

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #149 from M. Tompsett  ---
Created attachment 59841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59841=edit
Bug 17855: Follow up on more trimming

Still needed to remove some libraries to address point 3 in comment #133.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #147 from M. Tompsett  ---
Comment on attachment 59830
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Review of attachment 59830:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=59830)
-

Found more point 3 trimming needed.

::: installer/onboarding.pl
@@ +27,1 @@
>  use C4::Koha;

Digest::MD5, Encoding and C4::Koha don't need to be here. :(

@@ +30,2 @@
>  use Koha::Patrons;
>  use Koha::Items;

Koha::Items is not necessary either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #146 from M. Tompsett  ---
Comment on attachment 59830
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Review of attachment 59830:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=59830)
-

Quick eyeball. If it behaves as before, I'll sign off.

::: installer/onboarding.pl
@@ +2,4 @@
>  
>  # This file is part of Koha.
>  #
> +# Copyright (C) 2017 Catalyst IT

Addresses point 4 in comment #133.

@@ -30,5 @@
> -use C4::Members::Attributes;
> -use C4::Members::AttributeTypes;
> -use C4::Log;
> -use Koha::AuthorisedValues;
> -use Koha::Patron::Debarments;

Addresses point 3 in comment #133.

@@ -39,5 @@
>  use Koha::DateUtils;
>  use Koha::Patron::Categories;
>  use Koha::Patron::Category;
> -use Koha::Patron::HouseboundRole;
> -use Koha::Patron::HouseboundRoles;

Addresses point 3 in comment #133.

@@ -44,4 @@
>  use Koha::ItemTypes;
>  use Koha::IssuingRule;
>  use Koha::IssuingRules;
> -use Data::Dumper;

Addresses point 3 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
@@ -42,5 @@
>   href="/cgi-bin/koha/admin/admin-home.pl">Administration
>  [% END %]
>  About Koha
> -Summary
> -

Removal deals with point 7-9 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
@@ +5,5 @@
>   Add a patron category
>  [% INCLUDE 'installer-doc-head-close.inc' %]
>  [% INCLUDE 'calendar.inc' %]
> +[% INCLUDE 'js_includes.inc' %]
> +[% INCLUDE 'datatables.inc' %]

Good simplification to address point 5 in comment #133.

@@ +20,4 @@
>} else {
>   return true;
>}
> +}, MSG_ONE_ENROLLMENTPERIOD

Because of using included javascripts, variable name changed. Related to point
5 in comment #133.

@@ +25,2 @@
>  
> +

Addresses point 5 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ +7,4 @@
>  [% INCLUDE 'installer-doc-head-close.inc' %]
>  [% INCLUDE 'calendar.inc' %]
>  [% INCLUDE 'datatables.inc' %]
> +[% INCLUDE 'js_includes.inc' %]

Point 6 in comment #133.

@@ -21,5 @@
> -
> -
>

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #145 from Alex Buckley  ---
Created attachment 59830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830=edit
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Tets plan: Same as outlined in previous comments:
Go to and go through the web installer and onboarding tool:
https://koha-community.org/manual/installation/html/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59742|0   |1
is obsolete||

--- Comment #144 from Alex Buckley  ---
Created attachment 59826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59826=edit
Bug 17855: Follow-up on broken xt test

Apologies for missing that. Here is a patch for point 2 in
comment #133.

TEST PLAN
-
1) apply all except this patch
2) prove xt
   -- a failure
3) apply this patch
4) prove xt
   -- no failures
5) prove t
   -- only prices fails on master, and is unrelated to this patch.
6) run koha qa test tools

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #143 from Alex Buckley  ---
In the commit I have just finished (soon to be attached to bug 17855) the
following points have been addressed:

1/ I have made a new bug 18039 (assigned to myself but if someone else wants to
take it on they are more than welcome to). This bug requires the movement of
the mandatory and optional files of other languages into default directories.
Because this is a complex job it is going to take significant testing and so I
have placed the work for this in a new bug report to keep bug 17855 moving
forwards.


2/ M.Tompsetts patch has addressed this issue as the xt test now returns a
successful result of:
xt/sample_notices.t . ok
xt/single_quotes.t .. ok   
xt/tt_valid.t ... ok   
xt/verify-debian-docbook.t .. ok
xt/yaml_valid.t . ok 
All tests successful.
Files=5, Tests=90,  5 wallclock secs ( 0.05 usr  0.00 sys +  4.19 cusr  0.06
csys =  4.30 CPU)
Result: PASS


3/ I assume you mean the use pragmas at the top of the onboarding tool. If this
is the case in my most recent commit I have removed 7 more unused use pragmas.

4. I've fixed the copyright notice

5. I now include the js from categories.js, removing the duplicate js code in
onboardingstep2.tt except for the assignment of the message variables and the
enrollment_period function which is different for the onboarding tool to that
in the categories.js

6. I've fixed the indentation of js in onboardingstep3.tt. 
Due to my password_match js function being slightly different to the one in
members.js I have left that in onboardingstep3.tt additionally I have left the
form validation js code in onboardingstep3.tt as there are different fields to
validate than the memberentrygen.tt. 
Making the js form validation in members.js work for both the
onboardingstep3.tt and memberentrygen.tt can be done in a later bug as a lot of
testing would be required.

7. I have now removed summary.tt which can be added in a later bug 

8. Removed summary.pl same reason as above

9. Removed summary info same reason as above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||18039


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039
[Bug 18039] Move the mandatory and optional files for non-english languages
into 'default' directory so bug 17855 permits use of other languages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #142 from Owen Leonard  ---
(In reply to Alex Buckley from comment #138)

> Re: point 9: What is the final decision on summary info. To get this signed
> off and through QA are both of you happy for me to remove summary.pl and
> summary.tt. And they can be added in a separate bug?

I think this is the right thing to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #141 from Alex Buckley  ---
(in reply to M.Tompsett in comment 133 and M.Tompsett in comment 140)

Yes thanks, I also asked elsewhere.

I am currently working through the issues in comment 133

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #140 from M. Tompsett  ---
(In reply to Alex Buckley from comment #139)
> (in reply to Jonathan Druart and M.Tompsett in comment 133, 136 and 137 and
> 17855)
> 
> As I am still learning Koha can I please have a more specific explanation of
> the issue(s) which you addressed in points 1 and 2?
> 
> And possible solutions thereof

Non-English template files are generated from the English ones. When you moved
the English ones, did you check (sorry, I forgot to check) if you could
generate another language and run through the onboarding tool? This is not
necessarily related, but I thought I'd mention it. Too often, English speakers
(myself included) fail to test other languages as well. In fact, we need to
test for all the languages that we do have.

Also, you've modified the mandatory/optional directory structure and locations
of the English files. It is probably a good idea to keep the structures aligned
across all languages. Again, we'll need to test for all the languages that we
do have.

My follow up on the broken xt test makes the broken test pass. However, any
changes as triggered above, may required further changes to the same test. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #139 from Alex Buckley  ---
(in reply to Jonathan Druart and M.Tompsett in comment 133, 136 and 137 and
17855)

As I am still learning Koha can I please have a more specific explanation of
the issue(s) which you addressed in points 1 and 2?

And possible solutions thereof

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #138 from Alex Buckley  ---
(in reply to Jonathan Druart and Owen Leonard in comment 133 and 134)

Just to clarify a few of your points:

Re: point 5: "5/ You copied some existing javascript functions to
onboardingstep2.tt. Do not
duplicate existing code." 
Do you want me to remove the JavaScript functions and or will fixing the
indentation be sufficient to pass QA?

Re: point 9: What is the final decision on summary info. To get this signed off
and through QA are both of you happy for me to remove summary.pl and
summary.tt. And they can be added in a separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #137 from M. Tompsett  ---
(In reply to M. Tompsett from comment #136)
> Created attachment 59742 [details] [review]
> Bug 17855: Follow-up on broken xt test
> 
> Apologies for missing that. Here is a patch for point 2 in
> comment #133.

Though, this will need to be modified further to address point 1 in comment
#133.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #136 from M. Tompsett  ---
Created attachment 59742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59742=edit
Bug 17855: Follow-up on broken xt test

Apologies for missing that. Here is a patch for point 2 in
comment #133.

TEST PLAN
-
1) apply all except this patch
2) prove xt
   -- a failure
3) apply this patch
4) prove xt
   -- no failures
5) prove t
   -- only prices fails on master, and is unrelated to this patch.
6) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #135 from M. Tompsett  ---
(In reply to Owen Leonard from comment #134)
> I wonder if we could add a persistent shortcut of some kind to the
> global help system? I suggest this feature be discussed in a separate bug.

Yes, points 7-9 are valid issues, but probably removing summary from this, and
discussing perhaps a simplified basics help page on another bug might be in
order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #134 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #133)

> 9/ Is this Summary info really useful? To me it looks like it should be
> moved to the help part. I am not sure it worth a new entry in the "More"
> menu.

I agree. I wonder if we could add a persistent shortcut of some kind to the
global help system? I suggest this feature be discussed in a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #133 from Jonathan Druart  
---
Alex,

Few more remarks:
1/ There is something wrong with the sql sample files for translated languages.
The mandatory and optional files for the other languages have to be moved to
the default directory as well.
We will have to be meticulous to avoid regressions.

2/ You should also adapt xt/sample_notices.t, tests are failing after your
patches

3/ Could you double check the module you use in installer/onboarding.pl, some
are uselessly used.

4/ Double check the copyright lines you have added (+# Copyright (C) YEAR 
YOURNAME-OR-YOUREMPLOYER)

5/ You copied some existing javascript functions to onboardingstep2.tt. Do not
duplicate existing code.
You should also have a look at this template, the indentation in the javascript
portion is weird.

6/ Same as 5 for onboardingstep3.tt

7/ summary.tt - you should not use  tag, our translation tool does not
handle sentences when they are split by html tag. That make the job really hard
(and sometimes impossible) for translators.

8/ Copyright of summary.pl sounds totally wrong.

9/ Is this Summary info really useful? To me it looks like it should be moved
to the help part. I am not sure it worth a new entry in the "More" menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #132 from Alex Buckley  ---
*** Bug 17955 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59708|0   |1
is obsolete||

--- Comment #131 from M. Tompsett  ---
Created attachment 59712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59712=edit
Bug 17855: Follow up - Fix onshelfholds

Signed-off-by: Alex Buckley 
Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59709|0   |1
is obsolete||

--- Comment #130 from M. Tompsett  ---
Created attachment 59711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59711=edit
Bug 17855 - Follow up: code clean up

Removed unnecessary use pragmas in the onboarding.pl script

Replaced all sql code in onboarding.pl script with DBIx

Changed the logic of the onshelfholds if statement in onboarding.pl

Signed-off-by: Alex Buckley 

NOTE: Initially came from 17955
Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59628|0   |1
is obsolete||

--- Comment #129 from M. Tompsett  ---
Created attachment 59710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59710=edit
Bug 17855 - Implemented a retrieval of patron category
enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron
accounts created with the onboarding tool.

Set address and city variables to "" in onboarding.pl

Fixed the creation/filling of the $firstpassword, $secondpassword and
$op variables in the onboarding.pl so they don't cause uninitialised
variable errors.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59706|0   |1
is obsolete||

--- Comment #128 from Alex Buckley  ---
Created attachment 59709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59709=edit
Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script

Replaced all sql code in onboarding.pl script with DBIx

Changed the logic of the onshelfholds if statement in onboarding.pl

https://bugs.koha-community.org/show_bug.cgi?id=17855
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59703|0   |1
is obsolete||

--- Comment #127 from Alex Buckley  ---
Created attachment 59708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59708=edit
Bug 17855: Follow up - Fix onshelfholds

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59707|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #126 from Alex Buckley  ---
Created attachment 59707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59707=edit
bug 17855 - Updated web installer finished

The onboarding tool has been implemented and integrated with the updated
web installer. The onboarding tool has the following functionality:
* After the user has finished the web installer they are automatically
redirected to the onboarding tool with no authentication in between
required
* Ability to create library, patron category, patron (set with
superlibrarian priviliages), item type and circulation rule.
* If the uaser installed sample libraries, patron categories and/or item
types then the step to create one in the onboarding tool will be skipped
and a skipping message will be displayed.
*HTML regxes on all text input fields in all forms in the onboarding
tool this prevents the user from writing in special characters
*Working date picker on the patron category form

Have moved all data values from mandatory to default.
Now all default data values are displayed with a bulletpoint rather than
a selectable checkbox stopping users from unticking neccisary data
values

Test plan:
1. Go through the web installer and onboarding tool with the same steps
as outlined in this below guide and check that the functionality
outlined in the guide exists in the patch:
https://koha-community.org/manual/installation/html/

 This is a combination of 67 commits.
Initial 3 HTML screens of the onboarding tool and
the perl onboarding.pl script

Note: The advanced setup option has not yet been
implemented, so what you will see is just the basic setup.

Altered web installer

Moved files from optional to mandatory. Edited
MARC screen so that MARC21 is selected by default.

Changed mandatory to default for MARC values

Changed a few file name descriptions to reduce
spacing in installer step 3 screen.

Changed the radiobuttons to bulletpoints for default settings

removed = sign

Fixed bug in installer where a loop was created if
you're database structure needed to be updated.
Redirected this to the marcflavour screen instead
of logging straight into Koha and skipping over
the basic configuration steps.

Changed the bulletpoints to disabled checkboxes
which are checked by default

Backup of step3.tt

Successfully working insertion of the default
options which are shown as bulletpoints

Removed test text

Working insertion of default and optional options

Correctly selected default marc flavour of marc21

NOTE: Mark Tompsett merged several commits

- Removed html regex on patron password fields. Ran perltidy to
indent and space code appropriately. Ran git bz configuration
commands to remove whitespace. Removed unnecissary uses in
the summary.pl script

- Made arrows in onboarding tool pages
  -> for consistency. Additionally removed the 'OR'

- Added the use CGI qw ( -utf8 );

- Removed the second path to creating a library, patron
category, patron, item type, and circulation rule. In onboarding
.tt files and summary.tt

- Fixed typo in summary.tt

- Made consistent single space before and after -> in all
onboarding .tt and summary.tt files.

- Made single  tag before path to create library, patron
category, item type, and circulation rule in the onboarding
.tt files (patron does not need this as its layout is slightly
different)

- Changed button and link names in web installer and onboarding
tool

- Implemented Javascript password check to determine if the values
in the 'password' and 'confirm password' fields are consistent.

If passwords are not consistent a message informing the user
is displayed and they only have to change the password values
rather than re-fill out the whole form.

- Fixed the errors from the koha qa test

- Removed use:C4/Auth from the onboarding.pl

- Moved the "select all options" button down to just above
the selectable options in the basic setup, and positioned at
the top of the page for the advanced setup.

- Removed the "there is nothing to do because the sample data
is already installed" page so if the user has install sample
data in the web installer then the step to create that object
in the onboarding tool is skipped altogether.

- Removed the "We're just going to setup a few more things"
page

- Changed the title of the 'Create patron page'

- Added clarifying information to the "Add a patron category"
page

- Added clarifying information to the "Create item type" page

- Fixed the capitalization in the onboarding tool

- Removed the BackupStep3.tt file which was un-used

- Changed the redirect time displayed to user in step3.tt to 10

- Changed the cardnumber on the create patron administrator
page so that it is only populated when the user installed
sample patrons. Also changed the regex so that it allows
letters and number.

- Used the HTMl validator to identify errors in the template
and have corrected all

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59705|0   |1
is obsolete||

--- Comment #125 from Alex Buckley  ---
Created attachment 59706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59706=edit
Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script

Replaced all sql code in onboarding.pl script with DBIx

Changed the logic of the onshelfholds if statement in onboarding.pl

https://bugs.koha-community.org/show_bug.cgi?id=17855
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #124 from Alex Buckley  ---
Created attachment 59705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59705=edit
Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script

Replaced all sql code in onboarding.pl script with DBIx

Changed the logic of the onshelfholds if statement in onboarding.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #123 from M. Tompsett  ---
Created attachment 59703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59703=edit
Bug 17855: Follow up - Fix onshelfholds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #122 from M. Tompsett  ---
If you want to have this signed off, I don't want to see:

Software error:

DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value:
'anyunavailable' for column 'onshelfholds' at row 1 at
/home/mtompset/kohaclone/Koha/Object.pm line 120
For help, please send mail to the webmaster (webmaster@ubuntu), giving this
error message and the time and date of the error.

When I attempt a Xenial install.
The other possibility is completely remove onshelfholds and just default it to
something.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #121 from Alex Buckley  ---
(in reply to M.Tompsett in comment 120)

I believe we are starting to scope creep. The purpose of the create circulation
rule is simply to display the library, patron category and item type the user
created/installed (in drop-down boxes) and then the user can choose 'All' or a
specific value and the circulation rule is assigned accordingly. Thus at
present the create circulation rule step does what it's supposed to do
successfully. 

Regarding the onshelfholds logic I fixed it up in the bug 17955 (which needs
signoff), because some of the sql queries were inserting into the onshelfholds
column of the default_branch_circ_rules table (see below) (there is no such
column in this table) so I changed the insert to input values into the
issuingrules table. 

628 my $sth_insert = $dbh->prepare(
629 "INSERT INTO default_branch_circ_rules
630 (branchcode, onshelfholds)
631 VALUES (?, ?)"
632 );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #120 from M. Tompsett  ---
(In reply to Alex Buckley from comment #117)
> Regarding the onshelfholds logic, I suggest we leave that to be fixed in bug
> 17955 which I am also currently working on as I am removing the SQL code
> which forms a big portion of the onshelfholds code in the onboarding.pl
> script and reworking it to use DBIx.

I'm wondering if the wrong thing is being accessed.
I was reading updatedatabase.pl around 3.19.00.017's update.
The drop down list you give makes me think of the variable opac items holds.
I'd personally prefer the functionality clean up (does it actually generate
valid values to go in the right place) here. You can do the code clean up
(DBIx, making the gui pretty, etc) there.

Sorry, I just got my xenial up again to retest and ran out of time. I'll aim
for 12 hours from now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #119 from M. Tompsett  ---
Comment on attachment 59628
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59628
Bug 17855 - Implemented a retrieval of patron category
enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron
accounts created with the onboarding tool.

Review of attachment 59628:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=59628)
-

This is my quick eyeball. I'll test later.

::: installer/onboarding.pl
@@ +92,4 @@
>  );
>  
>  #Store the value of the template input name='op' in the variable $op so we 
> can check if the user has pressed the button with the name="op" and 
> value="finish" meaning the user has finished the onboarding tool.
> +my $op = $input->param('op') || "";

For future reference q{} is perlcritic level 1 friendly. Single quotes are also
more perlcritic friendly.

@@ +282,5 @@
>  $template->param( 'categories' => $categories, );
>  
> +
> +
> +

Hmmm... excess space? I'm not going to fail over this. I'll let QA fix it.

@@ +387,5 @@
> +$newdata{city}   = "";
> +
> +#Determine the dateexpiry of the patron based on the patron category it is 
> created from
> +my $patron_category = Koha::Patron::Categories->find( 
> $newdata{categorycode} );
> +$newdata{dateexpiry} = $patron_category->get_expiry_date( 
> $newdata{dateenrolled} );

It's so pretty!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #118 from Alex Buckley  ---
Created attachment 59628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59628=edit
Bug 17855 - Implemented a retrieval of patron category
enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron
accounts created with the onboarding tool.

Set address and city variables to "" in onboarding.pl

Fixed the creation/filling of the $firstpassword, $secondpassword and
$op variables in the onboarding.pl so they don't cause uninitialised
variable errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #117 from Alex Buckley  ---
(In reply to M.Tompsett in comment 116)

Yes I've checked and the dateexpiry is based on the patron category and so I am
currently working on retrieving the selected patron category enrolement date to
be used as the value for the dateexpiry variable.

In the commit I am working on currently I have set the address and city to
blank values- so that is that issue fixed. 

Regarding the onshelfholds logic, I suggest we leave that to be fixed in bug
17955 which I am also currently working on as I am removing the SQL code which
forms a big portion of the onshelfholds code in the onboarding.pl script and
reworking it to use DBIx.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #116 from M. Tompsett  ---
(In reply to Alex Buckley from comment #115)
> (in reply to M.Tompsett in comments 113 and 114)
> 
> To fix the dateexpiry issue I can simply remove the dateexpiry altogether
> from the onboarding.pl script, because in the database it is set to null by
> default.

But shouldn't it be set based on the patron category? I didn't check, but I
think the patron category would determine what the date expiry should be.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #115 from Alex Buckley  ---
(in reply to M.Tompsett in comments 113 and 114)

To fix the dateexpiry issue I can simply remove the dateexpiry altogether from
the onboarding.pl script, because in the database it is set to null by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #114 from M. Tompsett  ---
Also missing: address and city need to default to something other than undef
(onboarding.pl line 378ish -- see lack of address and city). Adding blank
values should be good enough.

Also questionable: onshelfholds logic. The schema says bit, but "yes" and the
other possible string values are not bit values. I hacked a !(!( blah )) to get
it to keep running, but that's the wrong solution.

All problems are highlighted when testing on Xenial KohaDevBox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #113 from M. Tompsett  ---
Comment on attachment 59279
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59279
[SIGNED-OFF] bug 17855 - Updated web installer finished

Review of attachment 59279:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=59279)
-

Sorry I didn't catch this the first time.

::: installer/onboarding.pl
@@ +381,5 @@
> +$newdata{categorycode}   = $input->param('categorycode_entry');
> +$newdata{userid} = $input->param('userid');
> +$newdata{password}   = $input->param('password');
> +$newdata{password2}  = $input->param('password2');
> +$newdata{dateexpiry} = '12/10/2016';

No no no! I was trying to test under Xenial Kohadevbox, and it blew up!
"DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '12/10/2016'
for column 'dateexpiry' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line
120"
Dates that will be used directly with SQL queries need to be -MM-DD.
Plus hard coded?! YUCK!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||18002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002
[Bug 18002] Add functionality to create  a vendor and budget in the onboarding
tool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||17956


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956
[Bug 17956] Provide additional functionality in the onboarding tool through
configuring z-targets, and providing information on setting up SIP and LDAP
services
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||17955


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955
[Bug 17955] Remove the sql code and unnecessary use pragmas from the
onboarding.pl script
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||17954


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954
[Bug 17954] Remove the sql code from the smart-rules.pl administrative script
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #112 from M. Tompsett  ---
I tested this in conjunction with bug 17942. There are only a couple things on
17942 holding me back from signing off on that too.

Make sure to test by selecting but all sample data and not selecting it, so as
to trigger the onboarding steps or to skip them nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59051|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59140|0   |1
is obsolete||
  Attachment #59141|0   |1
is obsolete||
  Attachment #59174|0   |1
is obsolete||
  Attachment #59188|0   |1
is obsolete||

--- Comment #111 from M. Tompsett  ---
Created attachment 59281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59281=edit
[SIGNED-OFF] Bug 17855 - Other followups

- Removed the html regex from the cardnumber field in the
'Create patron administrator' page of the onboarding tool. Added
'|html' into the the value attribute of the cardnumber input
field to filter the inputted cardnumber.

So now the same level of validation exists for validating the
inputted cardnumber in the staff interface and the onboarding
tool.

- Removed the unnecessary javascript cardnumber
validation code from onboardingstep3.tt

- Removed HTML regexes from all fields on all screens
of onboarding tool except branchcode, patron category code
and item type code. Also ensured these three remaining regexes
are all {1,10} for length as they are all required.

- Added |html and added in input title attribute to
input fields where it existed previously

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59277|0   |1
is obsolete||

--- Comment #109 from M. Tompsett  ---
Created attachment 59279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59279=edit
[SIGNED-OFF] bug 17855 - Updated web installer finished

The onboarding tool has been implemented and integrated with the updated
web installer. The onboarding tool has the following functionality:
* After the user has finished the web installer they are automatically
redirected to the onboarding tool with no authentication in between
required
* Ability to create library, patron category, patron (set with
superlibrarian priviliages), item type and circulation rule.
* If the uaser installed sample libraries, patron categories and/or item
types then the step to create one in the onboarding tool will be skipped
and a skipping message will be displayed.
*HTML regxes on all text input fields in all forms in the onboarding
tool this prevents the user from writing in special characters
*Working date picker on the patron category form

Have moved all data values from mandatory to default.
Now all default data values are displayed with a bulletpoint rather than
a selectable checkbox stopping users from unticking neccisary data
values

Test plan:
1. Go through the web installer and onboarding tool with the same steps
as outlined in this below guide and check that the functionality
outlined in the guide exists in the patch:
https://koha-community.org/manual/installation/html/

 This is a combination of 67 commits.
Initial 3 HTML screens of the onboarding tool and
the perl onboarding.pl script

Note: The advanced setup option has not yet been
implemented, so what you will see is just the basic setup.

Altered web installer

Moved files from optional to mandatory. Edited
MARC screen so that MARC21 is selected by default.

Changed mandatory to default for MARC values

Changed a few file name descriptions to reduce
spacing in installer step 3 screen.

Changed the radiobuttons to bulletpoints for default settings

removed = sign

Fixed bug in installer where a loop was created if
you're database structure needed to be updated.
Redirected this to the marcflavour screen instead
of logging straight into Koha and skipping over
the basic configuration steps.

Changed the bulletpoints to disabled checkboxes
which are checked by default

Backup of step3.tt

Successfully working insertion of the default
options which are shown as bulletpoints

Removed test text

Working insertion of default and optional options

Correctly selected default marc flavour of marc21

NOTE: Mark Tompsett merged several commits

- Removed html regex on patron password fields. Ran perltidy to
indent and space code appropriately. Ran git bz configuration
commands to remove whitespace. Removed unnecissary uses in
the summary.pl script

- Made arrows in onboarding tool pages
  -> for consistency. Additionally removed the 'OR'

- Added the use CGI qw ( -utf8 );

- Removed the second path to creating a library, patron
category, patron, item type, and circulation rule. In onboarding
.tt files and summary.tt

- Fixed typo in summary.tt

- Made consistent single space before and after -> in all
onboarding .tt and summary.tt files.

- Made single  tag before path to create library, patron
category, item type, and circulation rule in the onboarding
.tt files (patron does not need this as its layout is slightly
different)

- Changed button and link names in web installer and onboarding
tool

- Implemented Javascript password check to determine if the values
in the 'password' and 'confirm password' fields are consistent.

If passwords are not consistent a message informing the user
is displayed and they only have to change the password values
rather than re-fill out the whole form.

- Fixed the errors from the koha qa test

- Removed use:C4/Auth from the onboarding.pl

- Moved the "select all options" button down to just above
the selectable options in the basic setup, and positioned at
the top of the page for the advanced setup.

- Removed the "there is nothing to do because the sample data
is already installed" page so if the user has install sample
data in the web installer then the step to create that object
in the onboarding tool is skipped altogether.

- Removed the "We're just going to setup a few more things"
page

- Changed the title of the 'Create patron page'

- Added clarifying information to the "Add a patron category"
page

- Added clarifying information to the "Create item type" page

- Fixed the capitalization in the onboarding tool

- Removed the BackupStep3.tt file which was un-used

- Changed the redirect time displayed to user in step3.tt to 10

-

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #110 from M. Tompsett  ---
Created attachment 59280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59280=edit
[SIGNED-OFF] Bug 17855 - removing some errant warns

Just removing some warns that crept in during debugging.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58895|0   |1
is obsolete||
  Attachment #58896|0   |1
is obsolete||
  Attachment #58897|0   |1
is obsolete||
  Attachment #58898|0   |1
is obsolete||
  Attachment #58899|0   |1
is obsolete||
  Attachment #58900|0   |1
is obsolete||
  Attachment #58903|0   |1
is obsolete||
  Attachment #58904|0   |1
is obsolete||
  Attachment #58907|0   |1
is obsolete||
  Attachment #59037|0   |1
is obsolete||

--- Comment #108 from M. Tompsett  ---
Created attachment 59277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59277=edit
[SIGNED-OFF] Bug 17855 - Other followups

- Removed the html regex from the cardnumber field in the
'Create patron administrator' page of the onboarding tool. Added
'|html' into the the value attribute of the cardnumber input
field to filter the inputted cardnumber.

So now the same level of validation exists for validating the
inputted cardnumber in the staff interface and the onboarding
tool.

- Removed the unnecessary javascript cardnumber
validation code from onboardingstep3.tt

- Removed HTML regexes from all fields on all screens
of onboarding tool except branchcode, patron category code
and item type code. Also ensured these three remaining regexes
are all {1,10} for length as they are all required.

- Added |html and added in input title attribute to
input fields where it existed previously

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #107 from M. Tompsett  ---
Can we push this through first, and then discuss what to fix on it in another
bug? I'm almost done my sign off testing. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #106 from Alex Buckley  ---
I have written this bug report (bug 17944) which I will work on immediately
after this bug (17855) is signed off. 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||17944
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944
[Bug 17944] Remove the sql code from onboarding and administrative perl
scripts, and remove unnecessary use pragmas from onboarding.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #105 from Alex Buckley  ---
(in reply to Owen Leonard in comment 104)

When writing this script I noticed that several of the administration scripts
(itemtypes.pl (to create an item type)and smart-rules.pl ( to create a
circulation rule)) had significant amounts of sql in them. 

Therefore what I am planning to do is if we can get this patch signed off I
will have time to be able to go through and move the sql code from the
onboarding.pl, itemtypes.pl, and smart-rules.pl.

Additionally in that second patch I would be able to go through and see which
of the 'use's I can remove from onboarding.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Owen Leonard  changed:

   What|Removed |Added

 Blocks||17942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942
[Bug 17942] Update style of the web installer with Bootstrap 3
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #104 from Owen Leonard  ---
I notice that onboarding.pl has a lot of SQL operations. This is a violation of
our coding guidelines:

https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts

I also notice that there are quite a lot of "use" statements at the top of that
script. Are they all really necessary?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 227 matches

Mail list logo