[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun |ommunity.org|ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #40 from David Cook --- (In reply to Andrew from comment #39) > Hi David! Nick could give you better details, but we got stuck at one point > in your test plan when, with the patch applied, the system wouldn't renew or > apply an auto-renew error to a checkout that was within the window defined > by No Renewal Before but was not yet overdue. Thanks for the details, Andrew. I'll take another look when I have some time. Cheers! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #39 from Andrew --- Hi David! Nick could give you better details, but we got stuck at one point in your test plan when, with the patch applied, the system wouldn't renew or apply an auto-renew error to a checkout that was within the window defined by No Renewal Before but was not yet overdue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #38 from David Cook --- (In reply to Nick Clemens from comment #37) > I tested David's patch with our educators, I don't think it quite does what > it meant to do. I attached an updated version of David's patch that > simplifies the logic, I believe this fulfills the intent Could you elaborate on that, Nick? I think my patch does what I mean it to do, but maybe I'm not clearly communicating what I mean it to do? If you look at Circulation.pm (I think), I'm basically just copying what already happens if a person tries to perform a renewal manually. So I'm trying to harmonize the human and machine methods of renewing, and that takes into account NoRenewalBefore from the circulation rules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #37 from Nick Clemens --- I tested David's patch with our educators, I don't think it quite does what it meant to do. I attached an updated version of David's patch that simplifies the logic, I believe this fulfills the intent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #36 from Nick Clemens --- Created attachment 90509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90509&action=edit Bug 19014: [alternate-alternate] Only process issues for autorenewal if on or after soonest renewal date This patch check the soonest renewal date and skips processing auto renewals if before this date This ensures patrons won't get notifications far in advance if an item is on hold or has other issues To test: 1 - Checkout an item to a patron with a due date 2 days in the future and 'No renewal before' unset 2 - Place a hold on that item 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum [% checkout.auto_renew_error %] 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices 5 - Patron is not notified 6 - Set 'No renewal before' to 1 7 - run cronjob 8 - Patron is notified with error 'on_reserve' 9 - Set 'No renewal before' to 3 10 - UPDATE issues SET auto_renew_error = NULL; 11 - run cronjob 12 - Patron is notified with error 'on_reserve' 13 - APPLY PATCH 14 - Unset 'No renewal before' 15 - UPDATE issues SET auto_renew_error = NULL; 16 - run cronjob 17 - Patron is not notified 18 - UPDATE issues SET auto_renew_error = NULL; 19 - Set 'No renewal before' to 1 20 - run cronjob 21 - Patron is notified with error 'on_reserve' 22 - Set 'No renewal before' to 3 23 - UPDATE issues SET auto_renew_error = NULL; 24 - run cronjob 25 - Patron is not notified -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Cori Lynn Arnold changed: What|Removed |Added CC||carn...@dgiinc.com --- Comment #35 from Cori Lynn Arnold --- So, I was asked nicely to wade in on this as a librarian. I think that: 1. Koha should not notify patrons that a book is eligible to be renewed in the _way_ far future, as the original text says. 2. There should be a configurable time (lets say 3 days for the sake of argument) where patrons are notified that material: a. Has been auto-renewed and the new due date is MMDD b. Cannot be auto-renewed and must be returned on date XX-XX-XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #34 from David Cook --- (In reply to Ray Delahunty from comment #32) > (In reply to Andrew from comment #26) > > Are we focussing too much on manipulating when the auto-renewal takes place > as being the driver of limiting how many people receive renewal-failure > emails? I think we need a better driver. Auto-renewing an item earlier than > the moment it is due back penalises other users who may want the item. No it doesn't. Other users can place a hold on the item. > If it > has already auto-renewed (early) and they place a reservation / hold on it, > they will have to wait longer for it. The same thing could be achieved by a person manually renewing it. I don't see how this is relevant? > That is why we have opted for the > (admittedly harsh) situation where we only warn users that items have failed > auto-renewal when they are overdue. (We use a No Renewal Before value set to > zero, but we do use a long grace period.) > I think this is what most people do with Koha at the moment. > We have multiple copies of the same item (with various loan periods) out on > loan. If a reservation is placed we want to send renewal-failure > notification only to users whose copy is due “soon”, and not to people who > have, say, just taken a long-term loan copy out. Native Koha auto-renewal > functionality currently sees every holder of the item emailed. But the > first copy returned satisfies the reservation. Why pester everyone- we want > to better target the email. > Fair enough although I think that's a separate issue to this one. > In comment 26 Andrew mentions what I think could be the ideal solution- a No > Notice Before parameter. Rather than this being a system preference I see it > better as an additional column in the Circulation & Fine rules. This would > be configurable line by line (user category / item type) and allow the Koha > library to email as many or as few current holders of the non-renewed items > as they wished. Libraries that wanted to be more lenient that us could > increase the No Renewal Before to 1, 2, or 3, say, but it would be the wise > choice of a No Notice Before value that would be the best driver in > targeting users whose items are likely to fulfil the reservation / hold. I'm not interested in this idea, but you are free to pursue that idea by yourself or pay someone else to pursue it. I've provided my alternate patch as it's how me and my clients think the auto-renewal should work, and we've already implemented it locally and are satisfied with that. I've uploaded it here as I think other people would benefit from it as well. That's the limit to my contribution on this particular bug report though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #33 from David Cook --- (In reply to Björn Nylén from comment #31) > From our perspective Davids patch is the logical way it should function. > Don't do anything until it's time to renew. > > However it does change the behaviour and I guess some libraries might like > to keep sending early notices if no further renewal will be possible. > Perhaps it's possible to control it with a command line option (eg > '--early-notice') to skip the no-renwal-before check?(with the risk of > asking for a more complex solution) Oh that's a good point. In fact, locally, I have wrapped it in a system preference, so that it only applies to one instance of Koha. With Koha, when changing things, we typically make the new behaviour opt-in, so we'd either want to use a system preference or a command line option like "--no-early-notices" or something like that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jess Tobin changed: What|Removed |Added CC||lara...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #32 from Ray Delahunty --- (In reply to Andrew from comment #26) Are we focussing too much on manipulating when the auto-renewal takes place as being the driver of limiting how many people receive renewal-failure emails? I think we need a better driver. Auto-renewing an item earlier than the moment it is due back penalises other users who may want the item. If it has already auto-renewed (early) and they place a reservation / hold on it, they will have to wait longer for it. That is why we have opted for the (admittedly harsh) situation where we only warn users that items have failed auto-renewal when they are overdue. (We use a No Renewal Before value set to zero, but we do use a long grace period.) We have multiple copies of the same item (with various loan periods) out on loan. If a reservation is placed we want to send renewal-failure notification only to users whose copy is due “soon”, and not to people who have, say, just taken a long-term loan copy out. Native Koha auto-renewal functionality currently sees every holder of the item emailed. But the first copy returned satisfies the reservation. Why pester everyone- we want to better target the email. In comment 26 Andrew mentions what I think could be the ideal solution- a No Notice Before parameter. Rather than this being a system preference I see it better as an additional column in the Circulation & Fine rules. This would be configurable line by line (user category / item type) and allow the Koha library to email as many or as few current holders of the non-renewed items as they wished. Libraries that wanted to be more lenient that us could increase the No Renewal Before to 1, 2, or 3, say, but it would be the wise choice of a No Notice Before value that would be the best driver in targeting users whose items are likely to fulfil the reservation / hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #31 from Björn Nylén --- From our perspective Davids patch is the logical way it should function. Don't do anything until it's time to renew. However it does change the behaviour and I guess some libraries might like to keep sending early notices if no further renewal will be possible. Perhaps it's possible to control it with a command line option (eg '--early-notice') to skip the no-renwal-before check?(with the risk of asking for a more complex solution) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #30 from Andrew --- Sorry, David, my response was based on some misunderstanding of your patch. I thought you were tying the notice solely to the due date. If it's sending renewal failure notices at the renewal attempt as determined by the No Renewal Before value, then that seems reasonable. Libraries that want to give their patrons some padding between renewal attempt and due date can set No Renewal Before to a larger number. Thanks for clarifying! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #29 from David Cook --- (In reply to Joy Nelson from comment #27) > It seems logical that the autorenewal process should only be looking at > issues at the time specified for autorenewal. i.e. Only try to renew items > on the 'No renewals before" duedate value. I agree. I think it's both logical and it seems to be the way that other library systems do it as well, which suggests to me that is what patrons would expect as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #28 from David Cook --- (In reply to Andrew from comment #26) > Apologies for pushing for greater complexity on this, but I'm not sure about > this approach. If we make auto-renew notices only send on the day the item > is renewed or on the day it's due, we've not solved the problem so much as > inverted it -- some libraries will like it, some libraries will be > ambivalent, and some libraries will feel strongly that we're sending notices > too late. > > I'd like to see this either as a switch (Send notice on status change / Send > notice at due date & renewal) or as a configurable preference like a No > Notice Before value. Andrew, I don't understand what you're trying to say here. The auto-renew notices will be queued up when the renewal is processed. I don't see any other logical way of handling the notices. Are you meaning you want to change the timing of the renewals (and thus the notices associated with them)? If so, my patch allows you to use the "No Renewal Before" rule in Circulation and Fines Rules to specify that no renewal can happen until N days before the due date. My local public library (which doesn't use Koha) seems to have set "4 days before the due date", which means that if there are no restrictions on the item, it will autorenew 4 days before the due date and it will promptly send me an email notification to indicate this. I can't really see any other logical way of it working? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #27 from Joy Nelson --- It seems logical that the autorenewal process should only be looking at issues at the time specified for autorenewal. i.e. Only try to renew items on the 'No renewals before" duedate value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Andrew changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #26 from Andrew --- Apologies for pushing for greater complexity on this, but I'm not sure about this approach. If we make auto-renew notices only send on the day the item is renewed or on the day it's due, we've not solved the problem so much as inverted it -- some libraries will like it, some libraries will be ambivalent, and some libraries will feel strongly that we're sending notices too late. I'd like to see this either as a switch (Send notice on status change / Send notice at due date & renewal) or as a configurable preference like a No Notice Before value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #24 from David Cook --- Created attachment 86960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86960&action=edit [Alternate patch] Bug 19014: Do not try to autorenew an item too early There are a number of conditions which can cause autorenewals to send out confusing notifications to patrons far before the due date of an item. These may be exceeding the max number of renewals or checkouts, a hold on the item, etc. If an item has a hold, we don't want to tell the patron they can't autorenew the item until the earliest renewal date or the due date of the item. Test plan: 1) Check out an item with a due date 2 business days in the future 2) Place a hold on this item 3) Execute the cronjob - Without the patch, an email notification is generated for the patron - With the patch, no email notification is generated 4) Set norenewalbefore in the Circulation and Fines rules to 2 5) Execute the cronjob - Without the patch, an email notification is generated for the person - With the patch, an email notification is generated for the person 6) Set norenewalbefore in the Circulation and Fines rules to 3 7) Execute the cronjob - Without the patch, an email notification is generated for the patron - With the patch, no email notification is generated 8) Clear norenewalbefore in the Circulation and Fines rules 9) Change item due date (in database) to a date/time prior to now 10) Execute the cronjob - Without the patch, an email notification is generated for the person - With the patch, an email notification is generated for the person -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #25 from David Cook --- (In reply to David Cook from comment #24) > Created attachment 86960 [details] [review] > [Alternate patch] Bug 19014: Do not try to autorenew an item too early > I think this emulates the behaviour of other current LMSes/LSPs that use automatic renewal, and is what patrons would expect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #23 from David Cook --- (In reply to Liz Rea from comment #22) > I'd like to test what's here, but don't want to waste the time if it's just > going to be superceded. If no one is going to submit a counterpatch in the > very near term, this looks like it will be an improvement and the patch > probably needs attention so as not to waste Jonathan's work. > > For the record, it still applies and I plan to test it in the very near > term, unless someone says "no here is my go at fixing this." > > Liz Thanks, Liz. I do have a counterpatch which I've been using locally for one client... I'll post it here. It's actually not too dissimilar from Jonathan's patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #22 from Liz Rea --- I'd like to test what's here, but don't want to waste the time if it's just going to be superceded. If no one is going to submit a counterpatch in the very near term, this looks like it will be an improvement and the patch probably needs attention so as not to waste Jonathan's work. For the record, it still applies and I plan to test it in the very near term, unless someone says "no here is my go at fixing this." Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #21 from Ray Delahunty --- Almost 3 years after going live with auto-renewals, including our workaround to deal with this bug we have this very day found that the RenewalPeriodBase was set wrongly (left set the "current date", which was sensible for a manual renewal environment, but is I think NOT sensible for an auto-renewal one). This variable has had an impact on renewal timings and renewal outcomes. Our calendar has Sa/Su as closed days, items being 7 day loans, the No Renewal Before set to 1, and auto-renewal running at 10pm Mo-Su. These variables coupled with the wrong RenewalBasePeriod has seen the loan period on renewal drop a day, until the Monday is reached and then the Sunday closure is seen and items renew every Monday for 7 days from then on. So many variables interact with auto-renewal functionality it is challenging to get then all "right". We are about to look at 18.11 to see how many bug fixes have made it there, up from our 17.05 version. But if unexpected timing puzzles are happening, it might be worthwhile checking the RenewalBasePeriod setting to see if it is set correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Björn Nylén changed: What|Removed |Added CC||bjorn.ny...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22333 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #20 from David Cook --- Actually, it looks like there's already a function in C4::Circulation that could handle this scenario: GetSoonestRenewDate. Personally, I have a non-Koha loan that was due back on February 15th, but today on February 11th I got an email saying that my loan had been automatically renewed until sometime in March. That's a reasonable way of expecting automatic renewals to work I think. That it wouldn't try the automatic renewal until the soonest renew date. I'm going to do a local patch to try this idea out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Michal Denar changed: What|Removed |Added Blocks||17509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 [Bug 17509] Notify patrons to return items requested on hold by another person -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #19 from David Cook --- In 2019, I'm still having librarians getting in touch over irate patrons getting misleading notifications. And now it's not just holds. It's also notifications about reaching the limit of renewals, even though they won't need to autorenew for another 3 weeks. It seems like most people aren't affected by the problems with how autornewals works because they don't have notices set up, but the people who do get notices are plagued by notices that don't make sense. I think it's clear that we need to do "something". But how do we reconcile the people who like the current functionality and the people who hate the current functionality? Looking at Jonathan's patch, it doesn't go far enough. Maybe the easiest thing to do is refactor CanBookBeRenewed to have the "auto_too_soon" code put into a function... and then add that function wrapped in a system preference in automatic_renewals.pl, so that people can toggle between the preferred behaviours. I don't like it... I think everyone should agree with me about what I think is logical (hahahaha), but that might be the most feasible path forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org --- Comment #18 from Daniel Gaghan --- Having read over the comments here, there's nothing I can add besides saying that Pueblo City County Library District is hoping for a fix for this in 2019. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Holger Meißner changed: What|Removed |Added CC||h.meissner...@web.de --- Comment #17 from Holger Meißner --- (In reply to David Cook from comment #15) > I think the proper solution might be to refactor > C4::Circulation::CanBookBeRenewed and then maybe make a separate function > C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it > seems that different libraries have different needs/wants for autorenewal. That's also the first idea I had. Yet, there would be duplicate code and we shouldn't do that unless we have to. Second idea: Don't prioritize errors in CanBookBeRenewed. We already combine different errors in $error, e.g. if both "too_soon" and "auto_renew" apply, then it's "auto_too_soon". Take this one step further and return a complete list of basic errors instead. That list could be evaluated as needed, e.g. the cronjob could decide not to send a notice, because it's too soon and at the same time opac could decide to display a hold. I don't know whether the loss in performance would be noticable. Third idea: Tell CanBookBeRenewed the context we're in. Give CanBookBeRenewed an additional parameter, so it can return different errors depending on that parameter, e.g. CanBookBeRenewed(123,123,0,X) where X might be something like "auto", "staff" or "opac". Similar to the first idea, but the code stays in one function. Any other ideas? Maybe I'll find time to code in 2019, but I can't promise yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #16 from David Cook --- (In reply to David Cook from comment #15) > I think the proper solution might be to refactor > C4::Circulation::CanBookBeRenewed and then maybe make a separate function > C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it > seems that different libraries have different needs/wants for autorenewal. That said, I don't have the resources to do this at present. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #15 from David Cook --- I think the proper solution might be to refactor C4::Circulation::CanBookBeRenewed and then maybe make a separate function C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it seems that different libraries have different needs/wants for autorenewal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Comment #14 from David Cook ---
I've run into this same problem, but my thinking was that
C4::Circulation::CanBookBeRenewed() should check for "too_soon" before
"on_reserve".
In fact, shouldn't reserves be the last thing checked when determining whether
or not a book can be renewed?
Here's the scenario I see:
1. Patron A autorenews Book A on Wednesday morning
2. Patron B reserves Book A on Wednesday afternoon
3. Patron A receives autorenewal failure for Book A on Thursday morning
Here's some SQL I've used to find instances of that scenario happening (the
search strings will depend on the content of your notices):
select
m.borrowernumber,
m.message_id, mq.message_id, m.time_queued, mq.time_queued,m.content,
mq.content
from message_queue m
join message_queue mq ON
m.borrowernumber = mq.borrowernumber
AND substring(m.content,locate('The following item',m.content),30) =
substring(mq.content,locate('The following item',mq.content),30)
AND date(date_add(m.time_queued, INTERVAL 1 DAY)) = date(mq.time_queued)
where m.letter_code = 'AUTO_RENEWALS'
and mq.content like '%item is on hold%'
ORDER BY m.borrowernumber
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #13 from Jonathan Druart --- (In reply to Michal Denar from comment #12) > any progress with this issue? Could you test the patch and give us your feedback? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #12 from Michal Denar --- Hi, any progress with this issue? Thank you. Mike -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_05_candidate | --- Comment #11 from Jonathan Druart --- I will not have time to get back to this before the release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #10 from Ray Delahunty --- We have a test system at 17.11.04 and are investigating whether this problem / dilemma can be solved with the code, which I understand will solve the problem in this bug and the one in 20360 (and which is a candidate for 18.05) can possibly be added to our 17.11 version. We have a workaround where we disabled AUTO_RENEWALS notices and use ODUE to notify of auto-renewal failure, and RENEWALS to notify of auto-renewal success. We are today undoing this workaround and if the code can work in 17.11 we plan to address Katrin’s concerns expressed above by a mix of changes to ‘No renewal after’, ‘No renewal before’, choice of time for the auto-renewal job to run, and generous use of a grace period. These Circulation & Fine Rules changes do not solve every problem, but if they work, they will offer some improvement. If the code does not work, I think we may have to reinstate the workaround, and wait for Koha 18.05. Test plan. We set ‘No automatic renewal before’ to 2 days. We set ‘No automatic renewal after’ to 1 day. We set the time of the auto-renewal job to 7am. We set the RenewalBasePeriod to “old due date”. We set the Grace Period to 3 days. Assuming the new code solves both this bug and the one in 20360, this is what we would expect: Situation 1. Item is reserved / on hold and due date on Thursday. Auto-renewal job runs at 7am Wednesday, and AUTO_RENEWAL notice is sent advising of renewal failure. User has two remaining loan days and the three grace period days before fines start. If the reservation / hold is cancelled after the job has run or is fulfilled by another copy after 7am on Wednesday but before 7am Thursday, the second run of the auto-renewal job will result in the item being renewed, with the new date based on the old date (so the early renewal does not affect the loan period). Situation 2. Item is not reserved / on hold or otherwise blocked from renewal (say, due to max renewals count being reached) and it is due on Thursday. Auto-renewal job runs at 7am Wednesday, and AUTO_RENEWAL notice is sent advising of renewal success, with the new due date based on the old date. The early renewal does not badly affect the current holder- other than appearing to be an ‘early renewal’. But it does mean that if someone else places a reservation / hold on the title on the Wednesday or Thursday they will have a long wait than if the renewal were close to the original due date. We can play about with the settings in Circulation & Fine Rules to get the “best possible outcome” of minimal affect for maximum users (maybe set the ‘No Auto renewal before’ back to 3 days?) but whatever we do, it won’t be perfect as there are potentially problems with whatever settings we choose. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Ray Delahunty changed: What|Removed |Added Summary|Patrons should not get a|Patrons should not get a |on_reserve notification if |on_reserve notification if |the checkout is due in the |the due date is far into |future |the future -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
