[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #39 from Paul Poulain paul.poul...@biblibre.com --- follow-up string (syspref) only, passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Severity|normal |enhancement --- Comment #40 from Paul Poulain paul.poul...@biblibre.com --- follow-up pushed (back to ENH to have this feature in the release notes) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Severity|enhancement |normal --- Comment #38 from Nicole C. Engard neng...@gmail.com --- Changing from enhancement to 'normal' because this is a patch to an enhancement that was put in 3.10. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #12504|0 |1 is obsolete|| --- Comment #37 from Owen Leonard oleon...@myacpl.org --- Created attachment 12640 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12640action=edit [SIGNED-OFF] Bug 7412: Follow up: Update preference to sentence This patch updates the preference question to a sentence to follow the standard set with previous preferences. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #34 from Nicole C. Engard neng...@gmail.com --- Created attachment 12504 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12504action=edit Bug 7412: Follow up: Update preference to sentence This patch updates the preference question to a sentence to follow the standard set with previous preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #35 from Nicole C. Engard neng...@gmail.com --- I have submitted a follow up to fix the preference to be a sentence like other preferences. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #36 from Nicole C. Engard neng...@gmail.com --- Follow up needs sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #33 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #25) Why do you need two new prefs? - Maybe one would have been enough. On the other hand, with two sysprefs, you can enable/disable the feature and keep your settings. Well, I agree with Marcel that one syspref would have been enough = if you want to disable the feature for a short time, just copy/paste it somewhere. However, I won't reject your patch for that, because it is 9 months old, it would not be fair. Since we also have default values in framework, we have Add Duplicate, what exacly make this feature so needed? - This feature keeps track of what to prefill from one session to another (both in time and user: if the user disconnects and reconnects, the values are still prefilled. If a user disconnects and another user logs in, the values are still prefilled.). Add Duplicate does not. During my tests, I discovered that the cookie last only for the session. Is it one of my specific FF setup ? The cookie is created using: +my $itemcookie = $input-cookie( +-name = 'LastCreatedItem', +# We uri_escape the whole freezed structure so we're sure we won't have any encoding problems +-value = uri_escape_utf8( freeze( $record ) ), +-expires = '' +); isn't it meaning session ? However, I'm OK with a duration of a browser session (I even think I prefer that to a forever lasting prefill), so ... ... patch pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #11267|0 |1 is obsolete|| --- Comment #31 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 11723 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11723action=edit Bug 7412: Pre-filling items in cataloguing Pre-filling of items: remember what was in the previous item filled, to be able to create multiple items quickly. By default, all subfields are prefilled when the PrefillItem syspref is on, unless you specify which fields you want to prefill in the SubfieldsToUseWhenPrefill syspref. With a value of f u v, only the $f, $u and $v will be prefilled, for example. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Rebased and QAed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #32 from Matthias Meusburger matthias.meusbur...@biblibre.com --- It probably should be = [ .. ]; The cookie parameter of CGI accepts an arrayref. Please correct. - fixed Just a question, did not examine this further. But should you use uri_escape_utf8 instead of uri_escape? Please test on chars in 128..255 and above, and report back. - I've tested with the following chars: É À œ Œ ñ … as well as with some cyrillic: Советский Союз And it does behave correctly. But it also behave correctly with uri_escape_utf8. I changed to code so it uses uri_escape_utf8, which seems safer. Indentation: additem.pl lines 356 to 360; the same for segment 426-442 (followup..) - fixed You are adding this comment somewhere: This code is subject to change in 3.2 That sounds a little bit old now? In the new code you add code for incrementing barcode. Note that additem already contains subroutine _increment_barcode. Why not use that? Followup? - fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #26) I see that this report lost its signoff. Could you clarify, mtj? IMO it is still at signed off and I will continue with this report soon. No response: resetting status to Signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #28 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: General One pref instead of two prefs would probably be better in terms of managing the number of prefs. But this may be just easier in use. (No blocker) sub removeFieldsForPrefill Somewhat theoretical, but if you would not use barcode and disconnected that field from 952, the function will not work. (No blocker for me) Cookie This feature keeps track of what to prefill from one session to another (both in time and user: if the user disconnects and reconnects, the values are still prefilled. If a user disconnects and another user logs in, the values are still prefilled.). You assume that the user runs under the same OS credentials. But if he logs out from the OS and another user logs in, the situation is different of course. The line 439 is intriguing: $cookie = ( $cookie, $itemcookie ); Does that work? (Apparently..) It probably should be = [ .. ]; The cookie parameter of CGI accepts an arrayref. Please correct. URI::Escape Just a question, did not examine this further. But should you use uri_escape_utf8 instead of uri_escape? Please test on chars in 128..255 and above, and report back. Indentation: additem.pl lines 356 to 360; the same for segment 426-442 (followup..) Barcode You are adding this comment somewhere: This code is subject to change in 3.2 That sounds a little bit old now? In the new code you add code for incrementing barcode. Note that additem already contains subroutine _increment_barcode. Why not use that? Followup? Conclusion In general. Looks good to me, but needs some further attention. Note for RM: Paul, I am setting status to Passed QA for this one. It was quite long time in the queue. But it needs some clarification and followups. Matthias is close to you :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #30 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #28) Paul, I am setting status to Passed QA for this one. It was quite long time in the queue. But it needs some clarification and followups. Matthias is close to you :) I think Matts is closer to you than to me, because he live near Strasbourg ;-) Thx for the passed QA. There's not need to hurry to push it, Matts, pls provide follow-up to Marcel's comments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl --- I see that this report lost its signoff. Could you clarify, mtj? IMO it is still at signed off and I will continue with this report soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #25 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Why do you need two new prefs? - Maybe one would have been enough. On the other hand, with two sysprefs, you can enable/disable the feature and keep your settings. At first glance through code, I see a lot of testing on barcode and read about tricky cookie handling: Could you please explain? If you do not want to copy barcode, you should just not put it in the prefill? - I'm not sure I understand... The code about barcode is for barcode autoincrement management. How exactly do you use this new cookie? - The cookie is used to store the values to prefill. The tricky part is only because, when you send a cookie, you don't get to read its value right away. You have to wait for a refresh. Is this clear or does it need more explanations? Is the commit message outdated? - Why would you say that? Since we also have default values in framework, we have Add Duplicate, what exacly make this feature so needed? - This feature keeps track of what to prefill from one session to another (both in time and user: if the user disconnects and reconnects, the values are still prefilled. If a user disconnects and another user logs in, the values are still prefilled.). Add Duplicate does not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|koha.sek...@gmail.com |m.de.r...@rijksmuseum.nl --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- Just some questions before starting QA on this one: Why do you need two new prefs? At first glance through code, I see a lot of testing on barcode and read about tricky cookie handling: Could you please explain? If you do not want to copy barcode, you should just not put it in the prefill? How exactly do you use this new cookie? Is the commit message outdated? Since we also have default values in framework, we have Add Duplicate, what exacly make this feature so needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #7685|0 |1
is obsolete||
--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 7685
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7685
proposed patch
From f80b4d1115262d2cdace9eb7494da7c22116ebf0 Mon Sep 17 00:00:00 2001
From: Matthias Meusburger matthias.meusbur...@biblibre.com
Date: Fri, 6 Jan 2012 14:55:45 +0100
Subject: [PATCH] Bug 7412: Pre-filling items in cataloguing
Pre-filling of items: remember what was in the previous item filled, to be
able to create multiple items quickly.
By default, all subfields are prefilled when the PrefillItem syspref is on.
If you want some subfields not to be prefilled, you can use the
SubfieldsToDiscardWhenPrefill syspref.
With a value of f u v, the $f, $u and $v won't be prefilled, for example.
---
cataloguing/additem.pl | 123 +---
installer/data/mysql/sysprefs.sql |2 +
installer/data/mysql/updatedatabase.pl | 16 +++-
.../en/modules/admin/preferences/cataloguing.pref | 10 ++
4 files changed, 134 insertions(+), 17 deletions(-)
diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
index a734d0f..b10c986 100755
--- a/cataloguing/additem.pl
+++ b/cataloguing/additem.pl
@@ -32,6 +32,10 @@ use C4::Branch; # XXX subfield_is_koha_internal_p
use C4::ClassSource;
use C4::Dates;
use List::MoreUtils qw/any/;
+use Storable qw(thaw freeze);
+use URI::Escape;
+
+
use MARC::File::XML;
use URI::Escape;
@@ -275,6 +279,29 @@ sub generate_subfield_form {
return \%subfield_data;
}
+# Removes some subfields (defined in the SubfieldsToDiscardWhenPrefill
syspref) when prefilling items
+sub removeFieldsForPrefill {
+
+my $item = shift;
+
+# Getting item tag
+my ($tag, $subtag) = GetMarcFromKohaField(items.barcode, '');
+
+# Getting list of subfields to remove
+my $subfieldsToDiscardWhenPrefill =
C4::Context-preference('SubfieldsToDiscardWhenPrefill');
+
+# Removing subfields
+if ($tag $subfieldsToDiscardWhenPrefill) {
+my $field = $item-field($tag);
+my @subfieldsToDiscard= split(/ /,$subfieldsToDiscardWhenPrefill);
+foreach my $subfieldsDiscard(@subfieldsToDiscard) {
+$field-delete_subfield(code = $subfieldsDiscard);
+}
+}
+
+return $item;
+
+}
my $input= new CGI;
my $error= $input-param('error');
@@ -315,9 +342,26 @@ my $oldrecord = TransformMarcToKoha($dbh,$record);
my $itemrecord;
my $nextop=additem;
my @errors; # store errors found while checking data BEFORE saving item.
+
+# Getting last created item cookie
+my $prefillitem = C4::Context-preference('PrefillItem');
+my $justaddeditem;
+my $cookieitemrecord;
+if ($prefillitem) {
+my $lastitemcookie = $input-cookie('LastCreatedItem');
+if ($lastitemcookie) {
+ $lastitemcookie = uri_unescape($lastitemcookie);
+ if ( thaw($lastitemcookie) ) {
+ $cookieitemrecord = thaw($lastitemcookie) ;
+ $cookieitemrecord = removeFieldsForPrefill($cookieitemrecord);
+ }
+}
+}
+
#---
if ($op eq additem) {
-#---
+
+
#---
# rebuild
my @tags = $input-param('tag');
my @subfields = $input-param('subfield');
@@ -334,26 +378,69 @@ if ($op eq additem) {
my $add_multiple_copies_submit =
$input-param('add_multiple_copies_submit');
my $number_of_copies = $input-param('number_of_copies');
+# This is a bit tricky : if there is a cookie for the last created item
and
+# we just added an item, the cookie value is not correct yet (it will be
updated
+# next page). To prevent the form from being filled with outdated values,
we
+# force the use of add and duplicate feature, so the form will be
filled with
+# correct values.
+$add_duplicate_submit = 1 if ($prefillitem);
+$justaddeditem = 1;
+
+# if autoBarcode is set to 'incremental', calculate barcode...
+# NOTE: This code is subject to change in 3.2 with the implemenation of
ajax based autobarcode code
+# NOTE: 'incremental' is the ONLY autoBarcode option available to those
not using javascript
+if ( C4::Context-preference('autoBarcode') eq 'incremental' ) {
+my ( $tagfield, $tagsubfield ) = GetMarcFromKohaField(
items.barcode, $frameworkcode );
+unless ( $record-field($tagfield)-subfield($tagsubfield) ) {
+my $sth_barcode =
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Oups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ok, here are my testing comments: I like the new way better - a positive system preference to add all fields I want to have prefilled. I am wondering if we really need 2 new preferences for that. Perhaps turning the feature off could be done by leaving the field empty instead? That said, turning the feature off/on works. Only fields I wanted to be copied to the next item get copied. Adding items, duplicating items and adding multiple copies of an item seem to work nicely. Adding items in serials seems not to be affected and worked ok for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #8718|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 10088 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10088action=edit [SIGNED-OFF] Bug 7412: Pre-filling items in cataloguing Pre-filling of items: remember what was in the previous item filled, to be able to create multiple items quickly. By default, all subfields are prefilled when the PrefillItem syspref is on, unless you specify which fields you want to prefill in the SubfieldsToUseWhenPrefill syspref. With a value of f u v, only the $f, $u and $v will be prefilled, for example. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #19 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 8718 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8718action=edit Bug 7412: Pre-filling items in cataloguing This patch implements Katrin's point of view about prefilling only some fields.. The SubfieldsToDiscardWhenPrefill syspref become SubfieldsToUseWhenPrefill. This way, the user can specify which fields he wants to prefill (instead of specifying which fields he doesn't want to prefill) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #18 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Anybody have an opinion on this ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #16 from Matthias Meusburger matthias.meusbur...@biblibre.com --- I'm not sure about that. If you enable a feature, you naturally expect that feature to be working. Having a 'positive' syspref would make the feature disabled even when enabled, which is more confusing, to my opinion. Isn't it better to have a feature that simply works out of box when enabled, and to which you can perform fine-tuning if you want to, rather than having a feature that doesn't work unless you explicitely configure it ? What do you think ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Matthias :) It's already confusing me :) I think it's differnt to how Koha works now and we normally tend to not change Koha's behaviour on update, but make it possible to activate new functionality later. I think for some fields, prefilling might not make sense. The other thing was, that it seems a bit backward for me to think I have to add the fields that I don't want to be prefilled. So if I only want itemtype, callnumber, branchcodes and location (for example) I will have to check the frameworks and find all other fields where I perhaps don't want it to happen. If it was a positive pref I could add the fields I am using to be prefilled. Shorter list (probably) and easier to figure out. But perhaps it's safe to assume you want to copy all fields you entered? I am not really sure here - It would be great to get some more opinions on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-02-26 16:53:26 UTC --- Hi Matthias, what does biblibre MT6413 refer to? Is there a bug in bugzilla for that? The patch does no longer apply: CONFLICT (content): Merge conflict in cataloguing/additem.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. updatedatabase.pl has a bad version number, which makes testing a bit harder. Could you fix it to be XXX and resubmit? Thank you! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-02-26 16:54:42 UTC --- Also a thought - perhaps make it a 'positive' system preference. So people don't enter the fields that should not be prefilled, but those that should be. I think would be a little less confusing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #12 from Matthias Meusburger matthias.meusbur...@biblibre.com 2012-02-16 13:28:08 UTC --- At first, I thought of keeping only the mapped subfields for subfields that should not be prefilled and get rid of the others. By that would not have been generic enough anyway. Deciding which subfields should be prefilled and which should not has to be the librarian's call. So I came up with another solution (based on biblibre MT6413, for reference): a syspref has been added, in which we can give a list of the subfields that should not be prefilled. I also added informations in the commit message. Proposed patch has been updated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #7095|0 |1 is obsolete|| --- Comment #13 from Matthias Meusburger matthias.meusbur...@biblibre.com 2012-02-16 13:29:26 UTC --- Created attachment 7685 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7685 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #10 from Matthias Meusburger matthias.meusbur...@biblibre.com 2012-02-03 16:17:06 UTC --- Using koha to marc mappings is indeed a good idea. However, considering default unimarc mappings, not all of the removed fields are mapped. Mapped: $field-delete_subfield(code = 'f'); # barcode $field-delete_subfield(code = 'k'); # itemcallnumber $field-delete_subfield(code = 'u'); # itemnotes $field-delete_subfield(code = 'v'); # enumchron Not mapped: $field-delete_subfield(code = 'x'); # ? $field-delete_subfield(code = 'z'); # ? What should we do with those two ? Documenting which fields are prevented from being prefilled is a good idea too... Where should it be done ? In the page itself ? In the help page ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412
--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15
19:30:57 UTC ---
I fixed the conflicts in systempreferences.sql and updatedatabase.pl and
checked the code.
The patch uses subfield codes instead of the Koha to MARC mappings:
+sub removeFieldsForPrefill {
+#FIXME: this is not generic enough. We could define fields to remove in a
syspref.
+my $item = shift;
+# Getting item tag
+my ($tag, $subtag) = GetMarcFromKohaField(items.barcode, '');
+if ($tag) {
+my $field = $item-field($tag);
+if ($field) {
+$field-delete_subfield(code = 'f');
+$field-delete_subfield(code = 'k');
+$field-delete_subfield(code = 'u');
+$field-delete_subfield(code = 'v');
+$field-delete_subfield(code = 'x');
+$field-delete_subfield(code = 'z');
+}
+}
+return $item;
+
+}
I checked and the item subfields between UNIMARC and MARC21 are quite
different. Also it should be documented which fields are pre-filled and which
not.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #7069|0 |1 is obsolete|| --- Comment #7 from Matthias Meusburger matthias.meusbur...@biblibre.com 2012-01-09 15:25:58 UTC --- Created attachment 7095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7095 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #8 from Matthias Meusburger matthias.meusbur...@biblibre.com 2012-01-09 15:27:04 UTC --- My bad, sorry. I replaced the proposed patch with an updated version, which does not contain kohaversion.pl modification. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #1 from Matthias Meusburger matthias.meusbur...@biblibre.com 2012-01-06 13:59:36 UTC --- Created attachment 7069 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7069 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #2 from Matthias Meusburger matthias.meusbur...@biblibre.com 2012-01-06 14:01:26 UTC --- To test: Enable PrefillItem syspref Create a new item Create another item. Expected result: fields are prefilled with previous values. (except for the following fields: f k u v x z) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Priority|P5 - low|PATCH-Sent CC||neng...@gmail.com Patch Status|--- |Needs Signoff AssignedTo|gmcha...@gmail.com |matthias.meusburger@biblibr ||e.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Patch Status|Needs Signoff |Does not apply --- Comment #3 from Nicole C. Engard neng...@gmail.com 2012-01-06 14:34:47 UTC --- This does to appear to apply to master. nengard@debian:~/kohaclone$ git bz apply 7412 Bug 7412 - Pre-filling items in cataloguing proposed patch Apply? [yn] y Applying: Bug 7412: Pre-filling items in cataloguing /home/nengard/kohaclone/.git/rebase-apply/patch:85: trailing whitespace. # force the use of add and duplicate feature, so the form will be filled with /home/nengard/kohaclone/.git/rebase-apply/patch:176: trailing whitespace. $itemrecord = $cookieitemrecord if ($prefillitem and not $justaddeditem and $op ne edititem); error: patch failed: kohaversion.pl:16 error: kohaversion.pl: patch does not apply Patch failed at 0001 Bug 7412: Pre-filling items in cataloguing When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Patch left in /tmp/proposed-patch-NyUHpB.patch nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Patch Status|Does not apply |Needs Signoff --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 14:49:44 UTC --- Hi Nicole, I was looking at this too - applies to latest master cleanly for me using git bz. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #5 from Nicole C. Engard neng...@gmail.com 2012-01-06 14:58:31 UTC --- I just did a fetch on master and tried again and still it's not applying - are you on the latest master as of this minute? nengard@debian:~/kohaclone$ git bz apply 7412 Bug 7412 - Pre-filling items in cataloguing proposed patch Apply? [yn] y Applying: Bug 7412: Pre-filling items in cataloguing /home/nengard/kohaclone/.git/rebase-apply/patch:85: trailing whitespace. # force the use of add and duplicate feature, so the form will be filled with /home/nengard/kohaclone/.git/rebase-apply/patch:176: trailing whitespace. $itemrecord = $cookieitemrecord if ($prefillitem and not $justaddeditem and $op ne edititem); error: patch failed: kohaversion.pl:16 error: kohaversion.pl: patch does not apply Patch failed at 0001 Bug 7412: Pre-filling items in cataloguing When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Patch left in /tmp/proposed-patch-jUts5f.patch nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
