date:20170201

[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59750|0   |1
is obsolete||

--- Comment #16 from M. Tompsett  ---
Comment on attachment 59750
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59750
Bug 17982: Improve test coverage

Because there is no easy way to mock the file system. I'll just forget this,
and sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #13 from Josef Moravec  ---
Created attachment 59756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59756=edit
[SIGNED-OFF] Bug 17138: Add and use comparison function and tests

Added C4::Koha::compareNumbers($n1,$n2,$accuracy).
Added corresponding tests to t/Koha.t
Tweaked C4/Overdues to use the new function.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58985|0   |1
is obsolete||
  Attachment #58986|0   |1
is obsolete||
  Attachment #58987|0   |1
is obsolete||
  Attachment #58988|0   |1
is obsolete||
  Attachment #58989|0   |1
is obsolete||
  Attachment #58990|0   |1
is obsolete||
  Attachment #58991|0   |1
is obsolete||
  Attachment #58992|0   |1
is obsolete||

--- Comment #66 from Josef Moravec  ---
Created attachment 59757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59757=edit
Bug 8612: Use CSV profile for exporting basket

This patch allows the user to use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

Test plan:
1) Apply the patch
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
 
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
a) close the basket
b) View the basket
c) validate that there is an export button
d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

Initial work:

Sponsored by: CCSR

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #67 from Josef Moravec  ---
(In reply to Blou from comment #65)
> Josef,
> I'd be happy to have someone in our team test and sign this, but right now I
> get a 
> Applying: Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug
> 15451)
> fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
> 
> Damn sha1...
> Making one big patch out of it would probably limit future rebases, btw,
> since a lot of these do-undo-redo the same code...
> 
> Reminder for the initial work:
> 
> 
> Sponsored by : CCSR
> 

I squashed the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

Josef Moravec  changed:

   What|Removed |Added

  Attachment #59543|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 59758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59758=edit
[SIGNED-OFF] Bug 17988 - Select2 prevents correct tag expand/minimize
functionality

Overview:
Select2 (Bug 13501) introduced divs and inputs that broke some assumptions
about the expected HTML structure.
Because of that, expanding fields to show all hidden subfields does not work
properly.

Steps to Reproduce:
1. Open some book in the editor or create new (cataloguing/addbiblio.pl)
2. Try to minimize or expand fields, that have among subfields the following:
— Thesaurus driven subfield → subfield with Select2
— Hidden subfield.

Actual Results:
 — some fields become hidden, some not, and vice versa
 — in the console, you'll see «Uncaught TypeError: Cannot read property 'match'
of null»

Expected Results:
 — all subfields should minimize/maximize completely

Additional Information:
This happens because Select2 adds some divs, that do not have ID property.
The following patch adds check for the needed attribute existance.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

Josef Moravec  changed:

   What|Removed |Added

  Attachment #54532|0   |1
is obsolete||
  Attachment #58559|0   |1
is obsolete||

--- Comment #12 from Josef Moravec  ---
Created attachment 59755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59755=edit
[SIGNED-OFF] Bug 17138 - UpdateFine() modyfies existing fine records even when
there is no need

In C4/Overdues.pm:

  574: # we're updating an existing fine.  Only modify if amount changed

  577: if ( $data->{'amount'} != $amount ) {

for some numbers (e.g. 5.60) the comparison in line 577 fails
($data->{'amount'} is decimal(28,6) i.e. a string, and $amount may be
a floating point number with no exact binary representation).
E.g. when the fine amounts are multiple of 0.20, it fails for the 33.3%
of the amounts (on average).

Depending on the fine charging settings, this may trigger unnecessary
database writes (and a lot of them). If 'Fine Charging Interval' is
1 day, this has very little practical consequences (misc/cronjobs/fines.pl
script is usually run once per day, and all fines need an increase
anyway). But if the charging interval is longer, e.g. 7 days, in a given
day amount changes only for the 1/7 of the fines (again, on average),
and over 60% of the database writes would be redundant.

To reproduce:

1) run misc/cronjobs/fines.pl
2) add

   warn "AMOUNT ".$data->{'amount'}." vs $amount";

below line 577 in C4/Overdues.pm
3) run misc/cronjobs/fines.pl again
4) you'll see some warnings like 'AMOUNT 5.60 vs 5.6'

or: dump accountlines table after step 1), run the script 2nd time, dump
the table again and compare the contents - some of the records would have
a different timestamp.

To test:

1) apply patch
2) redo steps 1) - 4) above
3) no more warnings in step 4
4) 2nd run of misc/cronjobs/fines.pl should be noticeably faster

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

Francesco Rivetti  changed:

   What|Removed |Added

 CC||o...@oha.it

--- Comment #8 from Francesco Rivetti  ---
Hi! I can't think of any issue with plack or apache.

The only problem I had implementing it is the race with Exporter:

Attribute::Handlers apply attributes at CHECK time, while Exporter at BEGIN
time. I found a easy way to convince A::H to replace the methods at BEGIN time,
but I believe the order in the @ISA must be preserved.

But I don't consider this a proper fix, I just lack the experience to
understand the whole logic behind it yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #3 from Josef Moravec  ---
I was able to reproduce the problem with field 942, with this patch it is OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

--- Comment #1 from Liz Rea  ---
Created attachment 59760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59760=edit
Bug 18025 - Expired password recovery links cause sql crash

When a user gets an email, but doesn't act or visit it within two days,
 attempting to create a new one causes a collision. We should just
 delete the old one, assuming they still want to reset their
 password.

To test:
create yourself a borrower with a userid and password.
Attempt a password recovery on the OPAC
update the entry in the database for that user to have an expired token
e.g. update borrower_password_recovery set valid_until = '2017-01-25
03:25:26' where borrowernumber = 12;
Attempt another password recovery operation - should error
apply the patch
Try it again - no error, new token is generated and additional email
with new link is sent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #51 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #50)
> I'd like to get feedbacks about these few questions:
> 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes?

I think the initial devs might not have been aware of our terminology:
https://wiki.koha-community.org/wiki/Terminology
Could we fix this later on in a separate patch later on? This has been taking a
long time already.

> 2. Does everybody think that "PATRON_NOTE" template code is meaningful
> enough?

Don't have a better idea right now - it matches how it's called in the GUI.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #7 from Josef Moravec  ---
There is missing content in opac-maint.tt, nad intranet-main.tt

see git grep koha_new.new

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56920|0   |1
is obsolete||

--- Comment #4 from Josef Moravec  ---
Created attachment 59759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59759=edit
[SIGNED-OFF] Bug 17512: Improve handling dates in C4::Items

This is a follow-up on the internal server error on -00-00 in the items
column onloan. This patch deals with preventing to have such dates at all
in the date fields of items.

It is accomplished by:
[1] Adding a (private) subroutine _mod_item_dates. It takes an item hash
and replaces date values if needed.
[2] AddItem and ModItem call _koha_new_item resp. koha_modify_item. In these
routines a call to the new _mod_item_dates is inserted.
[3] Although the routine is actually private, I have added some unit tests
to Items.t.

Test plan:
[1] Add a new item. Fill a correct date in dateaccessioned and an invalid
date in Price effective from (=replacementpricedate).
[2] Verify that dateaccessioned is saved correctly and replacementpricedate
is still null (does not contain -00-00).
[3] Edit the item again. Fill some text in dateaccessioned and put a correct
date in replacementpricedate. Verify the results.
[4] Run t/db_dependent/Items.t

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #140 from M. Tompsett  ---
(In reply to Alex Buckley from comment #139)
> (in reply to Jonathan Druart and M.Tompsett in comment 133, 136 and 137 and
> 17855)
> 
> As I am still learning Koha can I please have a more specific explanation of
> the issue(s) which you addressed in points 1 and 2?
> 
> And possible solutions thereof

Non-English template files are generated from the English ones. When you moved
the English ones, did you check (sorry, I forgot to check) if you could
generate another language and run through the onboarding tool? This is not
necessarily related, but I thought I'd mention it. Too often, English speakers
(myself included) fail to test other languages as well. In fact, we need to
test for all the languages that we do have.

Also, you've modified the mandatory/optional directory structure and locations
of the English files. It is probably a good idea to keep the structures aligned
across all languages. Again, we'll need to test for all the languages that we
do have.

My follow up on the broken xt test makes the broken test pass. However, any
changes as triggered above, may required further changes to the same test. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #53 from Aleisha Amohia  ---
(In reply to Jonathan Druart from comment #50)
> (In reply to Jonathan Druart from comment #41)
> > Aleisha, it seems that your last patch kept the 2 subroutines in C4::Items.
> > Since you are not using them, you can remove them.
> 
> Note that this is still valid, C4::Circulation::GetItemIssues is readded by
> your patch whereas it has been removed by bug 17679.

Fixed in the latest patch.

(In reply to Katrin Fischer from comment #51)
> (In reply to Jonathan Druart from comment #50)
> > I'd like to get feedbacks about these few questions:
> > 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes?
> 
> I think the initial devs might not have been aware of our terminology:
> https://wiki.koha-community.org/wiki/Terminology
> Could we fix this later on in a separate patch later on? This has been
> taking a long time already.

I agree with Katrin - any other additional comments about language etc. can be
fixed once this has passed, but would really like to get this through. 
Reattached patch removes the GetItemIssues from the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #59638|0   |1
is obsolete||

--- Comment #9 from Aleisha Amohia  ---
Created attachment 59762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59762=edit
Bug 17698: Make patron notes show up on staff dashboard

This patch adds a user permission for managing issue notes, and a 'noteseen'
column to the issues table.

To test:
1) Apply Bug 14224 first, update database, rebuild schema.
2) Apply this patch, update database, rebuild schema.
3) Restart koha-common and memcached
4) Turn on AllowIssueNotes syspref if haven't already
5) Issue two items to two different users (one item each)
6) Log into the OPAC as one of the users and add an issue note to their
issue
7) Log out and log back into the OPAC as the other user
8) Disable Javascript
9) Refresh opac-user.pl
10) Leave an issue note on their issue
11) Enable javascript and log into the Staff Client as a superlibrarian
user
12) Go to your user's account and edit their permissions to have
everything ticked EXCEPT circulate->manage issue notes.
13) Go to main intranet page. There should be no message saying
'checkout notes pending'.
14) Go to circulation home page. There should be no link to Checkout notes.
15) Go back to user's permissions and tick circulate->manage issue
notes.
16) Go back to main intranet page. There should now be a message at the
bottom saying 'Checkout notes pending: 2'
17) Go to circulation home page. There should be a link to Checkout notes
with a 2 next to it. Click this link
18) Attempt to mark an issue note as seen. This should update the status
of the issue note to 'seen' and disable to 'mark as seen' button while
enabling the 'mark as not seen' button.
19) Test both buttons with both issues.
20) Test select all and clear all buttons
21) Confirm that buttons at the bottom are only enabled if a checkbox is
checked
22) Try selecting both issues and using the buttons at the bottom to
mark multiple issue notes at once.
23) Confirm the barcode link to the item works as expected.
24) Confirm the cardnumber link to the user works as expected.
25) Confirm all table details show correctly.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17512] Improve handling dates in C4::Items

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512

--- Comment #5 from Marcel de Rooy  ---
Thanks Josef.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14536] PageObject-pattern base implementation

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #23 from Aleisha Amohia  ---
Please provide a test plan so someone can test this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #59641|0   |1
is obsolete||

--- Comment #52 from Aleisha Amohia  ---
Created attachment 59761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59761=edit
Bug 14224: Allow patron notes about item shown at check in

This patch adds a "Note" input field to checked out items in the "your summary"
section. The field allows patrons to write notes about the item checked out,
such as "this DVD is scratched", "the binding was torn", etc. The note will be
emailed to the library and displayed on item check in.

Patch adds two fields to the "issues" table - "note" and "notedate".
Patch adds syspref "AllowIssueNotes" - default off.

Test Plan:
1) Apply this patch
2) Update database
3) Rebuild schema
4) Turn on 'AllowIssueNote' syspref
5) Check out three different items to a borrower (may be easiest to check
out to yourself)
6) Log in as that borrower (or yourself) on the OPAC side and go to your
summary
7) Confirm text field shows under Note column for all checkouts. Set a
note for each issue, confirm all save.
8) Check the message_queue in mysql for the entries for ALL THREE issue
notes.
9) Disable javascript in your browser
10) Refresh your summary page. Confirm that you can no longer edit the
notes in the text field. Click the 'Create/edit note' button and confirm
you are redirected to a new page.
11) Confirm that the correct title and author show for the note button
you clicked.
12) Set the note and click Submit -> confirm you are redirected
back to summary page and note is saved
13) Confirm there is a new entry in message_queue
14) Enable javascript and go back to the your checkouts page in the
staff client for the borrower you issued the items to
15) Check in TWO items
16) Confirm that the issue notes show under the "Date due" column for
the two items you checked in, and are accurate to the item (i.e. the
right issue note under the right item)
17) Go to circ/returns.pl and check in the final item using the barcode.
Confirm the issue note shows and the date is formatted correctly.

Sponsored-by: Region Halland

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18032] make test fail 'DBIx::Class::Storage::DBI'

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18032

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #1 from Mason James  ---
hi Jane

if you are try to 'make test' a Koha, you will need all it's required packages
too to pass some tests


you can get all packages with the following command...

$ sudo apt-get install koha-deps koha-perldeps

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #141 from Alex Buckley  ---
(in reply to M.Tompsett in comment 133 and M.Tompsett in comment 140)

Yes thanks, I also asked elsewhere.

I am currently working through the issues in comment 133

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

--- Comment #1 from Aleisha Amohia  ---
Created attachment 59763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59763=edit
Bug 18035: Front-end changes to serials -> Claims

This patch:
1) Uses datatables functionality on numbering patterns table
2) Shows breadcrumbs when using the form to add or modify numbering
patterns
3) Updates the Save, Reset, and Test Pattern buttons in the form to be
bootstrap 3 buttons

To test:
1) Confirm that datatable sorting works on all columns EXCEPT Actions
column
2) Click 'New numbering pattern'
3) Confirm breadcrumbs reads 'New numbering pattern'
4) Go back to numbering patterns and Edit an existing one
5) Confirm breadcrumbs reads 'Modifying number pattern ''
6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3
buttons
7) Confirm all buttons work as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] New: Front-end changes to serials -> Claims

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Bug ID: 18035
   Summary: Front-end changes to serials -> Claims
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Some small enhancements for the user experience
- datatable
- use of breadcrumbs for adding/modifying form
- bootstrap 3 buttons on adding/modifying form

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored
 CC||aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405

--- Comment #1 from Aleisha Amohia  ---
Created attachment 59764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59764=edit
Bug 14405: Add datatables to fines table in OPAC

To test:
1) Apply patch
2) Go to OPAC -> Your account
3) Confirm you can now sort on all columns

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
I'm not sure I understand this bug, but I'm very much in favour of creating
more standardized ways of paginating in Koha, especially in the staff client...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #19 from Liz Rea  ---
Hi Julian,

It seems patches 2 and 3 have snuck back into 3.22.15, have a look please?

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

--- Comment #25 from Jonathan Druart  
---
(In reply to Alex Buckley from comment #22)
> (in reply to Jonathan Druart in comment 21)
> 
> 1/ What tests specifically do you want?

When a subroutine or a method is added or updated, we need to provide tests
("unit tests") in the t directory.
For a method like "Koha::ItemType->is_used" you will want to add tests to
t/db_dependent/Koha/ItemTypes.t.
Create a new subtest per method is a good idea (`git grep subtest t` to see
examples)
In your case you want to test that this new method returns true if at least 1
item and/or 1 biblioitem is using it. Otherwise it returns false.

(In reply to Alex Buckley from comment #24)
> (in reply to Jonathan Druart in comment 21)
> Could you please explain what you mean in your point 5? Are you asking why I
> havent put the is_used subroutine in the Koha::Items and Koha::Biblioitems
> files?

Instead of using
  $schema->resultset('Item')->search
you can use
  Koha::Items->search

We have Koha objects to represent our data model, so when they exist
(Koha::Items and Koha::Biblioitems do exist) it's better to use them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

--- Comment #17 from Marcel de Rooy  ---
Created attachment 59765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59765=edit
Bug 17982: Expose wrong use of uniq

This test should fail without the patch fixing the uniq calls.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59749|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 59766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59766=edit
Bug 17982: Fix the use of uniq in sub themelanguage

Doing uniq( \@themes ) is useless. It will just return to you the only
reference you gave it.
List::MoreUtils::uniq requires a list instead of an arrayref.
So it is a trivial fix that makes sub themelanguage return one theme instead
of three themes like [ 'prog', 'prog',  'prog' ].
Note that Template->new inserts one or two include paths to TT for each of
these three identical themes.

Test plan:
[1] Run t/db_dependent/Templates.t (should no longer fail)
[2] Run t/db_dependent/Auth.t (triggering themelanguage)
[3] Open a page on OPAC or intranet. (Did you restart Plack?)

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

EDIT (Marcel): Amended test plan for additional unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] New: Improve test coverage for themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Bug ID: 18036
   Summary: Improve test coverage for themelanguage
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: gmcha...@gmail.com

See bug 17982

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||17982


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982
[Bug 17982] Fix the use of uniq in sub themelanguage
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||18036


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036
[Bug 18036] Improve test coverage for themelanguage
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

Jonathan Druart  changed:

   What|Removed |Added

Version|17.05   |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17802] Hea - Add geolocation information

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17802

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #2 from Josef Moravec  ---
I am for it, it could be useful. I think if libraries could set their position
just by clicking on the map, many of then do that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18022] Empty barcode causes internal server error

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022

--- Comment #2 from Jonathan Druart  
---
Note, from the mailing list: I am not able to recreate this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18022] Empty barcode causes internal server error

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |major

--- Comment #1 from Jonathan Druart  
---
https://lists.katipo.co.nz/pipermail/koha/2017-January/047102.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

Josef Moravec  changed:

   What|Removed |Added

  Attachment #59671|0   |1
is obsolete||
  Attachment #59672|0   |1
is obsolete||
  Attachment #59673|0   |1
is obsolete||
  Attachment #59674|0   |1
is obsolete||

--- Comment #43 from Josef Moravec  ---
Created attachment 59723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59723=edit
[SIGNED-OFF] Bug 15030 - Certain values in serials' items are lost on next edit

When editing serials subscription, we can edit them but some values are not
pulled from the DB correctly to be put in the edit box.  If not noticed, the
value will be overwritten on the next save.

Test:
- Create a subscription
- Edit itemcallnumber (952o?) and make sure to have a different value than the
default one.
- Save.
- Edit it again
- The saved value is not there.

This is true for itemcallnumber and a few other fields.

This was caused by calls to ->field($subfield).  This would always fail, of
course.

Signed-off-by: Nick Clemens 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

--- Comment #45 from Josef Moravec  ---
Created attachment 59725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59725=edit
[SIGNED-OFF] Bug 15030 - continue. The enumchron value was overwritten by
'header' even when value supplied

Signed-off-by: Nick Clemens 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

--- Comment #44 from Josef Moravec  ---
Created attachment 59724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59724=edit
[SIGNED-OFF] Bug 15030 - Fixes the serials fields associated with a plugin, to
not overwrite the previously saved value

This fixes the remaining fields from serials-edit.pl that were seeing their
previously entered values
be oblitarated with each new edit.  The fields associated to a plugin
(dateaccessioned and barcode) were
always displaying  with each new edit, losing the previous effort.

Signed-off-by: Nick Clemens 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

--- Comment #46 from Josef Moravec  ---
Created attachment 59726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59726=edit
[SIGNED-OFF] Bug 15030: Add tests

This test will prevent regression on the lost of data when
items.itemcallnumber is linked with a plugin.

Signed-off-by: Nick Clemens 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18016] C4::Auth_with_ldap:: ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016

--- Comment #3 from Jonathan Druart  
---
(In reply to Dobrica Pavlinusic from comment #2)
> Seems good, but would it better to do dt_from_string on them to verify they
> are also valid?

It should not happen I think. If that happened, I guess some people would have
raised this problem before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #6 from Jonathan Druart  
---
Hi Aleisha,

Here are a few remarks:
1/ in the preferences.pl file, I think it would be better to affect the patron
category list to $chunk->{'CHOICES'} if the type of the syspref is
patron-categories, and not depending on its name. That way it will be reusable
more easily.

2/ There is type=PatronCategories"in the DB, choices:patron-categories in the
opac.pref, then choices eq 'patron-categories' in preferences.pl
How is useful this type=PatronCategories?

3/ There are 2 problematic cases:
a. The field is not filled yet: it's not visible on the interface, there is no
blank entry
b. A bit more tricky: if the patron category has been removed, it will not be
displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x)

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|3.22|16.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59695|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 59727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59727=edit
Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59

to test patch...

1/ set date between 00:00 and 00:59
$ sudo date -s 'Sun Jan 29 00:41:55 NZDT 2017'

2/ run prove, see fail
$ prove -v t/db_dependent/Members/IssueSlip.t
...
t/db_dependent/Members/IssueSlip.t (Wstat: 65280 Tests: 1 Failed: 0)
Result: FAIL

3/ apply patch

4/ run prove, see pass
$ prove -v t/db_dependent/Members/IssueSlip.t
...
All tests successful.
Result: PASS

NOTE: for code obscurity you could have also done a modulus 24. ;)

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x)

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #30 from Jonathan Druart  
---
Mirko, do you know what is the install_misc/debian.packages file?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #24 from Josef Moravec  ---
(In reply to M. Tompsett from comment #22)
> (In reply to Josef Moravec from comment #18)
> > > In English it's OK
> 
> I can confirm this. Though, OK is so bland. It is quite pretty. Did you get
> it working in Czech, Josef? If so, would you like to sign off, or shall I?

Yes, after regenerating templates everything is OK, so my mistake...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Josef Moravec  changed:

   What|Removed |Added

  Attachment #59623|0   |1
is obsolete||

--- Comment #23 from Josef Moravec  ---
Created attachment 59721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59721=edit
[SIGNED-OFF] Bug 17942 - Update style of the web installer with Bootstrap 3

This patch makes style and markup changes to the web installer and new
onboarding tool (Bug 17855).

- Markup has been corrected, improved, and in many places reindented.
- Some page titles have been made more specific.
- Some JavaScript and CSS have been moved to separate files.

In the onboarding tool I have removed form validation from the markup
and JavaScript in many cases where the requirements were not matched
elsewhere in Koha. For instance, we shouldn't limit item type
descriptions to only letters because the database doesn't require such a
limit.

To test, apply the patch and run the web installer with an empty
database. Confirm that the installation process completes correctly and
that each page looks good and works correctly.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59662|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  
---
Created attachment 59722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59722=edit
Bug 17775 - Add new user with LDAP not works under Plack

This patch fixes internal server error:

Undefined subroutine ::Auth_with_ldap::AddMember called at
/srv/koha_ffzg/C4/Auth_with_ldap.pm line 213.

It occurs only under plack, and it's strange since C4::Members
does EXPORT AddMember and we are importing it into Auth_with_ldap.pm
(and it does work under CGI).

Signed-off-by: Liz Rea 

Signed-off-by: Jonathan Druart 
I did not test but trust author and signoffer. The change cannot hurt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #25 from Josef Moravec  ---
Signed off, has to say it looks really nice! Good job Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #133 from Jonathan Druart  
---
Alex,

Few more remarks:
1/ There is something wrong with the sql sample files for translated languages.
The mandatory and optional files for the other languages have to be moved to
the default directory as well.
We will have to be meticulous to avoid regressions.

2/ You should also adapt xt/sample_notices.t, tests are failing after your
patches

3/ Could you double check the module you use in installer/onboarding.pl, some
are uselessly used.

4/ Double check the copyright lines you have added (+# Copyright (C) YEAR 
YOURNAME-OR-YOUREMPLOYER)

5/ You copied some existing javascript functions to onboardingstep2.tt. Do not
duplicate existing code.
You should also have a look at this template, the indentation in the javascript
portion is weird.

6/ Same as 5 for onboardingstep3.tt

7/ summary.tt - you should not use  tag, our translation tool does not
handle sentences when they are split by html tag. That make the job really hard
(and sometimes impossible) for translators.

8/ Copyright of summary.pl sounds totally wrong.

9/ Is this Summary info really useful? To me it looks like it should be moved
to the help part. I am not sure it worth a new entry in the "More" menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17111

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x)

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18028

--- Comment #31 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #30)
> Mirko, do you know what is the install_misc/debian.packages file?

Opened bug 18028 to talk about that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #6)
> One test is failing after this patch:
> 
> #   Failed test 'Columns is nullable in DB, not in swagger file for
> hold: timestamp'
> #   at t/db_dependent/api/v1/swagger/definitions.t line 71.
> 
> I also think that we should add tests to check data types, don't you think?

Also, are you sure you tested this along with bug 17932?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933

Dobrica Pavlinusic  changed:

   What|Removed |Added

  Attachment #59194|0   |1
is obsolete||
  Attachment #59214|0   |1
is obsolete||
  Attachment #59215|0   |1
is obsolete||

--- Comment #12 from Dobrica Pavlinusic  ---
Created attachment 59733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59733=edit
Bug 17933: Do not instanciate a patron if not needed

Signed-off-by: Dobrica Pavlinusic 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #72 from Tomás Cohen Arazi  ---
Created attachment 59738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59738=edit
Bug 13757: Make Koha::Patron::Modification->store del empty attrs

This patch makes Koha::Patron::Modification->store delete the passed
attributes that contain empty values.

This is the way it currently works, as all opac-editable attributes are
presented to the end-user and they are allowed to delete them, and the
best way I found to represent the deletion on the modification request
is by setting it to the empty string. I chose this way because it is how
the staff interface handles it, so it is consistent.

To test:
- Apply this patch
- Run:
  $ prove t/db_dependent/Koha/Patron/Modifications.t
=> SUCCESS: This time tests pass!
- Verify comment #70 on the bug is fixed now
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

https://bugs.koha-community.org/show_bug.cgi?id=13737

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18008] Use templates for generating pagination

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

Josef Moravec  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |josef.mora...@gmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

--- Comment #5 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 59630 [details] [review]
> Bug 17982: Fix the use of uniq in sub themelanguage
> 
> Review of attachment 59630 [details] [review]:
> -
> 
> ::: C4/Templates.pm
> @@ +256,4 @@
> >  my $where = $tmpl =~ /xsl$/ ? 'xslt' : 'modules';
> >  for my $theme (@themes) {
> >  if ( -e "$htdocs/$theme/$lang/$where/$tmpl" ) {
> > +return ( $theme, $lang, [ uniq(@themes) ] );
> 
> I'm not sure the parenthesis for uniq are necessary.

Seems to be a more a matter of taste.
My personal preference is parentheses, only omitting them with builtins like
open or print.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #6)
> One test is failing after this patch:
> 
> #   Failed test 'Columns is nullable in DB, not in swagger file for
> hold: timestamp'
> #   at t/db_dependent/api/v1/swagger/definitions.t line 71.
> 
> I also think that we should add tests to check data types, don't you think?

I think we might better get rid of definitions.t as there's no obvious reason
why the swagger definition should match the DB. I can take care of adding
'null' as a valid type for 'timestamp' but I think we should better move that
to another bug as the tests are failing without this patches too. See comment
#5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #7 from M. Tompsett  ---
(In reply to Colin Campbell from comment #6)
> Other uses of sprintf in C4::Circulation no loger have the superfluous 0 -
> can we fix the bug now

Valid counter point. Okay.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #19 from Alex Arnaud  ---
Created attachment 59729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59729=edit
Bug 17047 - Remove action column from mana search result table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #18 from Alex Arnaud  ---
Created attachment 59728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59728=edit
Bug 17047 - Don't create numberpattern if the same exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||8840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840
[Bug 8840] ubuntu-pkg-check.sh fix and extend functionality
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18028


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028
[Bug 18028] install_dir/*.packages are outdated and must be removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028

--- Comment #1 from Jonathan Druart  
---
Created attachment 59730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59730=edit
Bug 18028: Remove outdated install_misc directory

This directory is no longer maintained and contain outdated information
on how to install Koha.
On the Internet there are tutos using them and that can create confusion
to new user (yes it could be confusing as well to execute a file that
does no longer exist).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028

Jonathan Druart  changed:

   What|Removed |Added

Summary|install_dir/*.packages are  |install_misc directory is
   |outdated and must be|outdated and must be
   |removed |removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

--- Comment #14 from Marcel de Rooy  ---
Thanks, Nick. You beat me in signing off :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927

--- Comment #9 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #7)
> I think we might better get rid of definitions.t as there's no obvious
> reason why the swagger definition should match the DB. I can take care of
> adding 'null' as a valid type for 'timestamp' but I think we should better
> move that to another bug as the tests are failing without this patches too.

No, they pass on master.

(In reply to Tomás Cohen Arazi from comment #8)

> Also, are you sure you tested this along with bug 17932?

Yes I did.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #134 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #133)

> 9/ Is this Summary info really useful? To me it looks like it should be
> moved to the help part. I am not sure it worth a new entry in the "More"
> menu.

I agree. I wonder if we could add a persistent shortcut of some kind to the
global help system? I suggest this feature be discussed in a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #73 from Tomás Cohen Arazi  ---
Created attachment 59739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59739=edit
Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion

The original code on this bug skipped empty-valued attributes. But
emptying attributes is the only way to tell the controller script that
the user wants to delete them.

This patch makes opac-memberentry.pl check the existence of attributes
sharing the code of the empty for the given patron, and it stores the
deletion on the Koha::Patron::Modification as needed. Otherwise
deletions got skipped.

To test:
- Verify setting/deleting attributes that are opac-editable and verify
the results are sound.

https://bugs.koha-community.org/show_bug.cgi?id=13737

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18028] New: install_dir/*.packages are outdated and must be removed

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028

Bug ID: 18028
   Summary: install_dir/*.packages are outdated and must be
removed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

It seems that the install_dir/*.packages files are no longer maintained and not
really useful.
I would suggest to remove them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17626

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17626] INSTALL files are outdated

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17626

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18028

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #6 from Colin Campbell  ---
Other uses of sprintf in C4::Circulation no loger have the superfluous 0 - can
we fix the bug now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #1 from Jonathan Druart  
---
Created attachment 59740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59740=edit
Try to recreate CanBookBeRenewed perf issue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #59686|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #59687|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #20 from Alex Arnaud  ---
Remember, test plan is here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047#c16

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59694|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 59731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59731=edit
Bug 18018 - WWW:CSRF is missing in PerlDependencies.pm

WWW:CSRF is missing in PerlDependencies.pm and so
libwww-csrf-perl is missing in PerlDependencies.pm
missing in debian/control.

This patch adds both.

NOTE: Tested on top of 17111.
  Checked
  ./koha_perl_deps.pl -m -u
  before and after. Control file eyeballs well.
  git diff origin/master -- debian/control
  does not differ in this change. :)

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x)

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #59691|0   |1
is obsolete||

--- Comment #32 from Mirko Tietgen  ---
Created attachment 59732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59732=edit
Bug 17111: Update control file for 16.05

https://bugs.koha-community.org/show_bug.cgi?id=17111

NOTE: Correctly adds/removes dependencies in debian/control

Signed-off-by: Mark Tompsett 
Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933

Dobrica Pavlinusic  changed:

   What|Removed |Added

  Attachment #59733|0   |1
is obsolete||

--- Comment #13 from Dobrica Pavlinusic  ---
Created attachment 59734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59734=edit
Bug 17933 - Internal software error when searching patron without birth date

When patrons don't have date of birth (which is not required) patron
search results on moremember page produce internal server error since we
can't convert MySQL invalid date -00-00 to datetime object and
call strfdate on it.

Additionally, since we assign dates to template variables and after
than assign whole $data hash to template, later assigment overrides
previous one, so we see birth date field even for patrons which don't
have one.

This patch fixes both of those problems.

Test:
1. edit patron and remove it's birth date
2. try to search for it, and verify server error
3. apply patch
4. repeat search for patron and verify that it works and doesn't
   have enpty birth date field

Signed-off-by: Grace McKenzie 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933

--- Comment #15 from Dobrica Pavlinusic  ---
Created attachment 59736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59736=edit
Bug 17933: Do not instanciate a patron if not needed

Signed-off-by: Dobrica Pavlinusic 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933

--- Comment #14 from Dobrica Pavlinusic  ---
Created attachment 59735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59735=edit
Bug 17933: Add test and return unless defined dob

Without this patch get_age return actually 0 instead of

Signed-off-by: Dobrica Pavlinusic 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
Hi Petter,
I'd be interested to recreate the perf issue.
I have written this quick script, it generates 20 items, 200 patrons and
generate a hold for each patron.

On the second run, I comment everything but the last 2 lines and execute again
the script. It is executed in 1.5s

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 168 matches

Mail list logo