Re: New g.gitDescribe() function

2017-11-19 Thread Edward K. Ream 
On Sun, Nov 19, 2017 at 7:33 AM, Matt Wilkie  wrote:

For what it's worth, this looks decent: https://bitbucket.org/
> th3l0nius/gitdiscribe/. Or at least I see how to use it immediately,
> unlike setuptools_scm. (A bookmark for future use, should g.gitDescribe
> need fixing/replacing/updating.)
>

​Thanks for this.  I've bookmarked it.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: New g.gitDescribe() function

2017-11-19 Thread Matt Wilkie 
>
> ​How could g.gitDescribe possibly be objectionable?  A PR is kinda
> overkill, imo.  It's a new function, so just push it to master.​
>

Simply because I've never touched anything in core before and I don't know
what bits do what. ;-) Thanks for the vote of confidence (and I realize
that's actually confidence in Leo's ability to withstand me!)


> The reason I don't like PyGit is that Leo's git-related functions are
> straightforward, whereas PyGit requires considerable setup.
>

Heheh. That's the same reasoning I went through to abandon using
`setuptools_scm`. I just mentionedt PyGit as something out there that has
some size and community, I've never tried it.

For what it's worth, this looks decent:
https://bitbucket.org/th3l0nius/gitdiscribe/. Or at least I see how to use
it immediately, unlike setuptools_scm. (A bookmark for future use, should
g.gitDescribe need fixing/replacing/updating.)

matt

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: New g.gitDescribe() function

2017-11-18 Thread Edward K. Ream 
On Sat, Nov 18, 2017 at 1:22 AM, Matt Wilkie  wrote:

> I added a new function to leoGobals to grab `git describe` results from
> command shell:
> https://github.com/leo-editor/leo-editor/commit/
> d4a890b49103212f71d5a5e00af0a139a8e7
>
> I followed the pattern of the other g.git commands already present and it
> works well enough for what I need. More experienced eyes than mine should
> look it over. It's not in Master branch, but I intend to issue a pull
> request soon.
>

​How could g.gitDescribe possibly be objectionable?  A PR is kinda
overkill, imo.  It's a new function, so just push it to master.​

(Arguably all the g.git commands could/should be dropped in favor of PyGit
> or similar.
>

​This particular argument has been resolved as far as I am concerned.
PyGit doesn't do nearly enough.  Leo's present git code is, imo, simpler,
faster and clearer.​

I'm unsure of what Leo's default stance is on the whole
> keep-most-things-in-house vs outsource-as-much-as-possible debate.)
>

​Imo, it's best to use the best possible tools whenever possible.  The
IPython project is a great model for this approach.

The reason I don't like PyGit is that Leo's git-related functions are
straightforward, whereas PyGit requires considerable setup.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

New g.gitDescribe() function

2017-11-17 Thread Matt Wilkie 
I added a new function to leoGobals to grab `git describe` results from
command shell:
https://github.com/leo-editor/leo-editor/commit/d4a890b49103212f71d5a5e00af0a139a8e7

I followed the pattern of the other g.git commands already present and it
works well enough for what I need. More experienced eyes than mine should
look it over. It's not in Master branch, but I intend to issue a pull
request soon.

(Arguably all the g.git commands could/should be dropped in favour of PyGit
or similar. I'm unsure of what Leo's default stance is on the whole
keep-most-things-in-house vs outsource-as-much-as-possible debate.)

Matt

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.