Re: Toggle-split-direction

2018-05-11 Thread Edward K. Ream 
On Thu, May 10, 2018 at 9:44 AM, Kent Tenney <kten...@gmail.com> wrote:

> I was surprised to find Toggle-split-direction under
> Window -> Expand/Contract Panes
> instead of
> Window -> Change Window Layout
>

​Fixed at 8f5236930 in devel.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Toggle-split-direction

2018-05-10 Thread Kent Tenney 
I was surprised to find Toggle-split-direction under
Window -> Expand/Contract Panes
instead of
Window -> Change Window Layout

by choice or bug?

Thanks,
Kent

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Closed, won't do: #483: remember toggle-split-direction

2017-06-19 Thread Edward K. Ream 
On Mon, Jun 19, 2017 at 8:10 AM, Kent Tenney <kten...@gmail.com> wrote:

> Currently I create a bookmark node, toggle split direction, adjust to
> taste,
> then rclick border and choose 'save layout'
>
> Provides the persistence I want.
>

​Glad to hear it.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Closed, won't do: #483: remember toggle-split-direction

2017-06-19 Thread Kent Tenney 
Currently I create a bookmark node, toggle split direction, adjust to taste,
then rclick border and choose 'save layout'

Provides the persistence I want.


On Sun, Jun 18, 2017 at 8:45 PM, Edward K. Ream <edream...@gmail.com> wrote:

> We discussed #483 <https://github.com/leo-editor/leo-editor/issues/483>
> in Ashland. I don't recall the discussion in detail, but I have given this
> issue careful thought.  Here is what I said when closing the issue and
> marking it "Won't Do":
>
> QQQ
> After careful consideration, I believe that the initial_split_orientation
> setting is enough. The toggle-split-direction command is merely a
> convenience. Users can change setting either in individual .leo files or in
> myLeoSettings.leo.
>
> There are far more important things to attend to. Please reopen only if
> you can explain a) why this issue is important and b) how to resolve the
> difficulties discussed [at the start of #483].
> QQQ
>
> Edward
>
> --
> You received this message because you are subscribed to the Google Groups
> "leo-editor" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to leo-editor+unsubscr...@googlegroups.com.
> To post to this group, send email to leo-editor@googlegroups.com.
> Visit this group at https://groups.google.com/group/leo-editor.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Closed, won't do: #483: remember toggle-split-direction

2017-06-18 Thread Edward K. Ream 
We discussed #483 <https://github.com/leo-editor/leo-editor/issues/483> in 
Ashland. I don't recall the discussion in detail, but I have given this 
issue careful thought.  Here is what I said when closing the issue and 
marking it "Won't Do":

QQQ
After careful consideration, I believe that the initial_split_orientation 
setting is enough. The toggle-split-direction command is merely a 
convenience. Users can change setting either in individual .leo files or in 
myLeoSettings.leo.

There are far more important things to attend to. Please reopen only if you 
can explain a) why this issue is important and b) how to resolve the 
difficulties discussed [at the start of #483].
QQQ

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Unexected difficulties "remembering" toggle-split-direction

2017-05-10 Thread Terry Brown 
On Wed, 10 May 2017 08:47:00 -0700 (PDT)
john lunzer <lun...@gmail.com> wrote:

> As an extension to "arrange the panes how you want and save the
> layout", there could be multiple saved (and custom named) layouts and
> Leo could ship with "vertical" and "horizontal" default layouts and
> the binding to "toggle-split-direction" could be replaced with a
> binding to "cycle-layouts". Then the user could either
> modify/overwrite the stock layouts or scrap those and just create
> their own layouts. I think this would maintain simplicity and also
> offer a powerful system for quickly changing layouts.

This is a good idea although it does run into one wrinkle.

free_layout already supports multiple named layouts, and cycling
through them would be convenient.  However, switching layouts causes
Leo to instantiate (create) the widgets needed to fill the panes in a
particular layout.  Sometimes that might be slow / undesirable.  So
perhaps when a layout is saved, we'd need a checkbox "include in cycle
layouts".

Clarifying - switching vertical / horizontal / wide body / narrow tree
etc. is fast and no problem, but a layout might include other panes
(todo interface, graph editor, movie viewer) that are klunky to throw
up just because you're trying to cycle from horizontal to vertical.

Cheers -Terry

> Just a thought for creating a simple/unified layout interface.
> 
> On Tuesday, May 9, 2017 at 3:37:22 PM UTC-4, Edward K. Ream wrote:
> >
> > On Tue, May 9, 2017 at 2:30 PM, Terry Brown <terry...@gmail.com 
> > > wrote:
> >
> > ​...​
> >> I wonder if we should
> >> ​ ​
> >> be thinking about obsoleting these settings (and the split ratio
> >> one, ​ ​
> >> too).  As long as it works, and it already exists in free_layout,
> >> it ​ ​
> >> seems the "arrange the panes how you want and save the layout"
> >> approach ​ ​
> >> ​is simpler for all concerned.
> >
> > ​I agree.  This seems like the best idea.​
> >
> > Toggle split direction should (if it doesn't already) just call
> >> free_layouts rotate all function.
> >
> > ​That's exactly what it does:
> >
> > @cmd('toggle-split-direction')
> > def toggleSplitDirection(self, event=None):
> > '''Toggle the split direction in the present Leo window.'''
> > if hasattr(self.c, 'free_layout'):
> > self.c.free_layout.get_top_splitter().rotate()
> > ​
> >
> >> Which, appropriately, has been relabeled "toggle split direction"
> >> in the pane layout menu.
> >
> > ​So it looks like we have a plan.  When docks work we can get rid
> > of several settings.  Until then, we can do nothing.
> >
> > Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Unexected difficulties "remembering" toggle-split-direction

2017-05-10 Thread john lunzer 
As an extension to "arrange the panes how you want and save the layout", 
there could be multiple saved (and custom named) layouts and Leo could ship 
with "vertical" and "horizontal" default layouts and the binding to 
"toggle-split-direction" could be replaced with a binding to 
"cycle-layouts". Then the user could either modify/overwrite the stock 
layouts or scrap those and just create their own layouts. I think this 
would maintain simplicity and also offer a powerful system for quickly 
changing layouts.

Just a thought for creating a simple/unified layout interface.

On Tuesday, May 9, 2017 at 3:37:22 PM UTC-4, Edward K. Ream wrote:
>
> On Tue, May 9, 2017 at 2:30 PM, Terry Brown <terry...@gmail.com 
> > wrote:
>
> ​...​
>> I wonder if we should
>> ​ ​
>> be thinking about obsoleting these settings (and the split ratio one,
>> ​ ​
>> too).  As long as it works, and it already exists in free_layout, it
>> ​ ​
>> seems the "arrange the panes how you want and save the layout" approach
>> ​ ​
>> ​is simpler for all concerned.
>>
>
> ​I agree.  This seems like the best idea.​
>  
>
> Toggle split direction should (if it doesn't already) just call
>> free_layouts rotate all function.
>>
>
> ​That's exactly what it does:
>
> @cmd('toggle-split-direction')
> def toggleSplitDirection(self, event=None):
> '''Toggle the split direction in the present Leo window.'''
> if hasattr(self.c, 'free_layout'):
> self.c.free_layout.get_top_splitter().rotate()
> ​
>  
>
>> Which, appropriately, has been relabeled "toggle split direction" in
>> the pane layout menu.
>>
>
> ​So it looks like we have a plan.  When docks work we can get rid of 
> several settings.  Until then, we can do nothing.
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Unexected difficulties "remembering" toggle-split-direction

2017-05-09 Thread Edward K. Ream 
On Tue, May 9, 2017 at 2:30 PM, Terry Brown <terrynbr...@gmail.com> wrote:

​...​
> I wonder if we should
> ​ ​
> be thinking about obsoleting these settings (and the split ratio one,
> ​ ​
> too).  As long as it works, and it already exists in free_layout, it
> ​ ​
> seems the "arrange the panes how you want and save the layout" approach
> ​ ​
> ​is simpler for all concerned.
>

​I agree.  This seems like the best idea.​


Toggle split direction should (if it doesn't already) just call
> free_layouts rotate all function.
>

​That's exactly what it does:

@cmd('toggle-split-direction')
def toggleSplitDirection(self, event=None):
'''Toggle the split direction in the present Leo window.'''
if hasattr(self.c, 'free_layout'):
self.c.free_layout.get_top_splitter().rotate()
​


> Which, appropriately, has been relabeled "toggle split direction" in
> the pane layout menu.
>

​So it looks like we have a plan.  When docks work we can get rid of
several settings.  Until then, we can do nothing.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Unexected difficulties "remembering" toggle-split-direction

2017-05-09 Thread Terry Brown 
On Tue, 9 May 2017 12:21:30 -0700 (PDT)
"Edward K. Ream" <edream...@gmail.com> wrote:

> On Tuesday, May 9, 2017 at 2:09:25 PM UTC-5, Edward K. Ream wrote:
> 
> > I have just updated #483: Remember toggle-split-direction 
> <https://github.com/leo-editor/leo-editor/issues/483>. I want to
> repeat the discussion here, so as to reach the widest audience.
> ...
> > Imo, the simplest and best approach is to do nothing. If you want
> > Leo to 
> "remember" your preferred orientation, then use the @string 
> initial_split_orientation. You can put this in individual files or,
> more likely, myLeoSettings.leo.
> 
> Hmm. The first time a user chooses toggle-split-direction, Leo could
> put up a dialog tell the user about @string initial_split_orientation.
> 
> A dialog might be the only way to mitigate the unavoidable possible 
> confusion. Otoh, the dialog might quickly become intrusive...

Ignoring the indefinite :-/ timeline for QtDocks, I wonder if we should
be thinking about obsoleting these settings (and the split ratio one,
too).  As long as it works, and it already exists in free_layout, it
seems the "arrange the panes how you want and save the layout" approach
is simpler for all concerned.

Toggle split direction should (if it doesn't already) just call
free_layouts rotate all function.

Which, appropriately, has been relabeled "toggle split direction" in
the pane layout menu.

Cheers -Terry

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Unexected difficulties "remembering" toggle-split-direction

2017-05-09 Thread Edward K. Ream 
On Tue, May 9, 2017 at 2:22 PM, Terry Brown  wrote:

​> ​
> Imo, the simplest and best approach is to do nothing.
​...​

​> ​
Implementation wise this will all need revisiting for the QtDocks
​ ​
interface
​.​

All the more reason to do nothing now.  In fact, I'll reject this proposal
unless Kent changes my mind :-)

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Unexected difficulties "remembering" toggle-split-direction

2017-05-09 Thread Edward K. Ream 
On Tuesday, May 9, 2017 at 2:09:25 PM UTC-5, Edward K. Ream wrote:

> I have just updated #483: Remember toggle-split-direction 
<https://github.com/leo-editor/leo-editor/issues/483>. I want to repeat the 
discussion here, so as to reach the widest audience.
...
> Imo, the simplest and best approach is to do nothing. If you want Leo to 
"remember" your preferred orientation, then use the @string 
initial_split_orientation. You can put this in individual files or, more 
likely, myLeoSettings.leo.

Hmm. The first time a user chooses toggle-split-direction, Leo could put up 
a dialog tell the user about @string initial_split_orientation.

A dialog might be the only way to mitigate the unavoidable possible 
confusion. Otoh, the dialog might quickly become intrusive...

What say you?

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Unexected difficulties "remembering" toggle-split-direction

2017-05-09 Thread Edward K. Ream 
I have just updated #483: Remember toggle-split-direction 
<https://github.com/leo-editor/leo-editor/issues/483>. I want to repeat the 
discussion here, so as to reach the widest audience.

The enhancement asks that Leo restore the proper split direction when 
reloading the file. Alas, this is an unexpectedly tricky request. We 
discussed this at the Ashland meeting without considering the consequences.

There are two competing "natural" ways to specify the split direction:

   - The existing setting: @string initial_split_orientation = vertical
   - A *new* xml element, say , in the .leo file.

The problem is, *what should take precedence if both exist?* Either way 
*will* lead to confusion. If the *setting* takes precedence, then Leo won't 
seem to remember toggle-split-direction. If the setting *doesn't* take 
precedence, then Leo won't seem to honor local settings!


The "heroic" solution would be for the toggle-split-direction command to 
change the initial_split_direction setting, *provided* such a setting 
exists in the *local *.leo file. Otherwise, the command would change a new 
element in the .leo file. But this design is too complex.


Imo, the simplest and best approach is to do nothing. If you want Leo to 
"remember" your preferred orientation, then use the @string 
initial_split_orientation.  You can put this in individual files or, more 
likely, myLeoSettings.leo.


Your comments, please.


Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Toggle Split Direction

2013-12-05 Thread Chris George 
I started my day this morning by trying to toggle the split direction using 
the window menu. I normally do not do this so I was surprised when I 
received the following error.

File /home/chris/Working/leo/leo-editor/leo/core/leoCommands.py, line 
545, in doCommand
val = command(event)

  File /home/chris/Working/leo/leo-editor/leo/plugins/qtGui.py, line 
5171, in toggleSplitDirection
r1 = getRatio(w1)

  File /home/chris/Working/leo/leo-editor/leo/plugins/qtGui.py, line 
5147, in getRatio
sizes = w.sizes()

RuntimeError: wrapped C/C++ object of type NestedSplitter has been deleted

wrote recent file: /home/chris/.leo/.leoRecentFiles.txt

Here is the output of debug, print splitter layout.

NestedSplitter (splitter_2) - vertical
   NestedSplitter () - horizontal
  QFrame (outlineFrame) from _leo_pane:outlineFrame
  QFrame (logFrame) from _leo_pane:logFrame
   QFrame (bodyFrame) from _leo_pane:bodyFrame

I then deleted my entire leo-editor directory and pulled fresh new code 
from bzr. Same errors.

I then removed myLeoSettings.leo from the equation, same errors.

Am I missing something obvious?

Chris

-- 
You received this message because you are subscribed to the Google Groups 
leo-editor group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Toggle Split Direction

2013-12-05 Thread Jacob Peck 

On 12/5/2013 3:10 PM, Chris George wrote:
I started my day this morning by trying to toggle the split direction 
using the window menu. I normally do not do this so I was surprised 
when I received the following error.


File /home/chris/Working/leo/leo-editor/leo/core/leoCommands.py, 
line 545, in doCommand

val = command(event)

  File /home/chris/Working/leo/leo-editor/leo/plugins/qtGui.py, line 
5171, in toggleSplitDirection

r1 = getRatio(w1)

  File /home/chris/Working/leo/leo-editor/leo/plugins/qtGui.py, line 
5147, in getRatio

sizes = w.sizes()

RuntimeError: wrapped C/C++ object of type NestedSplitter has been deleted

wrote recent file: /home/chris/.leo/.leoRecentFiles.txt

Here is the output of debug, print splitter layout.

NestedSplitter (splitter_2) - vertical
   NestedSplitter () - horizontal
  QFrame (outlineFrame) from _leo_pane:outlineFrame
  QFrame (logFrame) from _leo_pane:logFrame
   QFrame (bodyFrame) from _leo_pane:bodyFrame

I then deleted my entire leo-editor directory and pulled fresh new 
code from bzr. Same errors.


I then removed myLeoSettings.leo from the equation, same errors.

Am I missing something obvious?

Chris


Nope, I get the same behavior.  Please file a bug.

--Jake

--
You received this message because you are subscribed to the Google Groups 
leo-editor group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/groups/opt_out.

Re: toggle split direction?

2008-11-29 Thread Edward K. Ream 



On Nov 20, 2:49 pm, Terry Brown [EMAIL PROTECTED] wrote:
 What's the status of toggle split direction in qt?

Still not supported, but rev 1267 adds support for @string
initial_split_orientation = horizontal
which puts the body pane to the right.

I'll do  toggle split direction soon.

Edward
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
leo-editor group.
To post to this group, send email to leo-editor@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/leo-editor?hl=en
-~--~~~~--~~--~--~---

Re: toggle split direction?

2008-11-29 Thread Edward K. Ream 



On Nov 29, 11:57 am, Edward K. Ream [EMAIL PROTECTED] wrote:
  What's the status of toggle split direction in qt?

 Still not supported, but rev 1267 adds support for @string
 initial_split_orientation = horizontal
 which puts the body pane to the right.

 I'll do  toggle split direction soon.

Done at rev 1268 of the trunk.

Edward
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
leo-editor group.
To post to this group, send email to leo-editor@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/leo-editor?hl=en
-~--~~~~--~~--~--~---