[Libreoffice-commits] core.git: formula/source sw/source vcl/source

[Andrea Gelmini]

 formula/source/core/api/token.cxx |2 +-
 sw/source/core/layout/wsfrm.cxx   |2 +-
 vcl/source/window/paint.cxx   |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit fa4def2a2b93868b3750df06b7655801639b5233
Author: Andrea Gelmini 
Date:   Tue Feb 13 18:27:09 2018 +0100

Fix typos

Change-Id: I76d50754a660e006e5913b89caa491cc21d6f9dc
Reviewed-on: https://gerrit.libreoffice.org/49588
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/formula/source/core/api/token.cxx 
b/formula/source/core/api/token.cxx
index 05ca4cf5e1e9..13d6914392db 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -1224,7 +1224,7 @@ bool FormulaMissingContext::AddMissing( FormulaTokenArray 
*pNewArr, const Missin
 // --- more complex cases ---
 
 case ocOffset:
-// FIXME: rather tough.
+// FIXME: rather tough
 // if arg 3 (height) omitted, export arg1 (rows)
 break;
 default:
diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index 4e2eb99438ce..61195cbeef8b 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -1517,7 +1517,7 @@ SwTwips SwFrame::Shrink( SwTwips nDist, bool bTst, bool 
bInfo )
  * size changes. There is always a frame that takes the maximum possible space 
(the frame that
  * contains the Body text) and zero or more frames which only take the space 
needed (header/footer
  * area, footnote container). If one of these frames changes, the 
body-text-frame has to grow or
- * shrink accordingly, even tough it's fixed.
+ * shrink accordingly, even though it's fixed.
  *
  * !! Is it possible to do this in a generic way and not restrict it to the 
page and a distinct
  * frame which takes the maximum space (controlled using the FrameSize 
attribute)?
diff --git a/vcl/source/window/paint.cxx b/vcl/source/window/paint.cxx
index 54d61ac9dfe1..7862ced5d018 100644
--- a/vcl/source/window/paint.cxx
+++ b/vcl/source/window/paint.cxx
@@ -1338,7 +1338,7 @@ void Window::ImplPaintToDevice( OutputDevice* 
i_pTargetOutDev, const Point& i_rP
 {
 if(GetMapMode().GetMapUnit() != MapUnit::MapPixel &&
 // Some of the preview windows (SvxPreviewBase) uses different 
painting (drawinglayer primitives)
-// For these preview we don't need to scale even tough the unit is not 
pixel.
+// For these preview we don't need to scale even though the unit is 
not pixel.
 GetMapMode().GetMapUnit() != MapUnit::Map100thMM)
 {
 bNeedsScaling = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: package/source sd/qa

[Andrea Gelmini]

 package/source/zippackage/ZipPackage.cxx |2 +-
 sd/qa/unit/import-tests.cxx  |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 2dda7cca6feb14b4c6f6f04065e23a8e70e05be6
Author: Andrea Gelmini 
Date:   Wed Feb 14 08:13:05 2018 +0100

Fix typos

Change-Id: Icee735b303ca72bba7b2680676b0c0092d27e2ec
Reviewed-on: https://gerrit.libreoffice.org/49699
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/package/source/zippackage/ZipPackage.cxx 
b/package/source/zippackage/ZipPackage.cxx
index a67c90108481..aea7d14048dd 100644
--- a/package/source/zippackage/ZipPackage.cxx
+++ b/package/source/zippackage/ZipPackage.cxx
@@ -1110,7 +1110,7 @@ void ZipPackage::WriteContentTypes( ZipOutputStream& 
aZipOut, const vector< uno:
 {
 // only nonempty type makes sense here
 ( *aIter )[PKG_MNFST_FULLPATH].Value >>= aPath;
-//FIXME: For now we have no way of deferentiating defaults from 
others.
+//FIXME: For now we have no way of differentiating defaults from 
others.
 aOverridesSequence[nOverSeqLength].First = "/" + aPath;
 aOverridesSequence[nOverSeqLength].Second = aType;
 ++nOverSeqLength;
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 2ed7337438fd..02ab05d93b0d 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -2466,14 +2466,14 @@ void SdImportTest::testTdf51340()
 CPPUNIT_ASSERT_EQUAL( 
static_cast(css::style::LineSpacingMode::PROP), aSpacing.Mode );
 CPPUNIT_ASSERT_EQUAL( static_cast(125), aSpacing.Height );
 
-// Third paragraph has a 70% line spacing set directly on normal slide 
(master slide property ir overriden)
+// Third paragraph has a 70% line spacing set directly on normal slide 
(master slide property is overridden)
 xParagraph.set( getParagraphFromShape( 2, xShape ) );
 xPropSet.set( xParagraph, uno::UNO_QUERY_THROW );
 xPropSet->getPropertyValue( "ParaLineSpacing" ) >>= aSpacing;
 CPPUNIT_ASSERT_EQUAL( 
static_cast(css::style::LineSpacingMode::PROP), aSpacing.Mode );
 CPPUNIT_ASSERT_EQUAL( static_cast(70), aSpacing.Height );
 
-// Fourth paragraph has a 190% line spacing set directly on normal slide 
(slide layout property is overriden)
+// Fourth paragraph has a 190% line spacing set directly on normal slide 
(slide layout property is overridden)
 xParagraph.set( getParagraphFromShape( 3, xShape ) );
 xPropSet.set( xParagraph, uno::UNO_QUERY_THROW );
 xPropSet->getPropertyValue( "ParaLineSpacing" ) >>= aSpacing;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Markus Mohrhard]

 sc/source/ui/view/tabvwsh4.cxx |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 2fd7c18f42710bdaaf3262f4be9f1a706b33d38d
Author: Markus Mohrhard 
Date:   Wed Feb 14 02:25:32 2018 +0100

it does not make sense to check for nullptr and then access anyway

Seems to be related to the crashreports with the signatures:

http://crashreport.libreoffice.org/stats/signature/ScTabViewShell::~ScTabViewShell()

http://crashreport.libreoffice.org/stats/signature/ScInputHandler::EnterHandler(ScEnterMode)

Change-Id: Iff22db3988687a52a7596f01facd5bdd12ce4140
Reviewed-on: https://gerrit.libreoffice.org/49694
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx
index 5c0b1e8ab594..55caac70a18f 100644
--- a/sc/source/ui/view/tabvwsh4.cxx
+++ b/sc/source/ui/view/tabvwsh4.cxx
@@ -1774,10 +1774,12 @@ ScTabViewShell::~ScTabViewShell()
 // all to NULL, in case the TabView-dtor tries to access them
 //! (should not really! ??!?!)
 if (mpInputHandler)
+{
 mpInputHandler->SetDocumentDisposing(true);
-// We end edit mode, before destroying the input handler and the edit 
engine
-// and before end listening (in order to call 
ScTabViewShell::KillEditView())
-mpInputHandler->EnterHandler();
+// We end edit mode, before destroying the input handler and the edit 
engine
+// and before end listening (in order to call 
ScTabViewShell::KillEditView())
+mpInputHandler->EnterHandler();
+}
 
 ScDocShell* pDocSh = GetViewData().GetDocShell();
 EndListening(*pDocSh);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115691] Automatic preview of custom animation throws focus out of the effects list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115691

--- Comment #3 from Buovjaga  ---
(In reply to Jim Raykowski from comment #2)
> Anyone working on this one?

No one is working on this. I was secretly hoping you would get interested in
the topic :)

There are several tasks for further tweaks:
https://bugs.documentfoundation.org/showdependencytree.cgi?id=103437_resolved=1

I am not sure, if all the things mentioned in the original feature request as
comments have been fixed (as the report is still NEW): bug 87813
It would be best to sync with Yousuf on those.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115702] Optimise GTK3 image rendering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115702

--- Comment #1 from Clemens Eisserer  ---
The whole implementation is rather suboptimal performance-wise for all VCL
backends:

- X11/GTK2 frequently call into XGetImage
- GTK3 performs all rendering to system-memory surfaces, so all the scaling is
done exclusivly by the CPU

The different code-paths are the reason, why GTK3 is more handicapped by this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling (GTK3 related)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87485

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #56 from Buovjaga  ---
Fair enough, I created bug 115702 for Clemens's investigations

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
Bug 103152 depends on bug 87485, which changed state.

Bug 87485 Summary: Writer: embedded PNG results in slow scrolling (GTK3 related)
https://bugs.documentfoundation.org/show_bug.cgi?id=87485

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115702] Optimise GTK3 image rendering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115702

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115702] New: Optimise GTK3 image rendering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115702

Bug ID: 115702
   Summary: Optimise GTK3 image rendering
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: perf
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: todven...@suomi24.fi
CC: linuxhi...@gmail.com

Split from bug 87485
Open attachment 112539 and scroll up and down to see it (in your CPU cycles /
call trace).
More noticeable when scrolling with the scrollbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115211] change the behavior of font color - recent

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115211

--- Comment #5 from Roeland  ---
Hi Dieter, when I use a font color on a certain sentence, and I want to use
this color to "Paint" another sentence the color is not in the recent used
list.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114162] [META] EPUB export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114162

Dieter Praas  changed:

   What|Removed |Added

 Depends on||115623


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115623
[Bug 115623] EPUB: support vertical writing mode (rl-tb).
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115623] EPUB: support vertical writing mode (rl-tb).

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115623

Dieter Praas  changed:

   What|Removed |Added

 Blocks||114162


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114162
[Bug 114162] [META] EPUB export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115701] New: LibreOffice 6.0.1.1 - Writer : table --> insert table : table displays with borders when "border" is unchecked; table contents font defaults to original

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115701

Bug ID: 115701
   Summary: LibreOffice 6.0.1.1 - Writer : table --> insert table
: table displays with borders when "border" is
unchecked; table contents font defaults to original
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mark.coet...@gmail.com

Description:
LibreOffice Writer

Writer : Table --> Insert Table : table displays with borders when "border" is
unchecked; 

AND : the table contents font defaults to original (Liberation Serif 12)
irrespective of font chosen in basic fonts or set otherwise.



Actual Results:  
As above

Expected Results:
As above


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.0.1.1
Build ID: 1:6.0.1~rc1-0ubuntu0.17.10.1~lo1
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: en-ZA (en_ZA.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115258] FILESAVE: text with Asian phonetic guide (ruby) disappear after save to docx and reopened

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115258

Mark Hung  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

--- Comment #2 from Mark Hung  ---
Fixed by the following commit

author  Mark Hung    2018-02-04 23:45:09 +0800
committer   Mark Hung    2018-02-13 13:26:14 +0100
commit  3c1bfd952b7cf6b07b4d862e048146a9d245ec26 (patch)
tree43f3bfa67ea90ee46be9eeb759e9b8531bb4c9fb
parent  a4e0d20c7eff8b053ec754b0a4b89dcb26636bf5 (diff)
docx: output ruby attributes properly.
Enclose ruby with run, output hps, hpsBaseText, hpsRaise, etc,
,make the size and script correct as much as possible. The
ruby format in docx can be round-tripped now, so it is moved to
ooxmlexport.

Change-Id: I03797be54aeffeff016011ad8ec536cecf40064f
Reviewed-on: https://gerrit.libreoffice.org/49509
Tested-by: Jenkins 
Reviewed-by: Mark Hung 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115211] change the behavior of font color - recent

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115211

--- Comment #4 from Dieter Praas  ---
Can you describe what do you mean with "not correct / intuitive"? When I use a
font colour, it is added to recent used. So I can't see a problem here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 52048] FORMATTING: Support user-defined identifier sequences ( numbering) for ordered lists (refer comment 4)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=52048

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5679

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115679] FORMATTING: can not customize numbered list format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115679

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=52
   ||048
 Blocks||103364
 Ever confirmed|0   |1

--- Comment #1 from Dieter Praas  ---
I think you're right. I couldn't find a possibility to customize the numbering
list in that way => NEW


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103364
[Bug 103364] [META] Bullet and numbering dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103364] [META] Bullet and numbering dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103364

Dieter Praas  changed:

   What|Removed |Added

 Depends on||115679


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115679
[Bug 115679] FORMATTING: can not customize numbered list format
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/uiconfig

[andreas kainz]

 sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui | 1037 ++
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_full.ui|  700 +
 2 files changed, 1166 insertions(+), 571 deletions(-)

New commits:
commit 418dc19266519067ef8f3a2290ae9cb515677d43
Author: andreas kainz 
Date:   Tue Feb 13 18:18:27 2018 +0100

Groupedbar Impress add priority feature anf fix conatext-drefault

Change-Id: I84faaa1497d652a86183064be7f012948c7a7ef8
Reviewed-on: https://gerrit.libreoffice.org/49676
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 

diff --git a/sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui 
b/sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui
index 5e1b3f0d7e1b..ca09d73bf235 100644
--- a/sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui
+++ b/sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui
@@ -10,35 +10,41 @@
 
   
 True
+False
 .uno:ExtrusionToggle
   
 
 
   
 True
+False
   
 
 
   
 True
+False
 .uno:ExtrusionTiltDown
   
 
 
   
 True
+False
 .uno:ExtrusionTiltUp
   
 
 
   
 True
+False
 .uno:ExtrusionTiltLeft
   
 
 
   
 True
+False
 .uno:ExtrusionTiltRight
   
 
@@ -49,12 +55,14 @@
 
   
 True
+False
 .uno:TableSort
   
 
 
   
 True
+False
 .uno:AutoSum
   
 
@@ -65,72 +73,84 @@
 
   
 True
+False
 .uno:GraphicFilterSepia
   
 
 
   
 True
+False
 .uno:GraphicFilterSobel
   
 
 
   
 True
+False
 .uno:GraphicFilterInvert
   
 
 
   
 True
+False
 .uno:GraphicFilterMosaic
   
 
 
   
 True
+False
 .uno:GraphicFilterPopart
   
 
 
   
 True
+False
 .uno:GraphicFilterPoster
   
 
 
   
 True
+False
 .uno:GraphicFilterRelief
   
 
 
   
 True
+False
 .uno:GraphicFilterRemoveNoise
   
 
 
   
 True
+False
 .uno:GraphicFilterSharpen
   
 
 
   
 True
+False
 .uno:GraphicFilterSmooth
   
 
 
   
 True
+False
 .uno:GraphicFilterSolarize
   
 
 
   
 True
+False
 .uno:GrafMode
   
 
@@ -141,129 +161,151 @@
 
   
 True
+False
 .uno:Line
   
 
 
   
 True
+False
 .uno:Freeline_Unfilled
   
 
 
   
 True
+False
 .uno:Freeline
   
 
 
   
 True
+False
 .uno:Bezier_Unfilled
   
 
 
   
 True
+False
 .uno:BezierFill
   
 
 
   
 True
+False
 .uno:Polygon_Unfilled
   
 
 
   
 True
+False
 .uno:Polygon_Diagonal_Unfilled
   
 
 
   
 True
+False
 .uno:Polygon_Diagonal
   
 
 
   
 True
+False
   
 
 
   
 True
+False
 .uno:BasicShapes
   
 
 
   
 True
+False
 .uno:SymbolShapes
   
 
 
   
 True
+False
 .uno:ArrowShapes
   
 
 
   
 True
+False
 .uno:StarShapes
   
 
 
   
 True
+False
 .uno:CalloutShapes
   
 
 
   
 True
+False
 .uno:FlowChartShapes
   
 
 
   
 True
+False
   
 
 
   
 True
+False
 .uno:DrawCaption
   
 
 
   
 True
+False
 .uno:InsertGraphic
   
 
 
   
 True
+False
 .uno:FontworkGalleryFloater
   
 
 
   
 True
+False
   
 
 
   
 True
+False
 .uno:ExtrusionToggle
   
 
 
   
 True
+False
 .uno:ToggleObjectBezierMode
   
 
@@ -274,70 +316,82 @@
 
   
 True
+False
 .uno:SelectObject
   
 
 
   
 True
+False
 .uno:ToggleObjectRotateMode
   
 
 
   
 True
+False
 .uno:ToggleObjectBezierMode
   
 
 
   
 True
+False
   
 
 
   
 True
+False
 .uno:FlipVertical
   

[Libreoffice-bugs] [Bug 115659] Apparmor profile for senddoc is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115659

--- Comment #5 from Commit Notification 
 ---
Olivier Tilloy committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=92dbf3f70eafd4974290fc488f51c05093950dbf

tdf#115659 Apparmor profile fixes for senddoc

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115659] Apparmor profile for senddoc is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115659

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.0.2|target:6.0.2 target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sysui/desktop

[Olivier Tilloy]

 sysui/desktop/apparmor/program.senddoc |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 92dbf3f70eafd4974290fc488f51c05093950dbf
Author: Olivier Tilloy 
Date:   Mon Feb 12 19:13:45 2018 +0100

tdf#115659 Apparmor profile fixes for senddoc

Fix sending the current document by e-mail:
 - fix path to the installed senddoc executable
 - add missing exception for xdg-email
 - execute xdg-open and xdg-email unconfined

Change-Id: Ie7c5b112bd6c415036490e9f0f81063ca3ced5a1
Reviewed-on: https://gerrit.libreoffice.org/49614
Reviewed-by: Rene Engelhard 
Tested-by: Jenkins 

diff --git a/sysui/desktop/apparmor/program.senddoc 
b/sysui/desktop/apparmor/program.senddoc
index 0aa284de3684..d659ec9b98b3 100644
--- a/sysui/desktop/apparmor/program.senddoc
+++ b/sysui/desktop/apparmor/program.senddoc
@@ -14,7 +14,7 @@
 
 #include 
 
-profile libreoffice-senddoc 
INSTDIR-/usr/lib{,32,64}/libreoffice/program/senddoc {
+profile libreoffice-senddoc INSTDIR-program/senddoc {
   #include 
 
   owner /tmp/lu**   rw,#makes files like luR.tmp/lub.tmp where 
R is random
@@ -27,7 +27,8 @@ profile libreoffice-senddoc 
INSTDIR-/usr/lib{,32,64}/libreoffice/program/senddoc
   /usr/bin/basename rmix,
   /{usr/,}bin/grep  rmix,
   /{usr/,}bin/uname rmix,
-  /usr/bin/xdg-open Cxr -> sanitized_helper,
+  /usr/bin/xdg-open rPUx,
+  /usr/bin/xdg-emailrPUx,
   /dev/null rw,
   INSTDIR-program/uri-encode rmpux,
   /usr/share/libreoffice/share/config/* r,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115659] Apparmor profile for senddoc is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115659

--- Comment #4 from Rene Engelhard  ---
> An error message box saying: "LibreOffice is unable to find a working email 
> configuration. Please save your document locally and attached from within 
> your eMAIL client."

Interesting I get that also with apparmor only in complain mode...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95584] Text with background color set not rendered correctly in presentation and exported PDF file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95584

--- Comment #15 from Bruno MONDIN  ---
Version: 5.4.4.2 (x64), Windows 7 (6.1) 64 bits

PDF export preserves text highlighting
Text highlightning is still not shown in presentation mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source include/oox include/xmloff oox/source sd/CppunitTest_sd_import_tests.mk sd/qa sd/source svx/source sw/qa sw/source xmloff/inc xmloff/source

[Tomaž Vajngerl]

 filter/source/msfilter/escherex.cxx|   76 --
 filter/source/msfilter/eschesdo.cxx|4 -
 filter/source/msfilter/msdffimp.cxx|4 +
 include/oox/export/drawingml.hxx   |9 +++
 include/xmloff/xmlimp.hxx  |3 -
 oox/source/export/drawingml.cxx|   33 ---
 oox/source/export/shapes.cxx   |   19 ++
 sd/CppunitTest_sd_import_tests.mk  |1 
 sd/qa/unit/import-tests.cxx|   10 ++-
 sd/source/filter/eppt/epptso.cxx   |4 -
 svx/source/svdraw/svdograf.cxx |3 -
 sw/qa/extras/globalfilter/globalfilter.cxx |   50 +
 sw/source/filter/ww8/rtfsdrexport.cxx  |   37 ++---
 xmloff/inc/xmlmultiimagehelper.hxx |1 
 xmloff/source/core/xmlexp.cxx  |   23 +---
 xmloff/source/core/xmlimp.cxx  |   44 ++-
 xmloff/source/core/xmlmultiimagehelper.cxx |   52 +-
 xmloff/source/draw/shapeexport.cxx |   82 +++--
 xmloff/source/draw/ximpshap.cxx|   66 +++
 xmloff/source/draw/ximpshap.hxx|2 
 20 files changed, 390 insertions(+), 133 deletions(-)

New commits:
commit 1b02ba03bd62a712e15c15384a3d105d2c088120
Author: Tomaž Vajngerl 
Date:   Tue Feb 13 21:49:57 2018 +0900

shapes: don't use "GraphicURL" property, always use "Graphic"

With GraphicURL property on shapes (XShape) we transported the
external or internal URL to the model, which also included the
GraphicObject uniqueID style URLs. This changes that - now we
always use "Graphic" property and transfer XGraphic to and from
graphic filters. "Graphic" property is already present for XShape
so it wasn't needed to add it.

Filters changed are: OOXML (oox), ODF (xmloff), RTF and
binary MS (esherex).

Also start using originURL on Graphic which now transports the
URL of the external (linked) graphic/image if it was created that
way.

Change-Id: Ic338c60b7cfaaae354cf1e1ca3ae7a6373220230
Reviewed-on: https://gerrit.libreoffice.org/49648
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/filter/source/msfilter/escherex.cxx 
b/filter/source/msfilter/escherex.cxx
index 8807d84173c2..a308d9edc53b 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -85,6 +85,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1390,10 +1391,12 @@ void 
EscherPropertyContainer::CreateEmbeddedHatchProperties(const drawing::Hatch
 AddOpt( ESCHER_Prop_fillType, ESCHER_FillTexture );
 }
 
-bool EscherPropertyContainer::CreateGraphicProperties(
-const uno::Reference & rXPropSet,
-const OUString& rSource, const bool bCreateFillBitmap, const bool 
bCreateCroppingAttributes,
-const bool bFillBitmapModeAllowed, const bool bOOxmlExport )
+bool EscherPropertyContainer::CreateGraphicProperties(const 
uno::Reference & rXPropSet,
+  const OUString& rSource,
+  const bool 
bCreateFillBitmap,
+  const bool 
bCreateCroppingAttributes,
+  const bool 
bFillBitmapModeAllowed,
+  const bool bOOxmlExport )
 {
 boolbRetValue = false;
 boolbCreateFillStyles = false;
@@ -1403,6 +1406,8 @@ bool EscherPropertyContainer::CreateGraphicProperties(
 OUStringaGraphicUrl;
 OString aUniqueId;
 
+uno::Reference xGraphic;
+
 drawing::BitmapMode eBitmapMode(drawing::BitmapMode_NO_REPEAT);
 uno::Any aAny;
 
@@ -1465,6 +1470,11 @@ bool EscherPropertyContainer::CreateGraphicProperties(
 aGraphicUrl = *o3tl::doAccess(aAny);
 bCreateFillStyles = true;
 }
+else if ( rSource == "Graphic" )
+{
+xGraphic = aAny.get();
+bCreateFillStyles = true;
+}
 else if ( rSource == "FillHatch" )
 {
 drawing::Hatch aHatch;
@@ -1531,6 +1541,12 @@ bool EscherPropertyContainer::CreateGraphicProperties(
 : 0;
 }
 
+if (xGraphic.is())
+{
+Graphic aGraphic(xGraphic);
+aGraphicUrl = aGraphic.getOriginURL();
+}
+
 if ( aGraphicUrl.getLength() )
 {
 OUString aVndUrl( "vnd.sun.star.GraphicObject:" );
@@ -1598,7 +1614,7 @@ bool EscherPropertyContainer::CreateGraphicProperties(
 }
 }
 
-if ( aGraphicUrl.getLength() || !aUniqueId.isEmpty() )
+if ( aGraphicUrl.getLength() || !aUniqueId.isEmpty() || xGraphic.is())

[Libreoffice-commits] core.git: sc/source

[Markus Mohrhard]

 sc/source/ui/miscdlgs/datatableview.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 733d77570771e2536d5ce1f18ba82f68ac6c22ee
Author: Markus Mohrhard 
Date:   Thu Feb 8 22:52:00 2018 +0100

let column and row numbers in data table view start with 1

Change-Id: I90f5f69e39d758f3fb40a7ca489d6fd7813bbab1
Reviewed-on: https://gerrit.libreoffice.org/49460
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/miscdlgs/datatableview.cxx 
b/sc/source/ui/miscdlgs/datatableview.cxx
index 8c770957f6b5..76fea1d92650 100644
--- a/sc/source/ui/miscdlgs/datatableview.cxx
+++ b/sc/source/ui/miscdlgs/datatableview.cxx
@@ -63,7 +63,7 @@ sal_uInt16 ScDataTableColView::GetEntrySize(SCCOLROW nPos) 
const
 
 OUString ScDataTableColView::GetEntryText(SCCOLROW nPos) const
 {
-return "Col: " + OUString::number(nPos);
+return "Col: " + OUString::number(nPos + 1);
 }
 
 bool ScDataTableColView::IsLayoutRTL() const
@@ -114,7 +114,7 @@ sal_uInt16 ScDataTableRowView::GetEntrySize(SCCOLROW nPos) 
const
 
 OUString ScDataTableRowView::GetEntryText(SCCOLROW nPos) const
 {
-return OUString::number(nPos);
+return OUString::number(nPos + 1);
 }
 
 bool ScDataTableRowView::IsLayoutRTL() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source vcl/source

[Noel Grandin]

 filter/source/graphicfilter/itiff/itiff.cxx |  199 ++--
 vcl/source/bitmap/BitmapTools.cxx   |   38 -
 2 files changed, 135 insertions(+), 102 deletions(-)

New commits:
commit 6b4d3815a612b688cc5714f8b828a9cc9b109429
Author: Noel Grandin 
Date:   Tue Feb 13 13:41:55 2018 +0200

use BitmapTools in TIFFReader

part of making Bitmap an internal detail of vcl.

This one is a little trickier because it constructs the palette after it
reads the pixel data, so I couldn't use RawBitmap

Change-Id: I2f501260beebb541ee451e78d551e13f182a01b1
Reviewed-on: https://gerrit.libreoffice.org/49665
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 0449cdff7e2b..d86d2912804d 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -22,7 +22,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include "lzwdecom.hxx"
@@ -50,13 +50,13 @@ private:
 Animation   aAnimation;
 
 SvStream*   pTIFF;  // the TIFF file that 
should be read
-Bitmap  aBitmap;
-Bitmap::ScopedWriteAccess xAcc;
+std::unique_ptr mpBitmap;
+SizemaBitmapPixelSize;
+std::vector  mvPalette;
+MapMode maBitmapPrefMapMode;
+SizemaBitmapPrefSize;
 sal_uInt16  nDstBitsPerPixel;
 int nLargestPixelIndex;
-std::unique_ptr
-pAlphaMask;
-AlphaMask::ScopedWriteAccess xMaskAcc;
 
 sal_uInt64  nOrigPos;   // start position in 
pTIFF
 sal_uInt64  nEndOfFile; // end of file 
position in pTIFF
@@ -124,7 +124,9 @@ private:
 
 bool HasAlphaChannel() const;
 
-void SetPixelOnData(BitmapWriteAccess *pWriteAcc, sal_uInt8* pData, long 
nX, sal_uInt8 cIndex);
+void SetPixel(long nY, long nX, sal_uInt8 cIndex);
+void SetPixel(long nY, long nX, Color c);
+void SetPixelAlpha(long nY, long nX, sal_uInt8 nAlpha);
 
 public:
 
@@ -133,7 +135,6 @@ public:
 , pTIFF(nullptr)
 , nDstBitsPerPixel(0)
 , nLargestPixelIndex(-1)
-, pAlphaMask(nullptr)
 , nOrigPos(0)
 , nEndOfFile(0)
 , nDataType(0)
@@ -616,9 +617,9 @@ bool TIFFReader::ReadMap()
 //if the buffer for this line didn't change, then just copy the
 //previous scanline instead of painfully decoding and setting
 //each pixel one by one again
-Scanline pScanline = xAcc->GetScanline(ny);
-Scanline pPrevline = xAcc->GetScanline(ny-1);
-memcpy(pScanline, pPrevline, xAcc->GetScanlineSize());
+memcpy( mpBitmap.get() + (ny * maBitmapPixelSize.Width()) * 4,
+mpBitmap.get() + ((ny-1) * maBitmapPixelSize.Width()) 
* 4,
+maBitmapPixelSize.Width() * 4);
 }
 else
 {
@@ -780,20 +781,38 @@ sal_uInt32 TIFFReader::GetBits( const sal_uInt8 * pSrc, 
sal_uInt32 nBitsPos, sal
 return nRes;
 }
 
-void TIFFReader::SetPixelOnData(BitmapWriteAccess *pWriteAcc, sal_uInt8* 
pData, long nX, sal_uInt8 cIndex)
+void TIFFReader::SetPixel(long nY, long nX, sal_uInt8 cIndex)
 {
-pWriteAcc->SetPixelOnData(pData, nX, BitmapColor(cIndex));
+mpBitmap[(maBitmapPixelSize.Width() * nY + nX) * (HasAlphaChannel() ? 4 : 
3)] = cIndex;
 nLargestPixelIndex = std::max(nLargestPixelIndex, cIndex);
 }
 
+void TIFFReader::SetPixel(long nY, long nX, Color c)
+{
+auto p = mpBitmap.get() + ((maBitmapPixelSize.Width() * nY + nX) * 
(HasAlphaChannel() ? 4 : 3));
+*p = c.GetRed();
+p++;
+*p = c.GetGreen();
+p++;
+*p = c.GetBlue();
+if (HasAlphaChannel())
+{
+p++;
+*p = 0xff; // alpha
+}
+}
+
+void TIFFReader::SetPixelAlpha(long nY, long nX, sal_uInt8 nAlpha)
+{
+assert(HasAlphaChannel());
+mpBitmap[((maBitmapPixelSize.Width() * nY + nX) * 4) + 3] = nAlpha;
+}
+
 bool TIFFReader::ConvertScanline(sal_Int32 nY)
 {
 sal_uInt32  nRed, nGreen, nBlue, ns, nVal;
 sal_uInt8   nByteVal;
 
-BitmapWriteAccess* pAcc = xAcc.get();
-Scanline pScanLine = pAcc->GetScanline(nY);
-
 if ( nDstBitsPerPixel == 24 )
 {
 if ( nBitsPerSample == 8 && nSamplesPerPixel >= 3 &&
@@ -801,10 +820,6 @@ bool TIFFReader::ConvertScanline(sal_Int32 nY)
 {
 sal_uInt8* pt = getMapData(0);
 
-Scanline pMaskScanLine = nullptr;
-if (nSamplesPerPixel >= 4 && xMaskAcc)
-pMaskScanLine = xMaskAcc->GetScanline(nY);
-
 // are the values being saved as 

[Libreoffice-commits] core.git: 2 commits - include/svx include/vcl svtools/source svx/source vcl/source

[Noel Grandin]

 include/svx/svdhdl.hxx |2 
 include/vcl/bitmapex.hxx   |3 +
 svtools/source/graphic/grfmgr2.cxx |   57 --
 svx/source/svdraw/svdhdl.cxx   |   81 +
 vcl/source/gdi/bitmapex.cxx|   55 +
 5 files changed, 99 insertions(+), 99 deletions(-)

New commits:
commit d03c6ee8d0e2f5637038cf80b890e97630b60b9e
Author: Noel Grandin 
Date:   Tue Feb 13 16:14:57 2018 +0200

move transparency adjust code to BitmapEx

part of making Bitmap an internal implementation detail of vcl/

Change-Id: I6978d84c86c3d55b3ebbeacda60fd94b160daa29
Reviewed-on: https://gerrit.libreoffice.org/49667
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index 9faf3c8eb41c..ce45c0a6891f 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -441,6 +441,9 @@ public:
 const Size  );
 
 voidsetAlphaFrom( sal_uInt8 cIndexFrom, sal_Int8 nAlphaTo 
);
+
+voidAdjustTransparency( sal_uInt8 cTrans );
+
 public:
 
 SAL_DLLPRIVATE std::shared_ptr const & ImplGetBitmapImpBitmap() 
const { return aBitmap.ImplGetImpBitmap(); }
diff --git a/svtools/source/graphic/grfmgr2.cxx 
b/svtools/source/graphic/grfmgr2.cxx
index 451365cd7270..584c31daa07f 100644
--- a/svtools/source/graphic/grfmgr2.cxx
+++ b/svtools/source/graphic/grfmgr2.cxx
@@ -1452,63 +1452,10 @@ void GraphicManager::ImplAdjust( BitmapEx& rBmpEx, 
const GraphicAttr& rAttr, Gra
 rBmpEx.Rotate( aAttr.GetRotation(), Color( COL_TRANSPARENT ) );
 }
 
-if( !(( nAdjustmentFlags & GraphicAdjustmentFlags::TRANSPARENCY ) && 
aAttr.IsTransparent()) )
-return;
-
-AlphaMask   aAlpha;
-sal_uInt8   cTrans = aAttr.GetTransparency();
-
-if( !rBmpEx.IsTransparent() )
-aAlpha = AlphaMask( rBmpEx.GetSizePixel(),  );
-else if( !rBmpEx.IsAlpha() )
-{
-aAlpha = rBmpEx.GetMask();
-aAlpha.Replace( 0, cTrans );
-}
-else
+if( ( nAdjustmentFlags & GraphicAdjustmentFlags::TRANSPARENCY ) && 
aAttr.IsTransparent() )
 {
-aAlpha = rBmpEx.GetAlpha();
-BitmapWriteAccess* pA = aAlpha.AcquireWriteAccess();
-
-if( pA )
-{
-sal_uLong   nTrans = cTrans, nNewTrans;
-const long  nWidth = pA->Width(), nHeight = pA->Height();
-
-if( pA->GetScanlineFormat() == ScanlineFormat::N8BitPal )
-{
-for( long nY = 0; nY < nHeight; nY++ )
-{
-Scanline pAScan = pA->GetScanline( nY );
-
-for( long nX = 0; nX < nWidth; nX++ )
-{
-nNewTrans = nTrans + *pAScan;
-*pAScan++ = static_cast( ( nNewTrans & 
0xff00 ) ? 255 : nNewTrans );
-}
-}
-}
-else
-{
-BitmapColor aAlphaValue( 0 );
-
-for( long nY = 0; nY < nHeight; nY++ )
-{
-Scanline pScanline = pA->GetScanline( nY );
-for( long nX = 0; nX < nWidth; nX++ )
-{
-nNewTrans = nTrans + pA->GetIndexFromData( pScanline, 
nX );
-aAlphaValue.SetIndex( static_cast( ( 
nNewTrans & 0xff00 ) ? 255 : nNewTrans ) );
-pA->SetPixelOnData( pScanline, nX, aAlphaValue );
-}
-}
-}
-
-aAlpha.ReleaseAccess( pA );
-}
+rBmpEx.AdjustTransparency(aAttr.GetTransparency());
 }
-
-rBmpEx = BitmapEx( rBmpEx.GetBitmap(), aAlpha );
 }
 
 void GraphicManager::ImplAdjust( GDIMetaFile& rMtf, const GraphicAttr& rAttr, 
GraphicAdjustmentFlags nAdjustmentFlags )
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index 797319164de4..962f75cc03f4 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -1322,4 +1322,59 @@ void BitmapEx::setAlphaFrom( sal_uInt8 cIndexFrom, 
sal_Int8 nAlphaTo )
 }
 }
 }
+
+void BitmapEx::AdjustTransparency(sal_uInt8 cTrans)
+{
+AlphaMask   aAlpha;
+
+if( !IsTransparent() )
+aAlpha = AlphaMask( GetSizePixel(),  );
+else if( !IsAlpha() )
+{
+aAlpha = GetMask();
+aAlpha.Replace( 0, cTrans );
+}
+else
+{
+aAlpha = GetAlpha();
+Bitmap::ScopedWriteAccess pA(aAlpha);
+assert(pA);
+
+if( !pA )
+return;
+
+sal_uLong   nTrans = cTrans, nNewTrans;
+const long  nWidth = pA->Width(), nHeight = pA->Height();
+
+if( pA->GetScanlineFormat() == ScanlineFormat::N8BitPal )
+{
+for( long nY = 0; nY < nHeight; nY++ )
+ 

[Libreoffice-commits] core.git: filter/source include/vcl

[Noel Grandin]

 filter/source/graphicfilter/ipsd/ipsd.cxx |   89 ++
 include/vcl/BitmapTools.hxx   |5 +
 2 files changed, 36 insertions(+), 58 deletions(-)

New commits:
commit 2168d709805a847ac012ff87b06e081ca139d064
Author: Noel Grandin 
Date:   Mon Feb 12 15:29:10 2018 +0200

use RawBitmap in PSDReader

part of making Bitmap an internal detail of vcl

Change-Id: Icdb7a7474b19e304950fcf75ef2b85006b7755e9
Reviewed-on: https://gerrit.libreoffice.org/49664
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/filter/source/graphicfilter/ipsd/ipsd.cxx 
b/filter/source/graphicfilter/ipsd/ipsd.cxx
index 3d484621596e..e254b1946be0 100644
--- a/filter/source/graphicfilter/ipsd/ipsd.cxx
+++ b/filter/source/graphicfilter/ipsd/ipsd.cxx
@@ -19,7 +19,7 @@
 
 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -65,11 +65,8 @@ private:
 boolmbStatus;
 boolmbTransparent;
 
-Bitmap  maBmp;
-Bitmap  maMaskBmp;
-BitmapReadAccess*   mpReadAcc;
-BitmapWriteAccess*  mpWriteAcc;
-BitmapWriteAccess*  mpMaskWriteAcc;
+std::unique_ptr mpBitmap;
+std::vector  mvPalette;
 sal_uInt16  mnDestBitDepth;
 boolmbCompression;  // RLE decoding
 std::unique_ptr
@@ -92,9 +89,6 @@ PSDReader::PSDReader(SvStream )
 , mnYResFixed(0)
 , mbStatus(true)
 , mbTransparent(false)
-, mpReadAcc(nullptr)
-, mpWriteAcc(nullptr)
-, mpMaskWriteAcc(nullptr)
 , mnDestBitDepth(0)
 , mbCompression(false)
 , mpPalette(nullptr)
@@ -114,32 +108,19 @@ bool PSDReader::ReadPSD(Graphic & rGraphic )
 return false;
 
 Size aBitmapSize( mpFileHeader->nColumns, mpFileHeader->nRows );
-maBmp = Bitmap( aBitmapSize, mnDestBitDepth );
-if ( ( mpWriteAcc = maBmp.AcquireWriteAccess() ) == nullptr )
-mbStatus = false;
-if ( ( mpReadAcc = maBmp.AcquireReadAccess() ) == nullptr )
-mbStatus = false;
-if ( mbTransparent && mbStatus )
-{
-maMaskBmp = Bitmap( aBitmapSize, 1 );
-if ( ( mpMaskWriteAcc = maMaskBmp.AcquireWriteAccess() ) == nullptr )
-mbStatus = false;
-}
+mpBitmap.reset( new vcl::bitmap::RawBitmap( aBitmapSize ) );
 if ( mpPalette && mbStatus )
 {
-mpWriteAcc->SetPaletteEntryCount( 256 );
+mvPalette.resize( 256 );
 for ( sal_uInt16 i = 0; i < 256; i++ )
 {
-mpWriteAcc->SetPaletteColor( i, Color( mpPalette[ i ], mpPalette[ 
i + 256 ], mpPalette[ i + 512 ] ) );
+mvPalette[i] = Color( mpPalette[ i ], mpPalette[ i + 256 ], 
mpPalette[ i + 512 ] );
 }
 }
 // read bitmap data
 if ( mbStatus && ImplReadBody() )
 {
-if ( mbTransparent )
-rGraphic = Graphic( BitmapEx( maBmp, maMaskBmp ) );
-else
-rGraphic = maBmp;
+rGraphic = Graphic( vcl::bitmap::CreateFromData( std::move(*mpBitmap) 
) );
 
 if ( mnXResFixed && mnYResFixed )
 {
@@ -154,12 +135,6 @@ bool PSDReader::ReadPSD(Graphic & rGraphic )
 }
 else
 mbStatus = false;
-if ( mpWriteAcc )
-Bitmap::ReleaseAccess( mpWriteAcc );
-if ( mpReadAcc )
-Bitmap::ReleaseAccess( mpReadAcc );
-if ( mpMaskWriteAcc )
-Bitmap::ReleaseAccess( mpMaskWriteAcc );
 return mbStatus;
 }
 
@@ -361,7 +336,7 @@ bool PSDReader::ImplReadBody()
 nDat ^= 0xff;
 nBitCount = 7;
 }
-mpWriteAcc->SetPixelIndex( nY, nX, nDat >> nBitCount-- 
);
+mpBitmap->SetPixel( nY, nX, mvPalette[nDat >> 
nBitCount--] );
 if ( ++nX == mpFileHeader->nColumns )
 {
 nX = 0;
@@ -383,7 +358,7 @@ bool PSDReader::ImplReadBody()
 nDat ^= 0xff;
 nBitCount = 7;
 }
-mpWriteAcc->SetPixelIndex( nY, nX, nDat >> nBitCount-- 
);
+mpBitmap->SetPixel( nY, nX, mvPalette[nDat >> 
nBitCount--] );
 if ( ++nX == mpFileHeader->nColumns )
 {
 nX = 0;
@@ -417,7 +392,7 @@ bool PSDReader::ImplReadBody()
 const sal_uInt16 nCount = -nRunCount + 1;
 for (sal_uInt16 i = 0; i < nCount && m_rPSD.good(); ++i)
 {
-mpWriteAcc->SetPixelIndex( nY, nX, nDat );
+mpBitmap->SetPixel( nY, nX, mvPalette[nDat] );
 if ( ++nX == mpFileHeader->nColumns )
 {
 nX = 0;
@@ -435,7 +410,7 @@ bool PSDReader::ImplReadBody()
 

[Libreoffice-commits] core.git: 2 commits - dbaccess/source desktop/source editeng/source emfio/source extensions/source

[Noel Grandin]

 dbaccess/source/ui/app/AppDetailPageHelper.cxx  |8 
 dbaccess/source/ui/app/AppDetailView.cxx|8 
 dbaccess/source/ui/browser/brwview.cxx  |   12 
 dbaccess/source/ui/browser/dataview.cxx |2 
 dbaccess/source/ui/browser/sbagrid.cxx  |4 
 dbaccess/source/ui/control/FieldDescControl.cxx |   16 -
 dbaccess/source/ui/control/VertSplitView.cxx|8 
 dbaccess/source/ui/dlg/adminpages.cxx   |2 
 dbaccess/source/ui/dlg/indexfieldscontrol.cxx   |2 
 dbaccess/source/ui/dlg/sqlmessage.cxx   |   12 
 dbaccess/source/ui/misc/UITools.cxx |4 
 dbaccess/source/ui/querydesign/ConnectionLine.cxx   |   64 ++--
 dbaccess/source/ui/querydesign/JoinController.cxx   |6 
 dbaccess/source/ui/querydesign/JoinTableView.cxx|   40 +-
 dbaccess/source/ui/querydesign/QueryDesignView.cxx  |4 
 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx   |8 
 dbaccess/source/ui/querydesign/TableConnection.cxx  |2 
 dbaccess/source/ui/querydesign/TableWindow.cxx  |   28 -
 dbaccess/source/ui/querydesign/TableWindowTitle.cxx |   10 
 dbaccess/source/ui/querydesign/querycontainerwindow.cxx |8 
 dbaccess/source/ui/tabledesign/TEditControl.cxx |2 
 desktop/source/deployment/gui/dp_gui_extlistbox.cxx |   22 -
 desktop/source/splash/splash.cxx|2 
 editeng/source/accessibility/AccessibleStringWrap.cxx   |8 
 editeng/source/editeng/editdoc.cxx  |6 
 editeng/source/editeng/editeng.cxx  |   54 +--
 editeng/source/editeng/editview.cxx |4 
 editeng/source/editeng/impedit.cxx  |  120 +++
 editeng/source/editeng/impedit2.cxx |   30 -
 editeng/source/editeng/impedit3.cxx |  256 
 editeng/source/editeng/impedit4.cxx |8 
 editeng/source/items/frmitems.cxx   |8 
 editeng/source/items/numitem.cxx|4 
 editeng/source/items/svxfont.cxx|   22 -
 editeng/source/outliner/outlin2.cxx |2 
 editeng/source/outliner/outliner.cxx|   96 +++---
 editeng/source/outliner/outlvw.cxx  |4 
 editeng/source/uno/unoviwou.cxx |4 
 emfio/source/reader/emfreader.cxx   |4 
 emfio/source/reader/mtftools.cxx|   18 -
 emfio/source/reader/wmfreader.cxx   |   32 +-
 extensions/source/bibliography/toolbar.cxx  |6 
 extensions/source/propctrlr/browserline.cxx |8 
 extensions/source/propctrlr/browserlistbox.cxx  |   12 
 extensions/source/propctrlr/inspectorhelpwindow.cxx |4 
 extensions/source/propctrlr/standardcontrol.cxx |2 
 extensions/source/scanner/grid.cxx  |   22 -
 extensions/source/scanner/sanedlg.cxx   |   84 ++---
 extensions/source/update/ui/updatecheckui.cxx   |8 
 49 files changed, 550 insertions(+), 550 deletions(-)

New commits:
commit 2096aac8b958db66b3ddce16b06dca87edc8ba0a
Author: Noel Grandin 
Date:   Tue Feb 13 15:49:10 2018 +0200

loplugin:changetoolsgen in editeng..extensions

Change-Id: I476fd8b988216a300c57fcf184ea3742139363fe
Reviewed-on: https://gerrit.libreoffice.org/49656
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/accessibility/AccessibleStringWrap.cxx 
b/editeng/source/accessibility/AccessibleStringWrap.cxx
index 64ea287dc9ff..63a2fca3ef34 100644
--- a/editeng/source/accessibility/AccessibleStringWrap.cxx
+++ b/editeng/source/accessibility/AccessibleStringWrap.cxx
@@ -48,16 +48,16 @@ void AccessibleStringWrap::GetCharacterBounds( sal_Int32 
nIndex, tools::Rectangl
 {
 // create a caret bounding rect that has the height of the
 // current font and is one pixel wide.
-rRect.Left() = mrDev.GetTextWidth(maText);
-rRect.Top() = 0;
+rRect.SetLeft( mrDev.GetTextWidth(maText) );
+rRect.SetTop( 0 );
 rRect.SetSize( Size(mrDev.GetTextHeight(), 1) );
 }
 else
 {
 long aXArray[2];
 mrDev.GetCaretPositions( maText, aXArray, nIndex, 1 );
-rRect.Left() = 0;
-rRect.Top() = 0;
+rRect.SetLeft( 0 );
+rRect.SetTop( 0 );
 rRect.SetSize( Size(mrDev.GetTextHeight(), labs(aXArray[0] - 
aXArray[1])) );
 rRect.Move( std::min(aXArray[0], aXArray[1]), 0 );
 }
diff --git a/editeng/source/editeng/editdoc.cxx 
b/editeng/source/editeng/editdoc.cxx
index d7caea2f78df..55fe0bac0114 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ 

[Libreoffice-commits] core.git: 2 commits - filter/source include/vcl

[Noel Grandin]

 filter/source/graphicfilter/ieps/ieps.cxx |   22 +++---
 filter/source/graphicfilter/itga/itga.cxx |2 +-
 include/vcl/BitmapTools.hxx   |4 +++-
 3 files changed, 11 insertions(+), 17 deletions(-)

New commits:
commit f9e611478f7b5d07a6d623ee04ed3a5ea6b1156e
Author: Noel Grandin 
Date:   Mon Feb 12 15:16:02 2018 +0200

use RawBitmap in ipsGraphicImport

part of making Bitmap an internal detail of vcl

Change-Id: Idbc44c29292e7136e6bb09b8472a396e15e5bc68
Reviewed-on: https://gerrit.libreoffice.org/49663
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/filter/source/graphicfilter/ieps/ieps.cxx 
b/filter/source/graphicfilter/ieps/ieps.cxx
index 2808975ff5e1..a2d94c45faac 100644
--- a/filter/source/graphicfilter/ieps/ieps.cxx
+++ b/filter/source/graphicfilter/ieps/ieps.cxx
@@ -29,7 +29,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -656,16 +656,13 @@ ipsGraphicImport( SvStream & rStream, Graphic & rGraphic, 
FilterConfigItem* )
 {
 rStream.Seek( nBufStartPos + ( pDest - pBuf.get() ) );
 
-Bitmap aBitmap( Size( nWidth, nHeight ), 1 );
-BitmapWriteAccess* pAcc = aBitmap.AcquireWriteAccess();
-if ( pAcc )
+vcl::bitmap::RawBitmap aBitmap( Size( nWidth, nHeight 
) );
 {
 bool bIsValid = true;
 sal_uInt8 nDat = 0;
 char nByte;
 for (long y = 0; bIsValid && y < nHeight; ++y)
 {
-Scanline pScanline = pAcc->GetScanline( y );
 int nBitsLeft = 0;
 for (long x = 0; x < nWidth; ++x)
 {
@@ -715,10 +712,10 @@ ipsGraphicImport( SvStream & rStream, Graphic & rGraphic, 
FilterConfigItem* )
 if (!bIsValid)
 break;
 if ( nBitDepth == 1 )
-pAcc->SetPixelOnData( pScanline, x, 
BitmapColor(static_cast(nDat >> nBitsLeft) & 1) );
+aBitmap.SetPixel( y, x, 
Color(static_cast(nDat >> nBitsLeft) & 1) );
 else
 {
-pAcc->SetPixelOnData( pScanline, x, 
BitmapColor(nDat ? 1 : 0) );  // nBitDepth == 8
+aBitmap.SetPixel( y, x, nDat ? 
COL_WHITE : COL_BLACK );  // nBitDepth == 8
 nBitsLeft = 0;
 }
 }
@@ -727,15 +724,11 @@ ipsGraphicImport( SvStream & rStream, Graphic & rGraphic, 
FilterConfigItem* )
 {
 ScopedVclPtrInstance pVDev;
 GDIMetaFile aMtf;
-SizeaSize;
+SizeaSize( nWidth, nHeight );
 pVDev->EnableOutput( false );
 aMtf.Record( pVDev );
-aSize = aBitmap.GetPrefSize();
-if( !aSize.Width() || !aSize.Height() )
-aSize = 
Application::GetDefaultDevice()->PixelToLogic(aBitmap.GetSizePixel(), 
MapMode(MapUnit::Map100thMM));
-else
-aSize = OutputDevice::LogicToLogic(aSize, 
aBitmap.GetPrefMapMode(), MapMode(MapUnit::Map100thMM));
-pVDev->DrawBitmap( Point(), aSize, aBitmap );
+aSize = OutputDevice::LogicToLogic(aSize, 
MapMode(), MapMode(MapUnit::Map100thMM));
+pVDev->DrawBitmapEx( Point(), aSize, 
vcl::bitmap::CreateFromData(std::move(aBitmap)) );
 aMtf.Stop();
 aMtf.WindStart();
 
aMtf.SetPrefMapMode(MapMode(MapUnit::Map100thMM));
@@ -743,7 +736,6 @@ ipsGraphicImport( SvStream & rStream, Graphic & rGraphic, 
FilterConfigItem* )
 aGraphic = aMtf;
 bHasPreview = bRetValue = true;
 }
-Bitmap::ReleaseAccess( pAcc );
 }
 }
 }
commit 83330a608d0e0be9735d00ae5d60ba262bd235c3
Author: Noel Grandin 
Date:   Mon Feb 12 14:07:24 2018 +0200

use Color, not BitmapColor in 

[Libreoffice-commits] core.git: reportdesign/source

[Julien Nabet]

 reportdesign/source/ui/report/ReportController.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit c8e19544cdc506dfc91dbd8045da208ded7d7d2c
Author: Julien Nabet 
Date:   Tue Feb 13 22:44:41 2018 +0100

Fix an assert in ReportController (reportdesign)

2  0x7739afca in __assert_fail_base (fmt=0x774eb890 "%s%s%s:%u: 
%s%sAssertion `%s' failed.
%n", assertion=assertion@entry=0x7131fb10 
"((*pImpl->mpStaticDefaults)[n]->Which() == n + pImpl->mnStart) && \"static 
defaults not sorted\"", file=file@entry=0x7131f920 
"/home/julien/lo/libreoffice/svl/source/items/itempool.cxx", 
line=line@entry=247, function=function@entry=0x71320bc0 
 >*)::__PRETTY_FUNCTION__> "void 
SfxItemPool::SetDefaults(std::__debug::vector*)") at assert.c:92
3  0x7739b042 in __GI___assert_fail (assertion=0x7131fb10 
"((*pImpl->mpStaticDefaults)[n]->Which() == n + pImpl->mnStart) && \"static 
defaults not sorted\"", file=0x7131f920 
"/home/julien/lo/libreoffice/svl/source/items/itempool.cxx", line=247, 
function=0x71320bc0 
 >*)::__PRETTY_FUNCTION__> "void 
SfxItemPool::SetDefaults(std::__debug::vector*)") at assert.c:101
4  0x711495f5 in 
SfxItemPool::SetDefaults(std::__debug::vector >*) (this=0x5bfec850, pDefaults=0x7fff1c40)
at /home/julien/lo/libreoffice/svl/source/items/itempool.cxx:246
5  0x7fff9b4df1d0 in 
rptui::OReportController::openPageDialog(com::sun::star::uno::Reference
 const&) (this=
0x58a94490, _xSection=empty uno::Reference) at 
/home/julien/lo/libreoffice/reportdesign/source/ui/report/ReportController.cxx:2392

Should stick with the order defined in include/svx/xdef.hxx

Change-Id: I1a6ca5b5cb9ccb87d0cf373f93e2d0bd401bd1ce
Reviewed-on: https://gerrit.libreoffice.org/49689
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/reportdesign/source/ui/report/ReportController.cxx 
b/reportdesign/source/ui/report/ReportController.cxx
index 6797b341194a..eb01ee3810c4 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -2328,14 +2328,14 @@ void OReportController::openPageDialog(const 
uno::Reference& _
 { XATTR_FILLBMP_POS,true },
 { XATTR_FILLBMP_SIZEX,  true },
 { XATTR_FILLBMP_SIZEY,  true },
+{ XATTR_FILLFLOATTRANSPARENCE,  true },
+{ XATTR_SECONDARYFILLCOLOR, true },
 { XATTR_FILLBMP_SIZELOG,true },
 { XATTR_FILLBMP_TILEOFFSETX,true },
 { XATTR_FILLBMP_TILEOFFSETY,true },
 { XATTR_FILLBMP_STRETCH,true },
 { XATTR_FILLBMP_POSOFFSETX, true },
 { XATTR_FILLBMP_POSOFFSETY, true },
-{ XATTR_FILLFLOATTRANSPARENCE,  true },
-{ XATTR_SECONDARYFILLCOLOR, true },
 { XATTR_FILLBACKGROUND, true },
 { SID_ATTR_METRIC,  true }
 };
@@ -2377,14 +2377,14 @@ void OReportController::openPageDialog(const 
uno::Reference& _
 new XFillBmpPosItem,
 new XFillBmpSizeXItem,
 new XFillBmpSizeYItem,
+new XFillFloatTransparenceItem(aNullGrad, false),
+new XSecondaryFillColorItem("", aNullFillCol),
 new XFillBmpSizeLogItem,
 new XFillBmpTileOffsetXItem,
 new XFillBmpTileOffsetYItem,
 new XFillBmpStretchItem,
 new XFillBmpPosOffsetXItem,
 new XFillBmpPosOffsetYItem,
-new XFillFloatTransparenceItem(aNullGrad, false),
-new XSecondaryFillColorItem("", aNullFillCol),
 new XFillBackgroundItem,
 new SfxUInt16Item(RPTUI_ID_METRIC,static_cast(eUserMetric))
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115700] New: Title property of document reverts to previous value when document is saved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115700

Bug ID: 115700
   Summary: Title property of document reverts to previous value
when document is saved
   Product: LibreOffice
   Version: 5.4.5.1 release
  Hardware: x86 (IA32)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jas...@globalacoustics.com.au

Description:
After updating the title property of a Writer document, the property is not
saved. Instead when save is clicked the title reverts back to it's previous
value, making it impossible to update the title of a document.

Steps to Reproduce:
1. Open a Writer document that has a value in the Title property
2. Change the Title to a different value
3. Save the document

Actual Results:  
The title property reverts to original value before saving.

Expected Results:
The new title property value should remain after saving


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 5.4.5.1
Build ID: 79c9829dd5d8054ec39a82dc51cd9eff340dbee8
CPU threads: 4; OS: Linux 3.19; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

Aron Budea  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #8 from Aron Budea  ---
Eike, here are my thoughts on this bug, but the big picture is still unclear,
can you please advise on how to approach it?

The immediate cause of this is that when exporting the built-in defined range,
it takes Excel's limits for colummns, which is 16384...

https://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/xename.cxx#613
// *** 2) print titles *** 
...


...then later, when XclExpNameManagerImpl::CreateName(...) is called, it checks
for an existing built-in range name, but also tries to match the range, which
is still 1024 here, so they won't match.
If the two matched, then as far as I can see, it would update the built-in
range based on the defined one. However, first it checks if the two token
arrays match... when could this work sensibly?

https://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/xename.cxx#555
/*  Try to replace by existing built-in name - complete token array is
needed for comparison, and due to the recursion problem above this
cannot be done earlier. If a built-in name is found, the created NAME
record for this name and all following records in the list must be
deleted, otherwise they may contain wrong name list indexes. */
sal_uInt16 nBuiltInIdx = FindBuiltInNameIdx( rName, *xTokArr );


It's not clear to me why the built-in named ranges are gathered both directly
from the respective spreadsheet settings, and also from regular named ranges
(as imported). Would it make sense to either only match based on names, or even
do away with the double handling of built-in names?

And indeed, when revisiting bug 112571 after its fix, as soon as the user
updates the print ranges, those names are duplicated again because of the
double handling and range-checking.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115699] New: ppt slideshow is not working on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115699

Bug ID: 115699
   Summary: ppt slideshow is not working on lo viewer master daily
build
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Created attachment 139888
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139888=edit
screenshot ppt

steps to reproduce:

open attachment 46869 on Bug# 37324
tap slideshow

current behaviour:
slide is blank

expected behaviour:
view content

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-12 15:26:16
tinderbox: git sha1s
core:9cf2616c5e709b5956ab88dacdfad2003f98

lyf flame 3, android 5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115207] Shapes should format text with word wrapping by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115207

Luke  changed:

   What|Removed |Added

   Keywords||needsDevAdvice

--- Comment #2 from Luke  ---
Two More data points. Both WordPerfect Office X7 and WPS Office default to wrap
text in the shape. So in order to be internally consistent and follow the
industry standard, this default makes perfect sense. 


Put a needs needsDevAdvice since this sounds like it should be added as an
easyHack.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/liborcus

[Kohei Yoshida]

 external/liborcus/0001-xls-xml-Import-hidden-row-and-column-flags.patch |   81 
++
 external/liborcus/UnpackedTarball_liborcus.mk   |1 
 2 files changed, 82 insertions(+)

New commits:
commit 9dbc3ffec050c880bb46e0edbdb9cd4a6241c9eb
Author: Kohei Yoshida 
Date:   Tue Feb 13 22:25:20 2018 -0500

Pick up hidden row and column flags when importing via orcus.

Change-Id: Idf2530935eb93339602ac5f6a5d0547aa56b453a
Reviewed-on: https://gerrit.libreoffice.org/49695
Tested-by: Jenkins 
Reviewed-by: Kohei Yoshida 

diff --git 
a/external/liborcus/0001-xls-xml-Import-hidden-row-and-column-flags.patch 
b/external/liborcus/0001-xls-xml-Import-hidden-row-and-column-flags.patch
new file mode 100644
index ..15a554a79cff
--- /dev/null
+++ b/external/liborcus/0001-xls-xml-Import-hidden-row-and-column-flags.patch
@@ -0,0 +1,81 @@
+From 66bbbd42f5d135b7e7dd57eaa7fdf6fd69c664df Mon Sep 17 00:00:00 2001
+From: Kohei Yoshida 
+Date: Tue, 13 Feb 2018 22:15:49 -0500
+Subject: [PATCH] xls-xml: Import hidden row and column flags.
+
+(cherry picked from commit 95420c1a1e8c082bb5953b2a49f0d56eef0e5f7e)
+---
+ src/liborcus/xls_xml_context.cpp | 20 ++--
+ 1 file changed, 18 insertions(+), 2 deletions(-)
+
+diff --git a/src/liborcus/xls_xml_context.cpp 
b/src/liborcus/xls_xml_context.cpp
+index 917ff86..04b863a 100644
+--- a/src/liborcus/xls_xml_context.cpp
 b/src/liborcus/xls_xml_context.cpp
+@@ -1222,6 +1222,7 @@ void xls_xml_context::start_element_column(const 
xml_token_pair_t& parent, const
+ spreadsheet::col_t col_index = m_cur_prop_col;
+ spreadsheet::col_t span = 0;
+ double width = 0.0;
++bool hidden = false;
+ 
+ std::for_each(attrs.begin(), attrs.end(),
+ [&](const xml_token_attr_t& attr)
+@@ -1244,6 +1245,8 @@ void xls_xml_context::start_element_column(const 
xml_token_pair_t& parent, const
+ case XML_Span:
+ span = to_long(attr.value);
+ break;
++case XML_Hidden:
++hidden = to_long(attr.value) != 0;
+ default:
+ ;
+ }
+@@ -1251,8 +1254,11 @@ void xls_xml_context::start_element_column(const 
xml_token_pair_t& parent, const
+ );
+ 
+ for (; span >= 0; --span, ++col_index)
++{
+ // Column widths are stored as points.
+ mp_sheet_props->set_column_width(col_index, width, 
orcus::length_unit_t::point);
++mp_sheet_props->set_column_hidden(col_index, hidden);
++}
+ 
+ m_cur_prop_col = col_index;
+ }
+@@ -1263,6 +1269,7 @@ void xls_xml_context::start_element_row(const 
xml_token_pair_t& parent, const xm
+ m_cur_col = 0;
+ spreadsheet::row_t row_index = -1;
+ bool has_height = false;
++bool hidden = false;
+ double height = 0.0;
+ 
+ for (const xml_token_attr_t& attr : attrs)
+@@ -1281,6 +1288,9 @@ void xls_xml_context::start_element_row(const 
xml_token_pair_t& parent, const xm
+ has_height = true;
+ height = to_double(attr.value);
+ break;
++case XML_Hidden:
++hidden = to_long(attr.value) != 0;
++break;
+ default:
+ ;
+ }
+@@ -1293,8 +1303,14 @@ void xls_xml_context::start_element_row(const 
xml_token_pair_t& parent, const xm
+ m_cur_row = row_index - 1;
+ }
+ 
+-if (mp_sheet_props && has_height)
+-mp_sheet_props->set_row_height(m_cur_row, height, 
length_unit_t::point);
++if (mp_sheet_props)
++{
++if (has_height)
++mp_sheet_props->set_row_height(m_cur_row, height, 
length_unit_t::point);
++
++if (hidden)
++mp_sheet_props->set_row_hidden(m_cur_row, true);
++}
+ }
+ 
+ void xls_xml_context::end_element_borders()
+-- 
+2.7.4
+
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk 
b/external/liborcus/UnpackedTarball_liborcus.mk
index a35ad9eec002..92e461f95e57 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -21,6 +21,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\

external/liborcus/0001-Alpha-value-of-0-means-fully-transparent.-I-m-sure-2.patch
 \

external/liborcus/0002-We-are-supposed-to-use-the-foreground-color-for-soli.patch
 \
external/liborcus/0001-xls-xml-Pick-up-border-colors.patch \
+   external/liborcus/0001-xls-xml-Import-hidden-row-and-column-flags.patch 
\
 ))
 
 ifeq ($(OS),WNT)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115602] Disabled toolbox items in the Sidebar Navigator deck are accessible when using keyboard navigation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115602

Jim Raykowski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115698] fileopen fods a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115698

krishna [:kr1shna]  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5697

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115697] fileopen ods a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115697

krishna [:kr1shna]  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5698

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115695] fileopen xls a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115695

krishna [:kr1shna]  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5696

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115696] fileopen xlsx a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115696

krishna [:kr1shna]  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5695

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115620] Performing of a Find Text operation Switches the Object Type of the “Navigate By” Drop-down Menu to “Repeat Search”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115620

Thorsten Behrens (CIB)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115620] Performing of a Find Text operation Switches the Object Type of the “Navigate By” Drop-down Menu to “Repeat Search”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115620

Thorsten Behrens (CIB)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||t...@libreoffice.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115620] Performing of a Find Text operation Switches the Object Type of the “Navigate By” Drop-down Menu to “Repeat Search”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115620

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski]

 sw/source/uibase/uiview/viewsrch.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit eb975197b62204062393979e33438a3a4e2d27c1
Author: Jim Raykowski 
Date:   Mon Feb 12 23:43:00 2018 -0900

tdf#115620 Prevent "Find Text" changing "Navigate By"

Change-Id: I46ab436e98f0d24e51277f22b2a707dfd5e2937c
Reviewed-on: https://gerrit.libreoffice.org/49690
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/uibase/uiview/viewsrch.cxx 
b/sw/source/uibase/uiview/viewsrch.cxx
index f377f35acdfe..d2932070dc89 100644
--- a/sw/source/uibase/uiview/viewsrch.cxx
+++ b/sw/source/uibase/uiview/viewsrch.cxx
@@ -198,6 +198,7 @@ void SwView::ExecSearch(SfxRequest& rReq)
 case FN_REPEAT_SEARCH:
 case FID_SEARCH_NOW:
 {
+sal_uInt16 nMoveType = SwView::GetMoveType();
 {
 if(FID_SEARCH_NOW == nSlot && !rReq.IsAPI())
 SwView::SetMoveType(NID_SRCH_REP);
@@ -396,6 +397,7 @@ void SwView::ExecSearch(SfxRequest& rReq)
 }
 #endif
 m_bFound = false;
+SwView::SetMoveType(nMoveType);
 return;
 }
 
@@ -425,6 +427,7 @@ void SwView::ExecSearch(SfxRequest& rReq)
 
 rReq.Done();
 m_eLastSearchCommand = m_pSrchItem->GetCommand();
+SwView::SetMoveType(nMoveType);
 }
 break;
 case FID_SEARCH_SEARCHSET:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115620] Performing of a Find Text operation Switches the Object Type of the “Navigate By” Drop-down Menu to “Repeat Search”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115620

--- Comment #2 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb975197b62204062393979e33438a3a4e2d27c1

tdf#115620 Prevent "Find Text" changing "Navigate By"

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115698] fileopen fods a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115698

--- Comment #1 from krishna [:kr1shna]  ---
Created attachment 139887
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139887=edit
screenshot fods

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115698] New: fileopen fods a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115698

Bug ID: 115698
   Summary: fileopen fods a1 cell is black on lo viewer master
daily build
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Created attachment 139886
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139886=edit
test file fods

open attachment fods.fods

current behaviour:
a1 cell is black

expected behaviour:
display content

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-12 15:26:16
tinderbox: git sha1s
core:9cf2616c5e709b5956ab88dacdfad2003f98

lyf flame 3, android 5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115697] New: fileopen ods a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115697

Bug ID: 115697
   Summary: fileopen ods a1 cell is black on lo viewer master
daily build
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Created attachment 139885
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139885=edit
screenshot ods

attachment 61416 on Bug# 49773

current behaviour:
a1 cell is black

expected behaviour:
display content

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-12 15:26:16
tinderbox: git sha1s
core:9cf2616c5e709b5956ab88dacdfad2003f98

lyf flame 3, android 5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86512] EDITING: Some objects displaced upon paste

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86512

--- Comment #15 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96290] Calc doesn' t answer for several minutes when searching and replacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96290

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115696] New: fileopen xlsx a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115696

Bug ID: 115696
   Summary: fileopen xlsx a1 cell is black on lo viewer master
daily build
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Created attachment 139884
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139884=edit
screenshot xlsx

attachment 73054 on Bug# 59399

current behaviour:
a1 cell is black

expected behaviour:
display content

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-12 15:26:16
tinderbox: git sha1s
core:9cf2616c5e709b5956ab88dacdfad2003f98

lyf flame 3, android 5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115695] New: fileopen xls a1 cell is black on lo viewer master daily build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115695

Bug ID: 115695
   Summary: fileopen xls a1 cell is black on lo viewer master
daily build
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Created attachment 139883
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139883=edit
screenshot xls

attachment 63733 on Bug# 51671

current behaviour:
a1 cell is black

expected behaviour:
display content

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-12 15:26:16
tinderbox: git sha1s
core:9cf2616c5e709b5956ab88dacdfad2003f98

lyf flame 3, android 5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/inc oox/source sd/qa

[Tamás Zolnai]

 oox/inc/drawingml/textparagraphproperties.hxx   |4 +
 oox/inc/drawingml/textparagraphpropertiescontext.hxx|1 
 oox/source/drawingml/textparagraphproperties.cxx|   11 
 oox/source/drawingml/textparagraphpropertiescontext.cxx |   17 +++---
 sd/qa/unit/data/pptx/tdf51340.pptx  |binary
 sd/qa/unit/import-tests.cxx |   42 
 6 files changed, 66 insertions(+), 9 deletions(-)

New commits:
commit 53551d49d3be2301985f2cf2d8bb23ff374ecfd1
Author: Tamás Zolnai 
Date:   Wed Feb 14 02:15:54 2018 +0100

tdf#51340: Line spacing is imported incorrectly from PPTX

Move the line spacing member to the TextParagraphProperties class
which is used to do the inheritance from master / layout slides.

Change-Id: I0bf92420963163eae78e06ebc7fdfa1f2c72fdf8
Reviewed-on: https://gerrit.libreoffice.org/49692
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/oox/inc/drawingml/textparagraphproperties.hxx 
b/oox/inc/drawingml/textparagraphproperties.hxx
index cac6d64f0447..2710dcb484b2 100644
--- a/oox/inc/drawingml/textparagraphproperties.hxx
+++ b/oox/inc/drawingml/textparagraphproperties.hxx
@@ -97,6 +97,9 @@ public:
 boost::optional< css::style::ParagraphAdjust >&   getParaAdjust() { 
return moParaAdjust; }
 voidsetParaAdjust( 
css::style::ParagraphAdjust nParaAdjust ) { moParaAdjust = nParaAdjust; }
 
+TextSpacing&getLineSpacing() { return 
maLineSpacing; }
+voidsetLineSpacing( const TextSpacing& 
rLineSpacing ) { maLineSpacing = rLineSpacing; }
+
 voidapply( const TextParagraphProperties& 
rSourceProps );
 voidpushToPropSet( const 
::oox::core::XmlFilterBase* pFilterBase,
 const css::uno::Reference < 
css::beans::XPropertySet > & xPropSet,
@@ -126,6 +129,7 @@ protected:
 boost::optional< sal_Int32 >moFirstLineIndentation;
 boost::optional< css::style::ParagraphAdjust >moParaAdjust;
 sal_Int16   mnLevel;
+TextSpacing maLineSpacing;
 };
 
 } }
diff --git a/oox/inc/drawingml/textparagraphpropertiescontext.hxx 
b/oox/inc/drawingml/textparagraphpropertiescontext.hxx
index 2de92b5b05ab..3cd2d0d375b4 100644
--- a/oox/inc/drawingml/textparagraphpropertiescontext.hxx
+++ b/oox/inc/drawingml/textparagraphpropertiescontext.hxx
@@ -42,7 +42,6 @@ public:
 
 private:
 TextParagraphProperties& mrTextParagraphProperties;
-TextSpacing maLineSpacing;
 BulletList& mrBulletList;
 std::vector< css::style::TabStop >  maTabList;
 std::shared_ptr< BlipFillProperties > mxBlipProps;
diff --git a/oox/source/drawingml/textparagraphproperties.cxx 
b/oox/source/drawingml/textparagraphproperties.cxx
index c36912bb9dca..8f4e635db48c 100644
--- a/oox/source/drawingml/textparagraphproperties.cxx
+++ b/oox/source/drawingml/textparagraphproperties.cxx
@@ -388,6 +388,8 @@ void TextParagraphProperties::apply( const 
TextParagraphProperties& rSourceProps
 mnLevel = rSourceProps.mnLevel;
 if( rSourceProps.moParaAdjust )
 moParaAdjust = rSourceProps.moParaAdjust;
+if( rSourceProps.maLineSpacing.bHasValue )
+maLineSpacing = rSourceProps.maLineSpacing;
 }
 
 void TextParagraphProperties::pushToPropSet( const ::oox::core::XmlFilterBase* 
pFilterBase,
@@ -486,6 +488,15 @@ void TextParagraphProperties::pushToPropSet( const 
::oox::core::XmlFilterBase* p
 {
 aPropSet.setProperty( PROP_ParaAdjust, 
css::style::ParagraphAdjust_LEFT);
 }
+
+if ( maLineSpacing.bHasValue )
+{
+aPropSet.setProperty( PROP_ParaLineSpacing, 
maLineSpacing.toLineSpacing());
+}
+else
+{
+aPropSet.setProperty( PROP_ParaLineSpacing, css::style::LineSpacing( 
css::style::LineSpacingMode::PROP, 100 ));
+}
 }
 
 float TextParagraphProperties::getCharHeightPoints( float fDefault ) const
diff --git a/oox/source/drawingml/textparagraphpropertiescontext.cxx 
b/oox/source/drawingml/textparagraphpropertiescontext.cxx
index fdc9c3f210a9..5cf1750dec4e 100644
--- a/oox/source/drawingml/textparagraphpropertiescontext.cxx
+++ b/oox/source/drawingml/textparagraphpropertiescontext.cxx
@@ -133,8 +133,8 @@ 
TextParagraphPropertiesContext::TextParagraphPropertiesContext( ContextHandler2H
 TextParagraphPropertiesContext::~TextParagraphPropertiesContext()
 {
 PropertyMap& rPropertyMap( 
mrTextParagraphProperties.getTextParagraphPropertyMap() );
-if ( maLineSpacing.bHasValue )
-rPropertyMap.setProperty( PROP_ParaLineSpacing, 
maLineSpacing.toLineSpacing());
+if ( mrTextParagraphProperties.getLineSpacing().bHasValue )
+rPropertyMap.setProperty( PROP_ParaLineSpacing, 

[Libreoffice-bugs] [Bug 115694] Insert > Images - Stripes appear on images (" =?UTF-8?Q?=D0=92=D1=81=D1=82=D0=B0=D0=B2=D0=B8=D1=82=D1=8C?=" картинку - картинка выглядит перечеркнутая п =?UTF-8?Q?=

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115694

--- Comment #3 from Kevin Suo  ---
@Павел: Please copy-paste the information from "Help > About LibreOffice"
dialog.

Also check whether OpenGL is enabled. If yes, please disable it and see whether
the bug still exist. (Tools > Options > LibreOffice > View > Enable OpenGL for
all rendering)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115694] Insert > Images - Stripes appear on images (" =?UTF-8?Q?=D0=92=D1=81=D1=82=D0=B0=D0=B2=D0=B8=D1=82=D1=8C?=" картинку - картинка выглядит перечеркнутая п =?UTF-8?Q?=

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115694

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com
Summary|"Вставить" картинку -   |Insert > Images - Stripes
   |картинка выглядит   |appear on images
   |перечеркнутая полосами. |("Вставить" картинку -
   ||картинка выглядит
   ||перечеркнутая полосами.)

--- Comment #2 from Kevin Suo  ---
>From Google Translation:

In previous versions it was normal, but this time is not normal.
I copy the text with a picture from the Internet, I paste it into a text
editor, but the picture is striped.

Created attachment 139881
Crossed Stripes Picture

LibreOffice 6.0 suits me - an excellent editor. But the latest version
disappointed the problem with the pictures - the inserted pictures look crossed
out by strips.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115557] FILEOPEN DOCX Charts in footnotes multiply with every open and save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115557

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|5.4.2.2 release |5.1.0.3 release
 Ever confirmed|0   |1

--- Comment #7 from Aron Budea  ---
Repro with LO 6.0.1.1 & 5.1.0.3 / Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115521] FILESAVE DOCX Change tracking of deleted empty paragraphs is removed on save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115521

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Blocks||107830
 Ever confirmed|0   |1

--- Comment #3 from Aron Budea  ---
Confirmed using LO 6.0.1.1 / Windows 7.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107830
[Bug 107830] [META] DOCX (OOXML) paragraph-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107830] [META] DOCX (OOXML) paragraph-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107830

Aron Budea  changed:

   What|Removed |Added

 Depends on||115521


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115521
[Bug 115521] FILESAVE DOCX Change tracking of deleted empty paragraphs is
removed on save
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source sc/uiconfig sc/UIConfig_scalc.mk

[Markus Mohrhard]

 sc/UIConfig_scalc.mk  |2 
 sc/source/ui/miscdlgs/dataproviderdlg.cxx |   79 ++
 sc/uiconfig/scalc/ui/deletecolumnentry.ui |   68 ++
 sc/uiconfig/scalc/ui/mergecolumnentry.ui  |   89 ++
 4 files changed, 227 insertions(+), 11 deletions(-)

New commits:
commit d0aca687f654eff81b86540007e7c8606ab00e1f
Author: Markus Mohrhard 
Date:   Thu Feb 8 22:46:59 2018 +0100

init the selected columns in data transformations dialog

Change-Id: Ie1d9213ba4f0d88e09a368fa778c77de3e89492f
Reviewed-on: https://gerrit.libreoffice.org/49458
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk
index 845ede98034b..2e8c1ad945c3 100644
--- a/sc/UIConfig_scalc.mk
+++ b/sc/UIConfig_scalc.mk
@@ -116,6 +116,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\
sc/uiconfig/scalc/ui/definedatabaserangedialog \
sc/uiconfig/scalc/ui/definename \
sc/uiconfig/scalc/ui/deletecells \
+   sc/uiconfig/scalc/ui/deletecolumnentry \
sc/uiconfig/scalc/ui/deletecontents \
sc/uiconfig/scalc/ui/descriptivestatisticsdialog \
sc/uiconfig/scalc/ui/dropmenu \
@@ -152,6 +153,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\
sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact \
sc/uiconfig/scalc/ui/managenamesdialog \
sc/uiconfig/scalc/ui/mergecellsdialog \
+   sc/uiconfig/scalc/ui/mergecolumnentry \
sc/uiconfig/scalc/ui/movecopysheet \
sc/uiconfig/scalc/ui/movingaveragedialog \
sc/uiconfig/scalc/ui/multipleoperationsdialog \
diff --git a/sc/source/ui/miscdlgs/dataproviderdlg.cxx 
b/sc/source/ui/miscdlgs/dataproviderdlg.cxx
index 11fa52ee2927..78953cb3d4fd 100644
--- a/sc/source/ui/miscdlgs/dataproviderdlg.cxx
+++ b/sc/source/ui/miscdlgs/dataproviderdlg.cxx
@@ -13,6 +13,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 
 constexpr int MENU_START = 0;
@@ -202,7 +204,6 @@ IMPL_LINK_NOARG(ScDataProviderBaseControl, ApplyBtnHdl, 
Button*, void)
 maImportCallback.Call(this);
 }
 
-
 namespace {
 
 struct MenuData
@@ -275,9 +276,10 @@ class ScSplitColumnTransformationControl : public 
ScDataTransformationBaseContro
 private:
 VclPtr maSeparator;
 VclPtr maNumColumns;
+SCCOL mnCol;
 
 public:
-ScSplitColumnTransformationControl(vcl::Window* pParent);
+ScSplitColumnTransformationControl(vcl::Window* pParent, SCCOL nCol);
 ~ScSplitColumnTransformationControl() override;
 
 virtual void dispose() override;
@@ -285,8 +287,9 @@ public:
 virtual std::shared_ptr getTransformation() 
override;
 };
 
-ScSplitColumnTransformationControl::ScSplitColumnTransformationControl(vcl::Window*
 pParent):
-ScDataTransformationBaseControl(pParent, 
"modules/scalc/ui/splitcolumnentry.ui")
+ScSplitColumnTransformationControl::ScSplitColumnTransformationControl(vcl::Window*
 pParent, SCCOL nCol):
+ScDataTransformationBaseControl(pParent, 
"modules/scalc/ui/splitcolumnentry.ui"),
+mnCol(nCol)
 {
 get(maSeparator, "ed_separator");
 get(maNumColumns, "num_cols");
@@ -307,28 +310,76 @@ void ScSplitColumnTransformationControl::dispose()
 
 std::shared_ptr 
ScSplitColumnTransformationControl::getTransformation()
 {
-return std::make_shared(0, ',');
+OUString aSeparator = maSeparator->GetText();
+sal_Unicode cSeparator = aSeparator.isEmpty() ? ',' : aSeparator[0];
+return std::make_shared(mnCol, cSeparator);
 }
 
 class ScMergeColumnTransformationControl : public 
ScDataTransformationBaseControl
 {
 private:
 
+VclPtr mpSeparator;
+VclPtr mpEdColumns;
+
 public:
-ScMergeColumnTransformationControl(vcl::Window* pParent);
+ScMergeColumnTransformationControl(vcl::Window* pParent, SCCOL nStartCol, 
SCCOL nEndCol);
+~ScMergeColumnTransformationControl() override;
+
+virtual void dispose() override;
 
 virtual std::shared_ptr getTransformation() 
override;
 };
 
-ScMergeColumnTransformationControl::ScMergeColumnTransformationControl(vcl::Window*
 pParent):
+ScMergeColumnTransformationControl::ScMergeColumnTransformationControl(vcl::Window*
 pParent, SCCOL nStartCol, SCCOL nEndCol):
 ScDataTransformationBaseControl(pParent, 
"modules/scalc/ui/mergecolumnentry.ui")
 {
+get(mpSeparator, "ed_separator");
+get(mpEdColumns, "ed_columns");
+
+OUStringBuffer aBuffer;
+
+// map from zero based to one based column numbers
+aBuffer.append(OUString::number(nStartCol + 1));
+for ( SCCOL nCol = nStartCol + 1; nCol <= nEndCol; ++nCol)
+{
+aBuffer.append(";").append(OUString::number(nCol + 1));
+}
+
+mpEdColumns->SetText(aBuffer.makeStringAndClear());
+}
+
+ScMergeColumnTransformationControl::~ScMergeColumnTransformationControl()
+{
+disposeOnce();
+}
+
+void 

[Libreoffice-bugs] [Bug 115161] FILESAVE DOCX Overlapping Shape and Field disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115161

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
Version|5.4.4.2 release |4.4.0.3 release
 Blocks||104442, 112969
 Ever confirmed|0   |1

--- Comment #4 from Aron Budea  ---
Reproduced using LO 6.0.1.1 & 4.4.0.3 / Windows 7.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
[Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112969
[Bug 112969] [META] DOCX (OOXML) field-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112969] [META] DOCX (OOXML) field-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112969

Aron Budea  changed:

   What|Removed |Added

 Depends on||115161


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115161
[Bug 115161] FILESAVE DOCX Overlapping Shape and Field disappear
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104442

Aron Budea  changed:

   What|Removed |Added

 Depends on||115161


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115161
[Bug 115161] FILESAVE DOCX Overlapping Shape and Field disappear
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115523] EDITING Track Changes: Writer does not show the change in number of deleted numbered paragraphs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115523

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |5524|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42748] EDITING: Numbering in numbered list doesn' t show when affected by tracked changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42748

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |5524|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115524] EDITING Track Changes does not show the change in number of added numbered paragraphs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115524

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=42 |
   |748 |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 115524, which changed state.

Bug 115524 Summary: EDITING Track Changes does not show the change in  number 
of added numbered paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=115524

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115683] When CSV file importing to calc, if LibreOffice already open, text import dialog box open behind a grey window.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115683

V Stuart Foote  changed:

   What|Removed |Added

 CC||chris.sherloc...@gmail.com,
   ||vstuart.fo...@utsa.edu

--- Comment #5 from V Stuart Foote  ---
Hey Chris, care to flex your new macOS skills?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42748] EDITING: Numbering in numbered list doesn' t show when affected by tracked changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42748

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5524

--- Comment #12 from Aron Budea  ---
*** Bug 115524 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115524] EDITING Track Changes does not show the change in number of added numbered paragraphs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115524

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   See Also|https://bugs.documentfounda |https://bugs.documentfounda
   |tion.org/show_bug.cgi?id=11 |tion.org/show_bug.cgi?id=42
   |5523|748
 Resolution|--- |DUPLICATE

--- Comment #2 from Aron Budea  ---
I think it makes sense to handle both addition and deletion in the same bug
report, so let's mark this one as duplicate as well.

*** This bug has been marked as a duplicate of bug 42748 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42748] EDITING: Numbering in numbered list doesn' t show when affected by tracked changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42748

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Version|3.3.4 release   |Inherited From OOo
Summary|Writer EDITING: Tracking|EDITING: Numbering in
   |changes not totally |numbered list doesn't show
   |consistent in numbered list |when affected by tracked
   ||changes

--- Comment #11 from Aron Budea  ---
Let's include the case when numbered items are added, numbering should reflect
that it's due to a tracked change. The cases (deletion and addition) have to be
fixed together after all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 115523, which changed state.

Bug 115523 Summary: EDITING Track Changes: Writer does not show the change in 
number of deleted numbered paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=115523

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115523] EDITING Track Changes: Writer does not show the change in number of deleted numbered paragraphs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115523

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Aron Budea  ---
Seems to be duplicate of bug 42748.

*** This bug has been marked as a duplicate of bug 42748 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42748] Writer EDITING: Tracking changes not totally consistent in numbered list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42748

Aron Budea  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com

--- Comment #10 from Aron Budea  ---
*** Bug 115523 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51340] FILEOPEN: PPTX - Master-slide style-level line spacing not applied to line that has a different paragraph-level above paragraph spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51340

Tamás Zolnai  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51340] FILEOPEN: PPTX - Master-slide style-level line spacing not applied to line that has a different paragraph-level above paragraph spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51340

Tamás Zolnai  changed:

   What|Removed |Added

 CC||zolnaitamas2...@gmail.com

--- Comment #25 from Tamás Zolnai  ---
*** Bug 115693 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115694] " Вставить " картинку - картинка выглядит перечеркнутая полосами.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115694

--- Comment #1 from Павел  ---
Created attachment 139881
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139881=edit
Картинка перечеркнутая полосами

LibreOffice 6.0 меня устраивает - отличный редактор. Но в последней версии
огорчила проблема с картинками - вставленные картинки выглядят перечеркнутыми
полосами.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114768] Preferred font order for Chinese locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114768

--- Comment #16 from Kevin Suo  ---
By the way, the screenshot named " Chinese System Font in Latest OS " is
misleading. Althrough the meanings may be correct, the exact font names in this
screenshot are wrong simplified Chinese, thus it's not safe to use these names
in the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114768] Preferred font order for Chinese locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114768

--- Comment #15 from Kevin Suo  ---
Created attachment 139880
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139880=edit
PDF file showing Simplified Chinese fonts - compare

As you can see, NSimSun is no difference with SimSun.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114768] Preferred font order for Chinese locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114768

--- Comment #14 from Kevin Suo  ---
(In reply to Yousuf Philips (jay) from comment #13)

> Was this a modification of my patch in comment 9 or something you created 
> from scratch?

>From scratch.

> From what i've seen, 新宋体 [NSimSun] (monospaced) seems to be more prevalent 
> than 宋体 [SimSun] (proportional), so you sure you want to go with SimSun?

You can put 新宋体 [NSimSun], both Chinese and english names, before SimSun. They
are quite the same fonts (see attachment pdf) shipped with different MS
versions, but any version of MS has SimSum installed.

> Traditional Chinese went with PingFang TC as the default sans, so it might be 
> good to have PingFang SC as the default sans for OSX 10.11+ users, with a 
> fallback on 华文细黑 [STXihei]. What do you think?

I agree with the Traditioinal team. Pingfang is a new font added in the new Mac
OS. So, please use 萍方-简 [PingFang SC] 

> About 华文宋体 [Songti SC], the chart in attachment 139870 [details] has 3 
> characters for the localized version of the name, similar to 宋體-繁, the 3 
> characters for Songti TC, which we are using for traditional chinese.

I my understanding, 宋体-简 is just an aliens of 华文宋体. I do not have MAC OS
installed, so I have no more comment on this. So, it may be safe to use 萍方-简
[PingFang SC]  and fall back to 宋体-简 [Songti SC]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/inc starmath/source

[Takeshi Abe]

 starmath/inc/parse.hxx|2 +-
 starmath/source/parse.cxx |   10 +++---
 starmath/source/view.cxx  |2 +-
 3 files changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 3c913c3844acae8ee0d80ab174133bdc7677efea
Author: Takeshi Abe 
Date:   Tue Feb 13 20:52:57 2018 +0900

starmath: Omit SmParser::GetError()'s argument

as it was always 0.

Change-Id: I59570967deb139f258e7aeaab17619f714bc7bb5
Reviewed-on: https://gerrit.libreoffice.org/49640
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/inc/parse.hxx b/starmath/inc/parse.hxx
index 6b8e7d8cd85b..c49f0f6ff9cf 100644
--- a/starmath/inc/parse.hxx
+++ b/starmath/inc/parse.hxx
@@ -128,7 +128,7 @@ public:
 voidAddError(SmParseError Type, SmNode *pNode);
 const SmErrorDesc*  NextError();
 const SmErrorDesc*  PrevError();
-const SmErrorDesc*  GetError(size_t i);
+const SmErrorDesc*  GetError();
 static const SmTokenTableEntry* GetTokenTableEntry( const OUString  
);
 const std::set< OUString >&   GetUsedSymbols() const  { return 
m_aUsedSymbols; }
 };
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 6c5414e25d50..9bb4530eae4e 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -2418,14 +2418,10 @@ const SmErrorDesc *SmParser::PrevError()
 }
 
 
-const SmErrorDesc *SmParser::GetError(size_t i)
+const SmErrorDesc *SmParser::GetError()
 {
-if ( i < m_aErrDescList.size() )
-return m_aErrDescList[ i ].get();
-
-if ( static_cast(m_nCurError) < m_aErrDescList.size() )
-return m_aErrDescList[ m_nCurError ].get();
-
+if ( !m_aErrDescList.empty() )
+return m_aErrDescList.front().get();
 return nullptr;
 }
 
diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index 21e3e619a978..34cff7ebedd3 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -1295,7 +1295,7 @@ void SmViewShell::SetStatusText(const OUString& rText)
 void SmViewShell::ShowError(const SmErrorDesc* pErrorDesc)
 {
 assert(GetDoc());
-if (pErrorDesc || nullptr != (pErrorDesc = 
GetDoc()->GetParser().GetError(0)) )
+if (pErrorDesc || nullptr != (pErrorDesc = 
GetDoc()->GetParser().GetError()) )
 {
 SetStatusText( pErrorDesc->m_aText );
 GetEditWindow()->MarkError( Point( pErrorDesc->m_pNode->GetColumn(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115694] New: " =?UTF-8?Q?=D0=92=D1=81=D1=82=D0=B0=D0=B2=D0=B8=D1=82=D1=8C?=" картинку - картинка выглядит перечеркнутая полосами.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115694

Bug ID: 115694
   Summary: "Вставить" картинку - картинка выглядит перечеркнутая
полосами.
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yto...@yandex.ru

Description:
 В предыдущих версиях было нормально, а сей час не нормально. 
Я копирую текст с картинкой из Интернета, вставляю в текстовый редактор, но
картинка выходит полосатая.

Actual Results:  
???

Expected Results:
???


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: ru
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no


User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: comphelper/source include/oox oox/source package/inc package/source sw/source writerfilter/source

[Ashod Nakashian]

 comphelper/source/xml/ofopxmlhelper.cxx |   18 +++
 include/oox/core/xmlfilterbase.hxx  |7 +-
 oox/source/core/xmlfilterbase.cxx   |4 -
 package/inc/ZipPackageEntry.hxx |   10 ++--
 package/source/zippackage/ZipPackage.cxx|   10 ++--
 sw/source/filter/ww8/docxexport.cxx |   14 ++---
 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |   60 ++--
 7 files changed, 56 insertions(+), 67 deletions(-)

New commits:
commit 97a73d2772a86e26369fc32e25a59c0d5a274c01
Author: Ashod Nakashian 
Date:   Tue Feb 6 17:23:58 2018 -0500

oox: cosmetic cleanup

Change-Id: Ifafd7338ddfec8b707b5ddf4acb39512faf186da
Reviewed-on: https://gerrit.libreoffice.org/49325
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/comphelper/source/xml/ofopxmlhelper.cxx 
b/comphelper/source/xml/ofopxmlhelper.cxx
index 205b8883c0d3..d3ce7b0dc65d 100644
--- a/comphelper/source/xml/ofopxmlhelper.cxx
+++ b/comphelper/source/xml/ofopxmlhelper.cxx
@@ -180,12 +180,12 @@ void WriteContentSequence(
 
 xWriter->setOutputStream( xOutStream );
 
-OUString aTypesElement( "Types" );
-OUString aDefaultElement( "Default" );
-OUString aOverrideElement( "Override" );
-OUString aContentTypeAttr( "ContentType" );
-OUString aCDATAString( "CDATA" );
-OUString aWhiteSpace( " " );
+static const OUString aTypesElement("Types");
+static const OUString aDefaultElement("Default");
+static const OUString aOverrideElement("Override");
+static const OUString aContentTypeAttr("ContentType");
+static const OUString aCDATAString("CDATA");
+static const OUString aWhiteSpace(" ");
 
 // write the namespace
 AttributeList* pRootAttrList = new AttributeList;
@@ -380,15 +380,15 @@ void SAL_CALL OFOPXMLHelper_Impl::startElement( const 
OUString& aName, const uno
 if ( m_aResultSeq.getLength() != 2 )
 throw uno::RuntimeException();
 
-OUString aExtensionValue = xAttribs->getValueByName( 
m_aExtensionAttr );
+const OUString aExtensionValue = xAttribs->getValueByName( 
m_aExtensionAttr );
 if ( aExtensionValue.isEmpty() )
 throw css::xml::sax::SAXException(); // TODO: the Extension 
value must present
 
-OUString aContentTypeValue = xAttribs->getValueByName( 
m_aContentTypeAttr );
+const OUString aContentTypeValue = xAttribs->getValueByName( 
m_aContentTypeAttr );
 if ( aContentTypeValue.isEmpty() )
 throw css::xml::sax::SAXException(); // TODO: the ContentType 
value must present
 
-sal_Int32 nNewResultLen = m_aResultSeq[0].getLength() + 1;
+const sal_Int32 nNewResultLen = m_aResultSeq[0].getLength() + 1;
 m_aResultSeq[0].realloc( nNewResultLen );
 
 m_aResultSeq[0][nNewResultLen-1].First = aExtensionValue;
diff --git a/include/oox/core/xmlfilterbase.hxx 
b/include/oox/core/xmlfilterbase.hxx
index 51e6e496ea6a..75fc03920b79 100644
--- a/include/oox/core/xmlfilterbase.hxx
+++ b/include/oox/core/xmlfilterbase.hxx
@@ -90,8 +90,7 @@ public:
 virtual ~XmlFilterBase() override;
 
 /** Has to be implemented by each filter, returns the current theme. */
-virtual const ::oox::drawingml::Theme*
-getCurrentTheme() const = 0;
+virtual const ::oox::drawingml::Theme* getCurrentTheme() const = 0;
 
 /** Has to be implemented by each filter to return the collection of VML 
shapes. */
 virtual ::oox::vml::Drawing* getVmlDrawing() = 0;
@@ -101,13 +100,13 @@ public:
 virtual ::oox::drawingml::chart::ChartConverter* getChartConverter() = 0;
 
 /** Helper to switch chart data table - specifically for xlsx imports */
- virtual void useInternalChartDataTable( bool /*bInternal*/ ) { }
+virtual void useInternalChartDataTable( bool /*bInternal*/ ) { }
 
 /** Has to be implemented by each filter to return the table style list. */
 virtual const ::oox::drawingml::table::TableStyleListPtr getTableStyles() 
= 0;
 
 
-OUString getFragmentPathFromFirstTypeFromOfficeDoc( const OUString& 
rPart );
+OUString getFragmentPathFromFirstTypeFromOfficeDoc( const OUString& rPart 
);
 
 /** Imports a fragment using the passed fragment handler, which contains
 the full path to the fragment stream.
diff --git a/oox/source/core/xmlfilterbase.cxx 
b/oox/source/core/xmlfilterbase.cxx
index d97aeab59a89..d268b6f67f45 100644
--- a/oox/source/core/xmlfilterbase.cxx
+++ b/oox/source/core/xmlfilterbase.cxx
@@ -341,7 +341,7 @@ bool XmlFilterBase::importFragment( const 
rtl::Reference& rxHan
 return false;
 
 // fragment handler must contain path to fragment stream
-OUString aFragmentPath = rxHandler->getFragmentPath();
+const OUString aFragmentPath = 

[Libreoffice-commits] core.git: 2 commits - include/oox oox/source writerfilter/source

[Ashod Nakashian]

 include/oox/core/xmlfilterbase.hxx  |5 
 oox/source/core/xmlfilterbase.cxx   |  202 
 writerfilter/source/filter/WriterFilter.cxx |   36 
 3 files changed, 209 insertions(+), 34 deletions(-)

New commits:
commit 335a2b80fa900848a8b60d8fd5db6656bc30a95a
Author: Ashod Nakashian 
Date:   Tue Feb 6 17:49:23 2018 -0500

oox: preserve custom oox fragments and packages

Change-Id: Ic4c75d136601a9b7d772aab577c9fbebc7391eaf
Reviewed-on: https://gerrit.libreoffice.org/49236
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/include/oox/core/xmlfilterbase.hxx 
b/include/oox/core/xmlfilterbase.hxx
index 7621a0081a53..51e6e496ea6a 100644
--- a/include/oox/core/xmlfilterbase.hxx
+++ b/include/oox/core/xmlfilterbase.hxx
@@ -259,6 +259,9 @@ private:
 virtual StorageRef  implCreateStorage(
 const css::uno::Reference< css::io::XStream >& 
rxOutStream ) const override;
 
+void importCustomFragments(css::uno::Reference& 
xDocumentStorage);
+void exportCustomFragments();
+
 private:
 ::std::unique_ptr< XmlFilterBaseImpl > mxImpl;
 sal_Int32 mnRelId;
diff --git a/oox/source/core/xmlfilterbase.cxx 
b/oox/source/core/xmlfilterbase.cxx
index 15f253c734c7..d97aeab59a89 100644
--- a/oox/source/core/xmlfilterbase.cxx
+++ b/oox/source/core/xmlfilterbase.cxx
@@ -29,6 +29,9 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -48,6 +51,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -57,6 +61,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -64,6 +69,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using ::com::sun::star::xml::dom::DocumentBuilder;
 using ::com::sun::star::xml::dom::XDocument;
@@ -282,6 +288,8 @@ void XmlFilterBase::importDocumentProperties()
 Reference< XDocumentProperties > xDocProps = 
xPropSupplier->getDocumentProperties();
 xImporter->importProperties( xDocumentStorage, xDocProps );
 checkDocumentProperties(xDocProps);
+
+importCustomFragments(xDocumentStorage);
 }
 
 FastParser* XmlFilterBase::createParser()
@@ -833,6 +841,8 @@ void XmlFilterBase::exportDocumentProperties( const 
Reference< XDocumentProperti
 writeAppProperties( *this, xProperties );
 writeCustomProperties( *this, xProperties );
 }
+
+exportCustomFragments();
 }
 
 // protected --
@@ -946,6 +956,168 @@ OUString XmlFilterBase::getNamespaceURL(sal_Int32 nNSID) 
const
 return itr->second;
 }
 
+void 
XmlFilterBase::importCustomFragments(css::uno::Reference& 
xDocumentStorage)
+{
+Reference xRelations(xDocumentStorage, UNO_QUERY);
+if (xRelations.is())
+{
+// These are all the custom types we recognize and can preserve.
+static const std::set sCustomTypes = {
+
"http://schemas.dell.com/ddp/2016/relationships/xenFile;,
+
"http://schemas.dell.com/ddp/2016/relationships/hmacFile;,
+
"http://schemas.dell.com/ddp/2016/relationships/metadataFile;
+};
+
+uno::Sequence aSeqs = 
xRelations->getAllRelationships();
+
+std::vector aCustomFragments;
+std::vector aCustomFragmentTypes;
+std::vector aCustomFragmentTargets;
+for (sal_Int32 j = 0; j < aSeqs.getLength(); j++)
+{
+OUString sType;
+OUString sTarget;
+const uno::Sequence& aSeq = aSeqs[j];
+for (sal_Int32 i = 0; i < aSeq.getLength(); i++)
+{
+const beans::StringPair& aPair = aSeq[i];
+if (aPair.First == "Target")
+sTarget = aPair.Second;
+else if (aPair.First == "Type")
+sType = aPair.Second;
+}
+
+if (sCustomTypes.find(sType) != sCustomTypes.end())
+{
+StreamDataSequence aDataSeq;
+if (importBinaryData(aDataSeq, sTarget))
+{
+aCustomFragments.emplace_back(aDataSeq);
+aCustomFragmentTypes.emplace_back(sType);
+aCustomFragmentTargets.emplace_back(sTarget);
+}
+}
+}
+
+// Adding the saved custom xml DOM
+comphelper::SequenceAsHashMap aGrabBagProperties;
+aGrabBagProperties["OOXCustomFragments"] <<= 
comphelper::containerToSequence(aCustomFragments);
+aGrabBagProperties["OOXCustomFragmentTypes"] <<= 
comphelper::containerToSequence(aCustomFragmentTypes);
+aGrabBagProperties["OOXCustomFragmentTargets"] <<= 
comphelper::containerToSequence(aCustomFragmentTargets);
+
+std::vector aCustomXmlDomList;
+ 

[Libreoffice-commits] core.git: package/source

[Ashod Nakashian]

 package/source/zippackage/ZipPackage.cxx |   21 ++---
 1 file changed, 14 insertions(+), 7 deletions(-)

New commits:
commit 00492aff753510bcb4fab81c5258584f3cda2d17
Author: Ashod Nakashian 
Date:   Tue Feb 6 17:42:36 2018 -0500

ofopxml: always generate default application/xml

MS Office always sets the application/xml entry
but LO doesn't preserve unknown entries.
Since this is a standard and always-set entry
LO should always stamp it as well.

Change-Id: I28b47634f2aa1fec233c9184deb65fd43f2f3ae8
Reviewed-on: https://gerrit.libreoffice.org/48724
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/package/source/zippackage/ZipPackage.cxx 
b/package/source/zippackage/ZipPackage.cxx
index 2a918c8df630..aa5ae86b27d8 100644
--- a/package/source/zippackage/ZipPackage.cxx
+++ b/package/source/zippackage/ZipPackage.cxx
@@ -1088,9 +1088,14 @@ void ZipPackage::WriteContentTypes( ZipOutputStream& 
aZipOut, const vector< uno:
 
 // Convert vector into a uno::Sequence
 // TODO/LATER: use Default entries in future
-uno::Sequence< beans::StringPair > aDefaultsSequence;
-uno::Sequence< beans::StringPair > aOverridesSequence( aManList.size() );
-sal_Int32 nSeqLength = 0;
+uno::Sequence< beans::StringPair > aDefaultsSequence(aManList.size());
+// Add at least the application/xml default entry.
+aDefaultsSequence[0].First = "xml";
+aDefaultsSequence[0].Second= "application/xml";
+sal_Int32 nDefSeqLength = 1;
+
+uno::Sequence< beans::StringPair > aOverridesSequence(aManList.size());
+sal_Int32 nOverSeqLength = 0;
 for ( vector< uno::Sequence< beans::PropertyValue > >::const_iterator 
aIter = aManList.begin(),
 aEnd = aManList.end();
  aIter != aEnd;
@@ -1104,13 +1109,15 @@ void ZipPackage::WriteContentTypes( ZipOutputStream& 
aZipOut, const vector< uno:
 if ( !aType.isEmpty() )
 {
 // only nonempty type makes sense here
-nSeqLength++;
 ( *aIter )[PKG_MNFST_FULLPATH].Value >>= aPath;
-aOverridesSequence[nSeqLength-1].First = "/" + aPath;
-aOverridesSequence[nSeqLength-1].Second = aType;
+//FIXME: For now we have no way of deferentiating defaults from 
others.
+aOverridesSequence[nOverSeqLength].First = "/" + aPath;
+aOverridesSequence[nOverSeqLength].Second = aType;
+++nOverSeqLength;
 }
 }
-aOverridesSequence.realloc( nSeqLength );
+aOverridesSequence.realloc(nOverSeqLength);
+aDefaultsSequence.realloc(nDefSeqLength);
 
 ::comphelper::OFOPXMLHelper::WriteContentSequence(
 xConTypeOutStream, aDefaultsSequence, aOverridesSequence, 
m_xContext );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113017] Old Hungarian fonts missing. Can I grant one?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113017

V Stuart Foote  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #8 from V Stuart Foote  ---
Viktor,

So you know, the project does not develop our own fonts. We tweak some, like
OpenSymbol to meet our needs, and we are shifting to favor open source choices
where feasible. We bundle some fonts to install with LibreOffice--but that has
been for general use. Not sure there is a lot of need to have a font dedicated
to this SMP block. It might be better if it were delivered as a LibreOffice
Extension.

Back in October I extracting and generating a font set from the Unicode 10.0
"Old Hungarian" (or Szekely-Hungarian Rovas) reference font introduced at
Unicode 8.0/ISO IEC 10646:2014 --and it came out pretty good. Unfortunately I
did not hear back from either Michael Everson or André Szabolcs Szelp with
permission to use their glyph designs drawn from the Unicode SMP pages.

So guess you will need to clean yours up to be--trouble free and well
designed--and continue, maybe László or Khaled would be able to advise.

I get the sense from looking at the history of the block at Unicode that there
is some residual politics over the final Unicode/ISO approval of the block name
and some of the glyphs. But the published Unicode/ISO block is legitimate.

Also, it looks like you probably will need to design some additional glyphs to
provide punctuation with the font [1]:

U+0021 EXCLAMATION MARK
U+002D HYPHEN - MINUS
U+002E FULL STOP
U+003A COLON
U+201F DOUBLE HIGH-REVERSED-9 QUOTATION MARK
U+204F REVERSED SEMICOLON
U+2E2E REVERSED QUESTION MARK
U+2E41 REVERSED COMMA
U+2E42 DOUBLE LOW-REVERSED-9 QUOTATION MARK

Seems like a worthwhile project, good luck with it.

Stuart

=-ref-=
[1] http://www.unicode.org/wg2/docs/n4268.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - filter/source

[Caolán McNamara]

 filter/source/msfilter/msdffimp.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e3d69e6d8b5d1da039d3e8a22800cde4947b48fc
Author: Caolán McNamara 
Date:   Tue Feb 13 21:16:56 2018 +

ofz: Abrt

Change-Id: I814b0e4255894d909d29a9a301488a23acf418a0
Reviewed-on: https://gerrit.libreoffice.org/49687
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 50fa3619c65d..c44f09a87ab1 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -1106,7 +1106,8 @@ void ApplyRectangularGradientAsBitmap( const 
SvxMSDffManager& rManager, SvStream
 {
 Size aBitmapSizePixel( static_cast< sal_Int32 >( ( 
rObjData.aBoundRect.GetWidth() / 2540.0 ) * 90.0 ),  // we will create a 
bitmap with 90 dpi
static_cast< sal_Int32 >( ( 
rObjData.aBoundRect.GetHeight() / 2540.0 ) * 90.0 ) );
-if ( aBitmapSizePixel.Width() && aBitmapSizePixel.Height() && ( 
aBitmapSizePixel.Width() <= 1024 ) && ( aBitmapSizePixel.Height() <= 1024 ) )
+if (aBitmapSizePixel.Width() > 0 && aBitmapSizePixel.Height() > 0 &&
+aBitmapSizePixel.Width() <= 1024 && aBitmapSizePixel.Height() <= 1024)
 {
 double fFocusX = rManager.GetPropertyValue( DFF_Prop_fillToRight, 0 ) 
/ 65536.0;
 double fFocusY = rManager.GetPropertyValue( DFF_Prop_fillToBottom, 0 ) 
/ 65536.0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115693] Line spacing is imported incorrectly from PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115693

Tamás Zolnai  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115693] New: Line spacing is imported incorrectly from PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115693

Bug ID: 115693
   Summary: Line spacing is imported incorrectly from PPTX
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zolnaitamas2...@gmail.com

Description:
Linespacing defined on slide layout is not imported from PPTX file. Open the
attached test document, the paragraph with "Text" string has a single line
spacing after importing to LO, but in the file format 140% line spacint is set
actually.

Steps to Reproduce:
1. Open attached PPTX file
2. Check line spacing of the paragraph with "Text" string


Actual Results:  
Line spacing is set to Single.

Expected Results:
Line spacing should be proportional with the value of 140%.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/61.0.3163.100 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115693] Line spacing is imported incorrectly from PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115693

--- Comment #1 from Tamás Zolnai  ---
Created attachment 139879
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139879=edit
PPTX with proportional line spacing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115607] [META] Bugs in Languages Used by Minority Nationalities of China 中国少数民族语音文字有关的 Bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115607

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||83066


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language
issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115607


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115607
[Bug 115607] [META] Bugs in Languages Used by Minority Nationalities of China
中国少数民族语音文字有关的 Bug
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115688] Add Checkbox option to disable animated overlay to Tools -> Options -> Accessibility panel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115688

crx...@hotmail.com changed:

   What|Removed |Added

 CC||crx...@hotmail.com

--- Comment #5 from crx...@hotmail.com ---
I will add my hat in the ring that it SHOULD be added to accessibility options.
 It isn't just for photosensitive, but also for people with OCD who are mildly
to severely distracted by animation.  Of course, they can use the expert config
option, but that is pretty well hidden there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sw/source

[Jim Raykowski]

 sw/source/uibase/shells/basesh.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 55b37cc3ade30257858515b1a062ff9130488a5f
Author: Jim Raykowski 
Date:   Tue Feb 6 22:50:02 2018 -0900

tdf#108227 Set table style so it is highlighted in Sidebar styles list

Change-Id: I930085839c9ab7297e492c1463b54d41c087361c
Reviewed-on: https://gerrit.libreoffice.org/49338
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit d1b13f486eacc60c9b71ec9f1b29cde2f4504d4e)
Reviewed-on: https://gerrit.libreoffice.org/49658
Reviewed-by: Katarina Behrens 

diff --git a/sw/source/uibase/shells/basesh.cxx 
b/sw/source/uibase/shells/basesh.cxx
index 9d907536b750..b938767159bb 100644
--- a/sw/source/uibase/shells/basesh.cxx
+++ b/sw/source/uibase/shells/basesh.cxx
@@ -2710,6 +2710,8 @@ void SwBaseShell::InsertTable( SfxRequest& _rRequest )
 
 if( pTAFormat == nullptr )
 rSh.SetTableStyle( SwStyleNameMapper::GetUIName( 
RES_POOLTABSTYLE_DEFAULT, OUString() ) );
+else
+rSh.SetTableStyle( aAutoName );
 
 rSh.EndAllAction();
 rTempView.AutoCaption(TABLE_CAP);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115506] FORMATTING: Crash in: XPropertyList::Count() when selecting " Pattern" button in "Background" tab in "Table Properties" window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115506

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0 target:5.4.6   |target:6.1.0 target:5.4.6
   ||target:6.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115506] FORMATTING: Crash in: XPropertyList::Count() when selecting " Pattern" button in "Background" tab in "Table Properties" window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115506

--- Comment #10 from Commit Notification 
 ---
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=10a5ea8f6365236fcc1d31b940113b3363f56209=libreoffice-6-0

tdf#115506: Crash when trying to set pattern fill for tables in Impress

It will be available in 6.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - cui/source

[Tamás Zolnai]

 cui/source/dialogs/sdrcelldlg.cxx |2 ++
 cui/source/inc/sdrcelldlg.hxx |1 +
 2 files changed, 3 insertions(+)

New commits:
commit 10a5ea8f6365236fcc1d31b940113b3363f56209
Author: Tamás Zolnai 
Date:   Wed Feb 7 15:54:41 2018 +0100

tdf#115506: Crash when trying to set pattern fill for tables in Impress

Setting pattern list was missed in this specific dialog.

Change-Id: I9f47e9e0dd4f99bf5403c70685508b0f14a5bd61
Reviewed-on: https://gerrit.libreoffice.org/49361
Reviewed-by: Julien Nabet 
Tested-by: Jenkins 
(cherry picked from commit de8a1b4f6c8fcca9fc9cc5ad83c393ecd7292f76)
Reviewed-on: https://gerrit.libreoffice.org/49404
Reviewed-by: Katarina Behrens 

diff --git a/cui/source/dialogs/sdrcelldlg.cxx 
b/cui/source/dialogs/sdrcelldlg.cxx
index 7011a4de1d9c..7789ddd64c13 100644
--- a/cui/source/dialogs/sdrcelldlg.cxx
+++ b/cui/source/dialogs/sdrcelldlg.cxx
@@ -33,6 +33,7 @@ SvxFormatCellsDialog::SvxFormatCellsDialog( vcl::Window* 
pParent, const SfxItemS
 , mpGradientList(pModel->GetGradientList())
 , mpHatchingList(pModel->GetHatchList())
 , mpBitmapList(pModel->GetBitmapList())
+, mpPatternList(pModel->GetPatternList())
 , m_nAreaPageId(0)
 {
 AddTabPage("name", RID_SVXPAGE_CHAR_NAME);
@@ -50,6 +51,7 @@ void SvxFormatCellsDialog::PageCreated( sal_uInt16 nId, 
SfxTabPage  )
 rAreaPage.SetGradientList( mpGradientList );
 rAreaPage.SetHatchingList( mpHatchingList );
 rAreaPage.SetBitmapList( mpBitmapList );
+rAreaPage.SetPatternList( mpPatternList );;
 rAreaPage.ActivatePage( mrOutAttrs );
 }
 else if (nId == m_nBorderPageId)
diff --git a/cui/source/inc/sdrcelldlg.hxx b/cui/source/inc/sdrcelldlg.hxx
index f5976be5d7f6..97a2abeec613 100644
--- a/cui/source/inc/sdrcelldlg.hxx
+++ b/cui/source/inc/sdrcelldlg.hxx
@@ -34,6 +34,7 @@ private:
 XGradientListRefmpGradientList;
 XHatchListRef   mpHatchingList;
 XBitmapListRef  mpBitmapList;
+XPatternListRef mpPatternList;
 
 sal_uInt16  m_nAreaPageId;
 sal_uInt16  m_nBorderPageId;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115620] Performing of a Find Text operation Switches the Object Type of the “Navigate By” Drop-down Menu to “Repeat Search”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115620

--- Comment #1 from Jim Raykowski  ---
Hi Harald, 

Here is a patch to prevent the "Navigate by" from being changed when a find
text operation is done:  

https://gerrit.libreoffice.org/#/c/49690/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93789] text background color not displayed in slide show

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93789

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||584

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs