[Libreoffice-bugs] [Bug 115705] When presentations are opened, LibreOffice does not respect the "Move focus to next window" in System Preferences

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115705

--- Comment #13 from Alex Thurgood  ---
Given the other related bugs, confirming.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115705] When presentations are opened, LibreOffice does not respect the "Move focus to next window" in System Preferences

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115705

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97983] cInt function treats , as decimal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97983

--- Comment #7 from t...@tim-passingham.co.uk ---
Retested under Version: 6.0.2.1
Build ID: 1:6.0.2~rc1-0ubuntu0.17.10.1~lo1
CPU threads: 8; OS: Linux 4.13; UI render: GL; VCL: gtk2; 
Locale: en-GB (en_GB.UTF-8); Calc: group

The behaviour is unchanged. 1,234 is still transformed to be 1 (rather than
1234), regardless of the fact that I am in the UK, with UK settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=10

Gülşah Köse  changed:

   What|Removed |Added

 Depends on||116256


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116256
[Bug 116256] DOCX Import: incorrect placement of table text.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116256] DOCX Import: incorrect placement of table text.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116256

Gülşah Köse  changed:

   What|Removed |Added

 Blocks||10


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX (OOXML) table-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116256] DOCX Import: incorrect placement of table text.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116256

--- Comment #3 from Gülşah Köse  ---
Created attachment 140411
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140411=edit
expected view

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116256] DOCX Import: incorrect placement of table text.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116256

--- Comment #2 from Gülşah Köse  ---
Created attachment 140410
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140410=edit
actual view

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116256] DOCX Import: incorrect placement of table text.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116256

--- Comment #1 from Gülşah Köse  ---
Created attachment 140409
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140409=edit
bug docx file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116256] New: DOCX Import: incorrect placement of table text.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116256

Bug ID: 116256
   Summary: DOCX Import: incorrect placement of table text.
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gulsah.1...@gmail.com

Description:
The text that normally needs to be in the table is placed outside the table.

Steps to Reproduce:
1.Open the WrongTableTextPlacement.docx

Actual Results:  
See actual.png

Expected Results:
See expected.png


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116108] Add option to fit images into their cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116108

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

MSVC being stupid (again)?

[Bjoern Michaelsen]

Hi,

Im going slightly mad over:

 https://gerrit.libreoffice.org/#/c/49565/

it:

- uses a class which has a move ctor in a std container and a deleted copy
  ctor, which _should_ be fine
- compiles fine on OSX and Linux gcc and Linux clang
- it fails on MSVC with some bull&^(t errors that start off with "I tried to
  instanciate the deleted copy ctor" (which sounds almost reasonable) but ends
  with stuff including boost::args. which has ~nothing to do with the changes
  stl stuff involved and sound like it really took a wrong turn at some place
- copying and renaming the involved clasess to uwriter seems to make the
  std::list compile just fine

My gut feeling is that window precompiled headers are hitting a broken corner
case here. Anyone having any hints?

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: editeng/source extensions/source filter/source forms/source

[Noel Grandin]

 editeng/source/accessibility/AccessibleEditableTextPara.cxx |   12 -
 editeng/source/accessibility/AccessibleImageBullet.cxx  |4 +--
 editeng/source/editeng/impedit3.cxx |6 ++--
 editeng/source/items/frmitems.cxx   |   12 -
 editeng/source/items/numitem.cxx|2 -
 editeng/source/items/textitem.cxx   |   15 
 editeng/source/uno/unonrule.cxx |2 -
 extensions/source/propctrlr/fontdialog.cxx  |   10 
 extensions/source/propctrlr/formcomponenthandler.cxx|9 ++-
 extensions/source/propctrlr/standardcontrol.cxx |4 +--
 filter/source/flash/swfwriter1.cxx  |2 -
 filter/source/msfilter/escherex.cxx |6 ++--
 filter/source/msfilter/msdffimp.cxx |2 -
 filter/source/msfilter/svdfppt.cxx  |9 +++
 filter/source/msfilter/util.cxx |6 ++--
 forms/source/component/Grid.cxx |4 +--
 forms/source/component/formcontrolfont.cxx  |8 +++---
 forms/source/component/navigationbar.cxx|8 +++---
 forms/source/inc/formcontrolfont.hxx|9 ---
 forms/source/richtext/richtextcontrol.cxx   |4 +--
 forms/source/solar/component/navbarcontrol.cxx  |6 ++--
 21 files changed, 66 insertions(+), 74 deletions(-)

New commits:
commit a498b12dc1723b072a165f8c528c377024fd4c98
Author: Noel Grandin 
Date:   Wed Mar 7 08:42:58 2018 +0200

use more Color in editeng..forms

Change-Id: If6c862e7bb61cd78c3379afde11b528a74162900
Reviewed-on: https://gerrit.libreoffice.org/50860
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/accessibility/AccessibleEditableTextPara.cxx 
b/editeng/source/accessibility/AccessibleEditableTextPara.cxx
index 90859aac7a73..cbb1d51bb224 100644
--- a/editeng/source/accessibility/AccessibleEditableTextPara.cxx
+++ b/editeng/source/accessibility/AccessibleEditableTextPara.cxx
@@ -1143,12 +1143,12 @@ namespace accessibility
 sal_Int32 SAL_CALL AccessibleEditableTextPara::getBackground(  )
 {
 // #10# Added to XAccessibleComponent interface
-Color aColor( 
Application::GetSettings().GetStyleSettings().GetWindowColor().GetColor() );
+Color aColor( 
Application::GetSettings().GetStyleSettings().GetWindowColor() );
 
 // the background is transparent
 aColor.SetTransparency( 0xFF);
 
-return static_cast( aColor.GetColor() );
+return static_cast( aColor );
 }
 
 // XAccessibleText
@@ -1470,7 +1470,7 @@ namespace accessibility
 if (rRes.Name == "CharColor")
 {
 uno::Any  = rRes.Value;
-sal_uInt32 crChar = static_cast( 
reinterpret_cast(anyChar.pReserved));
+Color crChar = static_cast( 
reinterpret_cast(anyChar.pReserved));
 if (COL_AUTO == crChar )
 {
 uno::Reference< css::accessibility::XAccessibleComponent > 
xComponent(mxParent,uno::UNO_QUERY);
@@ -1485,7 +1485,7 @@ namespace accessibility
 else
 {
 Color cr(xComponent->getBackground());
-crChar = sal_uInt32(cr.IsDark() ? COL_WHITE : 
COL_BLACK);
+crChar = cr.IsDark() ? COL_WHITE : COL_BLACK;
 anyChar <<= crChar;
 }
 }
@@ -1501,7 +1501,7 @@ namespace accessibility
 if (rRes.Name == "CharUnderlineColor")
 {
 uno::Any  = rRes.Value;
-sal_uInt32 crCharUnderLine = static_cast( 
reinterpret_cast( anyCharUnderLine.pReserved));
+Color crCharUnderLine = static_cast( 
reinterpret_cast( anyCharUnderLine.pReserved));
 if (COL_AUTO == crCharUnderLine )
 {
 uno::Reference< css::accessibility::XAccessibleComponent > 
xComponent(mxParent,uno::UNO_QUERY);
@@ -1516,7 +1516,7 @@ namespace accessibility
 else
 {
 Color cr(xComponent->getBackground());
-crCharUnderLine = sal_uInt32(cr.IsDark() ? 
COL_WHITE : COL_BLACK);
+crCharUnderLine = cr.IsDark() ? COL_WHITE : 
COL_BLACK;
 anyCharUnderLine <<= crCharUnderLine;
 }
 }
diff --git a/editeng/source/accessibility/AccessibleImageBullet.cxx 
b/editeng/source/accessibility/AccessibleImageBullet.cxx
index 

[Libreoffice-bugs] [Bug 116108] Add option to fit images into their cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116108

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116108] Add option to fit images into their cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116108

--- Comment #4 from Commit Notification 
 ---
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=073b4eadd2a9a00b915c664df90b15d5b2d709c0

tdf#116108 Add option to fit images into their cell

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx officecfg/registry sc/inc sc/sdi sc/source sc/uiconfig

[Samuel Mehrbrodt]

 include/svx/svdobj.hxx   |3 
 include/svx/svdograf.hxx |2 
 include/svx/svdomedia.hxx|2 
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |5 +
 sc/inc/globstr.hrc   |1 
 sc/inc/sc.hrc|1 
 sc/sdi/drawsh.sdi|1 
 sc/sdi/scalc.sdi |   18 +++
 sc/source/ui/drawfunc/drawsh2.cxx|8 +
 sc/source/ui/drawfunc/drawsh5.cxx|4 
 sc/source/ui/inc/drawview.hxx|1 
 sc/source/ui/view/drawvie4.cxx   |   46 
++
 sc/uiconfig/scalc/menubar/menubar.xml|1 
 sc/uiconfig/scalc/popupmenu/chart.xml|1 
 sc/uiconfig/scalc/popupmenu/draw.xml |1 
 sc/uiconfig/scalc/popupmenu/form.xml |1 
 sc/uiconfig/scalc/popupmenu/graphic.xml  |1 
 sc/uiconfig/scalc/popupmenu/media.xml|1 
 sc/uiconfig/scalc/popupmenu/oleobject.xml|1 
 19 files changed, 99 insertions(+)

New commits:
commit 073b4eadd2a9a00b915c664df90b15d5b2d709c0
Author: Samuel Mehrbrodt 
Date:   Thu Mar 1 12:17:46 2018 +0100

tdf#116108 Add option to fit images into their cell

Change-Id: I2e9a4f567049f11985e4bf914c2fa5bd1f181823
Reviewed-on: https://gerrit.libreoffice.org/50569
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 2f9542659cb0..3e97a472084f 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -733,6 +733,9 @@ public:
 void SetMarkProtect(bool bProt);
 bool IsMarkProtect() const { return bMarkProt;}
 
+/// Whether the aspect ratio should be kept by default when resizing.
+virtual bool shouldKeepAspectRatio() const { return false; }
+
 // application specific data
 sal_uInt16 GetUserDataCount() const;
 SdrObjUserData* GetUserData(sal_uInt16 nNum) const;
diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx
index f31ed858e575..abea8f1b222e 100644
--- a/include/svx/svdograf.hxx
+++ b/include/svx/svdograf.hxx
@@ -211,6 +211,8 @@ public:
 bool IsMirrored() const { return bMirrored;}
 void SetMirrored( bool _bMirrored );
 
+virtual bool shouldKeepAspectRatio() const override { return true; }
+
 // Access to GrafAnimationAllowed flag
 void SetGrafAnimationAllowed(bool bNew);
 
diff --git a/include/svx/svdomedia.hxx b/include/svx/svdomedia.hxx
index f0bf09300aff..43356da4e302 100644
--- a/include/svx/svdomedia.hxx
+++ b/include/svx/svdomedia.hxx
@@ -69,6 +69,8 @@ public:
 GetInputStream();
 void
SetInputStream(css::uno::Reference const&);
 
+virtual bool shouldKeepAspectRatio() const override { return true; }
+
 private:
 
 voidmediaPropertiesChanged( const 
::avmedia::MediaItem& rNewState );
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index af2f0c643cc5..22f09405bf64 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -2181,6 +2181,11 @@
   ~Original Size
 
   
+  
+
+  ~Fit to Cell Size
+
+  
   
 
   Gr~id and Helplines
diff --git a/sc/inc/globstr.hrc b/sc/inc/globstr.hrc
index 89f3150fa8d0..d08ec69ed2a5 100644
--- a/sc/inc/globstr.hrc
+++ b/sc/inc/globstr.hrc
@@ -93,6 +93,7 @@
 #define STR_UNDO_DETREFRESH NC_("STR_UNDO_DETREFRESH", 
"Refresh Traces")
 #define STR_UNDO_CHARTDATA  NC_("STR_UNDO_CHARTDATA", 
"Modify chart data range")
 #define STR_UNDO_ORIGINALSIZE   NC_("STR_UNDO_ORIGINALSIZE", 
"Original Size")
+#define STR_UNDO_FITCELLSIZENC_("STR_UNDO_FITCELLSIZE", 
"Fit to Cell Size")
 #define STR_UNDO_UPDATELINK NC_("STR_UNDO_UPDATELINK", 
"Update Link")
 #define STR_UNDO_REMOVELINK NC_("STR_UNDO_REMOVELINK", 
"Unlink")
 #define STR_UNDO_INSERTAREALINK NC_("STR_UNDO_INSERTAREALINK", 
"Insert Link")
diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index 64ee13afc73c..5f1ae5ef385b 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -409,6 +409,7 @@
 

[Libreoffice-bugs] [Bug 116255] code128 font does not work. in calc Version: 5.4.5.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116255

--- Comment #1 from tomima...@gmx.net ---
Created attachment 140408
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140408=edit
Screenshot code 128

The screenshot of the issue is attached.
This is the difference between Version: 5.4.5 and Version: 5.1.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116254] Writer: pdf-images disappear when exporting as pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116254

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4460

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - openssl/makefile.mk openssl/openssl.patch soltools/javadep

[Damjan Jovanovic]

 openssl/makefile.mk|   18 --
 openssl/openssl.patch  |   30 ++
 soltools/javadep/javadep.c |   14 +-
 3 files changed, 55 insertions(+), 7 deletions(-)

New commits:
commit dbda740d5e12fb77f3452c3e5515bdad233b91d8
Author: Damjan Jovanovic 
Date:   Wed Mar 7 06:16:30 2018 +

Get openssl to build on Win64.

Patch by: me

diff --git a/openssl/makefile.mk b/openssl/makefile.mk
index 6762f642d4b2..dc97bb1c7459 100644
--- a/openssl/makefile.mk
+++ b/openssl/makefile.mk
@@ -151,12 +151,18 @@ OUT2BIN += out/libeay32.dll
 .ENDIF
 
 #CONFIGURE_ACTION=cmd /c $(PERL:s!\!/!) configure
-CONFIGURE_ACTION=$(PERL) configure $(NO_ASM)
-CONFIGURE_FLAGS=VC-WIN32
-.IF "$(NASM_PATH)"=="NO_NASM_HOME"
-  BUILD_ACTION=cmd /c "ms$(EMQ)\do_ms.bat $(subst,/,\ $(normpath,1 
$(PERL)))" && nmake -f ms/ntdll.mak
-.ELSE
-  BUILD_ACTION=cmd /c "ms$(EMQ)\do_nasm.bat $(subst,/,\ $(normpath,1 
$(PERL)))" && nmake -f ms/ntdll.mak
+.IF "$(CPUNAME)"=="INTEL"
+CONFIGURE_ACTION=$(PERL) configure $(NO_ASM)
+CONFIGURE_FLAGS=VC-WIN32
+.IF "$(NASM_PATH)"=="NO_NASM_HOME"
+  BUILD_ACTION=cmd /c "ms$(EMQ)\do_ms.bat $(subst,/,\ $(normpath,1 
$(PERL)))" && nmake -f ms/ntdll.mak
+.ELSE
+  BUILD_ACTION=cmd /c "ms$(EMQ)\do_nasm.bat $(subst,/,\ 
$(normpath,1 $(PERL)))" && nmake -f ms/ntdll.mak
+.ENDIF
+.ELIF "$(CPUNAME)"=="X86_64"
+CONFIGURE_ACTION=$(PERL) configure $(NO_ASM)
+CONFIGURE_FLAGS=VC-WIN64A
+BUILD_ACTION=cmd /c "ms$(EMQ)\do_win64a.bat $(subst,/,\ 
$(normpath,1 $(PERL)))" && cmd /c "nmake -f ms/ntdll.mak"
 .ENDIF
 
 OUT2LIB = out32dll$/ssleay32.lib
diff --git a/openssl/openssl.patch b/openssl/openssl.patch
index b487f8fc5db4..27a01adffaa2 100644
--- a/openssl/openssl.patch
+++ b/openssl/openssl.patch
@@ -122,3 +122,33 @@ diff -ur misc/openssl-1.0.2h/util/pl/VC-32.pl 
misc/build/openssl-1.0.2h/util/pl/
  if ($FLAVOR =~ /WIN64/)
  {
  # Note that we currently don't have /WX on Win64! There is a lot of
+diff -Nur misc/build/openssl-1.0.2h/ms/do_win64a.bat 
misc/build/openssl-1.0.2h/ms/do_win64a.bat
+--- misc/build/openssl-1.0.2h/ms/do_win64a.bat 2016-05-03 15:44:42.0 
+0200
 misc/build/openssl-1.0.2h/ms/do_win64a.bat 2018-03-07 07:59:41.870638000 
+0200
+@@ -1,19 +1,19 @@
+-perl util\mkfiles.pl >MINFO
++%1 util\mkfiles.pl >MINFO
+ 
+ cmd /c "nasm -f win64 -v" >NUL 2>&1
+ if %errorlevel% neq 0 goto ml64
+ 
+-perl ms\uplink-x86_64.pl nasm > ms\uptable.asm
++%1 ms\uplink-x86_64.pl nasm > ms\uptable.asm
+ nasm -f win64 -o ms\uptable.obj ms\uptable.asm
+ goto proceed
+ 
+ :ml64
+-perl ms\uplink-x86_64.pl masm > ms\uptable.asm
++%1 ms/uplink-x86_64.pl masm > ms/uptable.asm
+ ml64 -c -Foms\uptable.obj ms\uptable.asm
+ 
+ :proceed
+-perl util\mk1mf.pl VC-WIN64A >ms\nt.mak
+-perl util\mk1mf.pl dll VC-WIN64A >ms\ntdll.mak
++%1 util\mk1mf.pl VC-WIN64A >ms\nt.mak
++%1 util\mk1mf.pl dll VC-WIN64A >ms\ntdll.mak
+ 
+-perl util\mkdef.pl 32 libeay > ms\libeay32.def
+-perl util\mkdef.pl 32 ssleay > ms\ssleay32.def
++%1 util\mkdef.pl 32 libeay > ms\libeay32.def
++%1 util\mkdef.pl 32 ssleay > ms\ssleay32.def
commit 756f141b6bfa64854d61230201ca9fc9d52a6b78
Author: Damjan Jovanovic 
Date:   Wed Mar 7 05:14:45 2018 +

Update the main/soltools javadep tool to deal with Java 9

(possibily 7 and 8 too, when using invokedynamic).

Patch by: me

diff --git a/soltools/javadep/javadep.c b/soltools/javadep/javadep.c
index e0902ba678b2..06e332f6a6f8 100644
--- a/soltools/javadep/javadep.c
+++ b/soltools/javadep/javadep.c
@@ -93,7 +93,10 @@ enum {
 CONSTANT_Long   = 5,
 CONSTANT_Double = 6,
 CONSTANT_NameAndType= 12,
-CONSTANT_Utf8   = 1
+CONSTANT_Utf8   = 1,
+CONSTANT_MethodHandle   = 15,
+CONSTANT_MethodType = 16,
+CONSTANT_InvokeDynamic  = 18
 };
 
 enum { NGROW_INIT = 10, NGROW = 2 };
@@ -512,6 +515,15 @@ process_class_file(const char *pfilename, const struct 
growable *pfilt)
 a_utf8 = read_utf8();
 pc_pool[i] = a_utf8;
 break;
+case CONSTANT_MethodHandle:
+skip_bytes(, 3);
+break;
+case CONSTANT_MethodType:
+skip_bytes(, 2);
+break;
+case CONSTANT_InvokeDynamic:
+skip_bytes(, 4);
+break;
 default:
 /* Unknown Constant_pool entry, this means we are
  * in trouble
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115432] ODF filters: footnote separator style:adjustment not imported /exported, always "left"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115432

--- Comment #21 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1163bcd5da3063e7e988ebf49d9b60dfd6f6c703

tdf#115432 footnote separator position wrong (2nd attempt)

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmloff/source

[Noel Grandin]

 xmloff/source/style/XMLFootnoteSeparatorImport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1163bcd5da3063e7e988ebf49d9b60dfd6f6c703
Author: Noel Grandin 
Date:   Tue Mar 6 15:18:53 2018 +0200

tdf#115432 footnote separator position wrong (2nd attempt)

the first attempt (d4a8d91abd40dee7f7bd739a678a502a6e34cb59)
incorrectly changed the type of a UNO property defined in a
published IDL file.

Change-Id: I75bc75dead0954d1faa6dfb6adab9f4c42c67cfc
Reviewed-on: https://gerrit.libreoffice.org/50827
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/xmloff/source/style/XMLFootnoteSeparatorImport.cxx 
b/xmloff/source/style/XMLFootnoteSeparatorImport.cxx
index 5ec390c459cc..9ebf9549e45e 100644
--- a/xmloff/source/style/XMLFootnoteSeparatorImport.cxx
+++ b/xmloff/source/style/XMLFootnoteSeparatorImport.cxx
@@ -159,7 +159,7 @@ void XMLFootnoteSeparatorImport::StartElement(
 sal_Int32 nIndex;
 
 nIndex = rMapper->FindEntryIndex(CTF_PM_FTN_LINE_ADJUST);
-XMLPropertyState aLineAdjust( nIndex, uno::Any(eLineAdjust));
+XMLPropertyState aLineAdjust( nIndex, uno::Any(sal_Int16(eLineAdjust)) );
 rProperties.push_back(aLineAdjust);
 
 nIndex = rMapper->FindEntryIndex(CTF_PM_FTN_LINE_COLOR);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116255] code128 font does not work. in calc Version: 5.4.5.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116255

tomima...@gmx.net changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116255] code128 font does not work. in calc Version: 5.4.5.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116255

tomima...@gmx.net changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116255] New: code128 font does not work. in calc Version: 5.4.5.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116255

Bug ID: 116255
   Summary: code128 font does not work. in calc Version: 5.4.5.1
   Product: LibreOffice
   Version: 5.4.5.1 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tomima...@gmx.net

Description:
After updating Version: 5.4.5.1, code 128 font (barcode symbols font) does not
work. It displays incorrectly. in Version: 5.1.3.2, code 128 font work
properly.

Actual Results:  
for example, 299085047 is encoded Í=zu$È7zÎ.
Í=zu$È7zÎ shoud be dispayed barcode, but code 128 font display encoded text
Í=zu$È7zÎ only.


Expected Results:
code 128 font should display barcode.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Pranav Kant]

 vcl/source/window/cursor.cxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 843f8e43e1e79bbd22cadabb54022c615c7a0d64
Author: Pranav Kant 
Date:   Tue Mar 6 19:21:48 2018 +0530

lokdialog: Fix cursor invalidates for some vcl controls

... like TextEdit, etc. The problem was that the code assumed that there
would be a mpData->mpWindow whenever a new cursor position is set. While
that's the case with most views, some controls set the position when
there's no window set.

With this patch, we send the cursor_invalidate just before we make the
cursor visible; by that time, we already have a valid mpWindow set in
the ImplCursorData.

Change-Id: I2cb40ae150e4d7555f17ebbb8e08c04fc05f447b
Reviewed-on: https://gerrit.libreoffice.org/50834
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx
index 2da864f9bcd2..0da13be25d16 100644
--- a/vcl/source/window/cursor.cxx
+++ b/vcl/source/window/cursor.cxx
@@ -189,9 +189,6 @@ void vcl::Cursor::ImplDoShow( bool bDrawDirect, bool 
bRestore )
 mpData->mbCurVisible = false;
 mpData->maTimer.SetInvokeHandler( LINK( this, Cursor, 
ImplTimerHdl ) );
 mpData->maTimer.SetDebugName( "vcl ImplCursorData maTimer" );
-
-// tell about "initial" coordinates
-LOKNotify( pWindow, "cursor_invalidate" );
 }
 
 mpData->mpWindow= pWindow;
@@ -206,6 +203,7 @@ void vcl::Cursor::ImplDoShow( bool bDrawDirect, bool 
bRestore )
 mpData->maTimer.Start();
 else if ( !mpData->mbCurVisible )
 ImplDraw();
+LOKNotify( pWindow, "cursor_invalidate" );
 LOKNotify( pWindow, "cursor_visible" );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: shell/source

[Mike Kaganski]

 shell/source/win32/simplemail/smplmailclient.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 01c71fba5f525b035f8a723215669d499bc27a3f
Author: Mike Kaganski 
Date:   Wed Mar 7 06:45:51 2018 +0100

Don't return local variable address

Oversight in 2f061dad7f875f704e3744fc5780c1d145b22e9f

Change-Id: I4cd4fcab7f5fa87f49ecc193a3f481fb9ac33932
Reviewed-on: https://gerrit.libreoffice.org/50857
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/shell/source/win32/simplemail/smplmailclient.cxx 
b/shell/source/win32/simplemail/smplmailclient.cxx
index 3a659548bbd1..87e324b4eeb5 100644
--- a/shell/source/win32/simplemail/smplmailclient.cxx
+++ b/shell/source/win32/simplemail/smplmailclient.cxx
@@ -170,7 +170,7 @@ namespace {
 // senddoc process lifetime. So we use base temppath for the attachments,
 // and let the senddoc to do the cleanup if it was started successfully.
 // This function works like Desktop::CreateTemporaryDirectory()
-OUString&& InitBaseTempDirURL()
+OUString InitBaseTempDirURL()
 {
 // No need to intercept an exception here, since
 // Desktop::CreateTemporaryDirectory() has ensured that path manager is 
available
@@ -183,7 +183,7 @@ OUString&& InitBaseTempDirURL()
 if (aRetURL.endsWith("/"))
 aRetURL = aRetURL.copy(0, aRetURL.getLength() - 1);
 
-return std::move(aRetURL);
+return aRetURL;
 }
 
 const OUString& GetBaseTempDirURL()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 56958] Spreadsheet Crashes trying to SORT after using and removing SUBTOTALs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56958

--- Comment #14 from Commit Notification 
 ---
Zdeněk Crhonek committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a790ee54319583897d82d4372243df870d4452a6

uitest - calc subtotals; tdf#114720 tdf#88792 tdf#88735 tdf#56958 tdf#55734

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56958] Spreadsheet Crashes trying to SORT after using and removing SUBTOTALs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56958

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:3.7.0 target:3.6.4   |target:3.7.0 target:3.6.4
   ||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/uitest/calc_tests/data/tdf55734.ods |binary
 sc/qa/uitest/calc_tests/data/tdf56958.ods |binary
 sc/qa/uitest/calc_tests/data/tdf88735.ods |binary
 sc/qa/uitest/calc_tests/data/tdf88792.ods |binary
 sc/qa/uitest/calc_tests/subtotals.py  |  188 ++
 5 files changed, 188 insertions(+)

New commits:
commit a790ee54319583897d82d4372243df870d4452a6
Author: Zdeněk Crhonek 
Date:   Sun Feb 25 23:20:06 2018 +0100

uitest - calc subtotals; tdf#114720 tdf#88792 tdf#88735 tdf#56958 tdf#55734

Change-Id: I6e31816409c105d572d545d7860d9e2ccadfad48
Reviewed-on: https://gerrit.libreoffice.org/50331
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/uitest/calc_tests/data/tdf55734.ods 
b/sc/qa/uitest/calc_tests/data/tdf55734.ods
new file mode 100644
index ..d3ccc258faf5
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf55734.ods differ
diff --git a/sc/qa/uitest/calc_tests/data/tdf56958.ods 
b/sc/qa/uitest/calc_tests/data/tdf56958.ods
new file mode 100644
index ..e2c65a21851e
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf56958.ods differ
diff --git a/sc/qa/uitest/calc_tests/data/tdf88735.ods 
b/sc/qa/uitest/calc_tests/data/tdf88735.ods
new file mode 100644
index ..59abf6050bfe
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf88735.ods differ
diff --git a/sc/qa/uitest/calc_tests/data/tdf88792.ods 
b/sc/qa/uitest/calc_tests/data/tdf88792.ods
new file mode 100644
index ..ecd9e60407cd
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf88792.ods differ
diff --git a/sc/qa/uitest/calc_tests/subtotals.py 
b/sc/qa/uitest/calc_tests/subtotals.py
new file mode 100644
index ..fa1e4f5602cf
--- /dev/null
+++ b/sc/qa/uitest/calc_tests/subtotals.py
@@ -0,0 +1,188 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.framework import UITestCase
+from libreoffice.calc.document import get_column
+from uitest.path import get_srcdir_url
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.common import get_state_as_dict
+import time
+from uitest.debug import sleep
+
+def get_url_for_data_file(file_name):
+return get_srcdir_url() + "/sc/qa/uitest/calc_tests/data/" + file_name
+
+class Subtotals(UITestCase):
+
+def test_tdf114720(self):
+calc_doc = self.ui_test.create_doc_in_start_center("calc")
+XcalcDoc = self.xUITest.getTopFocusWindow()
+document = self.ui_test.get_component()
+gridwin = XcalcDoc.getChild("grid_window")
+
+enter_text_to_cell(gridwin, "A1", "1")
+enter_text_to_cell(gridwin, "A2", "1")
+enter_text_to_cell(gridwin, "A3", "1")
+enter_text_to_cell(gridwin, "A4", "1")
+enter_text_to_cell(gridwin, "A5", "1")
+enter_text_to_cell(gridwin, "A6", "1")
+enter_text_to_cell(gridwin, "A7", "1")
+enter_text_to_cell(gridwin, "A8", "1")
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A9"}))
+
+self.ui_test.execute_dialog_through_command(".uno:DataSubTotals")
+xDialog = self.xUITest.getTopFocusWindow()
+
+xOKBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOKBtn)
+self.assertEqual(get_cell_by_position(document, 0, 0, 7).getValue(), 1)
+self.assertEqual(get_cell_by_position(document, 0, 0, 8).getString(), 
"")
+self.ui_test.close_doc()
+
+def test_tdf88792(self):
+calc_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf88792.ods"))
+XcalcDoc = self.xUITest.getTopFocusWindow()
+document = self.ui_test.get_component()
+gridwin = XcalcDoc.getChild("grid_window")
+
+# go to cell A1
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
+# Select from the menu bar Data
+# Select option subtotal
+# Subtotal dialog displays
+self.ui_test.execute_dialog_through_command(".uno:DataSubTotals")
+xDialog = self.xUITest.getTopFocusWindow()
+# Select group by: Category
+xGroupBy = xDialog.getChild("group_by")
+props = {"TEXT": "Category"}
+actionProps = mkPropertyValues(props)
+xGroupBy.executeAction("SELECT", actionProps)
+# Select calculate subtotals for the months -  selected by default
+# Select tab options
+xTabs = xDialog.getChild("tabcontrol")
+select_pos(xTabs, "3")
+# select option include 

[Libreoffice-commits] core.git: 2 commits - sc/source uitest/calc_tests

[Markus Mohrhard]

 sc/source/ui/uitest/uiobject.cxx |4 +++-
 uitest/calc_tests/gridwin.py |   17 +
 2 files changed, 20 insertions(+), 1 deletion(-)

New commits:
commit ab26cddc3325a6422993a3421a557536d6023936
Author: Markus Mohrhard 
Date:   Wed Mar 7 01:36:12 2018 +0100

uitest: add demo showing how to select different sheet

Change-Id: I1ddc8e9855832df7176d768e73d062e7f601a62c
Reviewed-on: https://gerrit.libreoffice.org/50854
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/uitest/calc_tests/gridwin.py b/uitest/calc_tests/gridwin.py
index 1afbe8142f54..7c9c87de0b03 100644
--- a/uitest/calc_tests/gridwin.py
+++ b/uitest/calc_tests/gridwin.py
@@ -6,6 +6,7 @@
 #
 
 from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict
 
 from uitest.framework import UITestCase
 
@@ -28,4 +29,20 @@ class GridWinTest(UITestCase):
 
 self.ui_test.close_doc()
 
+def test_select_sheet(self):
+
+self.ui_test.create_doc_in_start_center("calc")
+xCalcDoc = self.xUITest.getTopFocusWindow()
+xGridWindow = xCalcDoc.getChild("grid_window")
+
+for i in range(3):
+self.ui_test.execute_dialog_through_command(".uno:Insert")
+current_dialog = self.xUITest.getTopFocusWindow()
+
+xOkButton = current_dialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOkButton)
+
+xGridWindow.executeAction("SELECT", mkPropertyValues({"TABLE": "2"}))
+self.assertEqual(get_state_as_dict(xGridWindow)["SelectedTable"], "2")
+
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
commit 455fe33df4d498d8c374d43f57caf14897636749
Author: Markus Mohrhard 
Date:   Wed Mar 7 01:33:25 2018 +0100

uitest: fix small bug when trying to select different sheet in calc

Change-Id: I83e2b8dc1b0da9f28475994493e3776c898a5729
Reviewed-on: https://gerrit.libreoffice.org/50853
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/uitest/uiobject.cxx b/sc/source/ui/uitest/uiobject.cxx
index 323ae82e517a..3e98e1535bfc 100644
--- a/sc/source/ui/uitest/uiobject.cxx
+++ b/sc/source/ui/uitest/uiobject.cxx
@@ -131,7 +131,9 @@ void ScGridWinUIObject::execute(const OUString& rAction,
 auto itr = rParameters.find("TABLE");
 const OUString rStr = itr->second;
 sal_Int32 nTab = rStr.toUInt32();
-mxGridWindow->getViewData()->SetTabNo(nTab);
+ScTabView* pTabView = mxGridWindow->getViewData()->GetView();
+if (pTabView)
+pTabView->SetTabNo(nTab);
 }
 else if (rParameters.find("OBJECT") != rParameters.end())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 45789] automatic row height in reports

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45789

--- Comment #56 from Lionel Elie Mamane  ---
(In reply to Howard Johnson from comment #54)

> No really, the more important bug I think, is that the LO source code is
> mostly too hard to work on.  

> MY QUESTION: Are code comment-only commits (i.e. comments w/o any code
> changes) welcome to the powers that be here?

I expect so. I expect the right place to discuss that is the development
mailing list at https://lists.freedesktop.org/mailman/listinfo/libreoffice


> 2) As for THIS bug, and having used database report writers (plural)
> with CanGrow and CanShrink type features, I am definitely of the opinion
> that BOTH of these properties are required, not just AutoGrow, and need
> to be added to all controls.

Yes, the way I was suggesting this to be implemented is actually equivalent to
setting both "CanShrink" and "CanGrow". Setting it per-row can be done
relatively easily with the current infrastructure. Setting it per-control
requires a deeper redesign of report builder, or a new feature in ODT/Writer.
Report builder now "just" creates an ODT document, and Writer does all the
actual layouting. So per-control would require that *Writer* support the
feature of "autogrow" (which it calls "optimal row height") per cell, and not
only per row.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 45789] automatic row height in reports

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45789

--- Comment #56 from Lionel Elie Mamane  ---
(In reply to Howard Johnson from comment #54)

> No really, the more important bug I think, is that the LO source code is
> mostly too hard to work on.  

> MY QUESTION: Are code comment-only commits (i.e. comments w/o any code
> changes) welcome to the powers that be here?

I expect so. I expect the right place to discuss that is the development
mailing list at https://lists.freedesktop.org/mailman/listinfo/libreoffice


> 2) As for THIS bug, and having used database report writers (plural)
> with CanGrow and CanShrink type features, I am definitely of the opinion
> that BOTH of these properties are required, not just AutoGrow, and need
> to be added to all controls.

Yes, the way I was suggesting this to be implemented is actually equivalent to
setting both "CanShrink" and "CanGrow". Setting it per-row can be done
relatively easily with the current infrastructure. Setting it per-control
requires a deeper redesign of report builder, or a new feature in ODT/Writer.
Report builder now "just" creates an ODT document, and Writer does all the
actual layouting. So per-control would require that *Writer* support the
feature of "autogrow" (which it calls "optimal row height") per cell, and not
only per row.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 115649] 64-bit Writer v.6.0.1.1 crashes every time I send a file to network printer after clicking OK to print (ucrtbase.dll)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115649

--- Comment #33 from Mike Kaganski  ---
(In reply to Tyr Antilles from comment #32)

Thank you for your dedication in this issue!

Unfortunately, the only thing that might help us here is to get a backtrace. I
understand that you said in comment 7, that installing tools for getting them
on affected systems is not an option. But you didn't say if suggestion in
comment 8 fits you. Could you evaluate that? or try to reproduce this with some
system specifically created for testing this (so that you could install the
debug software)?

The problem indeed exists; it is reported on AkLibO site as well
(https://ask.libreoffice.org/en/question/146161/libreoffice-6-writer-crashing-on-print/
- mentioning it here for completeness); so reproducing it in an environment
that allows us to track it down and fix would be great help. Thank you again
for your persistence!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

[Julien Nabet]

 desktop/source/deployment/registry/dp_registry.cxx  |   45 +--
 desktop/source/deployment/registry/package/dp_package.cxx   |   19 -
 desktop/source/migration/migration.cxx  |  137 +---
 desktop/source/migration/services/basicmigration.cxx|   16 -
 desktop/source/migration/services/oo3extensionmigration.cxx |   16 -
 desktop/source/migration/services/wordbookmigration.cxx |   18 -
 desktop/source/pkgchk/unopkg/unopkg_misc.cxx|6 
 7 files changed, 113 insertions(+), 144 deletions(-)

New commits:
commit 1b0beef8794210b2af49d8c4a00ca7d4e3ebedb7
Author: Julien Nabet 
Date:   Tue Mar 6 22:36:02 2018 +0100

Use for-range loops in desktop (part2)

+ use 1 time replace size() > 0 by !empty()

Change-Id: If62a17171fc09e0bead7c0a791758705f62920d1
Reviewed-on: https://gerrit.libreoffice.org/50847
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/desktop/source/deployment/registry/dp_registry.cxx 
b/desktop/source/deployment/registry/dp_registry.cxx
index 09180c066a83..83cd03179119 100644
--- a/desktop/source/deployment/registry/dp_registry.cxx
+++ b/desktop/source/deployment/registry/dp_registry.cxx
@@ -134,10 +134,9 @@ inline void PackageRegistryImpl::check()
 void PackageRegistryImpl::disposing()
 {
 // dispose all backends:
-t_registryset::const_iterator iPos( m_allBackends.begin() );
-t_registryset::const_iterator const iEnd( m_allBackends.end() );
-for ( ; iPos != iEnd; ++iPos ) {
-try_dispose( *iPos );
+for (auto const& backend : m_allBackends)
+{
+try_dispose(backend);
 }
 m_mediaType2backend = t_string2registry();
 m_ambiguousBackends = t_registryset();
@@ -265,10 +264,9 @@ void PackageRegistryImpl::insertBackend(
 }
 
 // cut out ambiguous filters:
-t_stringset::const_iterator iPos( ambiguousFilters.begin() );
-const t_stringset::const_iterator iEnd( ambiguousFilters.end() );
-for ( ; iPos != iEnd; ++iPos ) {
-m_filter2mediaType.erase( *iPos );
+for (auto const& ambiguousFilter : ambiguousFilters)
+{
+m_filter2mediaType.erase(ambiguousFilter);
 }
 }
 
@@ -366,18 +364,16 @@ Reference 
PackageRegistryImpl::create(
 {
 t_registryset allBackends;
 dp_misc::TRACE("> [dp_registry.cxx] media-type detection:\n\n" );
-for ( t_string2string::const_iterator iPos(
-  that->m_filter2mediaType.begin() );
-  iPos != that->m_filter2mediaType.end(); ++iPos )
+for (auto const& elem : that->m_filter2mediaType)
 {
 OUStringBuffer buf;
 buf.append( "extension \"" );
-buf.append( iPos->first );
+buf.append( elem.first );
 buf.append( "\" maps to media-type \"" );
-buf.append( iPos->second );
+buf.append( elem.second );
 buf.append( "\" maps to backend " );
 const Reference xBackend(
-that->m_mediaType2backend.find( iPos->second )->second );
+that->m_mediaType2backend.find( elem.second )->second );
 allBackends.insert( xBackend );
 buf.append( Reference(
 xBackend, UNO_QUERY_THROW )
@@ -385,17 +381,15 @@ Reference 
PackageRegistryImpl::create(
 dp_misc::TRACE( buf.makeStringAndClear() + "\n");
 }
 dp_misc::TRACE( "> [dp_registry.cxx] ambiguous backends:\n\n" );
-for ( t_registryset::const_iterator iPos(
-  that->m_ambiguousBackends.begin() );
-  iPos != that->m_ambiguousBackends.end(); ++iPos )
+for (auto const& ambiguousBackend : that->m_ambiguousBackends)
 {
 OUStringBuffer buf;
 buf.append(
 Reference(
-*iPos, UNO_QUERY_THROW )->getImplementationName() );
+ambiguousBackend, UNO_QUERY_THROW 
)->getImplementationName() );
 buf.append( ": " );
 const Sequence< Reference > types(
-(*iPos)->getSupportedPackageTypes() );
+ambiguousBackend->getSupportedPackageTypes() );
 for ( sal_Int32 pos = 0; pos < types.getLength(); ++pos ) {
 Reference const & xInfo =
 types[ pos ];
@@ -425,10 +419,9 @@ Reference 
PackageRegistryImpl::create(
 void PackageRegistryImpl::update()
 {
 check();
-t_registryset::const_iterator iPos( m_allBackends.begin() );
-const t_registryset::const_iterator iEnd( m_allBackends.end() );
-for ( ; iPos != iEnd; ++iPos ) {
-const Reference xUpdatable( *iPos, UNO_QUERY );
+for (auto const& backend : m_allBackends)
+{
+const Reference xUpdatable(backend, UNO_QUERY);
 if (xUpdatable.is())
 xUpdatable->update();
 }
@@ -479,12 +472,10 @@ Reference 

[Libreoffice-bugs] [Bug 115649] 64-bit Writer v.6.0.1.1 crashes every time I send a file to network printer after clicking OK to print (ucrtbase.dll)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115649

--- Comment #32 from Tyr Antilles  ---
- I installed the update you pointed Windows6.1-KB2999226-x64.msu and no
effect. It still crashes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

[Noel Grandin]

 sc/inc/appoptio.hxx |   24 -
 sc/source/core/data/document10.cxx  |2 
 sc/source/core/tool/appoptio.cxx|   24 -
 sc/source/core/tool/detfunc.cxx |8 +--
 sc/source/core/tool/viewopti.cxx|2 
 sc/source/filter/excel/xestyle.cxx  |8 +--
 sc/source/filter/excel/xiescher.cxx |2 
 sc/source/filter/excel/xistyle.cxx  |2 
 sc/source/filter/excel/xlstyle.cxx  |   34 ++---
 sc/source/filter/html/htmlexp.cxx   |2 
 sc/source/filter/inc/stylesbuffer.hxx   |   12 ++--
 sc/source/filter/inc/themebuffer.hxx|4 -
 sc/source/filter/inc/viewsettings.hxx   |2 
 sc/source/filter/oox/condformatbuffer.cxx   |   17 +-
 sc/source/filter/oox/pagesettings.cxx   |2 
 sc/source/filter/oox/stylesbuffer.cxx   |   52 ++--
 sc/source/filter/oox/themebuffer.cxx|8 +--
 sc/source/filter/oox/viewsettings.cxx   |4 -
 sc/source/filter/xcl97/xcl97rec.cxx |2 
 sc/source/filter/xml/xmlsceni.cxx   |6 --
 sc/source/ui/Accessibility/AccessibleCellBase.cxx   |8 +--
 sc/source/ui/Accessibility/AccessibleCsvControl.cxx |8 +--
 sc/source/ui/app/rfindlst.cxx   |4 -
 sc/source/ui/cctrl/cbuttonw.cxx |2 
 sc/source/ui/optdlg/opredlin.cxx|   18 +++---
 sc/source/ui/sidebar/CellBorderUpdater.cxx  |2 
 sc/source/ui/unoobj/cellsuno.cxx|4 -
 sc/source/ui/unoobj/condformatuno.cxx   |   13 +
 sc/source/ui/unoobj/confuno.cxx |2 
 sc/source/ui/unoobj/viewuno.cxx |4 -
 sc/source/ui/vba/vbaborders.cxx |2 
 sc/source/ui/vba/vbainterior.cxx|   19 +++
 sc/source/ui/vba/vbapalette.cxx |   16 +++---
 sc/source/ui/view/formatsh.cxx  |2 
 sc/source/ui/view/viewdata.cxx  |7 +-
 35 files changed, 154 insertions(+), 174 deletions(-)

New commits:
commit 9d1f56903b05841020dfae21dca0c686483b2494
Author: Noel Grandin 
Date:   Tue Mar 6 13:34:11 2018 +0200

use more Color in sc

Change-Id: Ifdd53fa0eed8cec7878d0f5b9eea1e2c826e3ae5
Reviewed-on: https://gerrit.libreoffice.org/50819
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/appoptio.hxx b/sc/inc/appoptio.hxx
index cdc055e07ee2..43a75832be4b 100644
--- a/sc/inc/appoptio.hxx
+++ b/sc/inc/appoptio.hxx
@@ -57,14 +57,14 @@ public:
 voidSetDetectiveAuto( bool bNew )   { bDetectiveAuto = bNew; }
 boolGetDetectiveAuto() const{ return bDetectiveAuto; }
 
-voidSetTrackContentColor(sal_uInt32 nNew) { nTrackContentColor = 
nNew; }
-sal_uInt32  GetTrackContentColor() const { return nTrackContentColor; }
-voidSetTrackInsertColor(sal_uInt32 nNew)  { nTrackInsertColor = 
nNew;  }
-sal_uInt32  GetTrackInsertColor() const  { return nTrackInsertColor;  }
-voidSetTrackDeleteColor(sal_uInt32 nNew)  { nTrackDeleteColor = 
nNew;  }
-sal_uInt32  GetTrackDeleteColor() const  { return nTrackDeleteColor;  }
-voidSetTrackMoveColor(sal_uInt32 nNew){ nTrackMoveColor = 
nNew;}
-sal_uInt32  GetTrackMoveColor() const{ return nTrackMoveColor;}
+voidSetTrackContentColor(Color nNew) { nTrackContentColor = nNew; }
+Color   GetTrackContentColor() const { return nTrackContentColor; }
+voidSetTrackInsertColor(Color nNew)  { nTrackInsertColor = nNew;  }
+Color   GetTrackInsertColor() const  { return nTrackInsertColor;  }
+voidSetTrackDeleteColor(Color nNew)  { nTrackDeleteColor = nNew;  }
+Color   GetTrackDeleteColor() const  { return nTrackDeleteColor;  }
+voidSetTrackMoveColor(Color nNew){ nTrackMoveColor = nNew;}
+Color   GetTrackMoveColor() const{ return nTrackMoveColor;}
 
 ScLkUpdMode GetLinkMode() const { return eLinkMode ;}
 voidSetLinkMode( ScLkUpdMode nSet ) {   eLinkMode  = nSet;}
@@ -92,10 +92,10 @@ private:
 sal_uInt32  nStatusFunc;
 boolbAutoComplete;
 boolbDetectiveAuto;
-sal_uInt32  nTrackContentColor;
-sal_uInt32  nTrackInsertColor;
-sal_uInt32  nTrackDeleteColor;
-sal_uInt32  nTrackMoveColor;
+Color   nTrackContentColor;
+Color   nTrackInsertColor;
+Color   nTrackDeleteColor;
+Color   nTrackMoveColor;
 ScLkUpdMode eLinkMode;
 sal_Int32   

[Libreoffice-commits] core.git: sd/qa sd/source

[Noel Grandin]

 sd/qa/unit/import-tests.cxx|4 +-
 sd/source/core/EffectMigration.cxx |2 -
 sd/source/core/drawdoc4.cxx|2 -
 sd/source/filter/eppt/epptbase.hxx |2 -
 sd/source/filter/eppt/pptx-stylesheet.cxx  |   13 +++
 sd/source/filter/html/htmlex.cxx   |   10 ++---
 sd/source/filter/html/pubdlg.cxx   |   10 ++---
 sd/source/filter/ppt/ppt97animations.cxx   |6 ++-
 sd/source/filter/ppt/ppt97animations.hxx   |5 +-
 sd/source/filter/ppt/pptin.cxx |2 -
 sd/source/filter/ppt/pptinanimations.cxx   |4 +-
 sd/source/ui/accessibility/AccessibleSlideSorterObject.cxx |4 +-
 sd/source/ui/accessibility/AccessibleSlideSorterView.cxx   |4 +-
 sd/source/ui/animations/CustomAnimationDialog.cxx  |   10 ++---
 sd/source/ui/animations/motionpathtag.cxx  |2 -
 sd/source/ui/dlg/copydlg.cxx   |6 +--
 sd/source/ui/slideshow/slideshowimpl.cxx   |4 +-
 sd/source/ui/slidesorter/shell/SlideSorterService.cxx  |8 ++--
 sd/source/ui/slidesorter/view/SlideSorterView.cxx  |4 +-
 sd/source/ui/slidesorter/view/SlsTheme.cxx |   22 ++---
 sd/source/ui/unoidl/unoobj.cxx |2 -
 21 files changed, 64 insertions(+), 62 deletions(-)

New commits:
commit 1a41c0711d10bcfa45c7cd7d56c1e7f0055fa310
Author: Noel Grandin 
Date:   Tue Mar 6 13:18:13 2018 +0200

use more Color in sd

Change-Id: Iefd544a70730dfb760b7a89ff697a86ab4fae685
Reviewed-on: https://gerrit.libreoffice.org/50818
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 4fcc325b2370..bc343af65ba5 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -993,11 +993,11 @@ void SdImportTest::testBnc584721_4()
 // Get first run of the paragraph
 uno::Reference xRun( getRunFromParagraph (0, xParagraph 
) );
 uno::Reference< beans::XPropertySet > xPropSet( xRun, uno::UNO_QUERY_THROW 
);
-sal_Int32 nCharColor;
+Color nCharColor;
 xPropSet->getPropertyValue( "CharColor" ) >>= nCharColor;
 
 // Color should be black
-CPPUNIT_ASSERT_EQUAL( sal_Int32(COL_BLACK), nCharColor );
+CPPUNIT_ASSERT_EQUAL( COL_BLACK, nCharColor );
 
 xDocShRef->DoClose();
 }
diff --git a/sd/source/core/EffectMigration.cxx 
b/sd/source/core/EffectMigration.cxx
index 62b10a680f23..59f60cb21323 100644
--- a/sd/source/core/EffectMigration.cxx
+++ b/sd/source/core/EffectMigration.cxx
@@ -1019,7 +1019,7 @@ void EffectMigration::SetDimPrevious( SvxShape* pShape, 
bool bDimPrevious )
 Any aColor;
 
 if( bDimPrevious )
-aColor <<= static_cast(COL_LIGHTGRAY);
+aColor <<= COL_LIGHTGRAY;
 
 sd::MainSequencePtr pMainSequence = 
static_cast(pObj->GetPage())->getMainSequence();
 
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx
index 7fda9ef61e67..bf9686b5a777 100644
--- a/sd/source/core/drawdoc4.cxx
+++ b/sd/source/core/drawdoc4.cxx
@@ -550,7 +550,7 @@ void SdDrawDocument::CreateDefaultCellStyles()
 XHatchaNullHatch(aNullCol);
 
 rISet.Put(XFillStyleItem(drawing::FillStyle_SOLID));
-rISet.Put(XFillColorItem(OUString(), 0x00ff));
+rISet.Put(XFillColorItem(OUString(), Color(0x00ff)));
 
 vcl::Font aLatinFont, aCJKFont, aCTLFont;
 
diff --git a/sd/source/filter/eppt/epptbase.hxx 
b/sd/source/filter/eppt/epptbase.hxx
index b47d1a44fb4a..76f45a490da4 100644
--- a/sd/source/filter/eppt/epptbase.hxx
+++ b/sd/source/filter/eppt/epptbase.hxx
@@ -229,7 +229,7 @@ struct PPTExCharLevel
 sal_uInt16  mnAsianOrComplexFont;
 sal_uInt16  mnFontHeight;
 sal_uInt16  mnEscapement;
-sal_uInt32  mnFontColor;
+Color   mnFontColor;
 };
 
 struct PPTExCharSheet
diff --git a/sd/source/filter/eppt/pptx-stylesheet.cxx 
b/sd/source/filter/eppt/pptx-stylesheet.cxx
index e848deb77820..1dbd28ee8a11 100644
--- a/sd/source/filter/eppt/pptx-stylesheet.cxx
+++ b/sd/source/filter/eppt/pptx-stylesheet.cxx
@@ -102,8 +102,8 @@ void PPTExCharSheet::Write( SvStream& rSt, sal_uInt16 nLev, 
bool bSimpleText,
.WriteUInt16( rLev.mnFlags )
.WriteUInt16( rLev.mnFont );
 
-sal_uInt32 nFontColor = rLev.mnFontColor;
-if ( nFontColor == sal_uInt32(COL_AUTO) )
+Color nFontColor = rLev.mnFontColor;
+if ( nFontColor == COL_AUTO )
 {
 bool bIsDark = false;
 css::uno::Any aAny;
@@ -111,12 +111,11 @@ void PPTExCharSheet::Write( SvStream& rSt, sal_uInt16 
nLev, bool bSimpleText,
 aAny >>= bIsDark;
 nFontColor = bIsDark ? 

[Libreoffice-commits] core.git: sfx2/source slideshow/source starmath/source svl/source svtools/source

[Noel Grandin]

 sfx2/source/control/thumbnailviewacc.cxx   |8 +++---
 sfx2/source/dialog/backingwindow.cxx   |4 +--
 sfx2/source/sidebar/Tools.cxx  |4 +--
 slideshow/source/engine/shapes/gdimtftools.cxx |2 -
 starmath/source/accessibility.cxx  |   16 ++--
 starmath/source/dialog.cxx |4 +--
 starmath/source/tmpdevice.cxx  |2 -
 svl/source/numbers/numfmuno.cxx|6 ++--
 svtools/source/config/colorcfg.cxx |   32 ++---
 svtools/source/config/extcolorcfg.cxx  |2 -
 svtools/source/config/optionsdrawinglayer.cxx  |   16 ++--
 svtools/source/contnr/imivctl1.cxx |2 -
 svtools/source/control/accessibleruler.cxx |4 +--
 svtools/source/control/toolbarmenuacc.cxx  |8 +++---
 svtools/source/control/valueacc.cxx|   12 -
 svtools/source/dialogs/colrdlg.cxx |9 +--
 svtools/source/graphic/grfmgr2.cxx |4 +--
 svtools/source/uno/svtxgridcontrol.cxx |4 +--
 svtools/source/uno/unocontroltablemodel.cxx|2 -
 svtools/source/uno/unoiface.cxx|7 ++---
 20 files changed, 73 insertions(+), 75 deletions(-)

New commits:
commit 26a016be816826c80fc914a927758a814f29136c
Author: Noel Grandin 
Date:   Tue Mar 6 13:08:51 2018 +0200

use more Color in sfx2..svtools

Change-Id: Idd951841ce7e9c4b4e5229bc24efe5c7b8042617
Reviewed-on: https://gerrit.libreoffice.org/50817
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/control/thumbnailviewacc.cxx 
b/sfx2/source/control/thumbnailviewacc.cxx
index 600e8d705e21..04a7435ccb54 100644
--- a/sfx2/source/control/thumbnailviewacc.cxx
+++ b/sfx2/source/control/thumbnailviewacc.cxx
@@ -394,14 +394,14 @@ void SAL_CALL ThumbnailViewAcc::grabFocus()
 sal_Int32 SAL_CALL ThumbnailViewAcc::getForeground(  )
 {
 ThrowIfDisposed();
-sal_uInt32 nColor = 
Application::GetSettings().GetStyleSettings().GetWindowTextColor().GetColor();
+Color nColor = 
Application::GetSettings().GetStyleSettings().GetWindowTextColor();
 return static_cast(nColor);
 }
 
 sal_Int32 SAL_CALL ThumbnailViewAcc::getBackground(  )
 {
 ThrowIfDisposed();
-sal_uInt32 nColor = 
Application::GetSettings().GetStyleSettings().GetWindowColor().GetColor();
+Color nColor = 
Application::GetSettings().GetStyleSettings().GetWindowColor();
 return static_cast(nColor);
 }
 
@@ -884,13 +884,13 @@ void SAL_CALL ThumbnailViewItemAcc::grabFocus()
 
 sal_Int32 SAL_CALL ThumbnailViewItemAcc::getForeground(  )
 {
-sal_uInt32 nColor = 
Application::GetSettings().GetStyleSettings().GetWindowTextColor().GetColor();
+Color nColor = 
Application::GetSettings().GetStyleSettings().GetWindowTextColor();
 return static_cast(nColor);
 }
 
 sal_Int32 SAL_CALL ThumbnailViewItemAcc::getBackground(  )
 {
-return 
static_cast(Application::GetSettings().GetStyleSettings().GetWindowColor().GetColor());
+return 
static_cast(Application::GetSettings().GetStyleSettings().GetWindowColor());
 }
 
 sal_Int64 SAL_CALL ThumbnailViewItemAcc::getSomething( const uno::Sequence< 
sal_Int8 >& rId )
diff --git a/sfx2/source/dialog/backingwindow.cxx 
b/sfx2/source/dialog/backingwindow.cxx
index 8966a27face4..d2a30e25acdf 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -72,7 +72,7 @@ float const fMultiplier = 1.4f;
 BackingWindow::BackingWindow( vcl::Window* i_pParent ) :
 Window( i_pParent ),
 mbLocalViewInitialized(false),
-
maButtonsTextColor(officecfg::Office::Common::Help::StartCenter::StartCenterTextColor::get()),
+
maButtonsTextColor(Color(officecfg::Office::Common::Help::StartCenter::StartCenterTextColor::get())),
 mbInitControls( false )
 {
 m_pUIBuilder.reset(new VclBuilder(this, getUIRootDir(), 
"sfx/ui/startcenter.ui", "StartCenter" ));
@@ -279,7 +279,7 @@ void BackingWindow::initControls()
 mpHelpButton->SetControlForeground(maButtonsTextColor);
 mpExtensionsButton->SetControlForeground(maButtonsTextColor);
 
-const Color 
aButtonsBackground(officecfg::Office::Common::Help::StartCenter::StartCenterBackgroundColor::get());
+const Color aButtonsBackground = 
Color(officecfg::Office::Common::Help::StartCenter::StartCenterBackgroundColor::get());
 
 mpAllButtonsBox->SetBackground(aButtonsBackground);
 mpSmallButtonsBox->SetBackground(aButtonsBackground);
diff --git a/sfx2/source/sidebar/Tools.cxx b/sfx2/source/sidebar/Tools.cxx
index deeb3eb56808..727cd6f24bec 100644
--- a/sfx2/source/sidebar/Tools.cxx
+++ b/sfx2/source/sidebar/Tools.cxx
@@ -97,8 +97,8 @@ Gradient Tools::AwtToVclGradient (const css::awt::Gradient& 
rAwtGradient)
 {
 Gradient aVclGradient (
 GradientStyle(rAwtGradient.Style),
-

[Libreoffice-commits] core.git: sw/inc sw/source

[Noel Grandin]

 sw/inc/unosett.hxx   |4 ++--
 sw/source/core/access/acccell.cxx|6 +++---
 sw/source/core/access/accpara.cxx|   10 +-
 sw/source/core/access/acctable.cxx   |6 +++---
 sw/source/core/doc/docfmt.cxx|2 +-
 sw/source/core/edit/edfcol.cxx   |2 +-
 sw/source/core/layout/atrfrm.cxx |2 +-
 sw/source/core/text/inftxt.cxx   |4 ++--
 sw/source/core/txtnode/fntcache.cxx  |   12 ++--
 sw/source/core/unocore/unosett.cxx   |2 +-
 sw/source/core/view/viewimp.cxx  |2 +-
 sw/source/filter/html/css1atr.cxx|6 +++---
 sw/source/filter/html/htmlatr.cxx|4 ++--
 sw/source/filter/html/htmlform.cxx   |2 +-
 sw/source/filter/html/wrthtml.cxx|6 +++---
 sw/source/filter/inc/wrtswtbl.hxx|2 +-
 sw/source/filter/writer/wrtswtbl.cxx |4 ++--
 sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
 sw/source/filter/ww8/rtfattributeoutput.cxx  |   10 +-
 sw/source/filter/ww8/rtfexport.cxx   |4 ++--
 sw/source/filter/ww8/wrtw8esh.cxx|2 +-
 sw/source/filter/ww8/wrtww8.cxx  |2 +-
 sw/source/filter/ww8/ww8atr.cxx  |   14 +++---
 sw/source/filter/ww8/ww8par.hxx  |4 ++--
 sw/source/filter/ww8/ww8par2.cxx |   10 +-
 sw/source/filter/ww8/ww8par3.cxx |2 +-
 sw/source/filter/ww8/ww8par6.cxx |   22 +++---
 sw/source/filter/ww8/ww8scan.cxx |2 +-
 sw/source/filter/ww8/ww8struc.hxx|7 ++-
 sw/source/filter/xml/xmlexpit.cxx|2 +-
 sw/source/filter/xml/xmlimpit.cxx|4 +---
 sw/source/filter/xml/xmlithlp.cxx|3 +--
 sw/source/ui/config/optpage.cxx  |   10 +-
 sw/source/uibase/app/docsh2.cxx  |2 +-
 sw/source/uibase/config/modcfg.cxx   |   10 +-
 sw/source/uibase/config/usrpref.cxx  |4 ++--
 sw/source/uibase/config/viewopt.cxx  |2 +-
 sw/source/uibase/docvw/AnnotationWin2.cxx|2 +-
 sw/source/uibase/utlui/shdwcrsr.cxx  |2 +-
 sw/source/uibase/utlui/uiitems.cxx   |7 ---
 40 files changed, 104 insertions(+), 101 deletions(-)

New commits:
commit 9a97b9c051735afb3797888d111f1b6b2cab1a83
Author: Noel Grandin 
Date:   Tue Mar 6 11:09:21 2018 +0200

use more Color in sw

Change-Id: I51d575c40228bbd2ff384f12da33c1cd8bda2dda
Reviewed-on: https://gerrit.libreoffice.org/50800
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/unosett.hxx b/sw/inc/unosett.hxx
index 295eb06fe671..bf83e499f7b7 100644
--- a/sw/inc/unosett.hxx
+++ b/sw/inc/unosett.hxx
@@ -256,7 +256,7 @@ class SwXTextColumns : public cppu::WeakAggImplHelper4
 
 //separator line
 sal_Int32   nSepLineWidth;
-sal_Int32   nSepLineColor;
+Color   nSepLineColor;
 sal_Int8nSepLineHeightRelative;
 css::style::VerticalAlignment nSepLineVertAlign;
 boolbSepLineIsOn;
@@ -295,7 +295,7 @@ public:
 virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() 
override;
 
 sal_Int32   GetSepLineWidth() const {return nSepLineWidth;}
-sal_Int32   GetSepLineColor() const {return nSepLineColor;}
+Color   GetSepLineColor() const {return nSepLineColor;}
 sal_Int8GetSepLineHeightRelative() const {return
nSepLineHeightRelative;}
 css::style::VerticalAlignment GetSepLineVertAlign() const {return 
nSepLineVertAlign;}
 boolGetSepLineIsOn() const {return  bSepLineIsOn;}
diff --git a/sw/source/core/access/acccell.cxx 
b/sw/source/core/access/acccell.cxx
index 90fff856bf2e..f75a6fda8cdd 100644
--- a/sw/source/core/access/acccell.cxx
+++ b/sw/source/core/access/acccell.cxx
@@ -418,7 +418,7 @@ sal_Int32 SAL_CALL SwAccessibleCell::getBackground()
 SolarMutexGuard g;
 
 const SvxBrushItem  = GetFrame()->GetAttrSet()->GetBackground();
-sal_uInt32 crBack = rBack.GetColor().GetColor();
+Color crBack = rBack.GetColor();
 
 if (COL_AUTO == crBack)
 {
@@ -428,11 +428,11 @@ sal_Int32 SAL_CALL SwAccessibleCell::getBackground()
 uno::Reference xCompoentDoc(xAccDoc, 
uno::UNO_QUERY);
 if (xCompoentDoc.is())
 {
-crBack = 
static_cast(xCompoentDoc->getBackground());
+crBack = Color(xCompoentDoc->getBackground());
 }
 }
 }
-return crBack;
+return sal_Int32(crBack);
 }
 
 // XAccessibleSelection
diff --git a/sw/source/core/access/accpara.cxx 
b/sw/source/core/access/accpara.cxx
index 0b35cdf968c9..beb170862692 100644

[Libreoffice-commits] core.git: vcl/inc vcl/qa vcl/source vcl/win vcl/workben

[Noel Grandin]

 vcl/inc/svdata.hxx |   12 ++--
 vcl/qa/cppunit/BitmapProcessorTest.cxx |2 +-
 vcl/qa/cppunit/BitmapTest.cxx  |2 +-
 vcl/source/app/settings.cxx|2 +-
 vcl/source/control/button.cxx  |   24 
 vcl/source/gdi/gdimetafiletools.cxx|2 +-
 vcl/source/gdi/gdimtf.cxx  |6 +++---
 vcl/source/gdi/pngread.cxx |2 +-
 vcl/source/window/decoview.cxx |2 +-
 vcl/win/window/salframe.cxx|4 ++--
 vcl/workben/vcldemo.cxx|   10 +-
 11 files changed, 34 insertions(+), 34 deletions(-)

New commits:
commit b3ee860e523dce3df16350a4053a67f39c2f92f8
Author: Noel Grandin 
Date:   Tue Mar 6 10:42:13 2018 +0200

use more Color in vcl

Change-Id: Ia92c52d26b90898c1f7860128b478d1fada9d406
Reviewed-on: https://gerrit.libreoffice.org/50795
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index a074b3ce937f..42300a1e56e2 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -232,12 +232,12 @@ struct ImplSVCtrlData
 ImplTBDragMgr*  mpTBDragMgr = nullptr;  // DragMgr for 
ToolBox
 sal_uInt16  mnCheckStyle = 0;   // CheckBox-Style 
for ImageList-Update
 sal_uInt16  mnRadioStyle = 0;   // Radio-Style for 
ImageList-Update
-sal_uLong   mnLastCheckFColor = 0;  // Last FaceColor 
for CheckImage
-sal_uLong   mnLastCheckWColor = 0;  // Last 
WindowColor for CheckImage
-sal_uLong   mnLastCheckLColor = 0;  // Last LightColor 
for CheckImage
-sal_uLong   mnLastRadioFColor = 0;  // Last FaceColor 
for RadioImage
-sal_uLong   mnLastRadioWColor = 0;  // Last 
WindowColor for RadioImage
-sal_uLong   mnLastRadioLColor = 0;  // Last LightColor 
for RadioImage
+Color   mnLastCheckFColor;  // Last FaceColor 
for CheckImage
+Color   mnLastCheckWColor;  // Last 
WindowColor for CheckImage
+Color   mnLastCheckLColor;  // Last LightColor 
for CheckImage
+Color   mnLastRadioFColor;  // Last FaceColor 
for RadioImage
+Color   mnLastRadioWColor;  // Last 
WindowColor for RadioImage
+Color   mnLastRadioLColor;  // Last LightColor 
for RadioImage
 FieldUnitStringList*mpFieldUnitStrings = nullptr;   // list with field 
units
 FieldUnitStringList*mpCleanUnitStrings = nullptr;   // same list but 
with some "fluff" like spaces removed
 };
diff --git a/vcl/qa/cppunit/BitmapProcessorTest.cxx 
b/vcl/qa/cppunit/BitmapProcessorTest.cxx
index 558401f84771..300302d41d60 100644
--- a/vcl/qa/cppunit/BitmapProcessorTest.cxx
+++ b/vcl/qa/cppunit/BitmapProcessorTest.cxx
@@ -50,7 +50,7 @@ void BitmapProcessorTest::testDisabledImage()
 {
 Bitmap::ScopedReadAccess pReadAccess(aDisabledBitmap);
 Color aColor(pReadAccess->GetPixel(0, 0).GetColor());
-CPPUNIT_ASSERT_EQUAL(sal_uInt32(0x001E1E1E), sal_uInt32(aColor));
+CPPUNIT_ASSERT_EQUAL(Color(0x001E1E1E), aColor);
 }
 }
 
diff --git a/vcl/qa/cppunit/BitmapTest.cxx b/vcl/qa/cppunit/BitmapTest.cxx
index 5af967052326..3f112fa6f86b 100644
--- a/vcl/qa/cppunit/BitmapTest.cxx
+++ b/vcl/qa/cppunit/BitmapTest.cxx
@@ -484,7 +484,7 @@ void BitmapTest::testCRC()
 #endif
 
 // a 1x1 black & white checkerboard
-aVDev->DrawCheckered(Point(), aVDev->GetOutputSizePixel(), 1, 1);
+aVDev->DrawCheckered(Point(), aVDev->GetOutputSizePixel(), 1, Color(0, 0, 
1));
 Bitmap aChecker = getAsBitmap(aVDev);
 checkAndInsert(aCRCs, aChecker, "checkerboard");
 aChecker.Invert();
diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx
index f7c35931ee60..f9eaf47ce645 100644
--- a/vcl/source/app/settings.cxx
+++ b/vcl/source/app/settings.cxx
@@ -2159,7 +2159,7 @@ static void setupPersonaHeaderFooter( WhichPersona 
eWhich, OUString& rHeaderFoot
 if ( nIndex > 0 )
 {
 OUString aColor = aPersonaSettings.getToken( 0, ';', ++nIndex );
-rMenuBarTextColor = Color( aColor.toUInt64( 16 ) );
+rMenuBarTextColor = Color( aColor.toUInt32( 16 ) );
 }
 }
 
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index bffbd1e93b66..35400b70ed8a 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -2756,15 +2756,15 @@ Image RadioButton::GetRadioImage( const AllSettings& 
rSettings, DrawButtonFlags
 
 if ( pSVData->maCtrlData.maRadioImgList.empty() ||
  (pSVData->maCtrlData.mnRadioStyle != nStyle) ||
- 

[Libreoffice-bugs] [Bug 115432] ODF filters: footnote separator style:adjustment not imported /exported, always "left"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115432

--- Comment #20 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2407c183092d6559771738891d57d6375c4212ab

Revert "tdf#115432 footnote separator position remain in the left side"

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source xmloff/source

[Noel Grandin]

 sw/source/core/unocore/unomap1.cxx |3 +--
 sw/source/uibase/utlui/uiitems.cxx |   11 +++
 xmloff/source/style/XMLFootnoteSeparatorExport.cxx |3 +--
 3 files changed, 9 insertions(+), 8 deletions(-)

New commits:
commit 2407c183092d6559771738891d57d6375c4212ab
Author: Noel Grandin 
Date:   Tue Mar 6 14:16:48 2018 +0100

Revert "tdf#115432 footnote separator position remain in the left side"

This reverts commit d4a8d91abd40dee7f7bd739a678a502a6e34cb59.

because it changes the type of an UNO property defined in a published IDL 
file

Change-Id: I4d3db3532b27552a30f34fcd4201856565eb0a3b
Reviewed-on: https://gerrit.libreoffice.org/50825
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/unocore/unomap1.cxx 
b/sw/source/core/unocore/unomap1.cxx
index 522a9bc8610e..fbe12b66844e 100644
--- a/sw/source/core/unocore/unomap1.cxx
+++ b/sw/source/core/unocore/unomap1.cxx
@@ -58,7 +58,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -584,7 +583,7 @@ const SfxItemPropertyMapEntry*  
SwUnoPropertyMapProvider::GetPageStylePropertyMa
 { OUString(UNO_NAME_FOOTNOTE_LINE_COLOR), FN_PARAM_FTN_INFO,
cppu::UnoType::get(),   PROPERTY_NONE , MID_LINE_COLOR},
 { OUString(UNO_NAME_FOOTNOTE_LINE_STYLE), FN_PARAM_FTN_INFO,
cppu::UnoType::get(),PROPERTY_NONE , MID_FTN_LINE_STYLE},
 { OUString(UNO_NAME_FOOTNOTE_LINE_RELATIVE_WIDTH), FN_PARAM_FTN_INFO,  
 cppu::UnoType::get(),PROPERTY_NONE , 
MID_LINE_RELWIDTH},
-{ OUString(UNO_NAME_FOOTNOTE_LINE_ADJUST), FN_PARAM_FTN_INFO,   
cppu::UnoType::get(),   PROPERTY_NONE , 
MID_LINE_ADJUST },
+{ OUString(UNO_NAME_FOOTNOTE_LINE_ADJUST), FN_PARAM_FTN_INFO,   
cppu::UnoType::get(),   PROPERTY_NONE , MID_LINE_ADJUST },
 { OUString(UNO_NAME_FOOTNOTE_LINE_TEXT_DISTANCE), FN_PARAM_FTN_INFO,   
 cppu::UnoType::get(),   PROPERTY_NONE , MID_LINE_TEXT_DIST  
 |CONVERT_TWIPS },
 { OUString(UNO_NAME_FOOTNOTE_LINE_DISTANCE), FN_PARAM_FTN_INFO,
 cppu::UnoType::get(),   PROPERTY_NONE , 
MID_LINE_FOOTNOTE_DIST|CONVERT_TWIPS},
 { OUString(UNO_NAME_WRITING_MODE), RES_FRAMEDIR, 
cppu::UnoType::get(), PROPERTY_NONE, 0 },
diff --git a/sw/source/uibase/utlui/uiitems.cxx 
b/sw/source/uibase/utlui/uiitems.cxx
index eb1d80be738f..8b3f02a74b8a 100644
--- a/sw/source/uibase/utlui/uiitems.cxx
+++ b/sw/source/uibase/utlui/uiitems.cxx
@@ -18,7 +18,6 @@
  */
 
 #include 
-#include 
 #include 
 
 #include 
@@ -87,7 +86,7 @@ bool SwPageFootnoteInfoItem::QueryValue( Any& rVal, sal_uInt8 
nMemberId ) const
 rVal <<= static_cast(static_cast(aTmp));
 }
 break;
-case MID_LINE_ADJUST   : rVal <<= 
aFootnoteInfo.GetAdj();break;//text::HorizontalAdjust
+case MID_LINE_ADJUST   : rVal <<= 
static_cast(aFootnoteInfo.GetAdj());break;//text::HorizontalAdjust
 case MID_LINE_TEXT_DIST: rVal <<= 
static_cast(convertTwipToMm100(aFootnoteInfo.GetTopDist()));break;
 case MID_LINE_FOOTNOTE_DIST: rVal <<= 
static_cast(convertTwipToMm100(aFootnoteInfo.GetBottomDist()));break;
 case MID_FTN_LINE_STYLE:
@@ -157,8 +156,12 @@ bool SwPageFootnoteInfoItem::PutValue(const Any& rVal, 
sal_uInt8 nMemberId)
 break;
 case MID_LINE_ADJUST   :
 {
-text::HorizontalAdjust nSet = 
*o3tl::forceAccess(rVal);
-aFootnoteInfo.SetAdj(nSet);
+sal_Int16 nSet = 0;
+rVal >>= nSet;
+if(nSet >= 0 && nSet < 3) //text::HorizontalAdjust
+
aFootnoteInfo.SetAdj(static_cast(nSet));
+else
+bRet = false;
 }
 break;
 case MID_FTN_LINE_STYLE:
diff --git a/xmloff/source/style/XMLFootnoteSeparatorExport.cxx 
b/xmloff/source/style/XMLFootnoteSeparatorExport.cxx
index edf57dd3a6bd..5446398e5e72 100644
--- a/xmloff/source/style/XMLFootnoteSeparatorExport.cxx
+++ b/xmloff/source/style/XMLFootnoteSeparatorExport.cxx
@@ -31,7 +31,6 @@
 #include 
 #include 
 #include 
-#include 
 
 
 using namespace ::com::sun::star;
@@ -76,7 +75,7 @@ void XMLFootnoteSeparatorExport::exportXML(
 switch (rMapper->GetEntryContextId(rState.mnIndex))
 {
 case CTF_PM_FTN_LINE_ADJUST:
-eLineAdjust = 
*o3tl::forceAccess(rState.maValue);
+rState.maValue >>= eLineAdjust;
 break;
 case CTF_PM_FTN_LINE_COLOR:
 rState.maValue >>= nLineColor;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 88025] XY (scatter) first column of Y data lost on editions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88025

raal  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from raal  ---
Closing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116254] New: Writer: pdf-images disappear when exporting as pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116254

Bug ID: 116254
   Summary: Writer: pdf-images disappear when exporting as pdf
   Product: LibreOffice
   Version: 5.4.5.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oli4stu...@hotmail.com

Description:
When embedding a pdf as an image, the image is printed blank when the document
is exported as pdf.

Steps to Reproduce:
1. New Writer document
2. Insert > Image... > choose any pdf that wasn't created with LO and open *
3. Add some text
4. Export as PDF **

* doesn't matter if embedded or linked
** doesn't matter if using the toolbar button "Export as PDF" or File > Export
as PDF...

Actual Results:  
Text is visible, but image is not in exported pdf file

Expected Results:
Image should be visible in exported pdf file too


Reproducible: Always


User Profile Reset: No



Additional Info:
- It seems to work with pdf files that were created with LO, but not with
others e.g. pdf files created by InkScape. If desired, I can provide pdf files.

- It worked as expected in 5.4.3.2

- About:
Version: 5.4.5.1 (x64)
Build ID: 79c9829dd5d8054ec39a82dc51cd9eff340dbee8
CPU threads: 8; OS: Windows 6.1; UI render: default; 
Locale: de-CH (de_CH); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/64.0.3282.168 Safari/537.36 OPR/51.0.2830.40

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95949] Changing Display Mode using View menu does not update Display Mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95949

--- Comment #5 from Óvári  ---
(In reply to QA Administrators from comment #4)
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.
Version: 6.0.2.1
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 2; OS: Linux 4.13; UI render: default; VCL: gtk2

Linux Mint 18.3 Cinnamon 64-bit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111591] [META] File sending bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111591
Bug 111591 depends on bug 116074, which changed state.

Bug 116074 Summary: Send -> E-mail document... blocks LibreOffice until sending 
e-mail is finished
https://bugs.documentfoundation.org/show_bug.cgi?id=116074

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97143] Only current frame showing which selecting multiple columns/ rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97143

--- Comment #8 from Óvári  ---
(In reply to QA Administrators from comment #7)
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.
Version: 6.0.2.1
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 2; OS: Linux 4.13; UI render: default; VCL: gtk2

Linux Mint 18.3 Cinnamon 64-bit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88025] XY (scatter) first column of Y data lost on editions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88025

--- Comment #8 from andis.lazd...@gmail.com ---
The problem is not appearing in 6.0.2.1, report can be closed as solved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115420

--- Comment #40 from Aron Budea  ---
(In reply to Michael Meeks from comment #39)
> Thoughts much appreciated; I append a blind fix in case someone can
> reproduce this and can compile that.
After applying the patch, I'm getting assertion failed at startup:
"vcl/win/app/salint.cxx Line: 611

Expression: !pInst->mbNoYieldLock"

Note that I pulled ~1.5 weeks ago, so the sources aren't the freshest.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - icc/makefile.mk icc/SampleICC-1.3.2-Win64.patch salhelper/source

[Damjan Jovanovic]

 icc/SampleICC-1.3.2-Win64.patch |   11 +++
 icc/makefile.mk |2 -
 salhelper/source/makefile.mk|2 +
 salhelper/source/mscx.map   |   58 
 4 files changed, 72 insertions(+), 1 deletion(-)

New commits:
commit 4fd38c7a96b91bdce3804a490e6f4b643000c212
Author: Damjan Jovanovic 
Date:   Wed Mar 7 04:37:48 2018 +

Patch main/icc to build on Win64.

Patch by: me

diff --git a/icc/SampleICC-1.3.2-Win64.patch b/icc/SampleICC-1.3.2-Win64.patch
new file mode 100644
index ..ad1c8a54f81c
--- /dev/null
+++ b/icc/SampleICC-1.3.2-Win64.patch
@@ -0,0 +1,11 @@
+--- misc/build/SampleICC-1.3.2/IccProfLib/IccProfLibConf.h 2018-03-07 
06:19:39.296824700 +0200
 misc/build/SampleICC-1.3.2/IccProfLib/IccProfLibConf.h 2018-03-07 
06:33:33.075513600 +0200
+@@ -80,7 +80,7 @@
+ #endif
+ 
+ //PC, visual C++
+-#if defined(_MSC_VER) && !defined(__MWERKS__) && defined(_M_IX86)
++#if defined(_MSC_VER) && !defined(__MWERKS__) && (defined(_M_IX86) || 
defined(_M_AMD64))
+ 
+   //Define how 64 bit integers are represented
+   #define ICCUINT64 unsigned __int64
diff --git a/icc/makefile.mk b/icc/makefile.mk
index 40e849058e27..3b6d3102c75f 100644
--- a/icc/makefile.mk
+++ b/icc/makefile.mk
@@ -34,7 +34,7 @@ TARGET=icc
 
 TARFILE_NAME=SampleICC-1.3.2
 TARFILE_MD5=fdb27bfe2dbe2e7b57ae194d9bf36bab
-PATCH_FILES=$(TARFILE_NAME).patch $(TARFILE_NAME).format-security.patch
+PATCH_FILES=$(TARFILE_NAME).patch $(TARFILE_NAME).format-security.patch 
SampleICC-1.3.2-Win64.patch
 
 CONVERTFILES= \
 IccProfLib$/IccTagProfSeqId.h \
commit fbff6744fa4f49e5a3389a1c1d174b2a9914a211
Author: Damjan Jovanovic 
Date:   Wed Mar 7 04:15:14 2018 +

Add a linker map file for salhelper on Win64.

Patch by: me

diff --git a/salhelper/source/makefile.mk b/salhelper/source/makefile.mk
index 440bc6c2b11e..2f9ed8485e98 100644
--- a/salhelper/source/makefile.mk
+++ b/salhelper/source/makefile.mk
@@ -64,6 +64,8 @@ DEF1NAME= $(SHL1TARGET)
 
 .IF "$(COMNAME)"=="msci"
 SHL1VERSIONMAP=msci.map
+.ELIF "$(COMNAME)"=="mscx"
+SHL1VERSIONMAP=mscx.map
 .ELIF "$(GUI)"=="OS2"
 SHL1VERSIONMAP=gcc3os2.map
 .ELIF "$(COMNAME)"=="sunpro5"
diff --git a/salhelper/source/mscx.map b/salhelper/source/mscx.map
new file mode 100644
index ..a9d950b11e89
--- /dev/null
+++ b/salhelper/source/mscx.map
@@ -0,0 +1,58 @@
+###
+#
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing,
+#  software distributed under the License is distributed on an
+#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+#  KIND, either express or implied.  See the License for the
+#  specific language governing permissions and limitations
+#  under the License.
+#
+###
+UDK_3_0_0 {
+global:
+GetVersionInfo
+??0ORealDynamicLoader@salhelper@@IEAA@PEAPEAV01@AEBVOUString@rtl@@1PEAX2@Z
+??1ORealDynamicLoader@salhelper@@MEAA@XZ
+??_7ORealDynamicLoader@salhelper@@6B@
+?acquire@ORealDynamicLoader@salhelper@@QEAAKXZ
+?getApi@ORealDynamicLoader@salhelper@@QEBAPEAXXZ
+?newInstance@ORealDynamicLoader@salhelper@@SAPEAV12@PEAPEAV12@AEBVOUString@rtl@@1@Z
+?release@ORealDynamicLoader@salhelper@@QEAAKXZ
+??1SimpleReferenceObject@salhelper@@MEAA@XZ
+??2SimpleReferenceObject@salhelper@@SAPEAX_K@Z
+??2SimpleReferenceObject@salhelper@@SAPEAX_KAEBUnothrow_t@std@@@Z
+??3SimpleReferenceObject@salhelper@@SAXPEAX@Z
+??3SimpleReferenceObject@salhelper@@SAXPEAXAEBUnothrow_t@std@@@Z
+local:
+*;
+};
+
+UDK_3.1 {
+global:
+??_7SimpleReferenceObject@salhelper@@6B@;
+
+??0Condition@salhelper@@QEAA@AEAVMutex@osl@@@Z;
+??1Condition@salhelper@@UEAA@XZ;
+
+??0ConditionModifier@salhelper@@QEAA@AEAVCondition@1@@Z;
+??1ConditionModifier@salhelper@@QEAA@XZ
+
+??0ConditionWaiter@salhelper@@QEAA@AEAVCondition@1@@Z;
+??0ConditionWaiter@salhelper@@QEAA@AEAVCondition@1@K@Z;
+??1ConditionWaiter@salhelper@@QEAA@XZ
+
+??0timedout@ConditionWaiter@salhelper@@QEAA@XZ;
+??0timedout@ConditionWaiter@salhelper@@QEAA@AEBU012@@Z;
+??1timedout@ConditionWaiter@salhelper@@UEAA@XZ;
+??4timedout@ConditionWaiter@salhelper@@QEAAAEAU012@AEBU012@@Z;
+} UDK_3_0_0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83946

Aron Budea  changed:

   What|Removed |Added

 Depends on||106746


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106746
[Bug 106746] copy/pasting revisions copy deleted words
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Aron Budea  changed:

   What|Removed |Added

   Priority|medium  |high
 Blocks||83946
   Severity|minor   |normal

--- Comment #13 from Aron Budea  ---
The problem is with the following piece of change:
https://cgit.freedesktop.org/libreoffice/core/diff/sw/source/core/doc/DocumentContentOperationsManager.cxx?id=db17d3c17c40d6b0e92392cf3c6e343d1d17b771

The pointer in pDelPam actually needs to be preserved here:
pDelPam.reset(new SwPaM( *pCpyStt, pDelPam.get() ));

The following change fixes the behavior by releasing the smart pointer:
pDelPam.reset(new SwPaM( *pCpyStt, pDelPam.release() ));

Is the code otherwise correct? I'm surprised working with an invalid pointer
didn't cause a serious issue.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116253] 'NULL' appears as default text in text and combo boxes when editing a newly inserted record in a form 's table control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116253

--- Comment #2 from Howard Johnson  ---
It seems to do this only when connected to MariadDB.  So far I can't get this
behavior in HSQLDB 1.8.  (It's hard to tell for 100% sure, but time will tell.)

Also if the field is formatted as currency, (US$), then it inserts a $0.00 in
the text box, rather than just leaving it blank (null) as it should do.

It seems to do this only on nullable fields (those that allow a null value).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75930] IMPORT MathML: some characters are missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75930

--- Comment #8 from Mike Kaganski  ---
Still present in Version: 6.0.2.1 (x64)
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: ru-RU (ru_RU); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116253] 'NULL' appears as default text in text and combo boxes when editing a newly inserted record in a form 's table control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116253

--- Comment #1 from Howard Johnson  ---
Created attachment 140407
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140407=edit
screenshot showing issue

v5.4 and before doesn't do this.  

It doesn't always happen.  Will add more details as I can get them.


GNU/Linux Debian 9.3

(Also, sorry, but I accidentally hit return after entering the subject line and
it submitted the nearly blank bug report w/o these details.  First time that's
probably ever happened here.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116253] New: 'NULL' appears as default text in text and combo boxes when editing a newly inserted record in a form 's table control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116253

Bug ID: 116253
   Summary: 'NULL' appears as default text in text and combo boxes
when editing a newly inserted record in a form's table
control
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bridgeportcontrac...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85779] EPS file gets badly mangled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85779

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97392] -convert-to does not work for password-protected files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97392

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96393] File Picker Not Using Previous Session State/Geometry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96393

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96372] Filters do not work on Hsqldb subquery result when subquery has alias.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96372

--- Comment #16 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/oox oox/source

[Tomaž Vajngerl]

 include/oox/drawingml/shapepropertymap.hxx |   16 
 include/oox/helper/modelobjecthelper.hxx   |5 -
 oox/source/drawingml/fillproperties.cxx|8 
 oox/source/drawingml/shapepropertymap.cxx  |   18 +-
 oox/source/helper/modelobjecthelper.cxx|   15 ---
 5 files changed, 21 insertions(+), 41 deletions(-)

New commits:
commit e092c72b44d99ea5c6c7f71cd717b20a4a86f5ac
Author: Tomaž Vajngerl 
Date:   Tue Mar 6 20:02:05 2018 +0900

oox: rename FillBitmapUrl to FillBitmap, remove obsolete methods

Change-Id: I597aaa280ef12e46cf2d060cef1b042413d838d4
Reviewed-on: https://gerrit.libreoffice.org/50851
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/oox/drawingml/shapepropertymap.hxx 
b/include/oox/drawingml/shapepropertymap.hxx
index 8ba077ea3d27..2fb237cd496f 100644
--- a/include/oox/drawingml/shapepropertymap.hxx
+++ b/include/oox/drawingml/shapepropertymap.hxx
@@ -64,7 +64,7 @@ enum class ShapeProperty
 FillTransparency,
 GradientTransparency,
 FillGradient, /// Explicit fill gradient or name of a fill 
gradient stored in a global container.
-FillBitmapUrl,/// Explicit fill bitmap URL or name of a 
fill bitmap URL stored in a global container.
+FillBitmap,   /// Explicit fill bitmap or name of a fill 
bitmap stored in a global container.
 FillBitmapMode,
 FillBitmapSizeX,
 FillBitmapSizeY,
@@ -73,7 +73,7 @@ enum class ShapeProperty
 FillBitmapRectanglePoint,
 FillHatch,
 ShadowXDistance,
-FillBitmapNameFromUrl,
+FillBitmapName,
 FillBackground,
 LAST = FillBackground
 };
@@ -86,13 +86,13 @@ struct OOX_DLLPUBLIC ShapePropertyInfo
 bool mbNamedLineMarker;  /// True = use named line marker instead of 
explicit line marker.
 bool mbNamedLineDash;/// True = use named line dash instead of 
explicit line dash.
 bool mbNamedFillGradient;/// True = use named fill gradient instead of 
explicit fill gradient.
-bool mbNamedFillBitmapUrl;   /// True = use named fill bitmap URL instead 
of explicit fill bitmap URL.
+bool mbNamedFillBitmap;  /// True = use named fill bitmap instead of 
explicit fill bitmap.
 
 static ShapePropertyInfo DEFAULT;   /// Default property info 
(used as default parameter of other methods).
 
 explicit ShapePropertyInfo(const ShapePropertyIds& rnPropertyIds,
bool bNamedLineMarker, bool bNamedLineDash,
-   bool bNamedFillGradient, bool 
bNamedFillBitmapUrl);
+   bool bNamedFillGradient, bool bNamedFillBitmap);
 
 bool has(ShapeProperty ePropId) const
 {
@@ -143,10 +143,10 @@ private:
 bool setFillGradient( sal_Int32 nPropId, const css::uno::Any& rValue );
 /** Creates a named transparency gradient. */
 bool setGradientTrans( sal_Int32 nPropId, const css::uno::Any& rValue );
-/** Sets an explicit fill bitmap URL, or creates a named fill bitmap URL. 
*/
-bool setFillBitmapUrl( sal_Int32 nPropId, const css::uno::Any& rValue );
-/** Sets an explicit fill bitmap URL and pushes the name to FillBitmapName 
*/
-bool setFillBitmapNameFromUrl( const css::uno::Any& rValue );
+/** Sets an explicit fill bitmap, or creates a named fill bitmap. */
+bool setFillBitmap( sal_Int32 nPropId, const css::uno::Any& rValue );
+/** Sets an explicit fill bitmap and pushes the name to FillBitmapName */
+bool setFillBitmapName( const css::uno::Any& rValue );
 
 // not implemented, to prevent implicit conversion from enum to int
 css::uno::Any& operator[]( ShapeProperty ePropId ) = delete;
diff --git a/include/oox/helper/modelobjecthelper.hxx 
b/include/oox/helper/modelobjecthelper.hxx
index 694bdf13ddb7..eb9c7ba97228 100644
--- a/include/oox/helper/modelobjecthelper.hxx
+++ b/include/oox/helper/modelobjecthelper.hxx
@@ -105,15 +105,10 @@ public:
 
 OUString insertTransGrandient( const css::awt::Gradient& rGradient );
 
-/** Inserts a new named fill bitmap URL, returns the bitmap name, based on
-an internal constant name with a new unused index appended. */
-OUString insertFillBitmapUrl( const OUString& rGraphicUrl );
-
 /** Inserts a new named fill graphic, returns the bitmap name, based on
 an internal constant name with a new unused index appended. */
 OUString 
insertFillBitmapXGraphic(css::uno::Reference const & 
rxGraphic);
 
-OUString getFillBitmapUrl( const OUString& rGraphicName );
 css::uno::Reference getFillBitmap(OUString const & 
rGraphicName);
 
 private:
diff --git a/oox/source/drawingml/fillproperties.cxx 
b/oox/source/drawingml/fillproperties.cxx
index c22654ebeb6f..9ba7e46ac215 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ 

[Libreoffice-bugs] [Bug 87778] Locale not respected in Online Update Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87778

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75354] EDITING: Base TABLE Editor not updating table FIELDS properly when both FIELD NAME and FILED TYPE are changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75354

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88025] XY (scatter) first column of Y data lost on editions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88025

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103586] Assigning shortcuts to macro in context LibreOffice ( not a module) does not work anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103586

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97007] ODF does not allow presentation: master-element as attribute of anim:set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97007

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106360] Writer table embedded in presentation rendered incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106360

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87737] EDITING: Date-parameter in queries don't work in UI-language, if parameter is only in subquery

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87737

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97983] cInt function treats , as decimal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97983

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74231] Writer: (interactive?) frame not selected with Select All and not deleted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74231

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83090] UI: Entered font sizes (e.g., 12.4 pt, 12.7 pt) are being rounded off (rather than up) in the toolbar / sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83090

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54946] Custom variable cannot be applied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54946

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60953] REPORTBUILDER: missing header and footer on first page when section "Detail" is set to Page-Break after Section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=60953

--- Comment #20 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70339] Word boundary definition problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70339

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75930] IMPORT MathML: some characters are missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75930

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106329] Text reformats slightly when selected in Impress UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106329

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97482] Presentation-mode: Pen - drawing in presenter's view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97482

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97143] Only current frame showing which selecting multiple columns/ rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97143

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95949] Changing Display Mode using View menu does not update Display Mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95949

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93446] [l10n, Russian] Discrete distributions do not have probability density

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93446

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59257] UI: built-in elements (icons, labels) of a navigation bar control (for a data table) do not resize when zooming

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59257

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41842] FORMATTING: Transfering format with brush affects wrong cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41842

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75853] EDITING: Wrong timestamp in a table with date and time ( except 00:00:00) before 1899-12-30

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75853

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74514] FORMATTING; DATA SERIES; explicit data series not imported from excel.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74514

--- Comment #21 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82411] Numeric fields are limited to Integer-Values in Tablecontrols and Databrowser of a Form

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82411

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95919] LibreOffice File open dialog does not save column settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95919

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 shell/Executable_senddoc.mk shell/Library_smplmail.mk shell/source

[Mike Kaganski]

 include/sfx2/strings.hrc |3 
 shell/Executable_senddoc.mk  |4 
 shell/Library_smplmail.mk|3 
 shell/source/win32/simplemail/senddoc.cxx|  170 +--
 shell/source/win32/simplemail/smplmailclient.cxx |  120 +++-
 shell/source/win32/simplemail/smplmailclient.hxx |7 
 6 files changed, 287 insertions(+), 20 deletions(-)

New commits:
commit 2f061dad7f875f704e3744fc5780c1d145b22e9f
Author: Mike Kaganski 
Date:   Tue Feb 27 23:40:15 2018 +0300

tdf#116074: Don't block on sending email interactively

When sending e-mail using a MAPI mail client that doesn't recognize
MAPI_DIALOG_MODELESS flag, and doesn't return from MAPISendMail until
message compose dialog is closed (like MS Outlook 2010 and older),
waiting for the senddoc process blocks UI, which is unexpected and
prevents users from copying stuff from documents to the mail body.

Waiting for senddoc process completion is used for two things:
1. To serialize sending multiple mails (e.g., using mailmerge);
2. To show error in case when it failed.

This patch allows to avoid blocking the UI in case when compose UI is
requested - i.e., user interaction with the mail client is expected,
and serialization is not required. In this case, the senddoc process
will show the error message itself -> no need for main application to
wait for its return. The error message now includes actual error code.

To avoid cases when closing main program would remove temporary
attachment files before they were used by mail client, they are
copied to base temporary directory (instead of default session
temporary directory that gets deleted upon program shutdown).
senddoc cleans up its temporaries itself.

The temporary attachment files are copied to files with ASCII-only
filenames, and their original filenames are passed to mail clients
using MAPI. This allows to avoid cases when the filenames contain
characters outside of current Windows codepage, and the mail client
does not support Unicode MAPI, thus receiving wrong filename and
erroring out from the send.

Change-Id: I4a517bd7a797e76e4c0b7ea48bb1a7b652741a81
Reviewed-on: https://gerrit.libreoffice.org/50826
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/include/sfx2/strings.hrc b/include/sfx2/strings.hrc
index 4e8346b209a5..e5532815f63e 100644
--- a/include/sfx2/strings.hrc
+++ b/include/sfx2/strings.hrc
@@ -234,6 +234,9 @@
 #define STR_PRINT_NEWORISIZENC_("STR_PRINT_NEWORISIZE", 
"The page size and orientation have been modified.\nWould you like to save the 
new settings in the\nactive document?")
 #define STR_CANT_CLOSE  NC_("STR_CANT_CLOSE", "The 
document cannot be closed because a\n print job is being carried out.")
 #define STR_ERROR_SEND_MAIL NC_("STR_ERROR_SEND_MAIL", "An 
error occurred in sending the message. Possible errors could be a missing user 
account or a defective setup.\nPlease check the %PRODUCTNAME settings or your 
e-mail program settings.")
+// Error codes look like "MAPI_E_FAILURE" or "1234"
+#define STR_ERROR_SEND_MAIL_CODE
NC_("STR_ERROR_SEND_MAIL_CODE", "An error occurred in sending the message. 
Possible errors could be a missing user account or a defective setup.\n\nError 
code is $1")
+#define STR_ERROR_SEND_MAIL_HEADER  
NC_("STR_ERROR_SEND_MAIL_HEADER", "Error sending mail")
 #define STR_QUERY_OPENASTEMPLATE
NC_("STR_QUERY_OPENASTEMPLATE", "This document cannot be edited, possibly due 
to missing access rights. Do you want to edit a copy of the document?")
 #define STR_QUERY_OPENASTEMPLATE_ALLOW_IGNORE   
NC_("STR_QUERY_OPENASTEMPLATE_ALLOW_IGNORE", "This document cannot be edited, 
because it is locked in another session. Do you want to edit a copy of the 
document?\n\nYou can also try to ignore the lock and open the file for 
editing.")
 #define STR_QUERY_OPENASTEMPLATE_OPENCOPY_BTN   
NC_("STR_QUERY_OPENASTEMPLATE_OPENCOPY_BTN", "Open ~Copy")
diff --git a/shell/Executable_senddoc.mk b/shell/Executable_senddoc.mk
index f51c8441aada..4b8c5e3d18bb 100644
--- a/shell/Executable_senddoc.mk
+++ b/shell/Executable_senddoc.mk
@@ -13,8 +13,12 @@ $(eval $(call gb_Executable_use_system_win32_libs,senddoc,\
kernel32 \
 ))
 
+$(eval $(call gb_Executable_use_sdk_api,senddoc))
+
 $(eval $(call gb_Executable_use_libraries,senddoc,\
+   i18nlangtag \
sal \
+   utl \
 ))
 
 $(eval $(call gb_Executable_add_exception_objects,senddoc,\
diff --git a/shell/Library_smplmail.mk b/shell/Library_smplmail.mk
index d68f0a65e8ec..fa8c222943ed 100644
--- a/shell/Library_smplmail.mk
+++ b/shell/Library_smplmail.mk
@@ -18,7 +18,10 @@ $(eval $(call 

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - icu/createmakWin64.cfg icu/makefile.mk

[Damjan Jovanovic]

 icu/createmakWin64.cfg |  452 +
 icu/makefile.mk|4 
 2 files changed, 456 insertions(+)

New commits:
commit ef2aacc05233f278a9f25c93f3ad4674aa1431da
Author: Damjan Jovanovic 
Date:   Wed Mar 7 02:27:01 2018 +

Get main/icu building on Win64.

Patch by: me

diff --git a/icu/createmakWin64.cfg b/icu/createmakWin64.cfg
new file mode 100644
index ..3c98ec3c1af3
--- /dev/null
+++ b/icu/createmakWin64.cfg
@@ -0,0 +1,452 @@
+[Copy]
+SOURCE=
+InputPath=
+"" : $(SOURCE) "$(INTDIR)" "$(OUTDIR)"
+
+
+[Deps]
+SOURCE=.\.
+"$(INTDIR)\.obj": $(SOURCE) "$(INTDIR)" 
+
+[Cpp]
+CPP=cl.exe
+[Link]
+LINK32=link.exe
+[CDefs_Common]
+
+[RSC_Template]
+RSC=rc.exe
+RSC_PROJ=/l 0x409 /fo"$(INTDIR)\.res" /i "..\common" /d "NDEBUG"
+SOURCE=
+"$(INTDIR)\.res" : $(SOURCE) "$(INTDIR)"
+   $(RSC) $(RSC_PROJ) $(SOURCE)
+
+[General_CFlags]
+CPP_PROJ_INCLUDES=
+CDEFS=
+COPT=-nologo -O2 -Ob2
+CPDBOBJ=-FD -Fo"$(INTDIR)\\" -Fd"$(INTDIR)\\"
+CTOOLSFLAGS=-nologo -W3 $(EXCEPTIONSWITCH) $(CPP_PROJ_INCLUDES) $(CDEFS) 
$(CPDBOBJ) -c
+CDEF1FLAGS= -D "_WINDOWS" -D "_MBCS"
+
+[CFlags_common]
+CPP_PROJ=-nologo -MD -Za -Zi -W3 -GF -O2 -Ob2 $(EXCEPTIONSWITCH) 
$(CPP_PROJ_INCLUDES) $(CDEFS) $(CPDBOBJ) -c
+
+[CFlags_i18n]
+CPP_PROJ=-MD -W3 -Oi -Op -GF -FD -GS -Gy -Za -Zi $(EXCEPTIONSWITCH) $(COPT) 
$(CPP_PROJ_INCLUDES) $(CDEFS) -Fp".\Release/i18n.pch" $(CPDBOBJ) -c
+
+[CFlags_extra_uconv]
+CPP_PROJ=-MD -W3 -Op -GF -Gy $(EXCEPTIONSWITCH) $(COPT) $(CPP_PROJ_INCLUDES) 
$(CDEFS) -Fp".\Release/uconv.pch" $(CPDBOBJ) -c
+
+[CFlags_layout]
+CPP_PROJ=-Za -GF -Gy -W3 $(EXCEPTIONSWITCH) -O2 $(CPP_PROJ_INCLUDES) $(CDEFS) 
-D "LAYOUT_EXPORTS" -D "_WINDOWS" -D "_MBCS" -D "_USRDLL" $(CPDBOBJ) -c
+
+[CFlags_io]
+CPP_PROJ=-Za -GF -Gy -W3 $(EXCEPTIONSWITCH) -O2 $(CPP_PROJ_INCLUDES) $(CDEFS) 
-D "LAYOUT_EXPORTS" -D "_WINDOWS" -D "_MBCS" -D "_USRDLL" $(CPDBOBJ) -c
+
+[CFlags_layoutex]
+CPP_PROJ=-MT -W3 -Op -GF -Gy $(EXCEPTIONSWITCH) $(COPT) $(CPP_PROJ_INCLUDES) 
$(CDEFS) -Fp".\Release/layoutex.pch" $(CPDBOBJ) -c
+
+[CFlags_stubdata]
+CPP_PROJ=-MD -W3 -Op -GF -Gy -Za $(EXCEPTIONSWITCH) $(COPT) 
$(CPP_PROJ_INCLUDES) $(CDEFS) -Fp".\Release/stubdata.pch" $(CPDBOBJ) -c
+
+[CFlags_test_cintltst]
+CPP_PROJ=-MT -Za -O2 -W3 $(EXCEPTIONSWITCH) $(CPP_PROJ_INCLUDES) $(CDEFS) 
$(CPDBOBJ) -c
+
+[CFlags_test_intltest]
+CPP_PROJ=-nologo -MT -Za -Zi -Ox -Ob0 -W3 $(EXCEPTIONSWITCH) 
$(CPP_PROJ_INCLUDES) $(CDEFS) $(CPDBOBJ) -c
+
+[CFlags_test_iotest]
+CPP_PROJ=-nologo -MD -Za -Zi -Ox -Ob0 -W3 $(EXCEPTIONSWITCH) 
$(CPP_PROJ_INCLUDES) $(CDEFS) $(CPDBOBJ) -c
+
+[CFlags_test_letest]
+CPP_PROJ=-nologo -MD -Za -Zi -Ox -Ob0 -W3 $(EXCEPTIONSWITCH) 
$(CPP_PROJ_INCLUDES) $(CDEFS) $(CPDBOBJ) -c
+
+[CFlags_tools_ctestfw]
+CPP_PROJ=-nologo -MD -O2 -Op -FD -Za -W3 $(EXCEPTIONSWITCH) 
$(CPP_PROJ_INCLUDES) $(CDEFS) -Fp".\Release/icutest.pch" $(CPDBOBJ) -c
+
+[CFlags_tools_genbrk]
+CPP_PROJ=-nologo -MD -Za -O2 -W3 $(EXCEPTIONSWITCH) $(CPP_PROJ_INCLUDES) 
$(CDEFS) $(CPDBOBJ) -c
+
+[CFlags_tools_gencase]
+CPP_PROJ=-nologo -MD -GF -Za -Zi -W3 $(EXCEPTIONSWITCH) $(COPT) $(CPDBOBJ) -c
+
+[CFlags_tools_genccode]
+CPP_PROJ=-MD -O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_gencmn]
+CPP_PROJ=-O2 -Za $(CTOOLSFLAGS)
+
+[CFlags_tools_genctd]
+CPP_PROJ=-MD -O2 -Za $(CTOOLSFLAGS)
+
+[CFlags_tools_gencnval]
+CPP_PROJ=-MD -O2 -Za $(CTOOLSFLAGS)
+
+[CFlags_tools_gennames]
+CPP_PROJ=-MD -O2 -Za $(CTOOLSFLAGS)
+
+[CFlags_tools_gennorm]
+CPP_PROJ=-MD -O2 -Za $(CTOOLSFLAGS)
+
+[CFlags_tools_genpname]
+CPP_PROJ=-MD -O2 -Za $(CTOOLSFLAGS)
+
+[CFlags_tools_genprops]
+CPP_PROJ=-MD -O2 -Za $(CTOOLSFLAGS)
+
+[CFlags_tools_genrb]
+CPP_PROJ=-Za $(CTOOLSFLAGS)
+
+[CFlags_tools_genrb.derb]
+CPP_PROJ=-Za -GX $(CTOOLSFLAGS)
+
+[CFlags_tools_gensprep]
+CPP_PROJ=-Za $(CTOOLSFLAGS)
+
+[CFlags_tools_gentest]
+CPP_PROJ=-Za -O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_genuca]
+CPP_PROJ=-Za -O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_gencase]
+CPP_PROJ=-Za -O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_genbidi]
+CPP_PROJ=-Za -O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_icupkg]
+CPP_PROJ=-O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_icuswap]
+CPP_PROJ=-O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_makeconv]
+CPP_PROJ=-Za $(CTOOLSFLAGS)
+
+[CFlags_tools_pkgdata]
+CPP_PROJ=-Za -O2 $(CTOOLSFLAGS)
+
+[CFlags_tools_toolutil]
+CPP_PROJ=-MD -O2 $(CTOOLSFLAGS)
+
+[CommonLinkFlags]
+PDBOUT=/pdb:"" /out:""
+COMMONLINKFLAGS=/incremental:no /machine:X64 /nologo $(PDBOUT) /NXCOMPAT 
/DYNAMICBASE
+COMMONLINKFLAGS_CONSOLE=$(COMMONLINKFLAGS) /subsystem:console
+COMMONLINKFLAGS_DLL=$(COMMONLINKFLAGS) /dll
+
+[LinkFlags_common]
+LINK32_FLAGS=icudata.lib kernel32.lib user32.lib advapi32.lib shell32.lib 
$(COMMONLINKFLAGS_DLL) /base:"0x4a80" /implib:"$(OUTDIR)\icuuc.lib" 
/libpath:"..\..\lib"
+
+[LinkFlags_i18n]
+LINK32_FLAGS=icuuc.lib  $(COMMONLINKFLAGS_DLL) /base:"0x4a90" 
/implib:"$(OUTDIR)\icuin.lib" /libpath:"..\..\lib"
+
+[LinkFlags_extra_uconv]
+LINK32_FLAGS=icuuc.lib icuin.lib uconvmsg.lib 

[Libreoffice-bugs] [Bug 116199] Writer: Text with Track Changes copied differently with changes shown than if changes not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116199

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116199] Writer: Text with Track Changes copied differently with changes shown than if changes not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116199

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |DUPLICATE

--- Comment #1 from Aron Budea  ---
Confirmed, and is a duplicate of bug 106746.

*** This bug has been marked as a duplicate of bug 106746 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Aron Budea  changed:

   What|Removed |Added

 CC||gti...@gmail.com

--- Comment #12 from Aron Budea  ---
*** Bug 116199 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx svx/source

[Tomaž Vajngerl]

 include/svx/xmlgrhlp.hxx|2 +-
 svx/source/xml/xmlgrhlp.cxx |7 +--
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit bec51fdb04bf25b9d670982dccab728c55c83fdf
Author: Tomaž Vajngerl 
Date:   Tue Mar 6 18:47:46 2018 +0900

cache location and mime type when saving a graphic to a storage

Change-Id: If27a5f617a103da235d6690ea0447d6c64538dea
Reviewed-on: https://gerrit.libreoffice.org/50810
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/svx/xmlgrhlp.hxx b/include/svx/xmlgrhlp.hxx
index 94cc40d17179..578b9a5f98fb 100644
--- a/include/svx/xmlgrhlp.hxx
+++ b/include/svx/xmlgrhlp.hxx
@@ -63,7 +63,7 @@ private:
 ::std::set< OUString >  maURLSet;
 
 std::unordered_map 
maGraphicObjects;
-std::unordered_map maExportGraphics;
+std::unordered_map> 
maExportGraphics;
 
 SvXMLGraphicHelperMode  meCreateMode;
 OUStringmaOutputMimeType;
diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index f8f690747959..62aa1bb6dd1b 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -49,6 +49,7 @@
 
 #include 
 #include 
+#include 
 
 using namespace com::sun::star;
 using namespace com::sun::star::uno;
@@ -1070,7 +1071,9 @@ OUString 
SvXMLGraphicHelper::implSaveGraphic(css::uno::Referencesecond;
+auto const & aURLAndMimePair = aIterator->second;
+rOutSavedMimeType = aURLAndMimePair.second;
+return aURLAndMimePair.first;
 }
 
 GraphicObject aGraphicObject(aGraphic);
@@ -1275,7 +1278,7 @@ OUString 
SvXMLGraphicHelper::implSaveGraphic(css::uno::Referencehttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - oox/source sc/source

[Tomaž Vajngerl]

 oox/source/drawingml/shapepropertymap.cxx |2 -
 oox/source/export/drawingml.cxx   |   34 ++
 oox/source/export/shapes.cxx  |   31 ---
 oox/source/token/properties.txt   |3 --
 sc/source/filter/inc/pagesettings.hxx |2 -
 sc/source/filter/oox/pagesettings.cxx |   14 +++-
 6 files changed, 31 insertions(+), 55 deletions(-)

New commits:
commit e030fbbf67a2490c4e734583d9f987c27506179e
Author: Tomaž Vajngerl 
Date:   Tue Mar 6 18:29:40 2018 +0900

oox: remove property FillBitmapURL, BackGraphicURL and GraphicURL

Change-Id: I1f75b1775fec4b47ad78a32724785333a90d3baf
Reviewed-on: https://gerrit.libreoffice.org/50809
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/oox/source/drawingml/shapepropertymap.cxx 
b/oox/source/drawingml/shapepropertymap.cxx
index c0704381b19c..6d487f51c2ed 100644
--- a/oox/source/drawingml/shapepropertymap.cxx
+++ b/oox/source/drawingml/shapepropertymap.cxx
@@ -43,7 +43,7 @@ static const ShapePropertyIds spnDefaultShapeIds =
 PROP_LineStyle, PROP_LineWidth, PROP_LineColor, PROP_LineTransparence, 
PROP_LineDash, PROP_LineJoint,
 PROP_LineStartName, PROP_LineStartWidth, PROP_LineStartCenter, 
PROP_LineEndName, PROP_LineEndWidth, PROP_LineEndCenter,
 PROP_FillStyle, PROP_FillColor, PROP_FillTransparence, 
PROP_FillTransparenceGradientName, PROP_FillGradient,
-PROP_FillBitmapURL, PROP_FillBitmapMode, PROP_FillBitmapSizeX, 
PROP_FillBitmapSizeY,
+PROP_FillBitmap, PROP_FillBitmapMode, PROP_FillBitmapSizeX, 
PROP_FillBitmapSizeY,
 PROP_FillBitmapPositionOffsetX, PROP_FillBitmapPositionOffsetY, 
PROP_FillBitmapRectanglePoint,
 PROP_FillHatch,
 PROP_ShadowXDistance,
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index d3ccf3d81223..ca7c303acd6e 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1220,39 +1220,25 @@ void DrawingML::WriteBlipFill( const Reference< 
XPropertySet >& rXPropSet, const
 {
 if ( GetProperty( rXPropSet, sURLPropName ) )
 {
+uno::Reference xGraphic;
 if (mAny.has())
 {
 uno::Reference xBitmap;
 xBitmap = mAny.get();
-uno::Reference xGraphic(xBitmap, 
uno::UNO_QUERY);
-if (xBitmap.is() && xGraphic.is())
-{
-bool bWriteMode = false;
-if (sURLPropName == "FillBitmap" || sURLPropName == 
"BackGraphic")
-bWriteMode = true;
-WriteXGraphicBlipFill(rXPropSet, xGraphic, nXmlNamespace, 
bWriteMode);
-}
+if (xBitmap.is())
+xGraphic.set(xBitmap, uno::UNO_QUERY);
 }
 else if (mAny.has())
 {
-uno::Reference xGraphic;
 xGraphic = mAny.get();
-if (xGraphic.is())
-{
-bool bWriteMode = false;
-if (sURLPropName == "FillBitmap" || sURLPropName == 
"BackGraphic")
-bWriteMode = true;
-WriteXGraphicBlipFill(rXPropSet, xGraphic, nXmlNamespace, 
bWriteMode);
-}
 }
-else
+
+if (xGraphic.is())
 {
-OUString aURL;
-mAny >>= aURL;
 bool bWriteMode = false;
-if( sURLPropName == "FillBitmapURL" || sURLPropName == 
"BackGraphicURL")
+if (sURLPropName == "FillBitmap" || sURLPropName == "BackGraphic")
 bWriteMode = true;
-WriteBlipFill( rXPropSet, aURL, nXmlNamespace, bWriteMode );
+WriteXGraphicBlipFill(rXPropSet, xGraphic, nXmlNamespace, 
bWriteMode);
 }
 }
 }
diff --git a/oox/source/token/properties.txt b/oox/source/token/properties.txt
index 6754ee58558c..86dd843d12b7 100644
--- a/oox/source/token/properties.txt
+++ b/oox/source/token/properties.txt
@@ -22,7 +22,6 @@ BackColor
 BackColorTransparency
 BackGraphicLocation
 BackGraphic
-BackGraphicURL
 Background
 BackgroundColor
 BasicLibraries
@@ -167,7 +166,6 @@ FillBitmapPositionOffsetY
 FillBitmapRectanglePoint
 FillBitmapSizeX
 FillBitmapSizeY
-FillBitmapURL
 FillBitmap
 FillColor
 FillGradient
@@ -209,7 +207,6 @@ GraphicBitmap
 GraphicColorMode
 GraphicCrop
 GraphicSize
-GraphicURL
 GridColor
 GroupInfo
 GroupName
diff --git a/sc/source/filter/inc/pagesettings.hxx 
b/sc/source/filter/inc/pagesettings.hxx
index 03a0c8d32e36..2868d8eac4ad 100644
--- a/sc/source/filter/inc/pagesettings.hxx
+++ b/sc/source/filter/inc/pagesettings.hxx
@@ -34,7 +34,7 @@ class HeaderFooterParser;
 /** Holds page style data for a single sheet. */
 struct PageSettingsModel
 {
-OUString maGraphicUrl;   /// URL of the graphic object.
+css::uno::Reference mxGraphic; /// Background 
Graphic
 

[Libreoffice-commits] core.git: xmloff/source

[Tomaž Vajngerl]

 xmloff/source/draw/shapeexport.cxx |   98 +++--
 1 file changed, 42 insertions(+), 56 deletions(-)

New commits:
commit f7d3fc1774f3ada2af1c752bc8a63055a2ff
Author: Tomaž Vajngerl 
Date:   Tue Mar 6 13:54:45 2018 +0900

xmloff: remove "GraphicURL" from XMLShapeExport

Change-Id: If1967a7d87a934e2eea776bcd41b305e800f711a
Reviewed-on: https://gerrit.libreoffice.org/50790
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index 89a92f14229c..e028f56e846e 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -2356,56 +2356,38 @@ void XMLShapeExport::ImpExportGraphicObjectShape(
 
 const bool bSaveBackwardsCompatible = bool( mrExport.getExportFlags() & 
SvXMLExportFlags::SAVEBACKWARDCOMPATIBLE );
 
-OUString sImageURL;
-uno::Reference xGraphic;
-
-if( !bIsEmptyPresObj || bSaveBackwardsCompatible )
+if (!bIsEmptyPresObj || bSaveBackwardsCompatible)
 {
-if( !bIsEmptyPresObj )
+uno::Reference xGraphic;
+OUString sOutMimeType;
+
+if (!bIsEmptyPresObj)
 {
 OUString aStreamURL;
 xPropSet->getPropertyValue("GraphicStreamURL") >>= aStreamURL;
-
 OUString sRequestedName = getNameFromStreamURL(aStreamURL);
 
-xPropSet->getPropertyValue("GraphicURL") >>= sImageURL;
-
-uno::Any aGraphicAny = xPropSet->getPropertyValue("Graphic");
-if (aGraphicAny.has())
-xGraphic = 
aGraphicAny.get();
+xPropSet->getPropertyValue("Graphic") >>= xGraphic;
 
-OUString aStoredURL;
+OUString sInternalURL;
 
 if (xGraphic.is())
-{
-aStoredURL = mrExport.AddEmbeddedXGraphic(xGraphic, 
sRequestedName);
-}
-else
-{
-OUString aResolveURL(sImageURL);
-if (!sRequestedName.isEmpty())
-aResolveURL += "?requestedName=" + sRequestedName;
-
-aStoredURL = mrExport.AddEmbeddedGraphicObject(aResolveURL);
-}
-
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_HREF, aStoredURL);
+sInternalURL = mrExport.AddEmbeddedXGraphic(xGraphic, 
sOutMimeType, sRequestedName);
 
-if (!aStoredURL.isEmpty())
+if (!sInternalURL.isEmpty())
 {
-const OUString sPackageURL("vnd.sun.star.Package:");
-
 // apply possible changed stream URL to embedded image object
 if (!sRequestedName.isEmpty())
 {
+const OUString sPackageURL("vnd.sun.star.Package:");
 OUString newStreamURL = sPackageURL;
-if (aStoredURL[0] == '#')
+if (sInternalURL[0] == '#')
 {
-newStreamURL += aStoredURL.copy(1, 
aStoredURL.getLength() - 1);
+newStreamURL += sInternalURL.copy(1, 
sInternalURL.getLength() - 1);
 }
 else
 {
-newStreamURL += aStoredURL;
+newStreamURL += sInternalURL;
 }
 
 if (newStreamURL != aStreamURL)
@@ -2414,40 +2396,44 @@ void XMLShapeExport::ImpExportGraphicObjectShape(
 }
 }
 
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_TYPE, 
XML_SIMPLE );
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_SHOW, XML_EMBED 
);
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_ACTUATE, 
XML_ONLOAD );
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_HREF, 
sInternalURL);
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_TYPE, 
XML_SIMPLE);
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_SHOW, 
XML_EMBED);
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_ACTUATE, 
XML_ONLOAD);
 }
 }
 else
 {
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_HREF, OUString() );
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_TYPE, XML_SIMPLE );
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_SHOW, XML_EMBED );
-mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_ACTUATE, XML_ONLOAD 
);
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_HREF, OUString());
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_TYPE, XML_SIMPLE);
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_SHOW, XML_EMBED);
+mrExport.AddAttribute(XML_NAMESPACE_XLINK, XML_ACTUATE, 
XML_ONLOAD);
 }
 
 {
-// We can't guess the mimetype from 

[Libreoffice-commits] core.git: sw/CppunitTest_sw_odfimport.mk sw/qa xmloff/inc xmloff/source

[Tomaž Vajngerl]

 sw/CppunitTest_sw_odfimport.mk |1 
 sw/qa/extras/globalfilter/globalfilter.cxx |6 -
 xmloff/inc/xmlmultiimagehelper.hxx |4 
 xmloff/source/core/xmlmultiimagehelper.cxx |   39 ++--
 xmloff/source/draw/ximpshap.cxx|   10 --
 xmloff/source/draw/ximpshap.hxx|5 -
 xmloff/source/text/XMLTextFrameContext.cxx |   44 +++---
 xmloff/source/text/XMLTextFrameContext.hxx |5 -
 xmloff/source/text/txtparae.cxx|  126 -
 9 files changed, 127 insertions(+), 113 deletions(-)

New commits:
commit 27008aa028cde8d270e898c5743a9fe5c7701dab
Author: Tomaž Vajngerl 
Date:   Mon Mar 5 20:44:08 2018 +0900

xmloff: convert XMLTextParagraphExport to get rid of "GraphicURL"

Change-Id: I10cc1115bfe628dc296b67b75e386e1a2e4a6c46
Reviewed-on: https://gerrit.libreoffice.org/50789
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/sw/CppunitTest_sw_odfimport.mk b/sw/CppunitTest_sw_odfimport.mk
index 302f24a86897..be599de21a48 100644
--- a/sw/CppunitTest_sw_odfimport.mk
+++ b/sw/CppunitTest_sw_odfimport.mk
@@ -83,6 +83,7 @@ $(eval $(call gb_CppunitTest_use_components,sw_odfimport,\
 ) \
$(if $(filter DESKTOP,$(BUILD_TYPE)),xmlhelp/util/ucpchelp1) \
 xmloff/util/xo \
+svgio/svgio \
 ))
 
 $(eval $(call gb_CppunitTest_use_configuration,sw_odfimport))
diff --git a/sw/qa/extras/globalfilter/globalfilter.cxx 
b/sw/qa/extras/globalfilter/globalfilter.cxx
index 7bd0c1bb2633..7c3082aec701 100644
--- a/sw/qa/extras/globalfilter/globalfilter.cxx
+++ b/sw/qa/extras/globalfilter/globalfilter.cxx
@@ -189,11 +189,7 @@ void Test::testLinkedGraphicRT()
 {
 SwGrfNode* pGrfNode = aNodes[nIndex]->GetGrfNode();
 CPPUNIT_ASSERT(pGrfNode);
-// RT via DOCX makes linked graphic embedded?!
-if( aFilterNames[nFilter] != "Office Open XML Text" )
-{
-CPPUNIT_ASSERT_MESSAGE( sFailedMessage.getStr(), 
pGrfNode->IsGrfLink());
-}
+
 const GraphicObject& rGraphicObj = pGrfNode->GetGrfObj(true);
 CPPUNIT_ASSERT_MESSAGE( sFailedMessage.getStr(), 
!rGraphicObj.IsSwappedOut());
 CPPUNIT_ASSERT_EQUAL_MESSAGE( sFailedMessage.getStr(), 
int(GraphicType::Bitmap), int(rGraphicObj.GetType()));
diff --git a/xmloff/inc/xmlmultiimagehelper.hxx 
b/xmloff/inc/xmlmultiimagehelper.hxx
index 2b29835c2f26..90a279c083d2 100644
--- a/xmloff/inc/xmlmultiimagehelper.hxx
+++ b/xmloff/inc/xmlmultiimagehelper.hxx
@@ -32,9 +32,9 @@ private:
 
 protected:
 /// helper to get the created xShape instance, override this
-virtual OUString getGraphicURLFromImportContext(const SvXMLImportContext& 
rContext) const = 0;
 virtual void removeGraphicFromImportContext(const SvXMLImportContext& 
rContext) = 0;
-virtual css::uno::Reference 
getGraphicFromImportContext(const SvXMLImportContext& rContext) const;
+virtual OUString getGraphicPackageURLFromImportContext(const 
SvXMLImportContext& rContext) const = 0;
+virtual css::uno::Reference 
getGraphicFromImportContext(const SvXMLImportContext& rContext) const = 0;
 
 public:
 MultiImageImportHelper();
diff --git a/xmloff/source/core/xmlmultiimagehelper.cxx 
b/xmloff/source/core/xmlmultiimagehelper.cxx
index 83cee5bbae2a..6acf7b30ed28 100644
--- a/xmloff/source/core/xmlmultiimagehelper.cxx
+++ b/xmloff/source/core/xmlmultiimagehelper.cxx
@@ -29,19 +29,10 @@ namespace
 OUString getMimeTypeForURL(const OUString& rString)
 {
 OUString sMimeType;
-if (rString.startsWith("vnd.sun.star.GraphicObject"))
+if (rString.startsWith("vnd.sun.star.Package"))
 {
-sMimeType = 
comphelper::GraphicMimeTypeHelper::GetMimeTypeForImageUrl(rString);
-}
-else if (rString.startsWith("vnd.sun.star.Package"))
-{
-sMimeType
-= 
comphelper::GraphicMimeTypeHelper::GetMimeTypeForExtension(OUStringToOString(
-rString.copy(rString.lastIndexOf(".") + 1), 
RTL_TEXTENCODING_ASCII_US));
-}
-else
-{
-SAL_WARN("xmloff", "Unknown image source: " << rString);
+OString aExtension = 
OUStringToOString(rString.copy(rString.lastIndexOf(".") + 1), 
RTL_TEXTENCODING_ASCII_US);
+sMimeType = 
comphelper::GraphicMimeTypeHelper::GetMimeTypeForExtension(aExtension);
 }
 return sMimeType;
 }
@@ -116,23 +107,22 @@ SvXMLImportContextRef 
MultiImageImportHelper::solveMultipleImages()
 {
 const SvXMLImportContext& rContext = *maImplContextVector[a].get();
 
-sal_uInt32 nNewQuality = 0;
 
-uno::Reference 
xGraphic(getGraphicFromImportContext(rContext));
-if (xGraphic.is())
+OUString sMimeType;
+
+const 

[Libreoffice-commits] core.git: chart2/source xmloff/source

[Tomaž Vajngerl]

 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx  |2 
 chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx |   76 
+++---
 xmloff/source/chart/PropertyMap.hxx  |4 
 xmloff/source/chart/PropertyMaps.cxx |   21 +-
 xmloff/source/chart/XMLSymbolImageContext.cxx|   18 +-
 5 files changed, 51 insertions(+), 70 deletions(-)

New commits:
commit 5a4d6162f643050faf00ccf08d58feed00dcd781
Author: Tomaž Vajngerl 
Date:   Mon Mar 5 17:12:01 2018 +0900

convert SymbolBitmapURL to SymbolBitmap used in chart2

Change-Id: Ib35ee5b5890ff5ca30796fc8608f00ff4b6b03e2
Reviewed-on: https://gerrit.libreoffice.org/50788
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git 
a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
index 36619d12417c..dec06433ac9a 100644
--- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
@@ -590,7 +590,7 @@ beans::PropertyState SAL_CALL 
DataSeriesPointWrapper::getPropertyState( const OU
 beans::PropertyState aState( beans::PropertyState_DIRECT_VALUE );
 try
 {
-if (rPropertyName == "SymbolBitmapURL")
+if (rPropertyName == "SymbolBitmap")
 {
 uno::Any aAny = WrappedPropertySet::getPropertyValue("SymbolType");
 sal_Int32 nVal = css::chart::ChartSymbolType::NONE;
diff --git 
a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx 
b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
index 0547222017c8..ec84b1f869ad 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
@@ -61,13 +61,13 @@ public:
tSeriesOrDiagramPropertyType 
ePropertyType);
 };
 
-class WrappedSymbolBitmapURLProperty : public WrappedSeriesOrDiagramProperty< 
OUString >
+class WrappedSymbolBitmapProperty : public 
WrappedSeriesOrDiagramProperty
 {
 public:
-virtual OUString getValueFromSeries( const Reference< beans::XPropertySet 
>& xSeriesPropertySet ) const override;
-virtual void setValueToSeries( const Reference< beans::XPropertySet >& 
xSeriesPropertySet, const OUString& aNewGraphicURL ) const override;
+virtual uno::Reference getValueFromSeries(const 
Reference& xSeriesPropertySet) const override;
+virtual void setValueToSeries(const Reference & 
xSeriesPropertySet, uno::Reference const & aNewGraphicURL) 
const override;
 
-explicit WrappedSymbolBitmapURLProperty(const 
std::shared_ptr& spChart2ModelContact,
+explicit WrappedSymbolBitmapProperty(const 
std::shared_ptr& spChart2ModelContact,
 tSeriesOrDiagramPropertyType 
ePropertyType);
 };
 
@@ -99,7 +99,7 @@ enum
 {
 //symbol properties
 PROP_CHART_SYMBOL_TYPE = FAST_PROPERTY_ID_START_CHART_SYMBOL_PROP,
-PROP_CHART_SYMBOL_BITMAP_URL,
+PROP_CHART_SYMBOL_BITMAP,
 PROP_CHART_SYMBOL_SIZE,
 PROP_CHART_SYMBOL_AND_LINES
 };
@@ -154,7 +154,7 @@ void lcl_addWrappedProperties( std::vector< 
WrappedProperty* >& rList
 , tSeriesOrDiagramPropertyType 
ePropertyType )
 {
 rList.push_back( new WrappedSymbolTypeProperty( spChart2ModelContact, 
ePropertyType ) );
-rList.push_back( new WrappedSymbolBitmapURLProperty( spChart2ModelContact, 
ePropertyType ) );
+rList.push_back( new WrappedSymbolBitmapProperty( spChart2ModelContact, 
ePropertyType ) );
 rList.push_back( new WrappedSymbolSizeProperty( spChart2ModelContact, 
ePropertyType  ) );
 rList.push_back( new WrappedSymbolAndLinesProperty( spChart2ModelContact, 
ePropertyType  ) );
 }
@@ -169,9 +169,9 @@ void WrappedSymbolProperties::addProperties( std::vector< 
Property > & rOutPrope
   beans::PropertyAttribute::BOUND
   | beans::PropertyAttribute::MAYBEDEFAULT );
 
-rOutProperties.emplace_back( "SymbolBitmapURL",
-  PROP_CHART_SYMBOL_BITMAP_URL,
-  cppu::UnoType::get(),
+rOutProperties.emplace_back( "SymbolBitmap",
+  PROP_CHART_SYMBOL_BITMAP,
+  cppu::UnoType::get(),
   beans::PropertyAttribute::BOUND
   | beans::PropertyAttribute::MAYBEDEFAULT );
 
@@ -281,66 +281,42 @@ beans::PropertyState 
WrappedSymbolTypeProperty::getPropertyState( const Referenc
 return WrappedProperty::getPropertyState( xInnerPropertyState );
 }
 
-WrappedSymbolBitmapURLProperty::WrappedSymbolBitmapURLProperty(
+WrappedSymbolBitmapProperty::WrappedSymbolBitmapProperty(
 const std::shared_ptr& spChart2ModelContact,

[Libreoffice-commits] core.git: include/editeng include/oox include/xmloff oox/source sc/qa sw/qa sw/source writerfilter/source xmloff/inc xmloff/source

[Tomaž Vajngerl]

 include/editeng/memberids.h   |   19 ++---
 include/oox/helper/modelobjecthelper.hxx  |4 -
 include/xmloff/xmltypes.hxx   |1 
 oox/source/drawingml/fillproperties.cxx   |7 --
 oox/source/drawingml/shape.cxx|   14 ++--
 oox/source/drawingml/shapepropertymap.cxx |   17 ++--
 oox/source/export/drawingml.cxx   |   17 
 oox/source/helper/modelobjecthelper.cxx   |9 ++
 oox/source/token/properties.txt   |2 
 sc/qa/unit/subsequent_export-test.cxx |9 +-
 sw/qa/extras/ooxmlexport/ooxmlexport2.cxx |   13 ++-
 sw/qa/extras/rtfexport/rtfexport.cxx  |   13 ++-
 sw/source/core/unocore/unosett.cxx|   48 +++---
 sw/source/core/unocore/unotbl.cxx |1 
 sw/source/filter/ww8/docxattributeoutput.cxx  |2 
 sw/source/filter/xml/xmlbrsh.cxx  |   75 ++
 sw/source/filter/xml/xmlbrshi.hxx |7 +-
 sw/source/filter/xml/xmlexpit.cxx |   12 ---
 sw/source/filter/xml/xmlimpit.cxx |   11 ---
 writerfilter/source/dmapper/NumberingManager.cxx  |   25 ---
 writerfilter/source/dmapper/NumberingManager.hxx  |2 
 writerfilter/source/dmapper/PropertyIds.cxx   |1 
 writerfilter/source/dmapper/PropertyIds.hxx   |1 
 xmloff/inc/XMLBackgroundImageContext.hxx  |4 -
 xmloff/source/style/PageMasterStyleMap.cxx|6 -
 xmloff/source/style/XMLBackgroundImageContext.cxx |   29 
 xmloff/source/style/XMLBackgroundImageExport.cxx  |   30 
 xmloff/source/style/prstylei.cxx  |8 +-
 xmloff/source/style/xmlnume.cxx   |   30 +++-
 xmloff/source/text/txtprhdl.cxx   |   38 ++-
 xmloff/source/text/txtprmap.cxx   |6 -
 31 files changed, 257 insertions(+), 204 deletions(-)

New commits:
commit d72145f9307c732ced4a546ac1e5093ec7c1a982
Author: Tomaž Vajngerl 
Date:   Thu Mar 1 08:39:11 2018 +0900

Move BackGraphicURL property & friends to BackGraphic + fixes

This moves BackGraphicURL, HeaderGraphicURL, FooterGraphicURL and
ParaBackGraphicURL properties to BackGraphic, HeaderBackGraphic,
FooterBackGraphic and ParaBackGraphic. With this the property type
changes from String to XGraphic.

This change also fixes a bunch of test failures, changes the tests
to use the new properties and the correct type, changes the import
and export filters like xmloff and oox, to make the tests happy.

Change-Id: Ie66097514203c6dc36ab27420faf265322e9279e
Reviewed-on: https://gerrit.libreoffice.org/50760
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/editeng/memberids.h b/include/editeng/memberids.h
index d7d0a538ee4d..2f13be47a0f2 100644
--- a/include/editeng/memberids.h
+++ b/include/editeng/memberids.h
@@ -157,16 +157,15 @@
 //BrushItem
 #define MID_BACK_COLOR  0
 #define MID_GRAPHIC_POSITION1
-#define MID_GRAPHIC_LINK2
-#define MID_GRAPHIC 3
-#define MID_GRAPHIC_TRANSPARENT 4
-#define MID_GRAPHIC_URL 5
-#define MID_GRAPHIC_FILTER  6
-#define MID_GRAPHIC_REPEAT  7
-#define MID_GRAPHIC_TRANSPARENCY 8
-#define MID_BACK_COLOR_R_G_B9
-#define MID_BACK_COLOR_TRANSPARENCY 10
-#define MID_SHADING_VALUE   11
+#define MID_GRAPHIC 2
+#define MID_GRAPHIC_TRANSPARENT 3
+#define MID_GRAPHIC_URL 4
+#define MID_GRAPHIC_FILTER  5
+#define MID_GRAPHIC_REPEAT  6
+#define MID_GRAPHIC_TRANSPARENCY 7
+#define MID_BACK_COLOR_R_G_B8
+#define MID_BACK_COLOR_TRANSPARENCY 9
+#define MID_SHADING_VALUE   10
 
 //SvxFormatBreakItem
 #define MID_BREAK_BEFORE0
diff --git a/include/oox/helper/modelobjecthelper.hxx 
b/include/oox/helper/modelobjecthelper.hxx
index 67980b57f6c8..694bdf13ddb7 100644
--- a/include/oox/helper/modelobjecthelper.hxx
+++ b/include/oox/helper/modelobjecthelper.hxx
@@ -27,7 +27,8 @@
 #include 
 
 namespace com { namespace sun { namespace star {
-namespace awt { struct Gradient; }
+namespace awt { struct Gradient;
+class XBitmap; }
 namespace graphic { class XGraphic; }
 namespace container { class XNameContainer; }
 namespace drawing { struct LineDash; }
@@ -113,6 +114,7 @@ public:
 OUString 
insertFillBitmapXGraphic(css::uno::Reference const & 
rxGraphic);
 
 OUString getFillBitmapUrl( const OUString& rGraphicName );
+css::uno::Reference getFillBitmap(OUString const & 
rGraphicName);
 
 private:
 ObjectContainer maMarkerContainer;  ///< Contains all named line 
markers (line end polygons).
diff --git a/include/xmloff/xmltypes.hxx b/include/xmloff/xmltypes.hxx
index 8b7fc23981c7..dc2e6558321e 100644
--- 

[Libreoffice-commits] core.git: editeng/source sw/source

[Tomaž Vajngerl]

 editeng/source/items/frmitems.cxx  |   52 +++--
 sw/source/core/unocore/swunohelper.cxx |2 +
 sw/source/core/unocore/unoframe.cxx|9 +
 sw/source/core/unocore/unotbl.cxx  |1 
 4 files changed, 55 insertions(+), 9 deletions(-)

New commits:
commit 6b39ed0eaffabb6ffe11496d833053c094c72f7b
Author: Tomaž Vajngerl 
Date:   Thu Mar 1 06:33:30 2018 +0900

MID_GRAPHIC as alternative to set graphic to the SvxBrushItem

Change-Id: I6e17d1a34f0bd17a0eafd7c741162f23279e9d1a
Reviewed-on: https://gerrit.libreoffice.org/50539
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index 5d3f3370bbde..f7a73d190229 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -44,6 +44,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -84,6 +85,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::editeng;
 using namespace ::com::sun::star;
@@ -3190,10 +3192,6 @@ bool SvxBrushItem::QueryValue( uno::Any& rVal, sal_uInt8 
nMemberId ) const
 rVal <<= 
static_cast(static_cast(eGraphicPos));
 break;
 
-case MID_GRAPHIC:
-SAL_WARN( "editeng.items", "not implemented" );
-break;
-
 case MID_GRAPHIC_TRANSPARENT:
 rVal <<= ( aColor.GetTransparency() == 0xff );
 break;
@@ -3214,6 +3212,22 @@ bool SvxBrushItem::QueryValue( uno::Any& rVal, sal_uInt8 
nMemberId ) const
 }
 break;
 
+case MID_GRAPHIC:
+{
+uno::Reference xGraphic;
+if (!maStrLink.isEmpty())
+{
+Graphic aGraphic(vcl::graphic::loadFromURL(maStrLink));
+xGraphic = aGraphic.GetXGraphic();
+}
+else if (xGraphicObject)
+{
+xGraphic = xGraphicObject->GetGraphic().GetXGraphic();
+}
+rVal <<= xGraphic;
+}
+break;
+
 case MID_GRAPHIC_FILTER:
 {
 rVal <<= maStrFilter;
@@ -3276,10 +3290,6 @@ bool SvxBrushItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 }
 break;
 
-case MID_GRAPHIC:
-SAL_WARN( "editeng.items", "not implemented" );
-break;
-
 case MID_GRAPHIC_TRANSPARENT:
 aColor.SetTransparency( Any2Bool( rVal ) ? 0xff : 0 );
 break;
@@ -3316,6 +3326,32 @@ bool SvxBrushItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 }
 break;
 
+case MID_GRAPHIC:
+{
+if (rVal.getValueType() == cppu::UnoType::get())
+{
+auto xGraphic = rVal.get();
+
+Graphic aGraphic(xGraphic);
+maStrLink.clear();
+
+std::unique_ptr 
xOldGrfObj(std::move(xGraphicObject));
+xGraphicObject.reset(new GraphicObject(aGraphic));
+ApplyGraphicTransparency_Impl();
+xOldGrfObj.reset();
+
+if (aGraphic && eGraphicPos == GPOS_NONE)
+{
+eGraphicPos = GPOS_MM;
+}
+else if (!aGraphic)
+{
+eGraphicPos = GPOS_NONE;
+}
+}
+}
+break;
+
 case MID_GRAPHIC_FILTER:
 {
 if( rVal.getValueType() == ::cppu::UnoType::get() )
diff --git a/sw/source/core/unocore/swunohelper.cxx 
b/sw/source/core/unocore/swunohelper.cxx
index 354ff65703a5..9d2040e87d55 100644
--- a/sw/source/core/unocore/swunohelper.cxx
+++ b/sw/source/core/unocore/swunohelper.cxx
@@ -313,6 +313,8 @@ bool needToMapFillItemsToSvxBrushItemTypes(const 
SfxItemSet& rSet,
 {
 case MID_GRAPHIC_URL:
 return SfxItemState::SET == 
rSet.GetItemState(XATTR_FILLBITMAP);
+case MID_GRAPHIC:
+return SfxItemState::SET == 
rSet.GetItemState(XATTR_FILLBITMAP);
 case MID_GRAPHIC_POSITION:
 return SfxItemState::SET == 
rSet.GetItemState(XATTR_FILLBMP_STRETCH)
 || SfxItemState::SET == 
rSet.GetItemState(XATTR_FILLBMP_TILE)
diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index f93ed469dd21..bb2f794d7a3e 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -212,12 +212,14 @@ bool 
BaseFrameProperties_Impl::FillBaseProperties(SfxItemSet& rToSet, const SfxI
 const ::uno::Any* pTrans = nullptr; GetProperty(RES_BACKGROUND, 
MID_GRAPHIC_TRANSPARENT, pTrans );
 const ::uno::Any* pGrLoc = nullptr; GetProperty(RES_BACKGROUND, 
MID_GRAPHIC_POSITION, pGrLoc );
 const ::uno::Any* pGrURL = nullptr; GetProperty(RES_BACKGROUND, 

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
Bug 43808 depends on bug 116250, which changed state.

Bug 116250 Summary: When Keyboard is in Keyboard layout, up/down movement 
scrolls the viewport
https://bugs.documentfoundation.org/show_bug.cgi?id=116250

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112876] Add configuration to disable scroll lock function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112876

m.a.riosv  changed:

   What|Removed |Added

 CC||eyal...@technion.ac.il

--- Comment #15 from m.a.riosv  ---
*** Bug 116250 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116250] When Keyboard is in Keyboard layout, up/ down movement scrolls the viewport

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116250

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |DUPLICATE

--- Comment #1 from m.a.riosv  ---
Please if you are not agree, reopen it.

*** This bug has been marked as a duplicate of bug 112876 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs