[Libreoffice-bugs] [Bug 129434] Suggested features for Writer for authors.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129434

Dieter Praas  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 129434] Suggested features for Writer for authors.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129434

Dieter Praas  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 129434] Suggested features for Writer for authors.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129434

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter Praas  ---
(In reply to Lynne Connolly from comment #0)
> I'm an author, and there are reasons I don't use LO for novel writing, much
> though I love the program. Someone suggested I reported why I use a
> different word processor for writing, so here it is:
> 
> 1. All the autocorrect problems I've reported before.

Please give informations about bug numbers. Pleae don't report bug again, if
the're already reported.


> 2. I can check a box on AWP and it will start on the document I was last
> working on, the cursor at the place where I last left it. Such a useful
> feature to have!
> 
> 3. A browser-style tagged interface, so that I can have all the documents
> I'm working on easily visible, and just click on them to switch between them.
> 
> 4. A wonderful little tool that lists long sentences (over x number of
> words), word repetitions and word frequencies. But I doubt you'll be able to
> do that.

Please don't mix different proposals in one bug report, because we can't manage
that in bugzilla. Would be nice, if you create one bug report for each idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732

Dieter Praas  changed:

   What|Removed |Added

 Depends on||128987


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128987
[Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems
like font kerning has gone awry
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123182] Very Bad Character Kerning in Verdana pt11 in writer especially Letter 'm' (depending on zoom level)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123182

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8987

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128987

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEW
   Priority|medium  |low
   Severity|normal  |minor
 Ever confirmed|0   |1
 Blocks||71732
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3182

--- Comment #11 from Dieter Praas  ---
I confirm it with

Version: 6.3.4.2 (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

Similar to bug 123182 (So I also change status of this bug to NEW). Perhaps
it's better to merge them?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source

[Chris Sherlock (via logerrit)]

 drawinglayer/source/tools/emfphelperdata.cxx |   20 +++-
 1 file changed, 19 insertions(+), 1 deletion(-)

New commits:
commit 2d46f14fa0ef555069795bd4e889b6871e7ce943
Author: Chris Sherlock 
AuthorDate: Tue Dec 10 18:04:59 2019 +1100
Commit: Bartosz Kosiorek 
CommitDate: Fri Dec 20 08:43:36 2019 +0100

drawinglayer: better logging for brushes in EmfPlusRecordTypeDrawString

Change-Id: I8ac039fd81767a52593721f211f3887276230ccf
Reviewed-on: https://gerrit.libreoffice.org/84841
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index b7a0c893c7af..3dbb663a6f82 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -195,6 +195,23 @@ namespace emfplushelper
 return "";
 }
 
+static bool IsBrush(sal_uInt16 flags)
+{
+return (!((flags >> 15) & 0x0001));
+}
+
+static OUString BrushIDToString(sal_uInt16 flags, sal_uInt32 brushid)
+{
+OUString sBrushId;
+
+if (IsBrush(flags))
+sBrushId = sBrushId.concat("EmfPlusBrush ID: 
").concat(OUString::number(brushid));
+else
+sBrushId = sBrushId.concat("ARGB: 
0x").concat(OUString::number(brushid, 16));
+
+return sBrushId;
+}
+
 EMFPObject::~EMFPObject()
 {
 }
@@ -1477,7 +1494,8 @@ namespace emfplushelper
 sal_uInt32 formatId;
 sal_uInt32 stringLength;
 
rMS.ReadUInt32(brushId).ReadUInt32(formatId).ReadUInt32(stringLength);
-SAL_INFO("drawinglayer", "EMF+\t DrawString brushId: " 
<< brushId);
+SAL_INFO("drawinglayer", "EMF+\t FontId: " << 
OUString::number(flags & 0xFF));
+SAL_INFO("drawinglayer", "EMF+\t BrushId: " << 
BrushIDToString(flags, brushId));
 SAL_INFO("drawinglayer", "EMF+\t FormatId: " << 
formatId);
 SAL_INFO("drawinglayer", "EMF+\t Length: " << 
stringLength);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - officecfg/registry

[Roman Kuznetsov (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 868f3b157e2982887c3efeb4de850560a43755c5
Author: Roman Kuznetsov 
AuthorDate: Wed Dec 11 19:07:39 2019 +0100
Commit: Roman Kuznetsov 
CommitDate: Fri Dec 20 08:43:49 2019 +0100

tdf#128683 Add More Options button to Table section in Writer's Sidebar

Change-Id: I057f7853fafcf8aa33611adae969b12fda6405b7
Reviewed-on: https://gerrit.libreoffice.org/84972
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
Reviewed-by: Roman Kuznetsov 
(cherry picked from commit 82dce922e6d36b40dd0571b0c00666cd6fc1a8ac)
Reviewed-on: https://gerrit.libreoffice.org/85530

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
index c1fab7539039..dd777b7b228e 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
@@ -1561,6 +1561,9 @@
 
   PropertyDeck
 
+
+  .uno:TableDialog
+
 
   
 WriterVariants, Table,  visible ;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: drawinglayer/source

[Chris Sherlock (via logerrit)]

 drawinglayer/source/tools/emfphelperdata.cxx |   36 ++-
 drawinglayer/source/tools/emfppen.cxx|   50 +--
 drawinglayer/source/tools/emfppen.hxx|   14 +++
 3 files changed, 74 insertions(+), 26 deletions(-)

New commits:
commit 1bd303a4c38a1bc04c3cf7bf0e7a44ac0fdb209d
Author: Chris Sherlock 
AuthorDate: Tue Dec 10 03:04:18 2019 +1100
Commit: Bartosz Kosiorek 
CommitDate: Fri Dec 20 08:42:18 2019 +0100

drawinglayer: improve pen object logging

Change-Id: Iaae081ddee8097346000b7c2d987a2321d5e98cd
Reviewed-on: https://gerrit.libreoffice.org/84833
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index 51a727bdcc61..b7a0c893c7af 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -204,40 +204,28 @@ namespace emfplushelper
 switch (aUnitType)
 {
 case UnitTypePixel:
-{
 return 1.0f;
-}
+
 case UnitTypePoint:
-{
-SAL_INFO("drawinglayer", "EMF+\t Converting Points to 
Pixels.");
 return Application::GetDefaultDevice()->GetDPIX() / 72;
-}
+
 case UnitTypeInch:
-{
-SAL_INFO("drawinglayer", "EMF+\t Converting Inches to 
Pixels.");
 return Application::GetDefaultDevice()->GetDPIX();
-}
+
 case UnitTypeMillimeter:
-{
-SAL_INFO("drawinglayer", "EMF+\t Converting Millimeters to 
Pixels");
 return Application::GetDefaultDevice()->GetDPIX() / 25.4;
-}
+
 case UnitTypeDocument:
-{
-SAL_INFO("drawinglayer", "EMF+\t Converting Documents to 
Pixels.");
 return Application::GetDefaultDevice()->GetDPIX() / 300;
-}
+
 case UnitTypeWorld:
 case UnitTypeDisplay:
-{
 SAL_WARN("drawinglayer", "EMF+\t Converting to 
World/Display.");
 return 1.0f;
-}
+
 default:
-{
 SAL_WARN("drawinglayer", "EMF+\tTODO Unimplemented support of 
Unit Type: 0x" << std::hex << aUnitType);
 return 1.0f;
-}
 }
 }
 
@@ -491,14 +479,14 @@ namespace emfplushelper
 {
 // we need a line join attribute
 basegfx::B2DLineJoin lineJoin = basegfx::B2DLineJoin::Round;
-if (pen->penDataFlags & 0x0008) // additional line join 
information
+if (pen->penDataFlags & EmfPlusPenDataJoin) // additional line 
join information
 {
 lineJoin = 
static_cast(EMFPPen::lcl_convertLineJoinType(pen->lineJoin));
 }
 
 // we need a line cap attribute
 css::drawing::LineCap lineCap = css::drawing::LineCap_BUTT;
-if (pen->penDataFlags & 0x0002) // additional line cap 
information
+if (pen->penDataFlags & EmfPlusPenDataStartCap) // additional line 
cap information
 {
 lineCap = 
static_cast(EMFPPen::lcl_convertStrokeCap(pen->startCap));
 SAL_WARN_IF(pen->startCap != pen->endCap, "drawinglayer", 
"emf+ pen uses different start and end cap");
@@ -511,7 +499,7 @@ namespace emfplushelper
  lineCap);
 
 drawinglayer::attribute::StrokeAttribute aStrokeAttribute;
-if (pen->penDataFlags & 0x0020 && pen->dashStyle != 
EmfPlusLineStyleCustom) // pen has a predefined line style
+if (pen->penDataFlags & EmfPlusPenDataLineStyle && pen->dashStyle 
!= EmfPlusLineStyleCustom) // pen has a predefined line style
 {
 // short writing
 const double pw = maMapTransform.get(1, 1) * pen->penWidth;
@@ -539,7 +527,7 @@ namespace emfplushelper
 break;
 }
 }
-else if (pen->penDataFlags & 0x0100) // pen has a custom dash 
line
+else if (pen->penDataFlags & EmfPlusPenDataMiterLimit) // pen has 
a custom dash line
 {
 // StrokeAttribute needs a double vector while the pen 
provides a float vector
 std::vector aPattern(pen->dashPattern.size());
@@ -573,7 +561,7 @@ namespace emfplushelper
 pen->GetColor().GetTransparency() / 255.0));
 }
 
-if ((pen->penDataFlags & 0x0800) && 
(pen->customStartCap->polygon.begin()->count() > 1))
+if ((pen->penDataFlags & EmfPlusPenDataCustomStartCap) && 
(pen->customStartCap->polygon.begin()->count() > 1))
 {
 SAL_WARN("drawinglayer", "EMF+\tCustom Start Line Cap");
 

[Libreoffice-commits] core.git: drawinglayer/source

[Chris Sherlock (via logerrit)]

 drawinglayer/source/tools/emfpbrush.cxx|   84 +++
 drawinglayer/source/tools/emfphelperdata.cxx   |  177 ++---
 drawinglayer/source/tools/emfppath.cxx |   16 +-
 drawinglayer/source/tools/emfppen.cxx  |   16 +-
 drawinglayer/source/tools/emfpstringformat.cxx |   31 ++--
 5 files changed, 185 insertions(+), 139 deletions(-)

New commits:
commit aa59b0983061d344224986aa044b6ebd3ca218af
Author: Chris Sherlock 
AuthorDate: Thu Dec 5 08:05:35 2019 +1100
Commit: Bartosz Kosiorek 
CommitDate: Fri Dec 20 08:41:15 2019 +0100

drawinglayer: improve more EMF+ logging

- Fixed logging of objects
- Fixed indenting in log statements

Change-Id: If29dc2a0d781f9d4c3fd2c810aa29fe607f0a9c9
Reviewed-on: https://gerrit.libreoffice.org/84467
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfpbrush.cxx 
b/drawinglayer/source/tools/emfpbrush.cxx
index f7d316b48726..650f3e774d6e 100644
--- a/drawinglayer/source/tools/emfpbrush.cxx
+++ b/drawinglayer/source/tools/emfpbrush.cxx
@@ -47,14 +47,27 @@ namespace emfplushelper
 {
 }
 
+static OUString BrushTypeToString(sal_uInt32 type)
+{
+switch (type)
+{
+case BrushTypeSolidColor: return "BrushTypeSolidColor";
+case BrushTypeHatchFill: return "BrushTypeHatchFill";
+case BrushTypeTextureFill: return "BrushTypeTextureFill";
+case BrushTypePathGradient: return "BrushTypePathGradient";
+case BrushTypeLinearGradient: return "BrushTypeLinearGradient";
+}
+return "";
+}
+
 void EMFPBrush::Read(SvStream& s, EmfPlusHelperData const & rR)
 {
 sal_uInt32 header;
 
 s.ReadUInt32(header).ReadUInt32(type);
 
-SAL_INFO("drawinglayer", "EMF+\tbrush");
-SAL_INFO("drawinglayer", "EMF+\theader: 0x" << std::hex << header << " 
type: " << type << std::dec);
+SAL_INFO("drawinglayer", "EMF+\t\t\tHeader: 0x" << std::hex << header);
+SAL_INFO("drawinglayer", "EMF+\t\t\tType: " << BrushTypeToString(type) 
<< "(0x" << type << ")" << std::dec);
 
 switch (type)
 {
@@ -64,7 +77,7 @@ namespace emfplushelper
 s.ReadUInt32(color);
 
 solidColor = ::Color(0xff - (color >> 24), (color >> 16) & 
0xff, (color >> 8) & 0xff, color & 0xff);
-SAL_INFO("drawinglayer", "EMF+\tsolid color: 0x" << std::hex 
<< color << std::dec);
+SAL_INFO("drawinglayer", "EMF+\t\t\t\tSolid color: 0x" << 
std::hex << color << std::dec);
 break;
 }
 case BrushTypeHatchFill:
@@ -79,7 +92,9 @@ namespace emfplushelper
 hatchStyle = static_cast(style);
 solidColor = ::Color(0xff - (foregroundColor >> 24), 
(foregroundColor >> 16) & 0xff, (foregroundColor >> 8) & 0xff, foregroundColor 
& 0xff);
 secondColor = ::Color(0xff - (backgroundColor >> 24), 
(backgroundColor >> 16) & 0xff, (backgroundColor >> 8) & 0xff, backgroundColor 
& 0xff);
-SAL_INFO("drawinglayer", "EMF+\thatch style " << style << " 
foregroundcolor: 0x" << solidColor.AsRGBHexString() << " background 0x" << 
secondColor.AsRGBHexString());
+SAL_INFO("drawinglayer", "EMF+\t\t\t\tHatch style: 0x" << 
std::hex << style);
+SAL_INFO("drawinglayer", "EMF+\t\t\t\tForeground color: 0x" << 
solidColor.AsRGBHexString());
+SAL_INFO("drawinglayer", "EMF+\t\t\t\tBackground color: 0x" << 
secondColor.AsRGBHexString());
 break;
 }
 case BrushTypeTextureFill:
@@ -90,15 +105,15 @@ namespace emfplushelper
 case BrushTypePathGradient:
 {
 s.ReadUInt32(additionalFlags).ReadInt32(wrapMode);
-SAL_INFO("drawinglayer", "EMF+\tpath gradient, additional 
flags: 0x" << std::hex << additionalFlags << std::dec);
+SAL_INFO("drawinglayer", "EMF+\t\t\t\tAdditional flags: 0x" << 
std::hex << additionalFlags << std::dec);
 sal_uInt32 color;
 s.ReadUInt32(color);
 solidColor = ::Color(0xff - (color >> 24), (color >> 16) & 
0xff, (color >> 8) & 0xff, color & 0xff);
-SAL_INFO("drawinglayer", "EMF+\tcenter color: 0x" << std::hex 
<< color << std::dec);
+SAL_INFO("drawinglayer", "EMF+\t\t\t\tCenter color: 0x" << 
std::hex << color << std::dec);
 s.ReadFloat(firstPointX).ReadFloat(firstPointY);
-SAL_INFO("drawinglayer", "EMF+\tcenter point: " << firstPointX 
<< "," << firstPointY);
+SAL_INFO("drawinglayer", "EMF+\t\t\t\tCenter point: " << 
firstPointX << "," << firstPointY);
 s.ReadInt32(surroundColorsNumber);
-SAL_INFO("drawinglayer", "EMF+\t number of surround colors: " 
<< surroundColorsNumber);
+

[Libreoffice-bugs] [Bug 129502] is there a difference between insert cross-reference "number" and insert cross-reference "number (no context)"?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129502

Dieter Praas  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129502] is there a difference between insert cross-reference "number" and insert cross-reference "number (no context)"?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129502

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter Praas  ---
Created attachment 156684
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156684=edit
Differece between options

Yes there's a difference (see attachment)

So for me NOTABUG. Docmentation is correct (perhaps not very clear). Please
feel free to reopen it with a short reasoning, if you don't agree.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #42 from Mike Kaganski  ---
Also "Assigned Commands" lists on Manus, Toolbars, Notebookbar, and Context
menus likely also need those tooltips?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #41 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #40)
> The tree has now individual tooltips with Label (eg "About"), Name (eg
> .uno:About), and Tooltip (eg. "Show the about dialog") all data taken from
> the command.

Nice solution; thanks Jim!

However, testing with Version: 6.5.0.0.alpha0+ (x64)
Build ID: fdb5ce011cb043475869d0b607ea25b8f32b4314
CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL:
win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

in Writer's Customize (Keyboard tab), hovering over *every* function in All
commands category, I couldn't find a single function with non-empty Tooltip:
field - even for known-to-have one, like "Table" (defaulting to Ctrl+F12,
having a button on toolbar, with "Insert Table" tooltip).

And the Label: field seems redundant, since that's exactly what is displayed in
the Function list?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Bakos Attila (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf87569_drawingml.docx |binary
 sw/qa/extras/ooxmlexport/data/tdf87569_vml.docx   |binary
 sw/qa/extras/ooxmlexport/ooxmlexport14.cxx|   20 ++
 writerfilter/source/dmapper/DomainMapper.cxx  |   15 +
 writerfilter/source/dmapper/GraphicImport.cxx |9 
 5 files changed, 44 insertions(+)

New commits:
commit 10f29d8bf05d44ca8bc11d34d1294ec17f8ac0f1
Author: Bakos Attila 
AuthorDate: Sat Dec 14 12:36:13 2019 +0100
Commit: László Németh 
CommitDate: Fri Dec 20 08:04:15 2019 +0100

tdf#87569 tdf#109411 DOCX import: fix shape anchor in tables

Import "relative from page" horizontal setting of
VML and DrawingML shapes as "relative from column"
in tables, just as MSO handles it.

Change-Id: If71f2e52bbba324a98651e701feaeb99acfefc48
Reviewed-on: https://gerrit.libreoffice.org/85141
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf87569_drawingml.docx 
b/sw/qa/extras/ooxmlexport/data/tdf87569_drawingml.docx
new file mode 100644
index ..7f00a46e2cc6
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf87569_drawingml.docx differ
diff --git a/sw/qa/extras/ooxmlexport/data/tdf87569_vml.docx 
b/sw/qa/extras/ooxmlexport/data/tdf87569_vml.docx
new file mode 100644
index ..0223ad71d4e2
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf87569_vml.docx 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 51c2ee7acc2c..fb93572bf725 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -17,6 +17,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class Test : public SwModelTestBase
 {
@@ -33,6 +34,25 @@ protected:
 }
 };
 
+DECLARE_OOXMLEXPORT_TEST(testTdf87569v, "tdf87569_vml.docx")
+{
+//the original tdf87569 sample has vml shapes...
+uno::Reference xShapeProperties(getShape(1), 
uno::UNO_QUERY);
+sal_Int16 nValue;
+xShapeProperties->getPropertyValue("HoriOrientRelation") >>= nValue;
+CPPUNIT_ASSERT_EQUAL_MESSAGE("tdf87569_vml: The Shape is not in the 
table!",
+ text::RelOrientation::FRAME, nValue);
+}
+
+DECLARE_OOXMLEXPORT_TEST(testTdf87569d, "tdf87569_drawingml.docx")
+{
+//if the original tdf87569 sample is upgraded it will have drawingml 
shapes...
+uno::Reference xShapeProperties(getShape(1), 
uno::UNO_QUERY);
+sal_Int16 nValue;
+xShapeProperties->getPropertyValue("HoriOrientRelation") >>= nValue;
+CPPUNIT_ASSERT_EQUAL_MESSAGE("tdf87569_drawingml: The Shape is not in the 
table!",
+ text::RelOrientation::FRAME, nValue);
+}
 
 DECLARE_OOXMLEXPORT_TEST(testTdf120315, "tdf120315.docx")
 {
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 9bbbedf64f9c..ccbe8d8d197b 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -3023,6 +3023,21 @@ void 
DomainMapper::lcl_startShape(uno::Reference const& xShape)
 m_pImpl->PushPendingShape(xShape);
 
 m_pImpl->SetIsFirstParagraphInShape(true);
+
+//tdf#87569: Fix table layout with correcting anchoring
+//If anchored object is in table, Word calculates its position from cell 
border
+//instead of page (what is set in the sample document)
+if (m_pImpl->m_nTableDepth > 0) //if we had a table
+{
+uno::Reference xShapePropSet(xShape, 
uno::UNO_QUERY);
+sal_Int16 nCurrentHorOriRel; //A temp variable for storaging the 
current setting
+xShapePropSet->getPropertyValue("HoriOrientRelation") >>= 
nCurrentHorOriRel;
+//and the correction:
+if (nCurrentHorOriRel == text::RelOrientation::PAGE_FRAME)
+xShapePropSet->setPropertyValue("HoriOrientRelation",
+
uno::makeAny(text::RelOrientation::FRAME));
+}
+
 }
 
 void DomainMapper::lcl_endShape( )
diff --git a/writerfilter/source/dmapper/GraphicImport.cxx 
b/writerfilter/source/dmapper/GraphicImport.cxx
index 74fa991eeb10..63a0e7491fb4 100644
--- a/writerfilter/source/dmapper/GraphicImport.cxx
+++ b/writerfilter/source/dmapper/GraphicImport.cxx
@@ -867,6 +867,15 @@ void GraphicImport::lcl_attribute(Id nName, Value& rValue)
 if (nRotation)
 xShapeProps->setPropertyValue("RotateAngle", 
uno::makeAny(nRotation));
 }
+
+//tdf#109411 If anchored object is in table, Word 
calculates its position from cell border
+//instead of page (what is set in the sample document)
+if (m_pImpl->rDomainMapper.IsInTable() &&
+m_pImpl->nHoriRelation == 
text::RelOrientation::PAGE_FRAME && 

[Libreoffice-bugs] [Bug 127445] Missing translation in LO Impress 6.3.1> User Interface> Tabs> "Layout" tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127445

--- Comment #5 from Albert Acer  ---
I am testing LibreOffice 6.3.4, Using WIndows 10 Professional X64, in Spanish,
and I see that this bug has been completely resolved. So I am confirming to you
that this bug has been resolved after testing LO 6.3.4 in Spanish.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129348] Can't open files (new and existing) using the android app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129348

--- Comment #4 from Nicolas Christener  ---
Kendy: I found the culprit :)

It's a language issue. I set my Android device to "English (Switzerland)" -
this triggers the issue.

Changing the primary language to e.g. "German (Switzerland)" immediately makes
the app work again.

Hope this helps to resolve the issue.

All the best,
Nicolas

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127979] Spanish translation is missing in LO Draw 6.3.2.2, Spanish Version, View Menu> User Interface Sub-Menu> options: “Tabbed Compact” and “Contextual Single”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127979

--- Comment #13 from Albert Acer  ---
I am testing LibreOffice 6.3.4, Using WIndows 10 Professional X64, in Spanish,
and I see that this bug has been completely resolved. So I am confirming to you
that this bug has been resolved after testing LO 6.3.4 in Spanish.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108628] [META] Usability issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108628
Bug 108628 depends on bug 108458, which changed state.

Bug 108458 Summary: Label changes for Toolbar use degrade function listing in 
the Customize dialog--have duplicate entries on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=108458

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115596] [META] Labels of UNO commands bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115596
Bug 115596 depends on bug 108458, which changed state.

Bug 108458 Summary: Label changes for Toolbar use degrade function listing in 
the Customize dialog--have duplicate entries on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=108458

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #40 from Heiko Tietze  ---
The tree has now individual tooltips with Label (eg "About"), Name (eg
.uno:About), and Tooltip (eg. "Show the about dialog") all data taken from the
command.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103238
Bug 103238 depends on bug 108458, which changed state.

Bug 108458 Summary: Label changes for Toolbar use degrade function listing in 
the Customize dialog--have duplicate entries on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=108458

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
Bug 108897 depends on bug 129228, which changed state.

Bug 129228 Summary: FILEOPEN XLSX: Specific publicly available file won't open
https://bugs.documentfoundation.org/show_bug.cgi?id=129228

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #39 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fdb5ce011cb043475869d0b607ea25b8f32b4314

tdf#108458 Show tooltips in CuiConfigFunctionListBox

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129228] FILEOPEN XLSX: Specific publicly available file won't open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129228

Noel Grandin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/inc cui/source cui/uiconfig

[Jim Raykowski (via logerrit)]

 cui/inc/strings.hrc |4 
 cui/source/customize/CommandCategoryListBox.cxx |1 +
 cui/source/customize/cfgutil.cxx|   12 
 cui/source/inc/cfgutil.hxx  |3 +++
 cui/uiconfig/ui/menuassignpage.ui   |1 +
 5 files changed, 21 insertions(+)

New commits:
commit fdb5ce011cb043475869d0b607ea25b8f32b4314
Author: Jim Raykowski 
AuthorDate: Thu Dec 5 02:55:57 2019 -0900
Commit: Heiko Tietze 
CommitDate: Fri Dec 20 07:22:04 2019 +0100

tdf#108458 Show tooltips in CuiConfigFunctionListBox

Change-Id: I6644e939c644c827e2b3ad019b975a3845585063
Reviewed-on: https://gerrit.libreoffice.org/84555
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/inc/strings.hrc b/cui/inc/strings.hrc
index 1ade0c0d6b38..3169862f2e54 100644
--- a/cui/inc/strings.hrc
+++ b/cui/inc/strings.hrc
@@ -396,6 +396,10 @@
 
 #define RID_SVXSTR_EDIT_PATHS   
NC_("optpathspage|editpaths", "Edit Paths: %1")
 
+#define RID_SVXSTR_COMMANDLABEL 
NC_("RID_SVXSTR_COMMANDLABEL", "Label")
+#define RID_SVXSTR_COMMANDNAME  
NC_("RID_SVXSTR_COMMANDLABEL", "Command")
+#define RID_SVXSTR_COMMANDTIP   
NC_("RID_SVXSTR_COMMANDLABEL", "Tooltip")
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/customize/CommandCategoryListBox.cxx 
b/cui/source/customize/CommandCategoryListBox.cxx
index 7576d0771edc..d9e3f57b1352 100644
--- a/cui/source/customize/CommandCategoryListBox.cxx
+++ b/cui/source/customize/CommandCategoryListBox.cxx
@@ -243,6 +243,7 @@ void CommandCategoryListBox::FillFunctionsList(
 SfxGroupInfo_Impl* pGrpInfo = m_aGroupInfo.back().get();
 pGrpInfo->sCommand = rInfo.Command;
 pGrpInfo->sLabel   = sUIName;
+pGrpInfo->sTooltip = sTooltipLabel;
 
pFunctionListBox->append(OUString::number(reinterpret_cast(m_aGroupInfo.back().get())),
 sUIName, xImage);
 }
 }
diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index b464ff53f4e4..e52ed440d311 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -278,6 +278,7 @@ 
CuiConfigFunctionListBox::CuiConfigFunctionListBox(std::unique_ptrmake_sorted();
 m_xTreeView->set_size_request(m_xTreeView->get_approximate_digit_width() * 
35, m_xTreeView->get_height_rows(9));
+m_xTreeView->connect_query_tooltip(LINK(this, CuiConfigFunctionListBox, 
QueryTooltip));
 }
 
 CuiConfigFunctionListBox::~CuiConfigFunctionListBox()
@@ -285,6 +286,17 @@ CuiConfigFunctionListBox::~CuiConfigFunctionListBox()
 ClearAll();
 }
 
+IMPL_LINK(CuiConfigFunctionListBox, QueryTooltip, const weld::TreeIter&, 
rIter, OUString)
+{
+SfxGroupInfo_Impl *pData = 
reinterpret_cast(m_xTreeView->get_id(rIter).toInt64());
+if (!pData)
+return OUString();
+OUString aLabel = CuiResId(RID_SVXSTR_COMMANDLABEL) + ": ";
+OUString aName = CuiResId(RID_SVXSTR_COMMANDNAME) + ": ";
+OUString aTip = CuiResId(RID_SVXSTR_COMMANDTIP) + ": ";
+return  aLabel + pData->sLabel + "\n" + aName + pData->sCommand+ "\n" + 
aTip + pData->sTooltip;
+}
+
 void CuiConfigFunctionListBox::ClearAll()
 /*  Description
 Deletes all entries in the FunctionListBox, all UserData and all
diff --git a/cui/source/inc/cfgutil.hxx b/cui/source/inc/cfgutil.hxx
index e930c24ac3ec..bfce0d6b13f4 100644
--- a/cui/source/inc/cfgutil.hxx
+++ b/cui/source/inc/cfgutil.hxx
@@ -92,6 +92,7 @@ struct SfxGroupInfo_Impl
 OUStringsCommand;
 OUStringsLabel;
 OUStringsHelpText;
+OUStringsTooltip;
 
 SfxGroupInfo_Impl( SfxCfgKind n, sal_uInt16 nr, void* pObj = 
nullptr ) :
 nKind( n ), nUniqueID( nr ), pObject( pObj ) {}
@@ -175,6 +176,8 @@ public:
 OUString  GetHelpText( bool bConsiderParent = true );
 OUString  GetCurCommand() const;
 OUString  GetCurLabel() const;
+
+DECL_LINK(QueryTooltip, const weld::TreeIter& rIter, OUString);
 };
 
 struct SvxConfigGroupBoxResource_Impl;
diff --git a/cui/uiconfig/ui/menuassignpage.ui 
b/cui/uiconfig/ui/menuassignpage.ui
index 7f37aad311b0..44d06931ebe4 100644
--- a/cui/uiconfig/ui/menuassignpage.ui
+++ b/cui/uiconfig/ui/menuassignpage.ui
@@ -322,6 +322,7 @@
 True
 True
 True
+True
 True
 True
 liststore1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129228] FILEOPEN XLSX: Specific publicly available file won't open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129228

--- Comment #9 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f2f5d74067705b7c64f8fb510952d7cece417627

tdf#129228 speedup load xls file with lots of comments

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129228] FILEOPEN XLSX: Specific publicly available file won't open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129228

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Noel Grandin (via logerrit)]

 sc/source/filter/inc/worksheethelper.hxx |4 
 sc/source/filter/oox/commentsbuffer.cxx  |7 +++
 sc/source/filter/oox/worksheethelper.cxx |5 +
 3 files changed, 16 insertions(+)

New commits:
commit f2f5d74067705b7c64f8fb510952d7cece417627
Author: Noel Grandin 
AuthorDate: Thu Dec 19 15:07:46 2019 +0200
Commit: Noel Grandin 
CommitDate: Fri Dec 20 07:16:04 2019 +0100

tdf#129228 speedup load xls file with lots of comments

by locking the underlying SdrModel while the comments are added, so we
avoid the reformatting that happends when the model is unlocked

Takes the time from 3m30 to 1m for me.

Change-Id: Ibc3d2b1ded548d5eee7715d9a655a0af61b0eb2b
Reviewed-on: https://gerrit.libreoffice.org/85523
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/inc/worksheethelper.hxx 
b/sc/source/filter/inc/worksheethelper.hxx
index 8f135e05ea9c..e3a2a955b22a 100644
--- a/sc/source/filter/inc/worksheethelper.hxx
+++ b/sc/source/filter/inc/worksheethelper.hxx
@@ -27,6 +27,7 @@
 #include "formulabase.hxx"
 
 struct ScDataBarFormatData;
+class ScDocument;
 
 namespace com { namespace sun { namespace star {
 namespace awt { struct Point; }
@@ -294,6 +295,9 @@ public:
 void setCellFormulaValue(
 const ScAddress& rAddress, const OUString& rValueStr, sal_Int32 
nCellType );
 
+ScDocument& getScDocument();
+
+
 private:
 WorksheetGlobals&   mrSheetGlob;
 };
diff --git a/sc/source/filter/oox/commentsbuffer.cxx 
b/sc/source/filter/oox/commentsbuffer.cxx
index c3c60c3f5a6d..43b133aad4fe 100644
--- a/sc/source/filter/oox/commentsbuffer.cxx
+++ b/sc/source/filter/oox/commentsbuffer.cxx
@@ -34,6 +34,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 namespace oox {
 namespace xls {
@@ -221,7 +223,12 @@ CommentRef CommentsBuffer::createComment()
 
 void CommentsBuffer::finalizeImport()
 {
+// keep the model locked to avoid repeated reformatting in the model
+auto pModel = getScDocument().GetDrawLayer();
+bool bWasLocked = pModel->isLocked();
+pModel->setLock(true);
 maComments.forEachMem( ::finalizeImport );
+pModel->setLock(bWasLocked);
 }
 
 } // namespace xls
diff --git a/sc/source/filter/oox/worksheethelper.cxx 
b/sc/source/filter/oox/worksheethelper.cxx
index 7542e545b40f..d390e9c33357 100644
--- a/sc/source/filter/oox/worksheethelper.cxx
+++ b/sc/source/filter/oox/worksheethelper.cxx
@@ -1363,6 +1363,11 @@ WorksheetHelper::WorksheetHelper( WorksheetGlobals& 
rSheetGlob ) :
 {
 }
 
+ScDocument& WorksheetHelper::getScDocument()
+{
+return getDocImport().getDoc();
+}
+
 /*static*/ WorksheetGlobalsRef WorksheetHelper::constructGlobals( const 
WorkbookHelper& rHelper,
 const ISegmentProgressBarRef& rxProgressBar, WorksheetType eSheetType, 
SCTAB nSheet )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129508] Severe clipboard issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129508

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from BogdanB  ---


*** This bug has been marked as a duplicate of bug 62196 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62196] EDITING: copy-paste from non-LibO-text-source pastes previous clipboard contents (see comment 62)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62196

BogdanB  changed:

   What|Removed |Added

 CC||i...@billiotenglish.com

--- Comment #92 from BogdanB  ---
*** Bug 129508 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - external/neon

[Thorsten Behrens (via logerrit)]

 external/neon/UnpackedTarball_neon.mk |1 +
 external/neon/neon_fix_sspi_session_timeout.patch |   22 ++
 2 files changed, 23 insertions(+)

New commits:
commit 6a548a172d0be2356f644225297a10ec50387b24
Author: Thorsten Behrens 
AuthorDate: Fri Dec 20 07:03:47 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Dec 20 07:03:47 2019 +0100

Fix crash during WebDAV lock refresh

 - NeonSession is shared amongst several files (if on one server instance)
   - there's explicit code in DAVSessionFactory::createDAVSession()
 to share sessions for same host/target
 - so then after a while, locks get refreshed, and session timeout hits
 - first lock -> no prob, ne_auth.c:ah_post_send() has
   auth_challenge() failing, returning error, which puts that lock
   into m_aRemoveDeferred list
 - _but_ ah_post_send() then does a clean_session(), and the next
   lock refresh from the same session hits NULLPTR session host
 - so let's delay any sspi_host cleanup until session object gets freed,
   instead of just cleaned

Change-Id: Ie257310c47913aef9fcfec92c1722d64b28c4f89

diff --git a/external/neon/UnpackedTarball_neon.mk 
b/external/neon/UnpackedTarball_neon.mk
index dacf425fa80f..74ac2eb38c97 100644
--- a/external/neon/UnpackedTarball_neon.mk
+++ b/external/neon/UnpackedTarball_neon.mk
@@ -24,6 +24,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,neon,\
external/neon/ubsan.patch \
external/neon/neon_fix_lock_token_on_if.patch \
external/neon/neon_fix_lock_timeout_windows.patch \
+   external/neon/neon_fix_sspi_session_timeout.patch \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/neon/neon_fix_sspi_session_timeout.patch 
b/external/neon/neon_fix_sspi_session_timeout.patch
new file mode 100644
index ..5003fda35022
--- /dev/null
+++ b/external/neon/neon_fix_sspi_session_timeout.patch
@@ -0,0 +1,22 @@
+--- src/ne_auth.c~ 2019-12-05 15:38:50.246997951 +0100
 src/ne_auth.c  2019-12-20 06:54:31.555836285 +0100
+@@ -300,8 +300,6 @@
+ sess->sspi_token = NULL;
+ ne_sspi_destroy_context(sess->sspi_context);
+ sess->sspi_context = NULL;
+-if (sess->sspi_host) ne_free(sess->sspi_host);
+-sess->sspi_host = NULL;
+ #endif
+ #ifdef HAVE_NTLM
+ if (sess->ntlm_context) {
+@@ -1599,6 +1597,10 @@
+ }
+ 
+ clean_session(sess);
++#ifdef HAVE_SSPI
++if (sess->sspi_host) ne_free(sess->sspi_host);
++sess->sspi_host = NULL;
++#endif
+ ne_free(sess);
+ }
+ 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129509] New: Controls in Notebookbar user interfaces don't show as disabled for read-only document.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129509

Bug ID: 129509
   Summary: Controls in Notebookbar user interfaces don't show as
disabled for read-only document.
   Product: LibreOffice
   Version: 6.5.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

This happens when switching to a Notebookbar user interface from another user
interface when document is read-only.

Steps to repro:

1) Open a text document 
2) Set user interface to Standard Toolbar
Menu > View > User Interface > Standard Toolbar 
3) Uncheck Menu > Edit > Edit Mode
4) Set user interface to any of the Notebookbar user interfaces, Tabbed, Tabbed
Compact, Groupedbar Compact, Contextual Single 

Results: Controls that should be shown disabled when document is read-only are
shown as enabled.

Expected results: Controls that should be shown as disabled when document is
read-only are shown as disabled.

Additional comments: Even though the controls are shown as enabled they are not
functional.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127005] SVG export from Draw doesn't include correctly the font family

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127005

--- Comment #15 from Deandre Jordan  ---
Many thanks for sharing this good article. Very interesting ideas!
https://great-saver.com/kmartfeedback-kmart-survey/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128987

Ming Hua  changed:

   What|Removed |Added

 CC||ming.v@qq.com

--- Comment #10 from Ming Hua  ---
Created attachment 156683
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156683=edit
Comparison between LibreOffice and Notepad.exe

I understand what the reporter means as I've seen LO sometimes rendering text
with strange kerning as well.

For comparison I'm attaching screenshots of both LO 6.2.8 and Windows native
Notepad.exe rendering the same text, so that developers can see what we mean. 
Both screenshots are with Times New Roman font, 12 pt size, 100% zoom.

However, neither rendering is perfect, and I'll be reluctant to say the LO one
is "wrong".

My "About LO" information:
Version: 6.2.8.2 (x64)
Build ID: f82ddfca21ebc1e222a662a32b25c0c9d20169ee
CPU threads: 2; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: zh-CN (zh_CN); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78840] Add the regular expression (?ismwx-ismwx: ... ) Flag settings. Evaluate parenthesized expression with specifics flags enabled or -disabled. To have a case sensitive mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78840

--- Comment #7 from Mike Kaganski  ---
... simply adding sensitivity to those *flags* without any new settings ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78840] Add the regular expression (?ismwx-ismwx: ... ) Flag settings. Evaluate parenthesized expression with specifics flags enabled or -disabled. To have a case sensitive mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78840

--- Comment #6 from Mike Kaganski  ---
I don't believe in compatibility issue with currently-case-insensitive
functions like COUNTIF. I don't believe in actually used regexes there which
include the (?i). So i actually believe that simply adding sensitivity to those
without any new settings is really enough.45

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128987

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128987

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121382] Very Long Save Time Bug has returned

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121382

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129496] LO 6.3.3.2 and LO 6.3.4.2 can't vectorize images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129496

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129496] LO 6.3.3.2 and LO 6.3.4.2 can't vectorize images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129496

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107659
Bug 107659 depends on bug 121254, which changed state.

Bug 121254 Summary: You cannot access the Floating Frame interface from a macro.
https://bugs.documentfoundation.org/show_bug.cgi?id=121254

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121254] You cannot access the Floating Frame interface from a macro.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121254

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121382] Very Long Save Time Bug has returned

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121382

--- Comment #7 from QA Administrators  ---
Dear Kevin,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92778] EPS images stop rendering after short period of time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92778

--- Comment #13 from QA Administrators  ---
Dear Chris Cameron,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125442] Calc - change the Character Color to green and change it back to black the next bottom box will write often in green

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125442

--- Comment #3 from QA Administrators  ---
Dear weakbit,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122916] [EDITING] the cursor is not on the line but jump forward + [maiusc+F3] doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122916

--- Comment #3 from QA Administrators  ---
Dear Giovi,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125442] Calc - change the Character Color to green and change it back to black the next bottom box will write often in green

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125442

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88981] Wrong selection mode is shown selected in the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88981

--- Comment #6 from QA Administrators  ---
Dear Ajinkya Dahale,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125434] Windows Installer doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125434

--- Comment #5 from QA Administrators  ---
Dear Kenzo,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121254] You cannot access the Floating Frame interface from a macro.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121254

--- Comment #4 from QA Administrators  ---
Dear Kadet,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122916] [EDITING] the cursor is not on the line but jump forward + [maiusc+F3] doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122916

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104763] FILESAVE DOC: Broken layout in Word after export to DOC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104763

--- Comment #4 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125434] Windows Installer doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125434

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104735] major stuttering: leaves out characters if you type moderately fast, takes 5 seconds for deleted characters to disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104735

--- Comment #4 from QA Administrators  ---
Dear Todd Vance,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113117
Bug 113117 depends on bug 125434, which changed state.

Bug 125434 Summary: Windows Installer doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=125434

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

[Andras Timar (via logerrit)]

 sw/uiconfig/swriter/ui/sidebartableedit.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6142062844e6b342d97fd3d0c632a256b6cdfcaa
Author: Andras Timar 
AuthorDate: Thu Dec 19 00:18:59 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Dec 20 04:35:45 2019 +0100

interface domain is sw for this ui resource

Change-Id: I9a0fce51d52ab3c0d1c7540834112cff1f3e572f
Reviewed-on: https://gerrit.libreoffice.org/85451
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/sw/uiconfig/swriter/ui/sidebartableedit.ui 
b/sw/uiconfig/swriter/ui/sidebartableedit.ui
index d2e1d5418342..43634b4a34fe 100644
--- a/sw/uiconfig/swriter/ui/sidebartableedit.ui
+++ b/sw/uiconfig/swriter/ui/sidebartableedit.ui
@@ -1,6 +1,6 @@
 
 
-
+
   
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127552] Moving the mouse pointer over a button in a toolbar that has keyboard focus on a button causes loss of keyboard focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127552

--- Comment #6 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/a42bc2e56f935bb3caa22bd3f6ff27720939cb29

tdf#127552 Make toolbox highlighting behave as intended

It will be available in 6.4.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127552] Moving the mouse pointer over a button in a toolbar that has keyboard focus on a button causes loss of keyboard focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127552

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - vcl/source

[Jim Raykowski (via logerrit)]

 vcl/source/window/toolbox.cxx |   22 +++---
 1 file changed, 19 insertions(+), 3 deletions(-)

New commits:
commit a42bc2e56f935bb3caa22bd3f6ff27720939cb29
Author: Jim Raykowski 
AuthorDate: Tue Oct 22 18:24:07 2019 -0800
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Dec 20 04:28:23 2019 +0100

tdf#127552 Make toolbox highlighting behave as intended

This patch provides intended highlight behavior to my understanding of
comments found in the toolbox source code.

 *only highlight when the focus is not inside a child window of a
toolbox eg, in an edit control
 *do not highlight when focus is in a different toolbox
 *only clear highlight when focus is not in toolbar

Change-Id: Ia18d35c4255ed0940bce5f0c6d9448ed2c85c6fe
Reviewed-on: https://gerrit.libreoffice.org/81356
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 
(cherry picked from commit 800b6f095f95ccfb8a7ba9755292332bf97f97ad)
Reviewed-on: https://gerrit.libreoffice.org/83446
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx
index 7d0f56c9e804..3b0d6b5a5f7e 100644
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -3068,8 +3068,24 @@ void ToolBox::MouseMove( const MouseEvent& rMEvt )
 // eg, in an edit control
 // and do not highlight when focus is in a different toolbox
 bool bDrawHotSpot = true;
-vcl::Window *pWin = Application::GetFocusWindow();
-if( pWin && pWin->ImplGetWindowImpl()->mbToolBox && pWin != this )
+vcl::Window *pFocusWin = Application::GetFocusWindow();
+
+bool bFocusWindowIsAToolBoxChild = false;
+if (pFocusWin)
+{
+vcl::Window *pWin = pFocusWin->GetParent();
+while (pWin)
+{
+if(pWin->ImplGetWindowImpl()->mbToolBox)
+{
+bFocusWindowIsAToolBoxChild = true;
+break;
+}
+pWin = pWin->GetParent();
+}
+}
+
+if( bFocusWindowIsAToolBoxChild || (pFocusWin && 
pFocusWin->ImplGetWindowImpl()->mbToolBox && pFocusWin != this) )
 bDrawHotSpot = false;
 
 if ( mbSelection && bDrawHotSpot )
@@ -3204,7 +3220,7 @@ void ToolBox::MouseMove( const MouseEvent& rMEvt )
 
 // only clear highlight when focus is not in toolbar
 bool bMenuButtonHit = mpData->maMenubuttonItem.maRect.IsInside( 
aMousePos ) && ImplHasClippedItems();
-if ( bClearHigh || bMenuButtonHit )
+if ( !HasFocus() && (bClearHigh || bMenuButtonHit) )
 {
 if ( !bMenuButtonHit && mpData->mbMenubuttonSelected )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/docs

[Ilmari Lauhakangas (via logerrit)]

 readlicense_oo/docs/readme.xrm |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a7b58f29530f35f7948d1da59d52d085ca5a9cd8
Author: Ilmari Lauhakangas 
AuthorDate: Wed Dec 18 20:14:41 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Dec 20 04:26:46 2019 +0100

Point to the right readme

Part of Redmine issue 2556

Change-Id: I4bc21162d10170caff6ee44330747a698f7f6b41
Reviewed-on: https://gerrit.libreoffice.org/85423
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/readlicense_oo/docs/readme.xrm b/readlicense_oo/docs/readme.xrm
index 7deecb6bca3a..a7ccf388fbca 100644
--- a/readlicense_oo/docs/readme.xrm
+++ b/readlicense_oo/docs/readme.xrm
@@ -17,7 +17,7 @@


${PRODUCTNAME} 
${PRODUCTVERSION} ReadMe
-   For the latest 
updates to this readme file, see https://www.libreoffice.org/welcome/readme.html;>https://www.libreoffice.org/welcome/readme.html
+   For the latest 
updates to this readme file, see https://git.libreoffice.org/core/tree/master/README.md;>https://git.libreoffice.org/core/tree/master/README.md
This file contains 
important information about the ${PRODUCTNAME} software. You are recommended to 
read this information very carefully before starting installation.
The ${PRODUCTNAME} 
community is responsible for the development of this product, and invites you 
to consider participating as a community member. If you are a new user, you can 
visit the ${PRODUCTNAME} site, where you will find lots of information about 
the ${PRODUCTNAME} project and the communities that exist around it. Go to https://www.libreoffice.org/;>https://www.libreoffice.org/.
Is ${PRODUCTNAME} Really 
Free for Any User?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129508] New: Severe clipboard issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129508

Bug ID: 129508
   Summary: Severe clipboard issues
   Product: LibreOffice
   Version: 6.3.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: i...@billiotenglish.com

This bug affects Writer, Draw, Calc, and Impress.
This bug affects BOTH LO 6.3 and 6.2 on Ubuntu 19.10. Tested and confirmed on
multiple machines.
This bug affects only 6.3 and not 6.2 on Ubuntu 18.04. Tested and confirmed on
multiple machines. 
This bug affects only 6.3 and not 6.2 on Windows. Tested and confirmed and
confirmed on multiple machines.

How bug works:
Copy something. Paste it somewhere. The first time will be fine. 
Copy a second thing. Attempt to paste it. 

Expected result: the second item will be pasted correctly. 

What actually happens: 
1: nothing
2: the first thing is pasted again as if the second thing were not copied
3: when the first thing was a picture or other graphical element it will paste
the first again but it will be messed up.  Example, a textbox with text in it
will become just a blue square.  Several pictures or shapes copied as a group
will be pasted as a broken blue thing that can't be edited. Tables will paste
as blue squares that again can't be entered or edited.  

On Ubuntu 19.10 using Libreoffice 6.2 these bugs can be sometimes avoided by
exclusively using keyboard shortcuts and not the right click on the mouse or
drop down menu from edit in the software.  Any mixing of keyboard shortcuts
with either mouse right click menu or dropdown menu will almost always cause
the bug. Right clicking with the mouse or using the drop down menu will almost
always cause the bug but perhaps a little less often than mixing. Exclusively
using keyboard shortcuts doesn't work with LO 6.3 on either Ubuntu or Windows
but will seem to fix the problem on Ubuntu using 6.2. 

Another way to get around the problem in 6.3 is copy every thing that needs to
be pasted two or three times. 

Example: Copy item one and then paste will work fine. Copy item two. Attempt to
paste will cause either nothing to happen, item one to be pasted a second time,
or a very broken version of item one to be pasted that can potentially corrupt
the save file. 

New pattern (which isn't friendly to office workers): Copy item one and paste.
Item 1 will paste just fine. Copy item 2. Then copy item 2 a second time. Just
to be sure, copy item 2 a third time. Then paste item 2 and finally item 2 will
paste correctly. Repeat multiple copies before pasting for EVERY SINGLE THING
that needs to by copied and pasted. 

There are reports that Ubuntu 19.10 is having copy and paste issues with
multiple applications such as Thunderbird mail and firefox browswer. The
testing I have done shows that the only application affected by this particular
bug is Libreoffice. On the machines I take care of Thunderbird and Firefox both
work fine on 19.10 with no copy paste related issues. Also, this bug in
Libreoffice 6.3 affects not only Ubuntu 19.10 but also 18.04 and Windows 10. On
both 18.04 and Windows 10 using LO 6.2 the bug is not present but on both
systems using LO 6.3 the bug is present. In Ubuntu 19.10 the bug is present in
both 6.2 and 6.3. 

I hope that gives someone enough information to begin to track down the bug and
get it fixed. Libreoffice is by far the best office software for our workloads
and I'd like to be able to ask my staff to use it with confidence.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129501] Options: No possible to change separator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129501

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Works for me with:
Version: 6.5.0.0.alpha0+ (x64)
Build ID: 42a1a1c6b91907f81e15066ffab219411f18c4db
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win; 
Locale: es-ES (es_ES); UI-Language: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
Bug 102847 depends on bug 78840, which changed state.

Bug 78840 Summary: Add the regular expression (?ismwx-ismwx: ... ) Flag 
settings. Evaluate parenthesized expression with specifics flags enabled or 
-disabled.  To have a case sensitive mode in functions using regular 
expressions.
https://bugs.documentfoundation.org/show_bug.cgi?id=78840

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78840] Add the regular expression (?ismwx-ismwx: ... ) Flag settings. Evaluate parenthesized expression with specifics flags enabled or -disabled. To have a case sensitive mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78840

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #5 from m.a.riosv  ---
Thanks for the hints Mike.
I use REGEX function, in which, (?i) can be used in the regex pattern to change
sensitive case as default.
The count can be done with REGEX() but long from to be easy, as I know not
inside COUNTIF, at least SUMPRODUCT or a matrix, and some more function to
analyze the REGEX result. 

I don't like the situation, the same regex pattern should work equal every
where on the whole LibreOffice. But here we are and as Eike commented in
tdf#113977 it's hard to change, specially by backward incompatibilities.
Of course I don't like new options, we have already a lot of them, and many
users don't expend neither a minute to review them, how the world goes.

Sure there more needed enhancements to develop, so I think it's better for now 
to close as wontfix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96592] Thunderbird Addressbook deleted records not reflected in Base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96592

--- Comment #13 from b...@the-kirbys.org.uk ---
Not quite sure how to fill one of these comments out (e.g. what status it
should have - so left as NEW), but I can confirm that deleted records from the
Thunderbird AddressBook still show up in the Base database created when
generating labels from a mailing list.
I am using
Version: 6.2.8.2 (x64)
Build ID: f82ddfca21ebc1e222a662a32b25c0c9d20169ee
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129473] [Feature Request] Make a keyboard shortcut to highlight text (similar to CTRL+ALT+H in MS Office)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129473

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from sdc.bla...@youmail.dk ---
I believe this request is the same as bug #34804.  If not, then please reopen.

*** This bug has been marked as a duplicate of bug 34804 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34804

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 CC||amanda.l.ha...@gmail.com

--- Comment #37 from sdc.bla...@youmail.dk ---
*** Bug 129473 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89297] Header, footer and page number missing on second page when saved as docx (continuous section breaks enhancement request)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89297

Xisco Faulí  changed:

   What|Removed |Added

 CC||michael.st...@cib.de

--- Comment #18 from Xisco Faulí  ---
Still reproducible in

Version: 6.5.0.0.alpha0+
Build ID: 02b24d77476f93887691dde564351d6f8b770b8f
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Michael S, I thought you might be interested in this issue, after your recent
improvements done to loss headers <
https://cgit.freedesktop.org/libreoffice/core/commit/?id=08f13ab85b5c65b5dc8adfa15918fb3e426fcc3c
>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89297] Header, footer and page number missing on second page when saved as docx (continuous section breaks enhancement request)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89297

--- Comment #17 from Xisco Faulí  ---
Still reproducible in

Version: 6.5.0.0.alpha0+
Build ID: 02b24d77476f93887691dde564351d6f8b770b8f
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Michael S, I thought you might be interested in this issue, after your recent
improvements done to loss headers <
https://cgit.freedesktop.org/libreoffice/core/commit/?id=08f13ab85b5c65b5dc8adfa15918fb3e426fcc3c
>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105192] FILEOPEN: DOCX: Header is gone and left section is in all pages (continuous break combined with w:br)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105192

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED
 CC||michael.st...@cib.de

--- Comment #6 from Xisco Faulí  ---
Fixed by 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=08f13ab85b5c65b5dc8adfa15918fb3e426fcc3c

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: writerfilter/CppunitTest_writerfilter_dmapper.mk writerfilter/Module_writerfilter.mk writerfilter/qa writerfilter/source

[Miklos Vajna (via logerrit)]

 writerfilter/CppunitTest_writerfilter_dmapper.mk |   
48 ++
 writerfilter/Module_writerfilter.mk  |
1 
 writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx|   
76 ++
 writerfilter/qa/cppunittests/dmapper/data/1cell-insidev-rightborder.docx 
|binary
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |
3 
 5 files changed, 127 insertions(+), 1 deletion(-)

New commits:
commit fd92740a86ab8e71e77d947d1d7dabc51a8d0794
Author: Miklos Vajna 
AuthorDate: Thu Dec 19 17:54:08 2019 +0100
Commit: Miklos Vajna 
CommitDate: Fri Dec 20 00:32:35 2019 +0100

DOCX table import: fix interaction of 1-cell rows and "inside" vertical 
borders

The interesting part of the bugdoc was:

- table style wants visible borders
- table direct formatting clears left and right borders
- 1st row of the table has 1 cell (2 cells in fact, but they are
  merged)

Fix the "inside" vertical border handling, so that the first cell gets
these vertical borders as a right border only in case there are multiple
cells.

Change-Id: Id847109ecfa95d1745abe62ddf36c4936b730855
Reviewed-on: https://gerrit.libreoffice.org/85536
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/writerfilter/CppunitTest_writerfilter_dmapper.mk 
b/writerfilter/CppunitTest_writerfilter_dmapper.mk
new file mode 100644
index ..fbb302297c94
--- /dev/null
+++ b/writerfilter/CppunitTest_writerfilter_dmapper.mk
@@ -0,0 +1,48 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,writerfilter_dmapper))
+
+$(eval $(call gb_CppunitTest_use_externals,writerfilter_dmapper,\
+   boost_headers \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,writerfilter_dmapper, \
+writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,writerfilter_dmapper, \
+comphelper \
+cppu \
+oox \
+sal \
+test \
+unotest \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,writerfilter_dmapper))
+
+$(eval $(call gb_CppunitTest_use_ure,writerfilter_dmapper))
+$(eval $(call gb_CppunitTest_use_vcl,writerfilter_dmapper))
+
+$(eval $(call gb_CppunitTest_use_rdb,writerfilter_dmapper,services))
+
+$(eval $(call gb_CppunitTest_use_custom_headers,writerfilter_dmapper,\
+   officecfg/registry \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,writerfilter_dmapper))
+
+# we need to explicitly depend on library writerfilter because it is not 
implied
+# by a link relation
+$(call gb_CppunitTest_get_target,writerfilter_dmapper) : $(call 
gb_Library_get_target,writerfilter)
+
+# vim: set noet sw=4 ts=4:
diff --git a/writerfilter/Module_writerfilter.mk 
b/writerfilter/Module_writerfilter.mk
index 516a4832f340..34b75ee9d54d 100644
--- a/writerfilter/Module_writerfilter.mk
+++ b/writerfilter/Module_writerfilter.mk
@@ -17,6 +17,7 @@ $(eval $(call gb_Module_add_targets,writerfilter,\
 $(eval $(call gb_Module_add_slowcheck_targets,writerfilter,\
 CppunitTest_writerfilter_filters_test \
 CppunitTest_writerfilter_misc \
+CppunitTest_writerfilter_dmapper \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx 
b/writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx
new file mode 100644
index ..c3b52060646b
--- /dev/null
+++ b/writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx
@@ -0,0 +1,76 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+using namespace ::com::sun::star;
+
+namespace
+{
+/// Tests for writerfilter/source/dmapper/DomainMapperTableHandler.cxx.
+class Test : public test::BootstrapFixture, public unotest::MacrosTest
+{
+private:
+uno::Reference mxComponentContext;
+uno::Reference mxComponent;
+
+public:
+void setUp() override;
+void tearDown() override;
+uno::Reference& getComponent() { return mxComponent; }
+};
+
+void Test::setUp()
+{
+test::BootstrapFixture::setUp();
+
+

[Libreoffice-bugs] [Bug 127131] CPU to 100% when LibreOffice Calc is idle and has a Calc-document open...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127131

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||7344

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127344] Idle LibreOffice consumes 100% CPU on i386

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127344

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||7131

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116399] Sending a print job for a 400 paged document is rather slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116399

Xisco Faulí  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #15 from Xisco Faulí  ---
I do believe this might have the same root cause as bug 116400.
@Julien, would it be possible to have a perf chart so we can compare both ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129507] Erase Ink on Slide does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129507

--- Comment #1 from Marc Rochkind  ---
Also, there should be a way to erase all ink from all slides. It's too tedious
(even if it worked) to deal with each slide by itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129507] New: Erase Ink on Slide does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129507

Bug ID: 129507
   Summary: Erase Ink on Slide does not work
   Product: LibreOffice
   Version: 6.3.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rochk...@basepath.com

"Mouse Pointer as Pen" draws, but ink is saved along with file. This wouldn't
be a disaster, except that "Erase All Ink on Slide" erases the ink only on that
particular display of the slide. If you go forward and then back, the ink is
still there. So, there is no way to erase the ink.

What's more, with a lot of ink, saving and loading are unacceptably slow.

Not saving ink should be the default, with an option to save it. Erasing ink
should be fixed so that it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129499] Basic 'long integer color value' help page has a weird layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129499

--- Comment #2 from V Stuart Foote  ---
or should it maybe be an ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129499] Basic 'long integer color value' help page has a weird layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129499

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=84
   ||675
 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Confirmed, just the looks like  to the "long integer color
value" is not closed correctly in the XHP, so picks up other shared elements
from 0003.xhp

https://opengrok.libreoffice.org/xref/help/source/text/sbasic/shared/03010305.xhp?r=75cf3186#34

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122218

--- Comment #125 from Aron Budea  ---
(In reply to steve -_- from comment #119)
> Once identified what caused the much improved situation I think this can be
> closed and remaining issues should be filed as new bugs as those need
> different fixes. But let's wait what QA / dev department has to say about
> this.
I'd assume systems that can be used to reproduce this bug are extremely scarce
in the QA / dev department.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116399] Sending a print job for a 400 paged document is rather slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116399

--- Comment #14 from Telesto  ---
(In reply to Buovjaga from comment #13)
> (In reply to Telesto from comment #12)
> > Same reason I created all those reports and duped them to bug 112989. The
> > new text layout engine removed the shortcuts for latin script which causing
> > a regression from User POV. Printing and exporting Latin documents is
> > terrible slow compared to LibreOffice 5.3 with the Old engine
> 
> But why disagree with duping to bug 116400?

Valid point. Mainly because main bug report got closed as fixed and Xisco asked
to check the duplicates and set it to unconfirmed if still present. 

And bug 116400 comment 0 is talking about a difference between 6.0.0.0.alpha0
and LibreOffice 6.0.2.1. which is clearly not the case. 

---
The performance is still major problem, IMHO. Text layouting quite fundamental
for text editor. The current implementation is immensely expensive for
productivity Waiting time (PDF export/ printing), costs (electricity) and the
environment. Still hoping for a tender addressing this

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129506] Copy/Paste or Cut/Paste unpredictable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129506

andrehasek...@netscape.net changed:

   What|Removed |Added

 CC||andrehasek...@netscape.net

--- Comment #1 from andrehasek...@netscape.net ---
Created attachment 156682
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156682=edit
Any LibreOffice Writer document with text and images

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129506] New: Copy/Paste or Cut/Paste unpredictable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129506

Bug ID: 129506
   Summary: Copy/Paste or Cut/Paste unpredictable
   Product: LibreOffice
   Version: 6.2.8.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: andrehasek...@netscape.net

Description:
This is a continuation of e.g. bugs 57147, 128853, 129291, but here I consider
only Copy/Paste or Cut/Paste within the same LibreOffice Writer document.

LibreOffice Still Writer, Version 6.2.8.2, running under ArchLinux (LibreOffice
Arch Linux Build ID: 6.2.8-3).
LibreOffice Fresh Writer, Version 6.3.4.2.0+ running under Arch Linux
distribution (LibreOffice Arch Linux Build ID: 6.3.4-1).

It is completely unpredictable when Copy/Paste or Cut/Paste succeeds or fails,
but in any case, after a few attempts it definitely fails. So, below I will
suggest a procedure, but you may have to repeat parts of the procedure before
you see that the Copy/Paste or Cut/Paste fails.

Consider the attached document.

Let's start with a piece of text.

Copy/Paste or Cut/Paste a piece of text. For a document freshly loaded from
disk, this usually succeeds.

Now, either save or don't save the document (eventually, please try both
possibilities).

Then, Copy/Paste or Cut/Paste another piece of text. Usually, upon this second
paste you will see that not the piece of text you think just copied or cut to
the clipboard, but instead, the previously pasted text is now pasted again.
This erroneous second paste occurs rather consistently, but otherwise please
try a third piece of text.

Do the same with images and frames. Please, primarily do the Cut/Paste because
that is what I normally do.

When the Paste goes wrong with images and frames is even less predictable, but
please try a few times with different images and frames (with me, the problem
occurs after I Cut/Paste an image, save the document and and then Cut/Paste
another image, but sometimes the paste failure occurs upon a third Cut/Paste).

This is hopelessly irritating when you do this sort of work in a production
environment. In my environment I have to do several Cut/Pastes of text as well
as images within the same document.

The issue exists for a while now. Sorry, I can't say when I first saw it. You
live with it, until your frustration drives you write a bug report. Does not
occur with an old LibreOffice 5 running under Windows XP.

If you think it has something to do with the particular document appended to
this bug report, please let me know, I will send you other documents.

Steps to Reproduce:
1.See description above
2.
3.

Actual Results:
See description above

Expected Results:
Copy and/or Paste does not work.


Reproducible: Always


User Profile Reset: No



Additional Info:
Attached document. Apparently I can only append the document as an update to
this bug report. Will do that right away.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129505] Adding "translated" image?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129505

--- Comment #1 from Kolbjørn Stuestøl  ---
Created attachment 156681
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156681=edit
The translated image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128079] Still unsolved: Error in writing sub-document content.xml

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128079

Alex Thurgood  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129505] New: Adding "translated" image?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129505

Bug ID: 129505
   Summary: Adding "translated" image?
   Product: LibreOffice
   Version: 6.3.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kolbjo...@stuestoel.no
CC: olivier.hal...@libreoffice.org

Description:
I want to add a language spesific picture (impress_remote01.png) to the
Norwegian nynorsk translation in Impress Remote: initial thumbnail
shown.
File:
LibreOffice/help/nn/text/simpress/guide/impress_remote.html?DbPAR=IMPRESS.
Tranlation file: nn/helpcontent2/source/text/simpress/guide.po, streng 268.
Hoping this is enough to place the image in the right place..

Actual Results:
Image is now in a foreign language, I want it in Norwegian nynorsk.

Expected Results:
Not tried


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129368] Text-search history is kept in system memory after document had been closed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129368

--- Comment #6 from BogdanB  ---
Try to open this page in Chrome. It is working.
And see the video.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - extras/source include/svx solenv/bin svx/source sw/source sw/uiconfig

[Caolán McNamara (via logerrit)]

 extras/source/glade/libreoffice-catalog.xml.in |4 
 include/svx/samecontentlistbox.hxx |9 -
 solenv/bin/native-code.py  |1 
 svx/source/dialog/samecontentlistbox.cxx   |   41 +-
 sw/source/uibase/sidebar/PageFooterPanel.hxx   |3 
 sw/source/uibase/sidebar/PageFormatPanel.hxx   |2 
 sw/source/uibase/sidebar/PageHeaderPanel.hxx   |3 
 sw/source/uibase/sidebar/WrapPropertyPanel.cxx |  165 -
 sw/source/uibase/sidebar/WrapPropertyPanel.hxx |   35 ++---
 sw/uiconfig/swriter/ui/sidebarwrap.ui  |   29 ++--
 10 files changed, 127 insertions(+), 165 deletions(-)

New commits:
commit 3e0c33395c50aa58baac678067024cd23698a3d6
Author: Caolán McNamara 
AuthorDate: Thu Dec 19 15:12:55 2019 +
Commit: Caolán McNamara 
CommitDate: Thu Dec 19 22:11:45 2019 +0100

weld WrapPropertyPanel

Change-Id: I8ff662fbdcd4defc3d04795e70d95df31b154e20
Reviewed-on: https://gerrit.libreoffice.org/85532
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/sidebar/PageFooterPanel.hxx 
b/sw/source/uibase/sidebar/PageFooterPanel.hxx
index 00a536a38fb5..d855af799854 100644
--- a/sw/source/uibase/sidebar/PageFooterPanel.hxx
+++ b/sw/source/uibase/sidebar/PageFooterPanel.hxx
@@ -28,9 +28,6 @@
 
 #include 
 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sw/source/uibase/sidebar/PageFormatPanel.hxx 
b/sw/source/uibase/sidebar/PageFormatPanel.hxx
index 206d478fe403..db7311593c3f 100644
--- a/sw/source/uibase/sidebar/PageFormatPanel.hxx
+++ b/sw/source/uibase/sidebar/PageFormatPanel.hxx
@@ -29,8 +29,6 @@
 #include 
 #include 
 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sw/source/uibase/sidebar/PageHeaderPanel.hxx 
b/sw/source/uibase/sidebar/PageHeaderPanel.hxx
index bed71f71b043..60132d536080 100644
--- a/sw/source/uibase/sidebar/PageHeaderPanel.hxx
+++ b/sw/source/uibase/sidebar/PageHeaderPanel.hxx
@@ -28,9 +28,6 @@
 
 #include 
 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sw/source/uibase/sidebar/WrapPropertyPanel.cxx 
b/sw/source/uibase/sidebar/WrapPropertyPanel.cxx
index b9d01096a1f7..f87afb188735 100644
--- a/sw/source/uibase/sidebar/WrapPropertyPanel.cxx
+++ b/sw/source/uibase/sidebar/WrapPropertyPanel.cxx
@@ -21,6 +21,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -29,7 +30,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -69,7 +69,7 @@ WrapPropertyPanel::WrapPropertyPanel(
 vcl::Window* pParent,
 const css::uno::Reference< css::frame::XFrame >& rxFrame,
 SfxBindings* pBindings )
-: PanelLayout(pParent, "WrapPropertyPanel", 
"modules/swriter/ui/sidebarwrap.ui", rxFrame)
+: PanelLayout(pParent, "WrapPropertyPanel", 
"modules/swriter/ui/sidebarwrap.ui", rxFrame, true)
 , mxFrame( rxFrame )
 , mpBindings(pBindings)
 // spacing
@@ -89,19 +89,19 @@ WrapPropertyPanel::WrapPropertyPanel(
 , maSwEnableContourControl(FN_FRAME_WRAP_CONTOUR, *pBindings, *this)
 , maSwLRSpacingControl(SID_ATTR_LRSPACE, *pBindings, *this)
 , maSwULSpacingControl(SID_ATTR_ULSPACE, *pBindings, *this)
+, mxRBNoWrap(m_xBuilder->weld_radio_button("buttonnone"))
+, mxRBWrapLeft(m_xBuilder->weld_radio_button("buttonbefore"))
+, mxRBWrapRight(m_xBuilder->weld_radio_button("buttonafter"))
+, mxRBWrapParallel(m_xBuilder->weld_radio_button("buttonparallel"))
+, mxRBWrapThrough(m_xBuilder->weld_radio_button("buttonthrough"))
+, mxRBIdealWrap(m_xBuilder->weld_radio_button("buttonoptimal"))
+, mxEditContour(m_xBuilder->weld_button("editcontour"))
+, mxEnableContour(m_xBuilder->weld_check_button("enablecontour"))
+, mxSpacingLB(m_xBuilder->weld_combo_box("spacingLB"))
+, mxCustomEntry(m_xBuilder->weld_label("customlabel"))
 {
-get(mpRBNoWrap, "buttonnone");
-get(mpRBWrapLeft, "buttonbefore");
-get(mpRBWrapRight, "buttonafter");
-get(mpRBWrapParallel, "buttonparallel");
-get(mpRBWrapThrough, "buttonthrough");
-get(mpRBIdealWrap, "buttonoptimal");
-get(mpEnableContour, "enablecontour");
-get(mpEditContour, "editcontour");
-get(mpSpacingLB, "spacingLB");
 FieldUnit eMetric = ::GetDfltMetric(false);
-mpSpacingLB->Init(IsInch(eMetric) ? SpacingType::SPACING_INCH : 
SpacingType::SPACING_CM);
-get(mpCustomEntry, "customlabel");
+SpacingListBox::Fill(IsInch(eMetric) ? SpacingType::SPACING_INCH : 
SpacingType::SPACING_CM, *mxSpacingLB);
 
 Initialize();
 }
@@ -113,16 +113,16 @@ WrapPropertyPanel::~WrapPropertyPanel()
 
 void WrapPropertyPanel::dispose()
 {
-mpRBNoWrap.clear();
-mpRBWrapLeft.clear();
-mpRBWrapRight.clear();
-mpRBWrapParallel.clear();
-mpRBWrapThrough.clear();
-mpRBIdealWrap.clear();
-mpEnableContour.clear();
-mpEditContour.clear();
-mpSpacingLB.clear();
-

[Libreoffice-commits] core.git: sw/source sw/uiconfig

[Caolán McNamara (via logerrit)]

 sw/source/uibase/sidebar/PageHeaderPanel.cxx |  107 ++-
 sw/source/uibase/sidebar/PageHeaderPanel.hxx |   19 ++--
 sw/uiconfig/swriter/ui/pageheaderpanel.ui|6 -
 3 files changed, 69 insertions(+), 63 deletions(-)

New commits:
commit 3f0b93eb922d865ba11c4a228a0cb3377a228c89
Author: Caolán McNamara 
AuthorDate: Thu Dec 19 14:18:45 2019 +
Commit: Caolán McNamara 
CommitDate: Thu Dec 19 22:11:04 2019 +0100

weld PageHeaderPanel

Change-Id: I261f277b54938fa04f26bcd7f8e482517695b5e5
Reviewed-on: https://gerrit.libreoffice.org/85528
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/sidebar/PageHeaderPanel.cxx 
b/sw/source/uibase/sidebar/PageHeaderPanel.cxx
index 557c27ff7428..f0c06d5511f4 100644
--- a/sw/source/uibase/sidebar/PageHeaderPanel.cxx
+++ b/sw/source/uibase/sidebar/PageHeaderPanel.cxx
@@ -56,8 +56,8 @@ VclPtr PageHeaderPanel::Create(
 
 void PageHeaderPanel::SetMarginsAndSpacingFieldUnit()
 {
-mpHeaderSpacingLB->Init(IsInch(meFUnit) ? SpacingType::SPACING_INCH : 
SpacingType::SPACING_CM);
-mpHeaderMarginPresetLB->Init(IsInch(meFUnit) ? SpacingType::MARGINS_INCH : 
SpacingType::MARGINS_CM);
+SpacingListBox::Fill(IsInch(meFUnit) ? SpacingType::SPACING_INCH : 
SpacingType::SPACING_CM, *mxHeaderSpacingLB);
+SpacingListBox::Fill(IsInch(meFUnit) ? SpacingType::MARGINS_INCH : 
SpacingType::MARGINS_CM, *mxHeaderMarginPresetLB);
 }
 
 PageHeaderPanel::PageHeaderPanel(
@@ -65,7 +65,7 @@ PageHeaderPanel::PageHeaderPanel(
 const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XFrame >& 
rxFrame,
 SfxBindings* pBindings
 ) :
-PanelLayout(pParent, "PageHeaderPanel", 
"modules/swriter/ui/pageheaderpanel.ui", rxFrame),
+PanelLayout(pParent, "PageHeaderPanel", 
"modules/swriter/ui/pageheaderpanel.ui", rxFrame, true),
 mpBindings( pBindings ),
 maHFToggleController(SID_ATTR_PAGE_HEADER, *pBindings, *this),
 maMetricController(SID_ATTR_METRIC, *pBindings,*this),
@@ -77,14 +77,13 @@ PageHeaderPanel::PageHeaderPanel(
 mpHeaderItem( new SfxBoolItem(SID_ATTR_PAGE_HEADER) ),
 mpHeaderLRMarginItem( new SvxLongLRSpaceItem(0, 0, 
SID_ATTR_PAGE_HEADER_LRMARGIN)),
 mpHeaderSpacingItem( new SvxLongULSpaceItem(0, 0, 
SID_ATTR_PAGE_HEADER_SPACING)),
-mpHeaderLayoutItem( new SfxInt16Item(SID_ATTR_PAGE_HEADER_LAYOUT))
+mpHeaderLayoutItem( new SfxInt16Item(SID_ATTR_PAGE_HEADER_LAYOUT)),
+mxHeaderToggle(m_xBuilder->weld_check_button("headertoggle")),
+mxHeaderSpacingLB(m_xBuilder->weld_combo_box("spacingpreset")),
+mxHeaderMarginPresetLB(m_xBuilder->weld_combo_box("headermarginpreset")),
+mxHeaderLayoutLB(m_xBuilder->weld_combo_box("samecontentLB")),
+mxCustomEntry(m_xBuilder->weld_label("customlabel"))
 {
-get(mpHeaderToggle, "headertoggle");
-get(mpHeaderSpacingLB, "spacingpreset");
-get(mpHeaderLayoutLB, "samecontentLB");
-get(mpHeaderMarginPresetLB, "headermarginpreset");
-get(mpCustomEntry, "customlabel");
-
 Initialize();
 }
 
@@ -95,11 +94,11 @@ PageHeaderPanel::~PageHeaderPanel()
 
 void PageHeaderPanel::dispose()
 {
-mpHeaderToggle.disposeAndClear();
-mpHeaderSpacingLB.disposeAndClear();
-mpHeaderLayoutLB.disposeAndClear();
-mpHeaderMarginPresetLB.disposeAndClear();
-mpCustomEntry.clear();
+mxHeaderToggle.reset();
+mxHeaderSpacingLB.reset();
+mxHeaderLayoutLB.reset();
+mxHeaderMarginPresetLB.reset();
+mxCustomEntry.reset();
 
 PanelLayout::dispose();
 }
@@ -118,13 +117,15 @@ FieldUnit PageHeaderPanel::GetCurrentUnit(SfxItemState 
eState, const SfxPoolItem
 
 void PageHeaderPanel::Initialize()
 {
+SameContentListBox::Fill(*mxHeaderLayoutLB);
+
 SetMarginsAndSpacingFieldUnit();
 
-aCustomEntry = mpCustomEntry->GetText();
-mpHeaderToggle->SetClickHdl( LINK(this, PageHeaderPanel, HeaderToggleHdl) 
);
-mpHeaderMarginPresetLB->SetSelectHdl( LINK(this, PageHeaderPanel, 
HeaderLRMarginHdl));
-mpHeaderSpacingLB->SetSelectHdl( LINK(this, PageHeaderPanel, 
HeaderSpacingHdl));
-mpHeaderLayoutLB->SetSelectHdl( LINK(this, PageHeaderPanel, 
HeaderLayoutHdl));
+aCustomEntry = mxCustomEntry->get_label();
+mxHeaderToggle->connect_toggled( LINK(this, PageHeaderPanel, 
HeaderToggleHdl) );
+mxHeaderMarginPresetLB->connect_changed( LINK(this, PageHeaderPanel, 
HeaderLRMarginHdl));
+mxHeaderSpacingLB->connect_changed( LINK(this, PageHeaderPanel, 
HeaderSpacingHdl));
+mxHeaderLayoutLB->connect_changed( LINK(this, PageHeaderPanel, 
HeaderLayoutHdl));
 
 mpBindings->Invalidate(SID_ATTR_METRIC);
 mpBindings->Invalidate(SID_ATTR_PAGE_HEADER);
@@ -135,17 +136,17 @@ void PageHeaderPanel::Initialize()
 
 void PageHeaderPanel::UpdateHeaderCheck()
 {
-if(mpHeaderToggle->IsChecked())
+if (mxHeaderToggle->get_active())
 {
-mpHeaderSpacingLB->Enable();
-mpHeaderLayoutLB->Enable();
-

[Libreoffice-commits] core.git: include/svx svx/source sw/source sw/uiconfig

[Caolán McNamara (via logerrit)]

 include/svx/samecontentlistbox.hxx   |4 -
 include/svx/spacinglistbox.hxx   |2 
 svx/source/dialog/samecontentlistbox.cxx |   13 +++
 svx/source/dialog/spacinglistbox.cxx |   46 +++
 sw/source/uibase/sidebar/PageFooterPanel.cxx |  107 ++-
 sw/source/uibase/sidebar/PageFooterPanel.hxx |   19 ++--
 sw/uiconfig/swriter/ui/pagefooterpanel.ui|6 -
 7 files changed, 133 insertions(+), 64 deletions(-)

New commits:
commit 0a2b871ccdc5a76f793982bae45cb251c71e4b94
Author: Caolán McNamara 
AuthorDate: Thu Dec 19 13:41:16 2019 +
Commit: Caolán McNamara 
CommitDate: Thu Dec 19 22:08:44 2019 +0100

weld PageFooterPanel

Change-Id: Ice9e7c5ab9c1085021ebb3561cfb2bd0a6727066
Reviewed-on: https://gerrit.libreoffice.org/85526
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/svx/samecontentlistbox.hxx 
b/include/svx/samecontentlistbox.hxx
index 842063125d2e..73946e2a3f35 100644
--- a/include/svx/samecontentlistbox.hxx
+++ b/include/svx/samecontentlistbox.hxx
@@ -22,14 +22,16 @@
 
 #include 
 #include 
+#include 
 
 /// Custom Widget ListBox to hold entries for SameContent setting of 
Header/Footer
 class SVX_DLLPUBLIC SameContentListBox final : public ListBox
 {
 public:
 SameContentListBox( vcl::Window* pParent );
+static void Fill(weld::ComboBox& rComboBox);
 Size GetOptimalSize() const override;
 };
 
 #endif
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svx/spacinglistbox.hxx b/include/svx/spacinglistbox.hxx
index 91e7fa18d777..df8b8c043e19 100644
--- a/include/svx/spacinglistbox.hxx
+++ b/include/svx/spacinglistbox.hxx
@@ -22,6 +22,7 @@
 
 #include 
 #include 
+#include 
 
 enum class SpacingType { SPACING_INCH, MARGINS_INCH, SPACING_CM, MARGINS_CM };
 
@@ -31,6 +32,7 @@ class SVX_DLLPUBLIC SpacingListBox final : public ListBox
 public:
 SpacingListBox( vcl::Window* pParent );
 void Init(SpacingType eType);
+static void Fill(SpacingType eType, weld::ComboBox&);
 Size GetOptimalSize() const override;
 };
 
diff --git a/svx/source/dialog/samecontentlistbox.cxx 
b/svx/source/dialog/samecontentlistbox.cxx
index 29e72df42e73..e1bd38c05669 100644
--- a/svx/source/dialog/samecontentlistbox.cxx
+++ b/svx/source/dialog/samecontentlistbox.cxx
@@ -36,6 +36,19 @@ SameContentListBox::SameContentListBox(vcl::Window* pParent)
 SelectEntryPos(0);
 }
 
+void SameContentListBox::Fill(weld::ComboBox& rComboBox)
+{
+rComboBox.clear();
+for (size_t i = 0; i < SAL_N_ELEMENTS(RID_SVXSTRARY_SAMECONTENT); ++i)
+{
+OUString aStr = SvxResId(RID_SVXSTRARY_SAMECONTENT[i].first);
+sal_uInt32 nData = RID_SVXSTRARY_SAMECONTENT[i].second;
+rComboBox.append(OUString::number(nData), aStr);
+}
+rComboBox.set_active(0);
+rComboBox.set_size_request(150, -1);
+}
+
 VCL_BUILDER_FACTORY(SameContentListBox);
 
 Size SameContentListBox::GetOptimalSize() const
diff --git a/svx/source/dialog/spacinglistbox.cxx 
b/svx/source/dialog/spacinglistbox.cxx
index 90654618f994..ac31393b3a2f 100644
--- a/svx/source/dialog/spacinglistbox.cxx
+++ b/svx/source/dialog/spacinglistbox.cxx
@@ -78,6 +78,52 @@ void SpacingListBox::Init(SpacingType eType)
 SelectEntryPos(nSelected);
 }
 
+void SpacingListBox::Fill(SpacingType eType, weld::ComboBox& rComboBox)
+{
+auto nSelected = rComboBox.get_active();
+if (nSelected == -1)
+nSelected = 0;
+rComboBox.clear();
+
+const LocaleDataWrapper& rLocaleData = 
Application::GetSettings().GetLocaleDataWrapper();
+OUString sSuffix;
+
+const measurement* pResources;
+switch (eType)
+{
+case SpacingType::SPACING_INCH:
+pResources = RID_SVXSTRARY_SPACING_INCH;
+sSuffix = weld::MetricSpinButton::MetricToString(FieldUnit::INCH);
+break;
+case SpacingType::MARGINS_INCH:
+pResources = RID_SVXSTRARY_MARGINS_INCH;
+sSuffix = weld::MetricSpinButton::MetricToString(FieldUnit::INCH);
+break;
+case SpacingType::SPACING_CM:
+pResources = RID_SVXSTRARY_SPACING_CM;
+sSuffix = " " + 
weld::MetricSpinButton::MetricToString(FieldUnit::CM);
+break;
+default:
+case SpacingType::MARGINS_CM:
+sSuffix = " " + 
weld::MetricSpinButton::MetricToString(FieldUnit::CM);
+pResources = RID_SVXSTRARY_MARGINS_CM;
+break;
+}
+
+while (pResources->key)
+{
+OUString sMeasurement = rLocaleData.getNum(pResources->human, 2, true, 
false) + sSuffix;
+OUString aStr = SvxResId(pResources->key).replaceFirst("%1", 
sMeasurement);
+sal_uInt32 nData = pResources->twips;
+rComboBox.append(OUString::number(nData), aStr);
+++pResources;
+}
+
+

[Libreoffice-bugs] [Bug 129504] New: Breeze dark theme does not get selected automatically

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129504

Bug ID: 129504
   Summary: Breeze dark theme does not get selected automatically
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stdc...@yandex.com

Description:
A similar issue happened to me. I set the icon theme in Plasma under GNOME/GTK
Application Style to Breeze Dark. Then, as I launched LibreOffice Draw, all the
icons on the left in the DRaw toolbar, were invisible as they were black on
very dark grey background and unter less than optimal lightning conditions, it
simply is impossible to make out the icons. I essentially had to hover the
cursor over each button to see the tooltip which would allow me to recognize
where I clicked. I had to manually go to Tools - Options - LibreOffice - View
and set the Icon style to Breeze (dark) upon whihc the icons appear perfectly
fine.
No manual selection of the dark theme should be required ifit can be inherited
from the global plasma configuration.


Steps to Reproduce:
Set Plasma Style to Breeze Dark, set Application Style > GNOME/GTK Application
Style GTK2 theseme & GTK3 theme to Breeze-Dark, set Icon theme to Breeze Dark
in Plasma's System Settings dialog.

Actual Results:
Draw will start with having its Icon style set to Breeze in Tools - Options -
View dialog which leads to terrible contrast ratios for the icons in the
program!

Expected Results:
The Icon Style in Draw shgould be set to Breeze (dark) automatically.


Reproducible: Always


User Profile Reset: No



Additional Info:

LSB Version:1.4
Distributor ID: Arch
Description:Arch Linux
Release:rolling
Codename:   n/a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source sw/uiconfig

[Caolán McNamara (via logerrit)]

 sw/source/uibase/sidebar/PageFormatPanel.cxx |  143 ++-
 sw/source/uibase/sidebar/PageFormatPanel.hxx |   18 +--
 sw/uiconfig/swriter/ui/pageformatpanel.ui|   19 +--
 3 files changed, 93 insertions(+), 87 deletions(-)

New commits:
commit cbca3beb990df9e75218e27ff0f1b563cf3a67da
Author: Caolán McNamara 
AuthorDate: Thu Dec 19 12:36:12 2019 +
Commit: Caolán McNamara 
CommitDate: Thu Dec 19 22:08:28 2019 +0100

weld PageFormatPanel

Change-Id: I98b40be22d11bee055ae321e8a93430bc69fe023
Reviewed-on: https://gerrit.libreoffice.org/85525
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/sidebar/PageFormatPanel.cxx 
b/sw/source/uibase/sidebar/PageFormatPanel.cxx
index ad2fbc21c26a..269e03cead25 100644
--- a/sw/source/uibase/sidebar/PageFormatPanel.cxx
+++ b/sw/source/uibase/sidebar/PageFormatPanel.cxx
@@ -63,8 +63,8 @@ VclPtr PageFormatPanel::Create(
 
 void PageFormatPanel::SetMarginFieldUnit()
 {
-auto nSelected = mpMarginSelectBox->GetSelectedEntryPos();
-mpMarginSelectBox->Clear();
+auto nSelected = mxMarginSelectBox->get_active();
+mxMarginSelectBox->clear();
 
 const LocaleDataWrapper& rLocaleData = 
Application::GetSettings().GetLocaleDataWrapper();
 if (IsInch(meFUnit))
@@ -73,7 +73,7 @@ void PageFormatPanel::SetMarginFieldUnit()
 for (size_t i = 0; i < 
SAL_N_ELEMENTS(RID_PAGEFORMATPANEL_MARGINS_INCH); ++i)
 {
 OUString sStr = 
rLocaleData.getNum(RID_PAGEFORMATPANEL_MARGINS_INCH[i].second, 2, true, false) 
+ sSuffix;
-
mpMarginSelectBox->InsertEntry(SwResId(RID_PAGEFORMATPANEL_MARGINS_INCH[i].first).replaceFirst("%1",
 sStr));
+
mxMarginSelectBox->append_text(SwResId(RID_PAGEFORMATPANEL_MARGINS_INCH[i].first).replaceFirst("%1",
 sStr));
 }
 }
 else
@@ -82,18 +82,24 @@ void PageFormatPanel::SetMarginFieldUnit()
 for (size_t i = 0; i < SAL_N_ELEMENTS(RID_PAGEFORMATPANEL_MARGINS_CM); 
++i)
 {
 OUString sStr = 
rLocaleData.getNum(RID_PAGEFORMATPANEL_MARGINS_CM[i].second, 2, true, false) + 
" " + sSuffix;
-
mpMarginSelectBox->InsertEntry(SwResId(RID_PAGEFORMATPANEL_MARGINS_CM[i].first).replaceFirst("%1",
 sStr));
+
mxMarginSelectBox->append_text(SwResId(RID_PAGEFORMATPANEL_MARGINS_CM[i].first).replaceFirst("%1",
 sStr));
 }
 }
-mpMarginSelectBox->SelectEntryPos(nSelected);
+mxMarginSelectBox->set_active(nSelected);
 }
 
 PageFormatPanel::PageFormatPanel(
 vcl::Window* pParent,
 const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XFrame >& 
rxFrame,
 SfxBindings* pBindings) :
-PanelLayout(pParent, "PageFormatPanel", 
"modules/swriter/ui/pageformatpanel.ui", rxFrame),
+PanelLayout(pParent, "PageFormatPanel", 
"modules/swriter/ui/pageformatpanel.ui", rxFrame, true),
 mpBindings( pBindings ),
+mxPaperSizeBox(new 
SvxPaperSizeListBox(m_xBuilder->weld_combo_box("papersize"))),
+mxPaperWidth(new 
RelativeField(m_xBuilder->weld_metric_spin_button("paperwidth", 
FieldUnit::CM))),
+mxPaperHeight(new 
RelativeField(m_xBuilder->weld_metric_spin_button("paperheight", 
FieldUnit::CM))),
+mxPaperOrientation(m_xBuilder->weld_combo_box("paperorientation")),
+mxMarginSelectBox(m_xBuilder->weld_combo_box("marginLB")),
+mxCustomEntry(m_xBuilder->weld_label("customlabel")),
 maPaperSizeController(SID_ATTR_PAGE_SIZE, *pBindings, *this),
 maPaperOrientationController(SID_ATTR_PAGE, *pBindings, *this),
 maMetricController(SID_ATTR_METRIC, *pBindings,*this),
@@ -106,12 +112,6 @@ PageFormatPanel::PageFormatPanel(
 meUnit(),
 aCustomEntry()
 {
-get(mpPaperSizeBox, "papersize");
-get(mpPaperWidth, "paperwidth");
-get(mpPaperHeight, "paperheight");
-get(mpPaperOrientation, "paperorientation");
-get(mpMarginSelectBox, "marginLB");
-get(mpCustomEntry, "customlabel");
 Initialize();
 }
 
@@ -122,12 +122,12 @@ PageFormatPanel::~PageFormatPanel()
 
 void PageFormatPanel::dispose()
 {
-mpPaperSizeBox.disposeAndClear();
-mpPaperWidth.disposeAndClear();
-mpPaperHeight.disposeAndClear();
-mpPaperOrientation.disposeAndClear();
-mpMarginSelectBox.disposeAndClear();
-mpCustomEntry.clear();
+mxPaperSizeBox.reset();
+mxPaperWidth.reset();
+mxPaperHeight.reset();
+mxPaperOrientation.reset();
+mxMarginSelectBox.reset();
+mxCustomEntry.reset();
 
 maMetricController.dispose();
 maPaperOrientationController.dispose();
@@ -143,25 +143,22 @@ void PageFormatPanel::dispose()
 
 void PageFormatPanel::Initialize()
 {
-mpPaperSizeBox->FillPaperSizeEntries( PaperSizeApp::Std );
-mpPaperSizeBox->SetDropDownLineCount(6);
+mxPaperSizeBox->FillPaperSizeEntries( PaperSizeApp::Std );
 meUnit = maPaperSizeController.GetCoreMetric();
-SetFieldUnit( *mpPaperWidth, meFUnit );
-SetFieldUnit( 

[Libreoffice-commits] core.git: extensions/source include/svx include/vcl svx/source vcl/inc vcl/source vcl/unx

[Caolán McNamara (via logerrit)]

 extensions/source/propctrlr/browserline.cxx|6 
 extensions/source/propctrlr/browserline.hxx|2 
 extensions/source/propctrlr/browserlistbox.cxx |6 
 extensions/source/propctrlr/browserlistbox.hxx |3 
 extensions/source/propctrlr/browserpage.cxx|8 
 extensions/source/propctrlr/browserpage.hxx|4 
 extensions/source/propctrlr/browserview.cxx|4 
 extensions/source/propctrlr/browserview.hxx|2 
 extensions/source/propctrlr/handlerhelper.cxx  |   14 -
 extensions/source/propctrlr/handlerhelper.hxx  |2 
 extensions/source/propctrlr/propcontroller.cxx |5 
 extensions/source/propctrlr/propcontroller.hxx |1 
 extensions/source/propctrlr/propertyeditor.cxx |7 
 extensions/source/propctrlr/propertyeditor.hxx |3 
 include/svx/sidebar/PanelLayout.hxx|2 
 include/vcl/svapp.hxx  |3 
 include/vcl/sysdata.hxx|1 
 svx/source/sidebar/PanelLayout.cxx |   15 +
 vcl/inc/salinst.hxx|2 
 vcl/inc/salobj.hxx |1 
 vcl/inc/unx/gtk/gtkframe.hxx   |2 
 vcl/inc/unx/gtk/gtkinst.hxx|1 
 vcl/inc/unx/gtk/gtkobject.hxx  |   62 -
 vcl/source/app/salvtables.cxx  |7 
 vcl/source/window/builder.cxx  |2 
 vcl/source/window/stacking.cxx |   17 +
 vcl/unx/gtk3/gtk3gtkinst.cxx   |   27 ++
 vcl/unx/gtk3/gtk3gtkobject.cxx |  282 ++---
 28 files changed, 390 insertions(+), 101 deletions(-)

New commits:
commit e3a002c53a544de02e5119c5b0a2fd4f972156a8
Author: Caolán McNamara 
AuthorDate: Tue Dec 17 17:27:30 2019 +
Commit: Caolán McNamara 
CommitDate: Thu Dec 19 22:07:19 2019 +0100

get native gtk widgets in sidebars working

Change-Id: If65aef1249f54a87d7854c3fa2db4319a24a5a05
Reviewed-on: https://gerrit.libreoffice.org/85326
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extensions/source/propctrlr/browserline.cxx 
b/extensions/source/propctrlr/browserline.cxx
index 10beadbc3ba7..9b45c0c9e3f5 100644
--- a/extensions/source/propctrlr/browserline.cxx
+++ b/extensions/source/propctrlr/browserline.cxx
@@ -52,11 +52,9 @@ namespace pcr
 namespace PropertyLineElement = 
::com::sun::star::inspection::PropertyLineElement;
 
 OBrowserLine::OBrowserLine(const OUString& rEntryName, weld::Container* 
pParent, weld::SizeGroup* pLabelGroup,
-   weld::Container* pInitialControlParent, bool 
bInterimBuilder)
+   weld::Container* pInitialControlParent)
 : m_sEntryName(rEntryName)
-, m_xBuilder(bInterimBuilder
- ? Application::CreateInterimBuilder(pParent, 
"modules/spropctrlr/ui/browserline.ui")
- : Application::CreateBuilder(pParent, 
"modules/spropctrlr/ui/browserline.ui"))
+, m_xBuilder(Application::CreateBuilder(pParent, 
"modules/spropctrlr/ui/browserline.ui"))
 , m_xContainer(m_xBuilder->weld_container("BrowserLine"))
 , m_xFtTitle(m_xBuilder->weld_label("label"))
 , m_xBrowseButton(m_xBuilder->weld_button("browse"))
diff --git a/extensions/source/propctrlr/browserline.hxx 
b/extensions/source/propctrlr/browserline.hxx
index e3e668a26bb7..cbe577e58da6 100644
--- a/extensions/source/propctrlr/browserline.hxx
+++ b/extensions/source/propctrlr/browserline.hxx
@@ -70,7 +70,7 @@ namespace pcr
 
 public:
 OBrowserLine(const OUString& rEntryName, weld::Container* pParent, 
weld::SizeGroup* pLabelGroup,
- weld::Container* pInitialControlParent, bool 
bInterimBuilder);
+ weld::Container* pInitialControlParent);
 ~OBrowserLine();
 
 void setControl( const css::uno::Reference< 
css::inspection::XPropertyControl >& rxControl );
diff --git a/extensions/source/propctrlr/browserlistbox.cxx 
b/extensions/source/propctrlr/browserlistbox.cxx
index b626731b3c4c..a50d93c6f4aa 100644
--- a/extensions/source/propctrlr/browserlistbox.cxx
+++ b/extensions/source/propctrlr/browserlistbox.cxx
@@ -298,7 +298,7 @@ namespace pcr
 }
 }
 
-OBrowserListBox::OBrowserListBox(weld::Builder& rBuilder, weld::Container* 
pContainer, bool bInterimBuilder)
+OBrowserListBox::OBrowserListBox(weld::Builder& rBuilder, weld::Container* 
pContainer)
 : m_xScrolledWindow(rBuilder.weld_scrolled_window("scrolledwindow"))
 , m_xLinesPlayground(rBuilder.weld_container("playground"))
 , m_xSizeGroup(rBuilder.create_size_group())
@@ -308,7 +308,6 @@ namespace pcr
 , m_pControlObserver( nullptr )
 , m_nTheNameSize(0)
 , m_nRowHeight(0)
-, m_bInterimBuilder(bInterimBuilder)
 , m_pControlContextImpl( new PropertyControlContext_Impl( *this ) )
 {
 

[Libreoffice-bugs] [Bug 116683] LibreOffice is unusable under Plasma's breeze-dark theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116683

Buovjaga  changed:

   What|Removed |Added

Version|6.3.4.2 release |6.0.2.1 release
 Status|REOPENED|RESOLVED
  Component|Draw|LibreOffice
 Resolution|--- |NOTABUG

--- Comment #18 from Buovjaga  ---
stdcerr: please open a new report. Include the text in your Help - About (it
can be selected, copied & pasted)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112286] [META] gtk3 themeing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112286
Bug 112286 depends on bug 116683, which changed state.

Bug 116683 Summary: LibreOffice is unusable under Plasma's breeze-dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=116683

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116683] LibreOffice is unusable under Plasma's breeze-dark theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116683

stdcerr  changed:

   What|Removed |Added

 Resolution|NOTABUG |---
  Component|LibreOffice |Draw
 CC||stdc...@yandex.com
Version|6.0.2.1 release |6.3.4.2 release
 Status|RESOLVED|REOPENED

--- Comment #17 from stdcerr  ---
A similar issue happened to me. I set the icon theme in Plasma under GNOME/GTK
Application Style to Breeze Dark. Then, as I launched LibreOffice Draw, all the
icons on the left in the DRaw toolbar, were invisible as they were black on
very dark grey background and unter less than optimal lightning conditions, it
simply is impossible to make out the icons. I essentially had to hover the
cursor over each button to see the tooltip which would allow me to recognize
where I clicked. I had to manually go to Tools - Options - LibreOffice - View
and set the Icon style to Breeze (dark) upon whihc the icons appear perfectly
fine.
No manual selection of the dark theme should be required ifit can be inherited
from the global plasma configuration.

This is in version 6.3.4.2.0+

Steps to Reproduce:
Set Plasma Style to Breeze Dark, set Application Style > GNOME/GTK Application
Style GTK2 theseme & GTK3 theme to Breeze-Dark, set Icon theme to Breeze Dark
in Plasma's System Settings dialog.

Actual Results:  
Draw will start with having its Icon style set to Breeze in Tools - Options -
View dialog which leads to terrible contrast ratios for the icons in the
program!

Expected Results:
The Icon Style in Draw shgould be set to Breeze (dark) automatically.

Reproducible: Always

User Profile Reset: No

Additional info: 

LSB Version:1.4
Distributor ID: Arch
Description:Arch Linux
Release:rolling
Codename:   n/a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112286] [META] gtk3 themeing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112286
Bug 112286 depends on bug 116683, which changed state.

Bug 116683 Summary: LibreOffice is unusable under Plasma's breeze-dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=116683

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129138] libUEMF test EMF not displaying correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129138
Bug 129138 depends on bug 129188, which changed state.

Bug 129188 Summary: EMF+ SetTextContrast not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=129188

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 2 commits - loleaflet/po

[Pedro Pinto Silva (via logerrit)]

 loleaflet/po/ui-es.po|   54 +++--
 loleaflet/po/ui-pt_BR.po |  189 +++
 2 files changed, 159 insertions(+), 84 deletions(-)

New commits:
commit 7bfe321b9c98eb14b4675d5456e22583391d005a
Author: Pedro Pinto Silva 
AuthorDate: Wed Dec 18 23:33:21 2019 +0100
Commit: Andras Timar 
CommitDate: Thu Dec 19 21:33:26 2019 +0100

Updated pt-BR translation.

Change-Id: Ica0b354b5ca2e59cb9de7d476919439e6db35a1e
Reviewed-on: https://gerrit.libreoffice.org/85456
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/po/ui-pt_BR.po b/loleaflet/po/ui-pt_BR.po
index 6778c3b93..f895f4ddb 100644
--- a/loleaflet/po/ui-pt_BR.po
+++ b/loleaflet/po/ui-pt_BR.po
@@ -2,12 +2,11 @@
 # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
 # This file is distributed under the same license as the PACKAGE package.
 # FIRST AUTHOR , YEAR.
-#
 msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2019-12-13 12:22+0100\n"
+"POT-Creation-Date: 2019-12-18 12:26+0100\n"
 "PO-Revision-Date: 2019-12-14 18:56+\n"
 "Last-Translator: Olivier Hallot \n"
 "Language-Team: Portuguese (Brazil) 
\n"
@@ -147,7 +146,7 @@ msgstr "Memória virtual máxima para processamento de 
documentos (em MB) - some
 
 #: admin/admin.strings.js:37
 msgid "Maximum Document process stack memory (in KB) - reduce only"
-msgstr "Memória de pilha máxima para processamento de documentos (em MB) - 
somente redução"
+msgstr "Memória de pilha máxima para processamento de documentos (em KB) - 
somente redução"
 
 #: admin/admin.strings.js:38
 msgid "Maximum file size allowed to write to disk (in MB) - reduce only"
@@ -291,35 +290,47 @@ msgstr "Iniciar copiar/colar cruzado"
 
 #: src/control/ColorPicker.js:121
 msgid "No color"
-msgstr ""
+msgstr "Sem cor"
 
 #: src/control/Control.JSDialogBuilder.js:150
 msgid "Linear"
-msgstr ""
+msgstr "Linear"
 
 #: src/control/Control.JSDialogBuilder.js:153
 msgid "Axial"
-msgstr ""
+msgstr "Axial"
 
 #: src/control/Control.JSDialogBuilder.js:156
 msgid "Radial"
-msgstr ""
+msgstr "Radial"
 
 #: src/control/Control.JSDialogBuilder.js:159
-msgid "Elipsoid"
+msgid "Elipsóide"
 msgstr ""
 
 #: src/control/Control.JSDialogBuilder.js:163
 msgid "Quadratic"
-msgstr ""
+msgstr "Quadratica"
 
 #: src/control/Control.JSDialogBuilder.js:166
 msgid "Square"
-msgstr ""
+msgstr "Quadrado"
 
 #: src/control/Control.JSDialogBuilder.js:169
 msgid "Fixed size"
-msgstr ""
+msgstr "Tamanho fixo"
+
+#: src/control/Control.JSDialogBuilder.js:541
+msgid "\""
+msgstr "\""
+
+#: src/control/Control.JSDialogBuilder.js:543
+msgid "%"
+msgstr "%"
+
+#: src/control/Control.JSDialogBuilder.js:545
+msgid "°"
+msgstr "°"
 
 #: src/control/Control.JSDialogBuilder.js:734
 #: src/control/Control.Toolbar.js:1577
@@ -328,11 +339,11 @@ msgstr "Nenhum"
 
 #: src/control/Control.JSDialogBuilder.js:737
 msgid "Color"
-msgstr ""
+msgstr "Cor"
 
 #: src/control/Control.JSDialogBuilder.js:740
 msgid "Gradient"
-msgstr ""
+msgstr "Gradiente"
 
 #: src/control/Control.JSDialogBuilder.js:743
 msgid "Hatching"
@@ -340,37 +351,33 @@ msgstr ""
 
 #: src/control/Control.JSDialogBuilder.js:747
 msgid "Pattern"
-msgstr ""
+msgstr "Padrão"
 
 #: src/control/Control.JSDialogBuilder.js:880
 msgid "From"
-msgstr ""
+msgstr "De"
 
 #: src/control/Control.JSDialogBuilder.js:883
 msgid "To"
-msgstr ""
+msgstr "Para"
 
 #: src/control/Control.JSDialogBuilder.js:1014
-#, fuzzy
-#| msgid "Font"
 msgid "Font Name"
 msgstr "Fonte"
 
 #: src/control/Control.JSDialogBuilder.js:1016
-#, fuzzy
-#| msgid "Not Signed"
 msgid "Font Size"
-msgstr "Não assinado"
+msgstr "Tamanho de Fonte"
 
-#: src/control/Control.JSDialogBuilder.js:1468
+#: src/control/Control.JSDialogBuilder.js:1479
 msgid "Rows"
-msgstr ""
+msgstr "Linhas"
 
-#: src/control/Control.JSDialogBuilder.js:1469
+#: src/control/Control.JSDialogBuilder.js:1480
 msgid "Columns"
-msgstr ""
+msgstr "Colunas"
 
-#: src/control/Control.JSDialogBuilder.js:1489
+#: src/control/Control.JSDialogBuilder.js:1500
 #: src/control/Control.Menubar.js:615 src/control/Control.Menubar.js:666
 #: src/control/Control.Toolbar.js:957
 msgid "Insert table"
@@ -471,7 +478,7 @@ msgstr "Orientação do texto"
 #: src/control/Control.Menubar.js:239 src/control/Control.Menubar.js:338
 #: src/control/Control.Menubar.js:453
 msgid "Online Help"
-msgstr ""
+msgstr "Ajuda Online"
 
 #: src/control/Control.Menubar.js:240 src/control/Control.Menubar.js:339
 #: src/control/Control.Menubar.js:454
@@ -504,7 +511,7 @@ msgstr "Apresentação PowerPoint (.pptx)"
 #: src/control/Control.Menubar.js:329 src/control/Control.Menubar.js:544
 #: src/control/Control.Toolbar.js:
 msgid "Fullscreen presentation"
-msgstr "Apresentação de slide"
+msgstr "Apresentação em tela cheia"
 
 #: src/control/Control.Menubar.js:354