[Libreoffice-bugs] [Bug 130065] PDF export: need option to export without embedded font
https://bugs.documentfoundation.org/show_bug.cgi?id=130065 Timur changed: What|Removed |Added Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Timur --- Explanation is not sufficient. Please explain current situation, what is embedded, how much is it in size, is is possible to make PDF without fonts, did you search other bugs. So far, WontFix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131840] New: Changes to an embedded chart's Data Series format (color) not visible outside edit
https://bugs.documentfoundation.org/show_bug.cgi?id=131840 Bug ID: 131840 Summary: Changes to an embedded chart's Data Series format (color) not visible outside edit Product: LibreOffice Version: 6.3.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: windm...@gmail.com Description: Changes to chart format are not showing up in Calc outside of Chart edit mode. Steps to Reproduce: I created a line chart in a spreadsheet based on several columns of data. I then switched to edit mode and modified the color of the chart area, and then modified the format (color, to be specific) of several data series independently. In between each format change, I transitioned into and out of 'edit' mode on the chart several times to view the results of my work in the larger document. At some point, the color changes to the chart lines stopped being updated. I now have a chart that has one set of line colors in edit mode, but exhibits an entirely different set of colors when I leave chart edit mode. The old incorrect colors show up if I try to "Export as Image". Actual Results: Edit mode shows different colors for lines vs outside edit mode Expected Results: Editing a chart and not editing a chart should both display the same colors Reproducible: Didn't try User Profile Reset: No Additional Info: Version: 6.3.5.2 (x64) Build ID: dd0751754f11728f69b42ee2af66670068624673 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-CA (en_CA); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84542] can't open a Writer document at last modified page
https://bugs.documentfoundation.org/show_bug.cgi?id=84542 --- Comment #5 from Luca Wemyss --- GIVEN this age of political correctness, it's a source of amazement and fury to me that my condition is not recognised. Just about every other weakness of which it's possible to conceive seems to have its lobby group, organisation, support group, monthly magazine, or what have you. There's International Chronic Fatigue Syndrome Day, International Sleep Apnoea Day (surely "Sleep Apnoea Night" would make more sense), International Coeliac Day, International days for allergies to this, to that...Yet my affliction which is as debilitating, inconvenient and restrictive goes completely unrecognised. Not only in an official sense, but even as far as gaining a modicum of sympathy from my peers. I can guarantee if I went to anyone, even those people that would explode in a saccharine burst of sympathy towards a sufferer from peanut allergies or lactose intolerance, expecting compassion and understanding I'd draw a complete blank. Which is why, I suppose, I keep this journal. At least it gives me some chance to vent.My name is Didi Truelove. Not my real name, but it will do. And I am a natural submissive.All right, I think I can guess my reader's reaction here. Are, you're into that lifestyle, are you? Chains, whips, tight leather pants. A secret underground dungeon with steel rings set into the walls. A library containing the complete works of John Norman, along with a well-thumbed copy of "The Story Of O." Brass-studded leather collars, cats o'nine tails. Oohhh, kinky, kinky...No, no, no, no, no, no, no!Let me be clear here, my philosophy is one of complete "live and let live." The twilight worlds of Doms, Dommes, subs, slaves, switches and kajirae may well be a complete mystery to me, but whatever floats your boat. If you chose that way of living, all well and good.But I didn't. It's not a matter of going to clubs to get my rocks off, or playing cute little games on Saturday nights to spoice up my love life. If there existed a medication to make my condition go away, I'd swallow the lot, packet as well. Did you get the qualifying word in the description of my condition? All right, let me repeat it, more slowly.Natural submissive.Get it now?No? Well, let me give you an example of what I mean?It's a warm day in mid November. I've been doing a little shopping, and I'm sitting at a table in The Imperial in Defiance Valley, just north of Edenglassie City.https://thesexygirlsinlingerie.com/pin/category/red/ I'm enjoying the air-conditioning, sipping a well-iced gin and orange, vaguely taking on the inane soap opera on the TV just above the bar. My condition has not reared its head for a couple of weeks (or perhaps more precisely I have not encountered anyone with the particular attributes that cause that head to rear) and all is generally well with my world.And then I see him.He is not especially well-muscled, not particularly tall, not overly handsome. He is dressed well enough, in a tight t-shirt, designer jeans, well polished, up-market shoes, and wears a high-quality timepiece on his wrist. His hair is a dark brown, his eyes a deep blue. He is well tanned, yet not darkly so. He is drinking a lager, just the common or garden kind, a Stela Artois I think.And I know.My condition is not, you see, one that is triggered just by any man. If it were so, I would be unable to function in normal life https://thelingeriestockings.com/pin/category/teen/ . Often weeks, or even months, pass where you would never know about my affliction. Like being bipolar, there are fluctuations, currents, natural rhythms.It is not even a specific type of man that triggers it. If this were the case, I could simply avoid such places where such men are to be found. I could peep into places, see that such a man was there, and duck quickly out again.It is not, however, a matter of physical type. Men able to take advantage of my condition might be well-muscled or puny, obese or skeletal, short or tall, fair or dark, and of any race. I have no way of knowing, until they choose to exercise their will. Yet, somehow, they too know, presumably at an instinctive level, of my condition.They do not, of coarse, always choose to take advantage of it. Yet, men being man, so many do.He catches my eye, holds his glance for the merest second, then drops it back to the automotive magazine open before him on the table. That glance is enough.Once again, I am enslaved against my will.At this point let me describe, since it important in understanding my condition, what I am wearing.A person such as myself does not have much choice. Certain items of clothing, or styles, are out. I cannot, for example, wear pants or jeans. I have experimented with such, and been conscious, all day, that I should not be wearing these things. I feel like a normal person might if they walked around in nappies and sucking a dummy, or clothing woven of human hair, or dressed as a clown. This is
[Libreoffice-bugs] [Bug 131839] New: Hidden Character Style Doesn't Work on Chapter Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=131839 Bug ID: 131839 Summary: Hidden Character Style Doesn't Work on Chapter Numbering Product: LibreOffice Version: 6.4.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thehy...@gmail.com Description: I think this is a formatting problem. So I want heading 2, 3, and so on to have numbering with the first number is the chapter number, but I don't want the chapter number to show on heading 1. So I made a new character style and check the hidden checkbox on the font effects tab, and apply this character style to the heading 1 character style on the chapter numbering window. But it doesn't work. Steps to Reproduce: 1. Create a new character style. 2. Check hidden on the font effects tab. 3. Set the character style to a level on the chapter numbering window. Actual Results: The numbers are not hidden. Expected Results: The numbers are hidden. Reproducible: Always User Profile Reset: No Additional Info: If you do fix this, please tell me how to make the number hidden too in the table of content. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131416] [LOCALHELP] Add BASIC syntax diagrams to Help
https://bugs.documentfoundation.org/show_bug.cgi?id=131416 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131415] not possible to make "hidden" html characters visible using Tools-Options-Writer/Web-Formatting Aids
https://bugs.documentfoundation.org/show_bug.cgi?id=131415 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131388] File save fails when network document is opened on another machine
https://bugs.documentfoundation.org/show_bug.cgi?id=131388 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131425] Inconsistant behavior when changing part of a cross reference source
https://bugs.documentfoundation.org/show_bug.cgi?id=131425 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131802] LibreOffice Calc - V6.3 Print Reverts to Portrait and Cuts Off Landscape
https://bugs.documentfoundation.org/show_bug.cgi?id=131802 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131760] Commands related to styles miscategorized in customization dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=131760 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129987] It is no longer possible to copy from another program into LibreOffice under Windows 10 ver 1909?
https://bugs.documentfoundation.org/show_bug.cgi?id=129987 QA Administrators changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131802] LibreOffice Calc - V6.3 Print Reverts to Portrait and Cuts Off Landscape
https://bugs.documentfoundation.org/show_bug.cgi?id=131802 QA Administrators changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Ever confirmed|1 |0 Resolution|INSUFFICIENTDATA|--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129987] It is no longer possible to copy from another program into LibreOffice under Windows 10 ver 1909?
https://bugs.documentfoundation.org/show_bug.cgi?id=129987 --- Comment #21 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131760] Commands related to styles miscategorized in customization dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=131760 QA Administrators changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131236] junk files in debian-64 installer
https://bugs.documentfoundation.org/show_bug.cgi?id=131236 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131838] New: Enhancement : Request for adding a PDF viewer to LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=131838 Bug ID: 131838 Summary: Enhancement : Request for adding a PDF viewer to LibreOffice Product: LibreOffice Version: 6.3.5.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gprimard.m...@gmail.com Description: I’m wondering if the Document Foundation could develop and add a PDF component to LibreOffice. I mean a PDF viewer with which we can read, annotate, fill forms and manage PDF files. I know that LibreOffice can create PDF or can open and edit existing PDF. LibreOffice open PDF with Draw, but the document is always in “editor mode”. Which is not practical for just consulting a PDF. And it’s impossible to fill forms. It would be wonderful to have an open-source alternative for Adobe Reader or Acrobat. So I’m wondering if the Document Foundation team could consider working on that for a future release. (Besides, I don't know if there’s a better space for my comment/suggestion. Please, feel free to redirect me if there’s one.) Thanks for making LibreOffice alive! Actual Results: -nil- Expected Results: -nil- Reproducible: Always User Profile Reset: No Additional Info: -nil- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131837] My LibreOffice Writer RTF file takes soooo long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=131837 Diego changed: What|Removed |Added Whiteboard||perf Keywords||accessibility, filter:rtf, ||perf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131837] New: My LibreOffice Writer RTF file takes soooo long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=131837 Bug ID: 131837 Summary: My LibreOffice Writer RTF file takes s long to open Product: LibreOffice Version: 6.4.0.3 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Web Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: diegopant...@gmail.com Description: It started when I added long paragraphs in the RTF file. When I saved/closed the file it took long to save/close. now it takes about 10-30 minutes to open. I just leave it open once it is and leave it for the rest of the day, only closing it once I shut down my pc. Steps to Reproduce: 1.Open File Explorer 2.Open LibreOffice Writer RTF file Actual Results: once I double-click/open the RTF file it takes 10-30 minutes to open. the green bar loads only 3/4 full and then stays there for 10-30 minutes until it finally opens. Expected Results: When I normally open the file it takes only mere seconds to open. Reproducible: Always User Profile Reset: No Additional Info: the file size is 11.7 MB my other Writer RTF files take less time but still takes longer to open than normal. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131836] New: Ctrl-C, Ctrl-V dose not work on Lubuntu 18.04
https://bugs.documentfoundation.org/show_bug.cgi?id=131836 Bug ID: 131836 Summary: Ctrl-C, Ctrl-V dose not work on Lubuntu 18.04 Product: LibreOffice Version: 6.0.7.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: khim...@fujitsu.com Description: Ctrl-C, Ctrl-V dose not work on Lubuntu 18.04 in all time Steps to Reproduce: 1.input any cell 2.type ctrl-c 3.only "c" is input Actual Results: copy to clipboard Expected Results: only "c" is input Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125268] Wrong text highlight color when export document to doc/docx
https://bugs.documentfoundation.org/show_bug.cgi?id=125268 --- Comment #55 from Gerald Pfeifer --- (In reply to Miklos Vajna from comment #54) >> Miklos / Kendy can you add to the ESC agenda for next week ? all are welcome >> to show up & contribute there of course. > Done. Thank you. For a use case I don't think has been mentioned here, consider bug #131215 that was closed as a duplicate: I create a document in ODT all along the way, and in the last minute was asked to share as DOCX, exported, and was surprised how differently it appeared. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101211] "Previous page" and "Next page" functions in navigator not available for keyboard binding
https://bugs.documentfoundation.org/show_bug.cgi?id=101211 --- Comment #17 from Jim Raykowski --- Here is a link to a patch sent to logerrit that implements these uno commands: https://gerrit.libreoffice.org/c/core/+/91605 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 101211] "Previous page" and "Next page" functions in navigator not available for keyboard binding
https://bugs.documentfoundation.org/show_bug.cgi?id=101211 --- Comment #17 from Jim Raykowski --- Here is a link to a patch sent to logerrit that implements these uno commands: https://gerrit.libreoffice.org/c/core/+/91605 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124943] Copy to edit bar adds a suffix space, that is inconsistent with paste to cell.
https://bugs.documentfoundation.org/show_bug.cgi?id=124943 --- Comment #4 from b. --- add. observations: > Copy Ctrl+C any cell with text content; same behaviour with numerical values in 6.2.8.2 and 7.0.0.0.a0+, the blank is ommitted if you hit enter after insert, but if you continue editing you may produce content like '1 234', different behaviour with formula content in abovementioned versions, additional blank, and the formula is replaced with the value calculated in the source cell, is that intentional, did i miss any option settings, or a bug? copying the content of a cell with works fine and without add. blanks with any content, but is some more typing, -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131810] LibreOffice Writer: odts created by File > Send > Create Master Document don't open normally
https://bugs.documentfoundation.org/show_bug.cgi?id=131810 MarjaE changed: What|Removed |Added Summary|LibreOffice Writer: File > |LibreOffice Writer: odts |Send > Create Master|created by File > Send > |Document creates|Create Master Document |non-standard output |don't open normally -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131833] Character style generated from "Default style" does not honour the default in "Basic Fonts"
https://bugs.documentfoundation.org/show_bug.cgi?id=131833 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Mike Kaganski --- (In reply to R. Green from comment #0) > Expected result: The font should be Times New Roman as this is the default > in "Options > Libre Office Writer > Basic fonts". > Actual result: The font is actually Linux Libertine G, the same as the > paragraph. > > Conclusion: When generating a new character style from "Default style", the > font of the generated character style should be the same as the setting in > "Options > Libre Office Writer > Basic fonts". This is wrong. Basic character style means "no character-level formatting; use whatever is defined on paragraph level". That is how it is defined, implemented, and correct. The basic fonts options don't affect character styles, only default paragraph style. Closing NOTABUG. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131835] librelogo UITest fails with python3.8
https://bugs.documentfoundation.org/show_bug.cgi?id=131835 Rene Engelhard changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |noelgran...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131835] New: librelogo UITest fails with python3.8
https://bugs.documentfoundation.org/show_bug.cgi?id=131835 Bug ID: 131835 Summary: librelogo UITest fails with python3.8 Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r...@debian.org since https://cgit.freedesktop.org/libreoffice/core/commit/?id=8ea5a522f76dd089446e901f3cd324f98cd973e7https://cgit.freedesktop.org/libreoffice/core/commit/?id=8ea5a522f76dd089446e901f3cd324f98cd973e7 (I guess) the following happens because the test throws a warning: [build UIT] librelogo S=/home/rene/LibreOffice/git/master && I=$S/instdir && W=$S/workdir && rm -rf $W/UITest/librelogo/ && mkdir -p $W/UITest/librelogo//user/user && cp $S/qadevOOo/qa/registrymodifications.xcu $W/UITest/librelogo//user/user/ && rm -fr $W/UITest/librelogo/done.core && mkdir -p $W/UITest/librelogo/user/ && mkdir $W/UITest/librelogo/done.core && cd $W/UITest/librelogo/done.core && ( TDOC="$S/sw/qa/uitest/writer_tests/data" TEST_LIB=$W/LinkTarget/Library/libtest.so URE_BOOTSTRAP=vnd.sun.star.pathname:$I/program/fundamentalrc PYTHONPATH="$S/uitest:$S/unotest/source/python:$I/program:$S/sw/qa/uitest/librelogo/" TestUserDir="file://$W/UITest/librelogo/" PYTHONDONTWRITEBYTECODE=0 PYTHONWARNINGS=error MAX_CONCURRENCY=4 MOZILLA_CERTIFICATE_FOLDER= SAL_DISABLE_SYNCHRONOUS_PRINTER_DETECTION=1 SAL_USE_VCLPLUGIN=svp LIBO_LANG=C /usr/bin/python3 $S/uitest/test_main.py --soffice="path:$I/program/soffice" --userdir=file://$W/UITest/librelogo/user --dir=$S/sw/qa/uitest/librelogo/ 2>&1) False test_librelogo (run.LibreLogoTest) ... OfficeConnection: connecting to: uno:pipe,name=pytest027c5cb0-7518-11ea-b079-2016b9f1e514;urp;StarOffice.ComponentContext NoConnectException: sleeping... ['OnNew'] OnCreate ['OnNew'] OnStorageChanged ['OnNew'] OnTitleChanged ['OnNew'] OnFocus ['OnNew'] OnViewCreated ['OnNew'] OnPageCountChange ['OnNew'] OnLayoutFinished 1 Execution time for run.LibreLogoTest.test_librelogo: 0.417 tearDown: calling terminate()... ...done ERROR test_compile_librelogo (compile.LibreLogoCompileTest) ... OfficeConnection: connecting to: uno:pipe,name=pytest03737748-7518-11ea-b079-2016b9f1e514;urp;StarOffice.ComponentContext NoConnectException: sleeping... Execution time for compile.LibreLogoCompileTest.test_compile_librelogo: 0.050 close tearDown: calling terminate()... ...done ERROR == ERROR: test_librelogo (run.LibreLogoTest) -- Traceback (most recent call last): File "/home/rene/LibreOffice/git/master/sw/qa/uitest/librelogo/run.py", line 42, in test_librelogo xIsAlive = self.getScript("__is_alive__") File "/home/rene/LibreOffice/git/master/sw/qa/uitest/librelogo/run.py", line 29, in getScript xScript = xScriptProvider.getScript(self.LIBRELOGO_PATH %command) run.com.sun.star.script.provider.ScriptFrameworkErrorException: ProviderCache::createProvider() Error creating provider from factory. python-loader:: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses, traceback follows File "/home/rene/LibreOffice/git/master/instdir/program/pythonloader.py", line 22, in import imp File "/home/rene/LibreOffice/git/master/instdir/program/uno.py", line 356, in _uno_import return _builtin_import(name, *optargs, **kwargs) File "/usr/lib/python3.8/imp.py", line 31, in warnings.warn("the imp module is deprecated in favour of importlib; " == ERROR: test_compile_librelogo (compile.LibreLogoCompileTest) -- Traceback (most recent call last): File "/home/rene/LibreOffice/git/master/sw/qa/uitest/librelogo/compile.py", line 36, in test_compile_librelogo xCompile = self.getScript("__compil__") File "/home/rene/LibreOffice/git/master/sw/qa/uitest/librelogo/compile.py", line 30, in getScript xScript = xScriptProvider.getScript(self.LIBRELOGO_PATH %command) run.com.sun.star.script.provider.ScriptFrameworkErrorException: ProviderCache::createProvider() Error creating provider from factory. python-loader:: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses, traceback follows File "/home/rene/LibreOffice/git/master/instdir/program/pythonloader.py", line 22, in import imp File "/home/rene/LibreOffice/git/master/instdir/program/uno.py", line 356, in _uno_import return _builtin_import(name, *optargs, **kwargs) File "/usr/lib/python3.8/imp.py", line 31, in warnings.warn("the imp module is deprecated in favour of importlib; "
[Libreoffice-bugs] [Bug 131666] will not "save as" for anything
https://bugs.documentfoundation.org/show_bug.cgi?id=131666 --- Comment #2 from eisa01 --- Sounds a bit like bug #126638 ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131832] Unable to convert this single page PPTX to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=131832 --- Comment #4 from Julien Nabet --- if you can, go ahead! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Urgent - ideas for 2020 budget (was: Re: ESC meeting agenda: 2020-04-02 16:00 Berlin time)
Hi, It turns out that we don't have much time to discuss this, as the ESC decision is wanted on the budget topic already by April 20th. So if you have good ideas, please add them to the wiki now, and come to the call later today to discuss them: On Wed, Apr 01, 2020 at 04:50:24PM +0200, Miklos Vajna wrote: > + if you have good ideas, please add them to > https://wiki.documentfoundation.org/Development/Budget2020 Thanks and sorry for the rush, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: start calc if resolve fails
Ok thank you. Unfortunately my Ubuntu system has neither of these files. What part of libreoffice contains them? -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 115439] SVG-Icons should be preferred over PNG
https://bugs.documentfoundation.org/show_bug.cgi?id=115439 eisa01 changed: What|Removed |Added Blocks|130678 | Depends on||130678 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=130678 [Bug 130678] macOS: SVG icons rendered blurry -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130678] macOS: SVG icons rendered blurry
https://bugs.documentfoundation.org/show_bug.cgi?id=130678 eisa01 changed: What|Removed |Added Blocks||115439 Depends on|115439 | --- Comment #4 from eisa01 --- I don't agree, this needs to be fixed before SVG is enabled as the default, at least on macOS. The normal icons are not retina, but looks better than the blurry SVG versions I don't want us to have an oversight here, the macOS version already has too many QC issues (e.g., Catalina, the broken font-rendering in many versions etc.) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115439 [Bug 115439] SVG-Icons should be preferred over PNG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128699] macOS: LibreOffice Vanilla does not have retina toolbar icons
https://bugs.documentfoundation.org/show_bug.cgi?id=128699 --- Comment #8 from eisa01 --- Created attachment 159280 --> https://bugs.documentfoundation.org/attachment.cgi?id=159280=edit SVG rendering and settings in 7.0 nightly The theme looks good, but both the pixel version and the SVG is still "non-Retina" I tried OpenGL and Skia rendering of the SVG theme, didn't help -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131834] New: Error in invoking online help
https://bugs.documentfoundation.org/show_bug.cgi?id=131834 Bug ID: 131834 Summary: Error in invoking online help Product: LibreOffice Version: 6.4.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: valterm...@gmail.com Description: An error occurred when trying to open the integrated online help. It seems that it is invoked a help system different (the old one) than the new browser-based one. Steps to Reproduce: 1. Start LibreOffice, choose one component 2. Try to open the help through the menu Help > LibreOffice Guide or press F1 3. Actual Results: The Help interface opens and give the following error: "Object not accessible. The object cannot be accessed due to insufficient user rights." Expected Results: The Help should be displayed correctly. The Help should be open inside the predefined browser of the system (Firefox in my specific case) and not the "object". Reproducible: Always User Profile Reset: No Additional Info: Versione: 6.4.2.2 Build ID: 1:6.4.2-0ubuntu0.18.04.3 Thread CPU: 8; SO: Linux 5.3; Resa interfaccia: predefinito; VCL: kf5; Versione locale: it-IT (it_IT.UTF-8); Lingua interfaccia: it-IT Calc: threaded My system: Operating System: KDE neon Testing Edition KDE Plasma Version: 5.18.4 KDE Frameworks Version: 5.69.0 Qt Version: 5.14.1 Kernel Version: 5.3.0-46-generic OS Type: 64-bit Processors: 8 × Intel® Core™ i7-3770 CPU @ 3.40GHz Memory: 31,3 GiB -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131832] Unable to convert this single page PPTX to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=131832 --- Comment #3 from Robert --- What about testing with centos 7.4.1708 with package 6.4.2? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131833] New: Character style generated from "Default style" does not honour the default in "Basic Fonts"
https://bugs.documentfoundation.org/show_bug.cgi?id=131833 Bug ID: 131833 Summary: Character style generated from "Default style" does not honour the default in "Basic Fonts" Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: greenandpleasant2000-supp...@yahoo.co.uk Version: 6.4.1.2 (x64) Build ID: 4d224e95b98b138af42a64d84056446d09082932 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: en-GB (en_GB); UI-Language: en-GB Calc: threaded 1. Make sure that "Options > Libre Office Writer > Basic fonts" is set to the default fonts (Times, Lib Mono, Times, Times, Times). 1. Create a new default writer document. 2. Generate Lorem ipsum text. 3. Select the last paragraph and change it to the "Text body" paragraph style. Open "Text Body" paragraph style and change font to Linux Libertine G (for example). 5. Keep the cursor on the "Text Body paragraph". In "Character styles", click on "Default style" and select "New style from selection". Give the new style a name and click OK. 5. Open the new character style dialogue and inspect the Font tab. Expected result: The font should be Times New Roman as this is the default in "Options > Libre Office Writer > Basic fonts". Actual result: The font is actually Linux Libertine G, the same as the paragraph. Conclusion: When generating a new character style from "Default style", the font of the generated character style should be the same as the setting in "Options > Libre Office Writer > Basic fonts". However, at present the new character style seems to ignore this setting and adopts the font of the paragraph in which the cursor is located. (Note: Another possible issue is that if you change the font of the paragraph style "Default Style", this also changes "Options > Libre Office Writer > Basic fonts". IMV, this is wrong and the default in "Basic fonts" should only be changable in "Options".) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131832] Unable to convert this single page PPTX to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=131832 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Julien Nabet --- LO 5.0 is old, please give a try to a recent LO version. 6.3.5 is last stable LO version and there's also brand 6.4.2 On pc Debian testing x86-64 with LO Debian package 6.4.2, no pb to convert the file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131810] LibreOffice Writer: File > Send > Create Master Document creates non-standard output
https://bugs.documentfoundation.org/show_bug.cgi?id=131810 --- Comment #4 from MarjaE --- Created attachment 159279 --> https://bugs.documentfoundation.org/attachment.cgi?id=159279=edit Unexplained extra dialogue, when opening, shows folder in Calibre -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130028] TRACK CHANGES: Writer - Changes are not tracked for Format->Text menu capitalization edits (comment #14)
https://bugs.documentfoundation.org/show_bug.cgi?id=130028 eisa01 changed: What|Removed |Added Version|Inherited From OOo |6.3.1.2 release --- Comment #15 from eisa01 --- This has not been tested to occur on 3.3, so resetting version -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131810] LibreOffice Writer: File > Send > Create Master Document creates non-standard output
https://bugs.documentfoundation.org/show_bug.cgi?id=131810 --- Comment #3 from MarjaE --- And then I import into Calibre and they don't open normally any more. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - jvmfwk/plugins
jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx | 12 1 file changed, 12 insertions(+) New commits: commit 44a40091ae960a10ef88f16f04138989366017fd Author: ilhan AuthorDate: Wed Mar 25 11:18:09 2020 +0100 Commit: Thorsten Behrens CommitDate: Thu Apr 2 21:41:44 2020 +0200 tdf#131399 Update java settings after slight java version change Under linux, the version is now also checked for changes at startup of libreoffice. Change-Id: I572f718cf5afc83a70d98a6897f1d3d6877644f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91037 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit 6b6af620ff53209487a146aa3977db328c3a6300) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91405 Reviewed-by: Thorsten Behrens diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx index 128de9b352b0..4760ab629313 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx @@ -867,6 +867,18 @@ javaPluginError jfw_plugin_existJRE(const JavaInfo *pInfo, bool *exist) *exist = true; JFW_TRACE2("Java runtime library exist: " << sRuntimeLib); +// Check version +rtl::Reference aVendorInfo = getJREInfoByPath(sLocation); +if (!aVendorInfo.is()) +{ +*exist = false; +JFW_TRACE2("JRE or supported vendor not accessible at location: " << sLocation); +} +else if(pInfo->sVersion!=aVendorInfo->getVersion()) +{ +*exist = false; +JFW_TRACE2("Mismatch between version number in libreoffice settings and installed JRE: " << pInfo->sVersion <<" != " << aVendorInfo->getVersion()); +} } else if (::osl::File::E_NOENT == rc_itemRt) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - oox/source sd/qa
oox/source/ppt/pptshape.cxx |4 +++- sd/qa/unit/data/pptx/tdf131554.pptx |binary sd/qa/unit/export-tests-ooxml2.cxx | 11 +++ 3 files changed, 14 insertions(+), 1 deletion(-) New commits: commit 55d423e8f371e914c51f9aa18aacede46355b133 Author: nd101 AuthorDate: Wed Mar 25 13:17:48 2020 +0800 Commit: Thorsten Behrens CommitDate: Thu Apr 2 21:40:50 2020 +0200 tdf#131554 placeholder iteration fails to stop when a match is found Wrong placeholder is returned due to iteration not stopping when a match is found. It causes a text element position to be incorrectly set. Change-Id: I58be6825cec7a61f48b46418bdf28964c1afe4ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91023 Reviewed-by: Xisco Faulí Reviewed-by: Michael Stahl Tested-by: Jenkins Signed-off-by: Xisco Fauli Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91472 Reviewed-by: Thorsten Behrens diff --git a/oox/source/ppt/pptshape.cxx b/oox/source/ppt/pptshape.cxx index 0088c1e51673..39b0c2eb4abc 100644 --- a/oox/source/ppt/pptshape.cxx +++ b/oox/source/ppt/pptshape.cxx @@ -424,6 +424,8 @@ namespace // 3. ph with nSecondSubType and the same oSubTypeIndex // 4. ph with nSecondSubType // 5. ph with the same oSubTypeIndex +// It appears 3 and 1 has the same highest prority. + oox::drawingml::ShapePtr PPTShape::findPlaceholder( sal_Int32 nFirstSubType, sal_Int32 nSecondSubType, const OptValue< sal_Int32 >& oSubTypeIndex, std::vector< oox::drawingml::ShapePtr >& rShapes, bool bMasterOnly ) { @@ -473,7 +475,7 @@ oox::drawingml::ShapePtr PPTShape::findPlaceholder( sal_Int32 nFirstSubType, sal aChoiceShapePtr3 = aChoiceShapePtr4; } } -if (aShapePtr.get()) +if (aShapePtr.get() || aChoiceShapePtr2.get()) break; ++aRevIter; } diff --git a/sd/qa/unit/data/pptx/tdf131554.pptx b/sd/qa/unit/data/pptx/tdf131554.pptx new file mode 100644 index ..a65f423add39 Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf131554.pptx differ diff --git a/sd/qa/unit/export-tests-ooxml2.cxx b/sd/qa/unit/export-tests-ooxml2.cxx index 78452a763f01..d0ef2dac0eb7 100644 --- a/sd/qa/unit/export-tests-ooxml2.cxx +++ b/sd/qa/unit/export-tests-ooxml2.cxx @@ -182,6 +182,7 @@ public: void testTdf127372(); void testTdf127379(); void testTdf98603(); +void testTdf131554(); CPPUNIT_TEST_SUITE(SdOOXMLExportTest2); @@ -282,6 +283,7 @@ public: CPPUNIT_TEST(testTdf127372); CPPUNIT_TEST(testTdf127379); CPPUNIT_TEST(testTdf98603); +CPPUNIT_TEST(testTdf131554); CPPUNIT_TEST_SUITE_END(); @@ -2633,6 +2635,15 @@ void SdOOXMLExportTest2::testTdf98603() CPPUNIT_ASSERT_EQUAL(OUString("IL"), aLocale.Country); } +void SdOOXMLExportTest2::testTdf131554() +{ +::sd::DrawDocShellRef xDocShRef = loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/tdf131554.pptx"), PPTX); +xDocShRef = saveAndReload( xDocShRef.get(), PPTX ); +uno::Reference xShape(getShapeFromPage(1, 0, xDocShRef), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(static_cast(5622), xShape->getPosition().X); +CPPUNIT_ASSERT_EQUAL(static_cast(13251), xShape->getPosition().Y); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SdOOXMLExportTest2); CPPUNIT_PLUGIN_IMPLEMENT(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 80879] EXPORT: no means to export an entire document or selective pages as images (pngs or jpgs)
https://bugs.documentfoundation.org/show_bug.cgi?id=80879 --- Comment #9 from paulyste...@web.de --- 2 possible extensions can be modified for this problem. MultiFormatSave-Draw is not stable. 1. Export as images solution in impress and draw https://extensions.libreoffice.org/extensions/export-as-images Export all the Impress slides or Draw pages as images of JPG, PNG, GIF, BMP and TIFF format. 2. MultiFormatSave enables you to save simultaneously a document in the OpenDocument, MS Office and/or PDF formats as you choose. https://extensions.libreoffice.org/extensions/multisave-1 Draw Extension, Calc Extension, Writer Extension, Impress Extension, Fork of 2. MultiFormatSave-Draw https://extensions.libreoffice.org/extensions/multiformatsave-draw Draw Extension, Calc Extension, Writer Extension, Impress Extension Fork of MultiFormatSave supporting multisaving in Draw - into ODG, PNG, SVG and PDF. No stable release available yet. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/writer_tests/wordCount.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit f0bf741e0cda449666a9648f5bd2cef7c4d919d0 Author: Stephan Bergmann AuthorDate: Wed Apr 1 22:06:43 2020 +0200 Commit: Stephan Bergmann CommitDate: Thu Apr 2 21:32:35 2020 +0200 Run both test functions named test_word_count_interpunction_counted_tdf56975 ...by giving them different names. The first function had been hidden by the second ever since both were introduced in 5db29ca06b56bb235b0e8dfd0956715730f9cf0d "uitest-Word Count;tdf#68347 tdf#91100 tdf#58050 tdf#56975 tdf#56975" Change-Id: I6ab927b0fe0374927dacbe30fd930763cba96d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91534 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sw/qa/uitest/writer_tests/wordCount.py b/sw/qa/uitest/writer_tests/wordCount.py index 1b3d22616bb2..96ff3ea47349 100644 --- a/sw/qa/uitest/writer_tests/wordCount.py +++ b/sw/qa/uitest/writer_tests/wordCount.py @@ -125,7 +125,7 @@ class writerWordCount(UITestCase): self.ui_test.close_doc() -def test_word_count_interpunction_counted_tdf56975(self): +def test_word_count_interpunction_counted_tdf56975_a(self): self.ui_test.create_doc_in_start_center("writer") xWriterDoc = self.xUITest.getTopFocusWindow() @@ -159,7 +159,7 @@ class writerWordCount(UITestCase): self.ui_test.close_doc() -def test_word_count_interpunction_counted_tdf56975(self): +def test_word_count_interpunction_counted_tdf56975_b(self): self.ui_test.create_doc_in_start_center("writer") xWriterDoc = self.xUITest.getTopFocusWindow() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 101211] "Previous page" and "Next page" functions in navigator not available for keyboard binding
https://bugs.documentfoundation.org/show_bug.cgi?id=101211 --- Comment #16 from Jim Raykowski --- The term "physical" is used in the code for this kind of view movement [1]. .uno:PageUp and .uno:PageDown are already in use. Maybe .uno:GoToStartOfNextPageAlignTop .uno:ScrollToStartOfPrevPageAlignTop as suggested by Kenneth in Option (b)? [1] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/uiview/viewport.cxx?r=4407a035#589 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101211] "Previous page" and "Next page" functions in navigator not available for keyboard binding
https://bugs.documentfoundation.org/show_bug.cgi?id=101211 --- Comment #16 from Jim Raykowski --- The term "physical" is used in the code for this kind of view movement [1]. .uno:PageUp and .uno:PageDown are already in use. Maybe .uno:GoToStartOfNextPageAlignTop .uno:ScrollToStartOfPrevPageAlignTop as suggested by Kenneth in Option (b)? [1] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/uiview/viewport.cxx?r=4407a035#589 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: accessibility/source compilerplugins/clang include/vcl vcl/source
accessibility/source/extended/accessiblelistboxentry.cxx | 14 - compilerplugins/clang/virtualdead.py |2 compilerplugins/clang/virtualdead.results| 93 ++-- compilerplugins/clang/virtualdead.unusedparams.results | 112 +++ include/vcl/treelistbox.hxx |3 vcl/source/treelist/treelistbox.cxx | 18 -- 6 files changed, 114 insertions(+), 128 deletions(-) New commits: commit 6df92df74b68d5965ae3fbe9ce5cdc484f03ff20 Author: Noel Grandin AuthorDate: Thu Apr 2 14:38:04 2020 +0200 Commit: Noel Grandin CommitDate: Thu Apr 2 21:23:23 2020 +0200 loplugin:virtualdead Change-Id: I5698862e5890d3208bc7012b0ce5b60520797c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91571 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/accessibility/source/extended/accessiblelistboxentry.cxx b/accessibility/source/extended/accessiblelistboxentry.cxx index c5e65ee5a1d4..7b5b055f4d95 100644 --- a/accessibility/source/extended/accessiblelistboxentry.cxx +++ b/accessibility/source/extended/accessiblelistboxentry.cxx @@ -444,7 +444,7 @@ namespace accessibility SvTreeListEntry* pEntry = m_pTreeListBox->GetEntryFromPath( m_aEntryPath ); if( getAccessibleRole() == AccessibleRole::TREE_ITEM ) { -return m_pTreeListBox->GetEntryLongDescription( pEntry ); +return OUString(); } //want to count the real column number in the list box. sal_uInt16 iRealItemCount = 0; @@ -476,17 +476,7 @@ namespace accessibility EnsureIsAlive(); -OUString sRet(implGetText()); - -SvTreeListEntry* pEntry = m_pTreeListBox->GetEntryFromPath( m_aEntryPath ); - -OUString altText = m_pTreeListBox->GetEntryAltText( pEntry ); -if (!altText.isEmpty()) -{ -sRet += " " + altText; -} - -return sRet; +return implGetText(); } Reference< XAccessibleRelationSet > SAL_CALL AccessibleListBoxEntry::getAccessibleRelationSet( ) diff --git a/compilerplugins/clang/virtualdead.py b/compilerplugins/clang/virtualdead.py index eccfbd4f76e3..142743685bf4 100755 --- a/compilerplugins/clang/virtualdead.py +++ b/compilerplugins/clang/virtualdead.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/python2 import sys import re diff --git a/compilerplugins/clang/virtualdead.results b/compilerplugins/clang/virtualdead.results index 87e6431675e0..9a39282eff04 100644 --- a/compilerplugins/clang/virtualdead.results +++ b/compilerplugins/clang/virtualdead.results @@ -1,40 +1,40 @@ -basic/source/comp/codegen.cxx:464 -void OffSetAccumulator::start(const unsigned char *,) +basic/source/comp/codegen.cxx:478 +void (anonymous namespace)::OffSetAccumulator::start(const unsigned char *,) empty -basic/source/comp/codegen.cxx:476 -_Bool OffSetAccumulator::processParams() +basic/source/comp/codegen.cxx:490 +_Bool (anonymous namespace)::OffSetAccumulator::processParams() 0 -basic/source/comp/codegen.cxx:526 -_Bool BufferTransformer::processParams() +basic/source/comp/codegen.cxx:540 +_Bool (anonymous namespace)::BufferTransformer::processParams() 1 -desktop/source/deployment/registry/inc/dp_backenddb.hxx:119 -class rtl::OUString dp_registry::backend::BackendDb::getDbNSName() -"http://openoffi -include/basegfx/utils/unopolypolygon.hxx:97 -void basegfx::unotools::UnoPolyPolygon::modifying()const -empty -include/canvas/base/bitmapcanvasbase.hxx:80 +canvas/inc/base/bitmapcanvasbase.hxx:79 unsigned char canvas::BitmapCanvasBase::hasAlpha() 1 -include/canvas/base/bufferedgraphicdevicebase.hxx:108 +canvas/inc/base/bufferedgraphicdevicebase.hxx:107 void canvas::BufferedGraphicDeviceBase::destroyBuffers() empty -include/canvas/base/graphicdevicebase.hxx:235 +canvas/inc/base/graphicdevicebase.hxx:234 unsigned char canvas::GraphicDeviceBase::hasFullScreenMode() 0 -include/canvas/base/graphicdevicebase.hxx:240 +canvas/inc/base/graphicdevicebase.hxx:239 unsigned char canvas::GraphicDeviceBase::enterFullScreenMode(unsigned char,) 0 -include/canvas/base/graphicdevicebase.hxx:306 +canvas/inc/base/graphicdevicebase.hxx:305 void canvas::GraphicDeviceBase::removePropertyChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference &,) empty -include/canvas/base/graphicdevicebase.hxx:319 +canvas/inc/base/graphicdevicebase.hxx:318 void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference &,) empty +desktop/source/deployment/registry/inc/dp_backenddb.hxx:120 +class rtl::OUString dp_registry::backend::BackendDb::getDbNSName() +"http://openoffi +include/basegfx/utils/unopolypolygon.hxx:97 +void basegfx::unotools::UnoPolyPolygon::modifying()const +empty
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport10.cxx |7 +- sw/qa/extras/ooxmlexport/ooxmlexport5.cxx|5 + sw/source/filter/ww8/docxattributeoutput.cxx |7 +- sw/source/filter/ww8/docxexport.cxx | 48 +++ writerfilter/source/dmapper/DomainMapperTableHandler.cxx |3 5 files changed, 65 insertions(+), 5 deletions(-) New commits: commit 0ee0ee3eb66dadf50b3d2c6a7af9c095b26afd88 Author: Justin Luth AuthorDate: Fri Mar 13 07:14:29 2020 +0300 Commit: Thorsten Behrens CommitDate: Thu Apr 2 21:22:43 2020 +0200 tdf#131304 .docx: flag new files as MS Word 2019 native mode compatibilityMode = 15: [Word 2013/2016/2019] Up till now, documents that were exported into the docx format were treated by default as native Word 2007 format, since no compatibilityMode setting was provided. (Don't worry, we still round-trip existing older values. This patch only affects non-docx >>= .docx export.) Ultimately, this change is for the benefit of MS Word. It has no practical effect for LO. NOTE: This patch depends on previous commit 53f099c842d39266a0b4786a1af3db5628746634 which sets an appropriate value for existing .docx files. This scary change shouldn't actually be all that scary, since we already round-trip native 2019 files, without any complaint from Word or our users. The biggest change is that Word 2010 users might not be able to open NEW files perfectly. But Microsoft has already been doing that to them since 2013. By the time LO 7.0 hits stable version, it will have been months since 2010 has reached end-of-life. The vast majority of documents will still open perfectly for them. Plus, if a Word 2010 user does modify our new document, we will drop back down to their level. A nice, clear explanation of what compatibilityMode does is at howtogeek.com/256269/what-is-compatibility-mode-in-microsoft-office/ The MAIN CHANGE is that MS WORD has been DE-ACTIVATING features when it notices that it is SHARING the document with OLD_VERSION users. So Word is limiting what it will do for the BENEFIT OF THE OTHER USER while collaborating. There are a few instances where layout is affected by compatiblityMode. For example, tdf#123116 wants compat=15 so that Word will nicely layout an oversized table-row. tdf#131121 wants it too. By changing to compat=15, we can help Word take advantage of some fixes since docx 1.0, and avoid having to write new logic to export to old formats as well as new. Unfortunately, documentation on what layout changes are expected has not been identified yet. But in 7 years we should have run into most of them already... well maybe no. Change-Id: I1ce016618a680b9842fa6828c9e87cc6b677a557 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90455 Tested-by: Jenkins Reviewed-by: Miklos Vajna (cherry picked from commit f25985c55541cbbc9a4fc79e660592d3d0485196) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90920 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx index 835947da9dfb..2e870f5d016f 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx @@ -1180,13 +1180,14 @@ DECLARE_OOXMLEXPORT_TEST(testTableMarginAdjustment, "table.fodt") auto const xTable(getParagraphOrTable(1)); CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xTable, "LeftMargin")); -// currently no compatibilityMode is generated, it's only round-tripped if -// it exists in the input; if it doesn't exist, the default is "12" (old) +// Now that compatibilityMode is set to 2013's 15 (new), expect the new values, +// since LO is exporting in the NEW way now instead of the OLD way. +// This was 55 when using 2007's compatibilityMode of 12 (old) xmlDocPtr pXmlDoc = parseExport("word/document.xml"); assertXPath(pXmlDoc, "//w:tbl[1]/w:tblPr[1]/w:tblInd[1]", "type", "dxa"); -assertXPath(pXmlDoc, "//w:tbl[1]/w:tblPr[1]/w:tblInd[1]", "w", "55"); +assertXPath(pXmlDoc, "//w:tbl[1]/w:tblPr[1]/w:tblInd[1]", "w", "0"); } DECLARE_OOXMLEXPORT_TEST( testTableCellMargin, "table-cell-margin.docx" ) diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx index ee64589d0305..cc0295a36294 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx @@ -1112,6 +1112,11 @@ DECLARE_OOXMLEXPORT_TEST(tdf106843, "tdf106843.fodt") { assertXPath(pXmlSettings, "/w:settings/w:documentProtection", "edit", "trackedChanges"); assertXPath(pXmlSettings, "/w:settings/w:documentProtection", "enforcement",
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |6 ++ writerfilter/source/dmapper/SettingsTable.cxx | 17 + 2 files changed, 23 insertions(+) New commits: commit 3c92bceceea49f4a4449395ef0cf1c7d27e13d50 Author: Justin Luth AuthorDate: Thu Mar 12 21:44:57 2020 +0300 Commit: Thorsten Behrens CommitDate: Thu Apr 2 21:22:21 2020 +0200 tdf#131304 .docx: provide default compatibilityMode value When a docx is imported without specifying a compat mode, populate the appropriate compatibilityMode setting, which will be written out at save time. "12: Use word processing features specified in ECMA-376. This is the default." The immediate benefit for LO is that this will provide a cacheable result - instead of repeated lookup attempts for something that doesn't exist. Perhaps more importantly, it paves the way for allowing LO to export new documents as compatible with 2013, while leaving existing documents at their current level. Both Word and LO treat the missing compatSetting correctly as mode 12, so this should not have any affect on layout or any other compatibility aspect. Therefore I can't see any reason why it shouldn't be explicitly written. MS Word also writes it out on a round-trip. Writing it out doesn't limit us in any way either. As soon as it is in docx format, it will be treated as mode 12 anyway, so why not make it explicit? Well, I guess that since MS Word has been filling this in since 2010 at least, we could "assume" that if it is missing and has been modified in the past 5 years it was created by LO and thus treat it differently, contrary to standard. But that doesn't seem like a very good idea at all. Change-Id: If68cecc14bf4446c5ca25fd2dd6eebddf8d954a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90439 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Mike Kaganski Reviewed-by: Miklos Vajna (cherry picked from commit 53f099c842d39266a0b4786a1af3db5628746634) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90919 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx index 87795d6ba6c6..ee64589d0305 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx @@ -1122,6 +1122,12 @@ DECLARE_OOXMLEXPORT_TEST(tdf89991_revisionView, "tdf89991.docx") { assertXPath(pXmlSettings, "/w:settings/w:revisionView", "insDel", "0"); assertXPath(pXmlSettings, "/w:settings/w:revisionView", "formatting", "0"); + +// There was no compatibilityMode defined. +// 12: Use word processing features specified in ECMA-376. This is the default. +assertXPath(pXmlSettings, "/w:settings/w:compat/w:compatSetting[1]", "name", "compatibilityMode"); +assertXPath(pXmlSettings, "/w:settings/w:compat/w:compatSetting[1]", "uri", "http://schemas.microsoft.com/office/word;); +assertXPath(pXmlSettings, "/w:settings/w:compat/w:compatSetting[1]", "val", "12"); } } diff --git a/writerfilter/source/dmapper/SettingsTable.cxx b/writerfilter/source/dmapper/SettingsTable.cxx index 58399cf0a151..f875bdd70523 100644 --- a/writerfilter/source/dmapper/SettingsTable.cxx +++ b/writerfilter/source/dmapper/SettingsTable.cxx @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include "ConversionHelper.hxx" @@ -679,6 +680,22 @@ uno::Sequence const & SettingsTable::GetThemeFontLangPrope uno::Sequence SettingsTable::GetCompatSettings() const { +if ( GetWordCompatibilityMode() == -1 ) +{ +// the default value for an undefined compatibilityMode is 12 (Word 2007) +uno::Sequence aCompatSetting( comphelper::InitPropertySequence({ +{ "name", uno::Any(OUString("compatibilityMode")) }, +{ "uri", uno::Any(OUString("http://schemas.microsoft.com/office/word;)) }, +{ "val", uno::Any(OUString("12")) } //12: Use word processing features specified in ECMA-376. This is the default. +})); + +beans::PropertyValue aValue; +aValue.Name = "compatSetting"; +aValue.Value <<= aCompatSetting; + +m_pImpl->m_aCompatSettings.push_back(aValue); +} + return comphelper::containerToSequence(m_pImpl->m_aCompatSettings); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 131832] Unable to convert this single page PPTX to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=131832 --- Comment #1 from Robert --- Created attachment 159278 --> https://bugs.documentfoundation.org/attachment.cgi?id=159278=edit This is the file we were unable to convert to pdf in centos. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131832] New: Unable to convert this single page PPTX to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=131832 Bug ID: 131832 Summary: Unable to convert this single page PPTX to PDF Product: LibreOffice Version: 5.0 all versions Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robertaltmil...@chevron.com Description: Unable to convert this single page PPTX to PDF Steps to Reproduce: 1. Put this file on a centos vm running Centos Linus 7.4.1708 (Core) 2. execute the command sudo yum -y install libreoffice 3. Execute the following command 'libreoffice --headless --convert-to pdf abc123.pptx' Actual Results: It gives an error called "application error" Expected Results: We expected the command to convert the file to a pdf Reproducible: Always User Profile Reset: No Additional Info: We were able to convert this pptx file to pdf using windows. We could convert it to XML, and PPT. We then tried to convert the XML and PPT version of this file into pdf and it gave the same "application error" message. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94472] Proposal for working in documents on two positions in side by side (so vertical) panes
https://bugs.documentfoundation.org/show_bug.cgi?id=94472 --- Comment #3 from paulyste...@web.de --- mso 2016 includes this feature it is a feature of zoom. one page high max and two pages wide in german Ansicht -> mehrere Seiten translation english view -> some pages -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: ESC meeting minutes: 2020-04-02
Am 02.04.20 um 20:52 schrieb Ilmari Lauhakangas: > As you can see from this, interest in Jitsi has grown 100x during the > pandemic: https://trends.google.com/trends/explore?q=jitsi > > They are absolutely slammed with user support requests right now, so > let's give them peace to work on all these improvements. I guess the incentive to get video conferencing (VC) fixed on whatever side has now much increased, especially if you were following the Zoom debate and other VC related privacy problems and solutions; either if real or not. The old FF bug just (three days ago) got a priority boost to P1 and someone assigned. I don't think there is any need for us / me to get involved in it, except if someone wants to help fixing either FF or Jitsi stuff. Still I'll test, if chromium on Debian and Ubuntu is an alternative, if just for VC meetings. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 130712] Unusable track changes of formats saving as RTF with LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=130712 Timur changed: What|Removed |Added Summary|unusable recording changes |Unusable track changes of |saving as RTF with LO |formats saving as RTF with |Writer |LO Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130712] unusable recording changes saving as RTF with LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=130712 Timur changed: What|Removed |Added Whiteboard| QA:needsComment| Keywords||filter:rtf, ||implementationError Version|6.4.0.3 release |3.3.0 release Ever confirmed|0 |1 Summary|unusable recording changes |unusable recording changes |in rtf with LO Writer |saving as RTF with LO ||Writer Status|UNCONFIRMED |NEW OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130712] unusable recording changes in rtf with LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=130712 --- Comment #2 from Timur --- Created attachment 159277 --> https://bugs.documentfoundation.org/attachment.cgi?id=159277=edit Sample ODT OO didn't save some formatting changes in RTF. LO 3.3 does it wrong, up to 7.0+. ImplementationError. Steps: open attached ODT and save as RTF. On reopen, see numbers before bold, italic, underline, highlighted text, instead of tracked changes. I didn't find a duplicate (though hard to believe nobody noticed). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131831] New: Bad allocation crash pasting hug document as RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=131831 Bug ID: 131831 Summary: Bad allocation crash pasting hug document as RTF Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Bad allocation crash pasting hug document as RTF Steps to Reproduce: 1. Open https://cloud.libreofficechina.org/s/AHda2EyCYeKSjAb/download 2. CTRL+A CTRL+C 3. CTRL+N (new) Document 4. CTRL+SHIFT+V Paste as RTF Actual Results: Crash after a while Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.0.alpha0+ (x64) Build ID: 4501a0ba623ad61c5a4e0b807da2e96f0e4ce82c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/treelist.hxx |2 +- vcl/source/treelist/treelist.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 344a87f0bc4027825480e1c44235bd6d8d8fc2aa Author: Caolán McNamara AuthorDate: Thu Apr 2 17:17:06 2020 +0100 Commit: Caolán McNamara CommitDate: Thu Apr 2 20:57:19 2020 +0200 make SvListView::IsSelected take const arg Change-Id: I1e6d2ed5b092741499505bdfd65c6a583495204c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91594 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/include/vcl/treelist.hxx b/include/vcl/treelist.hxx index 433cd5db91f7..a6cdbe0aa60e 100644 --- a/include/vcl/treelist.hxx +++ b/include/vcl/treelist.hxx @@ -281,7 +281,7 @@ public: boolIsExpanded( SvTreeListEntry* pEntry ) const; boolIsAllExpanded( SvTreeListEntry* pEntry) const; -boolIsSelected( SvTreeListEntry* pEntry ) const; +boolIsSelected(const SvTreeListEntry* pEntry) const; voidSetEntryFocus( SvTreeListEntry* pEntry, bool bFocus ); const SvViewDataEntry* GetViewData( const SvTreeListEntry* pEntry ) const; SvViewDataEntry* GetViewData( SvTreeListEntry* pEntry ); diff --git a/vcl/source/treelist/treelist.cxx b/vcl/source/treelist/treelist.cxx index 1f16f1d1a150..2f99060ac1ea 100644 --- a/vcl/source/treelist/treelist.cxx +++ b/vcl/source/treelist/treelist.cxx @@ -1355,10 +1355,10 @@ bool SvListView::IsAllExpanded( SvTreeListEntry* pEntry ) const return true; } -bool SvListView::IsSelected( SvTreeListEntry* pEntry ) const +bool SvListView::IsSelected(const SvTreeListEntry* pEntry) const { DBG_ASSERT(pEntry,"IsExpanded:No Entry"); -SvDataTable::const_iterator itr = m_pImpl->m_DataTable.find(pEntry); +SvDataTable::const_iterator itr = m_pImpl->m_DataTable.find(const_cast(pEntry)); if (itr == m_pImpl->m_DataTable.end()) return false; return itr->second->IsSelected(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 46397] Not able to turn on/off page-background in pdf-export
https://bugs.documentfoundation.org/show_bug.cgi?id=46397 --- Comment #2 from paulyste...@web.de --- with coming dark mode and smart colors invert like in iOS or ipadOS changing background from black to white or white to black is more important. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: ESC meeting minutes: 2020-04-02
Jan-Marek Glogowski kirjoitti 2.4.2020 klo 21.40: Am 02.04.20 um 17:05 schrieb Miklos Vajna: * Test BBB for ESC meetings (Xisco) - Jitsi always problematic. Even with new adjustments ( Android app & chromium ) - Specially when many people in the call, like today - Board tested BBB in one meeting and it seems it went well - Would like to suggest the same for ESC meeting - Opinions ? + several improvements being pushed upstream as we speak (Ilmari) + people were waiting for this for years + not a great moment to change + any other instance would need somebody to admin the room (Thorsten) + anyone else has issues? (Cloph) + it’s working (Ilmari, Miklos) + mobile was problematic (Kendy) + using desktop browser now instead + massive lag sometimes (Michael M) + problems with Firefox and mobile apps (Cloph) + perhaps fixed with better VM recently (Thorsten) + it’s improving, even from Firefox (Thorsten) I've looked into this a few days ago, due to the current pandemic situation to stay in touch with my family: - https://github.com/jitsi/jitsi-meet/issues/4758 - https://bugzilla.mozilla.org/buglist.cgi?status_whiteboard_type=substring_whiteboard=jitsi-meet Main FF "bug" seems to be 5y old: https://bugzilla.mozilla.org/show_bug.cgi?id=1164187 As I understand it, FF says the feature is not needed and Jitsi says it won't implement a special solution for FF. My guess is, FF might start moving now, as video conferencing just became more important... Note that all this Firefox stuff only applies when having video calls, possibly only with screen sharing. Separately from this, the Jitsi devs are working on optimising the web UI itself to reduce load on the client side. As you can see from this, interest in Jitsi has grown 100x during the pandemic: https://trends.google.com/trends/explore?q=jitsi They are absolutely slammed with user support requests right now, so let's give them peace to work on all these improvements. Ilmari ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 131813] picture not printed completely
https://bugs.documentfoundation.org/show_bug.cgi?id=131813 --- Comment #2 from Telesto --- No issue Version: 7.0.0.0.alpha0+ (x64) Build ID: 4501a0ba623ad61c5a4e0b807da2e96f0e4ce82c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129703] specific form based sheet gets empty/invisible menu options and no mouseover comment pop-out in LO 6.4.0.1 WIN10 x64 with OpenGL (and Skia for master/6.5.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=129703 karsten.henn...@gmx.de changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #14 from karsten.henn...@gmx.de --- It works fine on Windows and Linux-platform since versions 6.4.2.1. I have closed this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: ESC meeting minutes: 2020-04-02
Am 02.04.20 um 17:05 schrieb Miklos Vajna: > * Test BBB for ESC meetings (Xisco) > - Jitsi always problematic. Even with new adjustments ( Android app & > chromium ) > - Specially when many people in the call, like today > - Board tested BBB in one meeting and it seems it went well > - Would like to suggest the same for ESC meeting > - Opinions ? > + several improvements being pushed upstream as we speak (Ilmari) > + people were waiting for this for years > + not a great moment to change > + any other instance would need somebody to admin the room (Thorsten) > + anyone else has issues? (Cloph) > + it’s working (Ilmari, Miklos) > + mobile was problematic (Kendy) > + using desktop browser now instead > + massive lag sometimes (Michael M) > + problems with Firefox and mobile apps (Cloph) > + perhaps fixed with better VM recently (Thorsten) > + it’s improving, even from Firefox (Thorsten) I've looked into this a few days ago, due to the current pandemic situation to stay in touch with my family: - https://github.com/jitsi/jitsi-meet/issues/4758 - https://bugzilla.mozilla.org/buglist.cgi?status_whiteboard_type=substring_whiteboard=jitsi-meet Main FF "bug" seems to be 5y old: https://bugzilla.mozilla.org/show_bug.cgi?id=1164187 As I understand it, FF says the feature is not needed and Jitsi says it won't implement a special solution for FF. My guess is, FF might start moving now, as video conferencing just became more important... Thanks for the BBB info. Had not seen this yet. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 131639] FILESAVE DOC: Font size changing in part of the document when I save a docx document to doc ('97-2003)
https://bugs.documentfoundation.org/show_bug.cgi?id=131639 Dieter changed: What|Removed |Added Summary|FILESAVE DOC: Font size |FILESAVE DOC: Font size |changing when I save a docx |changing in part of the |document to doc ('97-2003) |document when I save a docx ||document to doc ('97-2003) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131639] FILESAVE DOC: Font size changing when I save a docx document to doc ('97-2003)
https://bugs.documentfoundation.org/show_bug.cgi?id=131639 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Summary|Font size changing when I |FILESAVE DOC: Font size |save the document to doc|changing when I save a docx |('97-2003) |document to doc ('97-2003) CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEW Version|6.4.1.2 release |6.3.5.2 release Blocks||112681 --- Comment #4 from Dieter --- I confirm it with Version: 6.3.5.2 (x64) Build-ID: dd0751754f11728f69b42ee2af66670068624673 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded Additional information: Doesn't happen, if I use Word 2016 to save doc-file and reopen in Writer Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112681 [Bug 112681] [META] DOC (binary) character-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112681] [META] DOC (binary) character-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112681 Dieter changed: What|Removed |Added Depends on||131639 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131639 [Bug 131639] FILESAVE DOC: Font size changing when I save a docx document to doc ('97-2003) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #18 from Jan-Marek Glogowski --- I've opened bug 131830 for the missing context menu entry mentioned by Regina. Won't link it, as it's not related to this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #18 from Jan-Marek Glogowski --- I've opened bug 131830 for the missing context menu entry mentioned by Regina. Won't link it, as it's not related to this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 131830] New: No context menu entry to open closed polygons.
https://bugs.documentfoundation.org/show_bug.cgi?id=131830 Bug ID: 131830 Summary: No context menu entry to open closed polygons. Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: glo...@fbihome.de Created attachment 159276 --> https://bugs.documentfoundation.org/attachment.cgi?id=159276=edit Draw document with a single, open three point polyline While discussing bug 131758, I found there should be a context menu entry to "Open" a polygon, as the reverse action of the existing "Close object" entry. In bug 131758 comment 15, Regina provided an example document with screenshots to help me find that entry, which she is seeing on Windows. See attachment 159274. So currently I believe this is either a bug, or I'm still doing something different then Regina. I checked out the exact revision that Regina uses from the 6.5 / 7.0 linux bibisect repo (commit 0701a3a3be2f114d7ad176e7beabc7abc94cc5dc "sha:6388c578c672690fff662cb04b6a0436cd742f37"). No luck with either gen, gtk3 or kf5. So it doesn't seem to be a problem with the native menu VCL implementation in either gtk3 or kf5, as gen is also affected. I also tested a fresh profile using -env:UserInstallation without a difference. To reproduce: 1. open the attached document 2. select the polygon 3. open the context menu of the polygon and select "Close object" 4. open the context menu of the polygon and check for the toggle entry "Close object" Actual result: "Close object" entry vanishes after action 3. Expected result: "Close object" entry is a check box, doesn't vanish and is now selected. "Side bug": for whatever reason the entry is called "Close Beźier" in Regina's screenshot, even if it's a polygon from the status line. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131635] Selection rectangle persists after de-selection/selection change
https://bugs.documentfoundation.org/show_bug.cgi?id=131635 Dieter changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED --- Comment #4 from Dieter --- (In reply to Eyal Rozenberg from comment #3) > I don't have anything else I can add. Sorry. So let's close this bug. Feel free to change it back to UNCONFIRMED, if you can provide further informations that can help to reproduce it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112182] [META] Text and object selection issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112182 Bug 112182 depends on bug 131635, which changed state. Bug 131635 Summary: Selection rectangle persists after de-selection/selection change https://bugs.documentfoundation.org/show_bug.cgi?id=131635 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131812] Exporting to html doesn't preserve RTL property
https://bugs.documentfoundation.org/show_bug.cgi?id=131812 --- Comment #4 from Julien Nabet --- Don't know what to think, when I unzipped the file, I noticed that content.xml was containing this: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/core/api/Section.cxx| 32 reportdesign/source/core/sdr/PropertyForward.cxx| 92 +- reportdesign/source/core/sdr/RptObject.cxx | 222 ++--- reportdesign/source/core/sdr/UndoActions.cxx| 122 +- reportdesign/source/filter/xml/xmlAutoStyle.cxx | 36 reportdesign/source/filter/xml/xmlColumn.cxx| 76 - reportdesign/source/filter/xml/xmlControlProperty.cxx | 22 reportdesign/source/filter/xml/xmlExport.cxx| 494 +-- reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx | 20 reportdesign/source/filter/xml/xmlFixedContent.cxx | 46 - reportdesign/source/filter/xml/xmlHelper.cxx| 112 +- reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx | 66 - reportdesign/source/filter/xml/xmlSubDocument.cxx | 63 - reportdesign/source/ui/dlg/AddField.cxx | 92 +- reportdesign/source/ui/dlg/CondFormat.cxx | 22 reportdesign/source/ui/dlg/Condition.cxx| 44 reportdesign/source/ui/dlg/GroupsSorting.cxx| 238 ++--- reportdesign/source/ui/dlg/Navigator.cxx| 56 - reportdesign/source/ui/inspection/DataProviderHandler.cxx | 34 reportdesign/source/ui/inspection/GeometryHandler.cxx | 146 +-- reportdesign/source/ui/misc/RptUndo.cxx | 86 - reportdesign/source/ui/misc/statusbarcontroller.cxx | 94 +- reportdesign/source/ui/report/DesignView.cxx| 30 reportdesign/source/ui/report/ReportController.cxx | 531 +--- reportdesign/source/ui/report/ReportControllerObserver.cxx | 48 - reportdesign/source/ui/report/ReportSection.cxx | 316 +++ reportdesign/source/ui/report/ReportWindow.cxx | 50 - reportdesign/source/ui/report/SectionView.cxx | 52 - reportdesign/source/ui/report/StartMarker.cxx | 30 reportdesign/source/ui/report/ViewsWindow.cxx | 42 reportdesign/source/ui/report/dlgedfunc.cxx | 102 +- reportdesign/source/ui/report/propbrw.cxx | 30 32 files changed, 1722 insertions(+), 1724 deletions(-) New commits: commit ff7e960701ccacbd62bd2251f26561eeba8ebe8a Author: Noel Grandin AuthorDate: Thu Apr 2 12:06:45 2020 +0200 Commit: Noel Grandin CommitDate: Thu Apr 2 20:07:00 2020 +0200 loplugin:flatten in reportdesign Change-Id: I6d8b2730cede4453e7afd581cc24ed101ca6c81b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91557 Tested-by: Noel Grandin Reviewed-by: Noel Grandin diff --git a/reportdesign/source/core/api/Section.cxx b/reportdesign/source/core/api/Section.cxx index 6aa10a6acaa2..761ed63e5c67 100644 --- a/reportdesign/source/core/api/Section.cxx +++ b/reportdesign/source/core/api/Section.cxx @@ -194,22 +194,22 @@ void OSection::init() uno::Reference< report::XReportDefinition> xReport = getReportDefinition(); std::shared_ptr pModel = OReportDefinition::getSdrModel(xReport); assert(pModel && "No model set at the report definition!"); -if ( pModel ) -{ -uno::Reference const xSection(this); -SdrPage & rSdrPage(*pModel->createNewPage(xSection)); -m_xDrawPage.set(rSdrPage.getUnoPage(), uno::UNO_QUERY_THROW); -m_xDrawPage_ShapeGrouper.set(m_xDrawPage, uno::UNO_QUERY_THROW); -// apparently we may also get OReportDrawPage which doesn't support this -m_xDrawPage_FormSupplier.set(m_xDrawPage, uno::UNO_QUERY); -m_xDrawPage_Tunnel.set(m_xDrawPage, uno::UNO_QUERY_THROW); -// fdo#53872: now also exchange the XDrawPage in the SdrPage so that -// rSdrPage.getUnoPage returns this -rSdrPage.SetUnoPage(this); -// createNewPage _should_ have stored away 2 uno::References to this, -// so our ref count cannot be 1 here, so this isn't destroyed here -assert(m_refCount > 1); -} +if ( !pModel ) +return; + +uno::Reference const xSection(this); +SdrPage & rSdrPage(*pModel->createNewPage(xSection)); +m_xDrawPage.set(rSdrPage.getUnoPage(), uno::UNO_QUERY_THROW); +m_xDrawPage_ShapeGrouper.set(m_xDrawPage, uno::UNO_QUERY_THROW); +// apparently we may also get OReportDrawPage which doesn't support this +m_xDrawPage_FormSupplier.set(m_xDrawPage, uno::UNO_QUERY); +m_xDrawPage_Tunnel.set(m_xDrawPage, uno::UNO_QUERY_THROW); +// fdo#53872: now also exchange the XDrawPage in the SdrPage so that +// rSdrPage.getUnoPage returns this +rSdrPage.SetUnoPage(this); +// createNewPage _should_ have stored away 2 uno::References to this, +// so our ref count cannot be 1 here, so this isn't destroyed here +assert(m_refCount > 1); } // XSection diff --git a/reportdesign/source/core/sdr/PropertyForward.cxx
[Libreoffice-commits] core.git: sal/osl sal/rtl
sal/osl/all/log.cxx | 57 sal/osl/unx/file_path_helper.cxx | 26 +++ sal/osl/unx/process.cxx | 54 +++ sal/osl/unx/profile.cxx | 114 sal/osl/unx/signal.cxx | 66 +- sal/rtl/bootstrap.cxx| 42 ++-- sal/rtl/cipher.cxx | 40 +-- sal/rtl/cmdargs.cxx | 46 ++--- sal/rtl/strbuf.cxx | 84 sal/rtl/ustrbuf.cxx | 136 +++ 10 files changed, 333 insertions(+), 332 deletions(-) New commits: commit 4acb0e7f05fa7fe05f990786e0483e20962af1d9 Author: Noel Grandin AuthorDate: Thu Apr 2 10:58:02 2020 +0200 Commit: Noel Grandin CommitDate: Thu Apr 2 20:06:15 2020 +0200 loplugin:flatten in sal Change-Id: Icc30c79d599486203c8f763cd5ff43059f0bb910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91556 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx index 5a6ffdff9110..ed663076b8d2 100644 --- a/sal/osl/all/log.cxx +++ b/sal/osl/all/log.cxx @@ -228,23 +228,23 @@ void maybeOutputTimestamp(std::ostringstream ) { static_cast(dateTime.NanoSeconds / 100)); s << ts << '.' << milliSecs << ':'; } -if (outputRelativeTimer) +if (!outputRelativeTimer) +return; + +TimeValue now; +osl_getSystemTime(); +int seconds = now.Seconds - aStartTime.aTime.Seconds; +int milliSeconds; +if (now.Nanosec < aStartTime.aTime.Nanosec) { -TimeValue now; -osl_getSystemTime(); -int seconds = now.Seconds - aStartTime.aTime.Seconds; -int milliSeconds; -if (now.Nanosec < aStartTime.aTime.Nanosec) -{ -seconds--; -milliSeconds = 1000 - (aStartTime.aTime.Nanosec - now.Nanosec) / 100; -} -else -milliSeconds = (now.Nanosec - aStartTime.aTime.Nanosec) / 100; -char relativeTimestamp[100]; -snprintf(relativeTimestamp, sizeof(relativeTimestamp), "%d.%03d", seconds, milliSeconds); -s << relativeTimestamp << ':'; +seconds--; +milliSeconds = 1000 - (aStartTime.aTime.Nanosec - now.Nanosec) / 100; } +else +milliSeconds = (now.Nanosec - aStartTime.aTime.Nanosec) / 100; +char relativeTimestamp[100]; +snprintf(relativeTimestamp, sizeof(relativeTimestamp), "%d.%03d", seconds, milliSeconds); +s << relativeTimestamp << ':'; } #endif @@ -344,20 +344,21 @@ void sal_detail_logFormat( sal_detail_LogLevel level, char const * area, char const * where, char const * format, ...) { -if (sal_detail_log_report(level, area)) { -std::va_list args; -va_start(args, format); -char buf[1024]; -int const len = sizeof buf - RTL_CONSTASCII_LENGTH("..."); -int n = vsnprintf(buf, len, format, args); -if (n < 0) { -std::strcpy(buf, "???"); -} else if (n >= len) { -std::strcpy(buf + len - 1, "..."); -} -sal_detail_log(level, area, where, buf, 0); -va_end(args); +if (!sal_detail_log_report(level, area)) +return; + +std::va_list args; +va_start(args, format); +char buf[1024]; +int const len = sizeof buf - RTL_CONSTASCII_LENGTH("..."); +int n = vsnprintf(buf, len, format, args); +if (n < 0) { +std::strcpy(buf, "???"); +} else if (n >= len) { +std::strcpy(buf + len - 1, "..."); } +sal_detail_log(level, area, where, buf, 0); +va_end(args); } sal_Bool sal_detail_log_report(sal_detail_LogLevel level, char const * area) { diff --git a/sal/osl/unx/file_path_helper.cxx b/sal/osl/unx/file_path_helper.cxx index a0ef13f9503d..080a99c09928 100644 --- a/sal/osl/unx/file_path_helper.cxx +++ b/sal/osl/unx/file_path_helper.cxx @@ -35,21 +35,21 @@ const sal_Unicode FPH_CHAR_COLON = ':'; void osl_systemPathRemoveSeparator(rtl_String* pstrPath) { OSL_PRECOND(nullptr != pstrPath, "osl_systemPathRemoveSeparator: Invalid parameter"); -if (pstrPath != nullptr) -{ -// maybe there are more than one separator at end -// so we run in a loop -while ((pstrPath->length > 1) && (pstrPath->buffer[pstrPath->length - 1] == FPH_CHAR_PATH_SEPARATOR)) -{ -pstrPath->length--; -pstrPath->buffer[pstrPath->length] = '\0'; -} +if (pstrPath == nullptr) +return; -SAL_WARN_IF( !((0 == pstrPath->length) || (1 == pstrPath->length) || - (pstrPath->length > 1 && pstrPath->buffer[pstrPath->length - 1] != FPH_CHAR_PATH_SEPARATOR)), - "sal.osl", - "osl_systemPathRemoveSeparator: Post condition failed"); +// maybe there are more than one separator at end
[Libreoffice-commits] core.git: sax/source
sax/source/expatwrap/sax_expat.cxx | 32 +- sax/source/expatwrap/xml2utf.cxx | 65 ++--- sax/source/fastparser/fastparser.cxx | 65 ++--- sax/source/fastparser/legacyfastparser.cxx | 88 ++--- sax/source/tools/fastserializer.cxx| 30 - 5 files changed, 139 insertions(+), 141 deletions(-) New commits: commit d8af42ec5004c8cdb57b6aa60a0f811cf61ad355 Author: Noel Grandin AuthorDate: Thu Apr 2 10:52:17 2020 +0200 Commit: Noel Grandin CommitDate: Thu Apr 2 20:05:51 2020 +0200 loplugin:flatten in sax Change-Id: I01c1f3328d04cf6ea7c76fab9547970387b968e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91551 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sax/source/expatwrap/sax_expat.cxx b/sax/source/expatwrap/sax_expat.cxx index 3172fbe89503..b80ebf033782 100644 --- a/sax/source/expatwrap/sax_expat.cxx +++ b/sax/source/expatwrap/sax_expat.cxx @@ -699,25 +699,25 @@ void SaxExpatParser_Impl::callbackStartElement( void *pvThis , { SaxExpatParser_Impl *pImpl = static_cast(pvThis); -if( pImpl->rDocumentHandler.is() ) { - -int i = 0; -pImpl->rAttrList->Clear(); +if( !pImpl->rDocumentHandler.is() ) +return; -while( awAttributes[i] ) { -assert(awAttributes[i+1]); -pImpl->rAttrList->AddAttribute( -XML_CHAR_TO_OUSTRING( awAttributes[i] ) , -gsCDATA, // expat doesn't know types -XML_CHAR_TO_OUSTRING( awAttributes[i+1] ) ); -i +=2; -} +int i = 0; +pImpl->rAttrList->Clear(); -CALL_ELEMENT_HANDLER_AND_CARE_FOR_EXCEPTIONS( -pImpl , -rDocumentHandler->startElement( XML_CHAR_TO_OUSTRING( pwName ) , -pImpl->rAttrList.get() ) ); +while( awAttributes[i] ) { +assert(awAttributes[i+1]); +pImpl->rAttrList->AddAttribute( +XML_CHAR_TO_OUSTRING( awAttributes[i] ) , +gsCDATA, // expat doesn't know types +XML_CHAR_TO_OUSTRING( awAttributes[i+1] ) ); +i +=2; } + +CALL_ELEMENT_HANDLER_AND_CARE_FOR_EXCEPTIONS( +pImpl , +rDocumentHandler->startElement( XML_CHAR_TO_OUSTRING( pwName ) , +pImpl->rAttrList.get() ) ); } void SaxExpatParser_Impl::callbackEndElement( void *pvThis , const XML_Char *pwName ) diff --git a/sax/source/expatwrap/xml2utf.cxx b/sax/source/expatwrap/xml2utf.cxx index 3e318d8827c3..420f90b6c3f0 100644 --- a/sax/source/expatwrap/xml2utf.cxx +++ b/sax/source/expatwrap/xml2utf.cxx @@ -117,43 +117,42 @@ sal_Int32 XMLFile2UTFConverter::readAndConvert( Sequence , sal_In void XMLFile2UTFConverter::removeEncoding( Sequence ) { const sal_Int8 *pSource = seq.getArray(); -if (seq.getLength() >= 5 && !strncmp(reinterpret_cast(pSource), "= 5 && !strncmp(reinterpret_cast(pSource), "(pSource), seq.getLength() ); +// scan for encoding +OString str( reinterpret_cast(pSource), seq.getLength() ); -// cut sequence to first line break -// find first line break; -int nMax = str.indexOf( 10 ); -if( nMax >= 0 ) -{ -str = str.copy( 0 , nMax ); -} +// cut sequence to first line break +// find first line break; +int nMax = str.indexOf( 10 ); +if( nMax >= 0 ) +{ +str = str.copy( 0 , nMax ); +} -int nFound = str.indexOf( " encoding" ); -if( nFound >= 0 ) { -int nStop; -int nStart = str.indexOf( "\"" , nFound ); -if( nStart < 0 || str.indexOf( "'" , nFound ) < nStart ) -{ -nStart = str.indexOf( "'" , nFound ); -nStop = str.indexOf( "'" , nStart +1 ); -} -else -{ -nStop = str.indexOf( "\"" , nStart +1); -} +int nFound = str.indexOf( " encoding" ); +if( nFound < 0 )return; -if( nStart >= 0 && nStop >= 0 && nStart+1 < nStop ) -{ -// remove encoding tag from file -memmove(&( seq.getArray()[nFound] ) , -&( seq.getArray()[nStop+1]) , -seq.getLength() - nStop -1); -seq.realloc( seq.getLength() - ( nStop+1 - nFound ) ); -} -} +int nStop; +int nStart = str.indexOf( "\"" , nFound ); +if( nStart < 0 || str.indexOf( "'" , nFound ) < nStart ) +{ +nStart = str.indexOf( "'" , nFound ); +nStop = str.indexOf( "'" , nStart +1 ); +} +else +{ +nStop = str.indexOf( "\"" , nStart +1); +} + +if( nStart >= 0 && nStop >= 0 && nStart+1 < nStop ) +{ +// remove encoding tag from file +memmove(&(
[Libreoffice-commits] core.git: scripting/source
scripting/source/dlgprov/DialogModelProvider.cxx| 46 ++--- scripting/source/dlgprov/dlgevtatt.cxx | 168 +- scripting/source/dlgprov/dlgprov.cxx| 50 ++--- scripting/source/protocolhandler/scripthandler.cxx | 50 ++--- scripting/source/provider/ActiveMSPList.cxx | 28 +-- scripting/source/provider/BrowseNodeFactoryImpl.cxx | 24 +- scripting/source/stringresource/stringresource.cxx | 184 ++-- scripting/source/vbaevents/eventhelper.cxx | 130 +++--- 8 files changed, 340 insertions(+), 340 deletions(-) New commits: commit d9946e6d0ba81071f3e50622e5cae9e2ffc9bfb0 Author: Noel Grandin AuthorDate: Thu Apr 2 10:45:58 2020 +0200 Commit: Noel Grandin CommitDate: Thu Apr 2 20:05:25 2020 +0200 loplugin:flatten in scripting Change-Id: I8df38b4b581fb674a050ef32624b22498a8e340f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91549 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/scripting/source/dlgprov/DialogModelProvider.cxx b/scripting/source/dlgprov/DialogModelProvider.cxx index bd9525a5bc5b..5f9e4e15a032 100644 --- a/scripting/source/dlgprov/DialogModelProvider.cxx +++ b/scripting/source/dlgprov/DialogModelProvider.cxx @@ -42,33 +42,33 @@ DialogModelProvider::DialogModelProvider(Reference< XComponentContext > const & // lang::XInitialization: void SAL_CALL DialogModelProvider::initialize(const css::uno::Sequence< uno::Any > & aArguments) { -if ( aArguments.getLength() == 1 ) -{ -OUString sURL; -if ( !( aArguments[ 0 ] >>= sURL )) -throw css::lang::IllegalArgumentException(); - // Try any other URL with SimpleFileAccess -Reference< ucb::XSimpleFileAccess3 > xSFI = ucb::SimpleFileAccess::create(m_xContext); +if ( aArguments.getLength() != 1 ) +return; + +OUString sURL; +if ( !( aArguments[ 0 ] >>= sURL )) +throw css::lang::IllegalArgumentException(); + // Try any other URL with SimpleFileAccess +Reference< ucb::XSimpleFileAccess3 > xSFI = ucb::SimpleFileAccess::create(m_xContext); -try +try +{ +Reference< io::XInputStream > xInput = xSFI->openFileRead( sURL ); +Reference< resource::XStringResourceManager > xStringResourceManager; +if ( xInput.is() ) { -Reference< io::XInputStream > xInput = xSFI->openFileRead( sURL ); -Reference< resource::XStringResourceManager > xStringResourceManager; -if ( xInput.is() ) -{ -xStringResourceManager = dlgprov::lcl_getStringResourceManager(m_xContext,sURL); -Any aDialogSourceURLAny; -aDialogSourceURLAny <<= sURL; - -Reference< frame::XModel > xModel; -m_xDialogModel.set( dlgprov::lcl_createDialogModel( m_xContext, xInput , xModel, xStringResourceManager, aDialogSourceURLAny ), UNO_SET_THROW); -m_xDialogModelProp.set(m_xDialogModel, UNO_QUERY_THROW); -} +xStringResourceManager = dlgprov::lcl_getStringResourceManager(m_xContext,sURL); +Any aDialogSourceURLAny; +aDialogSourceURLAny <<= sURL; + +Reference< frame::XModel > xModel; +m_xDialogModel.set( dlgprov::lcl_createDialogModel( m_xContext, xInput , xModel, xStringResourceManager, aDialogSourceURLAny ), UNO_SET_THROW); +m_xDialogModelProp.set(m_xDialogModel, UNO_QUERY_THROW); } -catch( Exception& ) -{} -//m_sURL = sURL; } +catch( Exception& ) +{} +//m_sURL = sURL; } // container::XElementAccess: diff --git a/scripting/source/dlgprov/dlgevtatt.cxx b/scripting/source/dlgprov/dlgevtatt.cxx index 1269395b01f5..b1a3fceee7ec 100644 --- a/scripting/source/dlgprov/dlgevtatt.cxx +++ b/scripting/source/dlgprov/dlgevtatt.cxx @@ -118,37 +118,37 @@ namespace dlgprov args[0] <<= xModel; mxListener.set( xSMgr->createInstanceWithArgumentsAndContext( "ooo.vba.EventListener", args, m_xContext ), UNO_QUERY ); } -if ( rxControl.is() ) +if ( !rxControl.is() ) +return; + +try { -try -{ -Reference< XPropertySet > xProps( rxControl->getModel(), UNO_QUERY_THROW ); -xProps->getPropertyValue("Name") >>= msDialogCodeName; -xProps.set( mxListener, UNO_QUERY_THROW ); -xProps->setPropertyValue("Model", args[ 0 ] ); -} -catch( const Exception& ) -{ -DBG_UNHANDLED_EXCEPTION("scripting"); -} +Reference< XPropertySet > xProps( rxControl->getModel(), UNO_QUERY_THROW ); +xProps->getPropertyValue("Name") >>= msDialogCodeName; +xProps.set( mxListener, UNO_QUERY_THROW ); +xProps->setPropertyValue("Model",
[Libreoffice-commits] core.git: scaddins/source
scaddins/source/analysis/analysishelper.cxx | 32 ++-- 1 file changed, 16 insertions(+), 16 deletions(-) New commits: commit a3695d24087b7958850d73eee7e665c1d78a041b Author: Noel Grandin AuthorDate: Thu Apr 2 10:48:50 2020 +0200 Commit: Noel Grandin CommitDate: Thu Apr 2 20:04:45 2020 +0200 loplugin:flatten in scaddins Change-Id: I7a973de06d36fb10e9dd7f6826991ff9d503076d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91550 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/scaddins/source/analysis/analysishelper.cxx b/scaddins/source/analysis/analysishelper.cxx index 3206b650b30b..2e799c9d1588 100644 --- a/scaddins/source/analysis/analysishelper.cxx +++ b/scaddins/source/analysis/analysishelper.cxx @@ -2689,23 +2689,23 @@ void ScaAnyConverter::init( const uno::Reference< beans::XPropertySet >& xPropSe { // try to get default number format bHasValidFormat = false; -if( xFormatter.is() ) +if( !xFormatter.is() ) +return; + +// get XFormatsSupplier from outer XPropertySet +uno::Reference< util::XNumberFormatsSupplier > xFormatsSupp( xPropSet, uno::UNO_QUERY ); +if( !xFormatsSupp.is() ) +return; + +// get XNumberFormatTypes from XNumberFormatsSupplier to get standard index +uno::Reference< util::XNumberFormats > xFormats( xFormatsSupp->getNumberFormats() ); +uno::Reference< util::XNumberFormatTypes > xFormatTypes( xFormats, uno::UNO_QUERY ); +if( xFormatTypes.is() ) { -// get XFormatsSupplier from outer XPropertySet -uno::Reference< util::XNumberFormatsSupplier > xFormatsSupp( xPropSet, uno::UNO_QUERY ); -if( xFormatsSupp.is() ) -{ -// get XNumberFormatTypes from XNumberFormatsSupplier to get standard index -uno::Reference< util::XNumberFormats > xFormats( xFormatsSupp->getNumberFormats() ); -uno::Reference< util::XNumberFormatTypes > xFormatTypes( xFormats, uno::UNO_QUERY ); -if( xFormatTypes.is() ) -{ -lang::Locale eLocale; -nDefaultFormat = xFormatTypes->getStandardIndex( eLocale ); -xFormatter->attachNumberFormatsSupplier( xFormatsSupp ); -bHasValidFormat = true; -} -} +lang::Locale eLocale; +nDefaultFormat = xFormatTypes->getStandardIndex( eLocale ); +xFormatter->attachNumberFormatsSupplier( xFormatsSupp ); +bHasValidFormat = true; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang include/vcl sw/inc vcl/inc vcl/source xmloff/source
compilerplugins/clang/unusedmethods.results | 288 +--- include/vcl/treelist.hxx|7 include/vcl/treelistbox.hxx |4 sw/inc/calbck.hxx | 47 vcl/inc/svimpbox.hxx|7 vcl/source/treelist/svimpbox.cxx| 34 --- vcl/source/treelist/treelist.cxx| 10 vcl/source/treelist/treelistbox.cxx | 28 -- xmloff/source/draw/sdxmlimp.cxx | 23 -- xmloff/source/draw/sdxmlimp_impl.hxx|2 10 files changed, 142 insertions(+), 308 deletions(-) New commits: commit 51143bbb326a7a2e7df7ba987c0e50030c609841 Author: Noel Grandin AuthorDate: Thu Apr 2 09:05:06 2020 +0200 Commit: Noel Grandin CommitDate: Thu Apr 2 20:03:33 2020 +0200 loplugin:unusedmethods Change-Id: I906234a38b96c6ba6eaadf7693abd33e98debf50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91567 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index 4c05c1c08f25..b1318fc0f7ed 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -58,12 +58,6 @@ canvas/source/vcl/impltools.hxx:103 vclcanvas::tools::LocalGuard::LocalGuard() chart2/source/controller/dialogs/tp_3D_SceneIllumination.hxx:55 void chart::ThreeD_SceneIllumination_TabPage::LinkStubfillControlsFromModel(void *,void *) -chart2/source/controller/inc/ChartController.hxx:323 -_Bool chart::ChartController::isSelectedObjectDraggable() const -chart2/source/controller/inc/ChartController.hxx:324 -_Bool chart::ChartController::isSelectedObjectResizable() const -chart2/source/controller/inc/ChartController.hxx:325 -_Bool chart::ChartController::isSelectedObjectRotatable() const connectivity/inc/sdbcx/VGroup.hxx:63 connectivity::sdbcx::OGroup::OGroup(_Bool) connectivity/inc/sdbcx/VGroup.hxx:64 @@ -80,18 +74,10 @@ connectivity/source/drivers/firebird/Util.hxx:74 short connectivity::firebird::ColumnTypeInfo::getSubType() const connectivity/source/drivers/firebird/Util.hxx:76 const class rtl::OUString & connectivity::firebird::ColumnTypeInfo::getCharacterSet() const -connectivity/source/drivers/mork/mork_helper.cxx:37 -int main(int,char **) connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.hxx:96 type-parameter-?-? connectivity::mysqlc::OPreparedResultSet::safelyRetrieveValue(const int) connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.hxx:97 type-parameter-?-? connectivity::mysqlc::OPreparedResultSet::retrieveValue(const int) -connectivity/source/drivers/postgresql/pq_connection.hxx:79 -_Bool pq_sdbc_driver::isLog(const struct pq_sdbc_driver::ConnectionSettings *,enum pq_sdbc_driver::LogLevel) -connectivity/source/drivers/postgresql/pq_connection.hxx:80 -void pq_sdbc_driver::log(struct pq_sdbc_driver::ConnectionSettings *,enum pq_sdbc_driver::LogLevel,const class rtl::OUString &) -connectivity/source/drivers/postgresql/pq_connection.hxx:81 -void pq_sdbc_driver::log(struct pq_sdbc_driver::ConnectionSettings *,enum pq_sdbc_driver::LogLevel,const char *) connectivity/source/inc/dbase/dindexnode.hxx:67 _Bool connectivity::dbase::ONDXKey::operator<(const class connectivity::dbase::ONDXKey &) const connectivity/source/inc/java/sql/Connection.hxx:61 @@ -138,7 +124,7 @@ cui/source/inc/cfgutil.hxx:165 int CuiConfigFunctionListBox::get_selected_index() const cui/source/inc/cfgutil.hxx:166 void CuiConfigFunctionListBox::select(const class weld::TreeIter &) -cui/source/inc/CustomNotebookbarGenerator.hxx:31 +cui/source/inc/CustomNotebookbarGenerator.hxx:30 CustomNotebookbarGenerator::CustomNotebookbarGenerator() cui/source/inc/hangulhanjadlg.hxx:244 class rtl::OUString svx::SuggestionEdit::get_text() const @@ -178,6 +164,8 @@ dbaccess/source/ui/inc/WTypeSelect.hxx:76 void dbaui::OWizTypeSelectList::show() desktop/source/lib/lokclipboard.hxx:96 LOKClipboardFactory::LOKClipboardFactory() +drawinglayer/inc/texture/texture.hxx:43 +_Bool drawinglayer::texture::GeoTexSvx::operator!=(const class drawinglayer::texture::GeoTexSvx &) const drawinglayer/source/tools/emfpcustomlinecap.hxx:38 void emfplushelper::EMFPCustomLineCap::SetAttributes(struct com::sun::star::rendering::StrokeAttributes &) drawinglayer/source/tools/emfpstringformat.hxx:94 @@ -208,7 +196,7 @@ hwpfilter/source/mzstring.h:101 class MzString & MzString::operator<<(long) hwpfilter/source/mzstring.h:102 class MzString & MzString::operator<<(short) -include/basegfx/color/bcolormodifier.hxx:76 +include/basegfx/color/bcolormodifier.hxx:77 _Bool basegfx::BColorModifier::operator!=(const class basegfx::BColorModifier &) const include/basegfx/curve/b2dcubicbezier.hxx:52 _Bool basegfx::B2DCubicBezier::operator==(const
[Libreoffice-bugs] [Bug 115965] Radio buttons for .uno:DefaultBullet and uno:DefaultNumbering plus introducing a no list option
https://bugs.documentfoundation.org/show_bug.cgi?id=115965 Shameem changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mailtoshamee...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131812] Exporting to html doesn't preserve RTL property
https://bugs.documentfoundation.org/show_bug.cgi?id=131812 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- If you check Page Style, Text direction is LTR, not RTL. The text is only right justified. So yes html should be right justified, but nothing related to Text direction. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114293] [META] Address Book Data Source bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114293 Bug 114293 depends on bug 117101, which changed state. Bug 117101 Summary: Address Book Data Source Wizard: Default external data source format is dBASE https://bugs.documentfoundation.org/show_bug.cgi?id=117101 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107007] PDF export uses insecure RC4-128 encryption
https://bugs.documentfoundation.org/show_bug.cgi?id=107007 --- Comment #4 from paulyste...@web.de --- Repro 6.4.2.2 x64 win10-64 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107007] PDF export uses insecure RC4-128 encryption
https://bugs.documentfoundation.org/show_bug.cgi?id=107007 --- Comment #3 from paulyste...@web.de --- Much people in firms and journalists needs better encryption with AES so importance for security is high and not medium -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #17 from Jan-Marek Glogowski --- (In reply to Regina Henschel from comment #12) [info about ODF / SVG representation] I'm not sure, the external representation matters for this bug. But yup - a complex path of different parts (line, curve, arc) can not be constructed in Draw AFAIK, but maybe it's just a hidden feature Armin knows about. It can be done in code, as you can see in the AddPolygonToPath in vcl/qt5/Qt5Graphics_GDI.cxx. Not sure about the arc segment; maybe it's represented as a "fixed" Bézier curve internally. > Problems in the UI: > 1) Using Alt-Click to start a next sequence of points always inserts a > 'closepath' command. But reading a shape without this 'closepath' command is > possible. That's why I suggested the polygon / polyline split of the tool. > 2) Finish creating with a double-click on the first point, closes the shape > automatically. But elements with same start and end point > are possible and correctly read. Same as 1. > 3) The naming in the UI uses 'Polyline' and 'Polygon' too, when it is a > path-element with only straight lines. Hadn't noticed that. Still 1. > 4) The use of Alt-key with the 'Curves and Polygons'-tool is badly > communitcated. > > When starting with a polyline and using Alt-Double-click, it does only close > the shape because of behavior 1). > Using Ctrl-Alt-Click is the same as only using Alt-Click. It closes the > shape because of behavior 1) and goes into PolyPolygon-mode. The next line > will belong to the same shape. Yup - you need the alternative for "Alt + left-click", as this is the common action to move a window in Linux (Unix?) window managers. In that case you don't need to select the title bar of a window, but can directly start moving the window from the current mouse position. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #17 from Jan-Marek Glogowski --- (In reply to Regina Henschel from comment #12) [info about ODF / SVG representation] I'm not sure, the external representation matters for this bug. But yup - a complex path of different parts (line, curve, arc) can not be constructed in Draw AFAIK, but maybe it's just a hidden feature Armin knows about. It can be done in code, as you can see in the AddPolygonToPath in vcl/qt5/Qt5Graphics_GDI.cxx. Not sure about the arc segment; maybe it's represented as a "fixed" Bézier curve internally. > Problems in the UI: > 1) Using Alt-Click to start a next sequence of points always inserts a > 'closepath' command. But reading a shape without this 'closepath' command is > possible. That's why I suggested the polygon / polyline split of the tool. > 2) Finish creating with a double-click on the first point, closes the shape > automatically. But elements with same start and end point > are possible and correctly read. Same as 1. > 3) The naming in the UI uses 'Polyline' and 'Polygon' too, when it is a > path-element with only straight lines. Hadn't noticed that. Still 1. > 4) The use of Alt-key with the 'Curves and Polygons'-tool is badly > communitcated. > > When starting with a polyline and using Alt-Double-click, it does only close > the shape because of behavior 1). > Using Ctrl-Alt-Click is the same as only using Alt-Click. It closes the > shape because of behavior 1) and goes into PolyPolygon-mode. The next line > will belong to the same shape. Yup - you need the alternative for "Alt + left-click", as this is the common action to move a window in Linux (Unix?) window managers. In that case you don't need to select the title bar of a window, but can directly start moving the window from the current mouse position. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131820] Ich kann keine Daten öffnen oder speichern. - New (German)
https://bugs.documentfoundation.org/show_bug.cgi?id=131820 --- Comment #1 from Julien Nabet --- Please write in English so more people may intervene. About C:\Program Files\Common Files, do you know which files did you remove? If not, I think the best would be to reinstall Windows (make backups on usb key or external drive before) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #16 from Jan-Marek Glogowski --- (In reply to Regina Henschel from comment #15) > Created attachment 159274 [details] > Close and open polygon from the context menu > > (In reply to Jan-Marek Glogowski from comment #14) > > Where do you see this toggle? > > See attached file. > > Screenshots from Version: 7.0.0.0.alpha0+ (x64) > Build ID: 6388c578c672690fff662cb04b6a0436cd742f37 > CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; > Locale: de-DE (en_US); UI-Language: en-US > Calc: threaded So I just checkout out that exact revision from https://bibisect.libreoffice.org/linux-64-6.5.git, and I still don't see the toggle with either gen, gtk3 or kf5 backend. Interestingly it's named "Close Bézier", after you selected it, but even if I draw a curve instead of a polygon, that entry just vanishes. I'll open a bug report. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #16 from Jan-Marek Glogowski --- (In reply to Regina Henschel from comment #15) > Created attachment 159274 [details] > Close and open polygon from the context menu > > (In reply to Jan-Marek Glogowski from comment #14) > > Where do you see this toggle? > > See attached file. > > Screenshots from Version: 7.0.0.0.alpha0+ (x64) > Build ID: 6388c578c672690fff662cb04b6a0436cd742f37 > CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; > Locale: de-DE (en_US); UI-Language: en-US > Calc: threaded So I just checkout out that exact revision from https://bibisect.libreoffice.org/linux-64-6.5.git, and I still don't see the toggle with either gen, gtk3 or kf5 backend. Interestingly it's named "Close Bézier", after you selected it, but even if I draw a curve instead of a polygon, that entry just vanishes. I'll open a bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 101211] "Previous page" and "Next page" functions in navigator not available for keyboard binding
https://bugs.documentfoundation.org/show_bug.cgi?id=101211 --- Comment #15 from Kenneth Hanson --- @Jim I think you have it! Regarding naming, I would like to propose some new names, at least as a starting point for discussion. 1. Next/Previous Page -> "Page Up/Down", since they implement the default behavior of the PageUp and PageDown keys. I can't think of good names that are actually descriptive of what they do ("Scroll Up/Down" is sort of okay), but the current name is unacceptable. 2. To Begin of Next/Previous Page -> keep the same for now, since there are other commands with parallel names (which presumably behave similarly) 3. The new functions -> Option (a) -- "Next/Previous Page" -- fairly obvious for people looking for this functionality, and reflects the fact that there is no begin/end distinction (it always aligns to the top), but not clearly distinguished from (2) Option (b) -- "Next/Previous Page (Align Top)" -- wordy, but descriptive enough to distinguish it clearly from (2). Also leaves open the option to include parallel functions that align the bottom of the page (which may or may not be useful). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 101211] "Previous page" and "Next page" functions in navigator not available for keyboard binding
https://bugs.documentfoundation.org/show_bug.cgi?id=101211 --- Comment #15 from Kenneth Hanson --- @Jim I think you have it! Regarding naming, I would like to propose some new names, at least as a starting point for discussion. 1. Next/Previous Page -> "Page Up/Down", since they implement the default behavior of the PageUp and PageDown keys. I can't think of good names that are actually descriptive of what they do ("Scroll Up/Down" is sort of okay), but the current name is unacceptable. 2. To Begin of Next/Previous Page -> keep the same for now, since there are other commands with parallel names (which presumably behave similarly) 3. The new functions -> Option (a) -- "Next/Previous Page" -- fairly obvious for people looking for this functionality, and reflects the fact that there is no begin/end distinction (it always aligns to the top), but not clearly distinguished from (2) Option (b) -- "Next/Previous Page (Align Top)" -- wordy, but descriptive enough to distinguish it clearly from (2). Also leaves open the option to include parallel functions that align the bottom of the page (which may or may not be useful). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62196] EDITING: copy-paste from non-LibO-text-source pastes previous clipboard contents (see comment 62)
https://bugs.documentfoundation.org/show_bug.cgi?id=62196 --- Comment #101 from Michael --- (In reply to Paul Unger from comment #100) > I went to bug 97939 first, because it more accurately describes my > situation, but it has been marked as a duplicate of this bug... > I can't paste /anything/ from an outside program into LO Writer, let alone > the previous clipboard contents. > Pasting the same Ctrl+C content into gedit works as expected. > Ubuntu 18.04, LO 6.2.8.2, for whatever that's worth. Try the following link to a Gnome bug report. https://gitlab.gnome.org/GNOME/mutter/-/issues/1148 Perhaps that helps temporarily. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #15 from Regina Henschel --- Created attachment 159274 --> https://bugs.documentfoundation.org/attachment.cgi?id=159274=edit Close and open polygon from the context menu (In reply to Jan-Marek Glogowski from comment #14) > Where do you see this toggle? See attached file. Screenshots from Version: 7.0.0.0.alpha0+ (x64) Build ID: 6388c578c672690fff662cb04b6a0436cd742f37 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: de-DE (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 62196] EDITING: copy-paste from non-LibO-text-source pastes previous clipboard contents (see comment 62)
https://bugs.documentfoundation.org/show_bug.cgi?id=62196 --- Comment #100 from Paul Unger --- I went to bug 97939 first, because it more accurately describes my situation, but it has been marked as a duplicate of this bug... I can't paste /anything/ from an outside program into LO Writer, let alone the previous clipboard contents. Pasting the same Ctrl+C content into gedit works as expected. Ubuntu 18.04, LO 6.2.8.2, for whatever that's worth. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131758] Consistent polygon tool behavior in Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=131758 --- Comment #15 from Regina Henschel --- Created attachment 159274 --> https://bugs.documentfoundation.org/attachment.cgi?id=159274=edit Close and open polygon from the context menu (In reply to Jan-Marek Glogowski from comment #14) > Where do you see this toggle? See attached file. Screenshots from Version: 7.0.0.0.alpha0+ (x64) Build ID: 6388c578c672690fff662cb04b6a0436cd742f37 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: de-DE (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124732] Context menu item 'Exit Group' missing
https://bugs.documentfoundation.org/show_bug.cgi?id=124732 Rainer Bielefeld Retired changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #6 from Rainer Bielefeld Retired --- IMHO the current behavior is not user friendly. a) For my Version: 6.4.2.2 (x64) Build-ID: 4e471d8c02c9c90f512f7f9ead8875b57fcb1ec3 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US, Tango theme Online Help https://help.libreoffice.org/6.4/en-US/text/shared/guide/groups.html?DbPAR=SHARED#bm_id6888027 still tells about context menu item 'Exit Group'. Same with German build in Help. b) 'Exit Group' context menu item appears b1) after having pasted some bitmap contents into group and having clicked pasted contents b2) after having selected more than 1 element of the group and right click on an element in the selected area c) If I enter a group with context menu I expect that I should also be able to leave it that way. Especially that way works for (b1) (b2) d) the old way via context menu is not only more intuitive, but also faster than the way via the Main Menu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131635] Selection rectangle persists after de-selection/selection change
https://bugs.documentfoundation.org/show_bug.cgi?id=131635 --- Comment #3 from Eyal Rozenberg --- (In reply to Dieter from comment #2) Fair enough, but - I can't reproduce this myself. And it's not related to some specific document (and certainly does not last quitting and restarting LO writer). I don't have anything else I can add. Sorry. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/vi_VN.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 28ccea8b7feed20d33e2ca7d6197d947dbbad848 Author: Eike Rathke AuthorDate: Thu Apr 2 18:14:14 2020 +0200 Commit: Eike Rathke CommitDate: Thu Apr 2 18:54:35 2020 +0200 Resolves: tdf#131829 [vi-VN] set currency VND decimals to 0 Change-Id: I865d6b3dcb7f3bff037a4015aa98db2fa2578672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91593 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/i18npool/source/localedata/data/vi_VN.xml b/i18npool/source/localedata/data/vi_VN.xml index c2ee30b98bbc..2203461443b5 100644 --- a/i18npool/source/localedata/data/vi_VN.xml +++ b/i18npool/source/localedata/data/vi_VN.xml @@ -90,19 +90,19 @@ #.##0 [CURRENCY];-#.##0 [CURRENCY] - #.##0,00 [CURRENCY];-#.##0,00 [CURRENCY] + #.##0 [CURRENCY];-#.##0 [CURRENCY] #.##0 [CURRENCY];[RED]-#.##0 [CURRENCY] - #.##0,00 [CURRENCY];[RED]-#.##0,00 [CURRENCY] + #.##0 [CURRENCY];[RED]-#.##0 [CURRENCY] - #.##0,00 CCC + #.##0 CCC - #.##0,-- [CURRENCY];[RED]-#.##0,-- [CURRENCY] + #.##0 [CURRENCY];[RED]-#.##0 [CURRENCY] D/M/YY @@ -342,7 +342,7 @@ ₫ VND Việt Nam Đồng - 2 + 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: extensions/source
extensions/source/abpilot/abspilot.cxx |2 +- extensions/source/abpilot/datasourcehandling.cxx |5 +++-- extensions/source/abpilot/datasourcehandling.hxx |4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) New commits: commit f16214fc22aa6665bc9667033496f8e4bed80e05 Author: Gabor Kelemen AuthorDate: Thu Apr 2 01:28:21 2020 +0200 Commit: László Németh CommitDate: Thu Apr 2 18:53:52 2020 +0200 tdf#117101 Make Spreadsheet the default new data source type instead of DBase. It's more likely that people are having those as data source for Mail Merge Also change method name to mirror the "Other" option that was selected in the firs step of the wizard Change-Id: I12b7fa98ada3af4fd39614a77b47cb587743b614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91541 Tested-by: Jenkins Tested-by: László Németh Reviewed-by: László Németh diff --git a/extensions/source/abpilot/abspilot.cxx b/extensions/source/abpilot/abspilot.cxx index be1f98daf0eb..11376effb3a9 100644 --- a/extensions/source/abpilot/abspilot.cxx +++ b/extensions/source/abpilot/abspilot.cxx @@ -343,7 +343,7 @@ namespace abp break; case AST_OTHER: -m_aNewDataSource = aContext.createNewDBase( m_aSettings.sDataSourceName ); +m_aNewDataSource = aContext.createNewOther( m_aSettings.sDataSourceName ); break; case AST_INVALID: diff --git a/extensions/source/abpilot/datasourcehandling.cxx b/extensions/source/abpilot/datasourcehandling.cxx index 00ab85a2486a..46b71839d8e2 100644 --- a/extensions/source/abpilot/datasourcehandling.cxx +++ b/extensions/source/abpilot/datasourcehandling.cxx @@ -280,9 +280,10 @@ namespace abp } -ODataSource ODataSourceContext::createNewDBase( const OUString& _rName) +// tdf117101: Spreadsheet by default +ODataSource ODataSourceContext::createNewOther( const OUString& _rName) { -return lcl_implCreateAndSetURL( m_pImpl->xORB, _rName, "sdbc:dbase:" ); +return lcl_implCreateAndSetURL( m_pImpl->xORB, _rName, "sdbc:calc:" ); } struct ODataSourceImpl diff --git a/extensions/source/abpilot/datasourcehandling.hxx b/extensions/source/abpilot/datasourcehandling.hxx index 00da09f7941d..98e62e90ef3b 100644 --- a/extensions/source/abpilot/datasourcehandling.hxx +++ b/extensions/source/abpilot/datasourcehandling.hxx @@ -80,8 +80,8 @@ namespace abp /// creates a new macOS address book data source ODataSource createNewMacab( const OUString& _rName ); -/// creates a new dBase data source -ODataSource createNewDBase( const OUString& _rName ); +/// creates a new Other data source; tdf117101: Spreadsheet by default +ODataSource createNewOther( const OUString& _rName ); }; struct ODataSourceImpl; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 131785] LIST NUMBER: Different behaviour when using Font Colour and Highlight Colour
https://bugs.documentfoundation.org/show_bug.cgi?id=131785 --- Comment #5 from Kenneth Hanson --- This bug is an excellent example of a more general problem with lists. Sometimes formatting of the list contents bleeds over into the number/bullet, other times it doesn't, and the user has no control over this. See, for example, bug 99330. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs