[Libreoffice-bugs] [Bug 156929] Check for updates dialog not accessible with assistive technology

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156929

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
   Keywords||accessibility
 Blocks||113339
 CC||stephane.guillou@libreoffic
   ||e.org
Version|7.5.5.2 release |Inherited From OOo
 OS|Windows (All)   |All

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thank you for the report, Luca!

Reproduced in:

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

And recent master build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 642f2d7177ea3e6c365da2c2082a50a5137cd988
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same in OOo 3.3, so inherited.

Orca does not read the message in the first frame, focus is directly on Close
push button. But even Shift + Tab navigating to the first frame reads "blank"
instead of the text it contains.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113339
[Bug 113339] [META] Updates bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113339] [META] Updates bug tracker

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113339

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||156929


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156929
[Bug 156929] Check for updates dialog not accessible with assistive technology
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - xmloff/qa xmloff/source

2023-08-30 Thread Regina Henschel (via logerrit)
 xmloff/qa/unit/draw.cxx |   57 
 xmloff/source/draw/sdxmlexp.cxx |5 ---
 2 files changed, 58 insertions(+), 4 deletions(-)

New commits:
commit dfea87d635863251bac02183294d3bf75fa45820
Author: Regina Henschel 
AuthorDate: Tue Aug 29 22:18:29 2023 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Aug 31 07:58:05 2023 +0200

tdf#156975 Save a Theme in Draw too not only in Impress

Draw and Impress have many things in common and should therefore be
treated equally where possible.

Only if the theme colors are present in the document, colors can be
recognized as theme colors during import.

Change-Id: Ia1fae2aff989ae305c210efa3f925a80898880e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156267
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 6cdafbe4043ac98f94feda87318db44ffebba7d2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156224
Tested-by: Jenkins CollaboraOffice 

diff --git a/xmloff/qa/unit/draw.cxx b/xmloff/qa/unit/draw.cxx
index d09f2a236156..7091cea1a8b7 100644
--- a/xmloff/qa/unit/draw.cxx
+++ b/xmloff/qa/unit/draw.cxx
@@ -726,6 +726,63 @@ CPPUNIT_TEST_FIXTURE(XmloffDrawTest, 
testTextRotationPlusPre)
 // But reload catches it.
 saveAndReload("writer8");
 }
+
+CPPUNIT_TEST_FIXTURE(XmloffDrawTest, testTdf156975_ThemeExport)
+{
+// It tests, that a theme is written to master page in Draw documents.
+// Without fix for tdf#156975 it was not written at all.
+// The test needs to be adapted, when themes are available in ODF.
+
+mxComponent = loadFromDesktop("private:factory/sdraw");
+// generate a theme to be sure we have got one and know the values
+uno::Reference 
xDrawPagesSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference xDrawPage(
+xDrawPagesSupplier->getDrawPages()->getByIndex(0), uno::UNO_QUERY);
+uno::Reference 
xMasterPageProps(xDrawPage->getMasterPage(),
+ uno::UNO_QUERY);
+
+auto pTheme = std::make_shared("Custom");
+auto pColorSet = std::make_shared("My Colors");
+pColorSet->add(model::ThemeColorType::Dark1, 0x00);
+pColorSet->add(model::ThemeColorType::Light1, 0x11);
+pColorSet->add(model::ThemeColorType::Dark2, 0x002200);
+pColorSet->add(model::ThemeColorType::Light2, 0xff33ff);
+pColorSet->add(model::ThemeColorType::Accent1, 0x44);
+pColorSet->add(model::ThemeColorType::Accent2, 0x005500);
+pColorSet->add(model::ThemeColorType::Accent3, 0x66);
+pColorSet->add(model::ThemeColorType::Accent4, 0x00);
+pColorSet->add(model::ThemeColorType::Accent5, 0x880088);
+pColorSet->add(model::ThemeColorType::Accent6, 0x00);
+pColorSet->add(model::ThemeColorType::Hyperlink, 0x0a0a0a);
+pColorSet->add(model::ThemeColorType::FollowedHyperlink, 0xb0b0b0);
+pTheme->setColorSet(pColorSet);
+
+uno::Reference xTheme = model::theme::createXTheme(pTheme);
+xMasterPageProps->setPropertyValue("Theme", uno::Any(xTheme));
+
+// save as odg
+save("draw8");
+
+// and check the markup.
+xmlDocUniquePtr pXmlDoc = parseExport("styles.xml");
+static constexpr OStringLiteral sThemePath
+= "//office:master-styles/style:master-page/loext:theme";
+assertXPath(pXmlDoc, sThemePath, 1);
+assertXPath(pXmlDoc, sThemePath + "[@loext:name='Custom']");
+
+const OString sThemeColorsPath = sThemePath + "/loext:theme-colors";
+assertXPath(pXmlDoc, sThemeColorsPath, 1);
+assertXPath(pXmlDoc, sThemeColorsPath + "[@loext:name='My Colors']");
+
+const OString sThemeColorPath = sThemeColorsPath + "/loext:color";
+assertXPath(pXmlDoc, sThemeColorPath, 12);
+assertXPath(pXmlDoc, sThemeColorPath + "[3]", "name", "dark2");
+assertXPath(pXmlDoc, sThemeColorPath + "[3]", "color", "#002200");
+assertXPath(pXmlDoc, sThemeColorPath + "[9]", "name", "accent5");
+assertXPath(pXmlDoc, sThemeColorPath + "[9]", "color", "#880088");
+assertXPath(pXmlDoc, sThemeColorPath + "[12]", "name", 
"followed-hyperlink");
+assertXPath(pXmlDoc, sThemeColorPath + "[12]", "color", "#b0b0b0");
+}
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index a8f2deb0fcd3..4dfd2195bc49 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2306,10 +2306,7 @@ void SdXMLExport::ExportMasterStyles_()
 exportFormsElement( xMasterPage );
 
 // write optional loext:theme
-if (IsImpress())
-{
-ExportThemeElement(xMasterPage);
-}
+ExportThemeElement(xMasterPage);
 
 // write graphic objects on this master page (if any)
 if(xMasterPage.is() && xMasterPage->getCount())


[Libreoffice-bugs] [Bug 157028] FILESAVE PDF Tagged PDF export makes file size grow significantly

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157028

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #1 from V Stuart Foote  ---
Question is how much content to include with tagging. IIRC by default our
Tagged PDF/A-3 archival and PDF/UA includes what is appropriate for AT and
a11y.

Size of "tagged" PDF is a secondary concern to PDF content flow from-to,
locale/script tags, and including "Alternate Text" and "Actual Text" spans.

By nature "tagged" PDF will balloon in size.

IMHO => NAB

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156986] LibreOffice crashed

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156986

Klaus  changed:

   What|Removed |Added

   Keywords||difficultyBeginner
 CC||kja...@fastmail.fm
   Hardware|x86-64 (AMD64)  |Other
URL||https://ask.libreoffice.org
   ||/t/calc-screen-refresh-not-
   ||working/92715
 OS|Windows (All)   |macOS (All)
Version|7.5.5.2 release |7.4.7.2 release

--- Comment #5 from Klaus  ---
I reported an issue on LibreOffice Document Foundation that resulted in mostly
Calc screen displays overwriting each other making the spreadsheet unreadable. 
(https://ask.libreoffice.org/t/calc-screen-refresh-not-working/92715)
I was pointed to the setting "Use Skia for rendering" as well as Force Skia
software rendering".
This fixed the original issue of overwriting the screen contents, but now I am
experiencing that LibreOffice crashes several times, mainly shortly after
starting up for the day and/or scrolling a file.  Initially I experienced when
scrolling an open file (not changing anything), but today LibreOffice crashed
just on opening a new text document.  
When it happens all open files are saved before the crash and they will be
recovered successfully when reopening LibreOfiice.
More details in the URL above.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156265] Laggy Calc on Windows 11

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156265

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #2 from Buovjaga  ---
Igor: can you reproduce, if you go to Help - Restart in safe mode and then
Continue in safe mode?

Did you get "UI render: Skia/Raster" after checking the "Force Skia" option? Is
it laggy with UI render: default?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107404] Line with multiple superscript and subscript valued text not rendered correctly

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107404

Diana Vides  changed:

   What|Removed |Added

 CC||dianavide...@gmail.com

--- Comment #7 from Diana Vides  ---
Still confirmed

Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_US); UI: en-US
Calc: threaded 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: df3b95a39472e18ea8acdaae447b7176e37a9256
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157012] FILEOPEN DOCX: Pages keep on going indefinitely

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157012

--- Comment #5 from Sunil  ---
@m.a.riosv
Did you try to open the inf_loop.docx?

If you want to add a new row on works.docx then it seems LibreOffice crashes. 

1. Go to the last column of last row of works.docx in second page. 
2. Place the cursor on right after $15.00. 
3. Press Tab to insert a new row. 
4. LibreOffice Writer Crashes. 

The inf_loop.docx is generated by a script which adds row for each items.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156761] Marking image makes the scroll position jump

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156761

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152513] FORMATTING: Enhancement request [Custom Layouts]

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152513

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156790] Support referencing the endpoints of ranges in ODF

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156790

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156986] LibreOffice crashed

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156986

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156986] LibreOffice crashed

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156986

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148733] The active font isn't filtered in the Character dialog on open

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148733

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148733] The active font isn't filtered in the Character dialog on open

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148733

--- Comment #4 from QA Administrators  ---
Dear Telesto,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 77708] EDITING: Set "Collect at end of section" option independently for parent/child sections.

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77708

--- Comment #6 from QA Administrators  ---
Dear Owen Genat (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 76208] Borders around frames

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76208

--- Comment #9 from QA Administrators  ---
Dear hc.stoellinger,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144175] Remove strings from l10n in html export

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144175

--- Comment #3 from QA Administrators  ---
Dear sophie,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142541] Border formatting in Impress and Writer Tables does not consider the selected Border Color

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142541

--- Comment #10 from QA Administrators  ---
Dear Rafael Lima,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: #tdf51510: Change the DPI to get better resolution, but failed the unit test

2023-08-30 Thread Lodev

Hi,

Tomaž Vajngerl 於 2023/8/31 03:13 寫道:

Hi,

On Tue, Aug 29, 2023 at 9:09 AM Lodev  wrote:

Sorry if I'm asking a stupid question here.  First, I've never seen or
used a document with "multiple instances that all point to the same
image in the document".

That's easy - drag the image while holding ctrl and drop. It will make
a copy of the Graphic, but it still references the same instance and
you can resize each one independently. If you save the document there
will be only one image saved.


Thanks.


And I take "the image in the document" or "The

size the image takes up in the document" seems to be the "Apparent
dimensions", 4.24" in this case.  Is it?

Yes - the document has a size and combined with the size of the image
(in the document, not what it is set in SVG) you can calculate the
actual needed DPI relative to the document.


That is, even if there are
multiple images in this document which the source is the same one (I
still don't know how to do that), shouldn't it be calculated regarding
to the "Apparent dimensions" here?  I mean, after all, that is what user
set in the document.

That's the point - what is important is the size of the image in the
document, not what the size is the SVG image.


  Since the image shown in the document is actually
4.24"x4.24", while the original svg file is 0.21"x0.21, shouldn't it be
20 times (4.24/0.21 ~= 20) DPI, that is, 96*20 = 1920 sent to xBitmap()?

Yes, that seems correct. But this is only for this case - another case
would need another factor. For example if you resize the image in the
document to 0.42 x 0.42, you would use the factor 2.


We tried to set Size(20,20) to get aDPI, or directly set aDPI to
(1920,1920), they both ended up 4.24"x4.24" with 99DPI, which is good
enough.  Do you think it a reasonable thought?

That's only for this image where 20 is correct - you would need
another number calculated per image. Also use a constant DPI factor as
I already said at the beginning, not the size of the output device.

So you will need to first find the place where conversion for the
embedded PNG and properly calculate the size at that place - not
inside this method.

The size should be the Apparent dimensions, since in the document it was
set to that size.  That's what we thought.

Yes - it needs to be the size in the document, not the size of SVG.


BTW, if so, how can we get the Apparent dimensions in this method?

You will have to set it from the outside as a parameter - as it
depends on the image and here you don't have the information.


So, that's what we thought - to calculate the necessary DPI by Apparent 
dimensions every time we export to docx.


Could you please give us some hint about where to get the Apparent 
dimensions?  It's not very trivial to us.  We'd like to give it a try to 
provide a patch for this issue.



Thanks for your help,

Dev


[Libreoffice-bugs] [Bug 157030] New: hypenation properties get lost when doc gets closed and reopened

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157030

Bug ID: 157030
   Summary: hypenation properties get lost when doc gets closed
and reopened
   Product: LibreOffice
   Version: 7.0.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mseyd...@web.de

Description:
When I change the values for hyphenation (characters at line end/begin) from
default "2" to "3", klick ok, check the document, everything is as expected.
When I close the document and reopen it, both values (and some others) are
default again, also the text isnt processed as expected.


Steps to Reproduce:
1. open a document with some pages (in my case 400 pages)
2. place cursor in a paragraph with "default paragraph style"
3. open menu styles -> edit style -> text flow
4. check "automatically" and change values for "characters at line end/begin"
to 3 (default is 2)
5. broken words are now as expected at least 3 characters long.
6. close and reopen the document and look for words broken after 2 characters.
If there are any, thats not good.
7. open the dialog-box and look for the values mentioned above. In my case
they're always "2"

Actual Results:
values didnt get saved
after reopen I have a different document, with differen line-breaks and
different document-length and pages.

Expected Results:
values should be saved.


Reproducible: Always


User Profile Reset: No

Additional Info:
Working with Debian/Rasbian, Raspberry pi, regulary updated.
German installation, english language-settings but german hypenation-file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

2023-08-30 Thread Kohei Yoshida (via logerrit)
 sc/source/filter/inc/orcusinterface.hxx   |   15 
 sc/source/filter/orcus/interface.cxx  |   82 --
 sc/source/ui/dataprovider/xmldataprovider.cxx |2 
 3 files changed, 79 insertions(+), 20 deletions(-)

New commits:
commit 695ae365dcab7c7dd59b39411299c5c200081885
Author: Kohei Yoshida 
AuthorDate: Tue Aug 29 22:13:32 2023 -0400
Commit: Kohei Yoshida 
CommitDate: Thu Aug 31 03:03:29 2023 +0200

Add support for rich-text string import via orcus interface

It was previously imported only as non-formatted strings.  Font names
and sizes are to be imported later.

Change-Id: I93a313851e87f1d6d9ccc409ca9a9f1abff3de0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156271
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida 

diff --git a/sc/source/filter/inc/orcusinterface.hxx 
b/sc/source/filter/inc/orcusinterface.hxx
index ed3966a2e136..2fd1d5ed40f3 100644
--- a/sc/source/filter/inc/orcusinterface.hxx
+++ b/sc/source/filter/inc/orcusinterface.hxx
@@ -11,10 +11,12 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
 #include 
+#include 
 
 #include "sharedformulagroups.hxx"
 
@@ -30,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class ScOrcusSheet;
 class ScOrcusStyles;
@@ -103,8 +106,13 @@ public:
 class ScOrcusSharedStrings : public 
orcus::spreadsheet::iface::import_shared_strings
 {
 ScOrcusFactory& mrFactory;
+ScFieldEditEngine& mrEditEngine;
+
+SfxItemSet maCurFormat;
+std::vector> maFormatSegments;
+
+OUString toOUString(std::string_view s);
 
-OStringBuffer maCurSegment;
 public:
 ScOrcusSharedStrings(ScOrcusFactory& rFactory);
 
@@ -696,12 +704,13 @@ class ScOrcusFactory : public 
orcus::spreadsheet::iface::import_factory
 CellStoreToken( const ScAddress& rPos, OUString aFormula, 
formula::FormulaGrammar::Grammar eGrammar );
 };
 
+using StringValueType = std::variant>;
 typedef std::unordered_map StringHashType;
 typedef std::vector CellStoreTokensType;
 
 ScDocumentImport maDoc;
 
-std::vector maStrings;
+std::vector maStrings;
 StringHashType maStringHash;
 
 CellStoreTokensType maCellStoreTokens;
@@ -735,6 +744,8 @@ public:
 
 size_t appendString(const OUString& rStr);
 size_t addString(const OUString& rStr);
+std::size_t appendFormattedString(std::unique_ptr 
pEditText);
+
 const OUString* getString(size_t nIndex) const;
 
 void pushCellStoreAutoToken( const ScAddress& rPos, const OUString& rVal );
diff --git a/sc/source/filter/orcus/interface.cxx 
b/sc/source/filter/orcus/interface.cxx
index a61d545d9151..c2c784a5a016 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -37,6 +37,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -455,7 +456,16 @@ void ScOrcusFactory::finalize()
 // String index out-of-bound!  Something is up.
 break;
 
-maDoc.setStringCell(rToken.maPos, maStrings[rToken.mnIndex1]);
+const auto& s = maStrings[rToken.mnIndex1];
+switch (s.index())
+{
+case 0: // OUString
+maDoc.setStringCell(rToken.maPos, std::get<0>(s));
+break;
+case 1: // std::unique_ptr
+maDoc.setEditCell(rToken.maPos, 
std::get<1>(s)->Clone());
+break;
+}
 ++nCellCount;
 break;
 }
@@ -577,9 +587,23 @@ size_t ScOrcusFactory::addString(const OUString& rStr)
 return appendString(rStr);
 }
 
+std::size_t 
ScOrcusFactory::appendFormattedString(std::unique_ptr pEditText)
+{
+std::size_t nPos = maStrings.size();
+maStrings.push_back(std::move(pEditText));
+return nPos;
+}
+
 const OUString* ScOrcusFactory::getString(size_t nIndex) const
 {
-return nIndex < maStrings.size() ? [nIndex] : nullptr;
+if (nIndex >= maStrings.size())
+return nullptr;
+
+const StringValueType& rStr = maStrings[nIndex];
+if (rStr.index() != 0)
+return nullptr;
+
+return ::get(rStr);
 }
 
 void ScOrcusFactory::pushCellStoreAutoToken( const ScAddress& rPos, const 
OUString& rVal )
@@ -1294,31 +1318,43 @@ ScOrcusFactory& ScOrcusSheet::getFactory()
 return mrFactory;
 }
 
+OUString ScOrcusSharedStrings::toOUString(std::string_view s)
+{
+return {s.data(), sal_Int32(s.size()), 
mrFactory.getGlobalSettings().getTextEncoding()};
+}
+
 ScOrcusSharedStrings::ScOrcusSharedStrings(ScOrcusFactory& rFactory) :
-mrFactory(rFactory) {}
+mrFactory(rFactory),
+mrEditEngine(rFactory.getDoc().getDoc().GetEditEngine()),
+maCurFormat(mrEditEngine.GetEmptyItemSet())
+{
+mrEditEngine.Clear();
+}
 
 size_t ScOrcusSharedStrings::append(std::string_view s)
 {
-OUString aNewString(s.data(), s.size(), 

[Libreoffice-bugs] [Bug 157022] Freeze for 8-10 seconds when inserting/deleting a row

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157022

Telesto  changed:

   What|Removed |Added

 CC||michael.st...@allotropia.de
   Keywords||perf

--- Comment #4 from Telesto  ---
Follow-up on: bug 156551

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157029] Korean Font in UI is mismatched on English version of Windows & LibreOffice

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157029

--- Comment #1 from baesoft...@gmail.com ---
Created attachment 189272
  --> https://bugs.documentfoundation.org/attachment.cgi?id=189272=edit
Korean font is mismatched

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157029] New: Korean Font in UI is mismatched on English version of Windows & LibreOffice

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157029

Bug ID: 157029
   Summary: Korean Font in UI is mismatched on English version of
Windows & LibreOffice
   Product: LibreOffice
   Version: 7.5.5.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: baesoft...@gmail.com

Description:
Font is mismatched on English of Windows & LibreOffice. Default font set by
Windows is "Malgun Gothic (맑은 고딕)", but UI Font of LibreOffice is something
else.

Steps to Reproduce:
1. Install English Version of Libreoffice on English Version of Windows
2. Install several 3rd party Korean-focused Fonts
(Ex. Noto Sans KR, NanumGothic(나눔 고딕))
3. Enable Korean Input, save document to Korean

1. 영문 버전의 Windows에서 LibreOffice 영문판을 설치합니다.
2. 한글 폰트를 설치합니다. (예. Noto Sans KR, 나눔고딕)
3. 한국어 입력기를 활성화하고, 한글로 문서를 저장합니다.

Actual Results:
Font is mismatched. Default font set by Windows is "Malgun Gothic (맑은 고딕)", but
UI Font of LibreOffice is something else.

UI 폰트가 다릅니다. Windows에서 기본으로 지정한 폰트는 맑은 고딕이지만, LibreOffice에서는 맑은 고딕이 아닌 다른 폰트를
사용합니다.

Expected Results:
Set default Korean font on UI to "Malgun Gothic(맑은 고딕)"

한글을 표시하는 UI 폰트를 맑은 고딕으로 지정해야 할 것 같습니다.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e
CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157014] Comment style inherited from default text style

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157014

--- Comment #3 from m.a.riosv  ---
Even if inheriting from default, you can modify the new style 'Comments'.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154492] Presentation Styles aren't.

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154492

--- Comment #15 from Regina Henschel  ---
"Presentation Styles" are styles, which are only available in Impress, whereas
"Drawing Styles" are available in Draw too and hopefully soon in Calc and
Writer. So you should read "Presentation Styles" as "Styles which are used in
presentations for objects which are specific for presentations". And "Drawing
Styles" are "Styles for all kind of drawing objects, regardless whether they
are used in Impress or Draw".

"Presentation Styles" are connected to a master page. If you change such style,
when you are not in master view, the master page of the current page is
affected.

Some of these styles are bound to certain objects of the master page. These are
"Title", "Subtitle" and the "Outline"-styles. The "Background objects" style is
used for all other objects on a master page. Footer, Date/Time and Page number
fields belong to this group too, but you will notice it only if you remove the
direct formatting which they have got as default.
The "Background" is for the background of the master page. "Notes" is for the
object, were you enter your notes to a slide.

"Title", "Subtitle", "Outline" and "Notes" are not simple drawing objects, but
they have a placeholder feature.

When you examine these objects with the Development Tools and look at their
ShapeType, you will see, that they are of kind com.sun.star.presentation,
whereas other objects are of kind com.sun.star.drawing.

So for me "Presentation Styles" is a correct short label. If a little bit
longer text is possible, then "presentation specific styles" might work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139007] [META] PDF accessibility

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139007

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||157028


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157028
[Bug 157028] FILESAVE PDF Tagged PDF export makes file size grow significantly
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157028] New: FILESAVE PDF Tagged PDF export makes file size grow significantly

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157028

Bug ID: 157028
   Summary: FILESAVE PDF Tagged PDF export makes file size grow
significantly
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 139007

This is a followup on
https://bugs.documentfoundation.org/show_bug.cgi?id=39667#c12 

When for example the document
http://www.microsoft.com/investor/reports/ar13/docs/2013_Annual_Report.docx is
exported to PDF without enabling Tagged PDF option is about 600 KB in size, but
with enabled Tagged PDF it is 3600 KB. 
For comparison the same file exported from Word 2016 as tagged PDF is about
1600 KB.
It would be nice to reduce the extensive marking resulting disk space waste.

1. Download and open
http://www.microsoft.com/investor/reports/ar13/docs/2013_Annual_Report.docx 
2. File - Export As - PDF , check Tagged PDF (add document structure) option
3. Press the Export button
-> resulting files size is multiple of the original docx file size

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 33ae7c12bbdf19b76ced472ca8aed6cf66477bbe
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139007
[Bug 139007] [META] PDF accessibility
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156995] Selecting an embedded SVG is extremely slow in Linux

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156995

--- Comment #8 from Peter Bleszynski  ---
Slow selecting occurs in every Linux I have tested so far.

Clear Linux

Version: 7.6.0.3 (X86_64) / LibreOffice Community
Build ID: 60(Build:3)
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Ubuntu 22.04 #1 (standard kernel)

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 4:7.5.5~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded

Ubuntu 22.04 #2 (hwe kernel)

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 4:7.5.5~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded


It's also slow in a clean install of Ubuntu 23.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156995] Selecting an embedded SVG is extremely slow in Linux

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156995

--- Comment #7 from Peter Bleszynski  ---
Selection seems immediate in Windows and MacOS in recent versions of LO.  

It's interesting that Linux select in Navigator is fast while select in
document canvas is very slow.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157014] Comment style inherited from default text style

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157014

--- Comment #2 from Nadie Nada Nunca  ---
You may well be right, but not all users are as organized as we are (the
document I'm working on is good evidence of that), plus EVEN IF the user is
very organized and knows what they are doing when modifying the default style,
they have no good reason to think they are ALSO modifying the aspect of
comments. 

Document text is one thing and comments are another thing entirely. One
shouldn't affect another. It's common sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154492] Presentation Styles aren't.

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154492

--- Comment #14 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #13)
> Please find support for your POV

The support is the structure of the styles sidebar and the grammar of the
English language. The styles sidebar has "Styles of X" categories - for
different kinds of entities X. Each of these categories only has styles which
can apply to X objects, and nothing else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149625] FORMATTING: Pasting a table cell, pastes the source cell in the upper/actual cell as an inner table cell

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149625

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||eyalr...@gmx.com

--- Comment #22 from Eyal Rozenberg  ---
Someone please update regarding the status of this bug, which I can't reproduce
with v7.6.0.3 and apparently other commenters as well. Is it completely gone?
Does it occur in other cases? What's the ask right now? I'm confused.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149625] FORMATTING: Pasting a table cell, pastes the source cell in the upper/actual cell as an inner table cell

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149625

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||eyalr...@gmx.com

--- Comment #22 from Eyal Rozenberg  ---
Someone please update regarding the status of this bug, which I can't reproduce
with v7.6.0.3 and apparently other commenters as well. Is it completely gone?
Does it occur in other cases? What's the ask right now? I'm confused.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129434] [META] Writer (EDITING) Suggested bug fixes, enhancements and features for authors.

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129434
Bug 129434 depends on bug 150280, which changed state.

Bug 150280 Summary: After pasting shape 3x, save, close and reopen, middle copy 
has no fill
https://bugs.documentfoundation.org/show_bug.cgi?id=150280

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150280] After pasting shape 3x, save, close and reopen, middle copy has no fill

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150280

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
Ok, let's close as "works for me" then.
The sample document is interesting though, might be worth opening a new report
related to the missing shape style and related error messages Bogdan shared.
Any info about how those shapes were created would be helpful.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157016] 'Show bars side by side' setting in 'data series' options is not saved in file at all

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157016

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO

--- Comment #10 from m.a.riosv  ---
Is the option available in Excel?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157015] Super slow performance/navigation in Calc when hiding all unused rows and columns in a spreadsheet

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157015

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Looks a bit when the hidden rows/columns are in the window.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 33ae7c12bbdf19b76ced472ca8aed6cf66477bbe
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157014] Comment style inherited from default text style

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157014

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
IMHO, the point is that the default style should not be modified, instead a new
style should be used for that.
The modification of the default style should be restricted to those options to
be applied as a basis for the whole document, such as the font for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150280] After pasting shape 3x, save, close and reopen, middle copy has no fill

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150280

--- Comment #10 from Hildo  ---
No. I can not reproduce the error anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156970] Revert 7.6 Style Box in Menu Bar to 7.5 Style Box in Menu Bar

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156970

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2666

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
The relevant enhancement request is bug 152666. Please see there the rationale.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157013] Clumsy navigation in document with tracked changes

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157013

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m.a.riosv  ---
Please attach a sample file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157002] Leading Zeros search and replace fails

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157002

m.a.riosv  changed:

   What|Removed |Added

 Resolution|FIXED   |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156842] Export to PDF that includes PDF images are incorrect in size (macOS)

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156842

--- Comment #12 from Patrick Luby  ---
(In reply to Patrick Luby from comment #11)
> So, I suspect scaling should be applied to /BBox instead of /Matrix. Next
> step is to find where the above numbers are set in the code.

So I found the code where the scaling occurs. If you apply the following debug
patch, the bug no longer occurs. My conclusion is that the the image is 1024
DPI but the code currently assumes the default PDF DPI of 127. Next step is to
see if I can somehow resolve these two different DPI values:


diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 55ed6d514b9d..88e2afcdde06 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -9068,7 +9068,8 @@ void PDFWriterImpl::writeReferenceXObject(const
ReferenceXObjectEmit& rEmit)
 // Count /Matrix and /BBox.
 // vcl::ImportPDF() uses getDefaultPdfResolutionDpi to set the desired
 // rendering DPI so we have to take into account that here too.
-static const double fResolutionDPI =
vcl::pdf::getDefaultPdfResolutionDpi();
+// static const double fResolutionDPI =
vcl::pdf::getDefaultPdfResolutionDpi();
+static const double fResolutionDPI = 1024;

 sal_Int32 nOldDPIX = GetDPIX();
 sal_Int32 nOldDPIY = GetDPIY();

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157027] libreoffice calc does not open

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157027

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Are you really using version 4.4.7.2 ?
Please use a recent version from
https://www.libreoffice.org/download/download-libreoffice/ and if you can still
reproduce the issue, share with us the version number and your OS and desktop
environment details.
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157002] Leading Zeros search and replace fails

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157002

Paul  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #5 from Paul  ---
Thank you. 
That explains my misreading of the docs.

What I thought I was going to get was:

0001
0123

I'll head back to the drawing board. Sorry for the misreport.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107237

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|152534  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152534
[Bug 152534] Win11 dark theme support--Active selections have light blue
background which makes white icons and text almost invisible
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152534] Win11 dark theme support--Active selections have light blue background which makes white icons and text almost invisible

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152534

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Win11 dark theme|Win11 dark theme
   |support--Active selections  |support--Active selections
   |on Notebook Bar and Sidebar |have light blue background
   |UI have light blue  |which makes white icons and
   |background which makes the  |text almost invisible
   |white icon almost invisible |
 Blocks|107237  |

--- Comment #28 from Stéphane Guillou (stragu) 
 ---
Removing "notebook bar and sidebar UI" from the summary as
https://libreofficemaster.blogspot.com/2022/03/libreoffice-dark-mode-on-windows.html
shows it in the standard toolbars as well.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107237
[Bug 107237] [META] Notebookbar Tabbed
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124910] xmlsec: Build fails with error: ‘SEC_OID_SHA224’ undeclared (first use in this function); did you mean ‘SEC_OID_SHA384’?

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124910

Julien Nabet  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #15 from Julien Nabet  ---
Thank you for the feedback.
Let's put this one to WFM then and if someone reproduces the pb, don't hesitate
to reopen this tracker or rather send a message on dev mailing list or IRC
since it's a build pb.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152534] Win11 dark theme support--Active selections on Notebook Bar and Sidebar UI have light blue background which makes the white icon almost invisible

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152534

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||l.thieu...@protonmail.ch

--- Comment #27 from Stéphane Guillou (stragu) 
 ---
*** Bug 157017 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157017] Toolbar display in dark mode - annoying highlighting

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157017

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Pretty confident this is a duplicate of bug 152534.
Please let us know if you think it doesn't match, L. Thieulin.
Thank you!

*** This bug has been marked as a duplicate of bug 152534 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156885] add toggle to show / hide authorship metadata in popup Calc comments

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156885

--- Comment #11 from Eyal Rozenberg  ---
My opinion:

* Showing or hiding authorship metadata should indeed be toggle-able.
* It should be off by default
* The toggle should not be difficult to locate. Perhaps such a (global) toggle
could appear even in the in-comment context menu.
* We could very well consider such a toggle for other modules; the fact that
they don't have a toggle is not a reason to avoid adding one in Calc
(especially since it seems to matter more here)
* It would be even better if the timestamp and the author could be toggled
separately from each other. I might care about the date but know all comments
are from just one person, for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 156885] add toggle to show / hide authorship metadata in popup Calc comments

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156885

--- Comment #11 from Eyal Rozenberg  ---
My opinion:

* Showing or hiding authorship metadata should indeed be toggle-able.
* It should be off by default
* The toggle should not be difficult to locate. Perhaps such a (global) toggle
could appear even in the in-comment context menu.
* We could very well consider such a toggle for other modules; the fact that
they don't have a toggle is not a reason to avoid adding one in Calc
(especially since it seems to matter more here)
* It would be even better if the timestamp and the author could be toggled
separately from each other. I might care about the date but know all comments
are from just one person, for example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157022


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157022
[Bug 157022] Freeze for 8-10 seconds when inserting/deleting a row
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157022] Freeze for 8-10 seconds when inserting/deleting a row

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157022

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||notBibisectable, regression
 Status|UNCONFIRMED |NEW
 Blocks||103100
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Confirmed in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 642f2d7177ea3e6c365da2c2082a50a5137cd988
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Not reproduced in 7.4.7.2.

I'm calling it "notBibisectable" because the bug 156551 regression makes it
impossible to have the sample document open in a usable state in 7.5 since
commits 560b94971b656914d17c9d1befdad2dbd3f1119a. FWIW, not reproduced before
that commit.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130668] Android (CO): Squares instead special characters on slide

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130668

Timur  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Timur  ---
Ok for me in 21.11 and 23.05 snapshot.
Those bugs should be reported to Collabora Online Github.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157027] New: libreoffice calc does not open

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157027

Bug ID: 157027
   Summary: libreoffice calc does not open
   Product: LibreOffice
   Version: 4.4.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: johnwat...@aol.com

Description:
libreoffice calc does not open either by double-clicking on it or by
right-clicking and selecting new spreadsheet.

Steps to Reproduce:
1.open activities window
2.select libreoffice calc
3.right-click on it and select new spreadsheet.

Actual Results:
the circle appears indicating the program is opening, then the circle goes away
but the application does not open.

Expected Results:
the application should have opened for use.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Not available because the application does not open.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145022] Collabora Office: bug of comment appearing when added to a table cell

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145022

--- Comment #4 from Timur  ---
In addition to what is written, I add that 6.4 is very old version of Collabora
Android app.
Latest is 21.11 and soon to be released 23.05 can be tested as a snapshot.
https://www.collaboraoffice.com/downloads/Collabora-Office-Android-Snapshot/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157026] New: Align commands should appear in the Table tab of the Notebookbar when a table is selected

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157026

Bug ID: 157026
   Summary: Align commands should appear in the Table tab of the
Notebookbar when a table is selected
   Product: LibreOffice
   Version: 7.5.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

When you add a table to an Impress presentation and select the table, the
"Table" tab of the notebookbar is shown. However, this tab is missing the
"Align Objects" commands, which are very useful to f.i. center the table
horizontally/vertically on the slide.

Steps to reproduce
0) Make sure you're using the Tabbed UI
1) Create an empty presentation
2) Add a table to the current slide
3) Select the table
4) Notice the "Table" tab is selected, but it does not have the Align Object
commands

These commands exist and work fine with tables... they currently can be
accessed if you select the table and open the context menu.

So I propose we add these commands to the Table tab of the Tabbed UI.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157002] Leading Zeros search and replace fails

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157002

--- Comment #4 from m.a.riosv  ---
I don't understand what you are trying to do.
^[0-9] searches for a number at the beginning of the cell.
& replace what is founded for itself.

If you want to add zeroes at the beginning, in replace put:
0&
but as in the cell are numbers (not text) left zeroes are lost.
So replacing with:
'0&
they became text and the left zero is added.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157018] Color theme is not read on import

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157018

Regina Henschel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156989] Cycle Case on a selection of text affects text outside the block

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156989

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156989] Cycle Case on a selection of text affects text outside the block

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156989

--- Comment #6 from m.a.riosv  ---
I can't reproduce either with
Version: 7.4.7.2 (x64) / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
or
Version: 7.3.7.2 (x64) / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
or
Version: 7.2.7.2 (x64) / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: es-ES Calc: CL

Please could you test in safe mode, Menu/Help/Restart in Safe

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157025] New: List presets should include an option with a dash "-"

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157025

Bug ID: 157025
   Summary: List presets should include an option with a dash "-"
   Product: LibreOffice
   Version: 7.5.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

Created attachment 189271
  --> https://bugs.documentfoundation.org/attachment.cgi?id=189271=edit
Available list presets

LibreOffice Writer offers a tool to quickly format lists. However, the
available options could be better. See attached image with the currently
available options.

So we have a large and a small bullet, which are useful. Then we have 6 more
"exotic" options... but we do not have any option with a "-" dash, which is a
very common choice.

I suggest we replace one of the available presets for one that includes a dash
("em" and/or "en" dash) as the list marker.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156842] Export to PDF that includes PDF images are incorrect in size (macOS)

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156842

--- Comment #11 from Patrick Luby  ---
I took a fresh look at this bug and I no longer think the OSL_FAIL is the
actual cause this bug. AFAICT, PDFWriter::Document is only added in Writer
documents and it is apparently normal to have one or more top level struct
elements other than PDFWriter::Document or PDFWriter::NonStructElement.

So, I decided to relook at the bug to see if I can find what is causing the
scaling. I set the following environment variable and ran LibreOffice from the
command line:

  export VCL_DEBUG_DISABLE_PDFCOMPRESSION=1

This exports to PDF without any compression and I found the following in the
exported PDF file:

  << /Type /XObject /Subtype /Form /Resources << /XObject<< /Im12 12 0 R>> >>
/Matrix [ 0.0002195871 0 0 0.0002254283 0 0 ] /BBox [ 0 0 4554 4436 ]

If I edit the exported PDF manually and multiply the non-zero /Matrix elements
by 8 and divide the non-zero /BBox elements by 8 like in the following line,
the graphic renders at the right size:

  << /Type /XObject /Subtype /Form /Resources << /XObject<< /Im12 12 0 R>> >>
/Matrix [ 0.0017566968 0 0 0.0018034264 0 0 ] /BBox [ 0 0 569  556  ]

So, I suspect scaling should be applied to /BBox instead of /Matrix. Next step
is to find where the above numbers are set in the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156989] Cycle Case on a selection of text affects text outside the block

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156989

--- Comment #5 from James Craig  ---
I upgrade my copy of LO to 7.5.5.2, and the issue was resolved.

Thank you for looking at this, and sorry for the false report. I maybe guess
the issue was caught and updated sometime after 7.3.7.2.

Thank you for your help on this!!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124910] xmlsec: Build fails with error: ‘SEC_OID_SHA224’ undeclared (first use in this function); did you mean ‘SEC_OID_SHA384’?

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124910

--- Comment #14 from Paul Menzel 
 ---
Sorry, I have no spare cycles to look into this. (By the way, we have Nextcloud
and Collabora Online(?) support contract.)

If nobody has time to look into this, I guess it’s fixed in newer 7.x versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157004] Table of Contents add more tabs in Microsoft Word Document

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157004

m.a.riosv  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157019] FILEOPEN PPTX: Round corners of rectangle shape render as square corners

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157019

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
The shapes are derived from the outline placeholders. LibreOffice takes the
type of shape and the size from the definition on the master slide. It imports
them as "css.presentation.OutlineShape" which is in fact a text box.

It might be possible to detect the special case "rounded rectangle" and set the
rounded corner of the text box accordingly.

A text box does not have a property "Resize shape to fit text" but only "Fit
height to text". But that property does not shrink the shape automatically,
when its content is smaller than the current size, but only expand height if
the content would overflow otherwise. Therefore the shapes are too large. Here
the import needs to look at the shape on the slide and use its current size
instead of using the size from the master page. I don't know why the size is
correct for the third object.

A further problem is, that the layout of the master page has four outline
placeholders. That is not possible in LibreOffice, we have maximal two outline
placeholders. There exists a feature request to allow further layouts, bug
78156. 

It might be useful to split this report to address one issue at a time and to
simplify the example file as much as possible. Do you have PowerPoint on hand
to create specific examples?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152513] FORMATTING: Enhancement request [Custom Layouts]

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152513

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
Please have a look at
https://bugs.documentfoundation.org/show_bug.cgi?id=78156#c10 . Your requests
likely fit the one of the three mentioned bugs there. Please add your ideas and
wishes there and then close this bug then. If something is not covered by those
reports, please file a new report. Please keep in mind, that we cannot handle
bug reports, which cover several problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/workben

2023-08-30 Thread Caolán McNamara (via logerrit)
 vcl/workben/fodt2pdffuzzer.options |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4ffea8f932cbad912863f7df668ed7090e6f1821
Author: Caolán McNamara 
AuthorDate: Wed Aug 30 21:15:58 2023 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 30 22:17:23 2023 +0200

increase max_len for fodt2pdffuzzer

it's all gone very quiet since ofz#61511 Direct-leak

Change-Id: Ia78de8b10e89905a29c0150f9582ad769e6984a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156311
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/workben/fodt2pdffuzzer.options 
b/vcl/workben/fodt2pdffuzzer.options
index f52b0a7ed421..34d772abe884 100644
--- a/vcl/workben/fodt2pdffuzzer.options
+++ b/vcl/workben/fodt2pdffuzzer.options
@@ -1,3 +1,3 @@
 [libfuzzer]
-max_len = 12288
+max_len = 16384
 dict = odf.dict


[Libreoffice-commits] core.git: 2 commits - accessibility/inc accessibility/source

2023-08-30 Thread Noel Grandin (via logerrit)
 accessibility/inc/standard/vclxaccessibletabcontrol.hxx|4 
 accessibility/inc/standard/vclxaccessibletoolbox.hxx   |6 -
 accessibility/source/standard/vclxaccessibletabcontrol.cxx |   67 -
 accessibility/source/standard/vclxaccessibletoolbox.cxx|   33 ++
 4 files changed, 39 insertions(+), 71 deletions(-)

New commits:
commit a3f77a61c03340b79930e89d5c4045d814b93edf
Author: Noel Grandin 
AuthorDate: Wed Aug 30 14:43:18 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 30 22:16:36 2023 +0200

use concrete type for VCLXAccessibleTabControl::m_aAccessibleChildren

avoid some unnecessary casting

Change-Id: I2f6ed71fbffbcdfad18ed03dd45c12ea1f52fff6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156291
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/accessibility/inc/standard/vclxaccessibletabcontrol.hxx 
b/accessibility/inc/standard/vclxaccessibletabcontrol.hxx
index dcf515775bd7..32565c6d80ad 100644
--- a/accessibility/inc/standard/vclxaccessibletabcontrol.hxx
+++ b/accessibility/inc/standard/vclxaccessibletabcontrol.hxx
@@ -27,7 +27,7 @@
 
 #include 
 
-
+class VCLXAccessibleTabPage;
 
 
 class VCLXAccessibleTabControl final : public cppu::ImplInheritanceHelper<
@@ -35,7 +35,7 @@ class VCLXAccessibleTabControl final : public 
cppu::ImplInheritanceHelper<

css::accessibility::XAccessibleSelection>
 {
 private:
-typedef std::vector< css::uno::Reference< css::accessibility::XAccessible 
> > AccessibleChildren;
+typedef std::vector< rtl::Reference< VCLXAccessibleTabPage > > 
AccessibleChildren;
 
 AccessibleChildren  m_aAccessibleChildren;
 VclPtr  m_pTabControl;
diff --git a/accessibility/source/standard/vclxaccessibletabcontrol.cxx 
b/accessibility/source/standard/vclxaccessibletabcontrol.cxx
index 9963b51aef5f..0855b0f177aa 100644
--- a/accessibility/source/standard/vclxaccessibletabcontrol.cxx
+++ b/accessibility/source/standard/vclxaccessibletabcontrol.cxx
@@ -52,20 +52,16 @@ VCLXAccessibleTabControl::VCLXAccessibleTabControl( 
VCLXWindow* pVCLXWindow )
 m_pTabControl.clear();
 return;
 }
-m_aAccessibleChildren.assign( m_pTabControl->GetPageCount(), Reference< 
XAccessible >() );
+m_aAccessibleChildren.assign( m_pTabControl->GetPageCount(), 
rtl::Reference< VCLXAccessibleTabPage >() );
 }
 
 
 void VCLXAccessibleTabControl::UpdateFocused()
 {
-for (const Reference& xChild : m_aAccessibleChildren)
+for (const rtl::Reference& pVCLXAccessibleTabPage : 
m_aAccessibleChildren)
 {
-if ( xChild.is() )
-{
-VCLXAccessibleTabPage* pVCLXAccessibleTabPage = static_cast< 
VCLXAccessibleTabPage* >( xChild.get() );
-if ( pVCLXAccessibleTabPage )
-pVCLXAccessibleTabPage->SetFocused( 
pVCLXAccessibleTabPage->IsFocused() );
-}
+if ( pVCLXAccessibleTabPage )
+pVCLXAccessibleTabPage->SetFocused( 
pVCLXAccessibleTabPage->IsFocused() );
 }
 }
 
@@ -74,13 +70,9 @@ void VCLXAccessibleTabControl::UpdateSelected( sal_Int32 i, 
bool bSelected )
 {
 if ( i >= 0 && o3tl::make_unsigned(i) < m_aAccessibleChildren.size() )
 {
-Reference< XAccessible > xChild( m_aAccessibleChildren[i] );
-if ( xChild.is() )
-{
-VCLXAccessibleTabPage* pVCLXAccessibleTabPage = static_cast< 
VCLXAccessibleTabPage* >( xChild.get() );
-if ( pVCLXAccessibleTabPage )
-pVCLXAccessibleTabPage->SetSelected( bSelected );
-}
+rtl::Reference< VCLXAccessibleTabPage > pVCLXAccessibleTabPage( 
m_aAccessibleChildren[i] );
+if ( pVCLXAccessibleTabPage )
+pVCLXAccessibleTabPage->SetSelected( bSelected );
 }
 }
 
@@ -89,13 +81,9 @@ void VCLXAccessibleTabControl::UpdatePageText( sal_Int32 i )
 {
 if ( i >= 0 && o3tl::make_unsigned(i) < m_aAccessibleChildren.size() )
 {
-Reference< XAccessible > xChild( m_aAccessibleChildren[i] );
-if ( xChild.is() )
-{
-VCLXAccessibleTabPage* pVCLXAccessibleTabPage = static_cast< 
VCLXAccessibleTabPage* >( xChild.get() );
-if ( pVCLXAccessibleTabPage )
-pVCLXAccessibleTabPage->SetPageText( 
pVCLXAccessibleTabPage->GetPageText() );
-}
+rtl::Reference< VCLXAccessibleTabPage > pVCLXAccessibleTabPage( 
m_aAccessibleChildren[i] );
+if ( pVCLXAccessibleTabPage )
+pVCLXAccessibleTabPage->SetPageText( 
pVCLXAccessibleTabPage->GetPageText() );
 }
 }
 
@@ -104,13 +92,9 @@ void VCLXAccessibleTabControl::UpdateTabPage( sal_Int32 i, 
bool bNew )
 {
 if ( i >= 0 && o3tl::make_unsigned(i) < m_aAccessibleChildren.size() )
 {
-Reference< XAccessible > xChild( m_aAccessibleChildren[i] );
-if ( xChild.is() )
-{
-VCLXAccessibleTabPage* pVCLXAccessibleTabPage = static_cast< 
VCLXAccessibleTabPage* >( 

[Libreoffice-bugs] [Bug 156454] Indication of which table rows are considered heading rows is "hidden away" from the user

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156454

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7024

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 156454] Indication of which table rows are considered heading rows is "hidden away" from the user

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156454

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7024

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157024] Table pseudo-styles ignore the number of table heading rows

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157024

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||6454
 Blocks||103100, 107553


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=107553
[Bug 107553] [META] Writer table styles bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107553] [META] Writer table styles bugs and enhancements

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107553

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157024


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157024
[Bug 157024] Table pseudo-styles ignore the number of table heading rows
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157024


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157024
[Bug 157024] Table pseudo-styles ignore the number of table heading rows
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157024] Table pseudo-styles ignore the number of table heading rows

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157024

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||6454
 Blocks||103100, 107553


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=107553
[Bug 107553] [META] Writer table styles bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157024] New: Table pseudo-styles ignore the number of table heading rows

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157024

Bug ID: 157024
   Summary: Table pseudo-styles ignore the number of table heading
rows
   Product: LibreOffice
   Version: 7.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Writer supports setting some table rows as heading rows (which also repeat
across pages). Writer also has "styles" one can apply to tables; and those
include formatting for the table header.

However, when we apply a table "style", which involves header row formatting -
exactly one row gets this formatting, regardless of how many heading rows
exist, including the case of there being no heading rows. Applying the style
does not even coerce the number of heading rows 1.

Instead, the application of a table style should respect the number of heading
rows set for the table. 


Moreover, when the number of heading rows changes - the header row style should
apply, or be unapplied, to the rows which change status. However this part of
the bug is unlikely to be fixed without addressing the fact that table "styles"
are not actual styles; see bug 151264.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: dictionaries

2023-08-30 Thread Ismael Olea (via logerrit)
 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0974b4e97320a43040201557ff9c648a5f582b29
Author: Ismael Olea 
AuthorDate: Wed Aug 30 21:56:28 2023 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Aug 30 21:56:28 2023 +0200

Update git submodules

* Update dictionaries from branch 'master'
  to c1ddcf602ba97f8e99383f34e8027074d8193f61
  - Updating RLA-ES Spanish spellcheker to v2.8.

Change-Id: I749268a6e38e65e86633f39ea14710893cb6b468
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/156268
Reviewed-by: Adolfo Jayme Barrientos 
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/dictionaries b/dictionaries
index 14689ec8caae..c1ddcf602ba9 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 14689ec8caaecc2e58281e1876beb2800285be14
+Subproject commit c1ddcf602ba97f8e99383f34e8027074d8193f61


[Libreoffice-commits] dictionaries.git: Dictionary_es.mk es/description.xml es/dictionaries.xcu es/es.aff es/es_AR.dic es/es_BO.dic es/es_CL.dic es/es_CO.dic es/es_CR.dic es/es_CU.dic es/es.dic es/es_

2023-08-30 Thread Ismael Olea (via logerrit)
 Dictionary_es.mk   |7 
 es/description.xml |2 
 es/dictionaries.xcu|   15 
 es/es.aff  | 6907 
 es/es.dic  |70159 -
 es/es_AR.dic   |  106 
 es/es_BO.dic   |  106 
 es/es_CL.dic   |  107 
 es/es_CO.dic   |  107 
 es/es_CR.dic   |  110 
 es/es_CU.dic   |  106 
 es/es_DO.dic   |  106 
 es/es_EC.dic   |  109 
 es/es_ES.dic   |  106 
 es/es_GQ.dic   |  119 
 es/es_GT.dic   |  112 
 es/es_HN.dic   |  114 
 es/es_MX.dic   |  115 
 es/es_NI.dic   |  113 
 es/es_PA.dic   |  108 
 es/es_PE.dic   |  106 
 es/es_PH.dic   |  109 
 es/es_PR.dic   |  106 
 es/es_PY.dic   |  106 
 es/es_SV.dic   |  109 
 es/es_US.dic   |  106 
 es/es_UY.dic   |  106 
 es/es_VE.dic   |  106 
 es/package-description.txt |2 
 29 files changed, 2113 insertions(+), 77477 deletions(-)

New commits:
commit c1ddcf602ba97f8e99383f34e8027074d8193f61
Author: Ismael Olea 
AuthorDate: Tue Aug 29 22:32:49 2023 +0200
Commit: Thorsten Behrens 
CommitDate: Wed Aug 30 21:56:28 2023 +0200

Updating RLA-ES Spanish spellcheker to v2.8.

Change-Id: I749268a6e38e65e86633f39ea14710893cb6b468
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/156268
Reviewed-by: Adolfo Jayme Barrientos 
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/Dictionary_es.mk b/Dictionary_es.mk
index 5c9af0b..4a67121 100644
--- a/Dictionary_es.mk
+++ b/Dictionary_es.mk
@@ -9,9 +9,11 @@
 
 $(eval $(call gb_Dictionary_Dictionary,dict-es,dictionaries/es))
 
+$(eval $(call gb_Dictionary_add_files,dict-es,images,\
+dictionaries/es/RLA-ES.png \
+))
+
 $(eval $(call gb_Dictionary_add_root_files,dict-es,\
-   dictionaries/es/es.aff \
-   dictionaries/es/es.dic \
dictionaries/es/es_AR.aff \
dictionaries/es/es_AR.dic \
dictionaries/es/es_BO.aff \
@@ -63,7 +65,6 @@ $(eval $(call gb_Dictionary_add_root_files,dict-es,\
dictionaries/es/README_hunspell_es.txt \
dictionaries/es/README_hyph_es.txt \
dictionaries/es/README_th_es.txt \
-   dictionaries/es/RLA-ES.png \
dictionaries/es/LICENSE.md \
 ))
 
diff --git a/es/description.xml b/es/description.xml
index b605717..4a89f6d 100644
--- a/es/description.xml
+++ b/es/description.xml
@@ -1,7 +1,7 @@
 
 http://openoffice.org/extensions/description/2006; 
xmlns:d="http://openoffice.org/extensions/description/2006;  
xmlns:xlink="http://www.w3.org/1999/xlink;>
 
-  
+  
   
 
   
diff --git a/es/dictionaries.xcu b/es/dictionaries.xcu
index b453842..2f0c440 100644
--- a/es/dictionaries.xcu
+++ b/es/dictionaries.xcu
@@ -2,17 +2,6 @@
 http://openoffice.org/2001/registry; 
xmlns:xs="http://www.w3.org/2001/XMLSchema; oor:name="Linguistic" 
oor:package="org.openoffice.Office">
  
 
-
-
-%origin%/es.aff %origin%/es.dic
-
-
-DICT_SPELL
-
-
-es es-AR es-BO es-CL es-CO es-CR es-CU es-DO es-EC 
es-ES es-GQ es-GT es-HN es-MX es-NI es-PA es-PE es-PH es-PR es-PY es-SV es-US 
es-UY es-VE
-
-
 
 
 %origin%/es_AR.aff %origin%/es_AR.dic
@@ -274,7 +263,7 @@
 DICT_HYPH
 
 
-es es-AR es-BO es-CL es-CO es-CR es-CU es-DO es-EC 
es-ES es-GQ es-GT es-HN es-MX es-NI es-PA es-PE es-PH es-PR es-PY es-SV es-US 
es-UY es-VE
+es-AR es-BO es-CL es-CO es-CR es-CU es-DO es-EC es-ES 
es-GQ es-GT es-HN es-MX es-NI es-PA es-PE es-PH es-PR es-PY es-SV es-US es-UY 
es-VE
 
 
 
@@ -285,7 +274,7 @@
 DICT_THES
 
 
-es es-AR es-BO es-CL es-CO es-CR es-CU es-DO es-EC 
es-ES es-GQ es-GT es-HN es-MX es-NI es-PA es-PE es-PH es-PR es-PY es-SV es-US 
es-UY es-VE
+es-AR es-BO es-CL es-CO es-CR es-CU es-DO es-EC es-ES 
es-GQ es-GT es-HN es-MX es-NI es-PA es-PE es-PH es-PR es-PY es-SV es-US es-UY 
es-VE
 
 
 
diff --git a/es/es.aff b/es/es.aff
deleted file mode 100644
index 53eec9c..000
--- a/es/es.aff
+++ /dev/null
@@ -1,6907 +0,0 @@
-SET UTF-8
-FLAG UTF-8
-TRY aeroinsctldumpbgfvhzóíjáqéñxyúükwAEROINSCTLDUMPBGFVHZÓÍJÁQÉÑXYÚÜKW
-REP 19
-REP ás az
-REP az ás
-REP cc x
-REP és ez
-REP ez és
-REP güe hue
-REP güi hui
-REP hue güe
-REP hui güi
-REP ís iz
-REP ío ido
-REP ke que
-REP ki qui
-REP ll y
-REP mb nv
-REP nv mb
-REP seci cesi
-REP x cc
-REP y ll
-MAP 5
-MAP aáAÁ
-MAP eéEÉ
-MAP iíIÍ
-MAP oóOÓ
-MAP uúüUÚÜ
-PFX a Y 2
-PFX a 0 a [^aeiou]
-PFX a 0 an [aeiou]
-PFX b Y 1
-PFX b 0 ante .
-PFX c Y 2
-PFX c 0 anti [^r]

[Libreoffice-commits] core.git: basctl/source

2023-08-30 Thread Noel Grandin (via logerrit)
 basctl/source/accessibility/accessibledialogwindow.cxx |   50 +
 basctl/source/inc/accessibledialogwindow.hxx   |6 +-
 2 files changed, 19 insertions(+), 37 deletions(-)

New commits:
commit b58aeda083b245bd12b31f53c0fb1717af188cc4
Author: Noel Grandin 
AuthorDate: Wed Aug 30 13:55:05 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 30 21:36:17 2023 +0200

use concrete type for ChildDescriptor::mxAccessible

avoid some unnecessary casting

Change-Id: I23e0257d1831c1c43d2d646d4ff8e1d654c0b528
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156289
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basctl/source/accessibility/accessibledialogwindow.cxx 
b/basctl/source/accessibility/accessibledialogwindow.cxx
index 71a41aa6848a..9b17f3cf4caa 100644
--- a/basctl/source/accessibility/accessibledialogwindow.cxx
+++ b/basctl/source/accessibility/accessibledialogwindow.cxx
@@ -120,13 +120,8 @@ void AccessibleDialogWindow::UpdateFocused()
 {
 for (const ChildDescriptor & i : m_aAccessibleChildren)
 {
-Reference< XAccessible > xChild( i.rxAccessible );
-if ( xChild.is() )
-{
-AccessibleDialogControlShape* pShape = static_cast< 
AccessibleDialogControlShape* >( xChild.get() );
-if ( pShape )
-pShape->SetFocused( pShape->IsFocused() );
-}
+if ( i.mxAccessible )
+i.mxAccessible->SetFocused( i.mxAccessible->IsFocused() );
 }
 }
 
@@ -137,13 +132,8 @@ void AccessibleDialogWindow::UpdateSelected()
 
 for (const ChildDescriptor & i : m_aAccessibleChildren)
 {
-Reference< XAccessible > xChild( i.rxAccessible );
-if ( xChild.is() )
-{
-AccessibleDialogControlShape* pShape = static_cast< 
AccessibleDialogControlShape* >( xChild.get() );
-if ( pShape )
-pShape->SetSelected( pShape->IsSelected() );
-}
+if ( i.mxAccessible )
+i.mxAccessible->SetSelected( i.mxAccessible->IsSelected() );
 }
 }
 
@@ -152,13 +142,8 @@ void AccessibleDialogWindow::UpdateBounds()
 {
 for (const ChildDescriptor & i : m_aAccessibleChildren)
 {
-Reference< XAccessible > xChild( i.rxAccessible );
-if ( xChild.is() )
-{
-AccessibleDialogControlShape* pShape = static_cast< 
AccessibleDialogControlShape* >( xChild.get() );
-if ( pShape )
-pShape->SetBounds( pShape->GetBounds() );
-}
+if ( i.mxAccessible )
+i.mxAccessible->SetBounds( i.mxAccessible->GetBounds() );
 }
 }
 
@@ -244,7 +229,7 @@ void AccessibleDialogWindow::RemoveChild( const 
ChildDescriptor& rDesc )
 return;
 
 // get the accessible of the removed child
-Reference< XAccessible > xChild( aIter->rxAccessible );
+rtl::Reference< AccessibleDialogControlShape > xChild( aIter->mxAccessible 
);
 
 // remove entry from child list
 m_aAccessibleChildren.erase( aIter );
@@ -253,12 +238,11 @@ void AccessibleDialogWindow::RemoveChild( const 
ChildDescriptor& rDesc )
 if ( xChild.is() )
 {
 Any aOldValue, aNewValue;
-aOldValue <<= xChild;
+aOldValue <<= uno::Reference(xChild);
 NotifyAccessibleEvent( AccessibleEventId::CHILD, aOldValue, aNewValue 
);
 
-Reference< XComponent > xComponent( xChild, UNO_QUERY );
-if ( xComponent.is() )
-xComponent->dispose();
+if ( xChild )
+xChild->dispose();
 }
 }
 
@@ -380,9 +364,8 @@ void AccessibleDialogWindow::ProcessWindowEvent( const 
VclWindowEvent& rVclWindo
 // dispose all children
 for (const ChildDescriptor & i : m_aAccessibleChildren)
 {
-Reference< XComponent > xComponent( i.rxAccessible, 
UNO_QUERY );
-if ( xComponent.is() )
-xComponent->dispose();
+if ( i.mxAccessible )
+i.mxAccessible->dispose();
 }
 m_aAccessibleChildren.clear();
 }
@@ -514,9 +497,8 @@ void AccessibleDialogWindow::disposing()
 // dispose all children
 for (const ChildDescriptor & i : m_aAccessibleChildren)
 {
-Reference< XComponent > xComponent( i.rxAccessible, UNO_QUERY );
-if ( xComponent.is() )
-xComponent->dispose();
+if ( i.mxAccessible )
+i.mxAccessible->dispose();
 }
 m_aAccessibleChildren.clear();
 }
@@ -559,7 +541,7 @@ Reference< XAccessible > 
AccessibleDialogWindow::getAccessibleChild( sal_Int64 i
 if ( i < 0 || i >= getAccessibleChildCount() )
 throw IndexOutOfBoundsException();
 
-Reference< XAccessible > xChild = m_aAccessibleChildren[i].rxAccessible;
+rtl::Reference< AccessibleDialogControlShape > xChild = 
m_aAccessibleChildren[i].mxAccessible;
 if ( !xChild.is() )
 {

[Libreoffice-bugs] [Bug 156995] Selecting an embedded SVG is extremely slow in Linux

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156995

--- Comment #6 from Telesto  ---
(In reply to Telesto from comment #5)
> Selecting speed is so, so on Windows. Shrinking the shape is slow; dragging
> (the shrinked) shape is also slow
> Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: c9916d9be9c060d43fc063b76d70629162650fea
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
> Locale: nl-NL (nl_NL); UI: en-US
> Calc: CL threaded

Even worse in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

2023-08-30 Thread Noel Grandin (via logerrit)
 include/sfx2/thumbnailviewitem.hxx|8 ++--
 sfx2/source/control/thumbnailview.cxx |   12 ++--
 sfx2/source/control/thumbnailviewitem.cxx |4 ++--
 3 files changed, 14 insertions(+), 10 deletions(-)

New commits:
commit dbe8597ce4f8c503ac10836570a76a607b2ebb9c
Author: Noel Grandin 
AuthorDate: Wed Aug 30 13:42:09 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 30 21:33:35 2023 +0200

use concrete type for ThumbnailViewItem::mxAcc

avoid some unnecessary casting

Change-Id: I86d48cb463f4e9a1661025fa6e1f4f8c03d61eaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156287
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/sfx2/thumbnailviewitem.hxx 
b/include/sfx2/thumbnailviewitem.hxx
index 64644b772d64..7c84b344a8a0 100644
--- a/include/sfx2/thumbnailviewitem.hxx
+++ b/include/sfx2/thumbnailviewitem.hxx
@@ -27,6 +27,7 @@
 
 namespace com::sun::star::accessibility { class XAccessible; }
 namespace drawinglayer::primitive2d { class Primitive2DContainer; }
+class ThumbnailViewItemAcc;
 
 #define THUMBNAILVIEW_ITEM_NONEITEM  0xFFFE
 
@@ -76,7 +77,7 @@ public:
 BitmapEx maPreview1;
 OUString maTitle;
 OUString maHelpText;
-css::uno::Reference< css::accessibility::XAccessible > mxAcc;
+rtl::Reference< ThumbnailViewItemAcc > mxAcc;
 
 bool mbPinnedDocumentHighlighted;
 BitmapEx maPinnedDocumentBitmap;
@@ -86,6 +87,9 @@ public:
 
 virtual ~ThumbnailViewItem ();
 
+ThumbnailViewItem& operator=( ThumbnailViewItem const & ) = delete; // 
MSVC workaround
+ThumbnailViewItem( ThumbnailViewItem const & ) = delete; // MSVC workaround
+
 bool isVisible () const { return mbVisible; }
 
 void show (bool bVisible);
@@ -115,7 +119,7 @@ public:
 
 void setTitle (const OUString& rTitle);
 
-css::uno::Reference< css::accessibility::XAccessible > const &
+rtl::Reference< ThumbnailViewItemAcc > const &
 GetAccessible( bool bIsTransientChildrenDisabled );
 
 void setDrawArea (const tools::Rectangle );
diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index ca839162f0a2..12bfcb327143 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -294,7 +294,7 @@ void ThumbnailView::ImplDeleteItems()
 {
 css::uno::Any aOldAny, aNewAny;
 
-aOldAny <<= pItem->GetAccessible( false );
+aOldAny <<= 
css::uno::Reference(pItem->GetAccessible( 
false ));
 ImplFireAccessibleEvent( 
css::accessibility::AccessibleEventId::CHILD, aOldAny, aNewAny );
 }
 
@@ -438,7 +438,7 @@ void ThumbnailView::CalculateItemPositions(bool 
bScrollBarUsed)
 {
 css::uno::Any aOldAny, aNewAny;
 
-aNewAny <<= pItem->GetAccessible( false );
+aNewAny <<= 
css::uno::Reference(pItem->GetAccessible( 
false ));
 ImplFireAccessibleEvent( 
css::accessibility::AccessibleEventId::CHILD, aOldAny, aNewAny );
 }
 
@@ -466,7 +466,7 @@ void ThumbnailView::CalculateItemPositions(bool 
bScrollBarUsed)
 {
 css::uno::Any aOldAny, aNewAny;
 
-aOldAny <<= pItem->GetAccessible( false );
+aOldAny <<= 
css::uno::Reference(pItem->GetAccessible( 
false ));
 ImplFireAccessibleEvent( 
css::accessibility::AccessibleEventId::CHILD, aOldAny, aNewAny );
 }
 
@@ -1124,12 +1124,12 @@ void ThumbnailView::SelectItem( sal_uInt16 nItemId )
 return;
 
 // focus event (select)
-ThumbnailViewItemAcc* pItemAcc = ThumbnailViewItemAcc::getImplementation( 
pItem->GetAccessible( false ) );
+const rtl::Reference & pItemAcc = 
pItem->GetAccessible( false );
 
 if( pItemAcc )
 {
 css::uno::Any aOldAny, aNewAny;
-aNewAny <<= css::uno::Reference(getXWeak( pItemAcc ));
+aNewAny <<= css::uno::Reference( 
pItemAcc );
 ImplFireAccessibleEvent( 
css::accessibility::AccessibleEventId::ACTIVE_DESCENDANT_CHANGED, aOldAny, 
aNewAny );
 }
 
@@ -1207,7 +1207,7 @@ void ThumbnailView::filterItems(const std::functionGetAccessible( false );
+aOldAny <<= 
css::uno::Reference(pItem->GetAccessible( 
false ));
 ImplFireAccessibleEvent( 
css::accessibility::AccessibleEventId::CHILD, aOldAny, aNewAny );
 }
 
diff --git a/sfx2/source/control/thumbnailviewitem.cxx 
b/sfx2/source/control/thumbnailviewitem.cxx
index ca8920acafd2..9579889e7e9a 100644
--- a/sfx2/source/control/thumbnailviewitem.cxx
+++ b/sfx2/source/control/thumbnailviewitem.cxx
@@ -67,7 +67,7 @@ ThumbnailViewItem::~ThumbnailViewItem()
 {
 if( mxAcc.is() )
 {
-static_cast< ThumbnailViewItemAcc* >( mxAcc.get() )->ParentDestroyed();
+mxAcc->ParentDestroyed();
 }
 }
 
@@ -129,7 +129,7 @@ void 

[Libreoffice-bugs] [Bug 156995] Selecting an embedded SVG is extremely slow in Linux

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156995

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl

--- Comment #5 from Telesto  ---
Selecting speed is so, so on Windows. Shrinking the shape is slow; dragging
(the shrinked) shape is also slow
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c9916d9be9c060d43fc063b76d70629162650fea
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

Minutes from the UX/design meeting 2023-Aug-30

2023-08-30 Thread Heiko Tietze

Present: Eyal, Heiko
Comments: Khaled, Stuart

Tickets/Topics

 * Ability to remove non-printing/"atypical" characters in a stretch
   of text
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156507
   + there is no such thing as exotic characters (Khaled, Stuart)
   + recommended workflow is to use advanced search and replace
 with +F10 exposing NPC, and +X showing Unicode
   => wontfix

 * The "Fast Action" Buttons to hide/unhide all grouped columns & rows
   disappear when View Headers is set to conceal headers
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156495
   + a) keep the extra space and just hide the labels
   + b) disable the command and always show headers if groups exist
   + c) accept situation since done intentionally
   => c), resp. WF; also since groups still can be shown/hidden
  individually

 * Indication of which table rows are considered heading rows is
   "hidden away" from the user
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156454
   + make a duplicate of bug 113603 "Unified table management"
 + any band-aid like some info in the context menu or
   tooltips to indicate whether a row is a header is odd
   => make a duplicate

 * Allow insertion of items into master without a selected item
   + https://bugs.documentfoundation.org/show_bug.cgi?id=155741
   + works in the floating Navigator ("Text" is always selected)
 but not when docked
   + unclear why insertion is not possible
   + having some random entry when nothing is in the document
 is weird
   + selecting the first item by default is not a solution
 since after adding a document one ends up with no selection
   => needsDevEval

 * Custom list numbering from DOCX import is not available in UI
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156598
   + new scheme allows to use %1%2 on any level
   + mockup prepared during the session
   + would like to have "%1{.%2}[2-]{.%3}[3-]{.%4}[4-]{.%5}
[5-]{.%6}[6-]{.%7}[7-]{.%8}[8-]{.%9}[9-]{.%10}[10-]" (Eyal)


OpenPGP_0xA68C0CA5EEA5F466.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


[Libreoffice-qa] Minutes from the UX/design meeting 2023-Aug-30

2023-08-30 Thread Heiko Tietze

Present: Eyal, Heiko
Comments: Khaled, Stuart

Tickets/Topics

 * Ability to remove non-printing/"atypical" characters in a stretch
   of text
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156507
   + there is no such thing as exotic characters (Khaled, Stuart)
   + recommended workflow is to use advanced search and replace
 with +F10 exposing NPC, and +X showing Unicode
   => wontfix

 * The "Fast Action" Buttons to hide/unhide all grouped columns & rows
   disappear when View Headers is set to conceal headers
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156495
   + a) keep the extra space and just hide the labels
   + b) disable the command and always show headers if groups exist
   + c) accept situation since done intentionally
   => c), resp. WF; also since groups still can be shown/hidden
  individually

 * Indication of which table rows are considered heading rows is
   "hidden away" from the user
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156454
   + make a duplicate of bug 113603 "Unified table management"
 + any band-aid like some info in the context menu or
   tooltips to indicate whether a row is a header is odd
   => make a duplicate

 * Allow insertion of items into master without a selected item
   + https://bugs.documentfoundation.org/show_bug.cgi?id=155741
   + works in the floating Navigator ("Text" is always selected)
 but not when docked
   + unclear why insertion is not possible
   + having some random entry when nothing is in the document
 is weird
   + selecting the first item by default is not a solution
 since after adding a document one ends up with no selection
   => needsDevEval

 * Custom list numbering from DOCX import is not available in UI
   + https://bugs.documentfoundation.org/show_bug.cgi?id=156598
   + new scheme allows to use %1%2 on any level
   + mockup prepared during the session
   + would like to have "%1{.%2}[2-]{.%3}[3-]{.%4}[4-]{.%5}
[5-]{.%6}[6-]{.%7}[7-]{.%8}[8-]{.%9}[9-]{.%10}[10-]" (Eyal)


OpenPGP_0xA68C0CA5EEA5F466.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: #tdf51510: Change the DPI to get better resolution, but failed the unit test

2023-08-30 Thread Tomaž Vajngerl
Hi,

On Tue, Aug 29, 2023 at 9:09 AM Lodev  wrote:
> Sorry if I'm asking a stupid question here.  First, I've never seen or
> used a document with "multiple instances that all point to the same
> image in the document".

That's easy - drag the image while holding ctrl and drop. It will make
a copy of the Graphic, but it still references the same instance and
you can resize each one independently. If you save the document there
will be only one image saved.

> And I take "the image in the document" or "The
> size the image takes up in the document" seems to be the "Apparent
> dimensions", 4.24" in this case.  Is it?

Yes - the document has a size and combined with the size of the image
(in the document, not what it is set in SVG) you can calculate the
actual needed DPI relative to the document.

> That is, even if there are
> multiple images in this document which the source is the same one (I
> still don't know how to do that), shouldn't it be calculated regarding
> to the "Apparent dimensions" here?  I mean, after all, that is what user
> set in the document.

That's the point - what is important is the size of the image in the
document, not what the size is the SVG image.

>  Since the image shown in the document is actually
> 4.24"x4.24", while the original svg file is 0.21"x0.21, shouldn't it be
> 20 times (4.24/0.21 ~= 20) DPI, that is, 96*20 = 1920 sent to xBitmap()?

Yes, that seems correct. But this is only for this case - another case
would need another factor. For example if you resize the image in the
document to 0.42 x 0.42, you would use the factor 2.

> We tried to set Size(20,20) to get aDPI, or directly set aDPI to
> (1920,1920), they both ended up 4.24"x4.24" with 99DPI, which is good
> enough.  Do you think it a reasonable thought?

That's only for this image where 20 is correct - you would need
another number calculated per image. Also use a constant DPI factor as
I already said at the beginning, not the size of the output device.

> > So you will need to first find the place where conversion for the
> > embedded PNG and properly calculate the size at that place - not
> > inside this method.
>
> The size should be the Apparent dimensions, since in the document it was
> set to that size.  That's what we thought.

Yes - it needs to be the size in the document, not the size of SVG.

> BTW, if so, how can we get the Apparent dimensions in this method?

You will have to set it from the outside as a parameter - as it
depends on the image and here you don't have the information.

> Thanks for your reply,

Tomaž


[Libreoffice-bugs] [Bug 157022] Freeze for 8-10 seconds when inserting/deleting a row

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157022

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7023

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156297] In Calc, scrolling becomes very slow when hiding (many) columns

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156297

ady  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7015

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157023] The size of sections (with tables in it) suddenly increases to bottom page after inserting a row, creating large empty area

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157023

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7022

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157015] Super slow performance/navigation in Calc when hiding all unused rows and columns in a spreadsheet

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157015

ady  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||6297
   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157023] New: The size of sections (with tables in it) suddenly increases to bottom page after inserting a row, creating large empty area

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157023

Bug ID: 157023
   Summary: The size of sections (with tables in it) suddenly
increases to bottom page after inserting a row,
creating large empty area
   Product: LibreOffice
   Version: 4.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
The size of sections (with tables in it) suddenly increases to bottom page
after inserting a row 

Steps to Reproduce:
1. Open attachment 189269 (bug 157022). (modified version of bug 156551
document)
2. Go to page 11
3. Place cursor in the table row which is marked red
4. Press Insert Row

Actual Results:
The table is embedded in a section. The section suddenly expands to page end.
Causing a large empty area

Expected Results:
No increase of the section to bottom of the page


Reproducible: Always


User Profile Reset: No

Additional Info:
Found in
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c9916d9be9c060d43fc063b76d70629162650fea
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

and in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

and in
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)

---
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

In this case the section is already to bottom of the page on file-open. So no
need to add a row needed. 

I suppose there was a change which 'fixed' the empty area on file-open. However
it appears to be a partial fix.

A bibibsect might be helpful

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156310] Cross reference does not jump to number range

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156310

sdc.bla...@youmail.dk changed:

   What|Removed |Added

Summary|Cross reference does not|Cross reference does not
   |jump to number range in a   |jump to number range
   |frame   |

--- Comment #8 from sdc.bla...@youmail.dk ---
Have re-tested, without a frame. Just insert a number range variable and then a
cross-reference to that variable.  

As expected:  Ctrl-click on cross-reference variable jumps to the number-range
variable.

Unexpected:  single-click does not jump  (but it should). 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 218a7650a5cf03f895bed19c68d6f02daec536e9
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL threaded

Updating bug summary...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152837] changing date format is not possible

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152837

ady  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||9517

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139517] Calc: Date values toggle between date and text when changed

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139517

ady  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2837

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157022] Freeze for 8-10 seconds when inserting/deleting a row

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157022

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||6551

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148159] Please check if you get error reports which are assigned to the wrong version of LibreOfficeWriter

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148159

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de

--- Comment #3 from Dieter  ---
Hello Adalbert, a new major major release of LibreOffice is available since
this bug was reported. Could you please try to  reproduce it with the latest
version of LibreOffice from
https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

Please test only with older versions, that are still under development

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157022] Freeze for 8-10 seconds when inserting/deleting a row

2023-08-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157022

--- Comment #2 from Telesto  ---
No freeze with (but still odd table distribution across)
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >