[Bug 159863] Ctl + Shift + PgDn no longer assigned to JumpToFootnoteArea

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159863

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||accessibility

--- Comment #6 from V Stuart Foote  ---
(In reply to Jason White from comment #5)
> I take the view that components of the UI that cannot be accessed via a
> keyboard by default need to be made keyboard-accessible, either through a
> menu option or a key mapping. This is generally how keyboard operability
> accessibility requirements are understood and interpreted, and justifiably
> so.

Yes, and I do verify that from 7.6.0 onward there is no keyboard only
navigation down into the footnote area currently mapped, and requiring
customization.

So a usability issue with a11y impact. Should probably map a new keyboard
shortcut, and kind of seems like a contextual menu entry somewhere would be of
use. The SB Navigator deck handling of the Footnote objects 'Go to' action only
moves focus to the anchor on the document canvas, not to the associated
footnote. 

But immediate issue here remains one of correcting documentation of the
reassigned shortcut.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159868] Option for default row height for new tables in settings window

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159868

--- Comment #4 from dani.priv...@dismail.de ---
edit: forget about cfg, i just discovered "Expert Configuration", where you can
change default font size. But not zoom or row height.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159664] Floatable table not visible in after paste in new document but shown in navigator

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159664

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com,
   ||michael.st...@allotropia.de
  Regression By||Michael Stahl
 Blocks||108843
 OS|Windows (All)   |All
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9023
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #6 from Aron Budea  ---
(In reply to Telesto from comment #0)
> 2. Type X at the top of the table

To clarify, this means the beginning of the document, above the table.

Bibisected the regression to the following commit using repo
bibisect-linux-64-24.8. Adding CC: to Michael Stahl.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b68824d18316762a6afc35d355221e0228aebf8
author  Michael Stahl  2024-01-19
20:29:23 +0100
committer   Michael Stahl  2024-01-22
08:55:36 +0100

tdf#159023 sw_redlinehide: fix layout frames copying table into footer


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108843
[Bug 108843] [META] Clipboard bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108843] [META] Clipboard bugs and enhancements

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108843

Aron Budea  changed:

   What|Removed |Added

 Depends on||159664


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159664
[Bug 159664] Floatable table not visible in after paste in new document but
shown in navigator
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 134377] Unoperating Help buttons in File/Open|Save|Save As|Save Remote libO dialogs

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134377

--- Comment #18 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/62cfd5d6512a99cfa88a558d74b3bb335315e1ee

tdf#134377 Fix bookmark in native file explorer dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2024-02-24 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4287eb60ca1073a7a04bb552ad31e2ed1c3979d8
Author: Olivier Hallot 
AuthorDate: Sat Feb 24 13:39:36 2024 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Feb 24 17:39:36 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 62cfd5d6512a99cfa88a558d74b3bb335315e1ee
  - tdf#134377 Fix bookmark in native file explorer dialog

Change-Id: I47e06c8534d444a828d50c4dfc8e8b4c49d7fdab
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163880
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 93aacd69104e..62cfd5d6512a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 93aacd69104e0b1ad7d9e6279c8f0681456cc199
+Subproject commit 62cfd5d6512a99cfa88a558d74b3bb335315e1ee


[Bug 134377] Unoperating Help buttons in File/Open|Save|Save As|Save Remote libO dialogs

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134377

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.1.0 target:7.5.0   |target:7.1.0 target:7.5.0
   |target:7.6.0|target:7.6.0 target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

help.git: source/text

2024-02-24 Thread Olivier Hallot (via logerrit)
 source/text/shared/01/0102.xhp |7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 62cfd5d6512a99cfa88a558d74b3bb335315e1ee
Author: Olivier Hallot 
AuthorDate: Sat Feb 24 06:52:18 2024 -0300
Commit: Olivier Hallot 
CommitDate: Sat Feb 24 17:39:36 2024 +0100

tdf#134377 Fix bookmark in native file explorer dialog

Change-Id: I47e06c8534d444a828d50c4dfc8e8b4c49d7fdab
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163880
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/01/0102.xhp 
b/source/text/shared/01/0102.xhp
index 297c1063ee..0a89d4af99 100644
--- a/source/text/shared/01/0102.xhp
+++ b/source/text/shared/01/0102.xhp
@@ -42,13 +42,12 @@
 
 mw replaced "wildcards" by "regular expressions"
 mw deleted " regular expressions;" and "files;"
-
 
 
 
 
-
-
+
+
 Open, Insert text
 Opens a local or remote file, or inserts text from a 
file. Opening multiple files is 
possible.
 
@@ -78,7 +77,7 @@
   Add current 
folder to your favorite places using +. Remove a selected 
place from the list with -.
   Displays the files and folders in the folder that 
you are in. Click column headers to sort files names, types, sizes or 
dates in ascending or descending order.
   To open more than one document at the same time, 
each in an own window, hold CommandCtrl
 while you click the files, and then click Open.
-  
+
 
 
 Modern system file 
dialogs present many features for file handling. Most allows you to rename, 
delete, create files, sort list of files, display files and folders in icons, 
tree or list views, traverse the file system folder tree and much more. Use the 
mouse right button to get a list of commands on the selected files in the 
display area.


[Bug 156352] macOS: Save as > Encrypt with GPG key results in hang / crash

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156352

--- Comment #48 from steve  ---
Do you happen to know how to adjust the gpgme log level?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Import of lighting from MS Office for extruded shapes

2024-02-24 Thread Thorsten Behrens
Hi Regina,

Regina Henschel wrote:
> Unfortunately, our 3d engine does not support all needed features. Most
> important problem is, that in our 3d engine only the first light is
> specular.
>
I suspect that might be quick to add - Armin, what do you think?

> Further problem with our 3d engine is, that we cannot render the
> "Bevel" of MS Office. Not only the fancy ones, but the simple round
> bevel is missing too. Our "Rounded edges" are in fact straight. In
> MS Office you can use the bevel to create a sphere, for example.
>
Got it. Might also need some experimentation, such that we get the exact
same look. Let me play with this features a little bit.

> The question is more whether to start that immediately or first
> implement some ersatz lighting so that the shapes are approximately
> as light as in MS Office. When you use the current import (in daily
> build which has the 3d geometry) you can see, that our default
> lighting gives bad results.
>
I guess the specular light & API changes for it are relatively
straight-forward. Then again, getting the code merged as-is would
perhaps be quite satisfying, and I take it you would need some sort of
quick emulation for that, since it looks just too bad?

Cheers,

-- Thorsten

signature.asc
Description: PGP signature


[Bug 159868] Option for default row height for new tables in settings window

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159868

--- Comment #3 from dani.priv...@dismail.de ---
Sorry if i sounded hard, i didn't mean to attack you guys. But i think
one-size-fits-all doesn't hold true anymore with modern displays, even less so
in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159690] Manual line break forces automatic Wrap Text

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159690

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |9351|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159351] FILEOPEN: prompted to save changes when no change was made on ODS file with multiline cell

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159351

Aron Budea  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
 OS|Linux (All) |All
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |9690|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159863] Ctl + Shift + PgDn no longer assigned to JumpToFootnoteArea

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159863

--- Comment #5 from Jason White  ---
I take the view that components of the UI that cannot be accessed via a
keyboard by default need to be made keyboard-accessible, either through a menu
option or a key mapping. This is generally how keyboard operability
accessibility requirements are understood and interpreted, and justifiably so.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159868] Option for default row height for new tables in settings window

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159868

dani.priv...@dismail.de changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---
 Ever confirmed|0   |1

--- Comment #2 from dani.priv...@dismail.de ---
Hmm, i see changing default zoom is only possible per document, requires
changing font size, which is again saved in document. Both would require
creating a template, which doesn't work if you open a .csv. They are
*workarounds*, not solutions.
You're arguing with evaluated defaults but i'm asking that the user can set the
defaults. There's a mostly empty section "Vorgaben" (defaults/presets) in
settings. If not there, setting default row height, zoom, font, font size, etc.
should at least be possible via changing a cfg.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159863] Ctl + Shift + PgDn no longer assigned to JumpToFootnoteArea

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159863

--- Comment #4 from V Stuart Foote  ---
(In reply to Jason White from comment #3)
> The essence of this bug is that users shouldn't have to edit key bindings to
> obtain this functionality - there should be a default keyboard assignment.

Why? Reallocation of Ctrl + Shift + PgDn for the global Zoom-out / Zoom-in pair
was dev choice, under UX advisement.  The shortcut assignment was removed, UNO
function remains for customization, users can choose a shortcut of their
liking.

See:
https://help.libreoffice.org/latest/en-US/text/shared/01/06140200.html?DbPAR=SHARED#bm_id2322763

> Having the function available but unassigned probably doesn't satisfy
> accessibility standards/regulations for keyboard operation either (e.g.,
> public procurement standards that inherit WCAG 2.0, criterion 2.1.1).

Sorry, not going down that rabbit hole. This is a simple documentation issue. 

There are hundreds of potential UNO actions (across the UI) that could be
preassigned to fixed shortcuts, many of them of great potential benefit for
keyboard navigation and often assistive technology tool support.  

Assigning a shortcut for either .uno:JumpToFootnoteArea (with change in
documentation) or reassigning one to .uno:JumpToFootnoteOrAnchor is probably
now a reasonable improvement to do (movement into the footnote area previously
had a shortcut, so folks expect it) but that is not the main issue of a now
incorrectly documented shortcut action.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159868] Option for default row height for new tables in settings window

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159868

ady  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from ady  ---
You could change the zoom factor in Calc, which is independent of the row
height, so when the same spreadsheet is displayed on another screen size, the
attributes of the cell are the same and users/you only have to change the zoom
factor.

If you still want to change the row height, you can modify it for all cells and
save it as a new style, or even as the default style.

Moreover, you could perform additional changes and save them not only as a
(default) style on that file but also save the file as a template, or even as
your default template.

There are official Guides and Help content that might help you with these tasks
too.

Anyway, this is not an enhancement request (to change the default in LO, which
has been evaluated in the past) but a "how to" question. Please next time start
by using the users mailing list, or , leaving this
site for bug reports and enhancement requests.

I'll close this ticket now. Please feel free to re-open it in case I
misunderstood your comment 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Import of lighting from MS Office for extruded shapes

2024-02-24 Thread Regina Henschel

Hi Thorsten,

Thorsten Behrens schrieb am 22.02.2024 um 21:04:

Hi Regina,

Regina Henschel wrote:

Any ideas/wishes for a reasonably usable import?


Our 3d engine already supports all this FWICT (I see e.g.
SDRATTR_3DSCENE_LIGHTCOLOR_1 - 8) - so why not extend ODF here, when
it's obviously lacking?


Unfortunately, our 3d engine does not support all needed features. Most 
important problem is, that in our 3d engine only the first light is 
specular. We need three specular lights for MS Office light rigs. 
"Specular" means, that the light produces a bright spot on the shape.


Further problem with our 3d engine is, that we cannot render the "Bevel" 
of MS Office. Not only the fancy ones, but the simple round bevel is 
missing too. Our "Rounded edges" are in fact straight. In MS Office you 
can use the bevel to create a sphere, for example.


Nevertheless, extending ODF is likely needed anyway. That would include 
extending our API because the import goes via API properties. The 
question is more whether to start that immediately or first implement 
some ersatz lighting so that the shapes are approximately as light as in 
MS Office. When you use the current import (in daily build which has the 
3d geometry) you can see, that our default lighting gives bad results.


Kind regards,
Regina


core.git: Changes to 'refs/tags/cib_contract49-7.6.5.2.M2'

2024-02-24 Thread Thorsten Behrens (via logerrit)
Tag 'cib_contract49-7.6.5.2.M2' created by Thorsten Behrens 
 at 2024-02-24 15:12 +

cib_contract49-7.6.5.2.M2
-BEGIN PGP SIGNATURE-

iNUEABYKAH0WIQRV78SO268/dhkw1IIeB5amgXyR5gUCZdoHV18UgAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0NTVF
RkM0OEVEQkFGM0Y3NjE5MzBENDgyMUUwNzk2QTY4MTdDOTFFNgAKCRAeB5amgXyR
5qxdAQCbLPfkf4NEbIeSHNsqzJlVv5qqiRhgJJXmyFq0NT3NyQD/UtLrvXGRXvOE
9OOTWMrHldlM8GrJxdhePz56mSByxAs=
=iKFT
-END PGP SIGNATURE-

Changes since cib_contract49-7.6.5.2.M1-15:
---
 0 files changed
---


[Bug 159351] FILEOPEN: prompted to save changes when no change was made on ODS file with multiline cell

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159351

ady  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from ady  ---


*** This bug has been marked as a duplicate of bug 159690 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159690] Manual line break forces automatic Wrap Text

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159690

ady  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #16 from ady  ---
*** Bug 159351 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 116625] [META] Bugs where document modification status is wrong

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116625
Bug 116625 depends on bug 159351, which changed state.

Bug 159351 Summary: FILEOPEN: prompted to save changes when no change was made 
on ODS file with multiline cell
https://bugs.documentfoundation.org/show_bug.cgi?id=159351

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159863] Ctl + Shift + PgDn no longer assigned to JumpToFootnoteArea

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159863

--- Comment #3 from Jason White  ---
The essence of this bug is that users shouldn't have to edit key bindings to
obtain this functionality - there should be a default keyboard assignment.
Having the function available but unassigned probably doesn't satisfy
accessibility standards/regulations for keyboard operation either (e.g., public
procurement standards that inherit WCAG 2.0, criterion 2.1.1).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159868] New: Option for default row height for new tables in settings window

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159868

Bug ID: 159868
   Summary: Option for default row height for new tables in
settings window
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dani.priv...@dismail.de

Default row height of 0.45 cm is too small on 3k/4k screens, ideal would be 0.6
cm imho. But it's a matter of taste too. While searching how to set default row
height of new tables, the only thing i found is a post "it's hard coded" in
2019.
Is this still (or even) the case and if so, shouldn't default row height be an
option in the settings window with all the diversity of displays nowadays?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159738] CALC UI: Menu item "View headers" in menu "View" named wrong

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159738

--- Comment #5 from lol  ---
One problem resolved and another problem occurs.

The label "View column/row headers" is longer than "View headers" but it
describe what the function make, show or hide the column/row headers, not the
header.

The label "header" is used for the header on a page. See
https://bugs.documentfoundation.org/attachment.cgi?id=192747

The option which make the same as the menu item is named "column/row headers".
It is confusing for the user if the same function has different labels. See
https://bug-attachments.documentfoundation.org/attachment.cgi?id=192589

On the notbookbar is enough place for the label "View column/row headers".
Maybe the word "view" can be removed so the label is shorter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159738] CALC UI: Menu item "View headers" in menu "View" named wrong

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159738

--- Comment #5 from lol  ---
One problem resolved and another problem occurs.

The label "View column/row headers" is longer than "View headers" but it
describe what the function make, show or hide the column/row headers, not the
header.

The label "header" is used for the header on a page. See
https://bugs.documentfoundation.org/attachment.cgi?id=192747

The option which make the same as the menu item is named "column/row headers".
It is confusing for the user if the same function has different labels. See
https://bug-attachments.documentfoundation.org/attachment.cgi?id=192589

On the notbookbar is enough place for the label "View column/row headers".
Maybe the word "view" can be removed so the label is shorter.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159738] CALC UI: Menu item "View headers" in menu "View" named wrong

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159738

--- Comment #4 from lol  ---
Created attachment 192747
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192747=edit
Header

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159738] CALC UI: Menu item "View headers" in menu "View" named wrong

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159738

--- Comment #4 from lol  ---
Created attachment 192747
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192747=edit
Header

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159418] Missing Navigation Arrows for Editing Index Entry

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159418

Tex2002ans  changed:

   What|Removed |Added

 CC||Tex2002ans+LibreOffice@gmai
   ||l.com

--- Comment #5 from Tex2002ans  ---
A user on the LibreOffice subreddit just came across this "missing arrow
buttons" bug too:

-
https://www.reddit.com/r/libreoffice/comments/1aytsyo/indexes_cannot_be_stepped_through_in_24203/

They were using:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
Locale: en-US (en_US.utf8); UI: en-US
Flatpak
Calc: threaded

and I verified on my end too:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

- - - -

I verified this by:

1. Insert > Table of Contents and Index > Index Entry

Expect:

- Little Left/Right arrow buttons towards bottom of "Insert Index Entry" popup.
   - These step you through (or jump you) to each of the entries in your
document.

Actual:

- No Left/Right arrow buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 86209] MENUS: Reorganize the View menu

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86209

--- Comment #38 from perry  ---
Renovate your kitchen in Salt Lake City with us and get the best service in the
city. check for more info: https://kitchenremodelsaltlakecityut.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156352] macOS: Save as > Encrypt with GPG key results in hang / crash

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156352

--- Comment #47 from Patrick Luby  ---
(In reply to steve from comment #46)
> This is mygpgme.log until the crash happened and I closed LO:
> 
> 2024-02-24 14:03:30 gpgme[6785.1a81] gpgme_debug: level=2

Unfortunately, your "debug level 2" log is the same as mine so it seems that we
need at least "debug level 3" to see more detailed steps to log.

Is it possible to run with a higher debug level and search and replace any
names and e-mail addresses? What I see in my log in attachment #192737 is a
bunch of "gpgme:keylist_colon_handler:" messages. Then each is followed by what
looks like a loop of "gpgme_op_keylist_next:" messages.

If don't want to skip searching and replacing in the log, would it be possible
to post the message lines from the end of the log up to, but not including, the
last "gpgme:keylist_colon_handler:" message (i.e. everything after the last
message any names or e-mails)?

I don't want nor need to see any names or e-mails, I just need to know if you
ever see any "gpgme:keylist_colon_handler:" messages in your log. The names and
e-mails in a "debug level 3" log only indicate that gpgme sucessfully ran the
gpg command and gpg returned some list of certificates.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - sw/inc sw/source

2024-02-24 Thread Michael Stahl (via logerrit)
 sw/inc/pagedesc.hxx|6 +--
 sw/source/core/doc/docfmt.cxx  |   12 +++---
 sw/source/core/layout/pagedesc.cxx |   74 ++---
 3 files changed, 46 insertions(+), 46 deletions(-)

New commits:
commit 0b1bbcb8fb64e6db5ea3a0ff4c5739a5f1d19c07
Author: Michael Stahl 
AuthorDate: Fri Feb 23 17:18:04 2024 +0100
Commit: Tomaž Vajngerl 
CommitDate: Sat Feb 24 15:42:55 2024 +0100

tdf#147731 sw: fix memory leak in SwDoc::CopyPageDesc()

Commit 963de9feb37105560fde14b44d992e47f341bb5b "sw: fix issue with
copying stashed frame format" fixed the actual bug here, but introduced
a new memory leak.

This causes an assert in CppunitTest_uiwriter3:
cppunittester: svl/source/items/itempool.cxx:779: void 
SfxItemPool::Remove(const SfxPoolItem&): Assertion `rItem.GetRefCount() && 
"RefCount == 0, Remove impossible"' failed.

The assert happens only when this is backported to the libreoffice-7-6
branch, because commit ab7c81f55621d7b0d1468c63305163016dd78837 "ITEM:
Get away from classic 'poolable' Item flag" removed the assert.

The problem is that a SwFormatFrameSize inside a footer SwFrameFormat is
leaked 4 times, because 4 SwFrameFormats are leaked; the leak is that
SwDoc::CopyPageDesc() creates a new pNewFormat, passed it to
StashFrameFormat(), which copies it but doesn't free it.

There is also a usage of std::shared_ptr here that is very questionable;
SwFrameFormat should never be shared between different SwPageDesc.

(regression from commit b802ab694a8a7357d4657f3e11b571144fa7c7bf)

Change-Id: I44133bc5e6789a51ce064f1aa5ea8b325224365b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163854
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 5c4ae1b19c51dcd62dad8e1d3e8beb87a0311352)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163883
Tested-by: Jenkins CollaboraOffice 

diff --git a/sw/inc/pagedesc.hxx b/sw/inc/pagedesc.hxx
index 11bb347aa1fb..ddc7e659a5bb 100644
--- a/sw/inc/pagedesc.hxx
+++ b/sw/inc/pagedesc.hxx
@@ -151,9 +151,9 @@ class SW_DLLPUBLIC SwPageDesc final
 
 struct StashedPageDesc
 {
-std::shared_ptr m_pStashedFirst;
-std::shared_ptr m_pStashedLeft;
-std::shared_ptr m_pStashedFirstLeft;
+std::optional m_oStashedFirst;
+std::optional m_oStashedLeft;
+std::optional m_oStashedFirstLeft;
 };
 
 mutable StashedPageDesc m_aStashedHeader;
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index d6c943dbcdc8..1c696bebb6a0 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -1553,21 +1553,21 @@ void SwDoc::CopyPageDesc( const SwPageDesc& rSrcDesc, 
SwPageDesc& rDstDesc,
 {
 if (pStashedFormatSrc->GetDoc() != this)
 {
-SwFrameFormat* pNewFormat = new 
SwFrameFormat(GetAttrPool(), "CopyDesc", GetDfltFrameFormat());
+SwFrameFormat newFormat(GetAttrPool(), "CopyDesc", 
GetDfltFrameFormat());
 
 SfxItemSet aAttrSet(pStashedFormatSrc->GetAttrSet());
 aAttrSet.ClearItem(RES_HEADER);
 aAttrSet.ClearItem(RES_FOOTER);
 
-pNewFormat->DelDiffs( aAttrSet );
-pNewFormat->SetFormatAttr( aAttrSet );
+newFormat.DelDiffs(aAttrSet);
+newFormat.SetFormatAttr(aAttrSet);
 
 if (bHeader)
-CopyHeader(*pStashedFormatSrc, *pNewFormat);
+CopyHeader(*pStashedFormatSrc, newFormat);
 else
-CopyFooter(*pStashedFormatSrc, *pNewFormat);
+CopyFooter(*pStashedFormatSrc, newFormat);
 
-rDstDesc.StashFrameFormat(*pNewFormat, bHeader, bLeft, 
bFirst);
+rDstDesc.StashFrameFormat(newFormat, bHeader, bLeft, 
bFirst);
 }
 else
 {
diff --git a/sw/source/core/layout/pagedesc.cxx 
b/sw/source/core/layout/pagedesc.cxx
index 2b7882332789..f9679bb2a8e7 100644
--- a/sw/source/core/layout/pagedesc.cxx
+++ b/sw/source/core/layout/pagedesc.cxx
@@ -83,13 +83,13 @@ SwPageDesc::SwPageDesc( const SwPageDesc  )
 , m_FootnoteInfo( rCpy.GetFootnoteInfo() )
 , m_pdList( nullptr )
 {
-m_aStashedHeader.m_pStashedFirst = rCpy.m_aStashedHeader.m_pStashedFirst;
-m_aStashedHeader.m_pStashedLeft = rCpy.m_aStashedHeader.m_pStashedLeft;
-m_aStashedHeader.m_pStashedFirstLeft = 
rCpy.m_aStashedHeader.m_pStashedFirstLeft;
+m_aStashedHeader.m_oStashedFirst = rCpy.m_aStashedHeader.m_oStashedFirst;
+m_aStashedHeader.m_oStashedLeft = rCpy.m_aStashedHeader.m_oStashedLeft;
+

[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #66 from SSamiK  ---
Well look at that. Can confirm!  
I did the same thing and it works.

I  even gave the two other their names back and it still works with just
renaming Lightproof.components

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #65 from Buovjaga  ---
(In reply to SSamiK from comment #64)
> Confirmed. 
> 
> 
> C:\Program Files\LibreOffice\share\extensions\dict-en\Lightproof.old
> C:\Program Files\LibreOffice\share\extensions\dict-en\pythonpath-old
> 
> And you are not seeing LightProof in Tools - Options - Languages and Locales
> - Writing Aids?
>  
> Not seeing LightProof in Writing Aids.

Ok, I tested it now and the only thing you need to rename is
Lightproof.components. If I do it, I can use the file dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159867] LibreOffice --nologo bug

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159867

--- Comment #1 from Dave  ---
Created attachment 192746
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192746=edit
A capture of the error screen

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159867] New: LibreOffice --nologo bug

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159867

Bug ID: 159867
   Summary: LibreOffice --nologo bug
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dwalpole1...@gmail.com

Description:
close error on swriter 'LibreOffice stopped working'

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: CL threaded

system W1022h2/x64/i5-12gen


Steps to Reproduce:
1. Add --nologo to the shortcut for swriter.exe
2. start swritwer
3. close swriter and see 'LibreOffice stopped working'
4. remove --nologo and open swriter again - now no issue on close

Actual Results:
error message on close

Expected Results:
a graceful exit!


Reproducible: Always


User Profile Reset: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-GB
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159844] double free in __cxa_finalize

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159844

--- Comment #5 from Robert Nagy  ---
Are you using an external or internal libetonyek?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'feature/cib_contract49' - translations

2024-02-24 Thread Thorsten Behrens (via logerrit)
 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0912df283666ad93133fdc25079ac8ee56be1d5d
Author: Thorsten Behrens 
AuthorDate: Sat Feb 24 15:22:04 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 24 15:22:04 2024 +0100

Update git submodules

* Update translations from branch 'feature/cib_contract49'
  to 99dffd17046cb0c65a034af0bab81dbe770f70aa
  - Update DE translations

Change-Id: Ibcf9c09d2413c4931697449619e7a8fbe6940016

  - Version 7.6.5.2, tag libreoffice-7.6.5.2-hotfix1

Change-Id: I96cd6667819e3ff617ab7c7cb7fdc4a17562ec47

  - Version 7.6.5.2, tag libreoffice-7.6.5.2

Change-Id: Iee78b7547cfa59d396438242a20716813ba8814b

  - update translations for 7.6.5 rc2

and force-fix errors using pocheck

Change-Id: Ie92e7273a69b81df9bdcc4f7f08a7443fd2f6144
(cherry picked from commit 36885fbc6d49abbdb55f6ef9728ef5f49f61c8af)

  - Branch libreoffice-7-6-5

This is 'libreoffice-7-6-5' - the stable branch for the 7.6.5 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.6.x release,
please use the 'libreoffice-7-6' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I83e01542d7224395619e60cc69d0eb7b248b3303

  - update translations for 7.6.5 rc1

and force-fix errors using pocheck

Change-Id: Ie40ba4e69f02dec41db1c7690375460110ae25d0

  - update translations for 7.6.5 rc1

and force-fix errors using pocheck

Change-Id: I0c8b07d91bc81c5bd47d6f6a1c2c78162a3e304e

  - update translations for 7.6.4 rc1

and force-fix errors using pocheck

Change-Id: I8d7e3350c35b5da2513f8a32da3ab1595bd99cd6

  - update translations for 7-6

and force-fix errors using pocheck

Change-Id: Ib2ddeb17ecd788d3852eadfd649a1139d9d8b2d9

  - update translations for 7-6

and force-fix errors using pocheck

Change-Id: I7e98541ae70d37e70a1d33a755907044e945a1c3

  - Better translation for hidden info warndialog

Change-Id: Ia873da1405f9c7f6b72d940585c9f1633498ba10

  - Adjust tooltip translations

Change-Id: I8c0d78f554ff5ca6bd8441506a2f270c9f9f8e6e

  - Add missing fr translations

Follow-up to 79f9243e81eda3ab113d75538686ab81770c2c5d

Change-Id: I83351fe0d0ef6c1c17b48e99d1e80ab2cdb03e05

  - Add fr translations for f950036a89c46ce50bd7d62896cb6e4a690d323a

Change-Id: I497f6270322380d2d05716e81949434f75df8602

  - Backport fr translations for 76cac369d880a9aeebc86cfc84938dbf64a7435d

Change-Id: I955422a5fd582c6ff9909d89fda76dbbd956a1c5

  - Version 7.6.3.2, tag libreoffice-7.6.3.2

Change-Id: I4772fc0f2abffbb8015ee096bb9a4fc6d257d7cb

  - update translations for 7.6.3 rc2

and force-fix errors using pocheck

Change-Id: If5b89e12a3fdc3f94dd4159a89fe0a9c3a1bcf1c
(cherry picked from commit 9a36aad0f1471adcb3a93d9be53f9e19aef8b8cf)

  - Branch libreoffice-7-6-3

This is 'libreoffice-7-6-3' - the stable branch for the 7.6.3 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.6.x release,
please use the 'libreoffice-7-6' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I145b9af8d0a5c8319c63b139562c86caa94670e2

  - Add translations for f950036a89c46ce50bd7d62896cb6e4a690d323a

Change-Id: Ida57eb3b5034ec57266e8b95928c59a1d5efd065

  - Backport translations for 76cac369d880a9aeebc86cfc84938dbf64a7435d

Change-Id: I597ba186fb8736a50e141da34aea5dbc475f8652

diff --git a/translations b/translations
index 76ae0c32be86..99dffd17046c 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 76ae0c32be86cf727beeb0f58369fcb41677d97d
+Subproject commit 99dffd17046cb0c65a034af0bab81dbe770f70aa


core.git: vcl/skia

2024-02-24 Thread Patrick Luby (via logerrit)
 vcl/skia/osx/gdiimpl.cxx |   21 +++--
 1 file changed, 11 insertions(+), 10 deletions(-)

New commits:
commit 3e2dde97bc15f156837d10bf4456deb81f7f554a
Author: Patrick Luby 
AuthorDate: Thu Feb 22 10:01:00 2024 -0500
Commit: Patrick Luby 
CommitDate: Sat Feb 24 15:13:47 2024 +0100

Related: tdf#159529 eliminate possible memory leak

Despite confirming that the release function passed to
SkBitmap.bitmap.installPixels() does get called for every
data array that has been allocated, Apple's Instruments
indicates that the data is leaking. While it is likely a
false positive, it makes leak analysis difficult so leave
the bitmap mutable. That causes SkBitmap.asImage() to make
a copy of the data and the data can be safely deleted here.

Change-Id: Ib28d70bd5f51e6d3be7a7d7c0d5923d71a6e5390
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163774
Tested-by: Jenkins
Reviewed-by: Patrick Luby 

diff --git a/vcl/skia/osx/gdiimpl.cxx b/vcl/skia/osx/gdiimpl.cxx
index c4bd75184242..9b511ad4469b 100644
--- a/vcl/skia/osx/gdiimpl.cxx
+++ b/vcl/skia/osx/gdiimpl.cxx
@@ -37,12 +37,6 @@
 
 using namespace SkiaHelper;
 
-static void releaseInstalledPixels(void* pAddr, void*)
-{
-if (pAddr)
-delete[] static_cast(pAddr);
-}
-
 AquaSkiaSalGraphicsImpl::AquaSkiaSalGraphicsImpl(AquaSalGraphics& rParent,
  AquaSharedAttributes& rShared)
 : SkiaSalGraphicsImpl(rParent, rShared.mpFrame)
@@ -251,6 +245,7 @@ bool AquaSkiaSalGraphicsImpl::drawNativeControl(ControlType 
nType, ControlPart n
 if (!context)
 {
 SAL_WARN("vcl.skia", "drawNativeControl(): Failed to allocate bitmap 
context");
+delete[] data;
 return false;
 }
 // Setup context state for drawing (performDrawNativeControl() e.g. fills 
background in some cases).
@@ -287,12 +282,9 @@ bool 
AquaSkiaSalGraphicsImpl::drawNativeControl(ControlType nType, ControlPart n
 if (!bitmap.installPixels(SkImageInfo::Make(width, height,
 
mSurface->imageInfo().colorType(),
 kPremul_SkAlphaType),
-  data, width * 4, releaseInstalledPixels, 
nullptr))
+  data, width * 4, nullptr, nullptr))
 abort();
 
-// Make bitmap immutable to avoid making a copy in bitmap.asImage()
-bitmap.setImmutable();
-
 preDraw();
 SAL_INFO("vcl.skia.trace", "drawnativecontrol(" << this << "): " << 
rControlRegion << ":"
 << int(nType) << "/" 
<< int(nPart));
@@ -312,6 +304,15 @@ bool 
AquaSkiaSalGraphicsImpl::drawNativeControl(ControlType nType, ControlPart n
 ++pendingOperationsToFlush; // tdf#136369
 postDraw();
 }
+// Related: tdf#159529 eliminate possible memory leak
+// Despite confirming that the release function passed to
+// SkBitmap.bitmap.installPixels() does get called for every
+// data array that has been allocated, Apple's Instruments
+//  indicates that the data is leaking. While it is likely a
+// false positive, it makes leak analysis difficult so leave
+// the bitmap mutable. That causes SkBitmap.asImage() to make
+// a copy of the data and the data can be safely deleted here.
+delete[] data;
 return bOK;
 }
 


[Bug 139575] MSO Group Shape with SmartArt is not seen (zero size in Navigator)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139575

--- Comment #11 from Kevin Suo  ---
Created attachment 192745
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192745=edit
screenshot before the bisected commit

This is a screenshot before the bisected commit
59373b753902f69cd44d183568b084429322e7ab.

For screenshot with and after this commit, see the left part of attachment
169218 in comment 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #64 from SSamiK  ---
Confirmed. 


C:\Program Files\LibreOffice\share\extensions\dict-en\Lightproof.old
C:\Program Files\LibreOffice\share\extensions\dict-en\pythonpath-old

And you are not seeing LightProof in Tools - Options - Languages and Locales -
Writing Aids?

Not seeing LightProof in Writing Aids.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/CppunitTest_sc_a11y.mk sw/CppunitTest_sw_a11y.mk

2024-02-24 Thread Noel Grandin (via logerrit)
 sc/CppunitTest_sc_a11y.mk |4 
 sw/CppunitTest_sw_a11y.mk |4 
 2 files changed, 8 insertions(+)

New commits:
commit 0249f00aacc008969eb9bca5905dc2fea99e27fe
Author: Noel Grandin 
AuthorDate: Sat Feb 24 12:58:56 2024 +0200
Commit: Noel Grandin 
CommitDate: Sat Feb 24 14:48:46 2024 +0100

Missing test dependency

Change-Id: I65d41949fb031f41591b1daab6ecad7fab3405a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163882
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/CppunitTest_sc_a11y.mk b/sc/CppunitTest_sc_a11y.mk
index 3418f2fd4c44..b28dfb18ac8a 100644
--- a/sc/CppunitTest_sc_a11y.mk
+++ b/sc/CppunitTest_sc_a11y.mk
@@ -37,4 +37,8 @@ $(eval $(call gb_CppunitTest_use_vcl,sc_a11y))
 $(eval $(call gb_CppunitTest_use_instdir_configuration,sc_a11y))
 $(eval $(call gb_CppunitTest_use_common_configuration,sc_a11y))
 
+$(eval $(call gb_CppunitTest_use_packages,sc_a11y, \
+postprocess_images \
+))
+
 # vim: set noet sw=4 ts=4:
diff --git a/sw/CppunitTest_sw_a11y.mk b/sw/CppunitTest_sw_a11y.mk
index f67f4cf89e01..0c9a193a6135 100644
--- a/sw/CppunitTest_sw_a11y.mk
+++ b/sw/CppunitTest_sw_a11y.mk
@@ -39,4 +39,8 @@ $(eval $(call gb_CppunitTest_use_vcl,sw_a11y))
 $(eval $(call gb_CppunitTest_use_instdir_configuration,sw_a11y))
 $(eval $(call gb_CppunitTest_use_common_configuration,sw_a11y))
 
+$(eval $(call gb_CppunitTest_use_packages,sw_a11y, \
+postprocess_images \
+))
+
 # vim: set noet sw=4 ts=4:


[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #63 from Buovjaga  ---
(In reply to SSamiK from comment #62)
> And it is confirmed it is in LightProof the error resides? 
> I have tried renamed LightProof.py and associated folder and the same error
> still occurs.

See comment 41, it is confirmed.

Can you confirm that you renamed all of these:

C:\Program Files\LibreOffice\share\extensions\dict-en\Lightproof.py
C:\Program Files\LibreOffice\share\extensions\dict-en\pythonpath

And you are not seeing LightProof in Tools - Options - Languages and Locales -
Writing Aids?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #62 from SSamiK  ---
And it is confirmed it is in LightProof the error resides? 
I have tried renamed LightProof.py and associated folder and the same error
still occurs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 139575] MSO Group Shape with SmartArt is not seen (zero size in Navigator)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139575

Kevin Suo  changed:

   What|Removed |Added

 CC||ke...@collabora.com
   Keywords||bisected
Version|4.2.8.2 release |4.2.0.4 release

--- Comment #10 from Kevin Suo  ---
Bisected from source build on an old Fedora 19:

bad 59373b753902f69cd44d183568b084429322e7ab Related bnc#819614: The diagram is
a group.
good fc54915c461dc753866627bd52ea60b12b71a012 Replace reg2unoidl with
unoidl-write

commit 59373b753902f69cd44d183568b084429322e7ab
Author: Jan Holesovsky 
Date:   Mon Sep 16 16:30:45 2013 +0200

Related bnc#819614: The diagram is a group.

Bedore this commit, the text shapes are visiable, althouth positioned at the
wrong position. However, after this commit, the text shapes are not shown up.

Not sure whether this is a regression, but hope someone can fix both of these
two issues.

Adding Jan Holesovsky to cc: would you please take a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159837] keyboard shortcuts don't work when focus into toolbar items (x11,win,qt5)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159837

V Stuart Foote  changed:

   What|Removed |Added

 CC||caolan.mcnamara@collabora.c
   ||om

--- Comment #6 from V Stuart Foote  ---
Thanks Jim!

Got to test with the c68712d 20240224 nightly build. +w or +s
shortcut behavior from the SB decks and buttons are much improved.

Unfortunately seem to still have issues with  string shortcuts from other
Toolbars. The STR of comment 3 to position focus onto a button control (split
or direct) of the Standard toolbar still results in the shortcuts as
non-functional.

So a different issue for those TB?

Is this going to be some disconnect with shortcut sequence between the welded
TB controls and the SB deck vcl controls that now seem fixed?

=-testing-=

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c68712d3689a0322e59934cd8151d003e869f30d
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #61 from Buovjaga  ---
(In reply to SSamiK from comment #60)
> It would probably be helpful if more people could produce a minudump. 
> 
> See
> https://wiki.documentfoundation.org/
> How_to_get_a_backtrace_with_WinDbg#Producing_a_mini_dump 
> 
> Instructions to install Windbg is in the same page. 
> I was not able to do a debugging run as Windbg would not attach to
> soffice.exe for whatever reason.

Not sure, if that's a useful way to spend time. The problem source is know, it
is in LightProof, so its Python code should be examined and the actual problem
discovered. I'm not sure how to do it except removing bits until things work...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159837] keyboard shortcuts don't work when focus into toolbar items (x11,win,qt5)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159837

V Stuart Foote  changed:

   What|Removed |Added

 CC||caolan.mcnamara@collabora.c
   ||om

--- Comment #6 from V Stuart Foote  ---
Thanks Jim!

Got to test with the c68712d 20240224 nightly build. +w or +s
shortcut behavior from the SB decks and buttons are much improved.

Unfortunately seem to still have issues with  string shortcuts from other
Toolbars. The STR of comment 3 to position focus onto a button control (split
or direct) of the Standard toolbar still results in the shortcuts as
non-functional.

So a different issue for those TB?

Is this going to be some disconnect with shortcut sequence between the welded
TB controls and the SB deck vcl controls that now seem fixed?

=-testing-=

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c68712d3689a0322e59934cd8151d003e869f30d
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 156352] macOS: Save as > Encrypt with GPG key results in hang / crash

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156352

--- Comment #46 from steve  ---
Followed your three steps.

LO does show an empty dialog "Digital Signatures" (unexpected) and briefly
after (without any dialog interaction) crashes (1 year:
https://bin.disroot.org/?4b322ca330a5a239#GzpaKWdpqqfQu9nRvDdG3kP66TtwQoE89aCZ1r92njTr)

mygpgme.log says version 1.20.0
Was expecting 1.18 as per
https://bugs.documentfoundation.org/show_bug.cgi?id=152524#c16 but it seems
gpgme was updated to version 1.20.0. 1.23.2 seems to be the latest stable as
per https://gnupg.org/download/index.html#gpgme. Wondering if that could be
relevant.

This is mygpgme.log until the crash happened and I closed LO:

2024-02-24 14:03:30 gpgme[6785.1a81] gpgme_debug: level=2
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme_check_version: call:
req_version=(null), VERSION=1.20.0-unknown
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme_check_version_internal: call:
req_version=(null), offset_sig_validity=60
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:
gpgconf='/usr/local/MacGPG2/bin/gpgconf'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:  
gpg='/usr/local/MacGPG2/bin/gpg'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:
gpgsm='/usr/local/MacGPG2/bin/gpgsm'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:
gpg-agent='/usr/local/MacGPG2/bin/gpg-agent'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo: 
scdaemon='/usr/local/MacGPG2/libexec/scdaemon'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:  
dirmngr='/usr/local/MacGPG2/bin/dirmngr'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo: 
pinentry='/usr/local/MacGPG2/libexec/pinentry-mac.app/Contents/MacOS/pinentry-mac'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:  
homedir='/Users/username/.gnupg'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:  
sockdir='/Users/username/.gnupg'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:
agent='/Users/username/.gnupg/S.gpg-agent'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:  
ssh='/Users/username/.gnupg/S.gpg-agent.ssh'
2024-02-24 14:03:30 gpgme[6785.1a81] gpgme-dinfo:  
dirmngr='/Users/username/.gnupg/S.dirmngr'

Tests done in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3b73071f7a7fcf80547da81e5effe4ed6018bbb4
CPU threads: 8; OS: macOS 13.6.4; UI render: default; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 116625] [META] Bugs where document modification status is wrong

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116625

Aron Budea  changed:

   What|Removed |Added

 Depends on||159741


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159741
[Bug 159741] Pressing Print button followed by cancel is marked as document
modification
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159741] Pressing Print button followed by cancel is marked as document modification

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159741

Aron Budea  changed:

   What|Removed |Added

 Blocks||116625
 OS|Windows (All)   |All
 CC||aron.bu...@gmail.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116625
[Bug 116625] [META] Bugs where document modification status is wrong
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 137067] User interface - Inconsistent fonts in tabbed style (Remote Documents looks out-of-place)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137067

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9865

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159865] Font of the drop down menu in Page Size is very low (in NB bar Tabbed UI)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159865

V Stuart Foote  changed:

   What|Removed |Added

Summary|Font of the drop down menu  |Font of the drop down menu
   |in Page Size is very low.   |in Page Size is very low
   ||(in NB bar Tabbed UI)
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||7067

--- Comment #4 from V Stuart Foote  ---
Kind of seems this should be dupe to bug 136905 as known there that a full
refactoring would be needed for the flaky NB bar controls.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 117604] LibreOffice lose list element after conversion to HTML

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117604

Kevin Suo  changed:

   What|Removed |Added

   Keywords||filter:html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 117604] LibreOffice lose list element after conversion to HTML

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117604

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com
   Keywords|bibisectRequest, regression |
Version|4.2 all versions|Inherited From OOo

--- Comment #10 from Aron Budea  ---
For me this bug already exists in LO 3.3.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159865] Font of the drop down menu in Page Size is very low.

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159865

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||6905

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection / after hovering

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection / after hovering

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #15 from Commit Notification 
 ---
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6cad38dece31eb035a9685ed8d123a74a0b69637

tdf#159251: Blind fix

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: include/vcl

2024-02-24 Thread Khaled Hosny (via logerrit)
 include/vcl/rendercontext/State.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6cad38dece31eb035a9685ed8d123a74a0b69637
Author: Khaled Hosny 
AuthorDate: Sat Feb 24 11:18:04 2024 +0200
Commit: خالد حسني 
CommitDate: Sat Feb 24 13:40:42 2024 +0100

tdf#159251: Blind fix

Hopefully fixes regression introduced in:

commit 611694b707eb43e4c0f20b781f6869016a3ba099
Author: Khaled Hosny 
Date:   Thu Aug 17 17:39:29 2023 +0300

vcl: Allow pushing/popping OutputDevice’s RTLEnabled state

Change-Id: I9236bd6951d83a512390934127031204d94d14bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163877
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/include/vcl/rendercontext/State.hxx 
b/include/vcl/rendercontext/State.hxx
index 0359a486e4b2..33970dcccb7f 100644
--- a/include/vcl/rendercontext/State.hxx
+++ b/include/vcl/rendercontext/State.hxx
@@ -67,7 +67,7 @@ template <> struct typed_flags : 
is_typed_flags

[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #60 from SSamiK  ---
It would probably be helpful if more people could produce a minudump. 

See
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg#Producing_a_mini_dump
 

Instructions to install Windbg is in the same page. 
I was not able to do a debugging run as Windbg would not attach to soffice.exe
for whatever reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: writerfilter/source

2024-02-24 Thread Justin Luth (via logerrit)
 writerfilter/source/rtftok/rtfsdrimport.cxx |   19 +++
 1 file changed, 7 insertions(+), 12 deletions(-)

New commits:
commit fe84ced08668ef0030fbd37bea52424fd86c8e7a
Author: Justin Luth 
AuthorDate: Fri Feb 9 13:40:10 2024 -0500
Commit: Justin Luth 
CommitDate: Sat Feb 24 13:14:03 2024 +0100

tdf#126533 rtf import: page background fill

I worked on this mainly to see what the impact of the
docx changes would be on RTF.
It seemed to be OK. This patch shows that RTF
can now import gradient page backgrounds.

It does NOT import image backgrounds
(at least no the ones I tested)
because they were specified as
XML_sn: fillBlip
XML_sv: 
which is an unknown property in RTFSdrImport::resolve.

The only fill type that RTFSdrImport::resolve knows about
is XML_gradient.

The only existing unit test I noted was
page-background.rtf

Change-Id: Ie40b91468d21b29a102472c859cd1eecfcb2a5f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163199
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/writerfilter/source/rtftok/rtfsdrimport.cxx 
b/writerfilter/source/rtftok/rtfsdrimport.cxx
index 031f24117d00..9c673e871835 100644
--- a/writerfilter/source/rtftok/rtfsdrimport.cxx
+++ b/writerfilter/source/rtftok/rtfsdrimport.cxx
@@ -1136,18 +1136,6 @@ void RTFSdrImport::resolve(RTFShape& rShape, bool 
bClose, ShapeOrPict const shap
 return;
 }
 
-if (m_rImport.isInBackground())
-{
-RTFSprms aAttributes;
-aAttributes.set(NS_ooxml::LN_CT_Background_color,
-new 
RTFValue(xPropertySet->getPropertyValue("FillColor").get()));
-m_rImport.Mapper().props(new 
RTFReferenceProperties(std::move(aAttributes)));
-
-uno::Reference xComponent(xShape, uno::UNO_QUERY);
-xComponent->dispose();
-return;
-}
-
 // Send it to dmapper
 if (xShape.is())
 {
@@ -1158,6 +1146,13 @@ void RTFSdrImport::resolve(RTFShape& rShape, bool 
bClose, ShapeOrPict const shap
 }
 }
 
+if (m_rImport.isInBackground())
+{
+RTFSprms aSprms;
+aSprms.set(NS_ooxml::LN_background_background, new RTFValue()); // 
action="end"
+m_rImport.Mapper().props(new RTFReferenceProperties(RTFSprms(), 
std::move(aSprms)));
+}
+
 // If the shape has an inner shape, the inner object's properties should 
not be influenced by
 // the outer one.
 rShape.getProperties().clear();


[Bug 157135] LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157135

--- Comment #59 from Torstein  ---
I have the same problem on two different PCs, one with Win 10 and one with Win
11. Both with Norwegian set as language.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140403] LO 7.1 not opening files correctly and zoom not functioning in macOS 11.2

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140403

steve  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #27 from steve  ---
@PeeWee: Could you install LibreOffice nightly build and see if the problem
persists using that build:
https://dev-builds.libreoffice.org/daily/

Note for testers: the nightly master builds install in
/Applications/LibreOfficeDev.app. These builds are not codesigned like regular
LibreOffice releases so you will need to execute the following Terminal command
after installation but before you launch /Applications/LibreOfficeDev:

xattr -d com.apple.quarantine /Applications/LibreOfficeDev.app

Which version of macOS are you running now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 98774] Splash screen does not show up under macOS after first launch in desktop session

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98774

steve  changed:

   What|Removed |Added

Summary|Splash screen does not show |Splash screen does not show
   |up under Mac OS X after |up under macOS after first
   |first launch in desktop |launch in desktop session
   |session.|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159746] MacMini M2Pro (Mac OS Sonoma 14.3.1) HUNG while editing a .docx document using LibreOffice Writer

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159746

--- Comment #10 from stepped_canyon...@icloud.com ---
(In reply to Alex Thurgood from comment #9)
> The Apple dump file you provided shows a sigtramp being generated:
> 
>   11  -[AquaA11yWrapper accessibilityAttributeNames] + 272
> (libvclplug_osxlo.dylib + 290612) [0x100aeef34]
>   11  SwAccessibleGraphic::getAccessibleRole() + 60 (libswlo.dylib + 87324)
> [0x3b91d951c]
>   11  _sigtramp + 56 (libsystem_platform.dylib + 14884) [0x186bc1a24]
>   11  (anonymous namespace)::signalHandlerFunction(int, __siginfo*, void*) +
> 152 (libuno_sal.dylib.3 + 213896) [0x100e14388]
>   11  callSignalHandler(oslSignalInfo*) + 40 (libuno_sal.dylib.3 + 33280)
> [0x100de8200]
>   11  VCLExceptionSignal_impl(void*, oslSignalInfo*) + 340 (libvcllo.dylib +
> 4077336) [0x1058df718]
> 
> related to the accessibility code, but this might be a red herring.

(In reply to Alex Thurgood from comment #8)
> @stepped_canyon: what are your Skia settings ?
> 
> Look under LibreOffice > Preferences > View
> 
> Are you using any assistive technology tools (e.g. VoiceOver, screen zoom or
> magnifier, Rectangle, etc) ?

(In reply to Alex Thurgood from comment #8)
> @stepped_canyon: what are your Skia settings ?
> 
> Look under LibreOffice > Preferences > View
> 
> Are you using any assistive technology tools (e.g. VoiceOver, screen zoom or
> magnifier, Rectangle, etc) ?

Good morning Alex:
>The settings in LibreOffice > Preferences > View are all set to "Automatic" 
>
> "Graphics Output" "use anti-aliasing" and "use Skia for all rendering" are 
> both ticked.  The remaining options are not ticked.
>
> should I "Run Graphics Tests" ??

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 86209] MENUS: Reorganize the View menu

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86209

--- Comment #37 from movieclub  ---
Czy jesteś fanem sportu, który nie może przegapić żadnego meczu czy zawodów na
żywo? Odkryj, co MovieClub ma Ci do zaoferowania w 2024 roku. Nasz serwis to
Twoja brama do świata sportowych emocji. https://movieclub.pl/sport wyróżnia
się na rynku dzięki swojej szerokiej ofercie transmisji na żywo, obejmującej
mecze piłki nożnej, skoki narciarskie, tenis, siatkówkę i wiele innych
dyscyplin. Nie wiesz kiedy Twój ulubiony zespół gra mecz? Nie wiesz gdzie
obejrzeć dzisiaj mecze za darmo? W MovieClub odpowiemy na te pytania i wiele
więcej. Odkrywaj sport razem z nami, tak jak lubisz!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 75350] [UI] overall presentation progress bar

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=75350

--- Comment #19 from Thelaptopsguide  ---

Wow, this blog post really caught my attention! The depth of information
provided is impressive. I appreciate the effort put into explaining the topic
thoroughly. Also, kudos for keeping the content engaging. Looking forward to
more great reads. Cheers!
https://swyftx-au.org/ Swyftx Login 
https://bybit-us.org/ Bybit Login

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159351] FILEOPEN: prompted to save changes when no change was made on ODS file with multiline cell

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159351

Henning  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9690

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159690] Manual line break forces automatic Wrap Text

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159690

Henning  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9351

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 106179] [META] Writer comment bugs and enhancements

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106179

--- Comment #80 from Biyani Girls College  
---
I think your blog is captivating, unique, and original, however for the
greatest MCA education in Jaipur, check out Biyani Girls College, which is also
the https://www.biyanicolleges.org/course/mca-college-in-jaipur/;>best
mca college in jaipur. It's the best option because of its innovative
curriculum, connections to the business, and encouraging professors. In
addition to their degrees, graduates leave school with confidence and useful
skills for the tech industry. This college offers the clear route to success
for people who are serious about having a successful career in computer
applications.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159844] double free in __cxa_finalize

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159844

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #4 from Julien Nabet  ---
I gave a try following your last comment:
touch /tmp/tmp.92SyOf6UmZ

soffice --calc --headless --convert-to ods /tmp/tmp.92SyOf6UmZ 
convert /tmp/tmp.92SyOf6UmZ as a Calc document ->
/home/julien/lo/libreoffice/instdir/program/tmp.ods using filter : calc8
Overwriting: /home/julien/lo/libreoffice/instdir/program/tmp.ods

I also tried with master sources updated today (with debug):


/soffice --calc --headless --convert-to ods /tmp/tmp.92SyOf6UmZ 
WPSDocument::isFileFormatSupported()
libwps::readU8: can not read data
WPSDocument::isFileFormatSupported()
WPSDocument::isFileFormatSupported()
WPSDocument::isFileFormatSupported()
WPSDocument::isFileFormatSupported()
WPSDocument::isFileFormatSupported()
WPSDocument::isFileFormatSupported()
AbiDocument::isFileFormatSupported
Found xml parser severity error Extra content at the end of the document

WPSDocument::isFileFormatSupported()
VisioDocument: version 0
Found xml parser severity error Extra content at the end of the document

Throwing EndOfStreamException
Throwing EndOfStreamException
warn:legacy.tools:552566:552566:sfx2/source/appl/appuno.cxx:454: invalid type
for Stream
convert /tmp/tmp.92SyOf6UmZ as a Calc document ->
/home/julien/lo/libreoffice/instdir/program/tmp.ods using filter : calc8
warn:xmloff:552566:552566:xmloff/source/text/XMLTextListAutoStylePool.cxx:164:
getStyleFamilies() from XModel failed for export!
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-column with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-row with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-cell with mismatching mapper !
P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/text/XMLTextListAutoStylePool.cxx:164:
getStyleFamilies() from XModel failed for export!
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-column with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-row with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-cell with mismatching mapper !
P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/text/XMLTextListAutoStylePool.cxx:164:
getStyleFamilies() from XModel failed for export!
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-column with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-row with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-cell with mismatching mapper !
P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper
warn:legacy.osl:552566:552566:sc/source/core/data/document.cxx:5525: Wrong
index in AttrArray
warn:xmloff:552566:552566:xmloff/source/text/XMLTextListAutoStylePool.cxx:164:
getStyleFamilies() from XModel failed for export!
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-column with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-row with mismatching mapper !
P25SvXMLExportPropertyMapper 25SvXMLExportPropertyMapper
warn:xmloff:552566:552566:xmloff/source/style/impastpl.cxx:368: Adding
duplicate family table-cell with mismatching mapper !
P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper
warn:legacy.osl:552566:552566:xmloff/source/core/SettingsExportHelper.cxx:177:
this type is not implemented now
warn:vcl.schedule.deinit:552566:552566:vcl/source/app/scheduler.cxx:176: DeInit
task: Timer a: 1 p: 1 graphic::Manager maSwapOutTimer 1ms (0x7f3b6ae5b600)
warn:vcl.schedule.deinit:552566:552566:vcl/source/app/scheduler.cxx:197: DeInit
active tasks: 1 (ignored: 0)

So no double free here.

I can't help here=>uncc myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120620] setPosSize does not work properly

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120620

--- Comment #13 from TISSENDIER Pierre  ---
Confirmed in
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

I looked a lot, because even my programs in Python for QT do not work.
I found this:
https://github.com/gotk3/gotk3/issues/397
I leave a comment here if someone run in the same issue.
After talking with gnome team in irc, they said that wayland doesn't let an
application move its windows.

So Wayland is involved.

Is it too difficult to find a solution at Libre Office?

Thank a lot

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: svl/source

2024-02-24 Thread Julien Nabet (via logerrit)
 svl/source/items/srchitem.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dd5710a8dd4e05059ac248243d950e28d830905d
Author: Julien Nabet 
AuthorDate: Sat Feb 24 09:40:14 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Feb 24 11:23:20 2024 +0100

tdf#159862: set SearchWildcard to false changes SearchRegularExpression 
value

Like this since 2016 with 3a0abd3019ec3ca29b8f1378cdb32ebf741e6306
add SvxSearchItem::GetWildcard() SetWildcard()

Change-Id: Id988a6e58488af6b1f274a318e9d1f52c7a8b169
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163876
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/svl/source/items/srchitem.cxx b/svl/source/items/srchitem.cxx
index 1300bf744afa..6aa7c36ddca2 100644
--- a/svl/source/items/srchitem.cxx
+++ b/svl/source/items/srchitem.cxx
@@ -364,7 +364,7 @@ void SvxSearchItem::SetWildcard( bool bVal )
 {
 m_aSearchOpt.AlgorithmType2 = SearchAlgorithms2::WILDCARD;
 }
-else if ( SearchAlgorithms2::REGEXP == m_aSearchOpt.AlgorithmType2 )
+else if ( SearchAlgorithms2::WILDCARD == m_aSearchOpt.AlgorithmType2 )
 {
 m_aSearchOpt.AlgorithmType2 = SearchAlgorithms2::ABSOLUTE;
 }


[Bug 80430] [META] Documentation gap for new features

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 159596, which changed state.

Bug 159596 Summary: [LOCALHELP] Add Help page for Calc function XLOOKUP
https://bugs.documentfoundation.org/show_bug.cgi?id=159596

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: compression force for zip and ODF files in the installation archives

2024-02-24 Thread Jérôme Bouat

Hi Thorsten.



I mean there is no benefit for half compression force.> Oh, there's certainly a 
benefit going with the default - it is> considered a sweet spot between achieving 
reasonable compressionn,> while not being excessively slow.

I mean we can accept a slow compression while building the files. Next the 
multiple decompression will have the same speed whatever the compression force 
is (just slightly more memory). It would reduce the installed size for the 
millions downloads each version has :

https://stats.documentfoundation.org/downloads#month,version



Of course, in general nothing against having that configurable in some
ways, perhaps as a hidden config option. Would you be interested
implementing that?


I have no time before a few months.

Regards.


[Bug 134377] Unoperating Help buttons in File/Open|Save|Save As|Save Remote libO dialogs

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134377
Bug 134377 depends on bug 159111, which changed state.

Bug 159111 Summary: Help missing for Help ID: .uno:PickList in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=159111

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159111] Help missing for Help ID: .uno:PickList in Writer

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159111

Olivier Hallot  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: include/sfx2 sfx2/inc sfx2/source

2024-02-24 Thread Noel Grandin (via logerrit)
 sfx2/inc/DevelopmentToolDockingWindow.hxx |6 +++---
 sfx2/inc/pch/precompiled_sfx.hxx  |1 -
 sfx2/source/appl/appserv.cxx  |2 +-
 sfx2/source/devtools/DevelopmentToolChildWindow.cxx   |2 +-
 sfx2/source/devtools/DevelopmentToolDockingWindow.cxx |2 +-
 sfx2/source/devtools/SelectionChangeHandler.hxx   |2 +-
 6 files changed, 7 insertions(+), 8 deletions(-)

New commits:
commit e2cacf0456f79540ced611be84504d11b94ebe6f
Author: Noel Grandin 
AuthorDate: Fri Feb 23 13:02:41 2024 +0200
Commit: Noel Grandin 
CommitDate: Sat Feb 24 10:13:19 2024 +0100

move this header inside the module

it is not used anywhere else

Change-Id: I46cc42397cf56237818e6e58268a856e826a9985
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163818
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx 
b/sfx2/inc/DevelopmentToolDockingWindow.hxx
similarity index 90%
rename from include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
rename to sfx2/inc/DevelopmentToolDockingWindow.hxx
index 9cd1efeb352e..18511f70b9b6 100644
--- a/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
+++ b/sfx2/inc/DevelopmentToolDockingWindow.hxx
@@ -28,7 +28,7 @@
  * Contains two sides. Left side contains the simplified DOM tree and
  * the right side the object inspector tree.
  */
-class UNLESS_MERGELIBS(SFX2_DLLPUBLIC) DevelopmentToolDockingWindow final : 
public SfxDockingWindow
+class DevelopmentToolDockingWindow final : public SfxDockingWindow
 {
 private:
 std::unique_ptr mpObjectInspectorWidgets;
@@ -47,8 +47,8 @@ private:
 // Handler for the object inspector tree
 ObjectInspectorTreeHandler maObjectInspectorTreeHandler;
 
-DECL_DLLPRIVATE_LINK(DocumentModelTreeViewSelectionHandler, 
weld::TreeView&, void);
-DECL_DLLPRIVATE_LINK(DomToolbarButtonClicked, const OUString&, void);
+DECL_LINK(DocumentModelTreeViewSelectionHandler, weld::TreeView&, void);
+DECL_LINK(DomToolbarButtonClicked, const OUString&, void);
 
 void updateSelection();
 
diff --git a/sfx2/inc/pch/precompiled_sfx.hxx b/sfx2/inc/pch/precompiled_sfx.hxx
index 1f92a21a34ea..97de88104b0b 100644
--- a/sfx2/inc/pch/precompiled_sfx.hxx
+++ b/sfx2/inc/pch/precompiled_sfx.hxx
@@ -411,7 +411,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index d3884203596a..ed114b0d31a7 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -98,7 +98,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #include 
 #include 
diff --git a/sfx2/source/devtools/DevelopmentToolChildWindow.cxx 
b/sfx2/source/devtools/DevelopmentToolChildWindow.cxx
index 6b160bfa092a..291c476247ac 100644
--- a/sfx2/source/devtools/DevelopmentToolChildWindow.cxx
+++ b/sfx2/source/devtools/DevelopmentToolChildWindow.cxx
@@ -9,7 +9,7 @@
  */
 
 #include 
-#include 
+#include 
 #include 
 
 SFX_IMPL_DOCKINGWINDOW_WITHID(DevelopmentToolChildWindow, 
SID_DEVELOPMENT_TOOLS_DOCKING_WINDOW);
diff --git a/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx 
b/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx
index 0095e3396cf8..4e3107a71ced 100644
--- a/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx
+++ b/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx
@@ -10,7 +10,7 @@
 
 #include 
 
-#include 
+#include 
 
 #include 
 
diff --git a/sfx2/source/devtools/SelectionChangeHandler.hxx 
b/sfx2/source/devtools/SelectionChangeHandler.hxx
index 57224e056a52..f7c3afdf9c87 100644
--- a/sfx2/source/devtools/SelectionChangeHandler.hxx
+++ b/sfx2/source/devtools/SelectionChangeHandler.hxx
@@ -10,7 +10,7 @@
 
 #pragma once
 
-#include 
+#include 
 
 #include 
 #include 


[Bug 153862] missing link to help page for "Hidden paragraph" function variable

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153862

Olivier Hallot  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Olivier Hallot  ---
Tested on master and works for me.

Note: HID sent is HID=modules/swriter/ui/fldfuncpage/type

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2b9615995847b40d0fc166aa3eb32bc319e8a605
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: x11
Locale: en-US (pt_BR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120201] [META] Update or add link to help page

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120201
Bug 120201 depends on bug 153862, which changed state.

Bug 153862 Summary: missing link to help page for "Hidden paragraph" function 
variable
https://bugs.documentfoundation.org/show_bug.cgi?id=153862

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 112230] FILESAVE: ODT: Deleted changes are moved to the top after RT

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112230

Kevin Suo  changed:

   What|Removed |Added

Version|4.2 all versions|3.5 all versions

--- Comment #13 from Kevin Suo  ---
(In reply to Aron Budea from comment #12)
Thank you for the updated bibisecting. Based on the new range, I set the
version to 3.5.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155883] Help ID: .uno:NavElement is missing for "Navigate by" menu item (and toolbar widget)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155883

--- Comment #1 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/93aacd69104e0b1ad7d9e6279c8f0681456cc199

tdf#155883 "Navigate By" in Find Toolbar

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155883] Help ID: .uno:NavElement is missing for "Navigate by" menu item (and toolbar widget)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155883

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2024-02-24 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit abf23c8f9551a86246529e105fa38e7cb5894819
Author: Olivier Hallot 
AuthorDate: Sat Feb 24 05:55:37 2024 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Feb 24 09:55:37 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 93aacd69104e0b1ad7d9e6279c8f0681456cc199
  - tdf#155883 "Navigate By" in Find Toolbar

Change-Id: Ib0330a2b13345f860557b2406f0694b79ace7fb0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163858
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index ccaaa4f92689..93aacd69104e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ccaaa4f92689eb5d0de49bf4f47808fac6b63513
+Subproject commit 93aacd69104e0b1ad7d9e6279c8f0681456cc199


help.git: source/text

2024-02-24 Thread Olivier Hallot (via logerrit)
 source/text/shared/find_toolbar.xhp |   49 +++-
 source/text/swriter/01/0211.xhp |   13 +++--
 2 files changed, 32 insertions(+), 30 deletions(-)

New commits:
commit 93aacd69104e0b1ad7d9e6279c8f0681456cc199
Author: Olivier Hallot 
AuthorDate: Fri Feb 23 16:34:01 2024 -0300
Commit: Olivier Hallot 
CommitDate: Sat Feb 24 09:55:37 2024 +0100

tdf#155883 "Navigate By" in Find Toolbar

Change-Id: Ib0330a2b13345f860557b2406f0694b79ace7fb0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163858
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/find_toolbar.xhp 
b/source/text/shared/find_toolbar.xhp
index 5c119c21ef..bf77e221b5 100644
--- a/source/text/shared/find_toolbar.xhp
+++ b/source/text/shared/find_toolbar.xhp
@@ -11,26 +11,29 @@
 
 
   
-Find Bar
+Find Bar
 /text/shared/find_toolbar.xhp
   
 
 
 
-  
+  
 Find toolbar
   
-  
-  
-  
-
 
-  
-Find Bar
-The 
Find toolbar can be used to quickly search the contents of 
%PRODUCTNAME documents.
+  
+  
+  
+
+Find Bar
+The 
Find toolbar can be used to quickly search the contents of 
%PRODUCTNAME documents.
+  
+  
+
+Choose 
View - Toolbars - Find.
+
+CommandCtrl
 + F
   
-  Use the shortcut CommandCtrl
 + F to quickly open the Find toolbar.
-
   Find Text
   Enter the text to be 
searched in the document. Press Enter to perform the 
search.
 
@@ -39,12 +42,11 @@
   
 
   
-
-Find Previous Icon
+Find Previous Icon
 
   
   
-Find Previous 
Icon
+Find previous 
match
   
 
   
@@ -54,12 +56,11 @@
   
 
   
-
-Find Next Icon
+Find Next Icon
 
   
   
-Find Next 
Icon
+Find next 
match
   
 
   
@@ -82,15 +83,19 @@
   
 
   
-
-Find and Replace Icon
-
+Find and Replace 
Icon
   
   
-Find and 
Replace Icon
+Find and 
Replace
   
 
   
-
+  
+  
+  
+
+  
+
+  
 
 
diff --git a/source/text/swriter/01/0211.xhp 
b/source/text/swriter/01/0211.xhp
index 1c9c1803df..803bd84d4f 100644
--- a/source/text/swriter/01/0211.xhp
+++ b/source/text/swriter/01/0211.xhp
@@ -59,14 +59,13 @@
 
 
 
-Navigate By
-Use selection box to 
choose which type of item should be navigated, when using the Previous and Next 
buttons.
-
 
-
+
+
+  Navigate By
+Use selection box to 
choose which type of item should be navigated, when using the Previous and Next 
buttons.
 Previous
 Jumps to the previous item in 
the document. To specify the type of item to jump to, click the Navigate 
By list, and then click an item category - for example, 
"Images".
-
 
   
 
@@ -77,9 +76,6 @@
 
   
 
-
-
-
 Next
 Jumps to the next item in the 
document. To specify the type of item to jump to, click the Navigate 
By list, and then click an item category - for example, 
"Images".
 
@@ -93,6 +89,7 @@
 
   
 
+
 
 
 Page number


[Bug 139575] MSO Group Shape with SmartArt is not seen (zero size in Navigator)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139575

Kevin Suo  changed:

   What|Removed |Added

   Keywords||filter:pptx

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/inc sw/source

2024-02-24 Thread Michael Stahl (via logerrit)
 sw/inc/pagedesc.hxx|6 +--
 sw/source/core/doc/docfmt.cxx  |   12 +++---
 sw/source/core/layout/pagedesc.cxx |   74 ++---
 3 files changed, 46 insertions(+), 46 deletions(-)

New commits:
commit 5c4ae1b19c51dcd62dad8e1d3e8beb87a0311352
Author: Michael Stahl 
AuthorDate: Fri Feb 23 17:18:04 2024 +0100
Commit: Tomaž Vajngerl 
CommitDate: Sat Feb 24 09:44:41 2024 +0100

tdf#147731 sw: fix memory leak in SwDoc::CopyPageDesc()

Commit 963de9feb37105560fde14b44d992e47f341bb5b "sw: fix issue with
copying stashed frame format" fixed the actual bug here, but introduced
a new memory leak.

This causes an assert in CppunitTest_uiwriter3:
cppunittester: svl/source/items/itempool.cxx:779: void 
SfxItemPool::Remove(const SfxPoolItem&): Assertion `rItem.GetRefCount() && 
"RefCount == 0, Remove impossible"' failed.

The assert happens only when this is backported to the libreoffice-7-6
branch, because commit ab7c81f55621d7b0d1468c63305163016dd78837 "ITEM:
Get away from classic 'poolable' Item flag" removed the assert.

The problem is that a SwFormatFrameSize inside a footer SwFrameFormat is
leaked 4 times, because 4 SwFrameFormats are leaked; the leak is that
SwDoc::CopyPageDesc() creates a new pNewFormat, passed it to
StashFrameFormat(), which copies it but doesn't free it.

There is also a usage of std::shared_ptr here that is very questionable;
SwFrameFormat should never be shared between different SwPageDesc.

(regression from commit b802ab694a8a7357d4657f3e11b571144fa7c7bf)

Change-Id: I44133bc5e6789a51ce064f1aa5ea8b325224365b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163854
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/sw/inc/pagedesc.hxx b/sw/inc/pagedesc.hxx
index 136117114b30..3ec919ce3c83 100644
--- a/sw/inc/pagedesc.hxx
+++ b/sw/inc/pagedesc.hxx
@@ -151,9 +151,9 @@ class SW_DLLPUBLIC SwPageDesc final
 
 struct StashedPageDesc
 {
-std::shared_ptr m_pStashedFirst;
-std::shared_ptr m_pStashedLeft;
-std::shared_ptr m_pStashedFirstLeft;
+std::optional m_oStashedFirst;
+std::optional m_oStashedLeft;
+std::optional m_oStashedFirstLeft;
 };
 
 mutable StashedPageDesc m_aStashedHeader;
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index 19974139d125..66a61ebb02c6 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -1559,21 +1559,21 @@ void SwDoc::CopyPageDesc( const SwPageDesc& rSrcDesc, 
SwPageDesc& rDstDesc,
 {
 if (pStashedFormatSrc->GetDoc() != this)
 {
-SwFrameFormat* pNewFormat = new 
SwFrameFormat(GetAttrPool(), "CopyDesc", GetDfltFrameFormat());
+SwFrameFormat newFormat(GetAttrPool(), "CopyDesc", 
GetDfltFrameFormat());
 
 SfxItemSet aAttrSet(pStashedFormatSrc->GetAttrSet());
 aAttrSet.ClearItem(RES_HEADER);
 aAttrSet.ClearItem(RES_FOOTER);
 
-pNewFormat->DelDiffs( aAttrSet );
-pNewFormat->SetFormatAttr( aAttrSet );
+newFormat.DelDiffs(aAttrSet);
+newFormat.SetFormatAttr(aAttrSet);
 
 if (bHeader)
-CopyHeader(*pStashedFormatSrc, *pNewFormat);
+CopyHeader(*pStashedFormatSrc, newFormat);
 else
-CopyFooter(*pStashedFormatSrc, *pNewFormat);
+CopyFooter(*pStashedFormatSrc, newFormat);
 
-rDstDesc.StashFrameFormat(*pNewFormat, bHeader, bLeft, 
bFirst);
+rDstDesc.StashFrameFormat(newFormat, bHeader, bLeft, 
bFirst);
 }
 else
 {
diff --git a/sw/source/core/layout/pagedesc.cxx 
b/sw/source/core/layout/pagedesc.cxx
index 2b7882332789..f9679bb2a8e7 100644
--- a/sw/source/core/layout/pagedesc.cxx
+++ b/sw/source/core/layout/pagedesc.cxx
@@ -83,13 +83,13 @@ SwPageDesc::SwPageDesc( const SwPageDesc  )
 , m_FootnoteInfo( rCpy.GetFootnoteInfo() )
 , m_pdList( nullptr )
 {
-m_aStashedHeader.m_pStashedFirst = rCpy.m_aStashedHeader.m_pStashedFirst;
-m_aStashedHeader.m_pStashedLeft = rCpy.m_aStashedHeader.m_pStashedLeft;
-m_aStashedHeader.m_pStashedFirstLeft = 
rCpy.m_aStashedHeader.m_pStashedFirstLeft;
+m_aStashedHeader.m_oStashedFirst = rCpy.m_aStashedHeader.m_oStashedFirst;
+m_aStashedHeader.m_oStashedLeft = rCpy.m_aStashedHeader.m_oStashedLeft;
+m_aStashedHeader.m_oStashedFirstLeft = 
rCpy.m_aStashedHeader.m_oStashedFirstLeft;
 
-m_aStashedFooter.m_pStashedFirst = rCpy.m_aStashedFooter.m_pStashedFirst;
-m_aStashedFooter.m_pStashedLeft = 

[Bug 159862] Calc Macro set SearchWildcard to False changes SearchRegularExpression value.

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159862

Julien Nabet  changed:

   What|Removed |Added

 OS|Windows (All)   |All
Version|7.3.4.2 release |5.2.0.4 release
 Ever confirmed|0   |1
 CC||er...@redhat.com,
   ||serval2...@yahoo.fr
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #1 from Julien Nabet  ---
Indeed!
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Here's the debug:
1) when calling oDescriptor.SearchRegularExpression = true, it gets there:
348 void SvxSearchItem::SetRegExp( bool bVal )
349 {
350 if ( bVal )
351 {
352 m_aSearchOpt.AlgorithmType2 = SearchAlgorithms2::REGEXP;
<==HERE
353 }
354 else if ( SearchAlgorithms2::REGEXP == m_aSearchOpt.AlgorithmType2
)
355 {
356 m_aSearchOpt.AlgorithmType2 = SearchAlgorithms2::ABSOLUTE;
357 }
358 }

#0  SvxSearchItem::SetRegExp(bool) (this=0x55feb38452e0, bVal=true) at
svl/source/items/srchitem.cxx:352
#1  0x7fee5382583d in ScCellSearchObj::setPropertyValue(rtl::OUString
const&, com::sun::star::uno::Any const&)
(this=0x55feb370b1f0, aPropertyName="SearchRegularExpression",
aValue=uno::Any("boolean": 1 '\001')) at sc/source/ui/unoobj/srchuno.cxx:136
=> OK


2) when calling msgbox(oDescriptor.SearchRegularExpression), it gets there:
243 bool SvxSearchItem::GetRegExp() const
244 {
245 return m_aSearchOpt.AlgorithmType2 ==
css::util::SearchAlgorithms2::REGEXP ;
246 }

#0  SvxSearchItem::GetRegExp() const (this=0x55feb38452e0) at
include/svl/srchitem.hxx:245
#1  0x7fee538260a6 in ScCellSearchObj::getPropertyValue(rtl::OUString
const&) (this=0x55feb370b1f0, aPropertyName="SearchRegularExpression") at
sc/source/ui/unoobj/srchuno.cxx:159

so here it returns true as expected.
=> OK

3) when calling oDescriptor.SearchWildcard = false, it gets there:
361 void SvxSearchItem::SetWildcard( bool bVal )
362 {
363 if ( bVal )
364 {
365 m_aSearchOpt.AlgorithmType2 = SearchAlgorithms2::WILDCARD;
366 }
367 else if ( SearchAlgorithms2::REGEXP == m_aSearchOpt.AlgorithmType2
)
368 {
369 m_aSearchOpt.AlgorithmType2 =
SearchAlgorithms2::ABSOLUTE;//HERE
370 }
371 }


So when calling msgbox(oDescriptor.SearchRegularExpression) the second time, it
returns false since now m_aSearchOpt.AlgorithmType2 =
SearchAlgorithms2::ABSOLUTE and not css::util::SearchAlgorithms2::REGEXP
=> KO

I suppose line 367 is a wrong copy-paste, it should be:
else if ( SearchAlgorithms2::WILDCARD == m_aSearchOpt.AlgorithmType2 )

It's been like this since 3a0abd3019ec3ca29b8f1378cdb32ebf741e6306
add SvxSearchItem::GetWildcard() SetWildcard()
in 2016

Patch on gerrit here:
https://gerrit.libreoffice.org/c/core/+/163876

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159864] Impress error in slide transition (PUSH - Right to Left) when open Powerpoint presentation (pptx)

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159864

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from BogdanB  ---
Marco, any new bugs stay in Unconfirmed status, until someone else confirm it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159865] Font of the drop down menu in Page Size is very low.

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159865

raal  changed:

   What|Removed |Added

 CC||jl...@mail.com
  Regression By||Justin Luth
   Keywords||bibisected, bisected

--- Comment #3 from raal  ---
This seems to have begun at the below commit in bibisect repository/OS
linux-64-24.2.
Adding Cc: to Justin Luth ; Could you possibly take a look at this one?
Thanks

2a53cf5649b8c5e93fb98f919d8b9aa6c4d3b3f6 is the first bad commit
commit 2a53cf5649b8c5e93fb98f919d8b9aa6c4d3b3f6
Author: Jenkins Build User 
Date:   Tue Jul 18 01:39:34 2023 +0200

source sha:1876feb8a8805b2f80537e2828c152ccbdf67fe2

154286: tdf#136905 NBB: let ValueSetWithTextControl set optimal height |
https://gerrit.libreoffice.org/c/core/+/154286

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107237] [META] Notebookbar Tabbed

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107237

raal  changed:

   What|Removed |Added

 Depends on||159865


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159865
[Bug 159865] Font of the drop down menu in Page Size is very low.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159865] Font of the drop down menu in Page Size is very low.

2024-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159865

raal  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 CC||r...@post.cz
 Blocks||107237
   Keywords||regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from raal  ---
Confirm with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5f0021cdd0b84fccaecf23a014622f0aca86430c
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

Not in Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: 229123ccc6f90ebf66b3e659bebbd53f8a9bdd3a
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107237
[Bug 107237] [META] Notebookbar Tabbed
-- 
You are receiving this mail because:
You are the assignee for the bug.

<    1   2