Re: Can someone review a patch to fix the audio in PPTX?

[Miklos Vajna]

Hi Vladislav,

On Tue, Mar 12, 2024 at 03:08:23PM +0300, Владислав Тараканов 
 wrote:
> irgalie...@mail.ru and I recently sent a patch that adds launching media 
> files in presentation mode from the presentation directory if they were not 
> found in the absolute path. At the moment, we have implemented functionality 
> only for GStreamer. Before adding implementations for Windows, Mac and gtk4, 
> we would like to make sure that the part common to all players is written 
> correctly.
> 
> Can someone review this patch: https://gerrit.libreoffice.org/c/core/+/164023?

One way is to do a git log on the files you touched, see who are the
people with recent commits to those files and add them as reviewers.

Could you please do that?

Thanks,

Miklos

Can someone review a patch to fix the audio in PPTX?

[Владислав Тараканов]

Hello.

irgalie...@mail.ru and I recently sent a patch that adds launching media files 
in presentation mode from the presentation directory if they were not found in 
the absolute path. At the moment, we have implemented functionality only for 
GStreamer. Before adding implementations for Windows, Mac and gtk4, we would 
like to make sure that the part common to all players is written correctly.

Can someone review this patch: https://gerrit.libreoffice.org/c/core/+/164023?
--
Vladislav Tarakanov

Re: Missing Patch Inside LibreOffice Core Branch Master

[Miklos Vajna]

Hi Andreas,

On Wed, Dec 27, 2023 at 02:50:58PM +0100, Andreas Mantke  wrote:
> I found out again that at least one patch didn't make it to the
> LibreOffice core repository, branch master:
> https://gerrit.libreoffice.org/c/core/+/160022
> 
> I hope this is a lapse again and it would be good to have this patch in
> the LibreOffice core master tree too. It's currently only available in a
> branch.

This is done now.

Regards,

Miklos

Missing Patch Inside LibreOffice Core Branch Master

[Andreas Mantke]

Hi all,

I found out again that at least one patch didn't make it to the
LibreOffice core repository, branch master:
https://gerrit.libreoffice.org/c/core/+/160022

I hope this is a lapse again and it would be good to have this patch in
the LibreOffice core master tree too. It's currently only available in a
branch.

Regards,
Andreas

--
## Free Software Advocate
## Plone add-on developer
## My blog: http://www.amantke.de/blog

[Libreoffice-bugs] [Bug 66826] patch 2.7 / line-ending issue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66826

--- Comment #8 from Mike Kaganski  ---
This shows, that I followed the correct path when needed to build a 4.0 version
now :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Missing Patch Inside LibreOffice Core Master Branch

[Miklos Vajna]

Hi Andreas,

On Thu, Aug 10, 2023 at 09:05:06PM +0200, Andreas Mantke  wrote:
> I looked on the LibreOffice Gerrit and found out that a patch of the
> LibreOffice kit has not been committed to the LibreOffice master branch:
> https://gerrit.libreoffice.org/c/core/+/155282
> 
> I think it would only a lapse that it didn't make it only in branch but
> not into the master.

I think this was already explained in the past, some commits are not yet
ready for master and first bake in feature/ or distro/ branches.

With that aside, this particular change is now pending CI against master
at <https://gerrit.libreoffice.org/c/core/+/155577>.

Regards,

Miklos

Missing Patch Inside LibreOffice Core Master Branch

[Andreas Mantke]

Hi all,

I looked on the LibreOffice Gerrit and found out that a patch of the
LibreOffice kit has not been committed to the LibreOffice master branch:
https://gerrit.libreoffice.org/c/core/+/155282

I think it would only a lapse that it didn't make it only in branch but
not into the master.

Regards,
Andreas

--
## Free Software Advocate
## Plone add-on developer
## My blog: http://www.amantke.de/blog

Patch in Gerrit to bring Spanish dictionaries up to current version 2.7

[Ricardo Palomares]

Hi,

I don't know whether it is needed or not to announce it here, but,
just in case, I've just committed this changeset to Gerrit to update
shipped Spanish spellcheck dictionaries to our current version 2.7:

https://gerrit.libreoffice.org/c/dictionaries/+/145025

Thanks in advance, and Happy New Year. :-)

-- 
Ricardo Palomares (RickieES)
https://github.com/RickieES
https://sourceforge.net/u/rpalomares/profile
http://stackoverflow.com/users/1185157/

[RESOLVED] Re: Error when trying to submit patch on gerrit (No space left on device)

[Julien Nabet]

On 03/09/2022 09:12, Julien Nabet wrote:

Hello,

This morning when trying to submit a patch, I got:

no branch specified, guessing current branch master
Enumerating objects: 11, done.
Counting objects: 100% (11/11), done.
Delta compression using up to 12 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 622 bytes | 622.00 KiB/s, done.
Total 6 (delta 5), reused 0 (delta 0), pack-reused 0
error: remote unpack failed: error No space left on device
fatal: Unpack error, check server log
To ssh://logerrit/core
 ! [remote rejected]   HEAD -> refs/for/master (n/a (unpacker 
error))

error: failed to push some refs to 'ssh://logerrit/core'

Is someone taking a look at gerrit server?


It's been fixed by Guilhem, thank you to him!

Julien

Error when trying to submit patch on gerrit (No space left on device)

[Julien Nabet]

Hello,

This morning when trying to submit a patch, I got:

no branch specified, guessing current branch master
Enumerating objects: 11, done.
Counting objects: 100% (11/11), done.
Delta compression using up to 12 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 622 bytes | 622.00 KiB/s, done.
Total 6 (delta 5), reused 0 (delta 0), pack-reused 0
error: remote unpack failed: error No space left on device
fatal: Unpack error, check server log
To ssh://logerrit/core
 ! [remote rejected]   HEAD -> refs/for/master (n/a (unpacker 
error))

error: failed to push some refs to 'ssh://logerrit/core'

Is someone taking a look at gerrit server?

Julien

Re: Improve WriteCustomGeometry in oox export; review of patch

[Miklos Vajna]

Hi Regina,

On Thu, Mar 24, 2022 at 07:33:24PM +0100, Regina Henschel 
 wrote:
> The commit message is quite detailed. If something is still unclear, please
> send me a mail.

Not only that, but the various test files you added in the tests also
helped to understand the problem you solve. Thanks for that.

> BTW, Jenkins fails for a reason I don't know. But I want to first
> incorporate your suggestions before I start a next try with Jenkins.

It was just a one-off failure, it went away after a "resume".

Regards,

Miklos

Improve WriteCustomGeometry in oox export; review of patch

[Regina Henschel]

Hi Miklos, hi all,

the patch in https://gerrit.libreoffice.org/c/core/+/131837 is now ready 
for review.


It is a change in the way a custGeom element is generated. I have 
dropped the export via PolyPolygon. Instead our path commands are 
directly mapped to oox path commands. That is a larger change, so it 
would be good, if you find time to review it.


The commit message is quite detailed. If something is still unclear, 
please send me a mail.


BTW, Jenkins fails for a reason I don't know. But I want to first 
incorporate your suggestions before I start a next try with Jenkins.


Kind regards,
Regina

Re: submit a revised patch to an abandoned gerrit change

[Ilmari Lauhakangas]

On 12.1.2022 17.42, Chris Sherlock wrote:



On 13 Jan 2022, at 12:11 am, Winfried Donkers  
wrote:





I have the same menu, but just next to the menu button (the vertical ...),
on the left side, there is also a RESTORE button.


Might only work for own patches.


OK, thanks all, I'll simply submit a new patch and refer to the abandoned one 
(I have no need for elevated permissions).

Winfried


I think the issue will be, however, that the authorship information will have 
been diluted. I guess if you note in the commit message who the original author 
was and that you adapted it that would probably be fine.


One can do

git commit --author='First Last '

Ilmari

Re: submit a revised patch to an abandoned gerrit change

[Chris Sherlock]

> On 13 Jan 2022, at 12:11 am, Winfried Donkers 
>  wrote:
> 
> 
>> 
>>> I have the same menu, but just next to the menu button (the vertical ...),
>>> on the left side, there is also a RESTORE button.
>>> 
>> Might only work for own patches.
> 
> OK, thanks all, I'll simply submit a new patch and refer to the abandoned one 
> (I have no need for elevated permissions).
> 
> Winfried

I think the issue will be, however, that the authorship information will have 
been diluted. I guess if you note in the commit message who the original author 
was and that you adapted it that would probably be fine.

Chris

Re: submit a revised patch to an abandoned gerrit change

[Winfried Donkers]

I have the same menu, but just next to the menu button (the vertical ...),
on the left side, there is also a RESTORE button.


Might only work for own patches.


OK, thanks all, I'll simply submit a new patch and refer to the 
abandoned one (I have no need for elevated permissions).


Winfried

Re: submit a revised patch to an abandoned gerrit change

[Thorsten Behrens]

Jan-Marek Glogowski wrote:
> I have the same menu, but just next to the menu button (the vertical ...),
> on the left side, there is also a RESTORE button.
> 
Might only work for own patches.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature

Re: submit a revised patch to an abandoned gerrit change

[Michael Stahl]

On 12.01.22 08:56, Jan-Marek Glogowski wrote:

On 12.01.22 07:22, Winfried Donkers wrote:
Is it possible to reopen an abandoned gerrit change when you're not 
the original contributor?


I see a restore button for every abandoned patch. But why not simply 
try?


I can't see any restore button; in menu I see Cherry pick, Download 
patch and Ignore.


I have the same menu, but just next to the menu button (the vertical 
...), on the left side, there is also a RESTORE button.


https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#restore 


i think restoring other users' changes requires your gerrit user to have 
permissions that not everybody has.

Re: submit a revised patch to an abandoned gerrit change

[Jan-Marek Glogowski]

On 12.01.22 07:22, Winfried Donkers wrote:
Is it possible to reopen an abandoned gerrit change when you're not 
the original contributor?


I see a restore button for every abandoned patch. But why not simply try?


I can't see any restore button; in menu I see Cherry pick, Download 
patch and Ignore.


I have the same menu, but just next to the menu button (the vertical 
...), on the left side, there is also a RESTORE button.


https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#restore

Jan-Marek

Re: submit a revised patch to an abandoned gerrit change

[Winfried Donkers]

Is it possible to reopen an abandoned gerrit change when you're not 
the original contributor?


I see a restore button for every abandoned patch. But why not simply try?


I can't see any restore button; in menu I see Cherry pick, Download 
patch and Ignore.


Winfried

Re: submit a revised patch to an abandoned gerrit change

[Jan-Marek Glogowski]

On 11.01.22 16:16, Winfried Donkers wrote:
Is it possible to reopen an abandoned gerrit change when you're not the 
original contributor?


I see a restore button for every abandoned patch. But why not simply try?

submit a revised patch to an abandoned gerrit change

[Winfried Donkers]

In 2017 a contributor submitted several patches to gerrit, but in the 
end didn't succeed in fixing the bug and gave up.
The contributor gave up and gerrit (Pootle bot) changed the status of 
the gerrit change to abandoned.


Last month I received a question whether I could do something with the 
(still unresolved) bug report.
I made changes to the patch and would like to submit 'my' patch to the 
same gerrit change with me and the original contributor as co-authors.
However, gerrit won't accept the patch I submitted because the status of 
the change is 'abandoned'.


I can submit as a new patch of course and refer to the original patches, 
but reopening the original gerrit change seems (seemed?) a better idea.
Is it possible to reopen an abandoned gerrit change when you're not the 
original contributor? (In my case it isn't relevant whether the original 
contributor can reopen the change, I cannot get a response from him.)


If it a lot of bother to reopen, I will submit as a new patch and refer 
to the original change. But who knows, reopening might be simple...


Winfried

(I intentionally left out references to bug report and gerrit change to 
avoid over-publishing of someone's struggle to get a well written and 
properly functioning patch.)

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

Collabora Productivity Ltd  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Collabora Productivity Ltd 
 ---
https://gerrit.libreoffice.org/c/dictionaries/+/127910
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

Julien Nabet  changed:

   What|Removed |Added

 CC||tima...@gmail.com

--- Comment #6 from Julien Nabet  ---
(In reply to Michael Meeks from comment #5)
> Thanks for checking Julien - as Olivier said - dictionaries are something of
> a special-case license wise: much as it would be a good idea to re-base on
> the LaTeX MIT base here and have a clearer picture.
> 
> So no objections - as long as you're happy linguistically =)
> 
> Thanks Olivier !

No pb!
Andras: thought you might be interested in this one as dictionaries expert.

(I would have submitted the patch if I had remembered the mechanism of gerrit
submitting for a submodule)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

--- Comment #5 from Michael Meeks  ---
Thanks for checking Julien - as Olivier said - dictionaries are something of a
special-case license wise: much as it would be a good idea to re-base on the
LaTeX MIT base here and have a clearer picture.

So no objections - as long as you're happy linguistically =)

Thanks Olivier !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

--- Comment #4 from Olivier R.  ---
If you dig into the dictionaries repository, you’ll find other resources that
are licensed only with GPL or LGPL.

DE
- dictionary: GPL
- hyphenation: LGPL
- thesaurus: LGPL

ES
- thesaurus: LGPL

IT
- dictionary: GPL
- hyphenation: LGPL
- thesaurus: GPL

HU
- thesaurus: GPL

RU
- thesaurus: LGPL

That’s probably why the repository for external resources is separate from the
code repository.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

Julien Nabet  changed:

   What|Removed |Added

 CC||michael.me...@collabora.com
   ||, serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
I don't know if license of the patch (it seems GNU LGPL just reading the patch)
is fully compatible with the requirements indicated in
https://wiki.documentfoundation.org/Development/GetInvolved#License_statement:
MPLv2/LGPLv3+ dual license

(I'm not a lawyer expert but just would like potential pbs :-))

Michael: any idea?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

sophie  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||patch

--- Comment #2 from sophie  ---
Thanks Olivier for your patch and your work :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

Olivier R.  changed:

   What|Removed |Added

 CC||olivier@grammalecte.net

--- Comment #1 from Olivier R.  ---
Created attachment 177209
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177209=edit
Patch to update the French hyphenation rules

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] New: [PATCH] Update for French hyphenation rules

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146485

Bug ID: 146485
   Summary: [PATCH] Update for French hyphenation rules
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Linguistic
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: olivier@grammalecte.net
CC: so...@libreoffice.org

Description:
The new rules file for French hyphenation have been made by Marc Lodewijck, who
already created the previous version.
I have tested the new rules file and everything seems to work fine.

Thanks.


Steps to Reproduce:
Not a bug. An enhancement.

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Need help with patch for Fontwork shape

[Regina Henschel]

Hi Miklos,

thank you for starting a next try to build. The build was now successful.

Kind regards
Regina

Regina Henschel schrieb am 12.10.2021 um 17:00:

Hi all,

I need help with patch https://gerrit.libreoffice.org/c/core/+/123295

It passes Jenkins in Patchset 3. The only change was then a change in 
the commit message. But now it fails with always the same problem. I 
know Jenkins has a "hiccup" sometimes and tried a Rebase. But without 
success.


The failure refers to CppunitTest_vcl_filters_test.
https://ci.libreoffice.org/job/gerrit_linux_gcc_release/101923/consoleFull#-1482350923d893063f-7f3d-4b7e-b56f-4e0f225817cd 



I see no connection to the change in my patch and vcl.check has no 
problems locally on Windows 10/Cygwin.


Kind regards
Regina

Need help with patch for Fontwork shape

[Regina Henschel]

Hi all,

I need help with patch https://gerrit.libreoffice.org/c/core/+/123295

It passes Jenkins in Patchset 3. The only change was then a change in 
the commit message. But now it fails with always the same problem. I 
know Jenkins has a "hiccup" sometimes and tried a Rebase. But without 
success.


The failure refers to CppunitTest_vcl_filters_test.
https://ci.libreoffice.org/job/gerrit_linux_gcc_release/101923/consoleFull#-1482350923d893063f-7f3d-4b7e-b56f-4e0f225817cd

I see no connection to the change in my patch and vcl.check has no 
problems locally on Windows 10/Cygwin.


Kind regards
Regina

Re: cppunit Patch feature-modernize

[Florian Becker]

Hi Markus,

about the size_t changes. Most correct seams for me a solution to change all 
these to size_t and avoid casting, but that is a lot of work.

Let me know, if you need some kind of support.

Also, i saw, that you have not merges documentation termination for \n to \\n 
or c:\path to c:\\path.

The backslash is interpreted as command so you need to terminate it.

I have merged master from remote and new feature branch. So you can compare 
both to see, what patches are not yet merged.

Regards,
Florian

> Am 30.09.2021 um 21:55 schrieb Markus Mohrhard 
> :
> 
> Hey Florian,
> 
> On Fri, Oct 1, 2021 at 1:52 AM Markus Mohrhard 
> mailto:markus.mohrh...@googlemail.com>> 
> wrote:
> Hey Florian,
> 
> On Tue, Sep 28, 2021 at 5:59 PM Florian Becker  <mailto:f...@vxapps.com>> wrote:
> Hello,
> 
> i have patched the libcppunit 1.15.1 to modernize and use clang flags 
> with highest flag settings. Hopefully you can integrate this patch 
> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize 
> <https://github.com/VXAPPS/cppunit/tree/feature-modernize>
> 
> If you have suggestions, please let me know.
> 
> I'll have a look during the next few days and will let you know if I have any 
> questions or comments
> 
> Thanks for your patches. The summary is:
> 
> * first patch was used without modifications
> * second patch was split up into smaller commits:
>* add [[noreturn]]
>* add override annotations
>* switch from throw to noexcept
>* remove semicolons
>* a complete removal of the old casting macros by me instead of your 
> addition to the portability header
>* replace 0 with nullptr
>* disable a few simple compiler warnings
> 
> I have not yet taken the size_t changes as that part contains some bugs. I 
> have already fixed one but want to have a second look and think about whether 
> this is how we want to solve this problem.
> I also had to remove all references to [[deprecated]] in this change as 
> [[deprecated]] is only C++14 and at least for now cppunit is still at C++11.
> 
> * I'll have to think a bit about the third and fourth patch. If I merge them 
> I'll let you know.
> 
> You can find the full code that I have pushed at:
> 
> https://git.libreoffice.org/cppunit/+log/refs/heads/master 
> <https://git.libreoffice.org/cppunit/+log/refs/heads/master>
> 
> Cheers,
> Markus
> 
> 
> 
> Cheers,
> Markus
> 
> 
> Regards,
> Florian
> 



smime.p7s
Description: S/MIME cryptographic signature

Re: cppunit Patch feature-modernize

[Florian Becker]

Hi,

> Am 01.10.2021 um 12:47 schrieb Markus Mohrhard 
> :
> 
> Hey,
> 
> On Fri, Oct 1, 2021 at 4:02 AM Florian Becker  <mailto:f...@vxapps.com>> wrote:
> Hi Markus,
> 
> thanks a lot.
> 
> Is there a list of compiler, which are supported? Also, is there any reason, 
> why cppunit cannot upgrade to c++17?
> 
> This would force all dependent projects to use C++17 as well. Already the 
> move to C++11 caused some issues for some older projects using cppunit. 
> Currently I don't see a compelling reason to update for cppunit. The decision 
> to move to C++11 was easier and provided a clear benefit.
Ok, understand. Mostly this can be done by compiler checks and flag the 
functionality. But i think you already know that...
> 
> 
> I would like to create a cmake definition - do we handle that the same way?
> 
> Have you had a look at the feature/cmake branch?
Not yet, never thought there would be such a branch. I’ll check it. Thanks for 
the information.

Regards,
Florian
> 
> Cheers,
> Markus
> 
> 
> Regards,
> Florian
> 
>> Am 30.09.2021 um 21:56 schrieb Markus Mohrhard 
>> mailto:markus.mohrh...@googlemail.com>>:
>> 
>> 
>> Hey Florian,
>> 
>> On Fri, Oct 1, 2021 at 1:52 AM Markus Mohrhard 
>> mailto:markus.mohrh...@googlemail.com>> 
>> wrote:
>> Hey Florian,
>> 
>> On Tue, Sep 28, 2021 at 5:59 PM Florian Becker > <mailto:f...@vxapps.com>> wrote:
>> Hello,
>> 
>> i have patched the libcppunit 1.15.1 to modernize and use clang flags 
>> with highest flag settings. Hopefully you can integrate this patch 
>> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize 
>> <https://github.com/VXAPPS/cppunit/tree/feature-modernize>
>> 
>> If you have suggestions, please let me know.
>> 
>> I'll have a look during the next few days and will let you know if I have 
>> any questions or comments
>> 
>> Thanks for your patches. The summary is:
>> 
>> * first patch was used without modifications
>> * second patch was split up into smaller commits:
>>* add [[noreturn]]
>>* add override annotations
>>* switch from throw to noexcept
>>* remove semicolons
>>* a complete removal of the old casting macros by me instead of your 
>> addition to the portability header
>>* replace 0 with nullptr
>>* disable a few simple compiler warnings
>> 
>> I have not yet taken the size_t changes as that part contains some bugs. I 
>> have already fixed one but want to have a second look and think about 
>> whether this is how we want to solve this problem.
>> I also had to remove all references to [[deprecated]] in this change as 
>> [[deprecated]] is only C++14 and at least for now cppunit is still at C++11.
>> 
>> * I'll have to think a bit about the third and fourth patch. If I merge them 
>> I'll let you know.
>> 
>> You can find the full code that I have pushed at:
>> 
>> https://git.libreoffice.org/cppunit/+log/refs/heads/master 
>> <https://git.libreoffice.org/cppunit/+log/refs/heads/master>
>> 
>> Cheers,
>> Markus
>> 
>> 
>> 
>> Cheers,
>> Markus
>> 
>> 
>> Regards,
>> Florian
>> 



smime.p7s
Description: S/MIME cryptographic signature

Re: cppunit Patch feature-modernize

[Markus Mohrhard]

Hey,

On Fri, Oct 1, 2021 at 4:02 AM Florian Becker  wrote:

> Hi Markus,
>
> thanks a lot.
>
> Is there a list of compiler, which are supported? Also, is there any
> reason, why cppunit cannot upgrade to c++17?
>

This would force all dependent projects to use C++17 as well. Already the
move to C++11 caused some issues for some older projects using cppunit.
Currently I don't see a compelling reason to update for cppunit. The
decision to move to C++11 was easier and provided a clear benefit.


> I would like to create a cmake definition - do we handle that the same way?
>

Have you had a look at the feature/cmake branch?

Cheers,
Markus


> Regards,
> Florian
>
> Am 30.09.2021 um 21:56 schrieb Markus Mohrhard <
> markus.mohrh...@googlemail.com>:
>
> 
> Hey Florian,
>
> On Fri, Oct 1, 2021 at 1:52 AM Markus Mohrhard <
> markus.mohrh...@googlemail.com> wrote:
>
>> Hey Florian,
>>
>> On Tue, Sep 28, 2021 at 5:59 PM Florian Becker  wrote:
>>
>>> Hello,
>>>
>>> i have patched the libcppunit 1.15.1 to modernize and use clang flags
>>> with highest flag settings. Hopefully you can integrate this patch
>>> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize
>>>
>>> If you have suggestions, please let me know.
>>>
>>
>> I'll have a look during the next few days and will let you know if I have
>> any questions or comments
>>
>
> Thanks for your patches. The summary is:
>
> * first patch was used without modifications
> * second patch was split up into smaller commits:
>* add [[noreturn]]
>* add override annotations
>* switch from throw to noexcept
>* remove semicolons
>* a complete removal of the old casting macros by me instead of your
> addition to the portability header
>* replace 0 with nullptr
>* disable a few simple compiler warnings
>
> I have not yet taken the size_t changes as that part contains some bugs. I
> have already fixed one but want to have a second look and think about
> whether this is how we want to solve this problem.
> I also had to remove all references to [[deprecated]] in this change as
> [[deprecated]] is only C++14 and at least for now cppunit is still at C++11.
>
> * I'll have to think a bit about the third and fourth patch. If I merge
> them I'll let you know.
>
> You can find the full code that I have pushed at:
>
> https://git.libreoffice.org/cppunit/+log/refs/heads/master
>
> Cheers,
> Markus
>
>
>
>> Cheers,
>> Markus
>>
>>
>>> Regards,
>>> Florian
>>>
>>>

Re: cppunit Patch feature-modernize

[Florian Becker]

Hi Markus,

thanks a lot.

Is there a list of compiler, which are supported? Also, is there any reason, 
why cppunit cannot upgrade to c++17?

I would like to create a cmake definition - do we handle that the same way?

Regards,
Florian

> Am 30.09.2021 um 21:56 schrieb Markus Mohrhard 
> :
> 
> 
> Hey Florian,
> 
>> On Fri, Oct 1, 2021 at 1:52 AM Markus Mohrhard 
>>  wrote:
>> Hey Florian,
>> 
>>> On Tue, Sep 28, 2021 at 5:59 PM Florian Becker  wrote:
>>> Hello,
>>> 
>>> i have patched the libcppunit 1.15.1 to modernize and use clang flags 
>>> with highest flag settings. Hopefully you can integrate this patch 
>>> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize
>>> 
>>> If you have suggestions, please let me know.
>> 
>> I'll have a look during the next few days and will let you know if I have 
>> any questions or comments
> 
> Thanks for your patches. The summary is:
> 
> * first patch was used without modifications
> * second patch was split up into smaller commits:
>* add [[noreturn]]
>* add override annotations
>* switch from throw to noexcept
>* remove semicolons
>* a complete removal of the old casting macros by me instead of your 
> addition to the portability header
>* replace 0 with nullptr
>* disable a few simple compiler warnings
> 
> I have not yet taken the size_t changes as that part contains some bugs. I 
> have already fixed one but want to have a second look and think about whether 
> this is how we want to solve this problem.
> I also had to remove all references to [[deprecated]] in this change as 
> [[deprecated]] is only C++14 and at least for now cppunit is still at C++11.
> 
> * I'll have to think a bit about the third and fourth patch. If I merge them 
> I'll let you know.
> 
> You can find the full code that I have pushed at:
> 
> https://git.libreoffice.org/cppunit/+log/refs/heads/master
> 
> Cheers,
> Markus
> 
> 
>> 
>> Cheers,
>> Markus
>> 
>>> 
>>> Regards,
>>> Florian
>>> 


smime.p7s
Description: S/MIME cryptographic signature

Re: cppunit Patch feature-modernize

[Markus Mohrhard]

Hey Florian,

On Fri, Oct 1, 2021 at 1:52 AM Markus Mohrhard <
markus.mohrh...@googlemail.com> wrote:

> Hey Florian,
>
> On Tue, Sep 28, 2021 at 5:59 PM Florian Becker  wrote:
>
>> Hello,
>>
>> i have patched the libcppunit 1.15.1 to modernize and use clang flags
>> with highest flag settings. Hopefully you can integrate this patch
>> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize
>>
>> If you have suggestions, please let me know.
>>
>
> I'll have a look during the next few days and will let you know if I have
> any questions or comments
>

Thanks for your patches. The summary is:

* first patch was used without modifications
* second patch was split up into smaller commits:
   * add [[noreturn]]
   * add override annotations
   * switch from throw to noexcept
   * remove semicolons
   * a complete removal of the old casting macros by me instead of your
addition to the portability header
   * replace 0 with nullptr
   * disable a few simple compiler warnings

I have not yet taken the size_t changes as that part contains some bugs. I
have already fixed one but want to have a second look and think about
whether this is how we want to solve this problem.
I also had to remove all references to [[deprecated]] in this change as
[[deprecated]] is only C++14 and at least for now cppunit is still at C++11.

* I'll have to think a bit about the third and fourth patch. If I merge
them I'll let you know.

You can find the full code that I have pushed at:

https://git.libreoffice.org/cppunit/+log/refs/heads/master

Cheers,
Markus



> Cheers,
> Markus
>
>
>> Regards,
>> Florian
>>
>>

Re: cppunit Patch feature-modernize

[Markus Mohrhard]

Hey Florian,

On Tue, Sep 28, 2021 at 5:59 PM Florian Becker  wrote:

> Hello,
>
> i have patched the libcppunit 1.15.1 to modernize and use clang flags
> with highest flag settings. Hopefully you can integrate this patch
> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize
>
> If you have suggestions, please let me know.
>

I'll have a look during the next few days and will let you know if I have
any questions or comments

Cheers,
Markus


> Regards,
> Florian
>
>

Re: cppunit Patch feature-modernize

[Miklos Vajna]

Hi Florian,

On Mon, Sep 27, 2021 at 05:27:56PM +, Florian Becker  
wrote:
> i have patched the libcppunit 1.15.1 to modernize and use clang flags 
> with highest flag settings. Hopefully you can integrate this patch 
> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize
> 
> If you have suggestions, please let me know.

CC Markus, I'm not sure if he still follows the LO dev list actively.

Regards,

Miklos

cppunit Patch feature-modernize

[Florian Becker]

Hello,

i have patched the libcppunit 1.15.1 to modernize and use clang flags 
with highest flag settings. Hopefully you can integrate this patch 
inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize

If you have suggestions, please let me know.

Regards,
Florian

Code Reviewer needed to review patch

[Sarabjot Singh]

I need a code reviewer for a patch I submitted to gerrit for bug tdf#104169
<https://bugs.documentfoundation.org/show_bug.cgi?id=104169>.
Patch : https://gerrit.libreoffice.org/c/core/+/114679
Bug : https://bugs.documentfoundation.org/show_bug.cgi?id=104169

The bug is a difficultyInteresting EasyHack and involves Calc and mouse
cursors. It is actually an enhancement to calc and aims at introducing a
new cross cursor to replace the current Arrow pointer while hovering over
the spreadsheet in calc.

This patch is in continuation to an unfinished patch submitted by Mesut
Cifci an year ago (https://gerrit.libreoffice.org/c/core/+/89744). At the
time Mesut was working on this bug, a cross cursor was already present in
calc but it was the thin, black-coloured cross used for auto-fill. Mesut
added another thicker, white cross to use in this bug, which goes by the
name FatCross in code.

I adjusted cursor hotspot and fixed some cursor calls on mouse clicks in
code and have (apparently not) completed the enhancement. I successfully
tested the new cursor on my Linux system. It looks like this:
https://bugs.documentfoundation.org/attachment.cgi?id=171459. But Heiko
soon reported an issue with the appearance of the cursor on his
configuration (another flavour of Linux):
https://bugs.documentfoundation.org/attachment.cgi?id=171447. I have, so
far, failed to replicate the problem on my system. (More details on gerrit
<https://gerrit.libreoffice.org/c/core/+/114679>)

So I need someone to review my code (and perhaps help a bit if needed).
An opinion or suggestion on the cursor's appearance would also be
appreciated.

Thanks
Sarabjot Singh
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[julien2412]

Stanisław Jeśmanowicz wrote
>>
> This is not always the case, because if a platform didn't include
> graphite2 shaper in its HarfBuzz 
> implementaion, you won't have it anyway ( like ./configure
> --with-graphite2=no )
> Even if you set it the shapers list (as in 
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316
> )
> And if graphite2 shaper is implemented, then it will be first (as you can
> see in the harfbuzz code: 
> https://github.com/harfbuzz/harfbuzz/blob/master/src/hb-shaper-list.hh )
> And generally speaking, hard-coded list in such a case disables possible
> new shapers.

Perhaps the goal was indeed to avoid non tested new shapers in LO that could
bring some havoc.
So by hard coding shapers, you're sure you won't have problems.
Now of course, if nobody ever test new shapers, LO will be stuck with old
ones.

Anyway, now you got an account, once you had already submitted your license
(see
https://wiki.documentfoundation.org/Development/GetInvolved#License_statement),
I'll put Khaled in cc, he certainly will bring interesting thoughts here.

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[julien2412]

Stanisław Jeśmanowicz wrote
> ...
> Thank you for your advice, but getting familiar with gerrit on top of git
> would take some time for 
> me now.
> I hope, that some of your developers could commit this patch for me in vcl
> module.
> It is simple and won't harm anything.
> But people could benefit from it on all platforms that use system's native
> HarfBuzz implementation.
> ...

I can understand you don't have time for gerrit but would it be possible you
submit a license statement?

About this line, I retrieved the initial patches which put this line:
1) earliest
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316:
Author: Khaled Hosny 
Date:   Fri Mar 10 16:53:08 2017 +0200

tdf#106466: Use graphite2 shaper first

We want to always prefer Graphite shaping when supported by the font,
which is also what HarfBuzz does by default.

Change-Id: I6670fc03b8e6b3d7e07e1b8e0062880524da1655
Reviewed-on: https://gerrit.libreoffice.org/35046
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 


2) oldest
https://cgit.freedesktop.org/libreoffice/core/commit/?id=7854d35cd8172b201f1f3ad247860f242e5cb06b
Author: Khaled Hosny 
Date:   Thu Oct 6 04:15:41 2016 +0200

Use HarfBuzz shape plan for a bit more control

This way we control exactly what shapers we use in what order, and as an
extra we can now tell which shaper HarfBuzz ends up using.

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[Ilmari Lauhakangas]

On 9.3.2021 20.51, Stanisław Jeśmanowicz wrote:


On 3/9/21 6:34 PM, julien2412 wrote:

Stanisław Jeśmanowicz wrote

...
Thank you for your advice, but getting familiar with gerrit on top of 
git

would take some time for
me now.
I hope, that some of your developers could commit this patch for me 
in vcl

module.
It is simple and won't harm anything.
But people could benefit from it on all platforms that use system's 
native

HarfBuzz implementation.
...


I can understand you don't have time for gerrit but would it be 
possible you

submit a license statement?

I have created an account and can log in to https://gerrit.libreoffice.org/
but it is not clear for me where to submit a license statement.


If you already created an account, you might as well submit the patch 
using the web interface: 
https://gerrit.libreoffice.org/Documentation/user-inline-edit.html


Re: license statement: 
https://wiki.documentfoundation.org/Development/GetInvolved#License_statement


Ilmari
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[Stanisław Jeśmanowicz]

On 3/9/21 6:34 PM, julien2412 wrote:

Stanisław Jeśmanowicz wrote

...
Thank you for your advice, but getting familiar with gerrit on top of git
would take some time for
me now.
I hope, that some of your developers could commit this patch for me in vcl
module.
It is simple and won't harm anything.
But people could benefit from it on all platforms that use system's native
HarfBuzz implementation.
...


I can understand you don't have time for gerrit but would it be possible you
submit a license statement?

I have created an account and can log in to https://gerrit.libreoffice.org/
but it is not clear for me where to submit a license statement.


About this line, I retrieved the initial patches which put this line:
1) earliest
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316:
Author: Khaled Hosny 
Date:   Fri Mar 10 16:53:08 2017 +0200

 tdf#106466: Use graphite2 shaper first
 
 We want to always prefer Graphite shaping when supported by the font,

 which is also what HarfBuzz does by default.


This is not always the case, because if a platform didn't include graphite2 shaper in its HarfBuzz 
implementaion, you won't have it anyway ( like ./configure --with-graphite2=no )
Even if you set it the shapers list (as in 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316 )
And if graphite2 shaper is implemented, then it will be first (as you can see in the harfbuzz code: 
https://github.com/harfbuzz/harfbuzz/blob/master/src/hb-shaper-list.hh )

And generally speaking, hard-coded list in such a case disables possible new 
shapers.

 
 Change-Id: I6670fc03b8e6b3d7e07e1b8e0062880524da1655

 Reviewed-on: https://gerrit.libreoffice.org/35046
 Tested-by: Jenkins 
 Reviewed-by: Khaled Hosny 


2) oldest
https://cgit.freedesktop.org/libreoffice/core/commit/?id=7854d35cd8172b201f1f3ad247860f242e5cb06b
Author: Khaled Hosny 
Date:   Thu Oct 6 04:15:41 2016 +0200

 Use HarfBuzz shape plan for a bit more control
 
 This way we control exactly what shapers we use in what order, and as an

 extra we can now tell which shaper HarfBuzz ends up using.

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



Stan

--
__

Stanislaw Jesmanowicz  stan  mail2  jesmanowicz  com
Amsterdam  voice : + 31 20 6126193
The Netherlandsmobile: + 31  653380520
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[Stanisław Jeśmanowicz]

Hello Julien,

On 3/9/21 9:18 AM, julien2412 wrote:

Hello,

In addition to what Miklos indicated, I think you may be interested in
https://wiki.documentfoundation.org/Development/GetInvolved.
Indeed, it seems you've already downloaded sources, built and tried to fix a
problem with a patch.
So you only need now a gerrit account and submit your license statement (not
the most difficult).
About the patch itself, I got no expertise so can't tell at all.
In general a patch can be discussed precisely in gerrit.


Thank you for your advice, but getting familiar with gerrit on top of git would take some time for 
me now.

I hope, that some of your developers could commit this patch for me in vcl 
module.
It is simple and won't harm anything.
But people could benefit from it on all platforms that use system's native 
HarfBuzz implementation.



Julien.



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



Regards,
Stan
--
__

Stanislaw Jesmanowicz  stan  mail2  jesmanowicz  com
Amsterdam  voice : + 31 20 6126193
The Netherlandsmobile: + 31  653380520
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[Stanisław Jeśmanowicz]

Hello Miklos,

On 3/9/21 9:14 AM, Miklos Vajna wrote:

Hi Stan,

On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz 
 wrote:

Dear all,

I noticed that LibreOffice is using the hard coded harfbuzz shapers list in
CommonSalLayout.cxx file (line 470).
I recommend the patch attached to be more flexible.
This take all possible shapers in a given HarfBuzz implementation.
This also allows the use of newly created shapers.

Just repleces line:
-  const char*const pHbShapers[] = { "dt", "graphite2", "coretext_aat", "ot", 
"fallback", nullptr };

with:
+  const char **pHbShapers = hb_shape_list_shapers();


Are you more or less reverting 7854d35cd8172b201f1f3ad247860f242e5cb06b?
Can you describe what is the practical benefit of doing so?


The benefits of applying this patch are:
1. HarfBuzz allows the development of external shapers, like graphite2.
   This way, if a LibreOffice is build with system HarfBuzz 
(--with-system-harfbuzz),
   then any new developed shaper would work without recompiling LibreOffice.
2. Also in case of using system HarfBuzz, a particular HarfBuzz implementation 
can decide
   which shaper to use out of currently existing list: graphite2, uniscribe, 
directwrite (so far).
3. Last, but not least, I have developed a HarfBuzz shaper and I would like 
that it work on systems
   that have implemented it.

I have send a similar patch request to Scribus people, because thy use also 
hard coded shapers list.
But open source distribution of Chromium works with new shapers out of box.



Regards,

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



Regards,
Stan
--
__

Stanislaw Jesmanowicz  stan  mail2  jesmanowicz  com
Amsterdam  voice : + 31 20 6126193
The Netherlandsmobile: + 31  653380520
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[julien2412]

Hello,

In addition to what Miklos indicated, I think you may be interested in
https://wiki.documentfoundation.org/Development/GetInvolved.
Indeed, it seems you've already downloaded sources, built and tried to fix a
problem with a patch.
So you only need now a gerrit account and submit your license statement (not
the most difficult).
About the patch itself, I got no expertise so can't tell at all.
In general a patch can be discussed precisely in gerrit.

Julien.



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: proposition for patch in CommonSalLayout.cxx

[Miklos Vajna]

Hi Stan,

On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz 
 wrote:
> Dear all,
> 
> I noticed that LibreOffice is using the hard coded harfbuzz shapers list in
> CommonSalLayout.cxx file (line 470).
> I recommend the patch attached to be more flexible.
> This take all possible shapers in a given HarfBuzz implementation.
> This also allows the use of newly created shapers.
> 
> Just repleces line:
> -  const char*const pHbShapers[] = { "dt", "graphite2", "coretext_aat", "ot", 
> "fallback", nullptr };
> 
> with:
> +  const char **pHbShapers = hb_shape_list_shapers();

Are you more or less reverting 7854d35cd8172b201f1f3ad247860f242e5cb06b?
Can you describe what is the practical benefit of doing so?

Regards,

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

proposition for patch in CommonSalLayout.cxx

[Stanisław Jeśmanowicz]

Dear all,

I noticed that LibreOffice is using the hard coded harfbuzz shapers list in CommonSalLayout.cxx file 
(line 470).

I recommend the patch attached to be more flexible.
This take all possible shapers in a given HarfBuzz implementation.
This also allows the use of newly created shapers.

Just repleces line:
-  const char*const pHbShapers[] = { "dt", "graphite2", "coretext_aat", "ot", 
"fallback", nullptr };

with:
+  const char **pHbShapers = hb_shape_list_shapers();

Best regards,
Stan

= patch

--- libreoffice-7.0.4.9/vcl/source/gdi/CommonSalLayout.cxx 2021-03-07 
18:38:41.339770315 +0100
+++ libreoffice-7.0.4.x/vcl/source/gdi/CommonSalLayout.cxx 2021-03-08 
12:29:37.045184836 +0100
@@ -463,11 +463,8 @@
  nMinRunPos, nRunLen);
  hb_buffer_set_cluster_level(pHbBuffer, 
HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS);

-// The shapers that we want HarfBuzz to use, in the order of
-// preference. The coretext_aat shaper is available only on macOS,
-// but there is no harm in always including it, HarfBuzz will
-// ignore unavailable shapers.
-const char*const pHbShapers[] = { "dt", "graphite2", "coretext_aat", "ot", "fallback", 
nullptr };

+// Take all possible shapers in a given HarfBuzz implementation.
+const char **pHbShapers = hb_shape_list_shapers();
  bool ok = hb_shape_full(pHbFont, pHbBuffer, maFeatures.data(), maFeatures.size(), 
pHbShapers);

  assert(ok);
  (void) ok;

--
__

Stanislaw Jesmanowicz  stan  mail2  jesmanowicz  com
Amsterdam  voice : + 31 20 6126193
The Netherlandsmobile: + 31  653380520

--- libreoffice-7.0.4.9/vcl/source/gdi/CommonSalLayout.cxx  2021-03-07 18:38:41.339770315 +0100
+++ libreoffice-7.0.4.x/vcl/source/gdi/CommonSalLayout.cxx  2021-03-08 12:29:37.045184836 +0100
@@ -463,11 +463,8 @@
 nMinRunPos, nRunLen);
 hb_buffer_set_cluster_level(pHbBuffer, HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS);
 
-// The shapers that we want HarfBuzz to use, in the order of
-// preference. The coretext_aat shaper is available only on macOS,
-// but there is no harm in always including it, HarfBuzz will
-// ignore unavailable shapers.
-const char*const pHbShapers[] = { "dt", "graphite2", "coretext_aat", "ot", "fallback", nullptr };
+// Take all possible shapers in a given HarfBuzz implementation.
+const char **pHbShapers = hb_shape_list_shapers();
 bool ok = hb_shape_full(pHbFont, pHbBuffer, maFeatures.data(), maFeatures.size(), pHbShapers);
 assert(ok);
 (void) ok;


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch: fix unpack-sources to not require GNU find

[Andrew Udvare]

Requesting review.

Patch submitted here a few months ago: 
https://gerrit.libreoffice.org/c/core/+/107936

The find that comes with macOS is BSD find and does not have -printf.

On macOS: $ man /usr/share/man/man1/find.1 | grep -F printf
(No results)

On Linux: $ man /usr/share/man/man1/find.1* | grep -F printf
   -delete, -exec, -execdir, -ok, -okdir, -fls, -fprint, -fprintf, -ls, 
-print and -printf.
  -printf with the %F directive to see the types of your 
filesystems.

Thanks

-- 
Andrew Udvare


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Fwd: Need help implementing a patch

[Ilmari Lauhakangas]

Heiko gave advice already.

Ilmari

On 23.11.2020 17.29, Xisco Fauli wrote:

Adding dev list

On 23/11/20 16:22, Xisco Fauli wrote:


forwarding this to the dev and ux lists for a wider audience.



 Forwarded Message 
Subject:Need help implementing a patch
Date:   Thu, 19 Nov 2020 20:30:20 -0300
From:   Rafael Lima 
To: mentor...@documentfoundation.org



Hi!

I am developing a patch to LO Impress to update the "Table Design" 
styles. The ones currently available are reminiscent of the OpenOffice 
era and do not look modern (see image https://imgur.com/WibEM0K 
<https://imgur.com/WibEM0K>).


The current styles are hard-coded in the file:
sd/source/core/drawdoc4.cxx

What I did was update the colors with new RGB values and new style 
names. Previously there were 11 styles and now I implemented 14 new 
styles, deleting the old ones (see image https://imgur.com/deRdfRX 
<https://imgur.com/deRdfRX>). Everything is working well with my 
build... I can create files, add tables, apply the new styles, save 
the files and reopen them using my build.


The problem is when I open the files with the official build of LO 
(that still uses the old styles). Even though the new styles are saved 
into the styles.xml file (inside the zipped odp file), the official LO 
build overrides these styles and default all cell colors to blue.


Is there anyone available to be my mentor in this patch?

Many thanks!

Rafael Lima



--
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Fwd: Need help implementing a patch

[Xisco Fauli]

Adding dev list

On 23/11/20 16:22, Xisco Fauli wrote:
>
> forwarding this to the dev and ux lists for a wider audience.
>
>
>
>  Forwarded Message 
> Subject:  Need help implementing a patch
> Date: Thu, 19 Nov 2020 20:30:20 -0300
> From: Rafael Lima 
> To:   mentor...@documentfoundation.org
>
>
>
> Hi!
>
> I am developing a patch to LO Impress to update the "Table Design"
> styles. The ones currently available are reminiscent of the OpenOffice
> era and do not look modern (see image https://imgur.com/WibEM0K
> <https://imgur.com/WibEM0K>).
>
> The current styles are hard-coded in the file:
> sd/source/core/drawdoc4.cxx
>
> What I did was update the colors with new RGB values and new style
> names. Previously there were 11 styles and now I implemented 14 new
> styles, deleting the old ones (see image https://imgur.com/deRdfRX
> <https://imgur.com/deRdfRX>). Everything is working well with my
> build... I can create files, add tables, apply the new styles, save
> the files and reopen them using my build.
>
> The problem is when I open the files with the official build of LO
> (that still uses the old styles). Even though the new styles are saved
> into the styles.xml file (inside the zipped odp file), the official LO
> build overrides these styles and default all cell colors to blue.
>
> Is there anyone available to be my mentor in this patch?
>
> Many thanks!
>
> Rafael Lima
>
>
-- 
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Remove leftover cast of fResolutionDPI

[Rene Engelhard]

Hi,

Am 11.11.20 um 19:30 schrieb Brett T. Warden:
> When building with --disable-pdfium, compilation fails due to a
> reference to fResolutionDPI, which is now only defined within the
> #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block.

Already fixed?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5f3f17a9c64e33fb787a79dc94d902147da77d71


https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-7-0=b9e5d5347e5dece693fe56b88570abc07a30a8ba


(And yes, that fixes it when applied to a 7.0.3)

Regards,


Rene

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Remove leftover cast of fResolutionDPI

[Ilmari Lauhakangas]

Brett T. Warden kirjoitti 11.11.2020 klo 20.30:

When building with --disable-pdfium, compilation fails due to a
reference to fResolutionDPI, which is now only defined within the
#if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block.

---
  vcl/source/filter/ipdf/pdfread.cxx | 1 -
  1 file changed, 1 deletion(-)

diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index 3066c4deba4a..93c88d64b799 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -218,7 +218,6 @@ size_t RenderPDFBitmaps(const void* pBuffer, int nSize, 
std::vector& rBi
  (void)rBitmaps;
  (void)nFirstPage;
  (void)nPages;
-(void)fResolutionDPI;
  return 0;
  #endif // HAVE_FEATURE_PDFIUM
  }



Can you submit this to our Gerrit?

https://wiki.documentfoundation.org/Development/gerrit/setup
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch

You can also create it in the web interface directly: 
https://gerrit.libreoffice.org/Documentation/user-inline-edit.html


Ilmari
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove leftover cast of fResolutionDPI

[Brett T. Warden]

When building with --disable-pdfium, compilation fails due to a
reference to fResolutionDPI, which is now only defined within the
#if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block.

---
 vcl/source/filter/ipdf/pdfread.cxx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index 3066c4deba4a..93c88d64b799 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -218,7 +218,6 @@ size_t RenderPDFBitmaps(const void* pBuffer, int nSize, 
std::vector& rBi
 (void)rBitmaps;
 (void)nFirstPage;
 (void)nPages;
-(void)fResolutionDPI;
 return 0;
 #endif // HAVE_FEATURE_PDFIUM
 }
-- 
2.29.2

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Patch review

[Ilmari Lauhakangas]

anshu khare kirjoitti 10.11.2020 klo 16.27:

Hi

Please review my patch

https://gerrit.libreoffice.org/c/core/+/105501

I have tested it. It's working fine.
Please merge it.


You did not address Jim's comment:
"Please see 
https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf#1967986

I think this is the reason for diff showing all lines have been changed."

You have to fix this problem and amend your patch: 
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch#Submitting_a_new_version


Ilmari
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch review

[anshu khare]

Hi

Please review my patch

https://gerrit.libreoffice.org/c/core/+/105501

I have tested it. It's working fine.
Please merge it.


Thanks in advance
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

New submitted patch

[Mariam Fahmy]

Hi,
I have submitted my second patch on Gerrit,
Here it is: https://gerrit.libreoffice.org/c/core/+/104461
It is about using " #pragma once" instead of guards, I am asking for
reviewers to check what I have made.
Thanks in advance.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch review

[anshu khare]

Hi,

Could you please review my patch :

https://gerrit.libreoffice.org/c/core/+/103632

Thanks and Regards
Anshu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch Review

[anshu khare]

Hi,

I have worked on Bug 134779 - Entering a table with too many columns
causing Writer to lock up.

 Please review my patch.

https://gerrit.libreoffice.org/c/core/+/101561

Regards
Anshu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch review

[anshu khare]

Hi mentors,

Please check https://gerrit.libreoffice.org/c/core/+/101242

I have worked on the Bug 87963

Thank you
Regards
Anshu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

[Mike Kaganski]

On 19.05.2020 9:34, Roland Illig wrote:
> On 19.05.2020 07:32, Mike Kaganski wrote:
>>
>> See
>> https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-directly.html
>>
> 
> Thanks for this pointer.  I had previously bailed out when I had to
> select a project, and I typed "libre" and found nothing.
> 
> It's good to know that I have to type "core" instead of "libre".

For your case, you need "libetoneyk".


-- 
Best regards,
Mike Kaganski


pEpkey.asc
Description: application/pgp-keys
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

[Roland Illig]

On 19.05.2020 07:32, Mike Kaganski wrote:

On 19.05.2020 2:28, Jan-Marek Glogowski wrote:

Am 18.05.20 um 20:57 schrieb Roland Illig:

On 18.05.2020 09:21, Miklos Vajna wrote:

Could you please push your patch to gerrit?


Nope. I won't clone a 1 GB repository and install several tools just for
fixing a single line of code. It's much more efficient if you do that,
since you already have all the infrastructure set up.


You can create the change online via
https://gerrit.libreoffice.org/admin/repos/libetonyek,commands => Create
change

For this simple patch that is probably faster then the full setup.


See
https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-directly.html


Thanks for this pointer.  I had previously bailed out when I had to
select a project, and I typed "libre" and found nothing.

It's good to know that I have to type "core" instead of "libre".

Roland
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

[Mike Kaganski]

On 19.05.2020 2:28, Jan-Marek Glogowski wrote:
> Am 18.05.20 um 20:57 schrieb Roland Illig:
>> On 18.05.2020 09:21, Miklos Vajna wrote:
>>> Could you please push your patch to gerrit?
>>
>> Nope. I won't clone a 1 GB repository and install several tools just for
>> fixing a single line of code. It's much more efficient if you do that,
>> since you already have all the infrastructure set up.
> 
> You can create the change online via
> https://gerrit.libreoffice.org/admin/repos/libetonyek,commands => Create
> change
> 
> For this simple patch that is probably faster then the full setup.

See
https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-directly.html

-- 
Best regards,
Mike Kaganski


pEpkey.asc
Description: application/pgp-keys
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

[Jan-Marek Glogowski]

Am 18.05.20 um 20:57 schrieb Roland Illig:
> On 18.05.2020 09:21, Miklos Vajna wrote:
>> Could you please push your patch to gerrit?
> 
> Nope. I won't clone a 1 GB repository and install several tools just for
> fixing a single line of code. It's much more efficient if you do that,
> since you already have all the infrastructure set up.

You can create the change online via
https://gerrit.libreoffice.org/admin/repos/libetonyek,commands => Create
change

For this simple patch that is probably faster then the full setup.

Jan-Marek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

[Roland Illig]

On 18.05.2020 09:21, Miklos Vajna wrote:

Hi Roland,

Could you please push your patch to gerrit?


Nope. I won't clone a 1 GB repository and install several tools just for
fixing a single line of code. It's much more efficient if you do that,
since you already have all the infrastructure set up.


See <https://wiki.documentfoundation.org/Development/gerrit/setup>. It's
much easier to take patches from there.


Maybe for you, but for me it's a lot harder than writing a simple mail.

I have set myself a 15 minutes time limit for setting everything up and
submitting the patch. That time has passed now.

Roland
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

[Miklos Vajna]

Hi Roland,

Could you please push your patch to gerrit?

See <https://wiki.documentfoundation.org/Development/gerrit/setup>. It's
much easier to take patches from there.

Thanks,

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] libetonyek: std::for_each

[Roland Illig]

NUM3Parser.cpp: In member function 'virtual bool
libetonyek::NUM3Parser::parseDocument()':
NUM3Parser.cpp:46:3: error: 'for_each' is not a member of 'std'
   std::for_each(sheetListRefs.begin(), sheetListRefs.end(),
std::bind(::parseSheet, this, std::placeholders::_1));

std::for_each needs .

--- src/lib/NUM3Parser.cpp.orig 2018-12-28 17:45:35.0 +
+++ src/lib/NUM3Parser.cpp
@@ -7,6 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */

+#include 
 #include 

 #include "NUM3Parser.h"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 131140] [PATCH] Add a negative number to the example of NPV.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131140

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131140] [PATCH] Add a negative number to the example of NPV.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131140

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #1 from Buovjaga  ---
Thanks for the patch! However, it should be sent to gerrit:
https://wiki.documentfoundation.org/Development/gerrit
https://wiki.documentfoundation.org/Development/GetInvolved#License_statement

An easy way to edit directly inside gerrit:
https://wiki.documentfoundation.org/Documentation/GerritEditing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[SOLVED] Re: Patch ok locally but fails on gerrit

[julien2412]

Thank you Miklos and Stephan (who responded on gerrit).
The use of rtl::isSurrogate() avoids to call ICU libs from starmath.

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch ok locally but fails on gerrit

[julien2412]

Hello,

I gave a try to tdf#129372 (FILEOPEN: PPTX: File format error found at
SfxBaseModel::storeToStorage: 0x20d(row,col) – works w/ PowerPoint 2013)
with https://gerrit.libreoffice.org/c/core/+/91941.
The pb is it builds ok locally but it fails on Jenkins, eg on Linux gcc:
[build LNK] Library/libchartcontrollerlo.so
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/CxxObject/starmath/source/parse.o:
In function `SmParser::NextToken()':
parse.cxx:(.text+0x7ac): undefined reference to `u_charType_65'
collect2: error: ld returned 1 exit status
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/solenv/gbuild/LinkTarget.mk:672:
recipe for target
'/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/LinkTarget/CppunitTest/libtest_starmath_qa_cppunit.so'
failed
make[1]: ***
[/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/LinkTarget/CppunitTest/libtest_starmath_qa_cppunit.so]
Error 1

I had got this same error locally but it was ok with by adding "icuuc" in 
starmath/Library_sm.mk

$(eval $(call gb_Library_use_externals,sm, \
boost_headers \

icuuc \
icu_headers \
))

I did a "make starmath.clean && make starmath.build" to be sure.

Any thoughts?

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Patch ok locally but fails on gerrit

[Miklos Vajna]

Hi Julian,

On Thu, Apr 09, 2020 at 12:20:30AM -0700, julien2412  
wrote:
> I gave a try to tdf#129372 (FILEOPEN: PPTX: File format error found at
> SfxBaseModel::storeToStorage: 0x20d(row,col) – works w/ PowerPoint 2013)
> with https://gerrit.libreoffice.org/c/core/+/91941.
> The pb is it builds ok locally but it fails on Jenkins, eg on Linux gcc:

I've commented in the review, I believe
gb_CppunitTest_use_library_objects doesn't inherit the used externals
from the library you refer to.

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 131140] [PATCH] Add a negative number to the example of NPV.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131140

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131140] New: [PATCH] Add a negative number to the example of NPV.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131140

Bug ID: 131140
   Summary: [PATCH] Add a negative number to the example of NPV.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: h...@topbug.net
CC: olivier.hal...@libreoffice.org

Created attachment 158399
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158399=edit
patch

Otherwise the user may doubt whether negative numbers can be used.
---
 source/text/scalc/01/04060119.xhp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/text/scalc/01/04060119.xhp
b/source/text/scalc/01/04060119.xhp
index ea6686d20a1a..9805881768f1 100644
--- a/source/text/scalc/01/04060119.xhp
+++ b/source/text/scalc/01/04060119.xhp
@@ -338,9 +338,9 @@
 
 Value1, Value2, ..., Value30 are up to 30 values, which represent
deposits or withdrawals.
 
-What is the
net present value of periodic payments of 10, 20 and 30 currency units with a
discount rate of 8.75%. At time zero the costs were paid as -40 currency
units.
+What is the
net present value of periodic payments of 10, 20, 30 and -5 currency units with
a discount rate of 8.75%. At time zero the costs were paid as -40 currency
units.
 
-=NPV(8.75%;10;20;30) = 49.43 currency units. The net
present value is the returned value minus the initial costs of 40 currency
units, therefore 9.43 currency units.
+=NPV(8.75%;10;20;30;-5) = 45.68 currency units. The
net present value is the returned value minus the initial costs of 40 currency
units, therefore 5.68 currency units.
 
 
 calculating;nominal interest
rates
-- 
2.20.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Cannot review Gerrit patch

[David Ostrovsky]

Regina Henschel wrote on Fri Jan 3 01:15:56 UTC 2020:

> I can confirm, that it does not work in the old UI.

The old UI works as expected now, see this issue: [1].

[1] https://redmine.documentfoundation.org/issues/3068

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Cannot review Gerrit patch

[Regina Henschel]

Hi Chris,

I can confirm, that it does not work in the old UI.

Chris Sherlock schrieb am 02-Jan-20 um 23:01:

On 2 Jan 2020, at 10:24 am, Thorsten Behrens  wrote:


Hey Chris,

Chris Sherlock wrote:

Quick ping. Anyone able to assist?


Not really - seems to work fine here, though not using the old UI.

Cheers,

— Thorsten


Cool. Out of interest, how on earth do I get back to the new UI?

I switched to the old UI as a test, but there is no option to go back to the 
newest UI!


For me it is at the bottom of the page, at the right side, text "Switch 
to New UI".


Kind regards
Regin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Cannot review Gerrit patch

[Chris Sherlock]

On 2 Jan 2020, at 10:24 am, Thorsten Behrens  wrote:
> 
> Hey Chris,
> 
> Chris Sherlock wrote:
>> Quick ping. Anyone able to assist?
>> 
> Not really - seems to work fine here, though not using the old UI.
> 
> Cheers,
> 
> — Thorsten

Cool. Out of interest, how on earth do I get back to the new UI?

I switched to the old UI as a test, but there is no option to go back to the 
newest UI!

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Cannot review Gerrit patch

[Thorsten Behrens]

Hey Chris,

Chris Sherlock wrote:
> Quick ping. Anyone able to assist?
> 
Not really - seems to work fine here, though not using the old UI.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Cannot review Gerrit patch

[Chris Sherlock]

On 30 Dec 2019, at 10:06 pm, Chris Sherlock  wrote:
> 
> Hi all, 
> 
> Does anyone know why I can’t review the following?
> 
> https://gerrit.libreoffice.org/#/c/core/+/83439/ 
> 
> 
> I click on the hex/cxx files and it doesn’t open in the old classic UI. 
> 
> Any ideas?
> 
> Chris

Quick ping. Anyone able to assist?

Chris___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Cannot review Gerrit patch

[Chris Sherlock]

Hi all, 

Does anyone know why I can’t review the following?

https://gerrit.libreoffice.org/#/c/core/+/83439/ 


I click on the hex/cxx files and it doesn’t open in the old classic UI. 

Any ideas?

Chris___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |dlc@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #16 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/06b01f73a2d0cc5b6a1c86942e28b1ce7b37bd91

tdf#128189: fix couple issues in configure.ac

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #15 from Michael Weghorn  ---
Thanks for your patch, David.
Julien, thanks for submitting it to Gerrit, looks good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #14 from Julien Nabet  ---
I submitted the patch here:
https://gerrit.libreoffice.org/#/c/81005/

Michael: put you in cc as you may have seen.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #13 from David L. Craig  ---
Is there a problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #12 from Julien Nabet  ---
ok I had just read your first reply

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #11 from Julien Nabet  ---
i give up

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #10 from David L. Craig  ---
Okay, I sent it to that list, signed with my PGP-compliant key.  Let me know if
you need anything else.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #9 from David L. Craig  ---
libreoff...@lists.freedesktop.org ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #8 from David L. Craig  ---
So what is the developer's list email address?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #7 from Julien Nabet  ---
it’s just about sending an email to a specific address with:
- a specific subject
- a block of text in object
 details here: see https://wiki.documentfoundation.org/Development/Developers

I’d be quite astonished it takes more than 5 min.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #6 from David L. Craig  ---
Sigh.  Very well, in my copious free time--I'll start now (maybe it's more
trivial than I'm thinking)...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #5 from Julien Nabet  ---
(In reply to David L. Craig from comment #4)
> This patch, already attached, is against 1 file, 8 lines, 10 character
> deletions/replacements.  Do I really need to jump through these hoops?

I can understand you don’t want to bother about gerrit account so i may submit
the patch myself but IMHO at least you should do the license part since i’ll
quote you in the commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #4 from David L. Craig  ---
This patch, already attached, is against 1 file, 8 lines, 10 character
deletions/replacements.  Do I really need to jump through these hoops?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

Julien Nabet  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de,
   ||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Michael: thought you might be interested in this one since it concerns kde/qt.

David: I didn't see the patch but the first prerequisite is license part. We
can't integrate your patch if you don't provide required license statement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||patch
 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEW

--- Comment #2 from Xisco Faulí  ---
Hello David,
Thanks for filling this bug.
Could you please submit the patch to gerrit so developers can review it ? <
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch >

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

--- Comment #1 from David L. Craig  ---
Created attachment 155047
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155047=edit
Patch against configure.ac

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128189] New: configure.ac has a couple issues (patch attached)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128189

Bug ID: 128189
   Summary: configure.ac has a couple issues (patch attached)
   Product: LibreOffice
   Version: 6.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dlc@gmail.com

Description:
several test commands use '==' ops where '=' is needed, qmake-qt5 locating code
adds a blank to the $PATH string which prevents finding qmake-qt5 if its in the
last directory.  These defects are all in configure.ac, and the patch will be
attached immediately after filing.

Steps to Reproduce:
1.  Run autogen.sh
2.
3.

Actual Results:
Depends on the system, but can throw test command messages to stderr, fail to
find qmake-qt5 when it's actually in the PATH, and possibly other misbehavior.

Expected Results:
No error messages, qmake-qt5 is found if it's in the PATH.


Reproducible: Sometimes


User Profile Reset: No



Additional Info:
Patch to configure.ac attached, works for 6.3.2.2 and 6.3.3.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs