[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Keywords|difficultyInteresting, | |easyHack, skillCpp, | |skillVcl, skillWindows | --- Comment #13 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/161891 Since it affects a number of issues, I decided to handle this myself. This will also fix tdf#159079. Also, this will fix tdf#158112 - by completely disabling Alt+NumPad shortcuts, allowing only Alt+Numbers from main keyboard area. Basically, what V Stuart Foote suggested (even though I disliked the idea initially). Please shout if the last point (disabling Alt+NumPad) is concerning. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||9079 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #12 from libretist --- (In reply to Mike Kaganski from comment #8) sorry for my misunderstanding -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #11 from V Stuart Foote --- (In reply to Mike Kaganski from comment #10) > I am strongly in favor of removing Alt+Number as an assignable key > combination on Windows, completely. OK, not opposed, other than normal cross-platform documentation issues. So back to resolving bug 158112 and my suggestion about returning to the +[1-9], but to avoid bug 151059 by adjusting to handling for <==> needed for os/DE VK_MENU mapping when missing keyboards. Distinguishing between l-Alt and r-Alt modifier key scancodes could be an approach on several issues. But treacherous as we'd already tried similar for bug 95761 (Jurgen's work) [1] to normalize the +[x|c]Unicode toggle [2] and that had gotten messy and had to be reverted for bug 97908. =-ref-= [1] https://gerrit.libreoffice.org/19923 [2] Justin's implementation on bug 73691 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #10 from Mike Kaganski --- (In reply to V Stuart Foote from comment #9) > But don't the VK_NUMPAD[0-9] emit different scancodes to the VK_[0-9]? Hex > values (and decimal) of 0x60 -- 0x69 (96-105), 0x30 -- 0x39 (48-57) > respectively. [1][2] Indeed. We are able to disambiguate ~all keys on keyboard. If wanted, we can also keep the numpad numbers for Alt-extended characters, and other numbers for shortcuts. This still requires fixing bug 158112 (e.g., exactly this way: making Alt+Number shortcuts only work for non-numpad numbers) first, as I explained in comment 3. > The 'EnableHexNumpad' flavor ALT codes maybe needing a bit more handling, > but by that point our +x toggle already services Unicode centric users. EnableHexNumpad may be a separate issue, if needed. I mentioned it here, but with a note that "a follow-up enhancement could be filed for that". So it may be excluded from consideration here. However, I would think that Alt+NonNumpadNumber shortcut would still be confusing. Also, listing the Alt+Number in customization provokes for using it; and people who will try will *mostly* complain that it doesn't work: they would expect numpad numbers to do what they expect from the shortcut, and see it doesn't (because it would be used for Alt+Numpad Number extended character function). I am strongly in favor of removing Alt+Number as an assignable key combination on Windows, completely. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #9 from V Stuart Foote --- But don't the VK_NUMPAD[0-9] emit different scancodes to the VK_[0-9]? Hex values (and decimal) of 0x60 -- 0x69 (96-105), 0x30 -- 0x39 (48-57) respectively. [1][2] Also the loworder (1-254) "OEM" and 4-digit "ANSI" (dec 0032-0255 matching Unicode BMP) MS Alt keys *only* work for the NUMPAD keys? So on Windows builds the SB shortcuts in fact could still use the +[1-9] and leave the Alt+NUMPAD[0-9] for os/DE use. The 'EnableHexNumpad' flavor ALT codes maybe needing a bit more handling, but by that point our +x toggle already services Unicode centric users. =-ref-= [1] https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-tvtt/261ddfb0-ce10-4380-9b7a-4b50f482b8ec [2] https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #8 from Mike Kaganski --- (In reply to libretist from comment #7) The proposal here is based on the status *prior* to bug 158112. You may recall, that you wrote bug 158786 as a "regression": before the assignment of Alt+Number to sidebar panels, you could normally use the ALT+168 combination, and get what you expected. As explained in comment 0, the *combinations starting with 0 or greater than 255* weren't processed correctly. Values below 256 were processed using Windows WM_CHAR message, which contains a resulting character value, but only truncated. So the whole text there discussed how to enable *also* greater values. Then comment 3 (not mine) could confuse people, because it suggested this proposal as a "solution" to bug 158112 (which is it not, and can't be). As you noted in bug 158112 comment 22, even Alt+single_digit is a useful special character combination. But in any case, before writing things like "Many characters ... are not handled by your method", one needs to make sure they understand what they object to. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443
--- Comment #7 from libretist ---
(In reply to Mike Kaganski from comment #6)
> (In reply to libretist from comment #5)
>
> Do you really understand what this issue is about? The non-Unicode (lower
> numbers) codes were already working using the normal WM_CHAR method ("as
> before"). Please avoid commenting without understanding the technical
> background.
That's funny. One doesn't know what one doesn't know.
Of course I thought I understood your suggestion.
Otherwise I wouldn't have commented, obviously.
But if I got something wrong, please explain why/what. Thank you.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443
--- Comment #6 from Mike Kaganski ---
(In reply to libretist from comment #5)
Do you really understand what this issue is about? The non-Unicode (lower
numbers) codes were already working using the normal WM_CHAR method ("as
before"). Please avoid commenting without understanding the technical
background.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #5 from libretist --- (In reply to Mike Kaganski from comment #0) > 2. When Alt key's WM_KEYUP arrives, analyze the stored sequence, and decide > if it's Unicode (i.e., if it starts with [0] or is greater than 255) or not. > 3. If it's non-Unicode, just drop the sequence, and process the following > WM_CHAR as before. Many characters I regularly insert via ALT+numbercode are not handled by your method: ALT+7 = • ALT+3 = ♥ ALT+11 = ♂ ALT+12 = ♀ ALT+16 = ► ALT+24 = ↑ ALT+25 = ↓ ALT+26 = → ALT+27 = ← ALT+128 = Ç AKT+135 = ç ALT+145 = æ ALT+146 = Æ ALT+152 = ø ALT+156 = £ ALT+157 = Ø ALT+168 = ¿ ALT+171 = ½ ALT+172 = ¼ ALT+174 = « ALT+175 = » ALT+184 = © ALT+241 = ± ALT+243 = ¾ ALT+246 = ÷ ALT+251 = ¹ ALT+252 = ³ ALT+253 = ² -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #4 from libretist --- How would your proposed method distinguish between ALT+7 as a LibreOffice shortcut and ALT+7 as input for the bullet point sign "•" in Windows ? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #3 from V Stuart Foote --- @Mike, isn't the trigger on Windows the Keyup release of the key. So we could isolate and continue to use the +[1-9] shortcuts for the SB decks, exactly as you suggest? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 Mike Kaganski changed: What|Removed |Added Depends on||158112 Blocks|158112 | --- Comment #2 from Mike Kaganski --- This depends on bug 158112, because until the conflict with shortcuts is resolved, implementing the proposal is not realistic. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158112 [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input (comment 5, comment 9) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 V Stuart Foote changed: What|Removed |Added Blocks||158112 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158112 [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input (comment 5, comment 9) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1059 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 --- Comment #1 from V Stuart Foote --- +1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 Buovjaga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8112 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 BogdanB changed: What|Removed |Added Blocks||143781 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 Buovjaga changed: What|Removed |Added Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word
https://bugs.documentfoundation.org/show_bug.cgi?id=156443 Michael Warner changed: What|Removed |Added OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.
