[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2022-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7866

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2021-06-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2852

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #41 from Kevin Suo  ---
(In reply to Justin L from comment #38)

Finally, I found it! It is reported in bug 138047. It is not related to the fix
for this bug, sorry for the noise.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #40 from Kevin Suo  ---
(In reply to Kevin Suo from comment #39)
[1] https://go.suokunlong.cn:88/cgit/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #39 from Kevin Suo  ---
Yes I am compiling libreoffice myself and I have a bibisect repo on [1] since
the repo from tdf server would take ages to be pulled from China. I am tryingto
use the master builds in my daily work to find regressions.

What I have said was based a guess. What I am sure is that the problem started
on master from the end of Oct. I can try to bibisect, but it may take weeks as
I have not find a pattern to reproduce. It seems like keyboard order conruption
and fiannly lost focus.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #38 from Justin L  ---
(In reply to Kevin Suo from comment #37)
> This fix for this issue seems to caused a regression in Calc.
There are many fixes here spanning more than a week of work. What makes you
think anything here is connected to the problem you are seeing?  I assume you
must be compiling LO yourself, since none of this has even reached Beta level
testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #37 from Kevin Suo  ---
This fix for this issue seems to caused a regression in Calc. After this, when
I am setting complex formulas in cells (SUMIF, SUMIFS etc) sometimes the
formulas are not set, and at that point when I type in any char in the cell
formula is delete. I tried hard but could not find repeatable steps to
reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #36 from Justin L  ---
OK, I think that this report has enough comments and commits associated with it
- lets mark this as fixed. If there are any other situations, create a separate
bug report for it.

Thanks a million for all your work on this Caolán.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #35 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ff69401d8c941e5adaa662da81c6f02d9fe71955

tdf#137620 support surrounding text for calc comments

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #34 from Justin L  ---
The last instance I found was calc comments. They were working until 6.2 as
mentioned in comment 0, when again they stopped deleting the composing chars.
I tried to fix this one myself, but couldn't even find the window/control that
handled the comment...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #33 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c99e66cb5c75efb933694bfbb8edd7117c3d655f

tdf#137620 support surrounding text for impress outline view

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #32 from Caolán McNamara  ---
sd/source/ui/view/sdwindow.cxx has (pre-existing)
GetSurroundingText/GetSurroundingTextSelection and they have special cased
"ViewShell::ST_OUTLINE" to do nothing. It might be as simple as removing those
cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #31 from Justin L  ---
Comment 30's fix seems to work good for calc.

I have just two more places that I have found.
The first is Impress Outline view (view menu - Outline) doesn't delete
composing characters (the same problem response as comment 27). Bibisect points
to comment 22's Resolves: tdf#137620 add DeleteSurroundingText at vcl::Window
level

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #30 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c946abb704c9f72c1fdc696ac72c6a9381d95f16

tdf#137620 add explicit SurroundingText support to ScGridWindow

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #29 from Caolán McNamara  ---
yeah, probably, let me have an attempt at that I think I see where it should go

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #28 from Justin L  ---
(In reply to Justin L from comment #27)
>  Missing focus?
Probably not so simple. Needs something like comment 24? Looks like it came
from
commit  e087e25f05e689091cbf1c4f91b6e93878ac17e
  weld InputBar

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #27 from Justin L  ---
Calc's cells are not deleting the composing characters. (It works in the
editing area, but not when the cursor is in the cell itself.) It was working
earlier. Missing focus?

Open Calc. Start typing:
;;~a
vcl/unx/gtk3/gtk3gtkframe.cxx:4448: SignalIMDeleteSurrounding will
CalcDeleteSurrounding selection from text[] start[0] offset[-1] chars[1]
vcl/unx/gtk3/gtk3gtkframe.cxx:4413: IM delete-surrounding, unable to move to
offset: -1
vcl/unx/gtk3/gtk3gtkframe.cxx:4448: SignalIMDeleteSurrounding will
CalcDeleteSurrounding selection from text[] start[0] offset[-1] chars[1]
vcl/unx/gtk3/gtk3gtkframe.cxx:4413: IM delete-surrounding, unable to move to
offset: -1
vcl/unx/gtk3/gtk3gtkframe.cxx:4448: SignalIMDeleteSurrounding will
CalcDeleteSurrounding selection from text[] start[0] offset[-1] chars[1]
vcl/unx/gtk3/gtk3gtkframe.cxx:4413: IM delete-surrounding, unable to move to
offset: -1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #26 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a25acac2a6c7770bb07ced4c29b3b9009ad7ff14

Related: tdf#137620 focus-in IMHandler on grab_focus

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #25 from Caolán McNamara  ---
comment #23 might be a focus issue and
https://gerrit.libreoffice.org/c/core/+/104932 might help there

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #24 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8dcbbea3802670004c3e78a1ff1ec56b23df674c

tdf#137620 add explicit SurroundingText support to starmath Edit Window

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||096

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #23 from Justin L  ---
(In reply to Commit Notification from comment #22)
> Resolves: tdf#137620 add DeleteSurroundingText at vcl::Window level

Neat - this looks like it fixed the problem in Writer tables as well.

However, I just noticed one more problem. It ONLY seems to work on the first
document. If I close the writer document (down to the start center) and then
open up my draw test, then nothing IME happens at all.  No composed character
and no deleting characters.  (If I exit the program completely, then it works
again for the first document.)

It works fine if I open three documents from File - open. I can even close and
restart them as long as one if left running. It is only when dropping to the
start center that IME stuff stops.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #22 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b9405fbc4e19901c78d136895c5ab0437d8450ac

Resolves: tdf#137620 add DeleteSurroundingText at vcl::Window level

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #21 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ce5e41ab99af350ca8f4b9fef3017d53f3526f83

Related: tdf#137620 use existing SalEvent::SurroundingTextRequest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #20 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/41df2d06cc13a1c60a4ea9671535afb8bd55b344

Related: tdf#137620 factor out working IMDeleteSurrounding hunk

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Caolán McNamara  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #19 from Caolán McNamara  ---
well, that's somewhat encouraging and possibly gives us a chunk of something we
can reuse to escape out of this problem without having to use the a11y apis.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #18 from Justin L  ---
(In reply to Caolán McNamara from comment #17)
> should we just "select" and "delete" the range or should we copy the
> original cursor pos and just adjust it by the num of chars removed?

Well, in this case the select and delete method works for me.

At this point everything seems to be working well.  I was able to get an assert
doing undo once, but it is not necessarily related since undo is known to be
flaky and I could not reproduce it. In general undo and redo seem to work.
(Arguably in our use case it would be nice to just add/remove the composed
character and skip all of the intermediary keypresses, but that is way beyond
the scope of this bug report and probably not generically desirable in any
case.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #17 from Caolán McNamara  ---
should we just "select" and "delete" the range from delete-surrounding-text,
leaving the cursor at that deletion point ? like
https://gerrit.libreoffice.org/c/core/+/104735 does, or should we copy the
original cursor pos and just adjust it by the num of chars removed and set a
new cursor ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #16 from Justin L  ---
(In reply to Caolán McNamara from comment #15)
> I think comment #14 is a focus thing and
> https://gerrit.libreoffice.org/c/core/+/104721 seems to be the problem there.

That works in terms of always creating the composing text, and deleting
characters. So now I can easily enter characters in left, middle, and right.

However, in the middle of a word it deletes the wrong characters.
bc|def -> bc;;~adef == bc;;fä

That sounds like
https://cgit.freedesktop.org/libreoffice/core/commit/?id=6c76a0a84785b48c29687e6d31b8229a230563d8

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #15 from Caolán McNamara  ---
I think comment #14 is a focus thing and
https://gerrit.libreoffice.org/c/core/+/104721 seems to be the problem there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #14 from Justin L  ---
(In reply to Caolán McNamara from comment #13)
> alright, how about with https://gerrit.libreoffice.org/c/core/+/104659 then.

Nifty. That worked well for the left side. It took a bit of effort to get it to
work in the middle or right side. Either using the cursor to go back and forth
a few times, or pressing enter - all seemed to help, but still a bit hit or
miss. When it doesn't work, it just does nothing at all - no deletes and no
forming a composed character.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #13 from Caolán McNamara  ---
alright, how about with https://gerrit.libreoffice.org/c/core/+/104659 then.
That seems to work better wrt the editengine-in-GtkDrawingArea case

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #12 from Justin L  ---
For anyone needing a workaround for this bug, start LibreOffice with

 XMODIFIERS=@im=ibus GTK_IM_MODULE=xim  soffice

This can be automated in Ubuntu / Wasta with
sudo cat > /etc/profile.d/libreoffice   << EOF
XMODIFIERS=@im=ibus GTK_IM_MODULE=xim 
EOF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #11 from Justin L  ---
Created attachment 166609
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166609=edit
kmfl_prebacktrace.txt: gdb results before applying patch

(In reply to Caolán McNamara from comment #9)
> I'm clearly missing a SolarMutexGuard
> somewhere, should be fairly easy to spot from a backtrace.

Your patch does get rid of the assert. The composed character is created, but
only the last character is replaced.  So ";;~a" turned into ;;~ä̃".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #10 from Justin L  ---
(In reply to Caolán McNamara from comment #9)
> A quick "dnf search kmfl" doesn't show me something I could use to quickly
> reproduce locally under fedora.

KMFL is now an official release of http://keyman.com/linux.  
Q. What Linux distros will Keyman work with?

A. Keyman is built for amd64 architecture and runs on Debian, Ubuntu, Wasta
Linux. It can be compiled to run from source in most distributions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #9 from Caolán McNamara  ---
(In reply to Justin L from comment #8)
> calc's format->page->header->edit  does nothing on a build from Sept 12.

Yeah, its quite new.

> On another machine with a build from Oct 16, I get an assert as soon as I
> type the first semi-colon (only when the IME keyboard is chosen).
> 
> vcl/source/app/dbggui.cxx:35: void ImplDbgTestSolarMutex(): Assertion
> `ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() &&
> "SolarMutex not owned!"' failed.

That build surely has it :-) I'm clearly missing a SolarMutexGuard somewhere,
should be fairly easy to spot from a backtrace.
(https://gerrit.libreoffice.org/c/core/+/104644 is possibly sufficient) A quick
"dnf search kmfl" doesn't show me something I could use to quickly reproduce
locally under fedora.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #8 from Justin L  ---
calc's format->page->header->edit  does nothing on a build from Sept 12. (I
just get the characters I typed, but no deletions, and no composed end result. 
;;~a == ;;~a)

On another machine with a build from Oct 16, I get an assert as soon as I type
the first semi-colon (only when the IME keyboard is chosen).

vcl/source/app/dbggui.cxx:35: void ImplDbgTestSolarMutex(): Assertion
`ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && "SolarMutex
not owned!"' failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #7 from Caolán McNamara  ---
Using the a11y layer for "delete-surrounding" and "retrieve-surrounding" was
one of those bright ideas I probably should never have had, it's always been a
bit wrong in some way or another.

I wonder if the alternative thing I added for the "editengine hosted in a
GtkDrawingArea" case works better or just fails horribly in some other way. To
test that, in calc, format->page->header->edit and try out your IME in those
editengines. Maybe if that works, or can be improved to work, then the stuff
used to implement that could be adapted to handle the normal case of an
"editengine hosted in a vcl::Window" and sidestep the use of the a11y stuff
entirely

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=85
   ||912

--- Comment #6 from Justin L  ---
connecting to bug 85912 which has good info about kmfl. This was one of the
bugs that launched me into LibreOffice programming.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #5 from Justin L  ---
(In reply to Caolán McNamara from comment #4)
> does KMFL directly use accessibility calls or does it use
> "delete-surrounding" and "retrieve-surrounding" GTK-IM signals

delete-surrounding.

Here is a quote I found in my email:
"KMFL (and other inputs methods) need to be able to delete text that has been
previously entered. There are couple of ways to do this, one being to use a
system call like "delete surrounding text". Another method is to simulate the
backspace key. The former method is the preferred method because it gives
better control over what is deleted.  However applications have to be written
to support "surrounding text". Apps are supposed to report to ibus whether they
support "surrounding text" calls and if they don't,  then kmfl falls back to
simulating the backspace key.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Caolán McNamara  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #4 from Caolán McNamara  ---
Just to be clear, does KMFL directly use accessibility calls or does it use
"delete-surrounding" and "retrieve-surrounding" GTK-IM signals and LibreOffice
uses its accessibility stuff to try and fulfill those (the lcl_GetxText hack) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #3 from Noel Grandin  ---
Sorry, no idea how to fix this - might try asking caolan. Reverting that commit
will likely cause other problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Justin L  changed:

   What|Removed |Added

   Keywords||bisected
 CC||noelgran...@gmail.com,
   ||paul.troj...@gmail.com

--- Comment #2 from Justin L  ---
Likely no one will want a simple revert done, but that is fairly easily
possible and is staged at https://gerrit.libreoffice.org/c/core/+/104614.

The author has not been actively developing for the last two years - this was
one of his last commits. 
https://cgit.freedesktop.org/libreoffice/core/log/?qt=author=Paul+Trojahn.

I tried (without understanding) to just undo parts of this, but was
unsuccessful.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #1 from Justin L  ---
Created attachment 166545
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166545=edit
kmfl_bad.mp4: screen capture showing the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||8967

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-10-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137620

Justin L  changed:

   What|Removed |Added

   Keywords||bibisected, regression
 CC||jl...@mail.com,
   ||riksha...@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||641

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs