[PATCH] m4: update serial numbers in modified files

2024-01-31 Thread Mike Frysinger
These should have been included in the commits that updated these
files, but too late now to rewrite git history.

* m4/libtool.m4: Update serial number.
* m4/ltdl.m4, m4/ltoptions.m4: Likewise.
---
 m4/libtool.m4   | 2 +-
 m4/ltdl.m4  | 2 +-
 m4/ltoptions.m4 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 20527f830aa1..d9725fdfd1cd 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -32,7 +32,7 @@ m4_define([_LT_COPYING], [dnl
 # along with this program.  If not, see .
 ])
 
-# serial 59 LT_INIT
+# serial 60 LT_INIT
 
 
 # LT_PREREQ(VERSION)
diff --git a/m4/ltdl.m4 b/m4/ltdl.m4
index 0c43799cdecc..548e3643196e 100644
--- a/m4/ltdl.m4
+++ b/m4/ltdl.m4
@@ -8,7 +8,7 @@
 # unlimited permission to copy and/or distribute it, with or without
 # modifications, as long as this notice is preserved.
 
-# serial 21 LTDL_INIT
+# serial 22 LTDL_INIT
 
 # LT_CONFIG_LTDL_DIR(DIRECTORY, [LTDL-MODE])
 # --
diff --git a/m4/ltoptions.m4 b/m4/ltoptions.m4
index e24ae1538b6b..6dfe99f1f200 100644
--- a/m4/ltoptions.m4
+++ b/m4/ltoptions.m4
@@ -8,7 +8,7 @@
 # unlimited permission to copy and/or distribute it, with or without
 # modifications, as long as this notice is preserved.
 
-# serial 8 ltoptions.m4
+# serial 9 ltoptions.m4
 
 # This is to help aclocal find these macros, as it can't see m4_define.
 AC_DEFUN([LTOPTIONS_VERSION], [m4_if([1])])
-- 
2.43.0




branch master updated: m4: update serial numbers in modified files

2024-01-31 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 57dae03b m4: update serial numbers in modified files
57dae03b is described below

commit 57dae03b04a17ef61ba948062be22e5f68620eb9
Author: Mike Frysinger 
AuthorDate: Thu Feb 1 00:02:23 2024 -0500

m4: update serial numbers in modified files

These should have been included in the commits that updated these
files, but too late now to rewrite git history.

* m4/libtool.m4: Update serial number.
* m4/ltdl.m4, m4/ltoptions.m4: Likewise.
---
 m4/libtool.m4   | 2 +-
 m4/ltdl.m4  | 2 +-
 m4/ltoptions.m4 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 20527f83..d9725fdf 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -32,7 +32,7 @@ m4_define([_LT_COPYING], [dnl
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 ])
 
-# serial 59 LT_INIT
+# serial 60 LT_INIT
 
 
 # LT_PREREQ(VERSION)
diff --git a/m4/ltdl.m4 b/m4/ltdl.m4
index 0c43799c..548e3643 100644
--- a/m4/ltdl.m4
+++ b/m4/ltdl.m4
@@ -8,7 +8,7 @@
 # unlimited permission to copy and/or distribute it, with or without
 # modifications, as long as this notice is preserved.
 
-# serial 21 LTDL_INIT
+# serial 22 LTDL_INIT
 
 # LT_CONFIG_LTDL_DIR(DIRECTORY, [LTDL-MODE])
 # --
diff --git a/m4/ltoptions.m4 b/m4/ltoptions.m4
index e24ae153..6dfe99f1 100644
--- a/m4/ltoptions.m4
+++ b/m4/ltoptions.m4
@@ -8,7 +8,7 @@
 # unlimited permission to copy and/or distribute it, with or without
 # modifications, as long as this notice is preserved.
 
-# serial 8 ltoptions.m4
+# serial 9 ltoptions.m4
 
 # This is to help aclocal find these macros, as it can't see m4_define.
 AC_DEFUN([LTOPTIONS_VERSION], [m4_if([1])])



[sr #110674] Option --with-pic is a misnomer

2024-01-28 Thread Mike Frysinger
Follow-up Comment #1, sr#110674 (group libtool):

i don't know that we would ever really drop the option.  since libtool is
included in source distros, old versions that have --with-pic & not
--enable-pic will stick around basically forever.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #102300] libtool confused by depcomp

2024-01-28 Thread Mike Frysinger
Update of sr#102300 (group libtool):

  Status:None => Need Info  

___

Follow-up Comment #1:

sorry, but i'm not quite following the issue here.  can you include a full
command line & error message ?  and maybe include a patch showing what you're
thinking ?


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #110925] libtool 2.4.7.4-1ec8f-dirty infinite loop on unknown (out of order) argument

2024-01-28 Thread Mike Frysinger
Follow-up Comment #1, sr#110925 (group libtool):

please show an example command that fails, and ideally include a patch showing
what change you want to make

i tried to quickly reproduce this locally based on your description, but it
works fine for me


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #100875] libtool and amanda-2.4.3b3

2024-01-28 Thread Mike Frysinger
Update of sr#100875 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

seems like this might have been fixed with:
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=6e54c291b251a4d4de7373210dce9aac3fe6c2d5

which i think was first included in the libtool-1.5 release which was in Apr
2003 which is after this bug report.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #100410] clean mode wants to remove unknown files

2024-01-28 Thread Mike Frysinger
Update of sr#100410 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

i think current libtool 2.x releases handle this better by nuking all of .libs
and discarding error output


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #109183] Problem on compiling on git-bash/mingw using libtool coming with mpfr3.1.5

2024-01-28 Thread Mike Frysinger
Update of sr#109183 (group libtool):

  Status:None => Need Info  

___

Follow-up Comment #1:

if this is still an issue with current mpfr releases, please attach the
generated "libtool" script too from your build


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #111011] restore shared library support on Android

2024-01-28 Thread Mike Frysinger
Follow-up Comment #1, sr#111011 (group libtool):

this report lacks detailed (or really, any) information.  the git commit lacks
detailed information, and the author e-mail is set to nonsense.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




Re: [PATCH] libtool.m4: Fix -export-symbols for GNU ld on non-Linux

2024-01-22 Thread Mike Frysinger
On 22 Jan 2024 15:34, Tijl Coosemans wrote:
> Apply the fix for Linux from fb5e6cda96bd9dcae9e4f62ec8b6b3e572a32743
> to the non-Linux cases.
> 
> -export-symbols was implemented using --retain-symbols-file. For
> non-exported symbols this flag tries to remove symbol information
> altogether which it can only do if a symbol isn't referenced
> anywhere. So, often this flag doesn't do anything. With a version
> script non-exported symbols can be marked local instead of removed.

this looks fine, but i kind of think we should wait to kick out the current
release and then merge it
-mike


signature.asc
Description: PGP signature


Re: [PATCH] tests/demo.at: Also test for amd64 where we test for x86_64

2024-01-22 Thread Mike Frysinger
On 22 Jan 2024 14:12, Tijl Coosemans wrote:
> It is used on FreeBSD.
> 
> * tests/demo.at: Also test for amd64 where we test for x86_64.

thx, merged now
-mike


signature.asc
Description: PGP signature


branch master updated: tests: Also check amd64 where we test for x86_64

2024-01-22 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new e11fcf3b tests: Also check amd64 where we test for x86_64
e11fcf3b is described below

commit e11fcf3b38b92cc8da2b6d03c2adb623a54566df
Author: Tijl Coosemans 
AuthorDate: Mon Jan 22 14:12:26 2024 +0100

tests: Also check amd64 where we test for x86_64

It is used on FreeBSD.

* tests/demo.at: Also test for amd64 where we test for x86_64.
---
 tests/demo.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/demo.at b/tests/demo.at
index 970d3966..feb71dcd 100644
--- a/tests/demo.at
+++ b/tests/demo.at
@@ -511,7 +511,7 @@ AT_CLEANUP
 AT_SETUP([force non-PIC objects])
 
 AT_CHECK([case $host in
-hppa*|x86_64*|s390*)
+hppa*|amd64*|x86_64*|s390*)
   # These hosts cannot use non-PIC shared libs
   exit 77 ;;
 *-solaris*|*-sunos*)



branch master updated: libtoolize: always copy config-h.in like aclocal.m4

2024-01-22 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 8d188608 libtoolize: always copy config-h.in like aclocal.m4
8d188608 is described below

commit 8d188608ca471db3fe5cfe3fc1ee4481a178d2ca
Author: Mike Frysinger 
AuthorDate: Thu Jan 18 00:19:19 2024 -0500

libtoolize: always copy config-h.in like aclocal.m4

When running `libtoolize --ltdl`, a symlink to the source config-h.in
is used rather than a copy of the file.  This causes the build system
to look at its old timestamp relative to the other generated files
that are copied in, and then try to regenerate things, and update the
config-h.in timestamp by touching the symlink (which will dereference
things).  This breaks `make distcheck` because when a few tests run
that invoke `libtoolize --ltdl --install` w/out --copy, and then try
to build the project, automake's rules trigger autoheader regen, and
then update the timestamp, which updates the underlying file, and then
causes libtool's own files to get out of sync.  So the next time make
is run in the tree, it tries to regenerate the source files, and fails
as the source tree is read-only.

Change libtoolize to always copying the header over during install.
It's not clear to me whether this is 100% the right answer, but it
shouldn't make things worse beyond missing a case to use a symlink.
We probably can't avoid this as long as aclocal.m4 itself is copied
in instead of symlinked.  This changed between v2.4.2 and v2.4.3 in
commit 4e671d6ba69c889b1f9aee12de6c504d26dc6514 ("libtoolize:
simplify file-copying and -linking call-graph.").

Example failure log:

$ make distcheck
...
make[3]: Entering directory '.../libtool-2.4.7.62-3e11/_build/sub'
  GEN  ../../libltdl/Makefile.in
  GEN  ../../libltdl/configure
autom4te-2.72: error: cannot create autom4te.cache in 
.../libtool-2.4.7.62-3e11/libltdl: Permission denied
make[3]: *** [Makefile:2411: ../../libltdl/configure] Error 1
make[3]: *** Waiting for unfinished jobs
autom4te-2.72: error: cannot create autom4te.cache in 
.../libtool-2.4.7.62-3e11/libltdl: Permission denied
automake-1.16: error: autoconf failed with exit status: 1
make[3]: *** [Makefile:2387: ../../libltdl/Makefile.in] Error 1

We can see this in old-m4-iface.at:AC_WITH_LTDL which doesn't use
--copy with libtoolize:

$ stat libltdl/config-h.in | grep Modify
Modify: 2024-01-18 01:18:52.998059970 -0500
$ make check-local TESTSUITEFLAGS=100
...
100: AC_WITH_LTDLok
...
$ stat libltdl/config-h.in | grep Modify
Modify: 2024-01-18 01:19:19.254727020 -0500

And in the test log we can see:

100. old-m4-iface.at:113: testing AC_WITH_LTDL ...
...
libtoolize: linking file 'libltdl/config-h.in'
...
./old-m4-iface.at:161: : ${CONFIG_SHELL=/bin/sh}; export CONFIG_SHELL;
$CONFIG_SHELL ./configure $configure_options   --prefix="$prefix" 
--exec-prefix="$prefix" --bindir="$prefix/bin" --libdir="$prefix/lib" 
--with-included-ltdl
...
./old-m4-iface.at:161: $as_unset LIBTOOL; $as_unset LIBTOOLIZE; $MAKE 
$target
stderr:
stdout:
cd libltdl && make
make[1]: Entering directory 
'/usr/local/src/gnu/libtool/tests/testsuite.dir/100/libltdl'
CDPATH="${ZSH_VERSION+.}:" && cd . && aclocal -I m4
 cd . && automake --foreign
CDPATH="${ZSH_VERSION+.}:" && cd . && autoconf
/bin/sh ./config.status --recheck
...
(CDPATH="${ZSH_VERSION+.}:" && cd . && autoheader)
rm -f stamp-h1
touch config-h.in
...

* libtoolize.in: Copy config-h.in.
* tests/libtoolize.at: Change "linking" to "copying".
---
 libtoolize.in   | 10 +-
 tests/libtoolize.at |  4 ++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/libtoolize.in b/libtoolize.in
index 63106941..336fc81b 100644
--- a/libtoolize.in
+++ b/libtoolize.in
@@ -947,7 +947,15 @@ func_install_pkgltdl_files ()
  ;;
 
 config-h.in)
-  test subproject = "$ltdl_mode" || continue
+  test subproject = "$ltdl_mode" && {
+# Always copy config-h.in, otherwise automake's autoheader rules
+# will change the destination's timestamp if it is symlinked.
+( opt_copy=:
+  func_copy "$file" "$pkgltdldir" "$ltdl_dir" \
+pkgltdl_header "$my_copy_filter"
+)
+  }
+  continue
   ;;
 
 configure)
diff --git a/tests/libt

branch master updated: bootstrap: don't reset config-h.in timestamp newer than configure

2024-01-20 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new e602d877 bootstrap: don't reset config-h.in timestamp newer than 
configure
e602d877 is described below

commit e602d877f6dda901fedf828455f1b73b78eb1437
Author: Mike Frysinger 
AuthorDate: Thu Jan 18 00:19:05 2024 -0500

bootstrap: don't reset config-h.in timestamp newer than configure

Various autotools rules will compare the timestamps of config-h.in
and configure, and if config-h.in is newer than configure, attempt
to regenerate it.  This breaks `make distcheck` which we need to
produce new releases.  So update config-h.in timestamp, but only
up to the configure file.

The breakage is caught because distcheck makes source dirs read-only
before running.

$ make distcheck
...
make[3]: Entering directory '.../libtool-2.4.7.62-7132f/_build/sub'
  GEN  ../../libltdl/configure
autom4te-2.72: error: cannot create autom4te.cache in 
.../libtool-2.4.7.62-7132f/libltdl: Permission denied
make[3]: *** [Makefile:2411: ../../libltdl/configure] Error 1

* bootstrap.conf (libtool_fudge_timestamps): Set config-h.in timestamp
to configure.
---
 bootstrap.conf | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 808321a0..85ac3ee1 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -269,12 +269,17 @@ func_add_hook func_fini 
libtool_readme_release_package_substitutions
 # are updated.  Unfortunately config-h.in depends on aclocal.m4, which
 # *is* updated, so running 'libtoolize --ltdl=. && configure && make'
 # causes autoheader to be called... undesirable for users that do not
-# have it!  Fudge the timestamp to prevent that:
+# have it!  Fudge the timestamp to prevent that.  But only fudge it as
+# much as configure since configure depends on config-h.in and we don't
+# want to require autoconf either.
 libtool_fudge_timestamps ()
 {
 $debug_cmd
 
-sleep 2 && touch libltdl/config-h.in
+(
+cd libltdl
+touch -r configure config-h.in
+)
 }
 func_add_hook func_fini libtool_fudge_timestamps
 



[PATCH] doc: minor fixes

2024-01-20 Thread Mike Frysinger
* doc/libtool.texi: Fix some style & minor grammar.
---
 doc/libtool.texi | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/libtool.texi b/doc/libtool.texi
index ba2e99809de2..44f7eae26468 100644
--- a/doc/libtool.texi
+++ b/doc/libtool.texi
@@ -885,7 +885,7 @@ on to the program executable.  Therefore, the program 
executable may not
 employ command line options that begin with @code{--lt-}. (In fact, the
 wrapper executable will detect any command line options that begin with
 @code{--lt-} and abort with an error message if the option is not
-recognized). If this presents a problem, please contact the Libtool
+recognized.) If this presents a problem, please contact the Libtool
 team at @value{BUGADDR}.
 
 These command line options include:
@@ -1792,8 +1792,8 @@ These individual steps are often automated with 
@command{autoreconf}.
 
 Here is a diagram showing how such a typical Libtool configuration works
 when preparing a package for distribution, assuming that @file{m4} has
-been chosen as location for additional Autoconf macros, and
-@file{build-aux} as location for auxiliary build tools (@pxref{Input,,
+been chosen as the location for additional Autoconf macros, and
+@file{build-aux} as the location for auxiliary build tools (@pxref{Input,,
 The Autoconf Manual, autoconf, The Autoconf Manual}):
 
 @example
@@ -2046,8 +2046,8 @@ generated header file), you may find it necessary to 
manually record
 these dependencies.
 Because libtool archives generate object file names manually recording these
 dependencies is not as straightforward as the examples in Automake's manual
-describe in their examples.
-This effects header files in particular, because simply listing them as
+describe.
+This affects header files in particular, because simply listing them as
 @samp{nodist_libfoo_la_SOURCES} will not cause Automake to establish a
 dependent relationship for the object files of @file{libfoo.la}.
 A useful trick (although somewhat imprecise) is to manually record built
@@ -6160,7 +6160,7 @@ cross-compiling, and affects only the ability to launch 
host platform
 executables on the build platform using an emulation or API-enhancement
 environment such as Wine.  Failure to convert paths
 (@pxref{File Name Conversion Failure}) will cause a warning to be issued, but
-rarely causes the build to fail---and should have no affect on the compiled
+rarely causes the build to fail---and should have no effect on the compiled
 products, once installed properly on the host platform.  For more information,
 @pxref{Cross compiling}.
 
-- 
2.43.0




Re: [PATCH 1/2] libtool: replace : with $PATH_SEPARATOR

2024-01-18 Thread Mike Frysinger
On 17 Jan 2024 22:44, KO Myung-Hun wrote:
> Mike Frysinger wrote:
> > On 16 Jan 2024 23:44, KO Myung-Hun wrote:
> >> Some OSes such as OS/2, uses ';' as a path separator. So using 
> >> $PATH_SEPARATOR instead of hard-coded ':' is more proper.
> > 
> > so we're on the same page, we're talking about the separator that
> > is used in the $PATH environment variable.  it doesn't show up in
> > other places -- it is not used to separate e.g. rpath entries right
> > ?  what about LD_LIBRARY_PATH and similar vars ?  i guess we assume
> > the separator used by PATH is also used with that var ?
> 
> This is applied to all the variables containing a list of paths and/or
> dirs separated by ':' including PATH and LD_LIBRARY_PATH.
> 
> If rpath entries is separated by ':', it's also true.

i'm not familiar with the diff (non-glibc) runtime loaders, so will take your
word for this.  afaict, libtool has behaved this way for a long time, so i'm
a bit inclined to wait for 2.4.8 release and then merge it.
-mike


signature.asc
Description: PGP signature


Re: Introducing a new maintainer of libtool

2024-01-18 Thread Mike Frysinger
On 18 Jan 2024 11:25, Ozkan Sezer wrote:
> On 1/18/24, Mike Frysinger  wrote:
> > On 17 Jan 2024 20:07, Ozkan Sezer wrote:
> [...]
> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52253
> >
> > doesn't look like a regression.  it can wait.
> 
> It's a regression from 2.2.6, later versions have the issue,
> so how is it not a regression?

2.2.7 was released in 2010.  that's 14 years ago.  at some point, it just
turns into another bug.  it's not a regression relative to 2.4.6 or 2.4.7.
-mike


signature.asc
Description: PGP signature


Re: Introducing a new maintainer of libtool

2024-01-17 Thread Mike Frysinger
On 17 Jan 2024 18:43, Mike Frysinger wrote:
> On 17 Jan 2024 16:09, Ileana Dumitrescu wrote:
> > I'll need some time figuring out the release process, but otherwise I 
> > should be able to get an alpha release out soon. Mike has been helpful 
> > and has merged in many patches over the past few days.
> 
> there doesn't seem to be libtool-specific release details in the tree.
> i can update HACKING with some notes for you.  plus the dist target
> seems to be broken :/.

i was looking in HACKING & README & the manual & in a clean tree.  if you
bootstrap, you get the README-release file which explains things.

i posted 2 patches which fix `make distcheck` for me.  i'll wait a little
to see if there's any feedback on them before merging, but those should
otherwise unblock ability to make the new release.
-mike


signature.asc
Description: PGP signature


[PATCH 1/2] bootstrap: don't reset config-h.in timestamp newer than configure

2024-01-17 Thread Mike Frysinger
Various autotools rules will compare the timestamps of config-h.in
and configure, and if config-h.in is newer than configure, attempt
to regenerate it.  This breaks `make distcheck` which we need to
produce new releases.  So update config-h.in timestamp, but only
up to the configure file.

The breakage is caught because distcheck makes source dirs read-only
before running.

$ make distcheck
...
make[3]: Entering directory '.../libtool-2.4.7.62-7132f/_build/sub'
  GEN  ../../libltdl/configure
autom4te-2.72: error: cannot create autom4te.cache in 
.../libtool-2.4.7.62-7132f/libltdl: Permission denied
make[3]: *** [Makefile:2411: ../../libltdl/configure] Error 1

* bootstrap.conf (libtool_fudge_timestamps): Set config-h.in timestamp
to configure.
---
 bootstrap.conf | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 808321a0897b..85ac3ee19748 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -269,12 +269,17 @@ func_add_hook func_fini 
libtool_readme_release_package_substitutions
 # are updated.  Unfortunately config-h.in depends on aclocal.m4, which
 # *is* updated, so running 'libtoolize --ltdl=. && configure && make'
 # causes autoheader to be called... undesirable for users that do not
-# have it!  Fudge the timestamp to prevent that:
+# have it!  Fudge the timestamp to prevent that.  But only fudge it as
+# much as configure since configure depends on config-h.in and we don't
+# want to require autoconf either.
 libtool_fudge_timestamps ()
 {
 $debug_cmd
 
-sleep 2 && touch libltdl/config-h.in
+(
+cd libltdl
+touch -r configure config-h.in
+)
 }
 func_add_hook func_fini libtool_fudge_timestamps
 
-- 
2.43.0




[PATCH 2/2] libtoolize: always copy config-h.in like aclocal.m4

2024-01-17 Thread Mike Frysinger
When running `libtoolize --ltdl`, a symlink to the source config-h.in
is used rather than a copy of the file.  This causes the build system
to look at its old timestamp relative to the other generated files
that are copied in, and then try to regenerate things, and update the
config-h.in timestamp by touching the symlink (which will dereference
things).  This breaks `make distcheck` because when a few tests run
that invoke `libtoolize --ltdl --install` w/out --copy, and then try
to build the project, automake's rules trigger autoheader regen, and
then update the timestamp, which updates the underlying file, and then
causes libtool's own files to get out of sync.  So the next time make
is run in the tree, it tries to regenerate the source files, and fails
as the source tree is read-only.

Change libtoolize to always copying the header over during install.
It's not clear to me whether this is 100% the right answer, but it
shouldn't make things worse beyond missing a case to use a symlink.
We probably can't avoid this as long as aclocal.m4 itself is copied
in instead of symlinked.  This changed between v2.4.2 and v2.4.3 in
commit 4e671d6ba69c889b1f9aee12de6c504d26dc6514 ("libtoolize:
simplify file-copying and -linking call-graph.").

Example failure log:

$ make distcheck
...
make[3]: Entering directory '.../libtool-2.4.7.62-3e11/_build/sub'
  GEN  ../../libltdl/Makefile.in
  GEN  ../../libltdl/configure
autom4te-2.72: error: cannot create autom4te.cache in 
.../libtool-2.4.7.62-3e11/libltdl: Permission denied
make[3]: *** [Makefile:2411: ../../libltdl/configure] Error 1
make[3]: *** Waiting for unfinished jobs
autom4te-2.72: error: cannot create autom4te.cache in 
.../libtool-2.4.7.62-3e11/libltdl: Permission denied
automake-1.16: error: autoconf failed with exit status: 1
make[3]: *** [Makefile:2387: ../../libltdl/Makefile.in] Error 1

We can see this in old-m4-iface.at:AC_WITH_LTDL which doesn't use
--copy with libtoolize:

$ stat libltdl/config-h.in | grep Modify
Modify: 2024-01-18 01:18:52.998059970 -0500
$ make check-local TESTSUITEFLAGS=100
...
100: AC_WITH_LTDLok
...
$ stat libltdl/config-h.in | grep Modify
Modify: 2024-01-18 01:19:19.254727020 -0500

And in the test log we can see:

100. old-m4-iface.at:113: testing AC_WITH_LTDL ...
...
libtoolize: linking file 'libltdl/config-h.in'
...
./old-m4-iface.at:161: : ${CONFIG_SHELL=/bin/sh}; export CONFIG_SHELL;
$CONFIG_SHELL ./configure $configure_options   --prefix="$prefix" 
--exec-prefix="$prefix" --bindir="$prefix/bin" --libdir="$prefix/lib" 
--with-included-ltdl
...
./old-m4-iface.at:161: $as_unset LIBTOOL; $as_unset LIBTOOLIZE; $MAKE $target
stderr:
stdout:
cd libltdl && make
make[1]: Entering directory 
'/usr/local/src/gnu/libtool/tests/testsuite.dir/100/libltdl'
CDPATH="${ZSH_VERSION+.}:" && cd . && aclocal -I m4
 cd . && automake --foreign
CDPATH="${ZSH_VERSION+.}:" && cd . && autoconf
/bin/sh ./config.status --recheck
...
(CDPATH="${ZSH_VERSION+.}:" && cd . && autoheader)
rm -f stamp-h1
touch config-h.in
...

* libtoolize.in: Copy config-h.in.
* tests/libtoolize.at: Change "linking" to "copying".
---
 libtoolize.in   | 10 +-
 tests/libtoolize.at |  4 ++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/libtoolize.in b/libtoolize.in
index 631069418eb0..336fc81bd5ea 100644
--- a/libtoolize.in
+++ b/libtoolize.in
@@ -947,7 +947,15 @@ func_install_pkgltdl_files ()
  ;;
 
 config-h.in)
-  test subproject = "$ltdl_mode" || continue
+  test subproject = "$ltdl_mode" && {
+# Always copy config-h.in, otherwise automake's autoheader rules
+# will change the destination's timestamp if it is symlinked.
+( opt_copy=:
+  func_copy "$file" "$pkgltdldir" "$ltdl_dir" \
+pkgltdl_header "$my_copy_filter"
+)
+  }
+  continue
   ;;
 
 configure)
diff --git a/tests/libtoolize.at b/tests/libtoolize.at
index fec51c61c5e6..cbc21d68b61d 100644
--- a/tests/libtoolize.at
+++ b/tests/libtoolize.at
@@ -471,7 +471,7 @@ libtoolize: linking file 'ltdl/README'
 libtoolize: linking file 'ltdl/configure.ac'
 libtoolize: copying file 'ltdl/aclocal.m4'
 libtoolize: linking file 'ltdl/Makefile.in'
-libtoolize: linking file 'ltdl/config-h.in'
+libtoolize: copying file 'ltdl/config-h.in'
 libtoolize: copying file 'ltdl/configure'
 libtoolize: linking file 'ltdl/libltdl/lt__alloc.h'
 libtoolize: linking file 'ltdl/libltdl/lt__argz_.h'
@@ -1047,7 +1047,7 @@ libtoolize: linking file 'ltdl/README'
 libtoolize: creating file 'ltdl/configure.ac'
 libtoolize: creating file 'ltdl/aclocal.m4'
 libtoolize: creating file 'ltdl/Makefile.in'
-libtoolize: linking file 'ltdl/config-h.in'
+libtoolize: copying file 'ltdl/config-h.in'
 libtoolize: creating file 'ltdl/configure'
 libtoolize: linking file 'ltdl/libltdl/lt__alloc.h'
 libtoolize: linking file 

branch master updated: HACKING: add more test related tips

2024-01-17 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 23eacf88 HACKING: add more test related tips
23eacf88 is described below

commit 23eacf882e5247d95360740fd8742eec14146720
Author: Mike Frysinger 
AuthorDate: Thu Jan 18 01:37:11 2024 -0500

HACKING: add more test related tips

* HACKING: Document syntax-check & distcheck & parallel testing.
---
 HACKING | 16 ++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/HACKING b/HACKING
index 664251e6..38401c9c 100644
--- a/HACKING
+++ b/HACKING
@@ -24,6 +24,14 @@ and is not part of a release distribution.
   that demonstrates the bug.  Then fix the bug, re-run the test suite,
   and check everything in.
 
+* Always run the testsuite after applying a patch:
+make check syntax-check TESTSUITEFLAGS="--jobs=$(nproc)" -j$(nproc)
+
+  Ideally also verify the release process doesn't break:
+make distcheck TESTSUITEFLAGS="--jobs=$(nproc)" -j$(nproc)
+  This will run check & syntax-check from above, but will take longer as
+  builds & tests in different configurations.
+
 * Some files in the libtool package are not owned by libtool.  These
   files should never be edited here.  These files are:
COPYING
@@ -55,13 +63,17 @@ and is not part of a release distribution.
   AT_CHECK) is on a single line so that 'testsuite -x' displays the
   whole thing.  You can use m4_do or '[... ]dnl' to wrap long lines.
 
-* Use
-make -k check
+* Run tests in parallel with
+make -k check TESTSUITEFLAGS="--jobs=$(nproc)"
   liberally, on as many platforms as you can.  Use as many compilers and
   linkers you can.  To run old and new testsuites separately, use:
 make check TESTSUITEFLAGS=-V
 make check-local
 
+* The gnulib module also provides some maintainer-focused tests that only
+  work when run from a git checkout.
+make syntax-check
+
 * The new Autotest testsuite uses keywords to denote test features:
 autoconf   needs Autoconf
 automake   needs Automake



[PATCH] HACKING: add more test related tips

2024-01-17 Thread Mike Frysinger
* HACKING: Document syntax-check & distcheck & parallel testing.
---
 HACKING | 16 ++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/HACKING b/HACKING
index 664251e680a9..38401c9cd732 100644
--- a/HACKING
+++ b/HACKING
@@ -24,6 +24,14 @@ and is not part of a release distribution.
   that demonstrates the bug.  Then fix the bug, re-run the test suite,
   and check everything in.
 
+* Always run the testsuite after applying a patch:
+make check syntax-check TESTSUITEFLAGS="--jobs=$(nproc)" -j$(nproc)
+
+  Ideally also verify the release process doesn't break:
+make distcheck TESTSUITEFLAGS="--jobs=$(nproc)" -j$(nproc)
+  This will run check & syntax-check from above, but will take longer as
+  builds & tests in different configurations.
+
 * Some files in the libtool package are not owned by libtool.  These
   files should never be edited here.  These files are:
COPYING
@@ -55,13 +63,17 @@ and is not part of a release distribution.
   AT_CHECK) is on a single line so that 'testsuite -x' displays the
   whole thing.  You can use m4_do or '[... ]dnl' to wrap long lines.
 
-* Use
-make -k check
+* Run tests in parallel with
+make -k check TESTSUITEFLAGS="--jobs=$(nproc)"
   liberally, on as many platforms as you can.  Use as many compilers and
   linkers you can.  To run old and new testsuites separately, use:
 make check TESTSUITEFLAGS=-V
 make check-local
 
+* The gnulib module also provides some maintainer-focused tests that only
+  work when run from a git checkout.
+make syntax-check
+
 * The new Autotest testsuite uses keywords to denote test features:
 autoconf   needs Autoconf
 automake   needs Automake
-- 
2.43.0




Re: Introducing a new maintainer of libtool

2024-01-17 Thread Mike Frysinger
On 17 Jan 2024 16:09, Ileana Dumitrescu wrote:
> I'll need some time figuring out the release process, but otherwise I 
> should be able to get an alpha release out soon. Mike has been helpful 
> and has merged in many patches over the past few days.

there doesn't seem to be libtool-specific release details in the tree.
i can update HACKING with some notes for you.  plus the dist target
seems to be broken :/.
-mike


signature.asc
Description: PGP signature


Re: Introducing a new maintainer of libtool

2024-01-17 Thread Mike Frysinger
On 17 Jan 2024 20:07, Ozkan Sezer wrote:
> Please remember to check with debbugs.gnu.org:
> https://debbugs.gnu.org/cgi/pkgreport.cgi?package=libtool;max-bugs=100;base-order=1;bug-rev=1
> 
> There are plenty of bugs in there. E.g.:

we're always going to have a bug backlog.  if there's something specific you
want to highlight that you think have been missed and should be merged, then
please highlight them specifically.  not sure how you can up with this list.

> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52253

doesn't look like a regression.  it can wait.

> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45738

not a bug report exactly, no existing discussion, and looks questionable.

> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46559

merged now.

> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53479

doesn't look like a regression.  it can wait.

> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41837

already merged 2+ years ago.

> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23348

no, this shouldn't be merged.  the bug thread clearly says as much.

> (... some of which have already been fixed, I haven't checked.)

as Vincent said, if they're resolved/closed, then there's nothing more to do.

also keep in mind that if it's a long standing issue and not a regression in
2.4.7 specifically from 2.4.6, then it's less of a priority than getting the
new 2.4.8 out the door.  especially if there is no patch.
-mike


signature.asc
Description: PGP signature


Re: [PATCH 2/3] ltmain.in: Parse additional clang options

2024-01-17 Thread Mike Frysinger
On 17 Jan 2024 12:39, Richard Purdie wrote:
> clang uses -rtlib and --unwindlib to select proper compiler runtime in
> some cases. Therefore pass these options to linker when found in
> ldflags

merged, thanks
-mike


signature.asc
Description: PGP signature


branch master updated: ltmain.in: Parse additional clang options

2024-01-17 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 725646bf ltmain.in: Parse additional clang options
725646bf is described below

commit 725646bf095bf5c07c49ae38dd060f95bd95ae3c
Author: Richard Purdie 
AuthorDate: Wed Jan 17 12:39:21 2024 +

ltmain.in: Parse additional clang options

clang uses -rtlib and -unwindlib to select proper compiler runtime in
some cases.  Therefore pass these options to linker when found in
ldflags.

* build-aux/ltmain.in: Handle clang linker options.
---
 build-aux/ltmain.in | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index a6a9d696..d94bce55 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -5413,12 +5413,15 @@ func_mode_link ()
   # -shared-libsan   Link with shared sanitizer runtimes (Clang)
   # -static-libsan   Link with static sanitizer runtimes (Clang)
   # -fuse-ld=*   Linker select flags for GCC
+  # -rtlib=* select c runtime lib with clang
+  # --unwindlib=*select unwinder library with clang
   # -f{file|debug|macro|profile}-prefix-map=* needed for lto linking
   # -Wa,*Pass flags directly to the assembler
   # -Werror, -Werror=*   Report (specified) warnings as errors
   -64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \
   
-t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
-  
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
+  -O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*| \
+  -stdlib=*|-rtlib=*|--unwindlib=*| \
   -specs=*|-fsanitize=*|-fno-sanitize*|-shared-libsan|-static-libsan| \
   
-ffile-prefix-map=*|-fdebug-prefix-map=*|-fmacro-prefix-map=*|-fprofile-prefix-map=*|
 \
   -fdiagnostics-color*|-frecord-gcc-switches| \



branch master updated: libtool.m4: Cleanup sysroot trailing "/"

2024-01-17 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 36580532 libtool.m4: Cleanup sysroot trailing "/"
36580532 is described below

commit 365805327c7b9bbdb0e622b954b6b0d8eaeb3f99
Author: Richard Purdie 
AuthorDate: Wed Jan 17 12:39:22 2024 +

libtool.m4: Cleanup sysroot trailing "/"

If $CC has --sysroot=/, it is a valid configuration however libtool will
then set lt_sysroot to "/".

This means references like $lt_sysroot$libdir become //usr/lib instead
of the more normally expected /usr/lib. This may or may not break something
but certainly is confusing to the user and gives confusing output. Making
"/" simply unset lt_sysroot is much cleaner.

Whilst here, trim any trailing '/' from sysroot paths to drop the 
duplication
and result in cleaner/consistent output.

* m4/libtool.m4: Cleanup sysroot trailing '/' handling.
---
 m4/libtool.m4 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index f2c244f0..20527f83 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1255,7 +1255,9 @@ lt_sysroot=
 case $with_sysroot in #(
  yes)
if test yes = "$GCC"; then
- lt_sysroot=`$CC --print-sysroot 2>/dev/null`
+ # Trim trailing / since we'll always append absolute paths and we want
+ # to avoid //, if only for less confusing output for the user.
+ lt_sysroot=`$CC --print-sysroot 2>/dev/null | $SED 's:/\+$::'`
fi
;; #(
  /*)



Re: [PATCH 3/3] libtool.m4: Cleanup sysroot trailing "/"

2024-01-17 Thread Mike Frysinger
On 17 Jan 2024 12:39, Richard Purdie wrote:
> If $CC has --sysroot=/, it is a valid configuration however libtool will
> then set lt_sysroot to "/".
> 
> This means references like $lt_sysroot$libdir become //usr/lib instead
> of the more normally expected /usr/lib. This may or may not break something
> but certainly is confusing to the user and gives confusing output. Making
> "/" simply unset lt_sysroot is much cleaner.
> 
> Whilst here, trim any trailing '/' from sysroot paths to drop the duplication
> and result in cleaner/consistent output.

merged, thanks
-mike


signature.asc
Description: PGP signature


Re: [PATCH 1/3] ltmain.in: Handle prefix-map compiler options correctly

2024-01-17 Thread Mike Frysinger
On 17 Jan 2024 12:39, Richard Purdie wrote:
> If lto is enabled, we need the prefix-map variables to be passed to the linker
> to correctly link the objects using correctly mapped paths.
> 
> Add these to the list of options libtool passes through.

merged, thanks
-mike


signature.asc
Description: PGP signature


branch master updated: ltmain.in: Handle prefix-map compiler options correctly

2024-01-17 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new cdf4bf70 ltmain.in: Handle prefix-map compiler options correctly
cdf4bf70 is described below

commit cdf4bf702f11d17e06569936e8a433a77f791228
Author: Richard Purdie 
AuthorDate: Wed Jan 17 12:39:20 2024 +

ltmain.in: Handle prefix-map compiler options correctly

If lto is enabled, we need the prefix-map variables to be passed to the
linker to correctly link the objects using correctly mapped paths.

Add these to the list of options libtool passes through.

* build-aux/ltmain.in: Handle prefix-map compiler options.
---
 build-aux/ltmain.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index 9f473959..a6a9d696 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -5413,12 +5413,14 @@ func_mode_link ()
   # -shared-libsan   Link with shared sanitizer runtimes (Clang)
   # -static-libsan   Link with static sanitizer runtimes (Clang)
   # -fuse-ld=*   Linker select flags for GCC
+  # -f{file|debug|macro|profile}-prefix-map=* needed for lto linking
   # -Wa,*Pass flags directly to the assembler
   # -Werror, -Werror=*   Report (specified) warnings as errors
   -64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \
   
-t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
   
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
   -specs=*|-fsanitize=*|-fno-sanitize*|-shared-libsan|-static-libsan| \
+  
-ffile-prefix-map=*|-fdebug-prefix-map=*|-fmacro-prefix-map=*|-fprofile-prefix-map=*|
 \
   -fdiagnostics-color*|-frecord-gcc-switches| \
   -fuse-ld=*|-Wa,*|-Werror|-Werror=*)
 func_quote_arg pretty "$arg"



branch master updated: ltmain: correct fallout from freebsd-elf changes

2024-01-17 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 31d9133b ltmain: correct fallout from freebsd-elf changes
31d9133b is described below

commit 31d9133b4ce8d0de1445219b1f85ae8e0c6f5d1a
Author: Tim Rice 
AuthorDate: Sun Jun 18 19:43:49 2017 -0700

ltmain: correct fallout from freebsd-elf changes

Here is a small patch to correct builds on svr5.
When the freebsd-elf target was changed, this got missed.

Symptoms were, building newer lib ended up with libfoo.nn a lower number
than the previous version.  And building libpng-1.6.29 produced:
libtool:   error: CURRENT '' must be a nonnegative integer
libtool:   error: '16:29:0' is not valid version information

* build-aux/ltmain.in (func_mode_link): Add sco.
---
 build-aux/ltmain.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index 830b3982..9f473959 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -6956,7 +6956,7 @@ func_mode_link ()
age=$number_minor
revision=$number_revision
;;
- freebsd-aout|qnx|sunos)
+ freebsd-aout|qnx|sco|sunos)
current=$number_major
revision=$number_minor
age=0



Re: patch to correct fallout from freebsd-elf changes

2024-01-17 Thread Mike Frysinger
On 18 Jun 2017 19:43, Tim Rice wrote:
> Here is a small patch to correct builds on svr5.
> When the freebsd-elf target was changed, this got missed.
> 
> Symptoms were, build newer lib ened up with libfo.nn a loser number
> than the previous version. And building libpng-1.6.29 produced
> libtool:   error: CURRENT '' must be a nonnegative integer
> libtool:   error: '16:29:0' is not valid version information
> 
> Patch attached and inline here.

merged, thanks.

in the future, please make & send standard git commits instead.
when you attach patches, it makes things difficult for us to merge.
-mike


signature.asc
Description: PGP signature


[sr #110525] Typos caught by codespell

2024-01-17 Thread Mike Frysinger
Follow-up Comment #3, sr#110525 (group libtool):

feel free to send a patch to libtool-patches@ for it


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




Re: Introducing a new maintainer of libtool

2024-01-17 Thread Mike Frysinger
On 17 Jan 2024 15:56, Simon Josefsson wrote:
> Looking at that, it seems the bootstrap and bootstrap.conf scripts are
> really old.

seems like they're up-to-date to me.  it's using the fork:
https://github.com/gnulib-modules/bootstrap

> Do we have any GitLab CI/CD testing for libtool?

there is none.  i'm not aware of any in general for GNU/FSF/autotool projects.
-mike


signature.asc
Description: PGP signature


[no subject]

2024-01-16 Thread Mike Frysinger
branch: master
commit 9665e2f25ef27675e0b5fd149abbf3668c991e83
Author: Mike Frysinger 
AuthorDate: Wed Jan 17 02:30:41 2024 -0500

libtool.m4: drop AC_PROG_SED fallback

We require autoconf 2.62 which includes this macro so we don't need
this fallback logic anymore.

* m4/libtool.m4 (AC_PROG_SED): Delete.
---
 m4/libtool.m4 | 67 ---
 1 file changed, 67 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 4b60d27c..6172662c 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -8230,73 +8230,6 @@ _LT_DECL([], [SED], [1], [A sed program that does not 
truncate output])
 _LT_DECL([], [Xsed], ["\$SED -e 1s/^X//"],
 [Sed that helps us avoid accidentally triggering echo(1) options like -n])
 ])# _LT_DECL_SED
-
-m4_ifndef([AC_PROG_SED], [
-
-# NOTE: This macro has been submitted for inclusion into   #
-#  GNU Autoconf as AC_PROG_SED.  When it is available in   #
-#  a released version of Autoconf we should remove this#
-#  macro and use it instead.   #
-
-
-m4_defun([AC_PROG_SED],
-[AC_MSG_CHECKING([for a sed that does not truncate output])
-AC_CACHE_VAL(lt_cv_path_SED,
-[# Loop through the user's path and test for sed and gsed.
-# Then use that list of sed's as ones to test for truncation.
-as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
-  IFS=$as_save_IFS
-  test -z "$as_dir" && as_dir=.
-  for lt_ac_prog in sed gsed; do
-for ac_exec_ext in '' $ac_executable_extensions; do
-  if $as_executable_p "$as_dir/$lt_ac_prog$ac_exec_ext"; then
-lt_ac_sed_list="$lt_ac_sed_list $as_dir/$lt_ac_prog$ac_exec_ext"
-  fi
-done
-  done
-done
-IFS=$as_save_IFS
-lt_ac_max=0
-lt_ac_count=0
-# Add /usr/xpg4/bin/sed as it is typically found on Solaris
-# along with /bin/sed that truncates output.
-for lt_ac_sed in $lt_ac_sed_list /usr/xpg4/bin/sed; do
-  test ! -f "$lt_ac_sed" && continue
-  cat /dev/null > conftest.in
-  lt_ac_count=0
-  echo $ECHO_N "0123456789$ECHO_C" >conftest.in
-  # Check for GNU sed and select it if it is found.
-  if "$lt_ac_sed" --version 2>&1 < /dev/null | grep 'GNU' > /dev/null; then
-lt_cv_path_SED=$lt_ac_sed
-break
-  fi
-  while true; do
-cat conftest.in conftest.in >conftest.tmp
-mv conftest.tmp conftest.in
-cp conftest.in conftest.nl
-echo >>conftest.nl
-$lt_ac_sed -e 's/a$//' < conftest.nl >conftest.out || break
-cmp -s conftest.out conftest.nl || break
-# 1 chars as input seems more than enough
-test 10 -lt "$lt_ac_count" && break
-lt_ac_count=`expr $lt_ac_count + 1`
-if test "$lt_ac_count" -gt "$lt_ac_max"; then
-  lt_ac_max=$lt_ac_count
-  lt_cv_path_SED=$lt_ac_sed
-fi
-  done
-done
-])
-SED=$lt_cv_path_SED
-AC_SUBST([SED])
-AC_MSG_RESULT([$SED])
-])#AC_PROG_SED
-])#m4_ifndef
-
-# Old name:
-AU_ALIAS([LT_AC_PROG_SED], [AC_PROG_SED])
 dnl aclocal-1.4 backwards compatibility:
 dnl AC_DEFUN([LT_AC_PROG_SED], [])
 



master updated (bfcbcc2d -> e6004490)

2024-01-16 Thread Mike Frysinger
vapier pushed a change to branch master.

from bfcbcc2d libtool.m4: fix "manifest" typos
 new 9665e2f2 libtool.m4: drop AC_PROG_SED fallback
 new e6004490 libtool.m4: fix old_archive_from_new_cmds variable name typo


Summary of changes:
 m4/libtool.m4 | 73 +++
 1 file changed, 3 insertions(+), 70 deletions(-)



[no subject]

2024-01-16 Thread Mike Frysinger
branch: master
commit e60044908eec8948f04f8e0af5bb2a77cdb06027
Author: Paul Green 
AuthorDate: Wed Nov 20 23:02:59 2019 +

libtool.m4: fix old_archive_from_new_cmds variable name typo

The "From" should be "from" in the variable name.

Fixes libtool bug https://bugs.gnu.org/38305

* m4/libtool.m4: Change F to f in old_archive_from_new_cmds.
---
 m4/libtool.m4 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 6172662c..ed572bb3 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -5173,7 +5173,7 @@ _LT_EOF
cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
$CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs 
$compiler_flags $output_objdir/$libname.def~
emximp -o $lib $output_objdir/$libname.def'
-  _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+  _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
   _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
   _LT_TAGVAR(file_list_spec, $1)='@'
   ;;
@@ -5879,7 +5879,7 @@ _LT_EOF
cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
$CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs 
$compiler_flags $output_objdir/$libname.def~
emximp -o $lib $output_objdir/$libname.def'
-  _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+  _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
   _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
   _LT_TAGVAR(file_list_spec, $1)='@'
   ;;
@@ -6748,7 +6748,7 @@ if test yes != "$_lt_caught_CXX_error"; then
  cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
  $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs 
$compiler_flags $output_objdir/$libname.def~
  emximp -o $lib $output_objdir/$libname.def'
-   _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+   _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
_LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
_LT_TAGVAR(file_list_spec, $1)='@'
;;



[PATCH] libtool.m4: drop AC_PROG_SED fallback

2024-01-16 Thread Mike Frysinger
We require autoconf 2.62 which includes this macro so we don't need
this fallback logic anymore.

* m4/libtool.m4 (AC_PROG_SED): Delete.
---
 m4/libtool.m4 | 67 ---
 1 file changed, 67 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 4b60d27c0ec2..6172662c7a1f 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -8230,73 +8230,6 @@ _LT_DECL([], [SED], [1], [A sed program that does not 
truncate output])
 _LT_DECL([], [Xsed], ["\$SED -e 1s/^X//"],
 [Sed that helps us avoid accidentally triggering echo(1) options like -n])
 ])# _LT_DECL_SED
-
-m4_ifndef([AC_PROG_SED], [
-
-# NOTE: This macro has been submitted for inclusion into   #
-#  GNU Autoconf as AC_PROG_SED.  When it is available in   #
-#  a released version of Autoconf we should remove this#
-#  macro and use it instead.   #
-
-
-m4_defun([AC_PROG_SED],
-[AC_MSG_CHECKING([for a sed that does not truncate output])
-AC_CACHE_VAL(lt_cv_path_SED,
-[# Loop through the user's path and test for sed and gsed.
-# Then use that list of sed's as ones to test for truncation.
-as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
-  IFS=$as_save_IFS
-  test -z "$as_dir" && as_dir=.
-  for lt_ac_prog in sed gsed; do
-for ac_exec_ext in '' $ac_executable_extensions; do
-  if $as_executable_p "$as_dir/$lt_ac_prog$ac_exec_ext"; then
-lt_ac_sed_list="$lt_ac_sed_list $as_dir/$lt_ac_prog$ac_exec_ext"
-  fi
-done
-  done
-done
-IFS=$as_save_IFS
-lt_ac_max=0
-lt_ac_count=0
-# Add /usr/xpg4/bin/sed as it is typically found on Solaris
-# along with /bin/sed that truncates output.
-for lt_ac_sed in $lt_ac_sed_list /usr/xpg4/bin/sed; do
-  test ! -f "$lt_ac_sed" && continue
-  cat /dev/null > conftest.in
-  lt_ac_count=0
-  echo $ECHO_N "0123456789$ECHO_C" >conftest.in
-  # Check for GNU sed and select it if it is found.
-  if "$lt_ac_sed" --version 2>&1 < /dev/null | grep 'GNU' > /dev/null; then
-lt_cv_path_SED=$lt_ac_sed
-break
-  fi
-  while true; do
-cat conftest.in conftest.in >conftest.tmp
-mv conftest.tmp conftest.in
-cp conftest.in conftest.nl
-echo >>conftest.nl
-$lt_ac_sed -e 's/a$//' < conftest.nl >conftest.out || break
-cmp -s conftest.out conftest.nl || break
-# 1 chars as input seems more than enough
-test 10 -lt "$lt_ac_count" && break
-lt_ac_count=`expr $lt_ac_count + 1`
-if test "$lt_ac_count" -gt "$lt_ac_max"; then
-  lt_ac_max=$lt_ac_count
-  lt_cv_path_SED=$lt_ac_sed
-fi
-  done
-done
-])
-SED=$lt_cv_path_SED
-AC_SUBST([SED])
-AC_MSG_RESULT([$SED])
-])#AC_PROG_SED
-])#m4_ifndef
-
-# Old name:
-AU_ALIAS([LT_AC_PROG_SED], [AC_PROG_SED])
 dnl aclocal-1.4 backwards compatibility:
 dnl AC_DEFUN([LT_AC_PROG_SED], [])
 
-- 
2.43.0




[sr #107584] Fails to detect the global symbol pipe

2024-01-16 Thread Mike Frysinger
Update of sr#107584 (group libtool):

  Status:None => Need Info  


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #110261] _LT_CMD_OLD_ARCHIVE should not inline AC_PROG_RANLIB

2024-01-16 Thread Mike Frysinger
Follow-up Comment #1, sr#110261 (group libtool):

LT_INIT already does AC_PREREQ(2.62), so relying on AC_PROG_RANLIB sounds
fine

want to send a patch to the mailing list ?


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #111002] regression in libtool 2.4.7: build error in ncurses

2024-01-16 Thread Mike Frysinger
Update of sr#111002 (group libtool):

  Status:None => Need Info  

___

Follow-up Comment #1:

are you using patched libtool in your system ?  ncurses-6.4 builds fine for me
with libtool-2.4.7.

please attach your /usr/bin/libtool file.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #110947] flang: error: unknown argument: '-soname'

2024-01-16 Thread Mike Frysinger
Update of sr#110947 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

this is handled via https://savannah.gnu.org/patch/?9442


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #108559] libtool binary wrappers fall prey to aggressive optimizations

2024-01-16 Thread Mike Frysinger
Update of sr#108559 (group libtool):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #108558] libtool nm test does not really work for W32 versions of nm

2024-01-16 Thread Mike Frysinger
Update of sr#108558 (group libtool):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #107959] Libtool generates invalid .def files

2024-01-16 Thread Mike Frysinger
Update of sr#107959 (group libtool):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #107584] Fails to detect the global symbol pipe

2024-01-16 Thread Mike Frysinger
Follow-up Comment #1, sr#107584 (group libtool):

please attach a patch showing what you mean


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #102915] Compilation errors with gcc -mno-cygwin

2024-01-16 Thread Mike Frysinger
Update of sr#102915 (group libtool):

  Status:None => Invalid
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

i don't know what "plsdbug" is, but source compilation errors in random
projects are rarely a libtool bug.  you should contact whoever maintains
"lt-plsdbug.c".


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #102833] doc

2024-01-16 Thread Mike Frysinger
Update of sr#102833 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

i don't think there's anything left to do here


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #108987] libtool doesn't like simple RM defined (without options)

2024-01-16 Thread Mike Frysinger
Follow-up Comment #4, sr#108987 (group libtool):

bootstrap & build-aux/funclib.sh are not maintained in libtool.  you'll want
to send those fixes upstream.
https://github.com/gnulib-modules/bootstrap


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #110796] libtool-2.4.7/build-aux/git-version-gen uses kind of a hack

2024-01-16 Thread Mike Frysinger
Update of sr#110796 (group libtool):

  Status:None => Wont Do
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

build-aux/git-version-gen is maintained in the gnulib project, so you prob
want to report issues to them instead

https://www.gnu.org/software/gnulib


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #110525] Typos caught by codespell

2024-01-16 Thread Mike Frysinger
Update of sr#110525 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

should be fixed in latest git now, thanks


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[sr #110870] Typos in libtool.texi and libtool.m4

2024-01-16 Thread Mike Frysinger
Update of sr#110870 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

should be fixed in latest git now, thanks


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




branch master updated: libtool.m4: fix "manifest" typos

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new bfcbcc2d libtool.m4: fix "manifest" typos
bfcbcc2d is described below

commit bfcbcc2dcea8036cd41e440cc66f6b710ac05bbc
Author: Albert Chu 
AuthorDate: Wed Apr 19 16:18:36 2023 -0700

libtool.m4: fix "manifest" typos

* m4/libtool.m4: Rename lt_cv_path_mainfest_tool to 
lt_cv_path_manifest_tool.

Signed-off-by: Albert Chu 
---
 m4/libtool.m4 | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 541ba8a8..4b60d27c 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -3816,16 +3816,16 @@ _LT_DECL([], [sharedlib_from_linklib_cmd], [1],
 m4_defun([_LT_PATH_MANIFEST_TOOL],
 [AC_CHECK_TOOL(MANIFEST_TOOL, mt, :)
 test -z "$MANIFEST_TOOL" && MANIFEST_TOOL=mt
-AC_CACHE_CHECK([if $MANIFEST_TOOL is a manifest tool], 
[lt_cv_path_mainfest_tool],
-  [lt_cv_path_mainfest_tool=no
+AC_CACHE_CHECK([if $MANIFEST_TOOL is a manifest tool], 
[lt_cv_path_manifest_tool],
+  [lt_cv_path_manifest_tool=no
   echo "$as_me:$LINENO: $MANIFEST_TOOL '-?'" >_MESSAGE_LOG_FD
   $MANIFEST_TOOL '-?' 2>conftest.err > conftest.out
   cat conftest.err >_MESSAGE_LOG_FD
   if $GREP 'Manifest Tool' conftest.out > /dev/null; then
-lt_cv_path_mainfest_tool=yes
+lt_cv_path_manifest_tool=yes
   fi
   rm -f conftest*])
-if test yes != "$lt_cv_path_mainfest_tool"; then
+if test yes != "$lt_cv_path_manifest_tool"; then
   MANIFEST_TOOL=:
 fi
 _LT_DECL([], [MANIFEST_TOOL], [1], [Manifest tool])dnl



[sr #110962] pass_all for z/OS

2024-01-16 Thread Mike Frysinger
Update of sr#110962 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

you posted the patch to the list -- you don't need to file a bug report too


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




Re: [PATCH 1/3] libtool.m4: augment symcode for Solaris 11

2024-01-16 Thread Mike Frysinger
this should be fixed in git now.  i merged the one posted previously:
https://savannah.gnu.org/patch/?9086
-mike


signature.asc
Description: PGP signature


[patch #9086] Fix support for Solaris 11 build

2024-01-16 Thread Mike Frysinger
Update of patch#9086 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

thanks, merged now
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=b67d1a2db842c01c051c7e90d7f4c18928d8b555

in the future, please attach git formatted patches instead, and write proper
commit messages


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




branch master updated: libtool: fix Solaris 11 builds

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new b67d1a2d libtool: fix Solaris 11 builds
b67d1a2d is described below

commit b67d1a2db842c01c051c7e90d7f4c18928d8b555
Author: Oliver Kiddle 
AuthorDate: Wed Aug 17 08:27:43 2016 -0400

libtool: fix Solaris 11 builds

Trying to build clamav on Solaris 11.3 with the Oracle C compiler,
I got the following error:

libtool: error: not configured to extract global symbols from dlpreopened 
files

I would have expected a build to use dlopen rather than the preopen
fallback so looked for related configure tests that were perhaps
returning the wrong answer.

The global_symbol_pipe being empty seemed a likely culprit.
the last three lines of nm -p on the conftest.o in this test are:

32 T main
16 T nm_test_func
01 C nm_test_var

On Solaris 10, I'd get a D instead of a C. Adding C to the list of
characters in the symcode variable and building again resulted in a
successful build. I've attached a patch to add this C.

Url: https://savannah.gnu.org/patch/?9086

* m4/libtool.m4 (symcode): Add C for solaris.
---
 m4/libtool.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 7ab5fe57..541ba8a8 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -3944,7 +3944,7 @@ osf*)
   symcode='[[BCDEGQRST]]'
   ;;
 solaris*)
-  symcode='[[BDRT]]'
+  symcode='[[BCDRT]]'
   ;;
 sco3.2v5*)
   symcode='[[DT]]'



Re: [PATCH 02/12] libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 12:21, Richard Purdie wrote:
> On Mon, 2024-01-15 at 20:08 -0500, Mike Frysinger wrote:
> > On 25 Oct 2021 15:33, Richard Purdie wrote:
> > > This patch renames the --with-sysroot option to --with-libtool-sysroot
> > > to avoid namespace conflict with binutils, gcc and other toolchain
> > > components since these componets also add that option to configure
> > > and this becomes confusing and conflicting otherwise.
> > 
> > we're talking like 3 projects ?  libtool is used & included in way more
> > projects than that.  it seems like --with-sysroot as a standard name to
> > propagate out into the wider ecosystem makes more sense.
> 
> You're saying binutils and gcc should change? I'm fairly sure they'll
> decline to do that. Their options are encoded into quite a few cross
> compiling documents and build systems.

and there are even more packages out there using libtool.

these are all GNU projects working in the toolchain space to make the GNU
system coherent & better under the FSF.  it is not one GNU project working
in isolation and not caring about anyone else.  decisions should be made
with the long term outlook in mind, especially when we aren't talking about
runtime ABI that would break/blow up everywhere.  these are development and
build scripts ... they aren't immutable.

> > i agree there's confusion between "use this path as a sysroot to compile
> > and link against" and "have the compile tools target this sysroot".  the
> > same problem exists with host selection which is why we have the build,
> > host, and target options.  sounds like we want names that can align with
> > these somehow.
> 
> FWIW gcc and binutils have gone with --with-sysroot and --with-build-
> sysroot to differentiate. Unfortunately that doesn't really help
> libtool (see below).

i would argue --with-build-sysroot is not aligned with the other conventions
used in configure scripts.
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Hosts-and-Cross_002dCompilation.html

--build is the system doing the compilation and controls settings for the
build tools themselves, not for the toolchain specified via --host.  instead
the "host" part is omitted since it's the default.  c.f. BUILD_CC & CC,
BUILD_CFLAGS & CFLAGS, etc...

which makes --with-sysroot the original sin as it fills that gap already.
which is how libtool is using it now.

really it seems like --with-sysroot should be renamed to --with-target-sysroot
since it's controlling the target output behavior ... which is what gcc et al
already use --target for.  you can see that with the various libs it builds
and the use of xxx_FOR_TARGET variables.

ignoring the mismatch in conventions, i can't say that i would see much use
of a sysroot setting for the build tools themselves, so it isn't like gcc
has squatted in a space that would cause issues.  although that kind of
thinking is why we're in this situation in the first place.

> > --with-libtool-sysroot doesn't make sense as it isn't an internal libtool
> > setting, it's changing how executables are linked, and users (who run the
> > configure scripts) don't know or care about this "libtool" thing.
> 
> I think it partly depends upon how you view it. Most of the time
> libtool uses `$CC --print-sysroot` to set this and therefore most users
> wouldn't use the commandline option. In general you do want the
> compiler/linker and libtool to be working the same way.
> 
> The challenge is that binutils/gcc and libtool have adopted different
> meanings for the same option and if/as/where the commandline options
> get passed around, things can become quite broken when cross compiling.

i understand the conflict, and how it only applies to building the toolchain
source projects (gcc and its downstream like binutils & gdb).

> My ask is to try and find a way to avoid the confusion (and the need
> for Yocto Project to have to patch one set of components to make things
> work).
> 
> The options as I see it are:
> 
> a) Use a libtool specific option (as per the patch under review)

no.  libtool is an internal implementation detail.  there should be no
exposure/leakage of the name to people configuring+building.  it's like
saying we should call --with-pic --with-libtool-pic because it's libtool
creating the position independent code.

> b) Stop providing a commandline option for libtool and rely on the
> compiler query.

no, it is in active use as intended already.  this is like saying most
people don't set LDFLAGS, so just delete it.  while it's uncommon, it can
serve a pretty critical and irreplaceable function.

> c) Switch to --with-build-sysroot

not the worst option, but certainly not preferable as outlined above.

> d) Switch

Re: [PATCH] libtool: remove OpenBSD support for non-shared and a.out archs

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 21:11, Brad Smith wrote:
> libtool: remove OpenBSD support for non-shared and a.out archs
> 
> OpenBSD stopped supporting the last non-shared arch 8 years ago
> and stopped supporting a.out 10.5 years ago.

i'm on the fence here, and i don't know what historical guidance/policy
libtool has had.  i looked through HACKING & the manual and didn't find
anything relevant.

yeah, that's an old target, but libtool supports things older than that.
-mike


signature.asc
Description: PGP signature


[PATCH] HACKING: minor formatting tweaks

2024-01-16 Thread Mike Frysinger
* HACKING: Tweak style.
---
 HACKING | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/HACKING b/HACKING
index 92292d1d023d..664251e680a9 100644
--- a/HACKING
+++ b/HACKING
@@ -13,7 +13,7 @@ and is not part of a release distribution.
 * If you incorporate a change from somebody on the net:
   If it is a large change, you must make sure they have signed the
   appropriate paperwork, and be sure to add their name and email
-  address to THANKS
+  address to THANKS.
 
 * If a change fixes a test, mention the test in the git log entry.
 
@@ -45,7 +45,7 @@ and is not part of a release distribution.
   gnulib is up-to-date, and running 'bootstrap' to recheck the links are
   correct.
 
-* Changes other than bug fixes must be mentioned in NEWS
+* Changes other than bug fixes must be mentioned in NEWS.
 
 
 3. Test Suite
@@ -58,7 +58,7 @@ and is not part of a release distribution.
 * Use
 make -k check
   liberally, on as many platforms as you can.  Use as many compilers and
-  linkers you can.  To run old and new testsuites separately, use
+  linkers you can.  To run old and new testsuites separately, use:
 make check TESTSUITEFLAGS=-V
 make check-local
 
@@ -130,7 +130,7 @@ and is not part of a release distribution.
 6. Editing '.am' Files
 ==
 
-* Always use $(...) and not ${...}
+* Always use $(...) and not ${...}.
 
 * Use ':', not 'true'.  Use 'exit 1', not 'false'.
 
@@ -180,7 +180,7 @@ and is not part of a release distribution.
 
 
 8. Abstraction layers in libltdl
-=
+
 
 * The libltdl API uses a layered approach to differentiate internal and
   external interfaces, among other things.  To keep the abstraction
@@ -283,10 +283,10 @@ and is not part of a release distribution.
 9. Licensing Rules
 ==
 
-GNU Libtool uses 3 different licenses for various of the files distributed
-herein, with several variations on license text.  It is important that
-you use the correct license text in each new file added.  Here are the
-texts along with some notes on when each is appropriate.  Appropriate
+GNU Libtool uses 3 different licenses for the files distributed herein,
+with several variations on license text.  It is important that you use
+the correct license text in each new file added.  Here are the texts
+along with some notes on when each is appropriate.  Appropriate
 commenting (shell, C etc) and decoration (m4 etc) assumed throughout.
 
 
-- 
2.43.0




branch master updated: HACKING: minor formatting tweaks

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 3ebfdce7 HACKING: minor formatting tweaks
3ebfdce7 is described below

commit 3ebfdce755c6ecd0f8f77fc2c4fd699c6ee51fed
Author: Mike Frysinger 
AuthorDate: Tue Jan 16 23:42:04 2024 -0500

HACKING: minor formatting tweaks

* HACKING: Tweak style.
---
 HACKING | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/HACKING b/HACKING
index 92292d1d..664251e6 100644
--- a/HACKING
+++ b/HACKING
@@ -13,7 +13,7 @@ and is not part of a release distribution.
 * If you incorporate a change from somebody on the net:
   If it is a large change, you must make sure they have signed the
   appropriate paperwork, and be sure to add their name and email
-  address to THANKS
+  address to THANKS.
 
 * If a change fixes a test, mention the test in the git log entry.
 
@@ -45,7 +45,7 @@ and is not part of a release distribution.
   gnulib is up-to-date, and running 'bootstrap' to recheck the links are
   correct.
 
-* Changes other than bug fixes must be mentioned in NEWS
+* Changes other than bug fixes must be mentioned in NEWS.
 
 
 3. Test Suite
@@ -58,7 +58,7 @@ and is not part of a release distribution.
 * Use
 make -k check
   liberally, on as many platforms as you can.  Use as many compilers and
-  linkers you can.  To run old and new testsuites separately, use
+  linkers you can.  To run old and new testsuites separately, use:
 make check TESTSUITEFLAGS=-V
 make check-local
 
@@ -130,7 +130,7 @@ and is not part of a release distribution.
 6. Editing '.am' Files
 ==
 
-* Always use $(...) and not ${...}
+* Always use $(...) and not ${...}.
 
 * Use ':', not 'true'.  Use 'exit 1', not 'false'.
 
@@ -180,7 +180,7 @@ and is not part of a release distribution.
 
 
 8. Abstraction layers in libltdl
-=
+
 
 * The libltdl API uses a layered approach to differentiate internal and
   external interfaces, among other things.  To keep the abstraction
@@ -283,10 +283,10 @@ and is not part of a release distribution.
 9. Licensing Rules
 ==
 
-GNU Libtool uses 3 different licenses for various of the files distributed
-herein, with several variations on license text.  It is important that
-you use the correct license text in each new file added.  Here are the
-texts along with some notes on when each is appropriate.  Appropriate
+GNU Libtool uses 3 different licenses for the files distributed herein,
+with several variations on license text.  It is important that you use
+the correct license text in each new file added.  Here are the texts
+along with some notes on when each is appropriate.  Appropriate
 commenting (shell, C etc) and decoration (m4 etc) assumed throughout.
 
 



Re: pass_all for z/OS

2024-01-16 Thread Mike Frysinger
On 17 Jan 2024 02:41, Igor Todorovski wrote:
> I’ve attached the git patch based on the master branch.

can you write a proper git commit and send it with send-email ?
or at least format it with `git format-patch` ?

the first version did:
openedition)

the new one does:
*openedition*)

isn't it always going to be "openedition" exactly ?  no need for globs ?
-mike


signature.asc
Description: PGP signature


Re: [PATCH] libtool.m4: Handle "/" as a sysroot more correctly

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 21:47, Richard Purdie wrote:
> If $CC has --sysroot=/, it is a valid configuration however libtool will
> then set lt_sysroot to "/".
> 
> This means references like $lt_sysroot$libdir become //usr/lib instead
> of the more normally expected /usr/lib. This may or may not break something
> but certainly is confusing to the user and gives confusing output. Making
> "/" simply unset lt_sysroot is much cleaner.

could the same argument be made if the returned value is "/opt/sysroot/"
and not just "/opt/sysroot" ?  not sure if gcc forces normalization on its
side.  but we could "simplify" this with:

# Trim trailing / since we'll always append absolute paths and we want
# to avoid //, if only for less confusing output for the user.
lt_sysroot=`$CC --print-sysroot 2>/dev/null | $SED 's:/\+$::'`
-mike


signature.asc
Description: PGP signature


Re: [PATCH 05/12] ltmain.in: Don't encode RATHS which match default linker paths

2024-01-16 Thread Mike Frysinger
On 25 Oct 2021 15:33, Richard Purdie wrote:
> We don't want to add RPATHS which match default linker search paths, they're
> a waste of space. This patch filters libtools list of paths to encoode and
> removes the ones we don't need.
> 
> Libtool may be passed link paths of the form "/usr/lib/../lib" so normalize
> the paths before comparision.

add a bit more detail to the commit message, add the changelog, and fix the
typo in the subject line ("RATHS").

> --- a/build-aux/ltmain.in
> +++ b/build-aux/ltmain.in
> @@ -7672,8 +7672,16 @@ EOF
> esac
>   fi
> else
> - eval flag=\"$hardcode_libdir_flag_spec\"
> - func_append dep_rpath " $flag"
> +# We only want to hardcode in an rpath if it isn't in the
> +# default dlsearch path.
> +func_normal_abspath "$libdir"
> +libdir_norm=$func_normal_abspath_result
> + case " $sys_lib_dlsearch_path " in
> + *" $libdir_norm "*) ;;
> + *) eval flag=\"$hardcode_libdir_flag_spec\"
> +   func_append dep_rpath " $flag"
> +   ;;
> + esac

this is a non-trivial amount of boiler plate that you're pasting in here.
can we introduce a func to make this more readable ?  something like this
untested code.

# func_is_in_list   [separator]
# blah blah blah
func_is_in_list ()
{
case "${3:- }$2${3:- }" in
*"${3:- }$1${3:- }"*) return 0;;
esac
return 1
}

then you could write:
  func_normal_abspath "$libdir"
  if ! func_is_in_list "$func_normal_abspath_result" "$sys_lib_dlsearch_path"; 
then
eval flag=\"$hardcode_libdir_flag_spec\"
func_append dep_rpath " $flag"
  fi

and there's 2 other places where $sys_lib_dlsearch_path is checked that could
be converted over to this helper.
-mike


signature.asc
Description: PGP signature


Re: [PATCH] libtool: remove OpenBSD specific performance hack for ranlib

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 16:30, Brad Smith wrote:
> The -t flag was used as a performance hack for ranlib. The flag was
> supported by the GNU toolchain, but is a no-op with the LLVM toolchain.

merged, thx
-mike


signature.asc
Description: PGP signature


branch master updated: libtool: remove OpenBSD specific performance hack for ranlib

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 1ae386ba libtool: remove OpenBSD specific performance hack for ranlib
1ae386ba is described below

commit 1ae386ba78f499d366c3123d0737745589c5dfec
Author: Brad Smith 
AuthorDate: Tue Jan 16 16:30:09 2024 -0500

libtool: remove OpenBSD specific performance hack for ranlib

The -t flag was used as a performance hack for ranlib. The flag was
supported by the GNU toolchain, but is a no-op with the LLVM toolchain.

* m4/libtool.m4: Remove use of -t flag with ranlib.
---
 m4/libtool.m4 | 9 +
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 4b84ce96..7ab5fe57 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1555,15 +1555,8 @@ old_postinstall_cmds='chmod 644 $oldlib'
 old_postuninstall_cmds=
 
 if test -n "$RANLIB"; then
-  case $host_os in
-  openbsd*)
-old_postinstall_cmds="$old_postinstall_cmds~\$RANLIB -t \$tool_oldlib"
-;;
-  *)
-old_postinstall_cmds="$old_postinstall_cmds~\$RANLIB \$tool_oldlib"
-;;
-  esac
   old_archive_cmds="$old_archive_cmds~\$RANLIB \$tool_oldlib"
+  old_postinstall_cmds="$old_postinstall_cmds~\$RANLIB \$tool_oldlib"
 fi
 
 case $host_os in



Re: [PATCH 3/3] libtool: Fix support for NIOS2 processor

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 15:14, Richard Purdie wrote:
> The name of the system contains the string "nios2". This string
> is caught by the some of the greedy checks for OS/2 in libtool,
> in particular the *os2* branches of switch statements match for
> the nios2 string, which results in incorrect behavior of libtool.
> 
> Switch to use $host_os instead of $host and tweak the patterns to
> match to avoid this problem for nios2.

merged, thx
-mike


signature.asc
Description: PGP signature


branch master updated: libtool: Fix support for NIOS2 processor

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 49e6cb0d libtool: Fix support for NIOS2 processor
49e6cb0d is described below

commit 49e6cb0d4dfdca2a59b909dc4532fe22dbc57ad5
Author: Richard Purdie 
AuthorDate: Tue Jan 16 15:14:24 2024 +

libtool: Fix support for NIOS2 processor

When building for a nios2 system, the $host tuple starts with "nios2-"
which is caught by the some of the greedy checks for OS/2 in libtool.
In particular, the *os2* branches of switch statements that only want
to match the OS setting end up matching all nios2 targets, which
results in incorrect behavior.

Switch to use $host_os instead of $host and tweak the patterns to
match to avoid this problem for nios2.

* build-aux/ltmain.in: Switch some $host checks to $host_os.
---
 build-aux/ltmain.in | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index 9f4889f4..830b3982 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -518,10 +518,10 @@ libtool_validate_options ()
 # preserve --debug
 test : = "$debug_cmd" || func_append preserve_args " --debug"
 
-case $host in
+case $host_os in
   # Solaris2 added to fix 
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16452
   # see also: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59788
-  *cygwin* | *mingw* | *windows* | *pw32* | *cegcc* | *solaris2* | *os2*)
+  cygwin* | mingw* | windows* | pw32* | cegcc* | solaris2* | os2*)
 # don't eliminate duplications in $postdeps and $predeps
 opt_duplicate_compiler_generated_deps=:
 ;;
@@ -6276,8 +6276,8 @@ func_mode_link ()
fi
if test -n "$library_names" &&
   { test no = "$use_static_libs" || test -z "$old_library"; }; then
- case $host in
- *cygwin* | *mingw* | *windows* | *cegcc* | *os2*)
+ case $host_os in
+ cygwin* | mingw* | windows* | cegcc* | os2*)
  # No point in relinking DLLs because paths are not encoded
  func_append notinst_deplibs " $lib"
  need_relink=no
@@ -6346,8 +6346,8 @@ func_mode_link ()
  soname=$dlname
elif test -n "$soname_spec"; then
  # bleh windows
- case $host in
- *cygwin* | mingw* | *windows* | *cegcc* | *os2*)
+ case $host_os in
+ cygwin* | mingw* | windows* | cegcc* | os2*)
func_arith $current - $age
major=$func_arith_result
versuffix=-$major



Re: [PATCH 1/3] ltmain.in: Handle prefix-map compiler options correctly

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 15:14, Richard Purdie wrote:
> --- a/build-aux/ltmain.in
> +++ b/build-aux/ltmain.in
> @@ -7,7 +7,6 @@
>  # Copyright (C) 1996-2019, 2021-2024 Free Software Foundation, Inc.
>  # This is free software; see the source for copying conditions.  There is NO
>  # warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> -
>  # GNU Libtool is free software; you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
>  # the Free Software Foundation; either version 2 of the License, or

let's leave unrelated changes out please

> @@ -5413,12 +5412,14 @@ func_mode_link ()
># -shared-libsan   Link with shared sanitizer runtimes (Clang)
># -static-libsan   Link with static sanitizer runtimes (Clang)
># -fuse-ld=*   Linker select flags for GCC
> +  # -f{file|debug|macro}-prefix-map* needed for lto linking

these take the form of -ffile-prefix-map=xxx right ?
so we'd want to put a = before the glob at the end ?
-mike


signature.asc
Description: PGP signature


Re: [PATCH 1/2] libtool: replace : with $PATH_SEPARATOR

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 23:44, KO Myung-Hun wrote:
> Some OSes such as OS/2, uses ';' as a path separator. So using
> $PATH_SEPARATOR instead of hard-coded ':' is more proper.

so we're on the same page, we're talking about the separator that is used in
the $PATH environment variable.  it doesn't show up in other places -- it is
not used to separate e.g. rpath entries right ?  what about LD_LIBRARY_PATH
and similar vars ?  i guess we assume the separator used by PATH is also used
with that var ?
-mike


signature.asc
Description: PGP signature


[PATCH] bootstrap: sync to latest version

2024-01-16 Thread Mike Frysinger
* gl-mod/bootstrap: Update.
* bootstrap: Likewise.
---
 bootstrap| 34 +-
 gl-mod/bootstrap |  2 +-
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/bootstrap b/bootstrap
index 8e0b5e83218d..e57ec940db68 100755
--- a/bootstrap
+++ b/bootstrap
@@ -9,11 +9,11 @@
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2010-2019, 2021 Bootstrap Authors
+# Copyright (C) 2010-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# , and GPL version 2 or later
-# .  You must apply one of
+# , and GPL version 2 or later
+# .  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -48,7 +48,7 @@
 #   gl/build-aux/inline-source gl/build-aux/bootstrap.in > bootstrap
 #
 # You should then store than script in version control for other
-# developers in you project.  It will give you instructions about
+# developers in your project.  It will give you instructions about
 # how to keep it up to date if the sources change.
 #
 # See gl/doc/bootstrap.texi for documentation on how to write
@@ -235,11 +235,11 @@ scriptversion=2019-02-19.15; # UTC
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2004-2019, 2021 Bootstrap Authors
+# Copyright (C) 2004-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# , and GPL version 2 or later
-# .  You must apply one of
+# , and GPL version 2 or later
+# .  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -306,7 +306,7 @@ nl='
 '
 IFS="$sp   $nl"
 
-# There are apparently some retarded systems that use ';' as a PATH separator!
+# There are apparently some systems that use ';' as a PATH separator!
 if test "${PATH_SEPARATOR+set}" != set; then
   PATH_SEPARATOR=:
   (PATH='/bin;/bin'; FPATH=$PATH; sh -c :) >/dev/null 2>&1 && {
@@ -1699,11 +1699,11 @@ func_lt_ver ()
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2010-2019, 2021 Bootstrap Authors
+# Copyright (C) 2010-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# , and GPL version 2 or later
-# .  You must apply one of
+# , and GPL version 2 or later
+# .  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -2384,11 +2384,11 @@ func_version ()
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2010-2019, 2021 Bootstrap Authors
+# Copyright (C) 2010-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# , and GPL version 2 or later
-# .  You must apply one of
+# , and GPL version 2 or later
+# .  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -3832,7 +3832,7 @@ for tool in autoconf libtoolize autopoint; do
   _G_version=$func_extract_trace_result
   test -n "$_G_version" && {
 func_append buildreq "\
-'$tool' $_G_version http://www.gnu.org/s/'$b'
+'$tool' $_G_version https://www.gnu.org/s/'$b'
 "
 func_verbose \
 "auto-adding '\'$tool'-$_G_version'\'' to build requirements"
@@ -3865,7 +3865,7 @@ func_require_buildreq_automake ()
 test -n "$automake_version" || automake_version=-
 
 func_append buildreq "\
-automake $automake_version http://www.gnu.org/s/automake
+automake $automake_version 

[no subject]

2024-01-16 Thread Mike Frysinger
branch: master
commit 51ac68a24eb72e3e522d2d2d15f322f2163757ed
Author: Mike Frysinger 
AuthorDate: Tue Jan 16 20:01:41 2024 -0500

bootstrap: sync to latest version

* gl-mod/bootstrap: Update.
* bootstrap: Likewise.
---
 bootstrap| 34 +-
 gl-mod/bootstrap |  2 +-
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/bootstrap b/bootstrap
index 8e0b5e83..e57ec940 100755
--- a/bootstrap
+++ b/bootstrap
@@ -9,11 +9,11 @@
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2010-2019, 2021 Bootstrap Authors
+# Copyright (C) 2010-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# <https://opensource.org/license/MIT>, and GPL version 2 or later
-# <http://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
+# <https://opensource.org/licenses/MIT>, and GPL version 2 or later
+# <https://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -48,7 +48,7 @@
 #   gl/build-aux/inline-source gl/build-aux/bootstrap.in > bootstrap
 #
 # You should then store than script in version control for other
-# developers in you project.  It will give you instructions about
+# developers in your project.  It will give you instructions about
 # how to keep it up to date if the sources change.
 #
 # See gl/doc/bootstrap.texi for documentation on how to write
@@ -235,11 +235,11 @@ scriptversion=2019-02-19.15; # UTC
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2004-2019, 2021 Bootstrap Authors
+# Copyright (C) 2004-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# <https://opensource.org/license/MIT>, and GPL version 2 or later
-# <http://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
+# <https://opensource.org/licenses/MIT>, and GPL version 2 or later
+# <https://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -306,7 +306,7 @@ nl='
 '
 IFS="$sp   $nl"
 
-# There are apparently some retarded systems that use ';' as a PATH separator!
+# There are apparently some systems that use ';' as a PATH separator!
 if test "${PATH_SEPARATOR+set}" != set; then
   PATH_SEPARATOR=:
   (PATH='/bin;/bin'; FPATH=$PATH; sh -c :) >/dev/null 2>&1 && {
@@ -1699,11 +1699,11 @@ func_lt_ver ()
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2010-2019, 2021 Bootstrap Authors
+# Copyright (C) 2010-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# <https://opensource.org/license/MIT>, and GPL version 2 or later
-# <http://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
+# <https://opensource.org/licenses/MIT>, and GPL version 2 or later
+# <https://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -2384,11 +2384,11 @@ func_version ()
 # This is free software.  There is NO warranty; not even for
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# Copyright (C) 2010-2019, 2021 Bootstrap Authors
+# Copyright (C) 2010-2019, 2021, 2023 Bootstrap Authors
 #
 # This file is dual licensed under the terms of the MIT license
-# <https://opensource.org/license/MIT>, and GPL version 2 or later
-# <http://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
+# <https://opensource.org/licenses/MIT>, and GPL version 2 or later
+# <https://www.gnu.org/licenses/gpl-2.0.html>.  You must apply one of
 # these licenses when using or redistributing this software or any of
 # the files within it.  See the URLs above, or the file `LICENSE`
 # included in the Bootstrap distribution for the full license texts.
@@ -3832,7 +3832,7 @@ for tool in autoconf libtoolize autopoint; do
   _G_version=$func_extract_trace_result
   test -n "$_G_version" && {
 func_append buildreq "\
-'$tool' $_G_version http://www.gnu.org/s/'$b'
+'$tool' $_G_version https://www.gnu.org/s/'$b'
 "
 func_verbose \
 

[no subject]

2024-01-16 Thread Mike Frysinger
branch: master
commit 306c759bed5fbae0e08e795f8fd82eeffabfa35b
Author: Mike Frysinger 
AuthorDate: Tue Jan 16 20:01:00 2024 -0500

bootstrap: revert typo fixes

This is maintained elsewhere, so we don't want to fork it locally.

* bootstrap: Restore upstream typos.
---
 bootstrap | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/bootstrap b/bootstrap
index 3f8e0101..8e0b5e83 100755
--- a/bootstrap
+++ b/bootstrap
@@ -53,7 +53,7 @@
 #
 # See gl/doc/bootstrap.texi for documentation on how to write
 # a bootstrap.conf to customize it for your project's
-# idiosyncrasies.
+# idiosyncracies.
 
 
 ## == ##
@@ -192,7 +192,7 @@ extra_locale_categories=
 
 # Additional xgettext options to use.  Gnulib might provide you with an
 # extensive list of additional options to append to this, but gettext
-# 0.16.1 and newer appends them automatically, so you can safely ignore
+# 0.16.1 and newer appends them automaticaly, so you can safely ignore
 # the complaints from 'gnulib-tool' if your $configure_ac states:
 #
 #AM_GNU_GETTEXT_VERSION([0.16.1])
@@ -752,7 +752,7 @@ func_require_term_colors ()
 
   # _G_HAVE_PLUSEQ_OP
   # Can be empty, in which case the shell is probed, "yes" if += is
-  # usable or anything else if it does not work.
+  # useable or anything else if it does not work.
   test -z "$_G_HAVE_PLUSEQ_OP" \
 && (eval 'x=a; x+=" b"; test "a b" = "$x"') 2>/dev/null \
 && _G_HAVE_PLUSEQ_OP=yes
@@ -902,7 +902,7 @@ eval 'func_dirname ()
 # to NONDIR_REPLACEMENT.
 # value returned in "$func_dirname_result"
 #   basename: Compute filename of FILE.
-# value returned in "$func_basename_result"
+# value retuned in "$func_basename_result"
 # For efficiency, we do not delegate to the functions above but instead
 # duplicate the functionality here.
 eval 'func_dirname_and_basename ()
@@ -1060,7 +1060,7 @@ func_mkdir_p ()
   # While some portion of DIR does not yet exist...
   while test ! -d "$_G_directory_path"; do
 # ...make a list in topmost first order.  Use a colon delimited
-   # list in case some portion of path contains whitespace.
+   # list incase some portion of path contains whitespace.
 _G_dir_list=$_G_directory_path:$_G_dir_list
 
 # If the last portion added has no slash in it, the list is done
@@ -5082,7 +5082,7 @@ func_get_version ()
 _G_app=$1
 
 # Rather than uncomment the sed script in-situ, strip the comments
-# programmatically before passing the result to $SED for evaluation.
+# programatically before passing the result to $SED for evaluation.
 sed_get_version=`$ECHO '# extract version within line
   s|.*[v ]\{1,\}\([0-9]\{1,\}\.[.a-z0-9-]*\).*|\1|
   t done



master updated (fd8ab0cb -> 51ac68a2)

2024-01-16 Thread Mike Frysinger
vapier pushed a change to branch master.

from fd8ab0cb Fix various typos
 new 306c759b bootstrap: revert typo fixes
 new 51ac68a2 bootstrap: sync to latest version


Summary of changes:
 bootstrap| 46 +++---
 gl-mod/bootstrap |  2 +-
 2 files changed, 24 insertions(+), 24 deletions(-)



Re: [PATCH 1/3] Fix typos

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 17:59, Mike Frysinger wrote:
> merged, but please write ChangeLog entries in the commit message

i had to revert the changes to "bootstrap" as that isn't maintained here.
you'll want to send those fixes to that upstream:
https://github.com/gnulib-modules/bootstrap
-mike


signature.asc
Description: PGP signature


Re: [PATCH 1/3] Fix typos

2024-01-16 Thread Mike Frysinger
merged, but please write ChangeLog entries in the commit message
-mike


signature.asc
Description: PGP signature


branch master updated: Fix various typos

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new fd8ab0cb Fix various typos
fd8ab0cb is described below

commit fd8ab0cbd36a154c6c27dbf22a56f3f7068ca3d6
Author: Antonin Décimo 
AuthorDate: Thu Nov 23 09:44:21 2023 +0100

Fix various typos

* NEWS: Fix various typos.
* NO-THANKS, README.md, TODO, bootstrap, bootstrap.conf,
build-aux/edit-readme-alpha, build-aux/git-log-fix, build-aux/ltmain.in,
doc/libtool.texi, libltdl/libltdl/lt_error.h, libltdl/lt__argz.c,
libltdl/ltdl.c, libtoolize.in, tests/depdemo.at, tests/link-order.at: 
Likewise.
* cfg.mk (old_NEWS_hash): Update.

Copyright-paperwork-exempt: Yes
---
 NEWS|  4 ++--
 NO-THANKS   |  2 +-
 README.md   |  2 +-
 TODO|  6 +++---
 bootstrap   | 12 ++--
 bootstrap.conf  |  4 ++--
 build-aux/edit-readme-alpha |  2 +-
 build-aux/git-log-fix   |  2 +-
 build-aux/ltmain.in |  2 +-
 cfg.mk  |  2 +-
 doc/libtool.texi|  2 +-
 libltdl/libltdl/lt_error.h  |  2 +-
 libltdl/lt__argz.c  |  2 +-
 libltdl/ltdl.c  |  4 ++--
 libtoolize.in   |  4 ++--
 tests/depdemo.at|  2 +-
 tests/link-order.at |  4 ++--
 17 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/NEWS b/NEWS
index 5c0b614e..7750430a 100644
--- a/NEWS
+++ b/NEWS
@@ -739,7 +739,7 @@ New in 1.9b: 2004-08-29; CVS version 1.5a, Libtool team:
   libraries from dlpreopened modules.
 * libtoolize installs libtool.m4, (ltdl.m4 if used,) and various supporting
   m4 definitions to AC_CONFIG_MACRO_DIR.
-* Mode inferrence removed, shorthand for choosing modes added.
+* Mode inference removed, shorthand for choosing modes added.
 * Specifying -allow-undefined is now an error.
 * Speed up max_cmd_len check.
 * libltdl can now preopen modules from within a library, and libtool will
@@ -749,7 +749,7 @@ New in 1.9b: 2004-08-29; CVS version 1.5a, Libtool team:
   by module name.
 * New function in libltdl: lt_dlpreload_open opens all preloaded modules.
 * libltdl no longer loads shared libraries with global symbol resolution,
-  this caused problems when the symbols were intended to be overriden further
+  this caused problems when the symbols were intended to be overridden further
   up the stack; it is also not recommended practice.
 * New function in libltdl: lt_dlhandle_first, primes handle iterations (using
   lt_dlhandle_next) to filter by module interface.
diff --git a/NO-THANKS b/NO-THANKS
index 288b39eb..b06cb712 100644
--- a/NO-THANKS
+++ b/NO-THANKS
@@ -65,7 +65,7 @@ Todd Vierling t...@netbsd.org
 Vincent Torri  vto...@univ-evry.fr
 ##
 ## Add bug reporters, patch Authors you forgot to attribute at commit
-## time with 'git commit --author=...' and other non-patch contributers
+## time with 'git commit --author=...' and other non-patch contributors
 ## below:
 ##
 Allan McRaeal...@archlinux.org
diff --git a/README.md b/README.md
index fa6168af..e0039cc4 100644
--- a/README.md
+++ b/README.md
@@ -199,7 +199,7 @@ send the file `tests/testsuite.log` to the [bug mailing 
list][].
   - Any prerequisites of the above (such as m4, perl, tex)
 
   Note that these bootstrapping dependencies are much stricter than
-  those required to use a destributed release for your own packages.
+  those required to use a distributed release for your own packages.
   After installation, GNU Libtool is designed to work either standalone,
   or optionally with:
   - Autoconf 2.59 or later
diff --git a/TODO b/TODO
index 2c50fece..33b53353 100644
--- a/TODO
+++ b/TODO
@@ -114,7 +114,7 @@ GNU Libtool
 
 * Need to finalize the documentation, and give a specification of
   '.la' files so that people can depend on their format.  This would be
-  a good thing to put before the maintainance notes.
+  a good thing to put before the maintenance notes.
 
 * Document the installed 'libtool' and its limitations clearly (maybe implement
   --disable-script-install as well).  Or, even better, remove its limitations.
@@ -285,7 +285,7 @@ GNU Libtool
 cygwin, or unix.  Worse, you can't really do a set of
 {msys|cygwin|unix}_to_central_unixish that isn't simply a no-op -- because
 (A) they already are all unixish, and (B) what tool would you use? How 
would
-the later to_mingw function "know" how to covert this new representation to
+the later to_mingw function "know" how to convert this new representation 
to
 mingw.  So, {msys|cygwin|unix}_to_central_unixish would simply be a no-op
 and central_unixish_to_mingw would still do all the work (with its guts
 customized based on $build).
@@ -303,7 +303,7 @@ GNU Libtool
 So...I don't think it makes much 

branch master updated: cfg.mk: update old NEWS hash

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 8c3678bb cfg.mk: update old NEWS hash
8c3678bb is described below

commit 8c3678bb284613edfd739bfecbf222ef8caf03ca
Author: Mike Frysinger 
AuthorDate: Tue Jan 16 17:50:44 2024 -0500

cfg.mk: update old NEWS hash

The recent change to change http:// to https:// updated old NEWS
entries.  This isn't exactly against the spirit of the "don't
change old NEWS", so update the hash to match.

* cfg.mk (old_NEWS_hash): Update.
---
 cfg.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index fcf43e34..8bec8813 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -31,8 +31,8 @@ update-release-year:
-e "/^Copyright/ {s:[0-9][0-9][0-9][0-9]:$$year:} " \
m4/libtool.m4
 
-# Set format of NEWS
-old_NEWS_hash := 68e21416d15e517576ce749b131f
+# Set format of NEWS.
+old_NEWS_hash := 3e6638705e1c1ac7104260815a46c7bd
 
 manual_title = Portable Dynamic Shared Object Management
 



[PATCH] cfg.mk: update old NEWS hash

2024-01-16 Thread Mike Frysinger
The recent change to change http:// to https:// updated old NEWS
entries.  This isn't exactly against the spirit of the "don't
change old NEWS", so update the hash to match.

* cfg.mk (old_NEWS_hash): Update.
---
 cfg.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index fcf43e34d142..8bec8813353b 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -31,8 +31,8 @@ update-release-year:
-e "/^Copyright/ {s:[0-9][0-9][0-9][0-9]:$$year:} " \
m4/libtool.m4
 
-# Set format of NEWS
-old_NEWS_hash := 68e21416d15e517576ce749b131f
+# Set format of NEWS.
+old_NEWS_hash := 3e6638705e1c1ac7104260815a46c7bd
 
 manual_title = Portable Dynamic Shared Object Management
 
-- 
2.43.0




[PATCH] ChangeLog.old: Convert ISO-8859-1 to UTF-8

2024-01-16 Thread Mike Frysinger
From: Antonin D??cimo 

This file is mostly UTF-8 already, but some old entries were using
ISO-8859-1.  Change them to UTF-8 entirely.

* ChangeLog.old: Change ISO-8859-1 to UTF-8.

Copyright-paperwork-exempt: Yes
---
 ChangeLog.old | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ChangeLog.old b/ChangeLog.old
index 8e2b51caad46..bb84e8047d0b 100644
--- a/ChangeLog.old
+++ b/ChangeLog.old
@@ -15551,7 +15551,7 @@
 
* libltdl/ltdl.c (foreach_dirinpath): Ensure that filename is '\0'
terminated by all code paths.
-   Reported by Lutz M?ller 
+   Reported by Lutz M??ller 
 
 2002-06-20  Gary V. Vaughan  
 
@@ -18669,7 +18669,7 @@
  and file_magic_cmd
 
* README: use 'libtool --version' instead of 'ltconfig --version'
- (suggested by Francios Pinard 
+ (suggested by Fran??ois Pinard 
 
 2000-01-10  Gary V. Vaughan  
 
@@ -19442,7 +19442,7 @@
 
* ltconfig.in: Support new GNU ld --help output format.
* NEWS:  Likewise.
-   Reported by Ga?l Qu?ri  and
+   Reported by Ga??l Qu??ri  and
H.J. Lu .
 
 1999-06-05  Mark Kettenis  
@@ -23515,7 +23515,7 @@ Thu May 28 18:59:08 1998  Ian Lance Taylor  

ld's.  From Eiichi Takamori.
 
* ltmain.in (install): Don't print silly `library stripping'
-   warnings.  Reported by Fran?ois Pinard.
+   warnings.  Reported by Fran??ois Pinard.
 
 1997-12-19  Gordon Matzigkeit  
 
@@ -23650,7 +23650,7 @@ Thu May 28 18:59:08 1998  Ian Lance Taylor  

because we need it for quoting substitutions.  For most of the
script, though, use the default echo, just like Autoconf does.
Without this patch, character \001 ends up in global_symbol_pipe.
-   Reported by Lars Hecking and J?rgen Fluk.
+   Reported by Lars Hecking and J??rgen Fluk.
 
* ltmain.in (echo): Set default to `echo=echo'.  Ooops.  That's
what you get for testing obscure code paths and forgetting to
-- 
2.43.0




branch master updated: ChangeLog.old: Convert ISO-8859-1 to UTF-8

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 8fa76f16 ChangeLog.old: Convert ISO-8859-1 to UTF-8
8fa76f16 is described below

commit 8fa76f168edbdfa2bc758bf6fd0bc5c1ab71c32e
Author: Antonin Décimo 
AuthorDate: Thu Nov 23 09:44:22 2023 +0100

ChangeLog.old: Convert ISO-8859-1 to UTF-8

This file is mostly UTF-8 already, but some old entries were using
ISO-8859-1.  Change them to UTF-8 entirely.

* ChangeLog.old: Change ISO-8859-1 to UTF-8.

Copyright-paperwork-exempt: Yes
---
 ChangeLog.old | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ChangeLog.old b/ChangeLog.old
index 8e2b51ca..bb84e804 100644
--- a/ChangeLog.old
+++ b/ChangeLog.old
@@ -15551,7 +15551,7 @@
 
* libltdl/ltdl.c (foreach_dirinpath): Ensure that filename is '\0'
terminated by all code paths.
-   Reported by Lutz M�ller 
+   Reported by Lutz Müller 
 
 2002-06-20  Gary V. Vaughan  
 
@@ -18669,7 +18669,7 @@
  and file_magic_cmd
 
* README: use 'libtool --version' instead of 'ltconfig --version'
- (suggested by Francios Pinard 
+ (suggested by François Pinard 
 
 2000-01-10  Gary V. Vaughan  
 
@@ -19442,7 +19442,7 @@
 
* ltconfig.in: Support new GNU ld --help output format.
* NEWS:  Likewise.
-   Reported by Ga�l Qu�ri  and
+   Reported by Gaël Quéri  and
H.J. Lu .
 
 1999-06-05  Mark Kettenis  
@@ -23515,7 +23515,7 @@ Thu May 28 18:59:08 1998  Ian Lance Taylor  

ld's.  From Eiichi Takamori.
 
* ltmain.in (install): Don't print silly `library stripping'
-   warnings.  Reported by Fran�ois Pinard.
+   warnings.  Reported by François Pinard.
 
 1997-12-19  Gordon Matzigkeit  
 
@@ -23650,7 +23650,7 @@ Thu May 28 18:59:08 1998  Ian Lance Taylor  

because we need it for quoting substitutions.  For most of the
script, though, use the default echo, just like Autoconf does.
Without this patch, character \001 ends up in global_symbol_pipe.
-   Reported by Lars Hecking and J�rgen Fluk.
+   Reported by Lars Hecking and Jürgen Fluk.
 
* ltmain.in (echo): Set default to `echo=echo'.  Ooops.  That's
what you get for testing obscure code paths and forgetting to



[PATCH] use https:// with more gnu.org sites

2024-01-16 Thread Mike Frysinger
* NEWS: Change http:// to https:// for some URIs.
* bootstrap.conf, build-aux/ltmain.in, configure.ac, libtoolize.in: Likewise.
---
 NEWS| 2 +-
 bootstrap.conf  | 8 
 build-aux/ltmain.in | 2 +-
 configure.ac| 2 +-
 libtoolize.in   | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/NEWS b/NEWS
index 39a35e605488..5c0b614e6d55 100644
--- a/NEWS
+++ b/NEWS
@@ -1069,7 +1069,7 @@ New in 1.2d: 1998-12-16; CVS version 1.2c, Libtool team:
 * We now have anonymous CVS access to GNU libtool.  CVSROOT is
   :pserver:anon...@anoncvs.gnu.org:/gd/gnu/anoncvsroot.  The password
   is empty.  The directory is libtool.  Check our home-page at
-  http://www.gnu.org/software/libtool/libtool.html for details.
+  https://www.gnu.org/software/libtool/libtool.html for details.
 * Alexandre Oliva, Thomas Tanner and Gary V. Vaughan have taken over
   the maintenance of libtool.
 * Arguments to ltconfig have been changed to allow creation of a
diff --git a/bootstrap.conf b/bootstrap.conf
index 68295f640e90..bc91a67f8096 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -44,10 +44,10 @@ checkout_only_file=HACKING
 # List of programs (and minimum versions) required to bootstrap, maintain
 # and release Libtool.
 buildreq="
-help2man   1.29http://www.gnu.org/s/help2man
-make   3.81http://www.gnu.org/s/make
-makeinfo   4.8 http://www.gnu.org/s/texinfo
-xz 4.999.8beta http://tukaani.org/xz
+help2man   1.29https://www.gnu.org/s/help2man
+make   3.81https://www.gnu.org/s/make
+makeinfo   4.8 https://www.gnu.org/s/texinfo
+xz 4.999.8beta https://tukaani.org/xz
 "
 
 # Instructions on how to install packages in $buildreq.
diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index d996f7986993..f2cede828049 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -162,7 +162,7 @@ include the following information:
 
 Report bugs to <@PACKAGE_BUGREPORT@>.
 GNU @PACKAGE@ home page: <@PACKAGE_URL@>.
-General help using GNU software: ."
+General help using GNU software: ."
 exit 0
 }
 
diff --git a/configure.ac b/configure.ac
index cc8113154d54..9aef55d3712e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -35,7 +35,7 @@ AC_INIT([GNU Libtool],
m4_esyscmd([build-aux/git-version-gen .tarball-version]),
[bug-libt...@gnu.org])
 m4_ifndef([AC_PACKAGE_URL],
- [AC_SUBST([PACKAGE_URL], [http://www.gnu.org/s/libtool/])])
+ [AC_SUBST([PACKAGE_URL], [https://www.gnu.org/s/libtool/])])
 
 # Remove this when a released Autoconf is capable of bootstrapping
 # Libtool without it (probably after autoconf-2.70).
diff --git a/libtoolize.in b/libtoolize.in
index ecdf07f8af63..4c0c6cfbcf81 100644
--- a/libtoolize.in
+++ b/libtoolize.in
@@ -125,7 +125,7 @@ include the following information:
 
 Report bugs to <@PACKAGE_BUGREPORT@>.
 GNU @PACKAGE@ home page: <@PACKAGE_URL@>.
-General help using GNU software: ."
+General help using GNU software: ."
 exit 0
 }
 
-- 
2.43.0




branch master updated: use https:// with more gnu.org sites

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 003520d3 use https:// with more gnu.org sites
003520d3 is described below

commit 003520d34658e31af6b851c02125ea06a29fb46c
Author: Mike Frysinger 
AuthorDate: Tue Jan 16 15:46:12 2024 -0500

use https:// with more gnu.org sites

* NEWS: Change http:// to https:// for some URIs.
* bootstrap.conf, build-aux/ltmain.in, configure.ac, libtoolize.in: 
Likewise.
---
 NEWS| 2 +-
 bootstrap.conf  | 8 
 build-aux/ltmain.in | 2 +-
 configure.ac| 2 +-
 libtoolize.in   | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/NEWS b/NEWS
index 39a35e60..5c0b614e 100644
--- a/NEWS
+++ b/NEWS
@@ -1069,7 +1069,7 @@ New in 1.2d: 1998-12-16; CVS version 1.2c, Libtool team:
 * We now have anonymous CVS access to GNU libtool.  CVSROOT is
   :pserver:anon...@anoncvs.gnu.org:/gd/gnu/anoncvsroot.  The password
   is empty.  The directory is libtool.  Check our home-page at
-  http://www.gnu.org/software/libtool/libtool.html for details.
+  https://www.gnu.org/software/libtool/libtool.html for details.
 * Alexandre Oliva, Thomas Tanner and Gary V. Vaughan have taken over
   the maintenance of libtool.
 * Arguments to ltconfig have been changed to allow creation of a
diff --git a/bootstrap.conf b/bootstrap.conf
index 68295f64..bc91a67f 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -44,10 +44,10 @@ checkout_only_file=HACKING
 # List of programs (and minimum versions) required to bootstrap, maintain
 # and release Libtool.
 buildreq="
-help2man   1.29http://www.gnu.org/s/help2man
-make   3.81http://www.gnu.org/s/make
-makeinfo   4.8 http://www.gnu.org/s/texinfo
-xz 4.999.8beta http://tukaani.org/xz
+help2man   1.29https://www.gnu.org/s/help2man
+make   3.81https://www.gnu.org/s/make
+makeinfo   4.8 https://www.gnu.org/s/texinfo
+xz 4.999.8beta https://tukaani.org/xz
 "
 
 # Instructions on how to install packages in $buildreq.
diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index d996f798..f2cede82 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -162,7 +162,7 @@ include the following information:
 
 Report bugs to <@PACKAGE_BUGREPORT@>.
 GNU @PACKAGE@ home page: <@PACKAGE_URL@>.
-General help using GNU software: <http://www.gnu.org/gethelp/>."
+General help using GNU software: <https://www.gnu.org/gethelp/>."
 exit 0
 }
 
diff --git a/configure.ac b/configure.ac
index cc811315..9aef55d3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -35,7 +35,7 @@ AC_INIT([GNU Libtool],
m4_esyscmd([build-aux/git-version-gen .tarball-version]),
[bug-libt...@gnu.org])
 m4_ifndef([AC_PACKAGE_URL],
- [AC_SUBST([PACKAGE_URL], [http://www.gnu.org/s/libtool/])])
+ [AC_SUBST([PACKAGE_URL], [https://www.gnu.org/s/libtool/])])
 
 # Remove this when a released Autoconf is capable of bootstrapping
 # Libtool without it (probably after autoconf-2.70).
diff --git a/libtoolize.in b/libtoolize.in
index ecdf07f8..4c0c6cfb 100644
--- a/libtoolize.in
+++ b/libtoolize.in
@@ -125,7 +125,7 @@ include the following information:
 
 Report bugs to <@PACKAGE_BUGREPORT@>.
 GNU @PACKAGE@ home page: <@PACKAGE_URL@>.
-General help using GNU software: <http://www.gnu.org/gethelp/>."
+General help using GNU software: <https://www.gnu.org/gethelp/>."
 exit 0
 }
 



Re: Introducing a new maintainer of libtool

2024-01-16 Thread Mike Frysinger
On 13 Jan 2024 14:49, Ileana Dumitrescu wrote:
> My short term plans are to review the numerous mailing list patches and 
> get them merged in. This will be an easy and productive first step for 
> me and libtool. I will also look at the various distro patches and see 
> if any of them are fit to be upstreamed as I have noticed some of the 
> distros have been accruing a lot of patches as well.

i think we should aim to kick out something new sooner rather than later.
so aim to include smaller/less risky changes as it's been ~2 years since
the last release.  i don't mean this in terms of rushing you, but more
"better to cut off sooner" than "try to merge everything that should be
merged, but end up taking much longer in the process".  we can always
make another release if we really want something out there.  especially
as "this patch is so simple" can be very deceptive with libtool.
-mike


signature.asc
Description: PGP signature


[sr #110978] libtool.m4: Not respecting $LD when checking for --whole-archive

2024-01-16 Thread Mike Frysinger
Update of sr#110978 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

merged now, thanks
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=f81f36e4e9f9e4e5a8b827dd831393d5867b244f


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




branch master updated: libtool: Use $LD when checking for --whole-archive

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new f81f36e4 libtool: Use $LD when checking for --whole-archive
f81f36e4 is described below

commit f81f36e4e9f9e4e5a8b827dd831393d5867b244f
Author: Raul E Rangel 
AuthorDate: Wed Dec 13 09:44:57 2023 -0700

libtool: Use $LD when checking for --whole-archive

Using `$CC -print-prog-name=ld` will always use the `ld` linker. We
should instead be using the $LD variable so that we use the proper
linker.

There is already another part of the code that does this same check,
so I just copy/pasted the if line.

* m4/libtool.m4: Change `$CC -print-prog-name=ld` to $LD.

Url: https://savannah.gnu.org/support/?110978
Signed-off-by: Raul E Rangel 
---
 m4/libtool.m4 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 83c33d35..4b84ce96 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -6427,8 +6427,7 @@ if test yes != "$_lt_caught_CXX_error"; then
 wlarc='$wl'
 
 # ancient GNU ld didn't support --whole-archive et. al.
-if eval "`$CC -print-prog-name=ld` --help 2>&1" |
- $GREP 'no-whole-archive' > /dev/null; then
+if $LD --help 2>&1 | $GREP 'no-whole-archive' > /dev/null; then
   _LT_TAGVAR(whole_archive_flag_spec, 
$1)=$wlarc'--whole-archive$convenience '$wlarc'--no-whole-archive'
 else
   _LT_TAGVAR(whole_archive_flag_spec, $1)=



Re: [PATCH] libtool: remove bitrig support.

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 01:49, Brad Smith wrote:
> libtool: remove bitrig support.
> 
> Bitrig has been defunct for 7 years.

pushed, thanks
-mike


signature.asc
Description: PGP signature


branch master updated: libtool: remove bitrig support.

2024-01-16 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 5a7193db libtool: remove bitrig support.
5a7193db is described below

commit 5a7193dbfb8c90e1b1306a360a1b0c80ef8c4de0
Author: Brad Smith 
AuthorDate: Tue Jan 16 01:49:20 2024 -0500

libtool: remove bitrig support.

Bitrig has been defunct for 7 years.

* build-aux/ltmain.in (func_mode_link): Remove bitrig support.
* m4/libtool.m4 (_LT_CMD_OLD_ARCHIVE, LT_CMD_MAX_LEN)
(_LT_SYS_DYNAMIC_LINKER, _LT_CHECK_MAGIC_METHOD)
(_LT_LINKER_SHLIBS, _LT_LANG_CXX_CONFIG): Ditto.
* m4/ltdl.m4 (LT_SYS_DLOPEN_DEPLIBS): Ditto.
* NEWS: Updated.
---
 NEWS|  3 +++
 build-aux/ltmain.in |  4 ++--
 m4/libtool.m4   | 14 +++---
 m4/ltdl.m4  |  3 ---
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/NEWS b/NEWS
index 93ade4df..39a35e60 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,9 @@ NEWS - list of user-visible changes between releases of GNU 
Libtool
 
 * Noteworthy changes in release ?.? (-??-??) [?]
 
+** Changes in supported systems or compilers:
+
+  - Removed support for bitrig (*-*-bitrig*).
 
 * Noteworthy changes in release 2.4.7 (2022-03-16) [stable]
 
diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index d5157a8d..d996f798 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -5134,7 +5134,7 @@ func_mode_link ()
# These systems don't actually have a C library (as such)
test X-lc = "X$arg" && continue
;;
- *-*-openbsd* | *-*-freebsd* | *-*-dragonfly* | *-*-bitrig* | 
*-*-midnightbsd*)
+ *-*-openbsd* | *-*-freebsd* | *-*-dragonfly* | *-*-midnightbsd*)
# Do not include libc due to us having libc/libc_r.
test X-lc = "X$arg" && continue
;;
@@ -5154,7 +5154,7 @@ func_mode_link ()
  esac
elif test X-lc_r = "X$arg"; then
 case $host in
-*-*-openbsd* | *-*-freebsd* | *-*-dragonfly* | *-*-bitrig* | 
*-*-midnightbsd*)
+*-*-openbsd* | *-*-freebsd* | *-*-dragonfly* | *-*-midnightbsd*)
   # Do not include libc_r directly, use -pthread flag.
   continue
   ;;
diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 64df9b55..83c33d35 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1556,7 +1556,7 @@ old_postuninstall_cmds=
 
 if test -n "$RANLIB"; then
   case $host_os in
-  bitrig* | openbsd*)
+  openbsd*)
 old_postinstall_cmds="$old_postinstall_cmds~\$RANLIB -t \$tool_oldlib"
 ;;
   *)
@@ -1724,7 +1724,7 @@ AC_CACHE_VAL([lt_cv_sys_max_cmd_len], [dnl
 lt_cv_sys_max_cmd_len=8192;
 ;;
 
-  bitrig* | darwin* | dragonfly* | freebsd* | midnightbsd* | netbsd* | 
openbsd*)
+  darwin* | dragonfly* | freebsd* | midnightbsd* | netbsd* | openbsd*)
 # This has been around since 386BSD, at least.  Likely further.
 if test -x /sbin/sysctl; then
   lt_cv_sys_max_cmd_len=`/sbin/sysctl -n kern.argmax`
@@ -2944,7 +2944,7 @@ newsos6)
   dynamic_linker='ldqnx.so'
   ;;
 
-openbsd* | bitrig*)
+openbsd*)
   version_type=sunos
   sys_lib_dlsearch_path_spec=/usr/lib
   need_lib_prefix=no
@@ -3584,7 +3584,7 @@ newos6*)
   lt_cv_deplibs_check_method=pass_all
   ;;
 
-openbsd* | bitrig*)
+openbsd*)
   if test -z "`echo __ELF__ | $CC -E - | $GREP __ELF__`"; then
 lt_cv_deplibs_check_method='match_pattern 
/lib[[^/]]+(\.so\.[[0-9]]+\.[[0-9]]+|\.so|_pic\.a)$'
   else
@@ -5021,7 +5021,7 @@ dnl Note also adjust exclude_expsyms for C++ above.
 # we just hope/assume this is gcc and not c89 (= MSVC++ or ICC)
 with_gnu_ld=yes
 ;;
-  openbsd* | bitrig*)
+  openbsd*)
 with_gnu_ld=no
 ;;
   esac
@@ -5843,7 +5843,7 @@ _LT_EOF
 *nto* | *qnx*)
   ;;
 
-openbsd* | bitrig*)
+openbsd*)
   if test -f /usr/libexec/ld.so; then
_LT_TAGVAR(hardcode_direct, $1)=yes
_LT_TAGVAR(hardcode_shlibpath_var, $1)=no
@@ -7137,7 +7137,7 @@ if test yes != "$_lt_caught_CXX_error"; then
 _LT_TAGVAR(ld_shlibs, $1)=yes
;;
 
-  openbsd* | bitrig*)
+  openbsd*)
if test -f /usr/libexec/ld.so; then
  _LT_TAGVAR(hardcode_direct, $1)=yes
  _LT_TAGVAR(hardcode_shlibpath_var, $1)=no
diff --git a/m4/ltdl.m4 b/m4/ltdl.m4
index f631a00c..0c43799c 100644
--- a/m4/ltdl.m4
+++ b/m4/ltdl.m4
@@ -466,9 +466,6 @@ AC_CACHE_CHECK([whether deplibs are loaded by dlopen],
   ;;
 esac
 ;;
-  bitrig*)
-lt_cv_sys_dlopen_deplibs=yes
-;;
   darwin*)
 # Assuming the user has installed a libdl from somewhere, this is true
 # If you are looking for one http://www.opendarwin.org/projects/dlcompat



Re: [PATCH 05/12] ltmain.in: Don't encode RATHS which match default linker paths

2024-01-15 Thread Mike Frysinger
On 25 Oct 2021 15:33, Richard Purdie wrote:
> We don't want to add RPATHS which match default linker search paths, they're
> a waste of space. This patch filters libtools list of paths to encoode and
> removes the ones we don't need.

how are you defining "linker" ?  are you talking about the runtime linker
(i.e. ld.so) or the build time linker (i.e. `ld`) ?

the commit message also doesn't really explain in concrete details the
scenario you're running into.
-mike


signature.asc
Description: PGP signature


Re: [PATCH 02/12] libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils

2024-01-15 Thread Mike Frysinger
On 25 Oct 2021 15:33, Richard Purdie wrote:
> This patch renames the --with-sysroot option to --with-libtool-sysroot
> to avoid namespace conflict with binutils, gcc and other toolchain
> components since these componets also add that option to configure
> and this becomes confusing and conflicting otherwise.

we're talking like 3 projects ?  libtool is used & included in way more
projects than that.  it seems like --with-sysroot as a standard name to
propagate out into the wider ecosystem makes more sense.

i agree there's confusion between "use this path as a sysroot to compile
and link against" and "have the compile tools target this sysroot".  the
same problem exists with host selection which is why we have the build,
host, and target options.  sounds like we want names that can align with
these somehow.

--with-libtool-sysroot doesn't make sense as it isn't an internal libtool
setting, it's changing how executables are linked, and users (who run the
configure scripts) don't know or care about this "libtool" thing.
-mike


signature.asc
Description: PGP signature


Re: [PATCH 06/12] libtool.m4: Handle "/" as a sysroot correctly

2024-01-15 Thread Mike Frysinger
On 25 Oct 2021 15:33, Richard Purdie wrote:
> Update libtool.m4 to resolve a problem with lt_sysroot not being properly
> updated if the option '--with[-libtool]-sysroot' is not provided when
> running the 'configure' script for a package so that "/" as a sysroot
> is handled correctly by libtool.

this is a long sentence, and there's no concrete examples, so i'm having a
bit of trouble extrapolating the bug.  can you tweak this a bit to make it
more clear ?
-mike


signature.asc
Description: PGP signature


Re: [PATCH 11/12] ltmain.in: Handle prefix-map compiler options correctly

2024-01-15 Thread Mike Frysinger
On 25 Oct 2021 15:33, Richard Purdie wrote:
> +  # -f*-prefix-map*  needed for lto linking

what flags are you trying to actually match here ?  excessive globs
make it more likely to match flags we don't want.
-mike


signature.asc
Description: PGP signature


Re: [PATCH 00/12] Yocto Project libtool patch queue

2024-01-15 Thread Mike Frysinger
there's a bunch of changes in here, but no additional test coverage

also the project still requires ChangeLog entries in the commit message,
so can you please add those so we don't have to write them for you ?  if
you look at commit history, the format should hopefully be obvious.
-mike


signature.asc
Description: PGP signature


Re: [PATCH 07/12] libtool: Fix support for NIOS2 processor

2024-01-15 Thread Mike Frysinger
On 25 Oct 2021 15:33, Richard Purdie wrote:
> The name of the system contains the string "nios2". This string
> is caught by the some of the greedy checks for OS/2 in libtool,
> in particular the *os2* branches of switch statements match for
> the nios2 string, which results in incorrect behavior of libtool.
> 
> This patch adds an explicit check for *nios2* before the *os2*
> checks to prevent the OS/2 check incorrectly trapping the nios2
> as well.

i don't think this is the right approach.  this is adding another substring
search across the entire space (cpu/vendor/os).  we should fix the search so
it uses the right value only to match against.

> --- a/build-aux/ltmain.in
> +++ b/build-aux/ltmain.in
>
>  case $host in
> +  # For NIOS2, we want to make sure that it's not caught by the
> +  # more general OS/2 check below. Otherwise, NIOS2 is the same
> +  # as the default option.
> +  *nios2*)
> +opt_duplicate_compiler_generated_deps=$opt_preserve_dup_deps
> +;;
># Solaris2 added to fix 
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16452
># see also: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59788
>*cygwin* | *mingw* | *pw32* | *cegcc* | *solaris2* | *os2*)

these should only match $host_os, and remove the leading glob at the same time.
same for the other changes in this patch.
-mike


signature.asc
Description: PGP signature


Re: [PATCH 1/2] libtool: replace : with $PATH_SEPARATOR

2024-01-15 Thread Mike Frysinger
On 15 Jan 2024 21:15, KO Myung-Hun wrote:
> Mike Frysinger wrote:
> > On 15 Oct 2023 02:04, KO Myung-Hun wrote:
> >> Some OSes such as OS/2, uses ';' as a path separator. So using 
> >> $PATH_SEPARATOR instead of hard-coded ':' is more proper.
> >> 
> >> * build-aux-ltmain.in: replace : with $PATH_SEPARATOR. *
> >> m4/libtool.m4: Likewise.
> > 
> > this doesn't work for me
> > 
> > 544675d6b538 2024-01-14 18:06:03 -0500 gnulib: update submodule to
> > current versions
> > 
> > $ ./bootstrap $ ./configure ... checking for mt... no checking if :
> > is a manifest tool... no ./configure: 1: Syntax error: Unterminated
> > quoted string $ -mike
> 
> How about this?

it passes configure, but fails `make check` & `make syntax-check`.
-mike


signature.asc
Description: PGP signature


Re: [PATCH 1/2] libtool: replace : with $PATH_SEPARATOR

2024-01-14 Thread Mike Frysinger
On 15 Oct 2023 02:04, KO Myung-Hun wrote:
> Some OSes such as OS/2, uses ';' as a path separator. So using
> $PATH_SEPARATOR instead of hard-coded ':' is more proper.
> 
> * build-aux-ltmain.in: replace : with $PATH_SEPARATOR.
> * m4/libtool.m4: Likewise.

this doesn't work for me

544675d6b538 2024-01-14 18:06:03 -0500 gnulib: update submodule to current 
versions

$ ./bootstrap
$ ./configure
...
checking for mt... no
checking if : is a manifest tool... no
./configure: 1: Syntax error: Unterminated quoted string
$
-mike


signature.asc
Description: PGP signature


[PATCH 2/2] libltdl: unify get_vtable boilerplate

2024-01-14 Thread Mike Frysinger
These files all define get_vtable the same way, so create a single
header file to hold it.  This would fix desync problems like we had
with some defining the return value as const, and it'll make it a
bit easier to workaround GNU indent issues related to the defines.

* Makefile.am (pkgltdl_files): Add lt_vtable.h.
* libltdl/ltdl.mk (libltdl_libltdl_la_SOURCES): Likewise.
* libtoolize.in (all_pkgltdl_files): Likewise.
* libltdl/loaders/dld_link.c: Replace get_vtable prototype with lt_vtable.h
include.
* libltdl/loaders/dlopen.c, libltdl/loaders/dyld.c,
libltdl/loaders/load_add_on.c, libltdl/loaders/loadlibrary.c,
libltdl/loaders/preopen.c, libltdl/loaders/shl_load.c, libltdl/ltdl.c: Likewise.
* libltdl/lt_vtable.h: New file.
---
 Makefile.am   |  1 +
 libltdl/loaders/dld_link.c|  5 +---
 libltdl/loaders/dlopen.c  |  5 +---
 libltdl/loaders/dyld.c|  5 +---
 libltdl/loaders/load_add_on.c |  5 +---
 libltdl/loaders/loadlibrary.c |  5 +---
 libltdl/loaders/preopen.c |  5 +---
 libltdl/loaders/shl_load.c|  5 +---
 libltdl/lt_vtable.h   | 44 +++
 libltdl/ltdl.c|  4 +---
 libltdl/ltdl.mk   |  1 +
 libtoolize.in |  2 +-
 12 files changed, 55 insertions(+), 32 deletions(-)
 create mode 100644 libltdl/lt_vtable.h

diff --git a/Makefile.am b/Makefile.am
index 904f3d73fc89..34384c5acf26 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -479,6 +479,7 @@ pkgltdl_files   = COPYING.LIB \
  lt__strl.c \
  lt_dlloader.c \
  lt_error.c \
+ lt_vtable.h \
  ltdl.c \
  ltdl.h \
  ltdl.mk \
diff --git a/libltdl/loaders/dld_link.c b/libltdl/loaders/dld_link.c
index 9dc220d96c07..7e7541c7338d 100644
--- a/libltdl/loaders/dld_link.c
+++ b/libltdl/loaders/dld_link.c
@@ -37,10 +37,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
Use the "_LTX_" prefix so that the symbol addresses can
be fetched from the preloaded symbol list by lt_dlsym():  */
 #define get_vtable dld_link_LTX_get_vtable
-
-LT_BEGIN_C_DECLS
-LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
-LT_END_C_DECLS
+#include "lt_vtable.h"
 
 
 /* Boilerplate code to set up the vtable for hooking this loader into
diff --git a/libltdl/loaders/dlopen.c b/libltdl/loaders/dlopen.c
index 5ec46b7f126b..c8c03bf42e25 100644
--- a/libltdl/loaders/dlopen.c
+++ b/libltdl/loaders/dlopen.c
@@ -37,10 +37,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
Use the "_LTX_" prefix so that the symbol addresses can
be fetched from the preloaded symbol list by lt_dlsym():  */
 #define get_vtable dlopen_LTX_get_vtable
-
-LT_BEGIN_C_DECLS
-LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
-LT_END_C_DECLS
+#include "lt_vtable.h"
 
 
 /* Boilerplate code to set up the vtable for hooking this loader into
diff --git a/libltdl/loaders/dyld.c b/libltdl/loaders/dyld.c
index 2c62c6fb0642..bfd35b24c590 100644
--- a/libltdl/loaders/dyld.c
+++ b/libltdl/loaders/dyld.c
@@ -37,10 +37,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
Use the "_LTX_" prefix so that the symbol addresses can
be fetched from the preloaded symbol list by lt_dlsym():  */
 #define get_vtable dyld_LTX_get_vtable
-
-LT_BEGIN_C_DECLS
-LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
-LT_END_C_DECLS
+#include "lt_vtable.h"
 
 
 /* Boilerplate code to set up the vtable for hooking this loader into
diff --git a/libltdl/loaders/load_add_on.c b/libltdl/loaders/load_add_on.c
index 513daa4c147a..6b07cd521e22 100644
--- a/libltdl/loaders/load_add_on.c
+++ b/libltdl/loaders/load_add_on.c
@@ -37,10 +37,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
Use the "_LTX_" prefix so that the symbol addresses can
be fetched from the preloaded symbol list by lt_dlsym():  */
 #define get_vtable load_add_on_LTX_get_vtable
-
-LT_BEGIN_C_DECLS
-LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
-LT_END_C_DECLS
+#include "lt_vtable.h"
 
 
 /* Boilerplate code to set up the vtable for hooking this loader into
diff --git a/libltdl/loaders/loadlibrary.c b/libltdl/loaders/loadlibrary.c
index 10e44490548a..d8995eb5f2bc 100644
--- a/libltdl/loaders/loadlibrary.c
+++ b/libltdl/loaders/loadlibrary.c
@@ -41,10 +41,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
Use the "_LTX_" prefix so that the symbol addresses can
be fetched from the preloaded symbol list by lt_dlsym():  */
 #define get_vtable loadlibrary_LTX_get_vtable
-
-LT_BEGIN_C_DECLS
-LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
-LT_END_C_DECLS
+#include "lt_vtable.h"
 
 
 /* Boilerplate code to set up the vtable for hooking this loader into
diff --git a/libltdl/loaders/preopen.c b/libltdl/loaders/preopen.c
index e5440d3e07ac..4f61c03b3bda 100644

[PATCH 1/2] libltdl: constify get_vtable in loaders

2024-01-14 Thread Mike Frysinger
The lt_dlloader.h API already says these have const return values, and
the main ltdl.c module defines its get_vtable in that way, so update all
of the loaders to match.

* libltdl/loaders/dld_link.c (get_vtable): Add const.
* libltdl/loaders/dlopen.c, libltdl/loaders/dyld.c,
libltdl/loaders/load_add_on.c, libltdl/loaders/loadlibrary.c,
libltdl/loaders/preopen.c, libltdl/loaders/shl_load.c: Likewise.
---
 libltdl/loaders/dld_link.c| 4 ++--
 libltdl/loaders/dlopen.c  | 4 ++--
 libltdl/loaders/dyld.c| 4 ++--
 libltdl/loaders/load_add_on.c | 4 ++--
 libltdl/loaders/loadlibrary.c | 4 ++--
 libltdl/loaders/preopen.c | 4 ++--
 libltdl/loaders/shl_load.c| 4 ++--
 7 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/libltdl/loaders/dld_link.c b/libltdl/loaders/dld_link.c
index 3a9f345e53ae..9dc220d96c07 100644
--- a/libltdl/loaders/dld_link.c
+++ b/libltdl/loaders/dld_link.c
@@ -39,7 +39,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
 #define get_vtable dld_link_LTX_get_vtable
 
 LT_BEGIN_C_DECLS
-LT_SCOPE lt_dlvtable *get_vtable (lt_user_data loader_data);
+LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
 LT_END_C_DECLS
 
 
@@ -57,7 +57,7 @@ static lt_dlvtable *vtable = 0;
 /* Return the vtable for this loader, only the name and sym_prefix
attributes (plus the virtual function implementations, obviously)
change between loaders.  */
-lt_dlvtable *
+const lt_dlvtable *
 get_vtable (lt_user_data loader_data)
 {
   if (!vtable)
diff --git a/libltdl/loaders/dlopen.c b/libltdl/loaders/dlopen.c
index 66a129c9a472..5ec46b7f126b 100644
--- a/libltdl/loaders/dlopen.c
+++ b/libltdl/loaders/dlopen.c
@@ -39,7 +39,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
 #define get_vtable dlopen_LTX_get_vtable
 
 LT_BEGIN_C_DECLS
-LT_SCOPE lt_dlvtable *get_vtable (lt_user_data loader_data);
+LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
 LT_END_C_DECLS
 
 
@@ -57,7 +57,7 @@ static lt_dlvtable *vtable = 0;
 /* Return the vtable for this loader, only the name and sym_prefix
attributes (plus the virtual function implementations, obviously)
change between loaders.  */
-lt_dlvtable *
+const lt_dlvtable *
 get_vtable (lt_user_data loader_data)
 {
   if (!vtable)
diff --git a/libltdl/loaders/dyld.c b/libltdl/loaders/dyld.c
index 3889b6aa57a0..2c62c6fb0642 100644
--- a/libltdl/loaders/dyld.c
+++ b/libltdl/loaders/dyld.c
@@ -39,7 +39,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
 #define get_vtable dyld_LTX_get_vtable
 
 LT_BEGIN_C_DECLS
-LT_SCOPE lt_dlvtable *get_vtable (lt_user_data loader_data);
+LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
 LT_END_C_DECLS
 
 
@@ -58,7 +58,7 @@ static lt_dlvtable *vtable = 0;
 /* Return the vtable for this loader, only the name and sym_prefix
attributes (plus the virtual function implementations, obviously)
change between loaders.  */
-lt_dlvtable *
+const lt_dlvtable *
 get_vtable (lt_user_data loader_data)
 {
   if (!vtable)
diff --git a/libltdl/loaders/load_add_on.c b/libltdl/loaders/load_add_on.c
index 97b4fcb689c0..513daa4c147a 100644
--- a/libltdl/loaders/load_add_on.c
+++ b/libltdl/loaders/load_add_on.c
@@ -39,7 +39,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
 #define get_vtable load_add_on_LTX_get_vtable
 
 LT_BEGIN_C_DECLS
-LT_SCOPE lt_dlvtable *get_vtable (lt_user_data loader_data);
+LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
 LT_END_C_DECLS
 
 
@@ -57,7 +57,7 @@ static lt_dlvtable *vtable = 0;
 /* Return the vtable for this loader, only the name and sym_prefix
attributes (plus the virtual function implementations, obviously)
change between loaders.  */
-lt_dlvtable *
+const lt_dlvtable *
 get_vtable (lt_user_data loader_data)
 {
   if (!vtable)
diff --git a/libltdl/loaders/loadlibrary.c b/libltdl/loaders/loadlibrary.c
index 13fd2fb9c72c..10e44490548a 100644
--- a/libltdl/loaders/loadlibrary.c
+++ b/libltdl/loaders/loadlibrary.c
@@ -43,7 +43,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
 #define get_vtable loadlibrary_LTX_get_vtable
 
 LT_BEGIN_C_DECLS
-LT_SCOPE lt_dlvtable *get_vtable (lt_user_data loader_data);
+LT_SCOPE const lt_dlvtable *get_vtable (lt_user_data loader_data);
 LT_END_C_DECLS
 
 
@@ -62,7 +62,7 @@ static lt_dlvtable *vtable = 0;
 /* Return the vtable for this loader, only the name and sym_prefix
attributes (plus the virtual function implementations, obviously)
change between loaders.  */
-lt_dlvtable *
+const lt_dlvtable *
 get_vtable (lt_user_data loader_data)
 {
   if (!vtable)
diff --git a/libltdl/loaders/preopen.c b/libltdl/loaders/preopen.c
index f1ed0aa3e306..e5440d3e07ac 100644
--- a/libltdl/loaders/preopen.c
+++ b/libltdl/loaders/preopen.c
@@ -39,7 +39,7 @@ or obtained by writing to the Free Software Foundation, Inc.,
 #define get_vtable preopen_LTX_get_vtable
 
 LT_BEGIN_C_DECLS

branch master updated: gnulib: update submodule to current versions

2024-01-14 Thread Mike Frysinger
This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository libtool.

The following commit(s) were added to refs/heads/master by this push:
 new 544675d6 gnulib: update submodule to current versions
544675d6 is described below

commit 544675d6b538eed9804a230d5674338c95f47395
Author: Mike Frysinger 
AuthorDate: Sun Jan 14 18:06:03 2024 -0500

gnulib: update submodule to current versions

* gl/build-aux/do-release-commit-and-tag.diff: Rebase.
* gnulib: Update submodule.
---
 gl/build-aux/do-release-commit-and-tag.diff | 10 +-
 gnulib  |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/gl/build-aux/do-release-commit-and-tag.diff 
b/gl/build-aux/do-release-commit-and-tag.diff
index 1a8b29d1..f79870e5 100644
--- a/gl/build-aux/do-release-commit-and-tag.diff
+++ b/gl/build-aux/do-release-commit-and-tag.diff
@@ -1,20 +1,20 @@
 ./gnulib/build-aux/do-release-commit-and-tag   2013-01-26 
16:46:26.0 +1300
-+++ gl/build-aux/do-release-commit-and-tag 2013-10-28 20:21:38.0 
+1300
+--- ./gnulib/build-aux/do-release-commit-and-tag
 gl/build-aux/do-release-commit-and-tag
 @@ -5,6 +5,9 @@
  # will serve to identify the release, so apply a signed tag to it as well.
- VERSION=2012-08-01.09 # UTC
+ VERSION=2018-03-07.03 # UTC
  
 +# Make sure we've evaluated scripts we depend on.
 +test -z "$progpath" && . `echo "$0" |${SED-sed} 's|[^/]*$||'`/funclib.sh
 +
  # Note: this is a bash script (could be zsh or dash)
  
- # Copyright (C) 2009-2013 Free Software Foundation, Inc.
+ # Copyright (C) 2009-2024 Free Software Foundation, Inc.
 @@ -125,10 +128,8 @@
|| die 'failed to determine previous version number from .prev-version'
  
  # Verify that $ver is sensible (> .prev-version).
--case $(printf "$prev_ver\n$ver\n"|sort -V -u|tr '\n' ':') in
+-case $(printf "%s\n%s\n" "$prev_ver" "$ver"|sort -V -u|tr '\n' ':') in
 -  "$prev_ver:$ver:") ;;
 -  *) die "invalid version: $ver (<= $prev_ver)";;
 -esac
diff --git a/gnulib b/gnulib
index a5218207..29d705ea 16
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit a5218207e5f92e152a34994cce4aa415b1eb25c8
+Subproject commit 29d705ead11382c8d608dcc254394439cb43b9b8



branch m deleted (was 522bbc82)

2024-01-14 Thread Mike Frysinger
vapier pushed a change to branch m.

 was 522bbc82 gnulib: update submodule to current versions

This change permanently discards the following revisions:

 discard 522bbc82 gnulib: update submodule to current versions



  1   2   3   >