Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On 06/02/2014 06:51 PM, Josh Triplett wrote:
> On Mon, Jun 02, 2014 at 06:07:18PM -0700, Randy Dunlap wrote:
>> On 06/02/2014 05:02 PM, j...@joshtriplett.org wrote:
>>> On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote:
On 06/02/2014 01:36 PM, Joe Perches wrote:
> On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote:
>> On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney"
>> wrote:
>>
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c
>>>
>>> RCUTORTURE TEST FRAMEWORK
>>> M: "Paul E. McKenney"
>>> +R: Josh Triplett
>>> L: linux-kernel@vger.kernel.org
>>> S: Supported
>>> T: git
>>> git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
>>
>> I like the general principle - knowing who to poke regarding a kernel
>> change is useful.
>>
>> I don't care much whether it's "M:" or "R:", although "R:" carries more
>> meaning and hence is probably better.
>>
>> But why not "Cc:"? That's meaningful too and is more copy-n-paste
>> friendly.
Josh, what are you assuming that Andrew and I did not?
>>>
>>> Not sure what you mean here. Responding to the text you quoted: I have
>>> no particular need to bikeshed the tag name, so if you prefer "Cc" and
>>> can convince get_maintainer.pl to handle it, fine by me.
>>
>> Sorry, what I meant is that Andrew and I both mentioned copy-paste and
>> you replied earlier (and I have already deleted it) that copy-paste shouldn't
>> be necessary for someone who is using get_maintainer.pl.
>>
>> Do you redirect its output to your patch file and then edit it or does
>> get_maintainer.pl work with git-send-email or something else? if something
>> else, what is it, please?
>
> Oh, I see; that was in text you hadn't quoted, so I didn't know what you
> were asking. :)
>
> git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
> directly via --to-cmd or -cc-cmd; that works fine as long as you don't
> have a cover letter.
>
> Depending on the system I'm running on, and whether it's more convenient
> to invoke git-send-email or to edit patch mails and send them with 'mutt
> -H', I have a shell pipeline which invokes get_maintainer.pl on an
> entire patch series, collects all the email addresses it returns, and
> inserts them all into each mail as CCs. (That way, when I send a
> cross-subsystem patch series, I don't get a pile of maintainers confused
> that they only received a couple of the numbered patches.) One example:
>
> { echo -n "To: " ; for x in *.patch ; do scripts/get_maintainer.pl
> --no-rolestats < $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
> 's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
I see. Thanks for the summary.
> Personally, I'd find it handy if one of the following happened:
>
> - git send-email (and ideally also git format-patch) grew an option to
> collect *all* the to-cmd and cc-cmd output from each patch and apply
> it to every patch (including the cover letter).
>
> - get_maintainer.pl accepted multiple patchfile names and output the
> union of the results. Ideally, get_maintainer.pl would also have a -i
> option to edit the patch files and insert the addresses in the mail
> headers.
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On 06/02/2014 06:51 PM, Josh Triplett wrote:
On Mon, Jun 02, 2014 at 06:07:18PM -0700, Randy Dunlap wrote:
On 06/02/2014 05:02 PM, j...@joshtriplett.org wrote:
On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote:
On 06/02/2014 01:36 PM, Joe Perches wrote:
On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote:
On Mon, 2 Jun 2014 10:00:20 -0700 Paul E. McKenney
paul...@linux.vnet.ibm.com wrote:
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c
RCUTORTURE TEST FRAMEWORK
M: Paul E. McKenney paul...@linux.vnet.ibm.com
+R: Josh Triplett j...@joshtriplett.org
L: linux-kernel@vger.kernel.org
S: Supported
T: git
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
I like the general principle - knowing who to poke regarding a kernel
change is useful.
I don't care much whether it's M: or R:, although R: carries more
meaning and hence is probably better.
But why not Cc:? That's meaningful too and is more copy-n-paste
friendly.
Josh, what are you assuming that Andrew and I did not?
Not sure what you mean here. Responding to the text you quoted: I have
no particular need to bikeshed the tag name, so if you prefer Cc and
can convince get_maintainer.pl to handle it, fine by me.
Sorry, what I meant is that Andrew and I both mentioned copy-paste and
you replied earlier (and I have already deleted it) that copy-paste shouldn't
be necessary for someone who is using get_maintainer.pl.
Do you redirect its output to your patch file and then edit it or does
get_maintainer.pl work with git-send-email or something else? if something
else, what is it, please?
Oh, I see; that was in text you hadn't quoted, so I didn't know what you
were asking. :)
git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
directly via --to-cmd or -cc-cmd; that works fine as long as you don't
have a cover letter.
Depending on the system I'm running on, and whether it's more convenient
to invoke git-send-email or to edit patch mails and send them with 'mutt
-H', I have a shell pipeline which invokes get_maintainer.pl on an
entire patch series, collects all the email addresses it returns, and
inserts them all into each mail as CCs. (That way, when I send a
cross-subsystem patch series, I don't get a pile of maintainers confused
that they only received a couple of the numbered patches.) One example:
{ echo -n To: ; for x in *.patch ; do scripts/get_maintainer.pl
--no-rolestats $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
I see. Thanks for the summary.
Personally, I'd find it handy if one of the following happened:
- git send-email (and ideally also git format-patch) grew an option to
collect *all* the to-cmd and cc-cmd output from each patch and apply
it to every patch (including the cover letter).
- get_maintainer.pl accepted multiple patchfile names and output the
union of the results. Ideally, get_maintainer.pl would also have a -i
option to edit the patch files and insert the addresses in the mail
headers.
--
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2014-06-02 at 22:10 -0700, Josh Triplett wrote: > On Mon, Jun 02, 2014 at 08:11:36PM -0700, Joe Perches wrote: [] > "the appropriate mailing lists" often just mean LKML, > for many patches I've sent; almost nobody sees a patch only sent to > LKML, unless they specifically go looking for it.) It's a good thing then that Andre Morton is all-seeing. > > the > > quantity of names and addresses on the [0/n] > > patch can easily exceed vger's 1024 byte > > maximum header size limit. > > Is that the limit on the size of any *one* header, or on the size of all > headers combined? All headers > > Another possibility is to add a new "--bcc_cmd" > > to git send-email so that vger's header limit > > can be worked around. > > That breaks the ability for the recipients to see replies. If interested, the recipient knows where to look. > > I had patches to git to do that awhile ago. > > That'd be handy; did you try submitting them upstream? What reception > did you get? I don't recall. It was a bit after I added the cc-cmd stuff. Nearly 7 years ago now. > If you have objections to putting it directly in get_maintainer.pl, I do. > it'd > be easy enough to make a secondary script (patch_add_maintainers?) to > drive it. Go for it. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, Jun 02, 2014 at 08:11:36PM -0700, Joe Perches wrote:
> On Mon, 2014-06-02 at 18:51 -0700, Josh Triplett wrote:
> > git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
> > directly via --to-cmd or -cc-cmd; that works fine as long as you don't
> > have a cover letter.
> >
> > Depending on the system I'm running on, and whether it's more convenient
> > to invoke git-send-email or to edit patch mails and send them with 'mutt
> > -H', I have a shell pipeline which invokes get_maintainer.pl on an
> > entire patch series, collects all the email addresses it returns, and
> > inserts them all into each mail as CCs. (That way, when I send a
> > cross-subsystem patch series, I don't get a pile of maintainers confused
> > that they only received a couple of the numbered patches.) One example:
>
> I think that as long as the appropriate mailing lists receive
> the cover letter, any real maintainer won't be confused.
Not so much "confused" as "annoyed"; I've had people specifically
complain about getting one or two patches but not the cover letter, for
instance. (And "the appropriate mailing lists" often just mean LKML,
for many patches I've sent; almost nobody sees a patch only sent to
LKML, unless they specifically go looking for it.)
> > { echo -n "To: " ; for x in *.patch ; do scripts/get_maintainer.pl
> > --no-rolestats < $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
> > 's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
> >
> > Personally, I'd find it handy if one of the following happened:
> >
> > - git send-email (and ideally also git format-patch) grew an option to
> > collect *all* the to-cmd and cc-cmd output from each patch and apply
> > it to every patch (including the cover letter).
>
> The biggest issue with doing that is the
> quantity of names and addresses on the [0/n]
> patch can easily exceed vger's 1024 byte
> maximum header size limit.
Is that the limit on the size of any *one* header, or on the size of all
headers combined? If the former, there's an easy way around that. And
if the latter, that seems absurdly small.
Might also help to strip out the names and just insert the addresses;
annoying, but a handy workaround to make it likely that a sensibly sized
patch series won't hit the limit.
> Another possibility is to add a new "--bcc_cmd"
> to git send-email so that vger's header limit
> can be worked around.
That breaks the ability for the recipients to see replies.
> I had patches to git to do that awhile ago.
That'd be handy; did you try submitting them upstream? What reception
did you get?
> > - get_maintainer.pl accepted multiple patchfile names and output the
> > union of the results. Ideally, get_maintainer.pl would also have a -i
> > option to edit the patch files and insert the addresses in the mail
> > headers.
>
> Why would get_maintainer.pl have any option like that?
>
> Tools for uses. Scripting.
> Aren't we good at that sort of thing?
Yes, we're good at scripting; we put scripts many people might wish to
use in a scripts/ directory, such as the extremely handy script
get_maintainer.pl that does that sort of thing with patches. And since
it currently does nothing useful at all with cover letters, it'd be nice
to change that.
If you have objections to putting it directly in get_maintainer.pl, it'd
be easy enough to make a secondary script (patch_add_maintainers?) to
drive it.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2014-06-02 at 18:51 -0700, Josh Triplett wrote:
> git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
> directly via --to-cmd or -cc-cmd; that works fine as long as you don't
> have a cover letter.
>
> Depending on the system I'm running on, and whether it's more convenient
> to invoke git-send-email or to edit patch mails and send them with 'mutt
> -H', I have a shell pipeline which invokes get_maintainer.pl on an
> entire patch series, collects all the email addresses it returns, and
> inserts them all into each mail as CCs. (That way, when I send a
> cross-subsystem patch series, I don't get a pile of maintainers confused
> that they only received a couple of the numbered patches.) One example:
I think that as long as the appropriate mailing lists receive
the cover letter, any real maintainer won't be confused.
> { echo -n "To: " ; for x in *.patch ; do scripts/get_maintainer.pl
> --no-rolestats < $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
> 's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
>
> Personally, I'd find it handy if one of the following happened:
>
> - git send-email (and ideally also git format-patch) grew an option to
> collect *all* the to-cmd and cc-cmd output from each patch and apply
> it to every patch (including the cover letter).
The biggest issue with doing that is the
quantity of names and addresses on the [0/n]
patch can easily exceed vger's 1024 byte
maximum header size limit.
I drop all but the primary maintainers and
just cc lists.
I use a couple of scripts for that (attached)
for the "--to_cmd" and "--cc_cmd" options
Another possibility is to add a new "--bcc_cmd"
to git send-email so that vger's header limit
can be worked around.
I had patches to git to do that awhile ago.
> - get_maintainer.pl accepted multiple patchfile names and output the
> union of the results. Ideally, get_maintainer.pl would also have a -i
> option to edit the patch files and insert the addresses in the mail
> headers.
Why would get_maintainer.pl have any option like that?
Tools for uses. Scripting.
Aren't we good at that sort of thing?
to.sh
Description: application/shellscript
cc.sh
Description: application/shellscript
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, Jun 02, 2014 at 06:07:18PM -0700, Randy Dunlap wrote:
> On 06/02/2014 05:02 PM, j...@joshtriplett.org wrote:
> > On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote:
> >> On 06/02/2014 01:36 PM, Joe Perches wrote:
> >>> On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote:
> On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney"
> wrote:
>
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c
> >
> > RCUTORTURE TEST FRAMEWORK
> > M: "Paul E. McKenney"
> > +R: Josh Triplett
> > L: linux-kernel@vger.kernel.org
> > S: Supported
> > T: git
> > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
>
> I like the general principle - knowing who to poke regarding a kernel
> change is useful.
>
> I don't care much whether it's "M:" or "R:", although "R:" carries more
> meaning and hence is probably better.
>
> But why not "Cc:"? That's meaningful too and is more copy-n-paste
> friendly.
> >>
> >> Josh, what are you assuming that Andrew and I did not?
> >
> > Not sure what you mean here. Responding to the text you quoted: I have
> > no particular need to bikeshed the tag name, so if you prefer "Cc" and
> > can convince get_maintainer.pl to handle it, fine by me.
>
> Sorry, what I meant is that Andrew and I both mentioned copy-paste and
> you replied earlier (and I have already deleted it) that copy-paste shouldn't
> be necessary for someone who is using get_maintainer.pl.
>
> Do you redirect its output to your patch file and then edit it or does
> get_maintainer.pl work with git-send-email or something else? if something
> else, what is it, please?
Oh, I see; that was in text you hadn't quoted, so I didn't know what you
were asking. :)
git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
directly via --to-cmd or -cc-cmd; that works fine as long as you don't
have a cover letter.
Depending on the system I'm running on, and whether it's more convenient
to invoke git-send-email or to edit patch mails and send them with 'mutt
-H', I have a shell pipeline which invokes get_maintainer.pl on an
entire patch series, collects all the email addresses it returns, and
inserts them all into each mail as CCs. (That way, when I send a
cross-subsystem patch series, I don't get a pile of maintainers confused
that they only received a couple of the numbered patches.) One example:
{ echo -n "To: " ; for x in *.patch ; do scripts/get_maintainer.pl
--no-rolestats < $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
Personally, I'd find it handy if one of the following happened:
- git send-email (and ideally also git format-patch) grew an option to
collect *all* the to-cmd and cc-cmd output from each patch and apply
it to every patch (including the cover letter).
- get_maintainer.pl accepted multiple patchfile names and output the
union of the results. Ideally, get_maintainer.pl would also have a -i
option to edit the patch files and insert the addresses in the mail
headers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On 06/02/2014 05:02 PM, j...@joshtriplett.org wrote: > On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote: >> On 06/02/2014 01:36 PM, Joe Perches wrote: >>> On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney" wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7321,6 +7321,7 @@ F: kernel/rcu/torture.c > > RCUTORTURE TEST FRAMEWORK > M: "Paul E. McKenney" > +R: Josh Triplett > L: linux-kernel@vger.kernel.org > S: Supported > T: git > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git I like the general principle - knowing who to poke regarding a kernel change is useful. I don't care much whether it's "M:" or "R:", although "R:" carries more meaning and hence is probably better. But why not "Cc:"? That's meaningful too and is more copy-n-paste friendly. >> >> Josh, what are you assuming that Andrew and I did not? > > Not sure what you mean here. Responding to the text you quoted: I have > no particular need to bikeshed the tag name, so if you prefer "Cc" and > can convince get_maintainer.pl to handle it, fine by me. Sorry, what I meant is that Andrew and I both mentioned copy-paste and you replied earlier (and I have already deleted it) that copy-paste shouldn't be necessary for someone who is using get_maintainer.pl. Do you redirect its output to your patch file and then edit it or does get_maintainer.pl work with git-send-email or something else? if something else, what is it, please? thanks, -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote: > On 06/02/2014 01:36 PM, Joe Perches wrote: > > On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: > >> On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney" > >> wrote: > >> > >>> --- a/MAINTAINERS > >>> +++ b/MAINTAINERS > >>> @@ -7321,6 +7321,7 @@ F: kernel/rcu/torture.c > >>> > >>> RCUTORTURE TEST FRAMEWORK > >>> M: "Paul E. McKenney" > >>> +R: Josh Triplett > >>> L: linux-kernel@vger.kernel.org > >>> S: Supported > >>> T: git > >>> git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > >> > >> I like the general principle - knowing who to poke regarding a kernel > >> change is useful. > >> > >> I don't care much whether it's "M:" or "R:", although "R:" carries more > >> meaning and hence is probably better. > >> > >> But why not "Cc:"? That's meaningful too and is more copy-n-paste > >> friendly. > > Josh, what are you assuming that Andrew and I did not? Not sure what you mean here. Responding to the text you quoted: I have no particular need to bikeshed the tag name, so if you prefer "Cc" and can convince get_maintainer.pl to handle it, fine by me. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On 06/02/2014 01:36 PM, Joe Perches wrote: > On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: >> On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney" >> wrote: >> >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c >>> >>> RCUTORTURE TEST FRAMEWORK >>> M: "Paul E. McKenney" >>> +R: Josh Triplett >>> L: linux-kernel@vger.kernel.org >>> S: Supported >>> T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git >> >> I like the general principle - knowing who to poke regarding a kernel >> change is useful. >> >> I don't care much whether it's "M:" or "R:", although "R:" carries more >> meaning and hence is probably better. >> >> But why not "Cc:"? That's meaningful too and is more copy-n-paste friendly. Josh, what are you assuming that Andrew and I did not? -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: > On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney" > wrote: > > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c > > > > RCUTORTURE TEST FRAMEWORK > > M: "Paul E. McKenney" > > +R: Josh Triplett > > L: linux-kernel@vger.kernel.org > > S: Supported > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > > I like the general principle - knowing who to poke regarding a kernel > change is useful. > > I don't care much whether it's "M:" or "R:", although "R:" carries more > meaning and hence is probably better. > > But why not "Cc:"? That's meaningful too and is more copy-n-paste friendly. For one, it'd take an extra bit of rework to get_maintainer. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney" wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7321,6 +7321,7 @@ F: kernel/rcu/torture.c > > RCUTORTURE TEST FRAMEWORK > M: "Paul E. McKenney" > +R: Josh Triplett > L: linux-kernel@vger.kernel.org > S: Supported > T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git I like the general principle - knowing who to poke regarding a kernel change is useful. I don't care much whether it's "M:" or "R:", although "R:" carries more meaning and hence is probably better. But why not "Cc:"? That's meaningful too and is more copy-n-paste friendly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
From: "Paul E. McKenney" Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57d681d1d7d1..93054c4864d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c RCUTORTURE TEST FRAMEWORK M: "Paul E. McKenney" +R: Josh Triplett L: linux-kernel@vger.kernel.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git @@ -7345,6 +7346,7 @@ F:net/rds/ READ-COPY UPDATE (RCU) M: Dipankar Sarma M: "Paul E. McKenney" +R: Josh Triplett L: linux-kernel@vger.kernel.org W: http://www.rdrop.com/users/paulmck/RCU/ S: Supported @@ -8098,6 +8100,7 @@ F:mm/sl?b.c SLEEPABLE READ-COPY UPDATE (SRCU) M: Lai Jiangshan M: "Paul E. McKenney" +R: Josh Triplett L: linux-kernel@vger.kernel.org W: http://www.rdrop.com/users/paulmck/RCU/ S: Supported -- 1.8.1.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
From: Paul E. McKenney paul...@linux.vnet.ibm.com Signed-off-by: Paul E. McKenney paul...@linux.vnet.ibm.com Reviewed-by: Josh Triplett j...@joshtriplett.org --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57d681d1d7d1..93054c4864d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c RCUTORTURE TEST FRAMEWORK M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git @@ -7345,6 +7346,7 @@ F:net/rds/ READ-COPY UPDATE (RCU) M: Dipankar Sarma dipan...@in.ibm.com M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org W: http://www.rdrop.com/users/paulmck/RCU/ S: Supported @@ -8098,6 +8100,7 @@ F:mm/sl?b.c SLEEPABLE READ-COPY UPDATE (SRCU) M: Lai Jiangshan la...@cn.fujitsu.com M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org W: http://www.rdrop.com/users/paulmck/RCU/ S: Supported -- 1.8.1.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2 Jun 2014 10:00:20 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7321,6 +7321,7 @@ F: kernel/rcu/torture.c RCUTORTURE TEST FRAMEWORK M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git I like the general principle - knowing who to poke regarding a kernel change is useful. I don't care much whether it's M: or R:, although R: carries more meaning and hence is probably better. But why not Cc:? That's meaningful too and is more copy-n-paste friendly. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: On Mon, 2 Jun 2014 10:00:20 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c RCUTORTURE TEST FRAMEWORK M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git I like the general principle - knowing who to poke regarding a kernel change is useful. I don't care much whether it's M: or R:, although R: carries more meaning and hence is probably better. But why not Cc:? That's meaningful too and is more copy-n-paste friendly. For one, it'd take an extra bit of rework to get_maintainer. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On 06/02/2014 01:36 PM, Joe Perches wrote: On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: On Mon, 2 Jun 2014 10:00:20 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c RCUTORTURE TEST FRAMEWORK M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git I like the general principle - knowing who to poke regarding a kernel change is useful. I don't care much whether it's M: or R:, although R: carries more meaning and hence is probably better. But why not Cc:? That's meaningful too and is more copy-n-paste friendly. Josh, what are you assuming that Andrew and I did not? -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote: On 06/02/2014 01:36 PM, Joe Perches wrote: On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: On Mon, 2 Jun 2014 10:00:20 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7321,6 +7321,7 @@ F: kernel/rcu/torture.c RCUTORTURE TEST FRAMEWORK M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git I like the general principle - knowing who to poke regarding a kernel change is useful. I don't care much whether it's M: or R:, although R: carries more meaning and hence is probably better. But why not Cc:? That's meaningful too and is more copy-n-paste friendly. Josh, what are you assuming that Andrew and I did not? Not sure what you mean here. Responding to the text you quoted: I have no particular need to bikeshed the tag name, so if you prefer Cc and can convince get_maintainer.pl to handle it, fine by me. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On 06/02/2014 05:02 PM, j...@joshtriplett.org wrote: On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote: On 06/02/2014 01:36 PM, Joe Perches wrote: On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote: On Mon, 2 Jun 2014 10:00:20 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7321,6 +7321,7 @@ F: kernel/rcu/torture.c RCUTORTURE TEST FRAMEWORK M: Paul E. McKenney paul...@linux.vnet.ibm.com +R: Josh Triplett j...@joshtriplett.org L: linux-kernel@vger.kernel.org S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git I like the general principle - knowing who to poke regarding a kernel change is useful. I don't care much whether it's M: or R:, although R: carries more meaning and hence is probably better. But why not Cc:? That's meaningful too and is more copy-n-paste friendly. Josh, what are you assuming that Andrew and I did not? Not sure what you mean here. Responding to the text you quoted: I have no particular need to bikeshed the tag name, so if you prefer Cc and can convince get_maintainer.pl to handle it, fine by me. Sorry, what I meant is that Andrew and I both mentioned copy-paste and you replied earlier (and I have already deleted it) that copy-paste shouldn't be necessary for someone who is using get_maintainer.pl. Do you redirect its output to your patch file and then edit it or does get_maintainer.pl work with git-send-email or something else? if something else, what is it, please? thanks, -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, Jun 02, 2014 at 06:07:18PM -0700, Randy Dunlap wrote:
On 06/02/2014 05:02 PM, j...@joshtriplett.org wrote:
On Mon, Jun 02, 2014 at 01:38:56PM -0700, Randy Dunlap wrote:
On 06/02/2014 01:36 PM, Joe Perches wrote:
On Mon, 2014-06-02 at 13:35 -0700, Andrew Morton wrote:
On Mon, 2 Jun 2014 10:00:20 -0700 Paul E. McKenney
paul...@linux.vnet.ibm.com wrote:
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7321,6 +7321,7 @@ F:kernel/rcu/torture.c
RCUTORTURE TEST FRAMEWORK
M: Paul E. McKenney paul...@linux.vnet.ibm.com
+R: Josh Triplett j...@joshtriplett.org
L: linux-kernel@vger.kernel.org
S: Supported
T: git
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
I like the general principle - knowing who to poke regarding a kernel
change is useful.
I don't care much whether it's M: or R:, although R: carries more
meaning and hence is probably better.
But why not Cc:? That's meaningful too and is more copy-n-paste
friendly.
Josh, what are you assuming that Andrew and I did not?
Not sure what you mean here. Responding to the text you quoted: I have
no particular need to bikeshed the tag name, so if you prefer Cc and
can convince get_maintainer.pl to handle it, fine by me.
Sorry, what I meant is that Andrew and I both mentioned copy-paste and
you replied earlier (and I have already deleted it) that copy-paste shouldn't
be necessary for someone who is using get_maintainer.pl.
Do you redirect its output to your patch file and then edit it or does
get_maintainer.pl work with git-send-email or something else? if something
else, what is it, please?
Oh, I see; that was in text you hadn't quoted, so I didn't know what you
were asking. :)
git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
directly via --to-cmd or -cc-cmd; that works fine as long as you don't
have a cover letter.
Depending on the system I'm running on, and whether it's more convenient
to invoke git-send-email or to edit patch mails and send them with 'mutt
-H', I have a shell pipeline which invokes get_maintainer.pl on an
entire patch series, collects all the email addresses it returns, and
inserts them all into each mail as CCs. (That way, when I send a
cross-subsystem patch series, I don't get a pile of maintainers confused
that they only received a couple of the numbered patches.) One example:
{ echo -n To: ; for x in *.patch ; do scripts/get_maintainer.pl
--no-rolestats $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
Personally, I'd find it handy if one of the following happened:
- git send-email (and ideally also git format-patch) grew an option to
collect *all* the to-cmd and cc-cmd output from each patch and apply
it to every patch (including the cover letter).
- get_maintainer.pl accepted multiple patchfile names and output the
union of the results. Ideally, get_maintainer.pl would also have a -i
option to edit the patch files and insert the addresses in the mail
headers.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2014-06-02 at 18:51 -0700, Josh Triplett wrote:
git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
directly via --to-cmd or -cc-cmd; that works fine as long as you don't
have a cover letter.
Depending on the system I'm running on, and whether it's more convenient
to invoke git-send-email or to edit patch mails and send them with 'mutt
-H', I have a shell pipeline which invokes get_maintainer.pl on an
entire patch series, collects all the email addresses it returns, and
inserts them all into each mail as CCs. (That way, when I send a
cross-subsystem patch series, I don't get a pile of maintainers confused
that they only received a couple of the numbered patches.) One example:
I think that as long as the appropriate mailing lists receive
the cover letter, any real maintainer won't be confused.
{ echo -n To: ; for x in *.patch ; do scripts/get_maintainer.pl
--no-rolestats $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
Personally, I'd find it handy if one of the following happened:
- git send-email (and ideally also git format-patch) grew an option to
collect *all* the to-cmd and cc-cmd output from each patch and apply
it to every patch (including the cover letter).
The biggest issue with doing that is the
quantity of names and addresses on the [0/n]
patch can easily exceed vger's 1024 byte
maximum header size limit.
I drop all but the primary maintainers and
just cc lists.
I use a couple of scripts for that (attached)
for the --to_cmd and --cc_cmd options
Another possibility is to add a new --bcc_cmd
to git send-email so that vger's header limit
can be worked around.
I had patches to git to do that awhile ago.
- get_maintainer.pl accepted multiple patchfile names and output the
union of the results. Ideally, get_maintainer.pl would also have a -i
option to edit the patch files and insert the addresses in the mail
headers.
Why would get_maintainer.pl have any option like that?
Tools for uses. Scripting.
Aren't we good at that sort of thing?
to.sh
Description: application/shellscript
cc.sh
Description: application/shellscript
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, Jun 02, 2014 at 08:11:36PM -0700, Joe Perches wrote:
On Mon, 2014-06-02 at 18:51 -0700, Josh Triplett wrote:
git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
directly via --to-cmd or -cc-cmd; that works fine as long as you don't
have a cover letter.
Depending on the system I'm running on, and whether it's more convenient
to invoke git-send-email or to edit patch mails and send them with 'mutt
-H', I have a shell pipeline which invokes get_maintainer.pl on an
entire patch series, collects all the email addresses it returns, and
inserts them all into each mail as CCs. (That way, when I send a
cross-subsystem patch series, I don't get a pile of maintainers confused
that they only received a couple of the numbered patches.) One example:
I think that as long as the appropriate mailing lists receive
the cover letter, any real maintainer won't be confused.
Not so much confused as annoyed; I've had people specifically
complain about getting one or two patches but not the cover letter, for
instance. (And the appropriate mailing lists often just mean LKML,
for many patches I've sent; almost nobody sees a patch only sent to
LKML, unless they specifically go looking for it.)
{ echo -n To: ; for x in *.patch ; do scripts/get_maintainer.pl
--no-rolestats $x | fgrep -v j...@joshtriplett.org ; done | sort -u | sed
's/$/, /;$s/, $//' | tr -d '\n' ; echo ; } | sed -i '/^From:/r/dev/stdin'
Personally, I'd find it handy if one of the following happened:
- git send-email (and ideally also git format-patch) grew an option to
collect *all* the to-cmd and cc-cmd output from each patch and apply
it to every patch (including the cover letter).
The biggest issue with doing that is the
quantity of names and addresses on the [0/n]
patch can easily exceed vger's 1024 byte
maximum header size limit.
Is that the limit on the size of any *one* header, or on the size of all
headers combined? If the former, there's an easy way around that. And
if the latter, that seems absurdly small.
Might also help to strip out the names and just insert the addresses;
annoying, but a handy workaround to make it likely that a sensibly sized
patch series won't hit the limit.
Another possibility is to add a new --bcc_cmd
to git send-email so that vger's header limit
can be worked around.
That breaks the ability for the recipients to see replies.
I had patches to git to do that awhile ago.
That'd be handy; did you try submitting them upstream? What reception
did you get?
- get_maintainer.pl accepted multiple patchfile names and output the
union of the results. Ideally, get_maintainer.pl would also have a -i
option to edit the patch files and insert the addresses in the mail
headers.
Why would get_maintainer.pl have any option like that?
Tools for uses. Scripting.
Aren't we good at that sort of thing?
Yes, we're good at scripting; we put scripts many people might wish to
use in a scripts/ directory, such as the extremely handy script
get_maintainer.pl that does that sort of thing with patches. And since
it currently does nothing useful at all with cover letters, it'd be nice
to change that.
If you have objections to putting it directly in get_maintainer.pl, it'd
be easy enough to make a secondary script (patch_add_maintainers?) to
drive it.
- Josh Triplett
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC 2/2] rcu: Add Josh Triplett as designated reviewer
On Mon, 2014-06-02 at 22:10 -0700, Josh Triplett wrote: On Mon, Jun 02, 2014 at 08:11:36PM -0700, Joe Perches wrote: [] the appropriate mailing lists often just mean LKML, for many patches I've sent; almost nobody sees a patch only sent to LKML, unless they specifically go looking for it.) It's a good thing then that Andre Morton is all-seeing. the quantity of names and addresses on the [0/n] patch can easily exceed vger's 1024 byte maximum header size limit. Is that the limit on the size of any *one* header, or on the size of all headers combined? All headers Another possibility is to add a new --bcc_cmd to git send-email so that vger's header limit can be worked around. That breaks the ability for the recipients to see replies. shrug If interested, the recipient knows where to look. I had patches to git to do that awhile ago. That'd be handy; did you try submitting them upstream? What reception did you get? I don't recall. It was a bit after I added the cc-cmd stuff. Nearly 7 years ago now. If you have objections to putting it directly in get_maintainer.pl, I do. it'd be easy enough to make a secondary script (patch_add_maintainers?) to drive it. Go for it. cheers, Joe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
