Re: [PATCH 5/5] saa7164: Hauppauge HVR-2205 and HVR-2215 DVB-C/T/T2 tuners

2015-03-27 Thread Steven Toth
 The HVR-2215 is sold in Australia, it's not a prototype card:
 http://www.pccasegear.com/index.php?main_page=product_infoproducts_id=28385cPath=172

Thanks for the URL. I've ordered a card. I'll look into the gapped
clock. If it's not required on the HVR2205 (using 2168) then it
shouldn't be required for the HVR2215 (using 2168), but that's
speculation at this point.

I also have the hardware schematics so I'll check those when the board
arrives also.

Thanks for the heads up.

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 5/5] saa7164: Hauppauge HVR-2205 and HVR-2215 DVB-C/T/T2 tuners

2015-03-27 Thread Steven Toth
 I did not require any 2168/2157 driver changes to make these devices
 work. (Antti please note).


 There seems to be only minor TS config change (which is not even needed if
 you set that bit to existing TS mode config value) for gapped/variable
 length TS clock (which is in my understanding to leave TS valid line
 unconnected).

Its not required for the HVR2205 or the HVR2255, these are the only
two models of the hardware shipping in production volumes to
customers. Any other cards were advanced prototypes, that's my
understanding.

I'm not suggesting the gapped clock 2168 patch isn't useful for other
bridges, you might want to pull Olli's patch for that, but its not
required for the HVR2205/2255 support.

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 5/5] saa7164: Hauppauge HVR-2205 and HVR-2215 DVB-C/T/T2 tuners

2015-03-27 Thread Olli Salonen
Hauppauge HVR-2205 and HVR-2215 are PCIe dual tuner cards that support
DVB-C, DVB-T and DVB-T2.

PCIe bridge: SAA7164
Demodulator: Si2168-B40
Tuner: SI2157-A20

I know there's parallel activity ongoing regarding these devices, but I 
thought I'll submit my own version here as well. The maintainers of each 
module can then make the call what to merge.

Signed-off-by: Olli Salonen olli.salo...@iki.fi
---
 drivers/media/pci/saa7164/Kconfig |   2 +
 drivers/media/pci/saa7164/saa7164-cards.c | 101 ++
 drivers/media/pci/saa7164/saa7164-dvb.c   |  67 
 drivers/media/pci/saa7164/saa7164.h   |   2 +
 4 files changed, 172 insertions(+)

diff --git a/drivers/media/pci/saa7164/Kconfig 
b/drivers/media/pci/saa7164/Kconfig
index a53db7d..5ebe930 100644
--- a/drivers/media/pci/saa7164/Kconfig
+++ b/drivers/media/pci/saa7164/Kconfig
@@ -8,7 +8,9 @@ config VIDEO_SAA7164
select VIDEOBUF_DVB
select DVB_TDA10048 if MEDIA_SUBDRV_AUTOSELECT
select DVB_S5H1411 if MEDIA_SUBDRV_AUTOSELECT
+   select DVB_SI2168 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_TDA18271 if MEDIA_SUBDRV_AUTOSELECT
+   select MEDIA_TUNER_SI2157 if MEDIA_SUBDRV_AUTOSELECT
---help---
  This is a video4linux driver for NXP SAA7164 based
  TV cards.
diff --git a/drivers/media/pci/saa7164/saa7164-cards.c 
b/drivers/media/pci/saa7164/saa7164-cards.c
index 5b72da5..5ebd312 100644
--- a/drivers/media/pci/saa7164/saa7164-cards.c
+++ b/drivers/media/pci/saa7164/saa7164-cards.c
@@ -499,6 +499,90 @@ struct saa7164_board saa7164_boards[] = {
.i2c_reg_len= REGLEN_8bit,
} },
},
+   [SAA7164_BOARD_HAUPPAUGE_HVR2205] = {
+   .name   = Hauppauge WinTV-HVR2205,
+   .porta  = SAA7164_MPEG_DVB,
+   .portb  = SAA7164_MPEG_DVB,
+   .chiprev= SAA7164_CHIP_REV3,
+   .unit = {{
+   .id = 0x28,
+   .type = SAA7164_UNIT_EEPROM,
+   .name = 4K EEPROM,
+   .i2c_bus_nr = SAA7164_I2C_BUS_0,
+   .i2c_bus_addr   = 0xa0  1,
+   .i2c_reg_len= REGLEN_8bit,
+   }, {
+   .id = 0x04,
+   .type   = SAA7164_UNIT_TUNER,
+   .name   = SI2157-1,
+   .i2c_bus_nr = SAA7164_I2C_BUS_1,
+   .i2c_bus_addr   = 0xc0  1,
+   .i2c_reg_len= 0,
+   }, {
+   .id = 0x05,
+   .type   = SAA7164_UNIT_DIGITAL_DEMODULATOR,
+   .name   = SI2168-1,
+   .i2c_bus_nr = SAA7164_I2C_BUS_1,
+   .i2c_bus_addr   = 0xc8  1,
+   .i2c_reg_len= 0,
+   }, {
+   .id = 0x25,
+   .type   = SAA7164_UNIT_TUNER,
+   .name   = SI2157-2,
+   .i2c_bus_nr = SAA7164_I2C_BUS_2,
+   .i2c_bus_addr   = 0xc0  1,
+   .i2c_reg_len= 0,
+   }, {
+   .id = 0x26,
+   .type   = SAA7164_UNIT_DIGITAL_DEMODULATOR,
+   .name   = SI2168-2,
+   .i2c_bus_nr = SAA7164_I2C_BUS_2,
+   .i2c_bus_addr   = 0xcc  1,
+   .i2c_reg_len= 0,
+   } },
+   },
+   [SAA7164_BOARD_HAUPPAUGE_HVR2215] = {
+   .name   = Hauppauge WinTV-HVR2215,
+   .porta  = SAA7164_MPEG_DVB,
+   .portb  = SAA7164_MPEG_DVB,
+   .chiprev= SAA7164_CHIP_REV3,
+   .unit = {{
+   .id = 0x28,
+   .type = SAA7164_UNIT_EEPROM,
+   .name = 4K EEPROM,
+   .i2c_bus_nr = SAA7164_I2C_BUS_0,
+   .i2c_bus_addr   = 0xa0  1,
+   .i2c_reg_len= REGLEN_8bit,
+   }, {
+   .id = 0x04,
+   .type   = SAA7164_UNIT_TUNER,
+   .name   = SI2157-1,
+   .i2c_bus_nr = SAA7164_I2C_BUS_1,
+   .i2c_bus_addr   = 0xc0  1,
+   .i2c_reg_len= 0,
+   }, {
+   .id = 0x05,
+   .type   = SAA7164_UNIT_DIGITAL_DEMODULATOR,
+   .name   = SI2168-1,
+   .i2c_bus_nr = SAA7164_I2C_BUS_1,
+   .i2c_bus_addr   = 0xc8  1,
+   .i2c_reg_len  

Re: [PATCH 5/5] saa7164: Hauppauge HVR-2205 and HVR-2215 DVB-C/T/T2 tuners

2015-03-27 Thread Steven Toth
 I know there's parallel activity ongoing regarding these devices, but I
 thought I'll submit my own version here as well. The maintainers of each
 module can then make the call what to merge.

http://git.linuxtv.org/cgit.cgi/stoth/media_tree.git/log/?h=saa7164-dev

As mentioned previously, I've added support for the HVR2205 and
HVR2255. I moved those patches from bitbucket.org into linuxtv.org a
couple of days ago pending a pull request. It took a couple of days to
get my git.linuxtv.org account back up and running.

You've seen and commented on the patches when they were in bitbucket
earlier this week, so your need to push our your own patches only
confuses and concerns me.

I did not require any 2168/2157 driver changes to make these devices
work. (Antti please note).

I plan to issue a pull request for my tree shortly.

- Steve

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 5/5] saa7164: Hauppauge HVR-2205 and HVR-2215 DVB-C/T/T2 tuners

2015-03-27 Thread Olli Salonen
Hi,

Feel free to ignore the patches I sent. Just thought that since I made
the work to get the devices working anyway I'll post my code in case
someone can benefit from that somehow.

The HVR-2215 is sold in Australia, it's not a prototype card:
http://www.pccasegear.com/index.php?main_page=product_infoproducts_id=28385cPath=172

I also know a user in AU who has tested my code with HVR-2215 and it works ok.

My understanding is that the Windows driver does set the gapped clock,
the below is from Hauppauge's own Windows driver INF files for
HVR-2205 (I assume the parameters pointing to Si2164 apply also to
Si2168):

;gapped clock
HKR,Parameters,Si2164_ts_clk_gapped_en,0x00010001, 1

However, it is true that the device seems to work with or without this
setting. That was the case with TechnoTrend CT2-4400 earlier as well.
Only when TT made another version of the same device (with the same
USB IDs etc.) it stopped working and the change was necessary.

Cheers,
-olli


On 27 March 2015 at 14:08, Steven Toth st...@kernellabs.com wrote:
 I know there's parallel activity ongoing regarding these devices, but I
 thought I'll submit my own version here as well. The maintainers of each
 module can then make the call what to merge.

 http://git.linuxtv.org/cgit.cgi/stoth/media_tree.git/log/?h=saa7164-dev

 As mentioned previously, I've added support for the HVR2205 and
 HVR2255. I moved those patches from bitbucket.org into linuxtv.org a
 couple of days ago pending a pull request. It took a couple of days to
 get my git.linuxtv.org account back up and running.

 You've seen and commented on the patches when they were in bitbucket
 earlier this week, so your need to push our your own patches only
 confuses and concerns me.

 I did not require any 2168/2157 driver changes to make these devices
 work. (Antti please note).

 I plan to issue a pull request for my tree shortly.

 - Steve

 --
 Steven Toth - Kernel Labs
 http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 5/5] saa7164: Hauppauge HVR-2205 and HVR-2215 DVB-C/T/T2 tuners

2015-03-27 Thread Antti Palosaari

On 03/27/2015 02:08 PM, Steven Toth wrote:

I know there's parallel activity ongoing regarding these devices, but I
thought I'll submit my own version here as well. The maintainers of each
module can then make the call what to merge.


http://git.linuxtv.org/cgit.cgi/stoth/media_tree.git/log/?h=saa7164-dev

As mentioned previously, I've added support for the HVR2205 and
HVR2255. I moved those patches from bitbucket.org into linuxtv.org a
couple of days ago pending a pull request. It took a couple of days to
get my git.linuxtv.org account back up and running.

You've seen and commented on the patches when they were in bitbucket
earlier this week, so your need to push our your own patches only
confuses and concerns me.

I did not require any 2168/2157 driver changes to make these devices
work. (Antti please note).


There seems to be only minor TS config change (which is not even needed 
if you set that bit to existing TS mode config value) for 
gapped/variable length TS clock (which is in my understanding to leave 
TS valid line unconnected).



I plan to issue a pull request for my tree shortly.

- Steve



Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html