Re: Make failed - standard ubuntu 9.10
Thanks, I've been trying to follow the wiki, but getting this error. The main kernel packages seem to all be installed, but perhaps something less obvious is missing - hard to tell without a definitive list of dependencies. Help would be much appreciated! David Németh Márton wrote: David Henig wrote: Please can someone assist, not sure what the cause of the below is? This is my second attempt to get linux tv to work, I suspect it's a basic level error - sorry I'm fairly new to Linux... output below, I'm running a fairly standard ubuntu 9.10 setup. make[1]: Entering directory `/home/david/v4l-dvb/v4l' Updating/Creating .config Preparing to compile for kernel version 2.6.31 File not found: /lib/modules/2.6.31-17-generic/build/.config at ./scripts/make_kconfig.pl line 32, IN line 4. make[1]: *** No rule to make target `.myconfig', needed by `config-compat.h'. Stop. make[1]: Leaving directory `/home/david/v4l-dvb/v4l' make: *** [all] Error 2 I think you don't have the kernel development files installed. The recommended reading would be: http://linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers Regards, Márton Németh -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb
(resent: forgot to mail it to the linux-media list) Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for the following: - saa7134: remove stray unlock_kernel This is a high-prio bugfix that must go to 2.6.33! Dmitri, this patch will fix the kernel oops in your latest stack trace. Thanks, Hans diffstat: saa7134-empress.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Make failed - standard ubuntu 9.10
Its looking for .config file inside the kernel source. /lib/modules/2.6.31-17-generic/build/.config 1) check that /build is a symlink to /usr/src/kernel-path-source 2) IF there is something like /proc/config , copy it to /usr/src/kernel-path-source/.config IF NOT, then you could try doing a make oldconfig I really dont know that the ubuntu packages includes inside, so, those are my 2 cents... 2010/1/29 David Henig dhhe...@googlemail.com: Thanks, I've been trying to follow the wiki, but getting this error. The main kernel packages seem to all be installed, but perhaps something less obvious is missing - hard to tell without a definitive list of dependencies. Help would be much appreciated! David Németh Márton wrote: David Henig wrote: Please can someone assist, not sure what the cause of the below is? This is my second attempt to get linux tv to work, I suspect it's a basic level error - sorry I'm fairly new to Linux... output below, I'm running a fairly standard ubuntu 9.10 setup. make[1]: Entering directory `/home/david/v4l-dvb/v4l' Updating/Creating .config Preparing to compile for kernel version 2.6.31 File not found: /lib/modules/2.6.31-17-generic/build/.config at ./scripts/make_kconfig.pl line 32, IN line 4. make[1]: *** No rule to make target `.myconfig', needed by `config-compat.h'. Stop. make[1]: Leaving directory `/home/david/v4l-dvb/v4l' make: *** [all] Error 2 I think you don't have the kernel development files installed. The recommended reading would be: http://linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers Regards, Márton Németh -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: fix regression in pwc_set_shutter_speed???
On Fri, Jan 29, 2010 at 12:45:37AM +, Jef Treece wrote: I reported a regression and provided a fix a few months ago for a regression in pwc_set_shutter_speed that was introduced in approx April 2009. Is that regression going to get fixed? It's really causing a lot of pain because it means a custom kernel build every time. Does someone have a patch for it? Have a pointer to the email previously describing it? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Make failed - standard ubuntu 9.10
Thanks, eventually tip 1 fixed this. For some reason I had 2.6.31-17-generic without a .config, as I seem to be using 2.6.31-17-generic-pae. Creating a symlink to that fixed this error. Unfortunately still can't finish build, I get an error in firedtv-1394, as shown below. Do I need to reinstall, as I also get the following message? ***WARNING:*** You do not have the full kernel sources installed. This does not prevent you from building the v4l-dvb tree if you have the kernel headers, but the full kernel source may be required in order to use make menuconfig / xconfig / qconfig. If you are experiencing problems building the v4l-dvb tree, please try building against a vanilla kernel before reporting a bug. Thanks again for any help, I'm sorry I'm only a couple of months into linux, I'm just trying to do this against what I thought was a fairly standard build... David [error section] /home/david/v4l-dvb/v4l/firedtv-1394.c:21:17: error: dma.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:22:21: error: csr1212.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:23:23: error: highlevel.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:24:19: error: hosts.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:25:22: error: ieee1394.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:26:17: error: iso.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:27:21: error: nodemgr.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:40: warning: 'struct hpsb_iso' declared inside parameter list /home/david/v4l-dvb/v4l/firedtv-1394.c:40: warning: its scope is only this definition or declaration, which is probably not what you want /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'rawiso_activity_cb': /home/david/v4l-dvb/v4l/firedtv-1394.c:56: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:57: error: implicit declaration of function 'hpsb_iso_n_ready' /home/david/v4l-dvb/v4l/firedtv-1394.c:64: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:65: error: implicit declaration of function 'dma_region_i' /home/david/v4l-dvb/v4l/firedtv-1394.c:65: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:65: error: expected expression before 'unsigned' /home/david/v4l-dvb/v4l/firedtv-1394.c:66: warning: assignment makes pointer from integer without a cast /home/david/v4l-dvb/v4l/firedtv-1394.c:67: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:71: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:85: error: implicit declaration of function 'hpsb_iso_recv_release_packets' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_of': /home/david/v4l-dvb/v4l/firedtv-1394.c:90: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:90: warning: type defaults to 'int' in declaration of '__mptr' /home/david/v4l-dvb/v4l/firedtv-1394.c:90: warning: initialization from incompatible pointer type /home/david/v4l-dvb/v4l/firedtv-1394.c:90: error: invalid use of undefined type 'struct unit_directory' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_lock': /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: implicit declaration of function 'hpsb_node_lock' /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: 'EXTCODE_COMPARE_SWAP' undeclared (first use in this function) /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: (Each undeclared identifier is reported only once /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: for each function it appears in.) /home/david/v4l-dvb/v4l/firedtv-1394.c:98: error: 'quadlet_t' undeclared (first use in this function) /home/david/v4l-dvb/v4l/firedtv-1394.c:98: error: expected expression before ')' token /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_read': /home/david/v4l-dvb/v4l/firedtv-1394.c:106: error: implicit declaration of function 'hpsb_node_read' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_write': /home/david/v4l-dvb/v4l/firedtv-1394.c:111: error: implicit declaration of function 'hpsb_node_write' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'start_iso': /home/david/v4l-dvb/v4l/firedtv-1394.c:122: error: implicit declaration of function 'hpsb_iso_recv_init' /home/david/v4l-dvb/v4l/firedtv-1394.c:122: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:124: error: 'HPSB_ISO_DMA_DEFAULT' undeclared (first use in this function) /home/david/v4l-dvb/v4l/firedtv-1394.c:126: warning: assignment makes pointer from integer without a cast /home/david/v4l-dvb/v4l/firedtv-1394.c:133: error: implicit declaration of function 'hpsb_iso_recv_start' /home/david/v4l-dvb/v4l/firedtv-1394.c:136: error: implicit declaration of function 'hpsb_iso_shutdown'
Re: Make failed - standard ubuntu 9.10
On 29/01/2010 10:27 PM, David Henig wrote: Thanks, eventually tip 1 fixed this. For some reason I had 2.6.31-17-generic without a .config, as I seem to be using 2.6.31-17-generic-pae. Creating a symlink to that fixed this error. Unfortunately still can't finish build, I get an error in firedtv-1394, as shown below. Do I need to reinstall, as I also get the following message? ***WARNING:*** You do not have the full kernel sources installed. This does not prevent you from building the v4l-dvb tree if you have the kernel headers, but the full kernel source may be required in order to use make menuconfig / xconfig / qconfig. If you are experiencing problems building the v4l-dvb tree, please try building against a vanilla kernel before reporting a bug. Thanks again for any help, I'm sorry I'm only a couple of months into linux, I'm just trying to do this against what I thought was a fairly standard build... David Hi David, It looks like you don't have the kernel headers package installed. In Ubuntu this package is called linux-headers-generic for the generic kernel, and linux-headers-server for the server kernel, etc and so forth. If you have this package you shouldn't need to any symlinking with the .config, either. I didn't have to. Regards, Frank. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Jean Delvare wrote: From: Jean Delvare kh...@linux-fr.org Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131 Analog (card=146). However, by the time we find out, some card-specific initialization is missed. In particular, the fact that the IR is GPIO-based. Set it when we change the card type. We also have to move the initialization of IR until after the card number has been changed. I hope that this won't cause any problem. Hi Jean, Moving the initialization will likely cause regressions. The reason why there are two init codes there were due to the way the old i2c code used to work. This got fixed after the i2c rework, but it caused regressions on that time. The proper way would be to just muve the IR initialization on this board from init1 to init2, instead of changing it for all other devices. cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Make failed - standard ubuntu 9.10
Thanks, I appear to have the headers and no longer have to do the symlink, but still getting the same error - any help gratefully received, or do I need to get a vanilla kernel? CC [M] /home/david/v4l-dvb/v4l/firedtv-1394.o /home/david/v4l-dvb/v4l/firedtv-1394.c:21:17: error: dma.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:22:21: error: csr1212.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:23:23: error: highlevel.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:24:19: error: hosts.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:25:22: error: ieee1394.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:26:17: error: iso.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:27:21: error: nodemgr.h: No such file or directory /home/david/v4l-dvb/v4l/firedtv-1394.c:40: warning: 'struct hpsb_iso' declared inside parameter list /home/david/v4l-dvb/v4l/firedtv-1394.c:40: warning: its scope is only this definition or declaration, which is probably not what you want /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'rawiso_activity_cb': /home/david/v4l-dvb/v4l/firedtv-1394.c:56: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:57: error: implicit declaration of function 'hpsb_iso_n_ready' /home/david/v4l-dvb/v4l/firedtv-1394.c:64: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:65: error: implicit declaration of function 'dma_region_i' /home/david/v4l-dvb/v4l/firedtv-1394.c:65: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:65: error: expected expression before 'unsigned' /home/david/v4l-dvb/v4l/firedtv-1394.c:66: warning: assignment makes pointer from integer without a cast /home/david/v4l-dvb/v4l/firedtv-1394.c:67: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:71: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:85: error: implicit declaration of function 'hpsb_iso_recv_release_packets' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_of': /home/david/v4l-dvb/v4l/firedtv-1394.c:90: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:90: warning: type defaults to 'int' in declaration of '__mptr' /home/david/v4l-dvb/v4l/firedtv-1394.c:90: warning: initialization from incompatible pointer type /home/david/v4l-dvb/v4l/firedtv-1394.c:90: error: invalid use of undefined type 'struct unit_directory' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_lock': /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: implicit declaration of function 'hpsb_node_lock' /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: 'EXTCODE_COMPARE_SWAP' undeclared (first use in this function) /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: (Each undeclared identifier is reported only once /home/david/v4l-dvb/v4l/firedtv-1394.c:97: error: for each function it appears in.) /home/david/v4l-dvb/v4l/firedtv-1394.c:98: error: 'quadlet_t' undeclared (first use in this function) /home/david/v4l-dvb/v4l/firedtv-1394.c:98: error: expected expression before ')' token /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_read': /home/david/v4l-dvb/v4l/firedtv-1394.c:106: error: implicit declaration of function 'hpsb_node_read' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_write': /home/david/v4l-dvb/v4l/firedtv-1394.c:111: error: implicit declaration of function 'hpsb_node_write' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'start_iso': /home/david/v4l-dvb/v4l/firedtv-1394.c:122: error: implicit declaration of function 'hpsb_iso_recv_init' /home/david/v4l-dvb/v4l/firedtv-1394.c:122: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:124: error: 'HPSB_ISO_DMA_DEFAULT' undeclared (first use in this function) /home/david/v4l-dvb/v4l/firedtv-1394.c:126: warning: assignment makes pointer from integer without a cast /home/david/v4l-dvb/v4l/firedtv-1394.c:133: error: implicit declaration of function 'hpsb_iso_recv_start' /home/david/v4l-dvb/v4l/firedtv-1394.c:136: error: implicit declaration of function 'hpsb_iso_shutdown' /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'stop_iso': /home/david/v4l-dvb/v4l/firedtv-1394.c:147: error: implicit declaration of function 'hpsb_iso_stop' /home/david/v4l-dvb/v4l/firedtv-1394.c: At top level: /home/david/v4l-dvb/v4l/firedtv-1394.c:162: warning: 'struct hpsb_host' declared inside parameter list /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'fcp_request': /home/david/v4l-dvb/v4l/firedtv-1394.c:175: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c:176: error: dereferencing pointer to incomplete type /home/david/v4l-dvb/v4l/firedtv-1394.c: In function 'node_probe': /home/david/v4l-dvb/v4l/firedtv-1394.c:190:
Re: [Fwd: [Mjpeg-users] [PATCH] zoran: match parameter signedness of g_input_status]
Hi Bernhard ( Marton),
patch is OK with me, you can forward this to LKML, or better yet, to
the V4L maintainers (this is try#2 to CC them).
Cheers,
Ronald
2010/1/29 Bernhard Praschinger shadowl...@utanet.at:
Hallo
I hope that you got the mail to the mailinglist to. Can you please check it
and approve it or do something else with it ;)
auf hoffentlich bald,
Berni the Chaos of Woodquarter
Email: shadowl...@utanet.at
www: http://www.lysator.liu.se/~gz/bernhard
From: Márton Németh nm...@freemail.hu
The second parameter of g_input_status operation in media/v4l2-subdev.h
is unsigned so also call it with unsigned paramter.
This will remove the following sparse warning (see make C=1):
* incorrect type in argument 2 (different signedness)
expected unsigned int [usertype] *status
got int *noident
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 2a50a0a1c951 linux/drivers/media/video/zoran/zoran_device.c
--- a/linux/drivers/media/video/zoran/zoran_device.c Sat Jan 23 00:14:32
2010 -0200
+++ b/linux/drivers/media/video/zoran/zoran_device.c Sat Jan 23 07:57:09
2010 +0100
@@ -1197,7 +1197,8 @@
static void zoran_restart(struct zoran *zr)
{
/* Now the stat_comm buffer is ready for restart */
- int status = 0, mode;
+ unsigned int status = 0;
+ int mode;
if (zr-codec_mode == BUZ_MODE_MOTION_COMPRESS) {
decoder_call(zr, video, g_input_status, status);
diff -r 2a50a0a1c951 linux/drivers/media/video/zoran/zoran_driver.c
--- a/linux/drivers/media/video/zoran/zoran_driver.c Sat Jan 23 00:14:32
2010 -0200
+++ b/linux/drivers/media/video/zoran/zoran_driver.c Sat Jan 23 07:57:09
2010 +0100
@@ -1452,7 +1452,7 @@
}
if (norm == V4L2_STD_ALL) {
- int status = 0;
+ unsigned int status = 0;
v4l2_std_id std = 0;
decoder_call(zr, video, querystd, std);
--
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for
Conference
attendees to learn about information security's most important issues
through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
___
Mjpeg-users mailing list
mjpeg-us...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] uvcvideo: check minimum border of control
Mauro Carvalho Chehab wrote: Németh Márton wrote: Check also the minimum border of a value before setting it to a control value. See also http://bugzilla.kernel.org/show_bug.cgi?id=12824 . Patch didn't apply. Had you generated against our -git tree? http://git.linuxtv.org/v4l-dvb.git No, this is against http://git.linuxtv.org/pinchartl/uvcvideo.git . The latest patch which tried to fix http://bugzilla.kernel.org/show_bug.cgi?id=12824 missed to check the minimum border. Regards, Márton Németh Signed-off-by: Márton Németh nm...@freemail.hu --- drivers/media/video/uvc/uvc_ctrl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c --- a/drivers/media/video/uvc/uvc_ctrl.c +++ b/drivers/media/video/uvc/uvc_ctrl.c @@ -1068,6 +1068,8 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); xctrl-value = min + (xctrl-value - min + step/2) / step * step; +if (xctrl-value min) +xctrl-value = min; if (xctrl-value max) xctrl-value = max; value = xctrl-value; -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] uvcvideo: check minimum border of control
Németh Márton wrote: Mauro Carvalho Chehab wrote: Németh Márton wrote: Check also the minimum border of a value before setting it to a control value. See also http://bugzilla.kernel.org/show_bug.cgi?id=12824 . Patch didn't apply. Had you generated against our -git tree? http://git.linuxtv.org/v4l-dvb.git No, this is against http://git.linuxtv.org/pinchartl/uvcvideo.git . The latest patch which tried to fix http://bugzilla.kernel.org/show_bug.cgi?id=12824 missed to check the minimum border. Ah, ok. Please specify on the subject when you're writing patches against a different tree. This helps me to tag accordingly at Patchwork, saving me some time. Regards, Márton Németh Signed-off-by: Márton Németh nm...@freemail.hu -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: How can I add IR remote to this new device (DIKOM DK300)?
andrea.amoros...@gmail.com wrote: Mauro Carvalho Chehab ha scritto: andrea.amoros...@gmail.com wrote: So since it is necessary to create a new entry, is there any rules to follow to choose it? Just use the existing entry as an example. You'll need to put your card name at the entry, and add a new #define at em28xx.h. Cheers, Mauro Ok! As far as the auto detection issue is concerned, can I add the EEPROM ID and hash so that to use such data to detect the DIKOM device? I've seen that the same numbers are not present for other devices, so I think adding them should not create problems with other devices, but I'm not sure regard that. Yes, but the code will need to be changed a little bit, since the eeprom id detection happens only for some specific usb id's. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] uvcvideo: check minimum border of control
Mauro Carvalho Chehab wrote: Németh Márton wrote: Mauro Carvalho Chehab wrote: Németh Márton wrote: Check also the minimum border of a value before setting it to a control value. See also http://bugzilla.kernel.org/show_bug.cgi?id=12824 . Patch didn't apply. Had you generated against our -git tree? http://git.linuxtv.org/v4l-dvb.git No, this is against http://git.linuxtv.org/pinchartl/uvcvideo.git . The latest patch which tried to fix http://bugzilla.kernel.org/show_bug.cgi?id=12824 missed to check the minimum border. Ah, ok. Please specify on the subject when you're writing patches against a different tree. This helps me to tag accordingly at Patchwork, Could you please give me an example what do you mean? For example in this case. Regards, Márton Németh -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Make failed - standard ubuntu 9.10
On Fri, Jan 29, 2010 at 11:02 AM, David Henig dhhe...@googlemail.com wrote: Thanks, I appear to have the headers and no longer have to do the symlink, but still getting the same error - any help gratefully received, or do I need to get a vanilla kernel? Open up the file v4l/.config and change the line for firedtv from =m to =n. Then run make. This is a known packaging bug in Ubuntu's kernel headers. Cheers, Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] uvcvideo: check minimum border of control
Németh Márton wrote: Mauro Carvalho Chehab wrote: Németh Márton wrote: Mauro Carvalho Chehab wrote: Németh Márton wrote: Check also the minimum border of a value before setting it to a control value. See also http://bugzilla.kernel.org/show_bug.cgi?id=12824 . Patch didn't apply. Had you generated against our -git tree? http://git.linuxtv.org/v4l-dvb.git No, this is against http://git.linuxtv.org/pinchartl/uvcvideo.git . The latest patch which tried to fix http://bugzilla.kernel.org/show_bug.cgi?id=12824 missed to check the minimum border. Ah, ok. Please specify on the subject when you're writing patches against a different tree. This helps me to tag accordingly at Patchwork, Could you please give me an example what do you mean? For example in this case. You could for example, use at the subject: [PATCH uvc tree] patch description This helps me to not assume that it is against the upstream tree. -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cx18 fix patches
Hi Andy, On Thu, Jan 28, 2010 at 9:24 PM, Andy Walls awa...@radix.net wrote: Devin, I found interesting system interactions. On my dual core x86_64 Fedora 12 machine loading an HVR-1600 cold (no firmware has been loaded yet), the pulseaudio daemon opens up a CX23418 ALSA node almost immediately after it appears and has these effects: 1. Pulseaudio tries to perform some sort of op that starts a capture on the PCM stream before the APU and CPU firmware has finished loading. This results in error messages in the log and probably an undesirable driver state, if there was never any firmware loaded prior - such as at power up. I'm a little surprised by that, since the cx18-alsa module is only initialized after the rest of the cx18 driver is loaded. 2. Pulseaudio grabs the ALSA control node for the CX23418 and won't let go. If I kill the Pulseaudio process that has the node open, it just respawns and grabs the control node again. This prevents unloading the cx18-alsa and cx18 module. As far as I know, this is one of those dumb Pulseaudio things. Doesn't it do this with all PCI cards that provide ALSA? 3. If Pulseaudio also keeps the PCM analog stream going, then TV image settings are fixed to the values at the time Pulseaudio started the stream. I don't think it does, but I'm not sure yet. I know that Pulseaudio binds to the device, but as far as I know it does not actually open the PCM device for streaming. My off the cuff ideas for fixes are: 1. Integrate cx18-alsa functions into the driver and no longer have it as a module, to better coordinate firmware loading with the ALSA nodes. (The modular architecture appears to have been a bad choice on my part.) I'm not against merging the two into a single module, although it's not clear to me that it will help with the issues you are seeing. 2. Add a module option to disable setting up the cx18-alsa device nodes. I can see some value in such an option in general for debugging purposes, although I don't think it provides a whole lot of value for regular users who would not normally have it enabled. I'll try to work on these this Friday and Saturday. I will be out of town this weekend, but if you send me email I will try to respond as promptly as possible. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Make failed - standard ubuntu 9.10
Thanks, this is sounding promising, only thing is I'm not seeing a .config in the v4l directory although it shows up with the locate command, am I missing something very obvious. David Devin Heitmueller wrote: On Fri, Jan 29, 2010 at 11:02 AM, David Henig dhhe...@googlemail.com wrote: Thanks, I appear to have the headers and no longer have to do the symlink, but still getting the same error - any help gratefully received, or do I need to get a vanilla kernel? Open up the file v4l/.config and change the line for firedtv from =m to =n. Then run make. This is a known packaging bug in Ubuntu's kernel headers. Cheers, Devin -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Make failed - standard ubuntu 9.10
Devin Heitmueller wrote: On Fri, Jan 29, 2010 at 11:02 AM, David Henig dhhe...@googlemail.com wrote: Thanks, I appear to have the headers and no longer have to do the symlink, but still getting the same error - any help gratefully received, or do I need to get a vanilla kernel? Open up the file v4l/.config and change the line for firedtv from =m to =n. Then run make. This is a known packaging bug in Ubuntu's kernel headers. This issue is specific to Ubuntu. With Fedora and with upstream kernels, everything compiles fine. Maybe the better is if one of you that use Ubuntu to write a patch checking for the affected Ubuntu versions, and automatically disabling the compilation of this module, or doing some changes on compat.h to properly compile it. All it is needed is to patch one of some of those files: v4l/scripts/make_kconfig.pl (for the logic to disable it on Ubuntu) /v4l/compat.h (if is there some compat stuff that can be added) /v4l/scripts/make_config_compat.pl (for a most sophisticated logic based on some script) After having the patch done, just submit it to Douglas. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cx18 fix patches
Devin Heitmueller wrote: Hi Andy, On Thu, Jan 28, 2010 at 9:24 PM, Andy Walls awa...@radix.net wrote: Devin, I found interesting system interactions. On my dual core x86_64 Fedora 12 machine loading an HVR-1600 cold (no firmware has been loaded yet), the pulseaudio daemon opens up a CX23418 ALSA node almost immediately after it appears and has these effects: 1. Pulseaudio tries to perform some sort of op that starts a capture on the PCM stream before the APU and CPU firmware has finished loading. This results in error messages in the log and probably an undesirable driver state, if there was never any firmware loaded prior - such as at power up. I'm a little surprised by that, since the cx18-alsa module is only initialized after the rest of the cx18 driver is loaded. This is a problem that may affect all drivers: just after registering a device, udev (and other userspace tools) may try to use it. I doubt that making cx18-alsa part of cx18 would fix this issue. Also, it tends to became worse: as the number of CPU cores are increasing, the probability for reaching such race condition increases. The proper solution is to lock the driver while it is not completely initialized, or to delay the alsa registration to happen after having all firmware loaded. 2. Pulseaudio grabs the ALSA control node for the CX23418 and won't let go. If I kill the Pulseaudio process that has the node open, it just respawns and grabs the control node again. This prevents unloading the cx18-alsa and cx18 module. As far as I know, this is one of those dumb Pulseaudio things. Doesn't it do this with all PCI cards that provide ALSA? All cards that provide alsa support have this trouble, even without pulseaudio. kmixer does the same thing: when a new mixer is detected, it holds the mixer opened, preventing module unloading. 3. If Pulseaudio also keeps the PCM analog stream going, then TV image settings are fixed to the values at the time Pulseaudio started the stream. I don't think it does, but I'm not sure yet. I know that Pulseaudio binds to the device, but as far as I know it does not actually open the PCM device for streaming. Probably, it holds open just the mixer. My off the cuff ideas for fixes are: 1. Integrate cx18-alsa functions into the driver and no longer have it as a module, to better coordinate firmware loading with the ALSA nodes. (The modular architecture appears to have been a bad choice on my part.) I'm not against merging the two into a single module, although it's not clear to me that it will help with the issues you are seeing. I doubt it would solve. IMO, having it modular is good, since you may not need cx18 alsa on all devices. -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cx18 fix patches
On Fri, Jan 29, 2010 at 1:40 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: I doubt it would solve. IMO, having it modular is good, since you may not need cx18 alsa on all devices. Modularity is good, but we really need to rethink about the way we are loading these modules (this applies to dvb as well). For example, on em28xx, the dvb module is often getting loaded while at the same that hald is connecting to the v4l2 device (resulting in i2c errors while attempting to talk to tvp5150). A simple initialization lock would seem like a good idea, except that doesn't really work because the em28xx submodules get loaded asynchronously. And the problem isn't specific to em28xx by any means. I've hit comparable bugs in cx88. If we didn't load the modules asynchronously, then at least we would be able to hold the lock throughout the entire device initialization (ensuring that nobody can connect to the v4l2 device while the dvb and alsa drivers are initializing). Sure, it in theory adds a second or two to the module load (depending on the device), but we would have a much simpler model that would be less prone to race conditions. We would also lose the ability to modprobe the dvb module after-the-fact (and expect it to bind to existing devices), but I don't really think that would be a big deal since everything is auto-detected anyway. In fact, it might actually be a good thing given the number of times I've had to explain to people that you cannot do modprobe em28xx-dvb on an unsupported device and expect it to magically start working. I didn't mean to hijack the thread, but I'm just trying to point out that this is a pretty widespread problem, and not specific to cx18. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Make failed - standard ubuntu 9.10
David Henig wrote: Thanks, this is sounding promising, only thing is I'm not seeing a .config in the v4l directory although it shows up with the locate command, am I missing something very obvious. Sorry if I'm telling evidence, but just a hint: every file starts with . is a hidden file. So you'll need something like ls -a lib/modules/2.6.31-17-generic/build/.config , see man ls. Regards, Márton Németh Devin Heitmueller wrote: On Fri, Jan 29, 2010 at 11:02 AM, David Henig dhhe...@googlemail.com wrote: Thanks, I appear to have the headers and no longer have to do the symlink, but still getting the same error - any help gratefully received, or do I need to get a vanilla kernel? Open up the file v4l/.config and change the line for firedtv from =m to =n. Then run make. This is a known packaging bug in Ubuntu's kernel headers. Cheers, Devin -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cx18 fix patches
Devin Heitmueller wrote: On Fri, Jan 29, 2010 at 1:40 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: I doubt it would solve. IMO, having it modular is good, since you may not need cx18 alsa on all devices. Modularity is good, but we really need to rethink about the way we are loading these modules (this applies to dvb as well). For example, on em28xx, the dvb module is often getting loaded while at the same that hald is connecting to the v4l2 device (resulting in i2c errors while attempting to talk to tvp5150). A simple initialization lock would seem like a good idea, except that doesn't really work because the em28xx submodules get loaded asynchronously. And the problem isn't specific to em28xx by any means. I've hit comparable bugs in cx88. If we didn't load the modules asynchronously, then at least we would be able to hold the lock throughout the entire device initialization (ensuring that nobody can connect to the v4l2 device while the dvb and alsa drivers are initializing). Sure, it in theory adds a second or two to the module load (depending on the device), but we would have a much simpler model that would be less prone to race conditions. The asynchronous load were added not to improve the boot load time, but to avoid some troubles that happens when the load is synchronous. I don't remember what were the exact trouble, but I suspect that it was something related to i2c. The result was that, sometimes, the driver used to enter into a deadlock state (something like driver A waits for driver B to load, but, as driver B needs functions provided by driver A, both are put into sleep). Also, reducing the driver load time is a good thing. The asynchronous load is very interesting for devices where the firmware load takes a very long time. I love the fact that new kernels with new distros boot the machine on a few seconds. This is thanks to some asynchronous loads that happen on several drivers. The removal of KBL from open/close/ioct2 is one of the reasons for those improvements. Of course, if the driver is not properly locked, it will cause race conditions. Maybe one alternative would be to register the interfaces asynchronously also, as a deferred task that is started only after the driver enters into a sane state. For example, a kref may be used to indicate that there are init tasks pending. Only after having kref zeroed, the driver registers. As kref_put() automatically calls a routine when the usage count reaches zero, it shouldn't be hard to implement such locking schema. As the problem is common, the better is to provide a global way to avoid device open while the initialization is not complete, at the v4l core. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH gspca_jf tree] gspca zc3xx: signal when unknown packet received
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 95d3956ea3e5 linux/drivers/media/video/gspca/zc3xx.c
--- a/linux/drivers/media/video/gspca/zc3xx.c Fri Jan 29 15:05:25 2010 +0100
+++ b/linux/drivers/media/video/gspca/zc3xx.c Fri Jan 29 21:01:52 2010 +0100
@@ -7213,14 +7213,17 @@
u8 *data, /* interrupt packet data */
int len)/* interrput packet length */
{
+ int ret = -EINVAL;
+
if (len == 8 data[4] == 1) {
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 1);
input_sync(gspca_dev-input_dev);
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 0);
input_sync(gspca_dev-input_dev);
+ ret = 0;
}
- return 0;
+ return ret;
}
#endif
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Fri Jan 29 19:00:11 CET 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14067:8b9a62386b64 gcc version: i686-linux-gcc (GCC) 4.4.3 host hardware:x86_64 host os: 2.6.32.5 linux-2.6.32.6-armv5: OK linux-2.6.33-rc5-armv5: OK linux-2.6.32.6-armv5-davinci: WARNINGS linux-2.6.33-rc5-armv5-davinci: WARNINGS linux-2.6.32.6-armv5-dm365: ERRORS linux-2.6.33-rc5-armv5-dm365: ERRORS linux-2.6.32.6-armv5-ixp: WARNINGS linux-2.6.33-rc5-armv5-ixp: WARNINGS linux-2.6.32.6-armv5-omap2: WARNINGS linux-2.6.33-rc5-armv5-omap2: WARNINGS linux-2.6.22.19-i686: WARNINGS linux-2.6.23.17-i686: WARNINGS linux-2.6.24.7-i686: WARNINGS linux-2.6.25.20-i686: WARNINGS linux-2.6.26.8-i686: WARNINGS linux-2.6.27.44-i686: WARNINGS linux-2.6.28.10-i686: WARNINGS linux-2.6.29.1-i686: WARNINGS linux-2.6.30.10-i686: WARNINGS linux-2.6.31.12-i686: WARNINGS linux-2.6.32.6-i686: WARNINGS linux-2.6.33-rc5-i686: WARNINGS linux-2.6.32.6-m32r: OK linux-2.6.33-rc5-m32r: OK linux-2.6.32.6-mips: WARNINGS linux-2.6.33-rc5-mips: WARNINGS linux-2.6.32.6-powerpc64: WARNINGS linux-2.6.33-rc5-powerpc64: WARNINGS linux-2.6.22.19-x86_64: WARNINGS linux-2.6.23.17-x86_64: WARNINGS linux-2.6.24.7-x86_64: WARNINGS linux-2.6.25.20-x86_64: WARNINGS linux-2.6.26.8-x86_64: WARNINGS linux-2.6.27.44-x86_64: WARNINGS linux-2.6.28.10-x86_64: WARNINGS linux-2.6.29.1-x86_64: WARNINGS linux-2.6.30.10-x86_64: WARNINGS linux-2.6.31.12-x86_64: WARNINGS linux-2.6.32.6-x86_64: WARNINGS linux-2.6.33-rc5-x86_64: WARNINGS spec: OK sparse (linux-2.6.32.6): ERRORS sparse (linux-2.6.33-rc5): ERRORS linux-2.6.16.62-i686: ERRORS linux-2.6.17.14-i686: ERRORS linux-2.6.18.8-i686: ERRORS linux-2.6.19.7-i686: OK linux-2.6.20.21-i686: WARNINGS linux-2.6.21.7-i686: WARNINGS linux-2.6.16.62-x86_64: ERRORS linux-2.6.17.14-x86_64: ERRORS linux-2.6.18.8-x86_64: ERRORS linux-2.6.19.7-x86_64: WARNINGS linux-2.6.20.21-x86_64: WARNINGS linux-2.6.21.7-x86_64: WARNINGS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Friday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Friday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cx18 fix patches
On Fri, Jan 29, 2010 at 2:59 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: The asynchronous load were added not to improve the boot load time, but to avoid some troubles that happens when the load is synchronous. I don't remember what were the exact trouble, but I suspect that it was something related to i2c. The result was that, sometimes, the driver used to enter into a deadlock state (something like driver A waits for driver B to load, but, as driver B needs functions provided by driver A, both are put into sleep). It would be good if you could locate some specifics in terms of what prompted this. Also, reducing the driver load time is a good thing. The asynchronous load is very interesting for devices where the firmware load takes a very long time. I do not believe that loading the module synchronously will have any impact on the actual load time, since other modules can be loading in parallel to the initialization of the em28xx device (regardless of whether it is a single module, or three modules loading synchronously or asynchronously). Also, for xc3028 in particular, we could defer firmware loading until first use like we do with xc5000 - doing the firmware load at driver init isn't very useful anyway since we load the firmware and then immediately and put the device to sleep. Maybe one alternative would be to register the interfaces asynchronously also, as a deferred task that is started only after the driver enters into a sane state. Potentially. I feel this should really only be done though in response to an actual problem/bug. Otherwise it adds additional complexity with no real benefit. As the problem is common, the better is to provide a global way to avoid device open while the initialization is not complete, at the v4l core. I would be in favor of this, although I am not sure how practical it is given the diversity in the way different bridges are implemented. Also, we would need to take into account how this would work with DVB, since many of the races we run into are applications attempting to use both the v4l and dvb interfaces of a hybrid device. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] hdpvr-core: make module parameters local
From: Márton Németh nm...@freemail.hu The default_video_input and default_audio_input module parameters are only used inside the hdpvr-core.c file so make them static. This will remove the following sparse warnings (see make C=1): * warning: symbol 'default_video_input' was not declared. Should it be static? * warning: symbol 'default_audio_input' was not declared. Should it be static? Signed-off-by: Márton Németh nm...@freemail.hu --- diff -r 8b9a62386b64 linux/drivers/media/video/hdpvr/hdpvr-core.c --- a/linux/drivers/media/video/hdpvr/hdpvr-core.c Fri Jan 29 01:23:57 2010 -0200 +++ b/linux/drivers/media/video/hdpvr/hdpvr-core.c Fri Jan 29 21:25:45 2010 +0100 @@ -39,12 +39,12 @@ module_param(hdpvr_debug, int, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(hdpvr_debug, enable debugging output); -uint default_video_input = HDPVR_VIDEO_INPUTS; +static uint default_video_input = HDPVR_VIDEO_INPUTS; module_param(default_video_input, uint, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(default_video_input, default video input: 0=Component / 1=S-Video / 2=Composite); -uint default_audio_input = HDPVR_AUDIO_INPUTS; +static uint default_audio_input = HDPVR_AUDIO_INPUTS; module_param(default_audio_input, uint, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(default_audio_input, default audio input: 0=RCA back / 1=RCA front / 2=S/PDIF); -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] smsir: make local variables static
From: Márton Németh nm...@freemail.hu
Make the file local parameters static.
This will remove the following sparse warnings (see make C=1):
* warning: symbol 'ir_pos' was not declared. Should it be static?
* warning: symbol 'ir_word' was not declared. Should it be static?
* warning: symbol 'ir_toggle' was not declared. Should it be static?
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 8b9a62386b64 linux/drivers/media/dvb/siano/smsir.c
--- a/linux/drivers/media/dvb/siano/smsir.c Fri Jan 29 01:23:57 2010 -0200
+++ b/linux/drivers/media/dvb/siano/smsir.c Fri Jan 29 21:39:06 2010 +0100
@@ -85,9 +85,9 @@
{ } /* Terminating entry */
};
-u32 ir_pos;
-u32ir_word;
-u32 ir_toggle;
+static u32 ir_pos;
+static u32 ir_word;
+static u32 ir_toggle;
#define RC5_PUSH_BIT(dst, bit, pos)\
{ dst = 1; dst |= bit; pos++; }
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH gspca_jf tree] gspca zc3xx: signal when unknown packet received
Hi,
Nack!
Németh I know you mean well, but please don't go making
semi random behavior changes to code you don't have
hardware to test with.
There is a good reason this code is written the way it is.
Jean-Francois,
If you wonder what this is all about, this is a patch on
top of one of my trees which no one else has yet as
I have not send any pull request yet, see:
http://linuxtv.org/hg/~hgoede/gspca_jf
So back to the reason why this code is written the way it is,
the zc3xx sends a steady stream of interrupt packets consisting
of usually 8 0 byes, we definitely do not want to print out an
error message every time such a packet is received.
On some cams when they are just plugged in the 6th byte (data[5])
becomes 1 a couple of times, probably a floating pin.
And on all cams with a button, pressing that will make the
5th byte (data[4]) 1. As said these cam sends a steady
stream of interrupt packets, reporting I guess the
status of 8 gpio pins independent on whether this status
has changed since the last packet or not.
I've tested this with the following cams:
Logitech QuickCam IM/Connect046d:08d9 zc3xx HV7131R
Logitech QuickCam E2500 046d:089d zc3xx MC501CB
Labtec notebook cam 046d:08aa zc3xx PAS202B
Creative WebCam Notebook041e:401f zc3xx TAS5130C
Creative Live! Cam Video IM 041e:4053 zc3xx TAS5130-VF250
Philips SPC 200NC 0471:0325 zc3xx PAS106
Creative WebCam NX Pro 041e:401e zc3xx HV7131B
No brand0ac8:307b zc3xx ADCM2700
Regards,
Hans
On 01/29/2010 09:07 PM, Németh Márton wrote:
Signed-off-by: Márton Némethnm...@freemail.hu
---
diff -r 95d3956ea3e5 linux/drivers/media/video/gspca/zc3xx.c
--- a/linux/drivers/media/video/gspca/zc3xx.c Fri Jan 29 15:05:25 2010 +0100
+++ b/linux/drivers/media/video/gspca/zc3xx.c Fri Jan 29 21:01:52 2010 +0100
@@ -7213,14 +7213,17 @@
u8 *data, /* interrupt packet data */
int len)/* interrput packet length */
{
+ int ret = -EINVAL;
+
if (len == 8 data[4] == 1) {
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 1);
input_sync(gspca_dev-input_dev);
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 0);
input_sync(gspca_dev-input_dev);
+ ret = 0;
}
- return 0;
+ return ret;
}
#endif
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH gspca_jf tree] gspca zc3xx: signal when unknown packet received
Hans de Goede wrote:
Hi,
Nack!
Németh I know you mean well, but please don't go making
semi random behavior changes to code you don't have
hardware to test with.
I thought it is easier to write the patch I was thinking of than trying
to describe it in words. Maybe it was not the best idea, sorry about that.
There is a good reason this code is written the way it is.
Jean-Francois,
If you wonder what this is all about, this is a patch on
top of one of my trees which no one else has yet as
I have not send any pull request yet, see:
http://linuxtv.org/hg/~hgoede/gspca_jf
So back to the reason why this code is written the way it is,
the zc3xx sends a steady stream of interrupt packets consisting
of usually 8 0 byes, we definitely do not want to print out an
error message every time such a packet is received.
On some cams when they are just plugged in the 6th byte (data[5])
becomes 1 a couple of times, probably a floating pin.
And on all cams with a button, pressing that will make the
5th byte (data[4]) 1. As said these cam sends a steady
stream of interrupt packets, reporting I guess the
status of 8 gpio pins independent on whether this status
has changed since the last packet or not.
Based on your description the following two lines could be separated:
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 1);
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 0);
The first line should go when we detect a 0-1 transient (button push),
the second one when there is an 1-0 transient (button release).
In case of pac7302 there was only one event at button push. So there was
a need to simulate push and release. The camera haven't sent anything
when the button was released.
I've tested this with the following cams:
Logitech QuickCam IM/Connect046d:08d9 zc3xx HV7131R
Logitech QuickCam E2500 046d:089d zc3xx MC501CB
Labtec notebook cam 046d:08aa zc3xx PAS202B
Creative WebCam Notebook041e:401f zc3xx TAS5130C
Creative Live! Cam Video IM 041e:4053 zc3xx TAS5130-VF250
Philips SPC 200NC 0471:0325 zc3xx PAS106
Creative WebCam NX Pro 041e:401e zc3xx HV7131B
No brand0ac8:307b zc3xx ADCM2700
Regards,
Hans
On 01/29/2010 09:07 PM, Németh Márton wrote:
Signed-off-by: Márton Némethnm...@freemail.hu
---
diff -r 95d3956ea3e5 linux/drivers/media/video/gspca/zc3xx.c
--- a/linux/drivers/media/video/gspca/zc3xx.cFri Jan 29 15:05:25
2010 +0100
+++ b/linux/drivers/media/video/gspca/zc3xx.cFri Jan 29 21:01:52
2010 +0100
@@ -7213,14 +7213,17 @@
u8 *data, /* interrupt packet data */
int len)/* interrput packet length */
{
+int ret = -EINVAL;
+
if (len == 8 data[4] == 1) {
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 1);
input_sync(gspca_dev-input_dev);
input_report_key(gspca_dev-input_dev, KEY_CAMERA, 0);
input_sync(gspca_dev-input_dev);
+ret = 0;
}
-return 0;
+return ret;
}
#endif
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Hi, Am Freitag, den 29.01.2010, 13:40 -0200 schrieb Mauro Carvalho Chehab: Jean Delvare wrote: From: Jean Delvare kh...@linux-fr.org Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131 Analog (card=146). However, by the time we find out, some card-specific initialization is missed. In particular, the fact that the IR is GPIO-based. Set it when we change the card type. We also have to move the initialization of IR until after the card number has been changed. I hope that this won't cause any problem. Hi Jean, Moving the initialization will likely cause regressions. The reason why there are two init codes there were due to the way the old i2c code used to work. This got fixed after the i2c rework, but it caused regressions on that time. The proper way would be to just muve the IR initialization on this board from init1 to init2, instead of changing it for all other devices. cheers, Mauro Mauro, I do agree with you that it is likely better to go a way with minimum chances for regressions, also given the current testing base and that only this single card is involved.. Do we end up with something card specific in core code here? After all, we know this is a no go. Hartmut and me thought back and forth on how to deal with it for quite some while, unfortunately Hartmut is not present currently on the list, but he voted for to have a separate entry for that card finally too. What we seem to have now is: 1. We don't know, if Jean's patch really would cause regressions, but it is likely hard to get all the testing done. No problems with a FlyVideo3000 gpio remote at the time Roman suggested it, but I had not any i2c remote that time ... 2. The previous situation was, that this analog only card did use the entry of the Ausus P7131 Dual forcing card=78 without problems, but getting fake support for DVB-T announced and printing results of some fall through. 3. If we agree, that unique PCI subsystems should have highest priority for auto detection, in such a case, we likely could also set the PC-39 remote for the older card with USB remote. IIRC, that should survive the later change of the card caused by the work around eeprom detection later, and disable IR based on eeprom for the older then. To be honest, as pointed to already in the other thread around this, we should not try to become better than all others on m$ previously for some very small gain. We are already much, much better than drivers there, excluding each others, don't follow Philips/NXP eeprom rules and so on. We could just print something like use card=number to get the remote up too, if people, not reading the lists ;), hope to rely on auto detection in vain ... About all the LNA and IR mess we have for other manufactures, nobody talks about anymore ... Given what is also in the cruft for bttv, I would not care too much for that single card on that now also ancient driver, just print what the user can do to escape and any google would find it quickly too. For Asus it is a unique problem on that driver so far. I should have some time on Sunday afternoon for testing, if we should go that way. Cheers, Hermann -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: fix regression in pwc_set_shutter_speed???
On Sat, Jan 30, 2010 at 12:03:09AM +, Jef Treece wrote: Here's a link to the previous message: http://www.mail-archive.com/linux-media@vger.kernel.org/msg14330.html Great. Video developers, any comments? Jef, were you able to narrow it down to the actual patch that caused the problem. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
PAC7302 short datasheet from PixArt
Hi, if anyone interested there is a brief overview datasheet about PixArt PAC7301/PAC7302 at http://www.pixart.com.tw/upload/PAC7301_7302%20%20Spec%20V1_20091228174030.pdf Regards, Márton Németh -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
