Re: [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

[Simon Horman]

On Tue, Oct 17, 2017 at 01:39:33AM +, Yoshihiro Shimoda wrote:
> Hi Biju-san,
> 
> IIUC, when we submitted a patch for dts[i] file,
> we don't need to submit such a patch to usb maintainers.
> 
> > From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> > 
> > From: Fabrizio Castro 
> > 
> > Add node for xhci. Boards DT files will enable it if needed.
> > 
> > Signed-off-by: Fabrizio Castro 
> > ---
> >  arch/arm/boot/dts/r8a7743.dtsi | 20 
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> > index 699c040..386bf07 100644
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -931,6 +931,26 @@
> > status = "disabled";
> > };
> > 
> > +   /*
> > +* pci1 and xhci share the same phy, therefore only one of them
> > +* can be active at any one time. If both of them are enabled,
> > +* a race condition will determine who'll control the phy.
> > +* A firmware file is needed by the xhci driver in order for
> > +* USB 3.0 to work properly.
> > +*/
> > +   xhci: usb@ee00 {
> > +   compatible = "renesas,xhci-r8a7743",
> > +"renesas,rcar-gen2-xhci";
> > +   reg = <0 0xee00 0 0xc00>;
> > +   interrupts = ;
> > +   clocks = < CPG_MOD 328>;
> > +   power-domains = < R8A7743_PD_ALWAYS_ON>;
> > +   resets = < 328>;
> > +   phys = < 1>;
> > +   phy-names = "usb";
> > +   status = "disabled";
> > +   };
> > +
> > sdhi0: sd@ee10 {
> > compatible = "renesas,sdhi-r8a7743";
> > reg = <0 0xee10 0 0x328>;
> 
> It seems good to me. So,
> 
> Reviewed-by: Yoshihiro Shimoda 

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

[Biju Das]

Hi Shimoda-San,


> Hi Biju-san,
>
> IIUC, when we submitted a patch for dts[i] file, we don't need to submit such 
> a
> patch to usb maintainers.

Thanks. I will take care this in future.

Regards,
Biju



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

[Yoshihiro Shimoda]

Hi Biju-san,

IIUC, when we submitted a patch for dts[i] file,
we don't need to submit such a patch to usb maintainers.

> From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> 
> From: Fabrizio Castro 
> 
> Add node for xhci. Boards DT files will enable it if needed.
> 
> Signed-off-by: Fabrizio Castro 
> ---
>  arch/arm/boot/dts/r8a7743.dtsi | 20 
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 699c040..386bf07 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -931,6 +931,26 @@
>   status = "disabled";
>   };
> 
> + /*
> +  * pci1 and xhci share the same phy, therefore only one of them
> +  * can be active at any one time. If both of them are enabled,
> +  * a race condition will determine who'll control the phy.
> +  * A firmware file is needed by the xhci driver in order for
> +  * USB 3.0 to work properly.
> +  */
> + xhci: usb@ee00 {
> + compatible = "renesas,xhci-r8a7743",
> +  "renesas,rcar-gen2-xhci";
> + reg = <0 0xee00 0 0xc00>;
> + interrupts = ;
> + clocks = < CPG_MOD 328>;
> + power-domains = < R8A7743_PD_ALWAYS_ON>;
> + resets = < 328>;
> + phys = < 1>;
> + phy-names = "usb";
> + status = "disabled";
> + };
> +
>   sdhi0: sd@ee10 {
>   compatible = "renesas,sdhi-r8a7743";
>   reg = <0 0xee10 0 0x328>;

It seems good to me. So,

Reviewed-by: Yoshihiro Shimoda 

Best regards,
Yoshihiro Shimoda

> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

[Biju Das]

From: Fabrizio Castro 

Add node for xhci. Boards DT files will enable it if needed.

Signed-off-by: Fabrizio Castro 
---
 arch/arm/boot/dts/r8a7743.dtsi | 20 
 1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 699c040..386bf07 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -931,6 +931,26 @@
status = "disabled";
};
 
+   /*
+* pci1 and xhci share the same phy, therefore only one of them
+* can be active at any one time. If both of them are enabled,
+* a race condition will determine who'll control the phy.
+* A firmware file is needed by the xhci driver in order for
+* USB 3.0 to work properly.
+*/
+   xhci: usb@ee00 {
+   compatible = "renesas,xhci-r8a7743",
+"renesas,rcar-gen2-xhci";
+   reg = <0 0xee00 0 0xc00>;
+   interrupts = ;
+   clocks = < CPG_MOD 328>;
+   power-domains = < R8A7743_PD_ALWAYS_ON>;
+   resets = < 328>;
+   phys = < 1>;
+   phy-names = "usb";
+   status = "disabled";
+   };
+
sdhi0: sd@ee10 {
compatible = "renesas,sdhi-r8a7743";
reg = <0 0xee10 0 0x328>;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html