Re: [lldb-dev] Current state of the unit tests

[Vedant Kumar via lldb-dev]

> On Feb 23, 2018, at 3:17 PM, Vedant Kumar via lldb-dev 
>  wrote:
> 
> Hi,
> 
> At the moment, I'm seeing two issues with the unit tests on my machine.
> 
> First, TestBase.LaunchModePreservesEnvironment is failing:
> 
>> [ RUN  ] TestBase.LaunchModePreservesEnvironment
>> /Users/vsk/src/llvm.org-lldbsan/llvm/tools/lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp:30:
>>  Failure
>> Value of: 
>> llvm::detail::TakeExpected(Client.GetLatestStopReplyAs())
>> Expected: succeeded with value (is an object whose given property is equal 
>> to 2-byte object <00-00>)
>>  Actual: succeeded with value 16-byte object <10-60 A7-04 01-00 00-00 01-00 
>> 00-00 00-00 00-30>, whose given property is 2-byte object <00-01>(is an 
>> object whose given property isn't equal to 2-byte object <00-00>)
>> [  FAILED  ] TestBase.LaunchModePreservesEnvironment (67 ms)
> 
> I filed https://bugs.llvm.org/show_bug.cgi?id=36494 to track the issue.

^ This issue is resolved now with a cmake fix.


> Second, TestClient::SendMessage is generating quite a lot of "INFO" output 
> which clutters up the terminal. Pavel, would you mind if I removed this 
> logging?

^ I'll let Pavel decide the best way to deal with this one.

vedant

> 
> thanks,
> vedant
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Current state of the unit tests

[Pavel Labath via lldb-dev]

On 23 February 2018 at 16:19, Adrian McCarthy  wrote:
> I'm also seeing windows appear and quickly vanish a several times while
> running the lit tests.

That's because the tests run inferiors and lldb on windows will always
run them in a separate console window. IIRC, there is a special hack
in dotest, which prevents opening windows for testing. You probably
need something like that for lit tests as well.
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Current state of the unit tests

[Pavel Labath via lldb-dev]

Yeah, if a lit test fails, the dotest tests will not get run. That is
fine, but having a target which only runs dotest tests would probably
be nice as well.

On 23 February 2018 at 16:15, Vedant Kumar  wrote:
> check-lldb-lit should just be a dependency of check-lldb, so the dotest.py
> tests should still run.
>
> Are one of the lit tests failing? That might explain why subsequent tests
> aren't run.
>
> vedant
>
> On Feb 23, 2018, at 4:13 PM, Adrian McCarthy  wrote:
>
> As of this afternoon, it seems ninja check-lldb runs only the lit tests and
> not the dotest.py tests.  Was this an intentional change?
>
> On Fri, Feb 23, 2018 at 3:36 PM, Vedant Kumar via lldb-dev
>  wrote:
>>
>> Cool, I'll work up a patch for this.
>>
>> And thanks for commenting on PR36494, I'm testing a fix out right now :).
>>
>> vedant
>>
>> On Feb 23, 2018, at 3:35 PM, Pavel Labath  wrote:
>>
>> On 23 February 2018 at 15:17, Vedant Kumar  wrote:
>>
>> Second, TestClient::SendMessage is generating quite a lot of "INFO" output
>> which clutters up the terminal. Pavel, would you mind if I removed this
>> logging?
>>
>>
>> Yeah, we should probably do that. The idea here was that the packet
>> log would provide you with additional context for the situation when
>> the test fails, but it *is* very verbose. I'll have to come up with a
>> better solution for error reporting here.
>>
>>
>>
>> ___
>> lldb-dev mailing list
>> lldb-dev@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>
>
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Current state of the unit tests

[Adrian McCarthy via lldb-dev]

Actually, it appears one of the lit tests is unexpectedly passing:

Unexpected Passing Tests (1):
lldb :: Expr/TestCallStdStringFunction.test

lit then returns an error code, and ninja bails before starting the
dotest.py tests:

FAILED: cmd.exe /C "cd /D D:\src\llvm\build\mono\tools\lldb\lit &&
C:\python_35\python_d.exe D:/src/llvm/build/mono/./bin/llvm-lit.py -sv
--param lldb_site_config=D:/src/llvm/build/mono/tools/lldb/lit/lit.site.cfg
--param
lldb_unit_site_config=D:/src/llvm/build/mono/tools/lldb/lit/Unit/lit.site.cfg
D:/src/llvm/build/mono/tools/lldb/lit"
ninja: build stopped: subcommand failed.

I'm also seeing windows appear and quickly vanish a several times while
running the lit tests.

On Fri, Feb 23, 2018 at 4:15 PM, Vedant Kumar  wrote:

> check-lldb-lit should just be a dependency of check-lldb, so the dotest.py
> tests should still run.
>
> Are one of the lit tests failing? That might explain why subsequent tests
> aren't run.
>
> vedant
>
> On Feb 23, 2018, at 4:13 PM, Adrian McCarthy  wrote:
>
> As of this afternoon, it seems ninja check-lldb runs *only* the lit tests
> and not the dotest.py tests.  Was this an intentional change?
>
> On Fri, Feb 23, 2018 at 3:36 PM, Vedant Kumar via lldb-dev <
> lldb-dev@lists.llvm.org> wrote:
>
>> Cool, I'll work up a patch for this.
>>
>> And thanks for commenting on PR36494, I'm testing a fix out right now :).
>>
>> vedant
>>
>> On Feb 23, 2018, at 3:35 PM, Pavel Labath  wrote:
>>
>> On 23 February 2018 at 15:17, Vedant Kumar  wrote:
>>
>> Second, TestClient::SendMessage is generating quite a lot of "INFO"
>> output which clutters up the terminal. Pavel, would you mind if I removed
>> this logging?
>>
>>
>> Yeah, we should probably do that. The idea here was that the packet
>> log would provide you with additional context for the situation when
>> the test fails, but it *is* very verbose. I'll have to come up with a
>> better solution for error reporting here.
>>
>>
>>
>> ___
>> lldb-dev mailing list
>> lldb-dev@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>
>>
>
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Current state of the unit tests

[Vedant Kumar via lldb-dev]

check-lldb-lit should just be a dependency of check-lldb, so the dotest.py 
tests should still run.

Are one of the lit tests failing? That might explain why subsequent tests 
aren't run.

vedant

> On Feb 23, 2018, at 4:13 PM, Adrian McCarthy  wrote:
> 
> As of this afternoon, it seems ninja check-lldb runs only the lit tests and 
> not the dotest.py tests.  Was this an intentional change?
> 
> On Fri, Feb 23, 2018 at 3:36 PM, Vedant Kumar via lldb-dev 
> > wrote:
> Cool, I'll work up a patch for this.
> 
> And thanks for commenting on PR36494, I'm testing a fix out right now :).
> 
> vedant
> 
>> On Feb 23, 2018, at 3:35 PM, Pavel Labath > > wrote:
>> 
>> On 23 February 2018 at 15:17, Vedant Kumar > > wrote:
>>> Second, TestClient::SendMessage is generating quite a lot of "INFO" output 
>>> which clutters up the terminal. Pavel, would you mind if I removed this 
>>> logging?
>>> 
>> 
>> Yeah, we should probably do that. The idea here was that the packet
>> log would provide you with additional context for the situation when
>> the test fails, but it *is* very verbose. I'll have to come up with a
>> better solution for error reporting here.
> 
> 
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org 
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev 
> 
> 
> 

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Current state of the unit tests

[Adrian McCarthy via lldb-dev]

As of this afternoon, it seems ninja check-lldb runs *only* the lit tests
and not the dotest.py tests.  Was this an intentional change?

On Fri, Feb 23, 2018 at 3:36 PM, Vedant Kumar via lldb-dev <
lldb-dev@lists.llvm.org> wrote:

> Cool, I'll work up a patch for this.
>
> And thanks for commenting on PR36494, I'm testing a fix out right now :).
>
> vedant
>
> On Feb 23, 2018, at 3:35 PM, Pavel Labath  wrote:
>
> On 23 February 2018 at 15:17, Vedant Kumar  wrote:
>
> Second, TestClient::SendMessage is generating quite a lot of "INFO" output
> which clutters up the terminal. Pavel, would you mind if I removed this
> logging?
>
>
> Yeah, we should probably do that. The idea here was that the packet
> log would provide you with additional context for the situation when
> the test fails, but it *is* very verbose. I'll have to come up with a
> better solution for error reporting here.
>
>
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Current state of the unit tests

[Vedant Kumar via lldb-dev]

Cool, I'll work up a patch for this.

And thanks for commenting on PR36494, I'm testing a fix out right now :).

vedant

> On Feb 23, 2018, at 3:35 PM, Pavel Labath  wrote:
> 
> On 23 February 2018 at 15:17, Vedant Kumar  wrote:
>> Second, TestClient::SendMessage is generating quite a lot of "INFO" output 
>> which clutters up the terminal. Pavel, would you mind if I removed this 
>> logging?
>> 
> 
> Yeah, we should probably do that. The idea here was that the packet
> log would provide you with additional context for the situation when
> the test fails, but it *is* very verbose. I'll have to come up with a
> better solution for error reporting here.

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Current state of the unit tests

[Pavel Labath via lldb-dev]

On 23 February 2018 at 15:17, Vedant Kumar  wrote:
> Second, TestClient::SendMessage is generating quite a lot of "INFO" output 
> which clutters up the terminal. Pavel, would you mind if I removed this 
> logging?
>

Yeah, we should probably do that. The idea here was that the packet
log would provide you with additional context for the situation when
the test fails, but it *is* very verbose. I'll have to come up with a
better solution for error reporting here.
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

[lldb-dev] Current state of the unit tests

[Vedant Kumar via lldb-dev]

Hi,

At the moment, I'm seeing two issues with the unit tests on my machine.

First, TestBase.LaunchModePreservesEnvironment is failing:

> [ RUN  ] TestBase.LaunchModePreservesEnvironment
> /Users/vsk/src/llvm.org-lldbsan/llvm/tools/lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp:30:
>  Failure
> Value of: 
> llvm::detail::TakeExpected(Client.GetLatestStopReplyAs())
> Expected: succeeded with value (is an object whose given property is equal to 
> 2-byte object <00-00>)
>   Actual: succeeded with value 16-byte object <10-60 A7-04 01-00 00-00 01-00 
> 00-00 00-00 00-30>, whose given property is 2-byte object <00-01>(is an 
> object whose given property isn't equal to 2-byte object <00-00>)
> [  FAILED  ] TestBase.LaunchModePreservesEnvironment (67 ms)

I filed https://bugs.llvm.org/show_bug.cgi?id=36494 to track the issue.

Second, TestClient::SendMessage is generating quite a lot of "INFO" output 
which clutters up the terminal. Pavel, would you mind if I removed this logging?

thanks,
vedant
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev