[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894466#comment-15894466
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user robcube commented on the issue:

https://github.com/apache/log4net/pull/16
  
Bingo, found the culprit:
```

  

```

Changed it to
` `

Problem solved. :-) I guess XmlLayoutSchemaLog4j isn't quite there yet.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893213#comment-15893213
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user NachbarsLumpi commented on the issue:

https://github.com/apache/log4net/pull/16
  
I guess that writing xml tags that include a namespace results in the 
observed exception. Few people use xml layouts for logs, so this might be a 
regression or an incompatibility that shows itself only with .net core. Would 
you please create an issue for this so that we can track it better? I encourage 
you further to investigate in this.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893084#comment-15893084
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user robcube commented on the issue:

https://github.com/apache/log4net/pull/16
  
Getting a weird error using .net core 1.1:
```
var logRepository = LogManager.GetRepository(Assembly.GetEntryAssembly());
XmlConfigurator.ConfigureAndWatch(logRepository, new 
FileInfo("log4net.config.xml"));
ILog Log = LogManager.GetLogger(typeof(Program));
Log.Debug("hey!");
```
at last line results in:
```
System.ArgumentException: Invalid name character in 'log4j:event'. The ':' 
character, hexadecimal value 0x0x3A, cannot be included in a name.
   at System.Xml.XmlWellFormedWriter.CheckNCName(String ncname)
   at System.Xml.XmlWellFormedWriter.WriteStartElement(String prefix, 
String localName, String ns)
   at log4net.Layout.XmlLayoutSchemaLog4j.FormatXml(XmlWriter writer, 
LoggingEvent loggingEvent)
   at log4net.Layout.XmlLayoutBase.Format(TextWriter writer, LoggingEvent 
loggingEvent)
   at log4net.Appender.FileAppender.Append(LoggingEvent loggingEvent)
   at log4net.Appender.AppenderSkeleton.DoAppend(LoggingEvent loggingEvent)
```



> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724387#comment-15724387
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I've spelled out 
https://github.com/apache/log4net/blob/6e8c0db1407a398fa64d72f89cf6b460ad209808/src/site/xdoc/release/framework-support.xml#L578
 which will become visible at 
http://logging.apache.org/log4net/release/framework-support.html once we cut 
the release. Also I'll make sure I list those limitations in the release notes 
and the announcement mail.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15720444#comment-15720444
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user SeanSnyders commented on the issue:

https://github.com/apache/log4net/pull/16
  
Right, okay.
Yes a a list of things not working would be great.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15719771#comment-15719771
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
Yes, that seems to be expected as 
`src/Util/PatternStringConverters/EnvironmentFolderPathPatternConverter` is 
among the excludes in 
https://github.com/apache/log4net/blob/trunk/netstandard/log4net/project.json#L32

We really need to document what is known to not work with .NET Core.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715897#comment-15715897
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user SeanSnyders commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig Great, I'll try it again.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715590#comment-15715590
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
@SeanSnyders I've updated the package at 
https://www.myget.org/feed/log4net-test/package/nuget/log4net (overwritten the 
original one)


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707754#comment-15707754
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I think c661441 holds the necessary changes. Unfortunately assembling the 
release bits for log4net still requires two different VMs and about an hour of 
time, so I may need a few days before I can re-create the package.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707737#comment-15707737
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
The [nuspec](https://github.com/apache/log4net/blob/trunk/log4net.nuspec) 
doesn't list any dependencies, this is because all dependencies of log4net are 
part of the framework for the Mono and .NET versions.

Re-reading the nuspec schema we probably need to add a dependency `group` 
with the `targetFramework` set properly.  I'll try to see what the nuspec 
created with `dotnet pack` looks like.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707610#comment-15707610
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user SeanSnyders commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig Yeah, I'm also trying to get my head around .Net Core project 
setup. Things have been quite a bit in flux!

I think one will need to spec the dependencies, no? I could have it by the 
tail, though
I'll try the other build you linked to as well.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707551#comment-15707551
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
Many thanks @SeanSnyders . You are the first one actually given the 
binaries a try - or the first one who tells us so.

I've built the myget package using .NET Core 1.0.0 (SDK Preview 2), I 
really hope we don't need to provide assemblies built for different .NET Core 
1.x versions.

As for dependencies of the package, I didn't add any for the .NET Core 
version, maybe I should have. To be honest I'm far from an expert WRT .NET Core.

A preview build of the traditional distributions can be found in 
http://stefan.samaflost.de/staging/log4net-2.0.6/log4net-2.0.6-bin-newkey.zip - 
this contains the pdb file.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707217#comment-15707217
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user SeanSnyders commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig I've downloaded[ your 2.0.6 version from myget 
](https://www.myget.org/feed/log4net-test/package/nuget/log4net )but get an 
exception thrown during init of my logger in a NetCoreApp 1.1.0 application 
targeting win10-x64.

Now, I'm a bit new to .Net Core, but my same code runs fine using latest 
2.0.5 on .Net 4.6.1.

Any chance of getting a `.pdb` of 2.0.6 so I can dig a bit deeper into 
where the exception occur with a sensible stack trace?

At a high level, I get these:

![image](https://cloud.githubusercontent.com/assets/1384135/20736496/d16db8a8-b70b-11e6-9926-242928f7f20e.png)

in my code on line 176  here:

![image](https://cloud.githubusercontent.com/assets/1384135/20736483/b6817fa2-b70b-11e6-9c00-cb9b179d99a1.png)

If I add the dependency of `System.Collections.NonGeneric 4.3.0` to my 
`project.json`, I still get an exception of:

![image](https://cloud.githubusercontent.com/assets/1384135/20736578/4d63a936-b70c-11e6-822b-f69e20e9a6b2.png)

Is the nuget package for 2.0.6 specifying all the dependencies? What am I 
missing here?






> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575727#comment-15575727
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user derFunk commented on the issue:

https://github.com/apache/log4net/pull/16
  
Awesome, thanks.

I shared your cry for help on [Hacker 
News](https://news.ycombinator.com/item?id=12708507), maybe this gets some 
traction. Also you should maybe also add log4net here: 
http://up-for-grabs.net/#/tags/logging.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575662#comment-15575662
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
@derFunk the mailing list comment was meant to say that there may be things 
going on that one might miss when not following the list. I must admit there 
isn't that much going on: 
https://blogs.apache.org/logging/entry/apache_log4net_needs_help

As for packages, I'm sorry, we're not prepared for that. We will be 
publishing the final release to nuget but the current test build looks like a 
real release internally, so we can't publish it there. I'd need to make myself 
familiar with myget first.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575653#comment-15575653
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user derFunk commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig sorry for not using the mailing list ;) one last thing: I'd love 
to test basically right now. I don't have a public NuGet repo at hands, would 
it be possible for you to push it somewhere? NuGet.org/MyGet.org? I can test 
with my private repo until then, but it would be more convenient to have it 
publicly available.

Grüße aus München.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575644#comment-15575644
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
log4net development is coordinated via the mailing list :-)


https://lists.apache.org/thread.html/3dafd7f063d6106ca9ca20379f5851a10e1588e9d1ce955d23e93a62@%3Clog4net-dev.logging.apache.org%3E

a test build has been available for about two weeks now, with nobody 
testing it, or so it seems.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575620#comment-15575620
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user derFunk commented on the issue:

https://github.com/apache/log4net/pull/16
  
AFAIU it seems we could have a NuGet package release already, or at least a 
pre-release.
Is there anything else open we can help?
Unfortunately only the NuGet repo owner can push.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542604#comment-15542604
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user NachbarsLumpi commented on the issue:

https://github.com/apache/log4net/pull/16
  
It is done when it is done. If you need it anytime sooner, get involved.

On 3 Oct 2016 4:22 p.m., "Ibrar Mumtaz"  wrote:

> Hi, do you guys have a release date for the new package? 2.0.6?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542530#comment-15542530
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user iby-dev commented on the issue:

https://github.com/apache/log4net/pull/16
  
Hi, do you guys have a release date for the new package? 2.0.6?


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527125#comment-15527125
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user wjdavis5 commented on the issue:

https://github.com/apache/log4net/pull/16
  
Oh I see, I misread that their chart there. Thanks for clarifying.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525695#comment-15525695
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user wjdavis5 commented on the issue:

https://github.com/apache/log4net/pull/16
  
Following the MSFT release yesterday - 
https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/

It looks like this should be bumped to Net Standard 1.6
I did so locally and the build output is good, I'll PR back to this fork to 
hopefully get this PR updated.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525671#comment-15525671
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user wjdavis5 commented on the issue:

https://github.com/apache/log4net/pull/16
  
Hello, we are very patiently awaiting this next release. Thank you for 
putting this together.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 2.0.6
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489373#comment-15489373
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
Thank you very much @chlowell 

@TAGC the code is in Apache's svn trunk and has been integrated with the 
build system by now. There are some lose ends and the biggest task is likely 
updating all documentation but I'm positive we aren't that far away from 
cutting the next release of log4net which will also include the .NET Core 
version. "not that far" may still get measured in weeks rather than days, 
though. 


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487988#comment-15487988
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user TAGC commented on the issue:

https://github.com/apache/log4net/pull/16
  
That's for the info.  


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487962#comment-15487962
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user chlowell commented on the issue:

https://github.com/apache/log4net/pull/16
  
This code has been merged into `trunk`. To my knowledge there's no 
published package, but you can build one with the dotnet CLI.

`ColoredConsoleAppender` isn't available for .NET Core because it uses 
Win32 APIs. `RollingFileAppender` is available, with the caveat that its file 
locking doesn't work on Linux.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487929#comment-15487929
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user TAGC commented on the issue:

https://github.com/apache/log4net/pull/16
  
How far along is the .NET Core migration? I'm planning to migrate one of my 
projects that currently targets .NET Framework 4.5.2 to .NET Core and one of 
its dependencies is Log4Net. I only use `ColoredConsoleAppenders` and 
`RollingFileAppenders` - are these still available in the version targeting 
.NET Core?


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487892#comment-15487892
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user chlowell commented on the issue:

https://github.com/apache/log4net/pull/16
  
No, there are significant differences. My first post details some important 
ones.

.NET Framework 4.6 implements `netstandard1.3`. This means it exposes all 
the APIs specified by `netstandard1.3` (and below). However, in terms of 
exposed APIs, `netstandard1.3` is a subset of .NET Framework 4.6. The latter 
exposes many APIs not specified by the former.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487841#comment-15487841
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user NachbarsLumpi commented on the issue:

https://github.com/apache/log4net/pull/16
  
So that means that the log4net assembly targeting .net core has the same 
capabilities like the one targeting the .net framework 4.6 and differs only in 
the fact that it targets .net core with netstandard1.3?


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487744#comment-15487744
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user chlowell commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig I chose the version number to prevent any confusion between 
prerelease and published packages. There's no reason not to change it before 
release.

I chose `netstandard1.3` because it's the lowest version with the required 
APIs. Targeting a higher version than necessary generally brings no benefit. 
For example, UAP 10.0 (the current version) supports `netstandard1.4`. If 
log4net targets `netstandard1.6`, UWP apps won't be able to use it (at least, 
not without a hack). There's more on this in the 
[docs](https://docs.microsoft.com/en-us/dotnet/articles/standard/library#net-platforms-support).

There's no need to worry about overriding--a project targeting .NET 
Framework 4.5 or below won't use the `netstandard1.3` assembly.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487281#comment-15487281
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I'm not sure this applies here as we are still creating specific assemblies 
for .NET 2.0 up to 4.5 - and all of them are superior to the .NET Core DLL as 
they provide an ADO.NET appender, for example. The assembly built here is only 
expected to be used for .NET Core. At least that's where I'd have expected it 
to get used.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486266#comment-15486266
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user niemyjski commented on the issue:

https://github.com/apache/log4net/pull/16
  
The lower the .net standard you can target the more places it will run. 1.0 
can run every where (1.0, 1.6, etc). You should be targeting 1.3 here.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419986#comment-15419986
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I've just diffed chlowell:log4net-core-pcl against my svn working copy of 
trunk and it looks as if there have been changes after the PR which makes 
identifying misses more difficult. I'll apply #30 and then we can all go from 
there.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419983#comment-15419983
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
@jasonwilliams200OK, thanks, but too late, I went off fixing it myself 
before I saw you comment. :-)

I'll diff my svn tree against a checkout of @chlowell's original branch to 
verify whether I missed more patch failures. It's pretty strange as I don't 
recall seeing any "hunk failed" messages.

BTW, this is the test result on Linux (Ubuntu 16.04, but I don't think it 
matters):

```
Errors and Failures
1) Failed : 
log4net.Tests.Appender.RollingFileAppenderTest.TestExclusiveLockLocks
  Log contents is not what is expected
  String lengths are both 38. Strings differ at index 0.
  Expected: "This is a message\nThis is a message 2\n"
  But was:  "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0This is a message 2\n"
  ---^
at log4net.Tests.Appender.RollingFileAppenderTest.AssertFileEquals(String 
filename, String contents) in 
/devel/ASF/log4net/trunk/tests/src/Appender/RollingFileAppenderTest.cs:line 1470
at log4net.Tests.Appender.RollingFileAppenderTest.TestExclusiveLockLocks() 
in /devel/ASF/log4net/trunk/tests/src/Appender/RollingFileAppenderTest.cs:line 
1570
Run Settings
WorkDirectory: /devel/ASF/log4net/trunk/netstandard
Test Run Summary
  Overall result: Failed
  Test Count: 145, Passed: 136, Failed: 1, Inconclusive: 0, Skipped: 8
Failed Tests - Failures: 1, Errors: 0, Invalid: 0
Skipped Tests - Ignored: 8, Explicit: 0, Other: 0
  Start time: 2016-08-13 16:05:11Z
End time: 2016-08-13 16:05:14Z
Duration: 2,964 seconds
Results saved as /devel/ASF/log4net/trunk/netstandard/TestResult.xml
SUMMARY: Total: 1 targets, Passed: 0, Failed: 1.
```


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419972#comment-15419972
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
I've installed the Linux version, this is what happens for me:

```
Compiling log4net for .NETStandard,Version=v1.3
/usr/share/dotnet/dotnet compile-csc 
@/devel/ASF/log4net/trunk/netstandard/log4net/obj/Debug/netstandard1.3/dotnet-compile.rsp
 returned Exit Code 1
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(164,33): error 
CS0115: 'FileAppender.LockingStream.BeginRead(byte[], int, int, AsyncCallback, 
object)': no suitable method found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(175,33): error 
CS0115: 'FileAppender.LockingStream.BeginWrite(byte[], int, int, AsyncCallback, 
object)': no suitable method found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(183,25): error 
CS0115: 'FileAppender.LockingStream.Close()': no suitable method found to 
override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(188,24): error 
CS0115: 'FileAppender.LockingStream.EndRead(IAsyncResult)': no suitable method 
found to override
/devel/ASF/log4net/trunk/src/Appender/FileAppender.cs(193,25): error 
CS0115: 'FileAppender.LockingStream.EndWrite(IAsyncResult)': no suitable method 
found to override

Compilation failed.
0 Warning(s)
5 Error(s)
```

I'll double check whether I've missed some changes to `FileAppender`.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419973#comment-15419973
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
@bodewig, #30 fixed exactly this issue. Can you try with my branch?


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419970#comment-15419970
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
Fixed the build breakage and feedback in #30.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Fix For: 1.2.16
>
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419912#comment-15419912
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
Thanks a lot @bodewig! I am definitely willing to participate. I will test 
out the master and try to incorporate the feedback in subsequent PR pronto 
(before you start cutting the release :stuck_out_tongue_winking_eye:). I have 
subscribed to log4net-dev mailing list.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419910#comment-15419910
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
Many thanks for your persistence.

I have applied the patch as is as it didn't break anything of the existing 
build. But I haven't even tried to build the .NET Core part itself - I'll do so 
later, and try to figure out how to cut releases that contain the .NET Core 
assembly as well as the current process is centered around NAnt.

I'd like to invite anybody interested in keeping log4net moving to join the 
log4net-dev mailing list and lend a hand. We are severely understaffed and can 
use any help.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419908#comment-15419908
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user asfgit closed the pull request at:

https://github.com/apache/log4net/pull/16


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[Stefan Bodewig (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419880#comment-15419880
 ] 

Stefan Bodewig commented on LOG4NET-467:


[~jasonwilliams200ok] the real problem here is lack of time. Neither 
[~nachbarslumpi] nor myself are able to devote as much time to log4net as would 
be necessary and despite all our efforts to find additional folks who'd stick 
around for longer than a single pull request, this just never happened.

Unfortunately the PR doesn't use NAnt - because it isn't possible at all, I 
guess, as NAnt seems to be stuck in a situation similar to ours. This also 
means the release process which is incredibly cumbersome anyway will now 
require to switch build tools. Figuring out how to do that is going to cost 
time. Same goes for updating the documentation.

Don't get me wrong, I really appreciate the effort being made, I'm just not 
able to keep up.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[Peter Jas (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419850#comment-15419850
 ] 

Peter Jas commented on LOG4NET-467:
---

[~bodewig], [~nachbarslumpi],

Could you please spare sometime here? This proposal is opened for over an year 
now. .NET Core has been RTM'd for a dozen of operating systems. For most part, 
it is working out quite well for masses.

If this patch is passing all tests, working for us locally, on Travis / 
AppVeyor / Jenkins CIS' and everywhere we need log4net, is there still a reason 
not to accept this patch? This patch is mostly using preprocessor directives, 
making a very little alteration for the existing code paths and mainly adding 
support for an additional/new/trendy framework.

PLEASE note that this is an open source community which is showing interest 
here.. A beta release for .NET Core support would be a good gesture from Apache 
to it's consumers. If something breaks in beta, community members will send 
patches to help themselves (DIY model of OSS). If this is still NOT going to 
happen for some subtle reasons, please do tell and close the PR, so we know the 
maintainers' stance.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419846#comment-15419846
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r74683879
  
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter : 
LiteralPatternConverter, IOption
/// 
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+   if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS", 
CompareOptions.IgnoreCase) == 0)
+   {
+   Option = "\r\n";
+   }
+   else if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX", 
CompareOptions.IgnoreCase) == 0)
--- End diff --

@chlowell, do you think it's a good idea to instead of dogfooding 
`string.Compare(strA, strB, InvariantCulture) == 0` pattern with `CultureInfo` 
comparer, use common denominator `strA.ToUpperInvariant() == 
strB.ToUpperInvariant()` and remove the preprocessor all over the place as part 
of this PR? IMO, this will clean up quite a bit. If you want, I can send a PR 
to your `log4net-core-pcl` branch, then you would just need to update the JIRA 
patch. :)


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404695#comment-15404695
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r73228215
  
--- Diff: netstandard/log4net/project.json ---
@@ -0,0 +1,94 @@
+{
+  "name": "log4net",
+  "version": "3.0.0",
+  "frameworks": {
+"netstandard1.3": {
+  "buildOptions": {
+"compile": {
+  "include": [ "*.cs", "../../src/**/*.cs" ],
+  "exclude": [
+"../../src/Appender/AdoNetAppender.cs",
+"../../src/Appender/AspNetTraceAppender.cs",
+"../../src/Appender/ColoredConsoleAppender.cs",
+"../../src/Appender/EventLogAppender.cs",
+"../../src/Appender/NetSendAppender.cs",
+"../../src/Appender/RemotingAppender.cs",
+"../../src/Appender/SmtpAppender.cs",
+"../../src/LogicalThreadContext.cs",
+"../../src/Config/DOMConfigurator.cs",
+"../../src/Config/DOMConfiguratorAttribute.cs",
+"../../src/Config/Log4NetConfigurationSectionHandler.cs",
+"../../src/Layout/Pattern/AspNetCachePatternConverter.cs",
+"../../src/Layout/Pattern/AspNetContextPatternConverter.cs",
+"../../src/Layout/Pattern/AspNetPatternConverter.cs",
+"../../src/Layout/Pattern/AspNetRequestPatternConverter.cs",
+"../../src/Layout/Pattern/AspNetSessionPatternConverter.cs",
+"../../src/Layout/Pattern/StackTraceDetailPatternConverter.cs",
+"../../src/Layout/Pattern/StackTracePatternConverter.cs",
+"../../src/Plugin/RemoteLoggingServerPlugin.cs",
+
"../../src/Util/PatternStringConverters/EnvironmentFolderPathPatternConverter.cs",
+"../../src/Util/LogicalThreadContextProperties.cs",
+"../../src/Util/LogicalThreadContextStacks.cs",
+"../../src/Util/NativeError.cs",
+"../../src/Util/WindowsSecurityContext.cs"
+  ]
+},
+"define": [ "HAS_READERWRITERLOCKSLIM", "NETSTANDARD1_3" ]
--- End diff --

`NETSTANDARD1_3` definition is redundant here.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375230#comment-15375230
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user chlowell commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r70652017
  
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo 
info, StreamingContext conte
string entryKey = entry.Key as string;
object entryValue = entry.Value;
 
-   // If value is serializable then we add it to 
the list
-   if (entryKey != null && entryValue != null && 
entryValue.GetType().IsSerializable)
+// If value is serializable then we add it to the list
+#if NETSTANDARD1_3
+   bool isSerializable = 
entryValue.GetType().GetTypeInfo().IsSerializable;
+#else
+bool isSerializable = entryValue.GetType().IsSerializable;
+#endif
+if (entryKey != null && entryValue != null && 
isSerializable)
{
--- End diff --

The original code mixes tabs and spaces freely. I tried to remain 
consistent with that to limit whitespace noise in the diff. I'll normalize the 
lines you've called out; thanks for the attention to detail.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375066#comment-15375066
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on the issue:

https://github.com/apache/log4net/pull/16
  
> @arkadiuszwojcik the goal of this PR is to make log4net portable across 
.NET Core platforms. Implementing those abstractions could be useful, but doing 
so wouldn't enable consuming log4net on additional platforms.

I agree and I think that can be a separate repo / package, something like 
log4net.Extensions.Logging. However, having this Extensions package first hand 
from original vendor (Apache) is vital on multiple accounts.

---

Separately, can this PR get some prio love from the reviews please? All the 
providers listed here: https://github.com/aspnet/Logging#providers, are not as 
popular as log4net and we (folks running stuff on dotnet core) hoping to get 
our hands on apache/log4net bits.

@chlowell, could you please prepare a SVN patch for the reviewers? We can 
always have subsequent PRs to refine stuff. If you are aiming to add CI setup 
for .NET Core TxM as part of this PR, feel free to grab Travis/AppVeyor bits 
from https://github.com/autofac/Autofac.Extras.Moq/pull/6/files.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375022#comment-15375022
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user stuartd commented on the issue:

https://github.com/apache/log4net/pull/16
  

[ToUpperInvariant](http://stackoverflow.com/questions/2801508/what-is-wrong-with-tolowerinvariant)
 is preferable



> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374973#comment-15374973
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user niemyjski commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r70623307
  
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter : 
LiteralPatternConverter, IOption
/// 
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+   if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS", 
CompareOptions.IgnoreCase) == 0)
+   {
+   Option = "\r\n";
+   }
+   else if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX", 
CompareOptions.IgnoreCase) == 0)
--- End diff --

ToLowerInvariant()


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374800#comment-15374800
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r70601430
  
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter : 
LiteralPatternConverter, IOption
/// 
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+   if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS", 
CompareOptions.IgnoreCase) == 0)
+   {
+   Option = "\r\n";
+   }
+   else if 
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX", 
CompareOptions.IgnoreCase) == 0)
--- End diff --

Should we just ToLower(), compare with `==` and get rid of the 
preprocessors for all Compare()-like code?


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374796#comment-15374796
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r70601024
  
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo 
info, StreamingContext conte
string entryKey = entry.Key as string;
object entryValue = entry.Value;
 
-   // If value is serializable then we add it to 
the list
-   if (entryKey != null && entryValue != null && 
entryValue.GetType().IsSerializable)
+// If value is serializable then we add it to the list
+#if NETSTANDARD1_3
+   bool isSerializable = 
entryValue.GetType().GetTypeInfo().IsSerializable;
+#else
+bool isSerializable = entryValue.GetType().IsSerializable;
+#endif
+if (entryKey != null && entryValue != null && 
isSerializable)
{
--- End diff --

nit: indentation under `#if` `#else` and that of `if (entryKey` is off


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374790#comment-15374790
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user jasonwilliams200OK commented on a diff in the pull request:

https://github.com/apache/log4net/pull/16#discussion_r70600774
  
--- Diff: tests/src/Utils.cs ---
@@ -105,7 +114,28 @@ private static Type[] GetTypesArray(object[] args)
 internal static void RemovePropertyFromAllContexts() {
 GlobalContext.Properties.Remove(PROPERTY_KEY);
 ThreadContext.Properties.Remove(PROPERTY_KEY);
+#if !(NETCF || NETSTANDARD1_3)
 LogicalThreadContext.Properties.Remove(PROPERTY_KEY);
+#endif
 }
-   }
+
+// Wrappers because repository/logger retrieval APIs require an 
Assembly argument on NETSTANDARD1_3
+internal static ILog GetLogger(string name)
+{
+#if NETSTANDARD1_3
+return 
LogManager.GetLogger(typeof(Utils).GetTypeInfo().Assembly, name);
+#else
+   return LogManager.GetLogger(name);
+#endif
--- End diff --

nit: indentation of either one of two return statements is off


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373695#comment-15373695
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user chlowell commented on the issue:

https://github.com/apache/log4net/pull/16
  
I updated this branch for .NET Core 1.0 rather than creating a new PR. The 
branch name is unfortunate--there's no longer a PCL involved--but I hope 
keeping this open is convenient for those watching.

@arkadiuszwojcik the goal of this PR is to make log4net portable across 
.NET Core platforms. Implementing those abstractions could be useful, but doing 
so wouldn't enable consuming log4net on additional platforms.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370912#comment-15370912
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user arkadiuszwojcik commented on the issue:

https://github.com/apache/log4net/pull/16
  
I suggest all of you switch to:

https://www.nuget.org/packages/Microsoft.Extensions.Logging.Abstractions/

and create log4net port for that. Actually it is quite easy to create it on 
your own.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352426#comment-15352426
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user pantonis commented on the issue:

https://github.com/apache/log4net/pull/16
  
+1


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314862#comment-15314862
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user niemyjski commented on the issue:

https://github.com/apache/log4net/pull/16
  
+1 I'm also needing this for our oss projects that depend on log4net. Would 
be great to get this on the lowest .net standard possible.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310919#comment-15310919
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the issue:

https://github.com/apache/log4net/pull/16
  
so far there haven't been any concrete plans beyond this PR


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309257#comment-15309257
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user StrangeWill commented on the pull request:

https://github.com/apache/log4net/pull/16
  
@bodewig _Hopefully_ there shouldn't be much flux between RC2 and Final 
(well at least we were told porting from RC2 -> Final won't be nearly as bad as 
RC1 -> RC2 was, and it wasn't *that* bad), though I am struggling myself with 
System.Diagnostics.Stacktrace being gutted on one of my own projects. I can 
totally understand the hesitation though especially with a project like this.

I'll be keeping my eye out for support for .NET Core on log4net, I'm just 
not nearly as happy with any of the other solutions.

---

The other interesting question is whether or not log4net on .NET Core is 
going to support the new json configuration files or still require XML files 
out of the box.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304343#comment-15304343
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user chlowell commented on the pull request:

https://github.com/apache/log4net/pull/16#issuecomment-222199688
  
I have another branch on my fork (`dotnetcore-rc2`) which builds with RC2 
tools, and has some improvements over the code here. A few tests are broken due 
to executing with NUnitLite. Once the NUnit runner is updated for RC2 
(nunit/nunit#1371), I'll open a new PR.


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303822#comment-15303822
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user chester89 commented on the pull request:

https://github.com/apache/log4net/pull/16#issuecomment-222102483
  
@chlowell any updates on this?


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[Charles Lowell (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051840#comment-15051840
 ] 

Charles Lowell commented on LOG4NET-467:


I think you're correct that the code lives in SVN and changes are always merged 
via patches, even when they originate on GitHub. I can provide a patch here in 
addition to the pull request, if that would be a convenient format for 
reviewing the changes.

> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052175#comment-15052175
 ] 

ASF GitHub Bot commented on LOG4NET-467:


Github user bodewig commented on the pull request:

https://github.com/apache/log4net/pull/16#issuecomment-163839682
  
referenced in LOG4NET-467 https://issues.apache.org/jira/browse/LOG4NET-467


> Is .NET Core, will be supported in the near future, or not
> --
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.2.13
>Reporter: san kan
>  Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LOG4NET-467) Is .NET Core, will be supported in the near future, or not

[Dominik Psenner (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623993#comment-14623993
 ] 

Dominik Psenner commented on LOG4NET-467:
-

It is probably too early to comment or even decide what work will have to be 
done on log4net when dotnet core gets released. It might be possible that 
log4net is already compatible because, in a nutshell, dotnet core packs 
everything platform specific into separate libraries that are referened, 
fetched and included locally on demand. All the rest mostly stays the same. But 
that might be just me oversimplifying things.

Nevertheless: If you require log4net to work together with dotnet core, you 
should start to work on it for yourselve and share the results! It would be 
impudent to let others do your work. As you know most of us do this in our 
sparetime and everyone has its own priority queue. On mine there is no dotnet 
core, yet. :-)

As for the other question, Log4net does its job and when it doesnt it gets its 
attention. Major releases are neither planned, nor required at the moment. It 
has its position in the apache logging family and there is no reason why this 
should change in the near future.

Hth, d.

 Is .NET Core, will be supported in the near future, or not
 --

 Key: LOG4NET-467
 URL: https://issues.apache.org/jira/browse/LOG4NET-467
 Project: Log4net
  Issue Type: New Feature
  Components: Core
Affects Versions: 1.2.13
Reporter: san kan
  Labels: features

 As you know, ms is moving heavily toward .Net core:
 https://github.com/dotnet/core
 so, is there a road map for making a version that supports it?
 and i noticed that log4net, has not been updated for 2 years.
 so is it maintained, or being forgotten?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)