Re: Update of port ehcache to version 3.8.1

[SAPTARSHI MUKHERJEE]

Hi,

Having made the changes as per suggestions, I'd like to draw your kindest
attention to my PR and request you for reviewing the same. Link to the PR:
https://github.com/macports/macports-ports/pull/6784.

With Warmest Regards,
Yours Sincerely,
*Saptarshi Mukherjee,*
*A GSoC 2020 Aspirant.*


On Tue, Apr 7, 2020 at 3:40 PM SAPTARSHI MUKHERJEE <
saptars...@iitbhilai.ac.in> wrote:

> Thank you Sir. I'll keep them in mind.
>
> With Warmest Regards,
> Yours Sincerely,
> *Saptarshi Mukherjee,*
> *A GSoC 2020 Aspirant.*
>
>
> On Tue, Apr 7, 2020 at 2:39 PM Mojca Miklavec <
> mojca.miklavec.li...@gmail.com> wrote:
>
>> On Tue, 7 Apr 2020 at 06:23, SAPTARSHI MUKHERJEE wrote:
>> >
>> > May kindly validate the final commit, so that I may rebase the commits
>> with the right message and you may merge the same.
>>
>> Why do you wait to get approval before fixing "a known issue"?
>> GitHub offers an "Approve" button that developers may click without
>> leaving any further feedback, but this one cannot be clicked before
>> the contribution is ready to be merged; it's worse, one could have
>> clicked "Request changes" and then you'll be stuck with a red cross
>> until that same person checks again.
>>
>> > P.S.: If I'm undesirably spamming all of you, I'm sincerely apologetic
>> about it. May please let me know if I should mail these to some specific
>> recipients instead of the mailing list.
>>
>> I would advise against mailing individual recipients unless it's
>> really off-topic and you know whom to contact or when someone might
>> have missed the email in the sea of other messages from the mailing
>> list.
>>
>> Generally the communication for such issues would be kept on the
>> GitHub inside a code review, but asking the mailing list for attention
>> if you get stuck somewhere, or if nobody has responded for a couple
>> days.
>>
>> At these circumstances when we asked you for contributions it's
>> probably ideal to send one email when you have opened a new PR to
>> avoid a too long delay in response. When people have provided feedback
>> to you, they will likely get a notification when you change something
>> almost immediately, and there's certainly no need to send multiple
>> reminders per day with requests to check your changes.
>>
>> If you are bored while waiting for a response, start working on a
>> different ticket :)
>>
>> Mojca
>>
>

Re: Update of port ehcache to version 3.8.1

[SAPTARSHI MUKHERJEE]

Thank you Sir. I'll keep them in mind.

With Warmest Regards,
Yours Sincerely,
*Saptarshi Mukherjee,*
*A GSoC 2020 Aspirant.*


On Tue, Apr 7, 2020 at 2:39 PM Mojca Miklavec <
mojca.miklavec.li...@gmail.com> wrote:

> On Tue, 7 Apr 2020 at 06:23, SAPTARSHI MUKHERJEE wrote:
> >
> > May kindly validate the final commit, so that I may rebase the commits
> with the right message and you may merge the same.
>
> Why do you wait to get approval before fixing "a known issue"?
> GitHub offers an "Approve" button that developers may click without
> leaving any further feedback, but this one cannot be clicked before
> the contribution is ready to be merged; it's worse, one could have
> clicked "Request changes" and then you'll be stuck with a red cross
> until that same person checks again.
>
> > P.S.: If I'm undesirably spamming all of you, I'm sincerely apologetic
> about it. May please let me know if I should mail these to some specific
> recipients instead of the mailing list.
>
> I would advise against mailing individual recipients unless it's
> really off-topic and you know whom to contact or when someone might
> have missed the email in the sea of other messages from the mailing
> list.
>
> Generally the communication for such issues would be kept on the
> GitHub inside a code review, but asking the mailing list for attention
> if you get stuck somewhere, or if nobody has responded for a couple
> days.
>
> At these circumstances when we asked you for contributions it's
> probably ideal to send one email when you have opened a new PR to
> avoid a too long delay in response. When people have provided feedback
> to you, they will likely get a notification when you change something
> almost immediately, and there's certainly no need to send multiple
> reminders per day with requests to check your changes.
>
> If you are bored while waiting for a response, start working on a
> different ticket :)
>
> Mojca
>

Re: Update of port ehcache to version 3.8.1

[SAPTARSHI MUKHERJEE]

Hi,

In view of some valuable suggestions concerning the alignment, I've updated
the PR concerning update of port ehcache. I've corrected the spacing and
alignment with appropriate whitespaces. The original portfile had tabs, and
that misguided me to continue with the same.

May kindly validate the final commit, so that I may rebase the commits with
the right message and you may merge the same. Any
suggestions/recommendations are again thoroughly welcome and appreciated.
Link to the file: https://github.com/macports/macports-ports/pull/6784/files
.

P.S.: If I'm undesirably spamming all of you, I'm sincerely apologetic
about it. May please let me know if I should mail these to some specific
recipients instead of the mailing list.

Thanks and Regards,
Yours Sincerely,
*Saptarshi Mukherjee,*
*A GSoC 2020 Aspirant.*


On Mon, Apr 6, 2020 at 9:43 PM SAPTARSHI MUKHERJEE <
saptars...@iitbhilai.ac.in> wrote:

> Hi,
>
> Warmest thanks again to Ryan Sir and Jackson Sir for their valuable
> suggestions. The current PR seems to have met the requirements
> appropriately. The pinpointed guidance by Ryan Sir was surely instrumental
> in improving my understanding of many aspects of the ports' functioning.
>
> May please review my PR and provide necessary feedback, and if found
> alright, may please merge the same. I'll indeed be quite glad about it. The
> link to the PR is
> https://github.com/macports/macports-ports/pull/6784/commits. I've
> rebased the commits for a better view.
>
> Thanks and Regards,
> Yours Sincerely,
> *Saptarshi Mukherjee,*
> *A GSoC 2020 Aspirant**.*
>
>
> On Mon, Apr 6, 2020 at 12:13 PM SAPTARSHI MUKHERJEE <
> saptars...@iitbhilai.ac.in> wrote:
>
>> Hi,
>>
>> Thanks to Ryan Sir and Jackson Sir for the suggestions. I tried to
>> incorporate the "github.setup", but it seems it is wrongly searching for
>> the file "ehcache3-3.8.1.jar" instead of "ehcache-3.8.1.jar", and hence
>> failing to fetch the distfile. I tried correcting it using "name" set to
>> ehcache, but it doesn't help. Following is the link to the log file: Link
>> . The link to the PR is
>> https://github.com/macports/macports-ports/pull/6784/commits. Any
>> directions for correcting the error is highly appreciated. Thanks in
>> advance.
>>
>> With Warmest Regards,
>> Yours Sincerely,
>> *Saptarshi Mukherjee,*
>> *A GSoC 2020 Aspirant.*
>>
>>
>> On Sun, Apr 5, 2020 at 4:27 PM SAPTARSHI MUKHERJEE <
>> saptars...@iitbhilai.ac.in> wrote:
>>
>>> Hi Sir,
>>>
>>> Thanks again for the opportunity. I've made a final PR for the update of
>>> port 3.8.1 that has successfully passed the checks. Following is the link
>>> to the PR: https://github.com/macports/macports-ports/pull/6784/files.
>>>
>>> I'd hereby sincerely thank Ryan Sir for his assistance that has not only
>>> played a crucial role in enabling me in completing this, but has also
>>> improved my understanding of some parts of the codebase immensely.
>>>
>>> I've rebased the commits. May kindly review the same and provide
>>> necessary feedback. If it seems right, may kindly merge the same. Thanks
>>> again.
>>>
>>> With Warmest Regards,
>>> Yours Sincerely,
>>> *Saptarshi Mukherjee,*
>>> *A GSoC 2020 Aspirant.*
>>>
>>

Re: Update of port ehcache to version 3.8.1

[SAPTARSHI MUKHERJEE]

Hi,

Warmest thanks again to Ryan Sir and Jackson Sir for their valuable
suggestions. The current PR seems to have met the requirements
appropriately. The pinpointed guidance by Ryan Sir was surely instrumental
in improving my understanding of many aspects of the ports' functioning.

May please review my PR and provide necessary feedback, and if found
alright, may please merge the same. I'll indeed be quite glad about it. The
link to the PR is
https://github.com/macports/macports-ports/pull/6784/commits. I've rebased
the commits for a better view.

Thanks and Regards,
Yours Sincerely,
*Saptarshi Mukherjee,*
*A GSoC 2020 Aspirant**.*


On Mon, Apr 6, 2020 at 12:13 PM SAPTARSHI MUKHERJEE <
saptars...@iitbhilai.ac.in> wrote:

> Hi,
>
> Thanks to Ryan Sir and Jackson Sir for the suggestions. I tried to
> incorporate the "github.setup", but it seems it is wrongly searching for
> the file "ehcache3-3.8.1.jar" instead of "ehcache-3.8.1.jar", and hence
> failing to fetch the distfile. I tried correcting it using "name" set to
> ehcache, but it doesn't help. Following is the link to the log file: Link
> . The link to the PR is
> https://github.com/macports/macports-ports/pull/6784/commits. Any
> directions for correcting the error is highly appreciated. Thanks in
> advance.
>
> With Warmest Regards,
> Yours Sincerely,
> *Saptarshi Mukherjee,*
> *A GSoC 2020 Aspirant.*
>
>
> On Sun, Apr 5, 2020 at 4:27 PM SAPTARSHI MUKHERJEE <
> saptars...@iitbhilai.ac.in> wrote:
>
>> Hi Sir,
>>
>> Thanks again for the opportunity. I've made a final PR for the update of
>> port 3.8.1 that has successfully passed the checks. Following is the link
>> to the PR: https://github.com/macports/macports-ports/pull/6784/files.
>>
>> I'd hereby sincerely thank Ryan Sir for his assistance that has not only
>> played a crucial role in enabling me in completing this, but has also
>> improved my understanding of some parts of the codebase immensely.
>>
>> I've rebased the commits. May kindly review the same and provide
>> necessary feedback. If it seems right, may kindly merge the same. Thanks
>> again.
>>
>> With Warmest Regards,
>> Yours Sincerely,
>> *Saptarshi Mukherjee,*
>> *A GSoC 2020 Aspirant.*
>>
>

Re: Update of port ehcache to version 3.8.1

[SAPTARSHI MUKHERJEE]

Hi,

Thanks to Ryan Sir and Jackson Sir for the suggestions. I tried to
incorporate the "github.setup", but it seems it is wrongly searching for
the file "ehcache3-3.8.1.jar" instead of "ehcache-3.8.1.jar", and hence
failing to fetch the distfile. I tried correcting it using "name" set to
ehcache, but it doesn't help. Following is the link to the log file: Link
. The link to the PR is
https://github.com/macports/macports-ports/pull/6784/commits. Any
directions for correcting the error is highly appreciated. Thanks in
advance.

With Warmest Regards,
Yours Sincerely,
*Saptarshi Mukherjee,*
*A GSoC 2020 Aspirant.*


On Sun, Apr 5, 2020 at 4:27 PM SAPTARSHI MUKHERJEE <
saptars...@iitbhilai.ac.in> wrote:

> Hi Sir,
>
> Thanks again for the opportunity. I've made a final PR for the update of
> port 3.8.1 that has successfully passed the checks. Following is the link
> to the PR: https://github.com/macports/macports-ports/pull/6784/files.
>
> I'd hereby sincerely thank Ryan Sir for his assistance that has not only
> played a crucial role in enabling me in completing this, but has also
> improved my understanding of some parts of the codebase immensely.
>
> I've rebased the commits. May kindly review the same and provide necessary
> feedback. If it seems right, may kindly merge the same. Thanks again.
>
> With Warmest Regards,
> Yours Sincerely,
> *Saptarshi Mukherjee,*
> *A GSoC 2020 Aspirant.*
>